[ 
https://issues.apache.org/jira/browse/MXNET-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389194#comment-16389194
 ] 

ASF GitHub Bot commented on MXNET-36:
-------------------------------------

rahul003 commented on a change in pull request #9029: [MXNET-36] Update ndarray 
binary ops to use kernel launch instead of mshadow operations
URL: https://github.com/apache/incubator-mxnet/pull/9029#discussion_r172760891
 
 

 ##########
 File path: src/ndarray/ndarray_function-inl.h
 ##########
 @@ -446,6 +468,11 @@ DECL_SCALAR(DEVICE, Minus, EvalScalar_, true)
 DECL_SCALAR(DEVICE, Mul, EvalScalar_, true)
 DECL_SCALAR(DEVICE, Div, EvalScalar_, true)
 
+DECL_BINARY_LAUNCH(DEVICE, Plus)
 
 Review comment:
   Removed the earlier ones, thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update ndarray binary ops to use kernel launch interface
> --------------------------------------------------------
>
>                 Key: MXNET-36
>                 URL: https://issues.apache.org/jira/browse/MXNET-36
>             Project: Apache MXNet
>          Issue Type: New Feature
>            Reporter: Rahul Huilgol
>            Assignee: Chris Olivier
>            Priority: Major
>
> Replace older deprecated mshadow style binary operations with faster kernel 
> launch interface.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org

Reply via email to