[jira] [Updated] (NIFI-2902) S3 Processor Signer Override for v4 Throws Exception
[
https://issues.apache.org/jira/browse/NIFI-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Wing updated NIFI-2902:
-
Status: Patch Available (was: Open)
> S3 Processor Signer Override for v4 Throws Exception
>
>
> Key: NIFI-2902
> URL: https://issues.apache.org/jira/browse/NIFI-2902
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: James Wing
>Assignee: James Wing
>Priority: Minor
> Fix For: 1.1.0
>
>
> NIFI-2763 introduced optional signer overrides for S3 processors - default,
> v2, and v4. The signer type for the "Signature v4" is wrong, and throws an
> IllegalArgumentException when the processor attempts to start. The failing
> type is {{AWSS3V4Signer}}. The correct type is {{AWSS3V4SignerType}}.
> The impact is low for now - the feature has not been released, and the
> unconfigured default is v4 in the AWS SDK included with NiFi. The "Signature
> v2" value works OK. But the option does not work as advertised, and should
> be fixed before release.
> {code}
> 2016-10-14 17:46:28,685 ERROR [StandardProcessScheduler Thread-3]
> org.apache.nifi.engine.FlowEngine A flow controller task execution stopped
> abnormally
> java.util.concurrent.ExecutionException:
> java.lang.reflect.InvocationTargetException
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> ~[na:1.8.0_66]
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> ~[na:1.8.0_66]
> at org.apache.nifi.engine.FlowEngine.afterExecute(FlowEngine.java:100)
> ~[na:na]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1150)
> [na:1.8.0_66]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_66]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_66]
> Caused by: java.lang.reflect.InvocationTargetException: null
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[na:1.8.0_66]
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[na:1.8.0_66]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[na:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_66]
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:137)
> ~[na:na]
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:125)
> ~[na:na]
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:70)
> ~[na:na]
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:47)
> ~[na:na]
> at
> org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1244)
> ~[na:na]
> at
> org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1240)
> ~[na:na]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_66]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
> ~[na:1.8.0_66]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> ~[na:1.8.0_66]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_66]
> ... 2 common frames omitted
> Caused by: java.lang.IllegalArgumentException: unknown signer type:
> AWSS3V4Signer
> at
> com.amazonaws.auth.SignerFactory.createSigner(SignerFactory.java:118) ~[na:na]
> at
> com.amazonaws.auth.SignerFactory.getSignerByTypeAndService(SignerFactory.java:95)
> ~[na:na]
> at
> com.amazonaws.AmazonWebServiceClient.computeSignerByServiceRegion(AmazonWebServiceClient.java:262)
> ~[na:na]
> at
> com.amazonaws.AmazonWebServiceClient.computeSignerByURI(AmazonWebServiceClient.java:235)
> ~[na:na]
> at
> com.amazonaws.AmazonWebServiceClient.setEndpoint(AmazonWebServiceClient.java:186)
> ~[na:na]
> at
> com.amazonaws.services.s3.AmazonS3Client.setEndpoint(AmazonS3Client.java:463)
> ~[na:na]
> at
> com.amazonaws.services.s3.AmazonS3Client.init(AmazonS3Client.java:449)
> ~[na:na]
> at
> com.amazonaws.services.s3.AmazonS3Client.(AmazonS3Client.java:396)
> ~[na:na]
> at
> com.amazonaws.services.s3.AmazonS3Client.(AmazonS3Client.java:373)
> ~[na:na]
> at
> com.amazonaws.services.s3.AmazonS3Client.(AmazonS3Client.java:355)
> ~[na:na]
> at
> org.apache.nifi.processors.aws.s3.AbstractS3Processor.createClient(AbstractS3Processor.java:137)
> ~[na:na]
> at
> org.apache.nifi
[jira] [Updated] (NIFI-2902) S3 Processor Signer Override for v4 Throws Exception
[
https://issues.apache.org/jira/browse/NIFI-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Wing updated NIFI-2902:
-
Assignee: (was: James Wing)
> S3 Processor Signer Override for v4 Throws Exception
>
>
> Key: NIFI-2902
> URL: https://issues.apache.org/jira/browse/NIFI-2902
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: James Wing
>Priority: Minor
> Fix For: 1.1.0
>
>
> NIFI-2763 introduced optional signer overrides for S3 processors - default,
> v2, and v4. The signer type for the "Signature v4" is wrong, and throws an
> IllegalArgumentException when the processor attempts to start. The failing
> type is {{AWSS3V4Signer}}. The correct type is {{AWSS3V4SignerType}}.
> The impact is low for now - the feature has not been released, and the
> unconfigured default is v4 in the AWS SDK included with NiFi. The "Signature
> v2" value works OK. But the option does not work as advertised, and should
> be fixed before release.
> {code}
> 2016-10-14 17:46:28,685 ERROR [StandardProcessScheduler Thread-3]
> org.apache.nifi.engine.FlowEngine A flow controller task execution stopped
> abnormally
> java.util.concurrent.ExecutionException:
> java.lang.reflect.InvocationTargetException
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> ~[na:1.8.0_66]
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> ~[na:1.8.0_66]
> at org.apache.nifi.engine.FlowEngine.afterExecute(FlowEngine.java:100)
> ~[na:na]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1150)
> [na:1.8.0_66]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_66]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_66]
> Caused by: java.lang.reflect.InvocationTargetException: null
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[na:1.8.0_66]
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[na:1.8.0_66]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[na:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_66]
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:137)
> ~[na:na]
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:125)
> ~[na:na]
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:70)
> ~[na:na]
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:47)
> ~[na:na]
> at
> org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1244)
> ~[na:na]
> at
> org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1240)
> ~[na:na]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_66]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
> ~[na:1.8.0_66]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> ~[na:1.8.0_66]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_66]
> ... 2 common frames omitted
> Caused by: java.lang.IllegalArgumentException: unknown signer type:
> AWSS3V4Signer
> at
> com.amazonaws.auth.SignerFactory.createSigner(SignerFactory.java:118) ~[na:na]
> at
> com.amazonaws.auth.SignerFactory.getSignerByTypeAndService(SignerFactory.java:95)
> ~[na:na]
> at
> com.amazonaws.AmazonWebServiceClient.computeSignerByServiceRegion(AmazonWebServiceClient.java:262)
> ~[na:na]
> at
> com.amazonaws.AmazonWebServiceClient.computeSignerByURI(AmazonWebServiceClient.java:235)
> ~[na:na]
> at
> com.amazonaws.AmazonWebServiceClient.setEndpoint(AmazonWebServiceClient.java:186)
> ~[na:na]
> at
> com.amazonaws.services.s3.AmazonS3Client.setEndpoint(AmazonS3Client.java:463)
> ~[na:na]
> at
> com.amazonaws.services.s3.AmazonS3Client.init(AmazonS3Client.java:449)
> ~[na:na]
> at
> com.amazonaws.services.s3.AmazonS3Client.(AmazonS3Client.java:396)
> ~[na:na]
> at
> com.amazonaws.services.s3.AmazonS3Client.(AmazonS3Client.java:373)
> ~[na:na]
> at
> com.amazonaws.services.s3.AmazonS3Client.(AmazonS3Client.java:355)
> ~[na:na]
> at
> org.apache.nifi.processors.aws.s3.AbstractS3Processor.createClient(AbstractS3Processor.java:137)
> ~[na:na]
> at
> org.apache.nifi.processors.aws.s3.AbstractS3Processor.
[jira] [Commented] (NIFI-2902) S3 Processor Signer Override for v4 Throws Exception
[
https://issues.apache.org/jira/browse/NIFI-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578897#comment-15578897
]
ASF GitHub Bot commented on NIFI-2902:
--
GitHub user jvwing opened a pull request:
https://github.com/apache/nifi/pull/1140
NIFI-2902 Fix for S3 Signer v4 Override
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jvwing/nifi NIFI-2902-s3-signer-v4-fix-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1140
commit cbe9595be44be6613142fba0242184536c7795ac
Author: James Wing
Date: 2016-10-15T19:49:15Z
NIFI-2902 Fix for S3 Signer v4 Override
> S3 Processor Signer Override for v4 Throws Exception
>
>
> Key: NIFI-2902
> URL: https://issues.apache.org/jira/browse/NIFI-2902
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: James Wing
>Assignee: James Wing
>Priority: Minor
> Fix For: 1.1.0
>
>
> NIFI-2763 introduced optional signer overrides for S3 processors - default,
> v2, and v4. The signer type for the "Signature v4" is wrong, and throws an
> IllegalArgumentException when the processor attempts to start. The failing
> type is {{AWSS3V4Signer}}. The correct type is {{AWSS3V4SignerType}}.
> The impact is low for now - the feature has not been released, and the
> unconfigured default is v4 in the AWS SDK included with NiFi. The "Signature
> v2" value works OK. But the option does not work as advertised, and should
> be fixed before release.
> {code}
> 2016-10-14 17:46:28,685 ERROR [StandardProcessScheduler Thread-3]
> org.apache.nifi.engine.FlowEngine A flow controller task execution stopped
> abnormally
> java.util.concurrent.ExecutionException:
> java.lang.reflect.InvocationTargetException
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> ~[na:1.8.0_66]
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> ~[na:1.8.0_66]
> at org.apache.nifi.engine.FlowEngine.afterExecute(FlowEngine.java:100)
> ~[na:na]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1150)
> [na:1.8.0_66]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_66]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_66]
> Caused by: java.lang.reflect.InvocationTargetException: null
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[na:1.8.0_66]
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> ~[na:1.8.0_66]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[na:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.j
[GitHub] nifi pull request #1140: NIFI-2902 Fix for S3 Signer v4 Override
GitHub user jvwing opened a pull request: https://github.com/apache/nifi/pull/1140 NIFI-2902 Fix for S3 Signer v4 Override Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [X] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jvwing/nifi NIFI-2902-s3-signer-v4-fix-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1140.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1140 commit cbe9595be44be6613142fba0242184536c7795ac Author: James Wing Date: 2016-10-15T19:49:15Z NIFI-2902 Fix for S3 Signer v4 Override --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (NIFI-2902) S3 Processor Signer Override for v4 Throws Exception
James Wing created NIFI-2902:
Summary: S3 Processor Signer Override for v4 Throws Exception
Key: NIFI-2902
URL: https://issues.apache.org/jira/browse/NIFI-2902
Project: Apache NiFi
Issue Type: Bug
Affects Versions: 1.1.0
Reporter: James Wing
Assignee: James Wing
Priority: Minor
Fix For: 1.1.0
NIFI-2763 introduced optional signer overrides for S3 processors - default, v2,
and v4. The signer type for the "Signature v4" is wrong, and throws an
IllegalArgumentException when the processor attempts to start. The failing
type is {{AWSS3V4Signer}}. The correct type is {{AWSS3V4SignerType}}.
The impact is low for now - the feature has not been released, and the
unconfigured default is v4 in the AWS SDK included with NiFi. The "Signature
v2" value works OK. But the option does not work as advertised, and should be
fixed before release.
{code}
2016-10-14 17:46:28,685 ERROR [StandardProcessScheduler Thread-3]
org.apache.nifi.engine.FlowEngine A flow controller task execution stopped
abnormally
java.util.concurrent.ExecutionException:
java.lang.reflect.InvocationTargetException
at java.util.concurrent.FutureTask.report(FutureTask.java:122)
~[na:1.8.0_66]
at java.util.concurrent.FutureTask.get(FutureTask.java:192)
~[na:1.8.0_66]
at org.apache.nifi.engine.FlowEngine.afterExecute(FlowEngine.java:100)
~[na:na]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1150)
[na:1.8.0_66]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[na:1.8.0_66]
at java.lang.Thread.run(Thread.java:745) [na:1.8.0_66]
Caused by: java.lang.reflect.InvocationTargetException: null
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[na:1.8.0_66]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[na:1.8.0_66]
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[na:1.8.0_66]
at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_66]
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:137)
~[na:na]
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:125)
~[na:na]
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:70)
~[na:na]
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:47)
~[na:na]
at
org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1244)
~[na:na]
at
org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1240)
~[na:na]
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
~[na:1.8.0_66]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
~[na:1.8.0_66]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
~[na:1.8.0_66]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[na:1.8.0_66]
... 2 common frames omitted
Caused by: java.lang.IllegalArgumentException: unknown signer type:
AWSS3V4Signer
at
com.amazonaws.auth.SignerFactory.createSigner(SignerFactory.java:118) ~[na:na]
at
com.amazonaws.auth.SignerFactory.getSignerByTypeAndService(SignerFactory.java:95)
~[na:na]
at
com.amazonaws.AmazonWebServiceClient.computeSignerByServiceRegion(AmazonWebServiceClient.java:262)
~[na:na]
at
com.amazonaws.AmazonWebServiceClient.computeSignerByURI(AmazonWebServiceClient.java:235)
~[na:na]
at
com.amazonaws.AmazonWebServiceClient.setEndpoint(AmazonWebServiceClient.java:186)
~[na:na]
at
com.amazonaws.services.s3.AmazonS3Client.setEndpoint(AmazonS3Client.java:463)
~[na:na]
at
com.amazonaws.services.s3.AmazonS3Client.init(AmazonS3Client.java:449) ~[na:na]
at
com.amazonaws.services.s3.AmazonS3Client.(AmazonS3Client.java:396)
~[na:na]
at
com.amazonaws.services.s3.AmazonS3Client.(AmazonS3Client.java:373)
~[na:na]
at
com.amazonaws.services.s3.AmazonS3Client.(AmazonS3Client.java:355)
~[na:na]
at
org.apache.nifi.processors.aws.s3.AbstractS3Processor.createClient(AbstractS3Processor.java:137)
~[na:na]
at
org.apache.nifi.processors.aws.s3.AbstractS3Processor.createClient(AbstractS3Processor.java:45)
~[na:na]
at
org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor.onScheduledUsingControllerService(AbstractAWSCredentialsProviderProcessor.java:73)
~[na:na]
at
org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor.on
[GitHub] nifi pull request #1001: NIFI-2750
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1001#discussion_r83530556 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java --- @@ -254,6 +264,9 @@ public void onTrigger(final ProcessContext context, final ProcessSession session final boolean failUnmappedColumns = FAIL_UNMATCHED_COLUMN.getValue().equalsIgnoreCase(context.getProperty(UNMATCHED_COLUMN_BEHAVIOR).getValue()); final boolean warningUnmappedColumns = WARNING_UNMATCHED_COLUMN.getValue().equalsIgnoreCase(context.getProperty(UNMATCHED_COLUMN_BEHAVIOR).getValue()); +//Escape column names? +final boolean escapeColumnNames = "true".equalsIgnoreCase(context.getProperty(QUOTED_IDENTIFIERS).getValue()); --- End diff -- nice way of assigning the value! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2750) Add Optional Column Name Quoting to ConvertJSONToSQL
[ https://issues.apache.org/jira/browse/NIFI-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577930#comment-15577930 ] ASF GitHub Bot commented on NIFI-2750: -- Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1001#discussion_r83530556 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java --- @@ -254,6 +264,9 @@ public void onTrigger(final ProcessContext context, final ProcessSession session final boolean failUnmappedColumns = FAIL_UNMATCHED_COLUMN.getValue().equalsIgnoreCase(context.getProperty(UNMATCHED_COLUMN_BEHAVIOR).getValue()); final boolean warningUnmappedColumns = WARNING_UNMATCHED_COLUMN.getValue().equalsIgnoreCase(context.getProperty(UNMATCHED_COLUMN_BEHAVIOR).getValue()); +//Escape column names? +final boolean escapeColumnNames = "true".equalsIgnoreCase(context.getProperty(QUOTED_IDENTIFIERS).getValue()); --- End diff -- nice way of assigning the value! > Add Optional Column Name Quoting to ConvertJSONToSQL > > > Key: NIFI-2750 > URL: https://issues.apache.org/jira/browse/NIFI-2750 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Peter Wicks >Assignee: Peter Wicks >Priority: Minor > > If a column name happens to also be a SQL reserved word then the SQL > generated by ConvertJSONToSQL will be invalid and will fail when it runs. > By getting and quoting column identifiers (optionally) it will allow users to > keep original column names by quoting them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2711) Allow extension of nifi-assembly pom to override properties
[ https://issues.apache.org/jira/browse/NIFI-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577926#comment-15577926 ] ASF GitHub Bot commented on NIFI-2711: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/972 @brosander conflicts again... :cry: > Allow extension of nifi-assembly pom to override properties > --- > > Key: NIFI-2711 > URL: https://issues.apache.org/jira/browse/NIFI-2711 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Rosander > > As part of the tls-toolkit work, the nifi.properties filtering was moved to > nifi-resources. This didn't take into account usecases where overriding the > nifi.properties in an assembly was desired by those extending our assembly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi issue #972: NIFI-2711 - Making top-level nifi-assemblies directory with...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/972 @brosander conflicts again... :cry: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2380) ExtractEmailAttachments processor should support TNEF files (aka winmail.dat)
[ https://issues.apache.org/jira/browse/NIFI-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577922#comment-15577922 ] ASF GitHub Bot commented on NIFI-2380: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @olegz ? > ExtractEmailAttachments processor should support TNEF files (aka winmail.dat) > - > > Key: NIFI-2380 > URL: https://issues.apache.org/jira/browse/NIFI-2380 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.0.0 >Reporter: Andre >Assignee: Andre > Fix For: 1.1.0 > > > during the review of NIFI-1899 Dan Marshall highlighted some use cases for > email processing that have not been addressed as part of the initial > development cycle. > One of these use cases was the decoding of Microsoft Transport Neutral > Encoding Files (TNEF). > This type of attachments is popularly know as winmail.dat and uses a non RFC > compliant structure to transfer attachments across different Microsoft > Outlook clients. > Given the prevalence of outlook and the issues with winmail.dat files, it > would be nice to be able to decode TNEF as we currently do with MIME > attachments. > Permalink to Dan's comments > http://mail-archives.apache.org/mod_mbox/nifi-dev/201607.mbox/%3C1468716836729-12827.post%40n7.nabble.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @olegz ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2685) Builds fails due to "java.awt.AWTError: Can't connect to X11 window server "
[
https://issues.apache.org/jira/browse/NIFI-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577904#comment-15577904
]
ASF GitHub Bot commented on NIFI-2685:
--
Github user trkurc commented on the issue:
https://github.com/apache/nifi/pull/961
+1, please merge in.
> Builds fails due to "java.awt.AWTError: Can't connect to X11 window server "
>
>
> Key: NIFI-2685
> URL: https://issues.apache.org/jira/browse/NIFI-2685
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Andre
>Assignee: Andre
>Priority: Trivial
>
> When building NiFi on a machine with ssh X11 forwarding enabled, maven may
> fail to build due to the following error:
> {code}
> testResize(org.apache.nifi.processors.image.TestResizeImage) Time elapsed:
> 2.22 sec <<< FAILURE!
> java.lang.AssertionError: java.awt.AWTError: Can't connect to X11 window
> server using 'localhost:12.0' as the value of the DISPLAY variable.
> at
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:192)
> at
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:151)
> at
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:146)
> at
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:141)
> at
> org.apache.nifi.util.StandardProcessorTestRunner.run(StandardProcessorTestRunner.java:136)
> at
> org.apache.nifi.processors.image.TestResizeImage.testResize(TestResizeImage.java:44)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] nifi issue #961: NIFI-2685 - Configure surefire to use JAVA Headless mode
Github user trkurc commented on the issue: https://github.com/apache/nifi/pull/961 +1, please merge in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2900) DateTime API Endpoints don't respect RFC 3339
[ https://issues.apache.org/jira/browse/NIFI-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577879#comment-15577879 ] Stephane Maarek commented on NIFI-2900: --- Agreed! Makes sense. Maybe keep this API change in mind for a 2.0 release. I'll look into specifying string instead of date time for swagger in this PR this weekend hopefully On Sat., 15 Oct. 2016, 10:00 pm ASF GitHub Bot (JIRA), > DateTime API Endpoints don't respect RFC 3339 > - > > Key: NIFI-2900 > URL: https://issues.apache.org/jira/browse/NIFI-2900 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Stephane Maarek > > Hi, > the endpoint /flow/process-group/id is supposed to return lastRefreshed as > part of ProcessGroupFlowDTO as a DateTime, as indicated here: > lastRefreshed string (date-time) optionalThe time the flow for > the process group was last refreshed. > as it currently stands, what I am getting doesn't look like a timestamp: > "lastRefreshed":"14:02:46 AEDT" > I'm not sure how much of the overall API is affected > Edit: > Actually, it seems every date a "date-time" is created we expect the format > "HH:mm:ss z". > As per the OpenAPI specs, if a field is annotated "date-time", it should > respect the RFC 3339 convention > (https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#data-types). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (NIFI-2900) DateTime API Endpoints don't respect RFC 3339
[ https://issues.apache.org/jira/browse/NIFI-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577869#comment-15577869 ] ASF GitHub Bot commented on NIFI-2900: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1136 NiFi follows the semantic versioning guidelines. What your suggesting is changing the meaning of those fields. They are strings that are meant to be human-readable (one with the time and the other with the date and time). If we change them, we could be affecting any existing clients of that API that expect them to be human-readable strings. The clients I'm referring is anyone consuming this API in an existing version of NiFi. As you mentioned, in our case we would need to update the UI (which is a client of this API) to reformat it as necessary. This is not something we would expect others to do in a minor/incremental version change or without somehow versioning the API. As I mentioned earlier, I believe that any field using a JAXB adapter is currently being interpreted incorrectly by Swagger. While it would be nice if Swagger could correctly determine the actual data type (a string in this case and not a date-time) it appears they at least provide a mechanism for setting it explicitly. We should be taking advantage of that. > DateTime API Endpoints don't respect RFC 3339 > - > > Key: NIFI-2900 > URL: https://issues.apache.org/jira/browse/NIFI-2900 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Stephane Maarek > > Hi, > the endpoint /flow/process-group/id is supposed to return lastRefreshed as > part of ProcessGroupFlowDTO as a DateTime, as indicated here: > lastRefreshed string (date-time) optionalThe time the flow for > the process group was last refreshed. > as it currently stands, what I am getting doesn't look like a timestamp: > "lastRefreshed":"14:02:46 AEDT" > I'm not sure how much of the overall API is affected > Edit: > Actually, it seems every date a "date-time" is created we expect the format > "HH:mm:ss z". > As per the OpenAPI specs, if a field is annotated "date-time", it should > respect the RFC 3339 convention > (https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#data-types). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1136 NiFi follows the semantic versioning guidelines. What your suggesting is changing the meaning of those fields. They are strings that are meant to be human-readable (one with the time and the other with the date and time). If we change them, we could be affecting any existing clients of that API that expect them to be human-readable strings. The clients I'm referring is anyone consuming this API in an existing version of NiFi. As you mentioned, in our case we would need to update the UI (which is a client of this API) to reformat it as necessary. This is not something we would expect others to do in a minor/incremental version change or without somehow versioning the API. As I mentioned earlier, I believe that any field using a JAXB adapter is currently being interpreted incorrectly by Swagger. While it would be nice if Swagger could correctly determine the actual data type (a string in this case and not a date-time) it appears they at least provide a mechanism for setting it explicitly. We should be taking advantage of that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
