[jira] [Commented] (NIFI-3354) Create CSV To Avro transformer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837101#comment-15837101
 ] 

ASF GitHub Bot commented on NIFI-3354:
--

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1436
  
@joewitt Thanks Joe. That was indeed copy/paste issue from unrelated 
internal effort. Will fix.


> Create CSV To Avro transformer
> --
>
> Key: NIFI-3354
> URL: https://issues.apache.org/jira/browse/NIFI-3354
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
>
> While we currently have CSV to AVRO transformer it required HDFS/Kite 
> dependencies which could be easily eliminated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

[olegz]

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1436
  
@joewitt Thanks Joe. That was indeed copy/paste issue from unrelated 
internal effort. Will fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3352) ListenLumberjack ACK frame sends long instead of int

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837073#comment-15837073
 ] 

ASF GitHub Bot commented on NIFI-3352:
--

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1421
  
@joewitt 

sure thing:


https://github.com/elastic/logstash-forwarder/blob/master/PROTOCOL.md#ack-frame-type



> ListenLumberjack ACK frame sends long instead of int
> 
>
> Key: NIFI-3352
> URL: https://issues.apache.org/jira/browse/NIFI-3352
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.7.1, 1.1.1
>Reporter: Andre
>Assignee: Andre
>
> When working on beats support I noticed the current ACK frame is sending a 
> long back to client when it should be sending an int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1421: NIFI-3352 - Address issue where ListenLumberjack was sendi...

[trixpan]

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1421
  
@joewitt 

sure thing:


https://github.com/elastic/logstash-forwarder/blob/master/PROTOCOL.md#ack-frame-type



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3352) ListenLumberjack ACK frame sends long instead of int

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837068#comment-15837068
 ] 

ASF GitHub Bot commented on NIFI-3352:
--

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1421
  
@trixpan is there anything we can reference for this change showing it 
should be an int instead of a long?  It is clearly a pretty simple change just 
want to have some clear basis for it.  thanks


> ListenLumberjack ACK frame sends long instead of int
> 
>
> Key: NIFI-3352
> URL: https://issues.apache.org/jira/browse/NIFI-3352
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.7.1, 1.1.1
>Reporter: Andre
>Assignee: Andre
>
> When working on beats support I noticed the current ACK frame is sending a 
> long back to client when it should be sending an int



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1421: NIFI-3352 - Address issue where ListenLumberjack was sendi...

[joewitt]

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1421
  
@trixpan is there anything we can reference for this change showing it 
should be an int instead of a long?  It is clearly a pretty simple change just 
want to have some clear basis for it.  thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3354) Create CSV To Avro transformer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837064#comment-15837064
 ] 

ASF GitHub Bot commented on NIFI-3354:
--

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1436
  
some of the source files have headers referencing hortonworks copyright.  
That is either a copy/paste issue and just needs to be fixed or it is not an 
original work for apache nifi and will need to go through the ip clearance 
process.  can you please clarify and/or adjust.  thanks


> Create CSV To Avro transformer
> --
>
> Key: NIFI-3354
> URL: https://issues.apache.org/jira/browse/NIFI-3354
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
>
> While we currently have CSV to AVRO transformer it required HDFS/Kite 
> dependencies which could be easily eliminated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

[joewitt]

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1436
  
some of the source files have headers referencing hortonworks copyright.  
That is either a copy/paste issue and just needs to be fixed or it is not an 
original work for apache nifi and will need to go through the ip clearance 
process.  can you please clarify and/or adjust.  thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3385) Update docs to reflect 2017 for copyright

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837062#comment-15837062
 ] 

ASF GitHub Bot commented on NIFI-3385:
--

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1440
  
its probably not a big deal or maybe even not a thing but technically this 
might update too many things as it is including updates against some 
dependencies we have.  Such updates might not be true for the copyright years 
for those deps.  Perhaps only update the first occurrence in any given file so 
that you know you're getting our copyright header only? @apiri 


> Update docs to reflect 2017 for copyright
> -
>
> Key: NIFI-3385
> URL: https://issues.apache.org/jira/browse/NIFI-3385
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Documentation & Website
>Affects Versions: 1.1.1
>Reporter: Aldrin Piri
>Assignee: Aldrin Piri
>Priority: Minor
>
> Docs should be updated to reflect extension of copyright to the new year.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1440: NIFI-3385 - Updating Copyright statements to reflect the n...

[joewitt]

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1440
  
its probably not a big deal or maybe even not a thing but technically this 
might update too many things as it is including updates against some 
dependencies we have.  Such updates might not be true for the copyright years 
for those deps.  Perhaps only update the first occurrence in any given file so 
that you know you're getting our copyright header only? @apiri 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (NIFI-3391) Cron documentation fixes

[Andy LoPresto (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy LoPresto resolved NIFI-3391.
-
   Resolution: Fixed
Fix Version/s: 1.2.0

> Cron documentation fixes
> 
>
> Key: NIFI-3391
> URL: https://issues.apache.org/jira/browse/NIFI-3391
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Sarah Olson
>Priority: Minor
> Fix For: 1.2.0
>
>
> There seem to be some documentation errors around the cron scheduler.  It 
> should agree with the [quartz cron 
> documentation|http://www.quartz-scheduler.org/documentation/quartz-2.x/tutorials/crontrigger.html]
>  and should probably be made more explicit.
> Specific issues:
> Year should be noted as optional
> Incosistency with numbering of days of week in our documentation
> More examples would be helpful
> A link to Quartz doc would be helpful



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3391) Cron documentation fixes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837050#comment-15837050
 ] 

ASF subversion and git services commented on NIFI-3391:
---

Commit e0e6f0bacb722a9b7a1bb38b531e67154237eedb in nifi's branch 
refs/heads/master from [~solson75]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=e0e6f0b ]

NIFI-3391 Update CRON Scheduling information in the Configuring a Processor 
section of the User Guide

This closes #1442.

Signed-off-by: Andy LoPresto 


> Cron documentation fixes
> 
>
> Key: NIFI-3391
> URL: https://issues.apache.org/jira/browse/NIFI-3391
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Sarah Olson
>Priority: Minor
>
> There seem to be some documentation errors around the cron scheduler.  It 
> should agree with the [quartz cron 
> documentation|http://www.quartz-scheduler.org/documentation/quartz-2.x/tutorials/crontrigger.html]
>  and should probably be made more explicit.
> Specific issues:
> Year should be noted as optional
> Incosistency with numbering of days of week in our documentation
> More examples would be helpful
> A link to Quartz doc would be helpful



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3391) Cron documentation fixes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837053#comment-15837053
 ] 

ASF GitHub Bot commented on NIFI-3391:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1442
  
Fixed a minor typo and merged. @thesolson thanks for getting this done so 
quickly. 


> Cron documentation fixes
> 
>
> Key: NIFI-3391
> URL: https://issues.apache.org/jira/browse/NIFI-3391
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Sarah Olson
>Priority: Minor
>
> There seem to be some documentation errors around the cron scheduler.  It 
> should agree with the [quartz cron 
> documentation|http://www.quartz-scheduler.org/documentation/quartz-2.x/tutorials/crontrigger.html]
>  and should probably be made more explicit.
> Specific issues:
> Year should be noted as optional
> Incosistency with numbering of days of week in our documentation
> More examples would be helpful
> A link to Quartz doc would be helpful



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1442: NIFI-3391: Update Chron Scheduling information in t...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1442


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1442: NIFI-3391: Update Chron Scheduling information in the Conf...

[alopresto]

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1442
  
Fixed a minor typo and merged. @thesolson thanks for getting this done so 
quickly. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3391) Cron documentation fixes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837052#comment-15837052
 ] 

ASF GitHub Bot commented on NIFI-3391:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1442


> Cron documentation fixes
> 
>
> Key: NIFI-3391
> URL: https://issues.apache.org/jira/browse/NIFI-3391
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Sarah Olson
>Priority: Minor
>
> There seem to be some documentation errors around the cron scheduler.  It 
> should agree with the [quartz cron 
> documentation|http://www.quartz-scheduler.org/documentation/quartz-2.x/tutorials/crontrigger.html]
>  and should probably be made more explicit.
> Specific issues:
> Year should be noted as optional
> Incosistency with numbering of days of week in our documentation
> More examples would be helpful
> A link to Quartz doc would be helpful



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3391) Cron documentation fixes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836939#comment-15836939
 ] 

ASF GitHub Bot commented on NIFI-3391:
--

GitHub user thesolson opened a pull request:

https://github.com/apache/nifi/pull/1442

NIFI-3391: Update Chron Scheduling information in the Configuring a P…

…rocessor section of the User Guide

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/thesolson/nifi NIFI-3391

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1442


commit 7dcf834ea9b4fa984d10e2137b43550f3b1a98e0
Author: Sarah Olson 
Date:   2017-01-25T00:35:14Z

NIFI-3391: Update Chron Scheduling information in the Configuring a 
Processor section of the User Guide




> Cron documentation fixes
> 
>
> Key: NIFI-3391
> URL: https://issues.apache.org/jira/browse/NIFI-3391
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Sarah Olson
>Priority: Minor
>
> There seem to be some documentation errors around the cron scheduler.  It 
> should agree with the [quartz cron 
> documentation|http://www.quartz-scheduler.org/documentation/quartz-2.x/tutorials/crontrigger.html]
>  and should probably be made more explicit.
> Specific issues:
> Year should be noted as optional
> Incosistency with numbering of days of week in our documentation
> More examples would be helpful
> A link to Quartz doc would be helpful



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1442: NIFI-3391: Update Chron Scheduling information in t...

[thesolson]

GitHub user thesolson opened a pull request:

https://github.com/apache/nifi/pull/1442

NIFI-3391: Update Chron Scheduling information in the Configuring a P…

…rocessor section of the User Guide

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/thesolson/nifi NIFI-3391

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1442


commit 7dcf834ea9b4fa984d10e2137b43550f3b1a98e0
Author: Sarah Olson 
Date:   2017-01-25T00:35:14Z

NIFI-3391: Update Chron Scheduling information in the Configuring a 
Processor section of the User Guide




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (NIFI-3251) Users who do not have modify the component access policy for a process group should not be able to delete components.

[James Wing (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Wing updated NIFI-3251:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Users who do not have modify the component access policy for a process group 
> should not be able to delete components.
> -
>
> Key: NIFI-3251
> URL: https://issues.apache.org/jira/browse/NIFI-3251
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Matthew Clarke
>Assignee: Matt Gilman
>Priority: Minor
> Fix For: 1.2.0
>
>
> Users are required to have "modify the component" access policy granted to 
> them on a process group in which they want to add components to the canvas.  
> They are not however required to have this access policy in order to remove 
> components from the canvas.  If a user is granted the "modify the component" 
> access policy on a specific processor, that user can then delete that 
> processor.  The "modify the component" access policy when granted to a 
> processor should only allow that user to modify the configuration (start, 
> stop, disable, modify setting/properties).  User should still be unable to 
> delete that processor. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1399: NIFI-3251: Updating authorization requirements for removin...

[jvwing]

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1399
  
@mcgilman I think this looks good, it worked well in my testing. The 
integration tests are passing again.  These changes didn't break any tests, but 
none of the tests in nifi-web-api really exercise them, and the test framework 
does not make it easy to add something for this.  At the risk of being a bad 
committer, I merged anyways.

Thanks for contributing this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3251) Users who do not have modify the component access policy for a process group should not be able to delete components.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836667#comment-15836667
 ] 

ASF GitHub Bot commented on NIFI-3251:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1399
  
@mcgilman I think this looks good, it worked well in my testing. The 
integration tests are passing again.  These changes didn't break any tests, but 
none of the tests in nifi-web-api really exercise them, and the test framework 
does not make it easy to add something for this.  At the risk of being a bad 
committer, I merged anyways.

Thanks for contributing this.


> Users who do not have modify the component access policy for a process group 
> should not be able to delete components.
> -
>
> Key: NIFI-3251
> URL: https://issues.apache.org/jira/browse/NIFI-3251
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Matthew Clarke
>Assignee: Matt Gilman
>Priority: Minor
> Fix For: 1.2.0
>
>
> Users are required to have "modify the component" access policy granted to 
> them on a process group in which they want to add components to the canvas.  
> They are not however required to have this access policy in order to remove 
> components from the canvas.  If a user is granted the "modify the component" 
> access policy on a specific processor, that user can then delete that 
> processor.  The "modify the component" access policy when granted to a 
> processor should only allow that user to modify the configuration (start, 
> stop, disable, modify setting/properties).  User should still be unable to 
> delete that processor. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1399: NIFI-3251: Updating authorization requirements for ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1399


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3251) Users who do not have modify the component access policy for a process group should not be able to delete components.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836659#comment-15836659
 ] 

ASF GitHub Bot commented on NIFI-3251:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1399


> Users who do not have modify the component access policy for a process group 
> should not be able to delete components.
> -
>
> Key: NIFI-3251
> URL: https://issues.apache.org/jira/browse/NIFI-3251
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Matthew Clarke
>Assignee: Matt Gilman
>Priority: Minor
> Fix For: 1.2.0
>
>
> Users are required to have "modify the component" access policy granted to 
> them on a process group in which they want to add components to the canvas.  
> They are not however required to have this access policy in order to remove 
> components from the canvas.  If a user is granted the "modify the component" 
> access policy on a specific processor, that user can then delete that 
> processor.  The "modify the component" access policy when granted to a 
> processor should only allow that user to modify the configuration (start, 
> stop, disable, modify setting/properties).  User should still be unable to 
> delete that processor. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3251) Users who do not have modify the component access policy for a process group should not be able to delete components.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836658#comment-15836658
 ] 

ASF subversion and git services commented on NIFI-3251:
---

Commit 7340078de2229a4fc094cd2185117a7772389ec0 in nifi's branch 
refs/heads/master from [~mcgilman]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=7340078 ]

NIFI-3251: Delete requires WRITE perms on parent
- Requiring WRITE permissions to the parent resource when attempting to remove 
a component.
- Updating expired certificates in the REST API integration tests.

This closes #1399.

Signed-off-by: James Wing 


> Users who do not have modify the component access policy for a process group 
> should not be able to delete components.
> -
>
> Key: NIFI-3251
> URL: https://issues.apache.org/jira/browse/NIFI-3251
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Matthew Clarke
>Assignee: Matt Gilman
>Priority: Minor
> Fix For: 1.2.0
>
>
> Users are required to have "modify the component" access policy granted to 
> them on a process group in which they want to add components to the canvas.  
> They are not however required to have this access policy in order to remove 
> components from the canvas.  If a user is granted the "modify the component" 
> access policy on a specific processor, that user can then delete that 
> processor.  The "modify the component" access policy when granted to a 
> processor should only allow that user to modify the configuration (start, 
> stop, disable, modify setting/properties).  User should still be unable to 
> delete that processor. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (NIFI-3391) Cron documentation fixes

[Sarah Olson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarah Olson reassigned NIFI-3391:
-

Assignee: Sarah Olson

> Cron documentation fixes
> 
>
> Key: NIFI-3391
> URL: https://issues.apache.org/jira/browse/NIFI-3391
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Sarah Olson
>Priority: Minor
>
> There seem to be some documentation errors around the cron scheduler.  It 
> should agree with the [quartz cron 
> documentation|http://www.quartz-scheduler.org/documentation/quartz-2.x/tutorials/crontrigger.html]
>  and should probably be made more explicit.
> Specific issues:
> Year should be noted as optional
> Incosistency with numbering of days of week in our documentation
> More examples would be helpful
> A link to Quartz doc would be helpful



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (NIFI-3392) Enhance documentation for provenance event type definitions

[Andrew Lim (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Lim reassigned NIFI-3392:


Assignee: Andrew Lim

> Enhance documentation for provenance event type definitions
> ---
>
> Key: NIFI-3392
> URL: https://issues.apache.org/jira/browse/NIFI-3392
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation & Website
>Affects Versions: 1.1.1
>Reporter: Andy LoPresto
>Assignee: Andrew Lim
>
> The provenance events can be unfamiliar to new users, and the nuance of the 
> event types can be confusing even to experienced users and developers. The 
> documentation should be improved to contain a definition table of the various 
> event types ({{CREATE}}, {{DROP}}, etc.), their meaning, and (for developers) 
> when to use each type if writing their own provenance reporting code. 
> A comprehensive list of event types is available (and discussed somewhat) in 
> [{{ProvenanceEventType.java}}|https://github.com/apache/nifi/blob/master/nifi-api/src/main/java/org/apache/nifi/provenance/ProvenanceEventType.java].
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3251) Users who do not have modify the component access policy for a process group should not be able to delete components.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836552#comment-15836552
 ] 

ASF GitHub Bot commented on NIFI-3251:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1399
  
I've updated the PR with the changes suggested thus far. Thanks again 
@jvwing!


> Users who do not have modify the component access policy for a process group 
> should not be able to delete components.
> -
>
> Key: NIFI-3251
> URL: https://issues.apache.org/jira/browse/NIFI-3251
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Matthew Clarke
>Assignee: Matt Gilman
>Priority: Minor
> Fix For: 1.2.0
>
>
> Users are required to have "modify the component" access policy granted to 
> them on a process group in which they want to add components to the canvas.  
> They are not however required to have this access policy in order to remove 
> components from the canvas.  If a user is granted the "modify the component" 
> access policy on a specific processor, that user can then delete that 
> processor.  The "modify the component" access policy when granted to a 
> processor should only allow that user to modify the configuration (start, 
> stop, disable, modify setting/properties).  User should still be unable to 
> delete that processor. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (NIFI-3392) Enhance documentation for provenance event type definitions

[Andy LoPresto (JIRA)]

Andy LoPresto created NIFI-3392:
---

 Summary: Enhance documentation for provenance event type 
definitions
 Key: NIFI-3392
 URL: https://issues.apache.org/jira/browse/NIFI-3392
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Documentation & Website
Affects Versions: 1.1.1
Reporter: Andy LoPresto


The provenance events can be unfamiliar to new users, and the nuance of the 
event types can be confusing even to experienced users and developers. The 
documentation should be improved to contain a definition table of the various 
event types ({{CREATE}}, {{DROP}}, etc.), their meaning, and (for developers) 
when to use each type if writing their own provenance reporting code. 

A comprehensive list of event types is available (and discussed somewhat) in 
[{{ProvenanceEventType.java}}|https://github.com/apache/nifi/blob/master/nifi-api/src/main/java/org/apache/nifi/provenance/ProvenanceEventType.java].
 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1399: NIFI-3251: Updating authorization requirements for removin...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1399
  
I've updated the PR with the changes suggested thus far. Thanks again 
@jvwing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

[alopresto]

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1302
  
@skrewz Yes, please make the changes and then as @apiri mentioned just push 
to the same branch and the PR will update automatically. Thanks for the quick 
response to my comments. Sorry again for the delay. Really appreciate this 
valuable work. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1399: NIFI-3251: Updating authorization requirements for removin...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1399
  
Yep, I'm tracking. Looks like that will provide more consistent coverage 
when checking if that behavior should be available.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3251) Users who do not have modify the component access policy for a process group should not be able to delete components.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836530#comment-15836530
 ] 

ASF GitHub Bot commented on NIFI-3251:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1399
  
Yep, I'm tracking. Looks like that will provide more consistent coverage 
when checking if that behavior should be available.


> Users who do not have modify the component access policy for a process group 
> should not be able to delete components.
> -
>
> Key: NIFI-3251
> URL: https://issues.apache.org/jira/browse/NIFI-3251
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Matthew Clarke
>Assignee: Matt Gilman
>Priority: Minor
> Fix For: 1.2.0
>
>
> Users are required to have "modify the component" access policy granted to 
> them on a process group in which they want to add components to the canvas.  
> They are not however required to have this access policy in order to remove 
> components from the canvas.  If a user is granted the "modify the component" 
> access policy on a specific processor, that user can then delete that 
> processor.  The "modify the component" access policy when granted to a 
> processor should only allow that user to modify the configuration (start, 
> stop, disable, modify setting/properties).  User should still be unable to 
> delete that processor. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2656) Allow bootstrap process to prompt for password/key

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836522#comment-15836522
 ] 

ASF GitHub Bot commented on NIFI-2656:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1302
  
@skrewz Yes, please make the changes and then as @apiri mentioned just push 
to the same branch and the PR will update automatically. Thanks for the quick 
response to my comments. Sorry again for the delay. Really appreciate this 
valuable work. 


> Allow bootstrap process to prompt for password/key
> --
>
> Key: NIFI-2656
> URL: https://issues.apache.org/jira/browse/NIFI-2656
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Configuration, Core Framework
>Affects Versions: 1.0.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Minor
>  Labels: bootstrap, config, encryption, security
> Fix For: 1.2.0
>
> Attachments: NIFI-2656.-K_support.1.patch
>
>
> The bootstrap process {{RunNiFi.java}} is currently responsible for reading 
> the key from {{bootstrap.conf}} and sending it to the running NiFi process 
> {{NiFi.java}} to be used for sensitive property decryption. This exposes the 
> key in two places:
> * Plaintext in {{bootstrap.conf}}
> * In the process invocation
> Running the following command ({{ps -aef | grep -i nifi}}) will result in the 
> following output:
> {code}
> ...
>   501 11597 11596   0  6:51PM ttys0010:08.55 
> /Users/alopresto/.jenv/versions/1.8/bin/java -classpath 
> /Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./conf:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/bcprov-jdk15on-1.54.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/commons-lang3-3.4.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/jcl-over-slf4j-1.7.12.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/jul-to-slf4j-1.7.12.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/log4j-over-slf4j-1.7.12.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/logback-classic-1.1.3.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/logback-core-1.1.3.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/nifi-api-1.0.0-SNAPSHOT.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/nifi-documentation-1.0.0-SNAPSHOT.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/nifi-framework-api-1.0.0-SNAPSHOT.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/nifi-nar-utils-1.0.0-SNAPSHOT.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/nifi-properties-1.0.0-SNAPSHOT.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/nifi-properties-loader-1.0.0-SNAPSHOT.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/nifi-runtime-1.0.0-SNAPSHOT.jar:/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./lib/slf4j-api-1.7.12.jar
>  -Dorg.apache.jasper.compiler.disablejsr199=true -Xmx512m -Xms512m 
> -Dsun.net.http.allowRestrictedHeaders=true -Djava.net.preferIPv4Stack=true 
> -Djava.awt.headless=true -XX:+UseG1GC 
> -Djava.protocol.handler.pkgs=sun.net.www.protocol 
> -Dnifi.properties.file.path=/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/./conf/nifi.properties
>  -Dnifi.bootstrap.listen.port=58213 -Dapp=NiFi 
> -Dorg.apache.nifi.bootstrap.config.log.dir=/Users/alopresto/Workspace/nifi/nifi-assembly/target/nifi-1.0.0-SNAPSHOT-bin/nifi-1.0.0-SNAPSHOT/logs
>  org.apache.nifi.NiFi -k 
> 0123456789ABCDEFFEDCBA98765432100123456789ABCDEFFEDCBA9876543210
> ...
> {code}
> To allow for a more secure invocation, the NiFi process could pause and 
> prompt for the password/key entry in a secure console if it is not provided 
> in the invocation arguments from bootstrap (or if a special flag is 
> provided). While this would require manual intervention to start the process, 
> it would not be default behavior. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3251) Users who do not have modify the component access policy for a process group should not be able to delete components.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836520#comment-15836520
 ] 

ASF GitHub Bot commented on NIFI-3251:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1399
  
@mcgilman Did you consider modifying the `isDeletable` method in 
nf-canvas-utils to check process group write access?  This is currently 
enabling the Delete button in the operate palette when the user has write 
permissions on a processor but not on a process group.


> Users who do not have modify the component access policy for a process group 
> should not be able to delete components.
> -
>
> Key: NIFI-3251
> URL: https://issues.apache.org/jira/browse/NIFI-3251
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.1.0
>Reporter: Matthew Clarke
>Assignee: Matt Gilman
>Priority: Minor
> Fix For: 1.2.0
>
>
> Users are required to have "modify the component" access policy granted to 
> them on a process group in which they want to add components to the canvas.  
> They are not however required to have this access policy in order to remove 
> components from the canvas.  If a user is granted the "modify the component" 
> access policy on a specific processor, that user can then delete that 
> processor.  The "modify the component" access policy when granted to a 
> processor should only allow that user to modify the configuration (start, 
> stop, disable, modify setting/properties).  User should still be unable to 
> delete that processor. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1399: NIFI-3251: Updating authorization requirements for ...

[mcgilman]

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1399#discussion_r97633156
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-services.js
 ---
@@ -497,6 +497,36 @@ nf.ControllerServices = (function () {
 };
 
 /**
+ * Determines if the user is authorized for the parent of the 
specified controller service.
+ *
+ * @param dataContext
+ * @returns {boolean}
+ */
+var isAuthorizedForControllerServiceParent = function (dataContext) {
--- End diff --

Agreed. Will update.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (NIFI-3389) FlowFileSchema writes attribute name and value as STRING instead of LONG_STRING

[Bryan Rosander (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Rosander reassigned NIFI-3389:


Assignee: Bryan Rosander

> FlowFileSchema writes attribute name and value as STRING instead of 
> LONG_STRING
> ---
>
> Key: NIFI-3389
> URL: https://issues.apache.org/jira/browse/NIFI-3389
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>
> This causes errors when the names or values of attributes exceeds 65535 bytes 
> when encoded as UTF-8.
> The fix would be pretty trivial but it has backwards compatibility 
> implications and the schema will need to be versioned to still be able to 
> read old flow files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (NIFI-3390) Add support for LDAP HA

[Pierre Villard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-3390:
-
Assignee: Pierre Villard
  Status: Patch Available  (was: Open)

> Add support for LDAP HA
> ---
>
> Key: NIFI-3390
> URL: https://issues.apache.org/jira/browse/NIFI-3390
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>
> Update LDAP provider mechanism to support multiple LDAP servers.
> Accept:
> {noformat}
> ldap://node1:port1,ldap://node2:port2
> {noformat}
> In {{LdapProvider.java}}, update
> {noformat}
> context.setUrl(url);
> {noformat}
> to use {{setUrls(String[] urls)}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-3390) Add support for LDAP HA

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836400#comment-15836400
 ] 

ASF GitHub Bot commented on NIFI-3390:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1441

NIFI-3390 Added support for LDAP HA

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-3390

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1441


commit 1632496ac9987ec298b9f8412f095737c99222ae
Author: Pierre Villard 
Date:   2017-01-24T18:18:42Z

NIFI-3390 Added support for multiple LDAP servers




> Add support for LDAP HA
> ---
>
> Key: NIFI-3390
> URL: https://issues.apache.org/jira/browse/NIFI-3390
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>
> Update LDAP provider mechanism to support multiple LDAP servers.
> Accept:
> {noformat}
> ldap://node1:port1,ldap://node2:port2
> {noformat}
> In {{LdapProvider.java}}, update
> {noformat}
> context.setUrl(url);
> {noformat}
> to use {{setUrls(String[] urls)}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1441: NIFI-3390 Added support for LDAP HA

[pvillard31]

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1441

NIFI-3390 Added support for LDAP HA

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-3390

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1441


commit 1632496ac9987ec298b9f8412f095737c99222ae
Author: Pierre Villard 
Date:   2017-01-24T18:18:42Z

NIFI-3390 Added support for multiple LDAP servers




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1399: NIFI-3251: Updating authorization requirements for removin...

[jvwing]

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1399
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

[apiri]

Github user apiri commented on the issue:

https://github.com/apache/nifi/pull/1302
  
@skrewz You can just push to the same branch that this PR was made from and 
GitHub has you covered from there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

[skrewz]

Github user skrewz commented on the issue:

https://github.com/apache/nifi/pull/1302
  
So, ehm. Should I remedy the above, and ehm---haven't done GitHub pull 
requests before---update the pull request or how does this work? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1302: NIFI-2656: replace -k [password] with -K [passwordf...

[skrewz]

Github user skrewz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1302#discussion_r97520897
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -1027,19 +1028,24 @@ public boolean accept(final File dir, final String 
filename) {
 cmd.add("-Dorg.apache.nifi.bootstrap.config.log.dir=" + 
nifiLogDir);
 cmd.add("org.apache.nifi.NiFi");
 if (props.containsKey(NIFI_BOOTSTRAP_SENSITIVE_KEY) && 
!StringUtils.isBlank(props.get(NIFI_BOOTSTRAP_SENSITIVE_KEY))) {
-cmd.add("-k " + props.get(NIFI_BOOTSTRAP_SENSITIVE_KEY));
+File password_file = new File(confDir, "sensitive.key");
+
+// Restrict permissions:
+password_file.setReadable(false,false);
--- End diff --

Both of `RunNifi` and `Nifi` are run as the `run.as` user, referring to 
`nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi.sh`.
 `setOwner` is therefore implicitly already the `run.as` user---we can make it 
explicit, no trouble, but what do we gain from it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1302: NIFI-2656: replace -k [password] with -K [passwordf...

[skrewz]

Github user skrewz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1302#discussion_r97520807
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -1027,19 +1028,24 @@ public boolean accept(final File dir, final String 
filename) {
 cmd.add("-Dorg.apache.nifi.bootstrap.config.log.dir=" + 
nifiLogDir);
 cmd.add("org.apache.nifi.NiFi");
 if (props.containsKey(NIFI_BOOTSTRAP_SENSITIVE_KEY) && 
!StringUtils.isBlank(props.get(NIFI_BOOTSTRAP_SENSITIVE_KEY))) {
-cmd.add("-k " + props.get(NIFI_BOOTSTRAP_SENSITIVE_KEY));
+File password_file = new File(confDir, "sensitive.key");
+
+// Restrict permissions:
+password_file.setReadable(false,false);
--- End diff --

I went with `setReadable()`/`setWritable()` because of them not tying into 
POSIX more than necessary. But I guess we're relying on POSIX anyway. And at 
either rate: checking (and erroring out on) the return values indeed is an 
omission.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1294: NIFI-2961 Create EncryptAttribute processor

[HandOfGod94]

Github user HandOfGod94 commented on the issue:

https://github.com/apache/nifi/pull/1294
  
I am not in need of this processor. I just wanted to contribute so took it 
up. I'll give it another go, but I have few question:
1. Should we modify original EncryptContent to achieve encryption of 
attributes?
2. Do we need new JIRA ticket if I modifiy the original EncryptContent?
3. From intial lookup, it seems the code for EncryptContent will become 
more cumbersome if we want to add aditional functionality for encryption of 
attributes. Should we package it out to modularize or it'll be against NiFi 
guidelinies?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---