[GitHub] nifi issue #1860: NIFI-3979 Documenting how ListHDFS maintains state and per...
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1860 +1, merging, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3979) ListHDFS always skips files with latest timestamp
[ https://issues.apache.org/jira/browse/NIFI-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025994#comment-16025994 ] ASF GitHub Bot commented on NIFI-3979: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1860 +1, merging, thanks! > ListHDFS always skips files with latest timestamp > - > > Key: NIFI-3979 > URL: https://issues.apache.org/jira/browse/NIFI-3979 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.1.0, 1.2.0, 1.1.1 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Fix For: 1.3.0 > > > In NIFI-3213 there was a fix made for ListFile to correct a problem where it > was never listing the latest file. > The same problem exists in ListHDFS. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1860: NIFI-3979 Documenting how ListHDFS maintains state ...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1860 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3979) ListHDFS always skips files with latest timestamp
[ https://issues.apache.org/jira/browse/NIFI-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025998#comment-16025998 ] ASF GitHub Bot commented on NIFI-3979: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1860 > ListHDFS always skips files with latest timestamp > - > > Key: NIFI-3979 > URL: https://issues.apache.org/jira/browse/NIFI-3979 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.1.0, 1.2.0, 1.1.1 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Fix For: 1.3.0 > > > In NIFI-3213 there was a fix made for ListFile to correct a problem where it > was never listing the latest file. > The same problem exists in ListHDFS. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3979) ListHDFS always skips files with latest timestamp
[ https://issues.apache.org/jira/browse/NIFI-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025996#comment-16025996 ] ASF subversion and git services commented on NIFI-3979: --- Commit e85081ed201bc7413e3d2d062c814e23c0ff5467 in nifi's branch refs/heads/master from [~bbende] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=e85081e ] NIFI-3979 Documenting how ListHDFS maintains state and performs listings Signed-off-by: Pierre Villard This closes #1860. > ListHDFS always skips files with latest timestamp > - > > Key: NIFI-3979 > URL: https://issues.apache.org/jira/browse/NIFI-3979 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.1.0, 1.2.0, 1.1.1 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Fix For: 1.3.0 > > > In NIFI-3213 there was a fix made for ListFile to correct a problem where it > was never listing the latest file. > The same problem exists in ListHDFS. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3979) ListHDFS always skips files with latest timestamp
[ https://issues.apache.org/jira/browse/NIFI-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-3979: - Component/s: Extensions > ListHDFS always skips files with latest timestamp > - > > Key: NIFI-3979 > URL: https://issues.apache.org/jira/browse/NIFI-3979 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.1.0, 1.2.0, 1.1.1 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: documentation > Fix For: 1.3.0 > > > In NIFI-3213 there was a fix made for ListFile to correct a problem where it > was never listing the latest file. > The same problem exists in ListHDFS. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3979) ListHDFS always skips files with latest timestamp
[ https://issues.apache.org/jira/browse/NIFI-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-3979: - Labels: documentation (was: ) > ListHDFS always skips files with latest timestamp > - > > Key: NIFI-3979 > URL: https://issues.apache.org/jira/browse/NIFI-3979 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.1.0, 1.2.0, 1.1.1 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: documentation > Fix For: 1.3.0 > > > In NIFI-3213 there was a fix made for ListFile to correct a problem where it > was never listing the latest file. > The same problem exists in ListHDFS. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3979) ListHDFS always skips files with latest timestamp
[ https://issues.apache.org/jira/browse/NIFI-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-3979: - Resolution: Fixed Status: Resolved (was: Patch Available) > ListHDFS always skips files with latest timestamp > - > > Key: NIFI-3979 > URL: https://issues.apache.org/jira/browse/NIFI-3979 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.1.0, 1.2.0, 1.1.1 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: documentation > Fix For: 1.3.0 > > > In NIFI-3213 there was a fix made for ListFile to correct a problem where it > was never listing the latest file. > The same problem exists in ListHDFS. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3959) Anatomy of Processor/Process Group screenshots do not match statistics
[ https://issues.apache.org/jira/browse/NIFI-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026243#comment-16026243 ] ASF subversion and git services commented on NIFI-3959: --- Commit 3966f5ce866ab0d62ce966266bb074704c3d95f2 in nifi's branch refs/heads/master from [~andrewmlim] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=3966f5c ] NIFI-3959 Corrected Anatomy of Processor and Process group screenshots and text Signed-off-by: Scott Aslan This closes #1862 > Anatomy of Processor/Process Group screenshots do not match statistics > -- > > Key: NIFI-3959 > URL: https://issues.apache.org/jira/browse/NIFI-3959 > Project: Apache NiFi > Issue Type: Bug > Components: Documentation & Website >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > In the Anatomy of Processor and Anatomy of Process Group sections of the User > Guide, there are screenshots of these components and an explanation of the > statistics contained in them. But the statistics do not match. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1862: NIFI-3959 Corrected Anatomy of Processor and Process group...
Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/1862 Thanks @andrewmlim this has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1862: NIFI-3959 Corrected Anatomy of Processor and Proces...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1862 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3959) Anatomy of Processor/Process Group screenshots do not match statistics
[ https://issues.apache.org/jira/browse/NIFI-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026244#comment-16026244 ] ASF GitHub Bot commented on NIFI-3959: -- Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/1862 Thanks @andrewmlim this has been merged to master. > Anatomy of Processor/Process Group screenshots do not match statistics > -- > > Key: NIFI-3959 > URL: https://issues.apache.org/jira/browse/NIFI-3959 > Project: Apache NiFi > Issue Type: Bug > Components: Documentation & Website >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > In the Anatomy of Processor and Anatomy of Process Group sections of the User > Guide, there are screenshots of these components and an explanation of the > statistics contained in them. But the statistics do not match. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (NIFI-3959) Anatomy of Processor/Process Group screenshots do not match statistics
[ https://issues.apache.org/jira/browse/NIFI-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan resolved NIFI-3959. --- Resolution: Fixed > Anatomy of Processor/Process Group screenshots do not match statistics > -- > > Key: NIFI-3959 > URL: https://issues.apache.org/jira/browse/NIFI-3959 > Project: Apache NiFi > Issue Type: Bug > Components: Documentation & Website >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > In the Anatomy of Processor and Anatomy of Process Group sections of the User > Guide, there are screenshots of these components and an explanation of the > statistics contained in them. But the statistics do not match. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3959) Anatomy of Processor/Process Group screenshots do not match statistics
[ https://issues.apache.org/jira/browse/NIFI-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026245#comment-16026245 ] ASF GitHub Bot commented on NIFI-3959: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1862 > Anatomy of Processor/Process Group screenshots do not match statistics > -- > > Key: NIFI-3959 > URL: https://issues.apache.org/jira/browse/NIFI-3959 > Project: Apache NiFi > Issue Type: Bug > Components: Documentation & Website >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > > In the Anatomy of Processor and Anatomy of Process Group sections of the User > Guide, there are screenshots of these components and an explanation of the > statistics contained in them. But the statistics do not match. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (NIFI-3983) Support ability to make JMS 2.0 durable subscriptions on Topic
Michael Andre Pearce created NIFI-3983: -- Summary: Support ability to make JMS 2.0 durable subscriptions on Topic Key: NIFI-3983 URL: https://issues.apache.org/jira/browse/NIFI-3983 Project: Apache NiFi Issue Type: Improvement Reporter: Michael Andre Pearce Currently the jms consumer, only supports standard queue consumption and topic subscription. For topics, in JMS 2.0 you can make shared durable subscribers which gives a subscription semantic similar to queue per subscription name, meaning message is delivered once per subscription. This is very useful in setups using JMS 2.0. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1863: NIFI-3983 - Support ability to make JMS 2.0 durable...
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/nifi/pull/1863 NIFI-3983 - Support ability to make JMS 2.0 durable subscriptions on ⦠â¦Topic Add new optional config option to supply subscription name. Add logic in Consumer that if subscription name present and destination is pubsub (Topic) then make a SharedDurableConsumer. Else fallback to existing logic. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ Y] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? NIFI-3983 - [ Y] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ Y] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ Y] Is your initial contribution a single, squashed commit? ### For code changes: - [ ]Y Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [Y ] Have you written or updated unit tests to verify your changes? - [N/A ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [N/A ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ Y] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [N/A ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/nifi NIFI-3983 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1863.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1863 commit 43e4d57d530ebcbc75d61abda2bed5c864db27d8 Author: Michael Andre Pearce Date: 2017-05-26T13:12:45Z NIFI-3983 - Support ability to make JMS 2.0 durable subscriptions on Topic Add new optional config option to supply subscription name. Add logic in Consumer that if subscription name present and destination is pubsub (Topic) then make a SharedDurableConsumer. Else fallback to existing logic. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3983) Support ability to make JMS 2.0 durable subscriptions on Topic
[ https://issues.apache.org/jira/browse/NIFI-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026272#comment-16026272 ] ASF GitHub Bot commented on NIFI-3983: -- GitHub user michaelandrepearce opened a pull request: https://github.com/apache/nifi/pull/1863 NIFI-3983 - Support ability to make JMS 2.0 durable subscriptions on … …Topic Add new optional config option to supply subscription name. Add logic in Consumer that if subscription name present and destination is pubsub (Topic) then make a SharedDurableConsumer. Else fallback to existing logic. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ Y] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? NIFI-3983 - [ Y] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ Y] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ Y] Is your initial contribution a single, squashed commit? ### For code changes: - [ ]Y Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [Y ] Have you written or updated unit tests to verify your changes? - [N/A ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [N/A ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ Y] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [N/A ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/nifi NIFI-3983 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1863.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1863 commit 43e4d57d530ebcbc75d61abda2bed5c864db27d8 Author: Michael Andre Pearce Date: 2017-05-26T13:12:45Z NIFI-3983 - Support ability to make JMS 2.0 durable subscriptions on Topic Add new optional config option to supply subscription name. Add logic in Consumer that if subscription name present and destination is pubsub (Topic) then make a SharedDurableConsumer. Else fallback to existing logic. > Support ability to make JMS 2.0 durable subscriptions on Topic > -- > > Key: NIFI-3983 > URL: https://issues.apache.org/jira/browse/NIFI-3983 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Michael Andre Pearce > > Currently the jms consumer, only supports standard queue consumption and > topic subscription. For topics, in JMS 2.0 you can make shared durable > subscribers which gives a subscription semantic similar to queue per > subscription name, meaning message is delivered once per subscription. This > is very useful in setups using JMS 2.0. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi-minifi-cpp pull request #104: MINIFI-296 - Configurable logging, spdlog...
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704784 --- Diff: libminifi/include/Site2SitePeer.h --- @@ -72,8 +73,8 @@ class Site2SitePeer : public org::apache::nifi::minifi::io::BaseStream { explicit Site2SitePeer(Site2SitePeer &&ss) : stream_(ss.stream_.release()), host_(std::move(ss.host_)), -port_(std::move(ss.port_)) { -logger_ = logging::Logger::getLogger(); +port_(std::move(ss.port_)), +logger_(ss.logger_) { --- End diff -- @phrocker good call, will fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #104: MINIFI-296 - Configurable logging, spdlog...
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704804 --- Diff: libminifi/include/core/controller/ControllerService.h --- @@ -64,7 +64,7 @@ class ControllerService : public ConfigurableComponent, public Connectable { */ explicit ControllerService() : Connectable(core::getClassName(), 0), -ConfigurableComponent(logging::Logger::getLogger()), +ConfigurableComponent(), --- End diff -- @phrocker good call, will fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #104: MINIFI-296 - Configurable logging, spdlog...
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704895 --- Diff: libminifi/include/utils/StringUtils.h --- @@ -89,6 +89,25 @@ class StringUtils { s.end()); return s; } + + static std::vector split(const std::string &str, const std::string &delimiter) { +std::vector result; +int last = 0; +int next = 0; +while ((next = str.find(delimiter, last)) != std::string::npos) { + result.push_back(str.substr(last, next - last)); + last = next + delimiter.length(); +} +result.push_back(str.substr(last, next - last)); +return result; + } + + static inline bool starts_with(const std::string &str, const std::string &prefix) { --- End diff -- @phrocker good call, will fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #104: MINIFI-296 - Configurable logging, spdlog...
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704850 --- Diff: libminifi/include/core/logging/LoggerConfiguration.h --- @@ -0,0 +1,147 @@ +/** + * @file LoggerConfiguration.h + * Logger class declaration + * This is a C++ wrapper for spdlog, a lightweight C++ logging library + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifndef __LOGGER_CONFIGURATION_H__ +#define __LOGGER_CONFIGURATION_H__ + +#include +#include +#include +#include +#include "core/logging/Logger.h" +#include "properties/Properties.h" + +#include "spdlog/spdlog.h" +#include "spdlog/formatter.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace core { +namespace logging { + +namespace internal { + /** + * This class should not be instantiated directly. Use LoggerFactory to get an instance. --- End diff -- @phrocker good call, will fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #104: MINIFI-296 - Configurable logging, spdlog...
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704917 --- Diff: libminifi/test/TestBase.h --- @@ -21,35 +21,104 @@ #include #include #include +#include #include "ResourceClaim.h" #include "catch.hpp" #include -#include "core/logging/LogAppenders.h" #include "core/logging/Logger.h" #include "core/Core.h" #include "properties/Configure.h" +#include "properties/Properties.h" +#include "core/logging/LoggerConfiguration.h" +#include "spdlog/sinks/ostream_sink.h" +#include "spdlog/sinks/dist_sink.h" class LogTestController { public: - LogTestController(const std::string level = "debug") { -logging::Logger::getLogger()->setLogLevel(level); + static LogTestController& getInstance() { + static LogTestController instance; + return instance; } - - void enableDebug() { -logging::Logger::getLogger()->setLogLevel("debug"); + + template + void setDebug() { +setLevel(spdlog::level::debug); + } + + template + void setInfo() { +setLevel(spdlog::level::info); + } + + template + void setLevel(spdlog::level::level_enum level) { +logging::LoggerFactory::getLogger(); +std::string name = core::getClassName(); +modified_loggers.push_back(name); +setLevel(name, level); + } + + bool contains(const std::string &ending) { + return contains(log_output, ending); + } + + bool contains(const std::ostringstream &stream, const std::string &ending) { +std::string str = stream.str(); +logger_->log_info("Looking for %s in %s.", ending, str); +return (ending.length() > 0 && str.find(ending) != std::string::npos); + } + + void reset() { +for (auto const & name : modified_loggers) { + setLevel(name, spdlog::level::err); +} +modified_loggers = std::vector(); +resetStream(log_output); + } + + inline bool resetStream(std::ostringstream &stream) { +stream.str(""); +stream.clear(); --- End diff -- @phrocker good call, will fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #104: MINIFI-296 - Configurable logging, spdlog...
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118705983 --- Diff: libminifi/test/TestBase.h --- @@ -21,35 +21,104 @@ #include #include #include +#include #include "ResourceClaim.h" #include "catch.hpp" #include -#include "core/logging/LogAppenders.h" #include "core/logging/Logger.h" #include "core/Core.h" #include "properties/Configure.h" +#include "properties/Properties.h" +#include "core/logging/LoggerConfiguration.h" +#include "spdlog/sinks/ostream_sink.h" +#include "spdlog/sinks/dist_sink.h" class LogTestController { public: - LogTestController(const std::string level = "debug") { -logging::Logger::getLogger()->setLogLevel(level); + static LogTestController& getInstance() { + static LogTestController instance; + return instance; } - - void enableDebug() { -logging::Logger::getLogger()->setLogLevel("debug"); + + template + void setDebug() { +setLevel(spdlog::level::debug); --- End diff -- @phrocker the LogTestController class is already coupled to spdlog (for construction of the sinks, etc) and was where I was trying to isolate spdlog in context of the tests. I'd removed the parallel level enum logic we had in the code because it's only needed in tests as far as I can tell. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #104: MINIFI-296 - Configurable logging, spdlog...
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118706272 --- Diff: libminifi/test/TestBase.h --- @@ -21,35 +21,104 @@ #include #include #include +#include #include "ResourceClaim.h" #include "catch.hpp" #include -#include "core/logging/LogAppenders.h" #include "core/logging/Logger.h" #include "core/Core.h" #include "properties/Configure.h" +#include "properties/Properties.h" +#include "core/logging/LoggerConfiguration.h" +#include "spdlog/sinks/ostream_sink.h" +#include "spdlog/sinks/dist_sink.h" class LogTestController { public: - LogTestController(const std::string level = "debug") { -logging::Logger::getLogger()->setLogLevel(level); + static LogTestController& getInstance() { + static LogTestController instance; + return instance; } - - void enableDebug() { -logging::Logger::getLogger()->setLogLevel("debug"); + + template + void setDebug() { +setLevel(spdlog::level::debug); --- End diff -- Will do another sweep of the codebase for spdlog references and try to limit them to the Logger, LoggerConfiguration, and LogTestController --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1845: NIFI-3960 - ExtractGrok - Include exception message when c...
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1845 thanks for the contribution LGTM. merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3960) ExtractGrok - Include exception message when compile fails
[ https://issues.apache.org/jira/browse/NIFI-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026365#comment-16026365 ] ASF GitHub Bot commented on NIFI-3960: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1845 thanks for the contribution LGTM. merging > ExtractGrok - Include exception message when compile fails > -- > > Key: NIFI-3960 > URL: https://issues.apache.org/jira/browse/NIFI-3960 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Trivial > > When using ExtractGrok, I noticed that there is no way to have details when a > grok expression is not compiling. It's just saying "Not a valid Grok > Expression". Could be nice to include the message of the corresponding > exception in the validator. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (NIFI-3984) Support secure access to HWX Schema Registry
Bryan Bende created NIFI-3984: - Summary: Support secure access to HWX Schema Registry Key: NIFI-3984 URL: https://issues.apache.org/jira/browse/NIFI-3984 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.2.0 Reporter: Bryan Bende Priority: Minor In 1.2.0 we added support for accessing the Hortonworks Schema Registry. It looks like the next release of the schema registry will be adding support for Kerberos authentication: https://github.com/hortonworks/registry/issues/112 This is a place-holder to upgrade the registry-client version on the NiFi side when this functionality is released. Currently we are at 0.2.0 as specified here: https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L57 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1845: NIFI-3960 - ExtractGrok - Include exception message...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1845 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3960) ExtractGrok - Include exception message when compile fails
[ https://issues.apache.org/jira/browse/NIFI-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026370#comment-16026370 ] ASF GitHub Bot commented on NIFI-3960: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1845 > ExtractGrok - Include exception message when compile fails > -- > > Key: NIFI-3960 > URL: https://issues.apache.org/jira/browse/NIFI-3960 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Trivial > > When using ExtractGrok, I noticed that there is no way to have details when a > grok expression is not compiling. It's just saying "Not a valid Grok > Expression". Could be nice to include the message of the corresponding > exception in the validator. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (NIFI-3984) Support secure access to HWX Schema Registry
[ https://issues.apache.org/jira/browse/NIFI-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yolanda M. Davis reassigned NIFI-3984: -- Assignee: Yolanda M. Davis > Support secure access to HWX Schema Registry > > > Key: NIFI-3984 > URL: https://issues.apache.org/jira/browse/NIFI-3984 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Bryan Bende >Assignee: Yolanda M. Davis >Priority: Minor > > In 1.2.0 we added support for accessing the Hortonworks Schema Registry. It > looks like the next release of the schema registry will be adding support for > Kerberos authentication: > https://github.com/hortonworks/registry/issues/112 > This is a place-holder to upgrade the registry-client version on the NiFi > side when this functionality is released. > Currently we are at 0.2.0 as specified here: > https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L57 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (NIFI-3985) SiteToSiteProvenanceReportingTask should support starting at end of Provenance Stream or Beginning of Stream
Mark Payne created NIFI-3985: Summary: SiteToSiteProvenanceReportingTask should support starting at end of Provenance Stream or Beginning of Stream Key: NIFI-3985 URL: https://issues.apache.org/jira/browse/NIFI-3985 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Mark Payne Assignee: Mark Payne When the Site-to-Site Provenance Reporting Task is used, it always begins sending data with the oldest event in the Provenance Repository. The Reporting Task should support optionally starting at the most recent event as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3960) ExtractGrok - Include exception message when compile fails
[ https://issues.apache.org/jira/browse/NIFI-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andre F de Miranda updated NIFI-3960: - Resolution: Fixed Fix Version/s: 1.3.0 Status: Resolved (was: Patch Available) > ExtractGrok - Include exception message when compile fails > -- > > Key: NIFI-3960 > URL: https://issues.apache.org/jira/browse/NIFI-3960 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Trivial > Fix For: 1.3.0 > > > When using ExtractGrok, I noticed that there is no way to have details when a > grok expression is not compiling. It's just saying "Not a valid Grok > Expression". Could be nice to include the message of the corresponding > exception in the validator. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1864: NIFI-3985: Added 'Starting Position' property to Si...
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1864 NIFI-3985: Added 'Starting Position' property to SiteToSiteReportingT⦠â¦ask; also added additionalDetails.html that explains the schema and updated the reporting task to stop publishing when the user clicks 'stops' instead of running indefinitely until the reporting task has caught up Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi NIFI-3985 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1864.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1864 commit 2b3589fed8162e841afffd941aaca02539468636 Author: Mark Payne Date: 2017-05-26T14:59:47Z NIFI-3985: Added 'Starting Position' property to SiteToSiteReportingTask; also added additionalDetails.html that explains the schema and updated the reporting task to stop publishing when the user clicks 'stops' instead of running indefinitely until the reporting task has caught up --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (NIFI-358) Document contributing to documentation.
[ https://issues.apache.org/jira/browse/NIFI-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andre F de Miranda resolved NIFI-358. - Resolution: Fixed > Document contributing to documentation. > --- > > Key: NIFI-358 > URL: https://issues.apache.org/jira/browse/NIFI-358 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation & Website >Reporter: Sean Busbey >Assignee: Andre F de Miranda >Priority: Critical > > Our guides for contributing don't include anything on how to contribute to > the documentation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3985) SiteToSiteProvenanceReportingTask should support starting at end of Provenance Stream or Beginning of Stream
[ https://issues.apache.org/jira/browse/NIFI-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026372#comment-16026372 ] ASF GitHub Bot commented on NIFI-3985: -- GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/1864 NIFI-3985: Added 'Starting Position' property to SiteToSiteReportingT… …ask; also added additionalDetails.html that explains the schema and updated the reporting task to stop publishing when the user clicks 'stops' instead of running indefinitely until the reporting task has caught up Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi NIFI-3985 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1864.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1864 commit 2b3589fed8162e841afffd941aaca02539468636 Author: Mark Payne Date: 2017-05-26T14:59:47Z NIFI-3985: Added 'Starting Position' property to SiteToSiteReportingTask; also added additionalDetails.html that explains the schema and updated the reporting task to stop publishing when the user clicks 'stops' instead of running indefinitely until the reporting task has caught up > SiteToSiteProvenanceReportingTask should support starting at end of > Provenance Stream or Beginning of Stream > > > Key: NIFI-3985 > URL: https://issues.apache.org/jira/browse/NIFI-3985 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > When the Site-to-Site Provenance Reporting Task is used, it always begins > sending data with the oldest event in the Provenance Repository. The > Reporting Task should support optionally starting at the most recent event as > well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (NIFI-3986) Site-to-Site Provenance Reporting Task constantly emitting EOFException
Mark Payne created NIFI-3986: Summary: Site-to-Site Provenance Reporting Task constantly emitting EOFException Key: NIFI-3986 URL: https://issues.apache.org/jira/browse/NIFI-3986 Project: Apache NiFi Issue Type: Bug Reporter: Mark Payne Assignee: Mark Payne When I use the SiteToSiteProvenanceReportingTask, I consistently see error messages about EOFException being thrown when trying to read from the Provenance Repository. I suspect that it has to do with Provenance repository rolling over the log files while the Reporting Task is trying to read the data. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1865: NIFI-3836 Added check for root user in test that de...
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/1865 NIFI-3836 Added check for root user in test that depends on unreadabl⦠â¦e file. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alopresto/nifi NIFI-3836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1865.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1865 commit 8d5effabcf34fe79c894c8426528c3a2e298b556 Author: Andy LoPresto Date: 2017-05-26T17:27:18Z NIFI-3836 Added check for root user in test that depends on unreadable file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3836) CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test failure on Docker maven:latest
[ https://issues.apache.org/jira/browse/NIFI-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026582#comment-16026582 ] ASF GitHub Bot commented on NIFI-3836: -- GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/1865 NIFI-3836 Added check for root user in test that depends on unreadabl… …e file. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alopresto/nifi NIFI-3836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1865.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1865 commit 8d5effabcf34fe79c894c8426528c3a2e298b556 Author: Andy LoPresto Date: 2017-05-26T17:27:18Z NIFI-3836 Added check for root user in test that depends on unreadable file. > CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test > failure on Docker maven:latest > --- > > Key: NIFI-3836 > URL: https://issues.apache.org/jira/browse/NIFI-3836 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.2.0, 1.3.0 > Environment: maven:latest (b5ab9b7ecf5a) on Docker for Mac > 17.03.1-ce-mac5 (16048) >Reporter: Joey Frazee >Priority: Minor > > Running `mvn clean install` on Docker consistently fails with: > {code} > Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.65 sec <<< > FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest > testShouldNotValidateUnreadableFileBasedKeyProvider(org.apache.nifi.provenance.CryptoUtilsTest) > Time elapsed: 0.111 sec <<< FAILURE! > org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert > !unreadableKeyProviderIsValid >|| >|true >false > at > org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:402) > at > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:650) > at > org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider(CryptoUtilsTest.groovy:214) > Running org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.285 sec - > in org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Results : > Failed tests: > CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider:214 > assert !unreadableKeyProviderIsValid >|| >|true >false > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1865: NIFI-3836 Added check for root user in test that depends o...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1865 This can be verified by running the Maven test suite in `nifi-commons/nifi-data-provenance-utils` as the `root` user. The process `id -u` should return `0` for the `root` user and a non-`0` value for other users. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3836) CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test failure on Docker maven:latest
[ https://issues.apache.org/jira/browse/NIFI-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026584#comment-16026584 ] ASF GitHub Bot commented on NIFI-3836: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1865 This can be verified by running the Maven test suite in `nifi-commons/nifi-data-provenance-utils` as the `root` user. The process `id -u` should return `0` for the `root` user and a non-`0` value for other users. > CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test > failure on Docker maven:latest > --- > > Key: NIFI-3836 > URL: https://issues.apache.org/jira/browse/NIFI-3836 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.2.0, 1.3.0 > Environment: maven:latest (b5ab9b7ecf5a) on Docker for Mac > 17.03.1-ce-mac5 (16048) >Reporter: Joey Frazee >Priority: Minor > > Running `mvn clean install` on Docker consistently fails with: > {code} > Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.65 sec <<< > FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest > testShouldNotValidateUnreadableFileBasedKeyProvider(org.apache.nifi.provenance.CryptoUtilsTest) > Time elapsed: 0.111 sec <<< FAILURE! > org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert > !unreadableKeyProviderIsValid >|| >|true >false > at > org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:402) > at > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:650) > at > org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider(CryptoUtilsTest.groovy:214) > Running org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.285 sec - > in org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Results : > Failed tests: > CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider:214 > assert !unreadableKeyProviderIsValid >|| >|true >false > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (NIFI-3836) CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test failure on Docker maven:latest
[ https://issues.apache.org/jira/browse/NIFI-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto reassigned NIFI-3836: --- Assignee: Andy LoPresto > CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test > failure on Docker maven:latest > --- > > Key: NIFI-3836 > URL: https://issues.apache.org/jira/browse/NIFI-3836 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.2.0, 1.3.0 > Environment: maven:latest (b5ab9b7ecf5a) on Docker for Mac > 17.03.1-ce-mac5 (16048) >Reporter: Joey Frazee >Assignee: Andy LoPresto >Priority: Minor > Labels: permissions, test > > Running `mvn clean install` on Docker consistently fails with: > {code} > Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.65 sec <<< > FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest > testShouldNotValidateUnreadableFileBasedKeyProvider(org.apache.nifi.provenance.CryptoUtilsTest) > Time elapsed: 0.111 sec <<< FAILURE! > org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert > !unreadableKeyProviderIsValid >|| >|true >false > at > org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:402) > at > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:650) > at > org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider(CryptoUtilsTest.groovy:214) > Running org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.285 sec - > in org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Results : > Failed tests: > CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider:214 > assert !unreadableKeyProviderIsValid >|| >|true >false > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3836) CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test failure on Docker maven:latest
[ https://issues.apache.org/jira/browse/NIFI-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-3836: Component/s: Tools and Build > CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test > failure on Docker maven:latest > --- > > Key: NIFI-3836 > URL: https://issues.apache.org/jira/browse/NIFI-3836 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.2.0, 1.3.0 > Environment: maven:latest (b5ab9b7ecf5a) on Docker for Mac > 17.03.1-ce-mac5 (16048) >Reporter: Joey Frazee >Assignee: Andy LoPresto >Priority: Minor > Labels: permissions, test > > Running `mvn clean install` on Docker consistently fails with: > {code} > Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.65 sec <<< > FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest > testShouldNotValidateUnreadableFileBasedKeyProvider(org.apache.nifi.provenance.CryptoUtilsTest) > Time elapsed: 0.111 sec <<< FAILURE! > org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert > !unreadableKeyProviderIsValid >|| >|true >false > at > org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:402) > at > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:650) > at > org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider(CryptoUtilsTest.groovy:214) > Running org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.285 sec - > in org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Results : > Failed tests: > CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider:214 > assert !unreadableKeyProviderIsValid >|| >|true >false > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3836) CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test failure on Docker maven:latest
[ https://issues.apache.org/jira/browse/NIFI-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-3836: Status: Patch Available (was: Open) > CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test > failure on Docker maven:latest > --- > > Key: NIFI-3836 > URL: https://issues.apache.org/jira/browse/NIFI-3836 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.2.0, 1.3.0 > Environment: maven:latest (b5ab9b7ecf5a) on Docker for Mac > 17.03.1-ce-mac5 (16048) >Reporter: Joey Frazee >Priority: Minor > > Running `mvn clean install` on Docker consistently fails with: > {code} > Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.65 sec <<< > FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest > testShouldNotValidateUnreadableFileBasedKeyProvider(org.apache.nifi.provenance.CryptoUtilsTest) > Time elapsed: 0.111 sec <<< FAILURE! > org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert > !unreadableKeyProviderIsValid >|| >|true >false > at > org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:402) > at > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:650) > at > org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider(CryptoUtilsTest.groovy:214) > Running org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.285 sec - > in org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Results : > Failed tests: > CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider:214 > assert !unreadableKeyProviderIsValid >|| >|true >false > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3836) CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test failure on Docker maven:latest
[ https://issues.apache.org/jira/browse/NIFI-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-3836: Labels: permissions test (was: ) > CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test > failure on Docker maven:latest > --- > > Key: NIFI-3836 > URL: https://issues.apache.org/jira/browse/NIFI-3836 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.2.0, 1.3.0 > Environment: maven:latest (b5ab9b7ecf5a) on Docker for Mac > 17.03.1-ce-mac5 (16048) >Reporter: Joey Frazee >Assignee: Andy LoPresto >Priority: Minor > Labels: permissions, test > > Running `mvn clean install` on Docker consistently fails with: > {code} > Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.65 sec <<< > FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest > testShouldNotValidateUnreadableFileBasedKeyProvider(org.apache.nifi.provenance.CryptoUtilsTest) > Time elapsed: 0.111 sec <<< FAILURE! > org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert > !unreadableKeyProviderIsValid >|| >|true >false > at > org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:402) > at > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:650) > at > org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider(CryptoUtilsTest.groovy:214) > Running org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.285 sec - > in org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Results : > Failed tests: > CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider:214 > assert !unreadableKeyProviderIsValid >|| >|true >false > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1865: NIFI-3836 Added check for root user in test that depends o...
Github user jfrazee commented on the issue: https://github.com/apache/nifi/pull/1865 @alopresto I was expecting to see System.getProperty("user.name") used instead of the exec. But I'm a little naive about what the drawback could be; maybe because you could override it and then user.name isn't actually the user. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3836) CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test failure on Docker maven:latest
[ https://issues.apache.org/jira/browse/NIFI-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026645#comment-16026645 ] ASF GitHub Bot commented on NIFI-3836: -- Github user jfrazee commented on the issue: https://github.com/apache/nifi/pull/1865 @alopresto I was expecting to see System.getProperty("user.name") used instead of the exec. But I'm a little naive about what the drawback could be; maybe because you could override it and then user.name isn't actually the user. > CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test > failure on Docker maven:latest > --- > > Key: NIFI-3836 > URL: https://issues.apache.org/jira/browse/NIFI-3836 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.2.0, 1.3.0 > Environment: maven:latest (b5ab9b7ecf5a) on Docker for Mac > 17.03.1-ce-mac5 (16048) >Reporter: Joey Frazee >Assignee: Andy LoPresto >Priority: Minor > Labels: permissions, test > > Running `mvn clean install` on Docker consistently fails with: > {code} > Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.65 sec <<< > FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest > testShouldNotValidateUnreadableFileBasedKeyProvider(org.apache.nifi.provenance.CryptoUtilsTest) > Time elapsed: 0.111 sec <<< FAILURE! > org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert > !unreadableKeyProviderIsValid >|| >|true >false > at > org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:402) > at > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:650) > at > org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider(CryptoUtilsTest.groovy:214) > Running org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.285 sec - > in org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Results : > Failed tests: > CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider:214 > assert !unreadableKeyProviderIsValid >|| >|true >false > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (NIFI-3987) Put Expression Language Support for CSVReader Controller fixed Properties
Carlos Manuel António Fernandes created NIFI-3987: - Summary: Put Expression Language Support for CSVReader Controller fixed Properties Key: NIFI-3987 URL: https://issues.apache.org/jira/browse/NIFI-3987 Project: Apache NiFi Issue Type: Improvement Components: Core Framework Affects Versions: 1.2.0 Reporter: Carlos Manuel António Fernandes Put Expression Language Support for this properties: Value Separator, Skip Header Line,Quote Character and Escape Character This permits reusable flows based on parameters coming from others sources. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1865: NIFI-3836 Added check for root user in test that de...
Github user jfrazee commented on a diff in the pull request: https://github.com/apache/nifi/pull/1865#discussion_r118769414 --- Diff: nifi-commons/nifi-data-provenance-utils/src/test/groovy/org/apache/nifi/provenance/CryptoUtilsTest.groovy --- @@ -88,6 +88,11 @@ class CryptoUtilsTest { Cipher.getMaxAllowedKeyLength("AES") > 128 } +private static boolean isRootUser() { +Process p = Runtime.getRuntime().exec("id -u") +p.exitValue() == 0 --- End diff -- Isn't this just going to be true whenever `id -u` succeeds? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3836) CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test failure on Docker maven:latest
[ https://issues.apache.org/jira/browse/NIFI-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026680#comment-16026680 ] ASF GitHub Bot commented on NIFI-3836: -- Github user jfrazee commented on a diff in the pull request: https://github.com/apache/nifi/pull/1865#discussion_r118769414 --- Diff: nifi-commons/nifi-data-provenance-utils/src/test/groovy/org/apache/nifi/provenance/CryptoUtilsTest.groovy --- @@ -88,6 +88,11 @@ class CryptoUtilsTest { Cipher.getMaxAllowedKeyLength("AES") > 128 } +private static boolean isRootUser() { +Process p = Runtime.getRuntime().exec("id -u") +p.exitValue() == 0 --- End diff -- Isn't this just going to be true whenever `id -u` succeeds? > CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test > failure on Docker maven:latest > --- > > Key: NIFI-3836 > URL: https://issues.apache.org/jira/browse/NIFI-3836 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.2.0, 1.3.0 > Environment: maven:latest (b5ab9b7ecf5a) on Docker for Mac > 17.03.1-ce-mac5 (16048) >Reporter: Joey Frazee >Assignee: Andy LoPresto >Priority: Minor > Labels: permissions, test > > Running `mvn clean install` on Docker consistently fails with: > {code} > Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.65 sec <<< > FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest > testShouldNotValidateUnreadableFileBasedKeyProvider(org.apache.nifi.provenance.CryptoUtilsTest) > Time elapsed: 0.111 sec <<< FAILURE! > org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert > !unreadableKeyProviderIsValid >|| >|true >false > at > org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:402) > at > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:650) > at > org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider(CryptoUtilsTest.groovy:214) > Running org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.285 sec - > in org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Results : > Failed tests: > CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider:214 > assert !unreadableKeyProviderIsValid >|| >|true >false > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1575: NIFI-3572 Add PipelineXml processor to support XProc XML p...
Github user stevedlawrence commented on the issue: https://github.com/apache/nifi/pull/1575 Changes made to latest pull request: - Rebased onto latest master, and updated to 1.3.0-SNAPSHOT - Moved the pipelinexml processor out of standard bundle and into nifi-xmlcalabash-bundle - Add new Base URI option, which is needed in some cases when providing the XProc config as a string rather than a File - Minor fixes based on -Pcontrib-check Also, I've attached a template that shows a very simple use of the PipelineXML processor. It's probably not that realistic, but does show some more complicated apsects like auto detecting the output relationships based on the XProc config and dealing with XProc ports with multiple output files for a single port. The template includes a description of what it does in a bit more detail. [PipelineXML_Example.xml.zip](https://github.com/apache/nifi/files/1032779/PipelineXML_Example.xml.zip) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3572) Add a processor to support XProc XML Pipelines
[ https://issues.apache.org/jira/browse/NIFI-3572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026692#comment-16026692 ] ASF GitHub Bot commented on NIFI-3572: -- Github user stevedlawrence commented on the issue: https://github.com/apache/nifi/pull/1575 Changes made to latest pull request: - Rebased onto latest master, and updated to 1.3.0-SNAPSHOT - Moved the pipelinexml processor out of standard bundle and into nifi-xmlcalabash-bundle - Add new Base URI option, which is needed in some cases when providing the XProc config as a string rather than a File - Minor fixes based on -Pcontrib-check Also, I've attached a template that shows a very simple use of the PipelineXML processor. It's probably not that realistic, but does show some more complicated apsects like auto detecting the output relationships based on the XProc config and dealing with XProc ports with multiple output files for a single port. The template includes a description of what it does in a bit more detail. [PipelineXML_Example.xml.zip](https://github.com/apache/nifi/files/1032779/PipelineXML_Example.xml.zip) > Add a processor to support XProc XML Pipelines > -- > > Key: NIFI-3572 > URL: https://issues.apache.org/jira/browse/NIFI-3572 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Steve Lawrence > > An XProc processor was developed and submitted to the NiFi dev list: > https://mail-archives.apache.org/mod_mbox/nifi-dev/201703.mbox/%3c5d4c2d48-79de-5543-c704-27059c264...@tresys.com%3E > It would be nice if this could be pulled into NiFi. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi-minifi-cpp pull request #107: Configuration listener
GitHub user benqiu2016 opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/107 Configuration listener Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/benqiu2016/nifi-minifi-cpp configuration_listener Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/107.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #107 commit 9a4cc44671d1f492646f507c4ceb9fd63910dba8 Author: Bin Qiu Date: 2017-05-15T15:59:58Z Configuration Listener commit 0b221b9e63b54f4d5e46ad677dd8f09b374b5220 Author: Bin Qiu Date: 2017-05-20T20:44:40Z More configuration listener commit ad7a6e70f07afa60567eb9293ae22c3fc5e4411c Author: Bin Qiu Date: 2017-05-20T21:50:01Z More configuration Listener commit 1b8ffbd906f6edda9c104b7358c7af61df679b4a Author: Bin Qiu Date: 2017-05-21T15:57:47Z more listener commit 11bdd1e5d689935d78e56338cefa3e9398003831 Author: Bin Qiu Date: 2017-05-26T05:37:49Z More client auth for config listener commit e768a4c0d19aceb25784fec24ebc844fb77f449b Author: Bin Qiu Date: 2017-05-26T05:41:13Z More client auth for config listener --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1866: NIFI-3984 - upgraded version to 0.2.1
GitHub user YolandaMDavis opened a pull request: https://github.com/apache/nifi/pull/1866 NIFI-3984 - upgraded version to 0.2.1 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/YolandaMDavis/nifi NIFI-3984 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1866.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1866 commit faceb5a8b278ce59c06e5f28bf0042cd6cdd1976 Author: Yolanda M. Davis Date: 2017-05-26T17:49:24Z NIFI-3984 - upgraded version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1866: NIFI-3984 - upgraded version to 0.2.1
Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1866 @bbende can you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3984) Support secure access to HWX Schema Registry
[ https://issues.apache.org/jira/browse/NIFI-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026721#comment-16026721 ] ASF GitHub Bot commented on NIFI-3984: -- GitHub user YolandaMDavis opened a pull request: https://github.com/apache/nifi/pull/1866 NIFI-3984 - upgraded version to 0.2.1 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/YolandaMDavis/nifi NIFI-3984 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1866.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1866 commit faceb5a8b278ce59c06e5f28bf0042cd6cdd1976 Author: Yolanda M. Davis Date: 2017-05-26T17:49:24Z NIFI-3984 - upgraded version > Support secure access to HWX Schema Registry > > > Key: NIFI-3984 > URL: https://issues.apache.org/jira/browse/NIFI-3984 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Bryan Bende >Assignee: Yolanda M. Davis >Priority: Minor > > In 1.2.0 we added support for accessing the Hortonworks Schema Registry. It > looks like the next release of the schema registry will be adding support for > Kerberos authentication: > https://github.com/hortonworks/registry/issues/112 > This is a place-holder to upgrade the registry-client version on the NiFi > side when this functionality is released. > Currently we are at 0.2.0 as specified here: > https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L57 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3984) Support secure access to HWX Schema Registry
[ https://issues.apache.org/jira/browse/NIFI-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026723#comment-16026723 ] ASF GitHub Bot commented on NIFI-3984: -- Github user YolandaMDavis commented on the issue: https://github.com/apache/nifi/pull/1866 @bbende can you please review? > Support secure access to HWX Schema Registry > > > Key: NIFI-3984 > URL: https://issues.apache.org/jira/browse/NIFI-3984 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Bryan Bende >Assignee: Yolanda M. Davis >Priority: Minor > > In 1.2.0 we added support for accessing the Hortonworks Schema Registry. It > looks like the next release of the schema registry will be adding support for > Kerberos authentication: > https://github.com/hortonworks/registry/issues/112 > This is a place-holder to upgrade the registry-client version on the NiFi > side when this functionality is released. > Currently we are at 0.2.0 as specified here: > https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L57 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3984) Support secure access to HWX Schema Registry
[ https://issues.apache.org/jira/browse/NIFI-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yolanda M. Davis updated NIFI-3984: --- Status: Patch Available (was: In Progress) https://github.com/apache/nifi/pull/1866 > Support secure access to HWX Schema Registry > > > Key: NIFI-3984 > URL: https://issues.apache.org/jira/browse/NIFI-3984 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Bryan Bende >Assignee: Yolanda M. Davis >Priority: Minor > > In 1.2.0 we added support for accessing the Hortonworks Schema Registry. It > looks like the next release of the schema registry will be adding support for > Kerberos authentication: > https://github.com/hortonworks/registry/issues/112 > This is a place-holder to upgrade the registry-client version on the NiFi > side when this functionality is released. > Currently we are at 0.2.0 as specified here: > https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L57 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1865: NIFI-3836 Added check for root user in test that de...
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/1865#discussion_r118784606 --- Diff: nifi-commons/nifi-data-provenance-utils/src/test/groovy/org/apache/nifi/provenance/CryptoUtilsTest.groovy --- @@ -88,6 +88,11 @@ class CryptoUtilsTest { Cipher.getMaxAllowedKeyLength("AES") > 128 } +private static boolean isRootUser() { +Process p = Runtime.getRuntime().exec("id -u") +p.exitValue() == 0 --- End diff -- Yep, excellent catch. I'll fix it to evaluate the response, not the exit code. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3836) CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test failure on Docker maven:latest
[ https://issues.apache.org/jira/browse/NIFI-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026794#comment-16026794 ] ASF GitHub Bot commented on NIFI-3836: -- Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/1865#discussion_r118784606 --- Diff: nifi-commons/nifi-data-provenance-utils/src/test/groovy/org/apache/nifi/provenance/CryptoUtilsTest.groovy --- @@ -88,6 +88,11 @@ class CryptoUtilsTest { Cipher.getMaxAllowedKeyLength("AES") > 128 } +private static boolean isRootUser() { +Process p = Runtime.getRuntime().exec("id -u") +p.exitValue() == 0 --- End diff -- Yep, excellent catch. I'll fix it to evaluate the response, not the exit code. Thanks. > CryptoUtilsTest testShouldNotValidateUnreadableFileBasedKeyProvider test > failure on Docker maven:latest > --- > > Key: NIFI-3836 > URL: https://issues.apache.org/jira/browse/NIFI-3836 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.2.0, 1.3.0 > Environment: maven:latest (b5ab9b7ecf5a) on Docker for Mac > 17.03.1-ce-mac5 (16048) >Reporter: Joey Frazee >Assignee: Andy LoPresto >Priority: Minor > Labels: permissions, test > > Running `mvn clean install` on Docker consistently fails with: > {code} > Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.65 sec <<< > FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest > testShouldNotValidateUnreadableFileBasedKeyProvider(org.apache.nifi.provenance.CryptoUtilsTest) > Time elapsed: 0.111 sec <<< FAILURE! > org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert > !unreadableKeyProviderIsValid >|| >|true >false > at > org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:402) > at > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:650) > at > org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider(CryptoUtilsTest.groovy:214) > Running org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.285 sec - > in org.apache.nifi.provenance.AESProvenanceEventEncryptorTest > Results : > Failed tests: > CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyProvider:214 > assert !unreadableKeyProviderIsValid >|| >|true >false > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1866: NIFI-3984 - upgraded version to 0.2.1
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1866 +1 looks good, verified the 0.2.1 client is available in Maven central and brought in through the build, will merge to master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3984) Support secure access to HWX Schema Registry
[ https://issues.apache.org/jira/browse/NIFI-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026913#comment-16026913 ] ASF GitHub Bot commented on NIFI-3984: -- Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1866 +1 looks good, verified the 0.2.1 client is available in Maven central and brought in through the build, will merge to master, thanks! > Support secure access to HWX Schema Registry > > > Key: NIFI-3984 > URL: https://issues.apache.org/jira/browse/NIFI-3984 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Bryan Bende >Assignee: Yolanda M. Davis >Priority: Minor > > In 1.2.0 we added support for accessing the Hortonworks Schema Registry. It > looks like the next release of the schema registry will be adding support for > Kerberos authentication: > https://github.com/hortonworks/registry/issues/112 > This is a place-holder to upgrade the registry-client version on the NiFi > side when this functionality is released. > Currently we are at 0.2.0 as specified here: > https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L57 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3984) Support secure access to HWX Schema Registry
[ https://issues.apache.org/jira/browse/NIFI-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026916#comment-16026916 ] ASF subversion and git services commented on NIFI-3984: --- Commit dd50745a9f53982a3e53f9adbc0e1c45fb9e75bc in nifi's branch refs/heads/master from [~YolandaMDavis] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=dd50745 ] NIFI-3984 - upgraded version of schema-registry client to 0.2.1 This closes #1866. Signed-off-by: Bryan Bende > Support secure access to HWX Schema Registry > > > Key: NIFI-3984 > URL: https://issues.apache.org/jira/browse/NIFI-3984 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Bryan Bende >Assignee: Yolanda M. Davis >Priority: Minor > Fix For: 1.3.0 > > > In 1.2.0 we added support for accessing the Hortonworks Schema Registry. It > looks like the next release of the schema registry will be adding support for > Kerberos authentication: > https://github.com/hortonworks/registry/issues/112 > This is a place-holder to upgrade the registry-client version on the NiFi > side when this functionality is released. > Currently we are at 0.2.0 as specified here: > https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L57 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1866: NIFI-3984 - upgraded version to 0.2.1
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1866 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3984) Support secure access to HWX Schema Registry
[ https://issues.apache.org/jira/browse/NIFI-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026918#comment-16026918 ] ASF GitHub Bot commented on NIFI-3984: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1866 > Support secure access to HWX Schema Registry > > > Key: NIFI-3984 > URL: https://issues.apache.org/jira/browse/NIFI-3984 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Bryan Bende >Assignee: Yolanda M. Davis >Priority: Minor > Fix For: 1.3.0 > > > In 1.2.0 we added support for accessing the Hortonworks Schema Registry. It > looks like the next release of the schema registry will be adding support for > Kerberos authentication: > https://github.com/hortonworks/registry/issues/112 > This is a place-holder to upgrade the registry-client version on the NiFi > side when this functionality is released. > Currently we are at 0.2.0 as specified here: > https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L57 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3984) Support secure access to HWX Schema Registry
[ https://issues.apache.org/jira/browse/NIFI-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-3984: -- Fix Version/s: 1.3.0 > Support secure access to HWX Schema Registry > > > Key: NIFI-3984 > URL: https://issues.apache.org/jira/browse/NIFI-3984 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Bryan Bende >Assignee: Yolanda M. Davis >Priority: Minor > Fix For: 1.3.0 > > > In 1.2.0 we added support for accessing the Hortonworks Schema Registry. It > looks like the next release of the schema registry will be adding support for > Kerberos authentication: > https://github.com/hortonworks/registry/issues/112 > This is a place-holder to upgrade the registry-client version on the NiFi > side when this functionality is released. > Currently we are at 0.2.0 as specified here: > https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L57 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3984) Support secure access to HWX Schema Registry
[ https://issues.apache.org/jira/browse/NIFI-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-3984: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Support secure access to HWX Schema Registry > > > Key: NIFI-3984 > URL: https://issues.apache.org/jira/browse/NIFI-3984 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Bryan Bende >Assignee: Yolanda M. Davis >Priority: Minor > Fix For: 1.3.0 > > > In 1.2.0 we added support for accessing the Hortonworks Schema Registry. It > looks like the next release of the schema registry will be adding support for > Kerberos authentication: > https://github.com/hortonworks/registry/issues/112 > This is a place-holder to upgrade the registry-client version on the NiFi > side when this functionality is released. > Currently we are at 0.2.0 as specified here: > https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/pom.xml#L57 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1696: NIFI-1655 - Add .gitattributes to specifically define
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @jfrazee now that HL7 is out of the way, giving it another try... Will let you know when I am happy with code. Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-1655) create .gitattributes
[ https://issues.apache.org/jira/browse/NIFI-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027105#comment-16027105 ] ASF GitHub Bot commented on NIFI-1655: -- Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @jfrazee now that HL7 is out of the way, giving it another try... Will let you know when I am happy with code. Cheers > create .gitattributes > - > > Key: NIFI-1655 > URL: https://issues.apache.org/jira/browse/NIFI-1655 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Tony Kurc >Assignee: Andre F de Miranda >Priority: Minor > Labels: cross-platform, environment, git, line-endings > > Create a .gitattributes file for the repository for consistent build > environment, less dependent on individual environment settings > https://help.github.com/articles/dealing-with-line-endings/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1864: NIFI-3985: Added 'Starting Position' property to SiteToSit...
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/1864 very nice! +1 will merge to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3985) SiteToSiteProvenanceReportingTask should support starting at end of Provenance Stream or Beginning of Stream
[ https://issues.apache.org/jira/browse/NIFI-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027126#comment-16027126 ] ASF GitHub Bot commented on NIFI-3985: -- Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/1864 very nice! +1 will merge to master > SiteToSiteProvenanceReportingTask should support starting at end of > Provenance Stream or Beginning of Stream > > > Key: NIFI-3985 > URL: https://issues.apache.org/jira/browse/NIFI-3985 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > When the Site-to-Site Provenance Reporting Task is used, it always begins > sending data with the oldest event in the Provenance Repository. The > Reporting Task should support optionally starting at the most recent event as > well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1864: NIFI-3985: Added 'Starting Position' property to Si...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1864 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3985) SiteToSiteProvenanceReportingTask should support starting at end of Provenance Stream or Beginning of Stream
[ https://issues.apache.org/jira/browse/NIFI-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027132#comment-16027132 ] ASF GitHub Bot commented on NIFI-3985: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1864 > SiteToSiteProvenanceReportingTask should support starting at end of > Provenance Stream or Beginning of Stream > > > Key: NIFI-3985 > URL: https://issues.apache.org/jira/browse/NIFI-3985 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > When the Site-to-Site Provenance Reporting Task is used, it always begins > sending data with the oldest event in the Provenance Repository. The > Reporting Task should support optionally starting at the most recent event as > well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3985) SiteToSiteProvenanceReportingTask should support starting at end of Provenance Stream or Beginning of Stream
[ https://issues.apache.org/jira/browse/NIFI-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027131#comment-16027131 ] ASF subversion and git services commented on NIFI-3985: --- Commit 2b435cdfc6fd0824d9eb5f2cf140a330c9f258ed in nifi's branch refs/heads/master from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=2b435cd ] NIFI-3985: This closes #1864. Added 'Starting Position' property to SiteToSiteReportingTask; also added additionalDetails.html that explains the schema and updated the reporting task to stop publishing when the user clicks 'stops' instead of running indefinitely until the reporting task has caught up Signed-off-by: joewitt > SiteToSiteProvenanceReportingTask should support starting at end of > Provenance Stream or Beginning of Stream > > > Key: NIFI-3985 > URL: https://issues.apache.org/jira/browse/NIFI-3985 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > When the Site-to-Site Provenance Reporting Task is used, it always begins > sending data with the oldest event in the Provenance Repository. The > Reporting Task should support optionally starting at the most recent event as > well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3985) SiteToSiteProvenanceReportingTask should support starting at end of Provenance Stream or Beginning of Stream
[ https://issues.apache.org/jira/browse/NIFI-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-3985: -- Fix Version/s: 1.3.0 > SiteToSiteProvenanceReportingTask should support starting at end of > Provenance Stream or Beginning of Stream > > > Key: NIFI-3985 > URL: https://issues.apache.org/jira/browse/NIFI-3985 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > Fix For: 1.3.0 > > > When the Site-to-Site Provenance Reporting Task is used, it always begins > sending data with the oldest event in the Provenance Repository. The > Reporting Task should support optionally starting at the most recent event as > well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (NIFI-3985) SiteToSiteProvenanceReportingTask should support starting at end of Provenance Stream or Beginning of Stream
[ https://issues.apache.org/jira/browse/NIFI-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt resolved NIFI-3985. --- Resolution: Fixed > SiteToSiteProvenanceReportingTask should support starting at end of > Provenance Stream or Beginning of Stream > > > Key: NIFI-3985 > URL: https://issues.apache.org/jira/browse/NIFI-3985 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne > Fix For: 1.3.0 > > > When the Site-to-Site Provenance Reporting Task is used, it always begins > sending data with the oldest event in the Provenance Repository. The > Reporting Task should support optionally starting at the most recent event as > well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)