[jira] [Created] (NIFI-4068) Add first class support for rolling upgrades
Matt Gilman created NIFI-4068: - Summary: Add first class support for rolling upgrades Key: NIFI-4068 URL: https://issues.apache.org/jira/browse/NIFI-4068 Project: Apache NiFi Issue Type: Improvement Components: Core Framework Reporter: Matt Gilman We need to add first class support for rolling upgrades. Currently, all nodes need to be upgraded at the same time as our clustering model assumes all nodes are running the same version of the REST API and support the same data model used by that API. Based on which node is the active coordinator, it may be attempting to unmarshal a response from a newer version of NiFi. Additionally, the introduction of versioned components assumes that all nodes are running the same version of that component. This is necessary since different versions may support different properties, relationships, etc. And depending on the version of NiFi that is the active coordinator, the results to the client could vary (if they unmarshalled successfully). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-3688) Create extended groovy scripting processor
[ https://issues.apache.org/jira/browse/NIFI-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048499#comment-16048499 ] ASF GitHub Bot commented on NIFI-3688: -- Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1662 Sorry for the delay, I've been meaning to get back to this review. Unfortunately in the meantime the master branch has moved to version 1.4.0-SNAPSHOT, can you change your references from 1.3.0-SNAPSHOT to 1.4.0-SNAPSHOT and rebase against the latest master? Please and thank you! > Create extended groovy scripting processor > -- > > Key: NIFI-3688 > URL: https://issues.apache.org/jira/browse/NIFI-3688 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Dmitry Lukyanov >Priority: Minor > > The idea is to simplify groovy scripting. > Main targets: > - to be compatible with existing groovy scripting > - simplify read/write attributes > - simplify read/write content > - avoid closure casting to nifi types like `StreamCallback` > - simplify and provide visibility when accessing to controller services from > script -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi issue #1662: NIFI-3688 Extended Groovy Nifi Processor
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1662 Sorry for the delay, I've been meaning to get back to this review. Unfortunately in the meantime the master branch has moved to version 1.4.0-SNAPSHOT, can you change your references from 1.3.0-SNAPSHOT to 1.4.0-SNAPSHOT and rebase against the latest master? Please and thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-4067) Provide an interface to manually set/update the state of a processor
[ https://issues.apache.org/jira/browse/NIFI-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048346#comment-16048346 ] Pierre Villard commented on NIFI-4067: -- Yep, agree, would certainly be much easier to implement and would avoid weird situations. > Provide an interface to manually set/update the state of a processor > > > Key: NIFI-4067 > URL: https://issues.apache.org/jira/browse/NIFI-4067 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Pierre Villard > > Some processors are using a state manager and it would be useful to provide > an interface allowing a privileged used to set/update the information stored > in it. I believe some edge cases should be discussed but such an approach > would allow a flow to be deployed without the need of processing large amount > of existing data when only the newest data (generated once the workflow is > started) is required. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4067) Provide an interface to manually set/update the state of a processor
[ https://issues.apache.org/jira/browse/NIFI-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048326#comment-16048326 ] Bryan Bende commented on NIFI-4067: --- Just throwing out an alternative idea... processors that store state could offer a property to specify the initial value. In some cases this might be a toggle like "Beginning of Time vs. Current Time", or in other cases it might be an initial offset value like for a database table. This keeps it a little more restrictive to what the processor expects to store, where as arbitrarily modifying the state through the state manager could let someone set the value to anything. > Provide an interface to manually set/update the state of a processor > > > Key: NIFI-4067 > URL: https://issues.apache.org/jira/browse/NIFI-4067 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Pierre Villard > > Some processors are using a state manager and it would be useful to provide > an interface allowing a privileged used to set/update the information stored > in it. I believe some edge cases should be discussed but such an approach > would allow a flow to be deployed without the need of processing large amount > of existing data when only the newest data (generated once the workflow is > started) is required. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-106) Processor Counters should be included in the Status Reports
[ https://issues.apache.org/jira/browse/NIFI-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048288#comment-16048288 ] ASF GitHub Bot commented on NIFI-106: - Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1872 @mcgilman I pushed a new commit that addresses your concern, such that counters are included in the stats only if the user is authorized to read the processor that the counters belong to. Of note, all nodes in the cluster must also agree that counters should be shown (in case they differ in their policies). > Processor Counters should be included in the Status Reports > --- > > Key: NIFI-106 > URL: https://issues.apache.org/jira/browse/NIFI-106 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Matt Gilman >Assignee: Mark Payne >Priority: Minor > > This would allow a Processor's Status HIstory to show counters that were > maintained over time periods instead of having only a single count since > system start. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi issue #1872: NIFI-106: Expose processors' counters in Stats History
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/1872 @mcgilman I pushed a new commit that addresses your concern, such that counters are included in the stats only if the user is authorized to read the processor that the counters belong to. Of note, all nodes in the cluster must also agree that counters should be shown (in case they differ in their policies). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (NIFI-4067) Provide an interface to manually set/update the state of a processor
Pierre Villard created NIFI-4067: Summary: Provide an interface to manually set/update the state of a processor Key: NIFI-4067 URL: https://issues.apache.org/jira/browse/NIFI-4067 Project: Apache NiFi Issue Type: Improvement Reporter: Pierre Villard Some processors are using a state manager and it would be useful to provide an interface allowing a privileged used to set/update the information stored in it. I believe some edge cases should be discussed but such an approach would allow a flow to be deployed without the need of processing large amount of existing data when only the newest data (generated once the workflow is started) is required. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (NIFI-4064) Funnel with no outgoing connections and a queued Flow File uses high CPU
[ https://issues.apache.org/jira/browse/NIFI-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048137#comment-16048137 ] Wesley L Lawrence edited comment on NIFI-4064 at 6/13/17 5:25 PM: -- PR submitted through GitHub, but patch attached also. [^nifi-4064.patch] was (Author: wesleylawrence): PR submitted through GitHub, but patch attached also. > Funnel with no outgoing connections and a queued Flow File uses high CPU > > > Key: NIFI-4064 > URL: https://issues.apache.org/jira/browse/NIFI-4064 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Wesley L Lawrence >Assignee: Wesley L Lawrence >Priority: Minor > Fix For: 1.4.0 > > Attachments: FlowWithOneFileInQueue.png, nifi-4064.patch, > NifiPostEmptyLowCpu.png, NifiPreEmptyHighCpu.png, WithFixPrePostCpu.png > > > I have a simple Flow where a file containing JSON data is read, and converted > to Avro. > !FlowWithOneFileInQueue.png! > However, I have the resulting Avro container file parked in a queue going to > a Funnel, and it causes my CPU to spike. > !NifiPreEmptyHighCpu.png! > Emptying the queue causes the CPU to return to normal. > !NifiPostEmptyLowCpu.png! > It seems that in the 'ContinuallyRunConnectableTask' class, it does correctly > determine that the Funnel shouldn't be run, but since there is both a > FlowFile in queue, and a relaiton, it also decides to not yield. > I've added both a fix for this (patch to follow), as well as a new unit test > to make sure Funnels without outgoing connections get yielded. With the fix, > the CPU spiking is gone. > !WithFixPrePostCpu.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4064) Funnel with no outgoing connections and a queued Flow File uses high CPU
[ https://issues.apache.org/jira/browse/NIFI-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wesley L Lawrence updated NIFI-4064: Fix Version/s: 1.4.0 Status: Patch Available (was: In Progress) PR submitted through GitHub, but patch attached also. > Funnel with no outgoing connections and a queued Flow File uses high CPU > > > Key: NIFI-4064 > URL: https://issues.apache.org/jira/browse/NIFI-4064 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Wesley L Lawrence >Assignee: Wesley L Lawrence >Priority: Minor > Fix For: 1.4.0 > > Attachments: FlowWithOneFileInQueue.png, nifi-4064.patch, > NifiPostEmptyLowCpu.png, NifiPreEmptyHighCpu.png, WithFixPrePostCpu.png > > > I have a simple Flow where a file containing JSON data is read, and converted > to Avro. > !FlowWithOneFileInQueue.png! > However, I have the resulting Avro container file parked in a queue going to > a Funnel, and it causes my CPU to spike. > !NifiPreEmptyHighCpu.png! > Emptying the queue causes the CPU to return to normal. > !NifiPostEmptyLowCpu.png! > It seems that in the 'ContinuallyRunConnectableTask' class, it does correctly > determine that the Funnel shouldn't be run, but since there is both a > FlowFile in queue, and a relaiton, it also decides to not yield. > I've added both a fix for this (patch to follow), as well as a new unit test > to make sure Funnels without outgoing connections get yielded. With the fix, > the CPU spiking is gone. > !WithFixPrePostCpu.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (NIFI-4064) Funnel with no outgoing connections and a queued Flow File uses high CPU
[ https://issues.apache.org/jira/browse/NIFI-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wesley L Lawrence reassigned NIFI-4064: --- Assignee: Wesley L Lawrence > Funnel with no outgoing connections and a queued Flow File uses high CPU > > > Key: NIFI-4064 > URL: https://issues.apache.org/jira/browse/NIFI-4064 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Wesley L Lawrence >Assignee: Wesley L Lawrence >Priority: Minor > Attachments: FlowWithOneFileInQueue.png, nifi-4064.patch, > NifiPostEmptyLowCpu.png, NifiPreEmptyHighCpu.png, WithFixPrePostCpu.png > > > I have a simple Flow where a file containing JSON data is read, and converted > to Avro. > !FlowWithOneFileInQueue.png! > However, I have the resulting Avro container file parked in a queue going to > a Funnel, and it causes my CPU to spike. > !NifiPreEmptyHighCpu.png! > Emptying the queue causes the CPU to return to normal. > !NifiPostEmptyLowCpu.png! > It seems that in the 'ContinuallyRunConnectableTask' class, it does correctly > determine that the Funnel shouldn't be run, but since there is both a > FlowFile in queue, and a relaiton, it also decides to not yield. > I've added both a fix for this (patch to follow), as well as a new unit test > to make sure Funnels without outgoing connections get yielded. With the fix, > the CPU spiking is gone. > !WithFixPrePostCpu.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4064) Funnel with no outgoing connections and a queued Flow File uses high CPU
[ https://issues.apache.org/jira/browse/NIFI-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wesley L Lawrence updated NIFI-4064: Attachment: nifi-4064.patch > Funnel with no outgoing connections and a queued Flow File uses high CPU > > > Key: NIFI-4064 > URL: https://issues.apache.org/jira/browse/NIFI-4064 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Wesley L Lawrence >Priority: Minor > Attachments: FlowWithOneFileInQueue.png, nifi-4064.patch, > NifiPostEmptyLowCpu.png, NifiPreEmptyHighCpu.png, WithFixPrePostCpu.png > > > I have a simple Flow where a file containing JSON data is read, and converted > to Avro. > !FlowWithOneFileInQueue.png! > However, I have the resulting Avro container file parked in a queue going to > a Funnel, and it causes my CPU to spike. > !NifiPreEmptyHighCpu.png! > Emptying the queue causes the CPU to return to normal. > !NifiPostEmptyLowCpu.png! > It seems that in the 'ContinuallyRunConnectableTask' class, it does correctly > determine that the Funnel shouldn't be run, but since there is both a > FlowFile in queue, and a relaiton, it also decides to not yield. > I've added both a fix for this (patch to follow), as well as a new unit test > to make sure Funnels without outgoing connections get yielded. With the fix, > the CPU spiking is gone. > !WithFixPrePostCpu.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-1921) Average Lineage Duration stat is sometimes incorrect for cluster aggregate
[ https://issues.apache.org/jira/browse/NIFI-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048090#comment-16048090 ] ASF GitHub Bot commented on NIFI-1921: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1912 > Average Lineage Duration stat is sometimes incorrect for cluster aggregate > -- > > Key: NIFI-1921 > URL: https://issues.apache.org/jira/browse/NIFI-1921 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Minor > Fix For: 1.4.0 > > Attachments: screenshot-1.png > > > After running some data through the SplitText processor, I looked at the > Stats to see the Average Lineage Duration. While correct for each node, the > cluster aggregate was "0" which was clearly not right. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-1921) Average Lineage Duration stat is sometimes incorrect for cluster aggregate
[ https://issues.apache.org/jira/browse/NIFI-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-1921: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Average Lineage Duration stat is sometimes incorrect for cluster aggregate > -- > > Key: NIFI-1921 > URL: https://issues.apache.org/jira/browse/NIFI-1921 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Minor > Fix For: 1.4.0 > > Attachments: screenshot-1.png > > > After running some data through the SplitText processor, I looked at the > Stats to see the Average Lineage Duration. While correct for each node, the > cluster aggregate was "0" which was clearly not right. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-1921) Average Lineage Duration stat is sometimes incorrect for cluster aggregate
[ https://issues.apache.org/jira/browse/NIFI-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048089#comment-16048089 ] ASF subversion and git services commented on NIFI-1921: --- Commit c0ad5bcc7bf487c4097c7e6db77bf4e3254c0618 in nifi's branch refs/heads/master from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=c0ad5bc ] NIFI-1921: Fixed bug in how average lineage duration was calculated for cluster stat Signed-off-by: Matt Burgess This closes #1912 > Average Lineage Duration stat is sometimes incorrect for cluster aggregate > -- > > Key: NIFI-1921 > URL: https://issues.apache.org/jira/browse/NIFI-1921 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Minor > Fix For: 1.4.0 > > Attachments: screenshot-1.png > > > After running some data through the SplitText processor, I looked at the > Stats to see the Average Lineage Duration. While correct for each node, the > cluster aggregate was "0" which was clearly not right. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #1912: NIFI-1921: Fixed bug in how average lineage duratio...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1912 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-1921) Average Lineage Duration stat is sometimes incorrect for cluster aggregate
[ https://issues.apache.org/jira/browse/NIFI-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048088#comment-16048088 ] ASF GitHub Bot commented on NIFI-1921: -- Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1912 +1 LGTM (Travis failures not caused by this PR, and were fixed in a previous commit), merging to master, thanks! > Average Lineage Duration stat is sometimes incorrect for cluster aggregate > -- > > Key: NIFI-1921 > URL: https://issues.apache.org/jira/browse/NIFI-1921 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.0.0 >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Minor > Fix For: 1.4.0 > > Attachments: screenshot-1.png > > > After running some data through the SplitText processor, I looked at the > Stats to see the Average Lineage Duration. While correct for each node, the > cluster aggregate was "0" which was clearly not right. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi issue #1912: NIFI-1921: Fixed bug in how average lineage duration was c...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1912 +1 LGTM (Travis failures not caused by this PR, and were fixed in a previous commit), merging to master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (NIFI-4066) Error messages are logged incompletly
Gardella Juan Pablo created NIFI-4066:
-
Summary: Error messages are logged incompletly
Key: NIFI-4066
URL: https://issues.apache.org/jira/browse/NIFI-4066
Project: Apache NiFi
Issue Type: Bug
Components: Core Framework
Affects Versions: 1.2.0
Reporter: Gardella Juan Pablo
Priority: Minor
I saw a lot of components are not logging properly the error messages, for
example:
{noformat}
2017-06-13 11:42:45,949 ERROR [Timer-Driven Process Thread-10]
o.a.n.p.kafka.pubsub.PublishKafka_0_10
PublishKafka_0_10[id=4ecbe897-e2b0-35fa-f973-2f187172cf39]
PublishKafka_0_10[id=4ecbe897
-e2b0-35fa-f973-2f187172cf39] failed to process session due to
org.apache.kafka.common.KafkaException: Failed to construct kafka producer: {}
{noformat}
Check at the end the element '{}'. In order to sort it out, instead of passing
the throwable in the arguments as an array, it should be {{e.getMessage()}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (NIFI-4064) Funnel with no outgoing connections and a queued Flow File uses high CPU
[ https://issues.apache.org/jira/browse/NIFI-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048041#comment-16048041 ] ASF GitHub Bot commented on NIFI-4064: -- GitHub user Wesley-Lawrence opened a pull request: https://github.com/apache/nifi/pull/1914 NIFI-4064 Make sure that Funnels with queued incoming FlowFiles, but no outgoing connections yield rather than continually check to run. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [✓] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [✓] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [✓] Has your PR been rebased against the latest commit within the target branch (typically master)? - [✓] Is your initial contribution a single, squashed commit? ### For code changes: - [✓] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [✓] Have you written or updated unit tests to verify your changes? - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [N/A] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [N/A] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [N/A] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Wesley-Lawrence/nifi NIFI-4064 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1914.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1914 commit 9c479df6fe4cfcfe4c8c286dc8fe1def9a4d1714 Author: Wesley-Lawrence Date: 2017-06-13T15:34:12Z NIFI-4064 Make sure that Funnels with queued incoming FlowFiles, but no outgoing connections yield rather than continually check to run. > Funnel with no outgoing connections and a queued Flow File uses high CPU > > > Key: NIFI-4064 > URL: https://issues.apache.org/jira/browse/NIFI-4064 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Wesley L Lawrence >Priority: Minor > Attachments: FlowWithOneFileInQueue.png, NifiPostEmptyLowCpu.png, > NifiPreEmptyHighCpu.png, WithFixPrePostCpu.png > > > I have a simple Flow where a file containing JSON data is read, and converted > to Avro. > !FlowWithOneFileInQueue.png! > However, I have the resulting Avro container file parked in a queue going to > a Funnel, and it causes my CPU to spike. > !NifiPreEmptyHighCpu.png! > Emptying the queue causes the CPU to return to normal. > !NifiPostEmptyLowCpu.png! > It seems that in the 'ContinuallyRunConnectableTask' class, it does correctly > determine that the Funnel shouldn't be run, but since there is both a > FlowFile in queue, and a relaiton, it also decides to not yield. > I've added both a fix for this (patch to follow), as well as a new unit test > to make sure Funnels without outgoing connections get yielded. With the fix, > the CPU spiking is gone. > !WithFixPrePostCpu.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #1914: NIFI-4064 Make sure that Funnels with queued incomi...
GitHub user Wesley-Lawrence opened a pull request: https://github.com/apache/nifi/pull/1914 NIFI-4064 Make sure that Funnels with queued incoming FlowFiles, but no outgoing connections yield rather than continually check to run. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [â] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [â] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [â] Has your PR been rebased against the latest commit within the target branch (typically master)? - [â] Is your initial contribution a single, squashed commit? ### For code changes: - [â] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [â] Have you written or updated unit tests to verify your changes? - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [N/A] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [N/A] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [N/A] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Wesley-Lawrence/nifi NIFI-4064 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1914.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1914 commit 9c479df6fe4cfcfe4c8c286dc8fe1def9a4d1714 Author: Wesley-Lawrence Date: 2017-06-13T15:34:12Z NIFI-4064 Make sure that Funnels with queued incoming FlowFiles, but no outgoing connections yield rather than continually check to run. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (NIFI-4065) toString() method of StandardConnection provides wrong Source ID
Mark Payne created NIFI-4065: Summary: toString() method of StandardConnection provides wrong Source ID Key: NIFI-4065 URL: https://issues.apache.org/jira/browse/NIFI-4065 Project: Apache NiFi Issue Type: Bug Reporter: Mark Payne Assignee: Mark Payne Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4064) Funnel with no outgoing connections and a queued Flow File uses high CPU
[ https://issues.apache.org/jira/browse/NIFI-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wesley L Lawrence updated NIFI-4064: Description: I have a simple Flow where a file containing JSON data is read, and converted to Avro. !FlowWithOneFileInQueue.png! However, I have the resulting Avro container file parked in a queue going to a Funnel, and it causes my CPU to spike. !NifiPreEmptyHighCpu.png! Emptying the queue causes the CPU to return to normal. !NifiPostEmptyLowCpu.png! It seems that in the 'ContinuallyRunConnectableTask' class, it does correctly determine that the Funnel shouldn't be run, but since there is both a FlowFile in queue, and a relaiton, it also decides to not yield. I've added both a fix for this (patch to follow), as well as a new unit test to make sure Funnels without outgoing connections get yielded. With the fix, the CPU spiking is gone. !WithFixPrePostCpu.png! was: I have a simple Flow where a file containing JSON data is read, and converted to Avro. !FlowWithOneFileInQueue.png|thumbnail! However, I have the resulting Avro container file parked in a queue going to a Funnel, and it causes my CPU to spike. !NifiPreEmptyHighCpu.png! Emptying the queue causes the CPU to return to normal. !NifiPostEmptyLowCpu.png! It seems that in the 'ContinuallyRunConnectableTask' class, it does correctly determine that the Funnel shouldn't be run, but since there is both a FlowFile in queue, and a relaiton, it also decides to not yield. I've added both a fix for this (patch to follow), as well as a new unit test to make sure Funnels without outgoing connections get yielded. With the fix, the CPU spiking is gone. !WithFixPrePostCpu.png! > Funnel with no outgoing connections and a queued Flow File uses high CPU > > > Key: NIFI-4064 > URL: https://issues.apache.org/jira/browse/NIFI-4064 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Wesley L Lawrence >Priority: Minor > Attachments: FlowWithOneFileInQueue.png, NifiPostEmptyLowCpu.png, > NifiPreEmptyHighCpu.png, WithFixPrePostCpu.png > > > I have a simple Flow where a file containing JSON data is read, and converted > to Avro. > !FlowWithOneFileInQueue.png! > However, I have the resulting Avro container file parked in a queue going to > a Funnel, and it causes my CPU to spike. > !NifiPreEmptyHighCpu.png! > Emptying the queue causes the CPU to return to normal. > !NifiPostEmptyLowCpu.png! > It seems that in the 'ContinuallyRunConnectableTask' class, it does correctly > determine that the Funnel shouldn't be run, but since there is both a > FlowFile in queue, and a relaiton, it also decides to not yield. > I've added both a fix for this (patch to follow), as well as a new unit test > to make sure Funnels without outgoing connections get yielded. With the fix, > the CPU spiking is gone. > !WithFixPrePostCpu.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (NIFI-4064) Funnel with no outgoing connections and a queued Flow File uses high CPU
Wesley L Lawrence created NIFI-4064: --- Summary: Funnel with no outgoing connections and a queued Flow File uses high CPU Key: NIFI-4064 URL: https://issues.apache.org/jira/browse/NIFI-4064 Project: Apache NiFi Issue Type: Bug Affects Versions: 1.3.0 Reporter: Wesley L Lawrence Priority: Minor Attachments: FlowWithOneFileInQueue.png, NifiPostEmptyLowCpu.png, NifiPreEmptyHighCpu.png, WithFixPrePostCpu.png I have a simple Flow where a file containing JSON data is read, and converted to Avro. !FlowWithOneFileInQueue.png|thumbnail! However, I have the resulting Avro container file parked in a queue going to a Funnel, and it causes my CPU to spike. !NifiPreEmptyHighCpu.png! Emptying the queue causes the CPU to return to normal. !NifiPostEmptyLowCpu.png! It seems that in the 'ContinuallyRunConnectableTask' class, it does correctly determine that the Funnel shouldn't be run, but since there is both a FlowFile in queue, and a relaiton, it also decides to not yield. I've added both a fix for this (patch to follow), as well as a new unit test to make sure Funnels without outgoing connections get yielded. With the fix, the CPU spiking is gone. !WithFixPrePostCpu.png! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi pull request #1913: NIFI-3603：Localization needed
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1913#discussion_r121613477
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/bulletin-board/nf-bulletin-board.js
---
@@ -1,494 +1,494 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-/* global define, module, require, exports */
-
-(function (root, factory) {
-if (typeof define === 'function' && define.amd) {
-define(['jquery',
-'angular',
-'nf.Common',
-'nf.ng.AppConfig',
-'nf.ng.AppCtrl',
-'nf.ng.ServiceProvider',
-'nf.ng.Bridge',
-'nf.ErrorHandler',
-'nf.Storage'],
-function ($,
- angular,
- nfCommon,
- appConfig,
- appCtrl,
- serviceProvider,
- nfNgBridge,
- nfErrorHandler,
- nfStorage) {
-return (nf.ng.BulletinBoardCtrl =
-factory($,
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version
2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
--- End diff --
Is it possible to NOT make these unnecessary changes to make reviewing
easier?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1604: NIFI-3603：localization needed
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1604 This PR is superseded by #1913. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (NIFI-3603) localization needed
[
https://issues.apache.org/jira/browse/NIFI-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PetterWang updated NIFI-3603:
-
Status: Patch Available (was: Reopened)
> localization needed
> ---
>
> Key: NIFI-3603
> URL: https://issues.apache.org/jira/browse/NIFI-3603
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core UI
>Affects Versions: 1.1.0
>Reporter: PetterWang
> Labels: features
>
> JSP :
> 1.Use the JSTL standard fmt tag for multilingualization
> 1.The resource file is placed under the org.apache.nifi.web.resources
> package
> 2.Resource file name rules Messages_en.properties English resource
> file, Messages_cn.properties for Chinese resource file
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> 3.Will be around the jsp Chinese characters in accordance with message key = "canvas.about-dailog.nf-version" /> replace
> 2.In nifi-web-ui in the web.xml configuration in the following content
> specified properties file location, has been used language
>
> javax.servlet.jsp.jstl.fmt.localizationContext param-name>
> org.apache.nifi.web.resources.Messages param-value>
>
>
> javax.servlet.jsp.jstl.fmt.locale
> en
>
> 3.Add the * .properties file to the nifi-web-ui pom.xml war plugin
>
> org.apache.maven.plugins
> maven-war-plugin
>
> $ {staging.dir} /WEB-INF/web.xml
>
>
> src / main / java / org / apache /
> nifi / web / resources /
> WEB-INF / classes / org / apache
> / nifi / web / resources /
>
> *. Properties
>
> true
>
> 4.JSP page of the internationalization of the two general situation
>1. Directly replace the tag in the text content, for example: replace
> english content
> Relationships Replace with the result
>"partials.connection-details.Relationships" />
> 2.Replace the div in the attribute content, for example: replace the
> test content
>
> "partials.connection-details.configuration-tab.read-only-relationship-names-container.title"
> var = "Relationships"
>
> 3.In the jsp page to increase the fmt reference
> <% @ Taglib uri = "http://java.sun.com/jsp/jstl/fmt"; prefix =
> "fmt"%>
>4.Properties file rules
> There are two rules
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> If the text information is not unique xpath or id, you can use the
> original information to name enable-controller-service-dialog.Canceling =
> Canceling ...
> JS :
> 1.Make nf / globalization / resources.js add translation files
> 2.Global.js initialization, according to the current run of the file name and
> messsage to determine the resources to find json
> 3.Add the resources.js javascript into the war package in pif.xml for
> nifi-web-ui
>
>org.apache.maven.plugins
>maven-war-plugin
>2.5
>
>
> Js / nf / globalization / resources.js
> 4.Add a reference to resources.js in jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> bulletin-board.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / canvas.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / cluster.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / counters.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / history.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / login.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> provenance.jsp
> Modify: nifi-nar-bundles / nifi-framework-bun
[GitHub] nifi pull request #1913: NIFI-3603：Localization needed
GitHub user xijianlv opened a pull request: https://github.com/apache/nifi/pull/1913 NIFI-3603ï¼Localization needed NIFI-3603ï¼Localization needed I have completed localization changes including Chinese and English, as well as Japanese part of the localized changes, only need (1) in nifi-web-ui \ src \ main \ java add the local language properties file, and then specify it in web.xml (2) Add an array of native languages to nifi-web-ui \ src \ main \ webapp \ js \ nf \ globalization \ resources.js and point the parameter locale to it It can help NIFI developers around the world more convenient to use it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xijianlv/nifi-1 NIFI-3603 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1913.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1913 commit 2d0d09591263c0878f9c082637d6bbd7978b6c66 Author: WangJian <1925432...@qq.com> Date: 2017-03-19T01:45:11Z NIFI-3603:Updated nifi-web-ui POM to add localization files commit abf1ed3cd63b89c06945273783c7826ba6d7f9c7 Author: WangJian <1925432...@qq.com> Date: 2017-03-19T02:03:24Z NIFI-3603:Updated WEB-INF to add jstl dependencies to the jsp files and the jstl configuration in web.xml commit daa085203982d0b7d2fea71fd8856e23f5cc9839 Author: WangJian <1925432...@qq.com> Date: 2017-03-19T02:12:27Z Updated js directory to add *.js localized changes and add gloabalization directory commit 2da95e0d39d03bb0ba2596c0733071b4ceb86992 Author: WangJian <1925432...@qq.com> Date: 2017-03-19T02:13:53Z Updated js directory to add *.js localized changes and add gloabalization directory commit c55c9dfbe2761ac035ac6a5ae10161dda9d80331 Author: WangJian <1925432...@qq.com> Date: 2017-03-19T02:13:53Z NIFI-3603:Updated js directory to add *.js localized changes and add gloabalization directory commit c28f28098d91e8181460661bebc9a1254f3c6c24 Author: WangJian <1925432...@qq.com> Date: 2017-03-19T02:26:28Z Merge branch 'NIFI-3603' of https://github.com/wangrenlei/nifi-1 into NIFI-3603 commit 216d4d84d67dba21ab76264c14ee1221c8c654dc Author: WangJian <1925432...@qq.com> Date: 2017-03-19T02:33:28Z NIFI-3603:Add the *.properties file commit 60492b13c10cbab667d3b3cc2e9aaacc2a2341a2 Author: WangJian <1925432...@qq.com> Date: 2017-03-19T02:36:05Z nothing commit 5d1c68b7bde3c7601b3f4d411c14a00253bc0b05 Author: WangJian <1925432...@qq.com> Date: 2017-03-19T02:38:36Z NIFI-3603: Updated js directory to add *.js localized changes and add gloabalization directory commit bae6684551b375abcba4d2079df0a59e479f5d49 Author: WangJian <1925432...@qq.com> Date: 2017-03-19T03:09:09Z Merge branch 'master' into NIFI-3603 commit 62cf46f9f50e75b346e1e6ecada85e27e6a60db2 Author: WangJian <1925432...@qq.com> Date: 2017-03-20T09:31:40Z NIFI-3603:add the apache license in localization files commit 4189435d57926b46200570a3618a4e8fde3bac24 Author: WangJian <1925432...@qq.com> Date: 2017-03-20T09:33:05Z Merge branch 'NIFI-3603' of https://github.com/wangrenlei/nifi-1 into NIFI-3603 commit 1232ae728a21d2eb99a2a0070bbb487cd5cb6eff Author: WangJian <1925432...@qq.com> Date: 2017-03-20T10:38:32Z NIFI-3603:Modified js error commit fb9618ce09d06ed9109151d83deac84270c7dc71 Author: WangJian <1925432...@qq.com> Date: 2017-03-21T02:07:14Z NIFI-3603:Modified nf-process-group.js error commit 78369684b793302864b72ac250ec2f7835066e4d Author: WangJian <1925432...@qq.com> Date: 2017-03-21T02:23:44Z NIFI-3603:Modified port-configuration.jsp commit 08007c1203aa44039141b0962219dfec511fe1ab Author: WangJian <1925432...@qq.com> Date: 2017-03-22T09:21:34Z Merge branch 'master' into NIFI-3603 commit 7b3f456d19d50decb3f2d92ab3c35239a86446b0 Author: WangJian <1925432...@qq.com> Date: 2017-03-22T09:40:55Z NIFI-3603:Merge nf-remote-process-group-ports.js --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (NIFI-3603) localization needed
[
https://issues.apache.org/jira/browse/NIFI-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura updated NIFI-3603:
Status: Reopened (was: Reopened)
> localization needed
> ---
>
> Key: NIFI-3603
> URL: https://issues.apache.org/jira/browse/NIFI-3603
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core UI
>Affects Versions: 1.1.0
>Reporter: PetterWang
> Labels: features
>
> JSP :
> 1.Use the JSTL standard fmt tag for multilingualization
> 1.The resource file is placed under the org.apache.nifi.web.resources
> package
> 2.Resource file name rules Messages_en.properties English resource
> file, Messages_cn.properties for Chinese resource file
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> 3.Will be around the jsp Chinese characters in accordance with message key = "canvas.about-dailog.nf-version" /> replace
> 2.In nifi-web-ui in the web.xml configuration in the following content
> specified properties file location, has been used language
>
> javax.servlet.jsp.jstl.fmt.localizationContext param-name>
> org.apache.nifi.web.resources.Messages param-value>
>
>
> javax.servlet.jsp.jstl.fmt.locale
> en
>
> 3.Add the * .properties file to the nifi-web-ui pom.xml war plugin
>
> org.apache.maven.plugins
> maven-war-plugin
>
> $ {staging.dir} /WEB-INF/web.xml
>
>
> src / main / java / org / apache /
> nifi / web / resources /
> WEB-INF / classes / org / apache
> / nifi / web / resources /
>
> *. Properties
>
> true
>
> 4.JSP page of the internationalization of the two general situation
>1. Directly replace the tag in the text content, for example: replace
> english content
> Relationships Replace with the result
>"partials.connection-details.Relationships" />
> 2.Replace the div in the attribute content, for example: replace the
> test content
>
> "partials.connection-details.configuration-tab.read-only-relationship-names-container.title"
> var = "Relationships"
>
> 3.In the jsp page to increase the fmt reference
> <% @ Taglib uri = "http://java.sun.com/jsp/jstl/fmt"; prefix =
> "fmt"%>
>4.Properties file rules
> There are two rules
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> If the text information is not unique xpath or id, you can use the
> original information to name enable-controller-service-dialog.Canceling =
> Canceling ...
> JS :
> 1.Make nf / globalization / resources.js add translation files
> 2.Global.js initialization, according to the current run of the file name and
> messsage to determine the resources to find json
> 3.Add the resources.js javascript into the war package in pif.xml for
> nifi-web-ui
>
>org.apache.maven.plugins
>maven-war-plugin
>2.5
>
>
> Js / nf / globalization / resources.js
> 4.Add a reference to resources.js in jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> bulletin-board.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / canvas.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / cluster.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / counters.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / history.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / login.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> provenance.jsp
> Modify: nifi-nar-bundles / nifi-framework-bund
[jira] [Commented] (NIFI-3603) localization needed
[
https://issues.apache.org/jira/browse/NIFI-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047540#comment-16047540
]
Koji Kawamura commented on NIFI-3603:
-
[~PetterWang] I assume you closed this JIRA because you wanted to hand over
further work to [~xijianlv], please correct me if I'm wrong. In order to do so,
we can still use this same JIRA for xijianlv to create another PR. No need to
close and recreate JIRA, just closing the PR and create another PR is enough.
Thanks!
> localization needed
> ---
>
> Key: NIFI-3603
> URL: https://issues.apache.org/jira/browse/NIFI-3603
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core UI
>Affects Versions: 1.1.0
>Reporter: PetterWang
> Labels: features
>
> JSP :
> 1.Use the JSTL standard fmt tag for multilingualization
> 1.The resource file is placed under the org.apache.nifi.web.resources
> package
> 2.Resource file name rules Messages_en.properties English resource
> file, Messages_cn.properties for Chinese resource file
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> 3.Will be around the jsp Chinese characters in accordance with message key = "canvas.about-dailog.nf-version" /> replace
> 2.In nifi-web-ui in the web.xml configuration in the following content
> specified properties file location, has been used language
>
> javax.servlet.jsp.jstl.fmt.localizationContext param-name>
> org.apache.nifi.web.resources.Messages param-value>
>
>
> javax.servlet.jsp.jstl.fmt.locale
> en
>
> 3.Add the * .properties file to the nifi-web-ui pom.xml war plugin
>
> org.apache.maven.plugins
> maven-war-plugin
>
> $ {staging.dir} /WEB-INF/web.xml
>
>
> src / main / java / org / apache /
> nifi / web / resources /
> WEB-INF / classes / org / apache
> / nifi / web / resources /
>
> *. Properties
>
> true
>
> 4.JSP page of the internationalization of the two general situation
>1. Directly replace the tag in the text content, for example: replace
> english content
> Relationships Replace with the result
>"partials.connection-details.Relationships" />
> 2.Replace the div in the attribute content, for example: replace the
> test content
>
> "partials.connection-details.configuration-tab.read-only-relationship-names-container.title"
> var = "Relationships"
>
> 3.In the jsp page to increase the fmt reference
> <% @ Taglib uri = "http://java.sun.com/jsp/jstl/fmt"; prefix =
> "fmt"%>
>4.Properties file rules
> There are two rules
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> If the text information is not unique xpath or id, you can use the
> original information to name enable-controller-service-dialog.Canceling =
> Canceling ...
> JS :
> 1.Make nf / globalization / resources.js add translation files
> 2.Global.js initialization, according to the current run of the file name and
> messsage to determine the resources to find json
> 3.Add the resources.js javascript into the war package in pif.xml for
> nifi-web-ui
>
>org.apache.maven.plugins
>maven-war-plugin
>2.5
>
>
> Js / nf / globalization / resources.js
> 4.Add a reference to resources.js in jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> bulletin-board.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / canvas.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / cluster.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / counters.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / history.jsp
> Modify: nifi-nar-bundles /
[jira] [Updated] (NIFI-3603) localization needed
[
https://issues.apache.org/jira/browse/NIFI-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura updated NIFI-3603:
Status: Reopened (was: Closed)
> localization needed
> ---
>
> Key: NIFI-3603
> URL: https://issues.apache.org/jira/browse/NIFI-3603
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core UI
>Affects Versions: 1.1.0
>Reporter: PetterWang
> Labels: features
>
> JSP :
> 1.Use the JSTL standard fmt tag for multilingualization
> 1.The resource file is placed under the org.apache.nifi.web.resources
> package
> 2.Resource file name rules Messages_en.properties English resource
> file, Messages_cn.properties for Chinese resource file
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> 3.Will be around the jsp Chinese characters in accordance with message key = "canvas.about-dailog.nf-version" /> replace
> 2.In nifi-web-ui in the web.xml configuration in the following content
> specified properties file location, has been used language
>
> javax.servlet.jsp.jstl.fmt.localizationContext param-name>
> org.apache.nifi.web.resources.Messages param-value>
>
>
> javax.servlet.jsp.jstl.fmt.locale
> en
>
> 3.Add the * .properties file to the nifi-web-ui pom.xml war plugin
>
> org.apache.maven.plugins
> maven-war-plugin
>
> $ {staging.dir} /WEB-INF/web.xml
>
>
> src / main / java / org / apache /
> nifi / web / resources /
> WEB-INF / classes / org / apache
> / nifi / web / resources /
>
> *. Properties
>
> true
>
> 4.JSP page of the internationalization of the two general situation
>1. Directly replace the tag in the text content, for example: replace
> english content
> Relationships Replace with the result
>"partials.connection-details.Relationships" />
> 2.Replace the div in the attribute content, for example: replace the
> test content
>
> "partials.connection-details.configuration-tab.read-only-relationship-names-container.title"
> var = "Relationships"
>
> 3.In the jsp page to increase the fmt reference
> <% @ Taglib uri = "http://java.sun.com/jsp/jstl/fmt"; prefix =
> "fmt"%>
>4.Properties file rules
> There are two rules
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> If the text information is not unique xpath or id, you can use the
> original information to name enable-controller-service-dialog.Canceling =
> Canceling ...
> JS :
> 1.Make nf / globalization / resources.js add translation files
> 2.Global.js initialization, according to the current run of the file name and
> messsage to determine the resources to find json
> 3.Add the resources.js javascript into the war package in pif.xml for
> nifi-web-ui
>
>org.apache.maven.plugins
>maven-war-plugin
>2.5
>
>
> Js / nf / globalization / resources.js
> 4.Add a reference to resources.js in jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> bulletin-board.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / canvas.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / cluster.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / counters.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / history.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / login.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> provenance.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle
[jira] [Closed] (NIFI-3603) localization needed
[
https://issues.apache.org/jira/browse/NIFI-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PetterWang closed NIFI-3603.
closed
> localization needed
> ---
>
> Key: NIFI-3603
> URL: https://issues.apache.org/jira/browse/NIFI-3603
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core UI
>Affects Versions: 1.1.0
>Reporter: PetterWang
> Labels: features
>
> JSP :
> 1.Use the JSTL standard fmt tag for multilingualization
> 1.The resource file is placed under the org.apache.nifi.web.resources
> package
> 2.Resource file name rules Messages_en.properties English resource
> file, Messages_cn.properties for Chinese resource file
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> 3.Will be around the jsp Chinese characters in accordance with message key = "canvas.about-dailog.nf-version" /> replace
> 2.In nifi-web-ui in the web.xml configuration in the following content
> specified properties file location, has been used language
>
> javax.servlet.jsp.jstl.fmt.localizationContext param-name>
> org.apache.nifi.web.resources.Messages param-value>
>
>
> javax.servlet.jsp.jstl.fmt.locale
> en
>
> 3.Add the * .properties file to the nifi-web-ui pom.xml war plugin
>
> org.apache.maven.plugins
> maven-war-plugin
>
> $ {staging.dir} /WEB-INF/web.xml
>
>
> src / main / java / org / apache /
> nifi / web / resources /
> WEB-INF / classes / org / apache
> / nifi / web / resources /
>
> *. Properties
>
> true
>
> 4.JSP page of the internationalization of the two general situation
>1. Directly replace the tag in the text content, for example: replace
> english content
> Relationships Replace with the result
>"partials.connection-details.Relationships" />
> 2.Replace the div in the attribute content, for example: replace the
> test content
>
> "partials.connection-details.configuration-tab.read-only-relationship-names-container.title"
> var = "Relationships"
>
> 3.In the jsp page to increase the fmt reference
> <% @ Taglib uri = "http://java.sun.com/jsp/jstl/fmt"; prefix =
> "fmt"%>
>4.Properties file rules
> There are two rules
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> If the text information is not unique xpath or id, you can use the
> original information to name enable-controller-service-dialog.Canceling =
> Canceling ...
> JS :
> 1.Make nf / globalization / resources.js add translation files
> 2.Global.js initialization, according to the current run of the file name and
> messsage to determine the resources to find json
> 3.Add the resources.js javascript into the war package in pif.xml for
> nifi-web-ui
>
>org.apache.maven.plugins
>maven-war-plugin
>2.5
>
>
> Js / nf / globalization / resources.js
> 4.Add a reference to resources.js in jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> bulletin-board.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / canvas.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / cluster.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / counters.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / history.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / login.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> provenance.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / ni
[jira] [Resolved] (NIFI-3603) localization needed
[
https://issues.apache.org/jira/browse/NIFI-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PetterWang resolved NIFI-3603.
--
Resolution: Fixed
> localization needed
> ---
>
> Key: NIFI-3603
> URL: https://issues.apache.org/jira/browse/NIFI-3603
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core UI
>Affects Versions: 1.1.0
>Reporter: PetterWang
> Labels: features
>
> JSP :
> 1.Use the JSTL standard fmt tag for multilingualization
> 1.The resource file is placed under the org.apache.nifi.web.resources
> package
> 2.Resource file name rules Messages_en.properties English resource
> file, Messages_cn.properties for Chinese resource file
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> 3.Will be around the jsp Chinese characters in accordance with message key = "canvas.about-dailog.nf-version" /> replace
> 2.In nifi-web-ui in the web.xml configuration in the following content
> specified properties file location, has been used language
>
> javax.servlet.jsp.jstl.fmt.localizationContext param-name>
> org.apache.nifi.web.resources.Messages param-value>
>
>
> javax.servlet.jsp.jstl.fmt.locale
> en
>
> 3.Add the * .properties file to the nifi-web-ui pom.xml war plugin
>
> org.apache.maven.plugins
> maven-war-plugin
>
> $ {staging.dir} /WEB-INF/web.xml
>
>
> src / main / java / org / apache /
> nifi / web / resources /
> WEB-INF / classes / org / apache
> / nifi / web / resources /
>
> *. Properties
>
> true
>
> 4.JSP page of the internationalization of the two general situation
>1. Directly replace the tag in the text content, for example: replace
> english content
> Relationships Replace with the result
>"partials.connection-details.Relationships" />
> 2.Replace the div in the attribute content, for example: replace the
> test content
>
> "partials.connection-details.configuration-tab.read-only-relationship-names-container.title"
> var = "Relationships"
>
> 3.In the jsp page to increase the fmt reference
> <% @ Taglib uri = "http://java.sun.com/jsp/jstl/fmt"; prefix =
> "fmt"%>
>4.Properties file rules
> There are two rules
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> If the text information is not unique xpath or id, you can use the
> original information to name enable-controller-service-dialog.Canceling =
> Canceling ...
> JS :
> 1.Make nf / globalization / resources.js add translation files
> 2.Global.js initialization, according to the current run of the file name and
> messsage to determine the resources to find json
> 3.Add the resources.js javascript into the war package in pif.xml for
> nifi-web-ui
>
>org.apache.maven.plugins
>maven-war-plugin
>2.5
>
>
> Js / nf / globalization / resources.js
> 4.Add a reference to resources.js in jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> bulletin-board.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / canvas.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / cluster.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / counters.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / history.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / login.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> provenance.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework
[jira] [Updated] (NIFI-3603) localization needed
[
https://issues.apache.org/jira/browse/NIFI-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PetterWang updated NIFI-3603:
-
Status: Open (was: Patch Available)
> localization needed
> ---
>
> Key: NIFI-3603
> URL: https://issues.apache.org/jira/browse/NIFI-3603
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core UI
>Affects Versions: 1.1.0
>Reporter: PetterWang
> Labels: features
>
> JSP :
> 1.Use the JSTL standard fmt tag for multilingualization
> 1.The resource file is placed under the org.apache.nifi.web.resources
> package
> 2.Resource file name rules Messages_en.properties English resource
> file, Messages_cn.properties for Chinese resource file
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> 3.Will be around the jsp Chinese characters in accordance with message key = "canvas.about-dailog.nf-version" /> replace
> 2.In nifi-web-ui in the web.xml configuration in the following content
> specified properties file location, has been used language
>
> javax.servlet.jsp.jstl.fmt.localizationContext param-name>
> org.apache.nifi.web.resources.Messages param-value>
>
>
> javax.servlet.jsp.jstl.fmt.locale
> en
>
> 3.Add the * .properties file to the nifi-web-ui pom.xml war plugin
>
> org.apache.maven.plugins
> maven-war-plugin
>
> $ {staging.dir} /WEB-INF/web.xml
>
>
> src / main / java / org / apache /
> nifi / web / resources /
> WEB-INF / classes / org / apache
> / nifi / web / resources /
>
> *. Properties
>
> true
>
> 4.JSP page of the internationalization of the two general situation
>1. Directly replace the tag in the text content, for example: replace
> english content
> Relationships Replace with the result
>"partials.connection-details.Relationships" />
> 2.Replace the div in the attribute content, for example: replace the
> test content
>
> "partials.connection-details.configuration-tab.read-only-relationship-names-container.title"
> var = "Relationships"
>
> 3.In the jsp page to increase the fmt reference
> <% @ Taglib uri = "http://java.sun.com/jsp/jstl/fmt"; prefix =
> "fmt"%>
>4.Properties file rules
> There are two rules
> Bulletin-board-content-bullet-bullet-bullet-shell-content-bullet
> If the text information is not unique xpath or id, you can use the
> original information to name enable-controller-service-dialog.Canceling =
> Canceling ...
> JS :
> 1.Make nf / globalization / resources.js add translation files
> 2.Global.js initialization, according to the current run of the file name and
> messsage to determine the resources to find json
> 3.Add the resources.js javascript into the war package in pif.xml for
> nifi-web-ui
>
>org.apache.maven.plugins
>maven-war-plugin
>2.5
>
>
> Js / nf / globalization / resources.js
> 4.Add a reference to resources.js in jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> bulletin-board.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / canvas.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / cluster.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / counters.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / history.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages / login.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle / nifi-framework /
> nifi-web / nifi-web-ui / src / main / webapp / WEB-INF / pages /
> provenance.jsp
> Modify: nifi-nar-bundles / nifi-framework-bundle
[GitHub] nifi pull request #1604: NIFI-3603：localization needed
Github user wangrenlei closed the pull request at: https://github.com/apache/nifi/pull/1604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
