date:20171028

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

2017-10-28 Thread Dorian Bugeja (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dorian Bugeja updated NIFI-4540:

Attachment: (was: 
0001-NIFI-4540-Added-Validation-to-Message-Group-ID-Delay.patch)

> Support for AWS SQS FIFO message queue
> --
>
> Key: NIFI-4540
> URL: https://issues.apache.org/jira/browse/NIFI-4540
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.4.0
>Reporter: Dorian Bugeja
>  Labels: easyfix, features, newbie
> Fix For: 1.5.0
>
> Attachments: NIFI-4540-Added-MessageGroupId to AWS SQS FIFO 
> queue.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

2017-10-28 Thread Dorian Bugeja (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dorian Bugeja updated NIFI-4540:

Attachment: (was: 
0001-NIFI-4540-Added-Validation-to-Message-Group-ID-Delay.patch)

> Support for AWS SQS FIFO message queue
> --
>
> Key: NIFI-4540
> URL: https://issues.apache.org/jira/browse/NIFI-4540
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.4.0
>Reporter: Dorian Bugeja
>  Labels: easyfix, features, newbie
> Fix For: 1.5.0
>
> Attachments: NIFI-4540-Added-MessageGroupId to AWS SQS FIFO 
> queue.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

2017-10-28 Thread Dorian Bugeja (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dorian Bugeja updated NIFI-4540:

Attachment: NIFI-4540-Added-MessageGroupId to AWS SQS FIFO queue.patch

Added Support for AWS SQS FIFO queue using Message Group ID

> Support for AWS SQS FIFO message queue
> --
>
> Key: NIFI-4540
> URL: https://issues.apache.org/jira/browse/NIFI-4540
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.4.0
>Reporter: Dorian Bugeja
>  Labels: easyfix, features, newbie
> Fix For: 1.5.0
>
> Attachments: NIFI-4540-Added-MessageGroupId to AWS SQS FIFO 
> queue.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

2017-10-28 Thread Dorian Bugeja (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dorian Bugeja updated NIFI-4540:

Attachment: 0001-NIFI-4540-Added-Validation-to-Message-Group-ID-Delay.patch

> Support for AWS SQS FIFO message queue
> --
>
> Key: NIFI-4540
> URL: https://issues.apache.org/jira/browse/NIFI-4540
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.4.0
>Reporter: Dorian Bugeja
>  Labels: easyfix, features, newbie
> Fix For: 1.5.0
>
> Attachments: 
> 0001-NIFI-4540-Added-Validation-to-Message-Group-ID-Delay.patch, 
> 0001-NIFI-4540-Added-Validation-to-Message-Group-ID-Delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

2017-10-28 Thread Dorian Bugeja (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dorian Bugeja updated NIFI-4540:

Attachment: (was: 
0001-NIFI-4540-Added-Message-Group-Id-property-to-support.patch)

> Support for AWS SQS FIFO message queue
> --
>
> Key: NIFI-4540
> URL: https://issues.apache.org/jira/browse/NIFI-4540
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.4.0
>Reporter: Dorian Bugeja
>  Labels: easyfix, features, newbie
> Fix For: 1.5.0
>
> Attachments: 
> 0001-NIFI-4540-Added-Validation-to-Message-Group-ID-Delay.patch, 
> 0001-NIFI-4540-Added-Validation-to-Message-Group-ID-Delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

2017-10-28 Thread Dorian Bugeja (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dorian Bugeja updated NIFI-4540:

Attachment: 0001-NIFI-4540-Added-Validation-to-Message-Group-ID-Delay.patch

Updated patched for include validation on properties

> Support for AWS SQS FIFO message queue
> --
>
> Key: NIFI-4540
> URL: https://issues.apache.org/jira/browse/NIFI-4540
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.4.0
>Reporter: Dorian Bugeja
>  Labels: easyfix, features, newbie
> Fix For: 1.5.0
>
> Attachments: 
> 0001-NIFI-4540-Added-Message-Group-Id-property-to-support.patch, 
> 0001-NIFI-4540-Added-Validation-to-Message-Group-ID-Delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi-minifi-cpp issue #158: MINIFICPP-60: Add initial implementation of Site...

2017-10-28 Thread achristianson

Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/158
  
Nothing glaring on initial glance. There are a lot of changes. Can you 
summarize generally what the changes are for? Just want to get the right 
understanding to put it into context.


---

[jira] [Commented] (MINIFICPP-60) Support HTTP(s) as transport mechanism for Site to Site

2017-10-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223760#comment-16223760
 ] 

ASF GitHub Bot commented on MINIFICPP-60:
-

Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/158
  
Nothing glaring on initial glance. There are a lot of changes. Can you 
summarize generally what the changes are for? Just want to get the right 
understanding to put it into context.


> Support HTTP(s) as transport mechanism for Site to Site
> ---
>
> Key: MINIFICPP-60
> URL: https://issues.apache.org/jira/browse/MINIFICPP-60
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Aldrin Piri
>Assignee: marco polo
>
> The C++ implementation would benefit from having an HTTP(S) implementation of 
> Site to Site as was described in  
> https://cwiki.apache.org/confluence/display/NIFI/Support+HTTP(S)+as+a+transport+mechanism+for+Site-to-Site
>  and performed in NIFI-1857



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MINIFICPP-201) Support Site2Site Server Protocol

2017-10-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223759#comment-16223759
 ] 

ASF GitHub Bot commented on MINIFICPP-201:
--

Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/157
  
There are a few clang-tidy issues that come up, which are mostly valid if 
minor.

Other than that, looks good to me.


> Support Site2Site Server Protocol
> -
>
> Key: MINIFICPP-201
> URL: https://issues.apache.org/jira/browse/MINIFICPP-201
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 0.1.0
>Reporter: bqiu
>Assignee: bqiu
> Fix For: 0.2.0
>
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi-minifi-cpp issue #157: MINIFI-269 Implement ApplyTemplate processor

2017-10-28 Thread achristianson

Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/157
  
There are a few clang-tidy issues that come up, which are mostly valid if 
minor.

Other than that, looks good to me.


---

[jira] [Commented] (MINIFICPP-201) Support Site2Site Server Protocol

2017-10-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223756#comment-16223756
 ] 

ASF GitHub Bot commented on MINIFICPP-201:
--

Github user achristianson commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/157#discussion_r147565661
  
--- Diff: libminifi/test/bustache-tests/ApplyTemplateTests.cpp ---
@@ -0,0 +1,131 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#define CATCH_CONFIG_MAIN  // This tells Catch to provide a main() - only 
do this in one cpp file
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "../TestBase.h"
+#include "core/Core.h"
+
+#include "core/FlowFile.h"
+#include "core/Processor.h"
+#include "core/ProcessContext.h"
+#include "core/ProcessSession.h"
+#include "core/ProcessorNode.h"
+
+#include "ApplyTemplate.h"
+#include "processors/GetFile.h"
+#include "processors/ExtractText.h"
+
+const char* TEMPLATE = "TemplateBegins\n{{ ExampleAttribute 
}}\nTemplateEnds";
+const char* TEMPLATE_FILE = "test_template.txt";
+const char* TEST_ATTR = "ExampleAttribute";
+const char* TEST_VALUE = "ExampleValue";
+const char* TEST_FILE = "test_file.txt";
+const char* EXPECT_OUTPUT = "TemplateBegins\nExampleValue\nTemplateEnds";
+
+TEST_CASE("Test Creation of ApplyTemplate", "[ApplyTemplateCreate]") {
+TestController testController;
+std::shared_ptr processor = 
std::make_shared("processorname");
+REQUIRE(processor->getName() == "processorname");
+uuid_t processoruuid;
+REQUIRE(true == processor->getUUID(processoruuid));
+}
+
+TEST_CASE("Test usage of ApplyTemplate", "[ApplyTemplateTest]") {
+TestController testController;
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
+std::shared_ptr plan = testController.createPlan();
+std::shared_ptr repo = 
std::make_shared();
+
+char dir1[] = "/tmp/gt.XX";  // GetFile source
+char dir2[] = "/tmp/gt.XX";  // Template source
+char dir3[] = "/tmp/gt.XX";  // PutFile destionation
+
+REQUIRE(testController.createTempDirectory(dir1) != nullptr);
+REQUIRE(testController.createTempDirectory(dir2) != nullptr);
+REQUIRE(testController.createTempDirectory(dir3) != nullptr);
+
+std::shared_ptr getfile = 
plan->addProcessor("GetFile", "getFile");
+plan->setProperty(getfile, 
org::apache::nifi::minifi::processors::GetFile::Directory.getName(), dir1);
+plan->setProperty(getfile, 
org::apache::nifi::minifi::processors::GetFile::KeepSourceFile.getName(), 
"true");
+
+std::shared_ptr maprocessor = 
plan->addProcessor("ExtractText", "testExtractText", 
core::Relationship("success", "description"), true);
+plan->setProperty(maprocessor, 
org::apache::nifi::minifi::processors::ExtractText::Attribute.getName(), 
TEST_ATTR);
+
+std::shared_ptr atprocessor = 
plan->addProcessor("ApplyTemplate", "testApplyTemplate", 
core::Relationship("success", "description"), true);
+
+std::shared_ptr putfile = 
plan->addProcessor("PutFile", "putfile", core::Relationship("success", 
"description"), true);
+plan->setProperty(putfile, 
org::apache::nifi::minifi::processors::PutFile::Directory.getName(), dir3);
+plan->setProperty(putfile, 
org::apache::nifi::minifi::processors::PutFile::ConflictResolution.getName(),
+

[jira] [Commented] (MINIFICPP-201) Support Site2Site Server Protocol

2017-10-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223755#comment-16223755
 ] 

ASF GitHub Bot commented on MINIFICPP-201:
--

Github user achristianson commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/157#discussion_r147565654
  
--- Diff: libminifi/test/bustache-tests/ApplyTemplateTests.cpp ---
@@ -0,0 +1,131 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#define CATCH_CONFIG_MAIN  // This tells Catch to provide a main() - only 
do this in one cpp file
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "../TestBase.h"
+#include "core/Core.h"
+
+#include "core/FlowFile.h"
+#include "core/Processor.h"
+#include "core/ProcessContext.h"
+#include "core/ProcessSession.h"
+#include "core/ProcessorNode.h"
+
+#include "ApplyTemplate.h"
+#include "processors/GetFile.h"
+#include "processors/ExtractText.h"
+
+const char* TEMPLATE = "TemplateBegins\n{{ ExampleAttribute 
}}\nTemplateEnds";
+const char* TEMPLATE_FILE = "test_template.txt";
+const char* TEST_ATTR = "ExampleAttribute";
+const char* TEST_VALUE = "ExampleValue";
+const char* TEST_FILE = "test_file.txt";
+const char* EXPECT_OUTPUT = "TemplateBegins\nExampleValue\nTemplateEnds";
+
+TEST_CASE("Test Creation of ApplyTemplate", "[ApplyTemplateCreate]") {
+TestController testController;
+std::shared_ptr processor = 
std::make_shared("processorname");
+REQUIRE(processor->getName() == "processorname");
+uuid_t processoruuid;
+REQUIRE(true == processor->getUUID(processoruuid));
--- End diff --

Minor nit: simplify to `REQUIRE(processor->getUUID(processoruuid));`


> Support Site2Site Server Protocol
> -
>
> Key: MINIFICPP-201
> URL: https://issues.apache.org/jira/browse/MINIFICPP-201
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 0.1.0
>Reporter: bqiu
>Assignee: bqiu
> Fix For: 0.2.0
>
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi-minifi-cpp pull request #157: MINIFI-269 Implement ApplyTemplate proces...

2017-10-28 Thread achristianson

Github user achristianson commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/157#discussion_r147565661
  
--- Diff: libminifi/test/bustache-tests/ApplyTemplateTests.cpp ---
@@ -0,0 +1,131 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#define CATCH_CONFIG_MAIN  // This tells Catch to provide a main() - only 
do this in one cpp file
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "../TestBase.h"
+#include "core/Core.h"
+
+#include "core/FlowFile.h"
+#include "core/Processor.h"
+#include "core/ProcessContext.h"
+#include "core/ProcessSession.h"
+#include "core/ProcessorNode.h"
+
+#include "ApplyTemplate.h"
+#include "processors/GetFile.h"
+#include "processors/ExtractText.h"
+
+const char* TEMPLATE = "TemplateBegins\n{{ ExampleAttribute 
}}\nTemplateEnds";
+const char* TEMPLATE_FILE = "test_template.txt";
+const char* TEST_ATTR = "ExampleAttribute";
+const char* TEST_VALUE = "ExampleValue";
+const char* TEST_FILE = "test_file.txt";
+const char* EXPECT_OUTPUT = "TemplateBegins\nExampleValue\nTemplateEnds";
+
+TEST_CASE("Test Creation of ApplyTemplate", "[ApplyTemplateCreate]") {
+TestController testController;
+std::shared_ptr processor = 
std::make_shared("processorname");
+REQUIRE(processor->getName() == "processorname");
+uuid_t processoruuid;
+REQUIRE(true == processor->getUUID(processoruuid));
+}
+
+TEST_CASE("Test usage of ApplyTemplate", "[ApplyTemplateTest]") {
+TestController testController;
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
LogTestController::getInstance().setTrace();
+
+std::shared_ptr plan = testController.createPlan();
+std::shared_ptr repo = 
std::make_shared();
+
+char dir1[] = "/tmp/gt.XX";  // GetFile source
+char dir2[] = "/tmp/gt.XX";  // Template source
+char dir3[] = "/tmp/gt.XX";  // PutFile destionation
+
+REQUIRE(testController.createTempDirectory(dir1) != nullptr);
+REQUIRE(testController.createTempDirectory(dir2) != nullptr);
+REQUIRE(testController.createTempDirectory(dir3) != nullptr);
+
+std::shared_ptr getfile = 
plan->addProcessor("GetFile", "getFile");
+plan->setProperty(getfile, 
org::apache::nifi::minifi::processors::GetFile::Directory.getName(), dir1);
+plan->setProperty(getfile, 
org::apache::nifi::minifi::processors::GetFile::KeepSourceFile.getName(), 
"true");
+
+std::shared_ptr maprocessor = 
plan->addProcessor("ExtractText", "testExtractText", 
core::Relationship("success", "description"), true);
+plan->setProperty(maprocessor, 
org::apache::nifi::minifi::processors::ExtractText::Attribute.getName(), 
TEST_ATTR);
+
+std::shared_ptr atprocessor = 
plan->addProcessor("ApplyTemplate", "testApplyTemplate", 
core::Relationship("success", "description"), true);
+
+std::shared_ptr putfile = 
plan->addProcessor("PutFile", "putfile", core::Relationship("success", 
"description"), true);
+plan->setProperty(putfile, 
org::apache::nifi::minifi::processors::PutFile::Directory.getName(), dir3);
+plan->setProperty(putfile, 
org::apache::nifi::minifi::processors::PutFile::ConflictResolution.getName(),
+  
org::apache::nifi::minifi::processors::PutFile::CONFLICT_RESOLUTION_STRATEGY_REPLACE);
+
+// Write attribute value to file for GetFile->ExtractText
+std::stringstream ss1;
+ss1 << dir1 << "/" << TEST_FILE;
+std::string test_path =

[GitHub] nifi-minifi-cpp pull request #157: MINIFI-269 Implement ApplyTemplate proces...

2017-10-28 Thread achristianson

Github user achristianson commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/157#discussion_r147565654
  
--- Diff: libminifi/test/bustache-tests/ApplyTemplateTests.cpp ---
@@ -0,0 +1,131 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#define CATCH_CONFIG_MAIN  // This tells Catch to provide a main() - only 
do this in one cpp file
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "../TestBase.h"
+#include "core/Core.h"
+
+#include "core/FlowFile.h"
+#include "core/Processor.h"
+#include "core/ProcessContext.h"
+#include "core/ProcessSession.h"
+#include "core/ProcessorNode.h"
+
+#include "ApplyTemplate.h"
+#include "processors/GetFile.h"
+#include "processors/ExtractText.h"
+
+const char* TEMPLATE = "TemplateBegins\n{{ ExampleAttribute 
}}\nTemplateEnds";
+const char* TEMPLATE_FILE = "test_template.txt";
+const char* TEST_ATTR = "ExampleAttribute";
+const char* TEST_VALUE = "ExampleValue";
+const char* TEST_FILE = "test_file.txt";
+const char* EXPECT_OUTPUT = "TemplateBegins\nExampleValue\nTemplateEnds";
+
+TEST_CASE("Test Creation of ApplyTemplate", "[ApplyTemplateCreate]") {
+TestController testController;
+std::shared_ptr processor = 
std::make_shared("processorname");
+REQUIRE(processor->getName() == "processorname");
+uuid_t processoruuid;
+REQUIRE(true == processor->getUUID(processoruuid));
--- End diff --

Minor nit: simplify to `REQUIRE(processor->getUUID(processoruuid));`


---

[jira] [Commented] (MINIFICPP-201) Support Site2Site Server Protocol

2017-10-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223744#comment-16223744
 ] 

ASF GitHub Bot commented on MINIFICPP-201:
--

Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/157
  
The code looks very clean and straightforward. Great work.

I can definitely see the utility in such a processor for efficiently 
generating arbitrary textual formats from structured inputs.

I will build and test this and get back to you if I notice any issues.


> Support Site2Site Server Protocol
> -
>
> Key: MINIFICPP-201
> URL: https://issues.apache.org/jira/browse/MINIFICPP-201
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 0.1.0
>Reporter: bqiu
>Assignee: bqiu
> Fix For: 0.2.0
>
>
> Support Site2Site Server Protocol
> Now CPP site2Site only support client side.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi-minifi-cpp issue #157: MINIFI-269 Implement ApplyTemplate processor

2017-10-28 Thread achristianson

Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/157
  
The code looks very clean and straightforward. Great work.

I can definitely see the utility in such a processor for efficiently 
generating arbitrary textual formats from structured inputs.

I will build and test this and get back to you if I notice any issues.


---

[jira] [Created] (NIFI-4541) Variables can not be used for connection string in RedisConnectionPoolService

2017-10-28 Thread Uwe Geercken (JIRA)

Uwe Geercken created NIFI-4541:
--

 Summary: Variables can not be used for connection string in 
RedisConnectionPoolService
 Key: NIFI-4541
 URL: https://issues.apache.org/jira/browse/NIFI-4541
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core Framework
Affects Versions: 1.4.0
 Environment: Fedora 26, Nifi 1.4.0
Reporter: Uwe Geercken
Priority: Minor


The controller service RedisConnectionPoolService is not accpting variables for 
the connection string field.

Steps:
1) Create a variable on the Nifi Flow level named "redis.server" with the value 
of "localhost:6379"
2) Create a new controller service on the Nifi Flow level: 
RedisConnectionPoolService
3) As connection string enter "${redis.server}

Result:
When the configuration dialog is closed an error is displayed: 'Connection 
String' is invalid because Connection String cannot be blank

When the value "localhost:6379" is entered directly in the connection string 
field of the service controller, it does work correctly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MINIFICPP-267) MiNiFiMain crashes and fails to infer MINIFI_HOME if MINIFI_HOME not set

2017-10-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223486#comment-16223486
 ] 

ASF GitHub Bot commented on MINIFICPP-267:
--

Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/155
  
I'll get this merged ASAP.


> MiNiFiMain crashes and fails to infer MINIFI_HOME if MINIFI_HOME not set
> 
>
> Key: MINIFICPP-267
> URL: https://issues.apache.org/jira/browse/MINIFICPP-267
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>Priority: Minor
>
> When launching minifi cmd direcly without setting MINIFI_HOME, minifi tries 
> to infer MINIFI_HOME based on the exe path. This crashes the minifi (CentOS 
> 7.4).
> {code}
> [main] [info] MINIFI_HOME was not found, determining based on executable path.
> terminate called after throwing an instance of 'std::logic_error'
>   what():  basic_string::_S_construct null not valid
> Aborted (core dumped)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MINIFICPP-271) Unncessary Boost dependency in ProcessSession.h

2017-10-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223485#comment-16223485
 ] 

ASF GitHub Bot commented on MINIFICPP-271:
--

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/159#discussion_r147553895
  
--- Diff: libminifi/include/core/ProcessSession.h ---
@@ -19,7 +19,6 @@
 #define __PROCESS_SESSION_H__
 
 #include 
-#include 
--- End diff --

@dtrodrigues thanks for this. I think I let this slip through in a PR 
despite trying to eliminate boost for those that don't want it. Thanks for 
catching this and the contribution. I'll get this merged. 


> Unncessary Boost dependency in ProcessSession.h
> ---
>
> Key: MINIFICPP-271
> URL: https://issues.apache.org/jira/browse/MINIFICPP-271
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: Dustin Rodrigues
>
> There's an unnecessary header file included for Boost in ProcessSession.h 
> causing build errors on OSX.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi-minifi-cpp issue #155: MINIFICPP-267 Make inference of MINIFI_HOME more...

2017-10-28 Thread phrocker

Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/155
  
I'll get this merged ASAP.


---

[GitHub] nifi-minifi-cpp pull request #159: MINIFICPP-271: Remove unncessary Boost he...

2017-10-28 Thread phrocker

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/159#discussion_r147553895
  
--- Diff: libminifi/include/core/ProcessSession.h ---
@@ -19,7 +19,6 @@
 #define __PROCESS_SESSION_H__
 
 #include 
-#include 
--- End diff --

@dtrodrigues thanks for this. I think I let this slip through in a PR 
despite trying to eliminate boost for those that don't want it. Thanks for 
catching this and the contribution. I'll get this merged. 


---

[jira] [Commented] (NIFI-4080) ValidateCSV - Add support for Expression Language

2017-10-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223411#comment-16223411
 ] 

ASF GitHub Bot commented on NIFI-4080:
--

Github user patricker commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2226#discussion_r147551737
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java
 ---
@@ -227,9 +231,9 @@ public void setPreference(final ProcessContext context) 
{
 // input is transferred over to Java as is. So when you type the 
characters "\"
 // and "n" into the UI the Java string will end up being those two 
characters
 // not the interpreted value "\n".
-final String msgDemarcator = 
context.getProperty(END_OF_LINE_CHARACTER).getValue().replace("\\n", 
"\n").replace("\\r", "\r").replace("\\t", "\t");
-this.preference.set(new 
CsvPreference.Builder(context.getProperty(QUOTE_CHARACTER).getValue().charAt(0),
-
context.getProperty(DELIMITER_CHARACTER).getValue().charAt(0), 
msgDemarcator).build());
+final String msgDemarcator = 
context.getProperty(END_OF_LINE_CHARACTER).evaluateAttributeExpressions().getValue().replace("\\n",
 "\n").replace("\\r", "\r").replace("\\t", "\t");
+this.preference.set(new 
CsvPreference.Builder(context.getProperty(QUOTE_CHARACTER).evaluateAttributeExpressions().getValue().charAt(0),
+
context.getProperty(DELIMITER_CHARACTER).evaluateAttributeExpressions().getValue().charAt(0),
 msgDemarcator).build());
--- End diff --

No concerns.


> ValidateCSV - Add support for Expression Language 
> --
>
> Key: NIFI-4080
> URL: https://issues.apache.org/jira/browse/NIFI-4080
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>
> The ValidateCSV processor could benefit if the following fields supported 
> Expression Language evaluation:
> - Schema
> - Quote character
> - Delimiter character
> - End of line symbols



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi pull request #2226: NIFI-4080: Added EL support to fields in ValidateCS...

2017-10-28 Thread patricker

Github user patricker commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2226#discussion_r147551737
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java
 ---
@@ -227,9 +231,9 @@ public void setPreference(final ProcessContext context) 
{
 // input is transferred over to Java as is. So when you type the 
characters "\"
 // and "n" into the UI the Java string will end up being those two 
characters
 // not the interpreted value "\n".
-final String msgDemarcator = 
context.getProperty(END_OF_LINE_CHARACTER).getValue().replace("\\n", 
"\n").replace("\\r", "\r").replace("\\t", "\t");
-this.preference.set(new 
CsvPreference.Builder(context.getProperty(QUOTE_CHARACTER).getValue().charAt(0),
-
context.getProperty(DELIMITER_CHARACTER).getValue().charAt(0), 
msgDemarcator).build());
+final String msgDemarcator = 
context.getProperty(END_OF_LINE_CHARACTER).evaluateAttributeExpressions().getValue().replace("\\n",
 "\n").replace("\\r", "\r").replace("\\t", "\t");
+this.preference.set(new 
CsvPreference.Builder(context.getProperty(QUOTE_CHARACTER).evaluateAttributeExpressions().getValue().charAt(0),
+
context.getProperty(DELIMITER_CHARACTER).evaluateAttributeExpressions().getValue().charAt(0),
 msgDemarcator).build());
--- End diff --

No concerns.


---

[jira] [Assigned] (NIFI-4400) Advanced UI with code editor for scripted processors

2017-10-28 Thread Yuri (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yuri reassigned NIFI-4400:
--

Assignee: Yuri

> Advanced UI with code editor for scripted processors
> 
>
> Key: NIFI-4400
> URL: https://issues.apache.org/jira/browse/NIFI-4400
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI, Extensions
>Reporter: Pierre Villard
>Assignee: Yuri
>
> For the scripted processors it would nice to add an advanced UI with a "code 
> editor mode" that would provide some very useful features when typing code:
> - indentation
> - code highlighting
> - do not close the window when hitting enter
> etc
> The use of codemirror.js (as already done for EL auto-completion) sounds like 
> a good option.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi-minifi-cpp pull request #159: remove unncessary Boost header dependency...

2017-10-28 Thread dtrodrigues

GitHub user dtrodrigues opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/159

remove unncessary Boost header dependency from core

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-271

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #159


commit 481c4268710fa92db21951a8393025e6e75c6b12
Author: Dustin Rodrigues 
Date:   2017-10-28T06:28:40Z

remove unncessary Boost header dependency from core




---

[jira] [Created] (MINIFICPP-271) Unncessary Boost dependency in ProcessSession.h

2017-10-28 Thread Dustin Rodrigues (JIRA)

Dustin Rodrigues created MINIFICPP-271:
--

 Summary: Unncessary Boost dependency in ProcessSession.h
 Key: MINIFICPP-271
 URL: https://issues.apache.org/jira/browse/MINIFICPP-271
 Project: NiFi MiNiFi C++
  Issue Type: Bug
Reporter: Dustin Rodrigues


There's an unnecessary header file included for Boost in ProcessSession.h 
causing build errors on OSX.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

2017-10-28 Thread Dorian Bugeja (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dorian Bugeja updated NIFI-4540:

Labels: easyfix features newbie  (was: )
Status: Patch Available  (was: Open)

Added Message Group Id to flow-file for AWS SQS FIFO queues.

> Support for AWS SQS FIFO message queue
> --
>
> Key: NIFI-4540
> URL: https://issues.apache.org/jira/browse/NIFI-4540
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.4.0
>Reporter: Dorian Bugeja
>  Labels: easyfix, newbie, features
> Fix For: 1.5.0
>
> Attachments: 
> 0001-NIFI-4540-Added-Message-Group-Id-property-to-support.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (NIFI-4540) Support for AWS SQS FIFO message queue

2017-10-28 Thread Dorian Bugeja (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223277#comment-16223277
 ] 

Dorian Bugeja edited comment on NIFI-4540 at 10/28/17 6:22 AM:
---

Added support for AWS SQS FIFO queue by supplying the required Message Group Id 
on which the message should be ordered. The delay attribute cannot be used with 
FIFO message so the default value from AWS SDK is used.


was (Author: sunsation):
Added support for AWS SQS FIFO queue by supplying the required Message Group Id 
on which the file should be ordered. The delay attribute cannot be used with 
FIFO message so the default value from AWS SDK is used.

> Support for AWS SQS FIFO message queue
> --
>
> Key: NIFI-4540
> URL: https://issues.apache.org/jira/browse/NIFI-4540
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.4.0
>Reporter: Dorian Bugeja
> Fix For: 1.5.0
>
> Attachments: 
> 0001-NIFI-4540-Added-Message-Group-Id-property-to-support.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

2017-10-28 Thread Dorian Bugeja (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dorian Bugeja updated NIFI-4540:

Attachment: 0001-NIFI-4540-Added-Message-Group-Id-property-to-support.patch

Added support for AWS SQS FIFO queue by supplying the required Message Group Id 
on which the file should be ordered. The delay attribute cannot be used with 
FIFO message so the default value from AWS SDK is used.

> Support for AWS SQS FIFO message queue
> --
>
> Key: NIFI-4540
> URL: https://issues.apache.org/jira/browse/NIFI-4540
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.4.0
>Reporter: Dorian Bugeja
> Fix For: 1.5.0
>
> Attachments: 
> 0001-NIFI-4540-Added-Message-Group-Id-property-to-support.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (NIFI-4539) ExtractGrok - Add support returning only named captures

2017-10-28 Thread Norito Agetsuma (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norito Agetsuma updated NIFI-4539:
--
Status: Patch Available  (was: Open)

https://github.com/apache/nifi/pull/2233

> ExtractGrok - Add support returning only named captures
> ---
>
> Key: NIFI-4539
> URL: https://issues.apache.org/jira/browse/NIFI-4539
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Norito Agetsuma
>
> ExtractGrok support named captures only option.
> Currently, ExtractGrok returns all matches for a grok pattern. In some case, 
> this is verbose.
> Following example parse apache common access log.
> {noformat}
> 83.149.9.216 - - [17/May/2015:10:05:03 +] "GET 
> /presentations/logstash-monitorama-2013/images/kibana-search.png HTTP/1.1" 
> 200 203023 "http://semicomplete.com/presentations/logstash-monitorama-2013/; 
> "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_1) AppleWebKit/537.36 (KHTML, 
> like Gecko) Chrome/32.0.1700.77 Safari/537.36
> {noformat}
> Disable named captures only
> {noformat}
> {
>   "grok.auth": "-",
>   "grok.timestamp": "17/May/2015:10:05:03 +",
>   "grok.httpversion": "1.1",
>   "grok.HOUR": "10",
>   "grok.ident": "-",
>   "grok.SECOND": "03",
>   "grok.HTTPD_COMMONLOG": "83.149.9.216 - - [17/May/2015:10:05:03 +] 
> \"GET /presentations/logstash-monitorama-2013/images/kibana-search.png 
> HTTP/1.1\" 200 203023",
>   "grok.USERNAME": "[-, -]",
>   "grok.IP": "83.149.9.216",
>   "grok.clientip": "83.149.9.216",
>   "grok.verb": "GET",
>   "grok.EMAILADDRESS": "[null, null]",
>   "grok.request": 
> "/presentations/logstash-monitorama-2013/images/kibana-search.png",
>   "grok.EMAILLOCALPART": "[null, null]",
>   "grok.INT": "+",
>   "grok.BASE10NUM": "[1.1, 200, 203023]",
>   "grok.YEAR": "2015",
>   "grok.IPV4": "83.149.9.216",
>   "grok.MINUTE": "05",
>   "grok.HOSTNAME": "[null, null, null]",
>   "grok.USER": "[-, -]",
>   "grok.response": "200",
>   "grok.bytes": "203023",
>   "grok.TIME": "10:05:03",
>   "grok.MONTH": "May",
>   "grok.MONTHDAY": "17"
> }
> {noformat}
> Enable named captures only
> {noformat}
> {
>   "grok.request": 
> "/presentations/logstash-monitorama-2013/images/kibana-search.png",
>   "grok.auth": "-",
>   "grok.ident": "-",
>   "grok.timestamp": "17/May/2015:10:05:03 +",
>   "grok.httpversion": "1.1",
>   "grok.clientip": "83.149.9.216",
>   "grok.response": "200",
>   "grok.bytes": "203023",
>   "grok.verb": "GET"
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4539) ExtractGrok - Add support returning only named captures

2017-10-28 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223273#comment-16223273
 ] 

ASF GitHub Bot commented on NIFI-4539:
--

GitHub user n-agetsu opened a pull request:

https://github.com/apache/nifi/pull/2233

NIFI-4539 ExtractGrok - Add support returning only named captures

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/n-agetsu/nifi NIFI-4539

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2233


commit 51ad5d4c6c94f5ba0c7d462f2200a8fd25c5e43e
Author: Norito Agetsuma 
Date:   2017-10-28T05:20:34Z

NIFI-4539 ExtractGrok - Add support returning only named captures




> ExtractGrok - Add support returning only named captures
> ---
>
> Key: NIFI-4539
> URL: https://issues.apache.org/jira/browse/NIFI-4539
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.4.0
>Reporter: Norito Agetsuma
>
> ExtractGrok support named captures only option.
> Currently, ExtractGrok returns all matches for a grok pattern. In some case, 
> this is verbose.
> Following example parse apache common access log.
> {noformat}
> 83.149.9.216 - - [17/May/2015:10:05:03 +] "GET 
> /presentations/logstash-monitorama-2013/images/kibana-search.png HTTP/1.1" 
> 200 203023 "http://semicomplete.com/presentations/logstash-monitorama-2013/; 
> "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_1) AppleWebKit/537.36 (KHTML, 
> like Gecko) Chrome/32.0.1700.77 Safari/537.36
> {noformat}
> Disable named captures only
> {noformat}
> {
>   "grok.auth": "-",
>   "grok.timestamp": "17/May/2015:10:05:03 +",
>   "grok.httpversion": "1.1",
>   "grok.HOUR": "10",
>   "grok.ident": "-",
>   "grok.SECOND": "03",
>   "grok.HTTPD_COMMONLOG": "83.149.9.216 - - [17/May/2015:10:05:03 +] 
> \"GET /presentations/logstash-monitorama-2013/images/kibana-search.png 
> HTTP/1.1\" 200 203023",
>   "grok.USERNAME": "[-, -]",
>   "grok.IP": "83.149.9.216",
>   "grok.clientip": "83.149.9.216",
>   "grok.verb": "GET",
>   "grok.EMAILADDRESS": "[null, null]",
>   "grok.request": 
> "/presentations/logstash-monitorama-2013/images/kibana-search.png",
>   "grok.EMAILLOCALPART": "[null, null]",
>   "grok.INT": "+",
>   "grok.BASE10NUM": "[1.1, 200, 203023]",
>   "grok.YEAR": "2015",
>   "grok.IPV4": "83.149.9.216",
>   "grok.MINUTE": "05",
>   "grok.HOSTNAME": "[null, null, null]",
>   "grok.USER": "[-, -]",
>   "grok.response": "200",
>   "grok.bytes": "203023",
>   "grok.TIME": "10:05:03",
>   "grok.MONTH": "May",
>   "grok.MONTHDAY": "17"
> }
> {noformat}
> Enable named captures only
> {noformat}
> {
>   "grok.request": 
> "/presentations/logstash-monitorama-2013/images/kibana-search.png",
>   "grok.auth": "-",
>

[GitHub] nifi pull request #2233: NIFI-4539 ExtractGrok - Add support returning only ...

2017-10-28 Thread n-agetsu

GitHub user n-agetsu opened a pull request:

https://github.com/apache/nifi/pull/2233

NIFI-4539 ExtractGrok - Add support returning only named captures

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/n-agetsu/nifi NIFI-4539

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2233


commit 51ad5d4c6c94f5ba0c7d462f2200a8fd25c5e43e
Author: Norito Agetsuma 
Date:   2017-10-28T05:20:34Z

NIFI-4539 ExtractGrok - Add support returning only named captures




---

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

[GitHub] nifi-minifi-cpp issue #158: MINIFICPP-60: Add initial implementation of Site...

[jira] [Commented] (MINIFICPP-60) Support HTTP(s) as transport mechanism for Site to Site

[jira] [Commented] (MINIFICPP-201) Support Site2Site Server Protocol

[GitHub] nifi-minifi-cpp issue #157: MINIFI-269 Implement ApplyTemplate processor

[jira] [Commented] (MINIFICPP-201) Support Site2Site Server Protocol

[jira] [Commented] (MINIFICPP-201) Support Site2Site Server Protocol

[GitHub] nifi-minifi-cpp pull request #157: MINIFI-269 Implement ApplyTemplate proces...

[GitHub] nifi-minifi-cpp pull request #157: MINIFI-269 Implement ApplyTemplate proces...

[jira] [Commented] (MINIFICPP-201) Support Site2Site Server Protocol

[GitHub] nifi-minifi-cpp issue #157: MINIFI-269 Implement ApplyTemplate processor

[jira] [Created] (NIFI-4541) Variables can not be used for connection string in RedisConnectionPoolService

[jira] [Commented] (MINIFICPP-267) MiNiFiMain crashes and fails to infer MINIFI_HOME if MINIFI_HOME not set

[jira] [Commented] (MINIFICPP-271) Unncessary Boost dependency in ProcessSession.h

[GitHub] nifi-minifi-cpp issue #155: MINIFICPP-267 Make inference of MINIFI_HOME more...

[GitHub] nifi-minifi-cpp pull request #159: MINIFICPP-271: Remove unncessary Boost he...

[jira] [Commented] (NIFI-4080) ValidateCSV - Add support for Expression Language

[GitHub] nifi pull request #2226: NIFI-4080: Added EL support to fields in ValidateCS...

[jira] [Assigned] (NIFI-4400) Advanced UI with code editor for scripted processors

[GitHub] nifi-minifi-cpp pull request #159: remove unncessary Boost header dependency...

[jira] [Created] (MINIFICPP-271) Unncessary Boost dependency in ProcessSession.h

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

[jira] [Comment Edited] (NIFI-4540) Support for AWS SQS FIFO message queue

[jira] [Updated] (NIFI-4540) Support for AWS SQS FIFO message queue

[jira] [Updated] (NIFI-4539) ExtractGrok - Add support returning only named captures

[jira] [Commented] (NIFI-4539) ExtractGrok - Add support returning only named captures

[GitHub] nifi pull request #2233: NIFI-4539 ExtractGrok - Add support returning only ...

32 matches

Site Navigation

Mail list logo

Footer information