[jira] [Commented] (NIFIREG-84) Add screenshots to User Guide
[ https://issues.apache.org/jira/browse/NIFIREG-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305033#comment-16305033 ] ASF GitHub Bot commented on NIFIREG-84: --- Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/72 > Add screenshots to User Guide > - > > Key: NIFIREG-84 > URL: https://issues.apache.org/jira/browse/NIFIREG-84 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.1.0 > > > NIFIREG-67 added a very rough draft of the User Guide. Need to add > screenshots and make edits with new/changed functionality in the Registry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry pull request #72: NIFIREG-84 Corrected screenshot when creatin...
Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/72 ---
[jira] [Commented] (NIFIREG-84) Add screenshots to User Guide
[ https://issues.apache.org/jira/browse/NIFIREG-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305031#comment-16305031 ] ASF GitHub Bot commented on NIFIREG-84: --- Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/72 Looks good, merging > Add screenshots to User Guide > - > > Key: NIFIREG-84 > URL: https://issues.apache.org/jira/browse/NIFIREG-84 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.1.0 > > > NIFIREG-67 added a very rough draft of the User Guide. Need to add > screenshots and make edits with new/changed functionality in the Registry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry issue #72: NIFIREG-84 Corrected screenshot when creating group...
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/72 Looks good, merging ---
[jira] [Commented] (NIFIREG-84) Add screenshots to User Guide
[ https://issues.apache.org/jira/browse/NIFIREG-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305028#comment-16305028 ] ASF GitHub Bot commented on NIFIREG-84: --- GitHub user andrewmlim opened a pull request: https://github.com/apache/nifi-registry/pull/72 NIFIREG-84 Corrected screenshot when creating group from selected users You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrewmlim/nifi-registry NIFIREG-84-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit 32d06151253f99ead3a756e84e2ff12316bea0c0 Author: Andrew Lim Date: 2017-12-28T03:49:25Z NIFIREG-84 Corrected screenshot when creating group from selected users > Add screenshots to User Guide > - > > Key: NIFIREG-84 > URL: https://issues.apache.org/jira/browse/NIFIREG-84 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.1.0 > > > NIFIREG-67 added a very rough draft of the User Guide. Need to add > screenshots and make edits with new/changed functionality in the Registry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry pull request #72: NIFIREG-84 Corrected screenshot when creatin...
GitHub user andrewmlim opened a pull request: https://github.com/apache/nifi-registry/pull/72 NIFIREG-84 Corrected screenshot when creating group from selected users You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrewmlim/nifi-registry NIFIREG-84-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit 32d06151253f99ead3a756e84e2ff12316bea0c0 Author: Andrew Lim Date: 2017-12-28T03:49:25Z NIFIREG-84 Corrected screenshot when creating group from selected users ---
[jira] [Created] (NIFIREG-87) Release Manager - Release 0.1.0
Bryan Bende created NIFIREG-87: -- Summary: Release Manager - Release 0.1.0 Key: NIFIREG-87 URL: https://issues.apache.org/jira/browse/NIFIREG-87 Project: NiFi Registry Issue Type: Task Reporter: Bryan Bende Assignee: Bryan Bende Fix For: 0.1.0 Perform release manager activities for 0.1.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (NIFIREG-84) Add screenshots to User Guide
[ https://issues.apache.org/jira/browse/NIFIREG-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lim reopened NIFIREG-84: --- Screenshot for "Create a New Group with Selected Users" needs to be replaced. > Add screenshots to User Guide > - > > Key: NIFIREG-84 > URL: https://issues.apache.org/jira/browse/NIFIREG-84 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.1.0 > > > NIFIREG-67 added a very rough draft of the User Guide. Need to add > screenshots and make edits with new/changed functionality in the Registry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4708) Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit
[ https://issues.apache.org/jira/browse/NIFI-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Doran updated NIFI-4708: -- Status: In Progress (was: Patch Available) > Add support for NiFi Registry to the encrypt-config tool in NiFi Toolkit > > > Key: NIFI-4708 > URL: https://issues.apache.org/jira/browse/NIFI-4708 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > Fix For: 1.5.0 > > > NiFi Registry now supports loading encrypted config files (e.g., > nifi-registry.properties, authorizers.xml, login-identity-providers.xml). > These files are very difficult to encrypt by hand, and is not recommended. > Because NiFi Registry utilizes the same encryption algorithms supported by > NiFi, the easiest way to build a tool for encrypting NiFi Registry config > properties is to extend the the encrypt-config tool in NiFi Toolkit to > support NiFi Registry as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (NIFIREG-68) Align frontend-backend models and actions
[ https://issues.apache.org/jira/browse/NIFIREG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Doran closed NIFIREG-68. -- Resolution: Won't Do Several changes have been made recently that remove client-side logic and make the models in the frontend and backend more of a 1-to-1 mapping. Closing this and any remaining improvements that are identified should be opened as new tickets. > Align frontend-backend models and actions > - > > Key: NIFIREG-68 > URL: https://issues.apache.org/jira/browse/NIFIREG-68 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran > > Currently, there is a lot of frontend UI/UX that does not map cleanly to the > REST API backend, creating the need for lots of logic in the front end. This > complicates the frontend code and also makes it non-intuitive for third > parties how to use the REST API to accomplish actions that can be performed > in the UI. > This ticket is to explore and implement ways to move some of the frontend > logic into the backend to replace inferred fields with values that can be > directly read. Also replace one-to-many frontend/backend mappings with > one-to-one mappings. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (NIFIREG-86) Disconnecting a nested PG should result in a local change to be committed
Bryan Bende created NIFIREG-86: -- Summary: Disconnecting a nested PG should result in a local change to be committed Key: NIFIREG-86 URL: https://issues.apache.org/jira/browse/NIFIREG-86 Project: NiFi Registry Issue Type: Improvement Affects Versions: 0.1.0 Reporter: Bryan Bende If you create nested process groups where the parent and child are both under version control and then disconnect the child from version control, the parent should be considered dirty and allow you to commit a new version of the parent that now includes all of the child. Currently you have to work around this by making some other trivial change to the parent group to be able to commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4504) SimpleMapCache/PersistentMapCache: Add removeAndGet and removeByPatternAndGet
[ https://issues.apache.org/jira/browse/NIFI-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304965#comment-16304965 ] ASF GitHub Bot commented on NIFI-4504: -- Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2284 @mosermw Thank you for updating the PR, it's much easier to review now. The code implemented at DistributedMapCacheClientService and MapCacheServer looks good to me. Travis error should be fine as the failure looks depending on execution condition. However, let me ask one more time since adding methods is easy but hard to remove afterwards for things like this. Are all of these three methods, `removeAndGet`, `removeByPatternAndGet` and `keySet` required by the folks you know of? I prefer to minimize the addition as those methods are only supported by DistributedMapCacheClientService, which means those will not be used by most developers who write Processors. Also, it confuses such developers which to choose from `remove` and `removeAndGet`. Probably I imagine these concerns are what made you struggle with implementing default method to just throw UnsupportedOperationException. If there is no significant needs for `removeAndGet` and `removeByPatternAndGet`, then I'd prefer omit these method from DistributedMapCacheClient interface. As long as we support `keySet`, pretty much everything can be done at the caller side. The only benefit to have AndGet methods I am aware of is reducing the network traffic, and atomicity (atomicity is not that important in these method IMHO). Do you think those are more important than adding mostly unsupported methods into a common interface? > SimpleMapCache/PersistentMapCache: Add removeAndGet and removeByPatternAndGet > - > > Key: NIFI-4504 > URL: https://issues.apache.org/jira/browse/NIFI-4504 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Jon Kessler >Assignee: Michael Moser >Priority: Minor > > Typical map implementations return the value that was removed when performing > a remove. Because you couldn't update the existing remove methods without it > being a breaking change I suggest adding new versions of the remove and > removeByPattern methods that return the removed value(s). > These changes should also be applied up the chain to any class that makes use > of these classes such as the MapCacheServer and > AtomicDistributedMapCacheClient. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi issue #2284: NIFI-4504, NIFI-4505 added methods to MapCache API …
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2284 @mosermw Thank you for updating the PR, it's much easier to review now. The code implemented at DistributedMapCacheClientService and MapCacheServer looks good to me. Travis error should be fine as the failure looks depending on execution condition. However, let me ask one more time since adding methods is easy but hard to remove afterwards for things like this. Are all of these three methods, `removeAndGet`, `removeByPatternAndGet` and `keySet` required by the folks you know of? I prefer to minimize the addition as those methods are only supported by DistributedMapCacheClientService, which means those will not be used by most developers who write Processors. Also, it confuses such developers which to choose from `remove` and `removeAndGet`. Probably I imagine these concerns are what made you struggle with implementing default method to just throw UnsupportedOperationException. If there is no significant needs for `removeAndGet` and `removeByPatternAndGet`, then I'd prefer omit these method from DistributedMapCacheClient interface. As long as we support `keySet`, pretty much everything can be done at the caller side. The only benefit to have AndGet methods I am aware of is reducing the network traffic, and atomicity (atomicity is not that important in these method IMHO). Do you think those are more important than adding mostly unsupported methods into a common interface? ---
[jira] [Resolved] (NIFIREG-85) Custom ascii art banner
[ https://issues.apache.org/jira/browse/NIFIREG-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-85. Resolution: Fixed > Custom ascii art banner > --- > > Key: NIFIREG-85 > URL: https://issues.apache.org/jira/browse/NIFIREG-85 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran >Priority: Trivial > Fix For: 0.0.1 > > > Replace stock Spring Boot startup banner text with a NiFi Registry banner & > version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFIREG-85) Custom ascii art banner
[ https://issues.apache.org/jira/browse/NIFIREG-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304959#comment-16304959 ] ASF GitHub Bot commented on NIFIREG-85: --- Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/71 Very cool addition, going to merge > Custom ascii art banner > --- > > Key: NIFIREG-85 > URL: https://issues.apache.org/jira/browse/NIFIREG-85 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran >Priority: Trivial > Fix For: 0.0.1 > > > Replace stock Spring Boot startup banner text with a NiFi Registry banner & > version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFIREG-85) Custom ascii art banner
[ https://issues.apache.org/jira/browse/NIFIREG-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304961#comment-16304961 ] ASF GitHub Bot commented on NIFIREG-85: --- Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/71 > Custom ascii art banner > --- > > Key: NIFIREG-85 > URL: https://issues.apache.org/jira/browse/NIFIREG-85 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran >Priority: Trivial > Fix For: 0.0.1 > > > Replace stock Spring Boot startup banner text with a NiFi Registry banner & > version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry pull request #71: NIFIREG-85 Custom ascii art banner
Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/71 ---
[GitHub] nifi-registry issue #71: NIFIREG-85 Custom ascii art banner
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/71 Very cool addition, going to merge ---
[jira] [Resolved] (NIFIREG-67) Create User Guide and update Adminstrator's Guide
[ https://issues.apache.org/jira/browse/NIFIREG-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-67. Resolution: Fixed > Create User Guide and update Adminstrator's Guide > - > > Key: NIFIREG-67 > URL: https://issues.apache.org/jira/browse/NIFIREG-67 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > User Guide should cover topics such as Managing Flow, Managing Buckets, > Managing Users/Groups, Managing Policies,... > Sys Admin Guide should cover System Requirements, Installation, Security > Configuration,... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFIREG-67) Create User Guide and update Adminstrator's Guide
[ https://issues.apache.org/jira/browse/NIFIREG-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304957#comment-16304957 ] ASF GitHub Bot commented on NIFIREG-67: --- Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/69 > Create User Guide and update Adminstrator's Guide > - > > Key: NIFIREG-67 > URL: https://issues.apache.org/jira/browse/NIFIREG-67 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > User Guide should cover topics such as Managing Flow, Managing Buckets, > Managing Users/Groups, Managing Policies,... > Sys Admin Guide should cover System Requirements, Installation, Security > Configuration,... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFIREG-67) Create User Guide and update Adminstrator's Guide
[ https://issues.apache.org/jira/browse/NIFIREG-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304956#comment-16304956 ] ASF GitHub Bot commented on NIFIREG-67: --- Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/69 Looks good, merging... > Create User Guide and update Adminstrator's Guide > - > > Key: NIFIREG-67 > URL: https://issues.apache.org/jira/browse/NIFIREG-67 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > User Guide should cover topics such as Managing Flow, Managing Buckets, > Managing Users/Groups, Managing Policies,... > Sys Admin Guide should cover System Requirements, Installation, Security > Configuration,... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry pull request #69: NIFIREG-67 Revisions to Admin Guide
Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/69 ---
[GitHub] nifi-registry issue #69: NIFIREG-67 Revisions to Admin Guide
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/69 Looks good, merging... ---
[jira] [Closed] (NIFI-4725) Custom ascii art banner
[ https://issues.apache.org/jira/browse/NIFI-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Doran closed NIFI-4725. - > Custom ascii art banner > > > Key: NIFI-4725 > URL: https://issues.apache.org/jira/browse/NIFI-4725 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran >Priority: Trivial > > Replace stock Spring Boot startup banner text with a NiFi Registry banner & > version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFIREG-67) Create User Guide and update Adminstrator's Guide
[ https://issues.apache.org/jira/browse/NIFIREG-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304949#comment-16304949 ] ASF GitHub Bot commented on NIFIREG-67: --- Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/69 Updated to address the corrections noted by @andrewmlim. Thanks! > Create User Guide and update Adminstrator's Guide > - > > Key: NIFIREG-67 > URL: https://issues.apache.org/jira/browse/NIFIREG-67 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > User Guide should cover topics such as Managing Flow, Managing Buckets, > Managing Users/Groups, Managing Policies,... > Sys Admin Guide should cover System Requirements, Installation, Security > Configuration,... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry issue #69: NIFIREG-67 Revisions to Admin Guide
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/69 Updated to address the corrections noted by @andrewmlim. Thanks! ---
[jira] [Resolved] (NIFIREG-84) Add screenshots to User Guide
[ https://issues.apache.org/jira/browse/NIFIREG-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-84. Resolution: Fixed > Add screenshots to User Guide > - > > Key: NIFIREG-84 > URL: https://issues.apache.org/jira/browse/NIFIREG-84 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > NIFIREG-67 added a very rough draft of the User Guide. Need to add > screenshots and make edits with new/changed functionality in the Registry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFIREG-84) Add screenshots to User Guide
[ https://issues.apache.org/jira/browse/NIFIREG-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304948#comment-16304948 ] ASF GitHub Bot commented on NIFIREG-84: --- Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/70 > Add screenshots to User Guide > - > > Key: NIFIREG-84 > URL: https://issues.apache.org/jira/browse/NIFIREG-84 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > NIFIREG-67 added a very rough draft of the User Guide. Need to add > screenshots and make edits with new/changed functionality in the Registry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry pull request #70: NIFIREG-84 Added screenshots to User Guide a...
Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/70 ---
[jira] [Commented] (NIFIREG-84) Add screenshots to User Guide
[ https://issues.apache.org/jira/browse/NIFIREG-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304947#comment-16304947 ] ASF GitHub Bot commented on NIFIREG-84: --- Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/70 This looks good, nice work getting all the screenshots in there! Going to merge > Add screenshots to User Guide > - > > Key: NIFIREG-84 > URL: https://issues.apache.org/jira/browse/NIFIREG-84 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > NIFIREG-67 added a very rough draft of the User Guide. Need to add > screenshots and make edits with new/changed functionality in the Registry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry issue #70: NIFIREG-84 Added screenshots to User Guide and made...
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/70 This looks good, nice work getting all the screenshots in there! Going to merge ---
[jira] [Commented] (NIFIREG-85) Custom ascii art banner
[ https://issues.apache.org/jira/browse/NIFIREG-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304946#comment-16304946 ] ASF GitHub Bot commented on NIFIREG-85: --- GitHub user kevdoran opened a pull request: https://github.com/apache/nifi-registry/pull/71 NIFIREG-85 Custom ascii art banner I doubt anyone will notice unless they are looking in bootstrap.log, but this replaces the stock Spring Boot banner with a custom one: # example with version populated: Apache NiFi _ _ _ __ ___ __ _(_)___| |_ _ __ _ _ | '__/ _ \/ _` | / __| __| '__| | | | | | | __/ (_| | \__ \ |_| | | |_| | |_| \___|\__, |_|___/\__|_| \__, | ==|___/|___/= v0.0.1-SNAPSHOT You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevdoran/nifi-registry NIFIREG-85 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 commit b453e767af86f0fe6977ccd3e1c28798e4c13fdd Author: Kevin Doran Date: 2017-12-28T00:17:20Z NIFIREG-85 Custom ascii art banner > Custom ascii art banner > --- > > Key: NIFIREG-85 > URL: https://issues.apache.org/jira/browse/NIFIREG-85 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran >Priority: Trivial > Fix For: 0.0.1 > > > Replace stock Spring Boot startup banner text with a NiFi Registry banner & > version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry pull request #71: NIFIREG-85 Custom ascii art banner
GitHub user kevdoran opened a pull request: https://github.com/apache/nifi-registry/pull/71 NIFIREG-85 Custom ascii art banner I doubt anyone will notice unless they are looking in bootstrap.log, but this replaces the stock Spring Boot banner with a custom one: # example with version populated: Apache NiFi _ _ _ __ ___ __ _(_)___| |_ _ __ _ _ | '__/ _ \/ _` | / __| __| '__| | | | | | | __/ (_| | \__ \ |_| | | |_| | |_| \___|\__, |_|___/\__|_| \__, | ==|___/|___/= v0.0.1-SNAPSHOT You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevdoran/nifi-registry NIFIREG-85 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 commit b453e767af86f0fe6977ccd3e1c28798e4c13fdd Author: Kevin Doran Date: 2017-12-28T00:17:20Z NIFIREG-85 Custom ascii art banner ---
[jira] [Created] (NIFIREG-85) Custom ascii art banner
Kevin Doran created NIFIREG-85: -- Summary: Custom ascii art banner Key: NIFIREG-85 URL: https://issues.apache.org/jira/browse/NIFIREG-85 Project: NiFi Registry Issue Type: Improvement Reporter: Kevin Doran Assignee: Kevin Doran Priority: Trivial Fix For: 0.0.1 Replace stock Spring Boot startup banner text with a NiFi Registry banner & version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (NIFI-4725) Custom ascii art banner
[ https://issues.apache.org/jira/browse/NIFI-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Doran resolved NIFI-4725. --- Resolution: Invalid Intended to create this under NIFIREG project > Custom ascii art banner > > > Key: NIFI-4725 > URL: https://issues.apache.org/jira/browse/NIFI-4725 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Kevin Doran >Assignee: Kevin Doran >Priority: Trivial > > Replace stock Spring Boot startup banner text with a NiFi Registry banner & > version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (NIFI-4725) Custom ascii art banner
Kevin Doran created NIFI-4725: - Summary: Custom ascii art banner Key: NIFI-4725 URL: https://issues.apache.org/jira/browse/NIFI-4725 Project: Apache NiFi Issue Type: Improvement Reporter: Kevin Doran Assignee: Kevin Doran Priority: Trivial Replace stock Spring Boot startup banner text with a NiFi Registry banner & version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFIREG-67) Create User Guide and update Adminstrator's Guide
[ https://issues.apache.org/jira/browse/NIFIREG-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304888#comment-16304888 ] ASF GitHub Bot commented on NIFIREG-67: --- Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/69#discussion_r158882148 --- Diff: nifi-registry-docs/src/main/asciidoc/administration-guide.adoc --- @@ -237,9 +237,12 @@ During startup there is a check to ensure that there are no two users/groups wit The default UserGroupProvider is the FileUserGroupProvider, however, you can develop additional UserGroupProviders as extensions. The FileUserGroupProvider has the following properties: -* Users File - The file where the FileUserGroupProvider stores users and groups. By default, the 'users.xml' in the 'conf' directory is chosen. -* Legacy Authorized Users File - The full path to an existing authorized-users.xml that will be automatically be used to load the users and groups into the Users File. -* Initial User Identity - The identity of a users and systems to seed the Users File. The name of each property must be unique, for example: "Initial User Identity A", "Initial User Identity B", "Initial User Identity C" or "Initial User Identity 1", "Initial User Identity 2", "Initial User Identity 3" +* Users File - The file where the FileUserGroupProvider stores users and groups. + By default, 'users.xml' in the 'conf' directory is chosen. +* Initial User Identity - The identity of a user or system to seed an empty Users File. + Multiple Initial User Identity properties can be specified, but the name of each property must be unique, for example: "Initial User Identity A", "Initial User Identity B", "Initial User Identity C" or "Initial User Identity 1", "Initial User Identity 2", "Initial User Identity 3" + +NOTE: Initial User Identities these identities are only created if the specified Users File is missing or empty during NiFi Registry startup. Changes to the configured Initial Users Identities will not take effect if the Users File is populated. --- End diff -- thanks, will do > Create User Guide and update Adminstrator's Guide > - > > Key: NIFIREG-67 > URL: https://issues.apache.org/jira/browse/NIFIREG-67 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > User Guide should cover topics such as Managing Flow, Managing Buckets, > Managing Users/Groups, Managing Policies,... > Sys Admin Guide should cover System Requirements, Installation, Security > Configuration,... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry pull request #69: NIFIREG-67 Revisions to Admin Guide
Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/69#discussion_r158882148 --- Diff: nifi-registry-docs/src/main/asciidoc/administration-guide.adoc --- @@ -237,9 +237,12 @@ During startup there is a check to ensure that there are no two users/groups wit The default UserGroupProvider is the FileUserGroupProvider, however, you can develop additional UserGroupProviders as extensions. The FileUserGroupProvider has the following properties: -* Users File - The file where the FileUserGroupProvider stores users and groups. By default, the 'users.xml' in the 'conf' directory is chosen. -* Legacy Authorized Users File - The full path to an existing authorized-users.xml that will be automatically be used to load the users and groups into the Users File. -* Initial User Identity - The identity of a users and systems to seed the Users File. The name of each property must be unique, for example: "Initial User Identity A", "Initial User Identity B", "Initial User Identity C" or "Initial User Identity 1", "Initial User Identity 2", "Initial User Identity 3" +* Users File - The file where the FileUserGroupProvider stores users and groups. + By default, 'users.xml' in the 'conf' directory is chosen. +* Initial User Identity - The identity of a user or system to seed an empty Users File. + Multiple Initial User Identity properties can be specified, but the name of each property must be unique, for example: "Initial User Identity A", "Initial User Identity B", "Initial User Identity C" or "Initial User Identity 1", "Initial User Identity 2", "Initial User Identity 3" + +NOTE: Initial User Identities these identities are only created if the specified Users File is missing or empty during NiFi Registry startup. Changes to the configured Initial Users Identities will not take effect if the Users File is populated. --- End diff -- thanks, will do ---
[jira] [Commented] (NIFIREG-67) Create User Guide and update Adminstrator's Guide
[ https://issues.apache.org/jira/browse/NIFIREG-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304881#comment-16304881 ] ASF GitHub Bot commented on NIFIREG-67: --- Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/69#discussion_r158881648 --- Diff: nifi-registry-docs/src/main/asciidoc/administration-guide.adoc --- @@ -287,34 +290,30 @@ The CompositeConfigurableUserGroupProvider will provide support for retrieving u * Configurable User Group Provider - A configurable user group provider. * User Group Provider - The identifier of user group providers to load from. The name of each property must be unique, for example: "User Group Provider A", "User Group Provider B", "User Group Provider C" or "User Group Provider 1", "User Group Provider 2", "User Group Provider 3" +After you have configured a UserGroupProvider, you configure an AccessPolicyProvider that will control Access Policies for the identities in the UserGroupProvider. --- End diff -- To be consistent with rest of doc, add "must" in "After you have configured, you must configure an AccessPolicyProvider..." > Create User Guide and update Adminstrator's Guide > - > > Key: NIFIREG-67 > URL: https://issues.apache.org/jira/browse/NIFIREG-67 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > User Guide should cover topics such as Managing Flow, Managing Buckets, > Managing Users/Groups, Managing Policies,... > Sys Admin Guide should cover System Requirements, Installation, Security > Configuration,... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry pull request #69: NIFIREG-67 Revisions to Admin Guide
Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/69#discussion_r158881648 --- Diff: nifi-registry-docs/src/main/asciidoc/administration-guide.adoc --- @@ -287,34 +290,30 @@ The CompositeConfigurableUserGroupProvider will provide support for retrieving u * Configurable User Group Provider - A configurable user group provider. * User Group Provider - The identifier of user group providers to load from. The name of each property must be unique, for example: "User Group Provider A", "User Group Provider B", "User Group Provider C" or "User Group Provider 1", "User Group Provider 2", "User Group Provider 3" +After you have configured a UserGroupProvider, you configure an AccessPolicyProvider that will control Access Policies for the identities in the UserGroupProvider. --- End diff -- To be consistent with rest of doc, add "must" in "After you have configured, you must configure an AccessPolicyProvider..." ---
[jira] [Commented] (NIFIREG-67) Create User Guide and update Adminstrator's Guide
[ https://issues.apache.org/jira/browse/NIFIREG-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304878#comment-16304878 ] ASF GitHub Bot commented on NIFIREG-67: --- Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/69#discussion_r158881522 --- Diff: nifi-registry-docs/src/main/asciidoc/administration-guide.adoc --- @@ -237,9 +237,12 @@ During startup there is a check to ensure that there are no two users/groups wit The default UserGroupProvider is the FileUserGroupProvider, however, you can develop additional UserGroupProviders as extensions. The FileUserGroupProvider has the following properties: -* Users File - The file where the FileUserGroupProvider stores users and groups. By default, the 'users.xml' in the 'conf' directory is chosen. -* Legacy Authorized Users File - The full path to an existing authorized-users.xml that will be automatically be used to load the users and groups into the Users File. -* Initial User Identity - The identity of a users and systems to seed the Users File. The name of each property must be unique, for example: "Initial User Identity A", "Initial User Identity B", "Initial User Identity C" or "Initial User Identity 1", "Initial User Identity 2", "Initial User Identity 3" +* Users File - The file where the FileUserGroupProvider stores users and groups. + By default, 'users.xml' in the 'conf' directory is chosen. +* Initial User Identity - The identity of a user or system to seed an empty Users File. + Multiple Initial User Identity properties can be specified, but the name of each property must be unique, for example: "Initial User Identity A", "Initial User Identity B", "Initial User Identity C" or "Initial User Identity 1", "Initial User Identity 2", "Initial User Identity 3" + +NOTE: Initial User Identities these identities are only created if the specified Users File is missing or empty during NiFi Registry startup. Changes to the configured Initial Users Identities will not take effect if the Users File is populated. --- End diff -- Remove "these identities" > Create User Guide and update Adminstrator's Guide > - > > Key: NIFIREG-67 > URL: https://issues.apache.org/jira/browse/NIFIREG-67 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > User Guide should cover topics such as Managing Flow, Managing Buckets, > Managing Users/Groups, Managing Policies,... > Sys Admin Guide should cover System Requirements, Installation, Security > Configuration,... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry pull request #69: NIFIREG-67 Revisions to Admin Guide
Github user andrewmlim commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/69#discussion_r158881522 --- Diff: nifi-registry-docs/src/main/asciidoc/administration-guide.adoc --- @@ -237,9 +237,12 @@ During startup there is a check to ensure that there are no two users/groups wit The default UserGroupProvider is the FileUserGroupProvider, however, you can develop additional UserGroupProviders as extensions. The FileUserGroupProvider has the following properties: -* Users File - The file where the FileUserGroupProvider stores users and groups. By default, the 'users.xml' in the 'conf' directory is chosen. -* Legacy Authorized Users File - The full path to an existing authorized-users.xml that will be automatically be used to load the users and groups into the Users File. -* Initial User Identity - The identity of a users and systems to seed the Users File. The name of each property must be unique, for example: "Initial User Identity A", "Initial User Identity B", "Initial User Identity C" or "Initial User Identity 1", "Initial User Identity 2", "Initial User Identity 3" +* Users File - The file where the FileUserGroupProvider stores users and groups. + By default, 'users.xml' in the 'conf' directory is chosen. +* Initial User Identity - The identity of a user or system to seed an empty Users File. + Multiple Initial User Identity properties can be specified, but the name of each property must be unique, for example: "Initial User Identity A", "Initial User Identity B", "Initial User Identity C" or "Initial User Identity 1", "Initial User Identity 2", "Initial User Identity 3" + +NOTE: Initial User Identities these identities are only created if the specified Users File is missing or empty during NiFi Registry startup. Changes to the configured Initial Users Identities will not take effect if the Users File is populated. --- End diff -- Remove "these identities" ---
[jira] [Commented] (NIFIREG-84) Add screenshots to User Guide
[ https://issues.apache.org/jira/browse/NIFIREG-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304869#comment-16304869 ] ASF GitHub Bot commented on NIFIREG-84: --- GitHub user andrewmlim opened a pull request: https://github.com/apache/nifi-registry/pull/70 NIFIREG-84 Added screenshots to User Guide and made text edits You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrewmlim/nifi-registry NIFIREG-84 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit ef0b50f295dd0b3f000636ced0a651e071c98944 Author: Andrew Lim Date: 2017-12-27T23:37:21Z NIFIREG-84 Added screenshots to User Guide and made text edits > Add screenshots to User Guide > - > > Key: NIFIREG-84 > URL: https://issues.apache.org/jira/browse/NIFIREG-84 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > NIFIREG-67 added a very rough draft of the User Guide. Need to add > screenshots and make edits with new/changed functionality in the Registry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry pull request #70: NIFIREG-84 Added screenshots to User Guide a...
GitHub user andrewmlim opened a pull request: https://github.com/apache/nifi-registry/pull/70 NIFIREG-84 Added screenshots to User Guide and made text edits You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrewmlim/nifi-registry NIFIREG-84 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit ef0b50f295dd0b3f000636ced0a651e071c98944 Author: Andrew Lim Date: 2017-12-27T23:37:21Z NIFIREG-84 Added screenshots to User Guide and made text edits ---
[jira] [Created] (NIFIREG-84) Add screenshots to User Guide
Andrew Lim created NIFIREG-84: - Summary: Add screenshots to User Guide Key: NIFIREG-84 URL: https://issues.apache.org/jira/browse/NIFIREG-84 Project: NiFi Registry Issue Type: Improvement Reporter: Andrew Lim Fix For: 0.0.1 NIFIREG-67 added a very rough draft of the User Guide. Need to add screenshots and make edits with new/changed functionality in the Registry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (NIFIREG-84) Add screenshots to User Guide
[ https://issues.apache.org/jira/browse/NIFIREG-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lim reassigned NIFIREG-84: - Assignee: Andrew Lim > Add screenshots to User Guide > - > > Key: NIFIREG-84 > URL: https://issues.apache.org/jira/browse/NIFIREG-84 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > NIFIREG-67 added a very rough draft of the User Guide. Need to add > screenshots and make edits with new/changed functionality in the Registry. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFIREG-67) Create User Guide and update Adminstrator's Guide
[ https://issues.apache.org/jira/browse/NIFIREG-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304850#comment-16304850 ] ASF GitHub Bot commented on NIFIREG-67: --- GitHub user kevdoran opened a pull request: https://github.com/apache/nifi-registry/pull/69 NIFIREG-67 Revisions to Admin Guide Minor edits and corrections to the Admin Guide, particularly related to configuring an instance with security options. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevdoran/nifi-registry NIFIREG-67-documentation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit c2414f72bbb7e9643ba8dc87d05dbfb880b1427e Author: Kevin Doran Date: 2017-12-27T22:45:05Z NIFIREG-67 Revisions to Admin Guide Minor edits and corrections to the Admin Guide, particularly related to configuring an instance with security options. > Create User Guide and update Adminstrator's Guide > - > > Key: NIFIREG-67 > URL: https://issues.apache.org/jira/browse/NIFIREG-67 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.0.1 >Reporter: Andrew Lim >Assignee: Andrew Lim > Fix For: 0.0.1 > > > User Guide should cover topics such as Managing Flow, Managing Buckets, > Managing Users/Groups, Managing Policies,... > Sys Admin Guide should cover System Requirements, Installation, Security > Configuration,... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi-registry pull request #69: NIFIREG-67 Revisions to Admin Guide
GitHub user kevdoran opened a pull request: https://github.com/apache/nifi-registry/pull/69 NIFIREG-67 Revisions to Admin Guide Minor edits and corrections to the Admin Guide, particularly related to configuring an instance with security options. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevdoran/nifi-registry NIFIREG-67-documentation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit c2414f72bbb7e9643ba8dc87d05dbfb880b1427e Author: Kevin Doran Date: 2017-12-27T22:45:05Z NIFIREG-67 Revisions to Admin Guide Minor edits and corrections to the Admin Guide, particularly related to configuring an instance with security options. ---
[jira] [Commented] (NIFI-4504) SimpleMapCache/PersistentMapCache: Add removeAndGet and removeByPatternAndGet
[ https://issues.apache.org/jira/browse/NIFI-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304841#comment-16304841 ] ASF GitHub Bot commented on NIFI-4504: -- Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2284 I rebased and force pushed the discussed changes. It appears that the Travis failure is unrelated? > SimpleMapCache/PersistentMapCache: Add removeAndGet and removeByPatternAndGet > - > > Key: NIFI-4504 > URL: https://issues.apache.org/jira/browse/NIFI-4504 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Jon Kessler >Assignee: Michael Moser >Priority: Minor > > Typical map implementations return the value that was removed when performing > a remove. Because you couldn't update the existing remove methods without it > being a breaking change I suggest adding new versions of the remove and > removeByPattern methods that return the removed value(s). > These changes should also be applied up the chain to any class that makes use > of these classes such as the MapCacheServer and > AtomicDistributedMapCacheClient. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi issue #2284: NIFI-4504, NIFI-4505 added methods to MapCache API …
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2284 I rebased and force pushed the discussed changes. It appears that the Travis failure is unrelated? ---
[GitHub] nifi issue #2180: Added GetMongoAggregation to support running Mongo aggrega...
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2180 @mattyb149 If you get a chance, could you take a look? I just rebased it against master. ---
[jira] [Comment Edited] (NIFI-4638) Drop events disordering
[ https://issues.apache.org/jira/browse/NIFI-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304758#comment-16304758 ] Netanel Bitan edited comment on NIFI-4638 at 12/27/17 7:53 PM: --- In my attempts to try to get to the bottom of the events disorder bug I have written a small script that finds the disorders. I hope you might find this useful in trying to recreate the bug, and find out if you are experiencing it in any of your own nifi flows. The script is attached to this ticket and can be found as a gist in this link: https://gist.github.com/bitanetanel/808cb3a0204aad5830f31d6d7ff89299 as well To run the script simply configure the name of the nifi host and the amount of time back you want the script to check at the top of the document. Its interesting to note that we have not been able to reproduce this bug in any of our more simple flows, and it seems to happen only in a very complicated flow consisting of 75+ processors. was (Author: bitanetanel): In my attempts to try to get to the bottom of the events disorder bug I have written a small script that finds the disorders. I hope you might find this useful in trying to recreate the bug, and find out if you are experiencing it in any of your own nifi flows. To run the script simply configure the name of the nifi host and the amount of time back you want the script to check at the top of the document. Its interesting to note that we have not been able to reproduce this bug in any of our more simple flows, and it seems to happen only in a very complicated flow consisting of 75+ processors. > Drop events disordering > --- > > Key: NIFI-4638 > URL: https://issues.apache.org/jira/browse/NIFI-4638 > Project: Apache NiFi > Issue Type: Bug >Reporter: Omer Hadari > Attachments: nifi-script.py > > > Drop events that are generated by terminated relationships alongside other > event types are sometimes registered before them. This happens since the drop > event’s timestamp is lower by a millisecond compared to the timestamp of the > other event, even though the ordinal is higher. This causes the lineage graph > to look as if the other event comes out of the drop event. > The one millisecond difference and the fact that this bug is sporadic > suggests a rollover to the next millisecond when registering the event before > the drop event. > For example this was encountered in the split json processor, when the > original flowfile receives a fragment count and then dropped. This could be a > bug in the processor itself, though it seems to be more generic. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (NIFI-4638) Drop events disordering
[ https://issues.apache.org/jira/browse/NIFI-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Netanel Bitan updated NIFI-4638: Attachment: nifi-script.py In my attempts to try to get to the bottom of the events disorder bug I have written a small script that finds the disorders. I hope you might find this useful in trying to recreate the bug, and find out if you are experiencing it in any of your own nifi flows. To run the script simply configure the name of the nifi host and the amount of time back you want the script to check at the top of the document. Its interesting to note that we have not been able to reproduce this bug in any of our more simple flows, and it seems to happen only in a very complicated flow consisting of 75+ processors. > Drop events disordering > --- > > Key: NIFI-4638 > URL: https://issues.apache.org/jira/browse/NIFI-4638 > Project: Apache NiFi > Issue Type: Bug >Reporter: Omer Hadari > Attachments: nifi-script.py > > > Drop events that are generated by terminated relationships alongside other > event types are sometimes registered before them. This happens since the drop > event’s timestamp is lower by a millisecond compared to the timestamp of the > other event, even though the ordinal is higher. This causes the lineage graph > to look as if the other event comes out of the drop event. > The one millisecond difference and the fact that this bug is sporadic > suggests a rollover to the next millisecond when registering the event before > the drop event. > For example this was encountered in the split json processor, when the > original flowfile receives a fragment count and then dropped. This could be a > bug in the processor itself, though it seems to be more generic. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (NIFI-4504) SimpleMapCache/PersistentMapCache: Add removeAndGet and removeByPatternAndGet
[ https://issues.apache.org/jira/browse/NIFI-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304592#comment-16304592 ] ASF GitHub Bot commented on NIFI-4504: -- Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2284 Thank you Joe and Koji for taking a look at this. I struggled with deciding whether to provide a default UnsupportedOperationException or to provide the new methods in the various DistributedMapCacheClient implementations. I will happily change this PR to go with the UnsupportedOperationException route. Give me a little time to make the changes and force push, but it should be a much smaller PR and easier to review. I agree that a keySet method could become problematic in a distributed Map environment. However I believe it's important to provide as much of the Java Map interface in the distributed Map as we can, and let the implementer beware of the potential problems. I do know some folks who have extended DistributedMapCacheClient with their own implementations, and I would like the keySet method to exist to support them. > SimpleMapCache/PersistentMapCache: Add removeAndGet and removeByPatternAndGet > - > > Key: NIFI-4504 > URL: https://issues.apache.org/jira/browse/NIFI-4504 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Jon Kessler >Assignee: Michael Moser >Priority: Minor > > Typical map implementations return the value that was removed when performing > a remove. Because you couldn't update the existing remove methods without it > being a breaking change I suggest adding new versions of the remove and > removeByPattern methods that return the removed value(s). > These changes should also be applied up the chain to any class that makes use > of these classes such as the MapCacheServer and > AtomicDistributedMapCacheClient. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi issue #2284: NIFI-4504, NIFI-4505 added methods to MapCache API …
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2284 Thank you Joe and Koji for taking a look at this. I struggled with deciding whether to provide a default UnsupportedOperationException or to provide the new methods in the various DistributedMapCacheClient implementations. I will happily change this PR to go with the UnsupportedOperationException route. Give me a little time to make the changes and force push, but it should be a much smaller PR and easier to review. I agree that a keySet method could become problematic in a distributed Map environment. However I believe it's important to provide as much of the Java Map interface in the distributed Map as we can, and let the implementer beware of the potential problems. I do know some folks who have extended DistributedMapCacheClient with their own implementations, and I would like the keySet method to exist to support them. ---
[jira] [Commented] (NIFI-3648) Address Excessive Garbage Collection
[ https://issues.apache.org/jira/browse/NIFI-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304588#comment-16304588 ] ASF GitHub Bot commented on NIFI-3648: -- Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/1637 Bump. I had forgotten about this, but it looks like it can still merge cleanly. > Address Excessive Garbage Collection > > > Key: NIFI-3648 > URL: https://issues.apache.org/jira/browse/NIFI-3648 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: Mark Payne >Assignee: Mark Payne > > We have a lot of places in the codebase where we generate lots of unnecessary > garbage - especially byte arrays. We need to clean this up to in order to > relieve stress on the garbage collector. > Specific points that I've found create unnecessary garbage: > Provenance CompressableRecordWriter creates a new BufferedOutputStream for > each 'compression block' that it creates. Each one has a 64 KB byte[]. This > is very wasteful. We should instead subclass BufferedOutputStream so that we > are able to provide a byte[] to use instead of an int that indicates the > size. This way, we can just keep re-using the same byte[] that we create for > each writer. This saves about 32,000 of these 64 KB byte[] for each writer > that we create. And we create more than 1 of these per minute. > EvaluateJsonPath uses a BufferedInputStream but it is not necessary, because > the underlying library will also buffer data. So we are unnecessarily > creating a lot of byte[]'s > CompressContent uses Buffered Input AND Output. And uses 64 KB byte[]. And > doesn't need them at all, because it reads and writes with its own byte[] > buffer via StreamUtils.copy > Site-to-site uses CompressionInputStream. This stream creates a new byte[] in > the readChunkHeader() method continually. We should instead only create a new > byte[] if we need a bigger buffer and otherwise just use an offset & length > variable. > Right now, SplitText uses TextLineDemarcator. The fill() method increases the > size of the internal byte[] by 8 KB each time. When dealing with a large > chunk of data, this is VERY expensive on GC because we continually create a > byte[] and then discard it to create a new one. Take for example an 800 KB > chunk. We would do this 100,000 times. If we instead double the size we would > only have to create 8 of these. > Other Processors that use Buffered streams unnecessarily: > ConvertJSONToSQL > ExecuteProcess > ExecuteStreamCommand > AttributesToJSON > EvaluateJsonPath (when writing to content) > ExtractGrok > JmsConsumer -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] nifi issue #1637: NIFI-3648 removed cluster message copying when not in debu...
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/1637 Bump. I had forgotten about this, but it looks like it can still merge cleanly. ---
[jira] [Updated] (NIFI-4724) Publish kafka processors fails with FlowFileHandlingException if the flow file is empty
[
https://issues.apache.org/jira/browse/NIFI-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura updated NIFI-4724:
Affects Version/s: (was: 1.0.0)
1.1.0
> Publish kafka processors fails with FlowFileHandlingException if the flow
> file is empty
> ---
>
> Key: NIFI-4724
> URL: https://issues.apache.org/jira/browse/NIFI-4724
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.1.0
>Reporter: Mahesh Nayak
>Assignee: Koji Kawamura
>
> 1. Construct the flow GenerateFlowFile --> PublishKafka --> PutFile
> 2. In GenerateFlowFile set the "File Size" to 0B.
> 3. Start the flow.
> Result : Kafka processor throws below exception
> {code:None}
> 2017-12-27 02:49:21,933 WARN [Timer-Driven Process Thread-9]
> o.a.n.c.t.ContinuallyRunProcessorTask Administratively Yielding
> PublishKafka_0_10[id=95dbc77a-0160-1000--69761c4e] due to uncaught
> Exception: org.apache.nifi.processor.exception.FlowFileHandlingException:
> StandardFlowFileRecord[uuid=4d6cb989-b6a7-4129-9dfc-1598ee2b3937,claim=,offset=0,name=7061091998478433,size=0]
> transfer relationship not specified
> 2017-12-27 02:49:21,933 WARN [Timer-Driven Process Thread-9]
> o.a.n.c.t.ContinuallyRunProcessorTask
> org.apache.nifi.processor.exception.FlowFileHandlingException:
> StandardFlowFileRecord[uuid=4d6cb989-b6a7-4129-9dfc-1598ee2b3937,claim=,offset=0,name=7061091998478433,size=0]
> transfer relationship not specified
> at
> org.apache.nifi.controller.repository.StandardProcessSession.checkpoint(StandardProcessSession.java:251)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.commit(StandardProcessSession.java:321)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:28)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1120)
> at
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:147)
> at
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:128)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (NIFI-4724) Publish kafka processors fails with FlowFileHandlingException if the flow file is empty
[
https://issues.apache.org/jira/browse/NIFI-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura updated NIFI-4724:
Affects Version/s: (was: 1.5.0)
1.0.0
Status: Patch Available (was: In Progress)
> Publish kafka processors fails with FlowFileHandlingException if the flow
> file is empty
> ---
>
> Key: NIFI-4724
> URL: https://issues.apache.org/jira/browse/NIFI-4724
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.0.0
>Reporter: Mahesh Nayak
>Assignee: Koji Kawamura
>
> 1. Construct the flow GenerateFlowFile --> PublishKafka --> PutFile
> 2. In GenerateFlowFile set the "File Size" to 0B.
> 3. Start the flow.
> Result : Kafka processor throws below exception
> {code:None}
> 2017-12-27 02:49:21,933 WARN [Timer-Driven Process Thread-9]
> o.a.n.c.t.ContinuallyRunProcessorTask Administratively Yielding
> PublishKafka_0_10[id=95dbc77a-0160-1000--69761c4e] due to uncaught
> Exception: org.apache.nifi.processor.exception.FlowFileHandlingException:
> StandardFlowFileRecord[uuid=4d6cb989-b6a7-4129-9dfc-1598ee2b3937,claim=,offset=0,name=7061091998478433,size=0]
> transfer relationship not specified
> 2017-12-27 02:49:21,933 WARN [Timer-Driven Process Thread-9]
> o.a.n.c.t.ContinuallyRunProcessorTask
> org.apache.nifi.processor.exception.FlowFileHandlingException:
> StandardFlowFileRecord[uuid=4d6cb989-b6a7-4129-9dfc-1598ee2b3937,claim=,offset=0,name=7061091998478433,size=0]
> transfer relationship not specified
> at
> org.apache.nifi.controller.repository.StandardProcessSession.checkpoint(StandardProcessSession.java:251)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.commit(StandardProcessSession.java:321)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:28)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1120)
> at
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:147)
> at
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:128)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (NIFI-4724) Publish kafka processors fails with FlowFileHandlingException if the flow file is empty
[ https://issues.apache.org/jira/browse/NIFI-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304366#comment-16304366 ] ASF GitHub Bot commented on NIFI-4724: -- GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/2362 NIFI-4724: Support 0 byte message with PublishKafka Before this fix, PublishKafka (0.9) and PublishKafka_0_10 fail with empty incoming FlowFiles due to 'transfer relationship not specified' error. Because the internal 'publish' method is not called as StreamDemarcator does not emit any token regardless whether demarcator is set or not. As for PublishKafka_0_11 and PublishKafka_1_0, empty FlowFiles are transferred to 'success' relationship, however no Kafka message is sent to Kafka. Since Kafka allows 0 byte body empty messages, NiFi should be able to send it, too. This commit changes above current situation to the followings, with all PublishKafka_* processors: - If demarcator is not set, then publish incoming FlowFile content as it is. This enables sending an empty Kafka message. - If demarcator is set, send each token as a separate message. Even if no token is found (empty incoming FlowFile), transfer the FlowFile to 'success'. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijokarumawak/nifi nifi-4724 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2362 commit 513722c3382e5c7a9757b4ad71490483c151fa1f Author: Koji Kawamura Date: 2017-12-27T08:38:57Z NIFI-4724: Support 0 byte message with PublishKafka Before this fix, PublishKafka (0.9) and PublishKafka_0_10 fail with empty incoming FlowFiles due to 'transfer relationship not specified' error. Because the internal 'publish' method is not called as StreamDemarcator does not emit any token regardless whether demarcator is set or not. As for PublishKafka_0_11 and PublishKafka_1_0, empty FlowFiles are transferred to 'success' relationship, however no Kafka message is sent to Kafka. Since Kafka allows 0 byte body empty messages, NiFi should be able to send it, too. This commit changes above current situation to the followings, with all PublishKafka_* processors: - If demarcator is not set, then publish incoming FlowFile content as it is. This enables sending an empty Kafka message. - If demarcator is set, send each token as a separate message. Even if no token is found (empty incoming FlowFile), transfer the FlowFile to 'success'. > Publish kafka processors fails with FlowFileHandlingException if the flow > file is empty > --- > > Key: NIFI-4724 > URL: https://issues.apache.org/jira/browse/NIFI-4724 > Project: Apac
[GitHub] nifi pull request #2362: NIFI-4724: Support 0 byte message with PublishKafka
GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/2362 NIFI-4724: Support 0 byte message with PublishKafka Before this fix, PublishKafka (0.9) and PublishKafka_0_10 fail with empty incoming FlowFiles due to 'transfer relationship not specified' error. Because the internal 'publish' method is not called as StreamDemarcator does not emit any token regardless whether demarcator is set or not. As for PublishKafka_0_11 and PublishKafka_1_0, empty FlowFiles are transferred to 'success' relationship, however no Kafka message is sent to Kafka. Since Kafka allows 0 byte body empty messages, NiFi should be able to send it, too. This commit changes above current situation to the followings, with all PublishKafka_* processors: - If demarcator is not set, then publish incoming FlowFile content as it is. This enables sending an empty Kafka message. - If demarcator is set, send each token as a separate message. Even if no token is found (empty incoming FlowFile), transfer the FlowFile to 'success'. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijokarumawak/nifi nifi-4724 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2362 commit 513722c3382e5c7a9757b4ad71490483c151fa1f Author: Koji Kawamura Date: 2017-12-27T08:38:57Z NIFI-4724: Support 0 byte message with PublishKafka Before this fix, PublishKafka (0.9) and PublishKafka_0_10 fail with empty incoming FlowFiles due to 'transfer relationship not specified' error. Because the internal 'publish' method is not called as StreamDemarcator does not emit any token regardless whether demarcator is set or not. As for PublishKafka_0_11 and PublishKafka_1_0, empty FlowFiles are transferred to 'success' relationship, however no Kafka message is sent to Kafka. Since Kafka allows 0 byte body empty messages, NiFi should be able to send it, too. This commit changes above current situation to the followings, with all PublishKafka_* processors: - If demarcator is not set, then publish incoming FlowFile content as it is. This enables sending an empty Kafka message. - If demarcator is set, send each token as a separate message. Even if no token is found (empty incoming FlowFile), transfer the FlowFile to 'success'. ---
