[jira] [Commented] (NIFI-3711) Change default size of provenance details dialog to show Replay button by default
[
https://issues.apache.org/jira/browse/NIFI-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342428#comment-16342428
]
zenfenan commented on NIFI-3711:
I think it is a fair point to move the replay button.
> Change default size of provenance details dialog to show Replay button by
> default
> -
>
> Key: NIFI-3711
> URL: https://issues.apache.org/jira/browse/NIFI-3711
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core UI
>Affects Versions: 1.1.1
>Reporter: Andy LoPresto
>Priority: Minor
> Labels: beginner, dialog, provenance, replay, ui
> Attachments: Screen Shot 2017-04-18 at 11.19.12 AM.png, Screen Shot
> 2017-04-18 at 11.19.46 AM.png, Screenshot from 2017-09-10 20-56-41.png
>
>
> The provenance details dialog is sized such that the "Replay" button on the
> "Content" tab is not visible by default and there is no visible scroll bar
> indicating that the panel has additional content. Some users have reported
> being unaware of the replay feature because of this. I propose changing the
> default dialog size to ensure the panel is fully displayed ({{min-height}}?).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4686) MockFlowFile Penalized status is lost after putting attributes
[
https://issues.apache.org/jira/browse/NIFI-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342424#comment-16342424
]
ASF GitHub Bot commented on NIFI-4686:
--
GitHub user jlwt90 opened a pull request:
https://github.com/apache/nifi/pull/2438
NIFI-4686: MockFlowFile now includes penalized status when copying
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI- where is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jlwt90/nifi NIFI-4686-fix-mockflowfile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2438
commit 03550a71a083341d440995386d0d93fd623f732e
Author: jlwt90
Date: 2018-01-28T02:37:50Z
NIFI-4686 MockFlowFile now includes penalized status when copying
> MockFlowFile Penalized status is lost after putting attributes
> --
>
> Key: NIFI-4686
> URL: https://issues.apache.org/jira/browse/NIFI-4686
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: jlwt90
>Priority: Major
>
> Hello,
> When I write unit tests to test whether a FlowFile is penalised after an
> exception is thrown by an external resource, I find a possible issue in the
> current *MockFlowFile* class.
> I first penalized the FlowFile and put a *Error* attribute to the file
> afterwards. The class attribute *penalized* will be reset after the calling
> {code}session.putAttributes(xxx){code} function.
> Here is the unit test I added to the test class *TestMockProcessSession*.
> {code}
> @Test
> public void testKeepPenalizedStatusAfterPuttingAttribute(){
> final Processor processor = new PoorlyBehavedProcessor();
> final MockProcessSession session = new MockProcessSession(new
> SharedSessionState(processor, new AtomicLong(0L)), processor);
> FlowFile ff1 = session.createFlowFile("hello, world".getBytes());
> ff1 = session.penalize(ff1);
> assertEquals(ff1.isPenalized(), true);
> ff1 = session.putAttribute(ff1, "hello", "world");
> assertEquals(ff1.isPenalized(), true);
> }
> {code}
> In the current MockFlowFile implementation:
> {code}
> public MockFlowFile(final long id, final FlowFile toCopy) {}
> {code}
> Class attribute *penalized* will not be copied and therefore, this test will
> fail.
> I think this behaviour is unexpected and checked how this logic is
> implemented in *StandardFlowFileRecord*.
> https://github.com/apache/nifi/blob/c138987bb46b975379daa00e57c42f498b6ef207/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-repository-models/src/main/java/org/apache/nifi/controller/repository/StandardFlowFileRecord.java#L320
> *Calling method in StandardProcessSession:*
> https://github.com/apache/nifi/blob/c138987bb46b975379daa00e57c42f498b6ef207/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/ap
[GitHub] nifi pull request #2438: NIFI-4686: MockFlowFile now includes penalized stat...
GitHub user jlwt90 opened a pull request: https://github.com/apache/nifi/pull/2438 NIFI-4686: MockFlowFile now includes penalized status when copying Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jlwt90/nifi NIFI-4686-fix-mockflowfile Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2438.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2438 commit 03550a71a083341d440995386d0d93fd623f732e Author: jlwt90 Date: 2018-01-28T02:37:50Z NIFI-4686 MockFlowFile now includes penalized status when copying ---
[jira] [Commented] (NIFI-4819) Add support to delete blob from Azure Storage container
[ https://issues.apache.org/jira/browse/NIFI-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342423#comment-16342423 ] zenfenaan commented on NIFI-4819: - Can anyone assign it to me? I started working on it and created a PR. > Add support to delete blob from Azure Storage container > --- > > Key: NIFI-4819 > URL: https://issues.apache.org/jira/browse/NIFI-4819 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: zenfenaan >Priority: Major > > Implement a delete processor that handles deleting blob from Azure Storage > container. This should be an extension of nifi-azure-nar bundle. Currently, > the azure bundle's storage processors has support to list, fetch, put Azure > Storage blobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4289) Implement put processor for InfluxDB
[
https://issues.apache.org/jira/browse/NIFI-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342418#comment-16342418
]
ASF GitHub Bot commented on NIFI-4289:
--
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2101
@mattyb149 @MikeThomsen
If I use `NON_EMPTY_VALIDATOR` - I get the validation exception. I am
including the exception, property definition and unit test snippets below.
Please let me know if I am missing anything.
Thanks.
Here is the unit test validation exception with `NON_EMPTY_VALIDATOR`:
`
java.lang.AssertionError: Processor has 1 validation failures:
'influxdb-username' validated against '' is invalid because
influxdb-username cannot be empty
`
Here is how I am defining the property
```
public static final PropertyDescriptor USERNAME = new
PropertyDescriptor.Builder()
.name("influxdb-username")
.displayName("Username")
.required(false)
.description("Username for accessing InfluxDB")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
```
and here is the unit test:
```
@Test
public void testEmptyUsername() {
runner.setProperty(PutInfluxDB.USERNAME,"");
runner.assertValid();
}
```
> Implement put processor for InfluxDB
>
>
> Key: NIFI-4289
> URL: https://issues.apache.org/jira/browse/NIFI-4289
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
>Affects Versions: 1.3.0
> Environment: All
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
> Labels: insert, measurements,, put, timeseries
>
> Support inserting time series measurements into InfluxDB.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2101
@mattyb149 @MikeThomsen
If I use `NON_EMPTY_VALIDATOR` - I get the validation exception. I am
including the exception, property definition and unit test snippets below.
Please let me know if I am missing anything.
Thanks.
Here is the unit test validation exception with `NON_EMPTY_VALIDATOR`:
`
java.lang.AssertionError: Processor has 1 validation failures:
'influxdb-username' validated against '' is invalid because
influxdb-username cannot be empty
`
Here is how I am defining the property
```
public static final PropertyDescriptor USERNAME = new
PropertyDescriptor.Builder()
.name("influxdb-username")
.displayName("Username")
.required(false)
.description("Username for accessing InfluxDB")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
```
and here is the unit test:
```
@Test
public void testEmptyUsername() {
runner.setProperty(PutInfluxDB.USERNAME,"");
runner.assertValid();
}
```
---
[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2101 Probably NON_EMPTY_VALIDATOR? ---
[jira] [Commented] (NIFI-4289) Implement put processor for InfluxDB
[ https://issues.apache.org/jira/browse/NIFI-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342382#comment-16342382 ] ASF GitHub Bot commented on NIFI-4289: -- Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2101 Probably NON_EMPTY_VALIDATOR? > Implement put processor for InfluxDB > > > Key: NIFI-4289 > URL: https://issues.apache.org/jira/browse/NIFI-4289 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.3.0 > Environment: All >Reporter: Mans Singh >Assignee: Mans Singh >Priority: Minor > Labels: insert, measurements,, put, timeseries > > Support inserting time series measurements into InfluxDB. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4289) Implement put processor for InfluxDB
[ https://issues.apache.org/jira/browse/NIFI-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342380#comment-16342380 ] ASF GitHub Bot commented on NIFI-4289: -- Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 @mattyb149 Do you have a recommendation for the validator [to use here]( https://github.com/apache/nifi/pull/2101#issuecomment-361025124)? > Implement put processor for InfluxDB > > > Key: NIFI-4289 > URL: https://issues.apache.org/jira/browse/NIFI-4289 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.3.0 > Environment: All >Reporter: Mans Singh >Assignee: Mans Singh >Priority: Minor > Labels: insert, measurements,, put, timeseries > > Support inserting time series measurements into InfluxDB. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2101 @mattyb149 Do you have a recommendation for the validator [to use here]( https://github.com/apache/nifi/pull/2101#issuecomment-361025124)? ---
[jira] [Commented] (NIFI-4786) Allow Expression Evaluation to Kinesis/Firehose Stream Name
[ https://issues.apache.org/jira/browse/NIFI-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342378#comment-16342378 ] ASF GitHub Bot commented on NIFI-4786: -- Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/2409 @SunSatION, this is nice work. Thanks for the new Kinesis expression language features. And double thanks for fixing the if statements and the integration tests, I think your Jackson test dependency fix is a good approach. > Allow Expression Evaluation to Kinesis/Firehose Stream Name > --- > > Key: NIFI-4786 > URL: https://issues.apache.org/jira/browse/NIFI-4786 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.5.0 >Reporter: Dorian Bugeja >Priority: Minor > Labels: features, performance, pull-request-available > Attachments: > NIFI_4786___Allow_Expression_Evaluation_to_Kinesis_Firehose_Stream_Name_NIFI_4786___Allow_1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Currenctly, the Stream name propoerty for both Firehose and Kinesis does not > support the expression language. Routing can be performed based on an > attribute of the flowfile and having a single component rather than multiple > for each one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2409: NIFI-4786 - Allow Expression Evaluation to Kinesis/Firehos...
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/2409 @SunSatION, this is nice work. Thanks for the new Kinesis expression language features. And double thanks for fixing the if statements and the integration tests, I think your Jackson test dependency fix is a good approach. ---
[jira] [Commented] (NIFI-4786) Allow Expression Evaluation to Kinesis/Firehose Stream Name
[ https://issues.apache.org/jira/browse/NIFI-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342376#comment-16342376 ] ASF GitHub Bot commented on NIFI-4786: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2409 > Allow Expression Evaluation to Kinesis/Firehose Stream Name > --- > > Key: NIFI-4786 > URL: https://issues.apache.org/jira/browse/NIFI-4786 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.5.0 >Reporter: Dorian Bugeja >Priority: Minor > Labels: features, performance, pull-request-available > Attachments: > NIFI_4786___Allow_Expression_Evaluation_to_Kinesis_Firehose_Stream_Name_NIFI_4786___Allow_1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Currenctly, the Stream name propoerty for both Firehose and Kinesis does not > support the expression language. Routing can be performed based on an > attribute of the flowfile and having a single component rather than multiple > for each one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2409: NIFI-4786 - Allow Expression Evaluation to Kinesis/...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2409 ---
[jira] [Commented] (NIFI-4786) Allow Expression Evaluation to Kinesis/Firehose Stream Name
[ https://issues.apache.org/jira/browse/NIFI-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342375#comment-16342375 ] ASF subversion and git services commented on NIFI-4786: --- Commit 8bdc2910e1e0da4e49dd45123327b4b1d37ca640 in nifi's branch refs/heads/master from dorian.bugeja [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=8bdc291 ] NIFI-4786 Allow Expression Evaluation to Kinesis/Firehose Stream Name Signed-off-by: James Wing This closes #2409. > Allow Expression Evaluation to Kinesis/Firehose Stream Name > --- > > Key: NIFI-4786 > URL: https://issues.apache.org/jira/browse/NIFI-4786 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.5.0 >Reporter: Dorian Bugeja >Priority: Minor > Labels: features, performance, pull-request-available > Attachments: > NIFI_4786___Allow_Expression_Evaluation_to_Kinesis_Firehose_Stream_Name_NIFI_4786___Allow_1.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Currenctly, the Stream name propoerty for both Firehose and Kinesis does not > support the expression language. Routing can be performed based on an > attribute of the flowfile and having a single component rather than multiple > for each one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4289) Implement put processor for InfluxDB
[
https://issues.apache.org/jira/browse/NIFI-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342373#comment-16342373
]
ASF GitHub Bot commented on NIFI-4289:
--
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2101
Hello @MikeThomsen
Thanks for your feedback. Based on your feedback I've update the code
(added braces, corrected logging, removed state variables not required from the
put processor and added integration tests profile).
Regarding the timestamp issue - I forgot to mention that InfluxDB requires
timestamp in nano-seconds resolution so we need to multiply the timestamp with
million (I've updated the documentation also). I've tested with the following
template in generate processor:
`water,country=US,city=sf rain=1,humidity=0.6
${now():toNumber():multiply(100) }`
and I see the following in the influx shell:
```
time city country humidity rain
---
2018-01-27T23:31:46.331Z sf US 0.6 1
```
Please let me know if you have any additional advice/comments for me.
Thanks again.
Mans
> Implement put processor for InfluxDB
>
>
> Key: NIFI-4289
> URL: https://issues.apache.org/jira/browse/NIFI-4289
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
>Affects Versions: 1.3.0
> Environment: All
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
> Labels: insert, measurements,, put, timeseries
>
> Support inserting time series measurements into InfluxDB.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi issue #2101: NIFI-4289 - InfluxDB put processor
Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/2101
Hello @MikeThomsen
Thanks for your feedback. Based on your feedback I've update the code
(added braces, corrected logging, removed state variables not required from the
put processor and added integration tests profile).
Regarding the timestamp issue - I forgot to mention that InfluxDB requires
timestamp in nano-seconds resolution so we need to multiply the timestamp with
million (I've updated the documentation also). I've tested with the following
template in generate processor:
`water,country=US,city=sf rain=1,humidity=0.6
${now():toNumber():multiply(100) }`
and I see the following in the influx shell:
```
time city country humidity rain
---
2018-01-27T23:31:46.331Z sf US 0.6 1
```
Please let me know if you have any additional advice/comments for me.
Thanks again.
Mans
---
[jira] [Resolved] (MINIFICPP-379) Release 0.4.0
[ https://issues.apache.org/jira/browse/MINIFICPP-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri resolved MINIFICPP-379. --- Resolution: Done > Release 0.4.0 > - > > Key: MINIFICPP-379 > URL: https://issues.apache.org/jira/browse/MINIFICPP-379 > Project: NiFi MiNiFi C++ > Issue Type: Task >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Major > Fix For: 0.4.0 > > > This ticket is to track the release process for 0.4.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MINIFICPP-384) CPack needs to ignore flex/bison generated files
[ https://issues.apache.org/jira/browse/MINIFICPP-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri updated MINIFICPP-384: -- Fix Version/s: (was: 0.4.0) 0.5.0 > CPack needs to ignore flex/bison generated files > > > Key: MINIFICPP-384 > URL: https://issues.apache.org/jira/browse/MINIFICPP-384 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Andrew Christianson >Assignee: Andrew Christianson >Priority: Major > Fix For: 0.5.0 > > > Lexer/parser generated code is included in src packages. These files need to > be excluded. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4815) Add EL support to ExecuteProcess
[ https://issues.apache.org/jira/browse/NIFI-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342067#comment-16342067 ] ASF GitHub Bot commented on NIFI-4815: -- Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2432 +1 LGTM Ran it, and it worked fine. > Add EL support to ExecuteProcess > > > Key: NIFI-4815 > URL: https://issues.apache.org/jira/browse/NIFI-4815 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > > ExecuteProcess does not support EL for 'command' and 'working dir' > properties. That would be useful when promoting workflows between > environments. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2432: NIFI-4815 - Add EL support to ExecuteProcess
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2432 +1 LGTM Ran it, and it worked fine. ---
[jira] [Commented] (NIFI-4815) Add EL support to ExecuteProcess
[
https://issues.apache.org/jira/browse/NIFI-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342061#comment-16342061
]
ASF GitHub Bot commented on NIFI-4815:
--
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2432#discussion_r164268334
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteProcess.java
---
@@ -127,6 +128,10 @@ public void validateProcessInterruptOnStop() throws
Exception {
fail();
}
+final List flowFiles =
runner.getFlowFilesForRelationship(ExecuteProcess.REL_SUCCESS);
+if(!flowFiles.isEmpty()) {
--- End diff --
Nit: there should be a space between the if and the (
> Add EL support to ExecuteProcess
>
>
> Key: NIFI-4815
> URL: https://issues.apache.org/jira/browse/NIFI-4815
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> ExecuteProcess does not support EL for 'command' and 'working dir'
> properties. That would be useful when promoting workflows between
> environments.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2432: NIFI-4815 - Add EL support to ExecuteProcess
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2432#discussion_r164268334
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteProcess.java
---
@@ -127,6 +128,10 @@ public void validateProcessInterruptOnStop() throws
Exception {
fail();
}
+final List flowFiles =
runner.getFlowFilesForRelationship(ExecuteProcess.REL_SUCCESS);
+if(!flowFiles.isEmpty()) {
--- End diff --
Nit: there should be a space between the if and the (
---
