[jira] [Commented] (NIFI-5245) SimpleCSVFileLookupService should take account of charset.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493007#comment-16493007
 ] 

ASF GitHub Bot commented on NIFI-5245:
--

GitHub user ssogabe opened a pull request:

https://github.com/apache/nifi/pull/2745

NIFI-5245: SimpleCSVFileLookupService should take account of charset

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssogabe/nifi NiFi-5245

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2745


commit 025eec69d6fa19767077b9bbef2271a66e7969ba
Author: Seiji Sogabe 
Date:   2018-05-29T01:55:51Z

NIFI-5245: SimpleCSVFileLookupService should take account of charset




> SimpleCSVFileLookupService should  take account of  charset.
> 
>
> Key: NIFI-5245
> URL: https://issues.apache.org/jira/browse/NIFI-5245
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.6.0
> Environment: Windows 10
>Reporter: Seiji Sogabe
>Priority: Critical
>
> If charset of csv file is not default encoding on platform, 
> SimpleCSVFileLookupService will lead to garbled characters.
> CSVRecordLookupService also has the same problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2745: NIFI-5245: SimpleCSVFileLookupService should take a...

[ssogabe]

GitHub user ssogabe opened a pull request:

https://github.com/apache/nifi/pull/2745

NIFI-5245: SimpleCSVFileLookupService should take account of charset

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssogabe/nifi NiFi-5245

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2745


commit 025eec69d6fa19767077b9bbef2271a66e7969ba
Author: Seiji Sogabe 
Date:   2018-05-29T01:55:51Z

NIFI-5245: SimpleCSVFileLookupService should take account of charset




---

[jira] [Commented] (NIFI-5245) SimpleCSVFileLookupService should take account of charset.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493000#comment-16493000
 ] 

ASF GitHub Bot commented on NIFI-5245:
--

Github user ssogabe closed the pull request at:

https://github.com/apache/nifi/pull/2744


> SimpleCSVFileLookupService should  take account of  charset.
> 
>
> Key: NIFI-5245
> URL: https://issues.apache.org/jira/browse/NIFI-5245
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.6.0
> Environment: Windows 10
>Reporter: Seiji Sogabe
>Priority: Critical
>
> If charset of csv file is not default encoding on platform, 
> SimpleCSVFileLookupService will lead to garbled characters.
> CSVRecordLookupService also has the same problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2744: NIFI-5245: SimpleCSVFileLookupService should take a...

[ssogabe]

Github user ssogabe closed the pull request at:

https://github.com/apache/nifi/pull/2744


---

[jira] [Commented] (NIFI-5245) SimpleCSVFileLookupService should take account of charset.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492995#comment-16492995
 ] 

ASF GitHub Bot commented on NIFI-5245:
--

GitHub user ssogabe opened a pull request:

https://github.com/apache/nifi/pull/2744

NIFI-5245: SimpleCSVFileLookupService should take account of charset

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssogabe/nifi NiFi-5245

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2744


commit 3d3d604b1822104e8e4c0ee0177a98cd8bfd73ab
Author: Seiji Sogabe 
Date:   2018-04-09T09:18:02Z

Merge tag 'rel/nifi-1.6.0'

NIFI-4995 signed release tag for approved release of NiFi 1.6.0

commit a3cfa9c3f2d2e9f3f437e515ae9a045bff83b143
Author: Seiji Sogabe 
Date:   2018-04-26T03:33:43Z

Merge remote-tracking branch 'github/master'

commit fd6c855f166163416c355a0d581adb774bd8e106
Author: Seiji Sogabe 
Date:   2018-05-28T09:59:34Z

Merge remote-tracking branch 'nifi/master'

commit 8d9ce01a3531a0d8d43342676a1bdb359c80be50
Author: Seiji Sogabe 
Date:   2018-05-29T01:36:38Z

NiFi-5245: SimpleCSVFileLookupService should take account of charset




> SimpleCSVFileLookupService should  take account of  charset.
> 
>
> Key: NIFI-5245
> URL: https://issues.apache.org/jira/browse/NIFI-5245
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.6.0
> Environment: Windows 10
>Reporter: Seiji Sogabe
>Priority: Critical
>
> If charset of csv file is not default encoding on platform, 
> SimpleCSVFileLookupService will lead to garbled characters.
> CSVRecordLookupService also has the same problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2744: NIFI-5245: SimpleCSVFileLookupService should take a...

[ssogabe]

GitHub user ssogabe opened a pull request:

https://github.com/apache/nifi/pull/2744

NIFI-5245: SimpleCSVFileLookupService should take account of charset

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ssogabe/nifi NiFi-5245

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2744


commit 3d3d604b1822104e8e4c0ee0177a98cd8bfd73ab
Author: Seiji Sogabe 
Date:   2018-04-09T09:18:02Z

Merge tag 'rel/nifi-1.6.0'

NIFI-4995 signed release tag for approved release of NiFi 1.6.0

commit a3cfa9c3f2d2e9f3f437e515ae9a045bff83b143
Author: Seiji Sogabe 
Date:   2018-04-26T03:33:43Z

Merge remote-tracking branch 'github/master'

commit fd6c855f166163416c355a0d581adb774bd8e106
Author: Seiji Sogabe 
Date:   2018-05-28T09:59:34Z

Merge remote-tracking branch 'nifi/master'

commit 8d9ce01a3531a0d8d43342676a1bdb359c80be50
Author: Seiji Sogabe 
Date:   2018-05-29T01:36:38Z

NiFi-5245: SimpleCSVFileLookupService should take account of charset




---

[GitHub] nifi issue #2711: NIFI-1705 - Adding AttributesToCSV processor

[bdesert]

Github user bdesert commented on the issue:

https://github.com/apache/nifi/pull/2711
  
@joetrite , no more comments from my side, thanks for addressing code 
review comments!
@MikeThomsen , LGTM. Could you please give a second look on it now? I 
believe it's ready, but there are issues with build, which seems not related to 
this PR.


---

[jira] [Commented] (NIFI-1705) AttributesToCSV

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492959#comment-16492959
 ] 

ASF GitHub Bot commented on NIFI-1705:
--

Github user bdesert commented on the issue:

https://github.com/apache/nifi/pull/2711
  
@joetrite , no more comments from my side, thanks for addressing code 
review comments!
@MikeThomsen , LGTM. Could you please give a second look on it now? I 
believe it's ready, but there are issues with build, which seems not related to 
this PR.


> AttributesToCSV
> ---
>
> Key: NIFI-1705
> URL: https://issues.apache.org/jira/browse/NIFI-1705
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Extensions
>Reporter: Randy Gelhausen
>Priority: Major
>
> Create a new processor which converts a Flowfile's attributes into CSV 
> content.
> Should support the same configuration options as the AttributesToJSON 
> processor



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (NIFI-5246) ExecuteSQL Fails When Querying From PostgreSQL Geometric Types

[Scott Wilburn (JIRA)]

Scott Wilburn created NIFI-5246:
---

 Summary: ExecuteSQL Fails When Querying From PostgreSQL Geometric 
Types
 Key: NIFI-5246
 URL: https://issues.apache.org/jira/browse/NIFI-5246
 Project: Apache NiFi
  Issue Type: Bug
  Components: Extensions
Affects Versions: 1.5.0
Reporter: Scott Wilburn


ExecuteSQL processor errors when querying PostgreSQL database tables that 
contain geometric types, such as polygons, lines, and points. If Avro types are 
incompatible with any source types, then it needs to have a way cast to 
text/string so that queries do not fail.

The following is the error from NiFi:

ExecuteSQL[id=016366bb-22ff-1f1e-8061-a95b6f956fda] 
ExecuteSQL[id=0145610bb-22ff-1f1e-8061-a95b6f956fda] failed to process session 
due to java.lang.IllegalArgumentException: createSchema: Unknown SQL type  
/ geometry (table: buildings, column: spatialobject) cannot be converted to 
Avro type: createSchema: Unknown SQL type  / geometry (table: buildings, 
column: spatialobject) cannot be converted to Avro type

 

 

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-1201) Allow ExecuteSQL to run queries with that use a variable timestamp or sequence id

[Scott Wilburn (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492887#comment-16492887
 ] 

Scott Wilburn commented on NIFI-1201:
-

Much of the time, users are not permitted to update source database tables to 
put information like this. I vote it should be kept in NiFi.

> Allow ExecuteSQL to run queries with that use a variable timestamp or 
> sequence id
> -
>
> Key: NIFI-1201
> URL: https://issues.apache.org/jira/browse/NIFI-1201
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Randy Gelhausen
>Priority: Minor
>
> Users are employing ExecuteSQL as a means to schedule periodic queries 
> against remote databases. Other tools that do this type of task include the 
> ability to maintain and automatically increment a sequence or timestamp used 
> in query predicates.
> For example:
> select * from src_table where created_at > "2015-11-19 12:00:00"
> Then a minute later:
> select * from src_table where created_at > "2015-11-19 12:01:00"
> Or:
> insert into my_table values (${prev_id}+1, ${now()})
> Today users can implement the same logic with a series of processors, but 
> much work could be saved by allowing ExecuteSQL to maintain these bits of 
> state.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5133) Create a processor to Publish and Subscribe to Google Pub/Sub

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492812#comment-16492812
 ] 

ASF GitHub Bot commented on NIFI-5133:
--

Github user zenfenan commented on the issue:

https://github.com/apache/nifi/pull/2724
  
I get 60 messages published per minute. The size also plays a role. The 
sample content that I publish is ~5 KB


> Create a processor to Publish and Subscribe to Google Pub/Sub
> -
>
> Key: NIFI-5133
> URL: https://issues.apache.org/jira/browse/NIFI-5133
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.6.0
>Reporter: Abdelkrim Hadjidj
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> As a workflow designer, I would like to publish/subscribe messages to/from 
> Google Pub/Sub. This integration can enable several ingestion and realtime 
> use case where data is available on Google Cloud.
> There are few options that are outside the NiFi project:
> [https://github.com/ammitt90/nifi-pubsub-processor]
> [https://github.com/synack/nifi-gcp-pubsub-publisher]
> [https://github.com/synack/nifi-gcp-pubsub-consumer]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2724: NIFI-5133: Implemented Google Cloud PubSub Processors

[zenfenan]

Github user zenfenan commented on the issue:

https://github.com/apache/nifi/pull/2724
  
I get 60 messages published per minute. The size also plays a role. The 
sample content that I publish is ~5 KB


---

[jira] [Commented] (NIFI-5133) Create a processor to Publish and Subscribe to Google Pub/Sub

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492806#comment-16492806
 ] 

ASF GitHub Bot commented on NIFI-5133:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2724
  
Out of curiosity, what kind of performance do you get in your testing?


> Create a processor to Publish and Subscribe to Google Pub/Sub
> -
>
> Key: NIFI-5133
> URL: https://issues.apache.org/jira/browse/NIFI-5133
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.6.0
>Reporter: Abdelkrim Hadjidj
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> As a workflow designer, I would like to publish/subscribe messages to/from 
> Google Pub/Sub. This integration can enable several ingestion and realtime 
> use case where data is available on Google Cloud.
> There are few options that are outside the NiFi project:
> [https://github.com/ammitt90/nifi-pubsub-processor]
> [https://github.com/synack/nifi-gcp-pubsub-publisher]
> [https://github.com/synack/nifi-gcp-pubsub-consumer]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2724: NIFI-5133: Implemented Google Cloud PubSub Processors

[pvillard31]

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2724
  
Out of curiosity, what kind of performance do you get in your testing?


---

[jira] [Commented] (NIFI-5244) MockSchemaRegistry retrieveSchemaByName is broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492747#comment-16492747
 ] 

ASF GitHub Bot commented on NIFI-5244:
--

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2742
  
So the issue was passing the optional instead of the value and never 
finding the schema?


> MockSchemaRegistry retrieveSchemaByName is broken
> -
>
> Key: NIFI-5244
> URL: https://issues.apache.org/jira/browse/NIFI-5244
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Major
>
> retrieveSchemaByName uses an optional, but never calls get() on the optional 
> so the hashmap always returns null.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2742: NIFI-5244 Fixed a bug in MockSchemaRegistry that prevented...

[ottobackwards]

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2742
  
So the issue was passing the optional instead of the value and never 
finding the schema?


---

[jira] [Commented] (MINIFICPP-513) RVO causing seg fault due to taking reference to transient

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MINIFICPP-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492733#comment-16492733
 ] 

ASF GitHub Bot commented on MINIFICPP-513:
--

GitHub user phrocker opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/346

MINIFICPP-513: Avoid rvalue ref and move semantics. let compiler take…

… care of movement optimization

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-513

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #346


commit e4e826dec56902bd7dabbb084e48a0bd35684a8c
Author: Marc Parisi 
Date:   2018-05-28T14:17:50Z

MINIFICPP-513: Avoid rvalue ref and move semantics. let compiler take care 
of movement optimization




> RVO causing seg fault due to taking reference to transient 
> ---
>
> Key: MINIFICPP-513
> URL: https://issues.apache.org/jira/browse/MINIFICPP-513
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> RVO causing seg fault due to taking reference to transient on certain 
> compilers. Additionally, during profiling found that elision was prevented, 
> so we should avoid using the rvalue reference for the return and move 
> semantics and let the compiler take care of the optimization. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp pull request #346: MINIFICPP-513: Avoid rvalue ref and move ...

[phrocker]

GitHub user phrocker opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/346

MINIFICPP-513: Avoid rvalue ref and move semantics. let compiler take…

… care of movement optimization

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-513

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #346


commit e4e826dec56902bd7dabbb084e48a0bd35684a8c
Author: Marc Parisi 
Date:   2018-05-28T14:17:50Z

MINIFICPP-513: Avoid rvalue ref and move semantics. let compiler take care 
of movement optimization




---

[jira] [Updated] (MINIFICPP-513) RVO causing seg fault due to taking reference to transient

[marco polo (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

marco polo updated MINIFICPP-513:
-
Description: RVO causing seg fault due to taking reference to transient on 
certain compilers. Additionally, during profiling found that elision was 
prevented, so we should avoid using the rvalue reference for the return and 
move semantics and let the compiler take care of the optimization.   (was: RVO 
causing seg fault due to taking reference to transient)

> RVO causing seg fault due to taking reference to transient 
> ---
>
> Key: MINIFICPP-513
> URL: https://issues.apache.org/jira/browse/MINIFICPP-513
> Project: NiFi MiNiFi C++
>  Issue Type: Bug
>Reporter: marco polo
>Assignee: marco polo
>Priority: Major
>
> RVO causing seg fault due to taking reference to transient on certain 
> compilers. Additionally, during profiling found that elision was prevented, 
> so we should avoid using the rvalue reference for the return and move 
> semantics and let the compiler take care of the optimization. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (MINIFICPP-513) RVO causing seg fault due to taking reference to transient

[marco polo (JIRA)]

marco polo created MINIFICPP-513:


 Summary: RVO causing seg fault due to taking reference to 
transient 
 Key: MINIFICPP-513
 URL: https://issues.apache.org/jira/browse/MINIFICPP-513
 Project: NiFi MiNiFi C++
  Issue Type: Bug
Reporter: marco polo
Assignee: marco polo


RVO causing seg fault due to taking reference to transient



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2743: NIFI-5226: Implement a Record API based PutInfluxDB proces...

[bednar]

Github user bednar commented on the issue:

https://github.com/apache/nifi/pull/2743
  
Hi NiFi team, this pull request is now ready to get reviewed. 

The script to help reviewing/testing this PR is available in the sources: 
`nifi-nar-bundles/nifi-influxdb-bundle/InfluxDBIntegrationTests.sh`

Jakub



---

[jira] [Commented] (NIFI-5226) Implement a Record API based PutInfluxDB processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492591#comment-16492591
 ] 

ASF GitHub Bot commented on NIFI-5226:
--

Github user bednar commented on the issue:

https://github.com/apache/nifi/pull/2743
  
Hi NiFi team, this pull request is now ready to get reviewed. 

The script to help reviewing/testing this PR is available in the sources: 
`nifi-nar-bundles/nifi-influxdb-bundle/InfluxDBIntegrationTests.sh`

Jakub



> Implement a Record API based PutInfluxDB processor
> --
>
> Key: NIFI-5226
> URL: https://issues.apache.org/jira/browse/NIFI-5226
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Bonitoo4Influxdata Engineering
>Priority: Major
>  Labels: influx, processor, timeseries
> Fix For: 1.7.0
>
>
> Implement a new processor that uses the Record API to put data into InfluxDB.
> PutInfluxDBRecord features:
>  * Input can be any built-in or custom implemented NiFi RecordReader (json, 
> avro, csv, InfluxLineProtocolReader...)
>  * Configurable mapping between NiFi Records and InfluxDB measurement, field 
> and tags
>  * Configurable timestamp precision
>  * Reusable connection settings (InfluxDB url, password) for more processors 
> via InfluxDBService controller
>  * Advanced InfluxDB client settings
>  * 
>  ** Gzip compression
>  ** Batching, jitter, flush settings
> InfluxDBService features:
>  * InfluxDBService allows sharing connection configuration among more NiFi 
> processors.
>  * SSL support
> InfluxLineProtocolReader features
>  * InfluxLineProtocolReader parses the InfluxDB Line Protocol into NiFi 
> Record. This allows processing, filtering and partitioning data in NiFi 
> obtained from Telegraf agents, IoT devices, InfluxDB subscriptions and other 
> InfluxDB Line protocol devices.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5226) Implement a Record API based PutInfluxDB processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492513#comment-16492513
 ] 

ASF GitHub Bot commented on NIFI-5226:
--

GitHub user bednar opened a pull request:

https://github.com/apache/nifi/pull/2743

NIFI-5226: Implement a Record API based PutInfluxDB processor

- Added PutInfluxDBRecord for put data to InfluxDB by Apache NiFi Record API
- Added InfluxLineProtocolReader for parsing InfluxDB Line Protocol to 
Apache NiFi Record
- Added InfluxDBService for sharing connection settings to InfluxDB
- Upgraded influxdb-java to 2.10

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bonitoo-io/nifi nifi-5226

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2743.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2743


commit cd713cae8fff3c9036edb01519256a8458b2d12a
Author: Jakub Bednář 
Date:   2018-05-28T08:09:16Z

NIFI-5226: Implement a Record API based PutInfluxDB processor

- Added PutInfluxDBRecord for put data to InfluxDB by Apache NiFi Record API
- Added InfluxLineProtocolReader for parsing InfluxDB Line Protocol to 
Apache NiFi Record
- Added InfluxDBService for sharing connection settings to InfluxDB
- Upgraded influxdb-java to 2.10




> Implement a Record API based PutInfluxDB processor
> --
>
> Key: NIFI-5226
> URL: https://issues.apache.org/jira/browse/NIFI-5226
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Bonitoo4Influxdata Engineering
>Priority: Major
>  Labels: influx, processor, timeseries
> Fix For: 1.7.0
>
>
> Implement a new processor that uses the Record API to put data into InfluxDB.
> PutInfluxDBRecord features:
>  * Input can be any built-in or custom implemented NiFi RecordReader (json, 
> avro, csv, InfluxLineProtocolReader...)
>  * Configurable mapping between NiFi Records and InfluxDB measurement, field 
> and tags
>  * Configurable timestamp precision
>  * Reusable connection settings (InfluxDB url, password) for more processors 
> via InfluxDBService controller
>  * Advanced InfluxDB client settings
>  * 
>  ** Gzip compression
>  ** Batching, jitter, flush settings
> InfluxDBService features:
>  * InfluxDBService allows sharing connection configuration among more NiFi 
> processors.
>  * SSL support
> InfluxLineProtocolReader features
>  * InfluxLineProtocolReader parses the InfluxDB Line Protocol into NiFi 
> Record. This allows processing, filtering and partitioning data in NiFi 
> obtained from Telegraf agents, IoT devices, InfluxDB subscriptions and other 
> InfluxDB Line protocol devices.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2743: NIFI-5226: Implement a Record API based PutInfluxDB...

[bednar]

GitHub user bednar opened a pull request:

https://github.com/apache/nifi/pull/2743

NIFI-5226: Implement a Record API based PutInfluxDB processor

- Added PutInfluxDBRecord for put data to InfluxDB by Apache NiFi Record API
- Added InfluxLineProtocolReader for parsing InfluxDB Line Protocol to 
Apache NiFi Record
- Added InfluxDBService for sharing connection settings to InfluxDB
- Upgraded influxdb-java to 2.10

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bonitoo-io/nifi nifi-5226

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2743.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2743


commit cd713cae8fff3c9036edb01519256a8458b2d12a
Author: Jakub Bednář 
Date:   2018-05-28T08:09:16Z

NIFI-5226: Implement a Record API based PutInfluxDB processor

- Added PutInfluxDBRecord for put data to InfluxDB by Apache NiFi Record API
- Added InfluxLineProtocolReader for parsing InfluxDB Line Protocol to 
Apache NiFi Record
- Added InfluxDBService for sharing connection settings to InfluxDB
- Upgraded influxdb-java to 2.10




---

[jira] [Created] (NIFI-5245) SimpleCSVFileLookupService should take account of charset.

[Seiji Sogabe (JIRA)]

Seiji Sogabe created NIFI-5245:
--

 Summary: SimpleCSVFileLookupService should  take account of  
charset.
 Key: NIFI-5245
 URL: https://issues.apache.org/jira/browse/NIFI-5245
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core Framework
Affects Versions: 1.6.0
 Environment: Windows 10
Reporter: Seiji Sogabe


If charset of csv file is not default encoding on platform, 
SimpleCSVFileLookupService will lead to garbled characters.

CSVRecordLookupService also has the same problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5133) Create a processor to Publish and Subscribe to Google Pub/Sub

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492485#comment-16492485
 ] 

ASF GitHub Bot commented on NIFI-5133:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2724
  
Thanks for the update @zenfenan - I've played a bit with it and have two 
questions:
- does it make sense to expose both fetch count and batch size for the 
publish processor? Do we expect situations where numbers won't be the same?
- Not a huge user of the GC services but performances seemed really slow to 
me. Is that expected because I'm just using basic setup / free trial? Or is it 
just the Pub/Sub mechanism itself? Or is it something else on NiFi's side?


> Create a processor to Publish and Subscribe to Google Pub/Sub
> -
>
> Key: NIFI-5133
> URL: https://issues.apache.org/jira/browse/NIFI-5133
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.6.0
>Reporter: Abdelkrim Hadjidj
>Assignee: Sivaprasanna Sethuraman
>Priority: Major
>
> As a workflow designer, I would like to publish/subscribe messages to/from 
> Google Pub/Sub. This integration can enable several ingestion and realtime 
> use case where data is available on Google Cloud.
> There are few options that are outside the NiFi project:
> [https://github.com/ammitt90/nifi-pubsub-processor]
> [https://github.com/synack/nifi-gcp-pubsub-publisher]
> [https://github.com/synack/nifi-gcp-pubsub-consumer]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2724: NIFI-5133: Implemented Google Cloud PubSub Processors

[pvillard31]

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2724
  
Thanks for the update @zenfenan - I've played a bit with it and have two 
questions:
- does it make sense to expose both fetch count and batch size for the 
publish processor? Do we expect situations where numbers won't be the same?
- Not a huge user of the GC services but performances seemed really slow to 
me. Is that expected because I'm just using basic setup / free trial? Or is it 
just the Pub/Sub mechanism itself? Or is it something else on NiFi's side?


---

[jira] [Commented] (NIFI-4825) Processor is not shutting down normally

[Koji Kawamura (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492304#comment-16492304
 ] 

Koji Kawamura commented on NIFI-4825:
-

Hi [~ktj1312], it's been a while since you reported this JIRA, but do you still 
have the issue? I think the reason why you could not clear the queued FlowFiles 
was that ReplaceText was still running, or hanging at an unexpected place. The 
ReplaceText processor in your screenshot shows 2 at the right top corner, that 
means there were 2 threads running. One is processing, and holding the 100 
input FlowFiles, and the other is trying to stop the processor.

I recommend to take a thread dump by executing following command:
{code}
${NIFI_HOME}/bin/nifi.sh dump
{code}
The thread dump will be written to the nifi-bootstrap.log file. It will be 
useful to investigate the issue further. Please take the dump when you 
encountered this situation again.

> Processor is not shutting down normally
> ---
>
> Key: NIFI-4825
> URL: https://issues.apache.org/jira/browse/NIFI-4825
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Core UI
>Affects Versions: 1.4.0, 1.5.0
> Environment: Clustering with 3 Node and Seperated 3 zookeeper
>Reporter: kim teak jin
>Priority: Critical
> Attachments: error_template (1).xml, 
> image-2018-01-29-13-55-07-904.png, image-2018-01-29-13-55-56-745.png
>
>
> Hi dear Nifi users and Developers.
> If Json type time, created by default, is inserted, the problem did not 
> recognize the type as ISODate in MongoDB and is using ReplaceText processor 
> to resolve this.
> Now the input to MongoDB is working well, but there is another problem.
> So was v1.4, and I currently have updated to v1.5.
> The same phenomenon is occurring later but when the processor is not 
> operational anymore, the input queue becomes full approximately one day after 
> it starts on the ReplaceText processor.
> So I stopped the processor and tried to erase the queue and the processor in 
> front of it, but that didn't work.
> The following picture is a message that happens when I try to clear the queue.
> !image-2018-01-29-13-55-56-745.png!
> Now I think this is very important to me and if it continues to happen, I 
> think I will have to take a different solution.
> This is because it occurs continuously even if the queue can be deleted 
> normally after stopping and re-enabled successfully.
> So, temporarily, I copy the processor and know that it is not the right 
> solution though I am doing first aid such as photo.
> !image-2018-01-29-13-55-07-904.png!
> Currently, the left processor shows up as an inactive halt, but buttons such 
> as setting window and starting to stop do not appear.
>  I am attaching my template here, so please do not hesitate to deal with the 
> issue quickly.
>  
> We look forward to a speedy handling of the issues involved.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)