[jira] [Commented] (NIFI-6019) Remove Trusted Hostname property from InvokeHTTP processor
[
https://issues.apache.org/jira/browse/NIFI-6019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832981#comment-16832981
]
Andy LoPresto commented on NIFI-6019:
-
I can update the wiki with your proposed changes, or show you how to do that as
well. Thanks for the contribution.
> Remove Trusted Hostname property from InvokeHTTP processor
> --
>
> Key: NIFI-6019
> URL: https://issues.apache.org/jira/browse/NIFI-6019
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.8.0
>Reporter: Andy LoPresto
>Assignee: Troy Melhase
>Priority: Major
> Labels: InvokeHTTP, certificate, hostname, http, security, tls
> Fix For: 1.10.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The {{Trusted Hostname}} property in the {{InvokeHTTP}} processor is a legacy
> property created for a specific use in constrained environments. It now
> causes more problems than it solves ([mailing list
> questions|https://lists.apache.org/list.html?us...@nifi.apache.org:gte=1d:trusted%20hostname])
> and should not be provided as it is a security risk. Removing this property
> and encouraging users to correctly deploy TLS certificates when necessary is
> the correct path forward.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFI-6019) Remove Trusted Hostname property from InvokeHTTP processor
[
https://issues.apache.org/jira/browse/NIFI-6019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-6019:
Resolution: Fixed
Fix Version/s: 1.10.0
Status: Resolved (was: Patch Available)
> Remove Trusted Hostname property from InvokeHTTP processor
> --
>
> Key: NIFI-6019
> URL: https://issues.apache.org/jira/browse/NIFI-6019
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.8.0
>Reporter: Andy LoPresto
>Assignee: Troy Melhase
>Priority: Major
> Labels: InvokeHTTP, certificate, hostname, http, security, tls
> Fix For: 1.10.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The {{Trusted Hostname}} property in the {{InvokeHTTP}} processor is a legacy
> property created for a specific use in constrained environments. It now
> causes more problems than it solves ([mailing list
> questions|https://lists.apache.org/list.html?us...@nifi.apache.org:gte=1d:trusted%20hostname])
> and should not be provided as it is a security risk. Removing this property
> and encouraging users to correctly deploy TLS certificates when necessary is
> the correct path forward.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFI-6019) Remove Trusted Hostname property from InvokeHTTP processor
[
https://issues.apache.org/jira/browse/NIFI-6019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-6019:
Status: Patch Available (was: Open)
> Remove Trusted Hostname property from InvokeHTTP processor
> --
>
> Key: NIFI-6019
> URL: https://issues.apache.org/jira/browse/NIFI-6019
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.8.0
>Reporter: Andy LoPresto
>Assignee: Troy Melhase
>Priority: Major
> Labels: InvokeHTTP, certificate, hostname, http, security, tls
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The {{Trusted Hostname}} property in the {{InvokeHTTP}} processor is a legacy
> property created for a specific use in constrained environments. It now
> causes more problems than it solves ([mailing list
> questions|https://lists.apache.org/list.html?us...@nifi.apache.org:gte=1d:trusted%20hostname])
> and should not be provided as it is a security risk. Removing this property
> and encouraging users to correctly deploy TLS certificates when necessary is
> the correct path forward.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [nifi] asfgit closed pull request #3452: NIFI-6019 Removes "trusted hostname" property
asfgit closed pull request #3452: NIFI-6019 Removes "trusted hostname" property URL: https://github.com/apache/nifi/pull/3452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6019) Remove Trusted Hostname property from InvokeHTTP processor
[
https://issues.apache.org/jira/browse/NIFI-6019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832979#comment-16832979
]
ASF subversion and git services commented on NIFI-6019:
---
Commit 1cadc79ad50cf569ee107eaeeb95dc216ea2 in nifi's branch
refs/heads/master from Troy Melhase
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1cadc72 ]
NIFI-6019 Removes "trusted hostname" property.
NIFI-6019 Adds support for excluded HTTP headers.
This closes #3452.
Signed-off-by: Andy LoPresto
> Remove Trusted Hostname property from InvokeHTTP processor
> --
>
> Key: NIFI-6019
> URL: https://issues.apache.org/jira/browse/NIFI-6019
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.8.0
>Reporter: Andy LoPresto
>Assignee: Troy Melhase
>Priority: Major
> Labels: InvokeHTTP, certificate, hostname, http, security, tls
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The {{Trusted Hostname}} property in the {{InvokeHTTP}} processor is a legacy
> property created for a specific use in constrained environments. It now
> causes more problems than it solves ([mailing list
> questions|https://lists.apache.org/list.html?us...@nifi.apache.org:gte=1d:trusted%20hostname])
> and should not be provided as it is a security risk. Removing this property
> and encouraging users to correctly deploy TLS certificates when necessary is
> the correct path forward.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-6019) Remove Trusted Hostname property from InvokeHTTP processor
[
https://issues.apache.org/jira/browse/NIFI-6019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832980#comment-16832980
]
ASF subversion and git services commented on NIFI-6019:
---
Commit 1cadc79ad50cf569ee107eaeeb95dc216ea2 in nifi's branch
refs/heads/master from Troy Melhase
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1cadc72 ]
NIFI-6019 Removes "trusted hostname" property.
NIFI-6019 Adds support for excluded HTTP headers.
This closes #3452.
Signed-off-by: Andy LoPresto
> Remove Trusted Hostname property from InvokeHTTP processor
> --
>
> Key: NIFI-6019
> URL: https://issues.apache.org/jira/browse/NIFI-6019
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.8.0
>Reporter: Andy LoPresto
>Assignee: Troy Melhase
>Priority: Major
> Labels: InvokeHTTP, certificate, hostname, http, security, tls
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The {{Trusted Hostname}} property in the {{InvokeHTTP}} processor is a legacy
> property created for a specific use in constrained environments. It now
> causes more problems than it solves ([mailing list
> questions|https://lists.apache.org/list.html?us...@nifi.apache.org:gte=1d:trusted%20hostname])
> and should not be provided as it is a security risk. Removing this property
> and encouraging users to correctly deploy TLS certificates when necessary is
> the correct path forward.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [nifi] alopresto commented on issue #3452: NIFI-6019 Removes "trusted hostname" property
alopresto commented on issue #3452: NIFI-6019 Removes "trusted hostname" property URL: https://github.com/apache/nifi/pull/3452#issuecomment-489290566 Ran `contrib-check` and all tests pass. +1, merging. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] alopresto commented on issue #3452: NIFI-6019 Removes "trusted hostname" property
alopresto commented on issue #3452: NIFI-6019 Removes "trusted hostname" property URL: https://github.com/apache/nifi/pull/3452#issuecomment-489290485 Ran tests using a flow on a prior version of NiFi connecting to `https://google.com` with the **Trusted Hostname** property set, then copying the flow to a version of NiFi with this PR applied. The expected bulletin was shown and the log message was present in the `nifi-app.log` file.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] alopresto commented on issue #3457: NIFI-4247 Support ranges in `tls-toolkit` SAN cli option.
alopresto commented on issue #3457: NIFI-4247 Support ranges in `tls-toolkit` SAN cli option. URL: https://github.com/apache/nifi/pull/3457#issuecomment-489286968 I also made a trivial formatting fix. You can pull from [alopresto/nifi-4247-a](https://github.com/alopresto/nifi/commit/555a30c2f6ee6dc674a145c89f685c92df03c6a5), but it's likely faster to just remove the space manually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] alopresto edited a comment on issue #3457: NIFI-4247 Support ranges in `tls-toolkit` SAN cli option.
alopresto edited a comment on issue #3457: NIFI-4247 Support ranges in `tls-toolkit` SAN cli option. URL: https://github.com/apache/nifi/pull/3457#issuecomment-489286383 Troy, this looks like great work. I would like to see more explicit unit test cases added, but I understand that the toolkit testing can sometimes be difficult because of the tight coupling with `System.exit()`, etc. I ran a number of scenarios and I've pasted my results below to document. Only one scenario (#7) failed, and one (#1) had a possible minor improvement. ## 1. Static hostname, no SAN Expected output: 1 generated keystore containing 1 certificate with single hostname and 1 SAN entry (1 hostname) Result: **PASS** (with minor improvement) ``` ...NAPSHOT-bin/nifi-toolkit-1.10.0-SNAPSHOT (pr3457) 😉 🔓 0s @ 19:06:33 $ ./bin/tls-toolkit.sh standalone -n static.nifi.apache.org 2019/05/03 19:06:47 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandaloneCommandLine: No nifiPropertiesFile specified, using embedded one. 2019/05/03 19:06:47 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Running standalone certificate generation with output directory ../nifi-toolkit-1.10.0-SNAPSHOT 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Generated new CA certificate ../nifi-toolkit-1.10.0-SNAPSHOT/nifi-cert.pem and key ../nifi-toolkit-1.10.0-SNAPSHOT/nifi-key.key 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Hostname count does not match given alternate name count. Verify names in resulting certificate. 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Writing new ssl configuration to ../nifi-toolkit-1.10.0-SNAPSHOT/static.nifi.apache.org 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Successfully generated TLS configuration for static.nifi.apache.org 1 in ../nifi-toolkit-1.10.0-SNAPSHOT/static.nifi.apache.org 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: No clientCertDn specified, not generating any client certificates. 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: tls-toolkit standalone completed successfully ...NAPSHOT-bin/nifi-toolkit-1.10.0-SNAPSHOT (pr3457) 😉 🔓 1s @ 19:06:48 $ keytool -list -v -keystore static.nifi.apache.org/keystore.jks ... Your keystore contains 1 entry Alias name: nifi-key Creation date: May 3, 2019 Entry type: PrivateKeyEntry Certificate chain length: 2 Certificate[1]: Owner: CN=static.nifi.apache.org, OU=NIFI Issuer: CN=localhost, OU=NIFI ... #5: ObjectId: 2.5.29.17 Criticality=false SubjectAlternativeName [ DNSName: static.nifi.apache.org ] ... ``` ### Notes: * Remove log output that "hostname count does not match SAN count" when no SAN provided ## 2. Static hostname, static SAN Expected output: 1 generated keystore containing 1 certificate with single hostname and 2 SAN entries (1 hostname, 1 alternate name) Result: **PASS** ``` ...NAPSHOT-bin/nifi-toolkit-1.10.0-SNAPSHOT (pr3457) 😉 🔓 0s @ 19:09:43 $ ./bin/tls-toolkit.sh standalone -n static.nifi.apache.org --subjectAlternativeName alternative.nifi.apache.org 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandaloneCommandLine: No nifiPropertiesFile specified, using embedded one. 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Running standalone certificate generation with output directory ../nifi-toolkit-1.10.0-SNAPSHOT 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.util.TlsHelper: Verifying the certificate signature for CN=localhost,OU=NIFI 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.util.TlsHelper: Attempting to verify certificate CN=localhost,OU=NIFI signature with CN=localhost,OU=NIFI 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.util.TlsHelper: Certificate was signed by CN=localhost,OU=NIFI 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Using existing CA certificate ../nifi-toolkit-1.10.0-SNAPSHOT/nifi-cert.pem and key ../nifi-toolkit-1.10.0-SNAPSHOT/nifi-key.key 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Writing new ssl configuration to ../nifi-toolkit-1.10.0-SNAPSHOT/static.nifi.apache.org 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Successfully generated TLS configuration for static.nifi.apache.org 1 in ../nifi-toolkit-1.10.0-SNAPSHOT/static.nifi.apache.org 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandal
[GitHub] [nifi] alopresto commented on issue #3457: NIFI-4247 Support ranges in `tls-toolkit` SAN cli option.
alopresto commented on issue #3457: NIFI-4247 Support ranges in `tls-toolkit` SAN cli option. URL: https://github.com/apache/nifi/pull/3457#issuecomment-489286383 Troy, this looks like great work. I would like to see more explicit unit test cases added, but I understand that the toolkit testing can sometimes be difficult because of the tight coupling with `System.exit()`, etc. I ran a number of scenarios and I've pasted my results below to document. ## Static hostname, no SAN Expected output: 1 generated keystore containing 1 certificate with single hostname and 1 SAN entry (1 hostname) ``` ...NAPSHOT-bin/nifi-toolkit-1.10.0-SNAPSHOT (pr3457) 😉 🔓 0s @ 19:06:33 $ ./bin/tls-toolkit.sh standalone -n static.nifi.apache.org 2019/05/03 19:06:47 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandaloneCommandLine: No nifiPropertiesFile specified, using embedded one. 2019/05/03 19:06:47 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Running standalone certificate generation with output directory ../nifi-toolkit-1.10.0-SNAPSHOT 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Generated new CA certificate ../nifi-toolkit-1.10.0-SNAPSHOT/nifi-cert.pem and key ../nifi-toolkit-1.10.0-SNAPSHOT/nifi-key.key 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Hostname count does not match given alternate name count. Verify names in resulting certificate. 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Writing new ssl configuration to ../nifi-toolkit-1.10.0-SNAPSHOT/static.nifi.apache.org 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Successfully generated TLS configuration for static.nifi.apache.org 1 in ../nifi-toolkit-1.10.0-SNAPSHOT/static.nifi.apache.org 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: No clientCertDn specified, not generating any client certificates. 2019/05/03 19:06:48 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: tls-toolkit standalone completed successfully ...NAPSHOT-bin/nifi-toolkit-1.10.0-SNAPSHOT (pr3457) 😉 🔓 1s @ 19:06:48 $ keytool -list -v -keystore static.nifi.apache.org/keystore.jks ... Your keystore contains 1 entry Alias name: nifi-key Creation date: May 3, 2019 Entry type: PrivateKeyEntry Certificate chain length: 2 Certificate[1]: Owner: CN=static.nifi.apache.org, OU=NIFI Issuer: CN=localhost, OU=NIFI ... #5: ObjectId: 2.5.29.17 Criticality=false SubjectAlternativeName [ DNSName: static.nifi.apache.org ] ... ``` ### Notes: * Remove log output that "hostname count does not match SAN count" when no SAN provided ## Static hostname, static SAN Expected output: 1 generated keystore containing 1 certificate with single hostname and 2 SAN entries (1 hostname, 1 alternate name) ``` ...NAPSHOT-bin/nifi-toolkit-1.10.0-SNAPSHOT (pr3457) 😉 🔓 0s @ 19:09:43 $ ./bin/tls-toolkit.sh standalone -n static.nifi.apache.org --subjectAlternativeName alternative.nifi.apache.org 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandaloneCommandLine: No nifiPropertiesFile specified, using embedded one. 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Running standalone certificate generation with output directory ../nifi-toolkit-1.10.0-SNAPSHOT 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.util.TlsHelper: Verifying the certificate signature for CN=localhost,OU=NIFI 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.util.TlsHelper: Attempting to verify certificate CN=localhost,OU=NIFI signature with CN=localhost,OU=NIFI 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.util.TlsHelper: Certificate was signed by CN=localhost,OU=NIFI 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Using existing CA certificate ../nifi-toolkit-1.10.0-SNAPSHOT/nifi-cert.pem and key ../nifi-toolkit-1.10.0-SNAPSHOT/nifi-key.key 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Writing new ssl configuration to ../nifi-toolkit-1.10.0-SNAPSHOT/static.nifi.apache.org 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: Successfully generated TLS configuration for static.nifi.apache.org 1 in ../nifi-toolkit-1.10.0-SNAPSHOT/static.nifi.apache.org 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandalone: No clientCertDn specified, not generating any client certificates. 2019/05/03 19:10:13 INFO [main] org.apache.nifi.toolkit.tls.standalone.TlsToolki
[GitHub] [nifi] MikeThomsen commented on issue #3317: NIFI-6047 Add DetectDuplicateRecord Processor
MikeThomsen commented on issue #3317: NIFI-6047 Add DetectDuplicateRecord Processor URL: https://github.com/apache/nifi/pull/3317#issuecomment-489273250 @adamfisher Sorry about not getting back sooner. Been very busy with a lot of work projects. Appears you missed a few files in your commit: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.0:testCompile (default-testCompile) on project nifi-standard-processors: Compilation failure: Compilation failure: [ERROR] /home/travis/build/apache/nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestDetectDuplicateRecord.java:[45,12] error: cannot find symbol [ERROR] symbol: class MockCacheService [ERROR] location: class TestDetectDuplicateRecord [ERROR] /home/travis/build/apache/nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestDetectDuplicateRecord.java:[76,20] error: cannot find symbol [ERROR] symbol: class MockCacheService [ERROR] location: class TestDetectDuplicateRecord [ERROR] -> [Help 1] [ERROR] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6264) Version migration fails when flow contains only Controller Service
Mark Bean created NIFI-6264: --- Summary: Version migration fails when flow contains only Controller Service Key: NIFI-6264 URL: https://issues.apache.org/jira/browse/NIFI-6264 Project: Apache NiFi Issue Type: Bug Affects Versions: 1.9.2 Reporter: Mark Bean When upgrading NiFi, Components are naturally migrated to the latest version (when that is the only version available.) However, if the flow contains only a Controller Service with no other Components on the graph, NiFi fails to start throwing a MissingBundleException. The following is a snippet from nifi-app.log as an example: org.apache.nifi.controller.MissingBundleException: org.apache.nifi.ssl.StandardRestrictedSSLContextService from org.apache.nifi:nifi-ssl-context-service-nar:1.8.0 is not known to this NiFi instance. If a single processor placed on the graph, the Procesor and Controller Service are appropriately migrated to the available version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi-fds] scottyaslan opened a new pull request #20: [NIFI-6263] theme links style color
scottyaslan opened a new pull request #20: [NIFI-6263] theme links style color URL: https://github.com/apache/nifi-fds/pull/20 Thank you for submitting a contribution to Apache NiFi Flow Design System. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with either NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you ensured that a full build and that the full suite of unit tests is executed via npm run clean:install at the root nifi-fds folder? - [ ] Have you written or updated the Apache NiFi Flow Design System demo application to demonstrate any new functionality, provide examples of usage, and to verify your changes via npm start at the nifi-fds/target folder? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-fds? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-fds? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6263) create @mixin for link styles
Scott Aslan created NIFI-6263: - Summary: create @mixin for link styles Key: NIFI-6263 URL: https://issues.apache.org/jira/browse/NIFI-6263 Project: Apache NiFi Issue Type: Improvement Components: FDS Affects Versions: fds-0.2 Reporter: Scott Aslan Assignee: Scott Aslan Fix For: fds-0.2 Create SASS mixin to allow link styles to match the accent color of the theme. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-6262) Uprgrade to nifi-nar-maven-plugin 1.3.0
Bryan Bende created NIFI-6262: - Summary: Uprgrade to nifi-nar-maven-plugin 1.3.0 Key: NIFI-6262 URL: https://issues.apache.org/jira/browse/NIFI-6262 Project: Apache NiFi Issue Type: Improvement Reporter: Bryan Bende Assignee: Bryan Bende Fix For: 1.10.0 Upgrade version of nifi-nar-maven-plugin to recently released 1.3.0, and update any references to using Maven 3.1.0 to 3.1.1. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (NIFI-6248) Conduct Apache NiFi NAR Maven Plugin 1.3.0 release
[ https://issues.apache.org/jira/browse/NIFI-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFI-6248. --- Resolution: Fixed > Conduct Apache NiFi NAR Maven Plugin 1.3.0 release > -- > > Key: NIFI-6248 > URL: https://issues.apache.org/jira/browse/NIFI-6248 > Project: Apache NiFi > Issue Type: Task >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Fix For: nifi-nar-maven-plugin-1.3.0 > > > Perform RM duties for Apache NiFi NAR Maven Plugin 1.3.0 release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi-fds] scottyaslan opened a new pull request #19: [NIFI-6261] Create a @mixin to leverage the theme color in the .td-dat…
scottyaslan opened a new pull request #19: [NIFI-6261] Create a @mixin to leverage the theme color in the .td-dat… URL: https://github.com/apache/nifi-fds/pull/19 …a-table-cell classes. Thank you for submitting a contribution to Apache NiFi Flow Design System. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with either NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you ensured that a full build and that the full suite of unit tests is executed via npm run clean:install at the root nifi-fds folder? - [ ] Have you written or updated the Apache NiFi Flow Design System demo application to demonstrate any new functionality, provide examples of usage, and to verify your changes via npm start at the nifi-fds/target folder? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-fds? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-fds? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] bbende opened a new pull request #181: NIFIREG-267 Updating data model to capture parameter contexts
bbende opened a new pull request #181: NIFIREG-267 Updating data model to capture parameter contexts URL: https://github.com/apache/nifi-registry/pull/181 - Introducing v3 of flow serialization to switch to serializing VersionedFlowSnapshot instead of VersionedProcessGroup This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFIREG-267) Update data model to capture parameter contexts
Bryan Bende created NIFIREG-267: --- Summary: Update data model to capture parameter contexts Key: NIFIREG-267 URL: https://issues.apache.org/jira/browse/NIFIREG-267 Project: NiFi Registry Issue Type: Improvement Reporter: Bryan Bende Assignee: Bryan Bende Fix For: 0.4.0 As described in the NiFi feature proposal for parameterized flows, we need to update the registry data model to capture parameter contexts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-6261) theme .td-data-table-cell
Scott Aslan created NIFI-6261: - Summary: theme .td-data-table-cell Key: NIFI-6261 URL: https://issues.apache.org/jira/browse/NIFI-6261 Project: Apache NiFi Issue Type: Bug Components: FDS Affects Versions: fds-0.2 Reporter: Scott Aslan Assignee: Scott Aslan Fix For: fds-0.2 Create a mixin to leverage the theme color in the .td-data-table-cell classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-6260) update .md-title and .md-subhead font weight and color
[ https://issues.apache.org/jira/browse/NIFI-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-6260: -- Status: Patch Available (was: In Progress) > update .md-title and .md-subhead font weight and color > -- > > Key: NIFI-6260 > URL: https://issues.apache.org/jira/browse/NIFI-6260 > Project: Apache NiFi > Issue Type: Bug > Components: FDS >Affects Versions: fds-0.2 >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Minor > Fix For: fds-0.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi-fds] scottyaslan opened a new pull request #18: Nifi 6260
scottyaslan opened a new pull request #18: Nifi 6260 URL: https://github.com/apache/nifi-fds/pull/18 Thank you for submitting a contribution to Apache NiFi Flow Design System. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with either NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you ensured that a full build and that the full suite of unit tests is executed via npm run clean:install at the root nifi-fds folder? - [ ] Have you written or updated the Apache NiFi Flow Design System demo application to demonstrate any new functionality, provide examples of usage, and to verify your changes via npm start at the nifi-fds/target folder? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-fds? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-fds? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (NIFIREG-266) Introduce automated UI testing
[ https://issues.apache.org/jira/browse/NIFIREG-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lim reassigned NIFIREG-266: -- Assignee: Andrew Lim > Introduce automated UI testing > -- > > Key: NIFIREG-266 > URL: https://issues.apache.org/jira/browse/NIFIREG-266 > Project: NiFi Registry > Issue Type: Task >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFIREG-266) Introduce automated UI testing
Andrew Lim created NIFIREG-266: -- Summary: Introduce automated UI testing Key: NIFIREG-266 URL: https://issues.apache.org/jira/browse/NIFIREG-266 Project: NiFi Registry Issue Type: Task Reporter: Andrew Lim -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-6260) update .md-title and .md-subhead font weight and color
Scott Aslan created NIFI-6260: - Summary: update .md-title and .md-subhead font weight and color Key: NIFI-6260 URL: https://issues.apache.org/jira/browse/NIFI-6260 Project: Apache NiFi Issue Type: Bug Components: FDS Affects Versions: fds-0.2 Reporter: Scott Aslan Assignee: Scott Aslan Fix For: fds-0.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi-fds] scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating checkbox components to use the theme accent colors.
scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating
checkbox components to use the theme accent colors.
URL: https://github.com/apache/nifi-fds/pull/17#discussion_r280863959
##
File path: src/platform/core/common/styles/_checkboxes.scss
##
@@ -17,69 +17,84 @@
/* Checkboxes */
-body[fds] .mat-checkbox-inner-container {
- height: 10px !important;
- width: 10px !important;
-}
+@mixin fds-checkboxes-theme($theme) {
+ $primaryColor: map-get(map-get($theme, primary), 500);
+ $primaryColorHover: map-get(map-get($theme, primary), 100);
+ $accentColor: map-get(map-get($theme, accent), 500);
+ $accentColorHover: map-get(map-get($theme, accent), 100);
-body[fds] .mat-checkbox-frame {
- height: 10px;
- width: 10px;
- border-color: $grey7;
-}
+ body[fds] {
+.mat-checkbox-inner-container {
+ height: 10px !important;
+ width: 10px !important;
+ margin-right: 5px;
-body[fds] .mat-checkbox-ripple {
- left: -7px;
- top: -7px;
- right: -7px;
- bottom: -7px;
-}
+ &:hover {
+background-color: $accentColor;
+border-radius: 2px;
+ }
+}
-body[fds] .mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
-body[fds] .mat-checkbox-checked.mat-accent .mat-checkbox-background {
- background-color: $blue-grey1;
-}
+.mat-checkbox-frame {
+ height: 10px;
+ width: 10px;
+ border-color: $grey7;
+}
-body[fds] .mat-checkbox-inner-container:hover {
- background-color: $blue-grey1;
- border-radius: 2px;
-}
+.mat-checkbox-ripple {
+ left: -19px;
+ top: -19px;
+ right: -7px;
+ bottom: -7px;
+}
-body[fds] .mat-checkbox-background {
- height: 10px;
- width: 10px;
-}
+.mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
+.mat-checkbox-checked.mat-accent .mat-checkbox-background {
+ background-color: $accentColor;
+}
-/* Covalent TdDataTableComponent 'selectable' property checkboxes */
+.mat-checkbox-background {
+ height: 10px;
+ width: 10px;
+}
-body[fds] .mat-pseudo-checkbox {
- height: 10px !important;
- width: 10px !important;
- border: 1px solid $grey7;
-}
+/* Covalent TdDataTableComponent 'selectable' property checkboxes */
-body[fds] .mat-pseudo-checkbox:hover {
- background-color: $blue-grey1;
- border: 1px solid $blue-grey1;
-}
+.mat-pseudo-checkbox {
+ height: 10px !important;
+ width: 10px !important;
+ border: 1px solid $grey7;
+}
-body[fds] .mat-pseudo-checkbox-checked::after {
- content: '\f00c';
- font-size: 8px;
- font-family: fontawesome;
- margin-top: -9px;
- margin-left: -1px;
- border: none;
- transform: initial;
-}
+.mat-pseudo-checkbox:hover {
+ background-color: $blue-grey1;
+ border: 1px solid $blue-grey1;
+}
-body[fds] .mat-pseudo-checkbox-checked, body[fds]
.mat-pseudo-checkbox-indeterminate {
- background-color: $blue-grey1;
- border: 1px solid $blue-grey1;
- height: 10px;
- width: 10px;
-}
+.mat-pseudo-checkbox-checked::after {
+ content: '\f00c';
+ font-size: 8px;
+ font-family: fontawesome;
+ margin-top: -9px;
+ margin-left: -1px;
+ border: none;
+ transform: initial;
+}
+
+.mat-pseudo-checkbox-checked,
Review comment:
Please delete this style it is not used in nifi-fds
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-fds] scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating checkbox components to use the theme accent colors.
scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating
checkbox components to use the theme accent colors.
URL: https://github.com/apache/nifi-fds/pull/17#discussion_r280864085
##
File path: src/platform/core/common/styles/_checkboxes.scss
##
@@ -17,69 +17,84 @@
/* Checkboxes */
-body[fds] .mat-checkbox-inner-container {
- height: 10px !important;
- width: 10px !important;
-}
+@mixin fds-checkboxes-theme($theme) {
+ $primaryColor: map-get(map-get($theme, primary), 500);
+ $primaryColorHover: map-get(map-get($theme, primary), 100);
+ $accentColor: map-get(map-get($theme, accent), 500);
+ $accentColorHover: map-get(map-get($theme, accent), 100);
-body[fds] .mat-checkbox-frame {
- height: 10px;
- width: 10px;
- border-color: $grey7;
-}
+ body[fds] {
+.mat-checkbox-inner-container {
+ height: 10px !important;
+ width: 10px !important;
+ margin-right: 5px;
-body[fds] .mat-checkbox-ripple {
- left: -7px;
- top: -7px;
- right: -7px;
- bottom: -7px;
-}
+ &:hover {
+background-color: $accentColor;
+border-radius: 2px;
+ }
+}
-body[fds] .mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
-body[fds] .mat-checkbox-checked.mat-accent .mat-checkbox-background {
- background-color: $blue-grey1;
-}
+.mat-checkbox-frame {
+ height: 10px;
+ width: 10px;
+ border-color: $grey7;
+}
-body[fds] .mat-checkbox-inner-container:hover {
- background-color: $blue-grey1;
- border-radius: 2px;
-}
+.mat-checkbox-ripple {
+ left: -19px;
+ top: -19px;
+ right: -7px;
+ bottom: -7px;
+}
-body[fds] .mat-checkbox-background {
- height: 10px;
- width: 10px;
-}
+.mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
+.mat-checkbox-checked.mat-accent .mat-checkbox-background {
+ background-color: $accentColor;
+}
-/* Covalent TdDataTableComponent 'selectable' property checkboxes */
+.mat-checkbox-background {
+ height: 10px;
+ width: 10px;
+}
-body[fds] .mat-pseudo-checkbox {
- height: 10px !important;
- width: 10px !important;
- border: 1px solid $grey7;
-}
+/* Covalent TdDataTableComponent 'selectable' property checkboxes */
-body[fds] .mat-pseudo-checkbox:hover {
- background-color: $blue-grey1;
- border: 1px solid $blue-grey1;
-}
+.mat-pseudo-checkbox {
Review comment:
Please delete this style it is not used in nifi-fds
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-fds] scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating checkbox components to use the theme accent colors.
scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating
checkbox components to use the theme accent colors.
URL: https://github.com/apache/nifi-fds/pull/17#discussion_r280864016
##
File path: src/platform/core/common/styles/_checkboxes.scss
##
@@ -17,69 +17,84 @@
/* Checkboxes */
-body[fds] .mat-checkbox-inner-container {
- height: 10px !important;
- width: 10px !important;
-}
+@mixin fds-checkboxes-theme($theme) {
+ $primaryColor: map-get(map-get($theme, primary), 500);
+ $primaryColorHover: map-get(map-get($theme, primary), 100);
+ $accentColor: map-get(map-get($theme, accent), 500);
+ $accentColorHover: map-get(map-get($theme, accent), 100);
-body[fds] .mat-checkbox-frame {
- height: 10px;
- width: 10px;
- border-color: $grey7;
-}
+ body[fds] {
+.mat-checkbox-inner-container {
+ height: 10px !important;
+ width: 10px !important;
+ margin-right: 5px;
-body[fds] .mat-checkbox-ripple {
- left: -7px;
- top: -7px;
- right: -7px;
- bottom: -7px;
-}
+ &:hover {
+background-color: $accentColor;
+border-radius: 2px;
+ }
+}
-body[fds] .mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
-body[fds] .mat-checkbox-checked.mat-accent .mat-checkbox-background {
- background-color: $blue-grey1;
-}
+.mat-checkbox-frame {
+ height: 10px;
+ width: 10px;
+ border-color: $grey7;
+}
-body[fds] .mat-checkbox-inner-container:hover {
- background-color: $blue-grey1;
- border-radius: 2px;
-}
+.mat-checkbox-ripple {
+ left: -19px;
+ top: -19px;
+ right: -7px;
+ bottom: -7px;
+}
-body[fds] .mat-checkbox-background {
- height: 10px;
- width: 10px;
-}
+.mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
+.mat-checkbox-checked.mat-accent .mat-checkbox-background {
+ background-color: $accentColor;
+}
-/* Covalent TdDataTableComponent 'selectable' property checkboxes */
+.mat-checkbox-background {
+ height: 10px;
+ width: 10px;
+}
-body[fds] .mat-pseudo-checkbox {
- height: 10px !important;
- width: 10px !important;
- border: 1px solid $grey7;
-}
+/* Covalent TdDataTableComponent 'selectable' property checkboxes */
-body[fds] .mat-pseudo-checkbox:hover {
- background-color: $blue-grey1;
- border: 1px solid $blue-grey1;
-}
+.mat-pseudo-checkbox {
+ height: 10px !important;
+ width: 10px !important;
+ border: 1px solid $grey7;
+}
-body[fds] .mat-pseudo-checkbox-checked::after {
- content: '\f00c';
- font-size: 8px;
- font-family: fontawesome;
- margin-top: -9px;
- margin-left: -1px;
- border: none;
- transform: initial;
-}
+.mat-pseudo-checkbox:hover {
+ background-color: $blue-grey1;
+ border: 1px solid $blue-grey1;
+}
-body[fds] .mat-pseudo-checkbox-checked, body[fds]
.mat-pseudo-checkbox-indeterminate {
- background-color: $blue-grey1;
- border: 1px solid $blue-grey1;
- height: 10px;
- width: 10px;
-}
+.mat-pseudo-checkbox-checked::after {
Review comment:
Please delete this style it is not used in nifi-fds
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-fds] scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating checkbox components to use the theme accent colors.
scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating
checkbox components to use the theme accent colors.
URL: https://github.com/apache/nifi-fds/pull/17#discussion_r280864140
##
File path: src/platform/core/common/styles/_checkboxes.scss
##
@@ -17,69 +17,84 @@
/* Checkboxes */
-body[fds] .mat-checkbox-inner-container {
- height: 10px !important;
- width: 10px !important;
-}
+@mixin fds-checkboxes-theme($theme) {
+ $primaryColor: map-get(map-get($theme, primary), 500);
+ $primaryColorHover: map-get(map-get($theme, primary), 100);
+ $accentColor: map-get(map-get($theme, accent), 500);
+ $accentColorHover: map-get(map-get($theme, accent), 100);
-body[fds] .mat-checkbox-frame {
- height: 10px;
- width: 10px;
- border-color: $grey7;
-}
+ body[fds] {
+.mat-checkbox-inner-container {
+ height: 10px !important;
+ width: 10px !important;
+ margin-right: 5px;
-body[fds] .mat-checkbox-ripple {
- left: -7px;
- top: -7px;
- right: -7px;
- bottom: -7px;
-}
+ &:hover {
+background-color: $accentColor;
+border-radius: 2px;
+ }
+}
-body[fds] .mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
-body[fds] .mat-checkbox-checked.mat-accent .mat-checkbox-background {
- background-color: $blue-grey1;
-}
+.mat-checkbox-frame {
+ height: 10px;
+ width: 10px;
+ border-color: $grey7;
+}
-body[fds] .mat-checkbox-inner-container:hover {
- background-color: $blue-grey1;
- border-radius: 2px;
-}
+.mat-checkbox-ripple {
+ left: -19px;
+ top: -19px;
+ right: -7px;
+ bottom: -7px;
+}
-body[fds] .mat-checkbox-background {
- height: 10px;
- width: 10px;
-}
+.mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
+.mat-checkbox-checked.mat-accent .mat-checkbox-background {
+ background-color: $accentColor;
+}
-/* Covalent TdDataTableComponent 'selectable' property checkboxes */
+.mat-checkbox-background {
+ height: 10px;
+ width: 10px;
+}
-body[fds] .mat-pseudo-checkbox {
- height: 10px !important;
- width: 10px !important;
- border: 1px solid $grey7;
-}
+/* Covalent TdDataTableComponent 'selectable' property checkboxes */
Review comment:
Please delete this comment
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-fds] scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating checkbox components to use the theme accent colors.
scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating
checkbox components to use the theme accent colors.
URL: https://github.com/apache/nifi-fds/pull/17#discussion_r280864068
##
File path: src/platform/core/common/styles/_checkboxes.scss
##
@@ -17,69 +17,84 @@
/* Checkboxes */
-body[fds] .mat-checkbox-inner-container {
- height: 10px !important;
- width: 10px !important;
-}
+@mixin fds-checkboxes-theme($theme) {
+ $primaryColor: map-get(map-get($theme, primary), 500);
+ $primaryColorHover: map-get(map-get($theme, primary), 100);
+ $accentColor: map-get(map-get($theme, accent), 500);
+ $accentColorHover: map-get(map-get($theme, accent), 100);
-body[fds] .mat-checkbox-frame {
- height: 10px;
- width: 10px;
- border-color: $grey7;
-}
+ body[fds] {
+.mat-checkbox-inner-container {
+ height: 10px !important;
+ width: 10px !important;
+ margin-right: 5px;
-body[fds] .mat-checkbox-ripple {
- left: -7px;
- top: -7px;
- right: -7px;
- bottom: -7px;
-}
+ &:hover {
+background-color: $accentColor;
+border-radius: 2px;
+ }
+}
-body[fds] .mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
-body[fds] .mat-checkbox-checked.mat-accent .mat-checkbox-background {
- background-color: $blue-grey1;
-}
+.mat-checkbox-frame {
+ height: 10px;
+ width: 10px;
+ border-color: $grey7;
+}
-body[fds] .mat-checkbox-inner-container:hover {
- background-color: $blue-grey1;
- border-radius: 2px;
-}
+.mat-checkbox-ripple {
+ left: -19px;
+ top: -19px;
+ right: -7px;
+ bottom: -7px;
+}
-body[fds] .mat-checkbox-background {
- height: 10px;
- width: 10px;
-}
+.mat-checkbox-indeterminate.mat-accent .mat-checkbox-background,
+.mat-checkbox-checked.mat-accent .mat-checkbox-background {
+ background-color: $accentColor;
+}
-/* Covalent TdDataTableComponent 'selectable' property checkboxes */
+.mat-checkbox-background {
+ height: 10px;
+ width: 10px;
+}
-body[fds] .mat-pseudo-checkbox {
- height: 10px !important;
- width: 10px !important;
- border: 1px solid $grey7;
-}
+/* Covalent TdDataTableComponent 'selectable' property checkboxes */
-body[fds] .mat-pseudo-checkbox:hover {
- background-color: $blue-grey1;
- border: 1px solid $blue-grey1;
-}
+.mat-pseudo-checkbox {
+ height: 10px !important;
+ width: 10px !important;
+ border: 1px solid $grey7;
+}
-body[fds] .mat-pseudo-checkbox-checked::after {
- content: '\f00c';
- font-size: 8px;
- font-family: fontawesome;
- margin-top: -9px;
- margin-left: -1px;
- border: none;
- transform: initial;
-}
+.mat-pseudo-checkbox:hover {
Review comment:
Please delete this style it is not used in nifi-fds
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-fds] scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating checkbox components to use the theme accent colors.
scottyaslan commented on a change in pull request #17: [NIFI-6258] Updating
checkbox components to use the theme accent colors.
URL: https://github.com/apache/nifi-fds/pull/17#discussion_r280864680
##
File path: src/platform/core/common/styles/_checkboxes.scss
##
@@ -17,69 +17,84 @@
/* Checkboxes */
-body[fds] .mat-checkbox-inner-container {
- height: 10px !important;
- width: 10px !important;
-}
+@mixin fds-checkboxes-theme($theme) {
Review comment:
You will need to import this @mixin in
nifi-fds/src/platform/core/theming/_all-theme.scss
```
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
@import '../../../../node_modules/@angular/material/theming';
@import '../../../../node_modules/@covalent/core/theming/all-theme';
@import '../common/styles/buttons';
@import '../common/styles/expansionPanels';
@import '../common/styles/menus';
@import '../common/styles/checkboxes';
// Create a theme.
@mixin fds-theme($theme) {
// Include theme styles for core and each component used in your app.
// Alternatively, you can import and @include the theme mixins for each
component
// that you are using.
@include angular-material-theme($theme);
@include covalent-theme($theme);
@include fds-buttons-theme($theme);
@include fds-expansion-panels-theme($theme);
@include fds-menus-theme($theme);
@include fds-checkboxes-theme($theme);
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (NIFI-6255) Allow NiFi to hash specific attributes of a record
[
https://issues.apache.org/jira/browse/NIFI-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832669#comment-16832669
]
Bryan Bende commented on NIFI-6255:
---
I think we should consider adding hash functions to EL and/or record-path which
would eliminate the need for a new processor because then it could be done with
UpdateRecord.
If hashing with EL, then in UpdateRecord you could do:
{code:java}
/fieldA = ${hash(ALGORITHM, field.value)}{code}
If hashing with record-path, then in UpdateRecord you could do:
{code:java}
/fieldA = hash(ALGORITH, /fieldA){code}
> Allow NiFi to hash specific attributes of a record
> --
>
> Key: NIFI-6255
> URL: https://issues.apache.org/jira/browse/NIFI-6255
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
>Affects Versions: 2.0.0
>Reporter: Nathan Bruce
>Priority: Trivial
>
> Create a processor for NiFi to read in a file of records through the Record
> Reader service and hash specific keys within the record.
> The processor will accept a comma delimited list of strings that would
> specify the keys to be hashed, as an attribute. If the keys specified are not
> present in a given record, the processor should continue without resulting in
> a failure.
> The processor will have a list of hashing algorithms to be applied to the
> record, as well as an optional salt.
> The hashed value will replace the current value stored for the given key then
> passed on to the Record Writer service.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (NIFIREG-263) Update HTML ids added for testing to be more explicit about their purpose
[ https://issues.apache.org/jira/browse/NIFIREG-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan resolved NIFIREG-263. - Resolution: Fixed > Update HTML ids added for testing to be more explicit about their purpose > - > > Key: NIFIREG-263 > URL: https://issues.apache.org/jira/browse/NIFIREG-263 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > HTML ids were added in https://issues.apache.org/jira/browse/NIFIREG-56 and > https://issues.apache.org/jira/browse/NIFIREG-185 for testing/automation > purposes. > To avoid confusion, suggest we change these references from "id" to > "data-automation-id" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi-registry] scottyaslan commented on issue #180: NIFIREG-263 Update HTML id references to data-automation-ids
scottyaslan commented on issue #180: NIFIREG-263 Update HTML id references to data-automation-ids URL: https://github.com/apache/nifi-registry/pull/180#issuecomment-489134703 Thanks @andrewmlim this has been merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] asfgit closed pull request #180: NIFIREG-263 Update HTML id references to data-automation-ids
asfgit closed pull request #180: NIFIREG-263 Update HTML id references to data-automation-ids URL: https://github.com/apache/nifi-registry/pull/180 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] scottyaslan commented on issue #180: NIFIREG-263 Update HTML id references to data-automation-ids
scottyaslan commented on issue #180: NIFIREG-263 Update HTML id references to data-automation-ids URL: https://github.com/apache/nifi-registry/pull/180#issuecomment-489124864 Reviewing... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFIREG-263) Update HTML ids added for testing to be more explicit about their purpose
[ https://issues.apache.org/jira/browse/NIFIREG-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lim updated NIFIREG-263: --- Description: HTML ids were added in https://issues.apache.org/jira/browse/NIFIREG-56 and https://issues.apache.org/jira/browse/NIFIREG-185 for testing/automation purposes. To avoid confusion, suggest we change these references from "id" to "data-automation-id" was: HTML Iids were added in https://issues.apache.org/jira/browse/NIFIREG-56 and https://issues.apache.org/jira/browse/NIFIREG-185 for testing/automation purposes. To avoid confusion, suggest we change these references from "id" to "data-automation-id" > Update HTML ids added for testing to be more explicit about their purpose > - > > Key: NIFIREG-263 > URL: https://issues.apache.org/jira/browse/NIFIREG-263 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > HTML ids were added in https://issues.apache.org/jira/browse/NIFIREG-56 and > https://issues.apache.org/jira/browse/NIFIREG-185 for testing/automation > purposes. > To avoid confusion, suggest we change these references from "id" to > "data-automation-id" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-6257) duplicate info in administrator's guide
[
https://issues.apache.org/jira/browse/NIFI-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-6257:
---
Resolution: Fixed
Fix Version/s: 1.10.0
Status: Resolved (was: Patch Available)
> duplicate info in administrator's guide
> ---
>
> Key: NIFI-6257
> URL: https://issues.apache.org/jira/browse/NIFI-6257
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation & Website
>Reporter: Endre Kovacs
>Assignee: Endre Kovacs
>Priority: Trivial
> Labels: documentation
> Fix For: 1.10.0
>
> Attachments: Screen Shot 2019-05-03 at 09.38.14.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> i was just reading through the nifi.properties part of the administrator's
> guide.
> [https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#cluster_node_properties]
> i saw there was line duplication in the doc as follows:
> both:
> {code:java}
> nifi.cluster.flow.election.max.wait.time
> {code}
> and
> {code:java}
> nifi.cluster.flow.election.max.candidates
> {code}
> is twice in the table, with the exact same description.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [nifi] asfgit closed pull request #3461: NIFI-6257: removing duplicate table row from administration guide
asfgit closed pull request #3461: NIFI-6257: removing duplicate table row from administration guide URL: https://github.com/apache/nifi/pull/3461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6257) duplicate info in administrator's guide
[
https://issues.apache.org/jira/browse/NIFI-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832521#comment-16832521
]
ASF subversion and git services commented on NIFI-6257:
---
Commit 9194726b35ca06fc590c06674bb0cf4c7200d7b4 in nifi's branch
refs/heads/master from Endre Zoltan Kovacs
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=9194726 ]
NIFI-6257: removing duplicate table row from administration guide
Signed-off-by: Matthew Burgess
This closes #3461
> duplicate info in administrator's guide
> ---
>
> Key: NIFI-6257
> URL: https://issues.apache.org/jira/browse/NIFI-6257
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation & Website
>Affects Versions: 1.9.2
>Reporter: Endre Kovacs
>Assignee: Endre Kovacs
>Priority: Trivial
> Labels: documentation
> Attachments: Screen Shot 2019-05-03 at 09.38.14.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> i was just reading through the nifi.properties part of the administrator's
> guide.
> [https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#cluster_node_properties]
> i saw there was line duplication in the doc as follows:
> both:
> {code:java}
> nifi.cluster.flow.election.max.wait.time
> {code}
> and
> {code:java}
> nifi.cluster.flow.election.max.candidates
> {code}
> is twice in the table, with the exact same description.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFI-6257) duplicate info in administrator's guide
[
https://issues.apache.org/jira/browse/NIFI-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-6257:
---
Affects Version/s: (was: 1.9.2)
Status: Patch Available (was: Open)
> duplicate info in administrator's guide
> ---
>
> Key: NIFI-6257
> URL: https://issues.apache.org/jira/browse/NIFI-6257
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation & Website
>Reporter: Endre Kovacs
>Assignee: Endre Kovacs
>Priority: Trivial
> Labels: documentation
> Attachments: Screen Shot 2019-05-03 at 09.38.14.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> i was just reading through the nifi.properties part of the administrator's
> guide.
> [https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#cluster_node_properties]
> i saw there was line duplication in the doc as follows:
> both:
> {code:java}
> nifi.cluster.flow.election.max.wait.time
> {code}
> and
> {code:java}
> nifi.cluster.flow.election.max.candidates
> {code}
> is twice in the table, with the exact same description.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [nifi] mattyb149 commented on issue #3461: NIFI-6257: removing duplicate table row from administration guide
mattyb149 commented on issue #3461: NIFI-6257: removing duplicate table row from administration guide URL: https://github.com/apache/nifi/pull/3461#issuecomment-489107252 +1 LGTM, thanks for the fix! Merging to master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6259) Can't add registry clients which have an underscore in the URL
Luca Rettenberger created NIFI-6259: --- Summary: Can't add registry clients which have an underscore in the URL Key: NIFI-6259 URL: https://issues.apache.org/jira/browse/NIFI-6259 Project: Apache NiFi Issue Type: Bug Affects Versions: 1.9.2 Environment: Docker Container @ Latest Version Reporter: Luca Rettenberger Attachments: reg.png, reg2.png When adding an new Registry client to NiFi which has an underscore in its name, it result in the value being set to: "http://null:-1";. When editing the newly created client afterwards, the value will be accepted, even with a underscore in the URL. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-6258) UI - checkbox components should use the theme accent colors
[ https://issues.apache.org/jira/browse/NIFI-6258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832378#comment-16832378 ] László Horváth commented on NIFI-6258: -- I'm unable to assign this issue to myself but a PR is available: [https://github.com/apache/nifi-fds/pull/17] > UI - checkbox components should use the theme accent colors > --- > > Key: NIFI-6258 > URL: https://issues.apache.org/jira/browse/NIFI-6258 > Project: Apache NiFi > Issue Type: Bug > Components: FDS >Reporter: László Horváth >Priority: Minor > Labels: UI > Time Spent: 10m > Remaining Estimate: 0h > > UI - checkbox components should use the theme accent colors -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-6258) UI - checkbox components should use the theme accent colors
[ https://issues.apache.org/jira/browse/NIFI-6258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Horváth updated NIFI-6258: - Status: Patch Available (was: Open) > UI - checkbox components should use the theme accent colors > --- > > Key: NIFI-6258 > URL: https://issues.apache.org/jira/browse/NIFI-6258 > Project: Apache NiFi > Issue Type: Bug > Components: FDS >Reporter: László Horváth >Priority: Minor > Labels: UI > Time Spent: 10m > Remaining Estimate: 0h > > UI - checkbox components should use the theme accent colors -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi-fds] RynoRn opened a new pull request #17: [NIFI-6258] Updating checkbox components to use the theme accent colors.
RynoRn opened a new pull request #17: [NIFI-6258] Updating checkbox components to use the theme accent colors. URL: https://github.com/apache/nifi-fds/pull/17 Thank you for submitting a contribution to Apache NiFi Flow Design System. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with either NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you written or updated unit tests to verify your changes? - [x] Have you ensured that a full build and that the full suite of unit tests is executed via npm run clean:install at the root nifi-fds folder? - [ ] Have you written or updated the Apache NiFi Flow Design System demo application to demonstrate any new functionality, provide examples of usage, and to verify your changes via npm start at the nifi-fds/target folder? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-fds? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-fds? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6258) UI - checkbox components should use the theme accent colors
László Horváth created NIFI-6258: Summary: UI - checkbox components should use the theme accent colors Key: NIFI-6258 URL: https://issues.apache.org/jira/browse/NIFI-6258 Project: Apache NiFi Issue Type: Bug Components: FDS Reporter: László Horváth UI - checkbox components should use the theme accent colors -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-6257) duplicate info in administrator's guide
[
https://issues.apache.org/jira/browse/NIFI-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Endre Kovacs updated NIFI-6257:
---
Description:
i was just reading through the nifi.properties part of the administrator's
guide.
[https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#cluster_node_properties]
i saw there was line duplication in the doc as follows:
both:
{code:java}
nifi.cluster.flow.election.max.wait.time
{code}
and
{code:java}
nifi.cluster.flow.election.max.candidates
{code}
is twice in the table, with the exact same description.
was:
i was just reading through the nifi.properties part of the administrator's
guide.
[https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html]
i saw there was line duplication in the doc as follows:
both:
{code:java}
nifi.cluster.flow.election.max.wait.time
{code}
and
{code:java}
nifi.cluster.flow.election.max.candidates
{code}
is twice in the table, with the exact same description.
> duplicate info in administrator's guide
> ---
>
> Key: NIFI-6257
> URL: https://issues.apache.org/jira/browse/NIFI-6257
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation & Website
>Affects Versions: 1.9.2
>Reporter: Endre Kovacs
>Assignee: Endre Kovacs
>Priority: Trivial
> Labels: documentation
> Attachments: Screen Shot 2019-05-03 at 09.38.14.png
>
>
> i was just reading through the nifi.properties part of the administrator's
> guide.
> [https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#cluster_node_properties]
> i saw there was line duplication in the doc as follows:
> both:
> {code:java}
> nifi.cluster.flow.election.max.wait.time
> {code}
> and
> {code:java}
> nifi.cluster.flow.election.max.candidates
> {code}
> is twice in the table, with the exact same description.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [nifi] ekovacs opened a new pull request #3461: NIFI-6257: removing duplicate table row from administration guide
ekovacs opened a new pull request #3461: NIFI-6257: removing duplicate table row from administration guide URL: https://github.com/apache/nifi/pull/3461 removing duplicate lines from administration guide NiFi properties table. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6257) duplicate info in administrator's guide
Endre Kovacs created NIFI-6257:
--
Summary: duplicate info in administrator's guide
Key: NIFI-6257
URL: https://issues.apache.org/jira/browse/NIFI-6257
Project: Apache NiFi
Issue Type: Bug
Components: Documentation & Website
Affects Versions: 1.9.2
Reporter: Endre Kovacs
Assignee: Endre Kovacs
Attachments: Screen Shot 2019-05-03 at 09.38.14.png
i was just reading through the nifi.properties part of the administrator's
guide.
[https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html]
i saw there was line duplication in the doc as follows:
both:
{code:java}
nifi.cluster.flow.election.max.wait.time
{code}
and
{code:java}
nifi.cluster.flow.election.max.candidates
{code}
is twice in the table, with the exact same description.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
