[GitHub] [nifi] kevdoran commented on a change in pull request #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun…
kevdoran commented on a change in pull request #3492: NIFI-6164 - Added CLI
commands related to NiFi Registry extension bun…
URL: https://github.com/apache/nifi/pull/3492#discussion_r293969006
##
File path:
nifi-toolkit/nifi-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/command/registry/extension/UploadBundles.java
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.toolkit.cli.impl.command.registry.extension;
+
+import org.apache.commons.cli.ParseException;
+import org.apache.commons.codec.binary.Hex;
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.registry.client.BundleVersionClient;
+import org.apache.nifi.registry.client.NiFiRegistryClient;
+import org.apache.nifi.registry.client.NiFiRegistryException;
+import org.apache.nifi.registry.extension.bundle.BundleType;
+import org.apache.nifi.registry.extension.bundle.BundleVersion;
+import org.apache.nifi.toolkit.cli.api.Context;
+import org.apache.nifi.toolkit.cli.impl.command.CommandOption;
+import
org.apache.nifi.toolkit.cli.impl.command.registry.AbstractNiFiRegistryCommand;
+import org.apache.nifi.toolkit.cli.impl.result.StringResult;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.Properties;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class UploadBundles extends AbstractNiFiRegistryCommand {
+
+public UploadBundles() {
+super("upload-bundles", StringResult.class);
+}
+
+@Override
+public String getDescription() {
+return "Performs a bulk upload of multiple bundles to the specified
bucket in the registry. This command will look for " +
+"files in the specified directory, and if recurse (-r) is
specified then it will search child directories recursively. " +
+"If fileExtension is specified then it will only consider
files that have the specified extension, such as '.nar'";
+}
+
+@Override
+public void doInitialize(final Context context) {
+addOption(CommandOption.BUCKET_ID.createOption());
+addOption(CommandOption.EXT_BUNDLE_TYPE.createOption());
+addOption(CommandOption.EXT_BUNDLE_DIR.createOption());
+addOption(CommandOption.FILE_EXTENSION.createOption());
+addOption(CommandOption.RECURSIVE.createOption());
+addOption(CommandOption.SKIP_SHA_256.createOption());
+}
+
+@Override
+public StringResult doExecute(final NiFiRegistryClient client, final
Properties properties)
+throws IOException, NiFiRegistryException, ParseException {
+final String bucketId = getRequiredArg(properties,
CommandOption.BUCKET_ID);
+final String bundleDir = getRequiredArg(properties,
CommandOption.EXT_BUNDLE_DIR);
+final String fileExtension = getArg(properties,
CommandOption.FILE_EXTENSION);
+final boolean recursive =
properties.containsKey(CommandOption.RECURSIVE);
+final boolean skipSha256 =
properties.containsKey(CommandOption.SKIP_SHA_256.getLongName());
+final boolean verbose = isVerbose(properties);
+
+final BundleType bundleType;
+try {
+bundleType = BundleType.fromString(getRequiredArg(properties,
CommandOption.EXT_BUNDLE_TYPE));
+} catch (Exception e) {
Review comment:
```suggestion
} catch (IllegalArgumentException e) {
```
`Exception` is too broad. When the required arg is not provided, this will
catch `MissingOptionException` and instead of:
> Missing required option --extensionBundleType
we will get:
> Invalid bundle type, should be one of nifi-nar or minifi-cpp
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MINIFICPP-922) Connections aren't removed.
[ https://issues.apache.org/jira/browse/MINIFICPP-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864426#comment-16864426 ] Arpad Boda commented on MINIFICPP-922: -- Is it related to the shared_ptr issues we have discovered recently? > Connections aren't removed. > > > Key: MINIFICPP-922 > URL: https://issues.apache.org/jira/browse/MINIFICPP-922 > Project: Apache NiFi MiNiFi C++ > Issue Type: Sub-task >Reporter: Mr TheSegfault >Priority: Major > > It turns out that connections aren't removed from the agent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (MINIFICPP-923) Kafka version has performance issues and known bugs
[ https://issues.apache.org/jira/browse/MINIFICPP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri resolved MINIFICPP-923. --- Resolution: Fixed Fix Version/s: 0.7.0 > Kafka version has performance issues and known bugs > --- > > Key: MINIFICPP-923 > URL: https://issues.apache.org/jira/browse/MINIFICPP-923 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.7.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Should upgrade to 1.0.0 ( seems to be the most validated recently ) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi-minifi-cpp] asfgit closed pull request #594: MINIFICPP-923: remove librdkafka, and deal with some bugs
asfgit closed pull request #594: MINIFICPP-923: remove librdkafka, and deal with some bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6360) Update Mockito and PowerMock to 2.x
[ https://issues.apache.org/jira/browse/NIFI-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Storck updated NIFI-6360: -- Status: Patch Available (was: Open) > Update Mockito and PowerMock to 2.x > --- > > Key: NIFI-6360 > URL: https://issues.apache.org/jira/browse/NIFI-6360 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework, Extensions, Tools and Build >Affects Versions: 1.9.2 >Reporter: Jeff Storck >Assignee: Jeff Storck >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Update to the most recent stable 2.x versions of Mockito and PowerMock. > This is necessary for building NiFi on Java 11. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi-minifi-cpp] apiri commented on issue #594: MINIFICPP-923: remove librdkafka, and deal with some bugs
apiri commented on issue #594: MINIFICPP-923: remove librdkafka, and deal with some bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/594#issuecomment-502237646 thanks for confirming and updating. will merge This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFIREG-206) Support anonymous read-only access to a bucket
[ https://issues.apache.org/jira/browse/NIFIREG-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-206. - Resolution: Fixed Fix Version/s: 0.5.0 > Support anonymous read-only access to a bucket > -- > > Key: NIFIREG-206 > URL: https://issues.apache.org/jira/browse/NIFIREG-206 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Fix For: 0.5.0 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > Currently in a secure NiFi Registry, all users must authenticate with a valid > identity based on one of the authentication mechanisms that has been > configured (client certs, LDAP, or kerberos). If a request comes in with no > user credentials, then we create an anonymous user which will be denied > access. > We should support a way to indicate that a bucket can be read by anyone (i.e. > the anonymous user). This would allow there to be a bucket where publicly > available flows can be shared, but only those users with write permissions to > the bucket can add flows, and other buckets can remain private. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi-registry] asfgit closed pull request #197: NIFIREG-206 Support anonymous access to public resources
asfgit closed pull request #197: NIFIREG-206 Support anonymous access to public resources URL: https://github.com/apache/nifi-registry/pull/197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] bbende commented on issue #197: NIFIREG-206 Support anonymous access to public resources
bbende commented on issue #197: NIFIREG-206 Support anonymous access to public resources URL: https://github.com/apache/nifi-registry/pull/197#issuecomment-502232057 Thanks for the reviews, going to rebase and merge... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] thenatog commented on issue #3522: NIFI-6362 - Upgraded com.puppycrawl.tools:checkstyle to 8.18. Made sm…
thenatog commented on issue #3522: NIFI-6362 - Upgraded com.puppycrawl.tools:checkstyle to 8.18. Made sm… URL: https://github.com/apache/nifi/pull/3522#issuecomment-502230756 Submitted another commit which upgrades the maven-checkstyle-plugin and the puppycrawl tool. When this runs it will add a .checkstyleCache file at the root directory which caches the state of checked files. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bbende commented on issue #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun…
bbende commented on issue #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun… URL: https://github.com/apache/nifi/pull/3492#issuecomment-502228541 Thanks for checking out the latest changes. Yea, we'll need to wait for next release to update that one, probably not a big deal since we are only really storing NARs for now anyway, but just wanted to leave a reminder. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] kevdoran edited a comment on issue #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun…
kevdoran edited a comment on issue #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun… URL: https://github.com/apache/nifi/pull/3492#issuecomment-502226689 On second thought, I guess we need to wait for the next release of NiFi Registry to get the bugfix in the client. Nevermind - Friday afternoon brain haze over here. Will review and merge as-is barring finding anything else. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] kevdoran commented on issue #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun…
kevdoran commented on issue #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun… URL: https://github.com/apache/nifi/pull/3492#issuecomment-502226689 On second thought, I guess we need to wait for the next release of NiFi Registry to get the bugfix in the client. Nevermind - Friday afternoon brain haze over here. Will review and merge as-is. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] kevdoran edited a comment on issue #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun…
kevdoran edited a comment on issue #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun… URL: https://github.com/apache/nifi/pull/3492#issuecomment-502226063 I think these changes look good now @bbende. Let's leave the list-bundles-* commands as-is for now. Can always add list-bundles later. In your most recent commit I saw this code comment: > NOTE: There is a bug in the nifi-registry-client that sends bundleType from filter params using the name() instead of toString(). When that is resolved we can update this command to have an optional argument for bundle type and set it in the filter params. I saw PR apache/nifi-registry#200 which fixes this, and I reviewed and merged that today. Given that, do you want to update this PR now, or address the extension type filter in a future PR? Just let me know, I'm holding off running to test the functionality for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] kevdoran commented on issue #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun…
kevdoran commented on issue #3492: NIFI-6164 - Added CLI commands related to NiFi Registry extension bun… URL: https://github.com/apache/nifi/pull/3492#issuecomment-502226063 I think these changes look good now @bbende. Let's leave the list-bundles commands as-is for now. Can always add list-bundles later. In your most recent commit I saw this code comment: > NOTE: There is a bug in the nifi-registry-client that sends bundleType from filter params using the name() instead of toString(). When that is resolved we can update this command to have an optional argument for bundle type and set it in the filter params. I saw PR apache/nifi-registry#200 which fixes this, and I reviewed and merged that today. Given that, do you want to update this PR now, or address the extension type filter in a future PR? Just let me know, I'm holding off running to test the functionality for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Moved] (NIFIREG-285) Implement a database FlowPersistenceProvider
[ https://issues.apache.org/jira/browse/NIFIREG-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende moved NIFI-6383 to NIFIREG-285: --- Workflow: jira (was: patch-available, re-open possible) Key: NIFIREG-285 (was: NIFI-6383) Project: NiFi Registry (was: Apache NiFi) > Implement a database FlowPersistenceProvider > > > Key: NIFIREG-285 > URL: https://issues.apache.org/jira/browse/NIFIREG-285 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Priority: Major > > We currently have the options of local filesystem and git for flow storage. > While git is for pushing to a remote and visualizing in github, it is only a > one way push and not ideal for an HA scenario where we would want multiple > instances of the NiFi Registry application running. > We should implement a FlowStorageProvider backed by a relational database > table that could live in the same DB as the metadata database. This would > allow multiple NiFi Registry instances to run pointing at the same external > database. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-6383) Implement a database FlowPersistenceProvider
Bryan Bende created NIFI-6383: - Summary: Implement a database FlowPersistenceProvider Key: NIFI-6383 URL: https://issues.apache.org/jira/browse/NIFI-6383 Project: Apache NiFi Issue Type: Improvement Reporter: Bryan Bende We currently have the options of local filesystem and git for flow storage. While git is for pushing to a remote and visualizing in github, it is only a one way push and not ideal for an HA scenario where we would want multiple instances of the NiFi Registry application running. We should implement a FlowStorageProvider backed by a relational database table that could live in the same DB as the metadata database. This would allow multiple NiFi Registry instances to run pointing at the same external database. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi] ottobackwards commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
ottobackwards commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#issuecomment-502216151 Thanks for pointing in the right direction @joewitt This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #594: MINIFICPP-923: remove librdkafka, and deal with some bugs
phrocker commented on a change in pull request #594: MINIFICPP-923: remove
librdkafka, and deal with some bugs
URL: https://github.com/apache/nifi-minifi-cpp/pull/594#discussion_r293926792
##
File path: extensions/librdkafka/CMakeLists.txt
##
@@ -32,18 +30,42 @@ if(CMAKE_THREAD_LIBS_INIT)
target_link_libraries(minifi-rdkafka-extensions "${CMAKE_THREAD_LIBS_INIT}")
endif()
+ set(BASE_DIR "${CMAKE_CURRENT_BINARY_DIR}/thirdparty/kafka")
+ if (WIN32)
+ set(BYPRODUCT "${BASE_DIR}/install/lib/librdkafka.lib")
+ else()
+ set(BYPRODUCT "${BASE_DIR}/install/lib/librdkafka.a")
+ endif()
-# Include UUID
-find_package(UUID REQUIRED)
-target_link_libraries(minifi-rdkafka-extensions ${LIBMINIFI} ${UUID_LIBRARIES})
-target_link_libraries(minifi-rdkafka-extensions ${CMAKE_DL_LIBS} )
-if (LibRdKafka_FOUND AND NOT BUILD_LIBRDKAFKA)
- target_link_libraries(minifi-rdkafka-extensions ${LibRdKafka_LIBRARIES}
)
-else()
- target_link_libraries(minifi-rdkafka-extensions rdkafka )
+list(APPEND CMAKE_MODULE_PATH_PASSTHROUGH_LIST "${CMAKE_SOURCE_DIR}/cmake/ssl")
+list(APPEND CMAKE_MODULE_PATH_PASSTHROUGH_LIST
"${CMAKE_SOURCE_DIR}/cmake/zlib/dummy")
+
+ExternalProject_Add(
+kafka-external
+GIT_REPOSITORY "https://github.com/edenhill/librdkafka.git";
+GIT_TAG "v1.0.0"
Review comment:
@apiri I looked at the dropdown and saw RC1, but didn't see the tag above
it. Oversight on my part. Thanks! Tested it with 1.0.1 and no apparent issues.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] joewitt commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
joewitt commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#issuecomment-502212731 The implication about the JIRA and PR speed is problematic. If you look at the JIRA it is a child [1] of a parent [2] which links to a well written and detailed feature proposal laying out the full context [3]. [1] https://issues.apache.org/jira/browse/NIFI-6380 [2] https://issues.apache.org/jira/browse/NIFI-6276 [3] https://cwiki.apache.org/confluence/display/NIFI/Better+Support+for+Parameterizing+Flows This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mattyb149 commented on issue #3535: NIFI-6228 Fixed order of operations bug that prevented SSLContext fro…
mattyb149 commented on issue #3535: NIFI-6228 Fixed order of operations bug that prevented SSLContext fro… URL: https://github.com/apache/nifi/pull/3535#issuecomment-502208750 This LGTM, but I'd like to get @alopresto to comment as to whether the unit tests cover everything he's looking for. If he's +1 then so am I This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] andrewmlim commented on issue #197: NIFIREG-206 Support anonymous access to public resources
andrewmlim commented on issue #197: NIFIREG-206 Support anonymous access to public resources URL: https://github.com/apache/nifi-registry/pull/197#issuecomment-502206252 @bbende Thanks for trying. It wasn't a huge concern for me. I'm good with leaving things the way they are. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] markap14 commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
markap14 commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#issuecomment-502206361 I work fast :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] ottobackwards commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
ottobackwards commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#issuecomment-502206762 are you on slack? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] apiri commented on a change in pull request #594: MINIFICPP-923: remove librdkafka, and deal with some bugs
apiri commented on a change in pull request #594: MINIFICPP-923: remove
librdkafka, and deal with some bugs
URL: https://github.com/apache/nifi-minifi-cpp/pull/594#discussion_r293892192
##
File path: extensions/librdkafka/CMakeLists.txt
##
@@ -32,18 +30,42 @@ if(CMAKE_THREAD_LIBS_INIT)
target_link_libraries(minifi-rdkafka-extensions "${CMAKE_THREAD_LIBS_INIT}")
endif()
+ set(BASE_DIR "${CMAKE_CURRENT_BINARY_DIR}/thirdparty/kafka")
+ if (WIN32)
+ set(BYPRODUCT "${BASE_DIR}/install/lib/librdkafka.lib")
+ else()
+ set(BYPRODUCT "${BASE_DIR}/install/lib/librdkafka.a")
+ endif()
-# Include UUID
-find_package(UUID REQUIRED)
-target_link_libraries(minifi-rdkafka-extensions ${LIBMINIFI} ${UUID_LIBRARIES})
-target_link_libraries(minifi-rdkafka-extensions ${CMAKE_DL_LIBS} )
-if (LibRdKafka_FOUND AND NOT BUILD_LIBRDKAFKA)
- target_link_libraries(minifi-rdkafka-extensions ${LibRdKafka_LIBRARIES}
)
-else()
- target_link_libraries(minifi-rdkafka-extensions rdkafka )
+list(APPEND CMAKE_MODULE_PATH_PASSTHROUGH_LIST "${CMAKE_SOURCE_DIR}/cmake/ssl")
+list(APPEND CMAKE_MODULE_PATH_PASSTHROUGH_LIST
"${CMAKE_SOURCE_DIR}/cmake/zlib/dummy")
+
+ExternalProject_Add(
+kafka-external
+GIT_REPOSITORY "https://github.com/edenhill/librdkafka.git";
+GIT_TAG "v1.0.0"
Review comment:
can we bump this to 1.0.1
(https://github.com/edenhill/librdkafka/releases/tag/v1.0.1)? looks like a few
other fixes made it in
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] ottobackwards commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
ottobackwards commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#issuecomment-502199558 That is a huge pr for having an empty jira created about 10 minutes before the pr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] bbende commented on issue #197: NIFIREG-206 Support anonymous access to public resources
bbende commented on issue #197: NIFIREG-206 Support anonymous access to public resources URL: https://github.com/apache/nifi-registry/pull/197#issuecomment-502194596 @andrewmlim I tried a few things with the help icon and I'm leaning towards leaving it the way it is. Moving the icon outside of the checkbox changes the vertical alignment slightly so then we were trying to re-align it, but that wasn't working out so well. Another option I guess is that we can hide the help icon when disabled, but I'm not sure if it is better to not see it all. Let me know what you think. I'd like to proceed with merging this in if you are good with everything else. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] apiri commented on issue #594: MINIFICPP-923: remove librdkafka, and deal with some bugs
apiri commented on issue #594: MINIFICPP-923: remove librdkafka, and deal with some bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/594#issuecomment-502183341 reviewing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6228) ElasticSearchClient cannot handle trust-only SSL configurations
[ https://issues.apache.org/jira/browse/NIFI-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-6228: --- Status: Patch Available (was: Reopened) > ElasticSearchClient cannot handle trust-only SSL configurations > --- > > Key: NIFI-6228 > URL: https://issues.apache.org/jira/browse/NIFI-6228 > Project: Apache NiFi > Issue Type: Bug >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > Fix For: 1.10.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > The ElasticSearch client service will not setup SSL if only a trust store is > configured. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (NIFIREG-284) Update docs for newly added granular proxy policies
[ https://issues.apache.org/jira/browse/NIFIREG-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863492#comment-16863492 ] Andrew Lim edited comment on NIFIREG-284 at 6/14/19 4:05 PM: - Per a discussion with [~bende], for 0.5.0 migration guide, should note: Existing registries will have NiFi nodes as Proxy with WRITE, so on upgrade admins will need to go in and add READ and DELETE to get them back to the same functionality they had before. For _new_ installs this is not an issue because any NiFi Identities listed in _authorizers.xml_ will be granted all three. was (Author: andrewmlim): Per a discussion with [~bende], for 0.5.0 migration guide, should note: Existing registries will have NiFi nodes as Proxy with WRITE, so on upgrade they need to go in and add READ and DELETE to get them back to the same functionality they had before For new installs it is fine because any NiFi Identities listed in _authorizers.xml_ will be granted all three. > Update docs for newly added granular proxy policies > --- > > Key: NIFIREG-284 > URL: https://issues.apache.org/jira/browse/NIFIREG-284 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.5.0 >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Major > Labels: migration > > Read/write/delete policies added via NIFIREG-212 > At minimum, need to update screenshots as a result. But can also add more > information for possible use cases with these policies. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFIREG-284) Update docs for newly added granular proxy policies
[ https://issues.apache.org/jira/browse/NIFIREG-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lim updated NIFIREG-284: --- Labels: migration (was: ) > Update docs for newly added granular proxy policies > --- > > Key: NIFIREG-284 > URL: https://issues.apache.org/jira/browse/NIFIREG-284 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.5.0 >Reporter: Andrew Lim >Assignee: Andrew Lim >Priority: Major > Labels: migration > > Read/write/delete policies added via NIFIREG-212 > At minimum, need to update screenshots as a result. But can also add more > information for possible use cases with these policies. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi] bbende commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
bbende commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#issuecomment-502164778 Will review... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker opened a new pull request #594: MINIFICPP-923: remove librdkafka, and deal with some bugs
phrocker opened a new pull request #594: MINIFICPP-923: remove librdkafka, and deal with some bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/594 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MINIFICPP-923) Kafka version has performance issues and known bugs
Mr TheSegfault created MINIFICPP-923: Summary: Kafka version has performance issues and known bugs Key: MINIFICPP-923 URL: https://issues.apache.org/jira/browse/MINIFICPP-923 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Mr TheSegfault Assignee: Mr TheSegfault Should upgrade to 1.0.0 ( seems to be the most validated recently ) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-6380) Implement Parameter Context Backend
[ https://issues.apache.org/jira/browse/NIFI-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-6380: - Fix Version/s: 1.10.0 Status: Patch Available (was: Open) > Implement Parameter Context Backend > --- > > Key: NIFI-6380 > URL: https://issues.apache.org/jira/browse/NIFI-6380 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi] markap14 opened a new pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
markap14 opened a new pull request #3536: NIFI-6380: Introduced the notion of
Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536
… to the code base.
- Added nifi-parameter module
- Added Parameter to nifi-api
- Added ParameterContext and ParameterLookup
- Updated EL to support Parameters
- Updated backend so that any property can make use of Parameters
- Added web endpoint for Parameter Contexts
- Updated Templates to make use of Parameter Contexts
- Updated Versioned Flows to make use of Parameter Contexts
- Updated Stateless NiFi to support Parameters and take Parameters as part
of the configuration, not Variables.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (MINIFICPP-922) Connections aren't removed.
Mr TheSegfault created MINIFICPP-922: Summary: Connections aren't removed. Key: MINIFICPP-922 URL: https://issues.apache.org/jira/browse/MINIFICPP-922 Project: Apache NiFi MiNiFi C++ Issue Type: Sub-task Reporter: Mr TheSegfault It turns out that connections aren't removed from the agent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-6382) Ensure proper integration between NiFi & NiFi Registry with respect to Parameters
Mark Payne created NIFI-6382: Summary: Ensure proper integration between NiFi & NiFi Registry with respect to Parameters Key: NIFI-6382 URL: https://issues.apache.org/jira/browse/NIFI-6382 Project: Apache NiFi Issue Type: Sub-task Components: Core Framework Reporter: Mark Payne Assignee: Mark Payne -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-6381) Make Parameters and Parameter Contexts searchable in UI
Mark Payne created NIFI-6381: Summary: Make Parameters and Parameter Contexts searchable in UI Key: NIFI-6381 URL: https://issues.apache.org/jira/browse/NIFI-6381 Project: Apache NiFi Issue Type: Sub-task Components: Core Framework Reporter: Mark Payne -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-6380) Implement Parameter Context Backend
Mark Payne created NIFI-6380: Summary: Implement Parameter Context Backend Key: NIFI-6380 URL: https://issues.apache.org/jira/browse/NIFI-6380 Project: Apache NiFi Issue Type: Sub-task Components: Core Framework Reporter: Mark Payne Assignee: Mark Payne -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (NIFIREG-283) JerseyExtensionClient incorrectly uses bundleType.name()
[ https://issues.apache.org/jira/browse/NIFIREG-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Doran resolved NIFIREG-283. - Resolution: Fixed > JerseyExtensionClient incorrectly uses bundleType.name() > - > > Key: NIFIREG-283 > URL: https://issues.apache.org/jira/browse/NIFIREG-283 > Project: NiFi Registry > Issue Type: Bug >Affects Versions: 0.4.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 0.5.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Should use toString() because that what the unmarshalling expects on the > server and would be consistent with other end-points. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi-registry] andrewmlim commented on issue #197: NIFIREG-206 Support anonymous access to public resources
andrewmlim commented on issue #197: NIFIREG-206 Support anonymous access to public resources URL: https://github.com/apache/nifi-registry/pull/197#issuecomment-502120763 That's what I thought might be the case. Thanks for checking though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] kevdoran merged pull request #200: NIFIREG-283 Fixing JerseyExtensionClient to use bundleType.toString()
kevdoran merged pull request #200: NIFIREG-283 Fixing JerseyExtensionClient to use bundleType.toString() URL: https://github.com/apache/nifi-registry/pull/200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] bbende commented on issue #197: NIFIREG-206 Support anonymous access to public resources
bbende commented on issue #197: NIFIREG-206 Support anonymous access to public resources URL: https://github.com/apache/nifi-registry/pull/197#issuecomment-502100856 @andrewmlim I'll consult with Scott to see if that is possible, but the icon is part of the checkbox text, so it is inside the element that is disabled. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] MikeThomsen commented on issue #3535: NIFI-6228 Fixed order of operations bug that prevented SSLContext fro…
MikeThomsen commented on issue #3535: NIFI-6228 Fixed order of operations bug that prevented SSLContext fro… URL: https://github.com/apache/nifi/pull/3535#issuecomment-502084040 Added the unit test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6377) Code coverage is misaligned for TS & JS files
[ https://issues.apache.org/jira/browse/NIFI-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Horváth updated NIFI-6377: - Summary: Code coverage is misaligned for TS & JS files (was: Code coverage is misaligned for TS files) > Code coverage is misaligned for TS & JS files > - > > Key: NIFI-6377 > URL: https://issues.apache.org/jira/browse/NIFI-6377 > Project: Apache NiFi > Issue Type: Bug > Components: Flow Versioning >Reporter: László Horváth >Assignee: László Horváth >Priority: Major > Labels: UI > > Code coverage is misaligned for TS files -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-6376) Code coverage is misaligned for TS & JS files
[ https://issues.apache.org/jira/browse/NIFI-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] László Horváth updated NIFI-6376: - Summary: Code coverage is misaligned for TS & JS files (was: Code coverage is misaligned for TS files) > Code coverage is misaligned for TS & JS files > - > > Key: NIFI-6376 > URL: https://issues.apache.org/jira/browse/NIFI-6376 > Project: Apache NiFi > Issue Type: Bug > Components: FDS >Reporter: László Horváth >Assignee: László Horváth >Priority: Major > Labels: UI > > Code coverage is misaligned for TS files. Probably there is a problem with > the order of Webpack loaders when generating the Coverage reports. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #590: MINIFICPP-621 Nanofi Tailfile example
phrocker commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r293762235
##
File path: nanofi/examples/tail_file.c
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+*/
+
+#include "api/nanofi.h"
+#include "core/string_utils.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+typedef struct flow_file_records {
+flow_file_record ** records;
+uint64_t len;
+} flow_file_records;
+
+struct flow_file_records * flowfiles = NULL;
+nifi_instance * instance = NULL;
+standalone_processor * proc = NULL;
+int file_offset = 0;
+int stopped = 0;
+
+void signal_handler(int signum) {
+if (signum == SIGINT || signum == SIGTERM) {
+stopped = 1;
+}
+}
+
+void transmit_flow_files(nifi_instance * instance) {
+NULL_CHECK( ,flowfiles);
+int i;
+for (i = 0; i < flowfiles->len; ++i) {
+NULL_CHECK( ,flowfiles->records[i]);
Review comment:
This seems like a case where a NULL_CHECK would indicate a bug somewhere in
our or the implementation of this library. That seems to indicate we really
should be performing an assertion. This function seems to also exist within
comms.h "transmit_to_nifi". Can create a follow on -- but there is a "blocks"
directory for some of our code deemed as building blocks but not part of the
primary API, some of the code here that is useful for other programs like this
can be placed there. Further, can we move this from example to a directory
named, "ECU". Eventually we can break that out into a separate entity.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #590: MINIFICPP-621 Nanofi Tailfile example
phrocker commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r293759579
##
File path: nanofi/examples/tail_file.c
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+*/
+
+#include "api/nanofi.h"
+#include "core/string_utils.h"
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+typedef struct flow_file_records {
+flow_file_record ** records;
+uint64_t len;
+} flow_file_records;
+
+struct flow_file_records * flowfiles = NULL;
+nifi_instance * instance = NULL;
+standalone_processor * proc = NULL;
+int file_offset = 0;
+int stopped = 0;
+
+void signal_handler(int signum) {
+if (signum == SIGINT || signum == SIGTERM) {
+stopped = 1;
Review comment:
Can make a follow on ticket for this ( especially since I'm just skimming
and don't have full context ): sig_atomic_t is typically used here as it's a
cross platform way to achieve atomicity; however, I see you are using int,
which is probably going to be written in a single instruction, anyway.
Since this aims to achieve cross platform compilation anyway, I think a
ticket may be warranted to explore if this is actually an issue or not. I'll
leave that up to you to decide if a ticket for exploration is warranted. It may
be the case that int will never provide a problem.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #590: MINIFICPP-621 Nanofi Tailfile example
phrocker commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r293757377
##
File path: nanofi/src/core/string_utils.c
##
@@ -0,0 +1,87 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "core/cstructs.h"
+#include "core/string_utils.h"
+#include
+#include
+
+tokens * tokenize_string(char * str, const char * delimiter) {
+if (!str || !delimiter) return NULL;
+
+char delim = delimiter[0];
+if (delim == '\\') {
+ if (strlen(delimiter) > 1) {
+switch (delimiter[1]) {
+ case 'r':
+delim = '\r';
+break;
+ case 't':
+delim = '\t';
+break;
+ case 'n':
+delim = '\n';
+break;
+ case '\\':
+delim = '\\';
+break;
+ default:
+break;
+}
+}
+}
+
+char * begin = str;
+char * end = NULL;
+int num_strings = 0;
+while ((end = strchr(begin, delim))) {
+if (begin == end) {
+begin++;
+continue;
+}
+begin = (end+1);
+num_strings++;
+}
+
+struct tokens * tks = (struct tokens *)malloc(sizeof(tokens));
+tks->str_list = malloc(sizeof(char *) * (num_strings));
+tks->num_strings = 0;
+tks->total_bytes = 0;
+
+for (int i = 0; i < num_strings; ++i) {
+tks->str_list[i] = NULL;
+}
+
+begin = str;
+end = NULL;
+while ((end = strchr(begin, delim))) {
+if (begin == end) {
+begin++;
+tks->total_bytes++;
+continue;
+}
+int len = end - begin;
Review comment:
sorry @msharee9 I haven't been able to take a look as others have -- but it
seems like they're offering good comments. I skimmed the review quickly and
this caught my eye due to strndup.
I don't believe strndup is commonly implemented. A project that I've worked
on previously ( https://github.com/rougier/freetype-gl/blob/master/platform.c )
has this file for this specific reason. I've seen similar implementations
across other projects so may be a nice string util if and only if you feel this
a worthwhile change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (MINIFICPP-921) Incorrect assignment of flags
[ https://issues.apache.org/jira/browse/MINIFICPP-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-921: - Affects Version/s: 0.7.0 > Incorrect assignment of flags > - > > Key: MINIFICPP-921 > URL: https://issues.apache.org/jira/browse/MINIFICPP-921 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Affects Versions: 0.7.0 >Reporter: Mr TheSegfault >Priority: Blocker > > Evidently I made a mistake when putting the cxx and c flags into cmake. > [https://github.com/apache/nifi-minifi-cpp/blob/master/CMakeLists.txt#L302] > is the culprit. If this runs on a system whose user has spaces ( I have one > for testing purposes ) – it will cause a failure while building curl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MINIFICPP-921) Incorrect assignment of flags
Mr TheSegfault created MINIFICPP-921: Summary: Incorrect assignment of flags Key: MINIFICPP-921 URL: https://issues.apache.org/jira/browse/MINIFICPP-921 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Mr TheSegfault Evidently I made a mistake when putting the cxx and c flags into cmake. [https://github.com/apache/nifi-minifi-cpp/blob/master/CMakeLists.txt#L302] is the culprit. If this runs on a system whose user has spaces ( I have one for testing purposes ) – it will cause a failure while building curl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MINIFICPP-921) Incorrect assignment of flags
[ https://issues.apache.org/jira/browse/MINIFICPP-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-921: - Fix Version/s: 0.7.0 > Incorrect assignment of flags > - > > Key: MINIFICPP-921 > URL: https://issues.apache.org/jira/browse/MINIFICPP-921 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Affects Versions: 0.7.0 >Reporter: Mr TheSegfault >Priority: Blocker > Fix For: 0.7.0 > > > Evidently I made a mistake when putting the cxx and c flags into cmake. > [https://github.com/apache/nifi-minifi-cpp/blob/master/CMakeLists.txt#L302] > is the culprit. If this runs on a system whose user has spaces ( I have one > for testing purposes ) – it will cause a failure while building curl. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
