[jira] [Commented] (NIFI-6409) Error inserting null fields in Teradata (through JDBC)
[ https://issues.apache.org/jira/browse/NIFI-6409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877527#comment-16877527 ] Guillermo Chico commented on NIFI-6409: --- [~mattyb149] > Error inserting null fields in Teradata (through JDBC) > -- > > Key: NIFI-6409 > URL: https://issues.apache.org/jira/browse/NIFI-6409 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.8.0 >Reporter: Guillermo Chico >Priority: Critical > Labels: Nifi > Attachments: ErrorNull.png, PutDatabaseRecord.PNG, TeradataPool.jpg > > > Hi, > I'm trying to insert data in a Teradata database using PutDatabaseRecord > processor. The process is fine until one record (input field) is null. Then > the entire insertion batch get an error and do rollback of the transaction. > Error capture: !ErrorNull.png! > Attached the configuration info: > -Processor: !PutDatabaseRecord.PNG! > -Pool: !TeradataPool.jpg! > Any idea about how can I resolve this error? > > Thank you in advance, > Guillermo Chico > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi] travisneeley commented on a change in pull request #3541: NIFI-6387 Implemented RetryFlowFile
travisneeley commented on a change in pull request #3541: NIFI-6387 Implemented
RetryFlowFile
URL: https://github.com/apache/nifi/pull/3541#discussion_r299747505
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RetryFlowFile.java
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.DynamicProperty;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.ReadsAttribute;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.configuration.DefaultSettings;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.ProcessorInitializationContext;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.util.StringUtils;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+@Tags({"Retry", "FlowFile"})
+@CapabilityDescription("FlowFiles passed to this Processor have a 'Retry
Attribute' value checked against a " +
+"configured 'Maximum Retries' value. If the current attribute value is
below the configured maximum, the " +
+"FlowFile is passed to a retry relationship. The FlowFile may or may
not be penalized in that condition. " +
+"If the FlowFile's attribute value exceeds the configured maximum, the
FlowFile will be passed to a " +
+"'retries_exceeded' relationship. WARNING: If the incoming FlowFile
has a non-numeric value in the " +
+"configured 'Retry Attribute' attribute, it will be reset to '1'. You
may choose to fail the FlowFile " +
+"instead of performing the reset. Additional dynamic properties can be
defined for any attributes you " +
+"wish to add to the FlowFiles transferred to 'retries_exceeded'. These
attributes support attribute " +
+"expression language.")
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
+@SupportsBatching
+@SideEffectFree
+@DefaultSettings(penaltyDuration = "2 min")
+@ReadsAttribute(attribute = "Retry Attribute",
+description = "Will read the attribute or attribute expression
language result as defined in 'Retry Attribute'")
+@WritesAttribute(attribute = "Retry Attribute",
+description = "User defined retry attribute is updated with the
current retry count")
+@DynamicProperty(name = "Exceeded FlowFile Attribute Key",
+value = "The value of the attribute added to the FlowFile",
+description = "One or more dynamic properties can be used to add
attributes to FlowFiles passed to " +
+"the 'retries_exceeded' relationship",
+expressionLanguageScope = ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+public class RetryFlowFile extends AbstractProcessor {
+private List properties;
+private Set relationships;
+private String retryAttribute;
+private Integer maximumRetries;
+private Boolean penalizeRetried;
+private Boolean failOnOverwrite;
+
+public static final PropertyDescriptor RETRY_ATTRIBUTE = new
PropertyDescriptor.Builder()
+.name("Retry Attribute")
+.description("The name of the attribute that contains the current
retry count for the FlowFile. " +
+"WARNING: If the name matches an attribute already on the
FlowFile t
[GitHub] [nifi] travisneeley commented on a change in pull request #3541: NIFI-6387 Implemented RetryFlowFile
travisneeley commented on a change in pull request #3541: NIFI-6387 Implemented
RetryFlowFile
URL: https://github.com/apache/nifi/pull/3541#discussion_r299747328
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RetryFlowFile.java
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.DynamicProperty;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.ReadsAttribute;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.configuration.DefaultSettings;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.ProcessorInitializationContext;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.util.StringUtils;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+@Tags({"Retry", "FlowFile"})
+@CapabilityDescription("FlowFiles passed to this Processor have a 'Retry
Attribute' value checked against a " +
+"configured 'Maximum Retries' value. If the current attribute value is
below the configured maximum, the " +
+"FlowFile is passed to a retry relationship. The FlowFile may or may
not be penalized in that condition. " +
+"If the FlowFile's attribute value exceeds the configured maximum, the
FlowFile will be passed to a " +
+"'retries_exceeded' relationship. WARNING: If the incoming FlowFile
has a non-numeric value in the " +
+"configured 'Retry Attribute' attribute, it will be reset to '1'. You
may choose to fail the FlowFile " +
+"instead of performing the reset. Additional dynamic properties can be
defined for any attributes you " +
+"wish to add to the FlowFiles transferred to 'retries_exceeded'. These
attributes support attribute " +
+"expression language.")
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
+@SupportsBatching
+@SideEffectFree
+@DefaultSettings(penaltyDuration = "2 min")
+@ReadsAttribute(attribute = "Retry Attribute",
+description = "Will read the attribute or attribute expression
language result as defined in 'Retry Attribute'")
+@WritesAttribute(attribute = "Retry Attribute",
+description = "User defined retry attribute is updated with the
current retry count")
+@DynamicProperty(name = "Exceeded FlowFile Attribute Key",
+value = "The value of the attribute added to the FlowFile",
+description = "One or more dynamic properties can be used to add
attributes to FlowFiles passed to " +
+"the 'retries_exceeded' relationship",
+expressionLanguageScope = ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+public class RetryFlowFile extends AbstractProcessor {
+private List properties;
+private Set relationships;
+private String retryAttribute;
+private Integer maximumRetries;
+private Boolean penalizeRetried;
+private Boolean failOnOverwrite;
+
+public static final PropertyDescriptor RETRY_ATTRIBUTE = new
PropertyDescriptor.Builder()
+.name("Retry Attribute")
+.description("The name of the attribute that contains the current
retry count for the FlowFile. " +
+"WARNING: If the name matches an attribute already on the
FlowFile t
[GitHub] [nifi] travisneeley commented on a change in pull request #3541: NIFI-6387 Implemented RetryFlowFile
travisneeley commented on a change in pull request #3541: NIFI-6387 Implemented
RetryFlowFile
URL: https://github.com/apache/nifi/pull/3541#discussion_r299747308
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RetryFlowFile.java
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.DynamicProperty;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.ReadsAttribute;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.configuration.DefaultSettings;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.ProcessorInitializationContext;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.util.StringUtils;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+@Tags({"Retry", "FlowFile"})
+@CapabilityDescription("FlowFiles passed to this Processor have a 'Retry
Attribute' value checked against a " +
+"configured 'Maximum Retries' value. If the current attribute value is
below the configured maximum, the " +
+"FlowFile is passed to a retry relationship. The FlowFile may or may
not be penalized in that condition. " +
+"If the FlowFile's attribute value exceeds the configured maximum, the
FlowFile will be passed to a " +
+"'retries_exceeded' relationship. WARNING: If the incoming FlowFile
has a non-numeric value in the " +
+"configured 'Retry Attribute' attribute, it will be reset to '1'. You
may choose to fail the FlowFile " +
+"instead of performing the reset. Additional dynamic properties can be
defined for any attributes you " +
+"wish to add to the FlowFiles transferred to 'retries_exceeded'. These
attributes support attribute " +
+"expression language.")
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
+@SupportsBatching
+@SideEffectFree
+@DefaultSettings(penaltyDuration = "2 min")
+@ReadsAttribute(attribute = "Retry Attribute",
+description = "Will read the attribute or attribute expression
language result as defined in 'Retry Attribute'")
+@WritesAttribute(attribute = "Retry Attribute",
+description = "User defined retry attribute is updated with the
current retry count")
+@DynamicProperty(name = "Exceeded FlowFile Attribute Key",
+value = "The value of the attribute added to the FlowFile",
+description = "One or more dynamic properties can be used to add
attributes to FlowFiles passed to " +
+"the 'retries_exceeded' relationship",
+expressionLanguageScope = ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+public class RetryFlowFile extends AbstractProcessor {
+private List properties;
+private Set relationships;
+private String retryAttribute;
+private Integer maximumRetries;
+private Boolean penalizeRetried;
+private Boolean failOnOverwrite;
+
+public static final PropertyDescriptor RETRY_ATTRIBUTE = new
PropertyDescriptor.Builder()
+.name("Retry Attribute")
+.description("The name of the attribute that contains the current
retry count for the FlowFile. " +
+"WARNING: If the name matches an attribute already on the
FlowFile t
[jira] [Updated] (NIFI-6387) RetryFlowFile
[ https://issues.apache.org/jira/browse/NIFI-6387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Neeley updated NIFI-6387: Remaining Estimate: (was: 10m) > RetryFlowFile > - > > Key: NIFI-6387 > URL: https://issues.apache.org/jira/browse/NIFI-6387 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Travis Neeley >Priority: Minor > Original Estimate: 2h > Time Spent: 1h 50m > > Processor takes a FlowFile. It will then look for a retry attribute on the > FlowFile. If none is present or if the designated retry attribute is set and > not a number, the retry attribute is set to "1" and passed to a retry > relationship. > A configurable PropertyDescriptor contains the maximum number of times the > FlowFile can be retried before being passed to a separate retries exceeded > relationship. This PropertyDescriptor should have a validator for allowable > positive integers for the retry. > Processor may also conditionally penalize the FlowFile on the retry > relationship. > > Many interactions with NiFi request some information from a service and retry > if the response isn't explicitly success. While it's quite common to use > UpdateAttribute followed by a RouteOnAttribute to do this, there could be > value in having a discreet processor for this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-6417) JOLT processors should accept more character encodings
Matt Burgess created NIFI-6417: -- Summary: JOLT processors should accept more character encodings Key: NIFI-6417 URL: https://issues.apache.org/jira/browse/NIFI-6417 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Matt Burgess Currently JoltTransformJSON and JoltTransformRecord are hard-coded to input and output UTF-8 encoding. These processors should be able to at least accept a user-configured input encoding such as UTF-16, ISO-8859-1, etc. We could retain the behavior of writing out in UTF-8, but I think for consistency and flexibility we should add an Output Character Encoding property as well. Both would be defaulted to UTF-8 to maintain current default behavior. *NOTE*: There may be a limitation at present with JoltTransformRecord regarding String fields, where they are hard-coded to be UTF-8. If that is the case, then both processors should still offer the Input Character Encoding, but only JoltTransformJSON would have the Output Character Encoding property. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (NIFI-6401) Long List of Users Overflows onto Date
[ https://issues.apache.org/jira/browse/NIFI-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-6401: - Assignee: Robert Fellows > Long List of Users Overflows onto Date > -- > > Key: NIFI-6401 > URL: https://issues.apache.org/jira/browse/NIFI-6401 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Troy Melhase >Assignee: Robert Fellows >Priority: Minor > Fix For: 1.10.0 > > Attachments: Untitled.png > > Time Spent: 40m > Remaining Estimate: 0h > > When the users table has many users, the list can sometimes overflow onto the > date display. See screenshot for example. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (NIFI-6401) Long List of Users Overflows onto Date
[ https://issues.apache.org/jira/browse/NIFI-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman resolved NIFI-6401. --- Resolution: Fixed Fix Version/s: 1.10.0 > Long List of Users Overflows onto Date > -- > > Key: NIFI-6401 > URL: https://issues.apache.org/jira/browse/NIFI-6401 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Troy Melhase >Priority: Minor > Fix For: 1.10.0 > > Attachments: Untitled.png > > Time Spent: 40m > Remaining Estimate: 0h > > When the users table has many users, the list can sometimes overflow onto the > date display. See screenshot for example. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-6401) Long List of Users Overflows onto Date
[ https://issues.apache.org/jira/browse/NIFI-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877279#comment-16877279 ] ASF subversion and git services commented on NIFI-6401: --- Commit 846c9b0a3fbbe7ca366b34c89e0f5885750b8a59 in nifi's branch refs/heads/master from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=846c9b0 ] NIFI-6401 - Long List of Users Overflows onto Date This closes #3567 > Long List of Users Overflows onto Date > -- > > Key: NIFI-6401 > URL: https://issues.apache.org/jira/browse/NIFI-6401 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Troy Melhase >Priority: Minor > Attachments: Untitled.png > > Time Spent: 20m > Remaining Estimate: 0h > > When the users table has many users, the list can sometimes overflow onto the > date display. See screenshot for example. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi] mcgilman commented on issue #3567: NIFI-6401 - Long List of Users Overflows onto Date
mcgilman commented on issue #3567: NIFI-6401 - Long List of Users Overflows onto Date URL: https://github.com/apache/nifi/pull/3567#issuecomment-507824499 Thanks @rfellows! This has been merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] asfgit closed pull request #3567: NIFI-6401 - Long List of Users Overflows onto Date
asfgit closed pull request #3567: NIFI-6401 - Long List of Users Overflows onto Date URL: https://github.com/apache/nifi/pull/3567 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mcgilman commented on issue #3567: NIFI-6401 - Long List of Users Overflows onto Date
mcgilman commented on issue #3567: NIFI-6401 - Long List of Users Overflows onto Date URL: https://github.com/apache/nifi/pull/3567#issuecomment-507817801 Will review... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] rfellows opened a new pull request #3567: NIFI-6401 - Long List of Users Overflows onto Date
rfellows opened a new pull request #3567: NIFI-6401 - Long List of Users
Overflows onto Date
URL: https://github.com/apache/nifi/pull/3567
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
This fixes a display issue when viewing the list of users. If the list was
very long (or the browser very short) the user list would overlap the Date/time
display at the bottom.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (NIFI-6415) Nifi Build Fails on nifi-web-api
[
https://issues.apache.org/jira/browse/NIFI-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877260#comment-16877260
]
Matt Gilman commented on NIFI-6415:
---
[~dsargrad] Thanks for file this JIRA. I just tried a build after deleting my
maven repository and everything seems to work ok. Also, it looks like the
Travis build for master is currently passing. The artifact that is referenced
there is not something that is downloaded. It's something that should be
generated as part of this build. Can you inspect it in your maven repository?
{code}
# mgilman in ~/.m2/repository/org/apache/nifi/nifi-web-security/1.10.0-SNAPSHOT
[15:18:30]
$ ls
_remote.repositoriesmaven-metadata-local.xml
nifi-web-security-1.10.0-SNAPSHOT-tests.jar
nifi-web-security-1.10.0-SNAPSHOT.jar
nifi-web-security-1.10.0-SNAPSHOT.pom
# mgilman in ~/.m2/repository/org/apache/nifi/nifi-web-security/1.10.0-SNAPSHOT
[15:22:52]
$ file nifi-web-security-1.10.0-SNAPSHOT-tests.jar
nifi-web-security-1.10.0-SNAPSHOT-tests.jar: Zip archive data, at least v2.0 to
extract
{code}
Does the directory listing look the same? You should be able to just delete the
1.10.0-SNAPSHOT directory and rebuild again.
> Nifi Build Fails on nifi-web-api
>
>
> Key: NIFI-6415
> URL: https://issues.apache.org/jira/browse/NIFI-6415
> Project: Apache NiFi
> Issue Type: Bug
> Environment: centos 7
> mvn 3.6.0
> java 1.8.0_212 openjdk
>Reporter: David Sargrad
>Priority: Major
> Attachments: image-2019-07-02-14-11-15-318.png
>
>
> I am trying to build the latest nifi master from git.
>
> git clone [https://gitbox.apache.org/repos/asf/nifi.git]
> git checkout master
>
> I am using the command mvn install -Dmaven.test.skip=true
>
> The build consistently fails with the following message.
>
> !image-2019-07-02-14-11-15-318.png!
> I deleted my entire .m2 repository to force maven to download. I get the same
> results. Many other projects seem to build ok.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFI-6415) Nifi Build Fails on nifi-web-api
[ https://issues.apache.org/jira/browse/NIFI-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Sargrad updated NIFI-6415: Description: I am trying to build the latest nifi master from git. git clone [https://gitbox.apache.org/repos/asf/nifi.git] git checkout master I am using the command mvn install -Dmaven.test.skip=true The build consistently fails with the following message. !image-2019-07-02-14-11-15-318.png! I deleted my entire .m2 repository to force maven to download. I get the same results. Many other projects seem to build ok. was: I am trying to build the latest nifi master from git. git clone [https://gitbox.apache.org/repos/asf/nifi.git] git checkout master I am using the command mvn install -Dmaven.test.skip=true The build consistently fails with the following message. !image-2019-07-02-14-11-15-318.png! I deleted my entire .m2 repository to force maven to download. I get the same results. Many other projects seem to build ok. > Nifi Build Fails on nifi-web-api > > > Key: NIFI-6415 > URL: https://issues.apache.org/jira/browse/NIFI-6415 > Project: Apache NiFi > Issue Type: Bug > Environment: centos 7 > mvn 3.6.0 > java 1.8.0_212 openjdk >Reporter: David Sargrad >Priority: Major > Attachments: image-2019-07-02-14-11-15-318.png > > > I am trying to build the latest nifi master from git. > > git clone [https://gitbox.apache.org/repos/asf/nifi.git] > git checkout master > > > I am using the command mvn install -Dmaven.test.skip=true > > The build consistently fails with the following message. > > !image-2019-07-02-14-11-15-318.png! > I deleted my entire .m2 repository to force maven to download. I get the same > results. Many other projects seem to build ok. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-6415) Nifi Build Fails on nifi-web-api
[ https://issues.apache.org/jira/browse/NIFI-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Sargrad updated NIFI-6415: Description: I am trying to build the latest nifi master from git. git clone [https://gitbox.apache.org/repos/asf/nifi.git] git checkout master I am using the command mvn install -Dmaven.test.skip=true The build consistently fails with the following message. !image-2019-07-02-14-11-15-318.png! I deleted my entire .m2 repository to force maven to download. I get the same results. Many other projects seem to build ok. was: I am trying to build the latest nifi master from git. git clone [https://gitbox.apache.org/repos/asf/nifi.git] git checkout master I am using the command mvn install -Dmaven.test.skip=true The build consistently fails with the following message. !image-2019-07-02-14-11-15-318.png! I deleted my entire .m2 repository to force maven to download. I get the same results. Many other projects seem to build ok. > Nifi Build Fails on nifi-web-api > > > Key: NIFI-6415 > URL: https://issues.apache.org/jira/browse/NIFI-6415 > Project: Apache NiFi > Issue Type: Bug > Environment: centos 7 > mvn 3.6.0 > java 1.8.0_212 openjdk >Reporter: David Sargrad >Priority: Major > Attachments: image-2019-07-02-14-11-15-318.png > > > I am trying to build the latest nifi master from git. > > git clone [https://gitbox.apache.org/repos/asf/nifi.git] > git checkout master > > I am using the command mvn install -Dmaven.test.skip=true > > The build consistently fails with the following message. > > !image-2019-07-02-14-11-15-318.png! > I deleted my entire .m2 repository to force maven to download. I get the same > results. Many other projects seem to build ok. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-6415) Nifi Build Fails on nifi-web-api
[ https://issues.apache.org/jira/browse/NIFI-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Sargrad updated NIFI-6415: Description: I am trying to build the latest nifi master from git. git clone [https://gitbox.apache.org/repos/asf/nifi.git] git checkout master I am using the command mvn install -Dmaven.test.skip=true The build consistently fails with the following message. !image-2019-07-02-14-11-15-318.png! I deleted my entire .m2 repository to force maven to download. I get the same results. Many other projects seem to build ok. was: I am trying to build the latest nifi master from git. I am using the command mvn install -Dmaven.test.skip=true The build consistently fails with the following message. !image-2019-07-02-14-11-15-318.png! I deleted my entire .m2 repository to force maven to download. I get the same results. Many other projects seem to build ok. > Nifi Build Fails on nifi-web-api > > > Key: NIFI-6415 > URL: https://issues.apache.org/jira/browse/NIFI-6415 > Project: Apache NiFi > Issue Type: Bug > Environment: centos 7 > mvn 3.6.0 > java 1.8.0_212 openjdk >Reporter: David Sargrad >Priority: Major > Attachments: image-2019-07-02-14-11-15-318.png > > > I am trying to build the latest nifi master from git. > > git clone [https://gitbox.apache.org/repos/asf/nifi.git] > git checkout master > > I am using the command mvn install -Dmaven.test.skip=true > > The build consistently fails with the following message. > > !image-2019-07-02-14-11-15-318.png! > I deleted my entire .m2 repository to force maven to download. I get the same > results. Many other projects seem to build ok. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (NIFI-4265) Build fails on clean git clone at in org.apache.nifi.processors.standard.TestGetFile
[
https://issues.apache.org/jira/browse/NIFI-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877230#comment-16877230
]
Sol Huebner edited comment on NIFI-4265 at 7/2/19 6:32 PM:
---
I have the same issues with 1.9.2 (CentOS 7):
[ERROR] TestGetFile.testWithInaccessibleDir:64 NullPointer
[ERROR] TestGetFile.testWithUnreadableDir:93 NullPointer
[ERROR] TestGetFile.testWithUnwritableDir:121 NullPointer
was (Author: solhuebner):
I have the same issues with 1.9.2:
[ERROR] TestGetFile.testWithInaccessibleDir:64 NullPointer
[ERROR] TestGetFile.testWithUnreadableDir:93 NullPointer
[ERROR] TestGetFile.testWithUnwritableDir:121 NullPointer
> Build fails on clean git clone at in
> org.apache.nifi.processors.standard.TestGetFile
>
>
> Key: NIFI-4265
> URL: https://issues.apache.org/jira/browse/NIFI-4265
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.3.0
> Environment: Windows 10 PC and Ubuntu 16
>Reporter: Martin Voigt
>Priority: Major
> Labels: build, newbie
>
> After a git clone from https://github.com/apache/nifi of the current project
> state, the build (mvn clean install) fails.
> {{Running org.apache.nifi.processors.standard.TestGetFile
> Tests run: 7, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.021 sec <<<
> FAILURE! - in org.apache.nifi.processors.standard.TestGetFile
> testWithUnreadableDir(org.apache.nifi.processors.standard.TestGetFile) Time
> elapsed: 0.009 sec <<< ERROR!
> java.lang.NullPointerException: null
> at
> org.apache.nifi.processors.standard.TestGetFile.testWithUnreadableDir(TestGetFile.java:92)
> testWithInaccessibleDir(org.apache.nifi.processors.standard.TestGetFile)
> Time elapsed: 0 sec <<< ERROR!
> java.lang.NullPointerException: null
> at
> org.apache.nifi.processors.standard.TestGetFile.testWithInaccessibleDir(TestGetFile.java:64)
> testWithUnwritableDir(org.apache.nifi.processors.standard.TestGetFile) Time
> elapsed: 0.001 sec <<< ERROR!
> java.lang.NullPointerException: null
> at
> org.apache.nifi.processors.standard.TestGetFile.testWithUnwritableDir(TestGetFile.java:120)
> }}
> {{
> ...
> [INFO] nifi-standard-utils SUCCESS [ 2.179
> s]
> [INFO] nifi-standard-processors ... FAILURE [03:14
> min]
> [INFO] nifi-standard-reporting-tasks .. SKIPPED
> ...
> }}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4265) Build fails on clean git clone at in org.apache.nifi.processors.standard.TestGetFile
[
https://issues.apache.org/jira/browse/NIFI-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877230#comment-16877230
]
Sol Huebner commented on NIFI-4265:
---
I have the same issues with 1.9.2:
[ERROR] TestGetFile.testWithInaccessibleDir:64 NullPointer
[ERROR] TestGetFile.testWithUnreadableDir:93 NullPointer
[ERROR] TestGetFile.testWithUnwritableDir:121 NullPointer
> Build fails on clean git clone at in
> org.apache.nifi.processors.standard.TestGetFile
>
>
> Key: NIFI-4265
> URL: https://issues.apache.org/jira/browse/NIFI-4265
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.3.0
> Environment: Windows 10 PC and Ubuntu 16
>Reporter: Martin Voigt
>Priority: Major
> Labels: build, newbie
>
> After a git clone from https://github.com/apache/nifi of the current project
> state, the build (mvn clean install) fails.
> {{Running org.apache.nifi.processors.standard.TestGetFile
> Tests run: 7, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.021 sec <<<
> FAILURE! - in org.apache.nifi.processors.standard.TestGetFile
> testWithUnreadableDir(org.apache.nifi.processors.standard.TestGetFile) Time
> elapsed: 0.009 sec <<< ERROR!
> java.lang.NullPointerException: null
> at
> org.apache.nifi.processors.standard.TestGetFile.testWithUnreadableDir(TestGetFile.java:92)
> testWithInaccessibleDir(org.apache.nifi.processors.standard.TestGetFile)
> Time elapsed: 0 sec <<< ERROR!
> java.lang.NullPointerException: null
> at
> org.apache.nifi.processors.standard.TestGetFile.testWithInaccessibleDir(TestGetFile.java:64)
> testWithUnwritableDir(org.apache.nifi.processors.standard.TestGetFile) Time
> elapsed: 0.001 sec <<< ERROR!
> java.lang.NullPointerException: null
> at
> org.apache.nifi.processors.standard.TestGetFile.testWithUnwritableDir(TestGetFile.java:120)
> }}
> {{
> ...
> [INFO] nifi-standard-utils SUCCESS [ 2.179
> s]
> [INFO] nifi-standard-processors ... FAILURE [03:14
> min]
> [INFO] nifi-standard-reporting-tasks .. SKIPPED
> ...
> }}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [nifi] markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#discussion_r299624344 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ParameterContextResource.java ## @@ -0,0 +1,1185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.web.api; + +import io.swagger.annotations.Api; +import io.swagger.annotations.ApiOperation; +import io.swagger.annotations.ApiParam; +import io.swagger.annotations.ApiResponse; +import io.swagger.annotations.ApiResponses; +import io.swagger.annotations.Authorization; +import org.apache.commons.lang3.StringUtils; +import org.apache.nifi.authorization.Authorizer; +import org.apache.nifi.authorization.RequestAction; +import org.apache.nifi.authorization.resource.Authorizable; +import org.apache.nifi.authorization.user.NiFiUser; +import org.apache.nifi.authorization.user.NiFiUserUtils; +import org.apache.nifi.cluster.manager.NodeResponse; +import org.apache.nifi.controller.ScheduledState; +import org.apache.nifi.controller.service.ControllerServiceState; +import org.apache.nifi.web.NiFiServiceFacade; +import org.apache.nifi.web.ResourceNotFoundException; +import org.apache.nifi.web.ResumeFlowException; +import org.apache.nifi.web.Revision; +import org.apache.nifi.web.api.concurrent.AsyncRequestManager; +import org.apache.nifi.web.api.concurrent.AsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.RequestManager; +import org.apache.nifi.web.api.concurrent.StandardAsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.StandardUpdateStep; +import org.apache.nifi.web.api.concurrent.UpdateStep; +import org.apache.nifi.web.api.dto.AffectedComponentDTO; +import org.apache.nifi.web.api.dto.DtoFactory; +import org.apache.nifi.web.api.dto.ParameterContextDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateRequestDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateStepDTO; +import org.apache.nifi.web.api.dto.ParameterContextValidationRequestDTO; +import org.apache.nifi.web.api.dto.ParameterDTO; +import org.apache.nifi.web.api.dto.RevisionDTO; +import org.apache.nifi.web.api.entity.AffectedComponentEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultsEntity; +import org.apache.nifi.web.api.entity.Entity; +import org.apache.nifi.web.api.entity.ParameterContextEntity; +import org.apache.nifi.web.api.entity.ParameterContextUpdateRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextValidationRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextsEntity; +import org.apache.nifi.web.api.entity.ParameterEntity; +import org.apache.nifi.web.api.entity.ProcessGroupEntity; +import org.apache.nifi.web.api.request.ClientIdParameter; +import org.apache.nifi.web.api.request.LongParameter; +import org.apache.nifi.web.util.AffectedComponentUtils; +import org.apache.nifi.web.util.CancellableTimedPause; +import org.apache.nifi.web.util.ComponentLifecycle; +import org.apache.nifi.web.util.InvalidComponentAction; +import org.apache.nifi.web.util.LifecycleManagementException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.ws.rs.Consumes; +import javax.ws.rs.DELETE; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.HttpMethod; +import javax.ws.rs.POST; +import javax.ws.rs.PUT; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import java.net.URI; +import java.net.URISyntaxException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.Date; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.TimeUnit; +import java.util.function.Consumer; +import java.util.s
[GitHub] [nifi] markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#discussion_r299621049 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ParameterContextResource.java ## @@ -0,0 +1,1185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.web.api; + +import io.swagger.annotations.Api; +import io.swagger.annotations.ApiOperation; +import io.swagger.annotations.ApiParam; +import io.swagger.annotations.ApiResponse; +import io.swagger.annotations.ApiResponses; +import io.swagger.annotations.Authorization; +import org.apache.commons.lang3.StringUtils; +import org.apache.nifi.authorization.Authorizer; +import org.apache.nifi.authorization.RequestAction; +import org.apache.nifi.authorization.resource.Authorizable; +import org.apache.nifi.authorization.user.NiFiUser; +import org.apache.nifi.authorization.user.NiFiUserUtils; +import org.apache.nifi.cluster.manager.NodeResponse; +import org.apache.nifi.controller.ScheduledState; +import org.apache.nifi.controller.service.ControllerServiceState; +import org.apache.nifi.web.NiFiServiceFacade; +import org.apache.nifi.web.ResourceNotFoundException; +import org.apache.nifi.web.ResumeFlowException; +import org.apache.nifi.web.Revision; +import org.apache.nifi.web.api.concurrent.AsyncRequestManager; +import org.apache.nifi.web.api.concurrent.AsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.RequestManager; +import org.apache.nifi.web.api.concurrent.StandardAsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.StandardUpdateStep; +import org.apache.nifi.web.api.concurrent.UpdateStep; +import org.apache.nifi.web.api.dto.AffectedComponentDTO; +import org.apache.nifi.web.api.dto.DtoFactory; +import org.apache.nifi.web.api.dto.ParameterContextDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateRequestDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateStepDTO; +import org.apache.nifi.web.api.dto.ParameterContextValidationRequestDTO; +import org.apache.nifi.web.api.dto.ParameterDTO; +import org.apache.nifi.web.api.dto.RevisionDTO; +import org.apache.nifi.web.api.entity.AffectedComponentEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultsEntity; +import org.apache.nifi.web.api.entity.Entity; +import org.apache.nifi.web.api.entity.ParameterContextEntity; +import org.apache.nifi.web.api.entity.ParameterContextUpdateRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextValidationRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextsEntity; +import org.apache.nifi.web.api.entity.ParameterEntity; +import org.apache.nifi.web.api.entity.ProcessGroupEntity; +import org.apache.nifi.web.api.request.ClientIdParameter; +import org.apache.nifi.web.api.request.LongParameter; +import org.apache.nifi.web.util.AffectedComponentUtils; +import org.apache.nifi.web.util.CancellableTimedPause; +import org.apache.nifi.web.util.ComponentLifecycle; +import org.apache.nifi.web.util.InvalidComponentAction; +import org.apache.nifi.web.util.LifecycleManagementException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.ws.rs.Consumes; +import javax.ws.rs.DELETE; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.HttpMethod; +import javax.ws.rs.POST; +import javax.ws.rs.PUT; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import java.net.URI; +import java.net.URISyntaxException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.Date; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.TimeUnit; +import java.util.function.Consumer; +import java.util.s
[jira] [Created] (NIFI-6416) WriteAheadFlowFileRepository.swapFlowFilesIn() not removing swapLocationSuffixes
Brandon DeVries created NIFI-6416: - Summary: WriteAheadFlowFileRepository.swapFlowFilesIn() not removing swapLocationSuffixes Key: NIFI-6416 URL: https://issues.apache.org/jira/browse/NIFI-6416 Project: Apache NiFi Issue Type: Bug Components: Core Framework Reporter: Brandon DeVries WriteAheadFlowFileRepository maintains a list of swapLocationSuffixes. This is added to when records are swapped out, and removed from when records are swapped in when the repo is updated[1]. However, the swapFlowFilesIn method[2] appears to be adding instead of removing the specified swap location. [1] [https://github.com/apache/nifi/blob/f08c2ee43f39584b7d4e76d61d7d4aaa889068fd/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java#L372-L377] [2] [https://github.com/apache/nifi/blob/f08c2ee43f39584b7d4e76d61d7d4aaa889068fd/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java#L518] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi] mcgilman commented on a change in pull request #3553: NIFI-5856: When exporting a flow that references a Controller Service…
mcgilman commented on a change in pull request #3553: NIFI-5856: When exporting a flow that references a Controller Service… URL: https://github.com/apache/nifi/pull/3553#discussion_r299587983 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/NiFiServiceFacade.java ## @@ -1359,13 +1360,16 @@ * @param registryId the ID of the Flow Registry to persist the snapshot to * @param flow the flow where the snapshot should be persisted * @param snapshot the Snapshot to persist + * @param externalControllerServiceReferences a mapping of controller service id to ExternalControllerServiceReference for any Controller Service that is referenced in the flow but not included + * in the VersionedProcessGroup * @param comments about the snapshot * @param expectedVersion the version to save the flow as * @return the snapshot that represents what was stored in the registry * * @throws NiFiCoreException if unable to register the snapshot with the flow registry */ -VersionedFlowSnapshot registerVersionedFlowSnapshot(String registryId, VersionedFlow flow, VersionedProcessGroup snapshot, String comments, int expectedVersion); +VersionedFlowSnapshot registerVersionedFlowSnapshot(String registryId, VersionedFlow flow, VersionedProcessGroup snapshot, Review comment: Methods that start `register*` currently only obtains the service facade `READ` lock. Is this adequate for this and other `register*` methods? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mcgilman commented on a change in pull request #3553: NIFI-5856: When exporting a flow that references a Controller Service…
mcgilman commented on a change in pull request #3553: NIFI-5856: When exporting
a flow that references a Controller Service…
URL: https://github.com/apache/nifi/pull/3553#discussion_r299618765
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java
##
@@ -3071,6 +3076,99 @@ public void
discoverCompatibleBundles(VersionedProcessGroup versionedGroup) {
BundleUtils.discoverCompatibleBundles(controllerFacade.getExtensionManager(),
versionedGroup);
}
+@Override
+public void resolveInheritedControllerServices(final VersionedFlowSnapshot
versionedFlowSnapshot, final String processGroupId) {
+final VersionedProcessGroup versionedGroup =
versionedFlowSnapshot.getFlowContents();
+resolveInheritedControllerServices(versionedGroup, processGroupId,
versionedFlowSnapshot.getExternalControllerServices());
+}
+
+private void resolveInheritedControllerServices(final
VersionedProcessGroup versionedGroup, final String processGroupId,
+final Map externalControllerServiceReferences) {
+final Set availableControllerServiceIds =
findAllControllerServiceIds(versionedGroup);
+final ProcessGroup parentGroup =
processGroupDAO.getProcessGroup(processGroupId);
+final Set serviceNodes =
parentGroup.getControllerServices(true);
+
+for (final VersionedProcessor processor :
versionedGroup.getProcessors()) {
+resolveInheritedControllerServices(processor,
availableControllerServiceIds, serviceNodes,
externalControllerServiceReferences);
+}
+
+for (final VersionedControllerService service :
versionedGroup.getControllerServices()) {
+resolveInheritedControllerServices(service,
availableControllerServiceIds, serviceNodes,
externalControllerServiceReferences);
+}
+
+for (final VersionedProcessGroup child :
versionedGroup.getProcessGroups()) {
+resolveInheritedControllerServices(child, processGroupId,
externalControllerServiceReferences);
+}
+}
+
+
+private void resolveInheritedControllerServices(final
VersionedConfigurableComponent component, final Set
availableControllerServiceIds,
+final
Set availableControllerServices,
+final Map externalControllerServiceReferences) {
+final Map descriptors =
component.getPropertyDescriptors();
+final Map properties = component.getProperties();
+
+resolveInheritedControllerServices(descriptors, properties,
availableControllerServiceIds, availableControllerServices,
externalControllerServiceReferences);
+}
+
+
+private void resolveInheritedControllerServices(final Map propertyDescriptors, final Map
componentProperties,
+final Set
availableControllerServiceIds, final Set
availableControllerServices,
+final Map externalControllerServiceReferences) {
+
+for (final Map.Entry entry : new
HashMap<>(componentProperties).entrySet()) {
+final String propertyName = entry.getKey();
+final String propertyValue = entry.getValue();
+
+final VersionedPropertyDescriptor propertyDescriptor =
propertyDescriptors.get(propertyName);
+if (propertyDescriptor == null) {
+continue;
+}
+
+if (!propertyDescriptor.getIdentifiesControllerService()) {
+continue;
+}
+
+// If the referenced Controller Service is available in this flow,
there is nothing to resolve.
+if (availableControllerServiceIds.contains(propertyValue)) {
+continue;
+}
+
+final ExternalControllerServiceReference externalServiceReference
= externalControllerServiceReferences == null ? null :
externalControllerServiceReferences.get(propertyValue);
+final String externalControllerServiceName =
externalServiceReference == null ? null : externalServiceReference.getName();
+
+final List matchingControllerServices =
availableControllerServices.stream()
+.filter(service ->
service.getName().equals(externalControllerServiceName))
Review comment:
This only considers the external service by name. During my testing, I was
able to set this property to a service of an incompatible type. Should we also
be verifying the property descriptors type is compatible with the type of the
external service?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this se
[GitHub] [nifi] mcgilman commented on a change in pull request #3553: NIFI-5856: When exporting a flow that references a Controller Service…
mcgilman commented on a change in pull request #3553: NIFI-5856: When exporting a flow that references a Controller Service… URL: https://github.com/apache/nifi/pull/3553#discussion_r299588726 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/NiFiServiceFacade.java ## @@ -2156,6 +2160,16 @@ ControllerServiceReferencingComponentsEntity updateControllerServiceReferencingC */ void discoverCompatibleBundles(VersionedProcessGroup versionedGroup); +/** + * For any Controller Service that is found in the given Versioned Process Group, if that Controller Service is not itself included in the Versioned Process Groups, + * attempts to find an existing Controller Service that matches the definition. If any is found, the component within the Versioned Process Group is updated to point + * to the existing service. + * + * @param versionedFlowSnapshot the flow snapshot + * @param parentGroupId the ID of the Process Group from which the Controller Services are inherited + */ +void resolveInheritedControllerServices(VersionedFlowSnapshot versionedFlowSnapshot, String parentGroupId); Review comment: Methods starting with `resolve*` are currently ignored with the service facade lock. Can we please update it to ensure we are acquiring the appropriate lock? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mcgilman commented on a change in pull request #3553: NIFI-5856: When exporting a flow that references a Controller Service…
mcgilman commented on a change in pull request #3553: NIFI-5856: When exporting
a flow that references a Controller Service…
URL: https://github.com/apache/nifi/pull/3553#discussion_r299619421
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java
##
@@ -3071,6 +3076,99 @@ public void
discoverCompatibleBundles(VersionedProcessGroup versionedGroup) {
BundleUtils.discoverCompatibleBundles(controllerFacade.getExtensionManager(),
versionedGroup);
}
+@Override
+public void resolveInheritedControllerServices(final VersionedFlowSnapshot
versionedFlowSnapshot, final String processGroupId) {
+final VersionedProcessGroup versionedGroup =
versionedFlowSnapshot.getFlowContents();
+resolveInheritedControllerServices(versionedGroup, processGroupId,
versionedFlowSnapshot.getExternalControllerServices());
+}
+
+private void resolveInheritedControllerServices(final
VersionedProcessGroup versionedGroup, final String processGroupId,
+final Map externalControllerServiceReferences) {
+final Set availableControllerServiceIds =
findAllControllerServiceIds(versionedGroup);
+final ProcessGroup parentGroup =
processGroupDAO.getProcessGroup(processGroupId);
+final Set serviceNodes =
parentGroup.getControllerServices(true);
+
+for (final VersionedProcessor processor :
versionedGroup.getProcessors()) {
+resolveInheritedControllerServices(processor,
availableControllerServiceIds, serviceNodes,
externalControllerServiceReferences);
+}
+
+for (final VersionedControllerService service :
versionedGroup.getControllerServices()) {
+resolveInheritedControllerServices(service,
availableControllerServiceIds, serviceNodes,
externalControllerServiceReferences);
+}
+
+for (final VersionedProcessGroup child :
versionedGroup.getProcessGroups()) {
+resolveInheritedControllerServices(child, processGroupId,
externalControllerServiceReferences);
+}
+}
+
+
+private void resolveInheritedControllerServices(final
VersionedConfigurableComponent component, final Set
availableControllerServiceIds,
+final
Set availableControllerServices,
+final Map externalControllerServiceReferences) {
+final Map descriptors =
component.getPropertyDescriptors();
+final Map properties = component.getProperties();
+
+resolveInheritedControllerServices(descriptors, properties,
availableControllerServiceIds, availableControllerServices,
externalControllerServiceReferences);
+}
+
+
+private void resolveInheritedControllerServices(final Map propertyDescriptors, final Map
componentProperties,
+final Set
availableControllerServiceIds, final Set
availableControllerServices,
+final Map externalControllerServiceReferences) {
+
+for (final Map.Entry entry : new
HashMap<>(componentProperties).entrySet()) {
+final String propertyName = entry.getKey();
+final String propertyValue = entry.getValue();
+
+final VersionedPropertyDescriptor propertyDescriptor =
propertyDescriptors.get(propertyName);
+if (propertyDescriptor == null) {
+continue;
+}
+
+if (!propertyDescriptor.getIdentifiesControllerService()) {
+continue;
+}
+
+// If the referenced Controller Service is available in this flow,
there is nothing to resolve.
+if (availableControllerServiceIds.contains(propertyValue)) {
+continue;
+}
+
+final ExternalControllerServiceReference externalServiceReference
= externalControllerServiceReferences == null ? null :
externalControllerServiceReferences.get(propertyValue);
+final String externalControllerServiceName =
externalServiceReference == null ? null : externalServiceReference.getName();
Review comment:
If `externalControllerServiceName` is null, do we need to run the code
below? Can we short circuit with `continue`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (NIFI-6415) Nifi Build Fails on nifi-web-api
David Sargrad created NIFI-6415: --- Summary: Nifi Build Fails on nifi-web-api Key: NIFI-6415 URL: https://issues.apache.org/jira/browse/NIFI-6415 Project: Apache NiFi Issue Type: Bug Environment: centos 7 mvn 3.6.0 java 1.8.0_212 openjdk Reporter: David Sargrad Attachments: image-2019-07-02-14-11-15-318.png I am trying to build the latest nifi master from git. I am using the command mvn install -Dmaven.test.skip=true The build consistently fails with the following message. !image-2019-07-02-14-11-15-318.png! I deleted my entire .m2 repository to force maven to download. I get the same results. Many other projects seem to build ok. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi] markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#discussion_r299617168 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ParameterContextResource.java ## @@ -0,0 +1,1185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.web.api; + +import io.swagger.annotations.Api; +import io.swagger.annotations.ApiOperation; +import io.swagger.annotations.ApiParam; +import io.swagger.annotations.ApiResponse; +import io.swagger.annotations.ApiResponses; +import io.swagger.annotations.Authorization; +import org.apache.commons.lang3.StringUtils; +import org.apache.nifi.authorization.Authorizer; +import org.apache.nifi.authorization.RequestAction; +import org.apache.nifi.authorization.resource.Authorizable; +import org.apache.nifi.authorization.user.NiFiUser; +import org.apache.nifi.authorization.user.NiFiUserUtils; +import org.apache.nifi.cluster.manager.NodeResponse; +import org.apache.nifi.controller.ScheduledState; +import org.apache.nifi.controller.service.ControllerServiceState; +import org.apache.nifi.web.NiFiServiceFacade; +import org.apache.nifi.web.ResourceNotFoundException; +import org.apache.nifi.web.ResumeFlowException; +import org.apache.nifi.web.Revision; +import org.apache.nifi.web.api.concurrent.AsyncRequestManager; +import org.apache.nifi.web.api.concurrent.AsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.RequestManager; +import org.apache.nifi.web.api.concurrent.StandardAsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.StandardUpdateStep; +import org.apache.nifi.web.api.concurrent.UpdateStep; +import org.apache.nifi.web.api.dto.AffectedComponentDTO; +import org.apache.nifi.web.api.dto.DtoFactory; +import org.apache.nifi.web.api.dto.ParameterContextDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateRequestDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateStepDTO; +import org.apache.nifi.web.api.dto.ParameterContextValidationRequestDTO; +import org.apache.nifi.web.api.dto.ParameterDTO; +import org.apache.nifi.web.api.dto.RevisionDTO; +import org.apache.nifi.web.api.entity.AffectedComponentEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultsEntity; +import org.apache.nifi.web.api.entity.Entity; +import org.apache.nifi.web.api.entity.ParameterContextEntity; +import org.apache.nifi.web.api.entity.ParameterContextUpdateRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextValidationRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextsEntity; +import org.apache.nifi.web.api.entity.ParameterEntity; +import org.apache.nifi.web.api.entity.ProcessGroupEntity; +import org.apache.nifi.web.api.request.ClientIdParameter; +import org.apache.nifi.web.api.request.LongParameter; +import org.apache.nifi.web.util.AffectedComponentUtils; +import org.apache.nifi.web.util.CancellableTimedPause; +import org.apache.nifi.web.util.ComponentLifecycle; +import org.apache.nifi.web.util.InvalidComponentAction; +import org.apache.nifi.web.util.LifecycleManagementException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.ws.rs.Consumes; +import javax.ws.rs.DELETE; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.HttpMethod; +import javax.ws.rs.POST; +import javax.ws.rs.PUT; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import java.net.URI; +import java.net.URISyntaxException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.Date; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.TimeUnit; +import java.util.function.Consumer; +import java.util.s
[GitHub] [nifi] markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#discussion_r299606309 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ParameterContextResource.java ## @@ -0,0 +1,1185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.web.api; + +import io.swagger.annotations.Api; +import io.swagger.annotations.ApiOperation; +import io.swagger.annotations.ApiParam; +import io.swagger.annotations.ApiResponse; +import io.swagger.annotations.ApiResponses; +import io.swagger.annotations.Authorization; +import org.apache.commons.lang3.StringUtils; +import org.apache.nifi.authorization.Authorizer; +import org.apache.nifi.authorization.RequestAction; +import org.apache.nifi.authorization.resource.Authorizable; +import org.apache.nifi.authorization.user.NiFiUser; +import org.apache.nifi.authorization.user.NiFiUserUtils; +import org.apache.nifi.cluster.manager.NodeResponse; +import org.apache.nifi.controller.ScheduledState; +import org.apache.nifi.controller.service.ControllerServiceState; +import org.apache.nifi.web.NiFiServiceFacade; +import org.apache.nifi.web.ResourceNotFoundException; +import org.apache.nifi.web.ResumeFlowException; +import org.apache.nifi.web.Revision; +import org.apache.nifi.web.api.concurrent.AsyncRequestManager; +import org.apache.nifi.web.api.concurrent.AsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.RequestManager; +import org.apache.nifi.web.api.concurrent.StandardAsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.StandardUpdateStep; +import org.apache.nifi.web.api.concurrent.UpdateStep; +import org.apache.nifi.web.api.dto.AffectedComponentDTO; +import org.apache.nifi.web.api.dto.DtoFactory; +import org.apache.nifi.web.api.dto.ParameterContextDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateRequestDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateStepDTO; +import org.apache.nifi.web.api.dto.ParameterContextValidationRequestDTO; +import org.apache.nifi.web.api.dto.ParameterDTO; +import org.apache.nifi.web.api.dto.RevisionDTO; +import org.apache.nifi.web.api.entity.AffectedComponentEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultsEntity; +import org.apache.nifi.web.api.entity.Entity; +import org.apache.nifi.web.api.entity.ParameterContextEntity; +import org.apache.nifi.web.api.entity.ParameterContextUpdateRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextValidationRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextsEntity; +import org.apache.nifi.web.api.entity.ParameterEntity; +import org.apache.nifi.web.api.entity.ProcessGroupEntity; +import org.apache.nifi.web.api.request.ClientIdParameter; +import org.apache.nifi.web.api.request.LongParameter; +import org.apache.nifi.web.util.AffectedComponentUtils; +import org.apache.nifi.web.util.CancellableTimedPause; +import org.apache.nifi.web.util.ComponentLifecycle; +import org.apache.nifi.web.util.InvalidComponentAction; +import org.apache.nifi.web.util.LifecycleManagementException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.ws.rs.Consumes; +import javax.ws.rs.DELETE; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.HttpMethod; +import javax.ws.rs.POST; +import javax.ws.rs.PUT; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import java.net.URI; +import java.net.URISyntaxException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.Date; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.TimeUnit; +import java.util.function.Consumer; +import java.util.s
[GitHub] [nifi] solhuebner opened a new pull request #3566: NIFI-6414 java.net.PortUnreachableException: null when using UDP
solhuebner opened a new pull request #3566: NIFI-6414
java.net.PortUnreachableException: null when using UDP
URL: https://github.com/apache/nifi/pull/3566
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Fixes java.net.PortUnreachableException: null when using
DatagramChannelSender (UDP).
The issue only occurs when you try to use the connection multiple times.
I found a similar issue here:
http://www.java-gaming.org/index.php?PHPSESSID=u7ufav5hekdirj9991jll36e81&topic=1751.msg16721#msg16721
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (NIFI-6414) java.net.PortUnreachableException: null when using DatagramChannelSender (UDP)
[
https://issues.apache.org/jira/browse/NIFI-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sol Huebner updated NIFI-6414:
--
Labels: pull-request-available (was: patch)
> java.net.PortUnreachableException: null when using DatagramChannelSender (UDP)
> --
>
> Key: NIFI-6414
> URL: https://issues.apache.org/jira/browse/NIFI-6414
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.9.2
> Environment: CentOS 7 with NiFi 1.9.2
>Reporter: Sol Huebner
>Priority: Major
> Labels: pull-request-available
>
> I get "java.net.PortUnreachableException: null" when I use PutSyslog using
> UDP. I have no issues with TCP. The issue only occurs when you try to use the
> connection multiple times.
> I found a similar issue here:
> [http://www.java-gaming.org/index.php?PHPSESSID=u7ufav5hekdirj9991jll36e81&topic=1751.msg16721#msg16721]
> So I tried to modify DatagramChannelSender.java of the nifi-processor-utils:
> if (!channel.isConnected()) {
> {color:#59afe1}channel.socket().bind(newInetSocketAddress(InetAddress.getByName(host),
> port));{color}
> channel.connect(newInetSocketAddress(InetAddress.getByName(host), port));
> }
>
> And with the added line I have no more issues and it compiled without errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFI-6414) java.net.PortUnreachableException: null when using DatagramChannelSender (UDP)
[
https://issues.apache.org/jira/browse/NIFI-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sol Huebner updated NIFI-6414:
--
Labels: patch (was: pull-request-available)
> java.net.PortUnreachableException: null when using DatagramChannelSender (UDP)
> --
>
> Key: NIFI-6414
> URL: https://issues.apache.org/jira/browse/NIFI-6414
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.9.2
> Environment: CentOS 7 with NiFi 1.9.2
>Reporter: Sol Huebner
>Priority: Major
> Labels: patch
>
> I get "java.net.PortUnreachableException: null" when I use PutSyslog using
> UDP. I have no issues with TCP. The issue only occurs when you try to use the
> connection multiple times.
> I found a similar issue here:
> [http://www.java-gaming.org/index.php?PHPSESSID=u7ufav5hekdirj9991jll36e81&topic=1751.msg16721#msg16721]
> So I tried to modify DatagramChannelSender.java of the nifi-processor-utils:
> if (!channel.isConnected()) {
> {color:#59afe1}channel.socket().bind(newInetSocketAddress(InetAddress.getByName(host),
> port));{color}
> channel.connect(newInetSocketAddress(InetAddress.getByName(host), port));
> }
>
> And with the added line I have no more issues and it compiled without errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [nifi] markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#discussion_r299597619 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ParameterContextResource.java ## @@ -0,0 +1,1185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.web.api; + +import io.swagger.annotations.Api; +import io.swagger.annotations.ApiOperation; +import io.swagger.annotations.ApiParam; +import io.swagger.annotations.ApiResponse; +import io.swagger.annotations.ApiResponses; +import io.swagger.annotations.Authorization; +import org.apache.commons.lang3.StringUtils; +import org.apache.nifi.authorization.Authorizer; +import org.apache.nifi.authorization.RequestAction; +import org.apache.nifi.authorization.resource.Authorizable; +import org.apache.nifi.authorization.user.NiFiUser; +import org.apache.nifi.authorization.user.NiFiUserUtils; +import org.apache.nifi.cluster.manager.NodeResponse; +import org.apache.nifi.controller.ScheduledState; +import org.apache.nifi.controller.service.ControllerServiceState; +import org.apache.nifi.web.NiFiServiceFacade; +import org.apache.nifi.web.ResourceNotFoundException; +import org.apache.nifi.web.ResumeFlowException; +import org.apache.nifi.web.Revision; +import org.apache.nifi.web.api.concurrent.AsyncRequestManager; +import org.apache.nifi.web.api.concurrent.AsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.RequestManager; +import org.apache.nifi.web.api.concurrent.StandardAsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.StandardUpdateStep; +import org.apache.nifi.web.api.concurrent.UpdateStep; +import org.apache.nifi.web.api.dto.AffectedComponentDTO; +import org.apache.nifi.web.api.dto.DtoFactory; +import org.apache.nifi.web.api.dto.ParameterContextDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateRequestDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateStepDTO; +import org.apache.nifi.web.api.dto.ParameterContextValidationRequestDTO; +import org.apache.nifi.web.api.dto.ParameterDTO; +import org.apache.nifi.web.api.dto.RevisionDTO; +import org.apache.nifi.web.api.entity.AffectedComponentEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultsEntity; +import org.apache.nifi.web.api.entity.Entity; +import org.apache.nifi.web.api.entity.ParameterContextEntity; +import org.apache.nifi.web.api.entity.ParameterContextUpdateRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextValidationRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextsEntity; +import org.apache.nifi.web.api.entity.ParameterEntity; +import org.apache.nifi.web.api.entity.ProcessGroupEntity; +import org.apache.nifi.web.api.request.ClientIdParameter; +import org.apache.nifi.web.api.request.LongParameter; +import org.apache.nifi.web.util.AffectedComponentUtils; +import org.apache.nifi.web.util.CancellableTimedPause; +import org.apache.nifi.web.util.ComponentLifecycle; +import org.apache.nifi.web.util.InvalidComponentAction; +import org.apache.nifi.web.util.LifecycleManagementException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.ws.rs.Consumes; +import javax.ws.rs.DELETE; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.HttpMethod; +import javax.ws.rs.POST; +import javax.ws.rs.PUT; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import java.net.URI; +import java.net.URISyntaxException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.Date; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.TimeUnit; +import java.util.function.Consumer; +import java.util.s
[GitHub] [nifi] markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#discussion_r299595518 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ParameterContextResource.java ## @@ -0,0 +1,1185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.web.api; + +import io.swagger.annotations.Api; +import io.swagger.annotations.ApiOperation; +import io.swagger.annotations.ApiParam; +import io.swagger.annotations.ApiResponse; +import io.swagger.annotations.ApiResponses; +import io.swagger.annotations.Authorization; +import org.apache.commons.lang3.StringUtils; +import org.apache.nifi.authorization.Authorizer; +import org.apache.nifi.authorization.RequestAction; +import org.apache.nifi.authorization.resource.Authorizable; +import org.apache.nifi.authorization.user.NiFiUser; +import org.apache.nifi.authorization.user.NiFiUserUtils; +import org.apache.nifi.cluster.manager.NodeResponse; +import org.apache.nifi.controller.ScheduledState; +import org.apache.nifi.controller.service.ControllerServiceState; +import org.apache.nifi.web.NiFiServiceFacade; +import org.apache.nifi.web.ResourceNotFoundException; +import org.apache.nifi.web.ResumeFlowException; +import org.apache.nifi.web.Revision; +import org.apache.nifi.web.api.concurrent.AsyncRequestManager; +import org.apache.nifi.web.api.concurrent.AsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.RequestManager; +import org.apache.nifi.web.api.concurrent.StandardAsynchronousWebRequest; +import org.apache.nifi.web.api.concurrent.StandardUpdateStep; +import org.apache.nifi.web.api.concurrent.UpdateStep; +import org.apache.nifi.web.api.dto.AffectedComponentDTO; +import org.apache.nifi.web.api.dto.DtoFactory; +import org.apache.nifi.web.api.dto.ParameterContextDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateRequestDTO; +import org.apache.nifi.web.api.dto.ParameterContextUpdateStepDTO; +import org.apache.nifi.web.api.dto.ParameterContextValidationRequestDTO; +import org.apache.nifi.web.api.dto.ParameterDTO; +import org.apache.nifi.web.api.dto.RevisionDTO; +import org.apache.nifi.web.api.entity.AffectedComponentEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultEntity; +import org.apache.nifi.web.api.entity.ComponentValidationResultsEntity; +import org.apache.nifi.web.api.entity.Entity; +import org.apache.nifi.web.api.entity.ParameterContextEntity; +import org.apache.nifi.web.api.entity.ParameterContextUpdateRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextValidationRequestEntity; +import org.apache.nifi.web.api.entity.ParameterContextsEntity; +import org.apache.nifi.web.api.entity.ParameterEntity; +import org.apache.nifi.web.api.entity.ProcessGroupEntity; +import org.apache.nifi.web.api.request.ClientIdParameter; +import org.apache.nifi.web.api.request.LongParameter; +import org.apache.nifi.web.util.AffectedComponentUtils; +import org.apache.nifi.web.util.CancellableTimedPause; +import org.apache.nifi.web.util.ComponentLifecycle; +import org.apache.nifi.web.util.InvalidComponentAction; +import org.apache.nifi.web.util.LifecycleManagementException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.ws.rs.Consumes; +import javax.ws.rs.DELETE; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.HttpMethod; +import javax.ws.rs.POST; +import javax.ws.rs.PUT; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import java.net.URI; +import java.net.URISyntaxException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.Date; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.TimeUnit; +import java.util.function.Consumer; +import java.util.s
[jira] [Created] (NIFI-6414) java.net.PortUnreachableException: null when using DatagramChannelSender (UDP)
Sol Huebner created NIFI-6414:
-
Summary: java.net.PortUnreachableException: null when using
DatagramChannelSender (UDP)
Key: NIFI-6414
URL: https://issues.apache.org/jira/browse/NIFI-6414
Project: Apache NiFi
Issue Type: Bug
Components: Extensions
Affects Versions: 1.9.2
Environment: CentOS 7 with NiFi 1.9.2
Reporter: Sol Huebner
I get "java.net.PortUnreachableException: null" when I use PutSyslog using UDP.
I have no issues with TCP. The issue only occurs when you try to use the
connection multiple times.
I found a similar issue here:
[http://www.java-gaming.org/index.php?PHPSESSID=u7ufav5hekdirj9991jll36e81&topic=1751.msg16721#msg16721]
So I tried to modify DatagramChannelSender.java of the nifi-processor-utils:
if (!channel.isConnected()) {
{color:#59afe1}channel.socket().bind(newInetSocketAddress(InetAddress.getByName(host),
port));{color}
channel.connect(newInetSocketAddress(InetAddress.getByName(host), port));
}
And with the added line I have no more issues and it compiled without errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [nifi] arenger closed pull request #3414: NIFI-5900 Add a SplitLargeJson processor
arenger closed pull request #3414: NIFI-5900 Add a SplitLargeJson processor URL: https://github.com/apache/nifi/pull/3414 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] arenger commented on issue #3414: NIFI-5900 Add a SplitLargeJson processor
arenger commented on issue #3414: NIFI-5900 Add a SplitLargeJson processor URL: https://github.com/apache/nifi/pull/3414#issuecomment-507764244 Thanks @MikeThomsen . I already have a different PR for the alternate JsonSurfer implementation: #3455 We'll see what comes of it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the
notion of Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536#discussion_r299583211
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/parameter/StandardParameterContext.java
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.parameter;
+
+import org.apache.nifi.authorization.Resource;
+import org.apache.nifi.authorization.resource.Authorizable;
+import org.apache.nifi.authorization.resource.ResourceFactory;
+import org.apache.nifi.authorization.resource.ResourceType;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.ComponentNode;
+import org.apache.nifi.controller.ProcessorNode;
+import org.apache.nifi.controller.PropertyConfiguration;
+import org.apache.nifi.controller.service.ControllerServiceNode;
+import org.apache.nifi.controller.service.ControllerServiceState;
+import org.apache.nifi.groups.ProcessGroup;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.locks.Lock;
+import java.util.concurrent.locks.ReadWriteLock;
+import java.util.concurrent.locks.ReentrantReadWriteLock;
+
+public class StandardParameterContext implements ParameterContext {
+private static final Logger logger =
LoggerFactory.getLogger(StandardParameterContext.class);
+
+private final String id;
+private final ParameterReferenceManager parameterReferenceManager;
+
+private String name;
+private long version = 0L;
+private final Map parameters = new
LinkedHashMap<>();
+private volatile String description;
+
+private final ReadWriteLock rwLock = new ReentrantReadWriteLock();
+private final Lock readLock = rwLock.readLock();
+private final Lock writeLock = rwLock.writeLock();
+
+
+public StandardParameterContext(final String id, final String name, final
ParameterReferenceManager parameterReferenceManager) {
+this.id = Objects.requireNonNull(id);
+this.name = Objects.requireNonNull(name);
+this.parameterReferenceManager = parameterReferenceManager;
+}
+
+@Override
+public String getIdentifier() {
+return id;
+}
+
+public String getName() {
+readLock.lock();
+try {
+return name;
+} finally {
+readLock.unlock();
+}
+}
+
+public void setName(final String name) {
+writeLock.lock();
+try {
+this.version++;
+this.name = name;
+} finally {
+writeLock.unlock();
+}
+}
+
+@Override
+public void setDescription(String description) {
+this.description = description;
+}
+
+@Override
+public String getDescription() {
+return description;
+}
+
+public void setParameters(final Set updatedParameters) {
+writeLock.lock();
+try {
+this.version++;
+
+verifyCanSetParameters(updatedParameters);
+
+for (final Parameter parameter : updatedParameters) {
+if (parameter.getValue() == null) {
+parameters.remove(parameter.getDescriptor());
Review comment:
That's a good call. I had thought about the lack of the sensitive property
value on the client side but hadn't come up with a smart way of handling it. I
like this approach.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mcgilman commented on issue #3553: NIFI-5856: When exporting a flow that references a Controller Service…
mcgilman commented on issue #3553: NIFI-5856: When exporting a flow that references a Controller Service… URL: https://github.com/apache/nifi/pull/3553#issuecomment-507755675 Will review... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mcgilman commented on issue #3546: NIFI-6025: Include Processor 'scheduled state' (i.e., Enabled or Disa…
mcgilman commented on issue #3546: NIFI-6025: Include Processor 'scheduled state' (i.e., Enabled or Disa… URL: https://github.com/apache/nifi/pull/3546#issuecomment-507755482 @markap14 If I only changed the scheduled state to disabled, it does not show as a local change. I expected that disabling a processor in my flow would be recognized as a local change. It was not. Once I made another change, I was able to save a new revision. Upon import of that revision that processor was correctly disabled. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
markap14 commented on a change in pull request #3536: NIFI-6380: Introduced the
notion of Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536#discussion_r299576490
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/authorization/StandardAuthorizableLookup.java
##
@@ -158,6 +159,18 @@ public Resource getResource() {
}
};
+private static final Authorizable PARAMETER_CONTEXTS_AUTHORIZABLE = new
Authorizable() {
+@Override
+public Authorizable getParentAuthorizable() {
+return null;
Review comment:
Makes sense. Will do.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mcgilman commented on issue #3546: NIFI-6025: Include Processor 'scheduled state' (i.e., Enabled or Disa…
mcgilman commented on issue #3546: NIFI-6025: Include Processor 'scheduled state' (i.e., Enabled or Disa… URL: https://github.com/apache/nifi/pull/3546#issuecomment-507744476 Will review... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mcgilman commented on issue #3564: NIFI-6412 Upgraded Spring dependencies
mcgilman commented on issue #3564: NIFI-6412 Upgraded Spring dependencies URL: https://github.com/apache/nifi/pull/3564#issuecomment-507706931 Will review... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6410) FlowFile Repository could become corrupt if IOException or OOME thrown
[ https://issues.apache.org/jira/browse/NIFI-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-6410: -- Resolution: Fixed Status: Resolved (was: Patch Available) > FlowFile Repository could become corrupt if IOException or OOME thrown > -- > > Key: NIFI-6410 > URL: https://issues.apache.org/jira/browse/NIFI-6410 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.10.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The LengthDelimitedJournal class allows only a single thread to write to the > journal at a time (protected by a synchronized block). If the Thread throws > an Exception while writing, it calls the poison() method in order to prevent > any other Thread from updating the Repo and causing corruption. However, > there is a race condition that exists, where the Thread will exit the > synchronized block and then call poison(), which could result in a second > Thread entering the synchronized block and updating the Repository, which can > corrupt the Repository. > This would only happen in conditions such as an OutOfMemoryError or if the > FlowFile Repository runs out of disk space, and even then it won't > necessarily occur. But it can, so it needs to be addressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi] asfgit closed pull request #3561: NIFI-6410: Addressed race condition in LengthDelimitedJournal in whic…
asfgit closed pull request #3561: NIFI-6410: Addressed race condition in LengthDelimitedJournal in whic… URL: https://github.com/apache/nifi/pull/3561 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mcgilman commented on issue #3561: NIFI-6410: Addressed race condition in LengthDelimitedJournal in whic…
mcgilman commented on issue #3561: NIFI-6410: Addressed race condition in LengthDelimitedJournal in whic… URL: https://github.com/apache/nifi/pull/3561#issuecomment-507697150 Thanks @markap14! This has been merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6410) FlowFile Repository could become corrupt if IOException or OOME thrown
[ https://issues.apache.org/jira/browse/NIFI-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877009#comment-16877009 ] ASF subversion and git services commented on NIFI-6410: --- Commit 40dcd1577b5738f06f480196d74c76c779ac057b in nifi's branch refs/heads/master from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=40dcd15 ] NIFI-6410: Addressed race condition in LengthDelimitedJournal in which a Thread could throw an Exception, then another Thread could update the Journal before the first thread closes it. Added unit test to replicate. This closes #3561 > FlowFile Repository could become corrupt if IOException or OOME thrown > -- > > Key: NIFI-6410 > URL: https://issues.apache.org/jira/browse/NIFI-6410 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The LengthDelimitedJournal class allows only a single thread to write to the > journal at a time (protected by a synchronized block). If the Thread throws > an Exception while writing, it calls the poison() method in order to prevent > any other Thread from updating the Repo and causing corruption. However, > there is a race condition that exists, where the Thread will exit the > synchronized block and then call poison(), which could result in a second > Thread entering the synchronized block and updating the Repository, which can > corrupt the Repository. > This would only happen in conditions such as an OutOfMemoryError or if the > FlowFile Repository runs out of disk space, and even then it won't > necessarily occur. But it can, so it needs to be addressed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5816) SFTP cannot connect due to JSch limitations
[ https://issues.apache.org/jira/browse/NIFI-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876986#comment-16876986 ] Matt Hagenbuch commented on NIFI-5816: -- The JSch limitation also applies to the NiFi Registry GitFlowPersistenceProvider. Basically, modern OpenSSH keys cannot be used to authenticate with Git servers using this library as discussed here [https://www.eclipse.org/forums/index.php/t/1095599/] > SFTP cannot connect due to JSch limitations > --- > > Key: NIFI-5816 > URL: https://issues.apache.org/jira/browse/NIFI-5816 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.8.0 >Reporter: Laurenceau Julien >Priority: Minor > > Hi, > The JSch library used for SFTP does not support HostKeyAlgorithms=ed25519 > whereas it is the current standard. This make SFTP / SSH unusable when > dealing with recent openssh config. > On dbeaver project they switched to sshj. > [https://github.com/dbeaver/dbeaver/issues/2202] > [https://community.hortonworks.com/answers/226377/view.html] > > https://stackoverflow.com/questions/2003419/com-jcraft-jsch-jschexception-unknownhostkey > One more argument against JSch is that it does not support rsa key length > other than default (2048). > ssh-keygen -o -t rsa -b 4096 -f id_rsa -> does not work with nifi > ssh-keygen -t rsa -f id_rsa -> works with nifi > Thanks and regards > JL > PS : sorry but I do not know nifi deep enough to fill all fields. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (NIFIREG-291) adjust docker folder naming convention to have similar layout as NiFi
[ https://issues.apache.org/jira/browse/NIFIREG-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endre Kovacs reassigned NIFIREG-291: Assignee: Endre Kovacs > adjust docker folder naming convention to have similar layout as NiFi > - > > Key: NIFIREG-291 > URL: https://issues.apache.org/jira/browse/NIFIREG-291 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.4.0 >Reporter: Endre Kovacs >Assignee: Endre Kovacs >Priority: Trivial > > Currently NiFi's docker image > ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) > installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* > folder. > > NiFi registry's docker image > [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] > does it differently: it always creates *a version specific* folder (and sets > that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. > > For NiFi Registry, I'd like to propose, to follow the same convention, in > order to make it easier for downstream use-cases to find NiFi Registry's home > folder / directory layout -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi] mcgilman commented on issue #3561: NIFI-6410: Addressed race condition in LengthDelimitedJournal in whic…
mcgilman commented on issue #3561: NIFI-6410: Addressed race condition in LengthDelimitedJournal in whic… URL: https://github.com/apache/nifi/pull/3561#issuecomment-507670168 Will review... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFIREG-291) adjust docker folder naming convention to have similar layout as NiFi
[ https://issues.apache.org/jira/browse/NIFIREG-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endre Kovacs updated NIFIREG-291: - Description: Currently NiFi's docker image ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* folder. NiFi registry's docker image [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] does it differently: it always creates *a version specific* folder (and sets that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. For NiFi Registry, I'd like to propose, to follow the same convention, in order to make it easier for downstream use-cases to find NiFi Registry's home folder / directory layout was: Currently NiFi's docker image ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* folder. NiFi registry's docker image [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] does it differently: it always creates *a version specific* folder (and sets that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. For NiFi Registry, I'd like to propose, to follow the same convention, in order to make it easier for downstream use-cases to find NiFi Registry home / folder / directory layout > adjust docker folder naming convention to have similar layout as NiFi > - > > Key: NIFIREG-291 > URL: https://issues.apache.org/jira/browse/NIFIREG-291 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.4.0 >Reporter: Endre Kovacs >Priority: Trivial > > Currently NiFi's docker image > ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) > installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* > folder. > > NiFi registry's docker image > [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] > does it differently: it always creates *a version specific* folder (and sets > that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. > > For NiFi Registry, I'd like to propose, to follow the same convention, in > order to make it easier for downstream use-cases to find NiFi Registry's home > folder / directory layout -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFIREG-291) adjust docker folder naming convention to have similar layout as NiFi
[ https://issues.apache.org/jira/browse/NIFIREG-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endre Kovacs updated NIFIREG-291: - Description: Currently NiFi's docker image ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* folder. NiFi registry's docker image [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] does it differently: it always creates *a version specific* folder (and sets that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. For NiFi Registry, I'd like to propose, to follow the same convention, in order to make it easier for downstream use-cases to find NiFi Registry folders was: Currently NiFi's docker image ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* folder. NiFi registry's docker image [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] does it differently: it always creates *a version specific* folder (and sets that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. For NiFi Registry, I'd like to propose, to follow the same convention, in order to make it easier for downstream use-cases to find NiFi Regisytu > adjust docker folder naming convention to have similar layout as NiFi > - > > Key: NIFIREG-291 > URL: https://issues.apache.org/jira/browse/NIFIREG-291 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.4.0 >Reporter: Endre Kovacs >Priority: Trivial > > Currently NiFi's docker image > ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) > installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* > folder. > > NiFi registry's docker image > [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] > does it differently: it always creates *a version specific* folder (and sets > that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. > > For NiFi Registry, I'd like to propose, to follow the same convention, in > order to make it easier for downstream use-cases to find NiFi Registry folders -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFIREG-291) adjust docker folder naming convention to have similar layout as NiFi
[ https://issues.apache.org/jira/browse/NIFIREG-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endre Kovacs updated NIFIREG-291: - Description: Currently NiFi's docker image ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* folder. NiFi registry's docker image [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] does it differently: it always creates *a version specific* folder (and sets that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. For NiFi Registry, I'd like to propose, to follow the same convention, in order to make it easier for downstream use-cases to find NiFi Registry home / folder / directory layout was: Currently NiFi's docker image ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* folder. NiFi registry's docker image [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] does it differently: it always creates *a version specific* folder (and sets that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. For NiFi Registry, I'd like to propose, to follow the same convention, in order to make it easier for downstream use-cases to find NiFi Registry folders > adjust docker folder naming convention to have similar layout as NiFi > - > > Key: NIFIREG-291 > URL: https://issues.apache.org/jira/browse/NIFIREG-291 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.4.0 >Reporter: Endre Kovacs >Priority: Trivial > > Currently NiFi's docker image > ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) > installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* > folder. > > NiFi registry's docker image > [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] > does it differently: it always creates *a version specific* folder (and sets > that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. > > For NiFi Registry, I'd like to propose, to follow the same convention, in > order to make it easier for downstream use-cases to find NiFi Registry home / > folder / directory layout -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFIREG-291) adjust docker folder naming convention to have similar layout as NiFi
[ https://issues.apache.org/jira/browse/NIFIREG-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endre Kovacs updated NIFIREG-291: - Description: Currently NiFi's docker image ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* folder. NiFi registry's docker image [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29|https://github.com/ekovacs/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] does it differently: it always creates *a version specific* folder (and sets that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. For NiFi Registry, I'd like to propose, to follow the same convention, in order to make it easier for downstream use-cases to find NiFi Regisytu was: Currently NiFi's docker image ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* folder. NiFi registry's docker image [https://github.com/ekovacs/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] does it differently: it always creates *a version specific* folder (and sets that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. For NiFi Registry, I'd like to propose, to follow the same convention, in order to make it easier for downstream use-cases to find NiFi Regisytu > adjust docker folder naming convention to have similar layout as NiFi > - > > Key: NIFIREG-291 > URL: https://issues.apache.org/jira/browse/NIFIREG-291 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.4.0 >Reporter: Endre Kovacs >Priority: Trivial > > Currently NiFi's docker image > ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) > installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* > folder. > > NiFi registry's docker image > [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29|https://github.com/ekovacs/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] > does it differently: it always creates *a version specific* folder (and sets > that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. > > For NiFi Registry, I'd like to propose, to follow the same convention, in > order to make it easier for downstream use-cases to find NiFi Regisytu -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFIREG-291) adjust docker folder naming convention to have similar layout as NiFi
[ https://issues.apache.org/jira/browse/NIFIREG-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endre Kovacs updated NIFIREG-291: - Description: Currently NiFi's docker image ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* folder. NiFi registry's docker image [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] does it differently: it always creates *a version specific* folder (and sets that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. For NiFi Registry, I'd like to propose, to follow the same convention, in order to make it easier for downstream use-cases to find NiFi Regisytu was: Currently NiFi's docker image ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* folder. NiFi registry's docker image [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29|https://github.com/ekovacs/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] does it differently: it always creates *a version specific* folder (and sets that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. For NiFi Registry, I'd like to propose, to follow the same convention, in order to make it easier for downstream use-cases to find NiFi Regisytu > adjust docker folder naming convention to have similar layout as NiFi > - > > Key: NIFIREG-291 > URL: https://issues.apache.org/jira/browse/NIFIREG-291 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.4.0 >Reporter: Endre Kovacs >Priority: Trivial > > Currently NiFi's docker image > ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) > installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* > folder. > > NiFi registry's docker image > [https://github.com/apache/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] > does it differently: it always creates *a version specific* folder (and sets > that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. > > For NiFi Registry, I'd like to propose, to follow the same convention, in > order to make it easier for downstream use-cases to find NiFi Regisytu -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFIREG-291) adjust docker folder naming convention to have similar layout as NiFi
Endre Kovacs created NIFIREG-291: Summary: adjust docker folder naming convention to have similar layout as NiFi Key: NIFIREG-291 URL: https://issues.apache.org/jira/browse/NIFIREG-291 Project: NiFi Registry Issue Type: Improvement Affects Versions: 0.4.0 Reporter: Endre Kovacs Currently NiFi's docker image ([https://github.com/apache/nifi/blob/41663929a4727592972e6be04b3c516a752e760e/nifi-docker/dockerhub/Dockerfile#L32]) installs NiFi ( and sets that to $NIFI_HOME) into a *version agnostic* folder. NiFi registry's docker image [https://github.com/ekovacs/nifi-registry/blob/f3b82a7b8dab3737d9b9ca1dc8028d4e9d7108fa/nifi-registry-core/nifi-registry-docker/dockerhub/Dockerfile#L29] does it differently: it always creates *a version specific* folder (and sets that to $NIFI_REGISTRY_HOME) for any new NiFi Registry releases. For NiFi Registry, I'd like to propose, to follow the same convention, in order to make it easier for downstream use-cases to find NiFi Regisytu -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-6343) nifi-ignite-processors fails to build because /tmp/ignite was owned by another
[ https://issues.apache.org/jira/browse/NIFI-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Sargrad updated NIFI-6343: Attachment: image-2019-07-02-07-30-53-042.png > nifi-ignite-processors fails to build because /tmp/ignite was owned by another > -- > > Key: NIFI-6343 > URL: https://issues.apache.org/jira/browse/NIFI-6343 > Project: Apache NiFi > Issue Type: Bug > Environment: centos 7 > java-1.8.0-openjdk-1.8.0.191.b12-1.el7_6.x86_64 >Reporter: David Sargrad >Priority: Major > Attachments: image-2019-06-03-11-57-12-907.png, > image-2019-06-03-11-58-15-523.png, image-2019-06-03-12-00-44-650.png, > image-2019-06-03-12-01-35-030.png, image-2019-06-03-12-02-59-709.png, > image-2019-06-03-12-04-06-699.png, image-2019-06-03-12-47-07-720.png, > image-2019-07-01-11-36-52-582.png, image-2019-07-01-12-18-36-113.png, > image-2019-07-02-07-30-53-042.png > > > The nifi build fails again and again on nifi-ignite-processors. It seems to > build everything else successfully. > > > !image-2019-06-03-12-04-06-699.png! > > > > It turns out that the test case attempts to write to /tmp/ignite. > > !image-2019-06-03-12-02-59-709.png! > > > > However if another user on the same computer ran a past build of nifi, then > that /tmp/ignite directory is not writable (nor is it cleaned up). It would > seem that such test cases should not write in a /tmp directory that is shared. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-6343) nifi-ignite-processors fails to build because /tmp/ignite was owned by another
[ https://issues.apache.org/jira/browse/NIFI-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876883#comment-16876883 ] David Sargrad commented on NIFI-6343: - Builds fine when I turn off unit tests. Because of my commitment to support NIFI, I'm inclined to try again, and write issues for the failed unit tests. I will also try to isolate, and report, as best I can since I'm keen to better understand the unit test framework. !image-2019-07-02-07-30-53-042.png! > nifi-ignite-processors fails to build because /tmp/ignite was owned by another > -- > > Key: NIFI-6343 > URL: https://issues.apache.org/jira/browse/NIFI-6343 > Project: Apache NiFi > Issue Type: Bug > Environment: centos 7 > java-1.8.0-openjdk-1.8.0.191.b12-1.el7_6.x86_64 >Reporter: David Sargrad >Priority: Major > Attachments: image-2019-06-03-11-57-12-907.png, > image-2019-06-03-11-58-15-523.png, image-2019-06-03-12-00-44-650.png, > image-2019-06-03-12-01-35-030.png, image-2019-06-03-12-02-59-709.png, > image-2019-06-03-12-04-06-699.png, image-2019-06-03-12-47-07-720.png, > image-2019-07-01-11-36-52-582.png, image-2019-07-01-12-18-36-113.png, > image-2019-07-02-07-30-53-042.png > > > The nifi build fails again and again on nifi-ignite-processors. It seems to > build everything else successfully. > > > !image-2019-06-03-12-04-06-699.png! > > > > It turns out that the test case attempts to write to /tmp/ignite. > > !image-2019-06-03-12-02-59-709.png! > > > > However if another user on the same computer ran a past build of nifi, then > that /tmp/ignite directory is not writable (nor is it cleaned up). It would > seem that such test cases should not write in a /tmp directory that is shared. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [nifi] MikeThomsen commented on issue #3547: [WIP] NIFI-5254 Update Groovy dependecies to version 2.5.4
MikeThomsen commented on issue #3547: [WIP] NIFI-5254 Update Groovy dependecies to version 2.5.4 URL: https://github.com/apache/nifi/pull/3547#issuecomment-507624437 Go for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #601: MINIFICPP-937: resolve state file issues and rollover issues. Add tes…
arpadboda closed pull request #601: MINIFICPP-937: resolve state file issues and rollover issues. Add tes… URL: https://github.com/apache/nifi-minifi-cpp/pull/601 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] arpadboda edited a comment on issue #601: MINIFICPP-937: resolve state file issues and rollover issues. Add tes…
arpadboda edited a comment on issue #601: MINIFICPP-937: resolve state file issues and rollover issues. Add tes… URL: https://github.com/apache/nifi-minifi-cpp/pull/601#issuecomment-507579356 Merging this. In case any issue is found, it's going to be fixed in scope of #596 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] arpadboda commented on issue #601: MINIFICPP-937: resolve state file issues and rollover issues. Add tes…
arpadboda commented on issue #601: MINIFICPP-937: resolve state file issues and rollover issues. Add tes… URL: https://github.com/apache/nifi-minifi-cpp/pull/601#issuecomment-507579356 Merging this. In case any issues are found, it's going to be fixed in scope of #596 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
