[GitHub] [nifi] MikeThomsen commented on issue #3845: NIFI-6809 Make use of ASF shortened URL to point to community SLack i…
MikeThomsen commented on issue #3845: NIFI-6809 Make use of ASF shortened URL to point to community SLack i… URL: https://github.com/apache/nifi/pull/3845#issuecomment-546278904 @apiri looks like @markap14 already merged this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6805) When ControllerServiceNode is logged, it no longer includes the UUID of the Controller Service
[ https://issues.apache.org/jira/browse/NIFI-6805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen updated NIFI-6805: --- Fix Version/s: (was: 1.11.0) 1.10.0 > When ControllerServiceNode is logged, it no longer includes the UUID of the > Controller Service > -- > > Key: NIFI-6805 > URL: https://issues.apache.org/jira/browse/NIFI-6805 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.10.0 >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Critical > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The `toString()` method of StandardControllerServiceNode was changed in > NIFI-6201. The new `toString()` method no longer contains the CS's UUID. This > means that when log messages are generated about a Controller Service, > there's no easy way to track it back to the Controller Service that is > affected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-6805) When ControllerServiceNode is logged, it no longer includes the UUID of the Controller Service
[ https://issues.apache.org/jira/browse/NIFI-6805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen updated NIFI-6805: --- Resolution: Fixed Status: Resolved (was: Patch Available) > When ControllerServiceNode is logged, it no longer includes the UUID of the > Controller Service > -- > > Key: NIFI-6805 > URL: https://issues.apache.org/jira/browse/NIFI-6805 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.10.0 >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Critical > Fix For: 1.11.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The `toString()` method of StandardControllerServiceNode was changed in > NIFI-6201. The new `toString()` method no longer contains the CS's UUID. This > means that when log messages are generated about a Controller Service, > there's no easy way to track it back to the Controller Service that is > affected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #3827: NIFI-6793 Fix NumberFormatException at CaptureChangeMySQL
asfgit closed pull request #3827: NIFI-6793 Fix NumberFormatException at CaptureChangeMySQL URL: https://github.com/apache/nifi/pull/3827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFI-6793) CaptureChangeMySQL throws NumberFormatException when sequence id exceeds maximum Integer
[
https://issues.apache.org/jira/browse/NIFI-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Thomsen resolved NIFI-6793.
Fix Version/s: 1.10.0
Resolution: Fixed
> CaptureChangeMySQL throws NumberFormatException when sequence id exceeds
> maximum Integer
>
>
> Key: NIFI-6793
> URL: https://issues.apache.org/jira/browse/NIFI-6793
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>Priority: Major
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> NumberFormatException can be thrown because the internal sequence id is
> parsed as an integer where it should be a long.
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java#L492
> {code}
> 2019-10-14 04:45:54,727 WARN [Timer-Driven Process Thread-15]
> o.a.n.controller.tasks.ConnectableTask Administratively Yielding
> CaptureChangeMySQL[id=719232e6-2e6e-1d73-82b8-4f59a42c5e52] due to uncaught
> Exception: java.lang.NumberFormatException: For input string: "2291535530"
> java.lang.NumberFormatException: For input string: "2291535530"
> at
> java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
> at java.lang.Integer.parseInt(Integer.java:583)
> at java.lang.Integer.parseInt(Integer.java:615)
> at
> org.apache.nifi.cdc.mysql.processors.CaptureChangeMySQL.setup(CaptureChangeMySQL.java:492)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-6793) CaptureChangeMySQL throws NumberFormatException when sequence id exceeds maximum Integer
[
https://issues.apache.org/jira/browse/NIFI-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959617#comment-16959617
]
ASF subversion and git services commented on NIFI-6793:
---
Commit 87838e6c31ed8b104f79b7c7930b110e31bf7de7 in nifi's branch
refs/heads/master from Koji Kawamura
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=87838e6 ]
NIFI-6793 Fix NumberFormatException at CaptureChangeMySQL
This closes #3827
Signed-off-by: Mike Thomsen
> CaptureChangeMySQL throws NumberFormatException when sequence id exceeds
> maximum Integer
>
>
> Key: NIFI-6793
> URL: https://issues.apache.org/jira/browse/NIFI-6793
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> NumberFormatException can be thrown because the internal sequence id is
> parsed as an integer where it should be a long.
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java#L492
> {code}
> 2019-10-14 04:45:54,727 WARN [Timer-Driven Process Thread-15]
> o.a.n.controller.tasks.ConnectableTask Administratively Yielding
> CaptureChangeMySQL[id=719232e6-2e6e-1d73-82b8-4f59a42c5e52] due to uncaught
> Exception: java.lang.NumberFormatException: For input string: "2291535530"
> java.lang.NumberFormatException: For input string: "2291535530"
> at
> java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
> at java.lang.Integer.parseInt(Integer.java:583)
> at java.lang.Integer.parseInt(Integer.java:615)
> at
> org.apache.nifi.cdc.mysql.processors.CaptureChangeMySQL.setup(CaptureChangeMySQL.java:492)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MINIFICPP-1048) Add PublishKafka docker tests
[ https://issues.apache.org/jira/browse/MINIFICPP-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nghia Le resolved MINIFICPP-1048. - Resolution: Fixed > Add PublishKafka docker tests > - > > Key: MINIFICPP-1048 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1048 > Project: Apache NiFi MiNiFi C++ > Issue Type: Task >Reporter: Dániel Bakai >Assignee: Nghia Le >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > We should test: > - how the processor works with running, not running and flapping kafka > servers > - all processor properties -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MINIFICPP-976) Add Kafka broker to docker verify
[ https://issues.apache.org/jira/browse/MINIFICPP-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nghia Le resolved MINIFICPP-976. Resolution: Fixed > Add Kafka broker to docker verify > -- > > Key: MINIFICPP-976 > URL: https://issues.apache.org/jira/browse/MINIFICPP-976 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marc Parisi >Assignee: Nghia Le >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Add docker kafka tests -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] apiri commented on issue #3845: NIFI-6809 Make use of ASF shortened URL to point to community SLack i…
apiri commented on issue #3845: NIFI-6809 Make use of ASF shortened URL to point to community SLack i… URL: https://github.com/apache/nifi/pull/3845#issuecomment-546333012 @MikeThomsen Not seeing it in the commit history. Am I overlooking something? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFIREG-342) streamline nifi-registry docker projects to it's NiFi counterpart
Endre Kovacs created NIFIREG-342:
Summary: streamline nifi-registry docker projects to it's NiFi
counterpart
Key: NIFIREG-342
URL: https://issues.apache.org/jira/browse/NIFIREG-342
Project: NiFi Registry
Issue Type: Task
Affects Versions: 1.0.0
Reporter: Endre Kovacs
Assignee: Endre Kovacs
currently i see a few differences between the layout of NiFi vs.
nifi-registry's docker projects.
# {code}nifi-registry-docker{code} is a child project of
{code}nifi-registry/nifi-registry-core{code} it's NiFi counterpart lives in the
project root. Having it in the project-root is beneficial as it allows us to
defer its execution order after the assembly, so we could leverage the build
artifacts for docker build. Such docker build can be initiated with the
{code}-P docker{code} maven build profile, provided by NIFIREG-252
# currently nifi-registry/nifi-registry-core/nifi-registry-docker/dockerhub is
not a maven project (no pom.xml in its folder) this is another difference
between the NiFi dockerhub and the NiFi Registry counter part.
cc.: [~kdoran]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #3845: NIFI-6809 Make use of ASF shortened URL to point to community SLack i…
asfgit closed pull request #3845: NIFI-6809 Make use of ASF shortened URL to point to community SLack i… URL: https://github.com/apache/nifi/pull/3845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] ekovacs commented on issue #245: NIFIREG-252: adding mavendocker build profile
ekovacs commented on issue #245: NIFIREG-252: adding mavendocker build profile URL: https://github.com/apache/nifi-registry/pull/245#issuecomment-546347391 > +1 for relocating it and making it a maven project, as well as for doing that as a separate jira/pr. I will re-review this PR as-is. just created a follow up JIRA about it: https://issues.apache.org/jira/browse/NIFIREG-342 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] MikeThomsen commented on issue #3845: NIFI-6809 Make use of ASF shortened URL to point to community SLack i…
MikeThomsen commented on issue #3845: NIFI-6809 Make use of ASF shortened URL to point to community SLack i… URL: https://github.com/apache/nifi/pull/3845#issuecomment-546347445 NM. It was an early morning screw up on my part. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6809) Update README to make use of ASF url for community slack channel
[ https://issues.apache.org/jira/browse/NIFI-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959753#comment-16959753 ] ASF subversion and git services commented on NIFI-6809: --- Commit 20f70357a364c103f4d669c48bc8920550993467 in nifi's branch refs/heads/master from Aldrin Piri [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=20f7035 ] NIFI-6809 Make use of ASF shortened URL to point to community SLack invite link. This closes #3845 Signed-off-by: Mike Thomsen > Update README to make use of ASF url for community slack channel > > > Key: NIFI-6809 > URL: https://issues.apache.org/jira/browse/NIFI-6809 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Trivial > Time Spent: 0.5h > Remaining Estimate: 0h > > We can use the shortened URL https://s.apache.org/nifi-community-slack to > point to the community slack invite link should it need to be refreshed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6687) Update Ranger dependencies
[ https://issues.apache.org/jira/browse/NIFI-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959765#comment-16959765 ] ASF subversion and git services commented on NIFI-6687: --- Commit 2cef010b06ee0e3db82ea0272733e426c8e5d884 in nifi's branch refs/heads/master from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2cef010 ] NIFI-6687: - Using correct NiFi Ranger Service name in unit tests. This closes #3842. Signed-off-by: Bryan Bende > Update Ranger dependencies > -- > > Key: NIFI-6687 > URL: https://issues.apache.org/jira/browse/NIFI-6687 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 1.11.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Upgrade the Ranger authorizer to leverage version 2.x. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #3842: NIFI-6687: Fixing Ranger unit tests
asfgit closed pull request #3842: NIFI-6687: Fixing Ranger unit tests URL: https://github.com/apache/nifi/pull/3842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bbende commented on issue #3842: NIFI-6687: Fixing Ranger unit tests
bbende commented on issue #3842: NIFI-6687: Fixing Ranger unit tests URL: https://github.com/apache/nifi/pull/3842#issuecomment-546355362 Looks good, merged This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFI-6687) Update Ranger dependencies
[ https://issues.apache.org/jira/browse/NIFI-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFI-6687. --- Resolution: Fixed > Update Ranger dependencies > -- > > Key: NIFI-6687 > URL: https://issues.apache.org/jira/browse/NIFI-6687 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 1.11.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Upgrade the Ranger authorizer to leverage version 2.x. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-registry] bbende merged pull request #246: NIFIREG-341 Make use of ASF shortened URL to point to community Slack…
bbende merged pull request #246: NIFIREG-341 Make use of ASF shortened URL to point to community Slack… URL: https://github.com/apache/nifi-registry/pull/246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFIREG-341) Update README to make use of ASF url for community slack channel
[ https://issues.apache.org/jira/browse/NIFIREG-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-341. - Fix Version/s: 1.0.0 Resolution: Fixed > Update README to make use of ASF url for community slack channel > > > Key: NIFIREG-341 > URL: https://issues.apache.org/jira/browse/NIFIREG-341 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Aldrin Piri >Assignee: Aldrin Piri >Priority: Trivial > Fix For: 1.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > We can use the shortened URL https://s.apache.org/nifi-community-slack to > point to the community slack invite link should it need to be refreshed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] ivan1221 edited a comment on issue #3837: NIFI-6800: Fix hashmap counter overwritten in highThroughputSession
ivan1221 edited a comment on issue #3837: NIFI-6800: Fix hashmap counter overwritten in highThroughputSession URL: https://github.com/apache/nifi/pull/3837#issuecomment-545435939 Fix this issue: [https://issues.apache.org/jira/browse/NIFI-6800](https://issues.apache.org/jira/browse/NIFI-6800) This video shows the error comparing a normal session with a high performance: [NIFI - BUG - StandardProcessSession error - hashmap counter overwritten in highThroughputSession](https://youtu.be/DzwEQWmxNKc) This video shows a comparison between version 1.9.2 and the version that I compiled with the fix myself: [NIFI-6800 - FIX -hashmap counter overwritten in highThroughputSession](https://youtu.be/zlAQ69WX0tw) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] rfellows commented on issue #3846: NIFI-6811: Allow enterGroup to complete prior to loading CS table
rfellows commented on issue #3846: NIFI-6811: Allow enterGroup to complete prior to loading CS table URL: https://github.com/apache/nifi/pull/3846#issuecomment-546360639 Reviewing... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bbende commented on issue #3836: NIFI-6798: When checking that referenced Controller Services are vali…
bbende commented on issue #3836: NIFI-6798: When checking that referenced Controller Services are vali… URL: https://github.com/apache/nifi/pull/3836#issuecomment-546362262 Looks good, going to merge This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] asfgit closed pull request #3836: NIFI-6798: When checking that referenced Controller Services are vali…
asfgit closed pull request #3836: NIFI-6798: When checking that referenced Controller Services are vali… URL: https://github.com/apache/nifi/pull/3836 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6798) Validate Controller Services referenced via dynamic properties
[ https://issues.apache.org/jira/browse/NIFI-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-6798: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Validate Controller Services referenced via dynamic properties > -- > > Key: NIFI-6798 > URL: https://issues.apache.org/jira/browse/NIFI-6798 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Peter Turcsanyi >Assignee: Mark Payne >Priority: Major > Fix For: 1.11.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > If a Controller Service referenced by another component is disabled, then the > referencing component should be in invalid state. > It works fine for statically referenced Controller Services (configured via > static properties of the processor / another service), but it seems the > framework does not check it for dynamically configured services. > The validator method can be found here: > [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractComponentNode.java#L679] > Components that have Controller Service references configured via dynamic > properties: > * DBCPConnectionPoolLookup > * AzureStorageCredentialsControllerServiceLookup > * (there might be others, needs to be checked) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6798) Validate Controller Services referenced via dynamic properties
[ https://issues.apache.org/jira/browse/NIFI-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959775#comment-16959775 ] ASF subversion and git services commented on NIFI-6798: --- Commit 81fc2768c9d6cb61be10ba5adc805517c29816c7 in nifi's branch refs/heads/master from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=81fc276 ] NIFI-6798: When checking that referenced Controller Services are valid, use ValidationContext.getProperties() rather than ComponentNode.getSupportedPropertyDescriptors() because the latter does not include dynamic properties This closes #3836. Signed-off-by: Bryan Bende > Validate Controller Services referenced via dynamic properties > -- > > Key: NIFI-6798 > URL: https://issues.apache.org/jira/browse/NIFI-6798 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Peter Turcsanyi >Assignee: Mark Payne >Priority: Major > Fix For: 1.11.0 > > Time Spent: 20m > Remaining Estimate: 0h > > If a Controller Service referenced by another component is disabled, then the > referencing component should be in invalid state. > It works fine for statically referenced Controller Services (configured via > static properties of the processor / another service), but it seems the > framework does not check it for dynamically configured services. > The validator method can be found here: > [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractComponentNode.java#L679] > Components that have Controller Service references configured via dynamic > properties: > * DBCPConnectionPoolLookup > * AzureStorageCredentialsControllerServiceLookup > * (there might be others, needs to be checked) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-registry] asfgit closed pull request #234: [NIFIREG-324] add hammerJS to testbed
asfgit closed pull request #234: [NIFIREG-324] add hammerJS to testbed URL: https://github.com/apache/nifi-registry/pull/234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFIREG-324) UI - include hammerJS with unit tests
[ https://issues.apache.org/jira/browse/NIFIREG-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-324. - Fix Version/s: 1.0.0 Resolution: Fixed Looks good, merged > UI - include hammerJS with unit tests > - > > Key: NIFIREG-324 > URL: https://issues.apache.org/jira/browse/NIFIREG-324 > Project: NiFi Registry > Issue Type: Bug >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Labels: ui > Fix For: 1.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > We see > WARN LOG: 'The "longpress" event cannot be bound because Hammer.JS is not > loaded and no custom loader has been specified.' > in the logs when running JS unit tests. Including hammerJS will clean up > these warnings. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #3841: NIFI-6807: When a Controller Service's state is transitioned to ENABL…
asfgit closed pull request #3841: NIFI-6807: When a Controller Service's state is transitioned to ENABL… URL: https://github.com/apache/nifi/pull/3841 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mcgilman commented on issue #3841: NIFI-6807: When a Controller Service's state is transitioned to ENABL…
mcgilman commented on issue #3841: NIFI-6807: When a Controller Service's state is transitioned to ENABL… URL: https://github.com/apache/nifi/pull/3841#issuecomment-546404420 Thanks @markap14! This has been merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6807) When enabling Controller Service and referencing components, some references may fail to enable
[ https://issues.apache.org/jira/browse/NIFI-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-6807: -- Resolution: Fixed Status: Resolved (was: Patch Available) > When enabling Controller Service and referencing components, some references > may fail to enable > --- > > Key: NIFI-6807 > URL: https://issues.apache.org/jira/browse/NIFI-6807 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Critical > Fix For: 1.10.0 > > Time Spent: 40m > Remaining Estimate: 0h > > When a user chooses to enable a Controller Service and its referencing > components, there exists a situation where we can sometimes see the > referencing Controller Service fail to enable. This is particularly > problematic in a clustered environment, as it can result in nodes being > disconnected from the cluster because the service didn't enable. > To replicate, create a JSONRecordSetWriter service and an AvroSchemaRegistry > service. Configure the record writer to depend on the schema registry (and > all other necessary configuration to make the services valid). Now, enable > AvroSchemaRegistry and all referencing components. The JSONRecordSetWriter > will sometimes fail to enable because it is not yet valid. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6807) When enabling Controller Service and referencing components, some references may fail to enable
[ https://issues.apache.org/jira/browse/NIFI-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959865#comment-16959865 ] ASF subversion and git services commented on NIFI-6807: --- Commit 3f270f184c22f9686587bcedff396c434bd8f7d5 in nifi's branch refs/heads/master from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3f270f1 ] NIFI-6807: When a Controller Service's state is transitioned to ENABLING, complete the Future successfully, even if the Controller Service is not valid. The Controller Service will remain in the ENABLING state until it is made valid, at which point it will ENABLE (unless explicitly disabled first). This allows us to Enable a Controller Service and its referencing components, even if the referencing component is still invalid due to it not yet recognizing the the referenced service has been enabled. This closes #3841 > When enabling Controller Service and referencing components, some references > may fail to enable > --- > > Key: NIFI-6807 > URL: https://issues.apache.org/jira/browse/NIFI-6807 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Critical > Fix For: 1.11.0 > > Time Spent: 20m > Remaining Estimate: 0h > > When a user chooses to enable a Controller Service and its referencing > components, there exists a situation where we can sometimes see the > referencing Controller Service fail to enable. This is particularly > problematic in a clustered environment, as it can result in nodes being > disconnected from the cluster because the service didn't enable. > To replicate, create a JSONRecordSetWriter service and an AvroSchemaRegistry > service. Configure the record writer to depend on the schema registry (and > all other necessary configuration to make the services valid). Now, enable > AvroSchemaRegistry and all referencing components. The JSONRecordSetWriter > will sometimes fail to enable because it is not yet valid. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-6807) When enabling Controller Service and referencing components, some references may fail to enable
[ https://issues.apache.org/jira/browse/NIFI-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-6807: -- Fix Version/s: (was: 1.11.0) 1.10.0 > When enabling Controller Service and referencing components, some references > may fail to enable > --- > > Key: NIFI-6807 > URL: https://issues.apache.org/jira/browse/NIFI-6807 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Critical > Fix For: 1.10.0 > > Time Spent: 40m > Remaining Estimate: 0h > > When a user chooses to enable a Controller Service and its referencing > components, there exists a situation where we can sometimes see the > referencing Controller Service fail to enable. This is particularly > problematic in a clustered environment, as it can result in nodes being > disconnected from the cluster because the service didn't enable. > To replicate, create a JSONRecordSetWriter service and an AvroSchemaRegistry > service. Configure the record writer to depend on the schema registry (and > all other necessary configuration to make the services valid). Now, enable > AvroSchemaRegistry and all referencing components. The JSONRecordSetWriter > will sometimes fail to enable because it is not yet valid. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #3846: NIFI-6811: Allow enterGroup to complete prior to loading CS table
asfgit closed pull request #3846: NIFI-6811: Allow enterGroup to complete prior to loading CS table URL: https://github.com/apache/nifi/pull/3846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFI-6811) UI - Go to controller service issue
[ https://issues.apache.org/jira/browse/NIFI-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows resolved NIFI-6811. --- Resolution: Fixed > UI - Go to controller service issue > --- > > Key: NIFI-6811 > URL: https://issues.apache.org/jira/browse/NIFI-6811 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > Time Spent: 0.5h > Remaining Estimate: 0h > > When going to a controller service in an ancestor group from the controller > service table in a descendant group, we need to wait for enterGroup to > complete before attempting to load the table. This is because the table will > ask for the parameter context which is loaded conditionally based on the > currently loaded group. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6811) UI - Go to controller service issue
[ https://issues.apache.org/jira/browse/NIFI-6811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959890#comment-16959890 ] ASF subversion and git services commented on NIFI-6811: --- Commit 9364f7d2e80e7f3695f175d2d3c5d23883ad2ce4 in nifi's branch refs/heads/master from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=9364f7d ] NIFI-6811: - Allowing enterGroup to complete prior to loading the controller service table. This closes #3846. > UI - Go to controller service issue > --- > > Key: NIFI-6811 > URL: https://issues.apache.org/jira/browse/NIFI-6811 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Critical > Time Spent: 20m > Remaining Estimate: 0h > > When going to a controller service in an ancestor group from the controller > service table in a descendant group, we need to wait for enterGroup to > complete before attempting to load the table. This is because the table will > ask for the parameter context which is loaded conditionally based on the > currently loaded group. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NIFI-6812) Add LICENSE/NOTICE files to nifi-azure-services-api-nar
Peter Turcsanyi created NIFI-6812: - Summary: Add LICENSE/NOTICE files to nifi-azure-services-api-nar Key: NIFI-6812 URL: https://issues.apache.org/jira/browse/NIFI-6812 Project: Apache NiFi Issue Type: Bug Reporter: Peter Turcsanyi Fix For: 1.10.0 nifi-azure-services-api uses a subset of the dependencies of nifi-azure-processor. So the licenses can be copied from there and the main NOTICE file in the assembly module should already be fine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NIFI-6812) Add LICENSE/NOTICE files to nifi-azure-services-api-nar
[ https://issues.apache.org/jira/browse/NIFI-6812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-6812: - Assignee: Matt Gilman > Add LICENSE/NOTICE files to nifi-azure-services-api-nar > --- > > Key: NIFI-6812 > URL: https://issues.apache.org/jira/browse/NIFI-6812 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Turcsanyi >Assignee: Matt Gilman >Priority: Major > Fix For: 1.10.0 > > > nifi-azure-services-api uses a subset of the dependencies of > nifi-azure-processor. > So the licenses can be copied from there and the main NOTICE file in the > assembly module should already be fine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] mcgilman opened a new pull request #3847: NIFI-6812: Establishing the L&N for the azure-services-api-nar
mcgilman opened a new pull request #3847: NIFI-6812: Establishing the L&N for the azure-services-api-nar URL: https://github.com/apache/nifi/pull/3847 NIFI-6812: - Establishing the L&N for the azure-services-api-nar. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6812) Add LICENSE/NOTICE files to nifi-azure-services-api-nar
[ https://issues.apache.org/jira/browse/NIFI-6812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-6812: -- Status: Patch Available (was: Open) > Add LICENSE/NOTICE files to nifi-azure-services-api-nar > --- > > Key: NIFI-6812 > URL: https://issues.apache.org/jira/browse/NIFI-6812 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Turcsanyi >Assignee: Matt Gilman >Priority: Major > Fix For: 1.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > > nifi-azure-services-api uses a subset of the dependencies of > nifi-azure-processor. > So the licenses can be copied from there and the main NOTICE file in the > assembly module should already be fine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #3847: NIFI-6812: Establishing the L&N for the azure-services-api-nar
asfgit closed pull request #3847: NIFI-6812: Establishing the L&N for the azure-services-api-nar URL: https://github.com/apache/nifi/pull/3847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6812) Add LICENSE/NOTICE files to nifi-azure-services-api-nar
[ https://issues.apache.org/jira/browse/NIFI-6812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6812: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Add LICENSE/NOTICE files to nifi-azure-services-api-nar > --- > > Key: NIFI-6812 > URL: https://issues.apache.org/jira/browse/NIFI-6812 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Turcsanyi >Assignee: Matt Gilman >Priority: Major > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > > nifi-azure-services-api uses a subset of the dependencies of > nifi-azure-processor. > So the licenses can be copied from there and the main NOTICE file in the > assembly module should already be fine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6812) Add LICENSE/NOTICE files to nifi-azure-services-api-nar
[ https://issues.apache.org/jira/browse/NIFI-6812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959942#comment-16959942 ] ASF subversion and git services commented on NIFI-6812: --- Commit 4f5718bf50f0e53f859824bd0fbb29e4ec27e8ff in nifi's branch refs/heads/master from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4f5718b ] NIFI-6812: This closes #3847 - Establishing the L&N for the azure-services-api-nar. Signed-off-by: Joe Witt > Add LICENSE/NOTICE files to nifi-azure-services-api-nar > --- > > Key: NIFI-6812 > URL: https://issues.apache.org/jira/browse/NIFI-6812 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Turcsanyi >Assignee: Matt Gilman >Priority: Major > Fix For: 1.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > > nifi-azure-services-api uses a subset of the dependencies of > nifi-azure-processor. > So the licenses can be copied from there and the main NOTICE file in the > assembly module should already be fine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-6806) IllegalStateExceptionMapper, etc. should always log full stack trace
[ https://issues.apache.org/jira/browse/NIFI-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6806: --- Fix Version/s: (was: 1.11.0) 1.10.0 > IllegalStateExceptionMapper, etc. should always log full stack trace > > > Key: NIFI-6806 > URL: https://issues.apache.org/jira/browse/NIFI-6806 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.10.0 > > > The IllegalStateExceptionMapper is used when any IllegalStateException makes > its way all the way back to the web tier. This happens, for instance, if a > Controller Service cannot be enabled. When this happens, the Exception Mapper > only logs the stack trace if DEBUG is enabled. This is an old pattern that > was followed during early releases to prevent such verbose logging, but this > Exception Mapper needs to be updated to always log the stack traces. > Otherwise, we have no way of knowing the underlying cause of the failure. > IllegalArgumentExceptionMapper and a few others also appear to follow this > same pattern and need to be updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-6798) Validate Controller Services referenced via dynamic properties
[ https://issues.apache.org/jira/browse/NIFI-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6798: --- Fix Version/s: (was: 1.11.0) 1.10.0 > Validate Controller Services referenced via dynamic properties > -- > > Key: NIFI-6798 > URL: https://issues.apache.org/jira/browse/NIFI-6798 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Peter Turcsanyi >Assignee: Mark Payne >Priority: Major > Fix For: 1.10.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > If a Controller Service referenced by another component is disabled, then the > referencing component should be in invalid state. > It works fine for statically referenced Controller Services (configured via > static properties of the processor / another service), but it seems the > framework does not check it for dynamically configured services. > The validator method can be found here: > [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractComponentNode.java#L679] > Components that have Controller Service references configured via dynamic > properties: > * DBCPConnectionPoolLookup > * AzureStorageCredentialsControllerServiceLookup > * (there might be others, needs to be checked) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-6687) Update Ranger dependencies
[ https://issues.apache.org/jira/browse/NIFI-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6687: --- Fix Version/s: (was: 1.11.0) 1.10.0 > Update Ranger dependencies > -- > > Key: NIFI-6687 > URL: https://issues.apache.org/jira/browse/NIFI-6687 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 1.10.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Upgrade the Ranger authorizer to leverage version 2.x. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-6801) Connection analytics models should be distinct for connections
[
https://issues.apache.org/jira/browse/NIFI-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-6801:
---
Fix Version/s: (was: 1.11.0)
1.10.0
> Connection analytics models should be distinct for connections
> --
>
> Key: NIFI-6801
> URL: https://issues.apache.org/jira/browse/NIFI-6801
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.10.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>Priority: Major
> Fix For: 1.10.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Connections should have Status Analytics Model instances that are unique for
> each connection such that calculations for the model can be referred to or
> updated when new observations are available. Currently the model appears to
> be shared across connection objects which leads to erroneous results,
> especially when a connection does not have enough observations to update the
> model (since the older values of a previous connection may still be present).
> This behavior can be seen when debugging is enabled for analytics and noting
> differences between a Timer Driven Thread execution of predictions vs the
> NiFi Web Server thread predictions for multiple connections (a flow with one
> connection would not exhibit this issue). The Time Driven thread may not
> retrieve enough connection status observations to refresh the model, and when
> that occurs, it may still contain calculations from a previous model and use
> that for predictions. Observers may see behavior where web server and timer
> driven predictions only have similar or matching predictions for one
> connection but others may be mismatched, such as in the below (where
> connection has similar prediction between threads but , and do
> not):
> {code:java}
> 2019-10-22 08:01:34,539 INFO [NiFi Web Server-23]
> o.a.nifi.reporting.StandardEventAccess : predicted time to COUNT
> backpressure = 00:44:13 / 2653416
> 2019-10-22 08:01:34,539 INFO [NiFi Web Server-23]
> o.a.nifi.reporting.StandardEventAccess : predicted time to BYTES
> backpressure = 01:09:13 / 4153511
> 2019-10-22 08:01:34,540 INFO [NiFi Web Server-23]
> o.a.nifi.reporting.StandardEventAccess : predicted time to COUNT
> backpressure = 00:32:31 / 1951609
> 2019-10-22 08:01:34,540 INFO [NiFi Web Server-23]
> o.a.nifi.reporting.StandardEventAccess : predicted time to BYTES
> backpressure = 00:32:28 / 1948504
> 2019-10-22 08:01:34,541 INFO [NiFi Web Server-23]
> o.a.nifi.reporting.StandardEventAccess : predicted time to COUNT
> backpressure = 07:29:14 / 26954837
> 2019-10-22 08:01:34,541 INFO [NiFi Web Server-23]
> o.a.nifi.reporting.StandardEventAccess : predicted time to BYTES
> backpressure = 05:24:56 / 19496954
> 2019-10-22 08:02:02,767 INFO [Timer-Driven Process Thread-2]
> o.a.nifi.reporting.StandardEventAccess : predicted time to COUNT
> backpressure = 04:08:36 / 14916150
> 2019-10-22 08:02:02,767 INFO [Timer-Driven Process Thread-2]
> o.a.nifi.reporting.StandardEventAccess : predicted time to BYTES
> backpressure = 04:17:49 / 15469243
> 2019-10-22 08:02:02,769 INFO [Timer-Driven Process Thread-2]
> o.a.nifi.reporting.StandardEventAccess : predicted time to COUNT
> backpressure = 01:13:42 / 4422829
> 2019-10-22 08:02:02,769 INFO [Timer-Driven Process Thread-2]
> o.a.nifi.reporting.StandardEventAccess : predicted time to BYTES
> backpressure = 00:57:15 / 3435109
> 2019-10-22 08:02:02,770 INFO [Timer-Driven Process Thread-2]
> o.a.nifi.reporting.StandardEventAccess : predicted time to COUNT
> backpressure = 07:28:46 / 26926608
> 2019-10-22 08:02:02,770 INFO [Timer-Driven Process Thread-2]
> o.a.nifi.reporting.StandardEventAccess : predicted time to BYTES
> backpressure = 05:24:28 / 19468725
> {code}
> A workaround for this is to increase the nifi.analytics.query.interval
> property or decrease the nifi.components.status.snapshot.frequency property
> to ensure obtaining enough observations for a refresh. However an appropriate
> fix is to ensure model instances are unique for each connection and to ensure
> that, by default, all threads will obtain enough observations for predictions.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-6797) PublishKafka* Processors should support a property for Kafka Partition
[ https://issues.apache.org/jira/browse/NIFI-6797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6797: --- Fix Version/s: (was: 1.11.0) 1.10.0 > PublishKafka* Processors should support a property for Kafka Partition > -- > > Key: NIFI-6797 > URL: https://issues.apache.org/jira/browse/NIFI-6797 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.10.0 > > Time Spent: 40m > Remaining Estimate: 0h > > PublishKafka_* and PublishKafkaRecord_* processors do not provide the ability > to set the partition for each message. PublishKafka_* should support > indicating which partition a FlowFile goes to based on Expression Language > (including Attributes) and should use its own custom partitioner to handle > that. PublishKafkaRecord_* processors should do the same but should also > support using RecordPath to allow for sending records to different partitions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-registry] kevdoran closed pull request #245: NIFIREG-252: adding mavendocker build profile
kevdoran closed pull request #245: NIFIREG-252: adding mavendocker build profile URL: https://github.com/apache/nifi-registry/pull/245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] alopresto commented on a change in pull request #3844: NIFI-1474 Added validation for p in scrypt
alopresto commented on a change in pull request #3844: NIFI-1474 Added
validation for p in scrypt
URL: https://github.com/apache/nifi/pull/3844#discussion_r339188444
##
File path:
nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/crypto/ScryptCipherProvider.java
##
@@ -78,6 +79,17 @@ public ScryptCipherProvider(int n, int r, int p) {
if (p < DEFAULT_P) {
logger.warn("The provided parallelization factor {} is below the
recommended minimum {}", p, DEFAULT_P);
}
+
+if (!isPValid(r, p)) {
+logger.warn("Based on the provided block size {}, the provided
parallelization factor {} is out of bounds", r, p);
+throw new IllegalArgumentException("Invalid p value exceeds p
boundary");
+}
+}
+
+public static boolean isPValid(int r, int p) {
Review comment:
Please add a Javadoc comment for this public method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] alopresto commented on a change in pull request #3844: NIFI-1474 Added validation for p in scrypt
alopresto commented on a change in pull request #3844: NIFI-1474 Added
validation for p in scrypt
URL: https://github.com/apache/nifi/pull/3844#discussion_r339188702
##
File path:
nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/util/crypto/ScryptCipherProviderGroovyTest.groovy
##
@@ -513,6 +513,81 @@ class ScryptCipherProviderGroovyTest {
assert params[2] == EXPECTED_P
}
+@Test
+void testShouldVerifyPBoundary() throws Exception {
+// Arrange
+final int r = 8;
+final int p = 1;
+
+// Act
+boolean valid = ScryptCipherProvider.isPValid(r, p)
+
+// Assert
+assert valid
+}
+
+@Test
+void testShouldFailPBoundary() throws Exception {
+// Arrange
+// The p upper bound is calculated with the formula below:
+// pBoundary = ((Math.pow(2,32))-1) * (32.0/(r * 128)), where
pBoundary = 134217727.96875;
Review comment:
Update this comment to note that this particular `p` value is for `r = 8`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] alopresto commented on a change in pull request #3844: NIFI-1474 Added validation for p in scrypt
alopresto commented on a change in pull request #3844: NIFI-1474 Added
validation for p in scrypt
URL: https://github.com/apache/nifi/pull/3844#discussion_r339188893
##
File path:
nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/util/crypto/ScryptCipherProviderGroovyTest.groovy
##
@@ -513,6 +513,81 @@ class ScryptCipherProviderGroovyTest {
assert params[2] == EXPECTED_P
}
+@Test
+void testShouldVerifyPBoundary() throws Exception {
+// Arrange
+final int r = 8;
+final int p = 1;
+
+// Act
+boolean valid = ScryptCipherProvider.isPValid(r, p)
+
+// Assert
+assert valid
+}
+
+@Test
+void testShouldFailPBoundary() throws Exception {
+// Arrange
+// The p upper bound is calculated with the formula below:
+// pBoundary = ((Math.pow(2,32))-1) * (32.0/(r * 128)), where
pBoundary = 134217727.96875;
+Map costParameters = [8:134217729, 128:8388608, 4096: 0]
+
+// Act
+def results = costParameters.collectEntries { r, p ->
+def isValid = ScryptCipherProvider.isPValid(r, p)
+[r, isValid]
+}
+
+// results => [8: false, 128: false, 4096: false]
+
+// Assert
+results.each { r, isPValid ->
+logger.info("For r ${r}, p is ${isPValid}")
+assert !isPValid
+}
+
+
+
+}
+//*
Review comment:
Remove this comment block.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] aramcodz opened a new pull request #3848: Nifi 6762: Submit new List Processor - ListMultipleS3Buckets
aramcodz opened a new pull request #3848: Nifi 6762: Submit new List Processor
- ListMultipleS3Buckets
URL: https://github.com/apache/nifi/pull/3848
Description of PR
Nifi 6762: Submit new List Processor - ListMultipleS3Buckets
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
https://issues.apache.org/jira/browse/NIFI-6762
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
Yes
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
Yes, just rebased.
- [ ] Is your initial contribution a single, squashed commit?
Two commits in this PR Contribution.
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
YES
- [ ] Have you written or updated unit tests to verify your changes?
YES
- [ ] Have you verified that the full build is successful on both JDK 8 and
JDK 11?
YES
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)? YES
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
NOT Applicable
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
NOT Applicable
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
NOT Applicable
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
NOT Applicable
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] asfgit closed pull request #3844: NIFI-1474 Added validation for p in scrypt
asfgit closed pull request #3844: NIFI-1474 Added validation for p in scrypt URL: https://github.com/apache/nifi/pull/3844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] alopresto commented on issue #3844: NIFI-1474 Added validation for p in scrypt
alopresto commented on issue #3844: NIFI-1474 Added validation for p in scrypt URL: https://github.com/apache/nifi/pull/3844#issuecomment-546520492 Thanks for your first contribution. I have merged it and closed the ticket. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-1474) Enforce p boundary in Scrypt
[
https://issues.apache.org/jira/browse/NIFI-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960138#comment-16960138
]
ASF subversion and git services commented on NIFI-1474:
---
Commit 4d25b6341ccba0ee24da15198d030d8132972e7c in nifi's branch
refs/heads/master from mtien
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4d25b63 ]
NIFI-1474 Added method to check p boundary. Added a unit test.
NIFI-1474 Added unit test for constructor p boundaries. Added p boundary
conditions.
NIFI-1474 Updated documentation regarding p boundary.
NIFI-1474 Added r validation and unit tests. Added Javadoc for new methods.
This closes #3844.
Signed-off-by: Andy LoPresto
> Enforce p boundary in Scrypt
>
>
> Key: NIFI-1474
> URL: https://issues.apache.org/jira/browse/NIFI-1474
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: M Tien
>Priority: Trivial
> Labels: encryption, security
> Original Estimate: 24h
> Time Spent: 1h
> Remaining Estimate: 23h
>
> According to the Scrypt specification, there is a maximum boundary for {{p}}
> of {{(2^32 - 1) * 32 / MFlen}}. In practice, {{p}} almost always has a value
> of {{1}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-1474) Enforce p boundary in Scrypt
[
https://issues.apache.org/jira/browse/NIFI-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960140#comment-16960140
]
ASF subversion and git services commented on NIFI-1474:
---
Commit 4d25b6341ccba0ee24da15198d030d8132972e7c in nifi's branch
refs/heads/master from mtien
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4d25b63 ]
NIFI-1474 Added method to check p boundary. Added a unit test.
NIFI-1474 Added unit test for constructor p boundaries. Added p boundary
conditions.
NIFI-1474 Updated documentation regarding p boundary.
NIFI-1474 Added r validation and unit tests. Added Javadoc for new methods.
This closes #3844.
Signed-off-by: Andy LoPresto
> Enforce p boundary in Scrypt
>
>
> Key: NIFI-1474
> URL: https://issues.apache.org/jira/browse/NIFI-1474
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: M Tien
>Priority: Trivial
> Labels: encryption, security
> Original Estimate: 24h
> Time Spent: 1h 10m
> Remaining Estimate: 22h 50m
>
> According to the Scrypt specification, there is a maximum boundary for {{p}}
> of {{(2^32 - 1) * 32 / MFlen}}. In practice, {{p}} almost always has a value
> of {{1}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-1474) Enforce p boundary in Scrypt
[
https://issues.apache.org/jira/browse/NIFI-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-1474:
Status: Patch Available (was: Open)
> Enforce p boundary in Scrypt
>
>
> Key: NIFI-1474
> URL: https://issues.apache.org/jira/browse/NIFI-1474
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: M Tien
>Priority: Trivial
> Labels: encryption, security
> Original Estimate: 24h
> Time Spent: 1h 20m
> Remaining Estimate: 22h 40m
>
> According to the Scrypt specification, there is a maximum boundary for {{p}}
> of {{(2^32 - 1) * 32 / MFlen}}. In practice, {{p}} almost always has a value
> of {{1}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-1474) Enforce p boundary in Scrypt
[
https://issues.apache.org/jira/browse/NIFI-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960139#comment-16960139
]
ASF subversion and git services commented on NIFI-1474:
---
Commit 4d25b6341ccba0ee24da15198d030d8132972e7c in nifi's branch
refs/heads/master from mtien
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4d25b63 ]
NIFI-1474 Added method to check p boundary. Added a unit test.
NIFI-1474 Added unit test for constructor p boundaries. Added p boundary
conditions.
NIFI-1474 Updated documentation regarding p boundary.
NIFI-1474 Added r validation and unit tests. Added Javadoc for new methods.
This closes #3844.
Signed-off-by: Andy LoPresto
> Enforce p boundary in Scrypt
>
>
> Key: NIFI-1474
> URL: https://issues.apache.org/jira/browse/NIFI-1474
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: M Tien
>Priority: Trivial
> Labels: encryption, security
> Original Estimate: 24h
> Time Spent: 1h
> Remaining Estimate: 23h
>
> According to the Scrypt specification, there is a maximum boundary for {{p}}
> of {{(2^32 - 1) * 32 / MFlen}}. In practice, {{p}} almost always has a value
> of {{1}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-1474) Enforce p boundary in Scrypt
[
https://issues.apache.org/jira/browse/NIFI-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-1474:
Fix Version/s: 1.11.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Enforce p boundary in Scrypt
>
>
> Key: NIFI-1474
> URL: https://issues.apache.org/jira/browse/NIFI-1474
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: M Tien
>Priority: Trivial
> Labels: encryption, security
> Fix For: 1.11.0
>
> Original Estimate: 24h
> Time Spent: 1h 20m
> Remaining Estimate: 22h 40m
>
> According to the Scrypt specification, there is a maximum boundary for {{p}}
> of {{(2^32 - 1) * 32 / MFlen}}. In practice, {{p}} almost always has a value
> of {{1}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-1474) Enforce p boundary in Scrypt
[
https://issues.apache.org/jira/browse/NIFI-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960141#comment-16960141
]
ASF subversion and git services commented on NIFI-1474:
---
Commit 4d25b6341ccba0ee24da15198d030d8132972e7c in nifi's branch
refs/heads/master from mtien
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4d25b63 ]
NIFI-1474 Added method to check p boundary. Added a unit test.
NIFI-1474 Added unit test for constructor p boundaries. Added p boundary
conditions.
NIFI-1474 Updated documentation regarding p boundary.
NIFI-1474 Added r validation and unit tests. Added Javadoc for new methods.
This closes #3844.
Signed-off-by: Andy LoPresto
> Enforce p boundary in Scrypt
>
>
> Key: NIFI-1474
> URL: https://issues.apache.org/jira/browse/NIFI-1474
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: M Tien
>Priority: Trivial
> Labels: encryption, security
> Original Estimate: 24h
> Time Spent: 1h 10m
> Remaining Estimate: 22h 50m
>
> According to the Scrypt specification, there is a maximum boundary for {{p}}
> of {{(2^32 - 1) * 32 / MFlen}}. In practice, {{p}} almost always has a value
> of {{1}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #3772: NIFI-6682 SplitJson does not work if the input is null
asfgit closed pull request #3772: NIFI-6682 SplitJson does not work if the input is null URL: https://github.com/apache/nifi/pull/3772 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6682) SplitJson does not work if the input is String "null"
[ https://issues.apache.org/jira/browse/NIFI-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960149#comment-16960149 ] ASF subversion and git services commented on NIFI-6682: --- Commit cfcf2e698df34eb097c23a404c1a346a4aeb9c60 in nifi's branch refs/heads/master from Otto Fowler [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=cfcf2e6 ] NIFI-6682 SplitJson does not work if the input is null This closes #3772 Signed-off-by: Mike Thomsen > SplitJson does not work if the input is String "null" > -- > > Key: NIFI-6682 > URL: https://issues.apache.org/jira/browse/NIFI-6682 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.9.2 >Reporter: Frank Chen >Assignee: Otto Fowler >Priority: Major > Labels: patch-available > Attachments: image-2019-09-17-18-18-19-860.png, > image-2019-09-17-18-33-33-708.png > > Time Spent: 2h 10m > Remaining Estimate: 0h > > When the input is String "null", the SplitJson processor should output to > failure route rather than report error.As a result, the flowfile is not > processed in the queue all the time. > > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NIFI-6682) SplitJson does not work if the input is String "null"
[ https://issues.apache.org/jira/browse/NIFI-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen resolved NIFI-6682. Fix Version/s: 1.10.0 Resolution: Fixed > SplitJson does not work if the input is String "null" > -- > > Key: NIFI-6682 > URL: https://issues.apache.org/jira/browse/NIFI-6682 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.9.2 >Reporter: Frank Chen >Assignee: Otto Fowler >Priority: Major > Labels: patch-available > Fix For: 1.10.0 > > Attachments: image-2019-09-17-18-18-19-860.png, > image-2019-09-17-18-33-33-708.png > > Time Spent: 2h 20m > Remaining Estimate: 0h > > When the input is String "null", the SplitJson processor should output to > failure route rather than report error.As a result, the flowfile is not > processed in the queue all the time. > > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] MikeThomsen commented on issue #3816: Nifi-6682 SplitJson does not work if the input is String "null"
MikeThomsen commented on issue #3816: Nifi-6682 SplitJson does not work if the input is String "null" URL: https://github.com/apache/nifi/pull/3816#issuecomment-546524010 @aloneface I merged @ottobackwards's version of the PR. You can close this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3624: NIFI-6255 NIFI-6287: Hash function for expression language and record…
MikeThomsen commented on a change in pull request #3624: NIFI-6255 NIFI-6287:
Hash function for expression language and record…
URL: https://github.com/apache/nifi/pull/3624#discussion_r339251539
##
File path:
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/functions/Hash.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.record.path.functions;
+
+import org.apache.nifi.record.path.FieldValue;
+import org.apache.nifi.record.path.RecordPathEvaluationContext;
+import org.apache.nifi.record.path.StandardFieldValue;
+import org.apache.nifi.record.path.exception.RecordPathException;
+import org.apache.nifi.record.path.paths.RecordPathSegment;
+import org.apache.nifi.record.path.util.RecordPathUtils;
+import org.apache.nifi.serialization.record.util.DataTypeUtils;
+
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+import java.security.Security;
+import java.util.stream.Stream;
+
+public class Hash extends RecordPathSegment {
+private static final char[] DIGITS = { '0', '1', '2', '3', '4', '5', '6',
'7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f' };
Review comment:
Same here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] MikeThomsen commented on a change in pull request #3624: NIFI-6255 NIFI-6287: Hash function for expression language and record…
MikeThomsen commented on a change in pull request #3624: NIFI-6255 NIFI-6287:
Hash function for expression language and record…
URL: https://github.com/apache/nifi/pull/3624#discussion_r339251426
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/HashEvaluator.java
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+import java.security.Security;
+import org.apache.nifi.attribute.expression.language.EvaluationContext;
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException;
+
+public class HashEvaluator extends StringEvaluator {
+private static final char[] DIGITS = { '0', '1', '2', '3', '4', '5', '6',
'7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f' };
Review comment:
Would be good to see this refactored to use
[DigestUtils](https://commons.apache.org/proper/commons-codec/apidocs/org/apache/commons/codec/digest/DigestUtils.html)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (NIFI-6762) New Processor - Watch Multiple S3 Buckets for content changes
[ https://issues.apache.org/jira/browse/NIFI-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960070#comment-16960070 ] Aram S Openden commented on NIFI-6762: -- [~ste...@apache.org] Please check out my PR (just posted today): [https://github.com/apache/nifi/pull/3848.] Let me know if this adequately answers your design questions or if I need to provide more info. in some other format. > New Processor - Watch Multiple S3 Buckets for content changes > - > > Key: NIFI-6762 > URL: https://issues.apache.org/jira/browse/NIFI-6762 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.9.2 >Reporter: Aram S Openden >Priority: Major > Labels: Processor, S3, watch > Original Estimate: 384h > Remaining Estimate: 384h > > Proposing New S3 processor that is a "variation" on the existing ListS3 > Processor. For lack of better term, I will call this "Watch Multiple S3 > Buckets Processor" (naming here is open to feedback). This new Processor > takes an input attribute "Bucket" from the FlowFile, which could use NiFi > ExpressionLanguage to compute that value. Hence, the Processor could "watch" > different buckets in an S3 Object Store. > This processor must handle the State Management logic for multiple S3 > buckets. The simplest solution for this problem add to modify the State > Management logic to prepend the bucket name to this key/objectName that is > being used to track state. > Finally, the Dev should document the maximum number of buckets it will > monitor at once, maximum amount of state/storage it can have to track the > various listings in various buckets. -- This message was sent by Atlassian Jira (v8.3.4#803005)
