[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620906869
##
File path: extensions/jni/JVMCreator.h
##
@@ -40,7 +40,7 @@ namespace jni {
class JVMCreator : public minifi::core::CoreComponent {
public:
- explicit JVMCreator(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit JVMCreator(const std::string &name, const utils::Identifier& uuid =
{})
Review comment:
inconsistent `&` placing in a few places (counted 23)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620907627
##
File path: extensions/script/ExecuteScript.h
##
@@ -36,7 +36,7 @@ namespace processors {
class ExecuteScript : public core::Processor {
public:
- explicit ExecuteScript(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit ExecuteScript(const std::string &name, const utils::Identifier&
uuid = {})
Review comment:
here as well
##
File path: extensions/script/python/ExecutePythonProcessor.h
##
@@ -45,7 +45,7 @@ namespace processors {
class ExecutePythonProcessor : public core::Processor {
public:
- explicit ExecutePythonProcessor(const std::string &name, utils::Identifier
uuid = utils::Identifier())
+ explicit ExecutePythonProcessor(const std::string &name, const
utils::Identifier& uuid = {})
Review comment:
here as well
##
File path: extensions/script/python/PythonCreator.h
##
@@ -43,7 +43,7 @@ namespace python {
class PythonCreator : public minifi::core::CoreComponent {
public:
- explicit PythonCreator(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit PythonCreator(const std::string &name, const utils::Identifier&
uuid = {})
Review comment:
here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620907335
##
File path: extensions/opencv/CaptureRTSPFrame.h
##
@@ -37,7 +37,7 @@ class CaptureRTSPFrame : public core::Processor {
public:
- explicit CaptureRTSPFrame(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit CaptureRTSPFrame(const std::string &name, const utils::Identifier&
uuid = {})
Review comment:
here as well
##
File path: extensions/opencv/MotionDetector.h
##
@@ -40,7 +40,7 @@ class MotionDetector : public core::Processor {
public:
- explicit MotionDetector(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit MotionDetector(const std::string &name, const utils::Identifier&
uuid = {})
Review comment:
here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620906869
##
File path: extensions/jni/JVMCreator.h
##
@@ -40,7 +40,7 @@ namespace jni {
class JVMCreator : public minifi::core::CoreComponent {
public:
- explicit JVMCreator(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit JVMCreator(const std::string &name, const utils::Identifier& uuid =
{})
Review comment:
inconsistent `&` placing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] thenatog commented on a change in pull request #4988: NIFI-7870 - Fix anonymous access control for advanced UI resources
thenatog commented on a change in pull request #4988:
URL: https://github.com/apache/nifi/pull/4988#discussion_r620740659
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/NiFiBearerTokenResolver.java
##
@@ -0,0 +1,64 @@
+/*
+ * Copyright 2012-2016 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.security.jwt;
+
+import org.apache.nifi.web.security.InvalidAuthenticationException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.servlet.http.HttpServletRequest;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+public class NiFiBearerTokenResolver implements BearerTokenResolver {
+private static final Logger logger =
LoggerFactory.getLogger(NiFiBearerTokenResolver.class);
+private static final Pattern BEARER_HEADER_PATTERN =
Pattern.compile("^Bearer (\\S*\\.\\S*\\.\\S*)$");
+private static final Pattern JWT_PATTERN =
Pattern.compile("^(\\S*\\.\\S*\\.\\S*)$");
+public static final String AUTHORIZATION = "Authorization";
Review comment:
This value is also used in a few places in different modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] thenatog commented on a change in pull request #4988: NIFI-7870 - Fix anonymous access control for advanced UI resources
thenatog commented on a change in pull request #4988:
URL: https://github.com/apache/nifi/pull/4988#discussion_r620740330
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/JwtAuthenticationFilter.java
##
@@ -33,43 +32,25 @@
private static final Logger logger =
LoggerFactory.getLogger(JwtAuthenticationFilter.class);
// The Authorization header contains authentication credentials
-public static final String AUTHORIZATION = "Authorization";
-private static final Pattern tokenPattern = Pattern.compile("^Bearer
(\\S*\\.\\S*\\.\\S*)$");
+public static final String JWT_COOKIE_NAME = "__Host-jwt-auth-cookie";
Review comment:
It is used in a few places, I'm not sure how best to share this value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] sushilkm commented on pull request #3750: NIFI-4913 Added preserve.environment to read environment variables while using run.as
sushilkm commented on pull request #3750: URL: https://github.com/apache/nifi/pull/3750#issuecomment-827220306 Sure, I will do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #3750: NIFI-4913 Added preserve.environment to read environment variables while using run.as
thenatog commented on pull request #3750: URL: https://github.com/apache/nifi/pull/3750#issuecomment-827213859 I verified that these changes preserve the environment variables from the parent user using the `preserve.environment` variable in bootstrap.conf. This PR would need to be rebased onto 'main' branch, as this PR is made against the 'master' branch which we migrated away from some time ago. I can't see a way to automatically do that through GIthub so it may require @sushilkm to edit this PR or submit a new PR rebased on main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-8478) Unable to build the project (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature")
[
https://issues.apache.org/jira/browse/NIFI-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332808#comment-17332808
]
Paul Grey commented on NIFI-8478:
-
Able to reproduce by applying this diff:
{{diff --git a/pom.xml b/pom.xml}}
{{index 14e1c32d2f..c39d22c80a 100644}}
{{--- a/pom.xml}}
{{+++ b/pom.xml}}
{{@@ -435,6 +435,8 @@}}
{{ -Xmx1G}}
{{ -Djava.net.preferIPv4Stack=true}}
{{ ${maven.surefire.arguments}}}
{{+ -Duser.language=fr}}
{{+ -Duser.region=FR}}
{{ -Dfile.encoding=UTF-8}}
{{ }}
{{ }}
> Unable to build the project
> (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~
> "SAXParseException.* DOCTYPE is disallowed when the feature")
> -
>
> Key: NIFI-8478
> URL: https://issues.apache.org/jira/browse/NIFI-8478
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.13.2
> Environment: $ java -version
> openjdk version "11.0.11" 2021-04-20 LTS
> OpenJDK Runtime Environment Zulu11.48+21-CA (build 11.0.11+9-LTS)
> OpenJDK 64-Bit Server VM Zulu11.48+21-CA (build 11.0.11+9-LTS, mixed mode)
> $ mvn -version
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.11, vendor: Azul Systems, Inc., runtime:
> /usr/lib/jvm/zulu11-ca-amd64
> Default locale: fr_FR, platform encoding: UTF-8
> OS name: "linux", version: "5.8.0-50-generic", arch: "amd64", family: "unix"
> $ git status
> Sur la branche main
> Votre branche est à jour avec 'origin/main'.
> rien à valider, la copie de travail est propre
>Reporter: Julien G.
>Priority: Blocker
>
> Unable to build the projet with the command:
> {noformat}
> mvn clean install{noformat}
> I got the error:
> {code:java}
> [INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @
> nifi-security-utils ---
> [INFO] Surefire report directory:
> /home/juldrixx/Documents/tmp/nifi/nifi-commons/nifi-security-utils/target/surefire-reports
> [INFO] Using configured provider
> org.apache.maven.surefire.junit4.JUnit4Provider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.nifi.security.XXEValidatorTest
> [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.4 s
> - in org.apache.nifi.security.XXEValidatorTest
> [INFO] Running org.apache.nifi.security.xml.XmlUtilsTest
> [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.347
> s <<< FAILURE! - in org.apache.nifi.security.xml.XmlUtilsTest
> [ERROR]
> testShouldHandleXXEInDocumentBuilder(org.apache.nifi.security.xml.XmlUtilsTest)
> Time elapsed: 0.017 s <<< FAILURE!
> org.codehaus.groovy.runtime.powerassert.PowerAssertionError:
> assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature"
>| |
>| java.util.regex.Matcher[pattern=SAXParseException.* DOCTYPE is
> disallowed when the feature region=0,314 lastmatch=]
>org.xml.sax.SAXParseException; systemId:
> file:/home/juldrixx/Documents/tmp/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml;
> lineNumber: 1; columnNumber: 65; DOCTYPE n'est pas autorisé lorsque la
> fonctionnalité "http://apache.org/xml/features/disallow-doctype-decl"; est
> définie sur True.
> at
> org.apache.nifi.security.xml.XmlUtilsTest.testShouldHandleXXEInDocumentBuilder(XmlUtilsTest.groovy:97)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-8478) Unable to build the project (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature")
[
https://issues.apache.org/jira/browse/NIFI-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332800#comment-17332800
]
Paul Grey commented on NIFI-8478:
-
The test looks like it is looking for an English language exception message:
https://github.com/apache/nifi/blob/main/nifi-commons/nifi-security-utils/src/test/groovy/org/apache/nifi/security/xml/XmlUtilsTest.groovy#L97
> Unable to build the project
> (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~
> "SAXParseException.* DOCTYPE is disallowed when the feature")
> -
>
> Key: NIFI-8478
> URL: https://issues.apache.org/jira/browse/NIFI-8478
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.13.2
> Environment: $ java -version
> openjdk version "11.0.11" 2021-04-20 LTS
> OpenJDK Runtime Environment Zulu11.48+21-CA (build 11.0.11+9-LTS)
> OpenJDK 64-Bit Server VM Zulu11.48+21-CA (build 11.0.11+9-LTS, mixed mode)
> $ mvn -version
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.11, vendor: Azul Systems, Inc., runtime:
> /usr/lib/jvm/zulu11-ca-amd64
> Default locale: fr_FR, platform encoding: UTF-8
> OS name: "linux", version: "5.8.0-50-generic", arch: "amd64", family: "unix"
> $ git status
> Sur la branche main
> Votre branche est à jour avec 'origin/main'.
> rien à valider, la copie de travail est propre
>Reporter: Julien G.
>Priority: Blocker
>
> Unable to build the projet with the command:
> {noformat}
> mvn clean install{noformat}
> I got the error:
> {code:java}
> [INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @
> nifi-security-utils ---
> [INFO] Surefire report directory:
> /home/juldrixx/Documents/tmp/nifi/nifi-commons/nifi-security-utils/target/surefire-reports
> [INFO] Using configured provider
> org.apache.maven.surefire.junit4.JUnit4Provider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.nifi.security.XXEValidatorTest
> [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.4 s
> - in org.apache.nifi.security.XXEValidatorTest
> [INFO] Running org.apache.nifi.security.xml.XmlUtilsTest
> [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.347
> s <<< FAILURE! - in org.apache.nifi.security.xml.XmlUtilsTest
> [ERROR]
> testShouldHandleXXEInDocumentBuilder(org.apache.nifi.security.xml.XmlUtilsTest)
> Time elapsed: 0.017 s <<< FAILURE!
> org.codehaus.groovy.runtime.powerassert.PowerAssertionError:
> assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature"
>| |
>| java.util.regex.Matcher[pattern=SAXParseException.* DOCTYPE is
> disallowed when the feature region=0,314 lastmatch=]
>org.xml.sax.SAXParseException; systemId:
> file:/home/juldrixx/Documents/tmp/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml;
> lineNumber: 1; columnNumber: 65; DOCTYPE n'est pas autorisé lorsque la
> fonctionnalité "http://apache.org/xml/features/disallow-doctype-decl"; est
> définie sur True.
> at
> org.apache.nifi.security.xml.XmlUtilsTest.testShouldHandleXXEInDocumentBuilder(XmlUtilsTest.groovy:97)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-8478) Unable to build the project (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature")
[
https://issues.apache.org/jira/browse/NIFI-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332795#comment-17332795
]
Julien G. commented on NIFI-8478:
-
I change my System language globally from fr_FR to en_US and it's fixing the
problem.
> Unable to build the project
> (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~
> "SAXParseException.* DOCTYPE is disallowed when the feature")
> -
>
> Key: NIFI-8478
> URL: https://issues.apache.org/jira/browse/NIFI-8478
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.13.2
> Environment: $ java -version
> openjdk version "11.0.11" 2021-04-20 LTS
> OpenJDK Runtime Environment Zulu11.48+21-CA (build 11.0.11+9-LTS)
> OpenJDK 64-Bit Server VM Zulu11.48+21-CA (build 11.0.11+9-LTS, mixed mode)
> $ mvn -version
> Apache Maven 3.6.3
> Maven home: /usr/share/maven
> Java version: 11.0.11, vendor: Azul Systems, Inc., runtime:
> /usr/lib/jvm/zulu11-ca-amd64
> Default locale: fr_FR, platform encoding: UTF-8
> OS name: "linux", version: "5.8.0-50-generic", arch: "amd64", family: "unix"
> $ git status
> Sur la branche main
> Votre branche est à jour avec 'origin/main'.
> rien à valider, la copie de travail est propre
>Reporter: Julien G.
>Priority: Blocker
>
> Unable to build the projet with the command:
> {noformat}
> mvn clean install{noformat}
> I got the error:
> {code:java}
> [INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @
> nifi-security-utils ---
> [INFO] Surefire report directory:
> /home/juldrixx/Documents/tmp/nifi/nifi-commons/nifi-security-utils/target/surefire-reports
> [INFO] Using configured provider
> org.apache.maven.surefire.junit4.JUnit4Provider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.nifi.security.XXEValidatorTest
> [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.4 s
> - in org.apache.nifi.security.XXEValidatorTest
> [INFO] Running org.apache.nifi.security.xml.XmlUtilsTest
> [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.347
> s <<< FAILURE! - in org.apache.nifi.security.xml.XmlUtilsTest
> [ERROR]
> testShouldHandleXXEInDocumentBuilder(org.apache.nifi.security.xml.XmlUtilsTest)
> Time elapsed: 0.017 s <<< FAILURE!
> org.codehaus.groovy.runtime.powerassert.PowerAssertionError:
> assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature"
>| |
>| java.util.regex.Matcher[pattern=SAXParseException.* DOCTYPE is
> disallowed when the feature region=0,314 lastmatch=]
>org.xml.sax.SAXParseException; systemId:
> file:/home/juldrixx/Documents/tmp/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml;
> lineNumber: 1; columnNumber: 65; DOCTYPE n'est pas autorisé lorsque la
> fonctionnalité "http://apache.org/xml/features/disallow-doctype-decl"; est
> définie sur True.
> at
> org.apache.nifi.security.xml.XmlUtilsTest.testShouldHandleXXEInDocumentBuilder(XmlUtilsTest.groovy:97)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (NIFI-8478) Unable to build the project (XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature")
Julien G. created NIFI-8478:
---
Summary: Unable to build the project
(XmlUtilsTest.testShouldHandleXXEInDocumentBuilder:97 assert msg =~
"SAXParseException.* DOCTYPE is disallowed when the feature")
Key: NIFI-8478
URL: https://issues.apache.org/jira/browse/NIFI-8478
Project: Apache NiFi
Issue Type: Bug
Components: Core Framework
Affects Versions: 1.13.2
Environment: $ java -version
openjdk version "11.0.11" 2021-04-20 LTS
OpenJDK Runtime Environment Zulu11.48+21-CA (build 11.0.11+9-LTS)
OpenJDK 64-Bit Server VM Zulu11.48+21-CA (build 11.0.11+9-LTS, mixed mode)
$ mvn -version
Apache Maven 3.6.3
Maven home: /usr/share/maven
Java version: 11.0.11, vendor: Azul Systems, Inc., runtime:
/usr/lib/jvm/zulu11-ca-amd64
Default locale: fr_FR, platform encoding: UTF-8
OS name: "linux", version: "5.8.0-50-generic", arch: "amd64", family: "unix"
$ git status
Sur la branche main
Votre branche est à jour avec 'origin/main'.
rien à valider, la copie de travail est propre
Reporter: Julien G.
Unable to build the projet with the command:
{noformat}
mvn clean install{noformat}
I got the error:
{code:java}
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @
nifi-security-utils ---
[INFO] Surefire report directory:
/home/juldrixx/Documents/tmp/nifi/nifi-commons/nifi-security-utils/target/surefire-reports
[INFO] Using configured provider org.apache.maven.surefire.junit4.JUnit4Provider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO] Running org.apache.nifi.security.XXEValidatorTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.4 s -
in org.apache.nifi.security.XXEValidatorTest
[INFO] Running org.apache.nifi.security.xml.XmlUtilsTest
[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.347 s
<<< FAILURE! - in org.apache.nifi.security.xml.XmlUtilsTest
[ERROR]
testShouldHandleXXEInDocumentBuilder(org.apache.nifi.security.xml.XmlUtilsTest)
Time elapsed: 0.017 s <<< FAILURE!
org.codehaus.groovy.runtime.powerassert.PowerAssertionError:
assert msg =~ "SAXParseException.* DOCTYPE is disallowed when the feature"
| |
| java.util.regex.Matcher[pattern=SAXParseException.* DOCTYPE is
disallowed when the feature region=0,314 lastmatch=]
org.xml.sax.SAXParseException; systemId:
file:/home/juldrixx/Documents/tmp/nifi/nifi-commons/nifi-security-utils/src/test/resources/local_xxe_file.xml;
lineNumber: 1; columnNumber: 65; DOCTYPE n'est pas autorisé lorsque la
fonctionnalité "http://apache.org/xml/features/disallow-doctype-decl"; est
définie sur True.
at
org.apache.nifi.security.xml.XmlUtilsTest.testShouldHandleXXEInDocumentBuilder(XmlUtilsTest.groovy:97)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-8236) Nifi Cluster Autoscaling on Kubernetes
[ https://issues.apache.org/jira/browse/NIFI-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332720#comment-17332720 ] DEOM Damien commented on NIFI-8236: --- We've used this one successfully in our company; [https://github.com/cetic/helm-nifi] There is no autoscaling feature in it, but it could be a good starting point... > Nifi Cluster Autoscaling on Kubernetes > -- > > Key: NIFI-8236 > URL: https://issues.apache.org/jira/browse/NIFI-8236 > Project: Apache NiFi > Issue Type: New Feature >Reporter: DEOM Damien >Priority: Major > > Nifi should be able to scale up / scale down, based on some criteria, ex: > * load-based > * schedule-based > > As an example, here is the documentation on how to autoscale Azure HDInsight > clusters: > > [https://docs.microsoft.com/en-us/azure/hdinsight/hdinsight-autoscale-clusters] > > The community could provide an official Kubernetes template, ready to be > deployed on the main cloud providers. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-8474) Add new Replacement Strategy for variable substitution in ReplaceText
[ https://issues.apache.org/jira/browse/NIFI-8474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8474: -- Status: Patch Available (was: Open) > Add new Replacement Strategy for variable substitution in ReplaceText > - > > Key: NIFI-8474 > URL: https://issues.apache.org/jira/browse/NIFI-8474 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] turcsanyip opened a new pull request #5032: NIFI-8474: Added new Replacement Strategy for variable substitution i…
turcsanyip opened a new pull request #5032: URL: https://github.com/apache/nifi/pull/5032 …n ReplaceText. https://issues.apache.org/jira/browse/NIFI-8474 In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with **NIFI-** where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)? - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you verified that the full build is successful on JDK 8? - [ ] Have you verified that the full build is successful on JDK 11? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-8477) If a node completely dies, can not delete it from the cluster; AKA Zombie Node
Chris McKeever created NIFI-8477:
Summary: If a node completely dies, can not delete it from the
cluster; AKA Zombie Node
Key: NIFI-8477
URL: https://issues.apache.org/jira/browse/NIFI-8477
Project: Apache NiFi
Issue Type: Bug
Affects Versions: 1.13.2
Environment: Dockerized AWS ECS Instance
Reporter: Chris McKeever
Our nodes are ephemeral. Once they fall over, they don't come back in any
stateful manner. This is known to create data loss, which we are aware of.
The issue we are seeing is, that when they fall over (right now we are
forcefully knocking them over to test resiliency) the cluster heartbeat will
flag them as disconnected, but there is no way to then delete them as we get a
ERROR: Error executing command 'delete-node' : Error deleting node:
java.net.SocketTimeoutException: timeout
We have increased the read/connect timeouts to 20s (from default 5s) and that
changes the error to a `read timeout`
Increasing those values to anything greater than 30s gives us unstable usage
across the board
{ "servlet":"jerseySpring", "message":"Service Unavailable",
"url":"/nifi-api/flow/current-user", "status":"503" }
ERROR: Error executing command 'get-nodes' : Read timed out
Occasionally, when some stars align, we are able to delete the node via the
toolkit cli, but it happens far and few between but does lean itself to some
timing issue.
Have discussed this thoroughly on the Nifi Slack, and Joe W. has mentioned
"I know something super bad happened and well - crap happens - can you help us
clean the cluster back up and get on with life?"
and ...
we need a nicer option. I'm not sure if the CLI does something smart here
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests
fgerlits closed pull request #1059: URL: https://github.com/apache/nifi-minifi-cpp/pull/1059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-registry] mtien-apache commented on pull request #319: NIFIREG-395 - Implemented the ability to import and export versioned flows through the UI
mtien-apache commented on pull request #319: URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-827030107 > Hey @mtien-apache - thanks for all your work on this. @andrewmlim 's comments all make sense to me and I would proceed with his recommendations. RE the Delete button color, yes the vibrant red is intentional as Drew observed. I believe this color is also used in other "delete" scenarios, so perhaps double-check to make sure color usage is consistent. @moranr Thanks for confirming - will proceed with the UI changes. @andrewmlim Confirmed the Delete button color is the same as other Delete buttons used throughout Registry (eg, Delete Buckets). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-8476) ConverRecord JSON to AVRO with logicalType date fails
Christian Danner created NIFI-8476:
--
Summary: ConverRecord JSON to AVRO with logicalType date fails
Key: NIFI-8476
URL: https://issues.apache.org/jira/browse/NIFI-8476
Project: Apache NiFi
Issue Type: Bug
Affects Versions: 1.13.2
Reporter: Christian Danner
Attachments: avro_date_test.xml
I setup an example Flow (Template) that transforms a JSON to AVRO Binary using
the ConvertRecords while using JSONTreeReader and AVROSetWriter. Once I get
JSON data as type INT and logicalType date passed to the processor, I get the
result 0.
Idk what I am doing wrong, so I attached the Flow I used.
Generate Flowfile:
Custom Text:
{code:java}
{"DOCNUM":"12345678","ERSDA":20210426,"LAEDA":18743}
{code}
avro.schema:
{code:java}
{
"type": "record",
"name": "MAT",
"fields": [{
"name": "DOCNUM",
"size": 16,
"type": [
"null",
"string"
],
"default": null,
"doc": "NA"
}, {
"name": "ERSDA",
"size": 8,
"type": [
"null", {
"type": "int",
"logicalType": "date"
}
],
"default": null,
"doc": "NA"
}, {
"name": "LAEDA",
"size": 8,
"type": [
"null", {
"type": "int",
"logicalType": "date"
}
],
"default": null,
"doc": "NA"
}
]
}
{code}
Result:
Flowfile Viewer (formatted):
{code:java}
[ {
"DOCNUM" : "12345678",
"ERSDA" : "1970-01-01",
"LAEDA" : "1970-01-01"
} ]
{code}
avro-tools
{code:java}
avro-tools tojson ~/3a3c1a8e-5fda-4c67-a62c-bb9aacbcef1d
{"DOCNUM":{"string":"12345678"},"ERSDA":{"int":0},"LAEDA":{"int":0}}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1061: MINIFICPP-1549 Add automake packages to MacOS environments
fgerlits closed pull request #1061: URL: https://github.com/apache/nifi-minifi-cpp/pull/1061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-8475) EL query parser can produce wrong output when input contains multiple escaped expressions
[
https://issues.apache.org/jira/browse/NIFI-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-8475:
--
Summary: EL query parser can produce wrong output when input contains
multiple escaped expressions (was: EL query parser can produce wrong output
when multiple escaped expressions are used)
> EL query parser can produce wrong output when input contains multiple escaped
> expressions
> -
>
> Key: NIFI-8475
> URL: https://issues.apache.org/jira/browse/NIFI-8475
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.13.2
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It can be replicated with GenerateFlowFile using 'Custom Text':
> {noformat}
> aaa $${var1} bbb
> ccc $${var2} ddd
> {noformat}
> Output:
> {noformat}
> aaa ${var1}aaa ${var1} bbb
> ccc ${var2} ddd
> {noformat}
> Expected output:
> {noformat}
> aaa ${var1} bbb
> ccc ${var2} ddd
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-8475) EL query parser can produce wrong output when multiple escaped expressions are used
[
https://issues.apache.org/jira/browse/NIFI-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-8475:
--
Status: Patch Available (was: In Progress)
> EL query parser can produce wrong output when multiple escaped expressions
> are used
> ---
>
> Key: NIFI-8475
> URL: https://issues.apache.org/jira/browse/NIFI-8475
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.13.2
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It can be replicated with GenerateFlowFile using 'Custom Text':
> {noformat}
> aaa $${var1} bbb
> ccc $${var2} ddd
> {noformat}
> Output:
> {noformat}
> aaa ${var1}aaa ${var1} bbb
> ccc ${var2} ddd
> {noformat}
> Expected output:
> {noformat}
> aaa ${var1} bbb
> ccc ${var2} ddd
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] turcsanyip opened a new pull request #5031: NIFI-8475: Fixed EL query parser when input contains multiple escaped…
turcsanyip opened a new pull request #5031: URL: https://github.com/apache/nifi/pull/5031 … expressions https://issues.apache.org/jira/browse/NIFI-8475 In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with **NIFI-** where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)? - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you verified that the full build is successful on JDK 8? - [ ] Have you verified that the full build is successful on JDK 11? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] tpalfy commented on a change in pull request #4973: NIFI-8373 Add Kerberos support to Accumulo processors
tpalfy commented on a change in pull request #4973:
URL: https://github.com/apache/nifi/pull/4973#discussion_r620407997
##
File path:
nifi-nar-bundles/nifi-accumulo-bundle/nifi-accumulo-services/src/main/java/org/apache/nifi/accumulo/controllerservices/AccumuloService.java
##
@@ -50,52 +61,95 @@
*/
@RequiresInstanceClassLoading
@Tags({"accumulo", "client", "service"})
-@CapabilityDescription("A controller service for accessing an HBase client.")
+@CapabilityDescription("A controller service for accessing an Accumulo
Client.")
public class AccumuloService extends AbstractControllerService implements
BaseAccumuloService {
-private enum AuthenticationType{
+private enum AuthenticationType {
PASSWORD,
+KERBEROS,
NONE
}
protected static final PropertyDescriptor ZOOKEEPER_QUORUM = new
PropertyDescriptor.Builder()
.name("ZooKeeper Quorum")
+.displayName("ZooKeeper Quorum")
.description("Comma-separated list of ZooKeeper hosts for
Accumulo.")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
protected static final PropertyDescriptor INSTANCE_NAME = new
PropertyDescriptor.Builder()
-.name("Instance Name")
+.name("accumulo-instance-name")
+.displayName("Instance Name")
.description("Instance name of the Accumulo cluster")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
+protected static final PropertyDescriptor AUTHENTICATION_TYPE = new
PropertyDescriptor.Builder()
+.name("accumulo-authentication-type")
+.displayName("Authentication Type")
+.description("Authentication Type")
+.allowableValues(AuthenticationType.values())
+.defaultValue(AuthenticationType.PASSWORD.toString())
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
protected static final PropertyDescriptor ACCUMULO_USER = new
PropertyDescriptor.Builder()
-.name("Accumulo User")
+.name("accumulo-user")
+.displayName("Accumulo User")
.description("Connecting user for Accumulo")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.dependsOn(AUTHENTICATION_TYPE,
AuthenticationType.PASSWORD.toString())
.build();
protected static final PropertyDescriptor ACCUMULO_PASSWORD = new
PropertyDescriptor.Builder()
-.name("Accumulo Password")
-.description("Connecting user's password when using the PASSWORD
Authentication type")
+.name("accumulo-password")
+.displayName("Accumulo Password")
+.description("Connecting user's password")
.sensitive(true)
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.dependsOn(AUTHENTICATION_TYPE,
AuthenticationType.PASSWORD.toString())
.build();
-protected static final PropertyDescriptor AUTHENTICATION_TYPE = new
PropertyDescriptor.Builder()
-.name("Authentication Type")
-.description("Authentication Type")
-.allowableValues(AuthenticationType.values())
-.defaultValue(AuthenticationType.PASSWORD.toString())
+protected static final PropertyDescriptor KERBEROS_CREDENTIALS_SERVICE =
new PropertyDescriptor.Builder()
+.name("kerberos-credentials-service")
+.displayName("Kerberos Credentials Service")
+.description("Specifies the Kerberos Credentials Controller
Service that should be used for principal + keytab Kerberos authentication")
+.identifiesControllerService(KerberosCredentialsService.class)
+.dependsOn(AUTHENTICATION_TYPE,
AuthenticationType.KERBEROS.toString())
+.build();
+
+protected static final PropertyDescriptor ACCUMULO_PRINCIPAL = new
PropertyDescriptor.Builder()
+.name("accumulo-principal")
+.displayName("Accumulo Principal")
+.description("Connecting principal for Accumulo")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.dependsOn(AUTHENTICATION_TYPE,
AuthenticationType.KERBEROS.toString())
.build();
+protected static final PropertyDescriptor ACCUMULO_PASSWORD_FOR_KERBEROS =
new PropertyDescriptor.Builder()
Review comment:
```suggestion
protected static final PropertyDescriptor KERBEROS
[jira] [Updated] (NIFI-8475) EL query parser can produce wrong output when multiple escaped expressions are used
[
https://issues.apache.org/jira/browse/NIFI-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-8475:
--
Affects Version/s: 1.13.2
> EL query parser can produce wrong output when multiple escaped expressions
> are used
> ---
>
> Key: NIFI-8475
> URL: https://issues.apache.org/jira/browse/NIFI-8475
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.13.2
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>
> It can be replicated with GenerateFlowFile using 'Custom Text':
> {noformat}
> aaa $${var1} bbb
> ccc $${var2} ddd
> {noformat}
> Output:
> {noformat}
> aaa ${var1}aaa ${var1} bbb
> ccc ${var2} ddd
> {noformat}
> Expected output:
> {noformat}
> aaa ${var1} bbb
> ccc ${var2} ddd
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-8474) Add new Replacement Strategy for variable substitution in ReplaceText
[ https://issues.apache.org/jira/browse/NIFI-8474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8474: -- Component/s: Extensions > Add new Replacement Strategy for variable substitution in ReplaceText > - > > Key: NIFI-8474 > URL: https://issues.apache.org/jira/browse/NIFI-8474 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NIFI-8475) EL query parser can produce wrong output when multiple escaped expressions are used
Peter Turcsanyi created NIFI-8475:
-
Summary: EL query parser can produce wrong output when multiple
escaped expressions are used
Key: NIFI-8475
URL: https://issues.apache.org/jira/browse/NIFI-8475
Project: Apache NiFi
Issue Type: Bug
Components: Core Framework
Reporter: Peter Turcsanyi
Assignee: Peter Turcsanyi
It can be replicated with GenerateFlowFile using 'Custom Text':
{noformat}
aaa $${var1} bbb
ccc $${var2} ddd
{noformat}
Output:
{noformat}
aaa ${var1}aaa ${var1} bbb
ccc ${var2} ddd
{noformat}
Expected output:
{noformat}
aaa ${var1} bbb
ccc ${var2} ddd
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-8465) Correct intermittent failures in PasswordBasedEncryptorGroovyTest
[
https://issues.apache.org/jira/browse/NIFI-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-8465:
---
Affects Version/s: 1.13.2
> Correct intermittent failures in PasswordBasedEncryptorGroovyTest
> -
>
> Key: NIFI-8465
> URL: https://issues.apache.org/jira/browse/NIFI-8465
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.13.2
>Reporter: David Handermann
>Assignee: Paul Grey
>Priority: Minor
> Labels: encryption, security
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{PasswordBasedEncryptorGroovyTest}} can fail intermittently during automated
> builds. A recent failure occurred when comparing encrypted and plaintext
> results:
> {quote}Error: Failures:
> Error:
> PasswordBasedEncryptorGroovyTest.testBcryptDecryptShouldSupportLegacyKeyDerivationProcess:445
> assert recovered == PLAINTEXT{quote}
> The test class should be evaluated to determine the source of the problem and
> refactored to avoid potential failures. It is also worth evaluating the
> opportunity to refactor the test into more discrete test classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (NIFI-8465) Correct intermittent failures in PasswordBasedEncryptorGroovyTest
[
https://issues.apache.org/jira/browse/NIFI-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-8465.
Fix Version/s: 1.14.0
Resolution: Fixed
> Correct intermittent failures in PasswordBasedEncryptorGroovyTest
> -
>
> Key: NIFI-8465
> URL: https://issues.apache.org/jira/browse/NIFI-8465
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.13.2
>Reporter: David Handermann
>Assignee: Paul Grey
>Priority: Minor
> Labels: encryption, security
> Fix For: 1.14.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{PasswordBasedEncryptorGroovyTest}} can fail intermittently during automated
> builds. A recent failure occurred when comparing encrypted and plaintext
> results:
> {quote}Error: Failures:
> Error:
> PasswordBasedEncryptorGroovyTest.testBcryptDecryptShouldSupportLegacyKeyDerivationProcess:445
> assert recovered == PLAINTEXT{quote}
> The test class should be evaluated to determine the source of the problem and
> refactored to avoid potential failures. It is also worth evaluating the
> opportunity to refactor the test into more discrete test classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #5029: NIFI-8465; issue with legacy KDF logic
asfgit closed pull request #5029: URL: https://github.com/apache/nifi/pull/5029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-8465) Correct intermittent failures in PasswordBasedEncryptorGroovyTest
[
https://issues.apache.org/jira/browse/NIFI-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332579#comment-17332579
]
ASF subversion and git services commented on NIFI-8465:
---
Commit 835f50c83a9b2ed89374da127893cb40db5b3c79 in nifi's branch
refs/heads/main from Paul Grey
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=835f50c ]
NIFI-8465 Handle bcrypt legacy decrypt failures in testing
This closes #5029
Signed-off-by: David Handermann
> Correct intermittent failures in PasswordBasedEncryptorGroovyTest
> -
>
> Key: NIFI-8465
> URL: https://issues.apache.org/jira/browse/NIFI-8465
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: Paul Grey
>Priority: Minor
> Labels: encryption, security
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{PasswordBasedEncryptorGroovyTest}} can fail intermittently during automated
> builds. A recent failure occurred when comparing encrypted and plaintext
> results:
> {quote}Error: Failures:
> Error:
> PasswordBasedEncryptorGroovyTest.testBcryptDecryptShouldSupportLegacyKeyDerivationProcess:445
> assert recovered == PLAINTEXT{quote}
> The test class should be evaluated to determine the source of the problem and
> refactored to avoid potential failures. It is also worth evaluating the
> opportunity to refactor the test into more discrete test classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (NIFI-8474) Add new Replacement Strategy for variable substitution in ReplaceText
Peter Turcsanyi created NIFI-8474: - Summary: Add new Replacement Strategy for variable substitution in ReplaceText Key: NIFI-8474 URL: https://issues.apache.org/jira/browse/NIFI-8474 Project: Apache NiFi Issue Type: Improvement Reporter: Peter Turcsanyi Assignee: Peter Turcsanyi -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-8473) REST API Documentation Missing Parameter Contexts
[ https://issues.apache.org/jira/browse/NIFI-8473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-8473: --- Status: Patch Available (was: In Progress) > REST API Documentation Missing Parameter Contexts > - > > Key: NIFI-8473 > URL: https://issues.apache.org/jira/browse/NIFI-8473 > Project: Apache NiFi > Issue Type: Bug > Components: Documentation & Website >Affects Versions: 1.13.2 >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The REST API documentation is missing a section on Parameter Contexts due to > the resource not being added to the list of sections. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] exceptionfactory opened a new pull request #5030: NIFI-8473 Added Parameter Contexts section to REST API documentation
exceptionfactory opened a new pull request #5030:
URL: https://github.com/apache/nifi/pull/5030
Description of PR
NIFI-8473 Adds Parameter Context section to REST API documentation template
so that Parameter Context resources are not grouped under the default
Controller section.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (NIFI-6826) Description in REST Api is misaligned
[ https://issues.apache.org/jira/browse/NIFI-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-6826: -- Assignee: David Handermann > Description in REST Api is misaligned > - > > Key: NIFI-6826 > URL: https://issues.apache.org/jira/browse/NIFI-6826 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation & Website >Reporter: Andrew M. Lim >Assignee: David Handermann >Priority: Minor > Attachments: nifi-6826-misalignment.png > > > See attached screenshot -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (NIFI-6826) Description in REST Api is misaligned
[
https://issues.apache.org/jira/browse/NIFI-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-6826:
---
Comment: was deleted
(was: There appears to be an issue with the {{summary}} class not being hidden
by default inside the {{operation}} element for this particular resource
operation.)
> Description in REST Api is misaligned
> -
>
> Key: NIFI-6826
> URL: https://issues.apache.org/jira/browse/NIFI-6826
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Documentation & Website
>Reporter: Andrew M. Lim
>Priority: Minor
> Attachments: nifi-6826-misalignment.png
>
>
> See attached screenshot
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1055: MINIFICPP-1454 Reduce duplication of CMake parameters in docker build
lordgamez commented on a change in pull request #1055:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1055#discussion_r620443589
##
File path: docker/DockerBuild.sh
##
@@ -112,7 +80,13 @@ while [[ $# -gt 0 ]]; do
-c|--cmake-param)
IFS='=' read -ra ARR <<< "$2"
if [[ ${#ARR[@]} -gt 1 ]]; then
-declare "${ARR[0]}"="${ARR[1]}"
+if [ "${ARR[0]}" == "BUILD_NUMBER" ]; then
+ BUILD_NUMBER="${ARR[1]}"
+elif [ "${ARR[0]}" == "DOCKER_BASE_IMAGE" ]; then
+ BUILD_ARGS="${BUILD_ARGS} --build-arg BASE_ALPINE_IMAGE=${ARR[1]}"
+else
+ BUILD_ARGS="${BUILD_ARGS} --build-arg ${ARR[0]}=${ARR[1]}"
+fi
Review comment:
That would require some additional changes in our other CI environments,
where the BUILD_NUMBER is used, I'm not sure it would worth breaking those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1047: MINIFICPP-1503 Build Tensorflow extension in the CI
lordgamez commented on a change in pull request #1047: URL: https://github.com/apache/nifi-minifi-cpp/pull/1047#discussion_r620439674 ## File path: .github/workflows/ci.yml ## @@ -215,8 +215,14 @@ jobs: sudo ln -s /usr/lib/x86_64-linux-gnu/odbc/libsqlite3odbc.so /usr/lib/x86_64-linux-gnu/libsqlite3odbc.so echo "PATH=/usr/lib/ccache:$PATH" >> $GITHUB_ENV echo -e "127.0.0.1\t$HOSTNAME" | sudo tee -a /etc/hosts > /dev/null + docker pull lordgamez/tensorflow-cc-binaries:ubuntu-20.04 Review comment: I'm not familiar with tensorflow either, but as I checked the APIs and the distribution it seemed that the only way to use the C++ API is to build your own libraries from the tensorflow sources. There is an official docker image and pip packages, but those only provide python packages. Additionally we currently use the [tensorflow_cc](https://github.com/FloopCZ/tensorflow_cc) wrapper library instead of the official tensorflow libs in our extension, which also includes only the source files in its releases. For me it seemed the the most viable option to package these libraries in a docker image, this way we have a documentation of the builds process as well in the form of the Dockerfile. But I'm open for any additional ideas, if we have some better options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-8445) Implement HashicorpVaultCommunicationService
[ https://issues.apache.org/jira/browse/NIFI-8445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Gresock reassigned NIFI-8445: Assignee: Joseph Gresock > Implement HashicorpVaultCommunicationService > > > Key: NIFI-8445 > URL: https://issues.apache.org/jira/browse/NIFI-8445 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Joseph Gresock >Assignee: Joseph Gresock >Priority: Minor > > Suggest using Spring's VaultTemplate to expose an initial set of > Vault-related methods that can be later expanded. > Should take the following configuration: > # Vault address (e.g., [https://localhost:8200|https://localhost:8200/]) > # TLS configuration (used only if address is https) > # Properties file location for configuring Vault Authentication Method > Should expose the initial methods: > * encrypt(String transitKey, byte[] plainText) > * decrypt(String transitKey, String cipherText) > This service should be able to be used initially in the NiFi core code and > Encrypt-Config tool code, and should eventually be made available to the NiFi > Registry code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1055: MINIFICPP-1454 Reduce duplication of CMake parameters in docker build
fgerlits commented on a change in pull request #1055:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1055#discussion_r620428878
##
File path: docker/DockerBuild.sh
##
@@ -112,7 +80,13 @@ while [[ $# -gt 0 ]]; do
-c|--cmake-param)
IFS='=' read -ra ARR <<< "$2"
if [[ ${#ARR[@]} -gt 1 ]]; then
-declare "${ARR[0]}"="${ARR[1]}"
+if [ "${ARR[0]}" == "BUILD_NUMBER" ]; then
+ BUILD_NUMBER="${ARR[1]}"
+elif [ "${ARR[0]}" == "DOCKER_BASE_IMAGE" ]; then
+ BUILD_ARGS="${BUILD_ARGS} --build-arg BASE_ALPINE_IMAGE=${ARR[1]}"
+else
+ BUILD_ARGS="${BUILD_ARGS} --build-arg ${ARR[0]}=${ARR[1]}"
+fi
Review comment:
We could add a new parameter, eg. `-n`, for `BUILD_NUMBER` and change
DockerConfig.cmake to run `.../DockerBuild.sh ... -n ${BUILD_NUMBER} ... -c
BASE_ALPINE_IMAGE=${DOCKER_BASE_IMAGE}`, then we wouldn't need this if-else
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5028: NIFI-8325: Complete SNMP refactor: SNMP GET and SET processors rework, unit tests added
exceptionfactory commented on a change in pull request #5028:
URL: https://github.com/apache/nifi/pull/5028#discussion_r620420099
##
File path:
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java
##
@@ -151,7 +152,24 @@ public ValidationResult validate(final String subject,
final String value, final
}
};
-public static final Validator PORT_VALIDATOR = createLongValidator(1,
65535, true);
+public static final Validator NETWORK_ADDRESS_VALIDATOR = new Validator() {
+private final Pattern ipv4Pattern =
Pattern.compile("^(([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(\\.(?!$)|$)){4}$");
+
+@Override
+public ValidationResult validate(final String subject, final String
value, final ValidationContext context) {
+
+final String reason = "not a valid IP address";
+final boolean isValidInetAddress = "localhost".equals(value) ||
isValid(value);
+return new
ValidationResult.Builder().subject(subject).input(value).explanation(reason).valid(isValidInetAddress).build();
+}
+
+private boolean isValid(final String email) {
+Matcher matcher = ipv4Pattern.matcher(email);
+return matcher.matches();
+}
+};
+
+public static final Validator PORT_VALIDATOR = createLongValidator(0,
65535, true);
Review comment:
This change breaks existing unit tests that expect `0` to be an invalid
port number. Is there a particular reason for this change? If so, the
existing unit test should be updated, but having `0` as a port number may not
work as expected in some existing components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-1541) Move ODBC dependent SQL testing to the docker integration tests
[ https://issues.apache.org/jira/browse/MINIFICPP-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1541: Assignee: Gabor Gyimesi > Move ODBC dependent SQL testing to the docker integration tests > --- > > Key: MINIFICPP-1541 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1541 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Adam Debreceni >Assignee: Gabor Gyimesi >Priority: Major > > SQL tests currently use platform-dependent ODBC drivers which are possibly > missing on the user's machine, this results in test failure. We should mock > the ODBCService on Linux and macOS, and use the actual implementation in > docker-based integration tests. On Windows we should use the actual > implementation but only enable it in the CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1047: MINIFICPP-1503 Build Tensorflow extension in the CI
fgerlits commented on a change in pull request #1047: URL: https://github.com/apache/nifi-minifi-cpp/pull/1047#discussion_r620412480 ## File path: .github/workflows/ci.yml ## @@ -215,8 +215,14 @@ jobs: sudo ln -s /usr/lib/x86_64-linux-gnu/odbc/libsqlite3odbc.so /usr/lib/x86_64-linux-gnu/libsqlite3odbc.so echo "PATH=/usr/lib/ccache:$PATH" >> $GITHUB_ENV echo -e "127.0.0.1\t$HOSTNAME" | sudo tee -a /etc/hosts > /dev/null + docker pull lordgamez/tensorflow-cc-binaries:ubuntu-20.04 Review comment: I don't know anything about tensorflow, but is there really no more standard way to fetch these files than using your private docker image? For example, using `pip` or some official tensorflow docker image? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-1494) InvokeHTTP should behave in the same way as NiFi
[ https://issues.apache.org/jira/browse/MINIFICPP-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1494: Assignee: Gabor Gyimesi > InvokeHTTP should behave in the same way as NiFi > > > Key: MINIFICPP-1494 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1494 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Ferenc Gerlits >Assignee: Gabor Gyimesi >Priority: Minor > > There are some differences between the NiFi and MiNiFi implementations of > InvokeHTTP. I suspect these are not intentional, and we should change MiNiFi > to behave in the same way as NiFi. > # When InvokeHTTP is timer-driven and the Method is GET, then NiFi does not > require an incoming flow file, but MiNiFi does. > # The NiFi version of InvokeHTTP has an output relationship called Original. > This is called Success in MiNiFi; it should probably be renamed to Original. > TODO: any others? > *These changes could break some existing flows; discuss whether this is > acceptable.* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] exceptionfactory commented on pull request #4986: NIFI-8403: Generating Self-signed cert on startup when applicable
exceptionfactory commented on pull request #4986: URL: https://github.com/apache/nifi/pull/4986#issuecomment-826933134 Thanks for making updating the logic to check password properties @gresockj, those changes look good. Do you have any additional feedback @bbende? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
lordgamez opened a new pull request #1062: URL: https://github.com/apache/nifi-minifi-cpp/pull/1062 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-8465) Correct intermittent failures in PasswordBasedEncryptorGroovyTest
[
https://issues.apache.org/jira/browse/NIFI-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332486#comment-17332486
]
Paul Grey commented on NIFI-8465:
-
Trying to bound the work here.
Since we plan to revisit EncryptContent / StreamCallback, a test case patch
seems appropriate. I have direct evidence that the PKCS7Padding false positive
is the issue. I've opened a PR that will handle the existing random failure by
directly invoking the legacy KDF logic.
I've verified the expected log output on a failure case, as well as the correct
output. While this test formerly would fail 1/256 of the time, it should now
fail only when there is an actual problem.
> Correct intermittent failures in PasswordBasedEncryptorGroovyTest
> -
>
> Key: NIFI-8465
> URL: https://issues.apache.org/jira/browse/NIFI-8465
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: Paul Grey
>Priority: Minor
> Labels: encryption, security
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{PasswordBasedEncryptorGroovyTest}} can fail intermittently during automated
> builds. A recent failure occurred when comparing encrypted and plaintext
> results:
> {quote}Error: Failures:
> Error:
> PasswordBasedEncryptorGroovyTest.testBcryptDecryptShouldSupportLegacyKeyDerivationProcess:445
> assert recovered == PLAINTEXT{quote}
> The test class should be evaluated to determine the source of the problem and
> refactored to avoid potential failures. It is also worth evaluating the
> opportunity to refactor the test into more discrete test classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] greyp9 opened a new pull request #5029: NIFI-8465; issue with legacy KDF logic
greyp9 opened a new pull request #5029:
URL: https://github.com/apache/nifi/pull/5029
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
fallback logic to prevent random test case failure
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #1017: MINIFICPP-1515 - Add integration tests testing different flowfile sizes in a simple flow
fgerlits commented on pull request #1017: URL: https://github.com/apache/nifi-minifi-cpp/pull/1017#issuecomment-826910263 > The check still shows that we do not handle the file size 2.1 GiB properly. Merge only once it is fixed. Right -- #1028 needs to be merged first, and probably its successor (which will handle `OutputStream::write`), too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1061: MINIFICPP-1549 Add automake packages to MacOS environments
lordgamez opened a new pull request #1061: URL: https://github.com/apache/nifi-minifi-cpp/pull/1061 After a [Github Actions image update](https://github.com/actions/virtual-environments/commit/1cfd4804166402f910a59d74bfc29263a669d434#diff-dec3b956a881e60d26ef4404bbc288a4c7fcbb07dd0bfa0d26cf156c8c80a1a0) automake and autoconf packages are not installed by default on the MacOS VMs. This causes a constant failure in the CI. Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-1549) MacOS builds fail with missing automake package
Gabor Gyimesi created MINIFICPP-1549: Summary: MacOS builds fail with missing automake package Key: MINIFICPP-1549 URL: https://issues.apache.org/jira/browse/MINIFICPP-1549 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Gabor Gyimesi After a Github Actions image update automake and autoconf packages are not installed by default on the MacOS VMs. This causes a constant failure in the CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MINIFICPP-1549) MacOS builds fail with missing automake package
[ https://issues.apache.org/jira/browse/MINIFICPP-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1549: Assignee: Gabor Gyimesi > MacOS builds fail with missing automake package > --- > > Key: MINIFICPP-1549 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1549 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gabor Gyimesi >Assignee: Gabor Gyimesi >Priority: Major > > After a Github Actions image update automake and autoconf packages are not > installed by default on the MacOS VMs. This causes a constant failure in the > CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NIFI-8473) REST API Documentation Missing Parameter Contexts
David Handermann created NIFI-8473: -- Summary: REST API Documentation Missing Parameter Contexts Key: NIFI-8473 URL: https://issues.apache.org/jira/browse/NIFI-8473 Project: Apache NiFi Issue Type: Bug Components: Documentation & Website Affects Versions: 1.13.2 Reporter: David Handermann Assignee: David Handermann The REST API documentation is missing a section on Parameter Contexts due to the resource not being added to the list of sections. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6826) Description in REST Api is misaligned
[
https://issues.apache.org/jira/browse/NIFI-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332451#comment-17332451
]
David Handermann commented on NIFI-6826:
There appears to be an issue with the {{summary}} class not being hidden by
default inside the {{operation}} element for this particular resource operation.
> Description in REST Api is misaligned
> -
>
> Key: NIFI-6826
> URL: https://issues.apache.org/jira/browse/NIFI-6826
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Documentation & Website
>Reporter: Andrew M. Lim
>Priority: Minor
> Attachments: nifi-6826-misalignment.png
>
>
> See attached screenshot
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] thenatog commented on pull request #3750: NIFI-4913 Added preserve.environment to read environment variables while using run.as
thenatog commented on pull request #3750: URL: https://github.com/apache/nifi/pull/3750#issuecomment-826873555 I'll check it out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #3750: NIFI-4913 Added preserve.environment to read environment variables while using run.as
joewitt commented on pull request #3750: URL: https://github.com/apache/nifi/pull/3750#issuecomment-826872619 removing stale label. we really should review this one. looks helpful and easily tested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-8236) Nifi Cluster Autoscaling on Kubernetes
[ https://issues.apache.org/jira/browse/NIFI-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332437#comment-17332437 ] Joe Witt commented on NIFI-8236: [~DamD] Obviously you'll need to speak with the vendor for their plans around whatever products they offer. As you note though the community could provide this readily deployable for the various cloud providers. Let us know if you're working on something in this regard. There have been a few different approaches to nifi on k8s within/around the community but nothing which has become 'official'. We have a number of important challenges to work in the community first. First, our tests on Github CI are unstable because the increasing limitations on available build/runners. Second, our builds are too large for releases and take too long to run. We need to focus on fixing these things. > Nifi Cluster Autoscaling on Kubernetes > -- > > Key: NIFI-8236 > URL: https://issues.apache.org/jira/browse/NIFI-8236 > Project: Apache NiFi > Issue Type: New Feature >Reporter: DEOM Damien >Priority: Major > > Nifi should be able to scale up / scale down, based on some criteria, ex: > * load-based > * schedule-based > > As an example, here is the documentation on how to autoscale Azure HDInsight > clusters: > > [https://docs.microsoft.com/en-us/azure/hdinsight/hdinsight-autoscale-clusters] > > The community could provide an official Kubernetes template, ready to be > deployed on the main cloud providers. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] cosh commented on pull request #4884: NIFI-8294 - Functional processor and service for sending flowfile content to Azur…
cosh commented on pull request #4884: URL: https://github.com/apache/nifi/pull/4884#issuecomment-826859031 Hi @sjyang18 , may I ask what's missing for this PR to be merged? the failing Ubuntu test failed because of another component which is not related to this functionality. Please clarify. thx. Cheers, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-registry] moranr commented on pull request #319: NIFIREG-395 - Implemented the ability to import and export versioned flows through the UI
moranr commented on pull request #319: URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-826853222 Hey @mtien-apache - thanks for all your work on this. @andrewmlim 's comments all make sense to me and I would proceed with his recommendations. RE the Delete button color, yes the vibrant red is intentional as Drew observed. I believe this color is also used in other "delete" scenarios, so perhaps double-check to make sure color usage is consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] Lehel44 closed pull request #4898: NIFI-8325: Improve SNMP processors
Lehel44 closed pull request #4898: URL: https://github.com/apache/nifi/pull/4898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] Lehel44 commented on pull request #4898: NIFI-8325: Improve SNMP processors
Lehel44 commented on pull request #4898: URL: https://github.com/apache/nifi/pull/4898#issuecomment-826849329 Hey, Thank you for the comments again, I opened a new PR with better version of it: https://github.com/apache/nifi/pull/5028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] Lehel44 opened a new pull request #5028: NIFI-8325: Complete SNMP refactor: SNMP GET and SET processors rework, unit tests added
Lehel44 opened a new pull request #5028:
URL: https://github.com/apache/nifi/pull/5028
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
- complete SNMP refactor
- restructured with factories, builders, configuration objects
- refined error handling, validation
- unit tests by SNMP version
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MINIFICPP-1548) Investigate merging the three rocksdb repos
Adam Debreceni created MINIFICPP-1548: - Summary: Investigate merging the three rocksdb repos Key: MINIFICPP-1548 URL: https://issues.apache.org/jira/browse/MINIFICPP-1548 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Adam Debreceni Currently we use three separate rocksdb databases: one for the FlowFileRepository one for the ContentRepository and one for the KeyValueStoreService. There is ad-hoc syncing between some of them (FFRepo and ContentRepo) which a single rocksdb instance could provide out of the box. We should investigate if utilizing a single database backend and separate column families for these three, would be viable without large-scale refactors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MINIFICPP-1548) Investigate merging the three rocksdb databases
[ https://issues.apache.org/jira/browse/MINIFICPP-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Debreceni updated MINIFICPP-1548: -- Summary: Investigate merging the three rocksdb databases (was: Investigate merging the three rocksdb repos) > Investigate merging the three rocksdb databases > --- > > Key: MINIFICPP-1548 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1548 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Adam Debreceni >Priority: Major > > Currently we use three separate rocksdb databases: one for the > FlowFileRepository one for the ContentRepository and one for the > KeyValueStoreService. There is ad-hoc syncing between some of them (FFRepo > and ContentRepo) which a single rocksdb instance could provide out of the > box. We should investigate if utilizing a single database backend and > separate column families for these three, would be viable without large-scale > refactors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] gresockj commented on a change in pull request #4988: NIFI-7870 - Fix anonymous access control for advanced UI resources
gresockj commented on a change in pull request #4988:
URL: https://github.com/apache/nifi/pull/4988#discussion_r620241802
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/NiFiCsrfTokenRepository.java
##
@@ -0,0 +1,122 @@
+/*
+ * Copyright 2012-2016 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web;
+
+
+import org.springframework.security.web.csrf.CsrfToken;
+import org.springframework.security.web.csrf.CsrfTokenRepository;
+import org.springframework.security.web.csrf.DefaultCsrfToken;
+import org.springframework.util.Assert;
+import org.springframework.util.ReflectionUtils;
+import org.springframework.util.StringUtils;
+import org.springframework.web.util.WebUtils;
+
+import javax.servlet.http.Cookie;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.lang.reflect.Method;
+
+/**
+ * A {@link CsrfTokenRepository} implementation for NiFi that matches the NiFi
Cookie JWT against the
+ * Authorization header JWT to protect against CSRF. If the request is an
idempotent method type, then only the Cookie
+ * is required to be present - this allows authenticating access to static
resources using a Cookie. If the request is a non-idempotent
+ * method, NiFi requires the Authorization header (eg. for POST requests).
+ *
+ * @author Rob Winch
+ * @since 4.1
+ */
+public final class NiFiCsrfTokenRepository implements CsrfTokenRepository {
Review comment:
Though I understand you got this implementation from something like
[CookieCsrfTokenRepository](https://github.com/spring-projects/spring-security/blob/master/web/src/main/java/org/springframework/security/web/csrf/CookieCsrfTokenRepository.java),
I wonder if it would be preferable to use a [Delegation pattern
](https://refactoring.guru/replace-inheritance-with-delegation)here instead of
reimplementing CookieCsrfTokenRepository.
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/JwtAuthenticationFilter.java
##
@@ -33,43 +32,25 @@
private static final Logger logger =
LoggerFactory.getLogger(JwtAuthenticationFilter.class);
// The Authorization header contains authentication credentials
-public static final String AUTHORIZATION = "Authorization";
-private static final Pattern tokenPattern = Pattern.compile("^Bearer
(\\S*\\.\\S*\\.\\S*)$");
+public static final String JWT_COOKIE_NAME = "__Host-jwt-auth-cookie";
Review comment:
Does this need to be public?
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-canvas.js
##
@@ -907,7 +907,7 @@
$('#current-user').text(currentUser.identity).show();
// render the logout button if there is a token
locally
Review comment:
Change the comment?
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/NiFiCsrfTokenRepository.java
##
@@ -0,0 +1,122 @@
+/*
+ * Copyright 2012-2016 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web;
+
+
+import org.springframework.security.web.csrf.CsrfToken;
+import org.springframework.security.web.csrf.CsrfTokenRepository;
+import org.springframework.security.web.csrf.DefaultCsrfToken;
+import org.springframework.util.Assert;
+import org.springframework.util.ReflectionUtils;
+import org.springframework.util.StringUtils;
+import org.springframework.web.util.WebUtils;
+
+import javax.servlet.http.Cookie;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import jav
[jira] [Commented] (NIFI-8236) Nifi Cluster Autoscaling on Kubernetes
[ https://issues.apache.org/jira/browse/NIFI-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332109#comment-17332109 ] DEOM Damien commented on NIFI-8236: --- Any news ? I've seen this : [https://www.cloudera.com/about/events/webinars/live-demo-jam-continues-next-gen-apache-nifi.html?internal_keyplay=SEC&internal_campaign=FY22-Q1_CW_AMER_Demo_Jam_EP_2021-04-22&cid=7012H01hMhtQAE&internal_link=p07] Will the open source community benefit from it, or is this vendor locked ? Thx > Nifi Cluster Autoscaling on Kubernetes > -- > > Key: NIFI-8236 > URL: https://issues.apache.org/jira/browse/NIFI-8236 > Project: Apache NiFi > Issue Type: New Feature >Reporter: DEOM Damien >Priority: Major > > Nifi should be able to scale up / scale down, based on some criteria, ex: > * load-based > * schedule-based > > As an example, here is the documentation on how to autoscale Azure HDInsight > clusters: > > [https://docs.microsoft.com/en-us/azure/hdinsight/hdinsight-autoscale-clusters] > > The community could provide an official Kubernetes template, ready to be > deployed on the main cloud providers. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests
lordgamez commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620222683
##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -307,6 +315,6 @@ TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
REQUIRE(provEventRecord->getComponentType() == processor->getName());
Review comment:
Removed unused `getCurrentFlowFile` calls in
50926ed98c23a14b8f7113563aeb887aacb6678d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests
lordgamez commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620222408
##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST",
"[httptest1]") {
REQUIRE(provEventRecord->getComponentType() == listenhttp->getName());
}
std::shared_ptr ffr = session2->get();
- REQUIRE(true == LogTestController::getInstance().contains("exiting because
method is POST"));
+ REQUIRE(true == LogTestController::getInstance().contains("Exiting because
method is POST"));
LogTestController::getInstance().reset();
}
TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
TestController testController;
-
LogTestController::getInstance().setInfo();
-
LogTestController::getInstance().setInfo();
+
LogTestController::getInstance().setDebug();
+
LogTestController::getInstance().setDebug();
LogTestController::getInstance().setInfo();
std::shared_ptr plan = testController.createPlan();
std::shared_ptr processor =
plan->addProcessor("ListenHTTP", "listenhttp", core::Relationship("No Retry",
"description"), false);
Review comment:
Updated in 2f0d785b5ca87a468f64238d669bc5a447321b01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests
aminadinari19 commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620161673
##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST",
"[httptest1]") {
REQUIRE(provEventRecord->getComponentType() == listenhttp->getName());
}
std::shared_ptr ffr = session2->get();
- REQUIRE(true == LogTestController::getInstance().contains("exiting because
method is POST"));
+ REQUIRE(true == LogTestController::getInstance().contains("Exiting because
method is POST"));
LogTestController::getInstance().reset();
}
TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
TestController testController;
-
LogTestController::getInstance().setInfo();
-
LogTestController::getInstance().setInfo();
+
LogTestController::getInstance().setDebug();
Review comment:
Ahan it makes sense now. Thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests
aminadinari19 commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620159779
##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -307,6 +315,6 @@ TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
REQUIRE(provEventRecord->getComponentType() == processor->getName());
Review comment:
Correct me if I am wrong but `record = plan->getCurrentFlowFile()` has
been done twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool
fgerlits commented on a change in pull request #1040:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r620140801
##
File path: extensions/sftp/processors/SFTPProcessorBase.cpp
##
@@ -180,7 +180,7 @@ void
SFTPProcessorBase::parseCommonPropertiesOnSchedule(const std::shared_ptrgetProperty(SendKeepaliveOnTimeout.getName(), value)) {
logger_->log_error("Send Keep Alive On Timeout attribute is missing or
invalid");
} else {
-utils::StringUtils::StringToBool(value, use_keepalive_on_timeout_);
+use_keepalive_on_timeout_ =
utils::StringUtils::toBool(value).value_or(false);
Review comment:
the `SendKeepaliveOnTimeout` property defaults to true, so this should
probably be `value_or(true)`
##
File path: extensions/mqtt/processors/PublishMQTT.cpp
##
@@ -64,7 +64,14 @@ void PublishMQTT::onSchedule(const
std::shared_ptr &contex
logger_->log_debug("PublishMQTT: max flow segment size [%" PRIu64 "]",
max_seg_size_);
}
value = "";
- if (context->getProperty(Retain.getName(), value) && !value.empty() &&
org::apache::nifi::minifi::utils::StringUtils::StringToBool(value, retain_)) {
+
+ const auto retain_parsed = [&] () -> utils::optional {
+std::string property_value;
+if (!context->getProperty(CleanSession.getName(), value)) return
utils::nullopt;
Review comment:
here too, `value` should be `property_value`
##
File path: extensions/mqtt/processors/AbstractMQTTProcessor.cpp
##
@@ -85,10 +86,17 @@ void AbstractMQTTProcessor::onSchedule(const
std::shared_ptrlog_debug("AbstractMQTTProcessor: PassWord [%s]", passWord_);
}
value = "";
- if (context->getProperty(CleanSession.getName(), value) && !value.empty() &&
- org::apache::nifi::minifi::utils::StringUtils::StringToBool(value,
cleanSession_)) {
+
+ const auto cleanSession_parsed = [&] () -> utils::optional {
+std::string property_value;
+if (!context->getProperty(CleanSession.getName(), value)) return
utils::nullopt;
Review comment:
typo: `value` should be `property_value`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests
aminadinari19 commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620151494
##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST",
"[httptest1]") {
REQUIRE(provEventRecord->getComponentType() == listenhttp->getName());
}
std::shared_ptr ffr = session2->get();
- REQUIRE(true == LogTestController::getInstance().contains("exiting because
method is POST"));
+ REQUIRE(true == LogTestController::getInstance().contains("Exiting because
method is POST"));
LogTestController::getInstance().reset();
}
TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
TestController testController;
-
LogTestController::getInstance().setInfo();
-
LogTestController::getInstance().setInfo();
+
LogTestController::getInstance().setDebug();
+
LogTestController::getInstance().setDebug();
LogTestController::getInstance().setInfo();
std::shared_ptr plan = testController.createPlan();
std::shared_ptr processor =
plan->addProcessor("ListenHTTP", "listenhttp", core::Relationship("No Retry",
"description"), false);
Review comment:
I feel like it would be better to rename it to listenhttp cos its kinda
confusing which processor it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements
szaszm commented on a change in pull request #1042:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r620142973
##
File path: libminifi/include/core/Annotation.h
##
@@ -0,0 +1,79 @@
+/**
+
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace core {
+namespace annotation {
+
+template
+struct Annotation {
+ const T value_;
Review comment:
Good point about the compile-time requirements, I didn't think about not
having the static type being the most derived type. As a runtime-friendly
alternative, we could avoid using inheritance by introducing a new virtual
function, something along the lines of `getInputRequirements() const`, or
passing the enum value to the `Processor` base constructor for storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-1502) Update processors that take their name/id constructor arguments as values
[
https://issues.apache.org/jira/browse/MINIFICPP-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Gyimesi reassigned MINIFICPP-1502:
Assignee: Gabor Gyimesi
> Update processors that take their name/id constructor arguments as values
> -
>
> Key: MINIFICPP-1502
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1502
> Project: Apache NiFi MiNiFi C++
> Issue Type: Task
>Affects Versions: 0.7.0
>Reporter: Adam Hunyadi
>Assignee: Gabor Gyimesi
>Priority: Trivial
> Labels: MiNiFi-CPP-Hygiene
> Fix For: 1.0.0
>
>
> *Background:*
> Currently, probably due to copy-pasting, many of the processors take their
> name and id arguments as values as opposed to const references.
> {code:bash|title:Signature grep}
> ➜ git --no-pager grep '(std::string name, utils::Identifier uuid =
> utils::Identifier())' | wc -l
> 46
> {code}
> *Proposal:*
> It should be a trivial change to update these signatures. One should search
> and replace the mentioned signature and check if changing it has no impact
> (eg. values are not moved from).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats
lordgamez commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r620103666
##
File path: libminifi/include/utils/ValueCaster.h
##
@@ -0,0 +1,48 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenseas/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef LIBMINIFI_INCLUDE_UTILS_VALUECASTER_H_
+#define LIBMINIFI_INCLUDE_UTILS_VALUECASTER_H_
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace utils {
+namespace internal {
+
+template
+bool cast_if_in_range(T in, U& out) {
Review comment:
I don't have any strong preference here either, so you can keep it as it
is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats
martinzink commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r620100424
##
File path: libminifi/include/utils/ValueCaster.h
##
@@ -0,0 +1,48 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenseas/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef LIBMINIFI_INCLUDE_UTILS_VALUECASTER_H_
+#define LIBMINIFI_INCLUDE_UTILS_VALUECASTER_H_
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace utils {
+namespace internal {
+
+template
+bool cast_if_in_range(T in, U& out) {
Review comment:
yeah, now I am conflicted too. I was under the impression that
freefunctions should be snake_case (while member functions should be
lowerCamelCase) but there is no documentation about this besides the mentioning
the google style guide (which uses UpperCamelCase and sometimes snake_case)
I don't have a strong preference and I am comfortable with either snake_case
or lowerCamelCase here. What is your preference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats
martinzink commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r620090718
##
File path: libminifi/include/utils/ProcessCPUUsageTracker.h
##
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifndef LIBMINIFI_INCLUDE_UTILS_PROCESSCPUUSAGETRACKER_H_
+#define LIBMINIFI_INCLUDE_UTILS_PROCESSCPUUSAGETRACKER_H_
Review comment:
fixed it in
[007a486](https://github.com/apache/nifi-minifi-cpp/pull/1032/commits/007a486268761ce8fc086dbcc5148ff1e03b0689)
##
File path: libminifi/include/utils/ProcessCPUUsageTracker.h
##
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifndef LIBMINIFI_INCLUDE_UTILS_PROCESSCPUUSAGETRACKER_H_
+#define LIBMINIFI_INCLUDE_UTILS_PROCESSCPUUSAGETRACKER_H_
+
+#if defined(__linux__) || defined(__APPLE__)
+#include
+#endif
+
+#ifdef WIN32
+#include
+#include "windows.h"
+#endif
Review comment:
fixed it in
[007a486](https://github.com/apache/nifi-minifi-cpp/pull/1032/commits/007a486268761ce8fc086dbcc5148ff1e03b0689)
##
File path: libminifi/include/utils/ProcessCPUUsageTracker.h
##
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifndef LIBMINIFI_INCLUDE_UTILS_PROCESSCPUUSAGETRACKER_H_
+#define LIBMINIFI_INCLUDE_UTILS_PROCESSCPUUSAGETRACKER_H_
+
+#if defined(__linux__) || defined(__APPLE__)
+#include
+#endif
+
+#ifdef WIN32
+#include
+#include "windows.h"
+#endif
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace utils {
+
+class ProcessCPUUsageTrackerBase {
+ public:
+ ProcessCPUUsageTrackerBase() = default;
+ virtual ~ProcessCPUUsageTrackerBase() = default;
+ virtual double getCPUUsageAndRestartCollection() = 0;
+};
+
+#if defined(__linux__) || defined(__APPLE__)
+class ProcessCPUUsageTracker : ProcessCPUUsageTrackerBase {
+ public:
+ ProcessCPUUsageTracker();
+ ~ProcessCPUUsageTracker() = default;
+ double getCPUUsageAndRestartCollection() override;
+
+ protected:
+ void queryCPUTimes();
+ bool isCurrentQueryOlderThanPrevious();
+ bool isCurrentQuerySameAsPrevious();
Review comment:
fixed it in
[007a486](https://github.com/apache/nifi-minifi-cpp/pull/1032/commits/007a486268761ce8fc086dbcc5148ff1e03b0689)
##
File path: libminifi/include/utils/ValueParser.h
##
@@ -119,6 +119,17 @@ class ValueParser {
return *this;
}
+ ValueParser& parse(double& out) {
+double result; // NOLINT
Review comment:
sure, fixed it in
[007a486](https://github.com/apache/nifi-minifi-cpp/pull/1032/commits/007a486268761ce8fc086dbcc5148ff1e03b0689)
--
This is an automated
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements
adamdebreceni commented on a change in pull request #1042:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r620066444
##
File path: libminifi/include/core/Annotation.h
##
@@ -0,0 +1,79 @@
+/**
+
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace core {
+namespace annotation {
+
+template
+struct Annotation {
+ const T value_;
Review comment:
agree with the member pollution concern, we could get rid of the
`value_` altogether by trying successive `dynamic_cast`s to `Required`,
`Allowed` and `Forbidden`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements
adam-markovics commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r620064134 ## File path: libminifi/include/core/Processor.h ## @@ -251,6 +252,10 @@ class Processor : public Connectable, public ConfigurableComponent, public std:: std::shared_ptr pickIncomingConnection() override; + virtual void validateAnnotations() const; Review comment: It's possible for specific processors to override this method. But because it's not done yet, I will remove this virtual specifier from here, it could be reintroduced later if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements
adamdebreceni commented on a change in pull request #1042:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r620063174
##
File path: libminifi/include/core/Annotation.h
##
@@ -0,0 +1,79 @@
+/**
+
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace core {
+namespace annotation {
+
+template
+struct Annotation {
+ const T value_;
Review comment:
compile-time would be a nice touch, but I don't see how could we verify
at compile-time that a processor requiring inputs actually gets some input
connections, also wouldn't this require the code to a) either cast all
processors to their most derived type b) reimplement the input requirement
validation for all processor types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements
adamdebreceni commented on a change in pull request #1042: URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r620060353 ## File path: libminifi/include/core/Processor.h ## @@ -251,6 +252,10 @@ class Processor : public Connectable, public ConfigurableComponent, public std:: std::shared_ptr pickIncomingConnection() override; + virtual void validateAnnotations() const; Review comment: are there any plans for processor-specific annotation validation making this method`virtual`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1053: MINIFICPP-1373 - Add integration tests for ConsumeKafka and test cleanup issues
lordgamez commented on pull request #1053: URL: https://github.com/apache/nifi-minifi-cpp/pull/1053#issuecomment-826603773 Do these tests cover all the test cases of `ConsumeKafkaTests.cpp`? If so can we remove that test suite? It does not run in the CI currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on pull request #1060: MINIFI-CPP-1203 - Add linter recommended missing whitespaces
hunyadi-dev commented on pull request #1060: URL: https://github.com/apache/nifi-minifi-cpp/pull/1060#issuecomment-826602868 > I'm not a fan of space before the colon in range-based for loops. > Why does the linter check pass without these changes? Are these rules disabled? 1. I am not a fan either, but this is a listed rule in the [google style guide](https://google.github.io/styleguide/cppguide.html#Horizontal_Whitespace). 2. Yes, these files are not yet checked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1060: MINIFI-CPP-1203 - Add linter recommended missing whitespaces
hunyadi-dev commented on a change in pull request #1060:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1060#discussion_r620056414
##
File path: extensions/windows-event-log/wel/WindowsEventLog.h
##
@@ -87,36 +87,36 @@ class WindowsEventLogMetadata {
static std::string getMetadataString(METADATA val) {
static std::map< METADATA, std::string> map = {
{LOG_NAME, "LOG_NAME" },
-{SOURCE,"SOURCE"},
-{TIME_CREATED,"TIME_CREATED" },
-{EVENTID,"EVENTID"},
-{OPCODE,"OPCODE"},
-{EVENT_RECORDID,"EVENT_RECORDID"},
-{EVENT_TYPE,"EVENT_TYPE"},
+{SOURCE, "SOURCE"},
+{TIME_CREATED, "TIME_CREATED" },
+{EVENTID, "EVENTID"},
+{OPCODE, "OPCODE"},
+{EVENT_RECORDID, "EVENT_RECORDID"},
+{EVENT_TYPE, "EVENT_TYPE"},
{TASK_CATEGORY, "TASK_CATEGORY"},
-{LEVEL,"LEVEL"},
-{KEYWORDS,"KEYWORDS"},
-{USER,"USER"},
-{COMPUTER,"COMPUTER"}
+{LEVEL, "LEVEL"},
+{KEYWORDS, "KEYWORDS"},
+{USER, "USER"},
+{COMPUTER, "COMPUTER"}
Review comment:
Good catch, It was an issue with my replacement script, I figured that
if there was no space after a comma in any reported line, there should be, but
this was a wrong assumption.
##
File path: extensions/windows-event-log/wel/WindowsEventLog.h
##
@@ -87,36 +87,36 @@ class WindowsEventLogMetadata {
static std::string getMetadataString(METADATA val) {
static std::map< METADATA, std::string> map = {
{LOG_NAME, "LOG_NAME" },
-{SOURCE,"SOURCE"},
-{TIME_CREATED,"TIME_CREATED" },
-{EVENTID,"EVENTID"},
-{OPCODE,"OPCODE"},
-{EVENT_RECORDID,"EVENT_RECORDID"},
-{EVENT_TYPE,"EVENT_TYPE"},
+{SOURCE, "SOURCE"},
+{TIME_CREATED, "TIME_CREATED" },
+{EVENTID, "EVENTID"},
+{OPCODE, "OPCODE"},
+{EVENT_RECORDID, "EVENT_RECORDID"},
+{EVENT_TYPE, "EVENT_TYPE"},
{TASK_CATEGORY, "TASK_CATEGORY"},
-{LEVEL,"LEVEL"},
-{KEYWORDS,"KEYWORDS"},
-{USER,"USER"},
-{COMPUTER,"COMPUTER"}
+{LEVEL, "LEVEL"},
+{KEYWORDS, "KEYWORDS"},
+{USER, "USER"},
+{COMPUTER, "COMPUTER"}
};
return map[val];
}
static METADATA getMetadataFromString(const std::string &val) {
static std::map< std::string, METADATA> map = {
-{"LOG_NAME",LOG_NAME},
-{"SOURCE",SOURCE},
-{"TIME_CREATED",TIME_CREATED },
-{"EVENTID",EVENTID},
-{"OPCODE",OPCODE},
-{"EVENT_RECORDID",EVENT_RECORDID},
+{"LOG_NAME", LOG_NAME},
+{"SOURCE", SOURCE},
+{"TIME_CREATED", TIME_CREATED },
+{"EVENTID", EVENTID},
+{"OPCODE", OPCODE},
+{"EVENT_RECORDID", EVENT_RECORDID},
{"TASK_CATEGORY", TASK_CATEGORY},
-{"EVENT_TYPE",EVENT_TYPE},
-{"LEVEL",LEVEL},
-{"KEYWORDS",KEYWORDS},
-{"USER",USER},
-{"COMPUTER",COMPUTER}
+{"EVENT_TYPE", EVENT_TYPE},
+{"LEVEL", LEVEL},
+{"KEYWORDS", KEYWORDS},
+{"USER", USER},
+{"COMPUTER", COMPUTER}
Review comment:
same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests
lordgamez commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620055279
##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST",
"[httptest1]") {
REQUIRE(provEventRecord->getComponentType() == listenhttp->getName());
}
std::shared_ptr ffr = session2->get();
- REQUIRE(true == LogTestController::getInstance().contains("exiting because
method is POST"));
+ REQUIRE(true == LogTestController::getInstance().contains("Exiting because
method is POST"));
LogTestController::getInstance().reset();
}
TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
TestController testController;
-
LogTestController::getInstance().setInfo();
-
LogTestController::getInstance().setInfo();
+
LogTestController::getInstance().setDebug();
Review comment:
In the test we are checking for "Exiting because method is POST" log
message which is a debug log, so we have to modify the log level to be able to
assert on that. It was probably an info level log previously and changed later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1060: MINIFI-CPP-1203 - Add linter recommended missing whitespaces
hunyadi-dev commented on a change in pull request #1060:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1060#discussion_r620054454
##
File path: extensions/sftp/tests/PutSFTPTests.cpp
##
@@ -809,7 +809,7 @@ TEST_CASE_METHOD(PutSFTPTestsFixture, "PutSFTP batching
does not fail even if on
}
TEST_CASE_METHOD(PutSFTPTestsFixture, "PutSFTP put large file", "[PutSFTP]") {
- std::mt19937 rng(std::random_device{}());
+ std::mt19937 rng(std::random_device {}());
Review comment:
I replaced it with `// NOLINT` but I am not sure it helps readibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] aminadinari19 commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests
aminadinari19 commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620052349
##
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##
@@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST",
"[httptest1]") {
REQUIRE(provEventRecord->getComponentType() == listenhttp->getName());
}
std::shared_ptr ffr = session2->get();
- REQUIRE(true == LogTestController::getInstance().contains("exiting because
method is POST"));
+ REQUIRE(true == LogTestController::getInstance().contains("Exiting because
method is POST"));
LogTestController::getInstance().reset();
}
TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
TestController testController;
-
LogTestController::getInstance().setInfo();
-
LogTestController::getInstance().setInfo();
+
LogTestController::getInstance().setDebug();
Review comment:
Why is it better to set it to Debug level from info level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #3511: NIFI-6175 Spark Livy - Improving Livy
github-actions[bot] commented on pull request #3511: URL: https://github.com/apache/nifi/pull/3511#issuecomment-826171173 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #3905: adding openId support in configuration file
github-actions[bot] commented on pull request #3905: URL: https://github.com/apache/nifi/pull/3905#issuecomment-826171016 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #3896: NIFI-6881 - Add JDBC AtomicDistributedMapCacheClient
github-actions[bot] commented on pull request #3896: URL: https://github.com/apache/nifi/pull/3896#issuecomment-826171024 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4036: NIFI-7099: AbstractDatabaseLookupService: Add new option to use a Select Statement alternatively to table name and key column
github-actions[bot] commented on pull request #4036: URL: https://github.com/apache/nifi/pull/4036#issuecomment-826170949 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] tolaini commented on pull request #5026: NIFI-8470
tolaini commented on pull request #5026: URL: https://github.com/apache/nifi/pull/5026#issuecomment-826119347 > Hey @tolaini the change looks good to me, but the base branch needs to be `main`, not `support/nifi-1.13`. Can you change that? If we do end up doing another 1.13.x release, it can get pulled over then as apart of that release process. Hi, I have created PR #5027 rebased to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #3616: NIFI-6501: Add config to limit buffer queue size in CaptureChangeMySQL
github-actions[bot] commented on pull request #3616: URL: https://github.com/apache/nifi/pull/3616#issuecomment-826171131 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4385: NIFI-7600 - Defining JMS attribute types breaks due to invalid charac…
github-actions[bot] commented on pull request #4385: URL: https://github.com/apache/nifi/pull/4385#issuecomment-826170743 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4175: NIFI-7307 - Add User Metadata support to the Azure Blob Processors + LookupService
github-actions[bot] commented on pull request #4175: URL: https://github.com/apache/nifi/pull/4175#issuecomment-826170860 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4355: QueryElasticsearchHttp to support nested JSON objects
github-actions[bot] commented on pull request #4355: URL: https://github.com/apache/nifi/pull/4355#issuecomment-826170752 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #3921: add or replace properties in nifi.properties by environment variable
github-actions[bot] commented on pull request #3921: URL: https://github.com/apache/nifi/pull/3921#issuecomment-826171007 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4059: NIFI-7098 - Added count file count information in ListSFTP processor
github-actions[bot] commented on pull request #4059: URL: https://github.com/apache/nifi/pull/4059#issuecomment-826170932 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #3388: NIFI-1693
github-actions[bot] commented on pull request #3388: URL: https://github.com/apache/nifi/pull/3388#issuecomment-826171193 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4310: NIFI-7498 Adding unique prefix to every swagger operationId
github-actions[bot] commented on pull request #4310: URL: https://github.com/apache/nifi/pull/4310#issuecomment-826170794 We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
