[jira] [Assigned] (NIFI-9142) Refactor nifi-ranger-bundle to use JUnit 5

2021-09-03 Thread Mike Thomsen (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Thomsen reassigned NIFI-9142:
--

Assignee: Mike Thomsen

> Refactor nifi-ranger-bundle to use JUnit 5
> --
>
> Key: NIFI-9142
> URL: https://issues.apache.org/jira/browse/NIFI-9142
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (NIFI-9136) Refactor nifi-network-bundle to use JUnit 5

2021-09-03 Thread Mike Thomsen (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Thomsen reassigned NIFI-9136:
--

Assignee: Mike Thomsen

> Refactor nifi-network-bundle to use JUnit 5
> ---
>
> Key: NIFI-9136
> URL: https://issues.apache.org/jira/browse/NIFI-9136
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (NIFI-9135) Refactor nifi-mqtt-bundle to use JUnit 5

2021-09-03 Thread Mike Thomsen (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Thomsen reassigned NIFI-9135:
--

Assignee: Mike Thomsen

> Refactor nifi-mqtt-bundle to use JUnit 5
> 
>
> Key: NIFI-9135
> URL: https://issues.apache.org/jira/browse/NIFI-9135
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (NIFI-9194) Upsert for Oracle12+

2021-09-03 Thread ROBERTO SANTOS (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ROBERTO SANTOS updated NIFI-9194:
-
 Flags: Important
Remaining Estimate: 168h  (was: 48h)
 Original Estimate: 168h  (was: 48h)

> Upsert for Oracle12+
> 
>
> Key: NIFI-9194
> URL: https://issues.apache.org/jira/browse/NIFI-9194
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework
>Affects Versions: 1.14.0
> Environment: All OS
>Reporter: ROBERTO SANTOS
>Priority: Major
>  Labels: features
> Fix For: 1.15.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I have implemented Upsert capability for Oracle12+ in PutDatabaseRecord and 
> it’s Unity tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (NIFI-9134) Refactor nifi-metrics-reporting-bundle to use JUnit 5

2021-09-03 Thread Mike Thomsen (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Thomsen reassigned NIFI-9134:
--

Assignee: Mike Thomsen

> Refactor nifi-metrics-reporting-bundle to use JUnit 5
> -
>
> Key: NIFI-9134
> URL: https://issues.apache.org/jira/browse/NIFI-9134
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (NIFI-9133) Refactor nifi-media-bundle to use JUnit 5

2021-09-03 Thread Mike Thomsen (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Thomsen reassigned NIFI-9133:
--

Assignee: Mike Thomsen

> Refactor nifi-media-bundle to use JUnit 5
> -
>
> Key: NIFI-9133
> URL: https://issues.apache.org/jira/browse/NIFI-9133
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (NIFI-9132) Refactor nifi-lumberjack-bundle to use JUnit 5

2021-09-03 Thread Mike Thomsen (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Thomsen reassigned NIFI-9132:
--

Assignee: Mike Thomsen

> Refactor nifi-lumberjack-bundle to use JUnit 5
> --
>
> Key: NIFI-9132
> URL: https://issues.apache.org/jira/browse/NIFI-9132
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (NIFI-9131) Refactor nifi-ldap-iaa-providers-bundle to use JUnit 5

2021-09-03 Thread Mike Thomsen (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Thomsen resolved NIFI-9131.

Resolution: Won't Do

It would require building a lot of test scaffolding for this to work and that 
bleeds heavily into work that should be done by the Apache DS project to update 
their test code. We might revisit later.

> Refactor nifi-ldap-iaa-providers-bundle to use JUnit 5
> --
>
> Key: NIFI-9131
> URL: https://issues.apache.org/jira/browse/NIFI-9131
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (NIFI-9130) Refactor nifi-language-translation-bundle to use JUnit 5

2021-09-03 Thread Mike Thomsen (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Thomsen reassigned NIFI-9130:
--

Assignee: Mike Thomsen

> Refactor nifi-language-translation-bundle to use JUnit 5
> 
>
> Key: NIFI-9130
> URL: https://issues.apache.org/jira/browse/NIFI-9130
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (NIFI-9194) Upsert for Oracle12+

2021-09-03 Thread ROBERTO SANTOS (Jira)
ROBERTO SANTOS created NIFI-9194:


 Summary: Upsert for Oracle12+
 Key: NIFI-9194
 URL: https://issues.apache.org/jira/browse/NIFI-9194
 Project: Apache NiFi
  Issue Type: New Feature
  Components: Core Framework
Affects Versions: 1.14.0
 Environment: All OS
Reporter: ROBERTO SANTOS
 Fix For: 1.15.0


I have implemented Upsert capability for Oracle12+ in PutDatabaseRecord and 
it’s Unity tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (NIFI-9129) Refactor nifi-kudu-bundle to use JUnit 5

2021-09-03 Thread Mike Thomsen (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Thomsen reassigned NIFI-9129:
--

Assignee: Mike Thomsen

> Refactor nifi-kudu-bundle to use JUnit 5
> 
>
> Key: NIFI-9129
> URL: https://issues.apache.org/jira/browse/NIFI-9129
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (NIFI-9193) Generateflowfile must be able to run on a single node

2021-09-03 Thread Dennis Jaheruddin (Jira)
Dennis Jaheruddin created NIFI-9193:
---

 Summary: Generateflowfile must be able to run on a single node
 Key: NIFI-9193
 URL: https://issues.apache.org/jira/browse/NIFI-9193
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework
Affects Versions: 1.14.0
Reporter: Dennis Jaheruddin


If I understand the release notes of 1.14 correctly the option has been removed 
to set processors without incoming connections to run on the primary node.

I understand that the primary node should be used for lightweight things that 
must only be done once, like listing, and therefore that there should hardly be 
a reason to allow other processors to run as such.

However, I believe the GenerateFlowFile processor is a special case, its main 
purpose is testing or simulating, and it is very convenient when there is no 
outside connection available, to develop or test something. 

As such, the GenerateFlowFile processor should be allowed to run on the primary 
node, so it may substitute any processor (or set of processors) during 
development.

Alternately (or in addition) it may make sense to at least allow this to run on 
a single node, but for most consistency it would be good to allow for Primary 
node running. 

 

 

There may be ways to achieve a similar result (e.g. routing its output to 
single node and then throttling) but this is quite awkward.

This issue is mostly about being able what we were able to do before. However, 
there is an additional benefit in that now autoscaling is becoming more 
dominant, and it is also very convenient to test autoscaling if you can 
predictably generate an amount of flowfiles (withouth having the generator 
scale up when the nodes scale up).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [nifi] exceptionfactory commented on a change in pull request #5358: NIFI-9185 dd Avro logical type to SelectHive3QL processor

2021-09-03 Thread GitBox


exceptionfactory commented on a change in pull request #5358:
URL: https://github.com/apache/nifi/pull/5358#discussion_r702030424



##
File path: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/test/java/org/apache/nifi/processors/hive/TestSelectHive3QL.java
##
@@ -690,6 +698,114 @@ public void testMaxRowsPerFlowFileWithMaxFragments() 
throws ClassNotFoundExcepti
 runner.clearTransferState();
 }
 
+@Test
+public void testAvroRecordCreatedWithoutLogicalTypesByDefault() throws 
SQLException, IOException {
+final Schema expectedSchema = 
SchemaBuilder.record("NiFi_SelectHiveQL_Record").namespace("any.data").fields()
+
.name("ID").type().unionOf().nullBuilder().endNull().and().intType().endUnion().noDefault()
+
.name("NAME").type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault()
+
.name("BIRTH_DATE").type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault()
+
.name("BIG_NUMBER").type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault()
+
.name("CREATED_ON").type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault()
+.endRecord();
+final int expectedId = 1;
+final String expectedName = "Joe Smith";
+final String expectedBirthDate = "1956-11-22";
+final String expectedBigNumber = "12345678.12";
+final String expectedCreatedOn = "1962-09-23 03:23:34.234";
+
+// load test data to database
+final Connection con = ((DBCPService) 
runner.getControllerService("dbcp")).getConnection();
+final Statement stmt = con.createStatement();
+final InputStream in;
+final MockFlowFile mff;
+
+try {
+stmt.execute("drop table TEST_QUERY_DB_TABLE");
+} catch (final SQLException sqle) {
+// Ignore this error, probably a "table does not exist" since 
Derby doesn't yet support DROP IF EXISTS [DERBY-4842]
+}
+
+stmt.execute("create table TEST_QUERY_DB_TABLE (id integer not null, 
name varchar(100), birth_date date, big_number decimal(10,2),created_on 
timestamp)");
+stmt.execute("insert into TEST_QUERY_DB_TABLE (id, name, birth_date, 
big_number, created_on) VALUES (1, 'Joe Smith', '1956-11-22', 12345678.12, 
'1962-09-23 03:23:34.234')");
+
+runner.setIncomingConnection(false);
+runner.setProperty(SelectHive3QL.HIVEQL_SELECT_QUERY, "SELECT * FROM 
TEST_QUERY_DB_TABLE");
+
+runner.run();
+
+runner.assertAllFlowFilesTransferred(SelectHive3QL.REL_SUCCESS, 1);
+mff = 
runner.getFlowFilesForRelationship(SelectHive3QL.REL_SUCCESS).get(0);
+in = new ByteArrayInputStream(mff.toByteArray());
+
+final GenericRecord record = getFirstRecordFromStream(in);
+
+assertEquals(expectedSchema, record.getSchema());
+assertEquals(expectedId, record.get("ID"));
+assertEquals(expectedName, record.get("NAME").toString());
+assertEquals(expectedBirthDate, record.get("BIRTH_DATE").toString());
+assertEquals(expectedBigNumber, record.get("BIG_NUMBER").toString());
+assertEquals(expectedCreatedOn, record.get("CREATED_ON").toString());
+
+runner.clearTransferState();
+}
+
+@Test
+public void testAvroRecordCreatedWithLogicalTypesWhenSet() throws 
SQLException, IOException {
+final Schema expectedSchema = 
SchemaBuilder.record("NiFi_SelectHiveQL_Record").namespace("any.data").fields()
+
.name("ID").type().unionOf().nullBuilder().endNull().and().intType().endUnion().noDefault()
+
.name("NAME").type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault()
+
.name("BIRTH_DATE").type().unionOf().nullBuilder().endNull().and()
+
.type(LogicalTypes.date().addToSchema(Schema.create(Schema.Type.INT))).endUnion().noDefault()
+
.name("BIG_NUMBER").type().unionOf().nullBuilder().endNull().and()
+.type(LogicalTypes.decimal(10, 
2).addToSchema(Schema.create(Schema.Type.BYTES))).endUnion().noDefault()
+
.name("CREATED_ON").type().unionOf().nullBuilder().endNull().and()
+
.type(LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG))).endUnion().noDefault()
+.endRecord();
+final int expectedId = 1;
+final String expectedName = "Joe Smith";
+final int expectedBirthDate = (int) 
LocalDate.parse("1956-11-22").toEpochDay();
+final BigDecimal decimal = new BigDecimal("12345678.12").setScale(2, 
BigDecimal.ROUND_HALF_EVEN);
+final ByteBuffer expectedBigNumber = 
ByteBuffer.wrap(decimal.unscaledValue().toByteArray());
+final long expectedCreatedOn = 

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5358: NIFI-9185 dd Avro logical type to SelectHive3QL processor

2021-09-03 Thread GitBox


exceptionfactory commented on a change in pull request #5358:
URL: https://github.com/apache/nifi/pull/5358#discussion_r702030424



##
File path: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/test/java/org/apache/nifi/processors/hive/TestSelectHive3QL.java
##
@@ -690,6 +698,114 @@ public void testMaxRowsPerFlowFileWithMaxFragments() 
throws ClassNotFoundExcepti
 runner.clearTransferState();
 }
 
+@Test
+public void testAvroRecordCreatedWithoutLogicalTypesByDefault() throws 
SQLException, IOException {
+final Schema expectedSchema = 
SchemaBuilder.record("NiFi_SelectHiveQL_Record").namespace("any.data").fields()
+
.name("ID").type().unionOf().nullBuilder().endNull().and().intType().endUnion().noDefault()
+
.name("NAME").type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault()
+
.name("BIRTH_DATE").type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault()
+
.name("BIG_NUMBER").type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault()
+
.name("CREATED_ON").type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault()
+.endRecord();
+final int expectedId = 1;
+final String expectedName = "Joe Smith";
+final String expectedBirthDate = "1956-11-22";
+final String expectedBigNumber = "12345678.12";
+final String expectedCreatedOn = "1962-09-23 03:23:34.234";
+
+// load test data to database
+final Connection con = ((DBCPService) 
runner.getControllerService("dbcp")).getConnection();
+final Statement stmt = con.createStatement();
+final InputStream in;
+final MockFlowFile mff;
+
+try {
+stmt.execute("drop table TEST_QUERY_DB_TABLE");
+} catch (final SQLException sqle) {
+// Ignore this error, probably a "table does not exist" since 
Derby doesn't yet support DROP IF EXISTS [DERBY-4842]
+}
+
+stmt.execute("create table TEST_QUERY_DB_TABLE (id integer not null, 
name varchar(100), birth_date date, big_number decimal(10,2),created_on 
timestamp)");
+stmt.execute("insert into TEST_QUERY_DB_TABLE (id, name, birth_date, 
big_number, created_on) VALUES (1, 'Joe Smith', '1956-11-22', 12345678.12, 
'1962-09-23 03:23:34.234')");
+
+runner.setIncomingConnection(false);
+runner.setProperty(SelectHive3QL.HIVEQL_SELECT_QUERY, "SELECT * FROM 
TEST_QUERY_DB_TABLE");
+
+runner.run();
+
+runner.assertAllFlowFilesTransferred(SelectHive3QL.REL_SUCCESS, 1);
+mff = 
runner.getFlowFilesForRelationship(SelectHive3QL.REL_SUCCESS).get(0);
+in = new ByteArrayInputStream(mff.toByteArray());
+
+final GenericRecord record = getFirstRecordFromStream(in);
+
+assertEquals(expectedSchema, record.getSchema());
+assertEquals(expectedId, record.get("ID"));
+assertEquals(expectedName, record.get("NAME").toString());
+assertEquals(expectedBirthDate, record.get("BIRTH_DATE").toString());
+assertEquals(expectedBigNumber, record.get("BIG_NUMBER").toString());
+assertEquals(expectedCreatedOn, record.get("CREATED_ON").toString());
+
+runner.clearTransferState();
+}
+
+@Test
+public void testAvroRecordCreatedWithLogicalTypesWhenSet() throws 
SQLException, IOException {
+final Schema expectedSchema = 
SchemaBuilder.record("NiFi_SelectHiveQL_Record").namespace("any.data").fields()
+
.name("ID").type().unionOf().nullBuilder().endNull().and().intType().endUnion().noDefault()
+
.name("NAME").type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault()
+
.name("BIRTH_DATE").type().unionOf().nullBuilder().endNull().and()
+
.type(LogicalTypes.date().addToSchema(Schema.create(Schema.Type.INT))).endUnion().noDefault()
+
.name("BIG_NUMBER").type().unionOf().nullBuilder().endNull().and()
+.type(LogicalTypes.decimal(10, 
2).addToSchema(Schema.create(Schema.Type.BYTES))).endUnion().noDefault()
+
.name("CREATED_ON").type().unionOf().nullBuilder().endNull().and()
+
.type(LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG))).endUnion().noDefault()
+.endRecord();
+final int expectedId = 1;
+final String expectedName = "Joe Smith";
+final int expectedBirthDate = (int) 
LocalDate.parse("1956-11-22").toEpochDay();
+final BigDecimal decimal = new BigDecimal("12345678.12").setScale(2, 
BigDecimal.ROUND_HALF_EVEN);
+final ByteBuffer expectedBigNumber = 
ByteBuffer.wrap(decimal.unscaledValue().toByteArray());
+final long expectedCreatedOn = 

[jira] [Commented] (NIFI-7899) InvokeHTTP does not timeout

2021-09-03 Thread Abdelrahim Ahmad (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409566#comment-17409566
 ] 

Abdelrahim Ahmad commented on NIFI-7899:


Hi All,
I have exactly the same issue with Version 1.12.1. the process works for a 
couple of days and then hangs. I have to terminate the process in order to stop 
it and if started again it doesn't work at all.

the workaround I do:
 * Eather to stop the process each around 1 day and start it again (before it 
hangs).
 * or I replace the process with a new copy of it (when it hangs and does not 
work).

BR
Abdelrahim Ahmad

> InvokeHTTP does not timeout
> ---
>
> Key: NIFI-7899
> URL: https://issues.apache.org/jira/browse/NIFI-7899
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.11.4
> Environment: Ubuntu 18.04. Nifi 1.11.4.
> 4 core, 8GB mem. Java set to 4GB mem
>Reporter: Jens M Kofoed
>Priority: Major
>
> We have some issues with the InvokeHTTP process. It "randomly" hangs in the 
> process without timing out. The processor shows that there are 1 task running 
> (upper right corner) and it can runs for hours without any outputs, but with 
> multiply flowfiles in the queue.
> Trying to stop it takes forever so I have to terminate it. restart the 
> processor and everything works fine for a long time. until next time it hangs.
> Our configuration of the process is as follow:
>  Penalty: 30s, Yield: 1s,
>  Scheduling: timer driven, Concurrent Task: 1, Run Schedule: 0, Run duration: > 0
> HTTP Method: GET
> Connection timeout: 5s
> Read timeout: 15s
> Idle Timeout: 5m
> Max idle Connection: 5
> I could not find any other bug reports here. but there are other people 
> metion same issues:
> [https://webcache.googleusercontent.com/search?q=cache:LMqcymQiM-IJ:https://community.cloudera.com/t5/Support-Questions/InvokeHTTP-randomly-hangs/td-p/296184+=1=da=clnk=dk]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [nifi] pgyori opened a new pull request #5365: NIFI-9192: ResultSetRecordSet considers value of useLogicalTypes flag…

2021-09-03 Thread GitBox


pgyori opened a new pull request #5365:
URL: https://github.com/apache/nifi/pull/5365


   … when determining the object's schema.
   
   Signed-off-by: Peter Gyori 
   
   
   
   https://issues.apache.org/jira/browse/NIFI-9192
   
    Description of PR
   
   Introduces the useLogicalTypes flag to the ResultSetRecordSet and implements 
the logic in ResultSetRecordSet that considers the flag's value when 
determining the schema for the object that gets created.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [ ] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (NIFI-9192) Value of QueryDatabaseTableRecord's "Use Avro Logical Types" property ignored when determining the schema of the recordset

2021-09-03 Thread Peter Gyori (Jira)
Peter Gyori created NIFI-9192:
-

 Summary: Value of QueryDatabaseTableRecord's "Use Avro Logical 
Types" property ignored when determining the schema of the recordset
 Key: NIFI-9192
 URL: https://issues.apache.org/jira/browse/NIFI-9192
 Project: Apache NiFi
  Issue Type: Bug
  Components: Extensions
Reporter: Peter Gyori
Assignee: Peter Gyori


In RecordSqlWriter, the avro schema is determined using this:
{code:java}
final Schema avroSchema = JdbcCommon.createSchema(resultSet, options);{code}
Here, in 'options' the value of "Use Avro Logical Types" is passed and taken 
into consideration. This avroSchema is used to create the recordAvroSchema, 
which is OK:
{code:java}
final RecordSchema recordAvroSchema = 
AvroTypeUtil.createSchema(avroSchema);{code}
*However*, when creating the fullRecordSet object (which contains the schema as 
well, the creation:
{code:java}
fullRecordSet = new ResultSetRecordSetWithCallback(resultSet, recordAvroSchema, 
callback, options.getDefaultPrecision(), options.getDefaultScale()){code}
does not consider the value of the useLogicalTypes flag since it is not passed 
to the constructor. recordAvroSchema was created considering the value of the 
flag, and is passed to the constructor but *the settings in this schema are 
overridden during the ResultSetRecordSet creation*, where a schema is created 
based on the metadata received from the database.

As a result, if we have "Use Avro Logical Types" set to false, and we have a 
column in an Oracle DB table (for the sake of this example) that is of type 
NUMBER, the resulting avro shcema is:
{code:java}
"type" : {
  "type" : "bytes",
  "logicalType" : "decimal",
  "precision" : 10,
  "scale" : 0
}
{code}
which unfortunately contains logical avro type.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (NIFI-8899) Add version info to the UI

2021-09-03 Thread Tim Smith (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-8899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Smith reassigned NIFI-8899:
---

Assignee: Tim Smith

> Add version info to the UI
> --
>
> Key: NIFI-8899
> URL: https://issues.apache.org/jira/browse/NIFI-8899
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: NiFi Registry
>Reporter: Mark Bean
>Assignee: Tim Smith
>Priority: Major
>
> Currently, the UI does not present the current version of NiFi Registry. This 
> information should be available through an "about" menu item and included on 
> the documentation pages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (NIFI-9191) Add NiFi version in about tab on component UIs and documentation.

2021-09-03 Thread Tim Smith (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409465#comment-17409465
 ] 

Tim Smith commented on NIFI-9191:
-

This is a duplicate , see https://issues.apache.org/jira/browse/NIFI-8899, and 
needs to be closed.

> Add NiFi version  in about tab on component UIs and documentation.
> --
>
> Key: NIFI-9191
> URL: https://issues.apache.org/jira/browse/NIFI-9191
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Tim Smith
>Priority: Minor
>
> For convenience, especially when using multiple versions of nars, the ability 
> to reference the current NiFi version in the component UI and usage 
> documentation, would be useful.  A new tab on the component UI "about" to 
> display the running NiFi version and displaying on usage documentation would 
> enhance user experience.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (NIFI-9191) Add NiFi version in about tab on component UIs and documentation.

2021-09-03 Thread Tim Smith (Jira)
Tim Smith created NIFI-9191:
---

 Summary: Add NiFi version  in about tab on component UIs and 
documentation.
 Key: NIFI-9191
 URL: https://issues.apache.org/jira/browse/NIFI-9191
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Tim Smith


For convenience, especially when using multiple versions of nars, the ability 
to reference the current NiFi version in the component UI and usage 
documentation, would be useful.  A new tab on the component UI "about" to 
display the running NiFi version and displaying on usage documentation would 
enhance user experience.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)