[jira] [Created] (NIFI-9830) Add Stateless NiFi option to delete extension NARs after unpacking

2022-03-23 Thread Joe Gresock (Jira)
Joe Gresock created NIFI-9830:
-

 Summary: Add Stateless NiFi option to delete extension NARs after 
unpacking
 Key: NIFI-9830
 URL: https://issues.apache.org/jira/browse/NIFI-9830
 Project: Apache NiFi
  Issue Type: Improvement
  Components: NiFi Stateless
Reporter: Joe Gresock


To cover some use cases where disk space may be limited, we could allow the 
Stateless Engine to delete extension NARs after unpacking.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi] Lehel44 commented on a change in pull request #5888: NIFI-7230: Created toInstant() and formatInstant() EL functions

2022-03-23 Thread GitBox


Lehel44 commented on a change in pull request #5888:
URL: https://github.com/apache/nifi/pull/5888#discussion_r833828735



##
File path: nifi-docs/src/main/asciidoc/expression-language-guide.adoc
##
@@ -2264,6 +2296,33 @@ chaining together the two functions: 
`${date:toDate('MM-dd-'):format('/M
 
 
 
+[.function]
+=== toInstant
+
+*Description*: [.description]#Converts a String or Number into an Instant data 
type, based on the format specified by the argument. The argument
+must be a String that is a valid Java DateTimeFormatter syntax. The Subject is 
expected to be a String that is formatted
+according the argument or a number which represents the datetime in 
milliseconds. The datetime will be evaluated using the local time zone unless
+specified in the second optional argument.#
+
+*Subject Type*: [.subject]#String or Number#
+
+*Arguments*:
+
+- [.argName]#_format_# : [.argDesc]#The current format to use when parsing the 
Subject, in the Java DateTimeFormatter syntax.#
+- [.argName]#_time zone_# : [.argDesc]#Optional argument that specifies the 
time zone to use when parsing the Subject, in the Java TimeZone syntax.#
+
+
+*Return Type*: [.returnType]#Instant#
+
+*Examples*: If the attribute "time" has the value "2014/12/31 15:36:03.264Z" 
then the expression `${time:toDate("/MM/dd HH:mm:ss.SSS'Z'", "GMT")}` will 
result in a Date data type for

Review comment:
   That's right!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] patalwell closed pull request #5894: NiFi-9817 Add a Validator for the PutCloudWatchMetric Processor's Unit Parameter

2022-03-23 Thread GitBox


patalwell closed pull request #5894:
URL: https://github.com/apache/nifi/pull/5894


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] github-actions[bot] closed pull request #5381: NIFI-9206: Add RemoveRecordField processor and implement the ability …

2022-03-23 Thread GitBox


github-actions[bot] closed pull request #5381:
URL: https://github.com/apache/nifi/pull/5381


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (NIFI-8472) New processors for data persistence of NGSI events in different Data Storage Systems

2022-03-23 Thread Joe Witt (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Witt resolved NIFI-8472.

Resolution: Information Provided

The conversation on the PR was to push these artifacts to some public location 
and we'll update our wiki to tell folks it exists.  Easier for all parties 
involved this way and helps the ngsi processors still progress.

> New processors for data persistence of NGSI events in different Data Storage 
> Systems
> 
>
> Key: NIFI-8472
> URL: https://issues.apache.org/jira/browse/NIFI-8472
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework
>Reporter: José Andrés Muñoz Arcentales
>Assignee: José Andrés Muñoz Arcentales
>Priority: Major
>  Labels: pull-request-available
> Attachments: image-2021-04-25-16-01-17-862.png
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> This implementation is intended to provide the capability to manage NGSI 
> events inside of NiFi. This Initiative is fully supported by FIWARE 
> community. FIWARE brings a curated framework of open source software platform 
> components which can be assembled together and with other third-party 
> components to build platforms that support the development of Smart Solutions 
> faster, easier and cheaper. Supplying a cornerstone function required in any 
> smart solution: the need to manage context information, enabling to perform 
> updates and bring access to context.
> Regarding NGSI, it is the API exported by a FIWARE Context Broker, used for 
> the integration of platform components within a “Powered by FIWARE” platform 
> and by applications to update or consume context information. [+FIWARE NGSI 
> API specifications+|http://fiware.github.io/specifications/ngsiv2/stable/] 
> have evolved over time, currently matching NGSIv2 specifications but evolving 
> to align with the [+ETSI NGSI-LD 
> standard+|https://www.etsi.org/committee/cim]. The FIWARE Community plays an 
> active role in the evolution of ETSI NGSI-LD specifications which were based 
> on NGSIv2 and commits to deliver compatible open-source implementations of 
> the specs.
> The implementation proposed here is intended to provide an alternative data 
> persistence mechanism for managing the history of context in different 
> databases like PostgreSQL, MySQL, MongoDB, or AWS DynamoDB. It was 
> materialized as a Generic Enabler called 
> [Draco|https://github.com/ging/fiware-draco/] and it is used for a 
> considerable number of people. A big picture of how it is integrated inside 
> of the Smart Ecosystem is the following:
>  
> !image-2021-04-25-16-01-17-862.png!  
> The intention is first to provide all the libraries and the implementation 
> for one Database PostgreSQL through the NGSIToPostgreSQL processor and then 
> continue with other databases.  The code, documentation, and tests are 
> available in [https://github.com/ging/fiware-draco]
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi] joewitt commented on pull request #5844: NIFI-8472 Add NGSIToMongo processor and NGSI libraries

2022-03-23 Thread GitBox


joewitt commented on pull request #5844:
URL: https://github.com/apache/nifi/pull/5844#issuecomment-1076883085


   Hello. We would update this page here.   
https://cwiki.apache.org/confluence/display/NIFI/Community+Contributions
   
   Just have your stuff in a github repo with licensing, readme, and have the 
artifacts published to some publicly accessible artifact repository and you 
should be in good shape.
   
   Feel free to tell us what you'd like in each of those boxes and we'd be 
happy to help people know about it/point to it. Going to close this PR and 
JIRA based on the discussion thus far.
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] joewitt closed pull request #5844: NIFI-8472 Add NGSIToMongo processor and NGSI libraries

2022-03-23 Thread GitBox


joewitt closed pull request #5844:
URL: https://github.com/apache/nifi/pull/5844


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] joewitt commented on pull request #5894: NiFi-9817 Add a Validator for the PutCloudWatchMetric Processor's Unit Parameter

2022-03-23 Thread GitBox


joewitt commented on pull request #5894:
URL: https://github.com/apache/nifi/pull/5894#issuecomment-1076877511


   Hello @patalwell .  If you run 'git status' you'll see all those files as 
untracked filed.  They're local.  Maven is seeing them and they do likely lack 
L&N so it is rightly complaining.  Remove them and you're good to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] patalwell commented on pull request #5894: NiFi-9817 Add a Validator for the PutCloudWatchMetric Processor's Unit Parameter

2022-03-23 Thread GitBox


patalwell commented on pull request #5894:
URL: https://github.com/apache/nifi/pull/5894#issuecomment-1076871873


   [rat.txt](https://github.com/apache/nifi/files/8337002/rat.txt)
   
   Getting [ERROR] Failed to execute goal 
org.apache.rat:apache-rat-plugin:0.13:check (default) on project 
nifi-nar-bundles: Too many files with unapproved license: 69 See RAT report in: 
/Users/palwell/Development/nifi-experimentation/nifi-nar-bundles/target/rat.txt 
-> [Help 1].
   
   This even after rebasing to main and making sure there were only changes to 
select java processor files in the aws bundle.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] patalwell commented on pull request #5894: NiFi-9817 Add a Validator for the PutCloudWatchMetric Processor's Unit Parameter

2022-03-23 Thread GitBox


patalwell commented on pull request #5894:
URL: https://github.com/apache/nifi/pull/5894#issuecomment-1076862452


   Getting a build/test error when running `mvn -Pcontrib-check clean install`. 
I can post the results in a file after I try to run it again. The code changes 
work with Java 8 and Java 11, just cant get the full test suite to run for some 
reason. Looking into it now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] patalwell opened a new pull request #5894: NiFi-9817 Add a Validator for the PutCloudWatchMetric Processor's Unit Parameter

2022-03-23 Thread GitBox


patalwell opened a new pull request #5894:
URL: https://github.com/apache/nifi/pull/5894


   
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
   NiFi 9817- Adds a Validator for the PutCloudWatchMetric Processor's Unit 
Parameter. This prevents the end user from entering invalid data prior to 
starting the processor by providing a warning flag with details in regards to 
the appropriate values for the Unit parameter.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ x] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [ x] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x ] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ x] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [x ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] andrewmlim commented on pull request #5247: NIFI-8927 - Add option to start/stop all controllers

2022-03-23 Thread GitBox


andrewmlim commented on pull request #5247:
URL: https://github.com/apache/nifi/pull/5247#issuecomment-1076845250


   Filed https://issues.apache.org/jira/browse/NIFI-9829 to capture some of the 
UX improvements discussed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (NIFI-9829) Improve UX of "Enable/disable all controller services"

2022-03-23 Thread Andrew M. Lim (Jira)
Andrew M. Lim created NIFI-9829:
---

 Summary: Improve UX of "Enable/disable all controller services"
 Key: NIFI-9829
 URL: https://issues.apache.org/jira/browse/NIFI-9829
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core UI
Affects Versions: 1.16.0
Reporter: Andrew M. Lim
 Attachments: image-2022-03-23-17-36-59-864.png

"Enable/disable" all controller services was added in 1.16.0 via 
https://issues.apache.org/jira/browse/NIFI-8927

Creating this Jira to capture improvements for this useful new feature. Some 
are taken from the conversation from https://github.com/apache/nifi/pull/5247

* Show the user can see the full scope of their action and gets updates while 
the action completes.
* When enabling add ability to choose to start referencing components as well.
* "Enable all controller services" starts enabling controller services that are 
INVALID. The UI appears like they are enabled though because the "Disable" icon 
is available. In reality, the controller service is stuck in ENABLING status.

 !image-2022-03-23-17-36-59-864.png! 





--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (NIFI-8124) Allow Cookie Preservation in Redirects for InvokeHTTP

2022-03-23 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-8124.

Fix Version/s: 1.17.0
   Resolution: Fixed

> Allow Cookie Preservation in Redirects for InvokeHTTP
> -
>
> Key: NIFI-8124
> URL: https://issues.apache.org/jira/browse/NIFI-8124
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.15.3
>Reporter: Shawn Weeks
>Assignee: Marcus Ely
>Priority: Minor
>  Labels: InvokeHTTP, cookie, cookies, http
> Fix For: 1.17.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Some authentication systems like 2-way ssl on an F5 Appliance use session 
> cookies during redirection to determine who you are. Currently InvokeHTTP 
> does not preserve these cookies during redirection causing authentication 
> failure. The OkHttp Library supports a Cookie Jar option like curl's "-c" 
> that would allow this to work. This issue is to add the option to enable that 
> feature if needed but leave it disabled by default.
> Of note it appears the Apache HttpClient supports this by default exactly 
> opposite from OkHttp.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (NIFI-8124) Allow Cookie Preservation in Redirects for InvokeHTTP

2022-03-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511489#comment-17511489
 ] 

ASF subversion and git services commented on NIFI-8124:
---

Commit 72435c3c6dc0e436bbb5767ed4cdf0ae26f33476 in nifi's branch 
refs/heads/main from Marcus Ely
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=72435c3 ]

NIFI-8124 Added Cookie Strategy property to InvokeHTTP

This closes #5887

Signed-off-by: David Handermann 


> Allow Cookie Preservation in Redirects for InvokeHTTP
> -
>
> Key: NIFI-8124
> URL: https://issues.apache.org/jira/browse/NIFI-8124
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.15.3
>Reporter: Shawn Weeks
>Assignee: Marcus Ely
>Priority: Minor
>  Labels: InvokeHTTP, cookie, cookies, http
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Some authentication systems like 2-way ssl on an F5 Appliance use session 
> cookies during redirection to determine who you are. Currently InvokeHTTP 
> does not preserve these cookies during redirection causing authentication 
> failure. The OkHttp Library supports a Cookie Jar option like curl's "-c" 
> that would allow this to work. This issue is to add the option to enable that 
> feature if needed but leave it disabled by default.
> Of note it appears the Apache HttpClient supports this by default exactly 
> opposite from OkHttp.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi] exceptionfactory closed pull request #5887: NIFI-8124 Added cookie redirect handling to InvokeHTTP

2022-03-23 Thread GitBox


exceptionfactory closed pull request #5887:
URL: https://github.com/apache/nifi/pull/5887


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (NIFI-9816) Ensure "lang" attribute is set in tags

2022-03-23 Thread Jonathan Conti-Vock (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Conti-Vock updated NIFI-9816:
--
Status: Patch Available  (was: In Progress)

> Ensure "lang" attribute is set in  tags
> -
>
> Key: NIFI-9816
> URL: https://issues.apache.org/jira/browse/NIFI-9816
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.15.3
>Reporter: Jonathan Conti-Vock
>Assignee: Jonathan Conti-Vock
>Priority: Minor
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Accessibility standards require every  tag to have a "lang" attribute 
> where the value represents the primary language of the document. From the 
> [WCAG 2.1 requirement's 
> description|[https://www.w3.org/WAI/WCAG21/Techniques/html/H57]], identifying 
> the language of the document is important for a number of reasons:
>  * It allows braille translation software to substitute control codes for 
> accented characters, and insert control codes necessary to prevent erroneous 
> creation of Grade 2 braille contractions.
>  * Speech synthesizers that support multiple languages will be able to orient 
> and adapt to the pronunciation and syntax that are specific to the language 
> of the page, speaking the text in the appropriate accent with proper 
> pronunciation.
>  * Marking the language can benefit future developments in technology, for 
> example users who are unable to translate between languages themselves will 
> be able to use machines to translate unfamiliar languages.
>  * Marking the language can also assist user agents in providing definitions 
> using a dictionary.
> While reviewing the backlog for existing tickets related to localization, I 
> found there's already been some significant (though stale) work done to 
> implement localization/multilingualization (NIFI-4785). Given that work, I 
> would suggest compatible JSTL changes be made to the existing JSPs and 
> otherwise hardcode lang="en" in existing HTML pages until further 
> localization improvements are made.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (NIFI-9787) Improve visibility of selected row in Controller Services and Add Processor tables

2022-03-23 Thread Jonathan Conti-Vock (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Conti-Vock updated NIFI-9787:
--
Status: Patch Available  (was: In Progress)

> Improve visibility of selected row in Controller Services and Add Processor 
> tables
> --
>
> Key: NIFI-9787
> URL: https://issues.apache.org/jira/browse/NIFI-9787
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.15.3
>Reporter: Jonathan Conti-Vock
>Assignee: Jonathan Conti-Vock
>Priority: Minor
>  Labels: Accessibility
> Attachments: image-2022-03-10-17-19-18-155.png, 
> image-2022-03-10-17-40-00-713.png, image-2022-03-10-17-45-27-014.png, 
> image-2022-03-10-17-46-02-065.png, image-2022-03-10-17-47-04-823.png, 
> image-2022-03-10-17-47-32-143.png, image-2022-03-10-17-48-10-252.png
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The particular concern this ticket addresses is to make it easier to identify 
> which row is selected/highlighted after adding a new Controller Service to 
> your configuration. This change would also make it easier to identify which 
> row is selected when navigating a table with the keyboard, and fulfill the 
> WCAG 2.1 success criteria "[Ensuring that additional visual cues are 
> available when text color differences are used to convey 
> information|https://www.w3.org/WAI/WCAG21/Techniques/general/G182]";.
> As you can see below, it is nearly or actually impossible for users with 
> color contrast insensitivity (particularly a complete lack of color vision) 
> to distinguish which row is currently highlighted.
>  
> In the Controller Services table...
> Achromatopsia (grayscale):
> !image-2022-03-10-17-45-27-014.png!
> No color contrast vision problems:
> !image-2022-03-10-17-46-02-065.png!
>  
> In the "Add Processor" table...
> Achromatopsia (grayscale):
> !image-2022-03-10-17-19-18-155.png!
>  
> No color contrast vision problems:
> !image-2022-03-10-17-40-00-713.png!
>  
> Proposed changes would look like the following:
> !image-2022-03-10-17-47-04-823.png!
>  
> !image-2022-03-10-17-47-32-143.png!
>  
> !image-2022-03-10-17-48-10-252.png!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (NIFI-1476) Enforce TripleDES Keying Option validation on TDES algorithms

2022-03-23 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-1476.

Resolution: Abandoned

NIST deprecated usage of 3DES in 2017, so further refinement of the valid key 
lengths does not seem necessary.

> Enforce TripleDES Keying Option validation on TDES algorithms
> -
>
> Key: NIFI-1476
> URL: https://issues.apache.org/jira/browse/NIFI-1476
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Minor
>  Labels: encryption, security
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The {{public static List getValidKeyLengthsForAlgorithm(String 
> algorithm)}} method in {{CipherUtility}} returns a constant list of {{[56, 
> 64, 112, 128, 168, 192]}} for all {{TRIPLEDES}} algorithms. However, some 
> algorithms, such as  {{PBEWITHSHAAND2-KEYTRIPLEDES-CBC}} and 
> {{PBEWITHSHAAND3-KEYTRIPLEDES-CBC}} specify the _keying option_ used in the 
> algorithm, and this indicates a more restrictive key length ({{112/128}} for 
> _Keying Option 2_ and {{168/192}} for _Keying Option 1_ respectively). 
> Enforce this validation and add unit tests. 
> [https://en.wikipedia.org/wiki/Triple_DES#Keying_options|Wikipedia - 
> TripleDES Keying Options]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (NIFI-6342) HandleHttpRequest enters in fault state and does not recover (regression)

2022-03-23 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-6342.

Resolution: Cannot Reproduce

Recent updates to HandleHttpRequest seem to have improved overall behavior and 
stability. Potential problems related to a more recent version can be tracked 
in new issues.

> HandleHttpRequest enters in fault state and does not recover (regression)
> -
>
> Key: NIFI-6342
> URL: https://issues.apache.org/jira/browse/NIFI-6342
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.9.2
>Reporter: Diego Queiroz
>Priority: Major
>  Labels: security
>
> Hello guys.
> I just updated my NiFi environment to the last available version and, 
> apparently, the bug reported in 
> [https://issues.apache.org/jira/projects/NIFI/issues/NIFI-5522] continues in 
> the last release (=1.9.2, Jetty = 9.4.11.v20180605).
> I was confused if I should comment in the same thread or open a new ticket, 
> so sorry if I did wrong in opening a new issue.
> Are there any thoughts about this? I really wasn't able to test in 1.8.0 
> where this bug was supposed to be fixed, so I don't know if it wasn't fixed 
> at all or if it happened again in 1.9.2.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (NIFI-9827) Update regions in AWS processors

2022-03-23 Thread Joe Gresock (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Gresock updated NIFI-9827:
--
Description: A more up-to-date list of AWS regions could be added to the 
AWS processors.  (was: Also called the "AWS Secret Region", the "us-iso-east-1" 
region can be added to the AWS processors.)

> Update regions in AWS processors
> 
>
> Key: NIFI-9827
> URL: https://issues.apache.org/jira/browse/NIFI-9827
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Joe Gresock
>Assignee: Joe Gresock
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> A more up-to-date list of AWS regions could be added to the AWS processors.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (NIFI-9827) Update regions in AWS processors

2022-03-23 Thread Joe Gresock (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Gresock updated NIFI-9827:
--
Summary: Update regions in AWS processors  (was: Add C2S Region to AWS 
processors)

> Update regions in AWS processors
> 
>
> Key: NIFI-9827
> URL: https://issues.apache.org/jira/browse/NIFI-9827
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Joe Gresock
>Assignee: Joe Gresock
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Also called the "AWS Secret Region", the "us-iso-east-1" region can be added 
> to the AWS processors.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (NIFI-9827) Add C2S Region to AWS processors

2022-03-23 Thread Joe Gresock (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Gresock updated NIFI-9827:
--
Status: Patch Available  (was: Open)

> Add C2S Region to AWS processors
> 
>
> Key: NIFI-9827
> URL: https://issues.apache.org/jira/browse/NIFI-9827
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Joe Gresock
>Assignee: Joe Gresock
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Also called the "AWS Secret Region", the "us-iso-east-1" region can be added 
> to the AWS processors.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (NIFI-1473) Add unit tests for EncryptContent processor

2022-03-23 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-1473.

Resolution: Abandoned

> Add unit tests for EncryptContent processor
> ---
>
> Key: NIFI-1473
> URL: https://issues.apache.org/jira/browse/NIFI-1473
> Project: Apache NiFi
>  Issue Type: Test
>  Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Minor
>  Labels: encryption, security
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Add additional unit tests for {{password}} validation in {{EncryptContent}} 
> processor in {{TestEncryptContentGroovy}}. 
> * {{testShouldValidatePasswordForPBE()}}
> * {{testShouldValidatePasswordEntropy()}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi] exceptionfactory commented on pull request #5893: NIFI-9816: Implementing a way of dynamically setting the 'lang' attribute…

2022-03-23 Thread GitBox


exceptionfactory commented on pull request #5893:
URL: https://github.com/apache/nifi/pull/5893#issuecomment-1076744163


   > Will make the changes and push them.
   
   Sounds good, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] jocovo commented on pull request #5893: NIFI-9816: Implementing a way of dynamically setting the 'lang' attribute…

2022-03-23 Thread GitBox


jocovo commented on pull request #5893:
URL: https://github.com/apache/nifi/pull/5893#issuecomment-1076741512


   I _had_ been wondering if I was over-engineering this solution given the 
current lack of localization. Hard-coding "en" would accurately represent the 
site's contents as it stands now, so I think that's a good idea. Will make the 
changes and push them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] jocovo opened a new pull request #5893: NIFI-9816: Implementing a way of dynamically setting the 'lang' attribute…

2022-03-23 Thread GitBox


jocovo opened a new pull request #5893:
URL: https://github.com/apache/nifi/pull/5893


   … on each html tag (where possible) to meet WCAG 2.1 Accessibility standards.
   
   
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
    Description of PR
   
   These changes provide a dynamic way of ensuring every  tag has a 
"lang" attribute with a [valid BCP 47 
language](https://www.w3.org/International/questions/qa-choosing-language-tags#question)
 value, which is used by accessibility devices like screen readers to correctly 
pronounce on-screen text. This also meets success criteria for [accessibility 
standards in WCAG 2.1](https://www.w3.org/WAI/WCAG21/Techniques/html/H57). 
Resolves ticket NIFI-9816.
   
   Testing the changes in this PR requires manual inspection of the  
elements on the affected pages, noting that the changes in the nifi-web-api 
package are verified by inspecting the contents of the Documentation view's 
iframe.
   
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [X] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [X] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [X] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [X] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (NIFI-1468) Add unit tests for invalid cipher streams

2022-03-23 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-1468.

Fix Version/s: 1.17.0
   Resolution: Fixed

> Add unit tests for invalid cipher streams
> -
>
> Key: NIFI-1468
> URL: https://issues.apache.org/jira/browse/NIFI-1468
> Project: Apache NiFi
>  Issue Type: Test
>  Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: Emilio Setiadarma
>Priority: Minor
>  Labels: encryption, security
> Fix For: 1.17.0
>
>   Original Estimate: 48h
>  Time Spent: 0.5h
>  Remaining Estimate: 47.5h
>
> Add unit tests for {{PasswordBasedEncryptorGroovyTest}} and 
> {{KeyedEncryptorGroovyTest}} to ensure they handle invalid cipher streams 
> correctly during decryption. Include the following tests:
> {{PasswordBasedEncryptorGroovyTest}}
> * {{testDecryptShouldHandleCipherStreamMissingSalt()}}
> * {{testDecryptShouldHandleCipherStreamMissingSaltDelimiter()}}
> * {{testDecryptShouldHandleCipherStreamMissingIV()}}
> * {{testDecryptShouldHandleCipherStreamMissingIVDelimiter()}}
> {{KeyedEncryptorGroovyTest}}
> * {{testDecryptShouldHandleCipherStreamMissingIV()}}
> * {{testDecryptShouldHandleCipherStreamMissingIVDelimiter()}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (NIFI-1468) Add unit tests for invalid cipher streams

2022-03-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511426#comment-17511426
 ] 

ASF subversion and git services commented on NIFI-1468:
---

Commit 772adbc70957cc47256c8f7ea3668b2187e12923 in nifi's branch 
refs/heads/main from Emilio Setiadarma
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=772adbc ]

NIFI-1468 Added tests to handle invalid cipher streams missing Salt/IV

- Updated PasswordBasedEncryptorGroovyTest and KeyedEncryptorGroovyTest

This closes #5877

Signed-off-by: David Handermann 


> Add unit tests for invalid cipher streams
> -
>
> Key: NIFI-1468
> URL: https://issues.apache.org/jira/browse/NIFI-1468
> Project: Apache NiFi
>  Issue Type: Test
>  Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: Emilio Setiadarma
>Priority: Minor
>  Labels: encryption, security
>   Original Estimate: 48h
>  Time Spent: 0.5h
>  Remaining Estimate: 47.5h
>
> Add unit tests for {{PasswordBasedEncryptorGroovyTest}} and 
> {{KeyedEncryptorGroovyTest}} to ensure they handle invalid cipher streams 
> correctly during decryption. Include the following tests:
> {{PasswordBasedEncryptorGroovyTest}}
> * {{testDecryptShouldHandleCipherStreamMissingSalt()}}
> * {{testDecryptShouldHandleCipherStreamMissingSaltDelimiter()}}
> * {{testDecryptShouldHandleCipherStreamMissingIV()}}
> * {{testDecryptShouldHandleCipherStreamMissingIVDelimiter()}}
> {{KeyedEncryptorGroovyTest}}
> * {{testDecryptShouldHandleCipherStreamMissingIV()}}
> * {{testDecryptShouldHandleCipherStreamMissingIVDelimiter()}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi] exceptionfactory closed pull request #5877: NIFI-1468 add tests to handle invalid cipher streams missing Salt/IV …

2022-03-23 Thread GitBox


exceptionfactory closed pull request #5877:
URL: https://github.com/apache/nifi/pull/5877


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] anmunoz commented on pull request #5844: NIFI-8472 Add NGSIToMongo processor and NGSI libraries

2022-03-23 Thread GitBox


anmunoz commented on pull request #5844:
URL: https://github.com/apache/nifi/pull/5844#issuecomment-1076663757


   Hello @joewitt,
   
   Please, can you help us with any information about how to included our 
components in the externally supported component list?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (NIFI-1129) InvokeHttp fine grain control over truststore

2022-03-23 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-1129.

Resolution: Duplicate

> InvokeHttp fine grain control over truststore
> -
>
> Key: NIFI-1129
> URL: https://issues.apache.org/jira/browse/NIFI-1129
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joe Percivall
>Priority: Minor
>
> The original ticket for this was a collections of improvements to InvokeHttp 
> but it was out the scope of the ticket. The original wording is:
> Add option to disable remote certificate issues, like invalid hostnames, etc. 
> Likely install a custom HostnameVerifier to do this.
> My understanding of this is, is for fine grain control over the truststore 
> and hostname verifier being used for the processor. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (NIFI-9826) Test failure on Ubuntu when using C locale

2022-03-23 Thread Paul Grey (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511408#comment-17511408
 ] 

Paul Grey commented on NIFI-9826:
-

The Github CI for the project runs regular builds (with unit tests) using 
multiple locales.  This is currently implemented by specifying system 
properties for the locale in the CI Maven command line, and configuring the 
root POM to propagate the locale settings to surefire.

It may be possible to specify the CI locale via an environment variable (such 
as `LC_ALL`).  If Maven and Surefire can accept specification of an alternate 
locale in this way, the `pom.xml` settings could be reverted.


> Test failure on Ubuntu when using C locale
> --
>
> Key: NIFI-9826
> URL: https://issues.apache.org/jira/browse/NIFI-9826
> Project: Apache NiFi
>  Issue Type: Bug
> Environment: Ubuntu 20.04, openjdk-17 and openjdk-8
>Reporter: Marton Szasz
>Priority: Minor
>
> When building NiFi, I ran into test failures:
> {code:java}
> [ERROR] Tests run: 7, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.689 
> s <<< FAILURE! - in org.apache.nifi.dbcp.HikariCPConnectionPoolTest
> [ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection  
> Time elapsed: 1.113 s  <<< ERROR!
> org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
> failed
> at 
> org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection(HikariCPConnectionPoolTest.java:152)
> Caused by: java.sql.SQLException: Failed to create database 
> '/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see 
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
> database 
> '/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see 
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException:
> Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
> ln[_CO[_variant]]
> ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
> ISO-3166 country codes, see java.util.Locale.
> [ERROR] 
> org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect  Time 
> elapsed: 1.019 s  <<< ERROR!
> org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
> failed
> at 
> org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect(HikariCPConnectionPoolTest.java:172)
> Caused by: java.sql.SQLException: Failed to create database 
> '/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see 
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
> database 
> '/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see 
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException:
> Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
> ln[_CO[_variant]]
> ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
> ISO-3166 country codes, see java.util.Locale. {code}
>  
> My system locale was set to C.UTF-8. When changed to en_US.UTF-8, the build 
> succeeded.
> Steps to reproduce:
> {code:java}
> export LANG=C.UTF-8
> export LC_ALL=C.UTF-8
> mvn package{code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi] gresockj opened a new pull request #5892: NIFI-9827: Upgrading AWS Java SDK to 1.12.182 to pick up new AWS Regions

2022-03-23 Thread GitBox


gresockj opened a new pull request #5892:
URL: https://github.com/apache/nifi/pull/5892


   
   
    Description of PR
   
   This upgrades the AWS Java SDK to 1.12.182, allowing recently added regions 
to appear in the "Regions" properties of AWS processors.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [ ] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (NIFI-1468) Add unit tests for invalid cipher streams

2022-03-23 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann reassigned NIFI-1468:
--

Assignee: Emilio Setiadarma  (was: Andy LoPresto)

> Add unit tests for invalid cipher streams
> -
>
> Key: NIFI-1468
> URL: https://issues.apache.org/jira/browse/NIFI-1468
> Project: Apache NiFi
>  Issue Type: Test
>  Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: Emilio Setiadarma
>Priority: Minor
>  Labels: encryption, security
>   Original Estimate: 48h
>  Time Spent: 20m
>  Remaining Estimate: 47h 40m
>
> Add unit tests for {{PasswordBasedEncryptorGroovyTest}} and 
> {{KeyedEncryptorGroovyTest}} to ensure they handle invalid cipher streams 
> correctly during decryption. Include the following tests:
> {{PasswordBasedEncryptorGroovyTest}}
> * {{testDecryptShouldHandleCipherStreamMissingSalt()}}
> * {{testDecryptShouldHandleCipherStreamMissingSaltDelimiter()}}
> * {{testDecryptShouldHandleCipherStreamMissingIV()}}
> * {{testDecryptShouldHandleCipherStreamMissingIVDelimiter()}}
> {{KeyedEncryptorGroovyTest}}
> * {{testDecryptShouldHandleCipherStreamMissingIV()}}
> * {{testDecryptShouldHandleCipherStreamMissingIVDelimiter()}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi] thenatog commented on pull request #5891: NIFI-9702 - ListSFTP does not set mime.type for corresponding recordwriter

2022-03-23 Thread GitBox


thenatog commented on pull request #5891:
URL: https://github.com/apache/nifi/pull/5891#issuecomment-1076563196


   This PR is based on changes in NIFI-9701 / 
https://github.com/apache/nifi/pull/5885


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] thenatog opened a new pull request #5891: NIFI-9702 - ListSFTP does not set mime.type for corresponding recordwriter

2022-03-23 Thread GitBox


thenatog opened a new pull request #5891:
URL: https://github.com/apache/nifi/pull/5891


   
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
    Description of PR
   
   _Enables X functionality; fixes bug NIFI-._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [x] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [x] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (NIFI-9828) Apache NiFi 1.15.3 - Load balancing error on one cluster node due to java.net.UnknownHostException: null

2022-03-23 Thread Emanuele Costantini (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emanuele Costantini updated NIFI-9828:
--
Description: 
I have a 11 nodes NiFi cluster. Each node can correctly communicate to each 
other.
However when the other nodes try to connect to a node 021 for load balancing, 
the following error occurs:

 
{code:java}
ERROR [Load-Balanced Client Thread-8] 
o.a.n.c.q.c.c.a.n.NioAsyncLoadBalanceClient Unable to connect to 
as021dos.intranet.fw:18090 for load balancing
java.net.UnknownHostException: null
at sun.nio.ch.Net.translateException(Net.java:154)
at sun.nio.ch.SocketAdaptor.connect(SocketAdaptor.java:127)
at sun.nio.ch.SocketAdaptor.connect(SocketAdaptor.java:80)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.createChannel(NioAsyncLoadBalanceClient.java:496)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.establishConnection(NioAsyncLoadBalanceClient.java:439)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.communicate(NioAsyncLoadBalanceClient.java:234)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClientTask.run(NioAsyncLoadBalanceClientTask.java:81)
at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748){code}
The error can be seen on all nodes and only towards the node 021.

 

Load balancing properties are the following on ALL nodes (actual ip address 
instead of "ipv4_address"):
{code:java}
nifi.cluster.load.balance.host=ipv4_address
nifi.cluster.load.balance.port=6342
nifi.cluster.load.balance.connections.per.node=4
nifi.cluster.load.balance.max.thread.count=8
nifi.cluster.load.balance.comms.timeout=30 sec{code}
While 18090, which is the port appearing in the error, is the HTTPS port.

Any idea on why does the error raise? And why does it appear just towards one 
node?

Thanks

  was:
I have a 11 nodes NiFi cluster. Each node can correctly communicate to each 
other.
However when the other nodes try to connect to a node 021 for load balancing, 
the following error occurs (x put instead of real name):

 
{code:java}
ERROR [Load-Balanced Client Thread-8] 
o.a.n.c.q.c.c.a.n.NioAsyncLoadBalanceClient Unable to connect to 
as021dos.intranet.fw:18090 for load balancing
java.net.UnknownHostException: null
at sun.nio.ch.Net.translateException(Net.java:154)
at sun.nio.ch.SocketAdaptor.connect(SocketAdaptor.java:127)
at sun.nio.ch.SocketAdaptor.connect(SocketAdaptor.java:80)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.createChannel(NioAsyncLoadBalanceClient.java:496)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.establishConnection(NioAsyncLoadBalanceClient.java:439)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.communicate(NioAsyncLoadBalanceClient.java:234)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClientTask.run(NioAsyncLoadBalanceClientTask.java:81)
at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748){code}
The error can be seen on all nodes and only towards the node 021.

 

Load balancing properties are the following on ALL nodes (actual ip address 
instead of "ipv4_address"):
{code:java}
nifi.cluster.load.balance.host=ipv4_address
nifi.cluster.load.balance.port=6342
nifi.cluster.load.balance.connections.per.node=4
nifi.cluster.load.balance.max.thread.count=8
nifi.cluster.load.balance.comms.timeout=30 sec{code}
While 18090, which is the port appearing in the error, is the HTTPS port.

Any idea on why does the error raise? And why does it appear just towards one 
node?

Thanks


> Apache NiFi 1.15.3 -

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1285: MINIFICPP-1779 Verify multiple C2 commands in HB response

2022-03-23 Thread GitBox


lordgamez opened a new pull request #1285:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1285


   https://issues.apache.org/jira/browse/MINIFICPP-1779
   
   -
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI 
results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (NIFI-9828) Apache NiFi 1.15.3 - Load balancing error on one cluster node due to java.net.UnknownHostException: null

2022-03-23 Thread Emanuele Costantini (Jira)
Emanuele Costantini created NIFI-9828:
-

 Summary: Apache NiFi 1.15.3 - Load balancing error on one cluster 
node due to java.net.UnknownHostException: null
 Key: NIFI-9828
 URL: https://issues.apache.org/jira/browse/NIFI-9828
 Project: Apache NiFi
  Issue Type: Bug
Affects Versions: 1.15.3
Reporter: Emanuele Costantini


I have a 11 nodes NiFi cluster. Each node can correctly communicate to each 
other.
However when the other nodes try to connect to a node 021 for load balancing, 
the following error occurs (x put instead of real name):

 
{code:java}
ERROR [Load-Balanced Client Thread-8] 
o.a.n.c.q.c.c.a.n.NioAsyncLoadBalanceClient Unable to connect to 
as021dos.intranet.fw:18090 for load balancing
java.net.UnknownHostException: null
at sun.nio.ch.Net.translateException(Net.java:154)
at sun.nio.ch.SocketAdaptor.connect(SocketAdaptor.java:127)
at sun.nio.ch.SocketAdaptor.connect(SocketAdaptor.java:80)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.createChannel(NioAsyncLoadBalanceClient.java:496)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.establishConnection(NioAsyncLoadBalanceClient.java:439)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.communicate(NioAsyncLoadBalanceClient.java:234)
at 
org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClientTask.run(NioAsyncLoadBalanceClientTask.java:81)
at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748){code}
The error can be seen on all nodes and only towards the node 021.

 

Load balancing properties are the following on ALL nodes (actual ip address 
instead of "ipv4_address"):
{code:java}
nifi.cluster.load.balance.host=ipv4_address
nifi.cluster.load.balance.port=6342
nifi.cluster.load.balance.connections.per.node=4
nifi.cluster.load.balance.max.thread.count=8
nifi.cluster.load.balance.comms.timeout=30 sec{code}
While 18090, which is the port appearing in the error, is the HTTPS port.

Any idea on why does the error raise? And why does it appear just towards one 
node?

Thanks



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1152: MINIFICPP-1593 ProcFsMonitor to monitor /proc pseduo filesystem

2022-03-23 Thread GitBox


fgerlits commented on a change in pull request #1152:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1152#discussion_r833175397



##
File path: extensions/procfs/ProcFsSerialization.h
##
@@ -0,0 +1,183 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+#include 
+#include 
+#include 
+
+#include "CpuStat.h"
+#include "DiskStat.h"
+#include "MemInfo.h"
+#include "NetDev.h"
+#include "ProcessStat.h"
+#include "utils/gsl.h"
+
+namespace org::apache::nifi::minifi::extensions::procfs {
+
+template
+requires std::invocable
+void SerializeCPUStatData(const CpuStatData& cpu_stat_data,
+  Serializer serializer) {
+  serializer("user time", cpu_stat_data.getUser().count());
+  serializer("nice time", cpu_stat_data.getNice().count());
+  serializer("system time", cpu_stat_data.getSystem().count());
+  serializer("idle time", cpu_stat_data.getIdle().count());
+  serializer("io wait time", cpu_stat_data.getIoWait().count());
+  serializer("irq time", cpu_stat_data.getIrq().count());
+  serializer("soft irq time", cpu_stat_data.getSoftIrq().count());
+  serializer("steal time", cpu_stat_data.getSteal().count());
+  serializer("guest time", cpu_stat_data.getGuest().count());
+  serializer("guest nice time", cpu_stat_data.getGuestNice().count());
+}
+
+template
+requires std::invocable
+void SerializeNormalizedCPUStat(const CpuStatData& cpu_stat_data,
+Serializer serializer) {
+  gsl_Expects(cpu_stat_data.getTotal() > 0ms);
+  serializer("user time %", cpu_stat_data.getUser()/cpu_stat_data.getTotal());
+  serializer("nice time %", cpu_stat_data.getNice()/cpu_stat_data.getTotal());
+  serializer("system time %", 
cpu_stat_data.getSystem()/cpu_stat_data.getTotal());
+  serializer("idle time %", cpu_stat_data.getIdle()/cpu_stat_data.getTotal());
+  serializer("io wait time %", 
cpu_stat_data.getIoWait()/cpu_stat_data.getTotal());
+  serializer("irq time %", cpu_stat_data.getIrq()/cpu_stat_data.getTotal());
+  serializer("soft irq %", 
cpu_stat_data.getSoftIrq()/cpu_stat_data.getTotal());
+  serializer("steal time %", 
cpu_stat_data.getSteal()/cpu_stat_data.getTotal());
+  serializer("guest time %", 
cpu_stat_data.getGuest()/cpu_stat_data.getTotal());
+  serializer("guest nice time %", 
cpu_stat_data.getGuestNice()/cpu_stat_data.getTotal());
+}
+
+template
+requires std::invocable
+void SerializeDiskStatData(const DiskStatData& disk_stat_data,
+   Serializer serializer) {
+  serializer("Major Device Number", disk_stat_data.getMajorDeviceNumber());
+  serializer("Minor Device Number", disk_stat_data.getMinorDeviceNumber());
+  serializer("Reads Completed", disk_stat_data.getReadsCompleted());
+  serializer("Reads Merged", disk_stat_data.getReadsMerged());
+  serializer("Sectors Read", disk_stat_data.getSectorsRead());
+  serializer("Writes Completed", disk_stat_data.getWritesCompleted());
+  serializer("Writes Merged", disk_stat_data.getWritesMerged());
+  serializer("Sectors Written", disk_stat_data.getSectorsWritten());
+  serializer("IOs in progress", disk_stat_data.getIosInProgress());
+}
+
+template
+requires std::invocable
+void SerializeDiskStatDataPerSec(const DiskStatData& disk_stat_data,
+ const std::chrono::duration duration,
+ Serializer serializer) {
+  gsl_Expects(duration > 0ms);
+  serializer("Major Device Number", disk_stat_data.getMajorDeviceNumber());
+  serializer("Minor Device Number", disk_stat_data.getMinorDeviceNumber());
+  serializer("Reads Completed/sec", 
disk_stat_data.getReadsCompleted()/duration.count());
+  serializer("Reads Merged/sec", 
disk_stat_data.getReadsMerged()/duration.count());
+  serializer("Sectors Read/sec", 
disk_stat_data.getSectorsRead()/duration.count());
+  serializer("Writes Completed/sec", 
disk_stat_data.getWritesCompleted()/duration.count());
+  serializer("Writes Merged/sec", 
disk_stat_data.getWritesMerged()/duration.count());
+  serializer("Sectors Written/sec", 
disk_stat_data.getSectorsWritten()/duration.count());
+  serializer("IOs in progress", 
disk_stat_data.getIosInProgress()/duration.count());
+}
+
+template
+requires std::i

[GitHub] [nifi] greyp9 opened a new pull request #5890: NIFI-9824 - Address WARN log message in ProcessorAuditor on action Ru…

2022-03-23 Thread GitBox


greyp9 opened a new pull request #5890:
URL: https://github.com/apache/nifi/pull/5890


   …nOnce
   
    Description of PR
   
   Properly handle audit of processor action "Run Once".  Class 
`ProcessorAuditor` generates an audit record for this action, where 
`processorAction.setOperation()` needs to be called to specify the operation.  
If the operation is unspecified, an NPE is thrown, and the operation is not 
audited.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [X] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [X] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [X] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [X] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (NIFI-9827) Add C2S Region to AWS processors

2022-03-23 Thread Joe Gresock (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Gresock reassigned NIFI-9827:
-

Assignee: Joe Gresock

> Add C2S Region to AWS processors
> 
>
> Key: NIFI-9827
> URL: https://issues.apache.org/jira/browse/NIFI-9827
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Joe Gresock
>Assignee: Joe Gresock
>Priority: Major
>
> Also called the "AWS Secret Region", the "us-iso-east-1" region can be added 
> to the AWS processors.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (NIFI-9827) Add C2S Region to AWS processors

2022-03-23 Thread Joe Gresock (Jira)
Joe Gresock created NIFI-9827:
-

 Summary: Add C2S Region to AWS processors
 Key: NIFI-9827
 URL: https://issues.apache.org/jira/browse/NIFI-9827
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Extensions
Reporter: Joe Gresock


Also called the "AWS Secret Region", the "us-iso-east-1" region can be added to 
the AWS processors.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (NIFI-9826) Test failure on Ubuntu when using C locale

2022-03-23 Thread Marton Szasz (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Szasz updated NIFI-9826:
---
Description: 
When building NiFi, I ran into test failures:
{code:java}
[ERROR] Tests run: 7, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.689 s 
<<< FAILURE! - in org.apache.nifi.dbcp.HikariCPConnectionPoolTest
[ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection  Time 
elapsed: 1.113 s  <<< ERROR!
org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
failed
at 
org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection(HikariCPConnectionPoolTest.java:152)
Caused by: java.sql.SQLException: Failed to create database 
'/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
database 
'/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException:
Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
ln[_CO[_variant]]
ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.

[ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect  
Time elapsed: 1.019 s  <<< ERROR!
org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
failed
at 
org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect(HikariCPConnectionPoolTest.java:172)
Caused by: java.sql.SQLException: Failed to create database 
'/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
database 
'/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException:
Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
ln[_CO[_variant]]
ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale. {code}
 

My system locale was set to C.UTF-8. When changed to en_US.UTF-8, the build 
succeeded.

Steps to reproduce:
{code:java}
export LANG=C.UTF-8
export LC_ALL=C.UTF-8
mvn package{code}

  was:
When building NiFi, I ran into test failures:


{code:java}
[ERROR] Tests run: 7, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.689 s 
<<< FAILURE! - in org.apache.nifi.dbcp.HikariCPConnectionPoolTest
[ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection Time 
elapsed: 1.113 s <<< ERROR!
org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
failed
at 
org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection(HikariCPConnectionPoolTest.java:152)
Caused by: java.sql.SQLException: Failed to create database 
'/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
database 
'/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException:
Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
ln[_CO[_variant]]
ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.
[ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect 
Time elapsed: 1.019 s <<< ERROR!
org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
failed
at 
org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect(HikariCPConnectionPoolTest.java:172)
Caused by: java.sql.SQLException: Failed to create database 
'/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
database 
'/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException:
Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
ln[_CO[_variant]]
ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.
{code}
 

My system locale was set to C.UTF-8. When changed to en_US.UTF-8, the build 
succeeded.

Steps to reproduce:
{code:java}
export LANG=C.UTF-8
export LC_ALL=C.UTF-8
mvn package{code}


> Test failure on Ubuntu when using C locale
> --
>
> Key: NIFI-9826
> URL: https://issues.apache.org/jira/browse/NIFI-9826
> Project: A

[jira] [Updated] (NIFI-9826) Test failure on Ubuntu when using C locale

2022-03-23 Thread Marton Szasz (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marton Szasz updated NIFI-9826:
---
Description: 
When building NiFi, I ran into test failures:


{code:java}
[ERROR] Tests run: 7, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.689 s 
<<< FAILURE! - in org.apache.nifi.dbcp.HikariCPConnectionPoolTest
[ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection Time 
elapsed: 1.113 s <<< ERROR!
org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
failed
at 
org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection(HikariCPConnectionPoolTest.java:152)
Caused by: java.sql.SQLException: Failed to create database 
'/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
database 
'/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException:
Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
ln[_CO[_variant]]
ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.
[ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect 
Time elapsed: 1.019 s <<< ERROR!
org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
failed
at 
org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect(HikariCPConnectionPoolTest.java:172)
Caused by: java.sql.SQLException: Failed to create database 
'/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
database 
'/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException:
Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
ln[_CO[_variant]]
ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.
{code}
 

My system locale was set to C.UTF-8. When changed to en_US.UTF-8, the build 
succeeded.

Steps to reproduce:
{code:java}
export LANG=C.UTF-8
export LC_ALL=C.UTF-8
mvn package{code}

  was:
When building NiFi, I ran into test failures:
```
[ERROR] Tests run: 7, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.689 s 
<<< FAILURE! - in org.apache.nifi.dbcp.HikariCPConnectionPoolTest
[ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection  Time 
elapsed: 1.113 s  <<< ERROR!
org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
failed
at 
org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection(HikariCPConnectionPoolTest.java:152)
Caused by: java.sql.SQLException: Failed to create database 
'/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
database 
'/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException:
Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
ln[_CO[_variant]]
ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.

[ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect  
Time elapsed: 1.019 s  <<< ERROR!
org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
failed
at 
org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect(HikariCPConnectionPoolTest.java:172)
Caused by: java.sql.SQLException: Failed to create database 
'/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
database 
'/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException:
Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
ln[_CO[_variant]]
ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.
```

My system locale was set to C.UTF-8. When changed to en_US.UTF-8, the build 
succeeded.

Steps to reproduce:
```
export LANG=C.UTF-8
export LC_ALL=C.UTF-8
mvn package
```


> Test failure on Ubuntu when using C locale
> --
>
> Key: NIFI-9826
> URL: https://issues.apache.org/jira/browse/NIFI-9826
> Project: Apache NiFi
>  I

[jira] [Created] (NIFI-9826) Test failure on Ubuntu when using C locale

2022-03-23 Thread Marton Szasz (Jira)
Marton Szasz created NIFI-9826:
--

 Summary: Test failure on Ubuntu when using C locale
 Key: NIFI-9826
 URL: https://issues.apache.org/jira/browse/NIFI-9826
 Project: Apache NiFi
  Issue Type: Bug
 Environment: Ubuntu 20.04, openjdk-17 and openjdk-8
Reporter: Marton Szasz


When building NiFi, I ran into test failures:
```
[ERROR] Tests run: 7, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.689 s 
<<< FAILURE! - in org.apache.nifi.dbcp.HikariCPConnectionPoolTest
[ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection  Time 
elapsed: 1.113 s  <<< ERROR!
org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
failed
at 
org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection(HikariCPConnectionPoolTest.java:152)
Caused by: java.sql.SQLException: Failed to create database 
'/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
database 
'/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException:
Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
ln[_CO[_variant]]
ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.

[ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect  
Time elapsed: 1.019 s  <<< ERROR!
org.apache.nifi.processor.exception.ProcessException: Connection retrieval 
failed
at 
org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect(HikariCPConnectionPoolTest.java:172)
Caused by: java.sql.SQLException: Failed to create database 
'/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException: Failed to create 
database 
'/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see the 
next exception for details.
Caused by: org.apache.derby.iapi.error.StandardException:
Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting 
ln[_CO[_variant]]
ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.
```

My system locale was set to C.UTF-8. When changed to en_US.UTF-8, the build 
succeeded.

Steps to reproduce:
```
export LANG=C.UTF-8
export LC_ALL=C.UTF-8
mvn package
```



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (NIFI-9824) Address WARN log message in ProcessorAuditor on action RunOnce

2022-03-23 Thread Paul Grey (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Grey updated NIFI-9824:

Status: Patch Available  (was: In Progress)

https://github.com/apache/nifi/pull/5890

> Address WARN log message in ProcessorAuditor on action RunOnce
> --
>
> Key: NIFI-9824
> URL: https://issues.apache.org/jira/browse/NIFI-9824
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Minor
>
> Noticed a WARN log message while reviewing NiFi logs. Tracked issue down to 
> `if` block in `updateProcessorAdvice()`.
> {code:java}
> // state is now stopped... consider the previous state
> if (ScheduledState.RUNNING.equals(scheduledState)) {
> processorAction.setOperation(Operation.Stop);
> } else if (ScheduledState.DISABLED.equals(scheduledState)) {
> processorAction.setOperation(Operation.Enable);
> }
> {code}
> An additional `else if` is needed to handle the "Run Once" case, where 
> `scheduledState` is "Stopped". Otherwise, the 
> `processorAction.setOperation()` is never called, which results in an NPE in 
> `NifiAuditor.saveActions()`.
> {code:java}
> WARN org.apache.nifi.audit.ProcessorAuditor Unable to record actions: Cannot 
> invoke "org.apache.nifi.action.Operation.name()" because the return value of 
> "org.apache.nifi.action.Action.getOperation()" is null
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (NIFI-9824) Address WARN log message in ProcessorAuditor on RunOnce

2022-03-23 Thread Paul Grey (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Grey updated NIFI-9824:

Summary: Address WARN log message in ProcessorAuditor on RunOnce  (was: 
Address WARN log message in ProcessorAuditor on processor RunOnce)

> Address WARN log message in ProcessorAuditor on RunOnce
> ---
>
> Key: NIFI-9824
> URL: https://issues.apache.org/jira/browse/NIFI-9824
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Minor
>
> Noticed a WARN log message while reviewing NiFi logs. Tracked issue down to 
> `if` block in `updateProcessorAdvice()`.
> {code:java}
> // state is now stopped... consider the previous state
> if (ScheduledState.RUNNING.equals(scheduledState)) {
> processorAction.setOperation(Operation.Stop);
> } else if (ScheduledState.DISABLED.equals(scheduledState)) {
> processorAction.setOperation(Operation.Enable);
> }
> {code}
> An additional `else if` is needed to handle the "Run Once" case, where 
> `scheduledState` is "Stopped". Otherwise, the 
> `processorAction.setOperation()` is never called, which results in an NPE in 
> `NifiAuditor.saveActions()`.
> {code:java}
> WARN org.apache.nifi.audit.ProcessorAuditor Unable to record actions: Cannot 
> invoke "org.apache.nifi.action.Operation.name()" because the return value of 
> "org.apache.nifi.action.Action.getOperation()" is null
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (NIFI-9824) Address WARN log message in ProcessorAuditor on action RunOnce

2022-03-23 Thread Paul Grey (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Grey updated NIFI-9824:

Summary: Address WARN log message in ProcessorAuditor on action RunOnce  
(was: Address WARN log message in ProcessorAuditor on RunOnce)

> Address WARN log message in ProcessorAuditor on action RunOnce
> --
>
> Key: NIFI-9824
> URL: https://issues.apache.org/jira/browse/NIFI-9824
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Minor
>
> Noticed a WARN log message while reviewing NiFi logs. Tracked issue down to 
> `if` block in `updateProcessorAdvice()`.
> {code:java}
> // state is now stopped... consider the previous state
> if (ScheduledState.RUNNING.equals(scheduledState)) {
> processorAction.setOperation(Operation.Stop);
> } else if (ScheduledState.DISABLED.equals(scheduledState)) {
> processorAction.setOperation(Operation.Enable);
> }
> {code}
> An additional `else if` is needed to handle the "Run Once" case, where 
> `scheduledState` is "Stopped". Otherwise, the 
> `processorAction.setOperation()` is never called, which results in an NPE in 
> `NifiAuditor.saveActions()`.
> {code:java}
> WARN org.apache.nifi.audit.ProcessorAuditor Unable to record actions: Cannot 
> invoke "org.apache.nifi.action.Operation.name()" because the return value of 
> "org.apache.nifi.action.Action.getOperation()" is null
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Assigned] (MINIFICPP-1779) Verify handling of multiple C2 commands in a single HB response

2022-03-23 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gábor Gyimesi reassigned MINIFICPP-1779:


Assignee: Gábor Gyimesi

> Verify handling of multiple C2 commands in a single HB response
> ---
>
> Key: MINIFICPP-1779
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1779
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Test
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Minor
>
> In theory MiNiFi handles nested C2 commands in a single heartbeat response, 
> but we need to write some tests to verify this.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (MINIFICPP-1779) Verify handling of multiple C2 commands in a single HB response

2022-03-23 Thread Jira
Gábor Gyimesi created MINIFICPP-1779:


 Summary: Verify handling of multiple C2 commands in a single HB 
response
 Key: MINIFICPP-1779
 URL: https://issues.apache.org/jira/browse/MINIFICPP-1779
 Project: Apache NiFi MiNiFi C++
  Issue Type: Test
Reporter: Gábor Gyimesi


In theory MiNiFi handles nested C2 commands in a single heartbeat response, but 
we need to write some tests to verify this.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1152: MINIFICPP-1593 ProcFsMonitor to monitor /proc pseduo filesystem

2022-03-23 Thread GitBox


fgerlits commented on a change in pull request #1152:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1152#discussion_r833187415



##
File path: extensions/procfs/processors/ProcFsMonitor.h
##
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "../ProcFs.h"
+#include "core/Processor.h"
+#include "core/logging/LoggerConfiguration.h"
+#include "core/logging/Logger.h"
+#include "utils/Enum.h"
+
+#include "rapidjson/stream.h"
+#include "rapidjson/document.h"
+
+namespace org::apache::nifi::minifi::extensions::procfs {
+
+class ProcFsMonitor : public core::Processor {
+ public:
+  explicit ProcFsMonitor(const std::string& name, utils::Identifier uuid = 
utils::Identifier())
+  : Processor(name, uuid) {
+  }
+  ProcFsMonitor(const ProcFsMonitor&) = delete;
+  ProcFsMonitor(ProcFsMonitor&&) = delete;
+  ProcFsMonitor& operator=(const ProcFsMonitor&) = delete;
+  ProcFsMonitor& operator=(ProcFsMonitor&&) = delete;
+  ~ProcFsMonitor() override = default;
+
+  static constexpr char const *ProcessorName = "ProcFsMonitor";
+
+  EXTENSIONAPI static const core::Property OutputFormatProperty;
+  EXTENSIONAPI static const core::Property OutputCompactnessProperty;
+  EXTENSIONAPI static const core::Property DecimalPlaces;
+  EXTENSIONAPI static const core::Property ResultRelativenessProperty;
+
+  EXTENSIONAPI static const core::Relationship Success;
+
+
+ public:
+  void onSchedule(const std::shared_ptr& context, const 
std::shared_ptr& sessionFactory) override;
+
+  void onTrigger(core::ProcessContext *context, core::ProcessSession *session) 
override;
+
+  void initialize() override;
+
+  SMART_ENUM(OutputFormat,
+ (JSON, "JSON"),
+ (OPENTELEMETRY, "OpenTelemetry")
+  )
+
+  SMART_ENUM(OutputCompactness,
+ (COMPACT, "Compact"),
+ (PRETTY, "Pretty")
+  )
+
+  SMART_ENUM(ResultRelativeness,
+ (RELATIVE, "Relative"),
+ (ABSOLUTE, "Absolute")
+  )
+
+ private:
+  bool isSingleThreaded() const override {
+return true;
+  }
+
+  core::annotation::Input getInputRequirement() const override {
+return core::annotation::Input::INPUT_FORBIDDEN;
+  }
+
+ protected:
+  rapidjson::Value& prepareJSONBody(rapidjson::Document& root);
+
+  void setupDecimalPlacesFromProperties(const core::ProcessContext& context);
+
+  void processCPUInformation(const std::unordered_map& current_cpu_stats,
+ rapidjson::Value& body,
+ rapidjson::Document::AllocatorType& alloc);
+  void processDiskInformation(const std::unordered_map& current_disk_stats,
+  rapidjson::Value& body,
+  rapidjson::Document::AllocatorType& alloc);
+  void processNetworkInformation(const std::unordered_map& current_net_devs,
+ rapidjson::Value& body,
+ rapidjson::Document::AllocatorType& alloc);
+  void processProcessInformation(const std::unordered_map& 
current_process_stats,
+ std::optional> 
last_cpu_period,
+ rapidjson::Value& body,
+ rapidjson::Document::AllocatorType& alloc);
+  void processMemoryInformation(rapidjson::Value& body,
+rapidjson::Document::AllocatorType& alloc);
+
+  void refreshMembers(std::unordered_map&& 
current_cpu_stats,
+  std::unordered_map&& 
current_disk_stats,
+  std::unordered_map&& 
current_net_devs,
+  std::unordered_map&& 
current_process_stats);
+
+  OutputFormat output_format_ = OutputFormat::JSON;
+  OutputCompactness output_compactness_ = OutputCompactness::PRETTY;
+  ResultRelativeness result_relativeness_ = ResultRelativeness::ABSOLUTE;
+
+  std::optional decimal_places_;
+  std::shared_ptr logger_ = 
core::logging::LoggerFactory::getLogger();
+
+  ProcFs proc_fs_;
+
+  std::unordered_map last_cpu_stats_;
+  std::unordered_map last_net_devs_;
+  std::unordered_map last_disk_stats_;
+  std::unordered_map last_process_stat

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1152: MINIFICPP-1593 ProcFsMonitor to monitor /proc pseduo filesystem

2022-03-23 Thread GitBox


fgerlits commented on a change in pull request #1152:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1152#discussion_r833166269



##
File path: extensions/procfs/processors/ProcFsMonitor.cpp
##
@@ -0,0 +1,282 @@
+/**
+ * @file GenerateFlowFile.cpp
+ * GenerateFlowFile class implementation
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "ProcFsMonitor.h"
+#include 
+#include 
+#include 
+#include 
+
+#include "core/Resource.h"
+#include "core/ProcessContext.h"
+#include "core/ProcessSession.h"
+#include "../ProcFsJsonSerialization.h"
+#include "utils/JsonCallback.h"
+#include "utils/OpenTelemetryLogDataModelUtils.h"
+#include "utils/gsl.h"
+
+using namespace std::literals::chrono_literals;
+
+namespace org::apache::nifi::minifi::extensions::procfs {
+
+const core::Relationship ProcFsMonitor::Success("success", "All files are 
routed to success");
+
+const core::Property ProcFsMonitor::OutputFormatProperty(
+core::PropertyBuilder::createProperty("Output Format")->
+withDescription("The output type of the new flowfile")->
+withAllowableValues(OutputFormat::values())->
+withDefaultValue(toString(OutputFormat::JSON))->build());
+
+const core::Property ProcFsMonitor::OutputCompactnessProperty(
+core::PropertyBuilder::createProperty("Output Compactness")->
+withDescription("The output format of the new flowfile")->
+withAllowableValues(OutputCompactness::values())->
+withDefaultValue(toString(OutputCompactness::PRETTY))->build());
+
+const core::Property ProcFsMonitor::DecimalPlaces(
+core::PropertyBuilder::createProperty("Round to decimal places")->
+withDescription("The number of decimal places to round the values to 
(blank for no rounding)")->build());
+
+const core::Property ProcFsMonitor::ResultRelativenessProperty(
+core::PropertyBuilder::createProperty("Result Type")->
+withDescription("Absolute returns the current procfs values, relative 
calculates the usage between triggers")->
+withAllowableValues(ResultRelativeness::values())->
+withDefaultValue(toString(ResultRelativeness::RELATIVE))->build());
+
+
+void ProcFsMonitor::initialize() {
+  setSupportedProperties({OutputFormatProperty, OutputCompactnessProperty, 
DecimalPlaces, ResultRelativenessProperty});
+  setSupportedRelationships({ProcFsMonitor::Success});
+}
+
+void ProcFsMonitor::onSchedule(const std::shared_ptr& 
context, const std::shared_ptr&) {
+  gsl_Expects(context);
+  context->getProperty(OutputFormatProperty.getName(), output_format_);
+  context->getProperty(OutputCompactnessProperty.getName(), 
output_compactness_);
+  context->getProperty(ResultRelativenessProperty.getName(), 
result_relativeness_);
+  setupDecimalPlacesFromProperties(*context);
+}
+
+namespace {
+size_t number_of_cores(const std::unordered_map& 
cpu_stat) {
+  return cpu_stat.size() > 1 ? cpu_stat.size() - 1 :  1;

Review comment:
   `cpu_stats_are_valid()` requires `cpu_stat.size()` to be more than 1, so 
I would write this instead:
   ```suggestion
 gsl_Expects(cpu_stat.size() > 1);
 return cpu_stat.size() - 1;
   ```

##
File path: extensions/procfs/ProcFsSerialization.h
##
@@ -0,0 +1,183 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+#include 
+#include 
+#include 
+
+#include "CpuStat.h"
+#include "DiskStat.h"
+#include "MemInfo.h"
+#include "NetDev.h"
+#include "ProcessSt

[GitHub] [nifi] exceptionfactory opened a new pull request #5889: NIFI-9823 Remove VolatileContentRepository

2022-03-23 Thread GitBox


exceptionfactory opened a new pull request #5889:
URL: https://github.com/apache/nifi/pull/5889


    Description of PR
   
   NIFI-9823 Removes the `VolatileContentRepository` implementation of the 
`ContentRepository` interface.
   
   Although the volatile implementation has existed since project inception, it 
is subject to a number of feature and performance issues. The implementation 
has been broken since at least NiFi version 1.13.0, such that a number of 
processors fail to read FlowFile content under certain conditions. Recent 
enhancements to the NiFi Stateless engine provide a better path forward in 
terms of memory-based operations. Removing the `VolatileContentRepository`, 
rather than marking it deprecated, avoids potential confusion and clarifies the 
fact that this implementation is not supported.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [X] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [X] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [X] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [X] Have you written or updated unit tests to verify your changes?
   - [X] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [X] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (NIFI-9823) Remove VolatileContentRepository

2022-03-23 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-9823:
---
Status: Patch Available  (was: Open)

> Remove VolatileContentRepository
> 
>
> Key: NIFI-9823
> URL: https://issues.apache.org/jira/browse/NIFI-9823
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>
> The {{VolatileContentRepository}} implementation of the Content Repository 
> interface supports storing FlowFile content claims in heap memory without 
> writing to a file system. Although this capability has potential uses, the 
> implementation is not optimal, and the repository itself has been broken for 
> several releases. Several framework updates to content claim processing 
> result in expected behavior when using the {{VolatileContentRepository}}, 
> leading to problems that can be difficult to troubleshoot. For these reasons, 
> the current {{VolatileContentRepository}} and associated documentation should 
> be removed from future releases.
> Future efforts to support a similar capabilities may build on NiFi Stateless 
> functionality, and those efforts can be addressed in separate issues.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (NIFI-9233) Improve reliability of system integration tests

2022-03-23 Thread Paul Grey (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Grey updated NIFI-9233:

Status: In Progress  (was: Patch Available)

> Improve reliability of system integration tests
> ---
>
> Key: NIFI-9233
> URL: https://issues.apache.org/jira/browse/NIFI-9233
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Tools and Build
>Reporter: David Handermann
>Assignee: Paul Grey
>Priority: Major
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> The {{nifi-system-tests}} module contains multiple integration tests for 
> verifying behavior using minimal instances of NiFi.  The GitHub 
> [system-tests|https://github.com/apache/nifi/actions/workflows/system-tests.yml]
>  workflow fails on some occasions due to apparent timing issues when making 
> requests or evaluating expected results. The polling approach and instance 
> configuration properties should be evaluated for potential improvements to 
> make the tests more reliable in environments with limited resources. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Assigned] (NIFI-9824) Address WARN log message in ProcessorAuditor on processor RunOnce

2022-03-23 Thread Paul Grey (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Grey reassigned NIFI-9824:
---

Assignee: Paul Grey

> Address WARN log message in ProcessorAuditor on processor RunOnce
> -
>
> Key: NIFI-9824
> URL: https://issues.apache.org/jira/browse/NIFI-9824
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Minor
>
> Noticed a WARN log message while reviewing NiFi logs. Tracked issue down to 
> `if` block in `updateProcessorAdvice()`.
> {code:java}
> // state is now stopped... consider the previous state
> if (ScheduledState.RUNNING.equals(scheduledState)) {
> processorAction.setOperation(Operation.Stop);
> } else if (ScheduledState.DISABLED.equals(scheduledState)) {
> processorAction.setOperation(Operation.Enable);
> }
> {code}
> An additional `else if` is needed to handle the "Run Once" case, where 
> `scheduledState` is "Stopped". Otherwise, the 
> `processorAction.setOperation()` is never called, which results in an NPE in 
> `NifiAuditor.saveActions()`.
> {code:java}
> WARN org.apache.nifi.audit.ProcessorAuditor Unable to record actions: Cannot 
> invoke "org.apache.nifi.action.Operation.name()" because the return value of 
> "org.apache.nifi.action.Action.getOperation()" is null
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (NIFI-9574) Connection Load Balancing: Failed to decrypt data from Peer

2022-03-23 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-9574:
---
Summary: Connection Load Balancing: Failed to decrypt data from Peer  (was: 
 Failed to decrypt data from Peer)

> Connection Load Balancing: Failed to decrypt data from Peer
> ---
>
> Key: NIFI-9574
> URL: https://issues.apache.org/jira/browse/NIFI-9574
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Mahieddine Cherif
>Priority: Major
> Attachments: Screenshot 2022-01-14 at 19.21.11.png, Screenshot 
> 2022-01-14 at 19.21.16.png, Screenshot 2022-01-14 at 19.21.36.png, Screenshot 
> 2022-01-14 at 19.21.46.png, activeThread.png, cores.png, flow.png, 
> heapUse.png, version.png
>
>
> After a migration to 1.15.2 it seems like we have almost systematically this 
> error on our cluster all the time 
> {code:java}
> Failed to communicate with Peer 
> nifi-0.nifi-headless.apache-nifi.svc.cluster.local:8443 when load balancing 
> data for Connection with ID b76e7297-e8a0-3b2b-ba30-d338db411301 due to 
> java.io.IOException: Failed to decrypt data from Peer 
> nifi-0.nifi-headless.apache-nifi.svc.cluster.local:8443 because Peer 
> unexpectedly closed connection
> {code}
> Files get stuck in the queue mentioned, it's not always the same, these are 
> simple round robin queues with or without compression. 
> When we recreate the cluster it goes for like some time and then it occurs 
> again and again 
> Is there a particular reason ? 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (NIFI-9695) Load balancing not working

2022-03-23 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511257#comment-17511257
 ] 

David Handermann commented on NIFI-9695:


[~vadidde] The release for 1.16.0 should be available soon. The errors you 
describe should be addressed in 1.16.0, and could be tested in the current 
release candidate version.  Due to the nature of the problem described, there 
do not appear to be any other workarounds.

> Load balancing not working
> --
>
> Key: NIFI-9695
> URL: https://issues.apache.org/jira/browse/NIFI-9695
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.13.2
>Reporter: davide
>Priority: Major
>  Labels: Cluster, balancer, nifi
> Attachments: activeThread.png, cores.png, flow.png, heapUse.png, 
> version.png
>
>
> I have a 3 nodes cluster(as you can see on attached images) with a connection 
> with a Load Balance Strategy set to Partition by attribute, sometimes some 
> flowfiles get stuck in this connection (see image1). Furthermore we have this 
> log error in bulletin board
> {\{10:56:28 UTC ERROR -xxx-xx-nifi0.:8443 }}
> {{Failed to receive FlowFiles for Load Balancing due to 
> org.apache.nifi.controller.queue.clustered.server.TransactionAbortedException:
>  Attempted to receive FlowFiles from Peer -xxx-xx-nifi2. for 
> Connection with ID 0c20343f-f63d-1ef1-8da0-6d3cb9fc670d but no Connection 
> exists with that ID}}
> {{10:56:28 UTC ERROR -xxx-xx-nifi0.:8443}}
> {{{}Failed to communicate with Peer -xxx-xx-nifi2.:8443 when load 
> balancing data for Connection with ID c12f3c02-9f05-1232--f8d925a9 
> due to java.io.IOException: Failed to decrypt data from Peer 
> -xxx-xx-nifi2.:8443 because Peer unexpectedly closed 
> connection{}}}}}{}}}
>  
> The weird thing is that only some flowfiles are stucked other flowfiles goes 
> forward in the flows.
> I think this bug is the same of 
> https://issues.apache.org/jira/browse/NIFI-9574, I post a comment in 
> NIFI-9574 but I have got no answer.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (NIFI-8643) Nifi 1.13.2 Cluster Load balancer connection refused

2022-03-23 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-8643:
---
Summary: Nifi 1.13.2 Cluster Load balancer connection refused  (was: Nifi 
1.13.2 Cluster Load balancer Does not Work Properly )

> Nifi 1.13.2 Cluster Load balancer connection refused
> 
>
> Key: NIFI-8643
> URL: https://issues.apache.org/jira/browse/NIFI-8643
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.13.2
> Environment: 3 node nifi cluster, installed in GCP Centos7 VM
>Reporter: Kristian Mojeno
>Assignee: Joe Gresock
>Priority: Major
> Fix For: 1.14.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> I have upgraded from nifi version 1.12.1 to 1.13.2. After the upgrade, the 
> cluster load balancer does not work properly and then flowfiles get stuck on 
> queue. Then the weird thing is that I can't see any error on logs.
> I've tried to downgrade java from 11 down to version 8 but still same issue 
> exist.
> My nifi cluster has three nodes deployed on a GCP VM.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (NIFI-9825) Execution "Primary node" with incoming connections limitation bug

2022-03-23 Thread Josef Zahner (Jira)
Josef Zahner created NIFI-9825:
--

 Summary: Execution "Primary node" with incoming connections 
limitation bug
 Key: NIFI-9825
 URL: https://issues.apache.org/jira/browse/NIFI-9825
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core UI
Affects Versions: 1.15.3
Reporter: Josef Zahner
 Attachments: Screenshot 2022-03-23 at 13.53.52.png

Somewhen in the past an information for users has been added that if a 
processor can have incoming connections, NiFi prevents the user to set 
execution to "Primary node" only. In theory this is fine, but the problem is, 
the "ExecuteSQL" processor can run with or without incoming connections.

I'm using the processor on a cluster without incoming connections, but I never 
wanna execute the same query on all cluster nodes and it's uncomfortable to set 
a "GenerateFlowFile" processor with "Primary only" execution mode in front of 
the "ExecuteSQL". At the moment I can't set the "ExecuteSQL" to "Primary node" 
only without a *connected* incoming connection as NiFi generates the error 
message "{_}'Execution Node' is invalid because Processors with incoming 
connections cannot be scheduled for Primary Node only{_}". Please check my 
screenshot.

NiFi should not check for the possibility on the processor for incoming 
connections but for real connected connections. Thanks

!Screenshot 2022-03-23 at 13.53.52.png!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi] ahmedshaaban1999 commented on pull request #5862: NIFI-8106 Added an "Are you sure ?" prompt when delete a processor group

2022-03-23 Thread GitBox


ahmedshaaban1999 commented on pull request #5862:
URL: https://github.com/apache/nifi/pull/5862#issuecomment-1076264846


   @mcgilman I have a question. In the deletion of a multi-selection, why after 
the snippet is removed we loop the components of the snippet and remove them 
one by one ? 
   
   ```
// remove all the non connections in the snippet first
   components.each(function (ids, type) {
   if (type !== 'Connection') {
   
nfCanvasUtils.getComponentByType(type).remove(ids);
   }
   });
   
   // then remove all the connections
   if (components.has('Connection')) {
   
nfConnection.remove(components.get('Connection'));
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (MINIFICPP-1770) Add C2 NO_OPERATION response if property update is NoOp

2022-03-23 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gábor Gyimesi resolved MINIFICPP-1770.
--
Fix Version/s: 0.12.0
   Resolution: Fixed

> Add C2 NO_OPERATION response if property update is NoOp
> ---
>
> Key: MINIFICPP-1770
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1770
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Minor
> Fix For: 0.12.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> If a property update through C2 command does not change any of the current 
> values we should return "NO_OPERATION" state value in the operationState of 
> the acknowledge response.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (MINIFICPP-1769) Add current value of properties in C2 agent manifest's update property metadata

2022-03-23 Thread Jira


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gábor Gyimesi resolved MINIFICPP-1769.
--
Fix Version/s: 0.12.0
   Resolution: Fixed

> Add current value of properties in C2 agent manifest's update property 
> metadata
> ---
>
> Key: MINIFICPP-1769
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1769
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Major
> Fix For: 0.12.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Currently the C2 update/properties command has a metadata object 
> "availableProperties" which only contains a propertyName and a validator 
> value for the name and the type of the object. This should be extended with a 
> propertyValue member to contain the current value of that object:
>  
>  
> {code:java}
> {
> "properties": {
> ...
> "properties": {
> "availableProperties": [
> {  
> "validator": "VALID",
> "propertyName": "nifi.version",
> "propertyValue": "0.12.0"
> },
> ...
> ]
>  }
> },  
> "type": "update"
> }{code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (NIFI-9695) Load balancing not working

2022-03-23 Thread davide (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511170#comment-17511170
 ] 

davide commented on NIFI-9695:
--

This issue happens very often, there are other possible fix? [~joewitt] 

> Load balancing not working
> --
>
> Key: NIFI-9695
> URL: https://issues.apache.org/jira/browse/NIFI-9695
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.13.2
>Reporter: davide
>Priority: Major
>  Labels: Cluster, balancer, nifi
> Attachments: activeThread.png, cores.png, flow.png, heapUse.png, 
> version.png
>
>
> I have a 3 nodes cluster(as you can see on attached images) with a connection 
> with a Load Balance Strategy set to Partition by attribute, sometimes some 
> flowfiles get stuck in this connection (see image1). Furthermore we have this 
> log error in bulletin board
> {\{10:56:28 UTC ERROR -xxx-xx-nifi0.:8443 }}
> {{Failed to receive FlowFiles for Load Balancing due to 
> org.apache.nifi.controller.queue.clustered.server.TransactionAbortedException:
>  Attempted to receive FlowFiles from Peer -xxx-xx-nifi2. for 
> Connection with ID 0c20343f-f63d-1ef1-8da0-6d3cb9fc670d but no Connection 
> exists with that ID}}
> {{10:56:28 UTC ERROR -xxx-xx-nifi0.:8443}}
> {{{}Failed to communicate with Peer -xxx-xx-nifi2.:8443 when load 
> balancing data for Connection with ID c12f3c02-9f05-1232--f8d925a9 
> due to java.io.IOException: Failed to decrypt data from Peer 
> -xxx-xx-nifi2.:8443 because Peer unexpectedly closed 
> connection{}}}}}{}}}
>  
> The weird thing is that only some flowfiles are stucked other flowfiles goes 
> forward in the flows.
> I think this bug is the same of 
> https://issues.apache.org/jira/browse/NIFI-9574, I post a comment in 
> NIFI-9574 but I have got no answer.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1281: MINIFICPP-1769 Add propertyValue to agent manifest metadata

2022-03-23 Thread GitBox


adamdebreceni closed pull request #1281:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1281


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Resolved] (MINIFICPP-1764) Add a license header to every .py and .feature file

2022-03-23 Thread Ferenc Gerlits (Jira)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ferenc Gerlits resolved MINIFICPP-1764.
---
Resolution: Fixed

> Add a license header to every .py and .feature file
> ---
>
> Key: MINIFICPP-1764
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1764
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Task
>Affects Versions: 0.12.0
>Reporter: Ferenc Gerlits
>Assignee: Ferenc Gerlits
>Priority: Trivial
> Fix For: 0.12.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Most of our Python files and Behave feature specifications lack an Apache 
> license header.  Please add one.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (MINIFICPP-1734) Create a version of the TailFile processor which can be used as a Kubernetes pod for log collection

2022-03-23 Thread Ferenc Gerlits (Jira)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ferenc Gerlits resolved MINIFICPP-1734.
---
Resolution: Fixed

> Create a version of the TailFile processor which can be used as a Kubernetes 
> pod for log collection
> ---
>
> Key: MINIFICPP-1734
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1734
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Ferenc Gerlits
>Assignee: Ferenc Gerlits
>Priority: Major
> Fix For: 0.12.0
>
>  Time Spent: 11h 10m
>  Remaining Estimate: 0h
>
> Following [~lordgamez]'s design,
> * create a controller service which can collect the pods (including 
> namespace, pod name, pod uid) and containers available on the current 
> Kubernetes node, and
> * create a processor which can collect logs from all these containers, 
> subject to regular expression filters.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (MINIFICPP-1762) Add pod name attribute to flow files created by TailFile in the Kubernetes use case

2022-03-23 Thread Ferenc Gerlits (Jira)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ferenc Gerlits resolved MINIFICPP-1762.
---
Resolution: Fixed

> Add pod name attribute to flow files created by TailFile in the Kubernetes 
> use case
> ---
>
> Key: MINIFICPP-1762
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1762
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Ferenc Gerlits
>Assignee: Ferenc Gerlits
>Priority: Minor
> Fix For: 0.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is an extension of MINIFICPP-1734.  Flow files produced by TailFile in 
> the Kubernetes use case have attributes like this:
> {noformat}
> FlowFile Attributes Map Content
> key:TextFragmentAttribute.base_name value:0
> key:TextFragmentAttribute.offset value:3431278
> key:TextFragmentAttribute.post_name value:log
> key:absolute.path 
> value:/var/log/pods/default_counter_dd5befc8-5573-40c3-a136-8daf6eb77b01/count/0.log
> key:filename value:0.3431278-3431357.log
> key:flow.id value:cbd22e73-f01b-43ee-aa73-a28963dc1d56
> key:path 
> value:/var/log/pods/default_counter_dd5befc8-5573-40c3-a136-8daf6eb77b01/count
> {noformat}
> In order to make it easier to separate flow files coming from the logs of 
> different pods, it would be useful to add some more attributes, for example:
> {noformat}
> key:kubernetes.namespace value:default
> key:kubernetes.pod value:counter
> key:kubernetes.uid value:dd5befc8-5573-40c3-a136-8daf6eb77b01
> key:kubernetes.container value:count
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1281: MINIFICPP-1769 Add propertyValue to agent manifest metadata

2022-03-23 Thread GitBox


adam-markovics commented on a change in pull request #1281:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1281#discussion_r833055384



##
File path: extensions/http-curl/tests/C2ClearCoreComponentStateTest.cpp
##
@@ -65,7 +65,9 @@ class VerifyC2ClearCoreComponentState : public VerifyC2Base {
 
 class ClearCoreComponentStateHandler: public HeartbeatHandler {
  public:
-  explicit ClearCoreComponentStateHandler(std::atomic_bool& 
component_cleared_successfully) : 
component_cleared_successfully_(component_cleared_successfully) {
+  explicit ClearCoreComponentStateHandler(std::atomic_bool& 
component_cleared_successfully, std::shared_ptr 
configuration)
+: HeartbeatHandler(std::move(configuration)),
+  component_cleared_successfully_(component_cleared_successfully) {

Review comment:
   Oh, I see. I just opened my IDE which said it was unused and I believed 
it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] ahmedshaaban1999 commented on pull request #5862: NIFI-8106 Added an "Are you sure ?" prompt when delete a processor group

2022-03-23 Thread GitBox


ahmedshaaban1999 commented on pull request #5862:
URL: https://github.com/apache/nifi/pull/5862#issuecomment-1076153175


   Thanks for the feedback,
   
   @thenatog that's strange, I have been facing some problems with whitespaces 
recently, I will try to double check them using vi and notepadd++ 
   
   @mcgilman your points are spot on. I tried to tackle both points at first 
but wasn't successful, though to myself that I can divide the work into two 
jira tickets. but I agree to get all things done in this ticket. I am currently 
working on refactoring to make use of the common code as much as possible and 
at the same time make the message appear when multi-select.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org