[jira] [Commented] (NIFI-9950) NiFi Registry selecting incorrect DB scripts for MariaDB
[ https://issues.apache.org/jira/browse/NIFI-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526171#comment-17526171 ] ASF subversion and git services commented on NIFI-9950: --- Commit 3a15d4fbe5c35a4c5adcf1e1046a37cfd8c12b89 in nifi's branch refs/heads/main from Bryan Bende [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3a15d4fbe5 ] NIFI-9950 Identify MariaDB database type and use MySQL migration scripts Signed-off-by: Nathan Gough This closes 5989. > NiFi Registry selecting incorrect DB scripts for MariaDB > > > Key: NIFI-9950 > URL: https://issues.apache.org/jira/browse/NIFI-9950 > Project: Apache NiFi > Issue Type: Task >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Flyway previously identified MariaDB as type "MYSQL" and now it identifies it > as "MARIADB". > Our scripts are divided into three categories: > * MySQL > * Postgres > * Default (H2) > Since MariaDB is not longer being identified as MySQL, it is falling into the > third category and trying to run the default scripts against MariaDB, which > fails and isn't expected to work. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [nifi] thenatog commented on pull request #5989: NIFI-9950 Identify MariaDB database type and use MySQL migration scripts
thenatog commented on PR #5989: URL: https://github.com/apache/nifi/pull/5989#issuecomment-1105940090 Without this fix and running **mvn clean install -Dspring.profiles.active=mariadb-10-2** in ./nifi/nifi-registry I see: > [ERROR] org.apache.nifi.registry.db.TestDatabaseMetadataService.testGetExtensionBundleVersionByBucketGroupArtifactVersion Time elapsed: 0 s <<< ERROR! java.lang.IllegalStateException: Failed to load ApplicationContext Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'databaseKeyService' defined in file [/Users/ngough/IdeaProjects/nifi-fresh/nifi-registry/nifi-registry-core/nifi-registry-framework/target/classes/org/apache/nifi/registry/db/DatabaseKeyService.class]: Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'flywayInitializer' defined in class path resource [org/springframework/boot/autoconfigure/flyway/FlywayAutoConfiguration$FlywayConfiguration.class]: Invocation of init method failed; nested exception is org.flywaydb.core.api.exception.FlywayValidateException: Validate failed: Migrations have failed validation Detected failed migration to version 2 (Initial). Please remove any half-completed changes then run repair to fix the schema history. Need more flexibility with validation rules? Learn more: https://rd.gt/3AbJUZE Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'flywayInitializer' defined in class path resource [org/springframework/boot/autoconfigure/flyway/FlywayAutoConfiguration$FlywayConfiguration.class]: Invocation of init method failed; nested exception is org.flywaydb.core.api.exception.FlywayValidateException: Validate failed: Migrations have failed validation Detected failed migration to version 2 (Initial). Please remove any half-completed changes then run repair to fix the schema history. Need more flexibility with validation rules? Learn more: https://rd.gt/3AbJUZE Caused by: org.flywaydb.core.api.exception.FlywayValidateException: Validate failed: Migrations have failed validation Detected failed migration to version 2 (Initial). Please remove any half-completed changes then run repair to fix the schema history. Need more flexibility with validation rules? Learn more: https://rd.gt/3AbJUZE and with this PR it looks all fixed: >[INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 03:59 min +1 will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #5989: NIFI-9950 Identify MariaDB database type and use MySQL migration scripts
thenatog commented on PR #5989: URL: https://github.com/apache/nifi/pull/5989#issuecomment-1105922280 Will review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] github-actions[bot] closed pull request #5579: NIFI-9449: Implement login redirects to specified URLs
github-actions[bot] closed pull request #5579: NIFI-9449: Implement login redirects to specified URLs URL: https://github.com/apache/nifi/pull/5579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-9950) NiFi Registry selecting incorrect DB scripts for MariaDB
[ https://issues.apache.org/jira/browse/NIFI-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-9950: -- Status: Patch Available (was: Open) > NiFi Registry selecting incorrect DB scripts for MariaDB > > > Key: NIFI-9950 > URL: https://issues.apache.org/jira/browse/NIFI-9950 > Project: Apache NiFi > Issue Type: Task >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Flyway previously identified MariaDB as type "MYSQL" and now it identifies it > as "MARIADB". > Our scripts are divided into three categories: > * MySQL > * Postgres > * Default (H2) > Since MariaDB is not longer being identified as MySQL, it is falling into the > third category and trying to run the default scripts against MariaDB, which > fails and isn't expected to work. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [nifi] bbende opened a new pull request, #5989: NIFI-9950 Identify MariaDB database type and use MySQL migration scripts
bbende opened a new pull request, #5989: URL: https://github.com/apache/nifi/pull/5989 Build NiFi Registry with `-Ptest-all-dbs` or specify `-Dspring.profiles.active=mariadb-10-3` or `-Dspring.profiles.active=mariadb-10-2`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-1807) Improve stat() error logging
[ https://issues.apache.org/jira/browse/MINIFICPP-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-1807: Status: Patch Available (was: In Progress) https://github.com/apache/nifi-minifi-cpp/pull/1311 > Improve stat() error logging > > > Key: MINIFICPP-1807 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1807 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Marton Szasz >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Because I got a random error from UnfocusArchiveEntry and didn't know what it > meant. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (NIFI-9901) Implement Module for Common XML Utilities
[
https://issues.apache.org/jira/browse/NIFI-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526019#comment-17526019
]
ASF subversion and git services commented on NIFI-9901:
---
Commit 3affd57efbc760dc109ea78a1b39446f3f817018 in nifi's branch
refs/heads/support/nifi-1.16 from Joe Witt
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3affd57efb ]
NIFI-9901 fixing version references
> Implement Module for Common XML Utilities
> -
>
> Key: NIFI-9901
> URL: https://issues.apache.org/jira/browse/NIFI-9901
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.16.0
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The {{nifi-security-utils}} module includes several classes for working with
> various Java XML components. These classes are self-contained, and do not
> require the set of dependencies listed for {{{}nifi-security-utils{}}}.
> Refactoring these classes to a new module under {{nifi-commons}} would
> streamline the dependency tree for other modules that do not need Bouncy
> Castle or other dependencies of {{{}nifi-security-utils{}}}.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (NIFI-9949) Intermittent Failures in TestPutSFTP testPutSFTPBatching
[
https://issues.apache.org/jira/browse/NIFI-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9949:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Intermittent Failures in TestPutSFTP testPutSFTPBatching
>
>
> Key: NIFI-9949
> URL: https://issues.apache.org/jira/browse/NIFI-9949
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Several recent GitHub automated builds have failed in the
> {{TestPutSFTP.testPutSFTPBatching}} method with the following error:
> {noformat}
> Error: Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.376 s <<< FAILURE! - in org.apache.nifi.processors.standard.TestPutSFTP
> Error: org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching
> Time elapsed: 0.045 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: expected: <2> but was: <0>
> at
> org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching(TestPutSFTP.java:233)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (NIFI-9949) Intermittent Failures in TestPutSFTP testPutSFTPBatching
[
https://issues.apache.org/jira/browse/NIFI-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526017#comment-17526017
]
ASF subversion and git services commented on NIFI-9949:
---
Commit 4b7f8cbe1f860dc99d72a86ea3c211c86b2f7aa8 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4b7f8cbe1f ]
NIFI-9949 This closes #5988. Corrected intermittent failures in TestPutSFTP
- Changed SSH server to start and stop after each method
- Replaced queued file with string FlowFile contents
- Refactored TestPutSFTP using JUnit 5
Signed-off-by: Joe Witt
> Intermittent Failures in TestPutSFTP testPutSFTPBatching
>
>
> Key: NIFI-9949
> URL: https://issues.apache.org/jira/browse/NIFI-9949
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Several recent GitHub automated builds have failed in the
> {{TestPutSFTP.testPutSFTPBatching}} method with the following error:
> {noformat}
> Error: Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.376 s <<< FAILURE! - in org.apache.nifi.processors.standard.TestPutSFTP
> Error: org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching
> Time elapsed: 0.045 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: expected: <2> but was: <0>
> at
> org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching(TestPutSFTP.java:233)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (NIFI-9949) Intermittent Failures in TestPutSFTP testPutSFTPBatching
[
https://issues.apache.org/jira/browse/NIFI-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526018#comment-17526018
]
ASF subversion and git services commented on NIFI-9949:
---
Commit a50c6c63b602a0516895fd35b0c24afcb0027e23 in nifi's branch
refs/heads/support/nifi-1.16 from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a50c6c63b6 ]
NIFI-9949 Corrected intermittent failures in TestPutSFTP
- Changed SSH server to start and stop after each method
- Replaced queued file with string FlowFile contents
- Refactored TestPutSFTP using JUnit 5
> Intermittent Failures in TestPutSFTP testPutSFTPBatching
>
>
> Key: NIFI-9949
> URL: https://issues.apache.org/jira/browse/NIFI-9949
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Several recent GitHub automated builds have failed in the
> {{TestPutSFTP.testPutSFTPBatching}} method with the following error:
> {noformat}
> Error: Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.376 s <<< FAILURE! - in org.apache.nifi.processors.standard.TestPutSFTP
> Error: org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching
> Time elapsed: 0.045 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: expected: <2> but was: <0>
> at
> org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching(TestPutSFTP.java:233)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [nifi] asfgit closed pull request #5988: NIFI-9949 Correct intermittent failures in TestPutSFTP
asfgit closed pull request #5988: NIFI-9949 Correct intermittent failures in TestPutSFTP URL: https://github.com/apache/nifi/pull/5988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1315: MINIFICPP-1810 Provide logs to be read from docker logs
szaszm commented on code in PR #1315:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1315#discussion_r855526559
##
docker/Dockerfile:
##
@@ -174,9 +174,12 @@ RUN addgroup -g ${GID} ${USER} && adduser -u ${UID} -D -G
${USER} -g "" ${USER}
# Copy built minifi distribution from builder
COPY --from=build --chown=${USER}:${USER} ${MINIFI_VERSIONED_HOME}
${MINIFI_HOME}
+RUN mkdir ${MINIFI_HOME}/scripts
+COPY --from=build --chown=${USER}:${USER}
${MINIFI_BASE_DIR}/docker/scripts/start.sh ${MINIFI_HOME}/scripts
+RUN chmod +x ${MINIFI_HOME}/scripts/start.sh
USER ${USER}
WORKDIR ${MINIFI_HOME}
# Start MiNiFi CPP in the foreground
-CMD ["./bin/minifi.sh", "run"]
+CMD ["./scripts/start.sh"]
Review Comment:
stderr would be even better if docker and k8s is capable of using that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1315: MINIFICPP-1810 Provide logs to be read from docker logs
szaszm commented on code in PR #1315:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1315#discussion_r855525744
##
docker/Dockerfile:
##
@@ -174,9 +174,12 @@ RUN addgroup -g ${GID} ${USER} && adduser -u ${UID} -D -G
${USER} -g "" ${USER}
# Copy built minifi distribution from builder
COPY --from=build --chown=${USER}:${USER} ${MINIFI_VERSIONED_HOME}
${MINIFI_HOME}
+RUN mkdir ${MINIFI_HOME}/scripts
+COPY --from=build --chown=${USER}:${USER}
${MINIFI_BASE_DIR}/docker/scripts/start.sh ${MINIFI_HOME}/scripts
+RUN chmod +x ${MINIFI_HOME}/scripts/start.sh
USER ${USER}
WORKDIR ${MINIFI_HOME}
# Start MiNiFi CPP in the foreground
-CMD ["./bin/minifi.sh", "run"]
+CMD ["./scripts/start.sh"]
Review Comment:
Instead of this script, we should configure the minifi logger to output logs
to stdout, through `minifi-log.properties`. Can we do that in the context of
the docker image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-9943) Implement Shared Components for XML Transformation
[
https://issues.apache.org/jira/browse/NIFI-9943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9943:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Implement Shared Components for XML Transformation
> --
>
> Key: NIFI-9943
> URL: https://issues.apache.org/jira/browse/NIFI-9943
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework, Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The {{nifi-xml-processing}} module includes shared components for handling
> XML using DOM, SAX, and StAX interfaces. With various uses of XML
> Transformation across the framework, the module should be expanded to include
> shared components for XSLT processing.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (NIFI-9943) Implement Shared Components for XML Transformation
[
https://issues.apache.org/jira/browse/NIFI-9943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526008#comment-17526008
]
ASF subversion and git services commented on NIFI-9943:
---
Commit 1ae55e1c7540d995e07182e400276ad6e58ea8ae in nifi's branch
refs/heads/support/nifi-1.16 from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1ae55e1c75 ]
NIFI-9943 Added Transform Provider to nifi-xml-processing
- Refactored TransformerFactory references using StandardTransformerProvider
This closes #5986
Signed-off-by: Paul Grey
> Implement Shared Components for XML Transformation
> --
>
> Key: NIFI-9943
> URL: https://issues.apache.org/jira/browse/NIFI-9943
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework, Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The {{nifi-xml-processing}} module includes shared components for handling
> XML using DOM, SAX, and StAX interfaces. With various uses of XML
> Transformation across the framework, the module should be expanded to include
> shared components for XSLT processing.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (NIFI-9950) NiFi Registry selecting incorrect DB scripts for MariaDB
Bryan Bende created NIFI-9950: - Summary: NiFi Registry selecting incorrect DB scripts for MariaDB Key: NIFI-9950 URL: https://issues.apache.org/jira/browse/NIFI-9950 Project: Apache NiFi Issue Type: Task Reporter: Bryan Bende Assignee: Bryan Bende Flyway previously identified MariaDB as type "MYSQL" and now it identifies it as "MARIADB". Our scripts are divided into three categories: * MySQL * Postgres * Default (H2) Since MariaDB is not longer being identified as MySQL, it is falling into the third category and trying to run the default scripts against MariaDB, which fails and isn't expected to work. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (NIFI-9943) Implement Shared Components for XML Transformation
[
https://issues.apache.org/jira/browse/NIFI-9943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526003#comment-17526003
]
ASF subversion and git services commented on NIFI-9943:
---
Commit b288810316f7ecbc3ec943f64284f0494379b371 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b288810316 ]
NIFI-9943 Added Transform Provider to nifi-xml-processing
- Refactored TransformerFactory references using StandardTransformerProvider
This closes #5986
Signed-off-by: Paul Grey
> Implement Shared Components for XML Transformation
> --
>
> Key: NIFI-9943
> URL: https://issues.apache.org/jira/browse/NIFI-9943
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework, Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The {{nifi-xml-processing}} module includes shared components for handling
> XML using DOM, SAX, and StAX interfaces. With various uses of XML
> Transformation across the framework, the module should be expanded to include
> shared components for XSLT processing.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [nifi] greyp9 closed pull request #5986: NIFI-9943 Add Transform Provider to nifi-xml-processing
greyp9 closed pull request #5986: NIFI-9943 Add Transform Provider to nifi-xml-processing URL: https://github.com/apache/nifi/pull/5986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-9949) Intermittent Failures in TestPutSFTP testPutSFTPBatching
[
https://issues.apache.org/jira/browse/NIFI-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9949:
---
Fix Version/s: 1.17.0
1.16.1
> Intermittent Failures in TestPutSFTP testPutSFTPBatching
>
>
> Key: NIFI-9949
> URL: https://issues.apache.org/jira/browse/NIFI-9949
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Several recent GitHub automated builds have failed in the
> {{TestPutSFTP.testPutSFTPBatching}} method with the following error:
> {noformat}
> Error: Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.376 s <<< FAILURE! - in org.apache.nifi.processors.standard.TestPutSFTP
> Error: org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching
> Time elapsed: 0.045 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: expected: <2> but was: <0>
> at
> org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching(TestPutSFTP.java:233)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [nifi] joewitt commented on pull request #5988: NIFI-9949 Correct intermittent failures in TestPutSFTP
joewitt commented on PR #5988: URL: https://github.com/apache/nifi/pull/5988#issuecomment-1105653075 reviewed code changes and all very welcome. Running a full clean build/contrib check now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #5977: NIFI-9936: Added enum support in PropertyDescriptor Builder for Allow…
exceptionfactory commented on code in PR #5977:
URL: https://github.com/apache/nifi/pull/5977#discussion_r855497812
##
nifi-api/src/main/java/org/apache/nifi/components/Allowable.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.components;
+
+public interface Allowable {
Review Comment:
Recommend renaming this interface to `DescribedValue`, which should
communicate the purpose more clearly.
##
nifi-api/src/main/java/org/apache/nifi/components/Allowable.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.components;
+
+public interface Allowable {
+
+String getDisplayName();
+String getDescription();
Review Comment:
With these methods being proposed as part of the `nifi-api` module, they
should have basic Java documentation indicating the general contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-9949) Intermittent Failures in TestPutSFTP testPutSFTPBatching
[
https://issues.apache.org/jira/browse/NIFI-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-9949:
---
Status: Patch Available (was: Open)
> Intermittent Failures in TestPutSFTP testPutSFTPBatching
>
>
> Key: NIFI-9949
> URL: https://issues.apache.org/jira/browse/NIFI-9949
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Several recent GitHub automated builds have failed in the
> {{TestPutSFTP.testPutSFTPBatching}} method with the following error:
> {noformat}
> Error: Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.376 s <<< FAILURE! - in org.apache.nifi.processors.standard.TestPutSFTP
> Error: org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching
> Time elapsed: 0.045 s <<< FAILURE!
> org.opentest4j.AssertionFailedError: expected: <2> but was: <0>
> at
> org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching(TestPutSFTP.java:233)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [nifi] exceptionfactory opened a new pull request, #5988: NIFI-9949 Correct intermittent failures in TestPutSFTP
exceptionfactory opened a new pull request, #5988:
URL: https://github.com/apache/nifi/pull/5988
Description of PR
NIFI-9949 Updates `TestPutSFTP` to reduce the possibility of intermittent
failures during automated builds. Changes include starting and stopping the
test SSH server for each method and refactoring the test to use JUnit 5.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-9941) adjust LifecycleState to correctly handle ReportingTask shutdown request
[ https://issues.apache.org/jira/browse/NIFI-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-9941: --- Fix Version/s: 1.16.1 > adjust LifecycleState to correctly handle ReportingTask shutdown request > > > Key: NIFI-9941 > URL: https://issues.apache.org/jira/browse/NIFI-9941 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Grey >Assignee: Paul Grey >Priority: Minor > Fix For: 1.17.0, 1.16.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > https://github.com/apache/nifi/actions/runs/2186739044 > An edge case in the teardown of ReportingTaskIT surfaced a possible issue in > the synchronization of the reporting task shutdown. The "stop" request was > received and scheduled, but service activity caused asynchronous processing > of the request to be delayed, causing the test failure. > Implement a means of effecting the stop in a timely manner. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (NIFI-9883) Refactor Property Protection Modules for Isolated Loading
[
https://issues.apache.org/jira/browse/NIFI-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525942#comment-17525942
]
ASF subversion and git services commented on NIFI-9883:
---
Commit 99f5f96ed1e519b9fffa0da8eae20866d69f5b9f in nifi's branch
refs/heads/support/nifi-1.16 from Bryan Bende
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=99f5f96ed1 ]
NIFI-9883 Updated Ranger assembly exclude property protection modules
This closes #5987
Signed-off-by: David Handermann
> Refactor Property Protection Modules for Isolated Loading
> -
>
> Key: NIFI-9883
> URL: https://issues.apache.org/jira/browse/NIFI-9883
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The {{nifi-property-protection}} modules include a large number of transitive
> dependencies as a result of leveraging libraries from different service
> providers. These dependencies can result in runtime conflicts due to the lack
> of isolation when loading classes. Both the bootstrap and framework modules
> depend on these modules. The loading approach should be refactored to
> implementation isolated loading in order to avoid runtime conflicts.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (NIFI-9941) adjust LifecycleState to correctly handle ReportingTask shutdown request
[ https://issues.apache.org/jira/browse/NIFI-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525943#comment-17525943 ] ASF subversion and git services commented on NIFI-9941: --- Commit 958baa0bba657cc9b8b8b58e14c13e5b836e0344 in nifi's branch refs/heads/support/nifi-1.16 from Paul Grey [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=958baa0bba ] NIFI-9941 - fix handling of ReportingTask stop request Signed-off-by: Matthew Burgess This closes #5985 > adjust LifecycleState to correctly handle ReportingTask shutdown request > > > Key: NIFI-9941 > URL: https://issues.apache.org/jira/browse/NIFI-9941 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Grey >Assignee: Paul Grey >Priority: Minor > Fix For: 1.17.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > https://github.com/apache/nifi/actions/runs/2186739044 > An edge case in the teardown of ReportingTaskIT surfaced a possible issue in > the synchronization of the reporting task shutdown. The "stop" request was > received and scheduled, but service activity caused asynchronous processing > of the request to be delayed, causing the test failure. > Implement a means of effecting the stop in a timely manner. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (NIFI-9941) adjust LifecycleState to correctly handle ReportingTask shutdown request
[ https://issues.apache.org/jira/browse/NIFI-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-9941: --- Fix Version/s: 1.17.0 Resolution: Fixed Status: Resolved (was: Patch Available) > adjust LifecycleState to correctly handle ReportingTask shutdown request > > > Key: NIFI-9941 > URL: https://issues.apache.org/jira/browse/NIFI-9941 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Grey >Assignee: Paul Grey >Priority: Minor > Fix For: 1.17.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > https://github.com/apache/nifi/actions/runs/2186739044 > An edge case in the teardown of ReportingTaskIT surfaced a possible issue in > the synchronization of the reporting task shutdown. The "stop" request was > received and scheduled, but service activity caused asynchronous processing > of the request to be delayed, causing the test failure. > Implement a means of effecting the stop in a timely manner. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (NIFI-9941) adjust LifecycleState to correctly handle ReportingTask shutdown request
[ https://issues.apache.org/jira/browse/NIFI-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525937#comment-17525937 ] ASF subversion and git services commented on NIFI-9941: --- Commit 4450f4ce50f23e5fc185a2597b3f891cbc7f820f in nifi's branch refs/heads/main from Paul Grey [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4450f4ce50 ] NIFI-9941 - fix handling of ReportingTask stop request Signed-off-by: Matthew Burgess This closes #5985 > adjust LifecycleState to correctly handle ReportingTask shutdown request > > > Key: NIFI-9941 > URL: https://issues.apache.org/jira/browse/NIFI-9941 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Grey >Assignee: Paul Grey >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > https://github.com/apache/nifi/actions/runs/2186739044 > An edge case in the teardown of ReportingTaskIT surfaced a possible issue in > the synchronization of the reporting task shutdown. The "stop" request was > received and scheduled, but service activity caused asynchronous processing > of the request to be delayed, causing the test failure. > Implement a means of effecting the stop in a timely manner. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [nifi] mattyb149 commented on pull request #5985: NIFI-9941 - fix handling of ReportingTask stop request
mattyb149 commented on PR #5985: URL: https://github.com/apache/nifi/pull/5985#issuecomment-1105598619 +1 LGTM, thanks for the fix! Merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #5985: NIFI-9941 - fix handling of ReportingTask stop request
mattyb149 closed pull request #5985: NIFI-9941 - fix handling of ReportingTask stop request URL: https://github.com/apache/nifi/pull/5985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-9949) Intermittent Failures in TestPutSFTP testPutSFTPBatching
David Handermann created NIFI-9949:
--
Summary: Intermittent Failures in TestPutSFTP testPutSFTPBatching
Key: NIFI-9949
URL: https://issues.apache.org/jira/browse/NIFI-9949
Project: Apache NiFi
Issue Type: Bug
Reporter: David Handermann
Assignee: David Handermann
Several recent GitHub automated builds have failed in the
{{TestPutSFTP.testPutSFTPBatching}} method with the following error:
{noformat}
Error: Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.376
s <<< FAILURE! - in org.apache.nifi.processors.standard.TestPutSFTP
Error: org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching
Time elapsed: 0.045 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <2> but was: <0>
at
org.apache.nifi.processors.standard.TestPutSFTP.testPutSFTPBatching(TestPutSFTP.java:233)
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (NIFI-9942) Remove Load Test method from TestPutUDP
[
https://issues.apache.org/jira/browse/NIFI-9942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9942:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Remove Load Test method from TestPutUDP
> ---
>
> Key: NIFI-9942
> URL: https://issues.apache.org/jira/browse/NIFI-9942
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions, Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Trivial
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The {{TestPutUDP}} class includes a method that tests sending 500 messages,
> requiring 500 invocations of the {{PutUDP}} processor. This kind of test is
> not optimal for automated builds, and can be subject to intermittent
> failures, so it should be removed.
> {noformat}
> Error: Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 31.211 s <<< FAILURE! - in org.apache.nifi.processors.standard.TestPutUDP
> Error: org.apache.nifi.processors.standard.TestPutUDP.testLoadTest Time
> elapsed: 30.107 s <<< ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 3
> milliseconds
> at
> app//org.apache.nifi.processors.standard.TestPutUDP.checkReceivedAllData(TestPutUDP.java:229)
> at
> app//org.apache.nifi.processors.standard.TestPutUDP.testLoadTest(TestPutUDP.java:173)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (NIFI-9942) Remove Load Test method from TestPutUDP
[
https://issues.apache.org/jira/browse/NIFI-9942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9942:
---
Fix Version/s: 1.17.0
1.16.1
> Remove Load Test method from TestPutUDP
> ---
>
> Key: NIFI-9942
> URL: https://issues.apache.org/jira/browse/NIFI-9942
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions, Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Trivial
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The {{TestPutUDP}} class includes a method that tests sending 500 messages,
> requiring 500 invocations of the {{PutUDP}} processor. This kind of test is
> not optimal for automated builds, and can be subject to intermittent
> failures, so it should be removed.
> {noformat}
> Error: Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 31.211 s <<< FAILURE! - in org.apache.nifi.processors.standard.TestPutUDP
> Error: org.apache.nifi.processors.standard.TestPutUDP.testLoadTest Time
> elapsed: 30.107 s <<< ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 3
> milliseconds
> at
> app//org.apache.nifi.processors.standard.TestPutUDP.checkReceivedAllData(TestPutUDP.java:229)
> at
> app//org.apache.nifi.processors.standard.TestPutUDP.testLoadTest(TestPutUDP.java:173)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (NIFI-9861) Stateless ClassLoader isolation does not work on Java 11
[
https://issues.apache.org/jira/browse/NIFI-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9861:
---
Fix Version/s: 1.16.1
> Stateless ClassLoader isolation does not work on Java 11
>
>
> Key: NIFI-9861
> URL: https://issues.apache.org/jira/browse/NIFI-9861
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Stateless ClassLoader isolation implementation (NIFI-9576) expects that the
> system class loader is an {{URLClassLoader}} instance but it is not true for
> Java 11. Due to this, {{BlockListClassLoader}} gets initialized with an empty
> set of classes and it cannot block anything (there is no isolation, otherwise
> it works on Java 11 as before NIFI-9576)
> [https://github.com/apache/nifi/blob/7fde2bbfd1afdd6037765340eca9fc675542323e/nifi-stateless/nifi-stateless-bootstrap/src/main/java/org/apache/nifi/stateless/bootstrap/StatelessBootstrap.java#L150-L153]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (NIFI-9938) Correct error message for PublishKafkaRecord_2_6 and PublishKafka_2_6
[
https://issues.apache.org/jira/browse/NIFI-9938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9938:
---
Fix Version/s: 1.16.1
> Correct error message for PublishKafkaRecord_2_6 and PublishKafka_2_6
> -
>
> Key: NIFI-9938
> URL: https://issues.apache.org/jira/browse/NIFI-9938
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.15.0, 1.16.0, 1.15.1, 1.15.2, 1.15.3, 1.16.1
>Reporter: RAVINARAYAN SINGH
>Priority: Major
> Labels: bulletins
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I am trying to read bulletin and I have observed two kind of message like
> below, one has bulletinFlowFileUuid and other won't have (as i notice they
> have uuid in bulletin message )
> {code:java}
> {
> "objectId" : "133daa29-c7a2-4e27-8280-93515afe21e8",
> "platform" : "nifi",
> "bulletinId" : 73,
> "bulletinCategory" : "Log Message",
> "bulletinGroupId" : "0180100d-8831-1705-c91e-fcf56119b794",
> "bulletinGroupName" : "",
> "bulletinGroupPath" : "",
> "bulletinLevel" : "ERROR",
> "bulletinMessage" :
> "PublishKafkaRecord_2_6[id=8831175d-101e-1180-d015-af879f9a08a3] Failed to
> send
> StandardFlowFileRecord[uuid=a2ae7ce6-cc6a-431a-a07c-a27eae803574,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1650393486592-12, container=default,
> section=12], offset=0,
> length=1068652],offset=0,name=aadbb17b-a59d-4d54-9054-4b38afb939f3,size=1068652]
> to Kafka: org.apache.kafka.common.errors.RecordTooLargeException: The
> message is 1068740 bytes when serialized which is larger than 1048576, which
> is the value of the max.request.size configuration.",
> "bulletinSourceId" : "8831175d-101e-1180-d015-af879f9a08a3",
> "bulletinSourceName" : "PublishKafkaRecord_2_6",
> "bulletinSourceType" : "PROCESSOR",
> "bulletinTimestamp" : "2022-04-19T18:38:20.721Z"
> }
> {
> "objectId" : "8af0eda1-4911-471f-811c-f914f560496d",
> "platform" : "nifi",
> "bulletinId" : 70,
> "bulletinCategory" : "Log Message",
> "bulletinGroupId" : "8831179e-1014-1180-9473-af0432d259ad",
> "bulletinGroupName" : "BulletinPublisher",
> "bulletinGroupPath" : "NiFi Flow / BulletinPublisher",
> "bulletinLevel" : "ERROR",
> "bulletinMessage" :
> "EvaluateJsonPath[id=88311752-101e-1180-1783-1c1ccf760a91] FlowFile
> FlowFile[filename=441b9cc4-a8d3-4426-8dbb-0cd49de2bac2] did not have valid
> JSON content.",
> "bulletinSourceId" : "88311752-101e-1180-1783-1c1ccf760a91",
> "bulletinSourceName" : "EvaluateJsonPath",
> "bulletinSourceType" : "PROCESSOR",
> "bulletinTimestamp" : "2022-04-19T18:22:10.078Z",
> "bulletinFlowFileUuid" : "441b9cc4-a8d3-4426-8dbb-0cd49de2bac2"
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (NIFI-9826) Test failure on Ubuntu when using C locale
[
https://issues.apache.org/jira/browse/NIFI-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9826:
---
Fix Version/s: 1.16.1
> Test failure on Ubuntu when using C locale
> --
>
> Key: NIFI-9826
> URL: https://issues.apache.org/jira/browse/NIFI-9826
> Project: Apache NiFi
> Issue Type: Bug
> Environment: Ubuntu 20.04, openjdk-17 and openjdk-8
>Reporter: Marton Szasz
>Assignee: Paul Grey
>Priority: Minor
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> When building NiFi, I ran into test failures:
> {code:java}
> [ERROR] Tests run: 7, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.689
> s <<< FAILURE! - in org.apache.nifi.dbcp.HikariCPConnectionPoolTest
> [ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection
> Time elapsed: 1.113 s <<< ERROR!
> org.apache.nifi.processor.exception.ProcessException: Connection retrieval
> failed
> at
> org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection(HikariCPConnectionPoolTest.java:152)
> Caused by: java.sql.SQLException: Failed to create database
> '/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException: Failed to create
> database
> '/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException:
> Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting
> ln[_CO[_variant]]
> ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter
> ISO-3166 country codes, see java.util.Locale.
> [ERROR]
> org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect Time
> elapsed: 1.019 s <<< ERROR!
> org.apache.nifi.processor.exception.ProcessException: Connection retrieval
> failed
> at
> org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect(HikariCPConnectionPoolTest.java:172)
> Caused by: java.sql.SQLException: Failed to create database
> '/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException: Failed to create
> database
> '/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException:
> Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting
> ln[_CO[_variant]]
> ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter
> ISO-3166 country codes, see java.util.Locale. {code}
>
> My system locale was set to C.UTF-8. When changed to en_US.UTF-8, the build
> succeeded.
> Steps to reproduce:
> {code:java}
> export LANG=C.UTF-8
> export LC_ALL=C.UTF-8
> mvn package{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (NIFI-9901) Implement Module for Common XML Utilities
[
https://issues.apache.org/jira/browse/NIFI-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525885#comment-17525885
]
ASF subversion and git services commented on NIFI-9901:
---
Commit ed7c3de115c8e13c87fb55914959e3a3f15cb58c in nifi's branch
refs/heads/support/nifi-1.16 from Joe Witt
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ed7c3de115 ]
NIFI-9901 fixing version references
> Implement Module for Common XML Utilities
> -
>
> Key: NIFI-9901
> URL: https://issues.apache.org/jira/browse/NIFI-9901
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.16.0
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The {{nifi-security-utils}} module includes several classes for working with
> various Java XML components. These classes are self-contained, and do not
> require the set of dependencies listed for {{{}nifi-security-utils{}}}.
> Refactoring these classes to a new module under {{nifi-commons}} would
> streamline the dependency tree for other modules that do not need Bouncy
> Castle or other dependencies of {{{}nifi-security-utils{}}}.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (NIFI-9883) Refactor Property Protection Modules for Isolated Loading
[
https://issues.apache.org/jira/browse/NIFI-9883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525858#comment-17525858
]
ASF subversion and git services commented on NIFI-9883:
---
Commit be65743727420ff6f1ae528802d694b85a2355d8 in nifi's branch
refs/heads/main from Bryan Bende
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=be65743727 ]
NIFI-9883 Updated Ranger assembly exclude property protection modules
This closes #5987
Signed-off-by: David Handermann
> Refactor Property Protection Modules for Isolated Loading
> -
>
> Key: NIFI-9883
> URL: https://issues.apache.org/jira/browse/NIFI-9883
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The {{nifi-property-protection}} modules include a large number of transitive
> dependencies as a result of leveraging libraries from different service
> providers. These dependencies can result in runtime conflicts due to the lack
> of isolation when loading classes. Both the bootstrap and framework modules
> depend on these modules. The loading approach should be refactored to
> implementation isolated loading in order to avoid runtime conflicts.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (MINIFICPP-1809) Improve the test coverage of cron driven scheduling
[ https://issues.apache.org/jira/browse/MINIFICPP-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink reassigned MINIFICPP-1809: -- Assignee: Martin Zink > Improve the test coverage of cron driven scheduling > --- > > Key: MINIFICPP-1809 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1809 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Major > > I couldn't find any test that verifies the behavior of > CronDrivenSchedulingAgent > We should create cpp and possible docker tests as well. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [nifi] exceptionfactory closed pull request #5987: NIFI-9883 Update ranger assembly descriptor to exclude property prote…
exceptionfactory closed pull request #5987: NIFI-9883 Update ranger assembly descriptor to exclude property prote… URL: https://github.com/apache/nifi/pull/5987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #5986: NIFI-9943 Add Transform Provider to nifi-xml-processing
exceptionfactory commented on code in PR #5986:
URL: https://github.com/apache/nifi/pull/5986#discussion_r855400548
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXPath.java:
##
@@ -381,48 +380,6 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
}
}
-private void doTransform(final Source sourceNode, OutputStream out) throws
TransformerFactoryConfigurationError, TransformerException {
-final Transformer transformer;
-try {
-transformer = TransformerFactory.newInstance().newTransformer();
-} catch (final Exception e) {
-throw new ProcessException(e);
-}
-
-final Properties props = new Properties();
-props.setProperty(OutputKeys.METHOD, "xml");
-props.setProperty(OutputKeys.INDENT, "no");
-props.setProperty(OutputKeys.OMIT_XML_DECLARATION, "no");
-transformer.setOutputProperties(props);
-
-final ComponentLog logger = getLogger();
-
-final AtomicReference error = new
AtomicReference<>(null);
Review Comment:
That's a good question. This component was the only reference that had a
custom `ErrorListener`. Given that the default `ErrorListener` throws
exceptions on errors, that is the desired standard behavior. Supporting a
custom `ErrorListener` might be useful in future use cases, but it also opens
the door to hiding transform processing problems. For that reason, it seems
best to avoid supporting a custom `ErrorListener` for now, and address it later
if a different use case arises.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #5986: NIFI-9943 Add Transform Provider to nifi-xml-processing
exceptionfactory commented on code in PR #5986:
URL: https://github.com/apache/nifi/pull/5986#discussion_r855393951
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/util/FlowParser.java:
##
@@ -278,13 +278,14 @@ private List getPorts(final Element element,
final String type) {
* @param flowDocument flowDocument of the associated XML content to write
to disk
* @param flowXmlPath path on disk to write the flow
* @throws IOException if there are issues in accessing the target
destination for the flow
- * @throws TransformerException if there are issues in the xml
transformation process
*/
-public void writeFlow(final Document flowDocument, final Path flowXmlPath)
throws IOException, TransformerException {
+public void writeFlow(final Document flowDocument, final Path flowXmlPath)
throws IOException {
Review Comment:
Correct, the caller would receiving a runtime XML `ProcessingException`,
instead of the checked `TransformerException`. As mentioned, this does not
appear to be an issue as this method does not appear to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #5986: NIFI-9943 Add Transform Provider to nifi-xml-processing
exceptionfactory commented on code in PR #5986:
URL: https://github.com/apache/nifi/pull/5986#discussion_r855391345
##
nifi-commons/nifi-xml-processing/src/main/java/org/apache/nifi/xml/processing/ProcessingAttribute.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.xml.processing;
+
+import javax.xml.XMLConstants;
+
+/**
+ * XML Processing Attributes
+ */
+public enum ProcessingAttribute {
+/** Access External Document Type Declaration with all protocols disabled
*/
Review Comment:
Thanks for the suggestion, that is a helpful improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] bbende opened a new pull request, #5987: NIFI-9883 Update ranger assembly descriptor to exclude property prote…
bbende opened a new pull request, #5987:
URL: https://github.com/apache/nifi/pull/5987
…ction modules
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #5986: NIFI-9943 Add Transform Provider to nifi-xml-processing
greyp9 commented on code in PR #5986:
URL: https://github.com/apache/nifi/pull/5986#discussion_r855383795
##
nifi-commons/nifi-xml-processing/src/main/java/org/apache/nifi/xml/processing/transform/StandardTransformProvider.java:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.xml.processing.transform;
+
+import org.apache.nifi.xml.processing.ProcessingAttribute;
+import org.apache.nifi.xml.processing.ProcessingException;
+
+import javax.xml.XMLConstants;
+import javax.xml.transform.OutputKeys;
+import javax.xml.transform.Result;
+import javax.xml.transform.Source;
+import javax.xml.transform.Transformer;
+import javax.xml.transform.TransformerConfigurationException;
+import javax.xml.transform.TransformerException;
+import javax.xml.transform.TransformerFactory;
+import java.util.Objects;
+
+/**
+ * Standard implementation of Transform Provider with secure processing enabled
+ */
+public class StandardTransformProvider implements TransformProvider {
+private static final boolean SECURE_PROCESSING_ENABLED = true;
+
+private static final String ENABLED_PROPERTY = "yes";
+
+private static final String INDENT_AMOUNT_OUTPUT_KEY =
"{http://xml.apache.org/xslt}indent-amount";;
+
+private static final String INDENT_AMOUNT = "2";
+
+private boolean indent;
+
+private boolean omitXmlDeclaration;
+
+private String method;
+
+/**
+ * Set Indent Status
+ *
+ * @param indent Indent Status
+ */
+public void setIndent(final boolean indent) {
+this.indent = indent;
+}
+
+/**
+ * Set Output Method
+ *
+ * @param method Method or null when default configuration should be used
+ */
+public void setMethod(final String method) {
+this.method = method;
+}
+
+/**
+ * Set Omit XML Declaration
+ *
+ * @param omitXmlDeclaration Omit XML Declaration
+ */
+public void setOmitXmlDeclaration(final boolean omitXmlDeclaration) {
+this.omitXmlDeclaration = omitXmlDeclaration;
+}
+
+/**
+ * Transform Source to Result
+ *
+ * @param source Source to be transformed
+ * @param result Result containing transformed information
+ */
+@Override
+public void transform(final Source source, final Result result) {
+Objects.requireNonNull(source, "Source required");
+Objects.requireNonNull(result, "Result required");
+
+final TransformerFactory transformerFactory =
TransformerFactory.newInstance();
+final Transformer transformer;
+try {
+transformerFactory.setAttribute(XMLConstants.ACCESS_EXTERNAL_DTD,
ProcessingAttribute.ACCESS_EXTERNAL_DTD.getValue());
+
transformerFactory.setAttribute(XMLConstants.ACCESS_EXTERNAL_STYLESHEET,
ProcessingAttribute.ACCESS_EXTERNAL_STYLESHEET.getValue());
+
transformerFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING,
SECURE_PROCESSING_ENABLED);
Review Comment:
> I've created a JIRA to capture the potential refactor of this module to
use something like `trySet` and `quietSet`. I find that a neat solution to this
specific problem. Thanks for sharing!
https://issues.apache.org/jira/browse/NIFI-9947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #5986: NIFI-9943 Add Transform Provider to nifi-xml-processing
greyp9 commented on code in PR #5986:
URL: https://github.com/apache/nifi/pull/5986#discussion_r855293739
##
nifi-commons/nifi-xml-processing/src/main/java/org/apache/nifi/xml/processing/ProcessingAttribute.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.xml.processing;
+
+import javax.xml.XMLConstants;
+
+/**
+ * XML Processing Attributes
+ */
+public enum ProcessingAttribute {
+/** Access External Document Type Declaration with all protocols disabled
*/
+ACCESS_EXTERNAL_DTD(XMLConstants.ACCESS_EXTERNAL_DTD, ""),
+
+/** Access External Stylesheet with all protocols disabled */
Review Comment:
```suggestion
/** Access External Stylesheet with an empty string to deny all access
to external references */
```
same thing here
##
nifi-commons/nifi-xml-processing/src/main/java/org/apache/nifi/xml/processing/ProcessingAttribute.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.xml.processing;
+
+import javax.xml.XMLConstants;
+
+/**
+ * XML Processing Attributes
+ */
+public enum ProcessingAttribute {
+/** Access External Document Type Declaration with all protocols disabled
*/
Review Comment:
```suggestion
/** Access External Document Type Declaration with an empty string to
deny all access to external references */
```
-
https://docs.oracle.com/javase/8/docs/api/javax/xml/XMLConstants.html#ACCESS_EXTERNAL_DTD
I think it is clearer.
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXPath.java:
##
@@ -381,48 +380,6 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
}
}
-private void doTransform(final Source sourceNode, OutputStream out) throws
TransformerFactoryConfigurationError, TransformerException {
-final Transformer transformer;
-try {
-transformer = TransformerFactory.newInstance().newTransformer();
-} catch (final Exception e) {
-throw new ProcessException(e);
-}
-
-final Properties props = new Properties();
-props.setProperty(OutputKeys.METHOD, "xml");
-props.setProperty(OutputKeys.INDENT, "no");
-props.setProperty(OutputKeys.OMIT_XML_DECLARATION, "no");
-transformer.setOutputProperties(props);
-
-final ComponentLog logger = getLogger();
-
-final AtomicReference error = new
AtomicReference<>(null);
Review Comment:
Maybe also a test case exercising in StandardTransformProviderTest.
##
nifi-commons/nifi-xml-processing/src/main/java/org/apache/nifi/xml/processing/transform/StandardTransformProvider.java:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on a
[jira] [Commented] (NIFI-9843) Select and/or delete individual files in queues
[ https://issues.apache.org/jira/browse/NIFI-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525838#comment-17525838 ] Paul Pascoe commented on NIFI-9843: --- Joe, Thanks for the reply, yes being able to delete single files from a queue would be nice. > Select and/or delete individual files in queues > --- > > Key: NIFI-9843 > URL: https://issues.apache.org/jira/browse/NIFI-9843 > Project: Apache NiFi > Issue Type: Improvement > Components: Configuration >Affects Versions: 1.15.3 >Reporter: Paul Pascoe >Priority: Major > > Add the ability to select and/or delete individual files from a queue. > You can already select items from the top X number of flowfiles in a queue. > From there you can see metadata/click to content, etc.. But it is not meant > for actual queue manipulation at this time. It is also not > exhaustive/searchable/filterable for a variety of reasons. > We have had cases where it would be super nice to be able to add flowfiles to > queues, delete them, etc.. So the general ask makes good sense. But this > would be a ton of work for sure. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (NIFI-9946) Add the ability to color code queues
[ https://issues.apache.org/jira/browse/NIFI-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Pascoe updated NIFI-9946: -- Attachment: Screenshot from 2022-04-21 16-06-28.png > Add the ability to color code queues > > > Key: NIFI-9946 > URL: https://issues.apache.org/jira/browse/NIFI-9946 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Pascoe >Priority: Minor > Attachments: Screenshot from 2022-04-21 16-06-28.png > > > Add the ability to change the color of queues. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (NIFI-9946) Add the ability to color code queues
[ https://issues.apache.org/jira/browse/NIFI-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525831#comment-17525831 ] Paul Pascoe commented on NIFI-9946: --- Joe, You are able to change the color of processors, would like that ability for the ques as well. Would help keep track of ques of the same value, i.e. "success", "failure", etc. !Screenshot from 2022-04-21 16-06-28.png! > Add the ability to color code queues > > > Key: NIFI-9946 > URL: https://issues.apache.org/jira/browse/NIFI-9946 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Pascoe >Priority: Minor > Attachments: Screenshot from 2022-04-21 16-06-28.png > > > Add the ability to change the color of queues. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (NIFI-9948) Upgrading Nifi Registry from 1.15.3 to 1.16.0 keeps failing with Flyway migration errors
[
https://issues.apache.org/jira/browse/NIFI-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525829#comment-17525829
]
Pierre Villard commented on NIFI-9948:
--
I do think this is related to NIFI-9836 and it should be solved as soon as we
release 1.16.1 which should happen really soon.
> Upgrading Nifi Registry from 1.15.3 to 1.16.0 keeps failing with Flyway
> migration errors
>
>
> Key: NIFI-9948
> URL: https://issues.apache.org/jira/browse/NIFI-9948
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Affects Versions: 1.16.0
>Reporter: Andreas Adamides
>Priority: Major
>
> When upgrading from version 1.15.3 to 1.16.0, the upgrade keeps failing.
> Looking at the logs the issue seems to be related with Flyway(database is
> Postgres 12.8) migration failures and checksum mismatches. The suggestion to
> fix this is to run the flyway.repair() commands, but flyway is embedded as
> Java code in the Nifi registry code itself.
> *Error logs:*
> {code:java}
> 2022-04-21 16:03:48,445 INFO [NiFi logging handler]
> org.apache.nifi.registry.StdOut
> 2022-04-21 16:03:48,445 INFO [NiFi logging handler]
> org.apache.nifi.registry.StdOut Apache NiFi _ _
> 2022-04-21 16:03:48,445 INFO [NiFi logging handler]
> org.apache.nifi.registry.StdOut _ __ ___ __ _(_)___| |_ _ __ _ _
> 2022-04-21 16:03:48,446 INFO [NiFi logging handler]
> org.apache.nifi.registry.StdOut | '__/ _ \/ _` | / __| __| '__| | | |
> 2022-04-21 16:03:48,450 INFO [NiFi logging handler]
> org.apache.nifi.registry.StdOut | | | __/ (_| | \__ \ |_| | | |_| |
> 2022-04-21 16:03:48,450 INFO [NiFi logging handler]
> org.apache.nifi.registry.StdOut |_| \___|\__, |_|___/\__|_| \__, |
> 2022-04-21 16:03:48,450 INFO [NiFi logging handler]
> org.apache.nifi.registry.StdOut ==|___/|___/=
> 2022-04-21 16:03:48,450 INFO [NiFi logging handler]
> org.apache.nifi.registry.StdOut v1.16.0
> 2022-04-21 16:03:48,532 INFO [NiFi logging handler]
> org.apache.nifi.registry.StdOut
> 2022-04-21 16:04:09,064 ERROR [NiFi logging handler]
> org.apache.nifi.registry.StdErr Failed to start web server:
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'accessPolicyResource' defined in file
> [/opt/nifi/nifi-registry-1.16.0/work/jetty/nifi-registry-web-api-1.16.0.war/webapp/WEB-INF/classes/org/apache/nifi/registry/web/api/AccessPolicyResource.class]:
> Unsatisfied dependency expressed through constructor parameter 0; nested
> exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'standardServiceFacade' defined in file
> [/opt/nifi/nifi-registry-1.16.0/work/jetty/nifi-registry-web-api-1.16.0.war/webapp/WEB-INF/classes/org/apache/nifi/registry/web/service/StandardServiceFacade.class]:
> Unsatisfied dependency expressed through constructor parameter 0; nested
> exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'registryService' defined in URL
> [jar:file:/opt/nifi/nifi-registry-1.16.0/work/jetty/nifi-registry-web-api-1.16.0.war/webapp/WEB-INF/lib/nifi-registry-framework-1.16.0.jar!/org/apache/nifi/registry/service/RegistryService.class]:
> Unsatisfied dependency expressed through constructor parameter 0; nested
> exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'databaseMetadataService' defined in URL
> [jar:file:/opt/nifi/nifi-registry-1.16.0/work/jetty/nifi-registry-web-api-1.16.0.war/webapp/WEB-INF/lib/nifi-registry-framework-1.16.0.jar!/org/apache/nifi/registry/db/DatabaseMetadataService.class]:
> Unsatisfied dependency expressed through constructor parameter 0; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'flywayInitializer' defined in class path resource
> [org/springframework/boot/autoconfigure/flyway/FlywayAutoConfiguration$FlywayConfiguration.class]:
> Invocation of init method failed; nested exception is
> org.flywaydb.core.api.exception.FlywayValidateException: Validate failed:
> Migrations have failed validation
> 2022-04-21 16:04:09,065 ERROR [NiFi logging handler]
> org.apache.nifi.registry.StdErr Migration checksum mismatch for migration
> version 6
> 2022-04-21 16:04:09,065 ERROR [NiFi logging handler]
> org.apache.nifi.registry.StdErr -> Applied to database : -260833722
> 2022-04-21 16:04:09,065 ERROR [NiFi logging handler]
> org.apache.nifi.registry.StdErr -> Resolved locally : -1218242517. Either
> revert the changes to the migration, or run repair to update the schema
> history.
> 2022-04-
[jira] [Created] (NIFI-9948) Upgrading Nifi Registry from 1.15.3 to 1.16.0 keeps failing with Flyway migration errors
Andreas Adamides created NIFI-9948:
--
Summary: Upgrading Nifi Registry from 1.15.3 to 1.16.0 keeps
failing with Flyway migration errors
Key: NIFI-9948
URL: https://issues.apache.org/jira/browse/NIFI-9948
Project: Apache NiFi
Issue Type: Bug
Components: NiFi Registry
Affects Versions: 1.16.0
Reporter: Andreas Adamides
When upgrading from version 1.15.3 to 1.16.0, the upgrade keeps failing.
Looking at the logs the issue seems to be related with Flyway(database is
Postgres 12.8) migration failures and checksum mismatches. The suggestion to
fix this is to run the flyway.repair() commands, but flyway is embedded as Java
code in the Nifi registry code itself.
*Error logs:*
{code:java}
2022-04-21 16:03:48,445 INFO [NiFi logging handler]
org.apache.nifi.registry.StdOut
2022-04-21 16:03:48,445 INFO [NiFi logging handler]
org.apache.nifi.registry.StdOut Apache NiFi _ _
2022-04-21 16:03:48,445 INFO [NiFi logging handler]
org.apache.nifi.registry.StdOut _ __ ___ __ _(_)___| |_ _ __ _ _
2022-04-21 16:03:48,446 INFO [NiFi logging handler]
org.apache.nifi.registry.StdOut | '__/ _ \/ _` | / __| __| '__| | | |
2022-04-21 16:03:48,450 INFO [NiFi logging handler]
org.apache.nifi.registry.StdOut | | | __/ (_| | \__ \ |_| | | |_| |
2022-04-21 16:03:48,450 INFO [NiFi logging handler]
org.apache.nifi.registry.StdOut |_| \___|\__, |_|___/\__|_| \__, |
2022-04-21 16:03:48,450 INFO [NiFi logging handler]
org.apache.nifi.registry.StdOut ==|___/|___/=
2022-04-21 16:03:48,450 INFO [NiFi logging handler]
org.apache.nifi.registry.StdOut v1.16.0
2022-04-21 16:03:48,532 INFO [NiFi logging handler]
org.apache.nifi.registry.StdOut
2022-04-21 16:04:09,064 ERROR [NiFi logging handler]
org.apache.nifi.registry.StdErr Failed to start web server:
org.springframework.beans.factory.UnsatisfiedDependencyException: Error
creating bean with name 'accessPolicyResource' defined in file
[/opt/nifi/nifi-registry-1.16.0/work/jetty/nifi-registry-web-api-1.16.0.war/webapp/WEB-INF/classes/org/apache/nifi/registry/web/api/AccessPolicyResource.class]:
Unsatisfied dependency expressed through constructor parameter 0; nested
exception is org.springframework.beans.factory.UnsatisfiedDependencyException:
Error creating bean with name 'standardServiceFacade' defined in file
[/opt/nifi/nifi-registry-1.16.0/work/jetty/nifi-registry-web-api-1.16.0.war/webapp/WEB-INF/classes/org/apache/nifi/registry/web/service/StandardServiceFacade.class]:
Unsatisfied dependency expressed through constructor parameter 0; nested
exception is org.springframework.beans.factory.UnsatisfiedDependencyException:
Error creating bean with name 'registryService' defined in URL
[jar:file:/opt/nifi/nifi-registry-1.16.0/work/jetty/nifi-registry-web-api-1.16.0.war/webapp/WEB-INF/lib/nifi-registry-framework-1.16.0.jar!/org/apache/nifi/registry/service/RegistryService.class]:
Unsatisfied dependency expressed through constructor parameter 0; nested
exception is org.springframework.beans.factory.UnsatisfiedDependencyException:
Error creating bean with name 'databaseMetadataService' defined in URL
[jar:file:/opt/nifi/nifi-registry-1.16.0/work/jetty/nifi-registry-web-api-1.16.0.war/webapp/WEB-INF/lib/nifi-registry-framework-1.16.0.jar!/org/apache/nifi/registry/db/DatabaseMetadataService.class]:
Unsatisfied dependency expressed through constructor parameter 0; nested
exception is org.springframework.beans.factory.BeanCreationException: Error
creating bean with name 'flywayInitializer' defined in class path resource
[org/springframework/boot/autoconfigure/flyway/FlywayAutoConfiguration$FlywayConfiguration.class]:
Invocation of init method failed; nested exception is
org.flywaydb.core.api.exception.FlywayValidateException: Validate failed:
Migrations have failed validation
2022-04-21 16:04:09,065 ERROR [NiFi logging handler]
org.apache.nifi.registry.StdErr Migration checksum mismatch for migration
version 6
2022-04-21 16:04:09,065 ERROR [NiFi logging handler]
org.apache.nifi.registry.StdErr -> Applied to database : -260833722
2022-04-21 16:04:09,065 ERROR [NiFi logging handler]
org.apache.nifi.registry.StdErr -> Resolved locally : -1218242517. Either
revert the changes to the migration, or run repair to update the schema history.
2022-04-21 16:04:09,065 ERROR [NiFi logging handler]
org.apache.nifi.registry.StdErr Migration checksum mismatch for migration
version 8
2022-04-21 16:04:09,065 ERROR [NiFi logging handler]
org.apache.nifi.registry.StdErr -> Applied to database : -2057645592
2022-04-21 16:04:09,065 ERROR [NiFi logging handler]
org.apache.nifi.registry.StdErr -> Resolved locally : -1726468007. Either
revert the changes to the migration, or run repair to update the schema history.
2022-04-21 16:04:09,065 ERROR [NiFi logging handler]
org.apache.nifi.regist
[jira] [Created] (NIFI-9947) Refactor module nifi-xml-utils factory setAttribute/setFeature for granular exception handling
Paul Grey created NIFI-9947: --- Summary: Refactor module nifi-xml-utils factory setAttribute/setFeature for granular exception handling Key: NIFI-9947 URL: https://issues.apache.org/jira/browse/NIFI-9947 Project: Apache NiFi Issue Type: Improvement Reporter: Paul Grey Following the pattern implemented in POI / XMLHelper, granular handling of individual setFeature / setAttribute calls might be useful in adapting to specialized circumstances associated with the use of various XSL / XML processing libraries. https://github.com/apache/poi/blob/9b60986f682ad3a23f3e5d4f19ddd645879ad8bb/poi/src/main/java/org/apache/poi/util/XMLHelper.java -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1315: MINIFICPP-1810 Provide logs to be read from docker logs
lordgamez opened a new pull request, #1315: URL: https://github.com/apache/nifi-minifi-cpp/pull/1315 A `start.sh` script is added to the Docker image to tail the MiNiFi log file to stdout done in a similar fashion as it is done in NiFi. This way it will be available to be consumed by the `docker logs` command for debugging and log collection while running the MiNiFi inside a container or in a kubernetes cluster. -- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] (MINIFICPP-1721) GetFileTests transiently fail
[ https://issues.apache.org/jira/browse/MINIFICPP-1721 ]
Gábor Gyimesi deleted comment on MINIFICPP-1721:
--
was (Author: lordgamez):
The referred line has changed since then and the issue could not be reproduced.
> GetFileTests transiently fail
> -
>
> Key: MINIFICPP-1721
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1721
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Priority: Minor
> Attachments: GetFileTests-failure-ubuntu2004-clang.log
>
>
> GetFileTests transiently fail in CI environment probably due to a timing
> issue:
> {code:java}
> 2022-01-07T15:13:24.6173440Z
> /home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/standard-processors/tests/unit/GetFileTests.cpp:262:
> FAILED:2022-01-07T15:13:24.6174907Z REQUIRE(
> utils::timeutils::getTimeMillis() - start_time >= 100
> )2022-01-07T15:13:24.6175497Z with expansion:2022-01-07T15:13:24.6175857Z
> 88 >= 100 {code}
> See more info in the attached logs
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (NIFI-9945) Upgrade jQuery UI - v1.12.1 To 1.13.1
[ https://issues.apache.org/jira/browse/NIFI-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-9945: - Description: NiFi uses a vulnerable version of JQuery UI, which has 3 CVEs against it. CVE-2021-41182 - [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41182] CVE-2021-41183 - [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41183] CVE-2021-41184 - [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41184] The way to mitigate these CVEs would be to upgrade to JQuery UI version 1.13.1. was: NiFi uses a vulnerable version of JQuery UI, which has 3 CVEs against it. CVE-2021-41182 - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41182 CVE-2021-41183 - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41183 CVE-2021-41184 - [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41184] Lets mitigate this by upgrading the version of JQuery UI used by NiFi to 1.13.1 > Upgrade jQuery UI - v1.12.1 To 1.13.1 > --- > > Key: NIFI-9945 > URL: https://issues.apache.org/jira/browse/NIFI-9945 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.16.0, 1.15.1, 1.15.2, 1.15.3 > Environment: Windows, Unix >Reporter: Mike R >Priority: Major > > NiFi uses a vulnerable version of JQuery UI, which has 3 CVEs against it. > CVE-2021-41182 - > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41182] > CVE-2021-41183 - > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41183] > CVE-2021-41184 - > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41184] > > The way to mitigate these CVEs would be to upgrade to JQuery UI version > 1.13.1. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (MINIFICPP-1720) C2DebugBundleTest transiently fails
[
https://issues.apache.org/jira/browse/MINIFICPP-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi reassigned MINIFICPP-1720:
Assignee: Gábor Gyimesi
> C2DebugBundleTest transiently fails
> ---
>
> Key: MINIFICPP-1720
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1720
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Minor
> Attachments: C2DebugBundleTest-failure-win10.log
>
>
> C2DebugBundleTest sometimes fails in CI environment with the following error:
> {code:java}
> Assertion failed: archive_content["minifi.properties"] == properties_file,
> file
> D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\http-curl\tests\C2DebugBundleTest.cpp,
> line 178 {code}
> See more info in the attached logs
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (MINIFICPP-1720) C2DebugBundleTest transiently fails
[
https://issues.apache.org/jira/browse/MINIFICPP-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi resolved MINIFICPP-1720.
--
Resolution: Cannot Reproduce
The issue has not been present for a long time, could not be reproduced locally.
> C2DebugBundleTest transiently fails
> ---
>
> Key: MINIFICPP-1720
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1720
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Minor
> Attachments: C2DebugBundleTest-failure-win10.log
>
>
> C2DebugBundleTest sometimes fails in CI environment with the following error:
> {code:java}
> Assertion failed: archive_content["minifi.properties"] == properties_file,
> file
> D:\a\nifi-minifi-cpp\nifi-minifi-cpp\extensions\http-curl\tests\C2DebugBundleTest.cpp,
> line 178 {code}
> See more info in the attached logs
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MINIFICPP-1711) C2PauseResumeTest transiently fails
[
https://issues.apache.org/jira/browse/MINIFICPP-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525819#comment-17525819
]
Gábor Gyimesi commented on MINIFICPP-1711:
--
The issue can be reproduced with multiple C2 tests if the test is run under
together with other C2 test cases. For example if we use the "ctest -j99"
command on a local machine:
{code:java}
The following tests FAILED:
77 - GetFileTests (Failed)
110 - C2JstackTest (Subprocess aborted)
132 - C2PauseResumeTest (Subprocess aborted)
136 - C2ClearCoreComponentStateTest (Subprocess aborted){code}
> C2PauseResumeTest transiently fails
> ---
>
> Key: MINIFICPP-1711
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1711
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Priority: Minor
> Attachments: C2PauseResumeTest-failure-win10.log
>
>
> See attachment for more information on the failure.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1309: MINIFICPP-1795 - C2ClearCoreComponentStateTest fails sometimes on CI
lordgamez commented on PR #1309: URL: https://github.com/apache/nifi-minifi-cpp/pull/1309#issuecomment-1105429767 > > Unfortunately the last commit did not help with the problem above, the test still fails with the same timeout. > > To me this did not occur. However, I have increased my timeout to 400 seconds. Out of 15 runs (the same way you did, -j99) none had this test failing. The tests still fail with a timeout, but the same problem seems to appear in multiple C2 related tests, so I would think this is unrelated to the current issue of the PR. ``` The following tests FAILED: 77 - GetFileTests (Failed) 110 - C2JstackTest (Subprocess aborted) 132 - C2PauseResumeTest (Subprocess aborted) 136 - C2ClearCoreComponentStateTest (Subprocess aborted) ``` This issue seems to pop up time to time in CI as well, as we currently have open issues for C2 related tests with this specific timeout problem for example in [MINIFICPP-1720](https://issues.apache.org/jira/browse/MINIFICPP-1720) and [MINIFICPP-1711](https://issues.apache.org/jira/browse/MINIFICPP-1711). This issue should be investigated separately, but I think this change can be merged and should fix the original issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (MINIFICPP-1721) GetFileTests transiently fail
[
https://issues.apache.org/jira/browse/MINIFICPP-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi reopened MINIFICPP-1721:
--
Issue seems to appear when running tests with "ctest -j99" command:
{code:java}
/home/ggyimesi/projects/nifi-minifi-cpp-fork/extensions/standard-processors/tests/unit/GetFileTests.cpp:249
.../home/ggyimesi/projects/nifi-minifi-cpp-fork/extensions/standard-processors/tests/unit/GetFileTests.cpp:262:
FAILED:
REQUIRE( std::chrono::steady_clock::now() - start_time >= 100ms )
with expansion:
{?} >=
{?}===
test cases: 12 | 11 passed | 1 failed
assertions: 55 | 54 passed | 1 failed
{code}
> GetFileTests transiently fail
> -
>
> Key: MINIFICPP-1721
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1721
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Minor
> Attachments: GetFileTests-failure-ubuntu2004-clang.log
>
>
> GetFileTests transiently fail in CI environment probably due to a timing
> issue:
> {code:java}
> 2022-01-07T15:13:24.6173440Z
> /home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/standard-processors/tests/unit/GetFileTests.cpp:262:
> FAILED:2022-01-07T15:13:24.6174907Z REQUIRE(
> utils::timeutils::getTimeMillis() - start_time >= 100
> )2022-01-07T15:13:24.6175497Z with expansion:2022-01-07T15:13:24.6175857Z
> 88 >= 100 {code}
> See more info in the attached logs
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (MINIFICPP-1721) GetFileTests transiently fail
[
https://issues.apache.org/jira/browse/MINIFICPP-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi reassigned MINIFICPP-1721:
Assignee: (was: Gábor Gyimesi)
> GetFileTests transiently fail
> -
>
> Key: MINIFICPP-1721
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1721
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Priority: Minor
> Attachments: GetFileTests-failure-ubuntu2004-clang.log
>
>
> GetFileTests transiently fail in CI environment probably due to a timing
> issue:
> {code:java}
> 2022-01-07T15:13:24.6173440Z
> /home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/standard-processors/tests/unit/GetFileTests.cpp:262:
> FAILED:2022-01-07T15:13:24.6174907Z REQUIRE(
> utils::timeutils::getTimeMillis() - start_time >= 100
> )2022-01-07T15:13:24.6175497Z with expansion:2022-01-07T15:13:24.6175857Z
> 88 >= 100 {code}
> See more info in the attached logs
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (NIFI-9843) Select and/or delete individual files in queues
[ https://issues.apache.org/jira/browse/NIFI-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-9843: --- Description: Add the ability to select and/or delete individual files from a queue. You can already select items from the top X number of flowfiles in a queue. From there you can see metadata/click to content, etc.. But it is not meant for actual queue manipulation at this time. It is also not exhaustive/searchable/filterable for a variety of reasons. We have had cases where it would be super nice to be able to add flowfiles to queues, delete them, etc.. So the general ask makes good sense. But this would be a ton of work for sure. was:Add the ability to select and/or delete individual files from a que. > Select and/or delete individual files in queues > --- > > Key: NIFI-9843 > URL: https://issues.apache.org/jira/browse/NIFI-9843 > Project: Apache NiFi > Issue Type: Improvement > Components: Configuration >Affects Versions: 1.15.3 >Reporter: Paul Pascoe >Priority: Major > > Add the ability to select and/or delete individual files from a queue. > You can already select items from the top X number of flowfiles in a queue. > From there you can see metadata/click to content, etc.. But it is not meant > for actual queue manipulation at this time. It is also not > exhaustive/searchable/filterable for a variety of reasons. > We have had cases where it would be super nice to be able to add flowfiles to > queues, delete them, etc.. So the general ask makes good sense. But this > would be a ton of work for sure. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (NIFI-9946) Add the ability to color code queues
[ https://issues.apache.org/jira/browse/NIFI-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-9946: --- Description: Add the ability to change the color of queues. was:Add the ability to change the color of ques. > Add the ability to color code queues > > > Key: NIFI-9946 > URL: https://issues.apache.org/jira/browse/NIFI-9946 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Pascoe >Priority: Minor > > Add the ability to change the color of queues. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (NIFI-9946) Add the ability to color code queues
[ https://issues.apache.org/jira/browse/NIFI-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525807#comment-17525807 ] Joe Witt commented on NIFI-9946: Paul can you please elaborate on what you mean/maybe show an image or a more detailed description of what you'd want to be able to do and what it would help you do as a user? > Add the ability to color code queues > > > Key: NIFI-9946 > URL: https://issues.apache.org/jira/browse/NIFI-9946 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Pascoe >Priority: Minor > > Add the ability to change the color of queues. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (NIFI-9843) Select and/or delete individual files in queues
[ https://issues.apache.org/jira/browse/NIFI-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-9843: --- Summary: Select and/or delete individual files in queues (was: Select and/or delete individual files in QUE) > Select and/or delete individual files in queues > --- > > Key: NIFI-9843 > URL: https://issues.apache.org/jira/browse/NIFI-9843 > Project: Apache NiFi > Issue Type: Improvement > Components: Configuration >Affects Versions: 1.15.3 >Reporter: Paul Pascoe >Priority: Major > > Add the ability to select and/or delete individual files from a que. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (NIFI-9946) Add the ability to color code queues
[ https://issues.apache.org/jira/browse/NIFI-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-9946: --- Summary: Add the ability to color code queues (was: Add the ability to color code queue) > Add the ability to color code queues > > > Key: NIFI-9946 > URL: https://issues.apache.org/jira/browse/NIFI-9946 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Pascoe >Priority: Minor > > Add the ability to change the color of ques. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (NIFI-9946) Add the ability to color code queue
[ https://issues.apache.org/jira/browse/NIFI-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-9946: --- Summary: Add the ability to color code queue (was: Add the ability to color code ques) > Add the ability to color code queue > --- > > Key: NIFI-9946 > URL: https://issues.apache.org/jira/browse/NIFI-9946 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Pascoe >Priority: Minor > > Add the ability to change the color of ques. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (NIFI-9855) NiFi Can Delete Its Own Configuration Files
[ https://issues.apache.org/jira/browse/NIFI-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525803#comment-17525803 ] Joe Witt commented on NIFI-9855: Hello. It isn't that it wont gain traction but rather it is that we've approached a solution for this in other ways. For instance, you can take advantage of the restricted components concept to limit authority to a very select set of users that can manipulate such dangerous/powerful components. There are actually a range of complex scenarios beyond what is even laid out here. That is the other edge of the double edge sword of power here. Ultimately we have chosen to give fine grained authority for such components that can interact with the local file system. Ruining data is just as problematic as reading certain data. The references to 'attacker' here are probably misleading. The real issue is really 'any properly authorized user knowing/unknowingly could cause bad things to happen'. We also have components which execute system commands, etc.. Thus we have fine grained controls and auditing and provenance, etc.. We *could* literally offer a 'block list' of directories that components could opt-in to checking and blocking. But at a framework level we cannot force/stop such things. Ultimately we'd need those who built processors (even custom ones or scripted ones) to opt in to such checks. This would really defeat the intent. Thus..we're back to why we have focused on authorization as a key answer here. > NiFi Can Delete Its Own Configuration Files > --- > > Key: NIFI-9855 > URL: https://issues.apache.org/jira/browse/NIFI-9855 > Project: Apache NiFi > Issue Type: Bug > Components: Security >Affects Versions: 1.16.0, 1.15.2, 1.15.3 > Environment: All Linux Distros >Reporter: Mike R >Priority: Major > > Using the GetFile and PutFile processors, an attacker could overwrite the > configuration files to the /dev/null. Using a regex of (.*?), an attacker > could point the GetFile Processor to the directory which the NiFi > configuration files are located in. If the attacker is able to login, they > can send the files to /dev/null on Linux, which although it will cause a > warning in the PutFile processor, it will still process. > This does not require that the attacker have access to the underlying system, > but rather just NiFi itself. > The ways to prevent this from happening would be to prevent the GetFile > Processor and other NiFi processors from being able to directly read files > from the configuration directories in a way that deletes the existing files > and another option would be to have processors prevented from overwriting > configuration directory files. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1306: MINIFICPP-1802 Do not make EC2 HTTP calls when AWS extension is not used
szaszm commented on code in PR #1306:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1306#discussion_r855338573
##
extensions/aws/processors/S3Processor.h:
##
@@ -115,7 +115,7 @@ class S3Processor : public core::Processor {
std::shared_ptr logger_;
aws::s3::S3Wrapper s3_wrapper_;
- Aws::Client::ClientConfiguration client_config_;
+ std::unique_ptr client_config_;
Review Comment:
Could `std::optional` work here instead of `std::unique_ptr`? It makes
late-init possible without an allocation.
##
libminifi/test/aws-tests/MockS3RequestSender.h:
##
@@ -227,7 +227,7 @@ class MockS3RequestSender : public
minifi::aws::s3::S3RequestSender {
const Aws::Client::ClientConfiguration& client_config) override {
head_object_request = request;
credentials_ = credentials;
-client_config_ = client_config;
+client_config_ =
const_cast(&client_config);
Review Comment:
Maybe it would be easier to make `client_config_` `const` instead of
const_casting everywhere? I only found reading from the client config in the
tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-9615) Extending the capabilities of the NAR provider functionality
[ https://issues.apache.org/jira/browse/NIFI-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-9615: - Fix Version/s: 1.17.0 > Extending the capabilities of the NAR provider functionality > > > Key: NIFI-9615 > URL: https://issues.apache.org/jira/browse/NIFI-9615 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Simon Bence >Assignee: Simon Bence >Priority: Major > Fix For: 1.17.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > NAR provider functionality would benefit from some additional funcitons which > would make it more user friendly and flexible: > - Restrain NiFi from startup before the first fetch attempt > - Adding the capability to decide what should be the "conflict resolution > strartegy" in case of a NAR with the same name already exists in the target > folder > - Allowing a property to refine poll intervals > In order to achieve this, relevant refactors and changes from > [NIFI-9208|https://issues.apache.org/jira/browse/NIFI-9208] will be applied > and refined. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (NIFI-9946) Add the ability to color code ques
Paul Pascoe created NIFI-9946: - Summary: Add the ability to color code ques Key: NIFI-9946 URL: https://issues.apache.org/jira/browse/NIFI-9946 Project: Apache NiFi Issue Type: Improvement Reporter: Paul Pascoe Add the ability to change the color of ques. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [nifi-minifi-cpp] adam-markovics commented on pull request #1309: MINIFICPP-1795 - C2ClearCoreComponentStateTest fails sometimes on CI
adam-markovics commented on PR #1309: URL: https://github.com/apache/nifi-minifi-cpp/pull/1309#issuecomment-1105362652 > Unfortunately the last commit did not help with the problem above, the test still fails with the same timeout. To me this did not occur. However, I have increased my timeout to 400 seconds. Out of 15 runs (the same way you did, -j99) none had this test failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-1810) Forward MiNiFi logs to docker logs output
[ https://issues.apache.org/jira/browse/MINIFICPP-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-1810: Assignee: Gábor Gyimesi > Forward MiNiFi logs to docker logs output > - > > Key: MINIFICPP-1810 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1810 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Minor > > MiNiFi logs to file by default and these logs are hard to view in case of a > container deployment. The optimal way to view these logs would be through the > docker logs command which reads from the stdout. We should provide the logs > to be viewable through the docker logs command for easier debugging. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MINIFICPP-1810) Forward MiNiFi logs to docker logs output
Gábor Gyimesi created MINIFICPP-1810: Summary: Forward MiNiFi logs to docker logs output Key: MINIFICPP-1810 URL: https://issues.apache.org/jira/browse/MINIFICPP-1810 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Gábor Gyimesi MiNiFi logs to file by default and these logs are hard to view in case of a container deployment. The optimal way to view these logs would be through the docker logs command which reads from the stdout. We should provide the logs to be viewable through the docker logs command for easier debugging. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (NIFI-9855) NiFi Can Delete Its Own Configuration Files
[ https://issues.apache.org/jira/browse/NIFI-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R resolved NIFI-9855. -- Resolution: Won't Fix Looks like this wont gain traction > NiFi Can Delete Its Own Configuration Files > --- > > Key: NIFI-9855 > URL: https://issues.apache.org/jira/browse/NIFI-9855 > Project: Apache NiFi > Issue Type: Bug > Components: Security >Affects Versions: 1.16.0, 1.15.2, 1.15.3 > Environment: All Linux Distros >Reporter: Mike R >Priority: Major > > Using the GetFile and PutFile processors, an attacker could overwrite the > configuration files to the /dev/null. Using a regex of (.*?), an attacker > could point the GetFile Processor to the directory which the NiFi > configuration files are located in. If the attacker is able to login, they > can send the files to /dev/null on Linux, which although it will cause a > warning in the PutFile processor, it will still process. > This does not require that the attacker have access to the underlying system, > but rather just NiFi itself. > The ways to prevent this from happening would be to prevent the GetFile > Processor and other NiFi processors from being able to directly read files > from the configuration directories in a way that deletes the existing files > and another option would be to have processors prevented from overwriting > configuration directory files. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (NIFI-9901) Implement Module for Common XML Utilities
[
https://issues.apache.org/jira/browse/NIFI-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525772#comment-17525772
]
ASF subversion and git services commented on NIFI-9901:
---
Commit e6d67dd104a6f540e7d3ba72a00c9c5a9e2c8cd8 in nifi's branch
refs/heads/support/nifi-1.16 from Joe Witt
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e6d67dd104 ]
NIFI-9901 fixing version references
> Implement Module for Common XML Utilities
> -
>
> Key: NIFI-9901
> URL: https://issues.apache.org/jira/browse/NIFI-9901
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.16.0
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The {{nifi-security-utils}} module includes several classes for working with
> various Java XML components. These classes are self-contained, and do not
> require the set of dependencies listed for {{{}nifi-security-utils{}}}.
> Refactoring these classes to a new module under {{nifi-commons}} would
> streamline the dependency tree for other modules that do not need Bouncy
> Castle or other dependencies of {{{}nifi-security-utils{}}}.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (NIFI-9826) Test failure on Ubuntu when using C locale
[
https://issues.apache.org/jira/browse/NIFI-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525768#comment-17525768
]
ASF subversion and git services commented on NIFI-9826:
---
Commit 520d2b145936f71fabf50e1c3a4e64b5765e0b54 in nifi's branch
refs/heads/support/nifi-1.16 from Paul Grey
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=520d2b1459 ]
NIFI-9826 Moved build locale settings from Maven to GitHub Workflow
- Adjusted Java 17 build locale settings
- Added test to verify match between System properties and build environment
variables
This closes #5980
Signed-off-by: David Handermann
> Test failure on Ubuntu when using C locale
> --
>
> Key: NIFI-9826
> URL: https://issues.apache.org/jira/browse/NIFI-9826
> Project: Apache NiFi
> Issue Type: Bug
> Environment: Ubuntu 20.04, openjdk-17 and openjdk-8
>Reporter: Marton Szasz
>Assignee: Paul Grey
>Priority: Minor
> Fix For: 1.17.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> When building NiFi, I ran into test failures:
> {code:java}
> [ERROR] Tests run: 7, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 2.689
> s <<< FAILURE! - in org.apache.nifi.dbcp.HikariCPConnectionPoolTest
> [ERROR] org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection
> Time elapsed: 1.113 s <<< ERROR!
> org.apache.nifi.processor.exception.ProcessException: Connection retrieval
> failed
> at
> org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testGetConnection(HikariCPConnectionPoolTest.java:152)
> Caused by: java.sql.SQLException: Failed to create database
> '/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException: Failed to create
> database
> '/tmp/HikariCPConnectionPoolTest-d9b0c324-86e6-4f15-818a-020c4de84ee2', see
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException:
> Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting
> ln[_CO[_variant]]
> ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter
> ISO-3166 country codes, see java.util.Locale.
> [ERROR]
> org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect Time
> elapsed: 1.019 s <<< ERROR!
> org.apache.nifi.processor.exception.ProcessException: Connection retrieval
> failed
> at
> org.apache.nifi.dbcp.HikariCPConnectionPoolTest.testCreateInsertSelect(HikariCPConnectionPoolTest.java:172)
> Caused by: java.sql.SQLException: Failed to create database
> '/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException: Failed to create
> database
> '/tmp/HikariCPConnectionPoolTest-e933e90f-c201-46d3-88f6-74bbcec53ab6', see
> the next exception for details.
> Caused by: org.apache.derby.iapi.error.StandardException:
> Supplied locale description 'en_${USER.COUNTRY}' is invalid, expecting
> ln[_CO[_variant]]
> ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter
> ISO-3166 country codes, see java.util.Locale. {code}
>
> My system locale was set to C.UTF-8. When changed to en_US.UTF-8, the build
> succeeded.
> Steps to reproduce:
> {code:java}
> export LANG=C.UTF-8
> export LC_ALL=C.UTF-8
> mvn package{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (NIFI-9861) Stateless ClassLoader isolation does not work on Java 11
[
https://issues.apache.org/jira/browse/NIFI-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525769#comment-17525769
]
ASF subversion and git services commented on NIFI-9861:
---
Commit ea7a343c6b7d9e65f5f4f64bc71e90672c06641f in nifi's branch
refs/heads/support/nifi-1.16 from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ea7a343c6b ]
NIFI-9861: Removed BlockListClassLoader in favor of AllowListClassLoader
NIFI-9861: Fixed stateless-processor-tests assembly to ensure that all
necessary libraries were included; removed BlockListClassLoader
NIFI-9861: Fixed issue in which we would list .class files as files that we
allow through the AllowListClassLoader but didn't allow them.
This closes #5925.
Signed-off-by: Peter Turcsanyi
> Stateless ClassLoader isolation does not work on Java 11
>
>
> Key: NIFI-9861
> URL: https://issues.apache.org/jira/browse/NIFI-9861
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.17.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Stateless ClassLoader isolation implementation (NIFI-9576) expects that the
> system class loader is an {{URLClassLoader}} instance but it is not true for
> Java 11. Due to this, {{BlockListClassLoader}} gets initialized with an empty
> set of classes and it cannot block anything (there is no isolation, otherwise
> it works on Java 11 as before NIFI-9576)
> [https://github.com/apache/nifi/blob/7fde2bbfd1afdd6037765340eca9fc675542323e/nifi-stateless/nifi-stateless-bootstrap/src/main/java/org/apache/nifi/stateless/bootstrap/StatelessBootstrap.java#L150-L153]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (NIFI-9942) Remove Load Test method from TestPutUDP
[
https://issues.apache.org/jira/browse/NIFI-9942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525770#comment-17525770
]
ASF subversion and git services commented on NIFI-9942:
---
Commit 6596d05144a27d9db07c26365d414fc1675b7d44 in nifi's branch
refs/heads/support/nifi-1.16 from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6596d05144 ]
NIFI-9942 Removed load test from TestPutUDP
- Refactored TestPutUDP using JUnit 5
- Standardized test method naming
This closes #5984
Signed-off-by: Paul Grey
> Remove Load Test method from TestPutUDP
> ---
>
> Key: NIFI-9942
> URL: https://issues.apache.org/jira/browse/NIFI-9942
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions, Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Trivial
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The {{TestPutUDP}} class includes a method that tests sending 500 messages,
> requiring 500 invocations of the {{PutUDP}} processor. This kind of test is
> not optimal for automated builds, and can be subject to intermittent
> failures, so it should be removed.
> {noformat}
> Error: Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 31.211 s <<< FAILURE! - in org.apache.nifi.processors.standard.TestPutUDP
> Error: org.apache.nifi.processors.standard.TestPutUDP.testLoadTest Time
> elapsed: 30.107 s <<< ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 3
> milliseconds
> at
> app//org.apache.nifi.processors.standard.TestPutUDP.checkReceivedAllData(TestPutUDP.java:229)
> at
> app//org.apache.nifi.processors.standard.TestPutUDP.testLoadTest(TestPutUDP.java:173)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (NIFI-9940) Update the StandardProcessGroupSynchronizer so that it can synchronize other components
[ https://issues.apache.org/jira/browse/NIFI-9940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525771#comment-17525771 ] ASF subversion and git services commented on NIFI-9940: --- Commit b989a620b09de2dc97394c796bc226f90463a1e2 in nifi's branch refs/heads/support/nifi-1.16 from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b989a620b0 ] NIFI-9940: Renamed StandardProcessGroupSynchronizer to StandardVersionedComponentSynchronizer. Added synching for processors, input/output ports, connections, etc. Added unit tests. This closes #5983 > Update the StandardProcessGroupSynchronizer so that it can synchronize other > components > --- > > Key: NIFI-9940 > URL: https://issues.apache.org/jira/browse/NIFI-9940 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.17.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The StandardProcessGroupSynchronizer works by synchronizing an entire > ProcessGroup with a VersionedProcessGroup. However, we should also allow > synchronizing individual components. There are many future improvements that > can be built off of this, such as reverting changes to a single component > instead of reverting all changes to a Process Group, etc. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (NIFI-9945) Upgrade jQuery UI - v1.12.1 To 1.13.1
Mike R created NIFI-9945: Summary: Upgrade jQuery UI - v1.12.1 To 1.13.1 Key: NIFI-9945 URL: https://issues.apache.org/jira/browse/NIFI-9945 Project: Apache NiFi Issue Type: Bug Components: Core UI Affects Versions: 1.15.3, 1.15.2, 1.15.1, 1.16.0 Environment: Windows, Unix Reporter: Mike R NiFi uses a vulnerable version of JQuery UI, which has 3 CVEs against it. CVE-2021-41182 - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41182 CVE-2021-41183 - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41183 CVE-2021-41184 - [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41184] Lets mitigate this by upgrading the version of JQuery UI used by NiFi to 1.13.1 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (NIFI-9940) Update the StandardProcessGroupSynchronizer so that it can synchronize other components
[ https://issues.apache.org/jira/browse/NIFI-9940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFI-9940. --- Fix Version/s: 1.17.0 Resolution: Fixed > Update the StandardProcessGroupSynchronizer so that it can synchronize other > components > --- > > Key: NIFI-9940 > URL: https://issues.apache.org/jira/browse/NIFI-9940 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.17.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The StandardProcessGroupSynchronizer works by synchronizing an entire > ProcessGroup with a VersionedProcessGroup. However, we should also allow > synchronizing individual components. There are many future improvements that > can be built off of this, such as reverting changes to a single component > instead of reverting all changes to a Process Group, etc. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (NIFI-9940) Update the StandardProcessGroupSynchronizer so that it can synchronize other components
[ https://issues.apache.org/jira/browse/NIFI-9940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525760#comment-17525760 ] ASF subversion and git services commented on NIFI-9940: --- Commit 5a3c7d1fbd78e78c79d206e34b6f30e25b108faf in nifi's branch refs/heads/main from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5a3c7d1fbd ] NIFI-9940: Renamed StandardProcessGroupSynchronizer to StandardVersionedComponentSynchronizer. Added synching for processors, input/output ports, connections, etc. Added unit tests. This closes #5983 > Update the StandardProcessGroupSynchronizer so that it can synchronize other > components > --- > > Key: NIFI-9940 > URL: https://issues.apache.org/jira/browse/NIFI-9940 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The StandardProcessGroupSynchronizer works by synchronizing an entire > ProcessGroup with a VersionedProcessGroup. However, we should also allow > synchronizing individual components. There are many future improvements that > can be built off of this, such as reverting changes to a single component > instead of reverting all changes to a Process Group, etc. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [nifi] asfgit closed pull request #5983: NIFI-9940: Renamed StandardProcessGroupSynchronizer to StandardVersionedComponentSynchronizer. Added synching for processors, input/output ports, conn
asfgit closed pull request #5983: NIFI-9940: Renamed StandardProcessGroupSynchronizer to StandardVersionedComponentSynchronizer. Added synching for processors, input/output ports, connections, etc. URL: https://github.com/apache/nifi/pull/5983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #5983: NIFI-9940: Renamed StandardProcessGroupSynchronizer to StandardVersionedComponentSynchronizer. Added synching for processors, input/output ports
bbende commented on PR #5983: URL: https://github.com/apache/nifi/pull/5983#issuecomment-1105290433 Looks good, going to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-1808) Improve RawSocketProtocol authorization error logging
[ https://issues.apache.org/jira/browse/MINIFICPP-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-1808: --- Status: Patch Available (was: In Progress) https://github.com/apache/nifi-minifi-cpp/pull/1314 > Improve RawSocketProtocol authorization error logging > - > > Key: MINIFICPP-1808 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1808 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Trivial > Time Spent: 10m > Remaining Estimate: 0h > > Currently we log error_code 240 as an unknown respond code, instead of > describing it as an authorization error. > This can cause confusion when setting up a RemoteProcessorGroup. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (NIFI-9942) Remove Load Test method from TestPutUDP
[
https://issues.apache.org/jira/browse/NIFI-9942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525728#comment-17525728
]
ASF subversion and git services commented on NIFI-9942:
---
Commit 1e345db64962c024ce91cc1717d444630b125347 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1e345db649 ]
NIFI-9942 Removed load test from TestPutUDP
- Refactored TestPutUDP using JUnit 5
- Standardized test method naming
This closes #5984
Signed-off-by: Paul Grey
> Remove Load Test method from TestPutUDP
> ---
>
> Key: NIFI-9942
> URL: https://issues.apache.org/jira/browse/NIFI-9942
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions, Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Trivial
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The {{TestPutUDP}} class includes a method that tests sending 500 messages,
> requiring 500 invocations of the {{PutUDP}} processor. This kind of test is
> not optimal for automated builds, and can be subject to intermittent
> failures, so it should be removed.
> {noformat}
> Error: Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 31.211 s <<< FAILURE! - in org.apache.nifi.processors.standard.TestPutUDP
> Error: org.apache.nifi.processors.standard.TestPutUDP.testLoadTest Time
> elapsed: 30.107 s <<< ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 3
> milliseconds
> at
> app//org.apache.nifi.processors.standard.TestPutUDP.checkReceivedAllData(TestPutUDP.java:229)
> at
> app//org.apache.nifi.processors.standard.TestPutUDP.testLoadTest(TestPutUDP.java:173)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [nifi] greyp9 closed pull request #5984: NIFI-9942 Remove load test from TestPutUDP
greyp9 closed pull request #5984: NIFI-9942 Remove load test from TestPutUDP URL: https://github.com/apache/nifi/pull/5984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-1803) Stop instantiating all classes on the first heartbeat
[ https://issues.apache.org/jira/browse/MINIFICPP-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits reassigned MINIFICPP-1803: - Assignee: Ferenc Gerlits > Stop instantiating all classes on the first heartbeat > - > > Key: MINIFICPP-1803 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1803 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Affects Versions: 0.6.0, 0.9.0, 0.7.0, 0.10.0, 0.11.0 >Reporter: Marton Szasz >Assignee: Ferenc Gerlits >Priority: Major > Labels: MiNiFi-CPP-Hygiene > > When producing the first heartbeat, BuildDescription::getClassDescriptions > instantiates *every single class* of each loader. In the case of AWS, the > processors happen to derive from S3Processor, and they contain a data member > of type Aws::Client::ClientConfiguration, whose default constructor makes > HTTP calls to AWS. > The easy fix is to delay the initialization of this particular member to > onSchedule. > The proper fix is to change the class loading and class description > generation logic to store more metadata about classes that are collected at > registration time, using compile-time introspection, instead of instantiating > the classes and using dynamic_cast. > This issue is about the proper fix. For the easy fix, see MINIFICPP-1802. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1314: MINIFICPP-1808 Improve RawSocketProtocol authorization error logging
martinzink opened a new pull request, #1314: URL: https://github.com/apache/nifi-minifi-cpp/pull/1314 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-1809) Improve the test coverage of cron driven scheduling
Martin Zink created MINIFICPP-1809: -- Summary: Improve the test coverage of cron driven scheduling Key: MINIFICPP-1809 URL: https://issues.apache.org/jira/browse/MINIFICPP-1809 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Martin Zink I couldn't find any test that verifies the behavior of CronDrivenSchedulingAgent We should create cpp and possible docker tests as well. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (NIFI-9938) Correct error message for PublishKafkaRecord_2_6 and PublishKafka_2_6
[
https://issues.apache.org/jira/browse/NIFI-9938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-9938:
-
Affects Version/s: 1.15.3
1.15.2
1.15.1
1.16.0
1.15.0
> Correct error message for PublishKafkaRecord_2_6 and PublishKafka_2_6
> -
>
> Key: NIFI-9938
> URL: https://issues.apache.org/jira/browse/NIFI-9938
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.15.0, 1.16.0, 1.15.1, 1.15.2, 1.15.3, 1.16.1
>Reporter: RAVINARAYAN SINGH
>Priority: Major
> Labels: bulletins
> Fix For: 1.17.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I am trying to read bulletin and I have observed two kind of message like
> below, one has bulletinFlowFileUuid and other won't have (as i notice they
> have uuid in bulletin message )
> {code:java}
> {
> "objectId" : "133daa29-c7a2-4e27-8280-93515afe21e8",
> "platform" : "nifi",
> "bulletinId" : 73,
> "bulletinCategory" : "Log Message",
> "bulletinGroupId" : "0180100d-8831-1705-c91e-fcf56119b794",
> "bulletinGroupName" : "",
> "bulletinGroupPath" : "",
> "bulletinLevel" : "ERROR",
> "bulletinMessage" :
> "PublishKafkaRecord_2_6[id=8831175d-101e-1180-d015-af879f9a08a3] Failed to
> send
> StandardFlowFileRecord[uuid=a2ae7ce6-cc6a-431a-a07c-a27eae803574,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1650393486592-12, container=default,
> section=12], offset=0,
> length=1068652],offset=0,name=aadbb17b-a59d-4d54-9054-4b38afb939f3,size=1068652]
> to Kafka: org.apache.kafka.common.errors.RecordTooLargeException: The
> message is 1068740 bytes when serialized which is larger than 1048576, which
> is the value of the max.request.size configuration.",
> "bulletinSourceId" : "8831175d-101e-1180-d015-af879f9a08a3",
> "bulletinSourceName" : "PublishKafkaRecord_2_6",
> "bulletinSourceType" : "PROCESSOR",
> "bulletinTimestamp" : "2022-04-19T18:38:20.721Z"
> }
> {
> "objectId" : "8af0eda1-4911-471f-811c-f914f560496d",
> "platform" : "nifi",
> "bulletinId" : 70,
> "bulletinCategory" : "Log Message",
> "bulletinGroupId" : "8831179e-1014-1180-9473-af0432d259ad",
> "bulletinGroupName" : "BulletinPublisher",
> "bulletinGroupPath" : "NiFi Flow / BulletinPublisher",
> "bulletinLevel" : "ERROR",
> "bulletinMessage" :
> "EvaluateJsonPath[id=88311752-101e-1180-1783-1c1ccf760a91] FlowFile
> FlowFile[filename=441b9cc4-a8d3-4426-8dbb-0cd49de2bac2] did not have valid
> JSON content.",
> "bulletinSourceId" : "88311752-101e-1180-1783-1c1ccf760a91",
> "bulletinSourceName" : "EvaluateJsonPath",
> "bulletinSourceType" : "PROCESSOR",
> "bulletinTimestamp" : "2022-04-19T18:22:10.078Z",
> "bulletinFlowFileUuid" : "441b9cc4-a8d3-4426-8dbb-0cd49de2bac2"
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (NIFI-9938) Correct error message for PublishKafkaRecord_2_6 and PublishKafka_2_6
[
https://issues.apache.org/jira/browse/NIFI-9938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne resolved NIFI-9938.
--
Fix Version/s: 1.17.0
Resolution: Fixed
> Correct error message for PublishKafkaRecord_2_6 and PublishKafka_2_6
> -
>
> Key: NIFI-9938
> URL: https://issues.apache.org/jira/browse/NIFI-9938
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.16.1
>Reporter: RAVINARAYAN SINGH
>Priority: Major
> Labels: bulletins
> Fix For: 1.17.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I am trying to read bulletin and I have observed two kind of message like
> below, one has bulletinFlowFileUuid and other won't have (as i notice they
> have uuid in bulletin message )
> {code:java}
> {
> "objectId" : "133daa29-c7a2-4e27-8280-93515afe21e8",
> "platform" : "nifi",
> "bulletinId" : 73,
> "bulletinCategory" : "Log Message",
> "bulletinGroupId" : "0180100d-8831-1705-c91e-fcf56119b794",
> "bulletinGroupName" : "",
> "bulletinGroupPath" : "",
> "bulletinLevel" : "ERROR",
> "bulletinMessage" :
> "PublishKafkaRecord_2_6[id=8831175d-101e-1180-d015-af879f9a08a3] Failed to
> send
> StandardFlowFileRecord[uuid=a2ae7ce6-cc6a-431a-a07c-a27eae803574,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1650393486592-12, container=default,
> section=12], offset=0,
> length=1068652],offset=0,name=aadbb17b-a59d-4d54-9054-4b38afb939f3,size=1068652]
> to Kafka: org.apache.kafka.common.errors.RecordTooLargeException: The
> message is 1068740 bytes when serialized which is larger than 1048576, which
> is the value of the max.request.size configuration.",
> "bulletinSourceId" : "8831175d-101e-1180-d015-af879f9a08a3",
> "bulletinSourceName" : "PublishKafkaRecord_2_6",
> "bulletinSourceType" : "PROCESSOR",
> "bulletinTimestamp" : "2022-04-19T18:38:20.721Z"
> }
> {
> "objectId" : "8af0eda1-4911-471f-811c-f914f560496d",
> "platform" : "nifi",
> "bulletinId" : 70,
> "bulletinCategory" : "Log Message",
> "bulletinGroupId" : "8831179e-1014-1180-9473-af0432d259ad",
> "bulletinGroupName" : "BulletinPublisher",
> "bulletinGroupPath" : "NiFi Flow / BulletinPublisher",
> "bulletinLevel" : "ERROR",
> "bulletinMessage" :
> "EvaluateJsonPath[id=88311752-101e-1180-1783-1c1ccf760a91] FlowFile
> FlowFile[filename=441b9cc4-a8d3-4426-8dbb-0cd49de2bac2] did not have valid
> JSON content.",
> "bulletinSourceId" : "88311752-101e-1180-1783-1c1ccf760a91",
> "bulletinSourceName" : "EvaluateJsonPath",
> "bulletinSourceType" : "PROCESSOR",
> "bulletinTimestamp" : "2022-04-19T18:22:10.078Z",
> "bulletinFlowFileUuid" : "441b9cc4-a8d3-4426-8dbb-0cd49de2bac2"
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [nifi] markap14 commented on pull request #5979: NIFI-9938 Error Reporting message has been Fixed for Kafka Bundle
markap14 commented on PR #5979: URL: https://github.com/apache/nifi/pull/5979#issuecomment-1105189333 THanks @ravinarayansingh looks good, merged to main. Thanks for fixing that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markap14 merged pull request #5979: NIFI-9938 Error Reporting message has been Fixed for Kafka Bundle
markap14 merged PR #5979: URL: https://github.com/apache/nifi/pull/5979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on pull request #1310: MINIFICPP-1806 - Use boyer_moore for extension verification
adamdebreceni commented on PR #1310: URL: https://github.com/apache/nifi-minifi-cpp/pull/1310#issuecomment-1105155136 > I think the clang job should be investigated, the FileUtilTests failure might relate to this change: > > ``` > double free or corruption (!prev) > > > 99% tests passed, 1 tests failed out of 183 > > Total Test time (real) = 300.55 sec > > The following tests FAILED: > 27 - FileUtilsTests (Timeout) > ``` yes it is currently being investigated, I will move it to draft until it is sorted out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #5986: NIFI-9943 Add Transform Provider to nifi-xml-processing
exceptionfactory commented on code in PR #5986:
URL: https://github.com/apache/nifi/pull/5986#discussion_r855133072
##
nifi-commons/nifi-xml-processing/src/main/java/org/apache/nifi/xml/processing/transform/StandardTransformProvider.java:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.xml.processing.transform;
+
+import org.apache.nifi.xml.processing.ProcessingAttribute;
+import org.apache.nifi.xml.processing.ProcessingException;
+
+import javax.xml.XMLConstants;
+import javax.xml.transform.OutputKeys;
+import javax.xml.transform.Result;
+import javax.xml.transform.Source;
+import javax.xml.transform.Transformer;
+import javax.xml.transform.TransformerConfigurationException;
+import javax.xml.transform.TransformerException;
+import javax.xml.transform.TransformerFactory;
+import java.util.Objects;
+
+/**
+ * Standard implementation of Transform Provider with secure processing enabled
+ */
+public class StandardTransformProvider implements TransformProvider {
+private static final boolean SECURE_PROCESSING_ENABLED = true;
+
+private static final String ENABLED_PROPERTY = "yes";
+
+private static final String INDENT_AMOUNT_OUTPUT_KEY =
"{http://xml.apache.org/xslt}indent-amount";;
+
+private static final String INDENT_AMOUNT = "2";
+
+private boolean indent;
+
+private boolean omitXmlDeclaration;
+
+private String method;
+
+/**
+ * Set Indent Status
+ *
+ * @param indent Indent Status
+ */
+public void setIndent(final boolean indent) {
+this.indent = indent;
+}
+
+/**
+ * Set Output Method
+ *
+ * @param method Method or null when default configuration should be used
+ */
+public void setMethod(final String method) {
+this.method = method;
+}
+
+/**
+ * Set Omit XML Declaration
+ *
+ * @param omitXmlDeclaration Omit XML Declaration
+ */
+public void setOmitXmlDeclaration(final boolean omitXmlDeclaration) {
+this.omitXmlDeclaration = omitXmlDeclaration;
+}
+
+/**
+ * Transform Source to Result
+ *
+ * @param source Source to be transformed
+ * @param result Result containing transformed information
+ */
+@Override
+public void transform(final Source source, final Result result) {
+Objects.requireNonNull(source, "Source required");
+Objects.requireNonNull(result, "Result required");
+
+final TransformerFactory transformerFactory =
TransformerFactory.newInstance();
+final Transformer transformer;
+try {
+transformerFactory.setAttribute(XMLConstants.ACCESS_EXTERNAL_DTD,
ProcessingAttribute.ACCESS_EXTERNAL_DTD.getValue());
+
transformerFactory.setAttribute(XMLConstants.ACCESS_EXTERNAL_STYLESHEET,
ProcessingAttribute.ACCESS_EXTERNAL_STYLESHEET.getValue());
+
transformerFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING,
SECURE_PROCESSING_ENABLED);
Review Comment:
Thanks for the feedback @pjfanning. Are you referring to old version of
Xalan? The documentation
[TransformerFactory.setFeature()](https://docs.oracle.com/javase/8/docs/api/javax/xml/transform/TransformerFactory.html#setAttribute-java.lang.String-java.lang.Object-)
documentation for Java 8 indicates the following:
> All implementations that implement JAXP 1.5 or newer are required to
support the
[XMLConstants.ACCESS_EXTERNAL_DTD](https://docs.oracle.com/javase/8/docs/api/javax/xml/XMLConstants.html#ACCESS_EXTERNAL_DTD)
and
[XMLConstants.ACCESS_EXTERNAL_STYLESHEET](https://docs.oracle.com/javase/8/docs/api/javax/xml/XMLConstants.html#ACCESS_EXTERNAL_STYLESHEET)
properties.
NiFi requires Java 8 as a minimum version, and framework usage of XML
transformation does not support overriding the JAXP implementation.
Although separating the calls into different blocks might help clarify what
failed, it seems like it would still result in failures on supported JAXP
implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1310: MINIFICPP-1806 - Use boyer_moore for extension verification
lordgamez commented on PR #1310: URL: https://github.com/apache/nifi-minifi-cpp/pull/1310#issuecomment-1105144011 I think the clang job should be investigated, the FileUtilTests failure might relate to this change: ``` double free or corruption (!prev) 99% tests passed, 1 tests failed out of 183 Total Test time (real) = 300.55 sec The following tests FAILED: 27 - FileUtilsTests (Timeout) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-1808) Improve RawSocketProtocol authorization error logging
Martin Zink created MINIFICPP-1808: -- Summary: Improve RawSocketProtocol authorization error logging Key: MINIFICPP-1808 URL: https://issues.apache.org/jira/browse/MINIFICPP-1808 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Martin Zink Assignee: Martin Zink Currently we log error_code 240 as an unknown respond code, instead of describing it as an authorization error. This can cause confusion when setting up a RemoteProcessorGroup. -- This message was sent by Atlassian Jira (v8.20.7#820007)
