[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6686: NIFI-10842 Adding option to disable HTTP2 in StandardOauth2AccessTokenProvider
exceptionfactory commented on code in PR #6686: URL: https://github.com/apache/nifi/pull/6686#discussion_r1027016177 ## nifi-nar-bundles/nifi-standard-services/nifi-oauth2-provider-bundle/nifi-oauth2-provider-service/src/main/java/org/apache/nifi/oauth2/HttpProtocolStrategy.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.oauth2; + +import org.apache.nifi.components.DescribedValue; +import org.apache.nifi.jetty.configuration.connector.ApplicationLayerProtocol; Review Comment: It looks like this import needs to be removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on pull request #6686: NIFI-10842 Adding option to disable HTTP2 in StandardOauth2AccessTokenProvider
MikeThomsen commented on PR #6686: URL: https://github.com/apache/nifi/pull/6686#issuecomment-1320647037 @ruckc FYI https://user-images.githubusercontent.com/108184/202819429-100ee521-b58a-479b-be5c-f74919b21594.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-10842) StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
[
https://issues.apache.org/jira/browse/NIFI-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636061#comment-17636061
]
Curtis W Ruck commented on NIFI-10842:
--
Just wish all issues were this easy.
> StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
> --
>
> Key: NIFI-10842
> URL: https://issues.apache.org/jira/browse/NIFI-10842
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.18.0
>Reporter: Curtis W Ruck
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We are trying to use nifi's StandardOauth2AccessTokenProvider to enable
> authentication in concert with InvokeHTTP to make requests to a REST API. The
> OAuth2 server is responding with a HTTP 408 error code, and okhttp3 is
> throwing a "stream was reset: HTTP_1_1_REQUIRED" exception.
> In the same manner that InvokeHTTP got the `HTTP/2 Disabled` property, it
> would be nice if StandardOauth2AccessTokenProvider had the same property.
> {code:java}
> 2022-11-18 20:44:17,842 ERROR [Timer-Driven Process Thread-9]
> o.a.nifi.processors.standard.InvokeHTTP
> InvokeHTTP[id=8c6c303d-0184-1000-2cd2-c88625f9a563] Failed to properly
> initialize Processor. If still scheduled to run, NiFi will attempt to
> initialize and run the Processor again after the 'Administrative Yield
> Duration' has elapsed. Failure is due to java.io.UncheckedIOException: OAuth2
> access token request failed
> java.io.UncheckedIOException: OAuth2 access token request failed
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:330)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.acquireAccessDetails(StandardOauth2AccessTokenProvider.java:289)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:243)
> at jdk.internal.reflect.GeneratedMethodAccessor966.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:105)
> at com.sun.proxy.$Proxy216.getAccessDetails(Unknown Source)
> at
> org.apache.nifi.processors.standard.InvokeHTTP.initOauth2AccessTokenProvider(InvokeHTTP.java:875)
> at jdk.internal.reflect.GeneratedMethodAccessor965.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
> at
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$8(StandardProcessorNode.java:1733)
> at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: okhttp3.internal.http2.StreamResetException: stream was reset:
> HTTP_1_1_REQUIRED
> at okhttp3.internal.http2.Http2Stream.takeHeaders(Http2Stream.kt:148)
> at
> okhttp3.internal.http2.Http2ExchangeCodec.readResponseHeaders(Http2ExchangeCodec.kt:96)
> at
> okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.kt:106)
> at
> okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:79)
> at
> okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
> at
> okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:34)
> at
> okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
> at
> okhttp3.internal.cache.
[jira] [Commented] (NIFI-10842) StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
[
https://issues.apache.org/jira/browse/NIFI-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636059#comment-17636059
]
David Handermann commented on NIFI-10842:
-
Thanks for working on resolving the issue [~ruckc]!
> StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
> --
>
> Key: NIFI-10842
> URL: https://issues.apache.org/jira/browse/NIFI-10842
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.18.0
>Reporter: Curtis W Ruck
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We are trying to use nifi's StandardOauth2AccessTokenProvider to enable
> authentication in concert with InvokeHTTP to make requests to a REST API. The
> OAuth2 server is responding with a HTTP 408 error code, and okhttp3 is
> throwing a "stream was reset: HTTP_1_1_REQUIRED" exception.
> In the same manner that InvokeHTTP got the `HTTP/2 Disabled` property, it
> would be nice if StandardOauth2AccessTokenProvider had the same property.
> {code:java}
> 2022-11-18 20:44:17,842 ERROR [Timer-Driven Process Thread-9]
> o.a.nifi.processors.standard.InvokeHTTP
> InvokeHTTP[id=8c6c303d-0184-1000-2cd2-c88625f9a563] Failed to properly
> initialize Processor. If still scheduled to run, NiFi will attempt to
> initialize and run the Processor again after the 'Administrative Yield
> Duration' has elapsed. Failure is due to java.io.UncheckedIOException: OAuth2
> access token request failed
> java.io.UncheckedIOException: OAuth2 access token request failed
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:330)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.acquireAccessDetails(StandardOauth2AccessTokenProvider.java:289)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:243)
> at jdk.internal.reflect.GeneratedMethodAccessor966.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:105)
> at com.sun.proxy.$Proxy216.getAccessDetails(Unknown Source)
> at
> org.apache.nifi.processors.standard.InvokeHTTP.initOauth2AccessTokenProvider(InvokeHTTP.java:875)
> at jdk.internal.reflect.GeneratedMethodAccessor965.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
> at
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$8(StandardProcessorNode.java:1733)
> at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: okhttp3.internal.http2.StreamResetException: stream was reset:
> HTTP_1_1_REQUIRED
> at okhttp3.internal.http2.Http2Stream.takeHeaders(Http2Stream.kt:148)
> at
> okhttp3.internal.http2.Http2ExchangeCodec.readResponseHeaders(Http2ExchangeCodec.kt:96)
> at
> okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.kt:106)
> at
> okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:79)
> at
> okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
> at
> okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:34)
> at
> okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
> at
> ok
[jira] [Commented] (NIFI-10842) StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
[
https://issues.apache.org/jira/browse/NIFI-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636054#comment-17636054
]
Curtis W Ruck commented on NIFI-10842:
--
Roger will work that. Just opened a PR for this, cloning the functionality
from InvokeHTTP, will refactor based on ListenHTTP.
> StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
> --
>
> Key: NIFI-10842
> URL: https://issues.apache.org/jira/browse/NIFI-10842
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.18.0
>Reporter: Curtis W Ruck
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We are trying to use nifi's StandardOauth2AccessTokenProvider to enable
> authentication in concert with InvokeHTTP to make requests to a REST API. The
> OAuth2 server is responding with a HTTP 408 error code, and okhttp3 is
> throwing a "stream was reset: HTTP_1_1_REQUIRED" exception.
> In the same manner that InvokeHTTP got the `HTTP/2 Disabled` property, it
> would be nice if StandardOauth2AccessTokenProvider had the same property.
> {code:java}
> 2022-11-18 20:44:17,842 ERROR [Timer-Driven Process Thread-9]
> o.a.nifi.processors.standard.InvokeHTTP
> InvokeHTTP[id=8c6c303d-0184-1000-2cd2-c88625f9a563] Failed to properly
> initialize Processor. If still scheduled to run, NiFi will attempt to
> initialize and run the Processor again after the 'Administrative Yield
> Duration' has elapsed. Failure is due to java.io.UncheckedIOException: OAuth2
> access token request failed
> java.io.UncheckedIOException: OAuth2 access token request failed
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:330)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.acquireAccessDetails(StandardOauth2AccessTokenProvider.java:289)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:243)
> at jdk.internal.reflect.GeneratedMethodAccessor966.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:105)
> at com.sun.proxy.$Proxy216.getAccessDetails(Unknown Source)
> at
> org.apache.nifi.processors.standard.InvokeHTTP.initOauth2AccessTokenProvider(InvokeHTTP.java:875)
> at jdk.internal.reflect.GeneratedMethodAccessor965.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
> at
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$8(StandardProcessorNode.java:1733)
> at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: okhttp3.internal.http2.StreamResetException: stream was reset:
> HTTP_1_1_REQUIRED
> at okhttp3.internal.http2.Http2Stream.takeHeaders(Http2Stream.kt:148)
> at
> okhttp3.internal.http2.Http2ExchangeCodec.readResponseHeaders(Http2ExchangeCodec.kt:96)
> at
> okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.kt:106)
> at
> okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:79)
> at
> okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
> at
> okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:34)
> at
> okhttp3.internal.http.R
[GitHub] [nifi] ruckc opened a new pull request, #6686: NIFI-10842 Adding option to disable HTTP2 in StandardOauth2AccessTokenProvider
ruckc opened a new pull request, #6686: URL: https://github.com/apache/nifi/pull/6686 # Summary [NIFI-10842](https://issues.apache.org/jira/browse/NIFI-10842) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-10842) StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
[
https://issues.apache.org/jira/browse/NIFI-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636050#comment-17636050
]
David Handermann commented on NIFI-10842:
-
Thanks for the additional background [~ruckc], having those runtime details
should be helpful in reproducing the problem.
It may be best to implement an HTTP Protocols property, similar to ListenHTTP,
where there are three options:
* http/1.1
* h2 http/1.1
* h2
Although this is slightly different from the {{Disable HTTP/2}} Boolean
property in InvokeHTTP, it provides similar capabilities with a little more
flexibility.
The default value should include both {{h2}} and {{http/1.1}} to maintain the
current behavior.
> StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
> --
>
> Key: NIFI-10842
> URL: https://issues.apache.org/jira/browse/NIFI-10842
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.18.0
>Reporter: Curtis W Ruck
>Priority: Major
>
> We are trying to use nifi's StandardOauth2AccessTokenProvider to enable
> authentication in concert with InvokeHTTP to make requests to a REST API. The
> OAuth2 server is responding with a HTTP 408 error code, and okhttp3 is
> throwing a "stream was reset: HTTP_1_1_REQUIRED" exception.
> In the same manner that InvokeHTTP got the `HTTP/2 Disabled` property, it
> would be nice if StandardOauth2AccessTokenProvider had the same property.
> {code:java}
> 2022-11-18 20:44:17,842 ERROR [Timer-Driven Process Thread-9]
> o.a.nifi.processors.standard.InvokeHTTP
> InvokeHTTP[id=8c6c303d-0184-1000-2cd2-c88625f9a563] Failed to properly
> initialize Processor. If still scheduled to run, NiFi will attempt to
> initialize and run the Processor again after the 'Administrative Yield
> Duration' has elapsed. Failure is due to java.io.UncheckedIOException: OAuth2
> access token request failed
> java.io.UncheckedIOException: OAuth2 access token request failed
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:330)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.acquireAccessDetails(StandardOauth2AccessTokenProvider.java:289)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:243)
> at jdk.internal.reflect.GeneratedMethodAccessor966.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:105)
> at com.sun.proxy.$Proxy216.getAccessDetails(Unknown Source)
> at
> org.apache.nifi.processors.standard.InvokeHTTP.initOauth2AccessTokenProvider(InvokeHTTP.java:875)
> at jdk.internal.reflect.GeneratedMethodAccessor965.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
> at
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$8(StandardProcessorNode.java:1733)
> at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: okhttp3.internal.http2.StreamResetException: stream was reset:
> HTTP_1_1_REQUIRED
> at okhttp3.internal.http2.Http2Stream.takeHeaders(Http2Stream.kt:148)
> at
> okhttp3.internal.http2.Http2ExchangeCodec.readResponseHeaders(Http2ExchangeCodec.kt:96)
> at
> okhttp3.internal.connection
[jira] [Commented] (NIFI-10842) StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
[
https://issues.apache.org/jira/browse/NIFI-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636044#comment-17636044
]
Curtis W Ruck commented on NIFI-10842:
--
The OAuth2 server is running https (proxied via httpd 2.4.37 w/ mod_ssl and
http2). If I disable http2 on the remote httpd, it succeeds. The
authentication endpoints do have optional mutual TLS client certificate
authentication enabled, which appears to be what triggers the OkHttp3 bug.
> StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
> --
>
> Key: NIFI-10842
> URL: https://issues.apache.org/jira/browse/NIFI-10842
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.18.0
>Reporter: Curtis W Ruck
>Priority: Major
>
> We are trying to use nifi's StandardOauth2AccessTokenProvider to enable
> authentication in concert with InvokeHTTP to make requests to a REST API. The
> OAuth2 server is responding with a HTTP 408 error code, and okhttp3 is
> throwing a "stream was reset: HTTP_1_1_REQUIRED" exception.
> In the same manner that InvokeHTTP got the `HTTP/2 Disabled` property, it
> would be nice if StandardOauth2AccessTokenProvider had the same property.
> {code:java}
> 2022-11-18 20:44:17,842 ERROR [Timer-Driven Process Thread-9]
> o.a.nifi.processors.standard.InvokeHTTP
> InvokeHTTP[id=8c6c303d-0184-1000-2cd2-c88625f9a563] Failed to properly
> initialize Processor. If still scheduled to run, NiFi will attempt to
> initialize and run the Processor again after the 'Administrative Yield
> Duration' has elapsed. Failure is due to java.io.UncheckedIOException: OAuth2
> access token request failed
> java.io.UncheckedIOException: OAuth2 access token request failed
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:330)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.acquireAccessDetails(StandardOauth2AccessTokenProvider.java:289)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:243)
> at jdk.internal.reflect.GeneratedMethodAccessor966.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:105)
> at com.sun.proxy.$Proxy216.getAccessDetails(Unknown Source)
> at
> org.apache.nifi.processors.standard.InvokeHTTP.initOauth2AccessTokenProvider(InvokeHTTP.java:875)
> at jdk.internal.reflect.GeneratedMethodAccessor965.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
> at
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$8(StandardProcessorNode.java:1733)
> at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: okhttp3.internal.http2.StreamResetException: stream was reset:
> HTTP_1_1_REQUIRED
> at okhttp3.internal.http2.Http2Stream.takeHeaders(Http2Stream.kt:148)
> at
> okhttp3.internal.http2.Http2ExchangeCodec.readResponseHeaders(Http2ExchangeCodec.kt:96)
> at
> okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.kt:106)
> at
> okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:79)
> at
> okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
> at
> okhttp
[jira] [Commented] (NIFI-10842) StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
[
https://issues.apache.org/jira/browse/NIFI-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636043#comment-17636043
]
David Handermann commented on NIFI-10842:
-
OkHttp Issue 5100 mentions this error, but the issue was closed and not fixed.
> StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
> --
>
> Key: NIFI-10842
> URL: https://issues.apache.org/jira/browse/NIFI-10842
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.18.0
>Reporter: Curtis W Ruck
>Priority: Major
>
> We are trying to use nifi's StandardOauth2AccessTokenProvider to enable
> authentication in concert with InvokeHTTP to make requests to a REST API. The
> OAuth2 server is responding with a HTTP 408 error code, and okhttp3 is
> throwing a "stream was reset: HTTP_1_1_REQUIRED" exception.
> In the same manner that InvokeHTTP got the `HTTP/2 Disabled` property, it
> would be nice if StandardOauth2AccessTokenProvider had the same property.
> {code:java}
> 2022-11-18 20:44:17,842 ERROR [Timer-Driven Process Thread-9]
> o.a.nifi.processors.standard.InvokeHTTP
> InvokeHTTP[id=8c6c303d-0184-1000-2cd2-c88625f9a563] Failed to properly
> initialize Processor. If still scheduled to run, NiFi will attempt to
> initialize and run the Processor again after the 'Administrative Yield
> Duration' has elapsed. Failure is due to java.io.UncheckedIOException: OAuth2
> access token request failed
> java.io.UncheckedIOException: OAuth2 access token request failed
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:330)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.acquireAccessDetails(StandardOauth2AccessTokenProvider.java:289)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:243)
> at jdk.internal.reflect.GeneratedMethodAccessor966.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:105)
> at com.sun.proxy.$Proxy216.getAccessDetails(Unknown Source)
> at
> org.apache.nifi.processors.standard.InvokeHTTP.initOauth2AccessTokenProvider(InvokeHTTP.java:875)
> at jdk.internal.reflect.GeneratedMethodAccessor965.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
> at
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$8(StandardProcessorNode.java:1733)
> at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: okhttp3.internal.http2.StreamResetException: stream was reset:
> HTTP_1_1_REQUIRED
> at okhttp3.internal.http2.Http2Stream.takeHeaders(Http2Stream.kt:148)
> at
> okhttp3.internal.http2.Http2ExchangeCodec.readResponseHeaders(Http2ExchangeCodec.kt:96)
> at
> okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.kt:106)
> at
> okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:79)
> at
> okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
> at
> okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:34)
> at
> okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
> at
> okhttp3.internal.cache.Cache
[GitHub] [nifi] tpalfy commented on a diff in pull request #6670: NIFI-10832: Create PutSalesforceRecord processor
tpalfy commented on code in PR #6670:
URL: https://github.com/apache/nifi/pull/6670#discussion_r1026780290
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/util/RecordExtender.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.salesforce.util;
+
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.node.ObjectNode;
+import org.apache.nifi.serialization.SimpleRecordSchema;
+import org.apache.nifi.serialization.record.MapRecord;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.serialization.record.RecordField;
+import org.apache.nifi.serialization.record.RecordFieldType;
+import org.apache.nifi.serialization.record.RecordSchema;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+public class RecordExtender {
+
+private static final ObjectMapper MAPPER = new ObjectMapper();
+static final SimpleRecordSchema ATTRIBUTES_RECORD_SCHEMA = new
SimpleRecordSchema(Arrays.asList(
+new RecordField("type", RecordFieldType.STRING.getDataType()),
+new RecordField("referenceId",
RecordFieldType.STRING.getDataType())
+));
+
+public ObjectNode getWrappedRecordsJson(ByteArrayOutputStream out) throws
IOException {
+ObjectNode root = MAPPER.createObjectNode();
+JsonNode jsonNode = MAPPER.readTree(out.toByteArray());
+root.set("records", jsonNode);
+return root;
+}
+
+public MapRecord getExtendedRecord(String objectType, RecordSchema
originalSchema, int count, Record record) {
+SimpleRecordSchema extendedSchema = getExtendedSchema(originalSchema);
+
+Set rawFieldNames = record.getRawFieldNames();
+Map objectMap = rawFieldNames.stream()
+.collect(Collectors.toMap(Function.identity(),
record::getValue));
+
+Map attributesMap = new HashMap<>();
+attributesMap.put("type", objectType);
+attributesMap.put("referenceId", count);
+
+MapRecord attributesRecord = new MapRecord(ATTRIBUTES_RECORD_SCHEMA,
attributesMap);
+
+objectMap.put("attributes", attributesRecord);
+
+return new MapRecord(extendedSchema, objectMap);
+}
+
+public SimpleRecordSchema getExtendedSchema(RecordSchema original) {
Review Comment:
This would be better done once, in the constructor for example.
A challenge when it needs to be instantiated in a try-with-resources block
without implementing AutoClosable but there's a trick we can use:
```java
RecordExtender extender;
try (InputStream in = session.read(flowFile);
RecordReader reader =
readerFactory.createRecordReader(flowFile, in, getLogger());
ByteArrayOutputStream out = new ByteArrayOutputStream();
WriteJsonResult writer = getWriter(extender = new
RecordExtender(reader.getSchema()), out)) {
```
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/util/SalesforceRestService.java:
##
@@ -84,11 +86,28 @@ public InputStream getNextRecords(String nextRecordsUrl) {
return request(request);
}
+public InputStream postRecord(String sObjectApiName, String body) {
+String url = baseUrl + "/services/data/v" + version +
"/composite/tree/" + sObjectApiName;
+
+HttpUrl httpUrl = HttpUrl.get(url).newBuilder()
+.build();
+
+final RequestBody requestBody = RequestBody.create(body,
MediaType.parse("application/json"));
+
+Request request = new Request.Builder()
+.addHeader("Authorization", "Bearer " +
accessTokenProvider.get())
+.url(httpUrl)
+.post(requestBody)
+.build();
+
+
[GitHub] [nifi] thenatog commented on a diff in pull request #6637: NIFI-10177: implemented ID token logout and revoke access token logou…
thenatog commented on code in PR #6637:
URL: https://github.com/apache/nifi/pull/6637#discussion_r1026848869
##
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ApplicationResource.java:
##
@@ -230,4 +230,10 @@ protected RevisionInfo getRevisionInfo(final LongParameter
version, final Client
return revisionInfo;
}
+private String getNiFiRegistryUri() {
+final String nifiRegistryApiUrl = generateResourceUri();
+final String baseUrl =
StringUtils.substringBeforeLast(nifiRegistryApiUrl, "/nifi-registry-api");
+
+return baseUrl + "/nifi-registry/";
Review Comment:
I would check if there's a way to use UriBuilder here to build this path
instead of using string manipulation/substring
##
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:
##
@@ -175,6 +175,20 @@ public String generateSignedToken(String identity, String
preferredUsername, Str
}
+public void deleteKey(final String userIdentity) {
Review Comment:
Why does this method duplicate the below 'logOut()' method?
##
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/AccessResource.java:
##
@@ -704,20 +707,131 @@ public void oidcLogout(@Context HttpServletRequest
httpServletRequest, @Context
throw new IllegalStateException("OpenId Connect is not
configured.");
}
-final String tokenHeader =
httpServletRequest.getHeader(JwtService.AUTHORIZATION);
-jwtService.logOutUsingAuthHeader(tokenHeader);
+// Checks if OIDC service supports logout using either by
+// 1. revoke access token method, or
+// 2. ID token logout method.
+// If either of the above methods are supported,
+// redirects request to OP to request authorization that can be
exchanged for a token used for logout
Review Comment:
Just want to confirm this - my understanding is that if we have an id_token,
we can make a simple logout request to end_session_endpoint. If we only
received an access_token initially, we need to HTTP request a new access_token
and send this to revocation_endpoint. Is this how we are logging out/what this
comment is saying?
##
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/AccessResource.java:
##
@@ -832,4 +950,133 @@ private boolean isBasicLoginSupported(HttpServletRequest
request) {
private boolean isOIDCLoginSupported(HttpServletRequest request) {
return request.isSecure() && oidcService != null &&
oidcService.isOidcEnabled();
}
+
+private String determineLogoutMethod() {
+if (oidcService.getEndSessionEndpoint() != null) {
+return ID_TOKEN_LOGOUT;
+} else if (oidcService.getRevocationEndpoint() != null) {
+return REVOKE_ACCESS_TOKEN_LOGOUT;
+} else {
+return STANDARD_LOGOUT;
+}
+}
+
+/**
+ * Generates the request Authorization URI for the OpenID Connect
Provider. Returns an authorization
+ * URI using the provided callback URI.
+ *
+ * @param httpServletResponse the servlet response
+ * @param callback the OIDC callback URI
+ * @return the authorization URI
+ */
+private URI oidcRequestAuthorizationCode(@Context final
HttpServletResponse httpServletResponse, final String callback) {
+final String oidcRequestIdentifier = UUID.randomUUID().toString();
+// generate a cookie to associate this login sequence
+final Cookie cookie = new Cookie(OIDC_REQUEST_IDENTIFIER,
oidcRequestIdentifier);
+cookie.setPath("/");
+cookie.setHttpOnly(true);
+cookie.setMaxAge(60);
+cookie.setSecure(true);
+httpServletResponse.addCookie(cookie);
+
+// get the state for this request
+final State state = oidcService.createState(oidcRequestIdentifier);
+
+// build the authorization uri
+final URI authorizationUri =
UriBuilder.fromUri(oidcService.getAuthorizationEndpoint())
+.queryParam("client_id", oidcService.getClientId())
+.queryParam("response_type", "code")
+.queryParam("scope", oidcService.getScope().toString())
+.queryParam("state", state.getValue())
+.queryParam("redirect_uri", callback)
+.build();
+return authorizationUri;
+}
+
+private String getOidcRequestIdentifier(final HttpServletRequest
httpServletRequest) {
+return getCookieValue(httpServletRequest.getCookies(),
OIDC_REQUEST_IDENTIFIER);
+}
+
+private com.nimbusds.openid.connect.sdk.AuthenticationResponse
parseAuthenticationResponse(final URI requestUri,
Review Comment:
Is there a reason these nimbusds
[jira] [Commented] (NIFI-10842) StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
[
https://issues.apache.org/jira/browse/NIFI-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636035#comment-17636035
]
David Handermann commented on NIFI-10842:
-
Thanks for providing the stack trace associated with the error [~ruckc], that
is helpful.
Can you provide any additional details on the OAuth2 service with which NiFi is
interfacing? Is the OAuth2 service running over HTTPS? If so, it should
explicitly declare support for HTTP/2, or else OkHttp should fall back to
HTTP/1.1.
> StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
> --
>
> Key: NIFI-10842
> URL: https://issues.apache.org/jira/browse/NIFI-10842
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.18.0
>Reporter: Curtis W Ruck
>Priority: Major
>
> We are trying to use nifi's StandardOauth2AccessTokenProvider to enable
> authentication in concert with InvokeHTTP to make requests to a REST API. The
> OAuth2 server is responding with a HTTP 408 error code, and okhttp3 is
> throwing a "stream was reset: HTTP_1_1_REQUIRED" exception.
> In the same manner that InvokeHTTP got the `HTTP/2 Disabled` property, it
> would be nice if StandardOauth2AccessTokenProvider had the same property.
> {code:java}
> 2022-11-18 20:44:17,842 ERROR [Timer-Driven Process Thread-9]
> o.a.nifi.processors.standard.InvokeHTTP
> InvokeHTTP[id=8c6c303d-0184-1000-2cd2-c88625f9a563] Failed to properly
> initialize Processor. If still scheduled to run, NiFi will attempt to
> initialize and run the Processor again after the 'Administrative Yield
> Duration' has elapsed. Failure is due to java.io.UncheckedIOException: OAuth2
> access token request failed
> java.io.UncheckedIOException: OAuth2 access token request failed
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:330)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.acquireAccessDetails(StandardOauth2AccessTokenProvider.java:289)
> at
> org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:243)
> at jdk.internal.reflect.GeneratedMethodAccessor966.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:105)
> at com.sun.proxy.$Proxy216.getAccessDetails(Unknown Source)
> at
> org.apache.nifi.processors.standard.InvokeHTTP.initOauth2AccessTokenProvider(InvokeHTTP.java:875)
> at jdk.internal.reflect.GeneratedMethodAccessor965.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
> at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
> at
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$8(StandardProcessorNode.java:1733)
> at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: okhttp3.internal.http2.StreamResetException: stream was reset:
> HTTP_1_1_REQUIRED
> at okhttp3.internal.http2.Http2Stream.takeHeaders(Http2Stream.kt:148)
> at
> okhttp3.internal.http2.Http2ExchangeCodec.readResponseHeaders(Http2ExchangeCodec.kt:96)
> at
> okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.kt:106)
> at
> okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:79)
> at
> okhttp3.internal.http.RealInterceptorChain.proceed(Real
[jira] [Created] (NIFI-10842) StandardOauth2AccessTokenProvider support forcing HTTP protocol to 1.1
Curtis W Ruck created NIFI-10842:
Summary: StandardOauth2AccessTokenProvider support forcing HTTP
protocol to 1.1
Key: NIFI-10842
URL: https://issues.apache.org/jira/browse/NIFI-10842
Project: Apache NiFi
Issue Type: Bug
Components: Extensions
Affects Versions: 1.18.0
Reporter: Curtis W Ruck
We are trying to use nifi's StandardOauth2AccessTokenProvider to enable
authentication in concert with InvokeHTTP to make requests to a REST API. The
OAuth2 server is responding with a HTTP 408 error code, and okhttp3 is throwing
a "stream was reset: HTTP_1_1_REQUIRED" exception.
In the same manner that InvokeHTTP got the `HTTP/2 Disabled` property, it would
be nice if StandardOauth2AccessTokenProvider had the same property.
{code:java}
2022-11-18 20:44:17,842 ERROR [Timer-Driven Process Thread-9]
o.a.nifi.processors.standard.InvokeHTTP
InvokeHTTP[id=8c6c303d-0184-1000-2cd2-c88625f9a563] Failed to properly
initialize Processor. If still scheduled to run, NiFi will attempt to
initialize and run the Processor again after the 'Administrative Yield
Duration' has elapsed. Failure is due to java.io.UncheckedIOException: OAuth2
access token request failed
java.io.UncheckedIOException: OAuth2 access token request failed
at
org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:330)
at
org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.acquireAccessDetails(StandardOauth2AccessTokenProvider.java:289)
at
org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider.getAccessDetails(StandardOauth2AccessTokenProvider.java:243)
at jdk.internal.reflect.GeneratedMethodAccessor966.invoke(Unknown Source)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
at
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:105)
at com.sun.proxy.$Proxy216.getAccessDetails(Unknown Source)
at
org.apache.nifi.processors.standard.InvokeHTTP.initOauth2AccessTokenProvider(InvokeHTTP.java:875)
at jdk.internal.reflect.GeneratedMethodAccessor965.invoke(Unknown Source)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
at
org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$8(StandardProcessorNode.java:1733)
at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: okhttp3.internal.http2.StreamResetException: stream was reset:
HTTP_1_1_REQUIRED
at okhttp3.internal.http2.Http2Stream.takeHeaders(Http2Stream.kt:148)
at
okhttp3.internal.http2.Http2ExchangeCodec.readResponseHeaders(Http2ExchangeCodec.kt:96)
at okhttp3.internal.connection.Exchange.readResponseHeaders(Exchange.kt:106)
at
okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:79)
at
okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at
okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:34)
at
okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:95)
at
okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at
okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83)
at
okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at
okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76)
at
okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at
[jira] [Commented] (NIFI-10660) AvroReader issue after upgrading to Nifi 1.18.0
[
https://issues.apache.org/jira/browse/NIFI-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636031#comment-17636031
]
Joe Witt commented on NIFI-10660:
-
Ok so it broke in https://issues.apache.org/jira/browse/NIFI-7234 which was
NIFI 1.17 then apparently. And the comments in the thread Matt shared clearly
show they knew they'd break behavior. Unfortunate
> AvroReader issue after upgrading to Nifi 1.18.0
> ---
>
> Key: NIFI-10660
> URL: https://issues.apache.org/jira/browse/NIFI-10660
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Sandro Berger
>Priority: Critical
> Fix For: 1.19.0
>
>
> After upgrading from 1.15.3 to 1.18.0 we saw some issue regarding AvroReader
> when the following conditions are met:
> # The AVRO schema in the flowFile uses the "aliases" attribute
> # There is a record in the flowFile where a field with set alias has a value
> of "null"
> The use of aliases and null values used to work for us before upgrading Nifi
> without issues
> Example schema:
> {code:java}
> {
> "type": "record",
> "name": "test",
> "fields": [
> { "name" : "id", "type" : "int", "aliases" : ["F1"] },
> { "name" : "field1", "type" : [ "string", "null" ], "aliases" : ["F2"]
> },
> { "name" : "field2", "type" : [ "string", "null" ], "aliases" : ["F3"] }
> ]
> }
> {code}
> Example data:
> {code:java}
> [ {
> "id" : 1,
> "field1" : "field1content",
> "field2" : "field2content"
> }, {
> "id" : 2,
> "field1" : null,
> "field2" : "field2content"
> } ]{code}
> Note: If we remove the "aliases" from the schema or make sure that there is
> never a field with a value of null, we don't have any errors in Nifi 1.18.0.
>
> ERROR log:
> {code:java}
> 2022-10-14 16:30:50,617 ERROR [Timer-Driven Process Thread-6]
> o.a.n.processors.standard.ConvertRecord
> ConvertRecord[id=c7ee1f0f-10ac-116e-9e4c-300530853ab8] Failed to process
> StandardFlow
> FileRecord[uuid=1d201fdb-e507-4d51-87c2-fbc895a450f3,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1665753427357-4670,
> container=default, section=574], offset=18384,
> length=324],offset=0,name=1d201fdb-e507-4d51-87c2-fbc895a450f3,size=324];
> will route to failure
> org.apache.nifi.processor.exception.ProcessException: Could not parse
> incoming data
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor$1.process(AbstractRecordProcessor.java:171)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:3434)
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor.onTrigger(AbstractRecordProcessor.java:122)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: org.apache.nifi.serialization.MalformedRecordException: Error
> while getting next record
> at
> org.apache.nifi.avro.AvroRecordReader.nextRecord(AvroRecordReader.java:50)
> at
> org.apache.nifi.serialization.RecordReader.nextRecord(RecordReader.java:50)
> at jdk.internal.reflect.GeneratedMethodAccessor150.invoke(Unknown
> Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.access$100(StandardControllerServiceInvocationHandler.java:38)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$Prox
[jira] [Commented] (NIFI-10660) AvroReader issue after upgrading to Nifi 1.18.0
[
https://issues.apache.org/jira/browse/NIFI-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636030#comment-17636030
]
Matt Burgess commented on NIFI-10660:
-
>From Mark's analysis I found the issue was introduced via
>https://issues.apache.org/jira/browse/AVRO-2278 in Avro 1.10.0
> AvroReader issue after upgrading to Nifi 1.18.0
> ---
>
> Key: NIFI-10660
> URL: https://issues.apache.org/jira/browse/NIFI-10660
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Sandro Berger
>Priority: Critical
> Fix For: 1.19.0
>
>
> After upgrading from 1.15.3 to 1.18.0 we saw some issue regarding AvroReader
> when the following conditions are met:
> # The AVRO schema in the flowFile uses the "aliases" attribute
> # There is a record in the flowFile where a field with set alias has a value
> of "null"
> The use of aliases and null values used to work for us before upgrading Nifi
> without issues
> Example schema:
> {code:java}
> {
> "type": "record",
> "name": "test",
> "fields": [
> { "name" : "id", "type" : "int", "aliases" : ["F1"] },
> { "name" : "field1", "type" : [ "string", "null" ], "aliases" : ["F2"]
> },
> { "name" : "field2", "type" : [ "string", "null" ], "aliases" : ["F3"] }
> ]
> }
> {code}
> Example data:
> {code:java}
> [ {
> "id" : 1,
> "field1" : "field1content",
> "field2" : "field2content"
> }, {
> "id" : 2,
> "field1" : null,
> "field2" : "field2content"
> } ]{code}
> Note: If we remove the "aliases" from the schema or make sure that there is
> never a field with a value of null, we don't have any errors in Nifi 1.18.0.
>
> ERROR log:
> {code:java}
> 2022-10-14 16:30:50,617 ERROR [Timer-Driven Process Thread-6]
> o.a.n.processors.standard.ConvertRecord
> ConvertRecord[id=c7ee1f0f-10ac-116e-9e4c-300530853ab8] Failed to process
> StandardFlow
> FileRecord[uuid=1d201fdb-e507-4d51-87c2-fbc895a450f3,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1665753427357-4670,
> container=default, section=574], offset=18384,
> length=324],offset=0,name=1d201fdb-e507-4d51-87c2-fbc895a450f3,size=324];
> will route to failure
> org.apache.nifi.processor.exception.ProcessException: Could not parse
> incoming data
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor$1.process(AbstractRecordProcessor.java:171)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:3434)
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor.onTrigger(AbstractRecordProcessor.java:122)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: org.apache.nifi.serialization.MalformedRecordException: Error
> while getting next record
> at
> org.apache.nifi.avro.AvroRecordReader.nextRecord(AvroRecordReader.java:50)
> at
> org.apache.nifi.serialization.RecordReader.nextRecord(RecordReader.java:50)
> at jdk.internal.reflect.GeneratedMethodAccessor150.invoke(Unknown
> Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.access$100(StandardControllerServiceInvocationHandler.java:38)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationH
[jira] [Updated] (NIFI-10608) Copied Processor Group no longer contains non-referenced Controller Services
[ https://issues.apache.org/jira/browse/NIFI-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nissim Shiman updated NIFI-10608: - Status: Patch Available (was: In Progress) > Copied Processor Group no longer contains non-referenced Controller Services > > > Key: NIFI-10608 > URL: https://issues.apache.org/jira/browse/NIFI-10608 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.18.0, 1.16.3 >Reporter: Nissim Shiman >Assignee: Nissim Shiman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > A copied processor group does not contain controller service that original > processor group had if controller service had not been referenced to a > processor. > To reproduce: > create new PG -> right click -> Configure -> Controller Sevices -> Add any > controller service (AvroReader for example) > copy PG > new PG -> right click -> Configure -> Controller Services -> (new controller > service will not be listed/ i.e. AvroReader does not show up here) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-4890) OIDC Token Refresh is not done correctly
[ https://issues.apache.org/jira/browse/NIFI-4890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636022#comment-17636022 ] Curtis W Ruck commented on NIFI-4890: - Definitely need refresh token. Typically applications use the refresh token to get new access tokens as needed. Our security requirements let us keep a session open if its not idle, and we use the refresh token to get new access tokens as necessary while the user is not idle. > OIDC Token Refresh is not done correctly > > > Key: NIFI-4890 > URL: https://issues.apache.org/jira/browse/NIFI-4890 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Environment: > Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) > >Reporter: Federico Michele Facca >Assignee: David Handermann >Priority: Major > Attachments: image-2022-10-20-12-23-38-675.png > > > It looks like the NIFI UI is not refreshing the OIDC token in background, and > because of that, when the token expires, tells you that your session is > expired. and you need to refresh the page, to get a new token. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] NissimShiman opened a new pull request, #6685: NIFI-10608 Copying Process Group now includes non-processor referenced controller services
NissimShiman opened a new pull request, #6685: URL: https://github.com/apache/nifi/pull/6685 # Summary [NIFI-10608](https://issues.apache.org/jira/browse/NIFI-10608) Copying a processor group used to miss controller services if controller service had not been referenced to a processor. This resolves that. To show fix: create new PG -> right click -> Configure -> Controller Sevices -> Add any controller service (AvroReader for example) copy PG copied PG -> right click -> Configure -> Controller Services -> (new controller service is now listed/ i.e. AvroReader will be listed) Prior to this the new controller service/Avro Reader would not be listed for the copied PG. This same issue was also present when making templates (i.e. the template would miss controller service that had not been referenced to a processor). This is now resolved for templates as well. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a diff in pull request #6540: NIFI-10656 Log ignored event with info instead of warning
turcsanyip commented on code in PR #6540:
URL: https://github.com/apache/nifi/pull/6540#discussion_r1026823892
##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureDataLakeStorage.java:
##
@@ -220,18 +213,25 @@ static void uploadContent(DataLakeFileClient fileClient,
InputStream in, long le
}
//Visible for testing
-DataLakeFileClient renameFile(final String fileName, final String
directoryPath, final DataLakeFileClient fileClient, final boolean overwrite) {
+String renameFile(final DataLakeFileClient sourceFileClient, final String
destinationDirectory, final String destinationFileName, final String
conflictResolution) {
try {
final DataLakeRequestConditions destinationCondition = new
DataLakeRequestConditions();
-if (!overwrite) {
+if (!conflictResolution.equals(REPLACE_RESOLUTION)) {
destinationCondition.setIfNoneMatch("*");
}
-final String destinationPath = createPath(directoryPath, fileName);
-return fileClient.renameWithResponse(null, destinationPath, null,
destinationCondition, null, null).getValue();
+final String destinationPath = createPath(destinationDirectory,
destinationFileName);
+return sourceFileClient.renameWithResponse(null, destinationPath,
null, destinationCondition, null, null).getValue().getFileUrl();
} catch (DataLakeStorageException dataLakeStorageException) {
-getLogger().error("Renaming File [{}] failed",
fileClient.getFileName(), dataLakeStorageException);
-removeTempFile(fileClient);
-throw dataLakeStorageException;
+removeTempFile(sourceFileClient);
+if (dataLakeStorageException.getStatusCode() == 409 &&
conflictResolution.equals(IGNORE_RESOLUTION)) {
+getLogger().info("File with the same name [{}] already exists.
Remote file not modified due to {} being set to '{}'.",
+sourceFileClient.getFileName(),
CONFLICT_RESOLUTION.getDisplayName(), conflictResolution);
+return null;
+} else {
+// FAIL_RESOLUTION
+getLogger().error("Renaming File [{}] failed",
sourceFileClient.getFileName(), dataLakeStorageException);
Review Comment:
The error is logged (and therefore appears on the bulletin) twice. It would
be enough to log the error in "main" catch block in `onTrigger()`.
##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/processors/azure/storage/ITPutAzureDataLakeStorage.java:
##
@@ -284,17 +285,18 @@ public void testPutFileButFailedToRename() {
final String componentId = "componentId";
final DataLakeFileClient fileClient = mock(DataLakeFileClient.class);
final Response response = mock(Response.class);
+final DataLakeStorageException exception =
mock(DataLakeStorageException.class);
//Mock logger
when(initContext.getIdentifier()).thenReturn(componentId);
MockComponentLog componentLog = new MockComponentLog(componentId,
processor);
when(initContext.getLogger()).thenReturn(componentLog);
processor.initialize(initContext);
//Mock renameWithResponse Azure method
when(fileClient.renameWithResponse(isNull(), anyString(), isNull(),
any(DataLakeRequestConditions.class), isNull(), isNull())).thenReturn(response);
-when(response.getValue()).thenThrow(DataLakeStorageException.class);
when(fileClient.getFileName()).thenReturn(FILE_NAME);
-
-assertThrows(DataLakeStorageException.class, () ->
processor.renameFile(FILE_NAME, "", fileClient, false));
+when(exception.getStatusCode()).thenReturn(405);
+when(response.getValue()).thenThrow(exception);
+assertThrows(DataLakeStorageException.class, () ->
processor.renameFile(fileClient, "", FILE_NAME, FAIL_RESOLUTION));
Review Comment:
If I understand correctly, here we test the "other" error case (non 409 /
non-conflicting). Generic errors should be handled the same way in all conflict
resolution strategies so the test should be extended with those too:
```suggestion
when(exception.getStatusCode()).thenReturn(405);
when(response.getValue()).thenThrow(exception);
assertThrows(DataLakeStorageException.class, () ->
processor.renameFile(fileClient, "", FILE_NAME, FAIL_RESOLUTION));
assertThrows(DataLakeStorageException.class, () ->
processor.renameFile(fileClient, "", FILE_NAME, REPLACE_RESOLUTION));
assertThrows(DataLakeStorageException.class, () ->
processor.renameFile(fileClient, "", FILE_NAME, IGNORE_RESOLUTION));
verify(fileClient, times(3)).delete();
```
This and the previous one are unit tests. Not clear why they were added in
the IT test class orig
[jira] [Commented] (NIFI-10660) AvroReader issue after upgrading to Nifi 1.18.0
[
https://issues.apache.org/jira/browse/NIFI-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636018#comment-17636018
]
Mark Payne commented on NIFI-10660:
---
Agreed [~joewitt] . Looks like Avro made some changes. Previously, we did
something like:
{code:java}
Object value = record.get(field.getFieldName());
if (value == null) {
for (String alias : field.getAliases()) {
value = record.get(alias);
if (value != null) {
break;
}
}
} {code}
This would give us the value from the Record, regardless of whether it came
from the field 'name' or an alias.
But now, if we call {{Record.get(alias)}} and the schema doesn't have that
alias, instead of returning {{null}} it throws an Exception.
I think we can work around this by first checking something like:
{code:java}
Field field = record.getSchema().getField(alias);
if (field != null) {
return record.get(alias);
}{code}
Will need to do some more testing though to confirm that this works as I think
it will.
> AvroReader issue after upgrading to Nifi 1.18.0
> ---
>
> Key: NIFI-10660
> URL: https://issues.apache.org/jira/browse/NIFI-10660
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Sandro Berger
>Priority: Critical
> Fix For: 1.19.0
>
>
> After upgrading from 1.15.3 to 1.18.0 we saw some issue regarding AvroReader
> when the following conditions are met:
> # The AVRO schema in the flowFile uses the "aliases" attribute
> # There is a record in the flowFile where a field with set alias has a value
> of "null"
> The use of aliases and null values used to work for us before upgrading Nifi
> without issues
> Example schema:
> {code:java}
> {
> "type": "record",
> "name": "test",
> "fields": [
> { "name" : "id", "type" : "int", "aliases" : ["F1"] },
> { "name" : "field1", "type" : [ "string", "null" ], "aliases" : ["F2"]
> },
> { "name" : "field2", "type" : [ "string", "null" ], "aliases" : ["F3"] }
> ]
> }
> {code}
> Example data:
> {code:java}
> [ {
> "id" : 1,
> "field1" : "field1content",
> "field2" : "field2content"
> }, {
> "id" : 2,
> "field1" : null,
> "field2" : "field2content"
> } ]{code}
> Note: If we remove the "aliases" from the schema or make sure that there is
> never a field with a value of null, we don't have any errors in Nifi 1.18.0.
>
> ERROR log:
> {code:java}
> 2022-10-14 16:30:50,617 ERROR [Timer-Driven Process Thread-6]
> o.a.n.processors.standard.ConvertRecord
> ConvertRecord[id=c7ee1f0f-10ac-116e-9e4c-300530853ab8] Failed to process
> StandardFlow
> FileRecord[uuid=1d201fdb-e507-4d51-87c2-fbc895a450f3,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1665753427357-4670,
> container=default, section=574], offset=18384,
> length=324],offset=0,name=1d201fdb-e507-4d51-87c2-fbc895a450f3,size=324];
> will route to failure
> org.apache.nifi.processor.exception.ProcessException: Could not parse
> incoming data
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor$1.process(AbstractRecordProcessor.java:171)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:3434)
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor.onTrigger(AbstractRecordProcessor.java:122)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: org.apache.nifi.serialization.MalformedRecordException: Error
> while getting next record
> at
> org.apache.nifi.avro.AvroRecordReader.nextRecord(AvroRecordReader.java:50)
> at
> org.apache.nifi.serialization.RecordReader.nextRecord(RecordReader.java:50)
> at jdk.internal.reflect.Genera
[jira] [Updated] (NIFI-10660) AvroReader issue after upgrading to Nifi 1.18.0
[
https://issues.apache.org/jira/browse/NIFI-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-10660:
Priority: Critical (was: Major)
> AvroReader issue after upgrading to Nifi 1.18.0
> ---
>
> Key: NIFI-10660
> URL: https://issues.apache.org/jira/browse/NIFI-10660
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Sandro Berger
>Priority: Critical
> Fix For: 1.19.0
>
>
> After upgrading from 1.15.3 to 1.18.0 we saw some issue regarding AvroReader
> when the following conditions are met:
> # The AVRO schema in the flowFile uses the "aliases" attribute
> # There is a record in the flowFile where a field with set alias has a value
> of "null"
> The use of aliases and null values used to work for us before upgrading Nifi
> without issues
> Example schema:
> {code:java}
> {
> "type": "record",
> "name": "test",
> "fields": [
> { "name" : "id", "type" : "int", "aliases" : ["F1"] },
> { "name" : "field1", "type" : [ "string", "null" ], "aliases" : ["F2"]
> },
> { "name" : "field2", "type" : [ "string", "null" ], "aliases" : ["F3"] }
> ]
> }
> {code}
> Example data:
> {code:java}
> [ {
> "id" : 1,
> "field1" : "field1content",
> "field2" : "field2content"
> }, {
> "id" : 2,
> "field1" : null,
> "field2" : "field2content"
> } ]{code}
> Note: If we remove the "aliases" from the schema or make sure that there is
> never a field with a value of null, we don't have any errors in Nifi 1.18.0.
>
> ERROR log:
> {code:java}
> 2022-10-14 16:30:50,617 ERROR [Timer-Driven Process Thread-6]
> o.a.n.processors.standard.ConvertRecord
> ConvertRecord[id=c7ee1f0f-10ac-116e-9e4c-300530853ab8] Failed to process
> StandardFlow
> FileRecord[uuid=1d201fdb-e507-4d51-87c2-fbc895a450f3,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1665753427357-4670,
> container=default, section=574], offset=18384,
> length=324],offset=0,name=1d201fdb-e507-4d51-87c2-fbc895a450f3,size=324];
> will route to failure
> org.apache.nifi.processor.exception.ProcessException: Could not parse
> incoming data
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor$1.process(AbstractRecordProcessor.java:171)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:3434)
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor.onTrigger(AbstractRecordProcessor.java:122)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: org.apache.nifi.serialization.MalformedRecordException: Error
> while getting next record
> at
> org.apache.nifi.avro.AvroRecordReader.nextRecord(AvroRecordReader.java:50)
> at
> org.apache.nifi.serialization.RecordReader.nextRecord(RecordReader.java:50)
> at jdk.internal.reflect.GeneratedMethodAccessor150.invoke(Unknown
> Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.access$100(StandardControllerServiceInvocationHandler.java:38)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
> at com.sun.proxy.$Proxy277.nextRecord(Unknown Source)
> at
> org.apache.nifi.processors.standard.AbstractRecordProces
[jira] [Commented] (NIFI-10660) AvroReader issue after upgrading to Nifi 1.18.0
[
https://issues.apache.org/jira/browse/NIFI-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636013#comment-17636013
]
Joe Witt commented on NIFI-10660:
-
Gonna hold up 1.19 for progress on this. Appears legit and related to change
in Avro behavior
> AvroReader issue after upgrading to Nifi 1.18.0
> ---
>
> Key: NIFI-10660
> URL: https://issues.apache.org/jira/browse/NIFI-10660
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Sandro Berger
>Priority: Critical
> Fix For: 1.19.0
>
>
> After upgrading from 1.15.3 to 1.18.0 we saw some issue regarding AvroReader
> when the following conditions are met:
> # The AVRO schema in the flowFile uses the "aliases" attribute
> # There is a record in the flowFile where a field with set alias has a value
> of "null"
> The use of aliases and null values used to work for us before upgrading Nifi
> without issues
> Example schema:
> {code:java}
> {
> "type": "record",
> "name": "test",
> "fields": [
> { "name" : "id", "type" : "int", "aliases" : ["F1"] },
> { "name" : "field1", "type" : [ "string", "null" ], "aliases" : ["F2"]
> },
> { "name" : "field2", "type" : [ "string", "null" ], "aliases" : ["F3"] }
> ]
> }
> {code}
> Example data:
> {code:java}
> [ {
> "id" : 1,
> "field1" : "field1content",
> "field2" : "field2content"
> }, {
> "id" : 2,
> "field1" : null,
> "field2" : "field2content"
> } ]{code}
> Note: If we remove the "aliases" from the schema or make sure that there is
> never a field with a value of null, we don't have any errors in Nifi 1.18.0.
>
> ERROR log:
> {code:java}
> 2022-10-14 16:30:50,617 ERROR [Timer-Driven Process Thread-6]
> o.a.n.processors.standard.ConvertRecord
> ConvertRecord[id=c7ee1f0f-10ac-116e-9e4c-300530853ab8] Failed to process
> StandardFlow
> FileRecord[uuid=1d201fdb-e507-4d51-87c2-fbc895a450f3,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1665753427357-4670,
> container=default, section=574], offset=18384,
> length=324],offset=0,name=1d201fdb-e507-4d51-87c2-fbc895a450f3,size=324];
> will route to failure
> org.apache.nifi.processor.exception.ProcessException: Could not parse
> incoming data
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor$1.process(AbstractRecordProcessor.java:171)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:3434)
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor.onTrigger(AbstractRecordProcessor.java:122)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: org.apache.nifi.serialization.MalformedRecordException: Error
> while getting next record
> at
> org.apache.nifi.avro.AvroRecordReader.nextRecord(AvroRecordReader.java:50)
> at
> org.apache.nifi.serialization.RecordReader.nextRecord(RecordReader.java:50)
> at jdk.internal.reflect.GeneratedMethodAccessor150.invoke(Unknown
> Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.access$100(StandardControllerServiceInvocationHandler.java:38)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
> at com.su
[jira] [Updated] (NIFI-10660) AvroReader issue after upgrading to Nifi 1.18.0
[
https://issues.apache.org/jira/browse/NIFI-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-10660:
Fix Version/s: 1.19.0
> AvroReader issue after upgrading to Nifi 1.18.0
> ---
>
> Key: NIFI-10660
> URL: https://issues.apache.org/jira/browse/NIFI-10660
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Sandro Berger
>Priority: Major
> Fix For: 1.19.0
>
>
> After upgrading from 1.15.3 to 1.18.0 we saw some issue regarding AvroReader
> when the following conditions are met:
> # The AVRO schema in the flowFile uses the "aliases" attribute
> # There is a record in the flowFile where a field with set alias has a value
> of "null"
> The use of aliases and null values used to work for us before upgrading Nifi
> without issues
> Example schema:
> {code:java}
> {
> "type": "record",
> "name": "test",
> "fields": [
> { "name" : "id", "type" : "int", "aliases" : ["F1"] },
> { "name" : "field1", "type" : [ "string", "null" ], "aliases" : ["F2"]
> },
> { "name" : "field2", "type" : [ "string", "null" ], "aliases" : ["F3"] }
> ]
> }
> {code}
> Example data:
> {code:java}
> [ {
> "id" : 1,
> "field1" : "field1content",
> "field2" : "field2content"
> }, {
> "id" : 2,
> "field1" : null,
> "field2" : "field2content"
> } ]{code}
> Note: If we remove the "aliases" from the schema or make sure that there is
> never a field with a value of null, we don't have any errors in Nifi 1.18.0.
>
> ERROR log:
> {code:java}
> 2022-10-14 16:30:50,617 ERROR [Timer-Driven Process Thread-6]
> o.a.n.processors.standard.ConvertRecord
> ConvertRecord[id=c7ee1f0f-10ac-116e-9e4c-300530853ab8] Failed to process
> StandardFlow
> FileRecord[uuid=1d201fdb-e507-4d51-87c2-fbc895a450f3,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1665753427357-4670,
> container=default, section=574], offset=18384,
> length=324],offset=0,name=1d201fdb-e507-4d51-87c2-fbc895a450f3,size=324];
> will route to failure
> org.apache.nifi.processor.exception.ProcessException: Could not parse
> incoming data
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor$1.process(AbstractRecordProcessor.java:171)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:3434)
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor.onTrigger(AbstractRecordProcessor.java:122)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: org.apache.nifi.serialization.MalformedRecordException: Error
> while getting next record
> at
> org.apache.nifi.avro.AvroRecordReader.nextRecord(AvroRecordReader.java:50)
> at
> org.apache.nifi.serialization.RecordReader.nextRecord(RecordReader.java:50)
> at jdk.internal.reflect.GeneratedMethodAccessor150.invoke(Unknown
> Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.access$100(StandardControllerServiceInvocationHandler.java:38)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
> at com.sun.proxy.$Proxy277.nextRecord(Unknown Source)
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor$1.process(
[jira] [Assigned] (NIFI-10756) StandardSSLContextService will fail silently on nifi restart if keystore no longer exists
[ https://issues.apache.org/jira/browse/NIFI-10756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nissim Shiman reassigned NIFI-10756: Assignee: Nissim Shiman > StandardSSLContextService will fail silently on nifi restart if keystore no > longer exists > - > > Key: NIFI-10756 > URL: https://issues.apache.org/jira/browse/NIFI-10756 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.17.0 >Reporter: Nissim Shiman >Assignee: Nissim Shiman >Priority: Major > > When StandardSSLContextService is successfully enabled, it will fail silently > on nifi restart if the keystore filename no longer exists. > There are no logs in nifi-app.log at WARN/ERROR that indicate any issues. > There is an alert in the nifi gui when looking at the controller service that > indicates that the needed file is missing. > Also, when debug is set via logback.xml, the issue can be seen as nifi will > continue to try to start it [1] > [1] > https://github.com/apache/nifi/blob/rel/nifi-1.17.0/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceNode.java#L586-L587 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10841) Enable dockermaven builds for arm64 architectures
[ https://issues.apache.org/jira/browse/NIFI-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-10841: - Description: The dockermaven builds (e.g. nifi, nifi-toolkit, nifi-registry, minifi, minifi-c2) currently do not work on arm64 architecture machines. This is due to a known limitation of the Spotify docker build plugin used in the maven profiles. An alternative (e.g. fabric8) should allow builds on both amd64 and arm64 architectures (and possibly others). NIFI-9177 allowed the docker image (e.g. produced using the dockerhub modules) to run on arm64 machines, so that's not a problem to fix, just the actual dockermaven module builds (and tests). was: The dockermaven builds (e.g. nifi, nifi-toolkit, nifi-registry, minifi, minifi-c2) currently do not work on arm64 architecture machines. This is due to a known limitation of the Spotify docker build plugin used in the maven profiles. An alternative (e.g. fabric8) should allow builds on both amd64 and arm64 architectures (and possibly others). > Enable dockermaven builds for arm64 architectures > - > > Key: NIFI-10841 > URL: https://issues.apache.org/jira/browse/NIFI-10841 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Chris Sampson >Priority: Major > > The dockermaven builds (e.g. nifi, nifi-toolkit, nifi-registry, minifi, > minifi-c2) currently do not work on arm64 architecture machines. > This is due to a known limitation of the Spotify docker build plugin used in > the maven profiles. > An alternative (e.g. fabric8) should allow builds on both amd64 and arm64 > architectures (and possibly others). > NIFI-9177 allowed the docker image (e.g. produced using the dockerhub > modules) to run on arm64 machines, so that's not a problem to fix, just the > actual dockermaven module builds (and tests). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-10841) Enable dockermaven builds for arm64 architectures
Chris Sampson created NIFI-10841: Summary: Enable dockermaven builds for arm64 architectures Key: NIFI-10841 URL: https://issues.apache.org/jira/browse/NIFI-10841 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.18.0 Reporter: Chris Sampson The dockermaven builds (e.g. nifi, nifi-toolkit, nifi-registry, minifi, minifi-c2) currently do not work on arm64 architecture machines. This is due to a known limitation of the Spotify docker build plugin used in the maven profiles. An alternative (e.g. fabric8) should allow builds on both amd64 and arm64 architectures (and possibly others). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-9177) Provide ARM64 docker Images for Apache Nifi
[
https://issues.apache.org/jira/browse/NIFI-9177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Sampson resolved NIFI-9177.
-
Fix Version/s: 1.19.0
Resolution: Fixed
> Provide ARM64 docker Images for Apache Nifi
> ---
>
> Key: NIFI-9177
> URL: https://issues.apache.org/jira/browse/NIFI-9177
> Project: Apache NiFi
> Issue Type: Wish
> Components: Docker
>Affects Versions: 1.14.0
>Reporter: Vaibhav Pal Singh
>Priority: Major
> Labels: arm64, docker
> Fix For: 1.19.0
>
>
> Docker for mac is not able to correctly emulate the amd64 binaries for apache
> nifi.
> Request to provide arm64 images for apache nifi, now that the apple M1
> hardware is becoming very popular among developer community as well.
> The error logs as follows :
> {code:java}
> 2021-08-29 04:36:48,799 WARN [main] org.apache.nifi.web.server.JettyServer
> Failed to start web server... shutting down.2021-08-29 04:36:48,799 WARN
> [main] org.apache.nifi.web.server.JettyServer Failed to start web server...
> shutting down.java.io.IOException: Function not implemented at
> sun.nio.fs.LinuxWatchService.(LinuxWatchService.java:64) at
> sun.nio.fs.LinuxFileSystem.newWatchService(LinuxFileSystem.java:47) at
> org.apache.nifi.nar.NarAutoLoader.start(NarAutoLoader.java:68) at
> org.apache.nifi.web.server.JettyServer.start(JettyServer.java:1229) at
> org.apache.nifi.NiFi.(NiFi.java:159) at
> org.apache.nifi.NiFi.(NiFi.java:71) at
> org.apache.nifi.NiFi.main(NiFi.java:303)2021-08-29 04:36:48,830 INFO
> [Thread-1] org.apache.nifi.NiFi Initiating shutdown of Jetty web server...
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-10714) DistributeLoad is invalid when changing Number of Relationships property
[ https://issues.apache.org/jira/browse/NIFI-10714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bean resolved NIFI-10714. -- Resolution: Cannot Reproduce As of version 1.17.0, this cannot be reproduced > DistributeLoad is invalid when changing Number of Relationships property > > > Key: NIFI-10714 > URL: https://issues.apache.org/jira/browse/NIFI-10714 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.16.3 >Reporter: Mark Bean >Priority: Major > > When the "Number of Relationship" property is changed on DistributeLoad and > an appropriate number of dynamic properties are added/removed to match Number > of Relationships, the processor goes to an invalid state. > For example, processor has 2 relationships initially and is in a valid state. > Change Number of Relationships to 3 and add a dynamic property '3' with value > '5'. Errors include: > 'Property Name' validated against '3' is invalid because Property Name must > be a positive integer between 1 and the number of relationships (inclusive) > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-10228) FlowParser is using incorrect identifier for process group
[ https://issues.apache.org/jira/browse/NIFI-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Bean reassigned NIFI-10228: Assignee: Mark Bean > FlowParser is using incorrect identifier for process group > -- > > Key: NIFI-10228 > URL: https://issues.apache.org/jira/browse/NIFI-10228 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.16.3 >Reporter: Mark Bean >Assignee: Mark Bean >Priority: Major > Fix For: 1.19.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > When starting NiFi for the first time using the managed-authorizer, NiFi will > put the Initial Admin Identity in certain Access Policies. However, it only > does this for Global Access Policies, and does not add this user to any > Component Access Policies, e.g. 'view/modify the component'. > > This has been frustrating, but as I understand it is unavoidable because the > UUID of the root process group has not yet been created (there is no > flow.xml.gz) at the time the policies are generated. > > However, I found that if a flow.xml.gz existed without a corresponding > authorizations.xml or users.xml, then the startup process would in fact > create the Component Access Policies and add the admin user to them. > > Now, with the introduction of flow.json.gz, the root process group has both > "identifier" and "instanceIdentifier" properties. The Component Access > Policies created on startup as described above reference the "identifier" > UUID, but the UI indicates the "instanceIdentifier" is the proper UUID for > the root process group. Therefore, the Component Access Policies are > ineffective as they reference an incorrect UUID value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10839) Change HubSpot and Shopify flowfile mimtype to JSON
[ https://issues.apache.org/jira/browse/NIFI-10839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635955#comment-17635955 ] David Handermann commented on NIFI-10839: - Closed in https://github.com/apache/nifi/commit/81b36e69aea0e23e5c839f103f0bc1d4099f6fb1 > Change HubSpot and Shopify flowfile mimtype to JSON > --- > > Key: NIFI-10839 > URL: https://issues.apache.org/jira/browse/NIFI-10839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Minor > Fix For: 1.19.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-10839) Change HubSpot and Shopify flowfile mimtype to JSON
[ https://issues.apache.org/jira/browse/NIFI-10839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-10839. - Fix Version/s: 1.19.0 Resolution: Fixed > Change HubSpot and Shopify flowfile mimtype to JSON > --- > > Key: NIFI-10839 > URL: https://issues.apache.org/jira/browse/NIFI-10839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Minor > Fix For: 1.19.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10389) Upgrade AWS Kinesis to 1.14.8
[ https://issues.apache.org/jira/browse/NIFI-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635952#comment-17635952 ] ASF subversion and git services commented on NIFI-10389: Commit 81b36e69aea0e23e5c839f103f0bc1d4099f6fb1 in nifi's branch refs/heads/main from Lehel Boér [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=81b36e69ae ] NIFI-10389 Added mime.type to GetShopify and GetHubSpot This closes #6682 Signed-off-by: David Handermann > Upgrade AWS Kinesis to 1.14.8 > - > > Key: NIFI-10389 > URL: https://issues.apache.org/jira/browse/NIFI-10389 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.17.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 1.18.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Upgrade AWS Kinesis to 1.14.8, from 1.14.7 to mitigate 2 CVEs: > [CVE-2021-22569|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22569] > [CVE-2021-44832|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-44832] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #6682: NIFI-10389: Add mimetype to GetShopify and GetHubSpot
exceptionfactory closed pull request #6682: NIFI-10389: Add mimetype to GetShopify and GetHubSpot URL: https://github.com/apache/nifi/pull/6682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] MikeThomsen opened a new pull request, #6684: NIFI-10840 Added a build profile to enable Neo4J 5 support.
MikeThomsen opened a new pull request, #6684: URL: https://github.com/apache/nifi/pull/6684 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-10840) Add support for Neo4J 5.X to the cypher service
Mike Thomsen created NIFI-10840: --- Summary: Add support for Neo4J 5.X to the cypher service Key: NIFI-10840 URL: https://issues.apache.org/jira/browse/NIFI-10840 Project: Apache NiFi Issue Type: Improvement Reporter: Mike Thomsen Assignee: Mike Thomsen It will need to be optional as a build profile because Neo4J 5 (driver and docker image) has a hard dependency on Java 17. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10809) Update greenmail to 1.6.11 or later
[ https://issues.apache.org/jira/browse/NIFI-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-10809: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Update greenmail to 1.6.11 or later > --- > > Key: NIFI-10809 > URL: https://issues.apache.org/jira/browse/NIFI-10809 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Release notes: [https://github.com/greenmail-mail-test/greenmail/releases] > Updating to keep the dependencies current, if possible to update. Version May > change depending upon when this is done -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-10808) Update Guava to 31.1-jre
[ https://issues.apache.org/jira/browse/NIFI-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-10808. - Fix Version/s: 1.19.0 Resolution: Fixed > Update Guava to 31.1-jre > > > Key: NIFI-10808 > URL: https://issues.apache.org/jira/browse/NIFI-10808 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update Guava to At Least 31.1-jre. Changes can be at > foundhttps://github.com/google/guava/releases > version depends on when this ticket is handled -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10808) Update Guava to 31.1-jre
[ https://issues.apache.org/jira/browse/NIFI-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10808: Labels: dependency-upgrade (was: ) > Update Guava to 31.1-jre > > > Key: NIFI-10808 > URL: https://issues.apache.org/jira/browse/NIFI-10808 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update Guava to At Least 31.1-jre. Changes can be at > foundhttps://github.com/google/guava/releases > version depends on when this ticket is handled -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10808) Update Guava to 31.1-jre
[ https://issues.apache.org/jira/browse/NIFI-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635942#comment-17635942 ] ASF subversion and git services commented on NIFI-10808: Commit c63a668ac570ab7a698e6d3b2fa7085759866c87 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c63a668ac5 ] NIFI-10808 Upgraded Guava from 31.0.1 to 31.1 This closes #6683 Signed-off-by: David Handermann > Update Guava to 31.1-jre > > > Key: NIFI-10808 > URL: https://issues.apache.org/jira/browse/NIFI-10808 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update Guava to At Least 31.1-jre. Changes can be at > foundhttps://github.com/google/guava/releases > version depends on when this ticket is handled -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #6683: NIFI-10808 Update Guava to 31.1-jre
exceptionfactory closed pull request #6683: NIFI-10808 Update Guava to 31.1-jre URL: https://github.com/apache/nifi/pull/6683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-10660) AvroReader issue after upgrading to Nifi 1.18.0
[
https://issues.apache.org/jira/browse/NIFI-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635936#comment-17635936
]
Mark Ward commented on NIFI-10660:
--
Hi,
I have also faced this issue after updating from 1.15.3 to 1.18.0.
In my case incoming data was CSV, but this data was read correctly and
converted to Avro with an embedded schema. The problem arose when subsequent
processors read the Avro content using the embedded schema. Furthermore, the
alias had to contain a space.
See here for more info:
https://apachenifi.slack.com/archives/C0L9VCD47/p1668772654762409
Thanks
Mark
> AvroReader issue after upgrading to Nifi 1.18.0
> ---
>
> Key: NIFI-10660
> URL: https://issues.apache.org/jira/browse/NIFI-10660
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Sandro Berger
>Priority: Major
>
> After upgrading from 1.15.3 to 1.18.0 we saw some issue regarding AvroReader
> when the following conditions are met:
> # The AVRO schema in the flowFile uses the "aliases" attribute
> # There is a record in the flowFile where a field with set alias has a value
> of "null"
> The use of aliases and null values used to work for us before upgrading Nifi
> without issues
> Example schema:
> {code:java}
> {
> "type": "record",
> "name": "test",
> "fields": [
> { "name" : "id", "type" : "int", "aliases" : ["F1"] },
> { "name" : "field1", "type" : [ "string", "null" ], "aliases" : ["F2"]
> },
> { "name" : "field2", "type" : [ "string", "null" ], "aliases" : ["F3"] }
> ]
> }
> {code}
> Example data:
> {code:java}
> [ {
> "id" : 1,
> "field1" : "field1content",
> "field2" : "field2content"
> }, {
> "id" : 2,
> "field1" : null,
> "field2" : "field2content"
> } ]{code}
> Note: If we remove the "aliases" from the schema or make sure that there is
> never a field with a value of null, we don't have any errors in Nifi 1.18.0.
>
> ERROR log:
> {code:java}
> 2022-10-14 16:30:50,617 ERROR [Timer-Driven Process Thread-6]
> o.a.n.processors.standard.ConvertRecord
> ConvertRecord[id=c7ee1f0f-10ac-116e-9e4c-300530853ab8] Failed to process
> StandardFlow
> FileRecord[uuid=1d201fdb-e507-4d51-87c2-fbc895a450f3,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1665753427357-4670,
> container=default, section=574], offset=18384,
> length=324],offset=0,name=1d201fdb-e507-4d51-87c2-fbc895a450f3,size=324];
> will route to failure
> org.apache.nifi.processor.exception.ProcessException: Could not parse
> incoming data
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor$1.process(AbstractRecordProcessor.java:171)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:3434)
> at
> org.apache.nifi.processors.standard.AbstractRecordProcessor.onTrigger(AbstractRecordProcessor.java:122)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
> at
> org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: org.apache.nifi.serialization.MalformedRecordException: Error
> while getting next record
> at
> org.apache.nifi.avro.AvroRecordReader.nextRecord(AvroRecordReader.java:50)
> at
> org.apache.nifi.serialization.RecordReader.nextRecord(RecordReader.java:50)
> at jdk.internal.reflect.GeneratedMethodAccessor150.invoke(Unknown
> Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
> at
> org.apache.nifi.controller.service.Stan
[GitHub] [nifi] thenatog commented on pull request #6637: NIFI-10177: implemented ID token logout and revoke access token logou…
thenatog commented on PR #6637: URL: https://github.com/apache/nifi/pull/6637#issuecomment-1320218892 Reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10807) Update gson to 2.10
[ https://issues.apache.org/jira/browse/NIFI-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-10807: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Update gson to 2.10 > --- > > Key: NIFI-10807 > URL: https://issues.apache.org/jira/browse/NIFI-10807 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update gson from 2.9.1 to 2.10. Release notes > https://github.com/google/gson/blob/master/CHANGELOG.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10804) Update okhttp-digest to version 2.7
[ https://issues.apache.org/jira/browse/NIFI-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-10804: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Update okhttp-digest to version 2.7 > --- > > Key: NIFI-10804 > URL: https://issues.apache.org/jira/browse/NIFI-10804 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The version of okhttp-digest used in the NiFi lookup services is outdated and > should be updated to remediate > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250] > The current version used there is 2.5, with the most recent version being > 2.7. Release notes > https://github.com/rburgst/okhttp-digest/blob/2.7/release-notes.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10806) Update snmp4j-agent to 2.8.14
[ https://issues.apache.org/jira/browse/NIFI-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-10806: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Update snmp4j-agent to 2.8.14 > - > > Key: NIFI-10806 > URL: https://issues.apache.org/jira/browse/NIFI-10806 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update snmp4j-agent to 2.8.14 From 2.8.7. It is found in the SNMP Processors > section. Updating would remediate the following CVE > https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10810) Update HTTPAsyncClient to 4.1.5
[ https://issues.apache.org/jira/browse/NIFI-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-10810: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Update HTTPAsyncClient to 4.1.5 > --- > > Key: NIFI-10810 > URL: https://issues.apache.org/jira/browse/NIFI-10810 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update the version of httpasyncclient to 4.1.5 to mitigate CVE > [2020-13956|tel:2020-13956] > ([https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-13956)] > release notes: > https://downloads.apache.org/httpcomponents/httpasyncclient/RELEASE_NOTES-4.1.x.txt -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10370) Create PutSnowflake processor using Snowpipe ingest
[ https://issues.apache.org/jira/browse/NIFI-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635917#comment-17635917 ] ASF subversion and git services commented on NIFI-10370: Commit 89426d167b34f49bfce28abf38ccb990f8bb7393 in nifi's branch refs/heads/main from Robert Kalmar [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=89426d167b ] NIFI-10370 Create PutSnowflake processor using Snowpipe ingest This closes #6584. Signed-off-by: Peter Turcsanyi > Create PutSnowflake processor using Snowpipe ingest > --- > > Key: NIFI-10370 > URL: https://issues.apache.org/jira/browse/NIFI-10370 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Kalmár Róbert >Assignee: Kalmár Róbert >Priority: Major > Time Spent: 3h 50m > Remaining Estimate: 0h > > Create a record oriented processor dedicated to push data into Snowflake > using the Snowpipe approach instead of JDBC. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-10370) Create PutSnowflake processor using Snowpipe ingest
[ https://issues.apache.org/jira/browse/NIFI-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi resolved NIFI-10370. Fix Version/s: 1.19.0 Resolution: Fixed > Create PutSnowflake processor using Snowpipe ingest > --- > > Key: NIFI-10370 > URL: https://issues.apache.org/jira/browse/NIFI-10370 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Kalmár Róbert >Assignee: Kalmár Róbert >Priority: Major > Fix For: 1.19.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Create a record oriented processor dedicated to push data into Snowflake > using the Snowpipe approach instead of JDBC. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #6584: NIFI-10370 Create PutSnowflake processor using Snowpipe ingest
asfgit closed pull request #6584: NIFI-10370 Create PutSnowflake processor using Snowpipe ingest URL: https://github.com/apache/nifi/pull/6584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10370) Create PutSnowflake processor using Snowpipe ingest
[ https://issues.apache.org/jira/browse/NIFI-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalmár Róbert updated NIFI-10370: - Summary: Create PutSnowflake processor using Snowpipe ingest (was: Create record oriented PutSnowflake processor) > Create PutSnowflake processor using Snowpipe ingest > --- > > Key: NIFI-10370 > URL: https://issues.apache.org/jira/browse/NIFI-10370 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Kalmár Róbert >Assignee: Kalmár Róbert >Priority: Major > Time Spent: 3h 50m > Remaining Estimate: 0h > > Create a record oriented processor dedicated to push data into Snowflake > using the Snowpipe approach instead of JDBC. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mark-bathori commented on pull request #6659: NIFI-10812: Remove duplicate record template creation from Iceberg record converter
mark-bathori commented on PR #6659: URL: https://github.com/apache/nifi/pull/6659#issuecomment-1320151206 Thanks for the comment @mattyb149. The record template copy was left here from a previous implementation and by removing this unnecessary call it doesn’t change the functionality only improves the performance so I think unit testing this change doesn’t really make sense. The method is covered with already existing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6682: NIFI-10389: Add mimetype to GetShopify and GetHubSpot
exceptionfactory commented on code in PR #6682:
URL: https://github.com/apache/nifi/pull/6682#discussion_r1026523366
##
nifi-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java:
##
@@ -234,6 +237,7 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
FlowFile flowFile = session.create();
flowFile = session.write(flowFile, parseHttpResponse(response,
total, stateMap));
if (total.get() > 0) {
+session.putAttribute(flowFile, CoreAttributes.MIME_TYPE.key(),
"application/json");
Review Comment:
Calling `session.putAttribute()` should update the reference to `flowFile`:
```suggestion
flowFile = session.putAttribute(flowFile,
CoreAttributes.MIME_TYPE.key(), "application/json");
```
##
nifi-nar-bundles/nifi-shopify-bundle/nifi-shopify-processors/src/main/java/org/apache/nifi/processors/shopify/GetShopify.java:
##
@@ -78,6 +80,7 @@
" The list of the resources with the supported parameters can be found
in the additional details.")
@CapabilityDescription("Retrieves objects from a custom Shopify store. The
processor yield time must be set to the account's rate limit accordingly.")
@DefaultSchedule(strategy = SchedulingStrategy.TIMER_DRIVEN, period = "1 min")
+@WritesAttribute(attribute = "mime.type", description = "Sets the mime type to
application/json")
Review Comment:
Minor wording adjustment, MIME should be uppercased.
```suggestion
@WritesAttribute(attribute = "mime.type", description = "Sets the MIME type
to application/json")
```
##
nifi-nar-bundles/nifi-shopify-bundle/nifi-shopify-processors/src/main/java/org/apache/nifi/processors/shopify/GetShopify.java:
##
@@ -322,6 +325,7 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
updateState(session, updatedStateMap);
}
if (objectCountHolder.get() > 0) {
+session.putAttribute(flowFile,
CoreAttributes.MIME_TYPE.key(), "application/json");
Review Comment:
Calling `session.putAttribute()` should update the reference to `flowFile`:
```suggestion
flowFile = session.putAttribute(flowFile,
CoreAttributes.MIME_TYPE.key(), "application/json");
```
##
nifi-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java:
##
@@ -82,6 +84,7 @@
" objects can be set in the 'Result Limit' property.")
@DefaultSettings(yieldDuration = "10 sec")
@DefaultSchedule(strategy = SchedulingStrategy.TIMER_DRIVEN, period = "1 min")
+@WritesAttribute(attribute = "mime.type", description = "Sets the mime type to
application/json")
Review Comment:
Minor wording adjustment, MIME should be uppercased.
```suggestion
@WritesAttribute(attribute = "mime.type", description = "Sets the MIME type
to application/json")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] mr1716 opened a new pull request, #6683: NIFI-10808 Update Guava to 31.1-jre
mr1716 opened a new pull request, #6683: URL: https://github.com/apache/nifi/pull/6683 # Summary [NIFI-10808](https://issues.apache.org/jira/browse/NIFI-10808) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-10808) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [X] JDK 8 - [X] JDK 11 - [X] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] Lehel44 opened a new pull request, #6682: NIFI-10389: Add mimetype to GetShopify and GetHubSpot
Lehel44 opened a new pull request, #6682: URL: https://github.com/apache/nifi/pull/6682 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10808) Update Guava to 31.1-jre
[ https://issues.apache.org/jira/browse/NIFI-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-10808: -- Summary: Update Guava to 31.1-jre (was: Update Guava to At Least 31.1-jre ) > Update Guava to 31.1-jre > > > Key: NIFI-10808 > URL: https://issues.apache.org/jira/browse/NIFI-10808 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Priority: Minor > > Update Guava to At Least 31.1-jre. Changes can be at > foundhttps://github.com/google/guava/releases > version depends on when this ticket is handled -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-10808) Update Guava to 31.1-jre
[ https://issues.apache.org/jira/browse/NIFI-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-10808: - Assignee: Mike R > Update Guava to 31.1-jre > > > Key: NIFI-10808 > URL: https://issues.apache.org/jira/browse/NIFI-10808 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > > Update Guava to At Least 31.1-jre. Changes can be at > foundhttps://github.com/google/guava/releases > version depends on when this ticket is handled -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1457: Utils net server coro
martinzink opened a new pull request, #1457: URL: https://github.com/apache/nifi-minifi-cpp/pull/1457 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-1964) Use URL/URL_HASH instead of GIT_REPOSITORY/GIT_TAG in FetchContentDeclare
[ https://issues.apache.org/jira/browse/MINIFICPP-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-1964: --- Status: Patch Available (was: In Progress) https://github.com/apache/nifi-minifi-cpp/pull/1454 > Use URL/URL_HASH instead of GIT_REPOSITORY/GIT_TAG in FetchContentDeclare > - > > Key: MINIFICPP-1964 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1964 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.12.0 >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Trivial > Fix For: 0.13.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Its faster, smaller and not prone to github's rate limitations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1456: MINIFICPP-1965 Add CMAKE flags to select malloc implementation
martinzink opened a new pull request, #1456: URL: https://github.com/apache/nifi-minifi-cpp/pull/1456 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-10839) Change HubSpot and Shopify flowfile mimtype to JSON
[ https://issues.apache.org/jira/browse/NIFI-10839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lehel Boér reassigned NIFI-10839: - Assignee: Lehel Boér > Change HubSpot and Shopify flowfile mimtype to JSON > --- > > Key: NIFI-10839 > URL: https://issues.apache.org/jira/browse/NIFI-10839 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-10839) Change HubSpot and Shopify flowfile mimtype to JSON
Lehel Boér created NIFI-10839: - Summary: Change HubSpot and Shopify flowfile mimtype to JSON Key: NIFI-10839 URL: https://issues.apache.org/jira/browse/NIFI-10839 Project: Apache NiFi Issue Type: Improvement Reporter: Lehel Boér -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1453: MINIFICPP-1989 - Discard old controller service provider from FlowController
lordgamez closed pull request #1453: MINIFICPP-1989 - Discard old controller service provider from FlowController URL: https://github.com/apache/nifi-minifi-cpp/pull/1453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1434: MINIFICPP-1949 ConsumeWindowsEventLog precompiled regex
martinzink commented on code in PR #1434:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1434#discussion_r1026454638
##
extensions/windows-event-log/Bookmark.cpp:
##
@@ -77,18 +74,18 @@ Bookmark::Bookmark(const std::wstring& channel,
state_manager_->set(state_map);
}
- if (!(hBookmark_ = unique_evt_handle{ EvtCreateBookmark(0) })) {
+ if (!(hBookmark_ = unique_evt_handle{ EvtCreateBookmark(nullptr) })) {
Review Comment:
good idea, I've changed it in
https://github.com/apache/nifi-minifi-cpp/pull/1434/files#diff-af3d1e50a2bd10e0b4ceda4fe27aaad8697ad7c82e8ffb99e188b20b2d7fff0cR64-R65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1447: MINIFICPP-1976 - Do not store a whole Relationship object for each transfer
lordgamez closed pull request #1447: MINIFICPP-1976 - Do not store a whole Relationship object for each transfer URL: https://github.com/apache/nifi-minifi-cpp/pull/1447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1452: MINIFICPP-1984 - Restart previous flow on failed flow update
lordgamez closed pull request #1452: MINIFICPP-1984 - Restart previous flow on failed flow update URL: https://github.com/apache/nifi-minifi-cpp/pull/1452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10806) Update snmp4j-agent to 2.8.14
[ https://issues.apache.org/jira/browse/NIFI-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-10806: -- Fix Version/s: 1.19.0 > Update snmp4j-agent to 2.8.14 > - > > Key: NIFI-10806 > URL: https://issues.apache.org/jira/browse/NIFI-10806 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update snmp4j-agent to 2.8.14 From 2.8.7. It is found in the SNMP Processors > section. Updating would remediate the following CVE > https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10804) Update okhttp-digest to version 2.7
[ https://issues.apache.org/jira/browse/NIFI-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-10804: -- Fix Version/s: 1.19.0 > Update okhttp-digest to version 2.7 > --- > > Key: NIFI-10804 > URL: https://issues.apache.org/jira/browse/NIFI-10804 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The version of okhttp-digest used in the NiFi lookup services is outdated and > should be updated to remediate > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250] > The current version used there is 2.5, with the most recent version being > 2.7. Release notes > https://github.com/rburgst/okhttp-digest/blob/2.7/release-notes.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10809) Update greenmail to 1.6.11 or later
[ https://issues.apache.org/jira/browse/NIFI-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-10809: -- Fix Version/s: 1.19.0 > Update greenmail to 1.6.11 or later > --- > > Key: NIFI-10809 > URL: https://issues.apache.org/jira/browse/NIFI-10809 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Release notes: [https://github.com/greenmail-mail-test/greenmail/releases] > Updating to keep the dependencies current, if possible to update. Version May > change depending upon when this is done -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10807) Update gson to 2.10
[ https://issues.apache.org/jira/browse/NIFI-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-10807: -- Fix Version/s: 1.19.0 > Update gson to 2.10 > --- > > Key: NIFI-10807 > URL: https://issues.apache.org/jira/browse/NIFI-10807 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update gson from 2.9.1 to 2.10. Release notes > https://github.com/google/gson/blob/master/CHANGELOG.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10810) Update HTTPAsyncClient to 4.1.5
[ https://issues.apache.org/jira/browse/NIFI-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-10810: -- Fix Version/s: 1.19.0 > Update HTTPAsyncClient to 4.1.5 > --- > > Key: NIFI-10810 > URL: https://issues.apache.org/jira/browse/NIFI-10810 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Fix For: 1.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update the version of httpasyncclient to 4.1.5 to mitigate CVE > [2020-13956|tel:2020-13956] > ([https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-13956)] > release notes: > https://downloads.apache.org/httpcomponents/httpasyncclient/RELEASE_NOTES-4.1.x.txt -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10736) Update snmp4j to 2.8.14 to mitigate CVE-2020-15250
[ https://issues.apache.org/jira/browse/NIFI-10736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635874#comment-17635874 ] Mike R commented on NIFI-10736: --- [~pvillard] Does this pull request solve this? [NIFI-10806 - update snmp4j dependencies · apache/nifi@85a9555 (github.com)|https://github.com/apache/nifi/commit/85a95550bbf8455ab535e9931180b071e922985b] > Update snmp4j to 2.8.14 to mitigate CVE-2020-15250 > -- > > Key: NIFI-10736 > URL: https://issues.apache.org/jira/browse/NIFI-10736 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Priority: Major > > Update snmp4j from 2.8.7 to 2.8.14 to mitigate CVE-2020-15250. The change log > can be found at https://www.snmp4j.org/CHANGES-2.x.txt -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10806) Update snmp4j-agent to 2.8.14
[ https://issues.apache.org/jira/browse/NIFI-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635865#comment-17635865 ] ASF subversion and git services commented on NIFI-10806: Commit 85a95550bbf8455ab535e9931180b071e922985b in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=85a95550bb ] NIFI-10806 - update snmp4j dependencies This closes #6677 Signed-off-by: Mike Thomsen > Update snmp4j-agent to 2.8.14 > - > > Key: NIFI-10806 > URL: https://issues.apache.org/jira/browse/NIFI-10806 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Update snmp4j-agent to 2.8.14 From 2.8.7. It is found in the SNMP Processors > section. Updating would remediate the following CVE > https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10804) Update okhttp-digest to version 2.7
[ https://issues.apache.org/jira/browse/NIFI-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635869#comment-17635869 ] ASF subversion and git services commented on NIFI-10804: Commit 2698282615ccf7fad03692badca9e2bceb86ea55 in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2698282615 ] NIFI-10804 - Update okhttp-digest to 2.7 This closes #6681 Signed-off-by: Mike Thomsen > Update okhttp-digest to version 2.7 > --- > > Key: NIFI-10804 > URL: https://issues.apache.org/jira/browse/NIFI-10804 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The version of okhttp-digest used in the NiFi lookup services is outdated and > should be updated to remediate > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250] > The current version used there is 2.5, with the most recent version being > 2.7. Release notes > https://github.com/rburgst/okhttp-digest/blob/2.7/release-notes.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10807) Update gson to 2.10
[ https://issues.apache.org/jira/browse/NIFI-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635868#comment-17635868 ] ASF subversion and git services commented on NIFI-10807: Commit f717025380fa0731a9be45179c9ca215bbe4c87e in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f717025380 ] NIFI-10807 - Update gson to 2.10 This closes #6680 Signed-off-by: Mike Thomsen > Update gson to 2.10 > --- > > Key: NIFI-10807 > URL: https://issues.apache.org/jira/browse/NIFI-10807 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Update gson from 2.9.1 to 2.10. Release notes > https://github.com/google/gson/blob/master/CHANGELOG.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10809) Update greenmail to 1.6.11 or later
[ https://issues.apache.org/jira/browse/NIFI-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635867#comment-17635867 ] ASF subversion and git services commented on NIFI-10809: Commit 87f02d26d9d7180699df1c87c0af6cad3f56ba33 in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=87f02d26d9 ] NIFI-10809 - Update greenmail to 1.6.11 This closes #6679 Signed-off-by: Mike Thomsen > Update greenmail to 1.6.11 or later > --- > > Key: NIFI-10809 > URL: https://issues.apache.org/jira/browse/NIFI-10809 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Release notes: [https://github.com/greenmail-mail-test/greenmail/releases] > Updating to keep the dependencies current, if possible to update. Version May > change depending upon when this is done -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10810) Update HTTPAsyncClient to 4.1.5
[ https://issues.apache.org/jira/browse/NIFI-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635866#comment-17635866 ] ASF subversion and git services commented on NIFI-10810: Commit 7374f9d2b2c25efc1acbc5b9f1689372b4a0d616 in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7374f9d2b2 ] NIFI-10810 - Update HTTPAsyncClient to 4.1.5 This closes #6678 Signed-off-by: Mike Thomsen > Update HTTPAsyncClient to 4.1.5 > --- > > Key: NIFI-10810 > URL: https://issues.apache.org/jira/browse/NIFI-10810 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Update the version of httpasyncclient to 4.1.5 to mitigate CVE > [2020-13956|tel:2020-13956] > ([https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-13956)] > release notes: > https://downloads.apache.org/httpcomponents/httpasyncclient/RELEASE_NOTES-4.1.x.txt -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #6679: NIFI-10809 - Update greenmail to 1.6.11
asfgit closed pull request #6679: NIFI-10809 - Update greenmail to 1.6.11 URL: https://github.com/apache/nifi/pull/6679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #6681: NIFI-10804 - Update okhttp-digest to 2.7
asfgit closed pull request #6681: NIFI-10804 - Update okhttp-digest to 2.7 URL: https://github.com/apache/nifi/pull/6681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #6680: NIFI-10807 - Update gson to 2.10
asfgit closed pull request #6680: NIFI-10807 - Update gson to 2.10 URL: https://github.com/apache/nifi/pull/6680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #6678: NIFI-10810 - Update HTTPAsyncClient to 4.1.5
asfgit closed pull request #6678: NIFI-10810 - Update HTTPAsyncClient to 4.1.5 URL: https://github.com/apache/nifi/pull/6678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #6677: NIFI-10806 - update snmp4j dependencies
asfgit closed pull request #6677: NIFI-10806 - update snmp4j dependencies URL: https://github.com/apache/nifi/pull/6677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1434: MINIFICPP-1949 ConsumeWindowsEventLog precompiled regex
martinzink commented on code in PR #1434:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1434#discussion_r1026440942
##
extensions/windows-event-log/ConsumeWindowsEventLog.cpp:
##
@@ -725,28 +744,24 @@ void
ConsumeWindowsEventLog::putEventRenderFlowFileToSession(const EventRender&
}
}
-void ConsumeWindowsEventLog::LogWindowsError(std::string error) const {
+void ConsumeWindowsEventLog::LogWindowsError(const std::string& error) const {
auto error_id = GetLastError();
LPVOID lpMsg;
FormatMessage(
-FORMAT_MESSAGE_ALLOCATE_BUFFER |
-FORMAT_MESSAGE_FROM_SYSTEM,
-NULL,
-error_id,
-MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
-(LPTSTR)&lpMsg,
-0, NULL);
+ FORMAT_MESSAGE_ALLOCATE_BUFFER |
+ FORMAT_MESSAGE_FROM_SYSTEM,
Review Comment:
resubmitted without this change
##
extensions/windows-event-log/ConsumeWindowsEventLog.cpp:
##
@@ -685,21 +698,27 @@ void ConsumeWindowsEventLog::refreshTimeZoneData() {
logger_->log_trace("Timezone name: %s, offset: %s", timezone_name_,
timezone_offset_);
}
-void ConsumeWindowsEventLog::putEventRenderFlowFileToSession(const
EventRender& eventRender, core::ProcessSession& session) const {
- auto commitFlowFile = [&] (const std::shared_ptr& flowFile,
const std::string& content, const std::string& mimeType) {
-session.writeBuffer(flowFile, content);
-session.putAttribute(flowFile, core::SpecialFlowAttribute::MIME_TYPE,
mimeType);
-session.putAttribute(flowFile, "timezone.name", timezone_name_);
-session.putAttribute(flowFile, "timezone.offset", timezone_offset_);
-session.getProvenanceReporter()->receive(flowFile, provenanceUri_,
getUUIDStr(), "Consume windows event logs", 0ms);
-session.transfer(flowFile, Success);
- };
+void ConsumeWindowsEventLog::putEventRenderFlowFileToSession(const
EventRender& eventRender,
+
core::ProcessSession& session) const {
Review Comment:
resubmitted without this change
##
extensions/windows-event-log/ConsumeWindowsEventLog.cpp:
##
@@ -657,19 +673,16 @@ void ConsumeWindowsEventLog::refreshTimeZoneData() {
long tzbias = 0; // NOLINT long comes from WINDOWS API
bool dst = false;
switch (ret) {
-case TIME_ZONE_ID_INVALID:
- logger_->log_error("Failed to get timezone information!");
+case TIME_ZONE_ID_INVALID:logger_->log_error("Failed to get timezone
information!");
Review Comment:
resubmitted without this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1434: MINIFICPP-1949 ConsumeWindowsEventLog precompiled regex
martinzink commented on PR #1434: URL: https://github.com/apache/nifi-minifi-cpp/pull/1434#issuecomment-1319997173 > t Sry about that, it turns out my windows machine was not correctly setup and the auto formatting from Visual Studio is a bit overreaching... I went over and removed the unintended format changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] (NIFI-5901) Write JSON record in database
[ https://issues.apache.org/jira/browse/NIFI-5901 ]
Luigi De Giovanni deleted comment on NIFI-5901:
-
was (Author: JIRAUSER298268):
It would be great to know at least a workaround for this case, if this feature
is not being implemented.
JOLT transformations don't seem to work, handling the JSON as string, as all
the field names lose the double quotes.
> Write JSON record in database
> -
>
> Key: NIFI-5901
> URL: https://issues.apache.org/jira/browse/NIFI-5901
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.8.0
>Reporter: Flo Rance
>Assignee: Mike Thomsen
>Priority: Minor
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> It would be good to be able to store a whole json record in databases that
> implement it (e.g. postgresql). This would require to define the field in the
> shema as json/jsonb and then let PutDatabaseRecord inserts the json value in
> the json/jsonb field.
> At the moment, it's possible to store a json/jsonb through Postgresql JDBC
> using the Java sql type 'OTHER':
> Object data = "\{...}"; // the JSON document
> PreparedStatement.setObject(1, data, java.sql.Types.OTHER);
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] pvillard31 opened a new pull request, #6681: NIFI-10804 - Update okhttp-digest to 2.7
pvillard31 opened a new pull request, #6681: URL: https://github.com/apache/nifi/pull/6681 # Summary [NIFI-10804](https://issues.apache.org/jira/browse/NIFI-10804) - Update okhttp-digest to 2.7 # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10804) Update okhttp-digest to version 2.7
[ https://issues.apache.org/jira/browse/NIFI-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10804: -- Assignee: Pierre Villard Status: Patch Available (was: Open) > Update okhttp-digest to version 2.7 > --- > > Key: NIFI-10804 > URL: https://issues.apache.org/jira/browse/NIFI-10804 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > > The version of okhttp-digest used in the NiFi lookup services is outdated and > should be updated to remediate > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250] > The current version used there is 2.5, with the most recent version being > 2.7. Release notes > https://github.com/rburgst/okhttp-digest/blob/2.7/release-notes.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10807) Update gson to 2.10
[ https://issues.apache.org/jira/browse/NIFI-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10807: -- Assignee: Pierre Villard Status: Patch Available (was: Open) > Update gson to 2.10 > --- > > Key: NIFI-10807 > URL: https://issues.apache.org/jira/browse/NIFI-10807 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Update gson from 2.9.1 to 2.10. Release notes > https://github.com/google/gson/blob/master/CHANGELOG.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] pvillard31 opened a new pull request, #6680: NIFI-10807 - Update gson to 2.10
pvillard31 opened a new pull request, #6680: URL: https://github.com/apache/nifi/pull/6680 # Summary [NIFI-10807](https://issues.apache.org/jira/browse/NIFI-10807) - Update gson to 2.10 # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10807) Update gson to 2.10
[ https://issues.apache.org/jira/browse/NIFI-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10807: -- Summary: Update gson to 2.10 (was: Update gson to 2.9.10) > Update gson to 2.10 > --- > > Key: NIFI-10807 > URL: https://issues.apache.org/jira/browse/NIFI-10807 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Priority: Minor > > Update gson from 2.9.1 to 2.10. Release notes > https://github.com/google/gson/blob/master/CHANGELOG.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10809) Update greenmail to 1.6.11 or later
[ https://issues.apache.org/jira/browse/NIFI-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10809: -- Assignee: Pierre Villard Status: Patch Available (was: Open) > Update greenmail to 1.6.11 or later > --- > > Key: NIFI-10809 > URL: https://issues.apache.org/jira/browse/NIFI-10809 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Release notes: [https://github.com/greenmail-mail-test/greenmail/releases] > Updating to keep the dependencies current, if possible to update. Version May > change depending upon when this is done -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] pvillard31 opened a new pull request, #6679: NIFI-10809 - Update greenmail to 1.6.11
pvillard31 opened a new pull request, #6679: URL: https://github.com/apache/nifi/pull/6679 # Summary [NIFI-10809](https://issues.apache.org/jira/browse/NIFI-10809) - Update greenmail to 1.6.11 # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-10810) Update HTTPAsyncClient to 4.1.5
[ https://issues.apache.org/jira/browse/NIFI-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard reassigned NIFI-10810: - Assignee: Pierre Villard > Update HTTPAsyncClient to 4.1.5 > --- > > Key: NIFI-10810 > URL: https://issues.apache.org/jira/browse/NIFI-10810 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Update the version of httpasyncclient to 4.1.5 to mitigate CVE > [2020-13956|tel:2020-13956] > ([https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-13956)] > release notes: > https://downloads.apache.org/httpcomponents/httpasyncclient/RELEASE_NOTES-4.1.x.txt -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10810) Update HTTPAsyncClient to 4.1.5
[ https://issues.apache.org/jira/browse/NIFI-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10810: -- Status: Patch Available (was: Open) > Update HTTPAsyncClient to 4.1.5 > --- > > Key: NIFI-10810 > URL: https://issues.apache.org/jira/browse/NIFI-10810 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Update the version of httpasyncclient to 4.1.5 to mitigate CVE > [2020-13956|tel:2020-13956] > ([https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-13956)] > release notes: > https://downloads.apache.org/httpcomponents/httpasyncclient/RELEASE_NOTES-4.1.x.txt -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] pvillard31 opened a new pull request, #6678: NIFI-10810 - Update HTTPAsyncClient to 4.1.5
pvillard31 opened a new pull request, #6678: URL: https://github.com/apache/nifi/pull/6678 # Summary [NIFI-10810](https://issues.apache.org/jira/browse/NIFI-10810) - Update HTTPAsyncClient to 4.1.5 # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10806) Update snmp4j-agent to 2.8.14
[ https://issues.apache.org/jira/browse/NIFI-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10806: -- Assignee: Pierre Villard Status: Patch Available (was: Open) > Update snmp4j-agent to 2.8.14 > - > > Key: NIFI-10806 > URL: https://issues.apache.org/jira/browse/NIFI-10806 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.18.0 >Reporter: Mike R >Assignee: Pierre Villard >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Update snmp4j-agent to 2.8.14 From 2.8.7. It is found in the SNMP Processors > section. Updating would remediate the following CVE > https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] pvillard31 opened a new pull request, #6677: NIFI-10806 - update snmp4j dependencies
pvillard31 opened a new pull request, #6677: URL: https://github.com/apache/nifi/pull/6677 # Summary [NIFI-10806](https://issues.apache.org/jira/browse/NIFI-10806) Update snmp4j dependencies # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10820) Change base Docker images for NiFi
[ https://issues.apache.org/jira/browse/NIFI-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-10820: - Resolution: Fixed Status: Resolved (was: Patch Available) > Change base Docker images for NiFi > -- > > Key: NIFI-10820 > URL: https://issues.apache.org/jira/browse/NIFI-10820 > Project: Apache NiFi > Issue Type: Sub-task > Components: Docker >Reporter: Kevin Doran >Assignee: Kevin Doran >Priority: Major > Fix For: 1.19.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Pretty much the same work that was done for minifi under NIFI-10701, but for > nifi -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-9656) Publish a Java 11 docker image
[ https://issues.apache.org/jira/browse/NIFI-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-9656: Resolution: Fixed Status: Resolved (was: Patch Available) > Publish a Java 11 docker image > -- > > Key: NIFI-9656 > URL: https://issues.apache.org/jira/browse/NIFI-9656 > Project: Apache NiFi > Issue Type: Wish > Components: Docker >Affects Versions: 1.15.3 > Environment: Docker >Reporter: Christoph Nölle >Assignee: Kevin Doran >Priority: Minor > Fix For: 1.19.0 > > > There have been requests before to update the official Docker image to Java > 11 (such as [NIFI-9188|https://issues.apache.org/jira/browse/NIFI-9188]). As > I understand, this would be a breaking change for many users, though, and > therefore has been postponed for Nifi 2.0. On the other hand, it would be > quite desirable if one could use Java 11 features in custom processors > (without maintaining a custom Docker image). > A solution could be to keep Java 8 for the default image (e.g. tagged > "1.15.3" = latest) and provide a second image, e.g. "1.15.3-openjdk-11". The > Dockerfile has already been adapted to support building with a Java 11 base > image in [https://github.com/apache/nifi/pull/4460]. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-9656) Publish a Java 11 docker image
[ https://issues.apache.org/jira/browse/NIFI-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635810#comment-17635810 ] ASF subversion and git services commented on NIFI-9656: --- Commit 78f206a811531c1dfcd3edc9fceb6cce7d0cc594 in nifi's branch refs/heads/main from Kevin Doran [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=78f206a811 ] NIFI-10820 Change Docker base image to eclipse-temurin NIFI-9656 Change Docker images to use Java 11 This closes #6673 Signed-off-by: Chris Sampson Signed-off-by: David Handermann > Publish a Java 11 docker image > -- > > Key: NIFI-9656 > URL: https://issues.apache.org/jira/browse/NIFI-9656 > Project: Apache NiFi > Issue Type: Wish > Components: Docker >Affects Versions: 1.15.3 > Environment: Docker >Reporter: Christoph Nölle >Assignee: Kevin Doran >Priority: Minor > Fix For: 1.19.0 > > > There have been requests before to update the official Docker image to Java > 11 (such as [NIFI-9188|https://issues.apache.org/jira/browse/NIFI-9188]). As > I understand, this would be a breaking change for many users, though, and > therefore has been postponed for Nifi 2.0. On the other hand, it would be > quite desirable if one could use Java 11 features in custom processors > (without maintaining a custom Docker image). > A solution could be to keep Java 8 for the default image (e.g. tagged > "1.15.3" = latest) and provide a second image, e.g. "1.15.3-openjdk-11". The > Dockerfile has already been adapted to support building with a Java 11 base > image in [https://github.com/apache/nifi/pull/4460]. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10820) Change base Docker images for NiFi
[ https://issues.apache.org/jira/browse/NIFI-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635809#comment-17635809 ] ASF subversion and git services commented on NIFI-10820: Commit 78f206a811531c1dfcd3edc9fceb6cce7d0cc594 in nifi's branch refs/heads/main from Kevin Doran [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=78f206a811 ] NIFI-10820 Change Docker base image to eclipse-temurin NIFI-9656 Change Docker images to use Java 11 This closes #6673 Signed-off-by: Chris Sampson Signed-off-by: David Handermann > Change base Docker images for NiFi > -- > > Key: NIFI-10820 > URL: https://issues.apache.org/jira/browse/NIFI-10820 > Project: Apache NiFi > Issue Type: Sub-task > Components: Docker >Reporter: Kevin Doran >Assignee: Kevin Doran >Priority: Major > Fix For: 1.19.0 > > Time Spent: 3h > Remaining Estimate: 0h > > Pretty much the same work that was done for minifi under NIFI-10701, but for > nifi -- This message was sent by Atlassian Jira (v8.20.10#820010)
