[GitHub] [nifi] sopan98 opened a new pull request, #6700: NIFI-10856 Fix Flaky Test in TestSegmentContent

2022-11-21 Thread GitBox


sopan98 opened a new pull request, #6700:
URL: https://github.com/apache/nifi/pull/6700

   # Summary
   
   [NIFI-10856](https://issues.apache.org/jira/browse/NIFI-10856)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [x] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10856) Tests in TestSegmentContent use non-deterministic HashSet

2022-11-21 Thread Sopan Phaltankar (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sopan Phaltankar updated NIFI-10856:

Attachment: org.apache.nifi.processors.standard.TestSegmentContent.txt

> Tests in TestSegmentContent use non-deterministic HashSet
> -
>
> Key: NIFI-10856
> URL: https://issues.apache.org/jira/browse/NIFI-10856
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
> Environment: Apache Maven 3.6.0;
> openjdk version "1.8.0_342";
> OpenJDK Runtime Environment (build 1.8.0_342-8u342-b07-0ubuntu1~20.04-b07);
> OpenJDK 64-Bit Server VM (build 25.342-b07, mixed mode);
>Reporter: Sopan Phaltankar
>Assignee: Sopan Phaltankar
>Priority: Trivial
> Fix For: 1.19.0
>
> Attachments: 
> org.apache.nifi.processors.standard.TestSegmentContent.txt
>
>
> {code:java}
> 1. org.apache.nifi.processors.standard.TestSegmentContent.test{code}
> This is a flaky test, it can pass mvn test while but when run using the tool 
> [NonDex|https://github.com/TestingResearchIllinois/NonDex], it fails. NonDex 
> is a tool that will introduce non-determinism in certain java collections.
> The test shows below:
> {code:java}
>  {code}
> *Steps to reproduce the failure:*
>  # Run the following command in nifi:
>  # First, build the module:
> {noformat}
> mvn install -pl 
> nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors -am 
> -DskipTests -Drat.skip{noformat}
>  # Then run the test using 
> [NonDex|https://github.com/TestingResearchIllinois/NonDex]
> {noformat}
> 1. mvn edu.illinois:nondex-maven-plugin:1.1.2:nondex -pl 
> nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors 
> -Dtest=org.apache.nifi.processors.standard.TestSegmentContent#test{noformat}
>  
> The result will be saved under the module folder in .nondex



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10856) Tests in TestSegmentContent use non-deterministic HashSet

2022-11-21 Thread Sopan Phaltankar (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sopan Phaltankar updated NIFI-10856:

Description: 
{code:java}
1. org.apache.nifi.processors.standard.TestSegmentContent.test{code}
This is a flaky test, it can pass mvn test while but when run using the tool 
[NonDex|https://github.com/TestingResearchIllinois/NonDex], it fails. NonDex is 
a tool that will introduce non-determinism in certain java collections.

The test shows below:
{code:java}
[ERROR] Failures:
[ERROR]   TestSegmentContent.test:51 FlowFile content differs from input at 
byte 0 with input having value 1 and FlowFile having value 9
{code}
*Steps to reproduce the failure:*
 # Run the following command in nifi:
 # First, build the module:

{noformat}
mvn install -pl nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors 
-am -DskipTests -Drat.skip{noformat}
 # Then run the test using 
[NonDex|https://github.com/TestingResearchIllinois/NonDex]

{noformat}
1. mvn edu.illinois:nondex-maven-plugin:1.1.2:nondex -pl 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors 
-Dtest=org.apache.nifi.processors.standard.TestSegmentContent#test{noformat}
The result will be saved under the module folder in .nondex

  was:
{code:java}
1. org.apache.nifi.processors.standard.TestSegmentContent.test{code}
This is a flaky test, it can pass mvn test while but when run using the tool 
[NonDex|https://github.com/TestingResearchIllinois/NonDex], it fails. NonDex is 
a tool that will introduce non-determinism in certain java collections.

The test shows below:
{code:java}
 {code}
*Steps to reproduce the failure:*
 # Run the following command in nifi:
 # First, build the module:

{noformat}
mvn install -pl nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors 
-am -DskipTests -Drat.skip{noformat}
 # Then run the test using 
[NonDex|https://github.com/TestingResearchIllinois/NonDex]

{noformat}
1. mvn edu.illinois:nondex-maven-plugin:1.1.2:nondex -pl 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors 
-Dtest=org.apache.nifi.processors.standard.TestSegmentContent#test{noformat}
 

The result will be saved under the module folder in .nondex


> Tests in TestSegmentContent use non-deterministic HashSet
> -
>
> Key: NIFI-10856
> URL: https://issues.apache.org/jira/browse/NIFI-10856
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
> Environment: Apache Maven 3.6.0;
> openjdk version "1.8.0_342";
> OpenJDK Runtime Environment (build 1.8.0_342-8u342-b07-0ubuntu1~20.04-b07);
> OpenJDK 64-Bit Server VM (build 25.342-b07, mixed mode);
>Reporter: Sopan Phaltankar
>Assignee: Sopan Phaltankar
>Priority: Trivial
> Fix For: 1.19.0
>
> Attachments: 
> org.apache.nifi.processors.standard.TestSegmentContent.txt
>
>
> {code:java}
> 1. org.apache.nifi.processors.standard.TestSegmentContent.test{code}
> This is a flaky test, it can pass mvn test while but when run using the tool 
> [NonDex|https://github.com/TestingResearchIllinois/NonDex], it fails. NonDex 
> is a tool that will introduce non-determinism in certain java collections.
> The test shows below:
> {code:java}
> [ERROR] Failures:
> [ERROR]   TestSegmentContent.test:51 FlowFile content differs from input at 
> byte 0 with input having value 1 and FlowFile having value 9
> {code}
> *Steps to reproduce the failure:*
>  # Run the following command in nifi:
>  # First, build the module:
> {noformat}
> mvn install -pl 
> nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors -am 
> -DskipTests -Drat.skip{noformat}
>  # Then run the test using 
> [NonDex|https://github.com/TestingResearchIllinois/NonDex]
> {noformat}
> 1. mvn edu.illinois:nondex-maven-plugin:1.1.2:nondex -pl 
> nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors 
> -Dtest=org.apache.nifi.processors.standard.TestSegmentContent#test{noformat}
> The result will be saved under the module folder in .nondex



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10856) Tests in TestSegmentContent use non-deterministic HashSet

2022-11-21 Thread Sopan Phaltankar (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sopan Phaltankar updated NIFI-10856:

Description: 
{code:java}
1. org.apache.nifi.processors.standard.TestSegmentContent.test{code}
This is a flaky test, it can pass mvn test while but when run using the tool 
[NonDex|https://github.com/TestingResearchIllinois/NonDex], it fails. NonDex is 
a tool that will introduce non-determinism in certain java collections.

The test shows below:
{code:java}
 {code}
*Steps to reproduce the failure:*
 # Run the following command in nifi:
 # First, build the module:

{noformat}
mvn install -pl nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors 
-am -DskipTests -Drat.skip{noformat}
 # Then run the test using 
[NonDex|https://github.com/TestingResearchIllinois/NonDex]

{noformat}
1. mvn edu.illinois:nondex-maven-plugin:1.1.2:nondex -pl 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors 
-Dtest=org.apache.nifi.processors.standard.TestSegmentContent#test{noformat}
 

The result will be saved under the module folder in .nondex

  was:
{code:java}
1. org.apache.nifi.hbase.TestScanHBase#testScanToContentWithStringValues
2. 
org.apache.nifi.hbase.TestScanHBase#testScanToContentWithQualifierAndValueJSON{code}
This is a flaky test, it can pass mvn test while but when run using the tool 
[NonDex|https://github.com/TestingResearchIllinois/NonDex], it fails. NonDex is 
a tool that will introduce non-determinism in certain java collections.

The test shows below:
{code:java}
1. org.apache.nifi.hbase.TestScanHBase.testScanToContentWithStringValues  
Time elapsed: 0.267 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: 
expected: <[{"row":"row1", "cells": 
[{"fam":"nifi","qual":"cq1","val":"val1","ts":123456789}, 
{"fam":"nifi","qual":"cq2","val":"val2","ts":123456789}]},
{"row":"row2", "cells": 
[{"fam":"nifi","qual":"cq1","val":"val1","ts":123456789}, 
{"fam":"nifi","qual":"cq2","val":"val2","ts":123456789}]}]> but was: 
<[{"row":"row1", "cells": 
[{"fam":"nifi","qual":"cq2","val":"val2","ts":123456789}, 
{"fam":"nifi","qual":"cq1","val":"val1","ts":123456789}]},
{"row":"row2", "cells": 
[{"fam":"nifi","qual":"cq1","val":"val1","ts":123456789}, 
{"fam":"nifi","qual":"cq2","val":"val2","ts":123456789}]}]>

2. 
org.apache.nifi.hbase.TestScanHBase#testScanToContentWithQualifierAndValueJSON
Time elapsed: 0.019 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <[{"cq1":"val1", "cq2":"val2"}]> 
but was: <[{"cq2":"val2", "cq1":"val1"}]>{code}
*Steps to reproduce the failure:*
 # Run the following command in nifi:
 # First, build the module:

{noformat}
mvn install -pl nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors 
-DskipTests -Drat.skip -am{noformat}
 # Then run the test using 
[NonDex|https://github.com/TestingResearchIllinois/NonDex]

{noformat}
1. mvn -pl nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors 
edu.illinois:nondex-maven-plugin:1.1.2:nondex 
-Dtest=org.apache.nifi.hbase.TestScanHBase#testScanToContentWithStringValues

2. mvn -pl nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors 
edu.illinois:nondex-maven-plugin:1.1.2:nondex 
-Dtest=org.apache.nifi.hbase.TestScanHBase#testScanToContentWithQualifierAndValueJSON{noformat}
 

The result will be saved under the module folder in .nondex


> Tests in TestSegmentContent use non-deterministic HashSet
> -
>
> Key: NIFI-10856
> URL: https://issues.apache.org/jira/browse/NIFI-10856
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
> Environment: Apache Maven 3.6.0;
> openjdk version "1.8.0_342";
> OpenJDK Runtime Environment (build 1.8.0_342-8u342-b07-0ubuntu1~20.04-b07);
> OpenJDK 64-Bit Server VM (build 25.342-b07, mixed mode);
>Reporter: Sopan Phaltankar
>Assignee: Sopan Phaltankar
>Priority: Trivial
> Fix For: 1.19.0
>
>
> {code:java}
> 1. org.apache.nifi.processors.standard.TestSegmentContent.test{code}
> This is a flaky test, it can pass mvn test while but when run using the tool 
> [NonDex|https://github.com/TestingResearchIllinois/NonDex], it fails. NonDex 
> is a tool that will introduce non-determinism in certain java collections.
> The test shows below:
> {code:java}
>  {code}
> *Steps to reproduce the failure:*
>  # Run the following command in nifi:
>  # First, build the module:
> {noformat}
> mvn install -pl 
> nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors -am 
> -DskipTests -Drat.skip{noformat}
>  # Then run the test using 
> [NonDex|https://github.com/TestingResearchIllinois/NonDex]
> {noformat}
> 1. mvn edu.illinois:nondex-maven-plugin:1.1.2:nondex -pl 
> nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors 
> -Dtest=org.apache.nifi.processors.standard.TestSegmentContent#test{nofo

[jira] [Created] (NIFI-10856) Tests in TestSegmentContent use non-deterministic HashSet

2022-11-21 Thread Sopan Phaltankar (Jira)
Sopan Phaltankar created NIFI-10856:
---

 Summary: Tests in TestSegmentContent use non-deterministic HashSet
 Key: NIFI-10856
 URL: https://issues.apache.org/jira/browse/NIFI-10856
 Project: Apache NiFi
  Issue Type: Bug
  Components: Extensions
 Environment: Apache Maven 3.6.0;
openjdk version "1.8.0_342";
OpenJDK Runtime Environment (build 1.8.0_342-8u342-b07-0ubuntu1~20.04-b07);
OpenJDK 64-Bit Server VM (build 25.342-b07, mixed mode);
Reporter: Sopan Phaltankar
Assignee: Sopan Phaltankar
 Fix For: 1.19.0


{code:java}
1. org.apache.nifi.hbase.TestScanHBase#testScanToContentWithStringValues
2. 
org.apache.nifi.hbase.TestScanHBase#testScanToContentWithQualifierAndValueJSON{code}
This is a flaky test, it can pass mvn test while but when run using the tool 
[NonDex|https://github.com/TestingResearchIllinois/NonDex], it fails. NonDex is 
a tool that will introduce non-determinism in certain java collections.

The test shows below:
{code:java}
1. org.apache.nifi.hbase.TestScanHBase.testScanToContentWithStringValues  
Time elapsed: 0.267 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: 
expected: <[{"row":"row1", "cells": 
[{"fam":"nifi","qual":"cq1","val":"val1","ts":123456789}, 
{"fam":"nifi","qual":"cq2","val":"val2","ts":123456789}]},
{"row":"row2", "cells": 
[{"fam":"nifi","qual":"cq1","val":"val1","ts":123456789}, 
{"fam":"nifi","qual":"cq2","val":"val2","ts":123456789}]}]> but was: 
<[{"row":"row1", "cells": 
[{"fam":"nifi","qual":"cq2","val":"val2","ts":123456789}, 
{"fam":"nifi","qual":"cq1","val":"val1","ts":123456789}]},
{"row":"row2", "cells": 
[{"fam":"nifi","qual":"cq1","val":"val1","ts":123456789}, 
{"fam":"nifi","qual":"cq2","val":"val2","ts":123456789}]}]>

2. 
org.apache.nifi.hbase.TestScanHBase#testScanToContentWithQualifierAndValueJSON
Time elapsed: 0.019 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <[{"cq1":"val1", "cq2":"val2"}]> 
but was: <[{"cq2":"val2", "cq1":"val1"}]>{code}
*Steps to reproduce the failure:*
 # Run the following command in nifi:
 # First, build the module:

{noformat}
mvn install -pl nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors 
-DskipTests -Drat.skip -am{noformat}
 # Then run the test using 
[NonDex|https://github.com/TestingResearchIllinois/NonDex]

{noformat}
1. mvn -pl nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors 
edu.illinois:nondex-maven-plugin:1.1.2:nondex 
-Dtest=org.apache.nifi.hbase.TestScanHBase#testScanToContentWithStringValues

2. mvn -pl nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors 
edu.illinois:nondex-maven-plugin:1.1.2:nondex 
-Dtest=org.apache.nifi.hbase.TestScanHBase#testScanToContentWithQualifierAndValueJSON{noformat}
 

The result will be saved under the module folder in .nondex



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi-fds] dependabot[bot] opened a new pull request, #70: Bump engine.io and socket.io

2022-11-21 Thread GitBox


dependabot[bot] opened a new pull request, #70:
URL: https://github.com/apache/nifi-fds/pull/70

   Bumps [engine.io](https://github.com/socketio/engine.io) and 
[socket.io](https://github.com/socketio/socket.io). These dependencies needed 
to be updated together.
   Updates `engine.io` from 6.1.2 to 6.2.1
   
   Release notes
   Sourced from https://github.com/socketio/engine.io/releases";>engine.io's 
releases.
   
   6.2.1
   :warning: This release contains an important security fix :warning:
   A malicious client could send a specially crafted HTTP request, 
triggering an uncaught exception and killing the Node.js process:
   Error: read ECONNRESET
   at TCP.onStreamRead (internal/stream_base_commons.js:209:20)
   Emitted 'error' event on Socket instance at:
   at emitErrorNT (internal/streams/destroy.js:106:8)
   at emitErrorCloseNT (internal/streams/destroy.js:74:3)
   at processTicksAndRejections (internal/process/task_queues.js:80:21) {
 errno: -104,
 code: 'ECONNRESET',
 syscall: 'read'
   }
   
   Please upgrade as soon as possible.
   Bug Fixes
   
   catch errors when destroying invalid upgrades (https://github-redirect.dependabot.com/socketio/engine.io/issues/658";>#658)
 (https://github.com/socketio/engine.io/commit/425e833ab13373edf1dd5a0706f07100db14e3c6";>425e833)
   
   6.2.0
   Features
   
   add the "maxPayload" field in the handshake details (https://github.com/socketio/engine.io/commit/088dcb4dff60df39785df13d0a33d3ceaa1dff38";>088dcb4)
   
   So that clients in HTTP long-polling can decide how many packets they 
have to send to stay under the maxHttpBufferSize
   value.
   This is a backward compatible change which should not mandate a new major 
revision of the protocol (we stay in v4), as
   we only add a field in the JSON-encoded handshake data:
   
0{"sid":"lv_VI97HAXpY6yYWAAAC","upgrades":["websocket"],"pingInterval":25000,"pingTimeout":5000,"maxPayload":100}
   
   Links
   
   Diff: https://github.com/socketio/engine.io/compare/6.1.3...6.2.0";>https://github.com/socketio/engine.io/compare/6.1.3...6.2.0
   Client release: https://github.com/socketio/engine.io-client/releases/tag/6.2.0";>6.2.0
   ws version: https://github.com/websockets/ws/releases/tag/8.2.3";>~8.2.3
   
   6.1.3
   Bug Fixes
   
   typings: allow CorsOptionsDelegate as cors options (https://github-redirect.dependabot.com/socketio/engine.io/issues/641";>#641)
 (https://github.com/socketio/engine.io/commit/a463d268ed90064e7863679bda423951de108c36";>a463d26)
   uws: properly handle chunked content (https://github-redirect.dependabot.com/socketio/engine.io/issues/642";>#642)
 (https://github.com/socketio/engine.io/commit/33674403084c329dc6ad026c4122333a6f8a9992";>3367440)
   
   
   
   ... (truncated)
   
   
   Changelog
   Sourced from https://github.com/socketio/engine.io/blob/main/CHANGELOG.md";>engine.io's 
changelog.
   
   https://github.com/socketio/engine.io/compare/6.2.0...6.2.1";>6.2.1 
(2022-11-20)
   :warning: This release contains an important security fix :warning:
   A malicious client could send a specially crafted HTTP request, 
triggering an uncaught exception and killing the Node.js process:
   Error: read ECONNRESET
   at TCP.onStreamRead (internal/stream_base_commons.js:209:20)
   Emitted 'error' event on Socket instance at:
   at emitErrorNT (internal/streams/destroy.js:106:8)
   at emitErrorCloseNT (internal/streams/destroy.js:74:3)
   at processTicksAndRejections (internal/process/task_queues.js:80:21) {
 errno: -104,
 code: 'ECONNRESET',
 syscall: 'read'
   }
   
   Please upgrade as soon as possible.
   Bug Fixes
   
   catch errors when destroying invalid upgrades (https://github-redirect.dependabot.com/socketio/engine.io/issues/658";>#658)
 (https://github.com/socketio/engine.io/commit/425e833ab13373edf1dd5a0706f07100db14e3c6";>425e833)
   
   https://github.com/socketio/engine.io/compare/3.5.0...3.6.0";>3.6.0 
(2022-06-06)
   Bug Fixes
   
   add extension in the package.json main entry (https://github-redirect.dependabot.com/socketio/engine.io/issues/608";>#608)
 (https://github.com/socketio/engine.io/commit/3ad0567dbd57cfb7c2ff4e8b7488d80f37022b4a";>3ad0567)
   do not reset the ping timer after upgrade (https://github.com/socketio/engine.io/commit/1f5d4699862afee1e410fcb0e1f5e751ebcd2f9f";>1f5d469),
 closes https://github-redirect.dependabot.com//github-redirect.dependabot.com/socketio/socket.io-client-swift/pull/1309/issues/issuecomment-768475704";>socketio/socket.io-client-swift#1309
   
   Features
   
   decrease the default value of maxHttpBufferSize (https://github.com/socketio/engine.io/commit/58e274c437e9cbcf69fd913c813aad8fbd253703";>58e274c)
   
   This change reduces the default value from 100 mb to a more sane 1 mb.
   This helps protect the server against denial of service attacks by 
malicious clients sending huge amounts of data.
   See also: https://github.com/advisories/GHSA-j4f2-536g-r55m";>https://git

[jira] [Updated] (NIFI-5819) Support SQLServer sql_variant type

2022-11-21 Thread Matt Burgess (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-5819:
---
Status: Patch Available  (was: In Progress)

> Support SQLServer sql_variant type
> --
>
> Key: NIFI-5819
> URL: https://issues.apache.org/jira/browse/NIFI-5819
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.8.0
>Reporter: Charlie Meyer
>Assignee: Matt Burgess
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If i run a query using executesqlrecord against a mssql database such as 
> {{SELECT SERVERPROPERTY ('ProductVersion') AS MajorVersion}} nifi logs the 
> following stack trace:
> {code:java}
> { "cause": { "cause": null, "stackTrace": [ { "methodName": "createSchema", 
> "fileName": "JdbcCommon.java", "lineNumber": 677, "className": 
> "org.apache.nifi.processors.standard.util.JdbcCommon", "nativeMethod": false 
> }, { "methodName": "writeResultSet", "fileName": "RecordSqlWriter.java", 
> "lineNumber": 68, "className": 
> "org.apache.nifi.processors.standard.sql.RecordSqlWriter", "nativeMethod": 
> false }, { "methodName": "lambda$onTrigger$1", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 362, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "write", "fileName": 
> "StandardProcessSession.java", "lineNumber": 2648, "className": 
> "org.apache.nifi.controller.repository.StandardProcessSession", 
> "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 360, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "AbstractProcessor.java", "lineNumber": 27, "className": 
> "org.apache.nifi.processor.AbstractProcessor", "nativeMethod": false }, { 
> "methodName": "onTrigger", "fileName": "StandardProcessorNode.java", 
> "lineNumber": 1165, "className": 
> "org.apache.nifi.controller.StandardProcessorNode", "nativeMethod": false }, 
> { "methodName": "invoke", "fileName": "ConnectableTask.java", "lineNumber": 
> 203, "className": "org.apache.nifi.controller.tasks.ConnectableTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "TimerDrivenSchedulingAgent.java", "lineNumber": 117, "className": 
> "org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1", 
> "nativeMethod": false }, { "methodName": "call", "fileName": 
> "Executors.java", "lineNumber": 511, "className": 
> "java.util.concurrent.Executors$RunnableAdapter", "nativeMethod": false }, { 
> "methodName": "runAndReset", "fileName": "FutureTask.java", "lineNumber": 
> 308, "className": "java.util.concurrent.FutureTask", "nativeMethod": false }, 
> { "methodName": "access$301", "fileName": "ScheduledThreadPoolExecutor.java", 
> "lineNumber": 180, "className": 
> "java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "ScheduledThreadPoolExecutor.java", "lineNumber": 294, "className": 
> "java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask", 
> "nativeMethod": false }, { "methodName": "runWorker", "fileName": 
> "ThreadPoolExecutor.java", "lineNumber": 1149, "className": 
> "java.util.concurrent.ThreadPoolExecutor", "nativeMethod": false }, { 
> "methodName": "run", "fileName": "ThreadPoolExecutor.java", "lineNumber": 
> 624, "className": "java.util.concurrent.ThreadPoolExecutor$Worker", 
> "nativeMethod": false }, { "methodName": "run", "fileName": "Thread.java", 
> "lineNumber": 748, "className": "java.lang.Thread", "nativeMethod": false } 
> ], "message": "createSchema: Unknown SQL type -156 / sql_variant (table: 
> NiFi_ExecuteSQL_Record, column: MajorVersion) cannot be converted to Avro 
> type", "localizedMessage": "createSchema: Unknown SQL type -156 / sql_variant 
> (table: NiFi_ExecuteSQL_Record, column: MajorVersion) cannot be converted to 
> Avro type", "suppressed": [] }, "stackTrace": [ { "methodName": 
> "lambda$onTrigger$1", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 364, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "write", "fileName": 
> "StandardProcessSession.java", "lineNumber": 2648, "className": 
> "org.apache.nifi.controller.repository.StandardProcessSession", 
> "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 360, 
> "className": 
> "com.civitaslearning.collect.nifi.proces

[GitHub] [nifi] mattyb149 opened a new pull request, #6699: NIFI-5819: Support SQLServer sql_variant type

2022-11-21 Thread GitBox


mattyb149 opened a new pull request, #6699:
URL: https://github.com/apache/nifi/pull/6699

   # Summary
   
   [NIFI-5819](https://issues.apache.org/jira/browse/NIFI-5819)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 8
 - [x] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10188) ConsumeEWS java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException

2022-11-21 Thread Matt Burgess (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-10188:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> ConsumeEWS  java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException
> -
>
> Key: NIFI-10188
> URL: https://issues.apache.org/jira/browse/NIFI-10188
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.16.2
> Environment: Java 11
> Cent OS 7
>Reporter: RAVINARAYAN SINGH
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I was trying to use ConsumeEWS processor with self hosted exchange  server 
> and i got following error 
> ConsumeEWS[id=327442d0-569a-1856--cabbf76f] Processing halted: 
> yielding [1 sec]: java.lang.NoClassDefFoundError: 
> javax/xml/ws/http/HTTPException
> - Caused by: java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10188) ConsumeEWS java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException

2022-11-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636930#comment-17636930
 ] 

ASF subversion and git services commented on NIFI-10188:


Commit 6b188636ff45c0380b6d3a08149ea5b342e8e5aa in nifi's branch 
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6b188636ff ]

NIFI-10188 Added jaxws-api for ConsumeEWS on Java 11

Signed-off-by: Matthew Burgess 

This closes #6697


> ConsumeEWS  java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException
> -
>
> Key: NIFI-10188
> URL: https://issues.apache.org/jira/browse/NIFI-10188
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.16.2
> Environment: Java 11
> Cent OS 7
>Reporter: RAVINARAYAN SINGH
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I was trying to use ConsumeEWS processor with self hosted exchange  server 
> and i got following error 
> ConsumeEWS[id=327442d0-569a-1856--cabbf76f] Processing halted: 
> yielding [1 sec]: java.lang.NoClassDefFoundError: 
> javax/xml/ws/http/HTTPException
> - Caused by: java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] mattyb149 closed pull request #6697: NIFI-10188 Add jaxws-api for ConsumeEWS on Java 11

2022-11-21 Thread GitBox


mattyb149 closed pull request #6697: NIFI-10188 Add jaxws-api for ConsumeEWS on 
Java 11
URL: https://github.com/apache/nifi/pull/6697


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (NIFI-9167) Refactor nifi-framework-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636928#comment-17636928
 ] 

Daniel Stieglitz edited comment on NIFI-9167 at 11/21/22 11:26 PM:
---

I broke down to these modules to how many files have org.junit.Test

nifi-framework-bundle/nifi-framework/nifi-authorizer 1 
nifi-framework-bundle/nifi-framework/nifi-client-dto 4 files
nifi-framework-bundle/nifi-framework-external-resource-utils 23 files
nifi-framework-bundle/nifi-framework/nifi-documentation 1 file
nifi-framework-bundle/nifi-framework/nifi-file-authorizer 3 files
nifi-framework-bundle/nifi-framework/nifi-framework-authorization 3 files
nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol 1 file
nifi-framework-bundle/nifi-framework/nifi-framework-components 14 files
nifi-framework-bundle/nifi-framework/nifi-framework-core-api 4 files
nifi-framework-bundle/nifi-framework/nifi-framework-core 83 files
nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils 1 file
nifi-framework-bundle/nifi-framework/nifi-framework-nar-utils 3 files
nifi-framework-bundle/nifi-framework/nifi-nar-utils 3 files
nifi-framework-bundle/nifi-framework/nifi-repository-models 2 files
nifi-framework-bundle/nifi-framework/nifi-shell-authorizer 1 file
nifi-framework-bundle/nifi-framework/nifi-site-to-site 10 files
nifi-framework-bundle/nifi-framework/nifi-standard-prioritizers 3 files
nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty 2 files
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api 62 file
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-error/ 1 file
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security 23 files


was (Author: JIRAUSER294662):
I broken down to these modules to how many files have org.junit.Test

nifi-framework-bundle/nifi-framework/nifi-authorizer 1 
nifi-framework-bundle/nifi-framework/nifi-client-dto 4 files
nifi-framework-bundle/nifi-framework-external-resource-utils 23 files
nifi-framework-bundle/nifi-framework/nifi-documentation 1 file
nifi-framework-bundle/nifi-framework/nifi-file-authorizer 3 files
nifi-framework-bundle/nifi-framework/nifi-framework-authorization 3 files
nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol 1 file
nifi-framework-bundle/nifi-framework/nifi-framework-components 14 files
nifi-framework-bundle/nifi-framework/nifi-framework-core-api 4 files
nifi-framework-bundle/nifi-framework/nifi-framework-core 83 files
nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils 1 file
nifi-framework-bundle/nifi-framework/nifi-framework-nar-utils 3 files
nifi-framework-bundle/nifi-framework/nifi-nar-utils 3 files
nifi-framework-bundle/nifi-framework/nifi-repository-models 2 files
nifi-framework-bundle/nifi-framework/nifi-shell-authorizer 1 file
nifi-framework-bundle/nifi-framework/nifi-site-to-site 10 files
nifi-framework-bundle/nifi-framework/nifi-standard-prioritizers 3 files
nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty 2 files
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api 62 file
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-error/ 1 file
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security 23 files

> Refactor nifi-framework-bundle to use JUnit 5
> -
>
> Key: NIFI-9167
> URL: https://issues.apache.org/jira/browse/NIFI-9167
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-9167) Refactor nifi-framework-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636928#comment-17636928
 ] 

Daniel Stieglitz commented on NIFI-9167:


I broken down to these modules to how many files have org.junit.Test

nifi-framework-bundle/nifi-framework/nifi-authorizer 1 
nifi-framework-bundle/nifi-framework/nifi-client-dto 4 files
nifi-framework-bundle/nifi-framework-external-resource-utils 23 files
nifi-framework-bundle/nifi-framework/nifi-documentation 1 file
nifi-framework-bundle/nifi-framework/nifi-file-authorizer 3 files
nifi-framework-bundle/nifi-framework/nifi-framework-authorization 3 files
nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol 1 file
nifi-framework-bundle/nifi-framework/nifi-framework-components 14 files
nifi-framework-bundle/nifi-framework/nifi-framework-core-api 4 files
nifi-framework-bundle/nifi-framework/nifi-framework-core 83 files
nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils 1 file
nifi-framework-bundle/nifi-framework/nifi-framework-nar-utils 3 files
nifi-framework-bundle/nifi-framework/nifi-nar-utils 3 files
nifi-framework-bundle/nifi-framework/nifi-repository-models 2 files
nifi-framework-bundle/nifi-framework/nifi-shell-authorizer 1 file
nifi-framework-bundle/nifi-framework/nifi-site-to-site 10 files
nifi-framework-bundle/nifi-framework/nifi-standard-prioritizers 3 files
nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty 2 files
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api 62 file
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-error/ 1 file
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security 23 files

> Refactor nifi-framework-bundle to use JUnit 5
> -
>
> Key: NIFI-9167
> URL: https://issues.apache.org/jira/browse/NIFI-9167
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] ruckc commented on a diff in pull request #6686: NIFI-10842 Adding option to disable HTTP2 in StandardOauth2AccessTokenProvider

2022-11-21 Thread GitBox


ruckc commented on code in PR #6686:
URL: https://github.com/apache/nifi/pull/6686#discussion_r1028604356


##
nifi-nar-bundles/nifi-standard-services/nifi-oauth2-provider-bundle/nifi-oauth2-provider-service/src/main/java/org/apache/nifi/oauth2/StandardOauth2AccessTokenProvider.java:
##
@@ -151,8 +152,18 @@ public class StandardOauth2AccessTokenProvider extends 
AbstractControllerService
 .required(false)
 .build();
 
+public static final PropertyDescriptor HTTP_PROTOCOL_STRATEGY = new 
PropertyDescriptor.Builder()
+.name("HTTP Protocols")
+.description("HTTP Protocols supported for Application Layer Protocol 
Negotiation with TLS")
+.required(true)
+.allowableValues(HttpProtocolStrategy.class)
+.defaultValue(HttpProtocolStrategy.HTTP_1_1.getValue())

Review Comment:
   Good catch, just fixed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-10855) Document Cross-Site Request Forgery Protection

2022-11-21 Thread David Handermann (Jira)
David Handermann created NIFI-10855:
---

 Summary: Document Cross-Site Request Forgery Protection
 Key: NIFI-10855
 URL: https://issues.apache.org/jira/browse/NIFI-10855
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core UI, Documentation & Website
Reporter: David Handermann
Assignee: David Handermann


Apache NiFi 1.15.0 included significant changes to web application security, 
including the introduction of Cross-Site Request Forgery protection using 
Spring Security Filters.

The CSRF configuration builds on the standard Spring Security Filter and 
provides a stateless implementation based on the [Double Submit Cookie 
Pattern|https://cheatsheetseries.owasp.org/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html#double-submit-cookie].
 The implementation maintains support for REST API access without cookies using 
the HTTP {{Authorization}} header, but documenting the implementation would 
provide additional background for clients integrating with the REST API.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-5819) Support SQLServer sql_variant type

2022-11-21 Thread Matt Burgess (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-5819:
---
Summary: Support SQLServer sql_variant type  (was: JDBCCommon does not 
handle converting SQLServer sql_variant type to avro)

> Support SQLServer sql_variant type
> --
>
> Key: NIFI-5819
> URL: https://issues.apache.org/jira/browse/NIFI-5819
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.8.0
>Reporter: Charlie Meyer
>Assignee: Matt Burgess
>Priority: Major
>
> If i run a query using executesqlrecord against a mssql database such as 
> {{SELECT SERVERPROPERTY ('ProductVersion') AS MajorVersion}} nifi logs the 
> following stack trace:
> {code:java}
> { "cause": { "cause": null, "stackTrace": [ { "methodName": "createSchema", 
> "fileName": "JdbcCommon.java", "lineNumber": 677, "className": 
> "org.apache.nifi.processors.standard.util.JdbcCommon", "nativeMethod": false 
> }, { "methodName": "writeResultSet", "fileName": "RecordSqlWriter.java", 
> "lineNumber": 68, "className": 
> "org.apache.nifi.processors.standard.sql.RecordSqlWriter", "nativeMethod": 
> false }, { "methodName": "lambda$onTrigger$1", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 362, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "write", "fileName": 
> "StandardProcessSession.java", "lineNumber": 2648, "className": 
> "org.apache.nifi.controller.repository.StandardProcessSession", 
> "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 360, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "AbstractProcessor.java", "lineNumber": 27, "className": 
> "org.apache.nifi.processor.AbstractProcessor", "nativeMethod": false }, { 
> "methodName": "onTrigger", "fileName": "StandardProcessorNode.java", 
> "lineNumber": 1165, "className": 
> "org.apache.nifi.controller.StandardProcessorNode", "nativeMethod": false }, 
> { "methodName": "invoke", "fileName": "ConnectableTask.java", "lineNumber": 
> 203, "className": "org.apache.nifi.controller.tasks.ConnectableTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "TimerDrivenSchedulingAgent.java", "lineNumber": 117, "className": 
> "org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1", 
> "nativeMethod": false }, { "methodName": "call", "fileName": 
> "Executors.java", "lineNumber": 511, "className": 
> "java.util.concurrent.Executors$RunnableAdapter", "nativeMethod": false }, { 
> "methodName": "runAndReset", "fileName": "FutureTask.java", "lineNumber": 
> 308, "className": "java.util.concurrent.FutureTask", "nativeMethod": false }, 
> { "methodName": "access$301", "fileName": "ScheduledThreadPoolExecutor.java", 
> "lineNumber": 180, "className": 
> "java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "ScheduledThreadPoolExecutor.java", "lineNumber": 294, "className": 
> "java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask", 
> "nativeMethod": false }, { "methodName": "runWorker", "fileName": 
> "ThreadPoolExecutor.java", "lineNumber": 1149, "className": 
> "java.util.concurrent.ThreadPoolExecutor", "nativeMethod": false }, { 
> "methodName": "run", "fileName": "ThreadPoolExecutor.java", "lineNumber": 
> 624, "className": "java.util.concurrent.ThreadPoolExecutor$Worker", 
> "nativeMethod": false }, { "methodName": "run", "fileName": "Thread.java", 
> "lineNumber": 748, "className": "java.lang.Thread", "nativeMethod": false } 
> ], "message": "createSchema: Unknown SQL type -156 / sql_variant (table: 
> NiFi_ExecuteSQL_Record, column: MajorVersion) cannot be converted to Avro 
> type", "localizedMessage": "createSchema: Unknown SQL type -156 / sql_variant 
> (table: NiFi_ExecuteSQL_Record, column: MajorVersion) cannot be converted to 
> Avro type", "suppressed": [] }, "stackTrace": [ { "methodName": 
> "lambda$onTrigger$1", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 364, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "write", "fileName": 
> "StandardProcessSession.java", "lineNumber": 2648, "className": 
> "org.apache.nifi.controller.repository.StandardProcessSession", 
> "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 360, 
> "className": 
> "com.civita

[jira] [Commented] (NIFI-9167) Refactor nifi-framework-bundle to use JUnit 5

2022-11-21 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636927#comment-17636927
 ] 

David Handermann commented on NIFI-9167:


Yes, creating sub-tasks under NIFI-9084 would be helpful.

> Refactor nifi-framework-bundle to use JUnit 5
> -
>
> Key: NIFI-9167
> URL: https://issues.apache.org/jira/browse/NIFI-9167
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-5819) JDBCCommon does not handle converting SQLServer sql_variant type to avro

2022-11-21 Thread Matt Burgess (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636926#comment-17636926
 ] 

Matt Burgess commented on NIFI-5819:


Turns out we need to provide a static schema for the values coming out of 
ExecuteSQLRecord/QueryDatabaseTable, so we can default to String instead of 
throwing an error; however it might lead to confusing results. I'm going to try 
with a union of all values and see if that helps.

> JDBCCommon does not handle converting SQLServer sql_variant type to avro
> 
>
> Key: NIFI-5819
> URL: https://issues.apache.org/jira/browse/NIFI-5819
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.8.0
>Reporter: Charlie Meyer
>Assignee: Matt Burgess
>Priority: Major
>
> If i run a query using executesqlrecord against a mssql database such as 
> {{SELECT SERVERPROPERTY ('ProductVersion') AS MajorVersion}} nifi logs the 
> following stack trace:
> {code:java}
> { "cause": { "cause": null, "stackTrace": [ { "methodName": "createSchema", 
> "fileName": "JdbcCommon.java", "lineNumber": 677, "className": 
> "org.apache.nifi.processors.standard.util.JdbcCommon", "nativeMethod": false 
> }, { "methodName": "writeResultSet", "fileName": "RecordSqlWriter.java", 
> "lineNumber": 68, "className": 
> "org.apache.nifi.processors.standard.sql.RecordSqlWriter", "nativeMethod": 
> false }, { "methodName": "lambda$onTrigger$1", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 362, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "write", "fileName": 
> "StandardProcessSession.java", "lineNumber": 2648, "className": 
> "org.apache.nifi.controller.repository.StandardProcessSession", 
> "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 360, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "AbstractProcessor.java", "lineNumber": 27, "className": 
> "org.apache.nifi.processor.AbstractProcessor", "nativeMethod": false }, { 
> "methodName": "onTrigger", "fileName": "StandardProcessorNode.java", 
> "lineNumber": 1165, "className": 
> "org.apache.nifi.controller.StandardProcessorNode", "nativeMethod": false }, 
> { "methodName": "invoke", "fileName": "ConnectableTask.java", "lineNumber": 
> 203, "className": "org.apache.nifi.controller.tasks.ConnectableTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "TimerDrivenSchedulingAgent.java", "lineNumber": 117, "className": 
> "org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1", 
> "nativeMethod": false }, { "methodName": "call", "fileName": 
> "Executors.java", "lineNumber": 511, "className": 
> "java.util.concurrent.Executors$RunnableAdapter", "nativeMethod": false }, { 
> "methodName": "runAndReset", "fileName": "FutureTask.java", "lineNumber": 
> 308, "className": "java.util.concurrent.FutureTask", "nativeMethod": false }, 
> { "methodName": "access$301", "fileName": "ScheduledThreadPoolExecutor.java", 
> "lineNumber": 180, "className": 
> "java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "ScheduledThreadPoolExecutor.java", "lineNumber": 294, "className": 
> "java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask", 
> "nativeMethod": false }, { "methodName": "runWorker", "fileName": 
> "ThreadPoolExecutor.java", "lineNumber": 1149, "className": 
> "java.util.concurrent.ThreadPoolExecutor", "nativeMethod": false }, { 
> "methodName": "run", "fileName": "ThreadPoolExecutor.java", "lineNumber": 
> 624, "className": "java.util.concurrent.ThreadPoolExecutor$Worker", 
> "nativeMethod": false }, { "methodName": "run", "fileName": "Thread.java", 
> "lineNumber": 748, "className": "java.lang.Thread", "nativeMethod": false } 
> ], "message": "createSchema: Unknown SQL type -156 / sql_variant (table: 
> NiFi_ExecuteSQL_Record, column: MajorVersion) cannot be converted to Avro 
> type", "localizedMessage": "createSchema: Unknown SQL type -156 / sql_variant 
> (table: NiFi_ExecuteSQL_Record, column: MajorVersion) cannot be converted to 
> Avro type", "suppressed": [] }, "stackTrace": [ { "methodName": 
> "lambda$onTrigger$1", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 364, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "write", "fileName": 
> "StandardProc

[jira] [Comment Edited] (NIFI-9167) Refactor nifi-framework-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636924#comment-17636924
 ] 

Daniel Stieglitz edited comment on NIFI-9167 at 11/21/22 11:13 PM:
---

[~exceptionfactory] So for the smaller subtasks would their parent ticket be 
this one or NIFI-9084?


was (Author: JIRAUSER294662):
[~exceptionfactory] So for the smaller subtasks would their parent ticket be 
this  or NIFI-9084?

> Refactor nifi-framework-bundle to use JUnit 5
> -
>
> Key: NIFI-9167
> URL: https://issues.apache.org/jira/browse/NIFI-9167
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-9167) Refactor nifi-framework-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636924#comment-17636924
 ] 

Daniel Stieglitz commented on NIFI-9167:


[~exceptionfactory] So for the smaller subtasks would their parent ticket be 
this  or NIFI-9084?

> Refactor nifi-framework-bundle to use JUnit 5
> -
>
> Key: NIFI-9167
> URL: https://issues.apache.org/jira/browse/NIFI-9167
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6686: NIFI-10842 Adding option to disable HTTP2 in StandardOauth2AccessTokenProvider

2022-11-21 Thread GitBox


exceptionfactory commented on code in PR #6686:
URL: https://github.com/apache/nifi/pull/6686#discussion_r1028591905


##
nifi-nar-bundles/nifi-standard-services/nifi-oauth2-provider-bundle/nifi-oauth2-provider-service/src/main/java/org/apache/nifi/oauth2/StandardOauth2AccessTokenProvider.java:
##
@@ -151,8 +152,18 @@ public class StandardOauth2AccessTokenProvider extends 
AbstractControllerService
 .required(false)
 .build();
 
+public static final PropertyDescriptor HTTP_PROTOCOL_STRATEGY = new 
PropertyDescriptor.Builder()
+.name("HTTP Protocols")
+.description("HTTP Protocols supported for Application Layer Protocol 
Negotiation with TLS")
+.required(true)
+.allowableValues(HttpProtocolStrategy.class)
+.defaultValue(HttpProtocolStrategy.HTTP_1_1.getValue())

Review Comment:
   The default value should be `H2_HTTP_1_1` to maintain the current behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (NIFI-5819) JDBCCommon does not handle converting SQLServer sql_variant type to avro

2022-11-21 Thread Matt Burgess (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess reassigned NIFI-5819:
--

Assignee: Matt Burgess

> JDBCCommon does not handle converting SQLServer sql_variant type to avro
> 
>
> Key: NIFI-5819
> URL: https://issues.apache.org/jira/browse/NIFI-5819
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.8.0
>Reporter: Charlie Meyer
>Assignee: Matt Burgess
>Priority: Major
>
> If i run a query using executesqlrecord against a mssql database such as 
> {{SELECT SERVERPROPERTY ('ProductVersion') AS MajorVersion}} nifi logs the 
> following stack trace:
> {code:java}
> { "cause": { "cause": null, "stackTrace": [ { "methodName": "createSchema", 
> "fileName": "JdbcCommon.java", "lineNumber": 677, "className": 
> "org.apache.nifi.processors.standard.util.JdbcCommon", "nativeMethod": false 
> }, { "methodName": "writeResultSet", "fileName": "RecordSqlWriter.java", 
> "lineNumber": 68, "className": 
> "org.apache.nifi.processors.standard.sql.RecordSqlWriter", "nativeMethod": 
> false }, { "methodName": "lambda$onTrigger$1", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 362, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "write", "fileName": 
> "StandardProcessSession.java", "lineNumber": 2648, "className": 
> "org.apache.nifi.controller.repository.StandardProcessSession", 
> "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 360, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "AbstractProcessor.java", "lineNumber": 27, "className": 
> "org.apache.nifi.processor.AbstractProcessor", "nativeMethod": false }, { 
> "methodName": "onTrigger", "fileName": "StandardProcessorNode.java", 
> "lineNumber": 1165, "className": 
> "org.apache.nifi.controller.StandardProcessorNode", "nativeMethod": false }, 
> { "methodName": "invoke", "fileName": "ConnectableTask.java", "lineNumber": 
> 203, "className": "org.apache.nifi.controller.tasks.ConnectableTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "TimerDrivenSchedulingAgent.java", "lineNumber": 117, "className": 
> "org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1", 
> "nativeMethod": false }, { "methodName": "call", "fileName": 
> "Executors.java", "lineNumber": 511, "className": 
> "java.util.concurrent.Executors$RunnableAdapter", "nativeMethod": false }, { 
> "methodName": "runAndReset", "fileName": "FutureTask.java", "lineNumber": 
> 308, "className": "java.util.concurrent.FutureTask", "nativeMethod": false }, 
> { "methodName": "access$301", "fileName": "ScheduledThreadPoolExecutor.java", 
> "lineNumber": 180, "className": 
> "java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "ScheduledThreadPoolExecutor.java", "lineNumber": 294, "className": 
> "java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask", 
> "nativeMethod": false }, { "methodName": "runWorker", "fileName": 
> "ThreadPoolExecutor.java", "lineNumber": 1149, "className": 
> "java.util.concurrent.ThreadPoolExecutor", "nativeMethod": false }, { 
> "methodName": "run", "fileName": "ThreadPoolExecutor.java", "lineNumber": 
> 624, "className": "java.util.concurrent.ThreadPoolExecutor$Worker", 
> "nativeMethod": false }, { "methodName": "run", "fileName": "Thread.java", 
> "lineNumber": 748, "className": "java.lang.Thread", "nativeMethod": false } 
> ], "message": "createSchema: Unknown SQL type -156 / sql_variant (table: 
> NiFi_ExecuteSQL_Record, column: MajorVersion) cannot be converted to Avro 
> type", "localizedMessage": "createSchema: Unknown SQL type -156 / sql_variant 
> (table: NiFi_ExecuteSQL_Record, column: MajorVersion) cannot be converted to 
> Avro type", "suppressed": [] }, "stackTrace": [ { "methodName": 
> "lambda$onTrigger$1", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 364, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "write", "fileName": 
> "StandardProcessSession.java", "lineNumber": 2648, "className": 
> "org.apache.nifi.controller.repository.StandardProcessSession", 
> "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 360, 
> "className": 
> "com.civitaslearning.collect.ni

[jira] [Updated] (NIFI-9107) Refactor nifi-enrich-bundle to use JUnit 5

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-9107:
---
Fix Version/s: 1.19.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Refactor nifi-enrich-bundle to use JUnit 5
> --
>
> Key: NIFI-9107
> URL: https://issues.apache.org/jira/browse/NIFI-9107
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Daniel Stieglitz
>Priority: Minor
> Fix For: 1.19.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-9107) Refactor nifi-enrich-bundle to use JUnit 5

2022-11-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636917#comment-17636917
 ] 

ASF subversion and git services commented on NIFI-9107:
---

Commit 844f311c523cbc9e5b34b68c2d9642d65cf7fd23 in nifi's branch 
refs/heads/main from dan-s1
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=844f311c52 ]

NIFI-9107 Converted remaining nifi-enrich-bundle tests from JUnit 4 to 5

This closes #6698

Signed-off-by: David Handermann 


> Refactor nifi-enrich-bundle to use JUnit 5
> --
>
> Key: NIFI-9107
> URL: https://issues.apache.org/jira/browse/NIFI-9107
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Daniel Stieglitz
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory closed pull request #6698: [NIFI-9107] Made changes to convert from JUnit 4 to JUnit 5

2022-11-21 Thread GitBox


exceptionfactory closed pull request #6698: [NIFI-9107] Made changes to convert 
from JUnit 4 to JUnit 5
URL: https://github.com/apache/nifi/pull/6698


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-9165) Refactor nifi-standard-bundle to use JUnit 5

2022-11-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636914#comment-17636914
 ] 

ASF subversion and git services commented on NIFI-9165:
---

Commit f3d2dfaf5cfdf90c660bb787a2719773aff9c356 in nifi's branch 
refs/heads/main from dan-s1
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f3d2dfaf5c ]

NIFI-9165 Converted remaining nifi-standard-bundle tests from JUnit 4 to JUnit 5

This closes #6696

Signed-off-by: David Handermann 


> Refactor nifi-standard-bundle to use JUnit 5
> 
>
> Key: NIFI-9165
> URL: https://issues.apache.org/jira/browse/NIFI-9165
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Daniel Stieglitz
>Priority: Minor
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-9165) Refactor nifi-standard-bundle to use JUnit 5

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-9165:
---
Fix Version/s: 1.19.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Refactor nifi-standard-bundle to use JUnit 5
> 
>
> Key: NIFI-9165
> URL: https://issues.apache.org/jira/browse/NIFI-9165
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Daniel Stieglitz
>Priority: Minor
> Fix For: 1.19.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory closed pull request #6696: [NIFI-9165] Made changes to convert from JUnit 4 to JUnit 5

2022-11-21 Thread GitBox


exceptionfactory closed pull request #6696: [NIFI-9165] Made changes to convert 
from JUnit 4 to JUnit 5
URL: https://github.com/apache/nifi/pull/6696


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-11-21 Thread GitBox


exceptionfactory commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1322758227

   Thanks the contribution @dan-s1, the general approach makes sense on a 
cursory review, but I would like to take a closer look, so I don't think this 
will make it in to 1.19.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10851) On update to controller service reference in processor configuration, ensure removal of old reference

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10851:

Component/s: Core Framework

> On update to controller service reference in processor configuration, ensure 
> removal of old reference
> -
>
> Key: NIFI-10851
> URL: https://issues.apache.org/jira/browse/NIFI-10851
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> https://lists.apache.org/thread/jjjopqndrp9y6dzdnjxsdfhw2ofjh469
> {quote}I'm using NiFi 1.18.0, and I use the controller services configure, 
> enable or disable screen, to determine what processors is using it. That way 
> I can determine if I can delete the controller service or not. Or, if I have 
> to migrate from 1 controller service to a controller service in a processor 
> group. (For instance, my flow gets too big, so I move the processors to a 
> group, but the controller services stay at the root level.) (That way I can 
> know for sure a controller service can get deleted because nothing is using 
> it, rather than deleting the controller service and having to find all 
> processors after the fact that are now invalid because of that.)
> To test this, I was able to do the following. Create a processor group, add 
> ConvertRecord in the group, and choose a standard AvroReader as the service 
> at the root level. Name all of them for uniqueness. Copy the processor group, 
> go into the ConvertRecord and choose a new processor group level AvroReader, 
> and name these items uniquely as well. Go back to the root level and look at 
> the root AvroReader, and it was showing both ConvertRecords, even the one in 
> the copied group that has a new AvroReader in it.
> I just tried that test in a 1.9.0 NiFi instance, and it didn't have the same 
> problem.{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10851) On update to controller service reference in processor configuration, ensure removal of old reference

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10851:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> On update to controller service reference in processor configuration, ensure 
> removal of old reference
> -
>
> Key: NIFI-10851
> URL: https://issues.apache.org/jira/browse/NIFI-10851
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> https://lists.apache.org/thread/jjjopqndrp9y6dzdnjxsdfhw2ofjh469
> {quote}I'm using NiFi 1.18.0, and I use the controller services configure, 
> enable or disable screen, to determine what processors is using it. That way 
> I can determine if I can delete the controller service or not. Or, if I have 
> to migrate from 1 controller service to a controller service in a processor 
> group. (For instance, my flow gets too big, so I move the processors to a 
> group, but the controller services stay at the root level.) (That way I can 
> know for sure a controller service can get deleted because nothing is using 
> it, rather than deleting the controller service and having to find all 
> processors after the fact that are now invalid because of that.)
> To test this, I was able to do the following. Create a processor group, add 
> ConvertRecord in the group, and choose a standard AvroReader as the service 
> at the root level. Name all of them for uniqueness. Copy the processor group, 
> go into the ConvertRecord and choose a new processor group level AvroReader, 
> and name these items uniquely as well. Go back to the root level and look at 
> the root AvroReader, and it was showing both ConvertRecords, even the one in 
> the copied group that has a new AvroReader in it.
> I just tried that test in a 1.9.0 NiFi instance, and it didn't have the same 
> problem.{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10851) On update to controller service reference in processor configuration, ensure removal of old reference

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10851:

Priority: Major  (was: Minor)

> On update to controller service reference in processor configuration, ensure 
> removal of old reference
> -
>
> Key: NIFI-10851
> URL: https://issues.apache.org/jira/browse/NIFI-10851
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> https://lists.apache.org/thread/jjjopqndrp9y6dzdnjxsdfhw2ofjh469
> {quote}I'm using NiFi 1.18.0, and I use the controller services configure, 
> enable or disable screen, to determine what processors is using it. That way 
> I can determine if I can delete the controller service or not. Or, if I have 
> to migrate from 1 controller service to a controller service in a processor 
> group. (For instance, my flow gets too big, so I move the processors to a 
> group, but the controller services stay at the root level.) (That way I can 
> know for sure a controller service can get deleted because nothing is using 
> it, rather than deleting the controller service and having to find all 
> processors after the fact that are now invalid because of that.)
> To test this, I was able to do the following. Create a processor group, add 
> ConvertRecord in the group, and choose a standard AvroReader as the service 
> at the root level. Name all of them for uniqueness. Copy the processor group, 
> go into the ConvertRecord and choose a new processor group level AvroReader, 
> and name these items uniquely as well. Go back to the root level and look at 
> the root AvroReader, and it was showing both ConvertRecords, even the one in 
> the copied group that has a new AvroReader in it.
> I just tried that test in a 1.9.0 NiFi instance, and it didn't have the same 
> problem.{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10851) On update to controller service reference in processor configuration, ensure removal of old reference

2022-11-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636910#comment-17636910
 ] 

ASF subversion and git services commented on NIFI-10851:


Commit 620b7365c2ed0bc741920d5208d733f540795b16 in nifi's branch 
refs/heads/main from Paul Grey
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=620b7365c2 ]

NIFI-10851 Corrected removal of Controller Service references on property 
updates

- Convert unit test to JUnit 5

This closes #6695

Signed-off-by: David Handermann 


> On update to controller service reference in processor configuration, ensure 
> removal of old reference
> -
>
> Key: NIFI-10851
> URL: https://issues.apache.org/jira/browse/NIFI-10851
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Minor
> Fix For: 1.19.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> https://lists.apache.org/thread/jjjopqndrp9y6dzdnjxsdfhw2ofjh469
> {quote}I'm using NiFi 1.18.0, and I use the controller services configure, 
> enable or disable screen, to determine what processors is using it. That way 
> I can determine if I can delete the controller service or not. Or, if I have 
> to migrate from 1 controller service to a controller service in a processor 
> group. (For instance, my flow gets too big, so I move the processors to a 
> group, but the controller services stay at the root level.) (That way I can 
> know for sure a controller service can get deleted because nothing is using 
> it, rather than deleting the controller service and having to find all 
> processors after the fact that are now invalid because of that.)
> To test this, I was able to do the following. Create a processor group, add 
> ConvertRecord in the group, and choose a standard AvroReader as the service 
> at the root level. Name all of them for uniqueness. Copy the processor group, 
> go into the ConvertRecord and choose a new processor group level AvroReader, 
> and name these items uniquely as well. Go back to the root level and look at 
> the root AvroReader, and it was showing both ConvertRecords, even the one in 
> the copied group that has a new AvroReader in it.
> I just tried that test in a 1.9.0 NiFi instance, and it didn't have the same 
> problem.{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory closed pull request #6695: NIFI-10851 - On update to controller service reference in processor c…

2022-11-21 Thread GitBox


exceptionfactory closed pull request #6695: NIFI-10851 - On update to 
controller service reference in processor c…
URL: https://github.com/apache/nifi/pull/6695


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] thenatog commented on a diff in pull request #6637: NIFI-10177: implemented ID token logout and revoke access token logou…

2022-11-21 Thread GitBox


thenatog commented on code in PR #6637:
URL: https://github.com/apache/nifi/pull/6637#discussion_r1028579874


##
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/AccessResource.java:
##
@@ -832,4 +950,133 @@ private boolean isBasicLoginSupported(HttpServletRequest 
request) {
 private boolean isOIDCLoginSupported(HttpServletRequest request) {
 return request.isSecure() && oidcService != null && 
oidcService.isOidcEnabled();
 }
+
+private String determineLogoutMethod() {
+if (oidcService.getEndSessionEndpoint() != null) {
+return ID_TOKEN_LOGOUT;
+} else if (oidcService.getRevocationEndpoint() != null) {
+return REVOKE_ACCESS_TOKEN_LOGOUT;
+} else {
+return STANDARD_LOGOUT;
+}
+}
+
+/**
+ * Generates the request Authorization URI for the OpenID Connect 
Provider. Returns an authorization
+ * URI using the provided callback URI.
+ *
+ * @param httpServletResponse the servlet response
+ * @param callback the OIDC callback URI
+ * @return the authorization URI
+ */
+private URI oidcRequestAuthorizationCode(@Context final 
HttpServletResponse httpServletResponse, final String callback) {
+final String oidcRequestIdentifier = UUID.randomUUID().toString();
+// generate a cookie to associate this login sequence
+final Cookie cookie = new Cookie(OIDC_REQUEST_IDENTIFIER, 
oidcRequestIdentifier);
+cookie.setPath("/");
+cookie.setHttpOnly(true);
+cookie.setMaxAge(60);
+cookie.setSecure(true);
+httpServletResponse.addCookie(cookie);
+
+// get the state for this request
+final State state = oidcService.createState(oidcRequestIdentifier);
+
+// build the authorization uri
+final URI authorizationUri = 
UriBuilder.fromUri(oidcService.getAuthorizationEndpoint())
+.queryParam("client_id", oidcService.getClientId())
+.queryParam("response_type", "code")
+.queryParam("scope", oidcService.getScope().toString())
+.queryParam("state", state.getValue())
+.queryParam("redirect_uri", callback)
+.build();
+return authorizationUri;
+}
+
+private String getOidcRequestIdentifier(final HttpServletRequest 
httpServletRequest) {
+return getCookieValue(httpServletRequest.getCookies(), 
OIDC_REQUEST_IDENTIFIER);
+}
+
+private com.nimbusds.openid.connect.sdk.AuthenticationResponse 
parseAuthenticationResponse(final URI requestUri,

Review Comment:
   I see now that AuthenticationResponse is a more general class used by all of 
our authn providers and is not logically equivalent to the nimbusds class, so I 
guess we'll leave these things as they are and plan that it will be removed 
when we migrate to use Spring for OIDC.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-9107) Refactor nifi-enrich-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Stieglitz updated NIFI-9107:
---
Status: Patch Available  (was: Open)

> Refactor nifi-enrich-bundle to use JUnit 5
> --
>
> Key: NIFI-9107
> URL: https://issues.apache.org/jira/browse/NIFI-9107
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Daniel Stieglitz
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] dan-s1 opened a new pull request, #6698: [NIFI-9107] Made changes to convert from JUnit 4 to JUnit 5

2022-11-21 Thread GitBox


dan-s1 opened a new pull request, #6698:
URL: https://github.com/apache/nifi/pull/6698

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-9107](https://issues.apache.org/jira/browse/NIFI-9107)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] mattyb149 commented on pull request #6697: NIFI-10188 Add jaxws-api for ConsumeEWS on Java 11

2022-11-21 Thread GitBox


mattyb149 commented on PR #6697:
URL: https://github.com/apache/nifi/pull/6697#issuecomment-1322737850

   +1 LGTM, will merge after Github Actions have completed. Thanks for the fix!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10851) On update to controller service reference in processor configuration, ensure removal of old reference

2022-11-21 Thread Nathan Gough (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nathan Gough updated NIFI-10851:

Description: 
https://lists.apache.org/thread/jjjopqndrp9y6dzdnjxsdfhw2ofjh469

{quote}I'm using NiFi 1.18.0, and I use the controller services configure, 
enable or disable screen, to determine what processors is using it. That way I 
can determine if I can delete the controller service or not. Or, if I have to 
migrate from 1 controller service to a controller service in a processor group. 
(For instance, my flow gets too big, so I move the processors to a group, but 
the controller services stay at the root level.) (That way I can know for sure 
a controller service can get deleted because nothing is using it, rather than 
deleting the controller service and having to find all processors after the 
fact that are now invalid because of that.)

To test this, I was able to do the following. Create a processor group, add 
ConvertRecord in the group, and choose a standard AvroReader as the service at 
the root level. Name all of them for uniqueness. Copy the processor group, go 
into the ConvertRecord and choose a new processor group level AvroReader, and 
name these items uniquely as well. Go back to the root level and look at the 
root AvroReader, and it was showing both ConvertRecords, even the one in the 
copied group that has a new AvroReader in it.

I just tried that test in a 1.9.0 NiFi instance, and it didn't have the same 
problem.{quote}


  was:https://lists.apache.org/thread/jjjopqndrp9y6dzdnjxsdfhw2ofjh469


> On update to controller service reference in processor configuration, ensure 
> removal of old reference
> -
>
> Key: NIFI-10851
> URL: https://issues.apache.org/jira/browse/NIFI-10851
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Minor
> Fix For: 1.19.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> https://lists.apache.org/thread/jjjopqndrp9y6dzdnjxsdfhw2ofjh469
> {quote}I'm using NiFi 1.18.0, and I use the controller services configure, 
> enable or disable screen, to determine what processors is using it. That way 
> I can determine if I can delete the controller service or not. Or, if I have 
> to migrate from 1 controller service to a controller service in a processor 
> group. (For instance, my flow gets too big, so I move the processors to a 
> group, but the controller services stay at the root level.) (That way I can 
> know for sure a controller service can get deleted because nothing is using 
> it, rather than deleting the controller service and having to find all 
> processors after the fact that are now invalid because of that.)
> To test this, I was able to do the following. Create a processor group, add 
> ConvertRecord in the group, and choose a standard AvroReader as the service 
> at the root level. Name all of them for uniqueness. Copy the processor group, 
> go into the ConvertRecord and choose a new processor group level AvroReader, 
> and name these items uniquely as well. Go back to the root level and look at 
> the root AvroReader, and it was showing both ConvertRecords, even the one in 
> the copied group that has a new AvroReader in it.
> I just tried that test in a 1.9.0 NiFi instance, and it didn't have the same 
> problem.{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10188) ConsumeEWS java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException

2022-11-21 Thread Joe Witt (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Witt updated NIFI-10188:

Fix Version/s: 1.19.0

> ConsumeEWS  java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException
> -
>
> Key: NIFI-10188
> URL: https://issues.apache.org/jira/browse/NIFI-10188
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.16.2
> Environment: Java 11
> Cent OS 7
>Reporter: RAVINARAYAN SINGH
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> I was trying to use ConsumeEWS processor with self hosted exchange  server 
> and i got following error 
> ConsumeEWS[id=327442d0-569a-1856--cabbf76f] Processing halted: 
> yielding [1 sec]: java.lang.NoClassDefFoundError: 
> javax/xml/ws/http/HTTPException
> - Caused by: java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (NIFI-5819) JDBCCommon does not handle converting SQLServer sql_variant type to avro

2022-11-21 Thread Matt Burgess (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636906#comment-17636906
 ] 

Matt Burgess edited comment on NIFI-5819 at 11/21/22 10:26 PM:
---

I'm not sure we should try to convert all unknown SQL types to String; however 
we do have handling already in place for custom SQL types from Oracle 
(timestamps for example). This is also a problem with PutDatabaseRecord but not 
in the same section of code, and not for the same exact reason. One thing that 
is highly unfortunate is that the driver has a different mapping of SQL types 
than the server, such as -150 instead of -156 for sql_variant and 93 instead of 
-150 for SMALLDATETIME. Since there is precedence for adding custom SQL types 
ad-hoc, we can look at adding handling of this type as well. However for 
sql_variant we may want to try to do something smarter than assuming a String 
since any value can go in, perhaps we fall back to use the RecordFieldType of 
the NiFi record field instead of the SQL type when setting parameters, or 
something like that.


was (Author: mattyb149):
I'm not sure we should try to convert all unknown SQL types to String; however 
we do have handling already in place for custom SQL types from Oracle 
(timestamps for example). This is also a problem with PutDatabaseRecord but not 
in the same section of code, and not for the same exact reason. One thing that 
is highly unfortunate is that the driver has a different mapping of SQL types 
than the server, such as -150 instead of -156 for sql_variant and 93 instead of 
-150 for SMALLDATETIME. Since there is precedence for adding custom SQL types 
ad-hoc, we can look at adding handling of this type as well. However for 
sql_variant we may want to try to do something smarter than assuming a String 
since any value can go in, perhaps we fall back to use the RecordFieldType of 
the NiFi record field instead of the SQL type when setting parameters, or 
something like that.{-}

> JDBCCommon does not handle converting SQLServer sql_variant type to avro
> 
>
> Key: NIFI-5819
> URL: https://issues.apache.org/jira/browse/NIFI-5819
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.8.0
>Reporter: Charlie Meyer
>Priority: Major
>
> If i run a query using executesqlrecord against a mssql database such as 
> {{SELECT SERVERPROPERTY ('ProductVersion') AS MajorVersion}} nifi logs the 
> following stack trace:
> {code:java}
> { "cause": { "cause": null, "stackTrace": [ { "methodName": "createSchema", 
> "fileName": "JdbcCommon.java", "lineNumber": 677, "className": 
> "org.apache.nifi.processors.standard.util.JdbcCommon", "nativeMethod": false 
> }, { "methodName": "writeResultSet", "fileName": "RecordSqlWriter.java", 
> "lineNumber": 68, "className": 
> "org.apache.nifi.processors.standard.sql.RecordSqlWriter", "nativeMethod": 
> false }, { "methodName": "lambda$onTrigger$1", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 362, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "write", "fileName": 
> "StandardProcessSession.java", "lineNumber": 2648, "className": 
> "org.apache.nifi.controller.repository.StandardProcessSession", 
> "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 360, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "AbstractProcessor.java", "lineNumber": 27, "className": 
> "org.apache.nifi.processor.AbstractProcessor", "nativeMethod": false }, { 
> "methodName": "onTrigger", "fileName": "StandardProcessorNode.java", 
> "lineNumber": 1165, "className": 
> "org.apache.nifi.controller.StandardProcessorNode", "nativeMethod": false }, 
> { "methodName": "invoke", "fileName": "ConnectableTask.java", "lineNumber": 
> 203, "className": "org.apache.nifi.controller.tasks.ConnectableTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "TimerDrivenSchedulingAgent.java", "lineNumber": 117, "className": 
> "org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1", 
> "nativeMethod": false }, { "methodName": "call", "fileName": 
> "Executors.java", "lineNumber": 511, "className": 
> "java.util.concurrent.Executors$RunnableAdapter", "nativeMethod": false }, { 
> "methodName": "runAndReset", "fileName": "FutureTask.java", "lineNumber": 
> 308, "className": "java.util.concurrent.FutureTask", "nativeMethod": false }, 
> { "methodName": "access$301", "fileName": "ScheduledThreadP

[jira] [Comment Edited] (NIFI-5819) JDBCCommon does not handle converting SQLServer sql_variant type to avro

2022-11-21 Thread Matt Burgess (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636906#comment-17636906
 ] 

Matt Burgess edited comment on NIFI-5819 at 11/21/22 10:26 PM:
---

I'm not sure we should try to convert all unknown SQL types to String; however 
we do have handling already in place for custom SQL types from Oracle 
(timestamps for example). This is also a problem with PutDatabaseRecord but not 
in the same section of code, and not for the same exact reason. One thing that 
is highly unfortunate is that the driver has a different mapping of SQL types 
than the server, such as -150 instead of -156 for sql_variant and 93 instead of 
-150 for SMALLDATETIME. Since there is precedence for adding custom SQL types 
ad-hoc, we can look at adding handling of this type as well. However for 
sql_variant we may want to try to do something smarter than assuming a String 
since any value can go in, perhaps we fall back to use the RecordFieldType of 
the NiFi record field instead of the SQL type when setting parameters, or 
something like that.{-}


was (Author: mattyb149):
I'm not sure we should try to convert all unknown SQL types to String; however 
we do have handling already in place for custom SQL types from Oracle 
(timestamps for example). This is also a problem with PutDatabaseRecord but not 
in the same section of code, and not for the same exact reason. One thing that 
is highly unfortunate is that the driver has a different mapping of SQL types 
than the server, such as -150 instead of -156 for sql_variant and 93 instead of 
-150 for SMALLDATETIME. Since there is precedence for adding custom SQL types 
ad-hoc, we can look at adding handling of this type as well. However for 
sql_variant we may want to try to do something smarter than assuming a String 
since any value can go in, perhaps we fall back to use the RecordFieldType of 
the NiFi record field instead of the SQL type when setting parameters, or 
something like that.-

> JDBCCommon does not handle converting SQLServer sql_variant type to avro
> 
>
> Key: NIFI-5819
> URL: https://issues.apache.org/jira/browse/NIFI-5819
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.8.0
>Reporter: Charlie Meyer
>Priority: Major
>
> If i run a query using executesqlrecord against a mssql database such as 
> {{SELECT SERVERPROPERTY ('ProductVersion') AS MajorVersion}} nifi logs the 
> following stack trace:
> {code:java}
> { "cause": { "cause": null, "stackTrace": [ { "methodName": "createSchema", 
> "fileName": "JdbcCommon.java", "lineNumber": 677, "className": 
> "org.apache.nifi.processors.standard.util.JdbcCommon", "nativeMethod": false 
> }, { "methodName": "writeResultSet", "fileName": "RecordSqlWriter.java", 
> "lineNumber": 68, "className": 
> "org.apache.nifi.processors.standard.sql.RecordSqlWriter", "nativeMethod": 
> false }, { "methodName": "lambda$onTrigger$1", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 362, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "write", "fileName": 
> "StandardProcessSession.java", "lineNumber": 2648, "className": 
> "org.apache.nifi.controller.repository.StandardProcessSession", 
> "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 360, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "AbstractProcessor.java", "lineNumber": 27, "className": 
> "org.apache.nifi.processor.AbstractProcessor", "nativeMethod": false }, { 
> "methodName": "onTrigger", "fileName": "StandardProcessorNode.java", 
> "lineNumber": 1165, "className": 
> "org.apache.nifi.controller.StandardProcessorNode", "nativeMethod": false }, 
> { "methodName": "invoke", "fileName": "ConnectableTask.java", "lineNumber": 
> 203, "className": "org.apache.nifi.controller.tasks.ConnectableTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "TimerDrivenSchedulingAgent.java", "lineNumber": 117, "className": 
> "org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1", 
> "nativeMethod": false }, { "methodName": "call", "fileName": 
> "Executors.java", "lineNumber": 511, "className": 
> "java.util.concurrent.Executors$RunnableAdapter", "nativeMethod": false }, { 
> "methodName": "runAndReset", "fileName": "FutureTask.java", "lineNumber": 
> 308, "className": "java.util.concurrent.FutureTask", "nativeMethod": false }, 
> { "methodName": "access$301", "fileName": "ScheduledThread

[jira] [Commented] (NIFI-5819) JDBCCommon does not handle converting SQLServer sql_variant type to avro

2022-11-21 Thread Matt Burgess (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636906#comment-17636906
 ] 

Matt Burgess commented on NIFI-5819:


I'm not sure we should try to convert all unknown SQL types to String; however 
we do have handling already in place for custom SQL types from Oracle 
(timestamps for example). This is also a problem with PutDatabaseRecord but not 
in the same section of code, and not for the same exact reason. One thing that 
is highly unfortunate is that the driver has a different mapping of SQL types 
than the server, such as -150 instead of -156 for sql_variant and 93 instead of 
-150 for SMALLDATETIME. Since there is precedence for adding custom SQL types 
ad-hoc, we can look at adding handling of this type as well. However for 
sql_variant we may want to try to do something smarter than assuming a String 
since any value can go in, perhaps we fall back to use the RecordFieldType of 
the NiFi record field instead of the SQL type when setting parameters, or 
something like that.-

> JDBCCommon does not handle converting SQLServer sql_variant type to avro
> 
>
> Key: NIFI-5819
> URL: https://issues.apache.org/jira/browse/NIFI-5819
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.8.0
>Reporter: Charlie Meyer
>Priority: Major
>
> If i run a query using executesqlrecord against a mssql database such as 
> {{SELECT SERVERPROPERTY ('ProductVersion') AS MajorVersion}} nifi logs the 
> following stack trace:
> {code:java}
> { "cause": { "cause": null, "stackTrace": [ { "methodName": "createSchema", 
> "fileName": "JdbcCommon.java", "lineNumber": 677, "className": 
> "org.apache.nifi.processors.standard.util.JdbcCommon", "nativeMethod": false 
> }, { "methodName": "writeResultSet", "fileName": "RecordSqlWriter.java", 
> "lineNumber": 68, "className": 
> "org.apache.nifi.processors.standard.sql.RecordSqlWriter", "nativeMethod": 
> false }, { "methodName": "lambda$onTrigger$1", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 362, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "write", "fileName": 
> "StandardProcessSession.java", "lineNumber": 2648, "className": 
> "org.apache.nifi.controller.repository.StandardProcessSession", 
> "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "ExecuteSqlRecordWithoutSwallowingErrors.java", "lineNumber": 360, 
> "className": 
> "com.civitaslearning.collect.nifi.processor.ExecuteSqlRecordWithoutSwallowingErrors",
>  "nativeMethod": false }, { "methodName": "onTrigger", "fileName": 
> "AbstractProcessor.java", "lineNumber": 27, "className": 
> "org.apache.nifi.processor.AbstractProcessor", "nativeMethod": false }, { 
> "methodName": "onTrigger", "fileName": "StandardProcessorNode.java", 
> "lineNumber": 1165, "className": 
> "org.apache.nifi.controller.StandardProcessorNode", "nativeMethod": false }, 
> { "methodName": "invoke", "fileName": "ConnectableTask.java", "lineNumber": 
> 203, "className": "org.apache.nifi.controller.tasks.ConnectableTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "TimerDrivenSchedulingAgent.java", "lineNumber": 117, "className": 
> "org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1", 
> "nativeMethod": false }, { "methodName": "call", "fileName": 
> "Executors.java", "lineNumber": 511, "className": 
> "java.util.concurrent.Executors$RunnableAdapter", "nativeMethod": false }, { 
> "methodName": "runAndReset", "fileName": "FutureTask.java", "lineNumber": 
> 308, "className": "java.util.concurrent.FutureTask", "nativeMethod": false }, 
> { "methodName": "access$301", "fileName": "ScheduledThreadPoolExecutor.java", 
> "lineNumber": 180, "className": 
> "java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask", 
> "nativeMethod": false }, { "methodName": "run", "fileName": 
> "ScheduledThreadPoolExecutor.java", "lineNumber": 294, "className": 
> "java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask", 
> "nativeMethod": false }, { "methodName": "runWorker", "fileName": 
> "ThreadPoolExecutor.java", "lineNumber": 1149, "className": 
> "java.util.concurrent.ThreadPoolExecutor", "nativeMethod": false }, { 
> "methodName": "run", "fileName": "ThreadPoolExecutor.java", "lineNumber": 
> 624, "className": "java.util.concurrent.ThreadPoolExecutor$Worker", 
> "nativeMethod": false }, { "methodName": "run", "fileName": "Thread.java", 
> "lineNumber": 748, "className": "java.lang.Thread", "nativeMethod": false } 
> ], "message": "createSchema: Unknown SQL type -156 / sql_variant (table: 
> NiFi_ExecuteSQL_Record, column: Ma

[jira] [Created] (NIFI-10854) Conduct Apache NiFi 1.19.0 Release

2022-11-21 Thread Joe Witt (Jira)
Joe Witt created NIFI-10854:
---

 Summary: Conduct Apache NiFi 1.19.0 Release
 Key: NIFI-10854
 URL: https://issues.apache.org/jira/browse/NIFI-10854
 Project: Apache NiFi
  Issue Type: Task
Reporter: Joe Witt
Assignee: Joe Witt
 Fix For: 1.19.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-9165) Refactor nifi-standard-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Stieglitz updated NIFI-9165:
---
Status: Patch Available  (was: Open)

> Refactor nifi-standard-bundle to use JUnit 5
> 
>
> Key: NIFI-9165
> URL: https://issues.apache.org/jira/browse/NIFI-9165
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Daniel Stieglitz
>Priority: Minor
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10851) On update to controller service reference in processor configuration, ensure removal of old reference

2022-11-21 Thread Joe Witt (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Witt updated NIFI-10851:

Fix Version/s: 1.19.0

> On update to controller service reference in processor configuration, ensure 
> removal of old reference
> -
>
> Key: NIFI-10851
> URL: https://issues.apache.org/jira/browse/NIFI-10851
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Minor
> Fix For: 1.19.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> https://lists.apache.org/thread/jjjopqndrp9y6dzdnjxsdfhw2ofjh469



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10188) ConsumeEWS java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException

2022-11-21 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636901#comment-17636901
 ] 

David Handermann commented on NIFI-10188:
-

Adding the {{jaxws-api}} dependency to the {{nifi-email-processors}} module 
resolves the class error on Java 11, as implemented in the linked pull request.

> ConsumeEWS  java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException
> -
>
> Key: NIFI-10188
> URL: https://issues.apache.org/jira/browse/NIFI-10188
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.16.2
> Environment: Java 11
> Cent OS 7
>Reporter: RAVINARAYAN SINGH
>Assignee: David Handermann
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> I was trying to use ConsumeEWS processor with self hosted exchange  server 
> and i got following error 
> ConsumeEWS[id=327442d0-569a-1856--cabbf76f] Processing halted: 
> yielding [1 sec]: java.lang.NoClassDefFoundError: 
> javax/xml/ws/http/HTTPException
> - Caused by: java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (NIFI-10188) ConsumeEWS java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann reassigned NIFI-10188:
---

Assignee: David Handermann

> ConsumeEWS  java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException
> -
>
> Key: NIFI-10188
> URL: https://issues.apache.org/jira/browse/NIFI-10188
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.16.2
> Environment: Java 11
> Cent OS 7
>Reporter: RAVINARAYAN SINGH
>Assignee: David Handermann
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> I was trying to use ConsumeEWS processor with self hosted exchange  server 
> and i got following error 
> ConsumeEWS[id=327442d0-569a-1856--cabbf76f] Processing halted: 
> yielding [1 sec]: java.lang.NoClassDefFoundError: 
> javax/xml/ws/http/HTTPException
> - Caused by: java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10188) ConsumeEWS java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10188:

Status: Patch Available  (was: Open)

> ConsumeEWS  java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException
> -
>
> Key: NIFI-10188
> URL: https://issues.apache.org/jira/browse/NIFI-10188
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.16.2
> Environment: Java 11
> Cent OS 7
>Reporter: RAVINARAYAN SINGH
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> I was trying to use ConsumeEWS processor with self hosted exchange  server 
> and i got following error 
> ConsumeEWS[id=327442d0-569a-1856--cabbf76f] Processing halted: 
> yielding [1 sec]: java.lang.NoClassDefFoundError: 
> javax/xml/ws/http/HTTPException
> - Caused by: java.lang.ClassNotFoundException: javax.xml.ws.http.HTTPException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory opened a new pull request, #6697: NIFI-10188 Add jaxws-api for ConsumeEWS on Java 11

2022-11-21 Thread GitBox


exceptionfactory opened a new pull request, #6697:
URL: https://github.com/apache/nifi/pull/6697

   # Summary
   
   [NIFI-10188](https://issues.apache.org/jira/browse/NIFI-10188) Adds the 
`jaxws-api` dependency to `nifi-email-processors` to avoid 
`NoClassDefFoundError` failures for `javax.xml.ws.http.HTTPException` with the 
`ConsumeEWS` Processor on Java 11 and Java 17.
   
   The Microsoft `ews-java-api` is no longer maintained and is targeted to Java 
8, which includes the `HTTPException` class as part of the standard 
distribution. Adding the `jaxws-api` dependency allows the new unit test to run 
without throwing a `NoClassDefFoundError` on Java 11 and 17.
   
   The `ConsumeEWS` Processor should be deprecated in subsequent releases, but 
this change provides the possibility for successful invocation on Java 11.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 8
 - [X] JDK 11
 - [X] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] dan-s1 opened a new pull request, #6696: [NIFI-9165] Made changes to convert from JUnit 4 to JUnit 5

2022-11-21 Thread GitBox


dan-s1 opened a new pull request, #6696:
URL: https://github.com/apache/nifi/pull/6696

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (NIFI-9107) Refactor nifi-enrich-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Stieglitz reassigned NIFI-9107:
--

Assignee: Daniel Stieglitz

> Refactor nifi-enrich-bundle to use JUnit 5
> --
>
> Key: NIFI-9107
> URL: https://issues.apache.org/jira/browse/NIFI-9107
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Daniel Stieglitz
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6637: NIFI-10177: implemented ID token logout and revoke access token logou…

2022-11-21 Thread GitBox


exceptionfactory commented on code in PR #6637:
URL: https://github.com/apache/nifi/pull/6637#discussion_r1028539817


##
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/AccessResource.java:
##
@@ -119,6 +137,7 @@ public AccessResource(
 this.oidcService = oidcService;
 this.kerberosSpnegoIdentityProvider = kerberosSpnegoIdentityProvider;
 this.identityProvider = identityProvider;
+this.bearerTokenResolver = new DefaultBearerTokenResolver();

Review Comment:
   @thenatog Not necessarily in this case, because the 
`StandardBearerTokenResolver` also looks at the Cookie, which is not necessary 
for Registry.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] thenatog commented on a diff in pull request #6637: NIFI-10177: implemented ID token logout and revoke access token logou…

2022-11-21 Thread GitBox


thenatog commented on code in PR #6637:
URL: https://github.com/apache/nifi/pull/6637#discussion_r1028535615


##
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/AccessResource.java:
##
@@ -119,6 +137,7 @@ public AccessResource(
 this.oidcService = oidcService;
 this.kerberosSpnegoIdentityProvider = kerberosSpnegoIdentityProvider;
 this.identityProvider = identityProvider;
+this.bearerTokenResolver = new DefaultBearerTokenResolver();

Review Comment:
   @exceptionfactory I assume we would want to keep using our 
StandardBearerTokenResolver here, and import the NiFi dependency?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

2022-11-21 Thread GitBox


dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1322669243

   @exceptionfactory If you have time, can you please review this in order for 
this to get into 1.19?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10851) On update to controller service reference in processor configuration, ensure removal of old reference

2022-11-21 Thread Paul Grey (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Grey updated NIFI-10851:
-
Status: Patch Available  (was: In Progress)

https://github.com/apache/nifi/pull/6695/files

> On update to controller service reference in processor configuration, ensure 
> removal of old reference
> -
>
> Key: NIFI-10851
> URL: https://issues.apache.org/jira/browse/NIFI-10851
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> https://lists.apache.org/thread/jjjopqndrp9y6dzdnjxsdfhw2ofjh469



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] greyp9 opened a new pull request, #6695: NIFI-10851 - On update to controller service reference in processor c…

2022-11-21 Thread GitBox


greyp9 opened a new pull request, #6695:
URL: https://github.com/apache/nifi/pull/6695

   …onfiguration, ensure removal of old reference
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-9167) Refactor nifi-framework-bundle to use JUnit 5

2022-11-21 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636880#comment-17636880
 ] 

David Handermann commented on NIFI-9167:


[~dstiegli1] It may be necessary to create smaller subtasks given the size of 
the nifi-framework-bundle, specifically nifi-framework has many child modules, 
so scoping the number of changes to a manageable number would be helpful if you 
want to work on this issue.

> Refactor nifi-framework-bundle to use JUnit 5
> -
>
> Key: NIFI-9167
> URL: https://issues.apache.org/jira/browse/NIFI-9167
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-7365) Add Microsoft Graph api for Mail to email bundle

2022-11-21 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636879#comment-17636879
 ] 

David Handermann commented on NIFI-7365:


Commenting for future implementation, the nifi-email-bundle includes a number 
of libraries, so it may be best to implement a Graph API Processor in a new 
bundle to avoid dependency issues.

> Add Microsoft Graph api for Mail to email bundle
> 
>
> Key: NIFI-7365
> URL: https://issues.apache.org/jira/browse/NIFI-7365
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.11.4
>Reporter: Otto Fowler
>Priority: Major
>
> 'Today, we are announcing that on October 13th, 2020 we will stop supporting 
> and fully decommission the Basic Authentication for EWS to access Exchange 
> Online. This means that new or existing apps will not be able to use Basic 
> Authentication when connecting to Exchange using EWS.'
> Thus, consumeEWS no longer will work with Microsoft Office 365.
> The path forward is with the Microsoft Graph Api for Mail
> https://docs.microsoft.com/en-us/graph/outlook-mail-concept-overview
> https://docs.microsoft.com/en-us/graph/tutorials/java
> https://developer.microsoft.com/en-us/graph/get-started/java
> https://github.com/microsoftgraph/msgraph-sdk-java/
> https://docs.microsoft.com/en-us/graph/api/user-sendmail?view=graph-rest-1.0&tabs=http
> Nifi should have the a graph api based functionality equivalent to consumeEWS 
> ( at least  and if possible ) for office 365 users.
> In order to use the java api ( an possibly the rest service ) your 
> "application" seems to have to be registered 
> https://docs.microsoft.com/en-us/graph/auth-register-app-v2.
> I am not certain how this would effect NIFI or Apache.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10829) Adding the parent folder name as an argument to the ConsumeEWS processor

2022-11-21 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636878#comment-17636878
 ] 

David Handermann commented on NIFI-10829:
-

Thanks for the comment [~dataminer.accolade], I agree that two different 
Processors are necessary, so a new component integrating with the Graph API 
would be a good way to go. See NIFI-7365

> Adding the parent folder name as an argument to the ConsumeEWS processor
> 
>
> Key: NIFI-10829
> URL: https://issues.apache.org/jira/browse/NIFI-10829
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework
>Reporter: dataminer.accolade
>Priority: Major
> Attachments: image-2022-11-16-17-32-21-819.png
>
>
> I want to be able to pass the root folder as an argument to the ConsumeEWS 
> processor.
> [Source|https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ConsumeEWS.java#L393]
> !image-2022-11-16-17-32-21-819.png!
> Primarily I am interested in 
> [PublicFoldersRoot|https://learn.microsoft.com/en-us/dotnet/api/microsoft.exchange.webservices.data.wellknownfoldername?view=exchange-ews-api]
>  making PublicFoldersRoot selectable will require the implementation of the 
> deep search because, [deep traversal queries cannot be performed on public 
> folders.|https://learn.microsoft.com/en-us/exchange/client-developer/web-service-reference/findfolder-operation?redirectedfrom=MSDN]
>  Alternatively it would be nice to pass the path of the folder instead of a 
> folder name with a specific root to avoid the usage of deep search.
> I would implement the new feature if it is desired and if it makes sense for 
> the project. 
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (NIFI-9165) Refactor nifi-standard-bundle to use JUnit 5

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann reassigned NIFI-9165:
--

Assignee: Daniel Stieglitz  (was: Mike Thomsen)

> Refactor nifi-standard-bundle to use JUnit 5
> 
>
> Key: NIFI-9165
> URL: https://issues.apache.org/jira/browse/NIFI-9165
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Daniel Stieglitz
>Priority: Minor
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-9165) Refactor nifi-standard-bundle to use JUnit 5

2022-11-21 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636877#comment-17636877
 ] 

David Handermann commented on NIFI-9165:


Thanks [~dstiegli1], I have assigned the issue to you.

> Refactor nifi-standard-bundle to use JUnit 5
> 
>
> Key: NIFI-9165
> URL: https://issues.apache.org/jira/browse/NIFI-9165
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Daniel Stieglitz
>Priority: Minor
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-9107) Refactor nifi-enrich-bundle to use JUnit 5

2022-11-21 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636876#comment-17636876
 ] 

David Handermann commented on NIFI-9107:


Thanks for the comment [~dstiegli1], it looks like {{TestQueryDNS}} is still 
using JUnit 4, so if you would like to put a pull request for that class, that 
would be helpful.

> Refactor nifi-enrich-bundle to use JUnit 5
> --
>
> Key: NIFI-9107
> URL: https://issues.apache.org/jira/browse/NIFI-9107
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10353) ConsumeAzureEventHub does not stop even though output queue is backpressured

2022-11-21 Thread David Handermann (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636875#comment-17636875
 ] 

David Handermann commented on NIFI-10353:
-

Thanks for the question [~peter.schmitzer]. The project receives a large number 
of bug reports and feature requests on a regular basis, and there is no 
automated prioritization mechanism. Unfortunately it looks like this behavior 
has been in place since the early versions of the Processor. NiFi 1.18.0 
included some significant changes to refactor the Processor implementation 
based on the latest Azure SDK, but it did not change the core functionality. 
This issue has not been prioritized right now, but the Processor is now in a 
better position as far as the code to address the problem described.

>  ConsumeAzureEventHub does not stop even though output queue is backpressured
> -
>
> Key: NIFI-10353
> URL: https://issues.apache.org/jira/browse/NIFI-10353
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.16.3
>Reporter: Peter Schmitzer
>Priority: Major
>
> ConsumeAzureEventHub seems to not care about backpressure and continues to 
> send flowfiles to the output queue even though it is backpressured. This 
> endlessly growing queue will ultimately lead to nifi going into overload and 
> be unhealthy.
> It was expected that the processor will stop putting further data in the 
> outgoing queue as soon as it is backpressured.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10837) TestXMLReader.testAttributePrefix

2022-11-21 Thread Mark Payne (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Payne updated NIFI-10837:
--
Fix Version/s: (was: 1.19.0)

> TestXMLReader.testAttributePrefix
> -
>
> Key: NIFI-10837
> URL: https://issues.apache.org/jira/browse/NIFI-10837
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: NiFi Registry
> Environment: Apache Maven 3.6.0;
> openjdk version "1.8.0_342";
> OpenJDK Runtime Environment (build 1.8.0_342-8u342-b07-0ubuntu1~20.04-b07);
> OpenJDK 64-Bit Server VM (build 25.342-b07, mixed mode);
>Reporter: Haoran Jiang
>Priority: Trivial
> Attachments: org.apache.nifi.xml.TestXMLReader.txt
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
>  
> {code:java}
> org.apache.nifi.xml.TestXMLReader.testAttributePrefix {code}
> This is the flaky test. It can pass maven-test while testing failed under 
> [NonDex|[https://github.com/TestingResearchIllinois/NonDex]].
>  
> This is the log for the result.
>  
> {code:java}
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
> TestXMLReader.testAttributePrefix:153 expected:  ATTR_ID=P1, NAME=Cleve Butler, AGE=42}]> but was:  NAME=Cleve Butler, ATTR_ID=P1, AGE=42}]> {code}
> *Steps to reproduce the failure:*
>  
>  # install [Nondex|[https://github.com/TestingResearchIllinois/NonDex]]
>  # Run the command in nifi:
> {code:java}
> mvn -pl 
> nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services
>  edu.illinois:nondex-maven-plugin:1.1.2:nondex 
> -Dtest=org.apache.nifi.xml.TestXMLReader#testAttributePrefix
>  {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] Lehel44 commented on a diff in pull request #6670: NIFI-10832: Create PutSalesforceRecord processor

2022-11-21 Thread GitBox


Lehel44 commented on code in PR #6670:
URL: https://github.com/apache/nifi/pull/6670#discussion_r1028478436


##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/test/java/org/apache/nifi/processors/salesforce/PutSalesforceRecordIT.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.salesforce;
+
+import org.apache.nifi.oauth2.StandardOauth2AccessTokenProvider;
+import org.apache.nifi.processor.Processor;
+import org.apache.nifi.processors.salesforce.util.SalesforceConfigAware;
+import org.apache.nifi.serialization.record.MockRecordParser;
+import org.apache.nifi.serialization.record.RecordFieldType;
+import org.apache.nifi.util.MockComponentLog;
+import org.apache.nifi.util.MockFlowFile;
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.util.Collections;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+class PutSalesforceRecordIT implements SalesforceConfigAware {
+
+private TestRunner runner;
+
+@BeforeEach
+void setUp() throws Exception {
+int maxRecordCount = 2;
+Processor putSalesforceRecord = new 
CustomPutSalesforceRecord(maxRecordCount);
+
+runner = TestRunners.newTestRunner(putSalesforceRecord);
+
+StandardOauth2AccessTokenProvider oauth2AccessTokenProvider = 
initOAuth2AccessTokenProvider(runner);
+runner.setProperty(QuerySalesforceObject.TOKEN_PROVIDER, 
oauth2AccessTokenProvider.getIdentifier());
+}
+
+@Test
+void testPutSalesforceRecord() throws Exception {
+MockComponentLog mockComponentLog = new MockComponentLog("id1", 
"testPutSalesforceRecord");
+InputStream in = readFile("src/test/resources/json/put_records.json");
+
+MockFlowFile flowFile = new MockFlowFile(1L);
+byte[] fileContent = 
Files.readAllBytes(Paths.get("src/test/resources/json/put_records.json"));
+flowFile.setData(fileContent);
+flowFile.putAttributes(Collections.singletonMap("objectType", 
"Account"));

Review Comment:
   That's true, thanks for the tip!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10660) AvroReader issue after upgrading to Nifi 1.18.0

2022-11-21 Thread Matt Burgess (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-10660:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> AvroReader issue after upgrading to Nifi 1.18.0
> ---
>
> Key: NIFI-10660
> URL: https://issues.apache.org/jira/browse/NIFI-10660
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Sandro Berger
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.19.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> After upgrading from 1.15.3 to 1.18.0 we saw some issue regarding AvroReader 
> when the following conditions are met:
>  # The AVRO schema in the flowFile uses the "aliases" attribute
>  # There is a record in the flowFile where a field with set alias has a value 
> of "null"
> The use of aliases and null values used to work for us before upgrading Nifi 
> without issues
> Example schema:
> {code:java}
> {
>   "type": "record",
>   "name": "test",
>   "fields": [
>       { "name" : "id", "type" : "int", "aliases" : ["F1"] },
>       { "name" : "field1", "type" : [ "string", "null" ], "aliases" : ["F2"] 
> },
>       { "name" : "field2", "type" : [ "string", "null" ], "aliases" : ["F3"] }
>  ]
> }
>  {code}
> Example data:
> {code:java}
> [ {
>   "id" : 1,
>   "field1" : "field1content",
>   "field2" : "field2content"
> }, {
>   "id" : 2,
>   "field1" : null,
>   "field2" : "field2content"
> } ]{code}
> Note: If we remove the "aliases" from the schema or make sure that there is 
> never a field with a value of null, we don't have any errors in Nifi 1.18.0.
>  
> ERROR log:
> {code:java}
> 2022-10-14 16:30:50,617 ERROR [Timer-Driven Process Thread-6] 
> o.a.n.processors.standard.ConvertRecord 
> ConvertRecord[id=c7ee1f0f-10ac-116e-9e4c-300530853ab8] Failed to process 
> StandardFlow
> FileRecord[uuid=1d201fdb-e507-4d51-87c2-fbc895a450f3,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1665753427357-4670, 
> container=default, section=574], offset=18384, 
> length=324],offset=0,name=1d201fdb-e507-4d51-87c2-fbc895a450f3,size=324]; 
> will route to failure
> org.apache.nifi.processor.exception.ProcessException: Could not parse 
> incoming data
>         at 
> org.apache.nifi.processors.standard.AbstractRecordProcessor$1.process(AbstractRecordProcessor.java:171)
>         at 
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:3434)
>         at 
> org.apache.nifi.processors.standard.AbstractRecordProcessor.onTrigger(AbstractRecordProcessor.java:122)
>         at 
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
>         at 
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
>         at 
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
>         at 
> org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59)
>         at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
>         at 
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
>         at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>         at 
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
>         at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>         at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>         at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: org.apache.nifi.serialization.MalformedRecordException: Error 
> while getting next record
>         at 
> org.apache.nifi.avro.AvroRecordReader.nextRecord(AvroRecordReader.java:50)
>         at 
> org.apache.nifi.serialization.RecordReader.nextRecord(RecordReader.java:50)
>         at jdk.internal.reflect.GeneratedMethodAccessor150.invoke(Unknown 
> Source)
>         at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>         at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
>         at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.access$100(StandardControllerServiceInvocationHandler.java:38)
>         at 
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler$ProxiedReturnObjectInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:240)
>       

[jira] [Commented] (NIFI-10660) AvroReader issue after upgrading to Nifi 1.18.0

2022-11-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636870#comment-17636870
 ] 

ASF subversion and git services commented on NIFI-10660:


Commit 2126dbbe29858eb00e88d27efcd668431ff185c9 in nifi's branch 
refs/heads/main from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2126dbbe29 ]

NIFI-10660: When converting Avro GenericRecord to a java Map, check 
GenericRecord's schema to see if field exists before calling Record.get().

NIFI-10660: Added unit tests; fixed bug to ensure that we use the desired field 
name when checking if it exists in schema

Signed-off-by: Matthew Burgess 

This closes #6688


> AvroReader issue after upgrading to Nifi 1.18.0
> ---
>
> Key: NIFI-10660
> URL: https://issues.apache.org/jira/browse/NIFI-10660
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Sandro Berger
>Assignee: Mark Payne
>Priority: Critical
> Fix For: 1.19.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> After upgrading from 1.15.3 to 1.18.0 we saw some issue regarding AvroReader 
> when the following conditions are met:
>  # The AVRO schema in the flowFile uses the "aliases" attribute
>  # There is a record in the flowFile where a field with set alias has a value 
> of "null"
> The use of aliases and null values used to work for us before upgrading Nifi 
> without issues
> Example schema:
> {code:java}
> {
>   "type": "record",
>   "name": "test",
>   "fields": [
>       { "name" : "id", "type" : "int", "aliases" : ["F1"] },
>       { "name" : "field1", "type" : [ "string", "null" ], "aliases" : ["F2"] 
> },
>       { "name" : "field2", "type" : [ "string", "null" ], "aliases" : ["F3"] }
>  ]
> }
>  {code}
> Example data:
> {code:java}
> [ {
>   "id" : 1,
>   "field1" : "field1content",
>   "field2" : "field2content"
> }, {
>   "id" : 2,
>   "field1" : null,
>   "field2" : "field2content"
> } ]{code}
> Note: If we remove the "aliases" from the schema or make sure that there is 
> never a field with a value of null, we don't have any errors in Nifi 1.18.0.
>  
> ERROR log:
> {code:java}
> 2022-10-14 16:30:50,617 ERROR [Timer-Driven Process Thread-6] 
> o.a.n.processors.standard.ConvertRecord 
> ConvertRecord[id=c7ee1f0f-10ac-116e-9e4c-300530853ab8] Failed to process 
> StandardFlow
> FileRecord[uuid=1d201fdb-e507-4d51-87c2-fbc895a450f3,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1665753427357-4670, 
> container=default, section=574], offset=18384, 
> length=324],offset=0,name=1d201fdb-e507-4d51-87c2-fbc895a450f3,size=324]; 
> will route to failure
> org.apache.nifi.processor.exception.ProcessException: Could not parse 
> incoming data
>         at 
> org.apache.nifi.processors.standard.AbstractRecordProcessor$1.process(AbstractRecordProcessor.java:171)
>         at 
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:3434)
>         at 
> org.apache.nifi.processors.standard.AbstractRecordProcessor.onTrigger(AbstractRecordProcessor.java:122)
>         at 
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
>         at 
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
>         at 
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
>         at 
> org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59)
>         at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
>         at 
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
>         at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>         at 
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
>         at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>         at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>         at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: org.apache.nifi.serialization.MalformedRecordException: Error 
> while getting next record
>         at 
> org.apache.nifi.avro.AvroRecordReader.nextRecord(AvroRecordReader.java:50)
>         at 
> org.apache.nifi.serialization.RecordReader.nextRecord(RecordReader.java:50)
>         at jdk.internal.reflect.GeneratedMethodAccessor150.invoke(Unknown 
> Source)
>         at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.base/java.lang.reflect.Method.invoke(Method.java:566)

[GitHub] [nifi] mattyb149 closed pull request #6688: NIFI-10660: When converting Avro GenericRecord to a java Map, check G…

2022-11-21 Thread GitBox


mattyb149 closed pull request #6688: NIFI-10660: When converting Avro 
GenericRecord to a java Map, check G…
URL: https://github.com/apache/nifi/pull/6688


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10840) Add optional build profile for Neo4J 5

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10840:

Summary: Add optional build profile for Neo4J 5  (was: Add support for 
Neo4J 5.X to the cypher service)

> Add optional build profile for Neo4J 5
> --
>
> Key: NIFI-10840
> URL: https://issues.apache.org/jira/browse/NIFI-10840
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> It will need to be optional as a build profile because Neo4J 5 (driver and 
> docker image) has a hard dependency on Java 17.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10840) Add support for Neo4J 5.X to the cypher service

2022-11-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636868#comment-17636868
 ] 

ASF subversion and git services commented on NIFI-10840:


Commit e172a3f2244039d564d8c0f0e998eb0d4b78b8df in nifi's branch 
refs/heads/main from Mike Thomsen
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e172a3f224 ]

NIFI-10840 Added a build profile to enable Neo4J 5 support

This closes #6684

Signed-off-by: David Handermann 


> Add support for Neo4J 5.X to the cypher service
> ---
>
> Key: NIFI-10840
> URL: https://issues.apache.org/jira/browse/NIFI-10840
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> It will need to be optional as a build profile because Neo4J 5 (driver and 
> docker image) has a hard dependency on Java 17.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (NIFI-10840) Add support for Neo4J 5.X to the cypher service

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-10840.
-
Fix Version/s: 1.19.0
   Resolution: Fixed

> Add support for Neo4J 5.X to the cypher service
> ---
>
> Key: NIFI-10840
> URL: https://issues.apache.org/jira/browse/NIFI-10840
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> It will need to be optional as a build profile because Neo4J 5 (driver and 
> docker image) has a hard dependency on Java 17.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] mattyb149 commented on pull request #6688: NIFI-10660: When converting Avro GenericRecord to a java Map, check G…

2022-11-21 Thread GitBox


mattyb149 commented on PR #6688:
URL: https://github.com/apache/nifi/pull/6688#issuecomment-1322584229

   +1 LGTM, thanks for the fix! Merging to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] exceptionfactory closed pull request #6684: NIFI-10840 Added a build profile to enable Neo4J 5 support.

2022-11-21 Thread GitBox


exceptionfactory closed pull request #6684: NIFI-10840 Added a build profile to 
enable Neo4J 5 support.
URL: https://github.com/apache/nifi/pull/6684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10852) compress-commons does not handle large groupid values

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10852:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> compress-commons does not handle large groupid values
> -
>
> Key: NIFI-10852
> URL: https://issues.apache.org/jira/browse/NIFI-10852
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: C2
>Affects Versions: 1.18.0
>Reporter: Mark Bean
>Assignee: Mark Bean
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There is a limitation in the org.apache.commons:commons-compress library 
> which does not allow groupid values larger than 2097151 by default. Some 
> users who have a large groupid value may experience problems building Apache 
> NiFi, particularly the c2 modules.
> While this isn't the cause of the problem, the exhibited unit test failure is:
> {{[ERROR] Tests run: 12, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 
> 0.317 s <<< FAILURE! - in 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest}}
> {{[ERROR] 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(String,
>  String, String, String)[1]  Time elapsed: 0.096 s  <<< FAILURE!}}
> {{Wanted but not invoked:}}
> {{c2Client.uploadBundle(}}
> {{    ,}}
> {{    }}
> {{);}}
> {{-> at 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(TransferDebugOperationHandlerTest.java:206)}}
> {{Actually, there were zero interactions with this mock.}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10852) compress-commons does not handle large groupid values

2022-11-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636866#comment-17636866
 ] 

ASF subversion and git services commented on NIFI-10852:


Commit 66be1cf0b285c094b77b3e17beeeabafc9ddfaa2 in nifi's branch 
refs/heads/main from Mark Bean
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=66be1cf0b2 ]

NIFI-10852 Allow commons-compress to use large OS groupid values

This closes #6694

Signed-off-by: David Handermann 


> compress-commons does not handle large groupid values
> -
>
> Key: NIFI-10852
> URL: https://issues.apache.org/jira/browse/NIFI-10852
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: C2
>Affects Versions: 1.18.0
>Reporter: Mark Bean
>Assignee: Mark Bean
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There is a limitation in the org.apache.commons:commons-compress library 
> which does not allow groupid values larger than 2097151 by default. Some 
> users who have a large groupid value may experience problems building Apache 
> NiFi, particularly the c2 modules.
> While this isn't the cause of the problem, the exhibited unit test failure is:
> {{[ERROR] Tests run: 12, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 
> 0.317 s <<< FAILURE! - in 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest}}
> {{[ERROR] 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(String,
>  String, String, String)[1]  Time elapsed: 0.096 s  <<< FAILURE!}}
> {{Wanted but not invoked:}}
> {{c2Client.uploadBundle(}}
> {{    ,}}
> {{    }}
> {{);}}
> {{-> at 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(TransferDebugOperationHandlerTest.java:206)}}
> {{Actually, there were zero interactions with this mock.}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory closed pull request #6694: NIFI-10852 allows commons-compress to use groupid large groupid values

2022-11-21 Thread GitBox


exceptionfactory closed pull request #6694: NIFI-10852 allows commons-compress 
to use groupid large groupid values
URL: https://github.com/apache/nifi/pull/6694


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10776) Add support for PKI Authentication in ElasticSearchClientServiceImpl

2022-11-21 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10776:

Fix Version/s: 1.19.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Add support for PKI Authentication in ElasticSearchClientServiceImpl
> 
>
> Key: NIFI-10776
> URL: https://issues.apache.org/jira/browse/NIFI-10776
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nandor Soma Abonyi
>Assignee: Chris Sampson
>Priority: Major
>  Labels: elasticsearch
> Fix For: 1.19.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Also add NONE as an AuthenticationScheme option.
> By [~Chris S]:
> I'd probably stick with {{BASIC}} being the default as that would mean 
> {{{}Username{}}}/{{{}Password{}}} remain available by default when adding the 
> Processor to the canvas, which matches the current behaviour and therefore is 
> backwards compatible.
> If the user selects {{NONE}} then I guess we'd be hiding the existing 
> Username/Password and new {{{}API Key{}}}property inputs (via 
> {{{}dependsOn{}}}).
> If the user selected {{PKI}} then it would be great if the {{SSLContext 
> Controller}} become mandatory, but I don't think that's currently possible, 
> so in effect this would have the same effect as {{NONE}} on the available 
> processor properties (we don't want to hide {{SSL Context}} if something 
> other than {{PKI}} is selected here, as {{{}https{}}}/{{{}TLS{}}}might very 
> well still be needed even if it's not used for Auth in Elasticsearch).
> One option might be to use some {{customerValidation}} for this though - if 
> the user has selected {{{}PKI{}}}, they {*}must{*}also specify an {{SSL 
> Context}} in their processor configuration. Similarly, if {{NONE}} is 
> selected, then we could validate that none of the Username/Password/API Key 
> fields are provided?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10776) Add support for PKI Authentication in ElasticSearchClientServiceImpl

2022-11-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636858#comment-17636858
 ] 

ASF subversion and git services commented on NIFI-10776:


Commit d23e50168f23d051a9ed866eb067362ca7e9df79 in nifi's branch 
refs/heads/main from Chris Sampson
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d23e50168f ]

NIFI-10776 Added NONE and PKI AuthorizationSchemes for 
ElasticSearchClientService

This closes #6662

Signed-off-by: David Handermann 


> Add support for PKI Authentication in ElasticSearchClientServiceImpl
> 
>
> Key: NIFI-10776
> URL: https://issues.apache.org/jira/browse/NIFI-10776
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nandor Soma Abonyi
>Assignee: Chris Sampson
>Priority: Major
>  Labels: elasticsearch
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Also add NONE as an AuthenticationScheme option.
> By [~Chris S]:
> I'd probably stick with {{BASIC}} being the default as that would mean 
> {{{}Username{}}}/{{{}Password{}}} remain available by default when adding the 
> Processor to the canvas, which matches the current behaviour and therefore is 
> backwards compatible.
> If the user selects {{NONE}} then I guess we'd be hiding the existing 
> Username/Password and new {{{}API Key{}}}property inputs (via 
> {{{}dependsOn{}}}).
> If the user selected {{PKI}} then it would be great if the {{SSLContext 
> Controller}} become mandatory, but I don't think that's currently possible, 
> so in effect this would have the same effect as {{NONE}} on the available 
> processor properties (we don't want to hide {{SSL Context}} if something 
> other than {{PKI}} is selected here, as {{{}https{}}}/{{{}TLS{}}}might very 
> well still be needed even if it's not used for Auth in Elasticsearch).
> One option might be to use some {{customerValidation}} for this though - if 
> the user has selected {{{}PKI{}}}, they {*}must{*}also specify an {{SSL 
> Context}} in their processor configuration. Similarly, if {{NONE}} is 
> selected, then we could validate that none of the Username/Password/API Key 
> fields are provided?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory closed pull request #6662: NIFI-10776 add NONE and PKI AuthorizationSchemes for ElasticSearchClientService

2022-11-21 Thread GitBox


exceptionfactory closed pull request #6662: NIFI-10776 add NONE and PKI 
AuthorizationSchemes for ElasticSearchClientService
URL: https://github.com/apache/nifi/pull/6662


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-10852) compress-commons does not handle large groupid values

2022-11-21 Thread Joe Witt (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636854#comment-17636854
 ] 

Joe Witt commented on NIFI-10852:
-

will handle this in 1.19 rc process

> compress-commons does not handle large groupid values
> -
>
> Key: NIFI-10852
> URL: https://issues.apache.org/jira/browse/NIFI-10852
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: C2
>Affects Versions: 1.18.0
>Reporter: Mark Bean
>Assignee: Mark Bean
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There is a limitation in the org.apache.commons:commons-compress library 
> which does not allow groupid values larger than 2097151 by default. Some 
> users who have a large groupid value may experience problems building Apache 
> NiFi, particularly the c2 modules.
> While this isn't the cause of the problem, the exhibited unit test failure is:
> {{[ERROR] Tests run: 12, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 
> 0.317 s <<< FAILURE! - in 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest}}
> {{[ERROR] 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(String,
>  String, String, String)[1]  Time elapsed: 0.096 s  <<< FAILURE!}}
> {{Wanted but not invoked:}}
> {{c2Client.uploadBundle(}}
> {{    ,}}
> {{    }}
> {{);}}
> {{-> at 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(TransferDebugOperationHandlerTest.java:206)}}
> {{Actually, there were zero interactions with this mock.}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10852) compress-commons does not handle large groupid values

2022-11-21 Thread Joe Witt (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Witt updated NIFI-10852:

Fix Version/s: 1.19.0

> compress-commons does not handle large groupid values
> -
>
> Key: NIFI-10852
> URL: https://issues.apache.org/jira/browse/NIFI-10852
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: C2
>Affects Versions: 1.18.0
>Reporter: Mark Bean
>Assignee: Mark Bean
>Priority: Major
> Fix For: 1.19.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There is a limitation in the org.apache.commons:commons-compress library 
> which does not allow groupid values larger than 2097151 by default. Some 
> users who have a large groupid value may experience problems building Apache 
> NiFi, particularly the c2 modules.
> While this isn't the cause of the problem, the exhibited unit test failure is:
> {{[ERROR] Tests run: 12, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 
> 0.317 s <<< FAILURE! - in 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest}}
> {{[ERROR] 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(String,
>  String, String, String)[1]  Time elapsed: 0.096 s  <<< FAILURE!}}
> {{Wanted but not invoked:}}
> {{c2Client.uploadBundle(}}
> {{    ,}}
> {{    }}
> {{);}}
> {{-> at 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(TransferDebugOperationHandlerTest.java:206)}}
> {{Actually, there were zero interactions with this mock.}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6694: NIFI-10852 allows commons-compress to use groupid large groupid values

2022-11-21 Thread GitBox


exceptionfactory commented on code in PR #6694:
URL: https://github.com/apache/nifi/pull/6694#discussion_r1028450214


##
c2/c2-client-bundle/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/operation/TransferDebugOperationHandler.java:
##
@@ -178,6 +178,7 @@ private Optional createDebugBundle(List 
filePaths) {
 try (GzipCompressorOutputStream gzipCompressorOutputStream = new 
GzipCompressorOutputStream(byteOutputStream);
  TarArchiveOutputStream tarOutputStream = new 
TarArchiveOutputStream(gzipCompressorOutputStream)) {
 for (Path filePath : filePaths) {
+tarOutputStream.setBigNumberMode(1);

Review Comment:
   Can you change this to `TarArchiveOutputStream.BIGNUMBER_POSIX`? The value 
of `1` is equivalent to `BIGNUMBER_STAR`, which does not appear to be as widely 
supported according to the [commons-compress 
documentation](https://commons.apache.org/proper/commons-compress/tar.html).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] gresockj commented on pull request #6690: NIFI-10819 Restrict JndiLoginModule for Kafka JAAS Config

2022-11-21 Thread GitBox


gresockj commented on PR #6690:
URL: https://github.com/apache/nifi/pull/6690#issuecomment-1322529773

   Thanks, @exceptionfactory -- reviewing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10853) UpdateAttribute - expression language syntax error not caught until processor runtime

2022-11-21 Thread Nissim Shiman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nissim Shiman updated NIFI-10853:
-
Description: 
The UpdateAttribute will not show any alerts when the following expression 
language value is used for a property value:
{code:java}
${filename:equals('testFile'}
{code}

This is also true when using the 'Verify Properties' button. (A green arrow is 
returned saying "Component Validation Passed").

The processor will start, but when a flowfile passed through on runtime, 
though, it will fail
with error
{code}
org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException:
 Invalid Expression: ${filename:equals('testFile'} due to Unexpected token '}' 
at line 1, column 28. Query: ${filename:equals(testFile}
{code}

(This is not the case with RouteOnAttribute, which will leave the processor in 
an invalid state, flagging this as an alert, until the expression is corrected.)

  was:
The UpdateAttribute will not show any alerts when the following expression 
language value is used for a property value:
{code:java}
${filename:equals('testFile'}
{code}

This is also true when using the 'Verify Properties' button. (A green arrow is 
returned saying "Component Validation Passed").

The processor will start, but when a flowfile passed through on runtime, 
though, it will fail
with error
{code}
org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException:
 Invalid Expression: ${filename:equals('testFile'} due to Unexpected token '}' 
at line 1, column 28. Query: ${filename:equals(testFile}
{code}


> UpdateAttribute - expression language syntax error not caught until processor 
> runtime
> -
>
> Key: NIFI-10853
> URL: https://issues.apache.org/jira/browse/NIFI-10853
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Nissim Shiman
>Priority: Major
>
> The UpdateAttribute will not show any alerts when the following expression 
> language value is used for a property value:
> {code:java}
> ${filename:equals('testFile'}
> {code}
> This is also true when using the 'Verify Properties' button. (A green arrow 
> is returned saying "Component Validation Passed").
> The processor will start, but when a flowfile passed through on runtime, 
> though, it will fail
> with error
> {code}
> org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException:
>  Invalid Expression: ${filename:equals('testFile'} due to Unexpected token 
> '}' at line 1, column 28. Query: ${filename:equals(testFile}
> {code}
> (This is not the case with RouteOnAttribute, which will leave the processor 
> in an invalid state, flagging this as an alert, until the expression is 
> corrected.)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-10853) UpdateAttribute - expression language syntax error not caught until processor runtime

2022-11-21 Thread Nissim Shiman (Jira)
Nissim Shiman created NIFI-10853:


 Summary: UpdateAttribute - expression language syntax error not 
caught until processor runtime
 Key: NIFI-10853
 URL: https://issues.apache.org/jira/browse/NIFI-10853
 Project: Apache NiFi
  Issue Type: Bug
Reporter: Nissim Shiman


The UpdateAttribute will not show any alerts when the following expression 
language value is used for a property value:
{code:java}
${filename:equals('testFile'}
{code}

This is also true when using the 'Verify Properties' button. (A green arrow is 
returned saying "Component Validation Passed").

The processor will start, but when a flowfile passed through on runtime, 
though, it will fail
with error
{code}
org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException:
 Invalid Expression: ${filename:equals('testFile'} due to Unexpected token '}' 
at line 1, column 28. Query: ${filename:equals(testFile}
{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10852) compress-commons does not handle large groupid values

2022-11-21 Thread Mark Bean (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Bean updated NIFI-10852:
-
Status: Patch Available  (was: In Progress)

> compress-commons does not handle large groupid values
> -
>
> Key: NIFI-10852
> URL: https://issues.apache.org/jira/browse/NIFI-10852
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: C2
>Affects Versions: 1.18.0
>Reporter: Mark Bean
>Assignee: Mark Bean
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> There is a limitation in the org.apache.commons:commons-compress library 
> which does not allow groupid values larger than 2097151 by default. Some 
> users who have a large groupid value may experience problems building Apache 
> NiFi, particularly the c2 modules.
> While this isn't the cause of the problem, the exhibited unit test failure is:
> {{[ERROR] Tests run: 12, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 
> 0.317 s <<< FAILURE! - in 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest}}
> {{[ERROR] 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(String,
>  String, String, String)[1]  Time elapsed: 0.096 s  <<< FAILURE!}}
> {{Wanted but not invoked:}}
> {{c2Client.uploadBundle(}}
> {{    ,}}
> {{    }}
> {{);}}
> {{-> at 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(TransferDebugOperationHandlerTest.java:206)}}
> {{Actually, there were zero interactions with this mock.}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (NIFI-10852) compress-commons does not handle large groupid values

2022-11-21 Thread Mark Bean (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Bean reassigned NIFI-10852:


Assignee: Mark Bean

> compress-commons does not handle large groupid values
> -
>
> Key: NIFI-10852
> URL: https://issues.apache.org/jira/browse/NIFI-10852
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: C2
>Affects Versions: 1.18.0
>Reporter: Mark Bean
>Assignee: Mark Bean
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> There is a limitation in the org.apache.commons:commons-compress library 
> which does not allow groupid values larger than 2097151 by default. Some 
> users who have a large groupid value may experience problems building Apache 
> NiFi, particularly the c2 modules.
> While this isn't the cause of the problem, the exhibited unit test failure is:
> {{[ERROR] Tests run: 12, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 
> 0.317 s <<< FAILURE! - in 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest}}
> {{[ERROR] 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(String,
>  String, String, String)[1]  Time elapsed: 0.096 s  <<< FAILURE!}}
> {{Wanted but not invoked:}}
> {{c2Client.uploadBundle(}}
> {{    ,}}
> {{    }}
> {{);}}
> {{-> at 
> org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(TransferDebugOperationHandlerTest.java:206)}}
> {{Actually, there were zero interactions with this mock.}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] markobean opened a new pull request, #6694: NIFI-10852 allows commons-compress to use groupid large groupid values

2022-11-21 Thread GitBox


markobean opened a new pull request, #6694:
URL: https://github.com/apache/nifi/pull/6694

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   Some users are not able to perform a full build of Apache NiFi source code. 
Specifically, the C2 modules fails to pass unit test when the user's groupid 
value is large (>2097151). This PR addresses the issue by enabling 
"bigNumberMode" in org.apache.commons:commons-compress library where otherwise 
errors would occur.
   
   [NIFI-10852](https://issues.apache.org/jira/browse/NIFI-10852)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   To verify, a build which consistently failed (due to groupid value being too 
large) was able to complete successfully. To test, the user's groupid value 
must be > 2097151.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 8
 - [X] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [X] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] sardell opened a new pull request, #6693: NIFI-10814: Display description for selected flow

2022-11-21 Thread GitBox


sardell opened a new pull request, #6693:
URL: https://github.com/apache/nifi/pull/6693

   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-10814](https://issues.apache.org/jira/browse/NIFI-10814)
   
   
![NIFI-10814-v1](https://user-images.githubusercontent.com/7304869/203108453-97691d09-9dad-48b4-af42-c6b33f9bc3bb.gif)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10814) UI - Display description on source selection

2022-11-21 Thread Shane Ardell (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shane Ardell updated NIFI-10814:

Description: 
Right now, in the NiFi UI, when dragging and dropping a process group and 
selecting the Registry as the source, we never display the description that has 
been given when versioning the flow if referencing a flow outside of NiFi 
registry.

Because of how the backend is currently implemented, a quick UI-only solution 
is to fetch the description on selection. In the future, an ideal solution 
would be to include the description in the summary endpoint return or create a 
new endpoint that returns all fully populated flows in order to display the 
description in the dropdown prior to selection.

  was:
Right now, in the NiFi UI, when dragging and dropping a process group and 
selecting the Registry as the source, we never display the description that has 
been given when versioning the flow.

Because of how the backend is currently implemented, a quick UI-only solution 
is to fetch the description on selection. In the future, an ideal solution 
would be to include the description in the summary endpoint return or create a 
new endpoint that returns all fully populated flows in order to display the 
description in the dropdown prior to selection.


> UI - Display description on source selection
> 
>
> Key: NIFI-10814
> URL: https://issues.apache.org/jira/browse/NIFI-10814
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Shane Ardell
>Assignee: Shane Ardell
>Priority: Major
>
> Right now, in the NiFi UI, when dragging and dropping a process group and 
> selecting the Registry as the source, we never display the description that 
> has been given when versioning the flow if referencing a flow outside of NiFi 
> registry.
> Because of how the backend is currently implemented, a quick UI-only solution 
> is to fetch the description on selection. In the future, an ideal solution 
> would be to include the description in the summary endpoint return or create 
> a new endpoint that returns all fully populated flows in order to display the 
> description in the dropdown prior to selection.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-10852) compress-commons does not handle large groupid values

2022-11-21 Thread Mark Bean (Jira)
Mark Bean created NIFI-10852:


 Summary: compress-commons does not handle large groupid values
 Key: NIFI-10852
 URL: https://issues.apache.org/jira/browse/NIFI-10852
 Project: Apache NiFi
  Issue Type: Bug
  Components: C2
Affects Versions: 1.18.0
Reporter: Mark Bean


There is a limitation in the org.apache.commons:commons-compress library which 
does not allow groupid values larger than 2097151 by default. Some users who 
have a large groupid value may experience problems building Apache NiFi, 
particularly the c2 modules.

While this isn't the cause of the problem, the exhibited unit test failure is:

{{[ERROR] Tests run: 12, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 
0.317 s <<< FAILURE! - in 
org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest}}
{{[ERROR] 
org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(String,
 String, String, String)[1]  Time elapsed: 0.096 s  <<< FAILURE!}}
{{Wanted but not invoked:}}
{{c2Client.uploadBundle(}}
{{    ,}}
{{    }}
{{);}}
{{-> at 
org.apache.nifi.c2.client.service.operation.TransferDebugOperationHandlerTest.testContentIsFilteredOut(TransferDebugOperationHandlerTest.java:206)}}
{{Actually, there were zero interactions with this mock.}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10850) Query Parameters property in InvokeAWSGatewayApi should support FlowFile attributes in EL

2022-11-21 Thread Peter Turcsanyi (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Turcsanyi updated NIFI-10850:
---
Status: Patch Available  (was: Open)

> Query Parameters property in InvokeAWSGatewayApi should support FlowFile 
> attributes in EL
> -
>
> Key: NIFI-10850
> URL: https://issues.apache.org/jira/browse/NIFI-10850
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Minor
>  Labels: aws
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Query Parameters property declares FlowFile Attributes support but it is not 
> handled in the code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] turcsanyip opened a new pull request, #6692: NIFI-10850: Fixed Query Parameters property in InvokeAWSGatewayApi sh…

2022-11-21 Thread GitBox


turcsanyip opened a new pull request, #6692:
URL: https://github.com/apache/nifi/pull/6692

   …ould support FlowFile attributes in EL
   
   # Summary
   
   [NIFI-10850](https://issues.apache.org/jira/browse/NIFI-10850)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-9165) Refactor nifi-standard-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636792#comment-17636792
 ] 

Daniel Stieglitz commented on NIFI-9165:


[~mike.thomsen] [~exceptionfactory] Looks like most of the unit tests are using 
JUnit 5 in the nifi-standard-bundle except for 

./nifi-standard-parameter-providers/src/test/java/org/apache/nifi/parameter/TestDatabaseParameterProvider.java
./nifi-standard-reporting-tasks/src/test/java/org/apache/nifi/controller/TestMonitorDiskUsage.java
./nifi-standard-utils/src/test/java/org/apache/nifi/processors/standard/util/TestTransformFactory.java

 

If it is okay with both of you, I will to try convert these.

> Refactor nifi-standard-bundle to use JUnit 5
> 
>
> Key: NIFI-9165
> URL: https://issues.apache.org/jira/browse/NIFI-9165
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (NIFI-9167) Refactor nifi-framework-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


[ https://issues.apache.org/jira/browse/NIFI-9167 ]


Daniel Stieglitz deleted comment on NIFI-9167:


was (Author: JIRAUSER294662):
[~mike.thomsen] Can you please assign this to me so I could at least try to 
completely convert it over to JUnit 5? Thanks!

> Refactor nifi-framework-bundle to use JUnit 5
> -
>
> Key: NIFI-9167
> URL: https://issues.apache.org/jira/browse/NIFI-9167
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (NIFI-9167) Refactor nifi-framework-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636779#comment-17636779
 ] 

Daniel Stieglitz edited comment on NIFI-9167 at 11/21/22 5:13 PM:
--

[~mike.thomsen] Can you please assign this to me so I could at least try to 
completely convert it over to JUnit 5? Thanks!


was (Author: JIRAUSER294662):
[~mike.thomsen] Can you please assign this to me so I could at least try to 
convert it over to JUnit 5? Thanks!

> Refactor nifi-framework-bundle to use JUnit 5
> -
>
> Key: NIFI-9167
> URL: https://issues.apache.org/jira/browse/NIFI-9167
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-9167) Refactor nifi-framework-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636779#comment-17636779
 ] 

Daniel Stieglitz commented on NIFI-9167:


[~mike.thomsen] Can you please assign this to me so I could at least try to 
convert it over to JUnit 5? Thanks!

> Refactor nifi-framework-bundle to use JUnit 5
> -
>
> Key: NIFI-9167
> URL: https://issues.apache.org/jira/browse/NIFI-9167
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (NIFI-9107) Refactor nifi-enrich-bundle to use JUnit 5

2022-11-21 Thread Daniel Stieglitz (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636774#comment-17636774
 ] 

Daniel Stieglitz edited comment on NIFI-9107 at 11/21/22 5:08 PM:
--

[~mike.thomsen] [~exceptionfactory] The ticket status indicates this still 
needs to be done but looking at the unit tests it appears that it has been done 
already. I have looked at unit tests TestGeoEnrichIP, TestGeoEnrichIPRecord and 
TestISPEnrichIP and they all seem to have JUnit 5 annotations and assertions. 
Is there something else that needs to be done? 


was (Author: JIRAUSER294662):
[~mike.thomsen] [~exceptionfactory] The ticket status indicates this still 
needs to be done but looking at the unit tests it appears that it has been done 
already. Is there something else that needs to be done? I have looked at unit 
tests TestGeoEnrichIP, TestGeoEnrichIPRecord and TestISPEnrichIP and they all 
seem to have JUnit 5 annotations and assertions.

> Refactor nifi-enrich-bundle to use JUnit 5
> --
>
> Key: NIFI-9107
> URL: https://issues.apache.org/jira/browse/NIFI-9107
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Mike Thomsen
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10851) On update to controller service reference in processor configuration, ensure removal of old reference

2022-11-21 Thread Paul Grey (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Grey updated NIFI-10851:
-
Description: 
https://lists.apache.org/thread/jjjopqndrp9y6dzdnjxsdfhw2ofjh469

> On update to controller service reference in processor configuration, ensure 
> removal of old reference
> -
>
> Key: NIFI-10851
> URL: https://issues.apache.org/jira/browse/NIFI-10851
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Paul Grey
>Assignee: Paul Grey
>Priority: Minor
>
> https://lists.apache.org/thread/jjjopqndrp9y6dzdnjxsdfhw2ofjh469



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


  1   2   >