[jira] [Created] (NIFI-11106) QueryRecord can fail to rollback sessions on commit failure.
Kevin Doran created NIFI-11106:
--
Summary: QueryRecord can fail to rollback sessions on commit
failure.
Key: NIFI-11106
URL: https://issues.apache.org/jira/browse/NIFI-11106
Project: Apache NiFi
Issue Type: Bug
Components: Extensions
Affects Versions: 1.19.1, 1.18.0, 1.16.3, 1.17.0, 1.15.3, 1.13.2, 1.14.0
Reporter: Kevin Doran
Attachments: query-record-config.json.txt
It appears that going back to at least NiFi 1.13.2, there are some
configurations of QueryRecord that can result flowfiles to be not closed
properly prior to attempting to commit a session. This causes session commit to
fail, as a a flow file cannot be written while it is still open for reading.
These show up as uncaught exceptions in NiFi logs (see below).
Additionally, failed session commits should be rolled back and reprocessed,
however, some of these QueryRecord commit failures do not get rolled back
properly. When this occurs, the content of the flowfile is stuck, uncommitted
so it will not reach downstream processors and not rolled back so that it will
land back in the QueryRecord input queue to be reprocessed. This can result in
data loss for the contents of the stuck flowfile.
Specifically this has been observed with QueryRecord, GrokReader, and
FreeFormTextRecordSetWriter.
*Attached is an example configuration of QueryRecord (including record
reader/writer) that can result in this behavior.*
During the time observed, data volume was about 40-78 million records per hour,
with the uncaught exceptions only occasionally occurring (between 0 and 10
times per hour). Of those uncaught exceptions, not all resulting in data loss /
failed rollback, so that is even more rare.
*Data characteristics:*
* For the given QueryRecord config that has include and exclude queries, both
queries are expected to match some lines in the input flowfile.
* The flowfile is also expected to contain some unmatched lines, such as empty
lines, lines of text that don't match either query, or corrupted / binary lines
that don't decode to ascii intermixed with plaintext lines.
Example data can be provided upon request.
Here are the stack traces for how this issue appears on NiFi 1.16.1:
{noformat}
2023-01-19T15:22:58.798926992Z stdout F 2023-01-19 15:22:58,797 ERROR
[Timer-Driven Process Thread-5] o.a.nifi.processors.standard.QueryRecord
QueryRecord[id=98518d51-88d8-3000-a38e-d629589cfd5a] Processing halted:
yielding [1 sec]
2023-01-19T15:22:58.798933858Z stdout F java.lang.IllegalStateException: Cannot
commit session while reading from FlowFile
2023-01-19T15:22:58.798940864Z stdout F at
org.apache.nifi.controller.repository.StandardProcessSession.validateCommitState(StandardProcessSession.java:241)
2023-01-19T15:22:58.798957184Z stdout F at
org.apache.nifi.controller.repository.StandardProcessSession.checkpoint(StandardProcessSession.java:270)
2023-01-19T15:22:58.798960616Z stdout F at
org.apache.nifi.controller.repository.StandardProcessSession.checkpoint(StandardProcessSession.java:233)
2023-01-19T15:22:58.798963703Z stdout F at
org.apache.nifi.controller.repository.BatchingSessionFactory$HighThroughputSession.commit(BatchingSessionFactory.java:69)
2023-01-19T15:22:58.798967659Z stdout F at
org.apache.nifi.controller.repository.BatchingSessionFactory$HighThroughputSession.commitAsync(BatchingSessionFactory.java:74)
2023-01-19T15:22:58.798970816Z stdout F at
org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:28)
2023-01-19T15:22:58.798974237Z stdout F at
org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1354)
2023-01-19T15:22:58.798978213Z stdout F at
org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:214)
2023-01-19T15:22:58.79899325Z stdout F at
org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:103)
2023-01-19T15:22:58.798996758Z stdout F at
org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
2023-01-19T15:22:58.799000774Z stdout F at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
2023-01-19T15:22:58.799004017Z stdout F at
java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
2023-01-19T15:22:58.799007704Z stdout F at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
2023-01-19T15:22:58.799011065Z stdout F at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
2023-01-19T15:22:58.799014058Z stdout F at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
2023-01-19T15:22:58.79901729Z stdout F at
java.util.concurrent.ThreadPoolExecutor$
[GitHub] [nifi] dependabot[bot] opened a new pull request, #6896: Bump ua-parser-js and karma in /nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main
dependabot[bot] opened a new pull request, #6896: URL: https://github.com/apache/nifi/pull/6896 Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) to 0.7.33 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These dependencies need to be updated together. Updates `ua-parser-js` from 0.7.22 to 0.7.33 Changelog Sourced from https://github.com/faisalman/ua-parser-js/blob/master/changelog.md";>ua-parser-js's changelog. Version 0.7.33 / 1.0.33 Add new browser : Cobalt Identify Macintosh as an Apple device Fix ReDoS vulnerability Version 0.8 Version 0.8 was created by accident. This version is now deprecated and no longer maintained, please update to version 0.7 / 1.0. Commits https://github.com/faisalman/ua-parser-js/commit/f2d0db001d87da15de7b9b1df7be9f2eacefd8c5";>f2d0db0 Bump version 0.7.33 https://github.com/faisalman/ua-parser-js/commit/a6140a17dd0300a35cfc9cff999545f267889411";>a6140a1 Remove unsafe regex in trim() function https://github.com/faisalman/ua-parser-js/commit/a88660493568d6144a551424a8139d6c876635f6";>a886604 Fix https://github-redirect.dependabot.com/faisalman/ua-parser-js/issues/605";>#605 - Identify Macintosh as Apple device https://github.com/faisalman/ua-parser-js/commit/b814bcd79198e730936c82462e2d729eb5423e3c";>b814bcd Merge pull request https://github-redirect.dependabot.com/faisalman/ua-parser-js/issues/606";>#606 from rileyjshaw/patch-1 https://github.com/faisalman/ua-parser-js/commit/7f71024161399b7aa5d5cd10dba9e059f0218262";>7f71024 Fix documentation https://github.com/faisalman/ua-parser-js/commit/c239ac5167abd574a635cb809a2b4fa35810d23b";>c239ac5 Merge pull request https://github-redirect.dependabot.com/faisalman/ua-parser-js/issues/604";>#604 from obecerra3/master https://github.com/faisalman/ua-parser-js/commit/8d3c2d327cf540ff2c050f1cc67bca8c6f8e4458";>8d3c2d3 Add new browser: Cobalt https://github.com/faisalman/ua-parser-js/commit/d11fc47dc9b6acc0f89fc10c120cea08e10cd31a";>d11fc47 Bump version 0.7.32 https://github.com/faisalman/ua-parser-js/commit/b490110109de586deab96c775c9ef0dfc9c919c4";>b490110 Merge branch 'develop' of github.com:faisalman/ua-parser-js https://github.com/faisalman/ua-parser-js/commit/cb5da5ea4b220d5b60fe209e123b7f911d8e0d4a";>cb5da5e Merge pull request https://github-redirect.dependabot.com/faisalman/ua-parser-js/issues/600";>#600 from moekm/develop Additional commits viewable in https://github.com/faisalman/ua-parser-js/compare/0.7.22...0.7.33";>compare view Updates `karma` from 5.2.3 to 6.4.1 Release notes Sourced from https://github.com/karma-runner/karma/releases";>karma's releases. v6.4.1 https://github.com/karma-runner/karma/compare/v6.4.0...v6.4.1";>6.4.1 (2022-09-19) Bug Fixes pass integrity value (https://github.com/karma-runner/karma/commit/63d86befd3431fe8e1500e22f4f115a3762d000a";>63d86be) v6.4.0 https://github.com/karma-runner/karma/compare/v6.3.20...v6.4.0";>6.4.0 (2022-06-14) Features support SRI verification of link tags (https://github.com/karma-runner/karma/commit/dc51a2e0e9b9805f7740f52fde01bcd20adc2dfc";>dc51a2e) support SRI verification of script tags (https://github.com/karma-runner/karma/commit/6a54b1c2a1df8214c470b8a5cc8036912874637e";>6a54b1c) v6.3.20 https://github.com/karma-runner/karma/compare/v6.3.19...v6.3.20";>6.3.20 (2022-05-13) Bug Fixes prefer IPv4 addresses when resolving domains (https://github.com/karma-runner/karma/commit/e17698f950af83bf2b3edc540d2a3e1fb73cba59";>e17698f), closes https://github-redirect.dependabot.com/karma-runner/karma/issues/3730";>#3730 v6.3.19 https://github.com/karma-runner/karma/compare/v6.3.18...v6.3.19";>6.3.19 (2022-04-19) Bug Fixes client: error out when opening a new tab fails (https://github.com/karma-runner/karma/commit/099b85ed0a46e37dd7cb14fc1596cbb1b3eabce9";>099b85e) v6.3.18 https://github.com/karma-runner/karma/compare/v6.3.17...v6.3.18";>6.3.18 (2022-04-13) Bug Fixes deps: upgrade socket.io to v4.4.1 (https://github.com/karma-runner/karma/commit/52a30bbc6e168333a8592c26c9f40678d6ab74ea";>52a30bb) v6.3.17 https://github.com/karma-runner/karma/compare/v6.3.16...v6.3.17";>6.3.17 (2022-02-28) Bug Fixes deps: update colors to maintained version (https://github-redirect.dependabot.com/karma-runner/karma/issues/3763";>#3763) (https://github.com/karma-runner/karma/commit/fca18843e7a04eeb67b86cb3cfc3db794d66f445";>fca1884) v6.3.16 ... (truncated) Changelog Sourced from https://github.com/karma-runner/karma/blob/master/CHANGELOG.md";>karma's changelog. https://github.com/karma-runner/karma/compare/v6.4.0...v6.4.1";>6.4.1 (2022-09-19) Bug Fixes pass integrity value (https://github.com/karma-runner/karma/commit/63d86befd
[jira] [Updated] (NIFI-11022) Add Decrypt Processors Compatible with EncryptContent Encoding
[
https://issues.apache.org/jira/browse/NIFI-11022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11022:
Fix Version/s: 1.20.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Add Decrypt Processors Compatible with EncryptContent Encoding
> --
>
> Key: NIFI-11022
> URL: https://issues.apache.org/jira/browse/NIFI-11022
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions, Security
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.20.0
>
> Attachments: DecryptContent_Flow.json
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The {{EncryptContent}} Processors supports a wide variety of configuration
> options, enabling both encryption and decryption using various algorithms.
> Many of these algorithms are not secure according to modern cryptographic
> analysis, and existing secure options use a custom encoding format. New
> Processors should be added that support decrypting content according to these
> legacy and custom formats, which will enable deprecating {{EncryptContent}}
> for removal and replacement with other approaches.
> The majority allowable values for the {{Encryption Method}} property in
> {{EncryptContent}} come from the PKCS #5 Password-Based Cryptography
> Specification, described in [RFC
> 8018|https://www.rfc-editor.org/rfc/rfc8018]. These algorithm names start
> with {{PBE}} and incorporate a message digest function along with a cipher
> algorithm. Although these methods include AES, the key derivation process for
> all PBE algorithms follows the {{PBES1}} specification from RFC 8018, which
> is not secure or suitable for modern applications. The ability to decrypt
> older content is useful, but new content should not be encrypted using these
> methods.
> The PBE algorithms can be configured together with either the {{NiFi Legacy}}
> or {{OpenSSL EVP BytesToKey}} option for key derivation. The {{NiFI Legacy}}
> option derives from the [Jasypt|http://www.jasypt.org/] library, which
> provides a standard wrapper for PBE algorithms that defaults to 1000
> iterations of a selected digest algorithm. The {{OpenSSL EVP}} option
> supports compatibility with encryption operations implemented in the
> {{OpenSSL}} library and command.
> Advanced Key Derivation Functions include Argon2, bcrypt, PBKDF2, and scrypt,
> which can be used together with AES in Galois/Counter Mode (GCM) for
> authenticated encryption. These options provide much better security than the
> legacy PBE methods, but they rely on custom file encoding using byte
> delimiters that are specific to Apache NiFi. In addition, these Key
> Derivation Functions generate keys of 16 bytes, which supports AES with 128
> bit keys, but not AES with 256 bit keys. NiFi 0.5.0 added bcrypt, PBKDF2, and
> scrypt, and NiFi 1.12.0 added Argon2. Decrypting content according to the
> custom NiFi encoding should be supported, but other options should be
> evaluated separately for encryption in new flows. The salt parameter bytes
> associated with Argon2, bcrypt, and scrypt allow for detection of file
> encoding, which can enable new decryption processors to be configured without
> reference to a specific Key Derivation Function.
> Adding new decryption processors will enable clear separation of encryption
> and decryption operations, providing a compatible transition path for
> historical usage of {{EncryptContent}} without the need to continue
> supporting insecure encryption methods.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11022) Add Decrypt Processors Compatible with EncryptContent Encoding
[
https://issues.apache.org/jira/browse/NIFI-11022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681150#comment-17681150
]
ASF subversion and git services commented on NIFI-11022:
Commit 0c676b96337a0afb760d78de11e7fb1747794f9d in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0c676b9633 ]
NIFI-11022 Added DecryptContent Compatibility Processors
- Added nifi-cipher-bundle with nifi-cipher-nar for new Processors
- Added DecryptContentCompatibilityMode Processor supporting PKCS5 and PKCS12
Password-Based Encryption Schemes
- Added DecryptContentEncoded Processor supporting NiFi Key Derivation
Functions and associated formatting
- Added nifi-security-crypt-key module with Key Derivation Functions and
Parameter Readers
- Added Additional Details documentation for Processors
This closes #6821
Signed-off-by: Paul Grey
> Add Decrypt Processors Compatible with EncryptContent Encoding
> --
>
> Key: NIFI-11022
> URL: https://issues.apache.org/jira/browse/NIFI-11022
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions, Security
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Attachments: DecryptContent_Flow.json
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The {{EncryptContent}} Processors supports a wide variety of configuration
> options, enabling both encryption and decryption using various algorithms.
> Many of these algorithms are not secure according to modern cryptographic
> analysis, and existing secure options use a custom encoding format. New
> Processors should be added that support decrypting content according to these
> legacy and custom formats, which will enable deprecating {{EncryptContent}}
> for removal and replacement with other approaches.
> The majority allowable values for the {{Encryption Method}} property in
> {{EncryptContent}} come from the PKCS #5 Password-Based Cryptography
> Specification, described in [RFC
> 8018|https://www.rfc-editor.org/rfc/rfc8018]. These algorithm names start
> with {{PBE}} and incorporate a message digest function along with a cipher
> algorithm. Although these methods include AES, the key derivation process for
> all PBE algorithms follows the {{PBES1}} specification from RFC 8018, which
> is not secure or suitable for modern applications. The ability to decrypt
> older content is useful, but new content should not be encrypted using these
> methods.
> The PBE algorithms can be configured together with either the {{NiFi Legacy}}
> or {{OpenSSL EVP BytesToKey}} option for key derivation. The {{NiFI Legacy}}
> option derives from the [Jasypt|http://www.jasypt.org/] library, which
> provides a standard wrapper for PBE algorithms that defaults to 1000
> iterations of a selected digest algorithm. The {{OpenSSL EVP}} option
> supports compatibility with encryption operations implemented in the
> {{OpenSSL}} library and command.
> Advanced Key Derivation Functions include Argon2, bcrypt, PBKDF2, and scrypt,
> which can be used together with AES in Galois/Counter Mode (GCM) for
> authenticated encryption. These options provide much better security than the
> legacy PBE methods, but they rely on custom file encoding using byte
> delimiters that are specific to Apache NiFi. In addition, these Key
> Derivation Functions generate keys of 16 bytes, which supports AES with 128
> bit keys, but not AES with 256 bit keys. NiFi 0.5.0 added bcrypt, PBKDF2, and
> scrypt, and NiFi 1.12.0 added Argon2. Decrypting content according to the
> custom NiFi encoding should be supported, but other options should be
> evaluated separately for encryption in new flows. The salt parameter bytes
> associated with Argon2, bcrypt, and scrypt allow for detection of file
> encoding, which can enable new decryption processors to be configured without
> reference to a specific Key Derivation Function.
> Adding new decryption processors will enable clear separation of encryption
> and decryption operations, providing a compatible transition path for
> historical usage of {{EncryptContent}} without the need to continue
> supporting insecure encryption methods.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] greyp9 closed pull request #6821: NIFI-11022 Add DecryptContent Compatibility Processors
greyp9 closed pull request #6821: NIFI-11022 Add DecryptContent Compatibility Processors URL: https://github.com/apache/nifi/pull/6821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11105) Download Flow takes long time when there are many Process Groups with Parameter Contexts
[ https://issues.apache.org/jira/browse/NIFI-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-11105: Resolution: Fixed Status: Resolved (was: Patch Available) > Download Flow takes long time when there are many Process Groups with > Parameter Contexts > > > Key: NIFI-11105 > URL: https://issues.apache.org/jira/browse/NIFI-11105 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.20.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > When we export a flow for download, we have to serialize any referenced > Parameter Context as part of the JSON. To do this, we build up a collection > of VersionedParameterContexts. The logic that we use does this for every > Process Group. So if we have many small Process Groups, each bound to a > Parameter Context, we formulate that VersionedParameterContext every time. > However, there is no need to create more than one VersionedParameterContext > for each existing ParameterContext. This mapping becomes very expensive and > can take many minutes for flows that contain lots of Parameters and lots of > Process Groups. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11105) Download Flow takes long time when there are many Process Groups with Parameter Contexts
[ https://issues.apache.org/jira/browse/NIFI-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681147#comment-17681147 ] ASF subversion and git services commented on NIFI-11105: Commit d9f35b89741ff2cd13ad77b7a8f995c96bac36b7 in nifi's branch refs/heads/main from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d9f35b8974 ] NIFI-11105: This closes #6895. When mapping Parameter Context to VersionedParameterContext, don't bother mapping those that have already been mapped, as it is redundant Signed-off-by: Joe Witt > Download Flow takes long time when there are many Process Groups with > Parameter Contexts > > > Key: NIFI-11105 > URL: https://issues.apache.org/jira/browse/NIFI-11105 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.20.0 > > Time Spent: 20m > Remaining Estimate: 0h > > When we export a flow for download, we have to serialize any referenced > Parameter Context as part of the JSON. To do this, we build up a collection > of VersionedParameterContexts. The logic that we use does this for every > Process Group. So if we have many small Process Groups, each bound to a > Parameter Context, we formulate that VersionedParameterContext every time. > However, there is no need to create more than one VersionedParameterContext > for each existing ParameterContext. This mapping becomes very expensive and > can take many minutes for flows that contain lots of Parameters and lots of > Process Groups. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #6895: NIFI-11105: When mapping Parameter Context to VersionedParameterConte…
asfgit closed pull request #6895: NIFI-11105: When mapping Parameter Context to VersionedParameterConte… URL: https://github.com/apache/nifi/pull/6895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11105) Download Flow takes long time when there are many Process Groups with Parameter Contexts
[ https://issues.apache.org/jira/browse/NIFI-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-11105: Fix Version/s: 1.20.0 > Download Flow takes long time when there are many Process Groups with > Parameter Contexts > > > Key: NIFI-11105 > URL: https://issues.apache.org/jira/browse/NIFI-11105 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.20.0 > > Time Spent: 10m > Remaining Estimate: 0h > > When we export a flow for download, we have to serialize any referenced > Parameter Context as part of the JSON. To do this, we build up a collection > of VersionedParameterContexts. The logic that we use does this for every > Process Group. So if we have many small Process Groups, each bound to a > Parameter Context, we formulate that VersionedParameterContext every time. > However, there is no need to create more than one VersionedParameterContext > for each existing ParameterContext. This mapping becomes very expensive and > can take many minutes for flows that contain lots of Parameters and lots of > Process Groups. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] joewitt commented on pull request #6895: NIFI-11105: When mapping Parameter Context to VersionedParameterConte…
joewitt commented on PR #6895: URL: https://github.com/apache/nifi/pull/6895#issuecomment-1405753262 pretty impressive what 3 little lines can do. Saw before after behavior on very large/complex flow. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-10721) PutAzureBlobStorage_v12 should not query for properties after success
[ https://issues.apache.org/jira/browse/NIFI-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-10721. - Fix Version/s: 1.20.0 Assignee: Malthe Borch Resolution: Fixed > PutAzureBlobStorage_v12 should not query for properties after success > - > > Key: NIFI-10721 > URL: https://issues.apache.org/jira/browse/NIFI-10721 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Malthe Borch >Assignee: Malthe Borch >Priority: Minor > Fix For: 1.20.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Since we're in control of all the properties of the blob, there is no reason > to query for the properties after success. > Using the information we already have will obviate the need for this > additional roundtrip. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10721) PutAzureBlobStorage_v12 should not query for properties after success
[ https://issues.apache.org/jira/browse/NIFI-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681145#comment-17681145 ] ASF subversion and git services commented on NIFI-10721: Commit 41649660be11431ffb02e4e1618c6559b1eeac28 in nifi's branch refs/heads/main from Malthe Borch [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=41649660be ] NIFI-10721 Avoid querying properties after Azure Blob upload This closes #6730 Signed-off-by: David Handermann > PutAzureBlobStorage_v12 should not query for properties after success > - > > Key: NIFI-10721 > URL: https://issues.apache.org/jira/browse/NIFI-10721 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Malthe Borch >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Since we're in control of all the properties of the blob, there is no reason > to query for the properties after success. > Using the information we already have will obviate the need for this > additional roundtrip. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10721) PutAzureBlobStorage_v12 should not query for properties after success
[ https://issues.apache.org/jira/browse/NIFI-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10721: Priority: Minor (was: Major) > PutAzureBlobStorage_v12 should not query for properties after success > - > > Key: NIFI-10721 > URL: https://issues.apache.org/jira/browse/NIFI-10721 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Malthe Borch >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > Since we're in control of all the properties of the blob, there is no reason > to query for the properties after success. > Using the information we already have will obviate the need for this > additional roundtrip. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #6730: NIFI-10721 No querying for props after successful blob upload
exceptionfactory closed pull request #6730: NIFI-10721 No querying for props after successful blob upload URL: https://github.com/apache/nifi/pull/6730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a diff in pull request #6892: NIFI-11059 PutBoxFile processor
turcsanyip commented on code in PR #6892:
URL: https://github.com/apache/nifi/pull/6892#discussion_r1088387924
##
nifi-nar-bundles/nifi-box-bundle/nifi-box-processors/src/main/java/org/apache/nifi/processors/box/PutBoxFile.java:
##
@@ -0,0 +1,366 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.box;
+
+import static java.lang.String.format;
+import static java.lang.String.valueOf;
+import static java.util.Arrays.asList;
+import static
org.apache.nifi.processor.util.StandardValidators.createRegexMatchingValidator;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ERROR_CODE;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ERROR_CODE_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ERROR_MESSAGE;
+import static
org.apache.nifi.processors.box.BoxFileAttributes.ERROR_MESSAGE_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.FILENAME_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ID;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ID_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.PATH_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.SIZE;
+import static org.apache.nifi.processors.box.BoxFileAttributes.SIZE_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.TIMESTAMP;
+import static org.apache.nifi.processors.box.BoxFileAttributes.TIMESTAMP_DESC;
+import static org.apache.nifi.processors.box.BoxFileUtils.BOX_URL;
+
+import com.box.sdk.BoxAPIConnection;
+import com.box.sdk.BoxAPIException;
+import com.box.sdk.BoxAPIResponseException;
+import com.box.sdk.BoxFile;
+import com.box.sdk.BoxFolder;
+import java.io.InputStream;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Pattern;
+import java.util.stream.StreamSupport;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.ReadsAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.SeeAlso;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.box.controllerservices.BoxClientService;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.DataUnit;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+
+@SeeAlso({ListBoxFile.class, FetchBoxFile.class})
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"box", "storage", "put"})
+@CapabilityDescription("Puts content to a Box folder.")
+@ReadsAttribute(attribute = "filename", description = "Uses the FlowFile's
filename as the filename for the Box object.")
+@WritesAttributes({
+@WritesAttribute(attribute = ID, description = ID_DESC),
+@WritesAttribute(attribute = "filename", description = FILENAME_DESC),
+@WritesAttribute(attribute = "path", description = PATH_DESC),
+@WritesAttribute(attribute = SIZE, description = SIZE_DESC),
+@WritesAttribute(attribute = TIMESTAMP, description = TIMESTAMP_DESC),
+@WritesAttribute(attribute = ERROR_CODE, description =
ERROR_CODE_DESC),
+@WritesAttribute(attribute = ERROR_MESSAGE, description =
ERROR_MESSAGE_DESC)})
+public class PutBoxFile extends AbstractProcessor {
+public static final int CHUNKED_UPLOAD_LOWER_LIMIT_IN_BYTES = 20 * 1024 *
1024;
+public stati
[jira] [Commented] (NIFI-10246) Node may fail to reconnect to cluster if controller service is in DISABLING state
[ https://issues.apache.org/jira/browse/NIFI-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681138#comment-17681138 ] Mark Payne commented on NIFI-10246: --- Typically will want both of these Jiras together. > Node may fail to reconnect to cluster if controller service is in DISABLING > state > - > > Key: NIFI-10246 > URL: https://issues.apache.org/jira/browse/NIFI-10246 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.17.0 > > Time Spent: 20m > Remaining Estimate: 0h > > If a Controller Service has a state of DISABLING and it's requested to join > the cluster, it can fail to join, providing an error message that says the > Controller Service cannot be modified because it is not disabled. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] turcsanyip commented on a diff in pull request #6892: NIFI-11059 PutBoxFile processor
turcsanyip commented on code in PR #6892:
URL: https://github.com/apache/nifi/pull/6892#discussion_r1088117506
##
nifi-nar-bundles/nifi-box-bundle/nifi-box-processors/src/main/java/org/apache/nifi/processors/box/PutBoxFile.java:
##
@@ -0,0 +1,366 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.box;
+
+import static java.lang.String.format;
+import static java.lang.String.valueOf;
+import static java.util.Arrays.asList;
+import static
org.apache.nifi.processor.util.StandardValidators.createRegexMatchingValidator;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ERROR_CODE;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ERROR_CODE_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ERROR_MESSAGE;
+import static
org.apache.nifi.processors.box.BoxFileAttributes.ERROR_MESSAGE_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.FILENAME_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ID;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ID_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.PATH_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.SIZE;
+import static org.apache.nifi.processors.box.BoxFileAttributes.SIZE_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.TIMESTAMP;
+import static org.apache.nifi.processors.box.BoxFileAttributes.TIMESTAMP_DESC;
+import static org.apache.nifi.processors.box.BoxFileUtils.BOX_URL;
+
+import com.box.sdk.BoxAPIConnection;
+import com.box.sdk.BoxAPIException;
+import com.box.sdk.BoxAPIResponseException;
+import com.box.sdk.BoxFile;
+import com.box.sdk.BoxFolder;
+import java.io.InputStream;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Pattern;
+import java.util.stream.StreamSupport;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.ReadsAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.SeeAlso;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.box.controllerservices.BoxClientService;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.DataUnit;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+
+@SeeAlso({ListBoxFile.class, FetchBoxFile.class})
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"box", "storage", "put"})
+@CapabilityDescription("Puts content to a Box folder.")
+@ReadsAttribute(attribute = "filename", description = "Uses the FlowFile's
filename as the filename for the Box object.")
+@WritesAttributes({
+@WritesAttribute(attribute = ID, description = ID_DESC),
+@WritesAttribute(attribute = "filename", description = FILENAME_DESC),
+@WritesAttribute(attribute = "path", description = PATH_DESC),
+@WritesAttribute(attribute = SIZE, description = SIZE_DESC),
+@WritesAttribute(attribute = TIMESTAMP, description = TIMESTAMP_DESC),
+@WritesAttribute(attribute = ERROR_CODE, description =
ERROR_CODE_DESC),
+@WritesAttribute(attribute = ERROR_MESSAGE, description =
ERROR_MESSAGE_DESC)})
+public class PutBoxFile extends AbstractProcessor {
+public static final int CHUNKED_UPLOAD_LOWER_LIMIT_IN_BYTES = 20 * 1024 *
1024;
+public stati
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6892: NIFI-11059 PutBoxFile processor
exceptionfactory commented on code in PR #6892:
URL: https://github.com/apache/nifi/pull/6892#discussion_r1088363732
##
nifi-nar-bundles/nifi-box-bundle/nifi-box-processors/src/main/java/org/apache/nifi/processors/box/PutBoxFile.java:
##
@@ -0,0 +1,366 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.box;
+
+import static java.lang.String.format;
+import static java.lang.String.valueOf;
+import static java.util.Arrays.asList;
+import static
org.apache.nifi.processor.util.StandardValidators.createRegexMatchingValidator;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ERROR_CODE;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ERROR_CODE_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ERROR_MESSAGE;
+import static
org.apache.nifi.processors.box.BoxFileAttributes.ERROR_MESSAGE_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.FILENAME_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ID;
+import static org.apache.nifi.processors.box.BoxFileAttributes.ID_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.PATH_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.SIZE;
+import static org.apache.nifi.processors.box.BoxFileAttributes.SIZE_DESC;
+import static org.apache.nifi.processors.box.BoxFileAttributes.TIMESTAMP;
+import static org.apache.nifi.processors.box.BoxFileAttributes.TIMESTAMP_DESC;
+import static org.apache.nifi.processors.box.BoxFileUtils.BOX_URL;
+
+import com.box.sdk.BoxAPIConnection;
+import com.box.sdk.BoxAPIException;
+import com.box.sdk.BoxAPIResponseException;
+import com.box.sdk.BoxFile;
+import com.box.sdk.BoxFolder;
+import java.io.InputStream;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Pattern;
+import java.util.stream.StreamSupport;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.ReadsAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.SeeAlso;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.box.controllerservices.BoxClientService;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.DataUnit;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+
+@SeeAlso({ListBoxFile.class, FetchBoxFile.class})
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"box", "storage", "put"})
+@CapabilityDescription("Puts content to a Box folder.")
+@ReadsAttribute(attribute = "filename", description = "Uses the FlowFile's
filename as the filename for the Box object.")
+@WritesAttributes({
+@WritesAttribute(attribute = ID, description = ID_DESC),
+@WritesAttribute(attribute = "filename", description = FILENAME_DESC),
+@WritesAttribute(attribute = "path", description = PATH_DESC),
+@WritesAttribute(attribute = SIZE, description = SIZE_DESC),
+@WritesAttribute(attribute = TIMESTAMP, description = TIMESTAMP_DESC),
+@WritesAttribute(attribute = ERROR_CODE, description =
ERROR_CODE_DESC),
+@WritesAttribute(attribute = ERROR_MESSAGE, description =
ERROR_MESSAGE_DESC)})
+public class PutBoxFile extends AbstractProcessor {
+public static final int CHUNKED_UPLOAD_LOWER_LIMIT_IN_BYTES = 20 * 1024 *
1024;
+public
[jira] [Commented] (NIFI-11068) Extract PutX processors' conflict resolution strategies to a common class
[ https://issues.apache.org/jira/browse/NIFI-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681128#comment-17681128 ] ASF subversion and git services commented on NIFI-11068: Commit 96a6594680db93684c813bfc0a9154adb4c5c687 in nifi's branch refs/heads/main from krisztina-zsihovszki [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=96a6594680 ] NIFI-11068 Introduced ConflictResolutionStrategy enum This closes #6861 Signed-off-by: David Handermann > Extract PutX processors' conflict resolution strategies to a common class > - > > Key: NIFI-11068 > URL: https://issues.apache.org/jira/browse/NIFI-11068 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Zsihovszki Krisztina >Assignee: Zsihovszki Krisztina >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > The PutX processors ( PutAzureDataLakeStorage, PutDropbox, future > PutGoogleDrive /PutBoxFiles etc.) > use the same conflict resolution strategy types: "fail", "replace", "ignore". > As recommended in > [https://github.com/apache/nifi/pull/6832#discussion_r1071421721] , it would > be useful to extract these values to a common class. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-11068) Extract PutX processors' conflict resolution strategies to a common class
[ https://issues.apache.org/jira/browse/NIFI-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11068. - Fix Version/s: 1.20.0 Resolution: Fixed > Extract PutX processors' conflict resolution strategies to a common class > - > > Key: NIFI-11068 > URL: https://issues.apache.org/jira/browse/NIFI-11068 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Zsihovszki Krisztina >Assignee: Zsihovszki Krisztina >Priority: Minor > Fix For: 1.20.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > The PutX processors ( PutAzureDataLakeStorage, PutDropbox, future > PutGoogleDrive /PutBoxFiles etc.) > use the same conflict resolution strategy types: "fail", "replace", "ignore". > As recommended in > [https://github.com/apache/nifi/pull/6832#discussion_r1071421721] , it would > be useful to extract these values to a common class. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11105) Download Flow takes long time when there are many Process Groups with Parameter Contexts
[ https://issues.apache.org/jira/browse/NIFI-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-11105: -- Status: Patch Available (was: Open) > Download Flow takes long time when there are many Process Groups with > Parameter Contexts > > > Key: NIFI-11105 > URL: https://issues.apache.org/jira/browse/NIFI-11105 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When we export a flow for download, we have to serialize any referenced > Parameter Context as part of the JSON. To do this, we build up a collection > of VersionedParameterContexts. The logic that we use does this for every > Process Group. So if we have many small Process Groups, each bound to a > Parameter Context, we formulate that VersionedParameterContext every time. > However, there is no need to create more than one VersionedParameterContext > for each existing ParameterContext. This mapping becomes very expensive and > can take many minutes for flows that contain lots of Parameters and lots of > Process Groups. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11068) Extract PutX processors' conflict resolution strategies to a common class
[ https://issues.apache.org/jira/browse/NIFI-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11068: Priority: Minor (was: Major) > Extract PutX processors' conflict resolution strategies to a common class > - > > Key: NIFI-11068 > URL: https://issues.apache.org/jira/browse/NIFI-11068 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Zsihovszki Krisztina >Assignee: Zsihovszki Krisztina >Priority: Minor > Time Spent: 1h 20m > Remaining Estimate: 0h > > The PutX processors ( PutAzureDataLakeStorage, PutDropbox, future > PutGoogleDrive /PutBoxFiles etc.) > use the same conflict resolution strategy types: "fail", "replace", "ignore". > As recommended in > [https://github.com/apache/nifi/pull/6832#discussion_r1071421721] , it would > be useful to extract these values to a common class. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #6861: NIFI-11068 Introduce ConflictResolutionStrategy enum
exceptionfactory closed pull request #6861: NIFI-11068 Introduce ConflictResolutionStrategy enum URL: https://github.com/apache/nifi/pull/6861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markap14 opened a new pull request, #6895: NIFI-11105: When mapping Parameter Context to VersionedParameterConte…
markap14 opened a new pull request, #6895: URL: https://github.com/apache/nifi/pull/6895 …xt, don't bother mapping those that have already been mapped, as it is redundant # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6892: NIFI-11059 PutBoxFile processor
exceptionfactory commented on code in PR #6892:
URL: https://github.com/apache/nifi/pull/6892#discussion_r1088329051
##
nifi-nar-bundles/nifi-box-bundle/nifi-box-processors/src/test/java/org/apache/nifi/processors/box/FetchBoxFileTest.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.box;
+
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.verify;
+
+import com.box.sdk.BoxFile;
+import java.io.OutputStream;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import org.apache.nifi.provenance.ProvenanceEventType;
+import org.apache.nifi.util.MockFlowFile;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+public class FetchBoxFileTest extends AbstractBoxFileTest{
+@Mock
+BoxFile mockBoxFile;
+
+@BeforeEach
+void setUp() throws Exception {
+
+final FetchBoxFile testSubject = new FetchBoxFile() {
+@Override
+protected BoxFile getBoxFile(String fileId) {
+return mockBoxFile;
+}
+};
+
+testRunner = TestRunners.newTestRunner(testSubject);
+super.setUp();
+}
+
+@Test
+void testBoxIdFromFlowFileAttribute() {
+testRunner.setProperty(FetchBoxFile.FILE_ID, "${box.id}");
+final MockFlowFile inputFlowFile = new MockFlowFile(0);
+final Map attributes = new HashMap<>();
+attributes.put(BoxFileAttributes.ID, TEST_FILE_ID);
+inputFlowFile.putAttributes(attributes);
+
+final BoxFile.Info fetchedFileInfo = createFileInfo(TEST_PATH,
MODIFIED_TIME);
+doReturn(fetchedFileInfo).when(mockBoxFile).getInfo();
+
+// WHEN
Review Comment:
The use of `WHEN` and `THEN` comments should be avoided.
##
nifi-nar-bundles/nifi-box-bundle/nifi-box-processors/src/main/java/org/apache/nifi/processors/box/BoxFileAttributes.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.box;
+
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+
+public class BoxFileAttributes {
+
+public static final String ID = "box.id";
+public static final String ID_DESC = "The id of the file";
+
+public static final String FILENAME = CoreAttributes.FILENAME.key();
Review Comment:
I recommend avoiding reproducing the `FILENAME` and `PATH` attributes and
using the `CoreAttributes` enum directly.
##
nifi-nar-bundles/nifi-box-bundle/nifi-box-processors/src/main/java/org/apache/nifi/processors/box/BoxFileUtils.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
[GitHub] [nifi] exceptionfactory commented on pull request #6821: NIFI-11022 Add DecryptContent Compatibility Processors
exceptionfactory commented on PR #6821: URL: https://github.com/apache/nifi/pull/6821#issuecomment-1405659129 Thanks for the feedback @greyp9, I updated the RFC 8018 link and renamed the Processors as follows: - Renamed `DecryptContentEncoded` to `DecryptContent` - Renamed `DecryptContentCompatibilityMode` to `DecryptContentCompatibility` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11105) Download Flow takes long time when there are many Process Groups with Parameter Contexts
Mark Payne created NIFI-11105: - Summary: Download Flow takes long time when there are many Process Groups with Parameter Contexts Key: NIFI-11105 URL: https://issues.apache.org/jira/browse/NIFI-11105 Project: Apache NiFi Issue Type: Bug Components: Core Framework Reporter: Mark Payne Assignee: Mark Payne When we export a flow for download, we have to serialize any referenced Parameter Context as part of the JSON. To do this, we build up a collection of VersionedParameterContexts. The logic that we use does this for every Process Group. So if we have many small Process Groups, each bound to a Parameter Context, we formulate that VersionedParameterContext every time. However, there is no need to create more than one VersionedParameterContext for each existing ParameterContext. This mapping becomes very expensive and can take many minutes for flows that contain lots of Parameters and lots of Process Groups. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] greyp9 commented on a diff in pull request #6821: NIFI-11022 Add DecryptContent Compatibility Processors
greyp9 commented on code in PR #6821:
URL: https://github.com/apache/nifi/pull/6821#discussion_r1088327831
##
nifi-nar-bundles/nifi-cipher-bundle/nifi-cipher-processors/src/main/java/org/apache/nifi/processors/cipher/DecryptContentEncoded.java:
##
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.cipher;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.io.StreamCallback;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.processors.cipher.algorithm.CipherAlgorithmMode;
+import org.apache.nifi.processors.cipher.algorithm.CipherAlgorithmPadding;
+import org.apache.nifi.processors.cipher.algorithm.SymmetricCipher;
+import org.apache.nifi.processors.cipher.encoded.EncodedDelimiter;
+import org.apache.nifi.processors.cipher.encoded.KeySpecificationFormat;
+import org.apache.nifi.processors.cipher.io.DecryptStreamCallback;
+import org.apache.nifi.security.crypto.key.DerivedKeyParameterSpec;
+import org.apache.nifi.security.crypto.key.DerivedKeySpec;
+import org.apache.nifi.security.crypto.key.StandardDerivedKeySpec;
+import
org.apache.nifi.security.crypto.key.detection.DetectedDerivedKeyParameterSpecReader;
+import
org.apache.nifi.security.crypto.key.detection.DetectedDerivedKeyProvider;
+import org.apache.nifi.security.crypto.key.io.ByteBufferSearch;
+import org.bouncycastle.util.encoders.Hex;
+
+import javax.crypto.Cipher;
+import javax.crypto.spec.GCMParameterSpec;
+import javax.crypto.spec.IvParameterSpec;
+import javax.crypto.spec.PBEKeySpec;
+import javax.crypto.spec.SecretKeySpec;
+import java.nio.ByteBuffer;
+import java.security.GeneralSecurityException;
+import java.security.Key;
+import java.security.spec.AlgorithmParameterSpec;
+import java.security.spec.KeySpec;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+@SideEffectFree
+@SupportsBatching
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
+@Tags({"cryptography", "decipher", "decrypt", "AES", "Argon2", "bcrypt",
"scrypt", "PBKDF2"})
+@CapabilityDescription("Decrypt content encrypted with AES and encoded
according conventions added in NiFi 0.5.0 for the EncryptContent Processor. " +
+"The Processor reads the first 256 bytes to determine the presence of
a cryptographic salt based on finding the 'NiFiSALT' delimiter. " +
+"The salt is not present for content encrypted with a raw hexadecimal
key. " +
+"The Processor determines the presence of the initialization vector
based on finding the 'NiFiIV' delimiter." +
+"The salt format indicates the Key Derivation Function that the
Processor uses to generate a secret key based on a configured password. " +
+"The Processor derives keys with a size of 128 bits according to the
conventions implemented in NiFi 0.5.0."
+)
+public class DecryptContentEncoded extends AbstractProcessor {
+
+static final PropertyDescriptor CIPHER_ALGORITHM_MODE = new
PropertyDescriptor.Builder()
+.name("cipher-algorithm-mode")
+.displayName("Cipher Algorithm Mode")
+.description("Block cipher mode of operation for decryption using
the Advanced Encryption Standard")
+.required(true)
+.allowableValues(CipherAlgorithmMode.class)
+.defaultValue(CipherAlgorithmMode.GCM.getValue())
+.build();
+
+static final PropertyDescriptor CIPHER_ALGORITHM_PADDING = new
PropertyDescriptor.Builder()
+.name("cipher-algorithm-padding")
+.displayName
[GitHub] [nifi] greyp9 commented on a diff in pull request #6821: NIFI-11022 Add DecryptContent Compatibility Processors
greyp9 commented on code in PR #6821:
URL: https://github.com/apache/nifi/pull/6821#discussion_r1088327831
##
nifi-nar-bundles/nifi-cipher-bundle/nifi-cipher-processors/src/main/java/org/apache/nifi/processors/cipher/DecryptContentEncoded.java:
##
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.cipher;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.io.StreamCallback;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.processors.cipher.algorithm.CipherAlgorithmMode;
+import org.apache.nifi.processors.cipher.algorithm.CipherAlgorithmPadding;
+import org.apache.nifi.processors.cipher.algorithm.SymmetricCipher;
+import org.apache.nifi.processors.cipher.encoded.EncodedDelimiter;
+import org.apache.nifi.processors.cipher.encoded.KeySpecificationFormat;
+import org.apache.nifi.processors.cipher.io.DecryptStreamCallback;
+import org.apache.nifi.security.crypto.key.DerivedKeyParameterSpec;
+import org.apache.nifi.security.crypto.key.DerivedKeySpec;
+import org.apache.nifi.security.crypto.key.StandardDerivedKeySpec;
+import
org.apache.nifi.security.crypto.key.detection.DetectedDerivedKeyParameterSpecReader;
+import
org.apache.nifi.security.crypto.key.detection.DetectedDerivedKeyProvider;
+import org.apache.nifi.security.crypto.key.io.ByteBufferSearch;
+import org.bouncycastle.util.encoders.Hex;
+
+import javax.crypto.Cipher;
+import javax.crypto.spec.GCMParameterSpec;
+import javax.crypto.spec.IvParameterSpec;
+import javax.crypto.spec.PBEKeySpec;
+import javax.crypto.spec.SecretKeySpec;
+import java.nio.ByteBuffer;
+import java.security.GeneralSecurityException;
+import java.security.Key;
+import java.security.spec.AlgorithmParameterSpec;
+import java.security.spec.KeySpec;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+@SideEffectFree
+@SupportsBatching
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
+@Tags({"cryptography", "decipher", "decrypt", "AES", "Argon2", "bcrypt",
"scrypt", "PBKDF2"})
+@CapabilityDescription("Decrypt content encrypted with AES and encoded
according conventions added in NiFi 0.5.0 for the EncryptContent Processor. " +
+"The Processor reads the first 256 bytes to determine the presence of
a cryptographic salt based on finding the 'NiFiSALT' delimiter. " +
+"The salt is not present for content encrypted with a raw hexadecimal
key. " +
+"The Processor determines the presence of the initialization vector
based on finding the 'NiFiIV' delimiter." +
+"The salt format indicates the Key Derivation Function that the
Processor uses to generate a secret key based on a configured password. " +
+"The Processor derives keys with a size of 128 bits according to the
conventions implemented in NiFi 0.5.0."
+)
+public class DecryptContentEncoded extends AbstractProcessor {
+
+static final PropertyDescriptor CIPHER_ALGORITHM_MODE = new
PropertyDescriptor.Builder()
+.name("cipher-algorithm-mode")
+.displayName("Cipher Algorithm Mode")
+.description("Block cipher mode of operation for decryption using
the Advanced Encryption Standard")
+.required(true)
+.allowableValues(CipherAlgorithmMode.class)
+.defaultValue(CipherAlgorithmMode.GCM.getValue())
+.build();
+
+static final PropertyDescriptor CIPHER_ALGORITHM_PADDING = new
PropertyDescriptor.Builder()
+.name("cipher-algorithm-padding")
+.displayName
[jira] [Commented] (NIFI-10581) Update to Apache Tika 2.6.0
[ https://issues.apache.org/jira/browse/NIFI-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681090#comment-17681090 ] Joe Witt commented on NIFI-10581: - awesome David thank you! Glad you remembered to come back to this > Update to Apache Tika 2.6.0 > --- > > Key: NIFI-10581 > URL: https://issues.apache.org/jira/browse/NIFI-10581 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: David Handermann >Priority: Major > Fix For: 1.20.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6821: NIFI-11022 Add DecryptContent Compatibility Processors
exceptionfactory commented on code in PR #6821: URL: https://github.com/apache/nifi/pull/6821#discussion_r1088228234 ## nifi-nar-bundles/nifi-cipher-bundle/nifi-cipher-processors/src/main/resources/docs/org.apache.nifi.processors.cipher.DecryptContentCompatibilityMode/additionalDetails.html: ## @@ -0,0 +1,144 @@ + + + + + +DecryptContentCompatibilityMode + + + +Summary + + This Processor supports decryption using legacy formats and Password-Based Encryption Algorithms. + https://www.rfc-editor.org/rfc/rfc8018";>RFC 8018 defines the Password-Based Cryptography Review Comment: Good point, adding the `target` attribute to the tag should help by opening it in a new window. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-10581) Update to Apache Tika 2.6.0
[ https://issues.apache.org/jira/browse/NIFI-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681081#comment-17681081 ] ASF subversion and git services commented on NIFI-10581: Commit d913f8046acb84acf4b98adf171c9d41bc245408 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d913f8046a ] NIFI-10581 Upgraded Apache Tika from 2.4.1 to 2.6.0 Signed-off-by: Pierre Villard This closes #6894. > Update to Apache Tika 2.6.0 > --- > > Key: NIFI-10581 > URL: https://issues.apache.org/jira/browse/NIFI-10581 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: David Handermann >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10581) Update to Apache Tika 2.6.0
[ https://issues.apache.org/jira/browse/NIFI-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-10581: -- Fix Version/s: 1.20.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Update to Apache Tika 2.6.0 > --- > > Key: NIFI-10581 > URL: https://issues.apache.org/jira/browse/NIFI-10581 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: David Handermann >Priority: Major > Fix For: 1.20.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #6894: NIFI-10581 Upgrade Apache Tika from 2.4.1 to 2.6.0
asfgit closed pull request #6894: NIFI-10581 Upgrade Apache Tika from 2.4.1 to 2.6.0 URL: https://github.com/apache/nifi/pull/6894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #6821: NIFI-11022 Add DecryptContent Compatibility Processors
greyp9 commented on code in PR #6821: URL: https://github.com/apache/nifi/pull/6821#discussion_r1088221059 ## nifi-nar-bundles/nifi-cipher-bundle/nifi-cipher-processors/src/main/resources/docs/org.apache.nifi.processors.cipher.DecryptContentCompatibilityMode/additionalDetails.html: ## @@ -0,0 +1,144 @@ + + + + + +DecryptContentCompatibilityMode + + + +Summary + + This Processor supports decryption using legacy formats and Password-Based Encryption Algorithms. + https://www.rfc-editor.org/rfc/rfc8018";>RFC 8018 defines the Password-Based Cryptography Review Comment: Weird interaction here between iframe and external link. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6821: NIFI-11022 Add DecryptContent Compatibility Processors
exceptionfactory commented on code in PR #6821:
URL: https://github.com/apache/nifi/pull/6821#discussion_r1088184226
##
nifi-nar-bundles/nifi-cipher-bundle/nifi-cipher-processors/src/main/java/org/apache/nifi/processors/cipher/compatibility/CompatibilityModeEncryptionScheme.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.cipher.compatibility;
+
+import org.apache.nifi.processors.cipher.algorithm.SymmetricCipher;
+import org.apache.nifi.processors.cipher.algorithm.DigestAlgorithm;
+import org.apache.nifi.components.DescribedValue;
+
+import static org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.AES;
+import static org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.DES;
+import static
org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.DESEDE;
+import static org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.RC2;
+import static org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.RC4;
+import static
org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.TWOFISH;
+
+/**
+ * Compatibility Mode Encryption Schemes supporting decryption using legacy
algorithms such as PBES1 defined in RFC 8018 Section 6.1
+ */
+public enum CompatibilityModeEncryptionScheme implements DescribedValue {
+PBE_WITH_MD5_AND_AES_CBC_128(
+"PBEWITHMD5AND128BITAES-CBC-OPENSSL",
+DigestAlgorithm.MD5,
+AES,
+"PKCS12 with MD5 digest and Advanced Encryption Standard in Cipher
Block Chaining mode using 128 bit keys."
+),
+
+PBE_WITH_MD5_AND_AES_CBC_192(
+"PBEWITHMD5AND192BITAES-CBC-OPENSSL",
+DigestAlgorithm.MD5,
+AES,
+"PKCS12 with MD5 digest and Advanced Encryption Standard in Cipher
Block Chaining mode using 192 bit keys."
+),
+
+PBE_WITH_MD5_AND_AES_CBC_256(
+"PBEWITHMD5AND256BITAES-CBC-OPENSSL",
+DigestAlgorithm.MD5,
+AES,
+"PKCS12 with MD5 digest and Advanced Encryption Standard in Cipher
Block Chaining mode using 256 bit keys."
+),
+
+PBE_WITH_MD5_AND_DES(
+"PBEWITHMD5ANDDES",
+DigestAlgorithm.MD5,
+DES,
+"PKCS5 Scheme 1 with MD5 digest and Data Encryption Standard 64
bit keys. OID 1.2.840.113549.1.5.3"
Review Comment:
No, `PKCS5` is correct. Some schemes follow the PKCS5 strategy for password
handling, others follow PKCS12.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #6821: NIFI-11022 Add DecryptContent Compatibility Processors
greyp9 commented on code in PR #6821:
URL: https://github.com/apache/nifi/pull/6821#discussion_r1088182867
##
nifi-nar-bundles/nifi-cipher-bundle/nifi-cipher-processors/src/main/java/org/apache/nifi/processors/cipher/compatibility/CompatibilityModeEncryptionScheme.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.cipher.compatibility;
+
+import org.apache.nifi.processors.cipher.algorithm.SymmetricCipher;
+import org.apache.nifi.processors.cipher.algorithm.DigestAlgorithm;
+import org.apache.nifi.components.DescribedValue;
+
+import static org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.AES;
+import static org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.DES;
+import static
org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.DESEDE;
+import static org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.RC2;
+import static org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.RC4;
+import static
org.apache.nifi.processors.cipher.algorithm.SymmetricCipher.TWOFISH;
+
+/**
+ * Compatibility Mode Encryption Schemes supporting decryption using legacy
algorithms such as PBES1 defined in RFC 8018 Section 6.1
+ */
+public enum CompatibilityModeEncryptionScheme implements DescribedValue {
+PBE_WITH_MD5_AND_AES_CBC_128(
+"PBEWITHMD5AND128BITAES-CBC-OPENSSL",
+DigestAlgorithm.MD5,
+AES,
+"PKCS12 with MD5 digest and Advanced Encryption Standard in Cipher
Block Chaining mode using 128 bit keys."
+),
+
+PBE_WITH_MD5_AND_AES_CBC_192(
+"PBEWITHMD5AND192BITAES-CBC-OPENSSL",
+DigestAlgorithm.MD5,
+AES,
+"PKCS12 with MD5 digest and Advanced Encryption Standard in Cipher
Block Chaining mode using 192 bit keys."
+),
+
+PBE_WITH_MD5_AND_AES_CBC_256(
+"PBEWITHMD5AND256BITAES-CBC-OPENSSL",
+DigestAlgorithm.MD5,
+AES,
+"PKCS12 with MD5 digest and Advanced Encryption Standard in Cipher
Block Chaining mode using 256 bit keys."
+),
+
+PBE_WITH_MD5_AND_DES(
+"PBEWITHMD5ANDDES",
+DigestAlgorithm.MD5,
+DES,
+"PKCS5 Scheme 1 with MD5 digest and Data Encryption Standard 64
bit keys. OID 1.2.840.113549.1.5.3"
Review Comment:
> PKCS5
Is this a typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (NIFI-10973) NiFi Registry Client with Nested PGs/Flows - sync issue (again)
[
https://issues.apache.org/jira/browse/NIFI-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681060#comment-17681060
]
Mark Payne edited comment on NIFI-10973 at 1/26/23 6:02 PM:
Thanks for the PR [~simonbence] . I think there's still something wrong though.
I performed the steps that are outlined above, and it did address the specific
issue mentioned here.
However, after verifying that, I performed the following:
* Rename GenerateFlowFile in parent to "GenerateFlowFile 2"
* Rename UpdateCounter in child group
* Move to parent and view local changes. Shows just the GenerateFlowFile
rename, which is correct.
* Revert changes to child group. This succeeds.
* Now view the Local Modifications for parent. It now shows the name change
for GenerateFlowFile, but it also shows every component within "Child" as a
newly added component.
As best I can tell, this is an issue with the Revert Changes. It results in
improperly setting the Child group's Versioned Flow Coordinates. When setting
breakpoints, in the View Local Changes action, I see that in
StandardFlowComparator line 596, the two VersionedProcessGroup's have different
Storage Locations:
* Local Flow has Storage Location "http://localhost:18080";
* Remote Flow from Registry has Storage Location
"http://localhost:18080/nifi-registry-api/buckets/f2af9ccd-e2c3-4bab-9d64-c35d1e0410b4/flows/d98b5574-d955-4609-ab74-bfaea988f41d/versions/2";
In this case, we're definitely seeing this as a difference in storage location.
But not sure either why that's causing local modifications to show for each
component...
was (Author: markap14):
Thanks for the PR [~simonbence] . I think there's still something wrong though.
I performed the steps that are outlined above, and it did address the specific
issue mentioned here.
However, after verifying that, I performed the following:
* Rename GenerateFlowFile in parent to "GenerateFlowFile 2"
* Rename UpdateCounter in child group
* Move to parent and view local changes. Shows just the GenerateFlowFile
rename, which is correct.
* Revert changes to child group. This succeeds.
* Now view the Local Modifications for parent. It now shows the name change
for GenerateFlowFile, but it also shows every component within "Child" as a
newly added component.
As best I can tell, this is an issue with the Revert Changes. It results in
improperly setting the Child group's Versioned Flow Coordinates. When setting
breakpoints, in the View Local Changes action, I see that in
StandardFlowComparator line 596, the two VersionedProcessGroup's have different
Storage Locations:
* Local Flow has Storage Location "http://localhost:18080";
* Remote Flow from Registry has Storage Location
"http://localhost:18080/nifi-registry-api/buckets/f2af9ccd-e2c3-4bab-9d64-c35d1e0410b4/flows/d98b5574-d955-4609-ab74-bfaea988f41d/versions/2";
> NiFi Registry Client with Nested PGs/Flows - sync issue (again)
> ---
>
> Key: NIFI-10973
> URL: https://issues.apache.org/jira/browse/NIFI-10973
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Affects Versions: 1.19.1
>Reporter: Josef Zahner
>Assignee: Simon Bence
>Priority: Critical
> Fix For: 1.20.0
>
> Attachments: Nested_PG_Test.xml, Sync_issue_State.png,
> Sync_issue_local_changes.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We just upgraded to NiFi 1.19.1 and we have an issue with the NiFi Registry
> Client in combination with nested PGs (parent PG and child PGs are both
> commited as NiFi Registry flows).
> Steps to reproduce the issue (based on the attached template xml):
> Hint: {color:#57d9a3}Green Color {color}-> NiFi Registry flow Master;
> {color:#4c9aff}Blue Color{color} -> Secondary NiFi/Canvas where you import
> the flow from Registry
> * {color:#57d9a3}Import the XML template{color}
> * {color:#57d9a3}Start Version Control for "Child PG"{color}
> * {color:#57d9a3}Start Version Control for "Parent PG"{color}
> * {color:#4c9aff}On an independent canvas/nifi click "Add Process Group" and
> "Import from Registry", select the "Parent PG" flow{color}
> * {color:#57d9a3}On the original "Child PG" rename the only existing
> processor, eg. to "UpdateCounter New"{color}
> * {color:#57d9a3}Commit the change for the "Child PG" (Processor
> Rename){color}
> * {color:#57d9a3}Commit the change for the "Parent PG" (Version change of
> "Child PG"){color}
> * {color:#4c9aff}Now click "Change Version" on the other NiFi/Canvas and
> switch to the newest version for the "Parent PG", which seems to be
> successful. *However* *now we are hitting the issue, NiFi shows a successful
> change, but NiFi shows as well "Local Changes" for the "Child PG
[jira] [Comment Edited] (NIFI-10973) NiFi Registry Client with Nested PGs/Flows - sync issue (again)
[
https://issues.apache.org/jira/browse/NIFI-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681060#comment-17681060
]
Mark Payne edited comment on NIFI-10973 at 1/26/23 6:00 PM:
Thanks for the PR [~simonbence] . I think there's still something wrong though.
I performed the steps that are outlined above, and it did address the specific
issue mentioned here.
However, after verifying that, I performed the following:
* Rename GenerateFlowFile in parent to "GenerateFlowFile 2"
* Rename UpdateCounter in child group
* Move to parent and view local changes. Shows just the GenerateFlowFile
rename, which is correct.
* Revert changes to child group. This succeeds.
* Now view the Local Modifications for parent. It now shows the name change
for GenerateFlowFile, but it also shows every component within "Child" as a
newly added component.
As best I can tell, this is an issue with the Revert Changes. It results in
improperly setting the Child group's Versioned Flow Coordinates. When setting
breakpoints, in the View Local Changes action, I see that in
StandardFlowComparator line 596, the two VersionedProcessGroup's have different
Storage Locations:
* Local Flow has Storage Location "http://localhost:18080";
* Remote Flow from Registry has Storage Location
"http://localhost:18080/nifi-registry-api/buckets/f2af9ccd-e2c3-4bab-9d64-c35d1e0410b4/flows/d98b5574-d955-4609-ab74-bfaea988f41d/versions/2";
was (Author: markap14):
Thanks for the PR [~simonbence] . I think there's still something wrong though.
I performed the steps that are outlined above, and it did address the specific
issue mentioned here.
However, after verifying that, I performed the following:
* Rename GenerateFlowFile in parent to "GenerateFlowFile 2"
* Rename UpdateCounter in child group
* Move to parent and view local changes. Shows just the GenerateFlowFile
rename, which is correct.
* Revert changes to child group. This succeeds.
* Now view the Local Modifications for parent. It now shows the name change
for GenerateFlowFile, but it also shows every component within "Child" as a
newly added component.
> NiFi Registry Client with Nested PGs/Flows - sync issue (again)
> ---
>
> Key: NIFI-10973
> URL: https://issues.apache.org/jira/browse/NIFI-10973
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Affects Versions: 1.19.1
>Reporter: Josef Zahner
>Assignee: Simon Bence
>Priority: Critical
> Fix For: 1.20.0
>
> Attachments: Nested_PG_Test.xml, Sync_issue_State.png,
> Sync_issue_local_changes.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We just upgraded to NiFi 1.19.1 and we have an issue with the NiFi Registry
> Client in combination with nested PGs (parent PG and child PGs are both
> commited as NiFi Registry flows).
> Steps to reproduce the issue (based on the attached template xml):
> Hint: {color:#57d9a3}Green Color {color}-> NiFi Registry flow Master;
> {color:#4c9aff}Blue Color{color} -> Secondary NiFi/Canvas where you import
> the flow from Registry
> * {color:#57d9a3}Import the XML template{color}
> * {color:#57d9a3}Start Version Control for "Child PG"{color}
> * {color:#57d9a3}Start Version Control for "Parent PG"{color}
> * {color:#4c9aff}On an independent canvas/nifi click "Add Process Group" and
> "Import from Registry", select the "Parent PG" flow{color}
> * {color:#57d9a3}On the original "Child PG" rename the only existing
> processor, eg. to "UpdateCounter New"{color}
> * {color:#57d9a3}Commit the change for the "Child PG" (Processor
> Rename){color}
> * {color:#57d9a3}Commit the change for the "Parent PG" (Version change of
> "Child PG"){color}
> * {color:#4c9aff}Now click "Change Version" on the other NiFi/Canvas and
> switch to the newest version for the "Parent PG", which seems to be
> successful. *However* *now we are hitting the issue, NiFi shows a successful
> change, but NiFi shows as well "Local Changes" for the "Child PG" (not for
> the "Parent PG"). To get a good state you have to click to "Revert Local
> Changes" on the "Child PG" which makes no sense, it should directly sync the
> "Child PG" according to the commited version. At least the version number of
> the "Child PG" has been changed but not the real configuration as you see
> below in the screenshots. It shows that there has been a component name
> change, which is true for the version but to get to the new version we have
> to revert the local changes*{color}
>
> Screenshots with the Failure State below, "Parent PG" is in sync, but not the
> "Child PG". The only thing I've done is to change the Version on the "Parent
> PG":
> {color:#4c9aff}*!Sync_issue_State.png!*{color}
>
>
[GitHub] [nifi] exceptionfactory commented on pull request #6761: NIFI-10952 - Fix TestScriptedPartitionRecord.testWhenMultiplePartitions
exceptionfactory commented on PR #6761: URL: https://github.com/apache/nifi/pull/6761#issuecomment-1405386167 Closing this pull request for now since the proposed changes break expectations in existing the unit test: ``` TestScriptedPartitionRecord.testWhenMultiplePartitions:94->thenPartitionContains:160 expected:<[1]> but was:<[0]> ``` Feel free to reopen the PR or submit a new one after confirming a successful run with `mvn clean install -am -pl :nifi-scripting-processors`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6761: NIFI-10952 - Fix TestScriptedPartitionRecord.testWhenMultiplePartitions
exceptionfactory closed pull request #6761: NIFI-10952 - Fix TestScriptedPartitionRecord.testWhenMultiplePartitions URL: https://github.com/apache/nifi/pull/6761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-10973) NiFi Registry Client with Nested PGs/Flows - sync issue (again)
[
https://issues.apache.org/jira/browse/NIFI-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681060#comment-17681060
]
Mark Payne commented on NIFI-10973:
---
Thanks for the PR [~simonbence] . I think there's still something wrong though.
I performed the steps that are outlined above, and it did address the specific
issue mentioned here.
However, after verifying that, I performed the following:
* Rename GenerateFlowFile in parent to "GenerateFlowFile 2"
* Rename UpdateCounter in child group
* Move to parent and view local changes. Shows just the GenerateFlowFile
rename, which is correct.
* Revert changes to child group. This succeeds.
* Now view the Local Modifications for parent. It now shows the name change
for GenerateFlowFile, but it also shows every component within "Child" as a
newly added component.
> NiFi Registry Client with Nested PGs/Flows - sync issue (again)
> ---
>
> Key: NIFI-10973
> URL: https://issues.apache.org/jira/browse/NIFI-10973
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Affects Versions: 1.19.1
>Reporter: Josef Zahner
>Assignee: Simon Bence
>Priority: Critical
> Fix For: 1.20.0
>
> Attachments: Nested_PG_Test.xml, Sync_issue_State.png,
> Sync_issue_local_changes.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We just upgraded to NiFi 1.19.1 and we have an issue with the NiFi Registry
> Client in combination with nested PGs (parent PG and child PGs are both
> commited as NiFi Registry flows).
> Steps to reproduce the issue (based on the attached template xml):
> Hint: {color:#57d9a3}Green Color {color}-> NiFi Registry flow Master;
> {color:#4c9aff}Blue Color{color} -> Secondary NiFi/Canvas where you import
> the flow from Registry
> * {color:#57d9a3}Import the XML template{color}
> * {color:#57d9a3}Start Version Control for "Child PG"{color}
> * {color:#57d9a3}Start Version Control for "Parent PG"{color}
> * {color:#4c9aff}On an independent canvas/nifi click "Add Process Group" and
> "Import from Registry", select the "Parent PG" flow{color}
> * {color:#57d9a3}On the original "Child PG" rename the only existing
> processor, eg. to "UpdateCounter New"{color}
> * {color:#57d9a3}Commit the change for the "Child PG" (Processor
> Rename){color}
> * {color:#57d9a3}Commit the change for the "Parent PG" (Version change of
> "Child PG"){color}
> * {color:#4c9aff}Now click "Change Version" on the other NiFi/Canvas and
> switch to the newest version for the "Parent PG", which seems to be
> successful. *However* *now we are hitting the issue, NiFi shows a successful
> change, but NiFi shows as well "Local Changes" for the "Child PG" (not for
> the "Parent PG"). To get a good state you have to click to "Revert Local
> Changes" on the "Child PG" which makes no sense, it should directly sync the
> "Child PG" according to the commited version. At least the version number of
> the "Child PG" has been changed but not the real configuration as you see
> below in the screenshots. It shows that there has been a component name
> change, which is true for the version but to get to the new version we have
> to revert the local changes*{color}
>
> Screenshots with the Failure State below, "Parent PG" is in sync, but not the
> "Child PG". The only thing I've done is to change the Version on the "Parent
> PG":
> {color:#4c9aff}*!Sync_issue_State.png!*{color}
>
> {color:#4c9aff}*!Sync_issue_local_changes.png!*{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11098) Deprecate ProcessContext encrypt and decrypt methods
[
https://issues.apache.org/jira/browse/NIFI-11098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681053#comment-17681053
]
ASF subversion and git services commented on NIFI-11098:
Commit d60f541d7edc89b968a932109be3c088b3d1bcf8 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d60f541d7e ]
NIFI-11098 Deprecated ProcessContext encrypt and decrypt methods
Signed-off-by: Pierre Villard
This closes #6891.
> Deprecate ProcessContext encrypt and decrypt methods
>
>
> Key: NIFI-11098
> URL: https://issues.apache.org/jira/browse/NIFI-11098
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{ProcessContext}} interface includes methods for encrypting and
> decrypting strings using the Sensitive Properties Key and Sensitive
> Properties Algorithm configured in {{nifi.properties}}. The deprecated
> {{GetJMSTopic}} Processor is the only component that uses these methods.
> Although these methods provide some potential conveniences, they introduce
> tight coupling between framework configuration settings and Processor
> implementation. Changing either the Sensitive Properties Key or Sensitive
> Properties Algorithm would break reading values encrypted using previous
> settings, with no programmatic way to recover the information. Requiring
> strings as input also necessitates using some prior encoding strategy to
> handle binary information.
> In light of the minimal usage of these methods and the potential
> implementation concerns, the encrypt and decrypt methods should be deprecated
> for removal in subsequent major versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] joewitt commented on pull request #6891: NIFI-11098 Deprecate ProcessContext encrypt and decrypt methods
joewitt commented on PR #6891: URL: https://github.com/apache/nifi/pull/6891#issuecomment-1405340765 We need to flag this for 2.0 migration guidance and have an associated 2.0 ticket if we don't. For custom things using this they WILL break and we've tried ultra hard to avoid such nifi-api changes. I think on balance this is the right thing but we need to give great guidance on this with caveats to the 2.0 adopters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11098) Deprecate ProcessContext encrypt and decrypt methods
[
https://issues.apache.org/jira/browse/NIFI-11098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard updated NIFI-11098:
--
Fix Version/s: 1.20.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Deprecate ProcessContext encrypt and decrypt methods
>
>
> Key: NIFI-11098
> URL: https://issues.apache.org/jira/browse/NIFI-11098
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.20.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{ProcessContext}} interface includes methods for encrypting and
> decrypting strings using the Sensitive Properties Key and Sensitive
> Properties Algorithm configured in {{nifi.properties}}. The deprecated
> {{GetJMSTopic}} Processor is the only component that uses these methods.
> Although these methods provide some potential conveniences, they introduce
> tight coupling between framework configuration settings and Processor
> implementation. Changing either the Sensitive Properties Key or Sensitive
> Properties Algorithm would break reading values encrypted using previous
> settings, with no programmatic way to recover the information. Requiring
> strings as input also necessitates using some prior encoding strategy to
> handle binary information.
> In light of the minimal usage of these methods and the potential
> implementation concerns, the encrypt and decrypt methods should be deprecated
> for removal in subsequent major versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #6891: NIFI-11098 Deprecate ProcessContext encrypt and decrypt methods
asfgit closed pull request #6891: NIFI-11098 Deprecate ProcessContext encrypt and decrypt methods URL: https://github.com/apache/nifi/pull/6891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11101) Deprecate the ConsumeEWS Processor
[ https://issues.apache.org/jira/browse/NIFI-11101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681047#comment-17681047 ] ASF subversion and git services commented on NIFI-11101: Commit 97cb3c4eaa0eb509653e7e4f5182ef7bcb7e2bd6 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=97cb3c4eaa ] NIFI-11101 Deprecated ConsumeEWS Processor Signed-off-by: Pierre Villard This closes #6893. > Deprecate the ConsumeEWS Processor > -- > > Key: NIFI-11101 > URL: https://issues.apache.org/jira/browse/NIFI-11101 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The ConsumeEWS Processor uses the > [ews-java-api|https://github.com/OfficeDev/ews-java-api] library, which is no > longer receiving updates as of 2018. > Microsoft recommends using the [Graph > API|https://devblogs.microsoft.com/microsoft365dev/upcoming-changes-to-exchange-web-services-ews-api-for-office-365/] > for accessing Office 365. > The ConsumeEWS Processor should be deprecated for removal in subsequent major > releases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11101) Deprecate the ConsumeEWS Processor
[ https://issues.apache.org/jira/browse/NIFI-11101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-11101: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Deprecate the ConsumeEWS Processor > -- > > Key: NIFI-11101 > URL: https://issues.apache.org/jira/browse/NIFI-11101 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > The ConsumeEWS Processor uses the > [ews-java-api|https://github.com/OfficeDev/ews-java-api] library, which is no > longer receiving updates as of 2018. > Microsoft recommends using the [Graph > API|https://devblogs.microsoft.com/microsoft365dev/upcoming-changes-to-exchange-web-services-ews-api-for-office-365/] > for accessing Office 365. > The ConsumeEWS Processor should be deprecated for removal in subsequent major > releases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #6893: NIFI-11101 Deprecate ConsumeEWS Processor
asfgit closed pull request #6893: NIFI-11101 Deprecate ConsumeEWS Processor URL: https://github.com/apache/nifi/pull/6893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11104) Switch to NiFi Maven Nar Plugin 1.4.0
Joe Witt created NIFI-11104: --- Summary: Switch to NiFi Maven Nar Plugin 1.4.0 Key: NIFI-11104 URL: https://issues.apache.org/jira/browse/NIFI-11104 Project: Apache NiFi Issue Type: Task Components: Core Framework Reporter: Joe Witt Assignee: Joe Witt Fix For: 1.20.0 Waiting on the RC/vote then will pull it in. Kevin Doran RM'ing that release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11102) Make property text editor open to a larger size depending on text size
[ https://issues.apache.org/jira/browse/NIFI-11102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Bretz updated NIFI-11102: --- Description: The property editor text box opens to a small default size, and needs to be clicked and dragged open often when using properties to store larger text values (SQL, Script Code, Jolt Specs). I often encounter situations where UpdateAttribute or similar attribute-creating processors are convenient to store code or sql configurations that need to be attached to a FlowFile for execution later in a flow, but repeated editing or examination of these values is cumbersome in a small default editor. A desired improvement would be to open the box to a larger default size depending on the size of the value currently occupying the property, if possible, or open to a larger size if the value is expected to contain larger text types. Other processors where this would be helpful: ExecuteSQL, ExecuteScript, QueryRecord was: The property editor text box opens to a small default size, and needs to be clicked and dragged open often when using properties to store larger text values (SQL, Script Code, Jolt Specs). I often encounter situations where UpdateAttribute or similar attribute-creating processors are convenient to store code or sql configurations that need to be attached to a FlowFile for execution later in a flow, but repeated editing or examination of these values is cumbersome in a small default editor. A desired improvement would be to open the box to a larger default size depending on the size of the value currently occupying the property, if possible. Other processors where this would be helpful: ExecuteSQL, ExecuteScript, QueryRecord > Make property text editor open to a larger size depending on text size > -- > > Key: NIFI-11102 > URL: https://issues.apache.org/jira/browse/NIFI-11102 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.19.1 >Reporter: Shane Bretz >Priority: Minor > Attachments: ExecuteScriptUseCase.PNG, UpdateAttributeUseCase.PNG > > > The property editor text box opens to a small default size, and needs to be > clicked and dragged open often when using properties to store larger text > values (SQL, Script Code, Jolt Specs). I often encounter situations where > UpdateAttribute or similar attribute-creating processors are convenient to > store code or sql configurations that need to be attached to a FlowFile for > execution later in a flow, but repeated editing or examination of these > values is cumbersome in a small default editor. > A desired improvement would be to open the box to a larger default size > depending on the size of the value currently occupying the property, if > possible, or open to a larger size if the value is expected to contain larger > text types. > Other processors where this would be helpful: ExecuteSQL, ExecuteScript, > QueryRecord > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11103) Conduct Apache NiFi 1.20 release
Joe Witt created NIFI-11103: --- Summary: Conduct Apache NiFi 1.20 release Key: NIFI-11103 URL: https://issues.apache.org/jira/browse/NIFI-11103 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt Fix For: 1.20.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11097) RegistryClientIT System Test Fails on Client Name
[
https://issues.apache.org/jira/browse/NIFI-11097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-11097:
Resolution: Fixed
Status: Resolved (was: Patch Available)
thanks merged
> RegistryClientIT System Test Fails on Client Name
> -
>
> Key: NIFI-11097
> URL: https://issues.apache.org/jira/browse/NIFI-11097
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Critical
> Fix For: 1.20.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Recent changes adding uniqueness check for Flow Registry Client names
> resulted in failures in the {{RegistryClientIT}} System Test, which creates
> multiple instances using same name.
> {noformat}
> Error:
> RegistryClientIT.testCopyPasteProcessGroupDoesNotDuplicateVersionedComponentId:119->registerClient:70
> » NiFiClient Error creating registry client: A Flow Registry already exists
> with the name FileRegistry
> Error:
> RegistryClientIT.testStartVersionControlThenImport:49->registerClient:70 »
> NiFiClient Error creating registry client: A Flow Registry already exists
> with the name FileRegistry
> Error:
> RegistryClientIT.testStartVersionControlThenModifyAndRevert:80->registerClient:70
> » NiFiClient Error creating registry client: A Flow Registry already exists
> with the name FileRegistry
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11097) RegistryClientIT System Test Fails on Client Name
[
https://issues.apache.org/jira/browse/NIFI-11097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681039#comment-17681039
]
ASF subversion and git services commented on NIFI-11097:
Commit e264f1fd7723a0913a3337ff32db104821ce22e8 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e264f1fd77 ]
NIFI-11097 This closes #6890. Adjusted RegistryClientIT with unique name for
Clients
Signed-off-by: Joe Witt
> RegistryClientIT System Test Fails on Client Name
> -
>
> Key: NIFI-11097
> URL: https://issues.apache.org/jira/browse/NIFI-11097
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Critical
> Fix For: 1.20.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Recent changes adding uniqueness check for Flow Registry Client names
> resulted in failures in the {{RegistryClientIT}} System Test, which creates
> multiple instances using same name.
> {noformat}
> Error:
> RegistryClientIT.testCopyPasteProcessGroupDoesNotDuplicateVersionedComponentId:119->registerClient:70
> » NiFiClient Error creating registry client: A Flow Registry already exists
> with the name FileRegistry
> Error:
> RegistryClientIT.testStartVersionControlThenImport:49->registerClient:70 »
> NiFiClient Error creating registry client: A Flow Registry already exists
> with the name FileRegistry
> Error:
> RegistryClientIT.testStartVersionControlThenModifyAndRevert:80->registerClient:70
> » NiFiClient Error creating registry client: A Flow Registry already exists
> with the name FileRegistry
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #6890: NIFI-11097 Adjust RegistryClientIT with unique name for Clients
asfgit closed pull request #6890: NIFI-11097 Adjust RegistryClientIT with unique name for Clients URL: https://github.com/apache/nifi/pull/6890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11102) Make property text editor open to a larger size depending on text size
Shane Bretz created NIFI-11102: -- Summary: Make property text editor open to a larger size depending on text size Key: NIFI-11102 URL: https://issues.apache.org/jira/browse/NIFI-11102 Project: Apache NiFi Issue Type: Improvement Components: Core UI Affects Versions: 1.19.1 Reporter: Shane Bretz Attachments: ExecuteScriptUseCase.PNG, UpdateAttributeUseCase.PNG The property editor text box opens to a small default size, and needs to be clicked and dragged open often when using properties to store larger text values (SQL, Script Code, Jolt Specs). I often encounter situations where UpdateAttribute or similar attribute-creating processors are convenient to store code or sql configurations that need to be attached to a FlowFile for execution later in a flow, but repeated editing or examination of these values is cumbersome in a small default editor. A desired improvement would be to open the box to a larger default size depending on the size of the value currently occupying the property, if possible. Other processors where this would be helpful: ExecuteSQL, ExecuteScript, QueryRecord -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10581) Update to Apache Tika 2.6.0
[ https://issues.apache.org/jira/browse/NIFI-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10581: Status: Patch Available (was: Open) > Update to Apache Tika 2.6.0 > --- > > Key: NIFI-10581 > URL: https://issues.apache.org/jira/browse/NIFI-10581 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: David Handermann >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #6894: NIFI-10581 Upgrade Apache Tika from 2.4.1 to 2.6.0
exceptionfactory opened a new pull request, #6894: URL: https://github.com/apache/nifi/pull/6894 # Summary [NIFI-10581](https://issues.apache.org/jira/browse/NIFI-10581) Upgrades Apache Tika dependencies from 2.4.1 to [2.6.0](https://dist.apache.org/repos/dist/release/tika/2.6.0/CHANGES-2.6.0.txt). Apache Tika 2.5.0 included a transitive dependency on SLF4J 2.0, which was upgraded in PR #6867 for NIFI-10580. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start
szaszm commented on code in PR #1498: URL: https://github.com/apache/nifi-minifi-cpp/pull/1498#discussion_r1088076713 ## minifi_main/MiNiFiWindowsService.h: ## @@ -20,10 +20,12 @@ #ifdef WIN32 #include +#include + #include "core/Core.h" void RunAsServiceIfNeeded(); -HANDLE GetTerminationEventHandle(bool* isStartedByService); +std::tuple GetTerminationEventHandle(); Review Comment: I think a trivial aggregate struct would be better, since it would allow naming the parts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-10581) Update to Apache Tika 2.6.0
[ https://issues.apache.org/jira/browse/NIFI-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-10581: --- Assignee: David Handermann (was: Joe Witt) > Update to Apache Tika 2.6.0 > --- > > Key: NIFI-10581 > URL: https://issues.apache.org/jira/browse/NIFI-10581 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: David Handermann >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10581) Update to Apache Tika 2.6.0
[ https://issues.apache.org/jira/browse/NIFI-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10581: Summary: Update to Apache Tika 2.6.0 (was: Update to Apache Tika 2.5.0) > Update to Apache Tika 2.6.0 > --- > > Key: NIFI-10581 > URL: https://issues.apache.org/jira/browse/NIFI-10581 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1498: MINIFICPP-2020 Improve error messages when MiNiFi is not able to start
fgerlits opened a new pull request, #1498: URL: https://github.com/apache/nifi-minifi-cpp/pull/1498 This came out of investigating https://issues.apache.org/jira/browse/MINIFICPP-2020, and doesn't solve any of the problems (also, it's not clear whether there are any problems really), but at least it improves the error messages. In particular, it was quite bad that in one case MiNiFi just quit without giving any error messages at all. Also, I did not like the fact that `minifi docs` (without any arguments) started up MiNiFi in normal mode, ignoring the "docs" argument, instead of telling the user to give additional arguments. --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1497: MINIFICPP-1869 Metrics-related refactoring
lordgamez opened a new pull request, #1497: URL: https://github.com/apache/nifi-minifi-cpp/pull/1497 Notable changes: - FlowController ise separated from C2Client - C2Client is separated by functionality to C2Agent and C2MetricsPublisher - MetricsPublisherStore is introduced to instantiate metrics publishers when configured through MetricsPublisherFactory - Response nodes are ensured to be not null - ConnectionStore is aggregated instead of inherited from - Root process group functionalities and flow change operations are moved to RootProcessGroupWrapper - ResponseNodeLoader is shared between metrics publishers - FlowConfiguration is shared between FlowController and ResponseNodeLoader - Unnecessary contructor parameters are removed from FlowController, metrics and C2 are made optional - Controller service provider update is centralized to the extracted FlowController::updateFromPayload function - ResponseNodeLoader's state now contains a pointer to the root process group - RestSender initialization crash avoided when controller is nullptr https://issues.apache.org/jira/browse/MINIFICPP-1869 - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2020) Fix the code which is supposed to stop two MiNiFi instances from interfering with each other
[
https://issues.apache.org/jira/browse/MINIFICPP-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-2020:
--
Description:
On Windows,
* (x) if MiNiFi is already running as a service and you try to start another
instance from the console, then the second instance will exit with %errorlevel%
== -1, but without any message printed to either the console or the log file,
because GetTerminationEventHandle returns a null pointer;
* (/) if MiNiFi is not running as a service, you can start up two instances
with different MINIFI_HOMES from the console;
* (?) if you start up a MiNiFi instance from the console, then you start the
MiNiFi service, that works (assuming their MINIFI_HOMEs are different).
On Linux,
* (/) you can start up two instances as long as their MINIFI_HOMEs are
different.
On both,
* (?) if you try to start up two MiNiFi instances with the same MINIFI_HOME,
it will fail, as long as some repositories are RocksDB, because RocksDB can't
open the repo if another process has it open already.
In theory, the process semaphore should stop the last case before trying to
open the DBs, but it doesn't, because we open the semaphore in non-exclusive
mode. Opening the process semaphore in exclusive mode (with no other changes)
would be a bad solution, because in the case of a crash or a kill signal, the
stale semaphore would stop the user from starting a new MiNiFi instance and
would have to be removed manually.
was:
If you start the {{minifi}} executable on Windows as a non-Admin user, it exits
with code -1 immediately, without any error message.
-Also, document generation in {{MiNiFiMain.cpp}} should be moved outside of the
complicated restarting mechanism, as it doesn't need it.- (I have decided not
to do this, because to generate docs, we need to load the extensions, which
requires loading {{{}minifi.properties{}}}. We could duplicate this before the
main retry loop, but there is no real reason to do so.)
> Fix the code which is supposed to stop two MiNiFi instances from interfering
> with each other
>
>
> Key: MINIFICPP-2020
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2020
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Ferenc Gerlits
>Assignee: Ferenc Gerlits
>Priority: Minor
> Fix For: 0.14.0
>
>
> On Windows,
> * (x) if MiNiFi is already running as a service and you try to start another
> instance from the console, then the second instance will exit with
> %errorlevel% == -1, but without any message printed to either the console or
> the log file, because GetTerminationEventHandle returns a null pointer;
> * (/) if MiNiFi is not running as a service, you can start up two instances
> with different MINIFI_HOMES from the console;
> * (?) if you start up a MiNiFi instance from the console, then you start the
> MiNiFi service, that works (assuming their MINIFI_HOMEs are different).
> On Linux,
> * (/) you can start up two instances as long as their MINIFI_HOMEs are
> different.
> On both,
> * (?) if you try to start up two MiNiFi instances with the same MINIFI_HOME,
> it will fail, as long as some repositories are RocksDB, because RocksDB can't
> open the repo if another process has it open already.
>
> In theory, the process semaphore should stop the last case before trying to
> open the DBs, but it doesn't, because we open the semaphore in non-exclusive
> mode. Opening the process semaphore in exclusive mode (with no other
> changes) would be a bad solution, because in the case of a crash or a kill
> signal, the stale semaphore would stop the user from starting a new MiNiFi
> instance and would have to be removed manually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2020) Fix the code which is supposed to stop two MiNiFi instances from interfering with each other
[
https://issues.apache.org/jira/browse/MINIFICPP-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-2020:
--
Summary: Fix the code which is supposed to stop two MiNiFi instances from
interfering with each other (was: Minifi main cannot be run on Windows as a
normal (non-Admin) user)
> Fix the code which is supposed to stop two MiNiFi instances from interfering
> with each other
>
>
> Key: MINIFICPP-2020
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2020
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Ferenc Gerlits
>Assignee: Ferenc Gerlits
>Priority: Minor
> Fix For: 0.14.0
>
>
> If you start the {{minifi}} executable on Windows as a non-Admin user, it
> exits with code -1 immediately, without any error message.
> -Also, document generation in {{MiNiFiMain.cpp}} should be moved outside of
> the complicated restarting mechanism, as it doesn't need it.- (I have
> decided not to do this, because to generate docs, we need to load the
> extensions, which requires loading {{{}minifi.properties{}}}. We could
> duplicate this before the main retry loop, but there is no real reason to do
> so.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MINIFICPP-2038) Update SSL context of C2 agent after flow update
Gábor Gyimesi created MINIFICPP-2038: Summary: Update SSL context of C2 agent after flow update Key: MINIFICPP-2038 URL: https://issues.apache.org/jira/browse/MINIFICPP-2038 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Gábor Gyimesi SSLContext for C2 communication is retrieved from the SSLContextService defined in the flow configuration. In case of a flow configuration update we should update the C2Agents's SSLContext if it is changed in the updated flow. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2037) Build SSLContext from minifi.properties for SSL communication on C2
Gábor Gyimesi created MINIFICPP-2037: Summary: Build SSLContext from minifi.properties for SSL communication on C2 Key: MINIFICPP-2037 URL: https://issues.apache.org/jira/browse/MINIFICPP-2037 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Gábor Gyimesi If we want to use SSL for C2 communication we have to define an SSLContextService in the flow configuration with the certificate information used for the SSL connection. If the flow fetched from the C2 server and the agent is started with an empty flow configuration this is not possible. We should be able to retrieve the needed SSL information from the minifi.properties file as well if we are not able to provide it in the flow configuration. There is a similar use case for this in the RemoteProcessorGroupPort where the SSLContextService is built manually from the information provided in the minifi.properties file. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6730: NIFI-10721 No querying for props after successful blob upload
exceptionfactory commented on code in PR #6730:
URL: https://github.com/apache/nifi/pull/6730#discussion_r1087976818
##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage_v12.java:
##
@@ -191,4 +198,13 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
session.transfer(flowFile, REL_FAILURE);
}
}
+
+private static void applyUploadResultAttributes(final Map
attributes, final BlockBlobItem blob, final BlobType blobType, final long
length) {
+attributes.put(ATTR_NAME_BLOBTYPE, blobType.toString());
+attributes.put(ATTR_NAME_ETAG, blob.getETag());
+attributes.put(ATTR_NAME_LENGTH, String.valueOf(length));
+attributes.put(ATTR_NAME_TIMESTAMP,
String.valueOf(blob.getLastModified()));
+attributes.put(ATTR_NAME_LANG, null);
+attributes.put(ATTR_NAME_MIME_TYPE, APPLICATION_OCTET_STREAM);
Review Comment:
Thanks, keeping the current behavior for this PR makes sense, it sounds like
something to consider for future improvement in a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (NIFI-7364) Document changes in office 365 support for EWS in consumeEWS processor
[ https://issues.apache.org/jira/browse/NIFI-7364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-7364. Resolution: Won't Fix With the supporting ews-java-api library no longer maintained as of 2018, additional updates to the ConsumeEWS Processor are not planned. Implementing a new Processor as described in NIFI-7365 seems like the best way forward. > Document changes in office 365 support for EWS in consumeEWS processor > -- > > Key: NIFI-7364 > URL: https://issues.apache.org/jira/browse/NIFI-7364 > Project: Apache NiFi > Issue Type: Task > Components: Documentation & Website >Affects Versions: 1.11.4 >Reporter: Otto Fowler >Assignee: Otto Fowler >Priority: Major > Labels: doc > > Microsoft has deprecated the EWS service. While older, presumably on prem > installations of exchange will still work, the current office 365 will not, > as basic authentication will not work. > The documentation of the processor should be updated to reflect this. > https://developer.microsoft.com/en-us/graph/blogs/upcoming-changes-to-exchange-web-services-ews-api-for-office-365/ > "Today, we are announcing that on October 13th, 2020 we will stop supporting > and fully decommission the Basic Authentication for EWS to access Exchange > Online. This means that new or existing apps will not be able to use Basic > Authentication when connecting to Exchange using EWS." > Well, it is past October 13th. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-6951) Support for shared Mailboxes in ConsumeEWS
[ https://issues.apache.org/jira/browse/NIFI-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-6951. Resolution: Won't Fix The supporting ews-java-api is no longer maintained, so additional updates to the ConsumeEWS Processor are not planned. > Support for shared Mailboxes in ConsumeEWS > -- > > Key: NIFI-6951 > URL: https://issues.apache.org/jira/browse/NIFI-6951 > Project: Apache NiFi > Issue Type: Wish > Components: Extensions >Reporter: Alois Gruber >Priority: Minor > > currently, folders are retrieved from the personal mailbox of the login user > an optional attribute "email address" to specify a dedicated shared mailbox > where the folder resides, would explicitly allow a technical account to > retrieve data from various mailboxes > if the attribute is not set, the processor works as it is now -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-4036) ConsumeEWS cannot handle 0 recipients
[ https://issues.apache.org/jira/browse/NIFI-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-4036. Resolution: Won't Fix The supporting ews-java-api is no longer maintained, so additional updates to the ConsumeEWS Processor are not planned. > ConsumeEWS cannot handle 0 recipients > - > > Key: NIFI-4036 > URL: https://issues.apache.org/jira/browse/NIFI-4036 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.2.0 > Environment: Windows 7, but also within a docker-environment >Reporter: Tim Fohrer >Priority: Major > Attachments: nifi-app.log > > > ConsumeEWS throws exceptions (stacktrace as attachment), when a mail within > the folder which has to be read has 0 recipients (to) but only bcc recipients. > This mail cannot be fetched and further transported within the flow. > Even more problematic is the fact, that other mails, which are also in the > folder and have to be read and transported, get lost. nifi just seems to > delete them on the exchange server and then forgets about them. they do not > appear as provenance data nor as a message in the success queue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11101) Deprecate the ConsumeEWS Processor
[ https://issues.apache.org/jira/browse/NIFI-11101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11101: Status: Patch Available (was: Open) > Deprecate the ConsumeEWS Processor > -- > > Key: NIFI-11101 > URL: https://issues.apache.org/jira/browse/NIFI-11101 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The ConsumeEWS Processor uses the > [ews-java-api|https://github.com/OfficeDev/ews-java-api] library, which is no > longer receiving updates as of 2018. > Microsoft recommends using the [Graph > API|https://devblogs.microsoft.com/microsoft365dev/upcoming-changes-to-exchange-web-services-ews-api-for-office-365/] > for accessing Office 365. > The ConsumeEWS Processor should be deprecated for removal in subsequent major > releases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #6893: NIFI-11101 Deprecate ConsumeEWS Processor
exceptionfactory opened a new pull request, #6893: URL: https://github.com/apache/nifi/pull/6893 # Summary [NIFI-11101](https://issues.apache.org/jira/browse/NIFI-11101) Deprecates the `ConsumeEWS` Processor for removal in subsequent major releases. The supporting [ews-java-api](https://github.com/OfficeDev/ews-java-api) library is no longer maintained as of 2018, and Microsoft recommends using the [REST Graph API](https://devblogs.microsoft.com/microsoft365dev/upcoming-changes-to-exchange-web-services-ews-api-for-office-365/) for accessing Office 365 services. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11101) Deprecate the ConsumeEWS Processor
David Handermann created NIFI-11101: --- Summary: Deprecate the ConsumeEWS Processor Key: NIFI-11101 URL: https://issues.apache.org/jira/browse/NIFI-11101 Project: Apache NiFi Issue Type: Improvement Reporter: David Handermann Assignee: David Handermann The ConsumeEWS Processor uses the [ews-java-api|https://github.com/OfficeDev/ews-java-api] library, which is no longer receiving updates as of 2018. Microsoft recommends using the [Graph API|https://devblogs.microsoft.com/microsoft365dev/upcoming-changes-to-exchange-web-services-ews-api-for-office-365/] for accessing Office 365. The ConsumeEWS Processor should be deprecated for removal in subsequent major releases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10974) Incorrect warning message on memory usage from MonitorMemory
[
https://issues.apache.org/jira/browse/NIFI-10974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Palfy updated NIFI-10974:
---
Fix Version/s: 1.20.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Incorrect warning message on memory usage from MonitorMemory
>
>
> Key: NIFI-10974
> URL: https://issues.apache.org/jira/browse/NIFI-10974
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Mark Bathori
>Assignee: Mark Bathori
>Priority: Major
> Fix For: 1.20.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> There are certain cases when the MonitorMemory reporting task is sending
> incorrect warning messages on memory usage crossing the threshold.
> {+}Repro steps{+}:
> * In the MonitorMemory reporting task, set the threshold value to low enough
> that the current memory usage is crossing that value.
> * Restart NiFi while the monitoring task is still running.
> * After the restart set the threshold to higher value above the actual
> memory usage.
> * The warning messages will be still send despite the threshold is above the
> actual memory usage.
> The main problem is that the *isCollectionUsageThresholdExceeded()* method
> call on *MemoryPoolMXBean* have a *gcSensor* registered at the VM that's 'on'
> attribute will get stuck on 'true' value. This will cause the method to
> always return with exceeded. The sensor will get reseted on the next garbage
> collection but until that it will send false messages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] turcsanyip closed pull request #6783: NIFI-10974: Incorrect warning message on memory usage from MonitorMemory
turcsanyip closed pull request #6783: NIFI-10974: Incorrect warning message on memory usage from MonitorMemory URL: https://github.com/apache/nifi/pull/6783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] tpalfy commented on pull request #6783: NIFI-10974: Incorrect warning message on memory usage from MonitorMemory
tpalfy commented on PR #6783: URL: https://github.com/apache/nifi/pull/6783#issuecomment-1404932359 LGTM Thanks for your work @mark-bathori and for the review @NissimShiman ! Merged to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-10974) Incorrect warning message on memory usage from MonitorMemory
[
https://issues.apache.org/jira/browse/NIFI-10974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680977#comment-17680977
]
ASF subversion and git services commented on NIFI-10974:
Commit c3dd2569dbaddf11c1be114921e34cd9c96393a5 in nifi's branch
refs/heads/main from Mark Bathori
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c3dd2569db ]
NIFI-10974: Incorrect warning message on memory usage from MonitorMemory
> Incorrect warning message on memory usage from MonitorMemory
>
>
> Key: NIFI-10974
> URL: https://issues.apache.org/jira/browse/NIFI-10974
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Mark Bathori
>Assignee: Mark Bathori
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> There are certain cases when the MonitorMemory reporting task is sending
> incorrect warning messages on memory usage crossing the threshold.
> {+}Repro steps{+}:
> * In the MonitorMemory reporting task, set the threshold value to low enough
> that the current memory usage is crossing that value.
> * Restart NiFi while the monitoring task is still running.
> * After the restart set the threshold to higher value above the actual
> memory usage.
> * The warning messages will be still send despite the threshold is above the
> actual memory usage.
> The main problem is that the *isCollectionUsageThresholdExceeded()* method
> call on *MemoryPoolMXBean* have a *gcSensor* registered at the VM that's 'on'
> attribute will get stuck on 'true' value. This will cause the method to
> always return with exceeded. The sensor will get reseted on the next garbage
> collection but until that it will send false messages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-11100) Cannot update controller service property of an inner process group when changing version
Joe Gresock created NIFI-11100: -- Summary: Cannot update controller service property of an inner process group when changing version Key: NIFI-11100 URL: https://issues.apache.org/jira/browse/NIFI-11100 Project: Apache NiFi Issue Type: Bug Affects Versions: 1.19.1 Reporter: Joe Gresock Assignee: Joe Gresock To reproduce: # Create a process group, and add a CSVReader controller service to that group, named "Outer" # Create a process group inside that group, and add a CSVReader controller service the inner group, named "Inner" # Add a CalculateRecordStats processor (or any with a reader property) and select the Inner service. # Version control the outer group. # Change the property to point to Inner. # Save the version. # Change the version back to 1: the property will have remained unchanged -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1477: MINIFICPP-2016 Add session commit time metrics
lordgamez commented on code in PR #1477:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1477#discussion_r1087563159
##
libminifi/src/core/ProcessorMetrics.cpp:
##
@@ -105,6 +110,17 @@ std::chrono::milliseconds
ProcessorMetrics::getLastOnTriggerRuntime() const {
return on_trigger_runtime_averager_.getLastValue();
}
+std::chrono::milliseconds ProcessorMetrics::getAverageSessionCommitRuntime()
const {
+ return session_commit_runtime_averager_.getAverage();
+}
+
+void ProcessorMetrics::addLastSessionCommitRuntime(std::chrono::milliseconds
runtime) {
+ session_commit_runtime_averager_.addValue(runtime);
+}
+
+std::chrono::milliseconds ProcessorMetrics::getLastSessionCommitRuntime()
const {
+ return session_commit_runtime_averager_.getLastValue();
+}
template
requires Summable && DividableByInteger
Review Comment:
Good catch, it was a mistake, updated in
7567374d9c44cf63b993eb76c1819ea957832e59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1477: MINIFICPP-2016 Add session commit time metrics
lordgamez commented on code in PR #1477:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1477#discussion_r1087562738
##
libminifi/test/unit/MetricsTests.cpp:
##
@@ -246,6 +246,38 @@ TEST_CASE("Test ProcessorMetrics", "[ProcessorMetrics]") {
metrics.addLastOnTriggerRuntime(10ms);
REQUIRE(metrics.getLastOnTriggerRuntime() == 10ms);
REQUIRE(metrics.getAverageOnTriggerRuntime() == 37ms);
+
+ REQUIRE(metrics.getLastSessionCommitRuntime() == 0ms);
+ REQUIRE(metrics.getAverageSessionCommitRuntime() == 0ms);
+
+ metrics.addLastSessionCommitRuntime(10ms);
+ metrics.addLastSessionCommitRuntime(20ms);
+ metrics.addLastSessionCommitRuntime(30ms);
+
+ REQUIRE(metrics.getLastSessionCommitRuntime() == 30ms);
+ REQUIRE(metrics.getAverageSessionCommitRuntime() == 20ms);
+
+ for (auto i = 0; i < 7; ++i) {
+metrics.addLastSessionCommitRuntime(50ms);
+ }
+ REQUIRE(metrics.getAverageSessionCommitRuntime() == 41ms);
+ REQUIRE(metrics.getLastSessionCommitRuntime() == 50ms);
+
+ for (auto i = 0; i < 3; ++i) {
+metrics.addLastSessionCommitRuntime(50ms);
+ }
+ REQUIRE(metrics.getAverageSessionCommitRuntime() == 50ms);
+ REQUIRE(metrics.getLastSessionCommitRuntime() == 50ms);
+
+ for (auto i = 0; i < 10; ++i) {
+metrics.addLastSessionCommitRuntime(40ms);
+ }
+ REQUIRE(metrics.getAverageSessionCommitRuntime() == 40ms);
+ REQUIRE(metrics.getLastSessionCommitRuntime() == 40ms);
+
+ metrics.addLastSessionCommitRuntime(10ms);
+ REQUIRE(metrics.getLastSessionCommitRuntime() == 10ms);
+ REQUIRE(metrics.getAverageSessionCommitRuntime() == 37ms);
Review Comment:
Updated in 7567374d9c44cf63b993eb76c1819ea957832e59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] krisztina-zsihovszki opened a new pull request, #6892: NIFI-11059 PutBoxFile processor
krisztina-zsihovszki opened a new pull request, #6892: URL: https://github.com/apache/nifi/pull/6892 # Summary [NIFI-11059](https://issues.apache.org/jira/browse/NIFI-11059) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-11059` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-11059` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [x] JDK 8 - [x] JDK 11 - [x] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
