[jira] [Commented] (NIFI-11250) InvokeHTTP drops the Body when using the DELETE method
[
https://issues.apache.org/jira/browse/NIFI-11250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724487#comment-17724487
]
Benji Benning commented on NIFI-11250:
--
Hi [~exceptionfactory],
Yes, as noted in the description, Keycloak's REST API uses DELETE requests with
a body to perform a bunch of operations.
In my case it's to Delete realm-level role mappings
([https://www.keycloak.org/docs-api/21.0.1/rest-api/#_role_mapper_resource)|https://www.keycloak.org/docs-api/21.0.1/rest-api/#_role_mapper_resource]
My workaround is to perform this specific action using a Jython
InvokeScriptedProcessor processor, but that's not ideal as the rest of my
interactions with Keycloak are all done seamlessly using InvokeHTTP, just this
one weird duck requires it's own script. : )
> InvokeHTTP drops the Body when using the DELETE method
> --
>
> Key: NIFI-11250
> URL: https://issues.apache.org/jira/browse/NIFI-11250
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Benji Benning
>Assignee: David Handermann
>Priority: Major
>
> Today, InvokeHTTP drops the Body when the method used isn't PUT, POST, or
> PATCH (As stated in the documentation). RFC states that DELETE with body
> isn't generally used, but doesn't disallow it.
> In my case, i'm using InvokeHTTP to interact with Keycloak's Admin REST API.
> They use DELETE with body in quite a few cases. for example in my specific
> use case:
> [https://www.keycloak.org/docs-api/21.0.1/rest-api/#_role_mapper_resource]
> (referring to: Delete realm-level role mappings)
> Additional information:
> {noformat}
> Although request message framing is independent of the method used, content
> received in a DELETE request has no generally defined semantics, cannot alter
> the meaning or target of the request, and might lead some implementations to
> reject the request and close the connection because of its potential as a
> request smuggling attack (Section 11.2 of [HTTP/1.1]). A client SHOULD NOT
> generate content in a DELETE request unless it is made directly to an origin
> server that has previously indicated, in or out of band, that such a request
> has a purpose and will be adequately supported. An origin server SHOULD NOT
> rely on private agreements to receive content, since participants in HTTP
> communication are often unaware of intermediaries along the request
> chain.{noformat}
> [https://www.rfc-editor.org/rfc/rfc9110.html#name-delete]
>
> During discussion with Otto Fowler, he stated that this is disabled in the
> [HTTPMethod
> enum|https://github.com/apache/nifi/blob/7a47c8cfbd458ab037275762c385d50372c130a3/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/http/HttpMethod.java].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-11573) Update swagger.annotations.version to 1.6.11
[ https://issues.apache.org/jira/browse/NIFI-11573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11573. - Fix Version/s: 2.0.0 1.22.0 Resolution: Fixed > Update swagger.annotations.version to 1.6.11 > > > Key: NIFI-11573 > URL: https://issues.apache.org/jira/browse/NIFI-11573 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Fix For: 2.0.0, 1.22.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Update swagger.annotations.version to 1.6.11 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11574) Upgrade snowflake-ingest-sdk to 1.1.4
[ https://issues.apache.org/jira/browse/NIFI-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11574: Fix Version/s: 2.0.0 1.22.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade snowflake-ingest-sdk to 1.1.4 > - > > Key: NIFI-11574 > URL: https://issues.apache.org/jira/browse/NIFI-11574 > Project: Apache NiFi > Issue Type: Task > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0, 1.22.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Upgrade snowflake-ingest-sdk to 1.1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11572) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/NIFI-11572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11572: Fix Version/s: 2.0.0 1.22.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade json-smart to 2.4.11 > > > Key: NIFI-11572 > URL: https://issues.apache.org/jira/browse/NIFI-11572 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0, 1.22.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Upgrade json-smart to 2.4.11 > [https://github.com/netplex/json-smart-v2/releases] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11573) Update swagger.annotations.version to 1.6.11
[ https://issues.apache.org/jira/browse/NIFI-11573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724420#comment-17724420 ] ASF subversion and git services commented on NIFI-11573: Commit f80151071407ec63ad9d09ac4d53c0929f074ca0 in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f801510714 ] NIFI-11573 Upgraded Swagger Annotations from 1.6.10 to 1.6.11 This closes #7278 Signed-off-by: David Handermann (cherry picked from commit 642b1748a6e103a218da44283e3d73b12db50404) > Update swagger.annotations.version to 1.6.11 > > > Key: NIFI-11573 > URL: https://issues.apache.org/jira/browse/NIFI-11573 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Update swagger.annotations.version to 1.6.11 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11574) Upgrade snowflake-ingest-sdk to 1.1.4
[ https://issues.apache.org/jira/browse/NIFI-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724419#comment-17724419 ] ASF subversion and git services commented on NIFI-11574: Commit dedbd617b133d3bf15d828df28cf77db34b4c09e in nifi's branch refs/heads/support/nifi-1.x from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=dedbd617b1 ] NIFI-11574 Upgraded snowflake-ingest-sdk from 1.1.3 to 1.1.4 This closes #7277 Signed-off-by: David Handermann (cherry picked from commit a54c9915c360ca5023a7ba832825a6c6e7f98259) > Upgrade snowflake-ingest-sdk to 1.1.4 > - > > Key: NIFI-11574 > URL: https://issues.apache.org/jira/browse/NIFI-11574 > Project: Apache NiFi > Issue Type: Task > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Upgrade snowflake-ingest-sdk to 1.1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11571) Upgrade SSHD to 2.10
[ https://issues.apache.org/jira/browse/NIFI-11571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11571: Fix Version/s: 2.0.0 1.22.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade SSHD to 2.10 > > > Key: NIFI-11571 > URL: https://issues.apache.org/jira/browse/NIFI-11571 > Project: Apache NiFi > Issue Type: Task > Components: Extensions, NiFi Registry >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0, 1.22.0 > > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/mina-sshd/blob/sshd-2.10.0/docs/changes/2.10.0.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11572) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/NIFI-11572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724418#comment-17724418 ] ASF subversion and git services commented on NIFI-11572: Commit 8c389bebb03fd8ada87f1165c0e7952a42aa29bd in nifi's branch refs/heads/support/nifi-1.x from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8c389bebb0 ] NIFI-11572 Upgraded json-smart from 2.4.10 to 2.4.11 This closes #7276 Signed-off-by: David Handermann (cherry picked from commit d030428dc36e6509ae6cf130f42e640609d123ae) > Upgrade json-smart to 2.4.11 > > > Key: NIFI-11572 > URL: https://issues.apache.org/jira/browse/NIFI-11572 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Upgrade json-smart to 2.4.11 > [https://github.com/netplex/json-smart-v2/releases] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11571) Upgrade SSHD to 2.10
[ https://issues.apache.org/jira/browse/NIFI-11571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724417#comment-17724417 ] ASF subversion and git services commented on NIFI-11571: Commit ce38aafa0627fc18379b93c8b2b24b035299069e in nifi's branch refs/heads/support/nifi-1.x from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ce38aafa06 ] NIFI-11571 Upgraded Apache SSHD from 2.9.2 to 2.10.0 This closes #7275 Signed-off-by: David Handermann (cherry picked from commit 0e8aa5b744d756c8edc17c724f0c9f98dbcc0b8a) > Upgrade SSHD to 2.10 > > > Key: NIFI-11571 > URL: https://issues.apache.org/jira/browse/NIFI-11571 > Project: Apache NiFi > Issue Type: Task > Components: Extensions, NiFi Registry >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/mina-sshd/blob/sshd-2.10.0/docs/changes/2.10.0.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11571) Upgrade SSHD to 2.10
[ https://issues.apache.org/jira/browse/NIFI-11571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724413#comment-17724413 ] ASF subversion and git services commented on NIFI-11571: Commit 0e8aa5b744d756c8edc17c724f0c9f98dbcc0b8a in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0e8aa5b744 ] NIFI-11571 Upgraded Apache SSHD from 2.9.2 to 2.10.0 This closes #7275 Signed-off-by: David Handermann > Upgrade SSHD to 2.10 > > > Key: NIFI-11571 > URL: https://issues.apache.org/jira/browse/NIFI-11571 > Project: Apache NiFi > Issue Type: Task > Components: Extensions, NiFi Registry >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/mina-sshd/blob/sshd-2.10.0/docs/changes/2.10.0.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11573) Update swagger.annotations.version to 1.6.11
[ https://issues.apache.org/jira/browse/NIFI-11573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724416#comment-17724416 ] ASF subversion and git services commented on NIFI-11573: Commit 642b1748a6e103a218da44283e3d73b12db50404 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=642b1748a6 ] NIFI-11573 Upgraded Swagger Annotations from 1.6.10 to 1.6.11 This closes #7278 Signed-off-by: David Handermann > Update swagger.annotations.version to 1.6.11 > > > Key: NIFI-11573 > URL: https://issues.apache.org/jira/browse/NIFI-11573 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update swagger.annotations.version to 1.6.11 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11574) Upgrade snowflake-ingest-sdk to 1.1.4
[ https://issues.apache.org/jira/browse/NIFI-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724415#comment-17724415 ] ASF subversion and git services commented on NIFI-11574: Commit a54c9915c360ca5023a7ba832825a6c6e7f98259 in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a54c9915c3 ] NIFI-11574 Upgraded snowflake-ingest-sdk from 1.1.3 to 1.1.4 This closes #7277 Signed-off-by: David Handermann > Upgrade snowflake-ingest-sdk to 1.1.4 > - > > Key: NIFI-11574 > URL: https://issues.apache.org/jira/browse/NIFI-11574 > Project: Apache NiFi > Issue Type: Task > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Upgrade snowflake-ingest-sdk to 1.1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11572) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/NIFI-11572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724414#comment-17724414 ] ASF subversion and git services commented on NIFI-11572: Commit d030428dc36e6509ae6cf130f42e640609d123ae in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d030428dc3 ] NIFI-11572 Upgraded json-smart from 2.4.10 to 2.4.11 This closes #7276 Signed-off-by: David Handermann > Upgrade json-smart to 2.4.11 > > > Key: NIFI-11572 > URL: https://issues.apache.org/jira/browse/NIFI-11572 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Upgrade json-smart to 2.4.11 > [https://github.com/netplex/json-smart-v2/releases] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7278: NIFI-11573 Update swagger.annotations.version to 1.6.11
exceptionfactory closed pull request #7278: NIFI-11573 Update swagger.annotations.version to 1.6.11 URL: https://github.com/apache/nifi/pull/7278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-8161) NiFi EL: migration from SimpleDateFormat to DateTimeFormatter
[
https://issues.apache.org/jira/browse/NIFI-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-8161:
---
Fix Version/s: 2.0.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> NiFi EL: migration from SimpleDateFormat to DateTimeFormatter
> -
>
> Key: NIFI-8161
> URL: https://issues.apache.org/jira/browse/NIFI-8161
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Arek Burdach
>Assignee: Arek Burdach
>Priority: Major
> Labels: Breaking-Change, perfomance, pull-request-available
> Fix For: 2.0.0
>
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> In NiFi Expression Language we are commonly using SimpleDateFormat. It is
> old, inefficient approach: due to mutability of SimpleDateFormat it need to
> be recreated for each operation. Also this format is lax in some places where
> user would like to be more strict. In my opinion better approach would be
> usage of java8 DateTimeFormatter instead.
> I've done some benchmarks that you can check on your own in
> FormatEvaluatorBenchmark. Results on my 8-core, i7-1065G7:
> - before change (SimpleDateFormat): 11.230 ± 5.407 us/op
> - after switching to DateTimeFormatter API: 4.747 ± 0.426 us/op
> - after introduction of preparation of formatter for literal formats: 2.025 ±
> 0.055 us/op
> This change is not 100% transparent so some changes might be necessary in
> users code. Most of differences are visible in modifications that I've made
> in TestQuery tests:
> - back tick (`) for escaping of extra characters is not supported anymore -
> only single quote is supported
> - "repeated" syntax like "dd" for days strictly check if two digits were
> provided - if someone need to use more lax syntax, need to use single "d"
> syntax
> [update]
> After switching to lenient mode, parsing is compatible with SimpleDateFormat
> in second point ("repeated" syntax)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-8161) NiFi EL: migration from SimpleDateFormat to DateTimeFormatter
[
https://issues.apache.org/jira/browse/NIFI-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-8161:
---
Labels: Breaking-Change perfomance pull-request-available (was: perfomance
pull-request-available)
> NiFi EL: migration from SimpleDateFormat to DateTimeFormatter
> -
>
> Key: NIFI-8161
> URL: https://issues.apache.org/jira/browse/NIFI-8161
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Arek Burdach
>Assignee: Arek Burdach
>Priority: Major
> Labels: Breaking-Change, perfomance, pull-request-available
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> In NiFi Expression Language we are commonly using SimpleDateFormat. It is
> old, inefficient approach: due to mutability of SimpleDateFormat it need to
> be recreated for each operation. Also this format is lax in some places where
> user would like to be more strict. In my opinion better approach would be
> usage of java8 DateTimeFormatter instead.
> I've done some benchmarks that you can check on your own in
> FormatEvaluatorBenchmark. Results on my 8-core, i7-1065G7:
> - before change (SimpleDateFormat): 11.230 ± 5.407 us/op
> - after switching to DateTimeFormatter API: 4.747 ± 0.426 us/op
> - after introduction of preparation of formatter for literal formats: 2.025 ±
> 0.055 us/op
> This change is not 100% transparent so some changes might be necessary in
> users code. Most of differences are visible in modifications that I've made
> in TestQuery tests:
> - back tick (`) for escaping of extra characters is not supported anymore -
> only single quote is supported
> - "repeated" syntax like "dd" for days strictly check if two digits were
> provided - if someone need to use more lax syntax, need to use single "d"
> syntax
> [update]
> After switching to lenient mode, parsing is compatible with SimpleDateFormat
> in second point ("repeated" syntax)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-8161) NiFi EL: migration from SimpleDateFormat to DateTimeFormatter
[
https://issues.apache.org/jira/browse/NIFI-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724412#comment-17724412
]
ASF subversion and git services commented on NIFI-8161:
---
Commit 8a4c3cab84253308c2f7fa4eda4a4221c73545e2 in nifi's branch
refs/heads/main from Arek Burdach
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8a4c3cab84 ]
NIFI-8161 Migrated EL from SimpleDateFormat to DateTimeFormatter
This closes #7169
Signed-off-by: David Handermann
> NiFi EL: migration from SimpleDateFormat to DateTimeFormatter
> -
>
> Key: NIFI-8161
> URL: https://issues.apache.org/jira/browse/NIFI-8161
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Arek Burdach
>Assignee: Arek Burdach
>Priority: Major
> Labels: perfomance, pull-request-available
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> In NiFi Expression Language we are commonly using SimpleDateFormat. It is
> old, inefficient approach: due to mutability of SimpleDateFormat it need to
> be recreated for each operation. Also this format is lax in some places where
> user would like to be more strict. In my opinion better approach would be
> usage of java8 DateTimeFormatter instead.
> I've done some benchmarks that you can check on your own in
> FormatEvaluatorBenchmark. Results on my 8-core, i7-1065G7:
> - before change (SimpleDateFormat): 11.230 ± 5.407 us/op
> - after switching to DateTimeFormatter API: 4.747 ± 0.426 us/op
> - after introduction of preparation of formatter for literal formats: 2.025 ±
> 0.055 us/op
> This change is not 100% transparent so some changes might be necessary in
> users code. Most of differences are visible in modifications that I've made
> in TestQuery tests:
> - back tick (`) for escaping of extra characters is not supported anymore -
> only single quote is supported
> - "repeated" syntax like "dd" for days strictly check if two digits were
> provided - if someone need to use more lax syntax, need to use single "d"
> syntax
> [update]
> After switching to lenient mode, parsing is compatible with SimpleDateFormat
> in second point ("repeated" syntax)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7169: NIFI-8161 NiFi EL: migration from SimpleDateFormat to DateTimeFormatter: rebased to 2.0
exceptionfactory closed pull request #7169: NIFI-8161 NiFi EL: migration from SimpleDateFormat to DateTimeFormatter: rebased to 2.0 URL: https://github.com/apache/nifi/pull/7169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11575) When you terminate a component - it increases the thread pool size and does not restore it until restart
Joe Witt created NIFI-11575: --- Summary: When you terminate a component - it increases the thread pool size and does not restore it until restart Key: NIFI-11575 URL: https://issues.apache.org/jira/browse/NIFI-11575 Project: Apache NiFi Issue Type: Improvement Components: Core Framework Affects Versions: 1.21.0, 2.0.0 Reporter: Joe Witt Assignee: Mark Payne Currently when you stop a component and then choose to terminate active threads we do this by expanding the core pool size by the number of currently running threads for that component. So if you have a pool size of 10 as configured in the flow controller and you choose to terminate a processor that currently has 5 running tasks the flow controller will now be updated to allow 15 threads. This happens only at runtime it doesn't change the config so the issue will resolve itself on restart. Why we need to do this makes sense. The stuck threads you wish to terminate may in fact never stop so these new threads replace those lost threads and work can continue. And indeed termination in general is an 'in case of emergency break glass' operation. But assuming termination works out we should return to the desired pool size. This becomes even more important on a system that is already resource saturated where termination might be a necessary/helpful tool in reworking the live flow and as of now doing so actually increase the thread pool size which increases the amount of work that can be done in parallel thus making the situation harder. Fixing this logic will help termination be useful without expanding the resource burden. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mr1716 opened a new pull request, #7278: NIFI-11573 Update swagger.annotations.version to 1.6.11
mr1716 opened a new pull request, #7278: URL: https://github.com/apache/nifi/pull/7278 # Summary [NIFI-11573](https://issues.apache.org/jira/browse/NIFI-11573) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-11573) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-11573) Update swagger.annotations.version to 1.6.11
[ https://issues.apache.org/jira/browse/NIFI-11573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-11573: - Assignee: Mike R > Update swagger.annotations.version to 1.6.11 > > > Key: NIFI-11573 > URL: https://issues.apache.org/jira/browse/NIFI-11573 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update swagger.annotations.version to 1.6.11 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] pvillard31 opened a new pull request, #7277: NIFI-11574 - Upgrade snowflake-ingest-sdk to 1.1.4
pvillard31 opened a new pull request, #7277: URL: https://github.com/apache/nifi/pull/7277 # Summary [NIFI-11574](https://issues.apache.org/jira/browse/NIFI-11574) Upgrade snowflake-ingest-sdk to 1.1.4 # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11574) Upgrade snowflake-ingest-sdk to 1.1.4
[ https://issues.apache.org/jira/browse/NIFI-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-11574: -- Status: Patch Available (was: Open) > Upgrade snowflake-ingest-sdk to 1.1.4 > - > > Key: NIFI-11574 > URL: https://issues.apache.org/jira/browse/NIFI-11574 > Project: Apache NiFi > Issue Type: Task > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > > Upgrade snowflake-ingest-sdk to 1.1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11574) Upgrade snowflake-ingest-sdk to 1.1.4
[ https://issues.apache.org/jira/browse/NIFI-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-11574: -- Description: Upgrade snowflake-ingest-sdk to 1.1.4 (was: Upgrade snowflake-ingest-sdk to 1.1.3) > Upgrade snowflake-ingest-sdk to 1.1.4 > - > > Key: NIFI-11574 > URL: https://issues.apache.org/jira/browse/NIFI-11574 > Project: Apache NiFi > Issue Type: Task > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > > Upgrade snowflake-ingest-sdk to 1.1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11574) Upgrade snowflake-ingest-sdk to 1.1.4
Pierre Villard created NIFI-11574: - Summary: Upgrade snowflake-ingest-sdk to 1.1.4 Key: NIFI-11574 URL: https://issues.apache.org/jira/browse/NIFI-11574 Project: Apache NiFi Issue Type: Task Components: Extensions Reporter: Pierre Villard Assignee: Pierre Villard Fix For: 1.latest, 2.latest Upgrade snowflake-ingest-sdk to 1.1.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11573) Update swagger.annotations.version to 1.6.11
Mike R created NIFI-11573: - Summary: Update swagger.annotations.version to 1.6.11 Key: NIFI-11573 URL: https://issues.apache.org/jira/browse/NIFI-11573 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.21.0 Reporter: Mike R Update swagger.annotations.version to 1.6.11 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] pvillard31 opened a new pull request, #7276: NIFI-11572 - Upgrade json-smart to 2.4.11
pvillard31 opened a new pull request, #7276: URL: https://github.com/apache/nifi/pull/7276 # Summary [NIFI-11572](https://issues.apache.org/jira/browse/NIFI-11572) Upgrade json-smart to 2.4.11 https://github.com/netplex/json-smart-v2/releases # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11572) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/NIFI-11572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-11572: -- Summary: Upgrade json-smart to 2.4.11 (was: Upgrade json-smart 2.4.11) > Upgrade json-smart to 2.4.11 > > > Key: NIFI-11572 > URL: https://issues.apache.org/jira/browse/NIFI-11572 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > > Upgrade json-smart 2.4.11 > [https://github.com/netplex/json-smart-v2/releases] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11572) Upgrade json-smart 2.4.11
[ https://issues.apache.org/jira/browse/NIFI-11572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-11572: -- Status: Patch Available (was: Open) > Upgrade json-smart 2.4.11 > - > > Key: NIFI-11572 > URL: https://issues.apache.org/jira/browse/NIFI-11572 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > > Upgrade json-smart 2.4.11 > [https://github.com/netplex/json-smart-v2/releases] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11572) Upgrade json-smart to 2.4.11
[ https://issues.apache.org/jira/browse/NIFI-11572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-11572: -- Description: Upgrade json-smart to 2.4.11 [https://github.com/netplex/json-smart-v2/releases] was: Upgrade json-smart 2.4.11 [https://github.com/netplex/json-smart-v2/releases] > Upgrade json-smart to 2.4.11 > > > Key: NIFI-11572 > URL: https://issues.apache.org/jira/browse/NIFI-11572 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > > Upgrade json-smart to 2.4.11 > [https://github.com/netplex/json-smart-v2/releases] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11572) Upgrade json-smart 2.4.11
Pierre Villard created NIFI-11572: - Summary: Upgrade json-smart 2.4.11 Key: NIFI-11572 URL: https://issues.apache.org/jira/browse/NIFI-11572 Project: Apache NiFi Issue Type: Task Components: Core Framework, Extensions Reporter: Pierre Villard Assignee: Pierre Villard Fix For: 1.latest, 2.latest Upgrade json-smart 2.4.11 [https://github.com/netplex/json-smart-v2/releases] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-11569) Update Testcontainers to 1.18.1
[ https://issues.apache.org/jira/browse/NIFI-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-11569. --- Fix Version/s: 2.0.0 1.22.0 Resolution: Fixed > Update Testcontainers to 1.18.1 > --- > > Key: NIFI-11569 > URL: https://issues.apache.org/jira/browse/NIFI-11569 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.22.0 > > > Update Testcontainers to 1.18.1 from 1.18.0 > > [Release Notes: Release 1.18.1 · testcontainers/testcontainers-java > (github.com)|https://github.com/testcontainers/testcontainers-java/releases/tag/1.18.1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11569) Update Testcontainers to 1.18.1
[ https://issues.apache.org/jira/browse/NIFI-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724380#comment-17724380 ] ASF subversion and git services commented on NIFI-11569: Commit 2bfbe35c567fba1688799ff8b877be23adc717eb in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2bfbe35c56 ] NIFI-11569: Update Testcontainers to 1.18.1 Signed-off-by: Pierre Villard This closes #7272. > Update Testcontainers to 1.18.1 > --- > > Key: NIFI-11569 > URL: https://issues.apache.org/jira/browse/NIFI-11569 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > > Update Testcontainers to 1.18.1 from 1.18.0 > > [Release Notes: Release 1.18.1 · testcontainers/testcontainers-java > (github.com)|https://github.com/testcontainers/testcontainers-java/releases/tag/1.18.1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11569) Update Testcontainers to 1.18.1
[ https://issues.apache.org/jira/browse/NIFI-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724378#comment-17724378 ] ASF subversion and git services commented on NIFI-11569: Commit 284c11fc877ef6f6476a4eabc975bae0b8b806f2 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=284c11fc87 ] NIFI-11569: Update Testcontainers to 1.18.1 Signed-off-by: Pierre Villard This closes #7272. > Update Testcontainers to 1.18.1 > --- > > Key: NIFI-11569 > URL: https://issues.apache.org/jira/browse/NIFI-11569 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > > Update Testcontainers to 1.18.1 from 1.18.0 > > [Release Notes: Release 1.18.1 · testcontainers/testcontainers-java > (github.com)|https://github.com/testcontainers/testcontainers-java/releases/tag/1.18.1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #7272: NIFI-11569: Update Testcontainers to 1.18.1
asfgit closed pull request #7272: NIFI-11569: Update Testcontainers to 1.18.1 URL: https://github.com/apache/nifi/pull/7272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-11565) Upgrade Jackson-databind to 2.15.1
[ https://issues.apache.org/jira/browse/NIFI-11565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-11565. --- Fix Version/s: 2.0.0 1.22.0 Resolution: Fixed > Upgrade Jackson-databind to 2.15.1 > -- > > Key: NIFI-11565 > URL: https://issues.apache.org/jira/browse/NIFI-11565 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.22.0 > > > Upgrade Jackson-databind to 2.15.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11565) Upgrade Jackson-databind to 2.15.1
[ https://issues.apache.org/jira/browse/NIFI-11565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724376#comment-17724376 ] ASF subversion and git services commented on NIFI-11565: Commit ac308ceddb9fe1b1698d040b67a42e44540dce1f in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ac308ceddb ] NIFI-11565: Upgrade jackson.bom to 2.15.1 Signed-off-by: Pierre Villard This closes #7271. > Upgrade Jackson-databind to 2.15.1 > -- > > Key: NIFI-11565 > URL: https://issues.apache.org/jira/browse/NIFI-11565 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > > Upgrade Jackson-databind to 2.15.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11565) Upgrade Jackson-databind to 2.15.1
[ https://issues.apache.org/jira/browse/NIFI-11565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724375#comment-17724375 ] ASF subversion and git services commented on NIFI-11565: Commit 0dba207a414b17bb61ef977dc27a09834c1412d1 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0dba207a41 ] NIFI-11565: Upgrade jackson.bom to 2.15.1 Signed-off-by: Pierre Villard This closes #7271. > Upgrade Jackson-databind to 2.15.1 > -- > > Key: NIFI-11565 > URL: https://issues.apache.org/jira/browse/NIFI-11565 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > > Upgrade Jackson-databind to 2.15.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11571) Upgrade SSHD to 2.10
[ https://issues.apache.org/jira/browse/NIFI-11571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-11571: -- Status: Patch Available (was: In Progress) > Upgrade SSHD to 2.10 > > > Key: NIFI-11571 > URL: https://issues.apache.org/jira/browse/NIFI-11571 > Project: Apache NiFi > Issue Type: Task > Components: Extensions, NiFi Registry >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > > https://github.com/apache/mina-sshd/blob/sshd-2.10.0/docs/changes/2.10.0.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] pvillard31 opened a new pull request, #7275: NIFI-11571 - Upgrade SSHD to 2.10
pvillard31 opened a new pull request, #7275: URL: https://github.com/apache/nifi/pull/7275 # Summary [NIFI-11571](https://issues.apache.org/jira/browse/NIFI-11571) - Upgrade SSHD to 2.10 https://github.com/apache/mina-sshd/blob/sshd-2.10.0/docs/changes/2.10.0.md # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11571) Upgrade SSHD to 2.10
Pierre Villard created NIFI-11571: - Summary: Upgrade SSHD to 2.10 Key: NIFI-11571 URL: https://issues.apache.org/jira/browse/NIFI-11571 Project: Apache NiFi Issue Type: Task Components: Extensions, NiFi Registry Reporter: Pierre Villard Assignee: Pierre Villard Fix For: 1.latest, 2.latest https://github.com/apache/mina-sshd/blob/sshd-2.10.0/docs/changes/2.10.0.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] dan-s1 commented on pull request #7194: NIFI-11167 - Add Excel Record Reader
dan-s1 commented on PR #7194: URL: https://github.com/apache/nifi/pull/7194#issuecomment-1555017392 @exceptionfactory I believe I covered all the points your brought up. Please let me know how this looks and whether there is anything else to change. Can I mark the conversations resolved or is that something the reviewer does? I have seen it done both ways on projects and I am not sure how Apache NIFI does it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11109) registry client class name modified in flow.json/xml when missing nifi-flow-registry-client-nar
[ https://issues.apache.org/jira/browse/NIFI-11109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nissim Shiman updated NIFI-11109: - Summary: registry client class name modified in flow.json/xml when missing nifi-flow-registry-client-nar (was: flow.json/xml modified when using registry client while missing nifi-flow-registry-client-nar) > registry client class name modified in flow.json/xml when missing > nifi-flow-registry-client-nar > --- > > Key: NIFI-11109 > URL: https://issues.apache.org/jira/browse/NIFI-11109 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.19.1 >Reporter: Nissim Shiman >Assignee: Nissim Shiman >Priority: Major > > If nifi is set to use a registry client and nifi-flow-registry-client-nar is > removed from lib, the next nifi restart will result in the registry's class > name (in flow.xml.gz/flow.json.gz) to be modified from > org.apache.nifi.registry.flow.NifiRegistryFlowRegistryClient > to > NifiRegistryFlowRegistryClient. > The url property will also be encrypted. > When the nifi-flow-registry-client-nar is returned to lib, and nifi is > restarted, these changes remain and registry is unreachable using this > registry client. > Update: The remainder of this ticket (that has had its text struck through) > has been made into its own ticket (NIFI-11570) as the underlying issue has > been found to be different. > -Also, if the nar removed was nifi-standard-services-api-nar, then besides > the above behavior, processors under version control via this registry client > may also have their dynamic properties encrypted. These properties remain > encrypted even after nifi-standard-services-api-nar is returned to lib and > nifi is restarted.- > -This is seen with a dynamic property added to GenerateFlowFile (when > GenericFlowFile is part of a PG under registry version control).- > -These are edge cases as admins should be very careful about removing nars > from lib, but it would be good if protections were added to protect > flow.xml/json from modifications in these situations.- -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11109) flow.json/xml modified when using registry client while missing nifi-flow-registry-client-nar
[ https://issues.apache.org/jira/browse/NIFI-11109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nissim Shiman updated NIFI-11109: - Status: Patch Available (was: Open) > flow.json/xml modified when using registry client while missing > nifi-flow-registry-client-nar > - > > Key: NIFI-11109 > URL: https://issues.apache.org/jira/browse/NIFI-11109 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.19.1 >Reporter: Nissim Shiman >Assignee: Nissim Shiman >Priority: Major > > If nifi is set to use a registry client and nifi-flow-registry-client-nar is > removed from lib, the next nifi restart will result in the registry's class > name (in flow.xml.gz/flow.json.gz) to be modified from > org.apache.nifi.registry.flow.NifiRegistryFlowRegistryClient > to > NifiRegistryFlowRegistryClient. > The url property will also be encrypted. > When the nifi-flow-registry-client-nar is returned to lib, and nifi is > restarted, these changes remain and registry is unreachable using this > registry client. > Update: The remainder of this ticket (that has had its text struck through) > has been made into its own ticket (NIFI-11570) as the underlying issue has > been found to be different. > -Also, if the nar removed was nifi-standard-services-api-nar, then besides > the above behavior, processors under version control via this registry client > may also have their dynamic properties encrypted. These properties remain > encrypted even after nifi-standard-services-api-nar is returned to lib and > nifi is restarted.- > -This is seen with a dynamic property added to GenerateFlowFile (when > GenericFlowFile is part of a PG under registry version control).- > -These are edge cases as admins should be very careful about removing nars > from lib, but it would be good if protections were added to protect > flow.xml/json from modifications in these situations.- -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11109) flow.json/xml modified when using registry client while missing nifi-flow-registry-client-nar
[ https://issues.apache.org/jira/browse/NIFI-11109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nissim Shiman updated NIFI-11109: - Description: If nifi is set to use a registry client and nifi-flow-registry-client-nar is removed from lib, the next nifi restart will result in the registry's class name (in flow.xml.gz/flow.json.gz) to be modified from org.apache.nifi.registry.flow.NifiRegistryFlowRegistryClient to NifiRegistryFlowRegistryClient. The url property will also be encrypted. When the nifi-flow-registry-client-nar is returned to lib, and nifi is restarted, these changes remain and registry is unreachable using this registry client. Update: The remainder of this ticket (that has had its text struck through) has been made into its own ticket (NIFI-11570) as the underlying issue has been found to be different. -Also, if the nar removed was nifi-standard-services-api-nar, then besides the above behavior, processors under version control via this registry client may also have their dynamic properties encrypted. These properties remain encrypted even after nifi-standard-services-api-nar is returned to lib and nifi is restarted.- -This is seen with a dynamic property added to GenerateFlowFile (when GenericFlowFile is part of a PG under registry version control).- -These are edge cases as admins should be very careful about removing nars from lib, but it would be good if protections were added to protect flow.xml/json from modifications in these situations.- was: If nifi is set to use a registry client and nifi-flow-registry-client-nar is removed from lib, the next nifi restart will result in the registry's class name (in flow.xml.gz/flow.json.gz) to be modified from org.apache.nifi.registry.flow.NifiRegistryFlowRegistryClient to NifiRegistryFlowRegistryClient. The url property will also be encrypted. When the nifi-flow-registry-client-nar is returned to lib, and nifi is restarted, these changes remain and registry is unreachable using this registry client. -Also, if the nar removed was nifi-standard-services-api-nar, then besides the above behavior, processors under version control via this registry client may also have their dynamic properties encrypted. These properties remain encrypted even after nifi-standard-services-api-nar is returned to lib and nifi is restarted.- -This is seen with a dynamic property added to GenerateFlowFile (when GenericFlowFile is part of a PG under registry version control).- -These are edge cases as admins should be very careful about removing nars from lib, but it would be good if protections were added to protect flow.xml/json from modifications in these situations.- > flow.json/xml modified when using registry client while missing > nifi-flow-registry-client-nar > - > > Key: NIFI-11109 > URL: https://issues.apache.org/jira/browse/NIFI-11109 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.19.1 >Reporter: Nissim Shiman >Assignee: Nissim Shiman >Priority: Major > > If nifi is set to use a registry client and nifi-flow-registry-client-nar is > removed from lib, the next nifi restart will result in the registry's class > name (in flow.xml.gz/flow.json.gz) to be modified from > org.apache.nifi.registry.flow.NifiRegistryFlowRegistryClient > to > NifiRegistryFlowRegistryClient. > The url property will also be encrypted. > When the nifi-flow-registry-client-nar is returned to lib, and nifi is > restarted, these changes remain and registry is unreachable using this > registry client. > Update: The remainder of this ticket (that has had its text struck through) > has been made into its own ticket (NIFI-11570) as the underlying issue has > been found to be different. > -Also, if the nar removed was nifi-standard-services-api-nar, then besides > the above behavior, processors under version control via this registry client > may also have their dynamic properties encrypted. These properties remain > encrypted even after nifi-standard-services-api-nar is returned to lib and > nifi is restarted.- > -This is seen with a dynamic property added to GenerateFlowFile (when > GenericFlowFile is part of a PG under registry version control).- > -These are edge cases as admins should be very careful about removing nars > from lib, but it would be good if protections were added to protect > flow.xml/json from modifications in these situations.- -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11109) flow.json/xml modified when using registry client while missing nifi-flow-registry-client-nar
[ https://issues.apache.org/jira/browse/NIFI-11109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nissim Shiman updated NIFI-11109: - Description: If nifi is set to use a registry client and nifi-flow-registry-client-nar is removed from lib, the next nifi restart will result in the registry's class name (in flow.xml.gz/flow.json.gz) to be modified from org.apache.nifi.registry.flow.NifiRegistryFlowRegistryClient to NifiRegistryFlowRegistryClient. The url property will also be encrypted. When the nifi-flow-registry-client-nar is returned to lib, and nifi is restarted, these changes remain and registry is unreachable using this registry client. -Also, if the nar removed was nifi-standard-services-api-nar, then besides the above behavior, processors under version control via this registry client may also have their dynamic properties encrypted. These properties remain encrypted even after nifi-standard-services-api-nar is returned to lib and nifi is restarted.- -This is seen with a dynamic property added to GenerateFlowFile (when GenericFlowFile is part of a PG under registry version control).- -These are edge cases as admins should be very careful about removing nars from lib, but it would be good if protections were added to protect flow.xml/json from modifications in these situations.- was: If nifi is set to use a registry client and nifi-flow-registry-client-nar is removed from lib, the next nifi restart will result in the registry's class name (in flow.xml.gz/flow.json.gz) to be modified from org.apache.nifi.registry.flow.NifiRegistryFlowRegistryClient to NifiRegistryFlowRegistryClient. The url property will also be encrypted. When the nifi-flow-registry-client-nar is returned to lib, and nifi is restarted, these changes remain and registry is unreachable using this registry client. Also, if the nar removed was nifi-standard-services-api-nar, then besides the above behavior, processors under version control via this registry client may also have their dynamic properties encrypted. These properties remain encrypted even after nifi-standard-services-api-nar is returned to lib and nifi is restarted. This is seen with a dynamic property added to GenerateFlowFile (when GenericFlowFile is part of a PG under registry version control). These are edge cases as admins should be very careful about removing nars from lib, but it would be good if protections were added to protect flow.xml/json from modifications in these situations. > flow.json/xml modified when using registry client while missing > nifi-flow-registry-client-nar > - > > Key: NIFI-11109 > URL: https://issues.apache.org/jira/browse/NIFI-11109 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.19.1 >Reporter: Nissim Shiman >Assignee: Nissim Shiman >Priority: Major > > If nifi is set to use a registry client and nifi-flow-registry-client-nar is > removed from lib, the next nifi restart will result in the registry's class > name (in flow.xml.gz/flow.json.gz) to be modified from > org.apache.nifi.registry.flow.NifiRegistryFlowRegistryClient > to > NifiRegistryFlowRegistryClient. > The url property will also be encrypted. > When the nifi-flow-registry-client-nar is returned to lib, and nifi is > restarted, these changes remain and registry is unreachable using this > registry client. > -Also, if the nar removed was nifi-standard-services-api-nar, then besides > the above behavior, processors under version control via this registry client > may also have their dynamic properties encrypted. These properties remain > encrypted even after nifi-standard-services-api-nar is returned to lib and > nifi is restarted.- > -This is seen with a dynamic property added to GenerateFlowFile (when > GenericFlowFile is part of a PG under registry version control).- > -These are edge cases as admins should be very careful about removing nars > from lib, but it would be good if protections were added to protect > flow.xml/json from modifications in these situations.- -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] greyp9 opened a new pull request, #7274: NIFI-11553 - additional configurability for GCP processors; PublishGC…
greyp9 opened a new pull request, #7274: URL: https://github.com/apache/nifi/pull/7274 …PubSub supports record-oriented FlowFile processing # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11570) Processors have difficulty restoring dynamic properties when leaving ghost mode
Nissim Shiman created NIFI-11570: Summary: Processors have difficulty restoring dynamic properties when leaving ghost mode Key: NIFI-11570 URL: https://issues.apache.org/jira/browse/NIFI-11570 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 1.19.1 Reporter: Nissim Shiman Assignee: Nissim Shiman When a processor with non sensitive dynamic properties is started in ghost mode due to its underlying nar being missing, it will have a difficult time being restored even when its nar has been replaced. The dynamic properties will be identified as being sensitive and not able to be accessed. So for example, if a dynamic property added to GenerateFlowFile and nifi-standard-nar is removed from lib and nifi is restarted, GenerateFlowFile will come up in ghosted mode (as expected). When nifi-standard-nar is replaced and nifi is restarted, GenerateFlowFile will be restored, but its dynamic property will not be accessable. This was originally filed as a second part of NIFI-11109, but after looking more into the underlying causes/symptoms, realized that these are two different issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] NissimShiman opened a new pull request, #7273: NIFI-11109 Allow registry client's class in flow.xml/json to not change when underlying nar for nifi-flow-registry-client-nar is missing
NissimShiman opened a new pull request, #7273: URL: https://github.com/apache/nifi/pull/7273 # Summary [NIFI-11109](https://issues.apache.org/jira/browse/NIFI-11109) If nifi registry client comes up in "ghost" mode. It can never be restored. This resolves this situation. To verify fix: Start nifi configure registry client (i.e. Global Menu -> Controller Settings -> Registry Clients) Verify there are no warnings associated with registry client Stop nifi move nifi-flow-registry-client-nar (found in lib directory) to another directory Start nifi Verify registry client (at above mentioned location) does not work (i.e. it will have a warning as it is now in ghost mode) Restore nifi-flow-registry-client-nar to lib directory Restart nifi Verify earlier warning is gone and registry client is restored # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mr1716 opened a new pull request, #7272: NIFI-11569: Update Testcontainers to 1.18.1
mr1716 opened a new pull request, #7272: URL: https://github.com/apache/nifi/pull/7272 # Summary [NIFI-11569](https://issues.apache.org/jira/browse/NIFI-11569) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-11569) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-11569) Update Testcontainers to 1.18.1
[ https://issues.apache.org/jira/browse/NIFI-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-11569: - Assignee: Mike R > Update Testcontainers to 1.18.1 > --- > > Key: NIFI-11569 > URL: https://issues.apache.org/jira/browse/NIFI-11569 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > > Update Testcontainers to 1.18.1 from 1.18.0 > > [Release Notes: Release 1.18.1 · testcontainers/testcontainers-java > (github.com)|https://github.com/testcontainers/testcontainers-java/releases/tag/1.18.1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11569) Update Testcontainers to 1.18.1
Mike R created NIFI-11569: - Summary: Update Testcontainers to 1.18.1 Key: NIFI-11569 URL: https://issues.apache.org/jira/browse/NIFI-11569 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.21.0 Reporter: Mike R Update Testcontainers to 1.18.1 from 1.18.0 [Release Notes: Release 1.18.1 · testcontainers/testcontainers-java (github.com)|https://github.com/testcontainers/testcontainers-java/releases/tag/1.18.1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mr1716 opened a new pull request, #7271: NIFI-11565: Upgrade jackson.bom to 2.15.1
mr1716 opened a new pull request, #7271: URL: https://github.com/apache/nifi/pull/7271 # Summary [NIFI-11565](https://issues.apache.org/jira/browse/NIFI-11565) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI11565) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7194: NIFI-11167 - Add Excel Record Reader
dan-s1 commented on code in PR #7194:
URL: https://github.com/apache/nifi/pull/7194#discussion_r1199121591
##
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/excel/RowIterator.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */package org.apache.nifi.excel;
+
+import com.github.pjfanning.xlsx.StreamingReader;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.poi.ss.usermodel.Row;
+import org.apache.poi.ss.usermodel.Sheet;
+import org.apache.poi.ss.usermodel.Workbook;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class RowIterator implements Iterator, Closeable {
+private final Workbook workbook;
+private final Iterator sheets;
+private Sheet currentSheet;
+private Iterator currentRows;
+private final Map desiredSheets;
+private final int firstRow;
+private ComponentLog logger;
+private boolean log;
+private Row currentRow;
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow) {
+this(in, desiredSheets, firstRow, null);
+}
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow, ComponentLog logger) {
+this.workbook = StreamingReader.builder()
+.rowCacheSize(100)
+.bufferSize(4096)
+.open(in);
+this.sheets = this.workbook.iterator();
+this.desiredSheets = desiredSheets != null ? desiredSheets.stream()
+.collect(Collectors.toMap(key -> key, value -> Boolean.FALSE))
: new HashMap<>();
+this.firstRow = firstRow;
+this.logger = logger;
+this.log = logger != null;
+}
+
+@Override
+public boolean hasNext() {
+setCurrent();
+boolean next = currentRow != null;
+if(!next) {
+String sheetsNotFound = getSheetsNotFound(desiredSheets);
+if (!sheetsNotFound.isEmpty() && log) {
+logger.warn("Excel sheet(s) not found: {}", sheetsNotFound);
+}
Review Comment:
Perfect, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] mqofori commented on pull request #6053: NIFI-4239 - Adding CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) from PostgreSQL tables via Logical Replicat
mqofori commented on PR #6053: URL: https://github.com/apache/nifi/pull/6053#issuecomment-1554780541 @davyam thanks for all your work on this. I am using the NAR that @janis-ax helped build and I keep losing connection to my server. This usually happens after the processor has been running for a while with no active changes. When I stop, re-enter the DB server password, and start the server then the error goes away. Do you know what could be going on or how I can resolve this? Also, should we expect a stable official version any time soon?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7194: NIFI-11167 - Add Excel Record Reader
exceptionfactory commented on code in PR #7194:
URL: https://github.com/apache/nifi/pull/7194#discussion_r1199111371
##
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/excel/RowIterator.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */package org.apache.nifi.excel;
+
+import com.github.pjfanning.xlsx.StreamingReader;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.poi.ss.usermodel.Row;
+import org.apache.poi.ss.usermodel.Sheet;
+import org.apache.poi.ss.usermodel.Workbook;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class RowIterator implements Iterator, Closeable {
+private final Workbook workbook;
+private final Iterator sheets;
+private Sheet currentSheet;
+private Iterator currentRows;
+private final Map desiredSheets;
+private final int firstRow;
+private ComponentLog logger;
+private boolean log;
+private Row currentRow;
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow) {
+this(in, desiredSheets, firstRow, null);
+}
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow, ComponentLog logger) {
+this.workbook = StreamingReader.builder()
+.rowCacheSize(100)
+.bufferSize(4096)
+.open(in);
+this.sheets = this.workbook.iterator();
+this.desiredSheets = desiredSheets != null ? desiredSheets.stream()
+.collect(Collectors.toMap(key -> key, value -> Boolean.FALSE))
: new HashMap<>();
+this.firstRow = firstRow;
+this.logger = logger;
+this.log = logger != null;
+}
+
+@Override
+public boolean hasNext() {
+setCurrent();
+boolean next = currentRow != null;
+if(!next) {
+String sheetsNotFound = getSheetsNotFound(desiredSheets);
+if (!sheetsNotFound.isEmpty() && log) {
+logger.warn("Excel sheet(s) not found: {}", sheetsNotFound);
+}
Review Comment:
It could be something else, probably `ProcessException` would be a good
option as a more specific subclass of `RuntimeException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] tpalfy commented on a diff in pull request #7240: NIFI-11178: Improve ListHDFS performance, incremental loading refactor.
tpalfy commented on code in PR #7240:
URL: https://github.com/apache/nifi/pull/7240#discussion_r1199095603
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/ListHDFS.java:
##
@@ -452,243 +305,201 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
// Pull in any file that is newer than the timestamp that we have.
final FileSystem hdfs = getFileSystem();
final boolean recursive =
context.getProperty(RECURSE_SUBDIRS).asBoolean();
-String fileFilterMode =
context.getProperty(FILE_FILTER_MODE).getValue();
+final PathFilter pathFilter = createPathFilter(context);
+final RecordSetWriterFactory writerFactory =
context.getProperty(RECORD_WRITER).asControllerService(RecordSetWriterFactory.class);
-final Set statuses;
+final HdfsObjectWriter writer = getHdfsObjectWriter(session,
writerFactory);
+
+long listedFileCount = 0;
try {
final Path rootPath = getNormalizedPath(context, DIRECTORY);
-statuses = getStatuses(rootPath, recursive, hdfs,
createPathFilter(context), fileFilterMode);
-getLogger().debug("Found a total of {} files in HDFS", new
Object[] {statuses.size()});
-} catch (final IOException | IllegalArgumentException e) {
-getLogger().error("Failed to perform listing of HDFS", e);
-return;
-} catch (final InterruptedException e) {
-Thread.currentThread().interrupt();
-getLogger().error("Interrupted while performing listing of HDFS",
e);
-return;
-}
-
-final Set listable = determineListable(statuses, context);
-getLogger().debug("Of the {} files found in HDFS, {} are listable",
new Object[] {statuses.size(), listable.size()});
-
-// Create FlowFile(s) for the listing, if there are any
-if (!listable.isEmpty()) {
-if (context.getProperty(RECORD_WRITER).isSet()) {
-try {
-createRecords(listable, context, session);
-} catch (final IOException | SchemaNotFoundException e) {
-getLogger().error("Failed to write listing of HDFS", e);
-return;
+final FileCountRemoteIterator fileStatusIterator =
getFileStatusIterator(rootPath, recursive, hdfs, pathFilter);
+
+final Long minAgeProp =
context.getProperty(MIN_AGE).asTimePeriod(TimeUnit.MILLISECONDS);
+final long minimumAge = (minAgeProp == null) ? Long.MIN_VALUE :
minAgeProp;
+final Long maxAgeProp =
context.getProperty(MAX_AGE).asTimePeriod(TimeUnit.MILLISECONDS);
+final long maximumAge = (maxAgeProp == null) ? Long.MAX_VALUE :
maxAgeProp;
+
+writer.beginListing();
+
+FileStatus status;
+while (fileStatusIterator.hasNext()) {
+status = fileStatusIterator.next();
+if (status != null && determineListable(status, minimumAge,
maximumAge, isTransitioningFromLegacyState, isLegacyLastStatusListed)) {
+writer.addToListing(status);
+fileStatusManager.update(status);
+listedFileCount++;
}
-} else {
-createFlowFiles(listable, session);
}
-}
+writer.finishListing();
-for (final FileStatus status : listable) {
-final long fileModTime = status.getModificationTime();
-if (fileModTime > latestTimestampEmitted) {
-latestTimestampEmitted = fileModTime;
-}
+long totalFileCount = fileStatusIterator.getFileCount();
+getLogger().debug("Found a total of {} files in HDFS, {} are
listed", totalFileCount, listedFileCount);
+} catch (final IOException | IllegalArgumentException |
SchemaNotFoundException e) {
+getLogger().error("Failed to perform listing of HDFS", e);
+writer.finishListingExceptionally(e);
+return;
}
-final Map updatedState = new HashMap<>(1);
-updatedState.put(LISTING_TIMESTAMP_KEY,
String.valueOf(latestTimestampListed));
-updatedState.put(EMITTED_TIMESTAMP_KEY,
String.valueOf(latestTimestampEmitted));
-getLogger().debug("New state map: {}", new Object[] {updatedState});
+if (listedFileCount > 0) {
+fileStatusManager.finishIteration();
+final Map updatedState = new HashMap<>(1);
+updatedState.put(LISTING_TIMESTAMP_KEY,
String.valueOf(fileStatusManager.getLastModificationTime()));
+getLogger().debug("New state map: {}", updatedState);
+updateState(session, updatedState);
-try {
-session.setState(updatedState, Scope.CLUSTER);
-} catch (final IOException ioe) {
-
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7194: NIFI-11167 - Add Excel Record Reader
dan-s1 commented on code in PR #7194:
URL: https://github.com/apache/nifi/pull/7194#discussion_r1199098457
##
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/excel/RowIterator.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */package org.apache.nifi.excel;
+
+import com.github.pjfanning.xlsx.StreamingReader;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.poi.ss.usermodel.Row;
+import org.apache.poi.ss.usermodel.Sheet;
+import org.apache.poi.ss.usermodel.Workbook;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class RowIterator implements Iterator, Closeable {
+private final Workbook workbook;
+private final Iterator sheets;
+private Sheet currentSheet;
+private Iterator currentRows;
+private final Map desiredSheets;
+private final int firstRow;
+private ComponentLog logger;
+private boolean log;
+private Row currentRow;
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow) {
+this(in, desiredSheets, firstRow, null);
+}
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow, ComponentLog logger) {
+this.workbook = StreamingReader.builder()
+.rowCacheSize(100)
+.bufferSize(4096)
+.open(in);
+this.sheets = this.workbook.iterator();
+this.desiredSheets = desiredSheets != null ? desiredSheets.stream()
+.collect(Collectors.toMap(key -> key, value -> Boolean.FALSE))
: new HashMap<>();
+this.firstRow = firstRow;
+this.logger = logger;
+this.log = logger != null;
+}
+
+@Override
+public boolean hasNext() {
+setCurrent();
+boolean next = currentRow != null;
+if(!next) {
+String sheetsNotFound = getSheetsNotFound(desiredSheets);
+if (!sheetsNotFound.isEmpty() && log) {
+logger.warn("Excel sheet(s) not found: {}", sheetsNotFound);
+}
Review Comment:
@exceptionfactory Does the exception have to be specifically an
`IOException`? The problem I have is if that or any other checked exception is
thrown then the `hasNext` method signature has to change and that clashes with
the` java.util.Iterator` interface. Would a `RuntimeException` be okay to throw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (NIFI-11564) Update msal4j to 1.13.8 for Azure Graph Authorizer
[ https://issues.apache.org/jira/browse/NIFI-11564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11564. - Fix Version/s: 2.0.0 1.22.0 Resolution: Fixed > Update msal4j to 1.13.8 for Azure Graph Authorizer > -- > > Key: NIFI-11564 > URL: https://issues.apache.org/jira/browse/NIFI-11564 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.22.0 > > > Update msal4j to 1.13.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11564) Update msal4j to 1.13.8
[ https://issues.apache.org/jira/browse/NIFI-11564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724320#comment-17724320 ] ASF subversion and git services commented on NIFI-11564: Commit f4e88d673c3e96cdd445dc5f65bf89de466e0c48 in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f4e88d673c ] NIFI-11564 Upgraded msal4j from 1.13.7 to 1.13.8 - Upgrade applies to nifi-azure-graph-authorizer This closes #7262 Signed-off-by: David Handermann (cherry picked from commit 141ea044bb15a1848a176625293ea80fe38ed809) > Update msal4j to 1.13.8 > --- > > Key: NIFI-11564 > URL: https://issues.apache.org/jira/browse/NIFI-11564 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > > Update msal4j to 1.13.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11564) Update msal4j to 1.13.8 for Azure Graph Authorizer
[ https://issues.apache.org/jira/browse/NIFI-11564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11564: Summary: Update msal4j to 1.13.8 for Azure Graph Authorizer (was: Update msal4j to 1.13.8) > Update msal4j to 1.13.8 for Azure Graph Authorizer > -- > > Key: NIFI-11564 > URL: https://issues.apache.org/jira/browse/NIFI-11564 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > > Update msal4j to 1.13.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11564) Update msal4j to 1.13.8
[ https://issues.apache.org/jira/browse/NIFI-11564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724319#comment-17724319 ] ASF subversion and git services commented on NIFI-11564: Commit 141ea044bb15a1848a176625293ea80fe38ed809 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=141ea044bb ] NIFI-11564 Upgraded msal4j from 1.13.7 to 1.13.8 - Upgrade applies to nifi-azure-graph-authorizer This closes #7262 Signed-off-by: David Handermann > Update msal4j to 1.13.8 > --- > > Key: NIFI-11564 > URL: https://issues.apache.org/jira/browse/NIFI-11564 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > > Update msal4j to 1.13.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7262: NIFI-11564 Update msal4j to 1.13.8
exceptionfactory closed pull request #7262: NIFI-11564 Update msal4j to 1.13.8 URL: https://github.com/apache/nifi/pull/7262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7194: NIFI-11167 - Add Excel Record Reader
dan-s1 commented on code in PR #7194:
URL: https://github.com/apache/nifi/pull/7194#discussion_r1199077438
##
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/excel/RowIterator.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */package org.apache.nifi.excel;
+
+import com.github.pjfanning.xlsx.StreamingReader;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.poi.ss.usermodel.Row;
+import org.apache.poi.ss.usermodel.Sheet;
+import org.apache.poi.ss.usermodel.Workbook;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class RowIterator implements Iterator, Closeable {
+private final Workbook workbook;
+private final Iterator sheets;
+private Sheet currentSheet;
+private Iterator currentRows;
+private final Map desiredSheets;
+private final int firstRow;
+private ComponentLog logger;
+private boolean log;
+private Row currentRow;
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow) {
+this(in, desiredSheets, firstRow, null);
+}
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow, ComponentLog logger) {
+this.workbook = StreamingReader.builder()
+.rowCacheSize(100)
+.bufferSize(4096)
+.open(in);
+this.sheets = this.workbook.iterator();
+this.desiredSheets = desiredSheets != null ? desiredSheets.stream()
+.collect(Collectors.toMap(key -> key, value -> Boolean.FALSE))
: new HashMap<>();
+this.firstRow = firstRow;
+this.logger = logger;
+this.log = logger != null;
+}
+
+@Override
+public boolean hasNext() {
+setCurrent();
+boolean next = currentRow != null;
+if(!next) {
+String sheetsNotFound = getSheetsNotFound(desiredSheets);
+if (!sheetsNotFound.isEmpty() && log) {
+logger.warn("Excel sheet(s) not found: {}", sheetsNotFound);
+}
Review Comment:
Sounds good to me. I will make these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-11221) Remove support for processor-level connection configuration in the MongoDB package
[ https://issues.apache.org/jira/browse/NIFI-11221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-11221: Fix Version/s: 2.0.0 (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Remove support for processor-level connection configuration in the MongoDB > package > -- > > Key: NIFI-11221 > URL: https://issues.apache.org/jira/browse/NIFI-11221 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > Fix For: 2.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The configuration should be done entirely through the controller service that > manages the connections. That class has been around for a few years now, so > it shouldn't be a surprise to anyone. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11221) Remove support for processor-level connection configuration in the MongoDB package
[ https://issues.apache.org/jira/browse/NIFI-11221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724310#comment-17724310 ] ASF subversion and git services commented on NIFI-11221: Commit c473e6fa0cf38ef4469a9c6656811eb7c8ae5591 in nifi's branch refs/heads/main from Mike Thomsen [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c473e6fa0c ] NIFI-11221 Removed client configuration from AbstractMongoProcessor. NIFI-11221 Style check fixes NIFI-11221 Removed dead code. Signed-off-by: Matthew Burgess This closes #7213 > Remove support for processor-level connection configuration in the MongoDB > package > -- > > Key: NIFI-11221 > URL: https://issues.apache.org/jira/browse/NIFI-11221 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike Thomsen >Assignee: Mike Thomsen >Priority: Major > Fix For: 2.latest > > Time Spent: 40m > Remaining Estimate: 0h > > The configuration should be done entirely through the controller service that > manages the connections. That class has been around for a few years now, so > it shouldn't be a surprise to anyone. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7194: NIFI-11167 - Add Excel Record Reader
exceptionfactory commented on code in PR #7194:
URL: https://github.com/apache/nifi/pull/7194#discussion_r1199060548
##
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/excel/RowIterator.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */package org.apache.nifi.excel;
+
+import com.github.pjfanning.xlsx.StreamingReader;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.poi.ss.usermodel.Row;
+import org.apache.poi.ss.usermodel.Sheet;
+import org.apache.poi.ss.usermodel.Workbook;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class RowIterator implements Iterator, Closeable {
+private final Workbook workbook;
+private final Iterator sheets;
+private Sheet currentSheet;
+private Iterator currentRows;
+private final Map desiredSheets;
+private final int firstRow;
+private ComponentLog logger;
+private boolean log;
+private Row currentRow;
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow) {
+this(in, desiredSheets, firstRow, null);
+}
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow, ComponentLog logger) {
+this.workbook = StreamingReader.builder()
+.rowCacheSize(100)
+.bufferSize(4096)
+.open(in);
+this.sheets = this.workbook.iterator();
+this.desiredSheets = desiredSheets != null ? desiredSheets.stream()
+.collect(Collectors.toMap(key -> key, value -> Boolean.FALSE))
: new HashMap<>();
+this.firstRow = firstRow;
+this.logger = logger;
+this.log = logger != null;
+}
+
+@Override
+public boolean hasNext() {
+setCurrent();
+boolean next = currentRow != null;
+if(!next) {
+String sheetsNotFound = getSheetsNotFound(desiredSheets);
+if (!sheetsNotFound.isEmpty() && log) {
+logger.warn("Excel sheet(s) not found: {}", sheetsNotFound);
+}
Review Comment:
You're right, I was thinking more of Record Writers and Processors that
generate record-oriented files. With that in mind, it looks like there isn't a
good way to signal a problem of this kind, other than throwing an exception.
With that in mind, I think the property should be changed to `Required
Sheets`, and the description should indicate that the absence of these Sheets
will throw an exception. We could theoretically introduce a `Sheet Processing
Strategy` of some kind, but I think having the single `Required Sheets`
property is the best way to go forward for now. How does that sound? In that
case, instead of logging a warning, this condition would throw an `IOException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #7213: NIFI-11221 Removed client configuration from AbstractMongoProcessor.
mattyb149 closed pull request #7213: NIFI-11221 Removed client configuration from AbstractMongoProcessor. URL: https://github.com/apache/nifi/pull/7213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #7213: NIFI-11221 Removed client configuration from AbstractMongoProcessor.
mattyb149 commented on PR #7213: URL: https://github.com/apache/nifi/pull/7213#issuecomment-1554713567 +1 LGTM, thanks for the improvement! Merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7194: NIFI-11167 - Add Excel Record Reader
dan-s1 commented on code in PR #7194:
URL: https://github.com/apache/nifi/pull/7194#discussion_r1199046989
##
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/excel/RowIterator.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */package org.apache.nifi.excel;
+
+import com.github.pjfanning.xlsx.StreamingReader;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.poi.ss.usermodel.Row;
+import org.apache.poi.ss.usermodel.Sheet;
+import org.apache.poi.ss.usermodel.Workbook;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class RowIterator implements Iterator, Closeable {
+private final Workbook workbook;
+private final Iterator sheets;
+private Sheet currentSheet;
+private Iterator currentRows;
+private final Map desiredSheets;
+private final int firstRow;
+private ComponentLog logger;
+private boolean log;
+private Row currentRow;
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow) {
+this(in, desiredSheets, firstRow, null);
+}
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow, ComponentLog logger) {
+this.workbook = StreamingReader.builder()
+.rowCacheSize(100)
+.bufferSize(4096)
+.open(in);
+this.sheets = this.workbook.iterator();
+this.desiredSheets = desiredSheets != null ? desiredSheets.stream()
+.collect(Collectors.toMap(key -> key, value -> Boolean.FALSE))
: new HashMap<>();
+this.firstRow = firstRow;
+this.logger = logger;
+this.log = logger != null;
+}
+
+@Override
+public boolean hasNext() {
+setCurrent();
+boolean next = currentRow != null;
+if(!next) {
+String sheetsNotFound = getSheetsNotFound(desiredSheets);
+if (!sheetsNotFound.isEmpty() && log) {
+logger.warn("Excel sheet(s) not found: {}", sheetsNotFound);
+}
Review Comment:
@exceptionfactory I did not see other record readers with a record.count
attribute. Which one(s) did you see this in? I did a search for `record.count`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7194: NIFI-11167 - Add Excel Record Reader
dan-s1 commented on code in PR #7194:
URL: https://github.com/apache/nifi/pull/7194#discussion_r1199046989
##
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/excel/RowIterator.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */package org.apache.nifi.excel;
+
+import com.github.pjfanning.xlsx.StreamingReader;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.poi.ss.usermodel.Row;
+import org.apache.poi.ss.usermodel.Sheet;
+import org.apache.poi.ss.usermodel.Workbook;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class RowIterator implements Iterator, Closeable {
+private final Workbook workbook;
+private final Iterator sheets;
+private Sheet currentSheet;
+private Iterator currentRows;
+private final Map desiredSheets;
+private final int firstRow;
+private ComponentLog logger;
+private boolean log;
+private Row currentRow;
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow) {
+this(in, desiredSheets, firstRow, null);
+}
+
+public RowIterator(InputStream in, List desiredSheets, int
firstRow, ComponentLog logger) {
+this.workbook = StreamingReader.builder()
+.rowCacheSize(100)
+.bufferSize(4096)
+.open(in);
+this.sheets = this.workbook.iterator();
+this.desiredSheets = desiredSheets != null ? desiredSheets.stream()
+.collect(Collectors.toMap(key -> key, value -> Boolean.FALSE))
: new HashMap<>();
+this.firstRow = firstRow;
+this.logger = logger;
+this.log = logger != null;
+}
+
+@Override
+public boolean hasNext() {
+setCurrent();
+boolean next = currentRow != null;
+if(!next) {
+String sheetsNotFound = getSheetsNotFound(desiredSheets);
+if (!sheetsNotFound.isEmpty() && log) {
+logger.warn("Excel sheet(s) not found: {}", sheetsNotFound);
+}
Review Comment:
@exceptionfactory I did not see other record readers with a record.count
attribute. Which one(s) did you see this in? I did a search for `record,.count`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7211: NIFI-8287: Updating SQS processors to use AWS SDK version 2.x
exceptionfactory commented on code in PR #7211:
URL: https://github.com/apache/nifi/pull/7211#discussion_r1198998416
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/v2/AbstractAwsProcessor.java:
##
@@ -0,0 +1,451 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.aws.v2;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.annotation.lifecycle.OnShutdown;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.ConfigVerificationResult;
+import org.apache.nifi.components.ConfigVerificationResult.Outcome;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.context.PropertyContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.VerifiableProcessor;
+import org.apache.nifi.processor.util.StandardValidators;
+import
org.apache.nifi.processors.aws.credentials.provider.PropertiesCredentialsProvider;
+import
org.apache.nifi.processors.aws.credentials.provider.factory.CredentialPropertyDescriptors;
+import
org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderService;
+import org.apache.nifi.proxy.ProxyConfiguration;
+import org.apache.nifi.proxy.ProxyConfigurationService;
+import org.apache.nifi.proxy.ProxySpec;
+import org.apache.nifi.security.util.KeyStoreUtils;
+import org.apache.nifi.security.util.TlsException;
+import org.apache.nifi.ssl.SSLContextService;
+import software.amazon.awssdk.auth.credentials.AnonymousCredentialsProvider;
+import software.amazon.awssdk.auth.credentials.AwsBasicCredentials;
+import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
+import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider;
+import software.amazon.awssdk.awscore.client.builder.AwsClientBuilder;
+import software.amazon.awssdk.awscore.client.builder.AwsSyncClientBuilder;
+import software.amazon.awssdk.core.SdkClient;
+import software.amazon.awssdk.core.client.config.SdkAdvancedClientOption;
+import software.amazon.awssdk.core.retry.RetryPolicy;
+import software.amazon.awssdk.http.SdkHttpClient;
+import software.amazon.awssdk.http.apache.ApacheHttpClient;
+import software.amazon.awssdk.regions.Region;
+
+import javax.net.ssl.KeyManagerFactory;
+import javax.net.ssl.TrustManager;
+import java.io.File;
+import java.net.Proxy;
+import java.net.URI;
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Base class for aws processors using the AWS v2 SDK.
+ *
+ * @param client type
+ *
+ * @see https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/auth/credentials/AwsCredentialsProvider.html;>AwsCredentialsProvider
+ */
+public abstract class AbstractAwsProcessor & AwsClientBuilder>
+extends AbstractProcessor implements VerifiableProcessor,
AwsClientProvider {
+
+protected static final String DEFAULT_USER_AGENT = "NiFi";
+public static final Region DEFAULT_REGION = Region.US_WEST_2;
+
+public static final Relationship REL_SUCCESS = new
Relationship.Builder().name("success")
+.description("FlowFiles are routed to success
relationship").build();
+public static final Relationship REL_FAILURE = new
Relationship.Builder().name("failure")
+.description("FlowFiles are routed to failure
relationship").build();
+
+public static final Set relationships =
Collections.unmodifiableSet(
+new HashSet<>(Arrays.asList(REL_SUCCESS, REL_FAILURE)));
+
+public static final PropertyDescriptor CREDENTIALS_FILE =
[jira] [Resolved] (NIFI-10397) InvokeHTTP is sending empty User-Agent header
[
https://issues.apache.org/jira/browse/NIFI-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-10397.
-
Assignee: David Handermann
Resolution: Won't Fix
Unfortunately this behavior appears to be the best option available based on
the usage of OkHttp.
The OkHttp library requires sending something for the {{User-Agent}} header.
When building a request, if InvokeHTTP did not set a {{{}User-Agent{}}}, the
library defaults to sending the library name and version number. OkHttp does
not support setting {{null}} for the {{User-Agent}} header, so sending an empty
string is the best option for those who want to avoid sending something. Other
HTTP client libraries might support different behavior, but changing libraries
for InvokeHTTP would require a substantial rewrite of the Processor.
> InvokeHTTP is sending empty User-Agent header
> -
>
> Key: NIFI-10397
> URL: https://issues.apache.org/jira/browse/NIFI-10397
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Josh Highley
>Assignee: David Handermann
>Priority: Minor
>
> Issue introduced by this change: [https://github.com/apache/nifi/pull/4428]
> When the InvokeHTTP processor configuration has no value for UserAgent,
> InvokeHTTP is still sending a User-Agent header but with no header value.
> (User-Agent: \r\n)
> If the configuration has no value, then no User-Agent header should be sent.
> An empty value for User-Agent header will trigger some request scanners
> attempting to block robots.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11250) InvokeHTTP drops the Body when using the DELETE method
[
https://issues.apache.org/jira/browse/NIFI-11250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724281#comment-17724281
]
David Handermann commented on NIFI-11250:
-
The lack of support for sending a request body has been part of the InvokeHTTP
implementation since early versions, the HttpMethod enum captures that fact as
part of more recent refactoring.
The RFC 9110 reference indicates that a client {{SHOULD NOT}} generate content
for a {{DELETE}} request, unless the semantics are described elsewhere. From
that perspective, the RFC discourages sending content, but does not disallow it
as described. Allowing InvokeHTTP to send a {{DELETE}} request would involve
some code changes as well as adjusting dependent properties to clarify
behavior. Given the long-standing status of the current implementation,
changing this seems questionable.
[~benj_928381923] Do you have a reference to well-known service that supports
{{DELETE}} requests with a body?
> InvokeHTTP drops the Body when using the DELETE method
> --
>
> Key: NIFI-11250
> URL: https://issues.apache.org/jira/browse/NIFI-11250
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Benji Benning
>Assignee: David Handermann
>Priority: Major
>
> Today, InvokeHTTP drops the Body when the method used isn't PUT, POST, or
> PATCH (As stated in the documentation). RFC states that DELETE with body
> isn't generally used, but doesn't disallow it.
> In my case, i'm using InvokeHTTP to interact with Keycloak's Admin REST API.
> They use DELETE with body in quite a few cases. for example in my specific
> use case:
> [https://www.keycloak.org/docs-api/21.0.1/rest-api/#_role_mapper_resource]
> (referring to: Delete realm-level role mappings)
> Additional information:
> {noformat}
> Although request message framing is independent of the method used, content
> received in a DELETE request has no generally defined semantics, cannot alter
> the meaning or target of the request, and might lead some implementations to
> reject the request and close the connection because of its potential as a
> request smuggling attack (Section 11.2 of [HTTP/1.1]). A client SHOULD NOT
> generate content in a DELETE request unless it is made directly to an origin
> server that has previously indicated, in or out of band, that such a request
> has a purpose and will be adequately supported. An origin server SHOULD NOT
> rely on private agreements to receive content, since participants in HTTP
> communication are often unaware of intermediaries along the request
> chain.{noformat}
> [https://www.rfc-editor.org/rfc/rfc9110.html#name-delete]
>
> During discussion with Otto Fowler, he stated that this is disabled in the
> [HTTPMethod
> enum|https://github.com/apache/nifi/blob/7a47c8cfbd458ab037275762c385d50372c130a3/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/http/HttpMethod.java].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11250) InvokeHTTP drops the Body when using the DELETE method
[
https://issues.apache.org/jira/browse/NIFI-11250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11250:
Issue Type: Improvement (was: Bug)
> InvokeHTTP drops the Body when using the DELETE method
> --
>
> Key: NIFI-11250
> URL: https://issues.apache.org/jira/browse/NIFI-11250
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.20.0
>Reporter: Benji Benning
>Assignee: David Handermann
>Priority: Major
>
> Today, InvokeHTTP drops the Body when the method used isn't PUT, POST, or
> PATCH (As stated in the documentation). RFC states that DELETE with body
> isn't generally used, but doesn't disallow it.
> In my case, i'm using InvokeHTTP to interact with Keycloak's Admin REST API.
> They use DELETE with body in quite a few cases. for example in my specific
> use case:
> [https://www.keycloak.org/docs-api/21.0.1/rest-api/#_role_mapper_resource]
> (referring to: Delete realm-level role mappings)
> Additional information:
> {noformat}
> Although request message framing is independent of the method used, content
> received in a DELETE request has no generally defined semantics, cannot alter
> the meaning or target of the request, and might lead some implementations to
> reject the request and close the connection because of its potential as a
> request smuggling attack (Section 11.2 of [HTTP/1.1]). A client SHOULD NOT
> generate content in a DELETE request unless it is made directly to an origin
> server that has previously indicated, in or out of band, that such a request
> has a purpose and will be adequately supported. An origin server SHOULD NOT
> rely on private agreements to receive content, since participants in HTTP
> communication are often unaware of intermediaries along the request
> chain.{noformat}
> [https://www.rfc-editor.org/rfc/rfc9110.html#name-delete]
>
> During discussion with Otto Fowler, he stated that this is disabled in the
> [HTTPMethod
> enum|https://github.com/apache/nifi/blob/7a47c8cfbd458ab037275762c385d50372c130a3/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/http/HttpMethod.java].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11250) InvokeHTTP drops the Body when using the DELETE method
[
https://issues.apache.org/jira/browse/NIFI-11250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11250:
Affects Version/s: (was: 1.20.0)
> InvokeHTTP drops the Body when using the DELETE method
> --
>
> Key: NIFI-11250
> URL: https://issues.apache.org/jira/browse/NIFI-11250
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Benji Benning
>Assignee: David Handermann
>Priority: Major
>
> Today, InvokeHTTP drops the Body when the method used isn't PUT, POST, or
> PATCH (As stated in the documentation). RFC states that DELETE with body
> isn't generally used, but doesn't disallow it.
> In my case, i'm using InvokeHTTP to interact with Keycloak's Admin REST API.
> They use DELETE with body in quite a few cases. for example in my specific
> use case:
> [https://www.keycloak.org/docs-api/21.0.1/rest-api/#_role_mapper_resource]
> (referring to: Delete realm-level role mappings)
> Additional information:
> {noformat}
> Although request message framing is independent of the method used, content
> received in a DELETE request has no generally defined semantics, cannot alter
> the meaning or target of the request, and might lead some implementations to
> reject the request and close the connection because of its potential as a
> request smuggling attack (Section 11.2 of [HTTP/1.1]). A client SHOULD NOT
> generate content in a DELETE request unless it is made directly to an origin
> server that has previously indicated, in or out of band, that such a request
> has a purpose and will be adequately supported. An origin server SHOULD NOT
> rely on private agreements to receive content, since participants in HTTP
> communication are often unaware of intermediaries along the request
> chain.{noformat}
> [https://www.rfc-editor.org/rfc/rfc9110.html#name-delete]
>
> During discussion with Otto Fowler, he stated that this is disabled in the
> [HTTPMethod
> enum|https://github.com/apache/nifi/blob/7a47c8cfbd458ab037275762c385d50372c130a3/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/http/HttpMethod.java].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (NIFI-11250) InvokeHTTP drops the Body when using the DELETE method
[
https://issues.apache.org/jira/browse/NIFI-11250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann reassigned NIFI-11250:
---
Assignee: David Handermann
> InvokeHTTP drops the Body when using the DELETE method
> --
>
> Key: NIFI-11250
> URL: https://issues.apache.org/jira/browse/NIFI-11250
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.20.0
>Reporter: Benji Benning
>Assignee: David Handermann
>Priority: Major
>
> Today, InvokeHTTP drops the Body when the method used isn't PUT, POST, or
> PATCH (As stated in the documentation). RFC states that DELETE with body
> isn't generally used, but doesn't disallow it.
> In my case, i'm using InvokeHTTP to interact with Keycloak's Admin REST API.
> They use DELETE with body in quite a few cases. for example in my specific
> use case:
> [https://www.keycloak.org/docs-api/21.0.1/rest-api/#_role_mapper_resource]
> (referring to: Delete realm-level role mappings)
> Additional information:
> {noformat}
> Although request message framing is independent of the method used, content
> received in a DELETE request has no generally defined semantics, cannot alter
> the meaning or target of the request, and might lead some implementations to
> reject the request and close the connection because of its potential as a
> request smuggling attack (Section 11.2 of [HTTP/1.1]). A client SHOULD NOT
> generate content in a DELETE request unless it is made directly to an origin
> server that has previously indicated, in or out of band, that such a request
> has a purpose and will be adequately supported. An origin server SHOULD NOT
> rely on private agreements to receive content, since participants in HTTP
> communication are often unaware of intermediaries along the request
> chain.{noformat}
> [https://www.rfc-editor.org/rfc/rfc9110.html#name-delete]
>
> During discussion with Otto Fowler, he stated that this is disabled in the
> [HTTPMethod
> enum|https://github.com/apache/nifi/blob/7a47c8cfbd458ab037275762c385d50372c130a3/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/http/HttpMethod.java].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-6238) Escape HTTP header names in InvokeHTTP processor
[ https://issues.apache.org/jira/browse/NIFI-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-6238. Resolution: Abandoned > Escape HTTP header names in InvokeHTTP processor > > > Key: NIFI-6238 > URL: https://issues.apache.org/jira/browse/NIFI-6238 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.9.2 >Reporter: Troy Melhase >Assignee: Troy Melhase >Priority: Major > Labels: InvokeHTTP, hostname, http, security > > HTTP headers are not checked/escaped during `InvokeHTTP.setHeaderProperties`. > When applying dynamic properties as HTTP headers, invalid headers break the > request, for example "Trusted Host". > > In lieu of setting the header name directly, the header name should be > escaped and then set. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-5086) Many usages of AbstractElasticsearchHttpProcessor.sendRequestToElasticsearch aren't closed properly
[ https://issues.apache.org/jira/browse/NIFI-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-5086. Resolution: Incomplete > Many usages of AbstractElasticsearchHttpProcessor.sendRequestToElasticsearch > aren't closed properly > --- > > Key: NIFI-5086 > URL: https://issues.apache.org/jira/browse/NIFI-5086 > Project: Apache NiFi > Issue Type: Bug >Reporter: Joe Percivall >Priority: Major > > Similar to NIFI-5085, all OkHttp responses must be closed[1]. > "AbstractElasticsearchHttpProcessor.sendRequestToElasticsearch" returns the > actual OkHttp response. All implementing processors should properly close > this. Processors that need to be updated: > * FetchElasticsearchHttp[2] > * PutElasticsearchHttp[3] > * PutElasticsearchHttpRecord[4] > * QueryElasticsearchHttp[5] > * ScrollElasticsearchHtt[6][7] > [1] [https://github.com/square/okhttp/issues/2311] > [2] > [[https://github.com/apache/nifi/blob/9736cb9d338b611ff3a096d97fd439cf8b8bbac3/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/FetchElasticsearchHttp.java#L223] > [3][https://github.com/apache/nifi/blob/e916594b69601bce58e045ba8ae2acf6af66eb46/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttp.java#L337] > [4] > [https://github.com/apache/nifi/blob/6b34d3bea9a1fd0923024018d73c3c0b0a807a67/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttpRecord.java#L400] > [5] > [[https://github.com/apache/nifi/blob/6baea8ccffe93e6ea6289cac8970f95e95f797bf/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/QueryElasticsearchHttp.java#L287] > [6] > [[https://github.com/apache/nifi/blob/6baea8ccffe93e6ea6289cac8970f95e95f797bf/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/ScrollElasticsearchHttp.java#L256] > [7][https://github.com/apache/nifi/blob/6baea8ccffe93e6ea6289cac8970f95e95f797bf/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/ScrollElasticsearchHttp.java#L269] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-7915) Components using okhttp 3.x Broken on Nifi 1.9.2
[
https://issues.apache.org/jira/browse/NIFI-7915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-7915.
Resolution: Cannot Reproduce
> Components using okhttp 3.x Broken on Nifi 1.9.2
>
>
> Key: NIFI-7915
> URL: https://issues.apache.org/jira/browse/NIFI-7915
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.9.2
>Reporter: Jake Dalli
>Priority: Major
>
> Hi,
> As of the latest Java version (8u252), components using the okhttp3
> dependency are broken with the following error:
> {code:java}
> clientBuilder.sslSocketFactory(SSLSocketFactory) not supported on JDK 9
> {code}
> Following some investigation, it turns out to be an issue with the
> dependency: [https://github.com/square/okhttp/issues/6019]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-8560) 0.6.0 Release Notes
[ https://issues.apache.org/jira/browse/NIFI-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-8560. Resolution: Abandoned > 0.6.0 Release Notes > --- > > Key: NIFI-8560 > URL: https://issues.apache.org/jira/browse/NIFI-8560 > Project: Apache NiFi > Issue Type: Task >Affects Versions: 0.6.0 >Reporter: Nathan Gough >Priority: Major > Labels: release, releasenotes > > This issue is tracking what work needs to be done for release notes to > release 0.6.0. > * Include dependency version changes > * Notify users that the OkHTTP upgrade will now require certificates to > include a DNS SAN entry, as recommended by > [https://tools.ietf.org/html/rfc6125]. Users will find that certificates > without a valid SAN entry in certificates used with MiNiFi will result in > failed TLS negotiation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] r-sidd commented on pull request #7270: NIFI-10611 upgrade ignite-core to 2.15.0
r-sidd commented on PR #7270: URL: https://github.com/apache/nifi/pull/7270#issuecomment-1554542087 > Thanks for contribution @r-sidd. The Maven configuration also includes an `ignite-slf4j` library version that needs to be updated. I'm sorry about that, let me commit and push the changes. Bumping both `ignite-slf4j` and `ignite-spring` to 2.15.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-1022) Create GetTachyon and PutTachyon Processors
[ https://issues.apache.org/jira/browse/NIFI-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-1022. Resolution: Abandoned > Create GetTachyon and PutTachyon Processors > --- > > Key: NIFI-1022 > URL: https://issues.apache.org/jira/browse/NIFI-1022 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Jeremy Dyer >Priority: Minor > Attachments: Alluxio.xml > > > Provide support for Apache Tachyon by implementing a GetTachyon and > PutTachyon processor. Having the ability to both read and write to Tachyon > would assist in sharing data with external applications such as Spark. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-10285) NIFI - Cassandra 4.0 connection
[ https://issues.apache.org/jira/browse/NIFI-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-10285. - Resolution: Duplicate > NIFI - Cassandra 4.0 connection > --- > > Key: NIFI-10285 > URL: https://issues.apache.org/jira/browse/NIFI-10285 > Project: Apache NiFi > Issue Type: Wish > Components: Extensions >Affects Versions: 1.16.3 >Reporter: batbileg >Priority: Major > Labels: easyfix > > Cant connect cassandra 4.0. > Nifi components can connect to cassandra 3.0 which cassandra 3.0 only works > on python 2.7(outdated version of python). > is there any way that nifi's components support cassandra 4.0? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-10746) Update cassandra-driver-core To 3.11.X Or 4.X.Y
[ https://issues.apache.org/jira/browse/NIFI-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-10746. - Resolution: Duplicate This issue requires significant refactoring of the Cassandra components and is already being tracked in NIFI-9770. > Update cassandra-driver-core To 3.11.X Or 4.X.Y > --- > > Key: NIFI-10746 > URL: https://issues.apache.org/jira/browse/NIFI-10746 > Project: Apache NiFi > Issue Type: Wish >Affects Versions: 1.18.0 >Reporter: Mike R >Priority: Major > > Update cassandra-driver-core To 4.X.Y from 3.10.2, which has some CVE in its > components. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-11563) Versioned component synchronizer does not stop source connectable for new connection
[ https://issues.apache.org/jira/browse/NIFI-11563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFI-11563. Fix Version/s: 2.0.0 1.22.0 Resolution: Fixed > Versioned component synchronizer does not stop source connectable for new > connection > > > Key: NIFI-11563 > URL: https://issues.apache.org/jira/browse/NIFI-11563 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.21.0 >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Minor > Fix For: 2.0.0, 1.22.0 > > > Although this cannot be reproduced directly in NiFi, if any external tools > use the StandardVersionedComponentSynchronizer to synchronize a flow, then > adding a connection with an already-running source throws an exception. This > is because although upstream connections are restarted for existing > connections, they are not restarted for new connections. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11563) Versioned component synchronizer does not stop source connectable for new connection
[ https://issues.apache.org/jira/browse/NIFI-11563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724244#comment-17724244 ] ASF subversion and git services commented on NIFI-11563: Commit 0e6a099eb690141e3dd2b447290fc81df39dc1f1 in nifi's branch refs/heads/support/nifi-1.x from Joe Gresock [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0e6a099eb6 ] NIFI-11563: Allowing source connectables to be restarted on new connections in the StandardVersionedComponentSynchronizer (#7261) > Versioned component synchronizer does not stop source connectable for new > connection > > > Key: NIFI-11563 > URL: https://issues.apache.org/jira/browse/NIFI-11563 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.21.0 >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Minor > > Although this cannot be reproduced directly in NiFi, if any external tools > use the StandardVersionedComponentSynchronizer to synchronize a flow, then > adding a connection with an already-running source throws an exception. This > is because although upstream connections are restarted for existing > connections, they are not restarted for new connections. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11563) Versioned component synchronizer does not stop source connectable for new connection
[ https://issues.apache.org/jira/browse/NIFI-11563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724243#comment-17724243 ] ASF subversion and git services commented on NIFI-11563: Commit 28f003d8869d390b132204b04639c8db6015ba95 in nifi's branch refs/heads/main from Joe Gresock [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=28f003d886 ] NIFI-11563: Allowing source connectables to be restarted on new connections in the StandardVersionedComponentSynchronizer (#7261) > Versioned component synchronizer does not stop source connectable for new > connection > > > Key: NIFI-11563 > URL: https://issues.apache.org/jira/browse/NIFI-11563 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.21.0 >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Minor > > Although this cannot be reproduced directly in NiFi, if any external tools > use the StandardVersionedComponentSynchronizer to synchronize a flow, then > adding a connection with an already-running source throws an exception. This > is because although upstream connections are restarted for existing > connections, they are not restarted for new connections. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] bbende merged pull request #7261: NIFI-11563: Allowing source connectables to be restarted on new conne…
bbende merged PR #7261: URL: https://github.com/apache/nifi/pull/7261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request, #1577: MINIFICPP-2020 - Protect MINIFI_HOME from mutual access
adamdebreceni opened a new pull request, #1577: URL: https://github.com/apache/nifi-minifi-cpp/pull/1577 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-10611) Upgrade org.apache.ignite ignite-core5 to 2.13.0
[ https://issues.apache.org/jira/browse/NIFI-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724221#comment-17724221 ] Siddharth R commented on NIFI-10611: PR: [https://github.com/apache/nifi/pull/7270] > Upgrade org.apache.ignite ignite-core5 to 2.13.0 > > > Key: NIFI-10611 > URL: https://issues.apache.org/jira/browse/NIFI-10611 > Project: Apache NiFi > Issue Type: Wish >Affects Versions: 1.17.0, 1.18.0 >Reporter: Mike R >Assignee: Siddharth R >Priority: Major > > Curious to see if it is possible to upgrade ignite-core5 version from 1.6 to > a version similar to 2.13.0 to mitigate the following CVE in 1.6: > CVE-2020-1963 > CVE-2018-8018 > CVE-2018-1295 > CVE-2017-7686 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] r-sidd opened a new pull request, #7270: Nifi 10611 upgrade ignite-core to 2.13.0
r-sidd opened a new pull request, #7270: URL: https://github.com/apache/nifi/pull/7270 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-10611) Upgrade org.apache.ignite ignite-core5 to 2.13.0
[ https://issues.apache.org/jira/browse/NIFI-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth R reassigned NIFI-10611: -- Assignee: Siddharth R > Upgrade org.apache.ignite ignite-core5 to 2.13.0 > > > Key: NIFI-10611 > URL: https://issues.apache.org/jira/browse/NIFI-10611 > Project: Apache NiFi > Issue Type: Wish >Affects Versions: 1.17.0, 1.18.0 >Reporter: Mike R >Assignee: Siddharth R >Priority: Major > > Curious to see if it is possible to upgrade ignite-core5 version from 1.6 to > a version similar to 2.13.0 to mitigate the following CVE in 1.6: > CVE-2020-1963 > CVE-2018-8018 > CVE-2018-1295 > CVE-2017-7686 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1576: MINIFICPP-2121 - Use std::atomic_flag instead of semaphore
adamdebreceni commented on code in PR #1576:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1576#discussion_r1198785129
##
minifi_main/MiNiFiMain.cpp:
##
@@ -91,27 +90,26 @@ static sem_t *process_running;
#ifdef WIN32
BOOL WINAPI consoleSignalHandler(DWORD signal) {
- if (!process_running) { exit(0); return TRUE; }
+ if (!process_running.test()) { exit(0); return TRUE; }
if (signal == CTRL_C_EVENT || signal == CTRL_BREAK_EVENT) {
-int ret = ETIMEDOUT;
-while (ret == ETIMEDOUT) {
- if (flow_controller_running) { sem_post(flow_controller_running); }
- const struct timespec timeout_100ms { .tv_sec = 0, .tv_nsec = 1};
- ret = sem_timedwait(process_running, _100ms);
-}
+flow_controller_running.clear();
+flow_controller_running.notify_all();
+process_running.wait(false);
return TRUE;
}
return FALSE;
}
void SignalExitProcess() {
- sem_post(flow_controller_running);
+ flow_controller_running.clear();
+ flow_controller_running.notify_all();
Review Comment:
according to the standard calling a non-static member function of
`std::atomic_flag` is a "plain lock-free atomic operation" which is allowed in
signal handlers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (NIFI-11566) CLI set-param command can timeout in some cases
[ https://issues.apache.org/jira/browse/NIFI-11566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-11566. --- Fix Version/s: 2.0.0 1.22.0 Resolution: Fixed > CLI set-param command can timeout in some cases > --- > > Key: NIFI-11566 > URL: https://issues.apache.org/jira/browse/NIFI-11566 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.21.0 >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Major > Fix For: 2.0.0, 1.22.0 > > > In cases where controller services take a long time to disable/enable, the > NIFI CLI command 'set-param' can timeout, causing problems for client code. > This command currently has a hard-coded 60-second timeout, which needs to be > configurable. An update timeout should be added as an argument to the > command. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11566) CLI set-param command can timeout in some cases
[ https://issues.apache.org/jira/browse/NIFI-11566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724214#comment-17724214 ] ASF subversion and git services commented on NIFI-11566: Commit e8ceed52acbbba552478192f13ad51bc65d53cc9 in nifi's branch refs/heads/support/nifi-1.x from Joe Gresock [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e8ceed52ac ] NIFI-11566: Adding updateTimeout argument to parameter commands in CLI Signed-off-by: Pierre Villard This closes #7267. > CLI set-param command can timeout in some cases > --- > > Key: NIFI-11566 > URL: https://issues.apache.org/jira/browse/NIFI-11566 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.21.0 >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Major > > In cases where controller services take a long time to disable/enable, the > NIFI CLI command 'set-param' can timeout, causing problems for client code. > This command currently has a hard-coded 60-second timeout, which needs to be > configurable. An update timeout should be added as an argument to the > command. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11566) CLI set-param command can timeout in some cases
[ https://issues.apache.org/jira/browse/NIFI-11566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724213#comment-17724213 ] ASF subversion and git services commented on NIFI-11566: Commit 6ee4632267fd1ffe645bfc1289def5d20da01500 in nifi's branch refs/heads/main from Joe Gresock [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6ee4632267 ] NIFI-11566: Adding updateTimeout argument to parameter commands in CLI Signed-off-by: Pierre Villard This closes #7267. > CLI set-param command can timeout in some cases > --- > > Key: NIFI-11566 > URL: https://issues.apache.org/jira/browse/NIFI-11566 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build >Affects Versions: 1.21.0 >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Major > > In cases where controller services take a long time to disable/enable, the > NIFI CLI command 'set-param' can timeout, causing problems for client code. > This command currently has a hard-coded 60-second timeout, which needs to be > configurable. An update timeout should be added as an argument to the > command. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #7267: NIFI-11566: Adding updateTimeout argument to parameter commands in CLI
asfgit closed pull request #7267: NIFI-11566: Adding updateTimeout argument to parameter commands in CLI URL: https://github.com/apache/nifi/pull/7267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1576: MINIFICPP-2121 - Use std::atomic_flag instead of semaphore
szaszm commented on code in PR #1576:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1576#discussion_r1198737019
##
minifi_main/MiNiFiMain.cpp:
##
@@ -91,27 +90,26 @@ static sem_t *process_running;
#ifdef WIN32
BOOL WINAPI consoleSignalHandler(DWORD signal) {
- if (!process_running) { exit(0); return TRUE; }
+ if (!process_running.test()) { exit(0); return TRUE; }
if (signal == CTRL_C_EVENT || signal == CTRL_BREAK_EVENT) {
-int ret = ETIMEDOUT;
-while (ret == ETIMEDOUT) {
- if (flow_controller_running) { sem_post(flow_controller_running); }
- const struct timespec timeout_100ms { .tv_sec = 0, .tv_nsec = 1};
- ret = sem_timedwait(process_running, _100ms);
-}
+flow_controller_running.clear();
+flow_controller_running.notify_all();
+process_running.wait(false);
return TRUE;
}
return FALSE;
}
void SignalExitProcess() {
- sem_post(flow_controller_running);
+ flow_controller_running.clear();
+ flow_controller_running.notify_all();
Review Comment:
Is this approach signal safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (NIFI-10611) Upgrade org.apache.ignite ignite-core5 to 2.13.0
[ https://issues.apache.org/jira/browse/NIFI-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724200#comment-17724200 ] Siddharth R edited comment on NIFI-10611 at 5/19/23 9:11 AM: - Can I take this up? [~msr1716] was (Author: JIRAUSER300307): Can I take this up [~msr1716] > Upgrade org.apache.ignite ignite-core5 to 2.13.0 > > > Key: NIFI-10611 > URL: https://issues.apache.org/jira/browse/NIFI-10611 > Project: Apache NiFi > Issue Type: Wish >Affects Versions: 1.17.0, 1.18.0 >Reporter: Mike R >Priority: Major > > Curious to see if it is possible to upgrade ignite-core5 version from 1.6 to > a version similar to 2.13.0 to mitigate the following CVE in 1.6: > CVE-2020-1963 > CVE-2018-8018 > CVE-2018-1295 > CVE-2017-7686 -- This message was sent by Atlassian Jira (v8.20.10#820010)
