[GitHub] [nifi] r-sidd commented on pull request #7341: NIFI-11643: Upgrade geoip2 to 4.0.1
r-sidd commented on PR #7341: URL: https://github.com/apache/nifi/pull/7341#issuecomment-1579861542 > Thanks @r-sidd, this upgrade looks good for the main branch. This cannot be backported to the support branch due to Java 11 requirements, but this is helpful for the next major release version. +1 merging Cool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2126) Reenable windows CI caching with sccache
[ https://issues.apache.org/jira/browse/MINIFICPP-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2126: Resolution: Done Status: Resolved (was: Patch Available) > Reenable windows CI caching with sccache > > > Key: MINIFICPP-2126 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2126 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Marton Szasz >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > In MINIFICPP-1499 we enabled clcache, but it broke builds in some cases, so > it had to be disabled later. Sccache seems to have matured a lot since, so we > can try enabling that one to keep the build times at bay. Currently Windows > CI builds often exceed 2.5 hours. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2120) Fix debian bookworm, and various bootstrap issues
[ https://issues.apache.org/jira/browse/MINIFICPP-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2120. - Resolution: Fixed > Fix debian bookworm, and various bootstrap issues > - > > Key: MINIFICPP-2120 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2120 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Marton Szasz >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > - move backports code to buster only, because cmake is new enough > - install compiler before the menu, so that entries can be selected > - Add boost package names > - devtoolset no longer requires nested calling of bootstrap > - fix compiler version checks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11654) Conduct Apache NiFi 1.22.0 release
[ https://issues.apache.org/jira/browse/NIFI-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729849#comment-17729849 ] ASF subversion and git services commented on NIFI-11654: Commit 15ebf56a085e7da820c2406cd512c6b1c2a5cefd in nifi's branch refs/heads/NIFI-11654-RC1 from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=15ebf56a08 ] NIFI-11654 removing extraneous tag > Conduct Apache NiFi 1.22.0 release > -- > > Key: NIFI-11654 > URL: https://issues.apache.org/jira/browse/NIFI-11654 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.22.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11654) Conduct Apache NiFi 1.22.0 release
[ https://issues.apache.org/jira/browse/NIFI-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729851#comment-17729851 ] ASF subversion and git services commented on NIFI-11654: Commit f1d5a8c4de3c2166c688a4c07478c2268dc15290 in nifi's branch refs/heads/NIFI-11654-RC1 from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f1d5a8c4de ] NIFI-11654-RC1 prepare for next development iteration > Conduct Apache NiFi 1.22.0 release > -- > > Key: NIFI-11654 > URL: https://issues.apache.org/jira/browse/NIFI-11654 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.22.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11654) Conduct Apache NiFi 1.22.0 release
[ https://issues.apache.org/jira/browse/NIFI-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729850#comment-17729850 ] ASF subversion and git services commented on NIFI-11654: Commit 71e3ea9f2c58d0cf2ce6824c388f2bd3e917dfc8 in nifi's branch refs/heads/NIFI-11654-RC1 from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=71e3ea9f2c ] NIFI-11654-RC1 prepare release nifi-1.22.0-RC1 > Conduct Apache NiFi 1.22.0 release > -- > > Key: NIFI-11654 > URL: https://issues.apache.org/jira/browse/NIFI-11654 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.22.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] dan-s1 commented on pull request #7194: NIFI-11167 - Add Excel Record Reader
dan-s1 commented on PR #7194: URL: https://github.com/apache/nifi/pull/7194#issuecomment-1579479353 @exceptionfactory Please let me know if there is anything else. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7274: NIFI-11553 - additional configurability for GCP processors; PublishGC…
exceptionfactory commented on code in PR #7274:
URL: https://github.com/apache/nifi/pull/7274#discussion_r1220305463
##
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/publish/NiFiApiFutureCallback.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.gcp.pubsub.publish;
+
+import com.google.api.core.ApiFutureCallback;
+
+import java.util.List;
+
+/**
+ * Specialization of {@link ApiFutureCallback} used to track Google PubSub
send results. Failure
+ * exceptions are captured to facilitate FlowFile routing decisions.
+ */
+public class NiFiApiFutureCallback implements ApiFutureCallback {
Review Comment:
Rather than using `NiFi` as the suffix, recommend something more specific to
the function, such as `TrackedApiFutureCallback`
##
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSubTest.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.gcp.pubsub;
+
+import com.google.api.core.ApiFuture;
+import com.google.api.core.ApiFutureCallback;
+import com.google.api.gax.grpc.GrpcStatusCode;
+import com.google.api.gax.rpc.UnavailableException;
+import com.google.cloud.pubsub.v1.Publisher;
+import io.grpc.Status;
+import org.apache.commons.io.IOUtils;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.controller.ControllerService;
+import org.apache.nifi.json.JsonRecordSetWriter;
+import org.apache.nifi.json.JsonTreeReader;
+import org.apache.nifi.processor.ProcessContext;
+import
org.apache.nifi.processors.gcp.credentials.service.GCPCredentialsControllerService;
+import org.apache.nifi.processors.gcp.pubsub.publish.ContentInputStrategy;
+import org.apache.nifi.processors.gcp.pubsub.publish.NiFiApiFutureCallback;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.util.MockFlowFile;
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.io.IOException;
+import java.util.Objects;
+import java.util.concurrent.Executor;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class PublishGCPubSubTest {
+
+private Throwable throwable;
+private Publisher publisherMock;
+private TestRunner runner;
+
+@BeforeEach
+void setRunner() {
+throwable = null;
+publisherMock = mock(Publisher.class);
+runner = TestRunners.newTestRunner(new PublishGCPubSub() {
+@Override
+@OnScheduled
+public void onScheduled(ProcessContext context) {
+publisher = publisherMock;
+}
+
+@Override
+protected void addCallback(ApiFuture apiFuture,
ApiFutureCallback callback, Executor executor) {
+if (callback instanceof NiFiApiFutureCallback) {
+final NiFiApiFutureCallback niFiApiFutureCallback =
(NiFiApiFutureCallback) callback;
+if (throwable == null) {
+
[jira] [Commented] (NIFI-11643) Upgrade geoip2 to 4.0.1
[ https://issues.apache.org/jira/browse/NIFI-11643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729838#comment-17729838 ] ASF subversion and git services commented on NIFI-11643: Commit e72ca689c2a6a2627192c9ebccecfadca682090c in nifi's branch refs/heads/main from siddr [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e72ca689c2 ] NIFI-11643 Upgraded geoip2 from 2.16.1 to 4.0.1 This closes #7341 Signed-off-by: David Handermann > Upgrade geoip2 to 4.0.1 > --- > > Key: NIFI-11643 > URL: https://issues.apache.org/jira/browse/NIFI-11643 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Siddharth R >Assignee: Siddharth R >Priority: Minor > Labels: dependency-upgrade > Fix For: 2.latest > > Time Spent: 40m > Remaining Estimate: 0h > > Bump version from 2.16.1 to 4.0.1 to remediate findings: > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-42004] > [https://mvnrepository.com/artifact/com.maxmind.geoip2/geoip2/2.16.1#:~:text=CVE%2D2022%2D42004-,CVE%2D2022%2D42003,-CVE%2D2021%2D46877] > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-46877] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-11643) Upgrade geoip2 to 4.0.1
[ https://issues.apache.org/jira/browse/NIFI-11643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11643. - Fix Version/s: 2.0.0 (was: 2.latest) Resolution: Fixed > Upgrade geoip2 to 4.0.1 > --- > > Key: NIFI-11643 > URL: https://issues.apache.org/jira/browse/NIFI-11643 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Siddharth R >Assignee: Siddharth R >Priority: Minor > Labels: dependency-upgrade > Fix For: 2.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Bump version from 2.16.1 to 4.0.1 to remediate findings: > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-42004] > [https://mvnrepository.com/artifact/com.maxmind.geoip2/geoip2/2.16.1#:~:text=CVE%2D2022%2D42004-,CVE%2D2022%2D42003,-CVE%2D2021%2D46877] > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-46877] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on pull request #7304: NIFI-11551 Default Use Avro Logical Types To True
exceptionfactory commented on PR #7304: URL: https://github.com/apache/nifi/pull/7304#issuecomment-1579383993 @jbalchan Given that this change involves the potential for a number of unit test changes, I am closing this pull request for now. Feel free to follow up and reopen the PR after you have resolved the issues and have verified a successful build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7304: NIFI-11551 Default Use Avro Logical Types To True
exceptionfactory closed pull request #7304: NIFI-11551 Default Use Avro Logical Types To True URL: https://github.com/apache/nifi/pull/7304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory opened a new pull request, #7351: NIFI-11657 Remove Deprecated PutBigQueryBatch and PutBigQueryStreaming
exceptionfactory opened a new pull request, #7351: URL: https://github.com/apache/nifi/pull/7351 # Summary [NIFI-11657](https://issues.apache.org/jira/browse/NIFI-11657) Removes the deprecated `PutBigQueryBatch` and `PutBigQueryStreaming` Processors which were deprecated with the introduction of `PutBigQuery` in [NIFI-10403](https://issues.apache.org/jira/browse/NIFI-10403). This removal aligns with NiFi 2.0 release goals for removing deprecated components. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11657) Remove Deprecated PutBigQueryBatch and PutBigQueryStreaming
David Handermann created NIFI-11657:
---
Summary: Remove Deprecated PutBigQueryBatch and
PutBigQueryStreaming
Key: NIFI-11657
URL: https://issues.apache.org/jira/browse/NIFI-11657
Project: Apache NiFi
Issue Type: Task
Reporter: David Handermann
Assignee: David Handermann
Fix For: 2.0.0
The addition of the {{PutBigQuery}} Processors provided a flexible alternative
to the more specific {{PutBigQueryBatch}} and {{PutBigQueryStreaming}}
Processors. With the more specific Processors being deprecated, they should be
removed for the next major release version.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11656) Remove Deprecated Azure Queue Storage Processors and Services
[ https://issues.apache.org/jira/browse/NIFI-11656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11656: Status: Patch Available (was: Open) > Remove Deprecated Azure Queue Storage Processors and Services > - > > Key: NIFI-11656 > URL: https://issues.apache.org/jira/browse/NIFI-11656 > Project: Apache NiFi > Issue Type: Task >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > With the addition of GetAzureQueueStorage_v12 and PutAzureQueueStorage_v12, > the deprecated GetAzureQueueStorage and PutAzureQueueStorage Processors > should be removed for the next major release version. > The removal of the deprecated Azure Queue Storage Processors also obviates > the need for the legacy Credentials Controller Services, so > AzureStorageCredentialsControllerService and related implementations should > be removed along with the legacy azure-storage dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #7350: NIFI-11656 Remove Deprecated Azure Queue Storage Processors
exceptionfactory opened a new pull request, #7350: URL: https://github.com/apache/nifi/pull/7350 # Summary [NIFI-11656](https://issues.apache.org/jira/browse/NIFI-11656) Removes deprecated `GetAzureQueueStorage` and `PutAzureQueueStorage` Processors along with `AzureStorageCredentialsControllerService` and related implementations as part of NiFi 2.0 release goals. Additional changes include removing the remaining legacy Microsoft Azure Storage SDK dependency. This required adding a direct dependency on `commons-lang3` for referencing components, and removing references to Google Guava in one integration test. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11656) Remove Deprecated Azure Queue Storage Processors and Services
David Handermann created NIFI-11656: --- Summary: Remove Deprecated Azure Queue Storage Processors and Services Key: NIFI-11656 URL: https://issues.apache.org/jira/browse/NIFI-11656 Project: Apache NiFi Issue Type: Task Reporter: David Handermann Assignee: David Handermann Fix For: 2.0.0 With the addition of GetAzureQueueStorage_v12 and PutAzureQueueStorage_v12, the deprecated GetAzureQueueStorage and PutAzureQueueStorage Processors should be removed for the next major release version. The removal of the deprecated Azure Queue Storage Processors also obviates the need for the legacy Credentials Controller Services, so AzureStorageCredentialsControllerService and related implementations should be removed along with the legacy azure-storage dependency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-11655) GenerateRecord doesn't generate floats and doubles correctly when a schema is supplied
[ https://issues.apache.org/jira/browse/NIFI-11655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-11655: --- Assignee: Matt Burgess > GenerateRecord doesn't generate floats and doubles correctly when a schema is > supplied > -- > > Key: NIFI-11655 > URL: https://issues.apache.org/jira/browse/NIFI-11655 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 1.latest, 2.latest > > > When a schema is supplied to GenerateRecord via the Schema Text property and > it contains either float or double fields, the processor fails with an error: > 2023-06-06 15:10:36,271 ERROR [Timer-Driven Process Thread-7] > o.a.n.processors.standard.GenerateRecord > GenerateRecord[id=9201dbe8-0188-1000-6d56-74ba1fc1e732] Processing failed > org.apache.nifi.processor.exception.ProcessException: Record generation failed > at > org.apache.nifi.processors.standard.GenerateRecord.onTrigger(GenerateRecord.java:274) > at > org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27) > at > org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1360) > at > org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:243) > at > org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59) > at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110) > at > java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at > java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) > at > java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) > at > java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) > at java.base/java.lang.Thread.run(Thread.java:829) > Caused by: java.lang.ClassCastException: class > org.apache.nifi.serialization.record.DataType cannot be cast to class > org.apache.nifi.serialization.record.type.DecimalDataType > (org.apache.nifi.serialization.record.DataType and > org.apache.nifi.serialization.record.type.DecimalDataType are in unnamed > module of loader org.apache.nifi.nar.NarClassLoader @7fd987ef) > at > org.apache.nifi.processors.standard.GenerateRecord.generateValueFromRecordField(GenerateRecord.java:316) > at > org.apache.nifi.processors.standard.GenerateRecord.lambda$onTrigger$0(GenerateRecord.java:238) > at > org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:3138) > at > org.apache.nifi.processors.standard.GenerateRecord.onTrigger(GenerateRecord.java:210) > This is because GenerateRecord handles floats, doubles, and decimals the same > way, by trying to treat them as DecimalDataTypes when floats and doubles are > not compatible (they have their own distinct data types). The cases should be > handled separately and unit tests added/augmented to verify. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11655) GenerateRecord doesn't generate floats and doubles correctly when a schema is supplied
Matt Burgess created NIFI-11655: --- Summary: GenerateRecord doesn't generate floats and doubles correctly when a schema is supplied Key: NIFI-11655 URL: https://issues.apache.org/jira/browse/NIFI-11655 Project: Apache NiFi Issue Type: Bug Components: Extensions Reporter: Matt Burgess Fix For: 1.latest, 2.latest When a schema is supplied to GenerateRecord via the Schema Text property and it contains either float or double fields, the processor fails with an error: 2023-06-06 15:10:36,271 ERROR [Timer-Driven Process Thread-7] o.a.n.processors.standard.GenerateRecord GenerateRecord[id=9201dbe8-0188-1000-6d56-74ba1fc1e732] Processing failed org.apache.nifi.processor.exception.ProcessException: Record generation failed at org.apache.nifi.processors.standard.GenerateRecord.onTrigger(GenerateRecord.java:274) at org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27) at org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1360) at org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:243) at org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59) at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.lang.ClassCastException: class org.apache.nifi.serialization.record.DataType cannot be cast to class org.apache.nifi.serialization.record.type.DecimalDataType (org.apache.nifi.serialization.record.DataType and org.apache.nifi.serialization.record.type.DecimalDataType are in unnamed module of loader org.apache.nifi.nar.NarClassLoader @7fd987ef) at org.apache.nifi.processors.standard.GenerateRecord.generateValueFromRecordField(GenerateRecord.java:316) at org.apache.nifi.processors.standard.GenerateRecord.lambda$onTrigger$0(GenerateRecord.java:238) at org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:3138) at org.apache.nifi.processors.standard.GenerateRecord.onTrigger(GenerateRecord.java:210) This is because GenerateRecord handles floats, doubles, and decimals the same way, by trying to treat them as DecimalDataTypes when floats and doubles are not compatible (they have their own distinct data types). The cases should be handled separately and unit tests added/augmented to verify. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1573: MINIFICPP-2120 Fix debian bookworm, and various bootstrap issues
fgerlits closed pull request #1573: MINIFICPP-2120 Fix debian bookworm, and various bootstrap issues URL: https://github.com/apache/nifi-minifi-cpp/pull/1573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11653) Add Connection URL Validation for DB Connection Pool Services
[
https://issues.apache.org/jira/browse/NIFI-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729810#comment-17729810
]
ASF subversion and git services commented on NIFI-11653:
Commit 6a7a91f0fa827a2fa30b408d8bf7f7952d34559a in nifi's branch
refs/heads/support/nifi-1.x from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6a7a91f0fa ]
NIFI-11653 This closes #7349. Added Connection URL Validation for Database
Services
Signed-off-by: Joe Witt
> Add Connection URL Validation for DB Connection Pool Services
> -
>
> Key: NIFI-11653
> URL: https://issues.apache.org/jira/browse/NIFI-11653
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The {{DBCPConnectionPool}} and {{HikariCPConnectionPool}} Controller Services
> support configurable access to databases using JDBC. Properties such as the
> Connection URL support a wide variety of options and the existing property
> validation allows any string. A custom property validator should be
> implemented to provide better scoping for supported use cases. This includes
> disallowing connections to file-backed database such as H2.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11653) Add Connection URL Validation for DB Connection Pool Services
[
https://issues.apache.org/jira/browse/NIFI-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-11653:
Fix Version/s: 2.0.0
1.22.0
(was: 1.latest)
(was: 2.latest)
> Add Connection URL Validation for DB Connection Pool Services
> -
>
> Key: NIFI-11653
> URL: https://issues.apache.org/jira/browse/NIFI-11653
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 2.0.0, 1.22.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The {{DBCPConnectionPool}} and {{HikariCPConnectionPool}} Controller Services
> support configurable access to databases using JDBC. Properties such as the
> Connection URL support a wide variety of options and the existing property
> validation allows any string. A custom property validator should be
> implemented to provide better scoping for supported use cases. This includes
> disallowing connections to file-backed database such as H2.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11653) Add Connection URL Validation for DB Connection Pool Services
[
https://issues.apache.org/jira/browse/NIFI-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-11653:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Add Connection URL Validation for DB Connection Pool Services
> -
>
> Key: NIFI-11653
> URL: https://issues.apache.org/jira/browse/NIFI-11653
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 2.0.0, 1.22.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The {{DBCPConnectionPool}} and {{HikariCPConnectionPool}} Controller Services
> support configurable access to databases using JDBC. Properties such as the
> Connection URL support a wide variety of options and the existing property
> validation allows any string. A custom property validator should be
> implemented to provide better scoping for supported use cases. This includes
> disallowing connections to file-backed database such as H2.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-11654) Conduct Apache NiFi 1.22.0 release
Joe Witt created NIFI-11654: --- Summary: Conduct Apache NiFi 1.22.0 release Key: NIFI-11654 URL: https://issues.apache.org/jira/browse/NIFI-11654 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt Fix For: 1.22.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11653) Add Connection URL Validation for DB Connection Pool Services
[
https://issues.apache.org/jira/browse/NIFI-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729807#comment-17729807
]
ASF subversion and git services commented on NIFI-11653:
Commit 4faf3ea59895e7e153db3f8f61147ff70a254361 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4faf3ea598 ]
NIFI-11653 This closes #7349. Added Connection URL Validation for Database
Services
Signed-off-by: Joe Witt
> Add Connection URL Validation for DB Connection Pool Services
> -
>
> Key: NIFI-11653
> URL: https://issues.apache.org/jira/browse/NIFI-11653
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{DBCPConnectionPool}} and {{HikariCPConnectionPool}} Controller Services
> support configurable access to databases using JDBC. Properties such as the
> Connection URL support a wide variety of options and the existing property
> validation allows any string. A custom property validator should be
> implemented to provide better scoping for supported use cases. This includes
> disallowing connections to file-backed database such as H2.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #7349: NIFI-11653 Add Connection URL Validation for Database Services
asfgit closed pull request #7349: NIFI-11653 Add Connection URL Validation for Database Services URL: https://github.com/apache/nifi/pull/7349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] r-sidd commented on pull request #7345: NIFI-11648: Bump archetype-packaging version to 3.2.1
r-sidd commented on PR #7345: URL: https://github.com/apache/nifi/pull/7345#issuecomment-1579098126 > @r-sidd These changes do not include updating the `maven-archetype-plugin` itself, which is also necessary in the referencing Maven configuration. Please review the entire file for related references. Sorry about that, let me check on this, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11653) Add Connection URL Validation for DB Connection Pool Services
[
https://issues.apache.org/jira/browse/NIFI-11653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11653:
Status: Patch Available (was: In Progress)
> Add Connection URL Validation for DB Connection Pool Services
> -
>
> Key: NIFI-11653
> URL: https://issues.apache.org/jira/browse/NIFI-11653
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{DBCPConnectionPool}} and {{HikariCPConnectionPool}} Controller Services
> support configurable access to databases using JDBC. Properties such as the
> Connection URL support a wide variety of options and the existing property
> validation allows any string. A custom property validator should be
> implemented to provide better scoping for supported use cases. This includes
> disallowing connections to file-backed database such as H2.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #7349: NIFI-11653 Add Connection URL Validation for Database Services
exceptionfactory opened a new pull request, #7349: URL: https://github.com/apache/nifi/pull/7349 # Summary [NIFI-11653](https://issues.apache.org/jira/browse/NIFI-11653) Adds a Connection URL Validator for Database URL properties in the DBCP and HikariCP Connection Pool Controller Services. The Connection URL Validator introduces the concept of unsupported URL schemes for JDBC connections with an initial value listing H2. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1540: MINIFICPP-2082 Move RocksDB stats to RepositoryMetrics
fgerlits commented on code in PR #1540:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1540#discussion_r1219886077
##
extensions/rocksdb-repos/RocksDbRepository.cpp:
##
@@ -20,22 +20,30 @@ using namespace std::literals::chrono_literals;
namespace org::apache::nifi::minifi::core::repository {
-void RocksDbRepository::printStats() {
+std::optional
RocksDbRepository::getRocksDbStats() const {
Review Comment:
This function is identical to
`DatabaseContentRepository::getRocksDbStats()`. Could we move the common code
somewhere and call it from these two places, to avoid duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (NIFI-11649) Update icu4j to 73.1
[ https://issues.apache.org/jira/browse/NIFI-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11649. - Fix Version/s: 2.0.0 1.22.0 Resolution: Fixed > Update icu4j to 73.1 > > > Key: NIFI-11649 > URL: https://issues.apache.org/jira/browse/NIFI-11649 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.22.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update icu4j to 73.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11649) Update icu4j to 73.1
[ https://issues.apache.org/jira/browse/NIFI-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729796#comment-17729796 ] ASF subversion and git services commented on NIFI-11649: Commit d956ede743342adea50ff31c17ea046c8fdd8bd4 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d956ede743 ] NIFI-11649 Upgraded icu4j from 72.1 to 73.1 This closes #7346 Signed-off-by: David Handermann > Update icu4j to 73.1 > > > Key: NIFI-11649 > URL: https://issues.apache.org/jira/browse/NIFI-11649 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update icu4j to 73.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11649) Update icu4j to 73.1
[ https://issues.apache.org/jira/browse/NIFI-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729797#comment-17729797 ] ASF subversion and git services commented on NIFI-11649: Commit 40889f00372a0965dca35b8f3fb4187c6ae3a023 in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=40889f0037 ] NIFI-11649 Upgraded icu4j from 72.1 to 73.1 This closes #7346 Signed-off-by: David Handermann (cherry picked from commit d956ede743342adea50ff31c17ea046c8fdd8bd4) > Update icu4j to 73.1 > > > Key: NIFI-11649 > URL: https://issues.apache.org/jira/browse/NIFI-11649 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update icu4j to 73.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7346: NIFI-11649 Update icu4j to 73.1
exceptionfactory closed pull request #7346: NIFI-11649 Update icu4j to 73.1 URL: https://github.com/apache/nifi/pull/7346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-11652) Update jolt.version to 0.1.8
[ https://issues.apache.org/jira/browse/NIFI-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11652. - Fix Version/s: 2.0.0 1.22.0 Resolution: Fixed > Update jolt.version to 0.1.8 > > > Key: NIFI-11652 > URL: https://issues.apache.org/jira/browse/NIFI-11652 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.22.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update jolt.version to 0.1.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-11651) Update okhttp.version to 4.11.0
[ https://issues.apache.org/jira/browse/NIFI-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11651. - Fix Version/s: 2.0.0 1.22.0 Resolution: Fixed > Update okhttp.version to 4.11.0 > --- > > Key: NIFI-11651 > URL: https://issues.apache.org/jira/browse/NIFI-11651 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.22.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update okhttp.version to 4.11.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11651) Update okhttp.version to 4.11.0
[ https://issues.apache.org/jira/browse/NIFI-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729791#comment-17729791 ] ASF subversion and git services commented on NIFI-11651: Commit 8f48f3adb03186f346984617bd3ec9b732f38046 in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8f48f3adb0 ] NIFI-11651 Upgraded OkHttp from 4.10.0 to 4.11.0 This closes #7347 Signed-off-by: David Handermann (cherry picked from commit 6c2983daf3d1836e132efa51764e04c38cc75f07) > Update okhttp.version to 4.11.0 > --- > > Key: NIFI-11651 > URL: https://issues.apache.org/jira/browse/NIFI-11651 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update okhttp.version to 4.11.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11652) Update jolt.version to 0.1.8
[ https://issues.apache.org/jira/browse/NIFI-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729790#comment-17729790 ] ASF subversion and git services commented on NIFI-11652: Commit 3b1ec2abe71a860ce1e40bf1cced7a925a977f49 in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3b1ec2abe7 ] NIFI-11652 Upgraded Jolt from 0.1.7 to 0.1.8 This closes #7348 Signed-off-by: David Handermann (cherry picked from commit e6c2c7c7eebbc1c63b4aa609fa04409efd481ac8) > Update jolt.version to 0.1.8 > > > Key: NIFI-11652 > URL: https://issues.apache.org/jira/browse/NIFI-11652 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update jolt.version to 0.1.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11651) Update okhttp.version to 4.11.0
[ https://issues.apache.org/jira/browse/NIFI-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729789#comment-17729789 ] ASF subversion and git services commented on NIFI-11651: Commit 6c2983daf3d1836e132efa51764e04c38cc75f07 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6c2983daf3 ] NIFI-11651 Upgraded OkHttp from 4.10.0 to 4.11.0 This closes #7347 Signed-off-by: David Handermann > Update okhttp.version to 4.11.0 > --- > > Key: NIFI-11651 > URL: https://issues.apache.org/jira/browse/NIFI-11651 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update okhttp.version to 4.11.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7347: NIFI-11651 Update okhttp.version to 4.11.0
exceptionfactory closed pull request #7347: NIFI-11651 Update okhttp.version to 4.11.0 URL: https://github.com/apache/nifi/pull/7347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7348: NIFI-11652 Update jolt.version to 0.1.8
exceptionfactory closed pull request #7348: NIFI-11652 Update jolt.version to 0.1.8 URL: https://github.com/apache/nifi/pull/7348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11652) Update jolt.version to 0.1.8
[ https://issues.apache.org/jira/browse/NIFI-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729788#comment-17729788 ] ASF subversion and git services commented on NIFI-11652: Commit e6c2c7c7eebbc1c63b4aa609fa04409efd481ac8 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e6c2c7c7ee ] NIFI-11652 Upgraded Jolt from 0.1.7 to 0.1.8 This closes #7348 Signed-off-by: David Handermann > Update jolt.version to 0.1.8 > > > Key: NIFI-11652 > URL: https://issues.apache.org/jira/browse/NIFI-11652 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update jolt.version to 0.1.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11653) Add Connection URL Validation for DB Connection Pool Services
David Handermann created NIFI-11653:
---
Summary: Add Connection URL Validation for DB Connection Pool
Services
Key: NIFI-11653
URL: https://issues.apache.org/jira/browse/NIFI-11653
Project: Apache NiFi
Issue Type: Bug
Components: Extensions
Reporter: David Handermann
Assignee: David Handermann
Fix For: 1.latest, 2.latest
The {{DBCPConnectionPool}} and {{HikariCPConnectionPool}} Controller Services
support configurable access to databases using JDBC. Properties such as the
Connection URL support a wide variety of options and the existing property
validation allows any string. A custom property validator should be implemented
to provide better scoping for supported use cases. This includes disallowing
connections to file-backed database such as H2.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11530) Disk full even with nifi.content.repository.archive.max.usage.percentage set to 50%
[
https://issues.apache.org/jira/browse/NIFI-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729762#comment-17729762
]
Giovanni commented on NIFI-11530:
-
Hi Joe,
thanks for your reply.
Here are my settings:
{code:java}
# FlowFile Repository
nifi.flowfile.repository.implementation=org.apache.nifi.controller.repository.WriteAheadFlowFileRepository
nifi.flowfile.repository.wal.implementation=org.apache.nifi.wali.SequentialAccessWriteAheadLog
nifi.flowfile.repository.directory=./flowfile_repository
nifi.flowfile.repository.checkpoint.interval=20 secs
nifi.flowfile.repository.always.sync=false
nifi.flowfile.repository.retain.orphaned.flowfiles=true
nifi.swap.manager.implementation=org.apache.nifi.controller.FileSystemSwapManager
nifi.queue.swap.threshold=2{code}
{code:java}
# Content Repository
nifi.content.repository.implementation=org.apache.nifi.controller.repository.FileSystemRepository
nifi.content.claim.max.appendable.size=50 KB
nifi.content.repository.directory.default=./content_repository
nifi.content.repository.archive.max.retention.period=7 days
nifi.content.repository.archive.max.usage.percentage=50%
nifi.content.repository.archive.enabled=true
nifi.content.repository.always.sync=false
nifi.content.viewer.url=../nifi-content-viewer/{code}
{code:java}
# Provenance Repository Properties
nifi.provenance.repository.implementation=org.apache.nifi.provenance.WriteAheadProvenanceRepository
# Persistent Provenance Repository Properties
nifi.provenance.repository.directory.default=./provenance_repository
nifi.provenance.repository.max.storage.time=30 days
nifi.provenance.repository.max.storage.size=10 GB
nifi.provenance.repository.rollover.time=10 mins
nifi.provenance.repository.rollover.size=100 MB
nifi.provenance.repository.query.threads=2
nifi.provenance.repository.index.threads=2
nifi.provenance.repository.compress.on.rollover=true
nifi.provenance.repository.always.sync=false
# Comma-separated list of fields. Fields that are not indexed will not be
searchable. Valid fields are:
# EventType, FlowFileUUID, Filename, TransitURI, ProcessorID,
AlternateIdentifierURI, Relationship, Details
nifi.provenance.repository.indexed.fields=EventType, FlowFileUUID, Filename,
ProcessorID, Relationship
# FlowFile Attributes that should be indexed and made searchable. Some
examples to consider are filename, uuid, mime.type
nifi.provenance.repository.indexed.attributes=
# Large values for the shard size will result in more Java heap usage when
searching the Provenance Repository
# but should provide better performance
nifi.provenance.repository.index.shard.size=500 MB
# Indicates the maximum length that a FlowFile attribute can be when retrieving
a Provenance Event from
# the repository. If the length of any attribute exceeds this value, it will be
truncated when the event is retrieved.
nifi.provenance.repository.max.attribute.length=65536
nifi.provenance.repository.concurrent.merge.threads=2
# Volatile Provenance Respository Properties
nifi.provenance.repository.buffer.size=10{code}
In response to your point, I confirm each node has only a single disk.
> Disk full even with nifi.content.repository.archive.max.usage.percentage set
> to 50%
> ---
>
> Key: NIFI-11530
> URL: https://issues.apache.org/jira/browse/NIFI-11530
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.20.0
> Environment: Ubuntu 20.04.5 LTS
>Reporter: Giovanni
>Priority: Major
> Attachments: 20230605_disk_usage.jpg, content_archive.jpg,
> flowfile_archive.jpg, jvm.jpg, nifi1-app.log, nifi2-app.log, nifi3-app.log,
> nifi_bug.jpg, provenance_archive.jpg
>
>
> Nifi primary node reports disk full causing all nodes to stop working.
> Restarting nifi service does not resolve.
> Restarting the VM does not resolve.
> The only way to fix is to clean te content_repository dir:
> rm -rf ./nifi/content_repository/*
>
> Unfortunately I have no logs of the issue ongoing.
>
> UPDATE:
> I'm having the problem again.
> Every archive size is more than 50% on each node, with 70%+ peak on
> coordinator node (see attachments).
> I'm also attaching nifi-app.log this time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request, #1584: MINIFICPP-1755 - Use std::span instead of gsl::span
adamdebreceni opened a new pull request, #1584: URL: https://github.com/apache/nifi-minifi-cpp/pull/1584 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11586) Add AzureStorageCredentialsControllerServiceLookup_v12
[
https://issues.apache.org/jira/browse/NIFI-11586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Soma Abonyi updated NIFI-11586:
--
Component/s: Extensions
> Add AzureStorageCredentialsControllerServiceLookup_v12
> --
>
> Key: NIFI-11586
> URL: https://issues.apache.org/jira/browse/NIFI-11586
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0, 1.22.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Similar to {{AzureStorageCredentialsControllerServiceLookup}}, add a lookup
> service for the v12 blob processors.
> {{AzureStorageCredentialsControllerServiceLookup_v12}} will provide accessing
> {{AzureStorageCredentialsService_v12}} services dynamically based on a
> FlowFile attribute.
> The v12 blob processors contain a single client reference. In order to
> support multiple credentials (that is multiple clients), the same client
> factory / cache approach need to be implemented as in case of the ADLS
> processors (DataLakeServiceClientFactory).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11586) Add AzureStorageCredentialsControllerServiceLookup_v12
[
https://issues.apache.org/jira/browse/NIFI-11586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Soma Abonyi updated NIFI-11586:
--
Labels: azure (was: )
> Add AzureStorageCredentialsControllerServiceLookup_v12
> --
>
> Key: NIFI-11586
> URL: https://issues.apache.org/jira/browse/NIFI-11586
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Labels: azure
> Fix For: 2.0.0, 1.22.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Similar to {{AzureStorageCredentialsControllerServiceLookup}}, add a lookup
> service for the v12 blob processors.
> {{AzureStorageCredentialsControllerServiceLookup_v12}} will provide accessing
> {{AzureStorageCredentialsService_v12}} services dynamically based on a
> FlowFile attribute.
> The v12 blob processors contain a single client reference. In order to
> support multiple credentials (that is multiple clients), the same client
> factory / cache approach need to be implemented as in case of the ADLS
> processors (DataLakeServiceClientFactory).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11586) Add AzureStorageCredentialsControllerServiceLookup_v12
[
https://issues.apache.org/jira/browse/NIFI-11586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Soma Abonyi updated NIFI-11586:
--
Fix Version/s: 2.0.0
1.22.0
> Add AzureStorageCredentialsControllerServiceLookup_v12
> --
>
> Key: NIFI-11586
> URL: https://issues.apache.org/jira/browse/NIFI-11586
> Project: Apache NiFi
> Issue Type: New Feature
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0, 1.22.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Similar to {{AzureStorageCredentialsControllerServiceLookup}}, add a lookup
> service for the v12 blob processors.
> {{AzureStorageCredentialsControllerServiceLookup_v12}} will provide accessing
> {{AzureStorageCredentialsService_v12}} services dynamically based on a
> FlowFile attribute.
> The v12 blob processors contain a single client reference. In order to
> support multiple credentials (that is multiple clients), the same client
> factory / cache approach need to be implemented as in case of the ADLS
> processors (DataLakeServiceClientFactory).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11586) Add AzureStorageCredentialsControllerServiceLookup_v12
[
https://issues.apache.org/jira/browse/NIFI-11586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Soma Abonyi updated NIFI-11586:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Add AzureStorageCredentialsControllerServiceLookup_v12
> --
>
> Key: NIFI-11586
> URL: https://issues.apache.org/jira/browse/NIFI-11586
> Project: Apache NiFi
> Issue Type: New Feature
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0, 1.22.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Similar to {{AzureStorageCredentialsControllerServiceLookup}}, add a lookup
> service for the v12 blob processors.
> {{AzureStorageCredentialsControllerServiceLookup_v12}} will provide accessing
> {{AzureStorageCredentialsService_v12}} services dynamically based on a
> FlowFile attribute.
> The v12 blob processors contain a single client reference. In order to
> support multiple credentials (that is multiple clients), the same client
> factory / cache approach need to be implemented as in case of the ADLS
> processors (DataLakeServiceClientFactory).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11652) Update jolt.version to 0.1.8
[ https://issues.apache.org/jira/browse/NIFI-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-11652: -- Priority: Minor (was: Major) > Update jolt.version to 0.1.8 > > > Key: NIFI-11652 > URL: https://issues.apache.org/jira/browse/NIFI-11652 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Update jolt.version to 0.1.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mr1716 opened a new pull request, #7348: NIFI-11652 Update jolt.version to 0.1.8
mr1716 opened a new pull request, #7348: URL: https://github.com/apache/nifi/pull/7348 # Summary [NIFI-11652](https://issues.apache.org/jira/browse/NIFI-11652) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-11652) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-11652) Update jolt.version to 0.1.8
[ https://issues.apache.org/jira/browse/NIFI-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-11652: - Assignee: Mike R > Update jolt.version to 0.1.8 > > > Key: NIFI-11652 > URL: https://issues.apache.org/jira/browse/NIFI-11652 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update jolt.version to 0.1.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11652) Update jolt.version to 0.1.8
Mike R created NIFI-11652: - Summary: Update jolt.version to 0.1.8 Key: NIFI-11652 URL: https://issues.apache.org/jira/browse/NIFI-11652 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.21.0 Reporter: Mike R Update jolt.version to 0.1.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11651) Update okhttp.version to 4.11.0
[ https://issues.apache.org/jira/browse/NIFI-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-11651: -- Priority: Minor (was: Major) > Update okhttp.version to 4.11.0 > --- > > Key: NIFI-11651 > URL: https://issues.apache.org/jira/browse/NIFI-11651 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Update okhttp.version to 4.11.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11649) Update icu4j to 73.1
[ https://issues.apache.org/jira/browse/NIFI-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R updated NIFI-11649: -- Priority: Minor (was: Major) > Update icu4j to 73.1 > > > Key: NIFI-11649 > URL: https://issues.apache.org/jira/browse/NIFI-11649 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Update icu4j to 73.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mr1716 opened a new pull request, #7347: NIFI-11651 Update okhttp.version to 4.11.0
mr1716 opened a new pull request, #7347: URL: https://github.com/apache/nifi/pull/7347 # Summary [NIFI-11651](https://issues.apache.org/jira/browse/NIFI-11651) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-11651) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-11651) Update okhttp.version to 4.11.0
[ https://issues.apache.org/jira/browse/NIFI-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-11651: - Assignee: Mike R > Update okhttp.version to 4.11.0 > --- > > Key: NIFI-11651 > URL: https://issues.apache.org/jira/browse/NIFI-11651 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update okhttp.version to 4.11.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11651) Update okhttp.version to 4.11.0
Mike R created NIFI-11651: - Summary: Update okhttp.version to 4.11.0 Key: NIFI-11651 URL: https://issues.apache.org/jira/browse/NIFI-11651 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.21.0 Reporter: Mike R Update okhttp.version to 4.11.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11650) Stateless NiFi does not support ssl properties passed in.
Stephanie Ambrose created NIFI-11650:
Summary: Stateless NiFi does not support ssl properties passed in.
Key: NIFI-11650
URL: https://issues.apache.org/jira/browse/NIFI-11650
Project: Apache NiFi
Issue Type: Bug
Affects Versions: 1.20.0
Reporter: Stephanie Ambrose
When deploying stateless NiFi in an environment like k8s, we have the
stateless.properties file as a configMap. We need to pass in the keystore
password, retrieved by the k8s secret (or environment variable). According to
the stateless documentation, this should be supported; however, it looks like
the ssl properties specifically don't allow for override. For example, I'm
trying to pass this in when running stateless from my deployment.yaml:
command:
["/bin/sh", "-c", "/opt/nifi/nifi-current/bin/nifi-stateless.sh -c -p
\"nifi.stateless.security.keystorePasswd=${KEYSTORE_PASSWORD}\""]
The expected behavior would be that the nifi.stateless.security.keystorePasswd
property in stateless.properties would be updated.
Documentation referenced here
([https://github.com/apache/nifi/blob/main/nifi-stateless/nifi-stateless-assembly/README.md#passing-parameters)]
Chatted briefly w/ Joe Gresock to verify and requested a ticket be submitted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] mr1716 opened a new pull request, #7346: NIFI-11649 Update icu4j to 73.1
mr1716 opened a new pull request, #7346: URL: https://github.com/apache/nifi/pull/7346 # Summary [NIFI-11649](https://issues.apache.org/jira/browse/NIFI-11649) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-11649) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-11649) Update icu4j to 73.1
[ https://issues.apache.org/jira/browse/NIFI-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-11649: - Assignee: Mike R > Update icu4j to 73.1 > > > Key: NIFI-11649 > URL: https://issues.apache.org/jira/browse/NIFI-11649 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.21.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update icu4j to 73.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11649) Update icu4j to 73.1
Mike R created NIFI-11649: - Summary: Update icu4j to 73.1 Key: NIFI-11649 URL: https://issues.apache.org/jira/browse/NIFI-11649 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.21.0 Reporter: Mike R Update icu4j to 73.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] r-sidd opened a new pull request, #7345: NIFI-11648: Bump archetype-packaging version to 3.2.1
r-sidd opened a new pull request, #7345: URL: https://github.com/apache/nifi/pull/7345 # Summary [NIFI-11648](https://issues.apache.org/jira/browse/NIFI-11648) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11648) Bump archetype-packaging version to 3.2.1
[ https://issues.apache.org/jira/browse/NIFI-11648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth R updated NIFI-11648: --- Description: Bump archetype-packaging version from 2.2 to 3.2.1 to remediate: [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250] was:Bump archetype-packaging version from 2.2 to 3.2.1 > Bump archetype-packaging version to 3.2.1 > - > > Key: NIFI-11648 > URL: https://issues.apache.org/jira/browse/NIFI-11648 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Siddharth R >Assignee: Siddharth R >Priority: Minor > Labels: dependency-upgrade > > Bump archetype-packaging version from 2.2 to 3.2.1 to remediate: > [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11648) Bump archetype-packaging version to 3.2.1
Siddharth R created NIFI-11648: -- Summary: Bump archetype-packaging version to 3.2.1 Key: NIFI-11648 URL: https://issues.apache.org/jira/browse/NIFI-11648 Project: Apache NiFi Issue Type: Improvement Reporter: Siddharth R Assignee: Siddharth R Bump archetype-packaging version from 2.2 to 3.2.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] r-sidd commented on pull request #7319: NIFI-11587: Update questdb to 6.7
r-sidd commented on PR #7319: URL: https://github.com/apache/nifi/pull/7319#issuecomment-1578505820 > Thanks for mentioning! I did take a look and it looks good to me. I am not sure about why there is a breaking change there but based on the QuestDb repository it looks like intentional (However I find no mention in the release notes). I will wait up to tomorrow for seeing rollback with non-empty datasets and if everyhings look right, I will merge the PR. Okay cool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] simonbence commented on pull request #7319: NIFI-11587: Update questdb to 6.7
simonbence commented on PR #7319: URL: https://github.com/apache/nifi/pull/7319#issuecomment-1578491877 Thanks for mentioning! I did take a look and it looks good to me. I am not sure about why there is a breaking change there but based on the QuestDb repository it looks like intentional (However I find no mention in the release notes). I will wait up to tomorrow for seeing rollback with non-empty datasets and if everyhings look right, I will merge the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] briansolo1985 opened a new pull request, #7344: NIFI-11514 Flow JSON support and deprecating YAML format. Migration tool from YAML to JSON
briansolo1985 opened a new pull request, #7344: URL: https://github.com/apache/nifi/pull/7344 # Summary [NIFI-11514](https://issues.apache.org/jira/browse/NIFI-11514) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-8531) Upgrade Kinesis Client Library to 2.x
[
https://issues.apache.org/jira/browse/NIFI-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Gresock reassigned NIFI-8531:
-
Assignee: Joe Gresock
> Upgrade Kinesis Client Library to 2.x
> -
>
> Key: NIFI-8531
> URL: https://issues.apache.org/jira/browse/NIFI-8531
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Chris Sampson
>Assignee: Joe Gresock
>Priority: Major
>
> The Kinesis Client Library [KCL] version 1.x is used by the
> {{ConsumeKinesisStream}} processor (NIFI-2892).
> It would be better to upgrade to KCL 2.x as it is more up-to-date and
> provides more advanced features.
> For example, the {{WorkerStateChangeListener}} in 2.x has an
> {{onAllInitializationAttemptsFailed}} method that could be used to better
> track {{Worker}} startup issues (instead of relying on checking for
> unexpected {{WorkerState}} values in our processor's {{onTrigger}} method).
> There are also more configuration options available that would be worth
> considering as processor properties/noting in the processor documentation.
> N.B. upgrading to KCL 2.x relies upon upgrading to AWS Java SDK 2.x first
> (NIFI-8287).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] timeabarna commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging
timeabarna commented on code in PR #7315:
URL: https://github.com/apache/nifi/pull/7315#discussion_r1219197176
##
nifi-api/src/main/java/org/apache/nifi/flow/VersionedProcessGroup.java:
##
@@ -47,6 +47,9 @@ public class VersionedProcessGroup extends VersionedComponent
{
private Long defaultBackPressureObjectThreshold;
private String defaultBackPressureDataSizeThreshold;
+private Boolean logToOwnFile;
Review Comment:
Thanks @markap14 for your review.
For better User experience I've separated the enabling and configuration.
There is a combolist with 'Yes' and 'No' options to turn dedicated logging and
there is an input field with Process Group name as a default value for the log
file name. I think this way the UI is more intuitive and more convenient than
typing/deleting log file suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1583: MINIFICPP-1719 Replace LibreSSL with OpenSSL 3.1
adamdebreceni commented on code in PR #1583:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1583#discussion_r1219180190
##
libminifi/src/controllers/SSLContextService.cpp:
##
@@ -112,6 +112,22 @@ const core::Property SSLContextService::ClientCertKeyUsage(
->build());
#endif // WIN32
+namespace {
+bool is_valid_and_readable_path(const std::filesystem::path&
path_to_be_tested) {
+ std::ifstream file_to_be_tested(path_to_be_tested);
+ return file_to_be_tested.good();
+}
+
+#ifdef WIN32
+std::string getCertName(const utils::tls::X509_unique_ptr& cert) {
+ const size_t BUFFER_SIZE = 256;
+ char name_buffer[BUFFER_SIZE];
+ X509_NAME_oneline(X509_get_subject_name(cert.get()), name_buffer,
BUFFER_SIZE);
Review Comment:
according to
[this](https://www.openssl.org/docs/man3.1/man3/X509_NAME_oneline.html) the
usage of `X509_NAME_oneline` is "strongly discouraged in new applications"
although not yet deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1572: MINIFICPP-2027 Upgrade Google Cloud library to version 2.10.1
lordgamez commented on code in PR #1572:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1572#discussion_r1219100389
##
cmake/GoogleCloudCpp.cmake:
##
@@ -22,17 +22,36 @@ include(Crc32c)
set(PATCH_FILE_1
"${CMAKE_SOURCE_DIR}/thirdparty/google-cloud-cpp/remove-find_package.patch")
set(PATCH_FILE_2
"${CMAKE_SOURCE_DIR}/thirdparty/google-cloud-cpp/nlohmann_lib_as_interface.patch")
-set(PC ${Bash_EXECUTABLE} -c "set -x &&\
-(\\\"${Patch_EXECUTABLE}\\\" -p1 -R -s -f --dry-run -i
\\\"${PATCH_FILE_1}\\\" || \\\"${Patch_EXECUTABLE}\\\" -p1 -N -i
\\\"${PATCH_FILE_1}\\\") &&\
-(\\\"${Patch_EXECUTABLE}\\\" -p1 -R -s -f --dry-run -i
\\\"${PATCH_FILE_2}\\\" || \\\"${Patch_EXECUTABLE}\\\" -p1 -N -i
\\\"${PATCH_FILE_2}\\\")")
+set(PATCH_FILE_3
"${CMAKE_SOURCE_DIR}/thirdparty/google-cloud-cpp/mock-client-without-decorators.patch")
+set(PATCH_FILE_4
"${CMAKE_SOURCE_DIR}/thirdparty/google-cloud-cpp/mock_client_target.patch")
+if (SKIP_TESTS)
+set(PC ${Bash_EXECUTABLE} -c "set -x &&\
+(\\\"${Patch_EXECUTABLE}\\\" -p1 -R -s -f --dry-run -i
\\\"${PATCH_FILE_1}\\\" || \\\"${Patch_EXECUTABLE}\\\" -p1 -N -i
\\\"${PATCH_FILE_1}\\\") &&\
+(\\\"${Patch_EXECUTABLE}\\\" -p1 -R -s -f --dry-run -i
\\\"${PATCH_FILE_2}\\\" || \\\"${Patch_EXECUTABLE}\\\" -p1 -N -i
\\\"${PATCH_FILE_2}\\\")")
Review Comment:
Sorry I meant to say single escapes, not single quotes. I used the same code
you suggested and that resulted in the error I mentioned above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] dam4rus commented on pull request #7338: NIFI-11631 Add OracleDB support for Nifi Registry
dam4rus commented on PR #7338: URL: https://github.com/apache/nifi/pull/7338#issuecomment-1578038320 Thanks @mattyb149 for bringing your change to my attention. Will definitely check it out. I was not aware that this was already WIP. I was also not aware of existing ITs related to DB in Nifi Registry. I'll try to spin up some tests for OracleDB -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
