[jira] [Commented] (NIFI-11841) Nifi in cluster setup doesn't stop within the graceful shutdown period
[
https://issues.apache.org/jira/browse/NIFI-11841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745405#comment-17745405
]
Dheeraj Joshi commented on NIFI-11841:
--
When bootstrap prints {{Shutdown in progress}} unable to take any thread dumps
{code:java}
Exception in thread "main" java.net.ConnectException: Connection refused
at java.base/sun.nio.ch.Net.connect0(Native Method)
at java.base/sun.nio.ch.Net.connect(Net.java:579)
at java.base/sun.nio.ch.Net.connect(Net.java:568)
at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:588)
at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:327)
at java.base/java.net.Socket.connect(Socket.java:633)
at java.base/java.net.Socket.connect(Socket.java:583)
at org.apache.nifi.bootstrap.RunNiFi.sendRequest(RunNiFi.java:853)
at org.apache.nifi.bootstrap.RunNiFi.makeRequest(RunNiFi.java:827)
at org.apache.nifi.bootstrap.RunNiFi.dump(RunNiFi.java:782)
at org.apache.nifi.bootstrap.RunNiFi.main(RunNiFi.java:320)
{code}
> Nifi in cluster setup doesn't stop within the graceful shutdown period
> --
>
> Key: NIFI-11841
> URL: https://issues.apache.org/jira/browse/NIFI-11841
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.22.0
>Reporter: Dheeraj Joshi
>Priority: Major
> Attachments: bootstrap.conf, nifi-app.log, nifi-bootstrap.log,
> nifi.properties, zookeeper.properties
>
>
> Bootstrap logs show the following logs when one of the nodes in a 3-node
> cluster is stopped
> {code:java}
> 2023-07-20 11:10:49,847 INFO [main] org.apache.nifi.bootstrap.Command
> Launched Apache NiFi with Process ID 18579
> 2023-07-20 11:10:50,475 INFO [NiFi Bootstrap Command Listener]
> org.apache.nifi.bootstrap.RunNiFi Apache NiFi now running and listening for
> Bootstrap requests on port 64739
> 2023-07-20 11:12:15,723 INFO [main] o.a.n.b.NotificationServiceManager
> Successfully loaded the following 0 services: []
> 2023-07-20 11:12:15,725 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> Registered no Notification Services for Notification Type NIFI_STARTED
> 2023-07-20 11:12:15,725 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> Registered no Notification Services for Notification Type NIFI_STOPPED
> 2023-07-20 11:12:15,725 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> Registered no Notification Services for Notification Type NIFI_DIED
> 2023-07-20 11:12:15,750 INFO [main] org.apache.nifi.bootstrap.Command Apache
> NiFi has accepted the Shutdown Command and is shutting down now
> 2023-07-20 11:12:15,859 INFO [main] org.apache.nifi.bootstrap.Command NiFi
> PID [18579] shutdown in progress...
> 2023-07-20 11:12:17,896 INFO [main] org.apache.nifi.bootstrap.Command NiFi
> PID [18579] shutdown in progress...
> 2023-07-20 11:12:19,919 INFO [main] org.apache.nifi.bootstrap.Command NiFi
> PID [18579] shutdown in progress...{code}
> The shutdown in progress message gets repeated till
> {code:java}
> graceful.shutdown.seconds{code}
> is elapsed.
> Nifi app logs print socket exception during the shutdown but eventually shuts
> down the application server server
> {code:java}
> 2023-07-20 11:12:15,750 INFO [pool-2-thread-2]
> org.apache.nifi.BootstrapListener Received SHUTDOWN request from Bootstrap
> 2023-07-20 11:12:15,750 INFO [pool-2-thread-2] org.apache.nifi.NiFi
> Application Server shutdown started
> 2023-07-20 11:12:15,755 INFO [pool-2-thread-2]
> o.eclipse.jetty.server.AbstractConnector Stopped
> ServerConnector@2407a36c{HTTP/1.1, (http/1.1)}
> {127.0.0.1:8080}
> 2023-07-20 11:12:15,756 INFO [pool-2-thread-2]
> org.eclipse.jetty.server.session node0 Stopped scavenging
> 2023-07-20 11:12:15,769 INFO [pool-2-thread-2]
> o.e.jetty.server.handler.ContextHandler Stopped
> o.e.j.w.WebAppContext@7cfb8e98{nifi-error,/,null,STOPPED}
> {./work/nar/extensions/nifi-server-nar-1.22.0.nar-unpacked/NAR-INF/bundled-dependencies/nifi-web-error-1.22.0.war}
> 2023-07-20 11:12:15,782 INFO [pool-2-thread-2]
> o.e.jetty.server.handler.ContextHandler Stopped
> o.e.j.w.WebAppContext@2aa5bd48{nifi-docs,/nifi-docs,null,STOPPED}
> {./work/nar/extensions/nifi-server-nar-1.22.0.nar-unpacked/NAR-INF/bundled-dependencies/nifi-web-docs-1.22.0.war}
> 2023-07-20 11:12:15,798 INFO [pool-2-thread-2]
> o.e.jetty.server.handler.ContextHandler Stopped
> o.e.j.w.WebAppContext@133aacbe{nifi-content-viewer,/nifi-content-viewer,null,STOPPED}
> {./work/nar/extensions/nifi-server-nar-1.22.0.nar-unpacked/NAR-INF/bundled-dependencies/nifi-web-content-viewer-1.22.0.war}
> 2023-07-20 11:12:15,803 INFO [pool-2-thread-2]
> o.a.n.w.c.ApplicationStartupContextListener Flow Service shutdown started
> 2023-07-20 11:12:15,803 INFO [pool-2-thread-2]
> o.a.n.c.c.node.NodeClusterCoordinator Status of
[jira] [Created] (NIFI-11841) Nifi in cluster setup doesn't stop within the graceful shutdown period
Dheeraj Joshi created NIFI-11841:
Summary: Nifi in cluster setup doesn't stop within the graceful
shutdown period
Key: NIFI-11841
URL: https://issues.apache.org/jira/browse/NIFI-11841
Project: Apache NiFi
Issue Type: Bug
Components: Core Framework
Affects Versions: 1.22.0
Reporter: Dheeraj Joshi
Attachments: bootstrap.conf, nifi-app.log, nifi-bootstrap.log,
nifi.properties, zookeeper.properties
Bootstrap logs show the following logs when one of the nodes in a 3-node
cluster is stopped
{code:java}
2023-07-20 11:10:49,847 INFO [main] org.apache.nifi.bootstrap.Command Launched
Apache NiFi with Process ID 18579
2023-07-20 11:10:50,475 INFO [NiFi Bootstrap Command Listener]
org.apache.nifi.bootstrap.RunNiFi Apache NiFi now running and listening for
Bootstrap requests on port 64739
2023-07-20 11:12:15,723 INFO [main] o.a.n.b.NotificationServiceManager
Successfully loaded the following 0 services: []
2023-07-20 11:12:15,725 INFO [main] org.apache.nifi.bootstrap.RunNiFi
Registered no Notification Services for Notification Type NIFI_STARTED
2023-07-20 11:12:15,725 INFO [main] org.apache.nifi.bootstrap.RunNiFi
Registered no Notification Services for Notification Type NIFI_STOPPED
2023-07-20 11:12:15,725 INFO [main] org.apache.nifi.bootstrap.RunNiFi
Registered no Notification Services for Notification Type NIFI_DIED
2023-07-20 11:12:15,750 INFO [main] org.apache.nifi.bootstrap.Command Apache
NiFi has accepted the Shutdown Command and is shutting down now
2023-07-20 11:12:15,859 INFO [main] org.apache.nifi.bootstrap.Command NiFi PID
[18579] shutdown in progress...
2023-07-20 11:12:17,896 INFO [main] org.apache.nifi.bootstrap.Command NiFi PID
[18579] shutdown in progress...
2023-07-20 11:12:19,919 INFO [main] org.apache.nifi.bootstrap.Command NiFi PID
[18579] shutdown in progress...{code}
The shutdown in progress message gets repeated till
{code:java}
graceful.shutdown.seconds{code}
is elapsed.
Nifi app logs print socket exception during the shutdown but eventually shuts
down the application server server
{code:java}
2023-07-20 11:12:15,750 INFO [pool-2-thread-2]
org.apache.nifi.BootstrapListener Received SHUTDOWN request from Bootstrap
2023-07-20 11:12:15,750 INFO [pool-2-thread-2] org.apache.nifi.NiFi Application
Server shutdown started
2023-07-20 11:12:15,755 INFO [pool-2-thread-2]
o.eclipse.jetty.server.AbstractConnector Stopped
ServerConnector@2407a36c{HTTP/1.1, (http/1.1)}
{127.0.0.1:8080}
2023-07-20 11:12:15,756 INFO [pool-2-thread-2] org.eclipse.jetty.server.session
node0 Stopped scavenging
2023-07-20 11:12:15,769 INFO [pool-2-thread-2]
o.e.jetty.server.handler.ContextHandler Stopped
o.e.j.w.WebAppContext@7cfb8e98{nifi-error,/,null,STOPPED}
{./work/nar/extensions/nifi-server-nar-1.22.0.nar-unpacked/NAR-INF/bundled-dependencies/nifi-web-error-1.22.0.war}
2023-07-20 11:12:15,782 INFO [pool-2-thread-2]
o.e.jetty.server.handler.ContextHandler Stopped
o.e.j.w.WebAppContext@2aa5bd48{nifi-docs,/nifi-docs,null,STOPPED}
{./work/nar/extensions/nifi-server-nar-1.22.0.nar-unpacked/NAR-INF/bundled-dependencies/nifi-web-docs-1.22.0.war}
2023-07-20 11:12:15,798 INFO [pool-2-thread-2]
o.e.jetty.server.handler.ContextHandler Stopped
o.e.j.w.WebAppContext@133aacbe{nifi-content-viewer,/nifi-content-viewer,null,STOPPED}
{./work/nar/extensions/nifi-server-nar-1.22.0.nar-unpacked/NAR-INF/bundled-dependencies/nifi-web-content-viewer-1.22.0.war}
2023-07-20 11:12:15,803 INFO [pool-2-thread-2]
o.a.n.w.c.ApplicationStartupContextListener Flow Service shutdown started
2023-07-20 11:12:15,803 INFO [pool-2-thread-2]
o.a.n.c.c.node.NodeClusterCoordinator Status of 127.0.0.1:8080 changed from
NodeConnectionStatus[nodeId=127.0.0.1:8080, state=CONNECTED, updateId=50] to
NodeConnectionStatus[nodeId=127.0.0.1:8080, state=DISCONNECTED, Disconnect
Code=Node was Shutdown, Disconnect Reason=Node was Shutdown, updateId=50]
2023-07-20 11:12:15,809 INFO [pool-2-thread-2]
o.a.n.c.c.node.NodeClusterCoordinator Successfully notified other nodes that I
am shutting down
2023-07-20 11:12:15,811 INFO [Curator-Framework-0]
o.a.c.f.imps.CuratorFrameworkImpl backgroundOperationsLoop exiting
2023-07-20 11:12:15,813 INFO [RequestThrottler]
o.a.zookeeper.server.ZooKeeperServer Submitting global closeSession request for
session 0x10001c33808
2023-07-20 11:12:15,815 INFO [Process Cluster Protocol Request-3]
o.a.n.c.c.node.NodeClusterCoordinator Status of 127.0.0.1:8080 changed from
NodeConnectionStatus[nodeId=127.0.0.1:8080, state=DISCONNECTED, Disconnect
Code=Node was Shutdown, Disconnect Reason=Node was Shutdown, updateId=50] to
NodeConnectionStatus[nodeId=127.0.0.1:8080, state=DISCONNECTED, Disconnect
Code=Node was Shutdown, Disconnect Reason=Node was Shutdown, updateId=50]
2023-07-20 11:12:15,816 INFO [Process Cluster Protocol Request-3]
[jira] [Updated] (NIFI-10784) Add Processor for Querying Apache IoTDB
[ https://issues.apache.org/jira/browse/NIFI-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10784: Summary: Add Processor for Querying Apache IoTDB(was: implement a processor of Apache IoTDB Query ) > Add Processor for Querying Apache IoTDB > - > > Key: NIFI-10784 > URL: https://issues.apache.org/jira/browse/NIFI-10784 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Zhizhou.Li >Assignee: Zhizhou.Li >Priority: Major > Fix For: 2.0.0, 1.23.0 > > Original Estimate: 168h > Time Spent: 1h 40m > Remaining Estimate: 166h 20m > > The PutIoTDBRecord process is in NIFI-10234. > This issue is the QueryIoTDBRecord process. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11832) Conduct Apache NiFi 1.23 release
[ https://issues.apache.org/jira/browse/NIFI-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745318#comment-17745318 ] ASF subversion and git services commented on NIFI-11832: Commit 36638b9581ca1aa2c2b98be5ed0963a220580df3 in nifi's branch refs/heads/NIFI-11832-RC2 from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=36638b9581 ] NIFI-11832-RC2 prepare for next development iteration > Conduct Apache NiFi 1.23 release > > > Key: NIFI-11832 > URL: https://issues.apache.org/jira/browse/NIFI-11832 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: David Handermann >Priority: Trivial > Fix For: 1.23.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11832) Conduct Apache NiFi 1.23 release
[ https://issues.apache.org/jira/browse/NIFI-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745317#comment-17745317 ] ASF subversion and git services commented on NIFI-11832: Commit 2c707ad4e35fa7086024b966f279c8d4da486144 in nifi's branch refs/heads/NIFI-11832-RC2 from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2c707ad4e3 ] NIFI-11832-RC2 prepare release nifi-1.23.0-RC2 > Conduct Apache NiFi 1.23 release > > > Key: NIFI-11832 > URL: https://issues.apache.org/jira/browse/NIFI-11832 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: David Handermann >Priority: Trivial > Fix For: 1.23.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11830) Allow JSLTTransformJSON to apply the transform to each object rather than the whole file
[ https://issues.apache.org/jira/browse/NIFI-11830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-11830: Status: Patch Available (was: In Progress) > Allow JSLTTransformJSON to apply the transform to each object rather than the > whole file > > > Key: NIFI-11830 > URL: https://issues.apache.org/jira/browse/NIFI-11830 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > Fix For: 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > JSLTTransformJSON currently reads the entire FlowFile in and applies the > transform to it. For efficiency and memory considerations it would be nice to > add a property to specify whether to apply the transform to the entire file > or for each JSON object in the top-level array one at a time. Since the > latter is more memory-efficient, that should be the default for the next > major version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mattyb149 opened a new pull request, #7509: NIFI-11830: Add ability to apply JSLT transform to each record
mattyb149 opened a new pull request, #7509: URL: https://github.com/apache/nifi/pull/7509 # Summary [NIFI-11830](https://issues.apache.org/jira/browse/NIFI-11830) This PR adds a "Transformation Strategy" property to JSLTTransformJSON to allow the user to choose whether to apply the JSLT transform to the entire JSON input or to each JSON object in a top-level array. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-11830` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-11830` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [x] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] wannadream commented on a diff in pull request #6619: NIFI-10760 Add Api key authentication option to ElasticSearchClientServiceImpl
wannadream commented on code in PR #6619:
URL: https://github.com/apache/nifi/pull/6619#discussion_r1270058336
##
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceImpl.java:
##
@@ -275,6 +318,12 @@ private CredentialsProvider addCredentials(final
CredentialsProvider credentials
return cp;
}
+private BasicHeader createApiKeyAuthorizationHeader(String apiKeyId,
String apiKey) {
+final String apiKeyCredentials = String.format("%s:%s", apiKeyId,
apiKey);
+final String apiKeyAuth =
Base64.getEncoder().encodeToString((apiKeyCredentials).getBytes(StandardCharsets.UTF_8));
Review Comment:
Thanks, Chris. Feeling enlightened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-11838) Upgrade Netty to 4.1.95
[ https://issues.apache.org/jira/browse/NIFI-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-11838: Fix Version/s: 2.0.0 1.23.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Netty to 4.1.95 > --- > > Key: NIFI-11838 > URL: https://issues.apache.org/jira/browse/NIFI-11838 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 2.0.0, 1.23.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Netty [4.1.95|https://netty.io/news/2023/07/20/4-1-95-Final.html] includes > several minor bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11838) Upgrade Netty to 4.1.95
[ https://issues.apache.org/jira/browse/NIFI-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745261#comment-17745261 ] ASF subversion and git services commented on NIFI-11838: Commit 902f4145fda965d85f1203e7c0b5c9c84e99a5a8 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=902f4145fd ] NIFI-11838 Upgraded Netty from 4.1.94 to 4.1.95 Signed-off-by: Matt Burgess This closes #7507 > Upgrade Netty to 4.1.95 > --- > > Key: NIFI-11838 > URL: https://issues.apache.org/jira/browse/NIFI-11838 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 0.5h > Remaining Estimate: 0h > > Netty [4.1.95|https://netty.io/news/2023/07/20/4-1-95-Final.html] includes > several minor bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11838) Upgrade Netty to 4.1.95
[ https://issues.apache.org/jira/browse/NIFI-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745260#comment-17745260 ] ASF subversion and git services commented on NIFI-11838: Commit 61019e7326442e8c6b92a6abedc21e5be1b2fe58 in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=61019e7326 ] NIFI-11838 Upgraded Netty from 4.1.94 to 4.1.95 Signed-off-by: Matt Burgess > Upgrade Netty to 4.1.95 > --- > > Key: NIFI-11838 > URL: https://issues.apache.org/jira/browse/NIFI-11838 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Netty [4.1.95|https://netty.io/news/2023/07/20/4-1-95-Final.html] includes > several minor bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11839) Upgrade Spring Boot to 2.7.14
[ https://issues.apache.org/jira/browse/NIFI-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-11839: Fix Version/s: 2.0.0 1.23.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Spring Boot to 2.7.14 > - > > Key: NIFI-11839 > URL: https://issues.apache.org/jira/browse/NIFI-11839 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 2.0.0, 1.23.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Spring Boot > [2.7.14|https://github.com/spring-projects/spring-boot/releases/tag/v2.7.14] > incorporates dependency upgrades for Spring Framework 5.3.29 and several > other incremental transitive dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11839) Upgrade Spring Boot to 2.7.14
[ https://issues.apache.org/jira/browse/NIFI-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745256#comment-17745256 ] ASF subversion and git services commented on NIFI-11839: Commit c75ed45032666bd832769fa25c2ba1fc82ab34d5 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c75ed45032 ] NIFI-11839 Upgraded Spring Boot from 2.7.13 to 2.7.14 Signed-off-by: Matt Burgess This closes #7508 > Upgrade Spring Boot to 2.7.14 > - > > Key: NIFI-11839 > URL: https://issues.apache.org/jira/browse/NIFI-11839 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 20m > Remaining Estimate: 0h > > Spring Boot > [2.7.14|https://github.com/spring-projects/spring-boot/releases/tag/v2.7.14] > incorporates dependency upgrades for Spring Framework 5.3.29 and several > other incremental transitive dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11839) Upgrade Spring Boot to 2.7.14
[ https://issues.apache.org/jira/browse/NIFI-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745254#comment-17745254 ] ASF subversion and git services commented on NIFI-11839: Commit 681e46010d79b929f39c6ee63751a2dbd395e9f1 in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=681e46010d ] NIFI-11839 Upgraded Spring Boot from 2.7.13 to 2.7.14 Signed-off-by: Matt Burgess > Upgrade Spring Boot to 2.7.14 > - > > Key: NIFI-11839 > URL: https://issues.apache.org/jira/browse/NIFI-11839 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Spring Boot > [2.7.14|https://github.com/spring-projects/spring-boot/releases/tag/v2.7.14] > incorporates dependency upgrades for Spring Framework 5.3.29 and several > other incremental transitive dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-11827) Create Schema Registry Controller Service for AWS Glue
[ https://issues.apache.org/jira/browse/NIFI-11827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11827. - Fix Version/s: 2.0.0 1.23.0 Resolution: Fixed > Create Schema Registry Controller Service for AWS Glue > -- > > Key: NIFI-11827 > URL: https://issues.apache.org/jira/browse/NIFI-11827 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Fix For: 2.0.0, 1.23.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11827) Create Schema Registry Controller Service for AWS Glue
[ https://issues.apache.org/jira/browse/NIFI-11827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745238#comment-17745238 ] ASF subversion and git services commented on NIFI-11827: Commit df8219ab57fbeba69f4a3c21aa9694ee35fab7d9 in nifi's branch refs/heads/support/nifi-1.x from Lehel [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=df8219ab57 ] NIFI-11827 Added AWS Glue Schema Registry Service This closes #7492 Signed-off-by: David Handermann (cherry picked from commit 8a5f7f00924cfb7922a69101c316b080dbcd) > Create Schema Registry Controller Service for AWS Glue > -- > > Key: NIFI-11827 > URL: https://issues.apache.org/jira/browse/NIFI-11827 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11827) Create Schema Registry Controller Service for AWS Glue
[ https://issues.apache.org/jira/browse/NIFI-11827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745232#comment-17745232 ] ASF subversion and git services commented on NIFI-11827: Commit 8a5f7f00924cfb7922a69101c316b080dbcd in nifi's branch refs/heads/main from Lehel [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8a5f7f0092 ] NIFI-11827 Added AWS Glue Schema Registry Service This closes #7492 Signed-off-by: David Handermann > Create Schema Registry Controller Service for AWS Glue > -- > > Key: NIFI-11827 > URL: https://issues.apache.org/jira/browse/NIFI-11827 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7492: NIFI-11827: Create Schema Registry Controller Service for AWS Glue
exceptionfactory closed pull request #7492: NIFI-11827: Create Schema Registry Controller Service for AWS Glue URL: https://github.com/apache/nifi/pull/7492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6619: NIFI-10760 Add Api key authentication option to ElasticSearchClientServiceImpl
ChrisSamo632 commented on code in PR #6619:
URL: https://github.com/apache/nifi/pull/6619#discussion_r1269822821
##
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceImpl.java:
##
@@ -275,6 +318,12 @@ private CredentialsProvider addCredentials(final
CredentialsProvider credentials
return cp;
}
+private BasicHeader createApiKeyAuthorizationHeader(String apiKeyId,
String apiKey) {
+final String apiKeyCredentials = String.format("%s:%s", apiKeyId,
apiKey);
+final String apiKeyAuth =
Base64.getEncoder().encodeToString((apiKeyCredentials).getBytes(StandardCharsets.UTF_8));
Review Comment:
The `id` and `key` would be the values returned by Elasticsearch when you
[create an api
key](https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-create-api-key.html#security-api-create-api-key-example)
- NiFi requires both of these to construct the `Authorization` (ApiKey) header
From your description, it sounds like you are applying the `encoded` field
from the Elasticsearch response (which is the Base64 encoded `id` & `key`) -
NiFi doesn't currently use that in its approach - if you require that, you
could raise a Jira to request it be added (submit a PR of your able) to make
that an alternative to providing these existing fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-11837) When a queue starts swapping out data, it never stops
[
https://issues.apache.org/jira/browse/NIFI-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11837:
Affects Version/s: 1.22.0
1.14.0
> When a queue starts swapping out data, it never stops
> -
>
> Key: NIFI-11837
> URL: https://issues.apache.org/jira/browse/NIFI-11837
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.14.0, 1.22.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 2.0.0, 1.23.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a queue reaches the swap threshold (defined in nifi.properties as
> {{nifi.queue.swap.threshold}} and defaulted to 20,000 FlowFiles), it enters
> 'swap mode'. However, it never exits swap mode.
> This means that even if the queue is completely emptied, the data that does
> enter the queue will be swapped out if the queue reaches 10K FlowFiles.
> Additionally, there is significant overhead under the covers in handling this.
> To replicate, create a simple flow:
> GenerateFlowFile -> UpdateAttribute.
> Set GenerateFlowFile to run with 6 threads, Run Schedule of "0 secs" and a
> Run Duration of "100 ms". Auto-terminate the 'success' relationship of
> UpdateAttribute
> This will quickly fill the queue beyond 20K FlowFiles.
> Now, stop GenerateFlowFile. Lower to 4 threads and a Run Duration of "10 ms"
> Start both processors. Watch the logs indicating that data is constantly be
> swapped in and out.
> This can have a very significant impact on performance. In my testing on my
> laptop, once this flow started swapping, its 5-minute stats dropped from 14.5
> MM FlowFiles per 5 minutes down to 11 MM FlowFiles (roughly a 30% decline)
> In addition to lower throughput, it causes much higher resource utilization,
> which affects all flows.
> This defect may affect anyone using a large number of small FlowFiles,
> especially those where data may be bursty enough to exceed to 20,000 FlowFile
> swapping limit or flows that have Backpressure Threshold set beyond 10,000.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11837) When a queue starts swapping out data, it never stops
[
https://issues.apache.org/jira/browse/NIFI-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11837:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> When a queue starts swapping out data, it never stops
> -
>
> Key: NIFI-11837
> URL: https://issues.apache.org/jira/browse/NIFI-11837
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.14.0, 1.22.0
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 2.0.0, 1.23.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a queue reaches the swap threshold (defined in nifi.properties as
> {{nifi.queue.swap.threshold}} and defaulted to 20,000 FlowFiles), it enters
> 'swap mode'. However, it never exits swap mode.
> This means that even if the queue is completely emptied, the data that does
> enter the queue will be swapped out if the queue reaches 10K FlowFiles.
> Additionally, there is significant overhead under the covers in handling this.
> To replicate, create a simple flow:
> GenerateFlowFile -> UpdateAttribute.
> Set GenerateFlowFile to run with 6 threads, Run Schedule of "0 secs" and a
> Run Duration of "100 ms". Auto-terminate the 'success' relationship of
> UpdateAttribute
> This will quickly fill the queue beyond 20K FlowFiles.
> Now, stop GenerateFlowFile. Lower to 4 threads and a Run Duration of "10 ms"
> Start both processors. Watch the logs indicating that data is constantly be
> swapped in and out.
> This can have a very significant impact on performance. In my testing on my
> laptop, once this flow started swapping, its 5-minute stats dropped from 14.5
> MM FlowFiles per 5 minutes down to 11 MM FlowFiles (roughly a 30% decline)
> In addition to lower throughput, it causes much higher resource utilization,
> which affects all flows.
> This defect may affect anyone using a large number of small FlowFiles,
> especially those where data may be bursty enough to exceed to 20,000 FlowFile
> swapping limit or flows that have Backpressure Threshold set beyond 10,000.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11837) When a queue starts swapping out data, it never stops
[
https://issues.apache.org/jira/browse/NIFI-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745200#comment-17745200
]
ASF subversion and git services commented on NIFI-11837:
Commit 9bc119ca197cd9f7537c63513e6010d4b4a4d71e in nifi's branch
refs/heads/support/nifi-1.x from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=9bc119ca19 ]
NIFI-11837: When determining whether or not a queue should exit 'swap mode' we
need to look at the updated size of the queue after migrating data from swapped
queue to active queue. Previously, we were looking at the size variable that
was obtained from before the migration happened.
This closes #7506
Signed-off-by: David Handermann
(cherry picked from commit 8f5392dd114ab5daeed12c6792d8dd2eb75bc362)
> When a queue starts swapping out data, it never stops
> -
>
> Key: NIFI-11837
> URL: https://issues.apache.org/jira/browse/NIFI-11837
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 2.0.0, 1.23.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a queue reaches the swap threshold (defined in nifi.properties as
> {{nifi.queue.swap.threshold}} and defaulted to 20,000 FlowFiles), it enters
> 'swap mode'. However, it never exits swap mode.
> This means that even if the queue is completely emptied, the data that does
> enter the queue will be swapped out if the queue reaches 10K FlowFiles.
> Additionally, there is significant overhead under the covers in handling this.
> To replicate, create a simple flow:
> GenerateFlowFile -> UpdateAttribute.
> Set GenerateFlowFile to run with 6 threads, Run Schedule of "0 secs" and a
> Run Duration of "100 ms". Auto-terminate the 'success' relationship of
> UpdateAttribute
> This will quickly fill the queue beyond 20K FlowFiles.
> Now, stop GenerateFlowFile. Lower to 4 threads and a Run Duration of "10 ms"
> Start both processors. Watch the logs indicating that data is constantly be
> swapped in and out.
> This can have a very significant impact on performance. In my testing on my
> laptop, once this flow started swapping, its 5-minute stats dropped from 14.5
> MM FlowFiles per 5 minutes down to 11 MM FlowFiles (roughly a 30% decline)
> In addition to lower throughput, it causes much higher resource utilization,
> which affects all flows.
> This defect may affect anyone using a large number of small FlowFiles,
> especially those where data may be bursty enough to exceed to 20,000 FlowFile
> swapping limit or flows that have Backpressure Threshold set beyond 10,000.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11837) When a queue starts swapping out data, it never stops
[
https://issues.apache.org/jira/browse/NIFI-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745201#comment-17745201
]
ASF subversion and git services commented on NIFI-11837:
Commit 9bc119ca197cd9f7537c63513e6010d4b4a4d71e in nifi's branch
refs/heads/support/nifi-1.x from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=9bc119ca19 ]
NIFI-11837: When determining whether or not a queue should exit 'swap mode' we
need to look at the updated size of the queue after migrating data from swapped
queue to active queue. Previously, we were looking at the size variable that
was obtained from before the migration happened.
This closes #7506
Signed-off-by: David Handermann
(cherry picked from commit 8f5392dd114ab5daeed12c6792d8dd2eb75bc362)
> When a queue starts swapping out data, it never stops
> -
>
> Key: NIFI-11837
> URL: https://issues.apache.org/jira/browse/NIFI-11837
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 2.0.0, 1.23.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a queue reaches the swap threshold (defined in nifi.properties as
> {{nifi.queue.swap.threshold}} and defaulted to 20,000 FlowFiles), it enters
> 'swap mode'. However, it never exits swap mode.
> This means that even if the queue is completely emptied, the data that does
> enter the queue will be swapped out if the queue reaches 10K FlowFiles.
> Additionally, there is significant overhead under the covers in handling this.
> To replicate, create a simple flow:
> GenerateFlowFile -> UpdateAttribute.
> Set GenerateFlowFile to run with 6 threads, Run Schedule of "0 secs" and a
> Run Duration of "100 ms". Auto-terminate the 'success' relationship of
> UpdateAttribute
> This will quickly fill the queue beyond 20K FlowFiles.
> Now, stop GenerateFlowFile. Lower to 4 threads and a Run Duration of "10 ms"
> Start both processors. Watch the logs indicating that data is constantly be
> swapped in and out.
> This can have a very significant impact on performance. In my testing on my
> laptop, once this flow started swapping, its 5-minute stats dropped from 14.5
> MM FlowFiles per 5 minutes down to 11 MM FlowFiles (roughly a 30% decline)
> In addition to lower throughput, it causes much higher resource utilization,
> which affects all flows.
> This defect may affect anyone using a large number of small FlowFiles,
> especially those where data may be bursty enough to exceed to 20,000 FlowFile
> swapping limit or flows that have Backpressure Threshold set beyond 10,000.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11837) When a queue starts swapping out data, it never stops
[
https://issues.apache.org/jira/browse/NIFI-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745199#comment-17745199
]
ASF subversion and git services commented on NIFI-11837:
Commit 8f5392dd114ab5daeed12c6792d8dd2eb75bc362 in nifi's branch
refs/heads/main from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8f5392dd11 ]
NIFI-11837: When determining whether or not a queue should exit 'swap mode' we
need to look at the updated size of the queue after migrating data from swapped
queue to active queue. Previously, we were looking at the size variable that
was obtained from before the migration happened.
This closes #7506
Signed-off-by: David Handermann
> When a queue starts swapping out data, it never stops
> -
>
> Key: NIFI-11837
> URL: https://issues.apache.org/jira/browse/NIFI-11837
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 2.0.0, 1.23.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When a queue reaches the swap threshold (defined in nifi.properties as
> {{nifi.queue.swap.threshold}} and defaulted to 20,000 FlowFiles), it enters
> 'swap mode'. However, it never exits swap mode.
> This means that even if the queue is completely emptied, the data that does
> enter the queue will be swapped out if the queue reaches 10K FlowFiles.
> Additionally, there is significant overhead under the covers in handling this.
> To replicate, create a simple flow:
> GenerateFlowFile -> UpdateAttribute.
> Set GenerateFlowFile to run with 6 threads, Run Schedule of "0 secs" and a
> Run Duration of "100 ms". Auto-terminate the 'success' relationship of
> UpdateAttribute
> This will quickly fill the queue beyond 20K FlowFiles.
> Now, stop GenerateFlowFile. Lower to 4 threads and a Run Duration of "10 ms"
> Start both processors. Watch the logs indicating that data is constantly be
> swapped in and out.
> This can have a very significant impact on performance. In my testing on my
> laptop, once this flow started swapping, its 5-minute stats dropped from 14.5
> MM FlowFiles per 5 minutes down to 11 MM FlowFiles (roughly a 30% decline)
> In addition to lower throughput, it causes much higher resource utilization,
> which affects all flows.
> This defect may affect anyone using a large number of small FlowFiles,
> especially those where data may be bursty enough to exceed to 20,000 FlowFile
> swapping limit or flows that have Backpressure Threshold set beyond 10,000.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7506: NIFI-11837: When determining whether or not a queue should exit 'swap…
exceptionfactory closed pull request #7506: NIFI-11837: When determining whether or not a queue should exit 'swap… URL: https://github.com/apache/nifi/pull/7506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11840) ConsumeKafkaRecord, add Kafka record metadata attributes before handoff to RecordReader
Paul Grey created NIFI-11840: Summary: ConsumeKafkaRecord, add Kafka record metadata attributes before handoff to RecordReader Key: NIFI-11840 URL: https://issues.apache.org/jira/browse/NIFI-11840 Project: Apache NiFi Issue Type: Improvement Reporter: Paul Grey Assignee: Paul Grey This adjustment would handle cases where RecordReader might want to adjust behavior based on metadata from the incoming Kafka ConsumeRecord (for example, topic name). One possibility would be to move attribute set from here: https://github.com/apache/nifi/blob/1156f4cbc57c2bac5654d6b475ddfd486cb66050/nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumerLease.java#L829-L830 to here: https://github.com/apache/nifi/blob/1156f4cbc57c2bac5654d6b475ddfd486cb66050/nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumerLease.java#L573 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11838) Upgrade Netty to 4.1.95
[ https://issues.apache.org/jira/browse/NIFI-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11838: Status: Patch Available (was: In Progress) > Upgrade Netty to 4.1.95 > --- > > Key: NIFI-11838 > URL: https://issues.apache.org/jira/browse/NIFI-11838 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Netty [4.1.95|https://netty.io/news/2023/07/20/4-1-95-Final.html] includes > several minor bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11839) Upgrade Spring Boot to 2.7.14
[ https://issues.apache.org/jira/browse/NIFI-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11839: Status: Patch Available (was: Open) > Upgrade Spring Boot to 2.7.14 > - > > Key: NIFI-11839 > URL: https://issues.apache.org/jira/browse/NIFI-11839 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Spring Boot > [2.7.14|https://github.com/spring-projects/spring-boot/releases/tag/v2.7.14] > incorporates dependency upgrades for Spring Framework 5.3.29 and several > other incremental transitive dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #7508: NIFI-11839 Upgrade Spring Boot from 2.7.13 to 2.7.14
exceptionfactory opened a new pull request, #7508: URL: https://github.com/apache/nifi/pull/7508 # Summary [NIFI-11839](https://issues.apache.org/jira/browse/NIFI-11839) Upgrades Spring Boot from 2.7.13 to [2.7.14](https://github.com/spring-projects/spring-boot/releases/tag/v2.7.14) aligning with the current project dependency on Spring Framework 5.3.29. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory opened a new pull request, #7507: NIFI-11838 Upgrade Netty from 4.1.94 to 4.1.95
exceptionfactory opened a new pull request, #7507: URL: https://github.com/apache/nifi/pull/7507 # Summary [NIFI-11838](https://issues.apache.org/jira/browse/NIFI-11838) Upgrades Netty from 4.1.94 to [4.1.95](https://netty.io/news/2023/07/20/4-1-95-Final.html) incorporating several minor bug fixes and improvements. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11839) Upgrade Spring Boot to 2.7.14
David Handermann created NIFI-11839: --- Summary: Upgrade Spring Boot to 2.7.14 Key: NIFI-11839 URL: https://issues.apache.org/jira/browse/NIFI-11839 Project: Apache NiFi Issue Type: Improvement Components: NiFi Registry Reporter: David Handermann Assignee: David Handermann Fix For: 1.latest, 2.latest Spring Boot [2.7.14|https://github.com/spring-projects/spring-boot/releases/tag/v2.7.14] incorporates dependency upgrades for Spring Framework 5.3.29 and several other incremental transitive dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11838) Upgrade Netty to 4.1.95
David Handermann created NIFI-11838: --- Summary: Upgrade Netty to 4.1.95 Key: NIFI-11838 URL: https://issues.apache.org/jira/browse/NIFI-11838 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: David Handermann Assignee: David Handermann Fix For: 1.latest, 2.latest Netty [4.1.95|https://netty.io/news/2023/07/20/4-1-95-Final.html] includes several minor bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] wannadream commented on a diff in pull request #6619: NIFI-10760 Add Api key authentication option to ElasticSearchClientServiceImpl
wannadream commented on code in PR #6619:
URL: https://github.com/apache/nifi/pull/6619#discussion_r1269709827
##
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceImpl.java:
##
@@ -275,6 +318,12 @@ private CredentialsProvider addCredentials(final
CredentialsProvider credentials
return cp;
}
+private BasicHeader createApiKeyAuthorizationHeader(String apiKeyId,
String apiKey) {
+final String apiKeyCredentials = String.format("%s:%s", apiKeyId,
apiKey);
+final String apiKeyAuth =
Base64.getEncoder().encodeToString((apiKeyCredentials).getBytes(StandardCharsets.UTF_8));
Review Comment:
Hi @nandorsoma , I ran into issues with Elastic Search API auth. Standard
HTTP client works well for me, but it did not work with this client
implementation. I looked into the code then found some questionable lines. What
is API key id doing here? It is a required field, but should it be part of the
token? And why does it encode the string once more as we already pass in base64
token string. Could you elaborate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-11816) Removal of Primary Node Scheduling Strategy
[ https://issues.apache.org/jira/browse/NIFI-11816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11816: Fix Version/s: 2.0.0 (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Removal of Primary Node Scheduling Strategy > --- > > Key: NIFI-11816 > URL: https://issues.apache.org/jira/browse/NIFI-11816 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As a follow-up of NIFI-11813, we want to remove the Primary Node Only > Scheduling Strategy that has been deprecated for a long time and replaced by > the Execution Node configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11816) Removal of Primary Node Scheduling Strategy
[ https://issues.apache.org/jira/browse/NIFI-11816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745168#comment-17745168 ] ASF subversion and git services commented on NIFI-11816: Commit 20b19992d2218d767e735d923a4cc7cf7733bc60 in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=20b19992d2 ] NIFI-11816 - Removed deprecated Primary Node Scheduling Strategy This closes #7501 Signed-off-by: David Handermann > Removal of Primary Node Scheduling Strategy > --- > > Key: NIFI-11816 > URL: https://issues.apache.org/jira/browse/NIFI-11816 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.latest > > Time Spent: 20m > Remaining Estimate: 0h > > As a follow-up of NIFI-11813, we want to remove the Primary Node Only > Scheduling Strategy that has been deprecated for a long time and replaced by > the Execution Node configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7501: NIFI-11816 - Removing deprecated Primary Node Scheduling Strategy
exceptionfactory closed pull request #7501: NIFI-11816 - Removing deprecated Primary Node Scheduling Strategy URL: https://github.com/apache/nifi/pull/7501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-11835) Update json-schema-validator to 1.0.86
[ https://issues.apache.org/jira/browse/NIFI-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11835. - Fix Version/s: 2.0.0 1.23.0 Resolution: Fixed > Update json-schema-validator to 1.0.86 > -- > > Key: NIFI-11835 > URL: https://issues.apache.org/jira/browse/NIFI-11835 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.23.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update json-schema-validator to 1.0.86 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11835) Update json-schema-validator to 1.0.86
[ https://issues.apache.org/jira/browse/NIFI-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11835: Priority: Minor (was: Major) > Update json-schema-validator to 1.0.86 > -- > > Key: NIFI-11835 > URL: https://issues.apache.org/jira/browse/NIFI-11835 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update json-schema-validator to 1.0.86 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11835) Update json-schema-validator to 1.0.86
[ https://issues.apache.org/jira/browse/NIFI-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745166#comment-17745166 ] ASF subversion and git services commented on NIFI-11835: Commit 0a774f231afc33a177f49246c2568f96c49fc680 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0a774f231a ] NIFI-11835 Upgraded json-schema-validator from 1.0.84 to 1.0.86 This closes #7505 Signed-off-by: David Handermann > Update json-schema-validator to 1.0.86 > -- > > Key: NIFI-11835 > URL: https://issues.apache.org/jira/browse/NIFI-11835 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.22.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Update json-schema-validator to 1.0.86 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11835) Update json-schema-validator to 1.0.86
[ https://issues.apache.org/jira/browse/NIFI-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745167#comment-17745167 ] ASF subversion and git services commented on NIFI-11835: Commit 079e0a4773e75fd03d84a27bbed6a23e8ce1416e in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=079e0a4773 ] NIFI-11835 Upgraded json-schema-validator from 1.0.84 to 1.0.86 This closes #7505 Signed-off-by: David Handermann (cherry picked from commit 0a774f231afc33a177f49246c2568f96c49fc680) > Update json-schema-validator to 1.0.86 > -- > > Key: NIFI-11835 > URL: https://issues.apache.org/jira/browse/NIFI-11835 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.22.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Update json-schema-validator to 1.0.86 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11835) Update json-schema-validator to 1.0.86
[ https://issues.apache.org/jira/browse/NIFI-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11835: Affects Version/s: (was: 1.22.0) > Update json-schema-validator to 1.0.86 > -- > > Key: NIFI-11835 > URL: https://issues.apache.org/jira/browse/NIFI-11835 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Update json-schema-validator to 1.0.86 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7505: NIFI-11835 Update json-schema-validator to 1.0.86
exceptionfactory closed pull request #7505: NIFI-11835 Update json-schema-validator to 1.0.86 URL: https://github.com/apache/nifi/pull/7505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] wannadream commented on a diff in pull request #6619: NIFI-10760 Add Api key authentication option to ElasticSearchClientServiceImpl
wannadream commented on code in PR #6619:
URL: https://github.com/apache/nifi/pull/6619#discussion_r1269709827
##
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceImpl.java:
##
@@ -275,6 +318,12 @@ private CredentialsProvider addCredentials(final
CredentialsProvider credentials
return cp;
}
+private BasicHeader createApiKeyAuthorizationHeader(String apiKeyId,
String apiKey) {
+final String apiKeyCredentials = String.format("%s:%s", apiKeyId,
apiKey);
+final String apiKeyAuth =
Base64.getEncoder().encodeToString((apiKeyCredentials).getBytes(StandardCharsets.UTF_8));
Review Comment:
Hi @nandorsoma , I ran into issues with Elastic Search API auth. Standard
HTTP client works well for me, but it did not work with this client
implementation. I looked into the code then found some questionable lines. What
is API key id doing here? It is a required field, but should it be part of the
token? And why does it encode the string once more as we already passed in
base64 token string. Could you elaborate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-11837) When a queue starts swapping out data, it never stops
[
https://issues.apache.org/jira/browse/NIFI-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11837:
Fix Version/s: 1.23.0
(was: 1.latest)
> When a queue starts swapping out data, it never stops
> -
>
> Key: NIFI-11837
> URL: https://issues.apache.org/jira/browse/NIFI-11837
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 2.0.0, 1.23.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When a queue reaches the swap threshold (defined in nifi.properties as
> {{nifi.queue.swap.threshold}} and defaulted to 20,000 FlowFiles), it enters
> 'swap mode'. However, it never exits swap mode.
> This means that even if the queue is completely emptied, the data that does
> enter the queue will be swapped out if the queue reaches 10K FlowFiles.
> Additionally, there is significant overhead under the covers in handling this.
> To replicate, create a simple flow:
> GenerateFlowFile -> UpdateAttribute.
> Set GenerateFlowFile to run with 6 threads, Run Schedule of "0 secs" and a
> Run Duration of "100 ms". Auto-terminate the 'success' relationship of
> UpdateAttribute
> This will quickly fill the queue beyond 20K FlowFiles.
> Now, stop GenerateFlowFile. Lower to 4 threads and a Run Duration of "10 ms"
> Start both processors. Watch the logs indicating that data is constantly be
> swapped in and out.
> This can have a very significant impact on performance. In my testing on my
> laptop, once this flow started swapping, its 5-minute stats dropped from 14.5
> MM FlowFiles per 5 minutes down to 11 MM FlowFiles (roughly a 30% decline)
> In addition to lower throughput, it causes much higher resource utilization,
> which affects all flows.
> This defect may affect anyone using a large number of small FlowFiles,
> especially those where data may be bursty enough to exceed to 20,000 FlowFile
> swapping limit or flows that have Backpressure Threshold set beyond 10,000.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11837) When a queue starts swapping out data, it never stops
[
https://issues.apache.org/jira/browse/NIFI-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-11837:
--
Fix Version/s: 2.0.0
1.latest
Status: Patch Available (was: Open)
> When a queue starts swapping out data, it never stops
> -
>
> Key: NIFI-11837
> URL: https://issues.apache.org/jira/browse/NIFI-11837
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 2.0.0, 1.latest
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When a queue reaches the swap threshold (defined in nifi.properties as
> {{nifi.queue.swap.threshold}} and defaulted to 20,000 FlowFiles), it enters
> 'swap mode'. However, it never exits swap mode.
> This means that even if the queue is completely emptied, the data that does
> enter the queue will be swapped out if the queue reaches 10K FlowFiles.
> Additionally, there is significant overhead under the covers in handling this.
> To replicate, create a simple flow:
> GenerateFlowFile -> UpdateAttribute.
> Set GenerateFlowFile to run with 6 threads, Run Schedule of "0 secs" and a
> Run Duration of "100 ms". Auto-terminate the 'success' relationship of
> UpdateAttribute
> This will quickly fill the queue beyond 20K FlowFiles.
> Now, stop GenerateFlowFile. Lower to 4 threads and a Run Duration of "10 ms"
> Start both processors. Watch the logs indicating that data is constantly be
> swapped in and out.
> This can have a very significant impact on performance. In my testing on my
> laptop, once this flow started swapping, its 5-minute stats dropped from 14.5
> MM FlowFiles per 5 minutes down to 11 MM FlowFiles (roughly a 30% decline)
> In addition to lower throughput, it causes much higher resource utilization,
> which affects all flows.
> This defect may affect anyone using a large number of small FlowFiles,
> especially those where data may be bursty enough to exceed to 20,000 FlowFile
> swapping limit or flows that have Backpressure Threshold set beyond 10,000.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] markap14 opened a new pull request, #7506: NIFI-11837: When determining whether or not a queue should exit 'swap…
markap14 opened a new pull request, #7506: URL: https://github.com/apache/nifi/pull/7506 … mode' we need to look at the updated size of the queue after migrating data from swapped queue to active queue. Previously, we were looking at the size variable that was obtained from before the migration happened. # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11833) Remove deprecated classes in nifi-commons
[ https://issues.apache.org/jira/browse/NIFI-11833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otto Fowler updated NIFI-11833: --- Resolution: Done Status: Resolved (was: Patch Available) > Remove deprecated classes in nifi-commons > - > > Key: NIFI-11833 > URL: https://issues.apache.org/jira/browse/NIFI-11833 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Some classes are deprecated in 1.x and can be removed in 2.x: > * > ./nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/DataOutputStream.java > * > ./nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/BufferedInputStream.java > * > ./nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/BufferedOutputStream.java > * > ./nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/ByteArrayInputStream.java > * > ./nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/ByteArrayOutputStream.java > * > ./nifi-commons/nifi-write-ahead-log/src/main/java/org/wali/MinimalLockingWriteAheadLog.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11837) When a queue starts swapping out data, it never stops
Mark Payne created NIFI-11837:
-
Summary: When a queue starts swapping out data, it never stops
Key: NIFI-11837
URL: https://issues.apache.org/jira/browse/NIFI-11837
Project: Apache NiFi
Issue Type: Bug
Components: Core Framework
Reporter: Mark Payne
Assignee: Mark Payne
When a queue reaches the swap threshold (defined in nifi.properties as
{{nifi.queue.swap.threshold}} and defaulted to 20,000 FlowFiles), it enters
'swap mode'. However, it never exits swap mode.
This means that even if the queue is completely emptied, the data that does
enter the queue will be swapped out if the queue reaches 10K FlowFiles.
Additionally, there is significant overhead under the covers in handling this.
To replicate, create a simple flow:
GenerateFlowFile -> UpdateAttribute.
Set GenerateFlowFile to run with 6 threads, Run Schedule of "0 secs" and a Run
Duration of "100 ms". Auto-terminate the 'success' relationship of
UpdateAttribute
This will quickly fill the queue beyond 20K FlowFiles.
Now, stop GenerateFlowFile. Lower to 4 threads and a Run Duration of "10 ms"
Start both processors. Watch the logs indicating that data is constantly be
swapped in and out.
This can have a very significant impact on performance. In my testing on my
laptop, once this flow started swapping, its 5-minute stats dropped from 14.5
MM FlowFiles per 5 minutes down to 11 MM FlowFiles (roughly a 30% decline)
In addition to lower throughput, it causes much higher resource utilization,
which affects all flows.
This defect may affect anyone using a large number of small FlowFiles,
especially those where data may be bursty enough to exceed to 20,000 FlowFile
swapping limit or flows that have Backpressure Threshold set beyond 10,000.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11833) Remove deprecated classes in nifi-commons
[ https://issues.apache.org/jira/browse/NIFI-11833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745149#comment-17745149 ] ASF subversion and git services commented on NIFI-11833: Commit c06bb97e85f1a592a85c529116739d9a86540dcd in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c06bb97e85 ] NIFI-11833 - remove deprecated classes in nifi-commons (#7503) Signed-off-by: Otto Fowler > Remove deprecated classes in nifi-commons > - > > Key: NIFI-11833 > URL: https://issues.apache.org/jira/browse/NIFI-11833 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Some classes are deprecated in 1.x and can be removed in 2.x: > * > ./nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/DataOutputStream.java > * > ./nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/BufferedInputStream.java > * > ./nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/BufferedOutputStream.java > * > ./nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/ByteArrayInputStream.java > * > ./nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/ByteArrayOutputStream.java > * > ./nifi-commons/nifi-write-ahead-log/src/main/java/org/wali/MinimalLockingWriteAheadLog.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] ottobackwards merged pull request #7503: NIFI-11833 - remove deprecated classes in nifi-commons
ottobackwards merged PR #7503: URL: https://github.com/apache/nifi/pull/7503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2168) Github actions cache issues
Gábor Gyimesi created MINIFICPP-2168: Summary: Github actions cache issues Key: MINIFICPP-2168 URL: https://issues.apache.org/jira/browse/MINIFICPP-2168 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi * There seems to be no cache saved and restored in the docker builds * Caches for pull requests are always evicted, only cache for main branch is kept -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] Lehel44 commented on pull request #7492: NIFI-11827: Create Schema Registry Controller Service for AWS Glue
Lehel44 commented on PR #7492: URL: https://github.com/apache/nifi/pull/7492#issuecomment-1644053225 Thanks for the review and testing @exceptionfactory! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11836) Update Guava to 31.1-jre
[ https://issues.apache.org/jira/browse/NIFI-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745095#comment-17745095 ] David Handermann commented on NIFI-11836: - Guava 32.0.1 is the latest version, so this should not be necessary. > Update Guava to 31.1-jre > > > Key: NIFI-11836 > URL: https://issues.apache.org/jira/browse/NIFI-11836 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.22.0 >Reporter: Mike R >Priority: Major > > Update Guava to 31.1-jre -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11836) Update Guava to 31.1-jre
Mike R created NIFI-11836: - Summary: Update Guava to 31.1-jre Key: NIFI-11836 URL: https://issues.apache.org/jira/browse/NIFI-11836 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.22.0 Reporter: Mike R Update Guava to 31.1-jre -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2157) Move response node implementations to source files
[ https://issues.apache.org/jira/browse/MINIFICPP-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2157: - Fix Version/s: 0.15.0 > Move response node implementations to source files > -- > > Key: MINIFICPP-2157 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2157 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Minor > Labels: MiNiFi-CPP-Hygiene > Fix For: 0.15.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Most response nodes have their implementations in the header files, which > should be moved to the cpp files. Additional refactoring can also be done > with the layout definitions to make them more compact. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2098) ENABLE_ALL should enable (almost) all extensions
[
https://issues.apache.org/jira/browse/MINIFICPP-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi updated MINIFICPP-2098:
-
Fix Version/s: 0.15.0
> ENABLE_ALL should enable (almost) all extensions
>
>
> Key: MINIFICPP-2098
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2098
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
>Affects Versions: 0.14.0
>Reporter: Ferenc Gerlits
>Assignee: Gábor Gyimesi
>Priority: Minor
> Fix For: 0.15.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently, {{ENABLE_ALL=ON}} enables most, but not all, extensions.
> For example, Bustache, Kubernetes, OPC, OpenCV, OpenWSMAN, PDH, Systemd and
> Tensorflow are not currently enabled by {{ENABLE_ALL}}.
> Tensorflow should probably not be enabled, as it requires special libraries
> to be installed on the system and cannot install them during the build
> process (and these libraries are not available as packages).
> The rest of the extensions should be enabled by {{ENABLE_ALL=ON}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2139) Build fails on ARM7 architecture
[ https://issues.apache.org/jira/browse/MINIFICPP-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2139: - Fix Version/s: 0.15.0 > Build fails on ARM7 architecture > > > Key: MINIFICPP-2139 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2139 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Fix For: 0.15.0 > > Time Spent: 40m > Remaining Estimate: 0h > > There are a few build issues on ARM7 architecture that should be fixed to be > able to build MiNiFi C++ on 32bit raspberry pi systems. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2135) Add SSL support for Prometheus reporter
[ https://issues.apache.org/jira/browse/MINIFICPP-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2135: - Fix Version/s: 0.15.0 > Add SSL support for Prometheus reporter > --- > > Key: MINIFICPP-2135 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2135 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Fix For: 0.15.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > MiNiFi needs Prometheus extensions to support SSL communication with > Prometheus server -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2135) Add SSL support for Prometheus reporter
[ https://issues.apache.org/jira/browse/MINIFICPP-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2135. - Resolution: Done > Add SSL support for Prometheus reporter > --- > > Key: MINIFICPP-2135 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2135 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > MiNiFi needs Prometheus extensions to support SSL communication with > Prometheus server -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2098) ENABLE_ALL should enable (almost) all extensions
[
https://issues.apache.org/jira/browse/MINIFICPP-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz resolved MINIFICPP-2098.
-
Resolution: Done
> ENABLE_ALL should enable (almost) all extensions
>
>
> Key: MINIFICPP-2098
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2098
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
>Affects Versions: 0.14.0
>Reporter: Ferenc Gerlits
>Assignee: Gábor Gyimesi
>Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently, {{ENABLE_ALL=ON}} enables most, but not all, extensions.
> For example, Bustache, Kubernetes, OPC, OpenCV, OpenWSMAN, PDH, Systemd and
> Tensorflow are not currently enabled by {{ENABLE_ALL}}.
> Tensorflow should probably not be enabled, as it requires special libraries
> to be installed on the system and cannot install them during the build
> process (and these libraries are not available as packages).
> The rest of the extensions should be enabled by {{ENABLE_ALL=ON}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2139) Build fails on ARM7 architecture
[ https://issues.apache.org/jira/browse/MINIFICPP-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2139. - Resolution: Fixed > Build fails on ARM7 architecture > > > Key: MINIFICPP-2139 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2139 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > There are a few build issues on ARM7 architecture that should be fixed to be > able to build MiNiFi C++ on 32bit raspberry pi systems. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2157) Move response node implementations to source files
[ https://issues.apache.org/jira/browse/MINIFICPP-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2157. - Resolution: Done > Move response node implementations to source files > -- > > Key: MINIFICPP-2157 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2157 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Minor > Labels: MiNiFi-CPP-Hygiene > Time Spent: 40m > Remaining Estimate: 0h > > Most response nodes have their implementations in the header files, which > should be moved to the cpp files. Additional refactoring can also be done > with the layout definitions to make them more compact. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1602: MINIFICPP-2157 Move response node implementations to source files
szaszm closed pull request #1602: MINIFICPP-2157 Move response node implementations to source files URL: https://github.com/apache/nifi-minifi-cpp/pull/1602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1590: MINIFICPP-2139 Fix build on ARM7 architecture
szaszm closed pull request #1590: MINIFICPP-2139 Fix build on ARM7 architecture URL: https://github.com/apache/nifi-minifi-cpp/pull/1590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1587: MINIFICPP-2135 Add SSL support for Prometheus reporter
szaszm closed pull request #1587: MINIFICPP-2135 Add SSL support for Prometheus reporter URL: https://github.com/apache/nifi-minifi-cpp/pull/1587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mr1716 opened a new pull request, #7505: NIFI-11835 Update json-schema-validator to 1.0.86
mr1716 opened a new pull request, #7505: URL: https://github.com/apache/nifi/pull/7505 # Summary [NIFI-11835](https://issues.apache.org/jira/browse/NIFI-11835) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-11835) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-11835) Update json-schema-validator to 1.0.86
[ https://issues.apache.org/jira/browse/NIFI-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-11835: - Assignee: Mike R > Update json-schema-validator to 1.0.86 > -- > > Key: NIFI-11835 > URL: https://issues.apache.org/jira/browse/NIFI-11835 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.22.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update json-schema-validator to 1.0.86 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11835) Update json-schema-validator to 1.0.86
Mike R created NIFI-11835: - Summary: Update json-schema-validator to 1.0.86 Key: NIFI-11835 URL: https://issues.apache.org/jira/browse/NIFI-11835 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.22.0 Reporter: Mike R Update json-schema-validator to 1.0.86 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1602: MINIFICPP-2157 Move response node implementations to source files
lordgamez commented on code in PR #1602:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1602#discussion_r1269385900
##
libminifi/src/core/state/nodes/DeviceInformation.cpp:
##
@@ -15,13 +15,307 @@
* limitations under the License.
*/
#include "core/state/nodes/DeviceInformation.h"
+
+#include
+#include
+
#include "core/Resource.h"
namespace org::apache::nifi::minifi::state::response {
utils::SystemCpuUsageTracker DeviceInfoNode::cpu_load_tracker_;
std::mutex DeviceInfoNode::cpu_load_tracker_mutex_;
+Device::Device() {
+ addrinfo hints;
+ memset(, 0, sizeof hints); // make sure the struct is empty
+ hints.ai_family = AF_UNSPEC;
+ hints.ai_socktype = SOCK_STREAM;
+ hints.ai_flags = AI_CANONNAME;
+ hints.ai_protocol = 0; /* any protocol */
+
Review Comment:
Good point, removed in 35ee94afcd51bd3ec6abaf6ba53e9fa1e1aa45ca
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1602: MINIFICPP-2157 Move response node implementations to source files
szaszm commented on code in PR #1602:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1602#discussion_r1254210913
##
libminifi/src/core/state/nodes/DeviceInformation.cpp:
##
@@ -15,13 +15,307 @@
* limitations under the License.
*/
#include "core/state/nodes/DeviceInformation.h"
+
+#include
+#include
+
#include "core/Resource.h"
namespace org::apache::nifi::minifi::state::response {
utils::SystemCpuUsageTracker DeviceInfoNode::cpu_load_tracker_;
std::mutex DeviceInfoNode::cpu_load_tracker_mutex_;
+Device::Device() {
+ addrinfo hints;
+ memset(, 0, sizeof hints); // make sure the struct is empty
+ hints.ai_family = AF_UNSPEC;
+ hints.ai_socktype = SOCK_STREAM;
+ hints.ai_flags = AI_CANONNAME;
+ hints.ai_protocol = 0; /* any protocol */
+
Review Comment:
This looks unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1612: MINIFICPP-2159 Add heterogeneous lookup to FlatMap
martinzink opened a new pull request, #1612: URL: https://github.com/apache/nifi-minifi-cpp/pull/1612 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1611: MINIFICPP-2162 Use className() instead of getClassName()
fgerlits opened a new pull request, #1611: URL: https://github.com/apache/nifi-minifi-cpp/pull/1611 https://issues.apache.org/jira/browse/MINIFICPP-2162 Replace usages of `getClassName() -> std::string` with `className() -> std::string_view`. This led to some other `const std::string&` to `std::string_view` changes in the parameter types of some functions. I have also removed a `static_assert` in the `className()` implementation, because it caused CLion to show bogus errors, probably due to a confusion between `gcc` (used to compile the code) and `clang` (used to analyze the code). If the condition fails, we will still get a compile error, just with a less useful error message. --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1610: MINIFICPP-2134 Do not swallow parsing exceptions
fgerlits opened a new pull request, #1610:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1610
https://issues.apache.org/jira/browse/MINIFICPP-2134
If the value of a typed property (Time Period, Data Size, Port etc) is set,
but to an invalid value, then we should throw in getProperty().
In some cases, we were using a typed getProperty(), but the corresponding
PropertyDefinition did not have a PropertyType, so the C2 server had no way of
validating the property. In these cases, I have kept the current behavior,
which is to treat the invalid value as if no value was set -- but I have also
added the PropertyType to the PropertyDefinition so we can add validation in a
later release.
Additionally, the Max Poll Records property of ConsumeKafka used to
internally treat the value as uint64, but in the manifest we sent a uint32
validator; I have changed the validator to be uint64 ("unsigned long"), as well.
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP- where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI
results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
