[GitHub] [nifi] levilentz commented on pull request #7677: Nifi-7355: add bytecode submission to tinkerpop service
levilentz commented on PR #7677: URL: https://github.com/apache/nifi/pull/7677#issuecomment-1714864098 > Thanks for the contribution @levilentz. Without going into the code details for now, there are two items worth highlighting for adjustment: > > 1. There are several Checkstyle warnings shown in the Static Analysis job that need to be corrected: > > > ``` > Warning: src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:[21,43] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - org.apache.nifi.annotation.behavior.*. > Warning: src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:[26,34] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - org.apache.nifi.components.*. > Warning: src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:[45,20] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - javax.script.*. > Warning: src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:[47,17] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - java.util.*. > Warning: src/test/java/org/apache/nifi/graph/TestableGremlinClientService.java:[20,8] (imports) UnusedImports: Unused import - org.apache.tinkerpop.gremlin.driver.Client. > ``` > > 2. New unit tests should use Java instead of Groovy, so the `GremlinByteCodeClientIT` class should be refactored. Thank you for the quick turn @exceptionfactory -- I have just simply removed the groovy IT tests in the most recent commit and have fixed the check style. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-11959) Jolt spec in JoltTransformJson Disallows Single Line Comments
[ https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11959. - Fix Version/s: 2.0.0 1.24.0 Resolution: Fixed > Jolt spec in JoltTransformJson Disallows Single Line Comments > - > > Key: NIFI-11959 > URL: https://issues.apache.org/jira/browse/NIFI-11959 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.23.0 >Reporter: Mahieddine Cherif >Assignee: Daniel Stieglitz >Priority: Major > Fix For: 2.0.0, 1.24.0 > > Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json > > Time Spent: 20m > Remaining Estimate: 0h > > Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt > Spec (JoltTransformJson/JoltTransformRecord processors) > This however seems something that was already supported at least the most > wide spread jolt engine [https://jolt-demo.appspot.com/#inception] > *Reproducer :* > We can easily reproduce it by simply putting a jolt with a comment using > either JoltTransformRecord or JoltTransformJson processors as both are > impacted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11959) Jolt spec in JoltTransformJson Disallows Single Line Comments
[ https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11959: Summary: Jolt spec in JoltTransformJson Disallows Single Line Comments (was: Jolt spec in JoltTransformJson processor no longer supporting text comments) > Jolt spec in JoltTransformJson Disallows Single Line Comments > - > > Key: NIFI-11959 > URL: https://issues.apache.org/jira/browse/NIFI-11959 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.23.0 >Reporter: Mahieddine Cherif >Assignee: Daniel Stieglitz >Priority: Major > Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json > > Time Spent: 20m > Remaining Estimate: 0h > > Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt > Spec (JoltTransformJson/JoltTransformRecord processors) > This however seems something that was already supported at least the most > wide spread jolt engine [https://jolt-demo.appspot.com/#inception] > *Reproducer :* > We can easily reproduce it by simply putting a jolt with a comment using > either JoltTransformRecord or JoltTransformJson processors as both are > impacted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11959) Jolt spec in JoltTransformJson processor no longer supporting text comments
[ https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763953#comment-17763953 ] ASF subversion and git services commented on NIFI-11959: Commit b468d4f5af5bdd2b0ab9bbbd6cffe97b1ad59f8f in nifi's branch refs/heads/support/nifi-1.x from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b468d4f5af ] NIFI-11959 Corrected single-line comment handling for Jolt JSON Added new lines back to the read in JSON spec to allow for single line comments to be parsed correctly and ignored. This closes #7678 Signed-off-by: David Handermann (cherry picked from commit 0280497c629538bdec8d9f06a3a68561d7a091ed) > Jolt spec in JoltTransformJson processor no longer supporting text comments > --- > > Key: NIFI-11959 > URL: https://issues.apache.org/jira/browse/NIFI-11959 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.23.0 >Reporter: Mahieddine Cherif >Assignee: Daniel Stieglitz >Priority: Major > Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json > > Time Spent: 20m > Remaining Estimate: 0h > > Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt > Spec (JoltTransformJson/JoltTransformRecord processors) > This however seems something that was already supported at least the most > wide spread jolt engine [https://jolt-demo.appspot.com/#inception] > *Reproducer :* > We can easily reproduce it by simply putting a jolt with a comment using > either JoltTransformRecord or JoltTransformJson processors as both are > impacted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11959) Jolt spec in JoltTransformJson processor no longer supporting text comments
[ https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763952#comment-17763952 ] ASF subversion and git services commented on NIFI-11959: Commit 0280497c629538bdec8d9f06a3a68561d7a091ed in nifi's branch refs/heads/main from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0280497c62 ] NIFI-11959 Corrected single-line comment handling for Jolt JSON Added new lines back to the read in JSON spec to allow for single line comments to be parsed correctly and ignored. This closes #7678 Signed-off-by: David Handermann > Jolt spec in JoltTransformJson processor no longer supporting text comments > --- > > Key: NIFI-11959 > URL: https://issues.apache.org/jira/browse/NIFI-11959 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.23.0 >Reporter: Mahieddine Cherif >Assignee: Daniel Stieglitz >Priority: Major > Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json > > Time Spent: 20m > Remaining Estimate: 0h > > Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt > Spec (JoltTransformJson/JoltTransformRecord processors) > This however seems something that was already supported at least the most > wide spread jolt engine [https://jolt-demo.appspot.com/#inception] > *Reproducer :* > We can easily reproduce it by simply putting a jolt with a comment using > either JoltTransformRecord or JoltTransformJson processors as both are > impacted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7678: NIFI-11959 Added new lines back to the read in JSON spec to allow for single line comments to be parsed correctly and ignored.
exceptionfactory closed pull request #7678: NIFI-11959 Added new lines back to the read in JSON spec to allow for single line comments to be parsed correctly and ignored. URL: https://github.com/apache/nifi/pull/7678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 opened a new pull request, #7681: NIFI-12042 Refactored unit test to Java and removed groovy-json dependency
dan-s1 opened a new pull request, #7681: URL: https://github.com/apache/nifi/pull/7681 # Summary [NIFI-12042](https://issues.apache.org/jira/browse/NIFI-12042) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2215) Ensure that unicode file paths work correctly
Marton Szasz created MINIFICPP-2215: --- Summary: Ensure that unicode file paths work correctly Key: MINIFICPP-2215 URL: https://issues.apache.org/jira/browse/MINIFICPP-2215 Project: Apache NiFi MiNiFi C++ Issue Type: Task Reporter: Marton Szasz In most parts of the code, we're assuming that strings are UTF-8 encoded. However, std::filesystem::path doesn't do encoding conversion, and it expects the input string's encoding to match the filesystem encoding. This is probably not a problem on Linux, but it may be a problem on Windows. We should check whether this is a problem in any filesystem operations, and construct `std::filesystem::path` objects from strings of char8_t to opt in to automatic conversion from UTF-8 to the filesystem encoding. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12042) Refactor Groovy unit test in nifi-mock-record-utils to Java
Daniel Stieglitz created NIFI-12042: --- Summary: Refactor Groovy unit test in nifi-mock-record-utils to Java Key: NIFI-12042 URL: https://issues.apache.org/jira/browse/NIFI-12042 Project: Apache NiFi Issue Type: Sub-task Reporter: Daniel Stieglitz Assignee: Daniel Stieglitz The single unit test is TestMockSchemaRegistry.groovy -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12041) Convert Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java
[ https://issues.apache.org/jira/browse/NIFI-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-12041: Description: The unit tests to refactor are # /nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestSimpleScriptedLookupService.groovy # ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestScriptedLookupService.groovy # ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/processors/script/ExecuteScriptGroovyTest.groovy # ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedReaderTest.groovy # ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedRecordSetWriterTest.groovy # ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/reporting/script/ScriptedReportingTaskTest.groovy was: The unit tests to refactor are /nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestSimpleScriptedLookupService.groovy ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestScriptedLookupService.groovy ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/processors/script/ExecuteScriptGroovyTest.groovy ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedReaderTest.groovy ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedRecordSetWriterTest.groovy ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/reporting/script/ScriptedReportingTaskTest.groovy > Convert Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to > Java > --- > > Key: NIFI-12041 > URL: https://issues.apache.org/jira/browse/NIFI-12041 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > > The unit tests to refactor are > # > /nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestSimpleScriptedLookupService.groovy > # > ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestScriptedLookupService.groovy > # > ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/processors/script/ExecuteScriptGroovyTest.groovy > # > ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedReaderTest.groovy > # > ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedRecordSetWriterTest.groovy > # > ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/reporting/script/ScriptedReportingTaskTest.groovy -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12041) Convert Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java
Daniel Stieglitz created NIFI-12041: --- Summary: Convert Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java Key: NIFI-12041 URL: https://issues.apache.org/jira/browse/NIFI-12041 Project: Apache NiFi Issue Type: Sub-task Reporter: Daniel Stieglitz Assignee: Daniel Stieglitz The unit tests to refactor are /nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestSimpleScriptedLookupService.groovy ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestScriptedLookupService.groovy ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/processors/script/ExecuteScriptGroovyTest.groovy ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedReaderTest.groovy ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedRecordSetWriterTest.groovy ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/reporting/script/ScriptedReportingTaskTest.groovy -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10047) Refactor Groovy Tests to Java
[ https://issues.apache.org/jira/browse/NIFI-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763919#comment-17763919 ] David Handermann commented on NIFI-10047: - Thanks for asking [~dstiegli1]. Those tests should be rewritten in Java. There are a number of Groovy scripts in src/test/resources/groovy that exercise the scripted capabilities, and those should remain in Groovy. However, for all the tests in src/test/groovy that you mentioned, those should be moved to Java. > Refactor Groovy Tests to Java > - > > Key: NIFI-10047 > URL: https://issues.apache.org/jira/browse/NIFI-10047 > Project: Apache NiFi > Issue Type: Epic > Components: Core Framework, Extensions, NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > > A number of component modules include unit tests written in Groovy, while the > majority of tests are written in Java. Although Groovy has some advantages > for testing in particular, the lack of consistency across the framework > presents several maintenance challenges. > Groovy is similar enough to Java that it is possible to read with minimal > effort, but writing idiomatic Groovy requires a greater understanding of the > language. Some unit tests have leveraged Groovy to bypass method visibility > constraints, which violates standard class and method contracts. Compiling > and running tests in Groovy requires additional Maven configuration and > plugin execution, which contributes to the overall runtime of continuous > integration workflows. Using Java as the standard language for both > implementation and tests also makes it easier for contributors to maintain > and review changes. > For these reasons, existing Groovy test classes should be rewritten in Java, > with the exception of scripting components. > Refactoring and rewriting tests should be done in logical groups of work to > avoid missing important test functions in the conversion process. Some of the > modules with larger numbers of Groovy tests include the following: > * nifi-toolkit-encrypt-config > * nifi-toolkit-admin > * nifi-registry-core > * nifi-security-utils > * nifi-elasticsearch-restapi-processors > * nifi-elasticsearch-client-service > * nifi-framework-cluster > * nifi-framework-core > * nifi-web-api > * nifi-lookup-services > * nifi-standard-processors -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12040) Upgrade Apache IoTDB to 1.2.0
[ https://issues.apache.org/jira/browse/NIFI-12040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12040: Status: Patch Available (was: Open) > Upgrade Apache IoTDB to 1.2.0 > - > > Key: NIFI-12040 > URL: https://issues.apache.org/jira/browse/NIFI-12040 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Apache IoTDB [1.2.0|https://dlcdn.apache.org/iotdb/1.2.0/RELEASE_NOTES.md] > incorporates a number of improvements and bug fixes over version 1.1.2 and > retains compatibility with Java 8 and higher. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10047) Refactor Groovy Tests to Java
[
https://issues.apache.org/jira/browse/NIFI-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763914#comment-17763914
]
Daniel Stieglitz commented on NIFI-10047:
-
[~exceptionfactory] I would also like to get clarification what you meant by
{quote}
For these reasons, existing Groovy test classes should be rewritten in Java,
with the exception of scripting components.
{quote}
Did you mean by this to exclude all the following unit tests?
#
./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestSimpleScriptedLookupService.groovy
#
./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestScriptedLookupService.groovy
#
./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/processors/script/ExecuteScriptGroovyTest.groovy
#
./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedReaderTest.groovy
#
./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedRecordSetWriterTest.groovy
#
./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/reporting/script/ScriptedReportingTaskTest.groovy
> Refactor Groovy Tests to Java
> -
>
> Key: NIFI-10047
> URL: https://issues.apache.org/jira/browse/NIFI-10047
> Project: Apache NiFi
> Issue Type: Epic
> Components: Core Framework, Extensions, NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>
> A number of component modules include unit tests written in Groovy, while the
> majority of tests are written in Java. Although Groovy has some advantages
> for testing in particular, the lack of consistency across the framework
> presents several maintenance challenges.
> Groovy is similar enough to Java that it is possible to read with minimal
> effort, but writing idiomatic Groovy requires a greater understanding of the
> language. Some unit tests have leveraged Groovy to bypass method visibility
> constraints, which violates standard class and method contracts. Compiling
> and running tests in Groovy requires additional Maven configuration and
> plugin execution, which contributes to the overall runtime of continuous
> integration workflows. Using Java as the standard language for both
> implementation and tests also makes it easier for contributors to maintain
> and review changes.
> For these reasons, existing Groovy test classes should be rewritten in Java,
> with the exception of scripting components.
> Refactoring and rewriting tests should be done in logical groups of work to
> avoid missing important test functions in the conversion process. Some of the
> modules with larger numbers of Groovy tests include the following:
> * nifi-toolkit-encrypt-config
> * nifi-toolkit-admin
> * nifi-registry-core
> * nifi-security-utils
> * nifi-elasticsearch-restapi-processors
> * nifi-elasticsearch-client-service
> * nifi-framework-cluster
> * nifi-framework-core
> * nifi-web-api
> * nifi-lookup-services
> * nifi-standard-processors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #7680: NIFI-12040 Upgrade Apache IoTDB from 1.1.2 to 1.2.0
exceptionfactory opened a new pull request, #7680: URL: https://github.com/apache/nifi/pull/7680 # Summary [NIFI-12040](https://issues.apache.org/jira/browse/NIFI-12040) Upgrades Apache IoTDB dependencies from 1.1.2 to [1.2.0](https://dlcdn.apache.org/iotdb/1.2.0/RELEASE_NOTES.md), incorporating several improvements and bug fixes, retaining compatibility with Java 8 and higher. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a diff in pull request #7667: NIFI-12022 Extract verification logic from JMSConnectionFactoryProvider
turcsanyip commented on code in PR #7667:
URL: https://github.com/apache/nifi/pull/7667#discussion_r1322042568
##
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-cf-service/src/main/java/org/apache/nifi/jms/cf/AbstractJMSConnectionFactoryProvider.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.jms.cf;
+
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.ConfigVerificationResult;
+import org.apache.nifi.components.ConfigVerificationResult.Outcome;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.controller.VerifiableControllerService;
+import org.apache.nifi.logging.ComponentLog;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.ExceptionListener;
+import javax.jms.JMSSecurityException;
+import javax.jms.Session;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
+
+/**
+ * Base JMS controller service implementation that provides verification logic.
+ */
+public abstract class AbstractJMSConnectionFactoryProvider extends
AbstractControllerService implements JMSConnectionFactoryProviderDefinition,
VerifiableControllerService {
+private static final String ESTABLISH_CONNECTION = "Establish Connection";
+private static final String VERIFY_JMS_INTERACTION = "Verify JMS
Interaction";
+
+protected volatile IJMSConnectionFactoryProvider delegate;
Review Comment:
@nandorsoma Thanks for extracting the connection verification logic to an
abstract parent class which can be used by other JMS controller services too!
However, I don't think that `IJMSConnectionFactoryProvider delegate` can be
useful for other implementors because it was created for a specific use case
(for sharing the same handler class among `JMSConnectionFactoryProvider` and
the JMS processors). So I would leave it as it is in
`JMSConnectionFactoryProvider`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-12040) Upgrade Apache IoTDB to 1.2.0
David Handermann created NIFI-12040: --- Summary: Upgrade Apache IoTDB to 1.2.0 Key: NIFI-12040 URL: https://issues.apache.org/jira/browse/NIFI-12040 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: David Handermann Assignee: David Handermann Fix For: 1.latest, 2.latest Apache IoTDB [1.2.0|https://dlcdn.apache.org/iotdb/1.2.0/RELEASE_NOTES.md] incorporates a number of improvements and bug fixes over version 1.1.2 and retains compatibility with Java 8 and higher. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10047) Refactor Groovy Tests to Java
[ https://issues.apache.org/jira/browse/NIFI-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763909#comment-17763909 ] David Handermann commented on NIFI-10047: - [~dstiegli1] The ConfigEncryptionTool class itself is also in need of refactoring, but that is beyond the scope of this test conversion. The test class is so large and involved, it may be better to address it as part of a larger rewrite effort. > Refactor Groovy Tests to Java > - > > Key: NIFI-10047 > URL: https://issues.apache.org/jira/browse/NIFI-10047 > Project: Apache NiFi > Issue Type: Epic > Components: Core Framework, Extensions, NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > > A number of component modules include unit tests written in Groovy, while the > majority of tests are written in Java. Although Groovy has some advantages > for testing in particular, the lack of consistency across the framework > presents several maintenance challenges. > Groovy is similar enough to Java that it is possible to read with minimal > effort, but writing idiomatic Groovy requires a greater understanding of the > language. Some unit tests have leveraged Groovy to bypass method visibility > constraints, which violates standard class and method contracts. Compiling > and running tests in Groovy requires additional Maven configuration and > plugin execution, which contributes to the overall runtime of continuous > integration workflows. Using Java as the standard language for both > implementation and tests also makes it easier for contributors to maintain > and review changes. > For these reasons, existing Groovy test classes should be rewritten in Java, > with the exception of scripting components. > Refactoring and rewriting tests should be done in logical groups of work to > avoid missing important test functions in the conversion process. Some of the > modules with larger numbers of Groovy tests include the following: > * nifi-toolkit-encrypt-config > * nifi-toolkit-admin > * nifi-registry-core > * nifi-security-utils > * nifi-elasticsearch-restapi-processors > * nifi-elasticsearch-client-service > * nifi-framework-cluster > * nifi-framework-core > * nifi-web-api > * nifi-lookup-services > * nifi-standard-processors -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12039) Upgrade Apache Commons DBCP to 2.10.0
[ https://issues.apache.org/jira/browse/NIFI-12039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12039: Status: Patch Available (was: Open) > Upgrade Apache Commons DBCP to 2.10.0 > - > > Key: NIFI-12039 > URL: https://issues.apache.org/jira/browse/NIFI-12039 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Apache Commons DBCP > [2.10.0|https://commons.apache.org/proper/commons-dbcp/changes-report.html#a2.10.0] > includes a number of incremental bug fixes and performance improvements over > version 2.9.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #7679: NIFI-12039 Upgrade Apache Commons DBCP from 2.9.0 to 2.10.0
exceptionfactory opened a new pull request, #7679: URL: https://github.com/apache/nifi/pull/7679 # Summary [NIFI-12039](https://issues.apache.org/jira/browse/NIFI-12039) Upgrades Apache Commons DBCP from 2.9.0 to [2.10.0](https://commons.apache.org/proper/commons-dbcp/changes-report.html#a2.10.0) incorporating incremental bug fixes and improvements for components such as DBCPConnectionPool. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (NIFI-10047) Refactor Groovy Tests to Java
[
https://issues.apache.org/jira/browse/NIFI-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763898#comment-17763898
]
Daniel Stieglitz edited comment on NIFI-10047 at 9/11/23 7:59 PM:
--
[~exceptionfactory] It seems the main class in nifi-toolkit-encrypt-config is
{code:java}
ConfigEncryptionTool.groovy{code}
which is already Groovy itself. Would it's corresponding unit test
{code:java}
ConfigEncryptionToolTest.groovy{code}
have to be refactored to Java? I noticed there are many cases in that unit test
where access to properties are exceeding its rights. It would necessitate many
changes to give properties private package scope. I know this was an issue when
working NIFI-11873. Please advise. Thanks!
was (Author: JIRAUSER294662):
[~exceptionfactory] It seems the main class in nifi-toolkit-encrypt-config is
{code:java}
ConfigEncryptionTool.groovy{code}
which is already Groovy itself. Would it's corresponding unit test
{code:java}
ConfigEncryptionToolTest.groovy{code}
have to be refactored to Java? I noticed there are many cases in that unit test
where access to properties are exceeding its rights. It would necessitate many
changes to give properties private package scope. I know this was an issue when
working NIFI-11873. Please advise. Thanks!
> Refactor Groovy Tests to Java
> -
>
> Key: NIFI-10047
> URL: https://issues.apache.org/jira/browse/NIFI-10047
> Project: Apache NiFi
> Issue Type: Epic
> Components: Core Framework, Extensions, NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>
> A number of component modules include unit tests written in Groovy, while the
> majority of tests are written in Java. Although Groovy has some advantages
> for testing in particular, the lack of consistency across the framework
> presents several maintenance challenges.
> Groovy is similar enough to Java that it is possible to read with minimal
> effort, but writing idiomatic Groovy requires a greater understanding of the
> language. Some unit tests have leveraged Groovy to bypass method visibility
> constraints, which violates standard class and method contracts. Compiling
> and running tests in Groovy requires additional Maven configuration and
> plugin execution, which contributes to the overall runtime of continuous
> integration workflows. Using Java as the standard language for both
> implementation and tests also makes it easier for contributors to maintain
> and review changes.
> For these reasons, existing Groovy test classes should be rewritten in Java,
> with the exception of scripting components.
> Refactoring and rewriting tests should be done in logical groups of work to
> avoid missing important test functions in the conversion process. Some of the
> modules with larger numbers of Groovy tests include the following:
> * nifi-toolkit-encrypt-config
> * nifi-toolkit-admin
> * nifi-registry-core
> * nifi-security-utils
> * nifi-elasticsearch-restapi-processors
> * nifi-elasticsearch-client-service
> * nifi-framework-cluster
> * nifi-framework-core
> * nifi-web-api
> * nifi-lookup-services
> * nifi-standard-processors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12039) Upgrade Apache Commons DBCP to 2.10.0
David Handermann created NIFI-12039: --- Summary: Upgrade Apache Commons DBCP to 2.10.0 Key: NIFI-12039 URL: https://issues.apache.org/jira/browse/NIFI-12039 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: David Handermann Assignee: David Handermann Fix For: 1.latest, 2.latest Apache Commons DBCP [2.10.0|https://commons.apache.org/proper/commons-dbcp/changes-report.html#a2.10.0] includes a number of incremental bug fixes and performance improvements over version 2.9.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10047) Refactor Groovy Tests to Java
[
https://issues.apache.org/jira/browse/NIFI-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763898#comment-17763898
]
Daniel Stieglitz commented on NIFI-10047:
-
[~exceptionfactory] It seems the main class in nifi-toolkit-encrypt-config is
{code:java}
ConfigEncryptionTool.groovy{code}
which is already Groovy itself. Would it's corresponding unit test
{code:java}
ConfigEncryptionToolTest.groovy{code}
have to be refactored to Java? I noticed there are many cases in that unit test
where access to properties are exceeding its rights. It would necessitate many
changes to give properties private package scope. I know this was an issue when
working NIFI-11873. Please advise. Thanks!
> Refactor Groovy Tests to Java
> -
>
> Key: NIFI-10047
> URL: https://issues.apache.org/jira/browse/NIFI-10047
> Project: Apache NiFi
> Issue Type: Epic
> Components: Core Framework, Extensions, NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>
> A number of component modules include unit tests written in Groovy, while the
> majority of tests are written in Java. Although Groovy has some advantages
> for testing in particular, the lack of consistency across the framework
> presents several maintenance challenges.
> Groovy is similar enough to Java that it is possible to read with minimal
> effort, but writing idiomatic Groovy requires a greater understanding of the
> language. Some unit tests have leveraged Groovy to bypass method visibility
> constraints, which violates standard class and method contracts. Compiling
> and running tests in Groovy requires additional Maven configuration and
> plugin execution, which contributes to the overall runtime of continuous
> integration workflows. Using Java as the standard language for both
> implementation and tests also makes it easier for contributors to maintain
> and review changes.
> For these reasons, existing Groovy test classes should be rewritten in Java,
> with the exception of scripting components.
> Refactoring and rewriting tests should be done in logical groups of work to
> avoid missing important test functions in the conversion process. Some of the
> modules with larger numbers of Groovy tests include the following:
> * nifi-toolkit-encrypt-config
> * nifi-toolkit-admin
> * nifi-registry-core
> * nifi-security-utils
> * nifi-elasticsearch-restapi-processors
> * nifi-elasticsearch-client-service
> * nifi-framework-cluster
> * nifi-framework-core
> * nifi-web-api
> * nifi-lookup-services
> * nifi-standard-processors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12010) Handle auto-commit and commit based on driver capabilities in SQL components
[ https://issues.apache.org/jira/browse/NIFI-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763896#comment-17763896 ] ASF subversion and git services commented on NIFI-12010: Commit af8128bb5c26e418d31ec38741648dd87607c33b in nifi's branch refs/heads/support/nifi-1.x from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=af8128bb5c ] NIFI-12010: Handle auto-commit and commit based on driver capabilities in SQL components Signed-off-by: Arpad Boda This closes #7663 > Handle auto-commit and commit based on driver capabilities in SQL components > > > Key: NIFI-12010 > URL: https://issues.apache.org/jira/browse/NIFI-12010 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Some JDBC drivers throw an exception when calling setAutoCommit(false), even > if the auto-commit setting for the driver is already false. Although > unfortunate, I'm not sure it is a violation of the JDBC API. The SQL > components in NiFi that use the JDBC API should catch > SQLFeatureNotSupportedException and perhaps log a debug message but otherwise > proceed. > Same goes for connection.commit() and connection.rollback(), these should not > be explicitly called if auto-commit is true for the connection. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12006) Remove Templates from Framework and UI
[ https://issues.apache.org/jira/browse/NIFI-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12006: Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Remove Templates from Framework and UI > -- > > Key: NIFI-12006 > URL: https://issues.apache.org/jira/browse/NIFI-12006 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Core UI >Reporter: Timea Barna >Assignee: Timea Barna >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Remove Templates from Framework and UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12006) Remove Templates from Framework and UI
[ https://issues.apache.org/jira/browse/NIFI-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12006: Epic Link: NIFI-11172 Description: Remove Templates from Framework and UI. (was: Remove Templates from backend) > Remove Templates from Framework and UI > -- > > Key: NIFI-12006 > URL: https://issues.apache.org/jira/browse/NIFI-12006 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Core UI >Reporter: Timea Barna >Assignee: Timea Barna >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Remove Templates from Framework and UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12006) Remove Templates from nifi 2.0
[ https://issues.apache.org/jira/browse/NIFI-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763894#comment-17763894 ] ASF subversion and git services commented on NIFI-12006: Commit c30fd9b66d34fecf20dde1b65c9ef0dae844eef9 in nifi's branch refs/heads/main from Timea Barna [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c30fd9b66d ] NIFI-12006 Removed Templates from Framework and UI This closes #7658 Signed-off-by: David Handermann > Remove Templates from nifi 2.0 > -- > > Key: NIFI-12006 > URL: https://issues.apache.org/jira/browse/NIFI-12006 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Timea Barna >Assignee: Timea Barna >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Remove Templates from backend -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12006) Remove Templates from Framework and UI
[ https://issues.apache.org/jira/browse/NIFI-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12006: Component/s: Core Framework Core UI > Remove Templates from Framework and UI > -- > > Key: NIFI-12006 > URL: https://issues.apache.org/jira/browse/NIFI-12006 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Core UI >Reporter: Timea Barna >Assignee: Timea Barna >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Remove Templates from backend -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12006) Remove Templates from Framework and UI
[ https://issues.apache.org/jira/browse/NIFI-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12006: Summary: Remove Templates from Framework and UI (was: Remove Templates from nifi 2.0) > Remove Templates from Framework and UI > -- > > Key: NIFI-12006 > URL: https://issues.apache.org/jira/browse/NIFI-12006 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Timea Barna >Assignee: Timea Barna >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Remove Templates from backend -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12037) AzureGraphUserGroupProvider does not work with regional Azure instances
[ https://issues.apache.org/jira/browse/NIFI-12037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin updated NIFI-12037: -- Description: When configuring the AzureGraphUserGroupProvider for clouds other than the Azure global service cloud ([https://learn.microsoft.com/en-us/azure/active-directory/develop/authentication-national-cloud)] all of the necessary endpoints are not updated so the graph endpoint stays as graph.microsoft.com instead of using the associated endpoint for the regional clouds. To keep implementation simple the graph endpoint and scope in "ClientCredentialAuthProvider.java" and "AzureGraphUserGroupProvider.java" from the nifi-azure-bundle can be exposed to the configuration file, keeping the current defaults, but allowing them to be changed when necessary. PR: https://github.com/apache/nifi/pull/7675 was:When configuring the AzureGraphUserGroupProvider for clouds other than the Azure global service cloud ([https://learn.microsoft.com/en-us/azure/active-directory/develop/authentication-national-cloud)] all of the necessary endpoints are not updated so the graph endpoint stays as graph.microsoft.com instead of using the associated endpoint for the regional clouds. To keep implementation simple the graph endpoint and scope in "ClientCredentialAuthProvider.java" and "AzureGraphUserGroupProvider.java" from the nifi-azure-bundle can be exposed to the configuration file, keeping the current defaults, but allowing them to be changed when necessary. > AzureGraphUserGroupProvider does not work with regional Azure instances > --- > > Key: NIFI-12037 > URL: https://issues.apache.org/jira/browse/NIFI-12037 > Project: Apache NiFi > Issue Type: Bug >Reporter: Justin >Priority: Blocker > Labels: authorization, azure > > When configuring the AzureGraphUserGroupProvider for clouds other than the > Azure global service cloud > ([https://learn.microsoft.com/en-us/azure/active-directory/develop/authentication-national-cloud)] > all of the necessary endpoints are not updated so the graph endpoint stays > as graph.microsoft.com instead of using the associated endpoint for the > regional clouds. To keep implementation simple the graph endpoint and scope > in "ClientCredentialAuthProvider.java" and "AzureGraphUserGroupProvider.java" > from the nifi-azure-bundle can be exposed to the configuration file, keeping > the current defaults, but allowing them to be changed when necessary. > PR: https://github.com/apache/nifi/pull/7675 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] dan-s1 opened a new pull request, #7678: NIFI-11959 Added new lines back to the read in JSON spec to allow for single line comments to be parsed correctly and ignored.
dan-s1 opened a new pull request, #7678: URL: https://github.com/apache/nifi/pull/7678 # Summary [NIFI-11959](https://issues.apache.org/jira/browse/NIFI-11959) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12038) Create processor to package FlowFiles
[ https://issues.apache.org/jira/browse/NIFI-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763883#comment-17763883 ] Michael W Moser commented on NIFI-12038: This was discussed a bit on Apache NiFi Slack channel [https://apachenifi.slack.com/archives/C0L9S92JY/p1692115270146369] > Create processor to package FlowFiles > - > > Key: NIFI-12038 > URL: https://issues.apache.org/jira/browse/NIFI-12038 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Michael W Moser >Assignee: Michael W Moser >Priority: Minor > > h4. Design Goals > Provide a simple way to package FlowFile attributes and content into > FlowFileV3 format that can be exported from NiFi and reimported later. > MergeContent can do this, but it is not intuitive that it has this > capability, and it can be complicated to setup perfectly. > h4. Use Cases > * Package FlowFile for external (off-NiFi) storage, for later ingest back > into NiFi using an ingress processor followed by UnpackContent > * Package FlowFile for NiFi-to-NiFi transfer when a direct connection is not > possible, or another transfer mechanism is required > * Package FlowFile then InvokeHTTP directly to another NiFi running > ListenHTTP, which can natively unpack FlowFileV3 format > h4. Other Ideas > * Offer best-effort, no guarantee N FlowFiles to 1 bundling > * Create new FlowFile serialization format to support interoperability with > non-NiFi services, such as core operating system tools -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11959) Jolt spec in JoltTransformJson processor no longer supporting text comments
[ https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763881#comment-17763881 ] David Handermann commented on NIFI-11959: - [~dstiegli1] Thanks for investigating this issue. Inserting the newlines back as you suggested sounds like a good approach. > Jolt spec in JoltTransformJson processor no longer supporting text comments > --- > > Key: NIFI-11959 > URL: https://issues.apache.org/jira/browse/NIFI-11959 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.23.0 >Reporter: Mahieddine Cherif >Assignee: Daniel Stieglitz >Priority: Major > Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json > > > Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt > Spec (JoltTransformJson/JoltTransformRecord processors) > This however seems something that was already supported at least the most > wide spread jolt engine [https://jolt-demo.appspot.com/#inception] > *Reproducer :* > We can easily reproduce it by simply putting a jolt with a comment using > either JoltTransformRecord or JoltTransformJson processors as both are > impacted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11959) Jolt spec in JoltTransformJson processor no longer supporting text comments
[
https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763770#comment-17763770
]
Daniel Stieglitz edited comment on NIFI-11959 at 9/11/23 6:35 PM:
--
[~mattyb149] I was able to trace this bug to code you had added for NIFI-4957
lines 488-495 in JoltTransformRecord and lines 396-402 in JoltTransformJSON
{code:java}
private String readTransform(final PropertyValue propertyValue) {
final ResourceReference resourceReference = propertyValue.asResource();
try (final BufferedReader reader = new BufferedReader(new
InputStreamReader(resourceReference.read( {
return reader.lines().collect(Collectors.joining());
} catch (final IOException e) {
throw new UncheckedIOException("Read JOLT Transform failed", e);
}
}{code}
Per [this article|https://www.baeldung.com/convert-input-stream-to-string]
'reader.lines()' uses readLine underneath the hood which thereby strips the new
lines. For single line comments ('//') that seems to prevent the JSON from
being parsed even if the parser is set to ignore comments. Multiline comments
('/**/') are unaffected. The fix for this would be to reinsert the new lines
with
{code:java}
return reader.lines().collect(Collectors.joining(System.lineSeparator()));{code}
I just wanted to double check with you first if there was any other reason not
to have the new lines in the spec. Please advise. Thanks!
was (Author: JIRAUSER294662):
[~mattyb149] I was able to trace this bug to code you had added for NIFI-4957
lines 488-495 in JoltTransformRecord and lines 396-402 in JoltTransformJSON
{code:java}
private String readTransform(final PropertyValue propertyValue) {
final ResourceReference resourceReference = propertyValue.asResource();
try (final BufferedReader reader = new BufferedReader(new
InputStreamReader(resourceReference.read( {
return reader.lines().collect(Collectors.joining());
} catch (final IOException e) {
throw new UncheckedIOException("Read JOLT Transform failed", e);
}
}{code}
Per [this article|https://www.baeldung.com/convert-input-stream-to-string]
'reader.lines()' uses readLine underneath the hood which thereby strips the new
lines. For single line comments ('//') that seems to prevent the JSON from
being parsed even if the parser is set to ignore comments. Multiline comments
('/**/') are unaffected. The fix for this would to reinsert the new lines with
{code:java}
return reader.lines().collect(Collectors.joining(System.lineSeparator()));{code}
I just wanted to double check with you first if there was any other reason not
to have the new lines in the spec. Please advise. Thanks!
> Jolt spec in JoltTransformJson processor no longer supporting text comments
> ---
>
> Key: NIFI-11959
> URL: https://issues.apache.org/jira/browse/NIFI-11959
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.23.0
>Reporter: Mahieddine Cherif
>Assignee: Daniel Stieglitz
>Priority: Major
> Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json
>
>
> Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt
> Spec (JoltTransformJson/JoltTransformRecord processors)
> This however seems something that was already supported at least the most
> wide spread jolt engine [https://jolt-demo.appspot.com/#inception]
> *Reproducer :*
> We can easily reproduce it by simply putting a jolt with a comment using
> either JoltTransformRecord or JoltTransformJson processors as both are
> impacted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12038) Create processor to package FlowFiles
[ https://issues.apache.org/jira/browse/NIFI-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael W Moser updated NIFI-12038: --- Description: h4. Design Goals Provide a simple way to package FlowFile attributes and content into FlowFileV3 format that can be exported from NiFi and reimported later. MergeContent can do this, but it is not intuitive that it has this capability, and it can be complicated to setup perfectly. h4. Use Cases * Package FlowFile for external (off-NiFi) storage, for later ingest back into NiFi using an ingress processor followed by UnpackContent * Package FlowFile for NiFi-to-NiFi transfer when a direct connection is not possible, or another transfer mechanism is required * Package FlowFile then InvokeHTTP directly to another NiFi running ListenHTTP, which can natively unpack FlowFileV3 format h4. Other Ideas * Offer best-effort, no guarantee N FlowFiles to 1 bundling * Create new FlowFile serialization format to support interoperability with non-NiFi services, such as core operating system tools was: h4. Design Goals Provide a simple way to package FlowFile attributes and content into FlowFileV3 format that can be exported from NiFi and reimported later. MergeContent can do this, but it is not intuitive that it has this capability, and it can be complicated to setup perfectly. h4. Use Cases * Package FlowFiles for external (off-NiFi) storage, for later ingest back into NiFi using UnpackContent * Package FlowFiles for NiFi-to-NiFi transfer when a direct connection is not possible, or another transfer mechanism is required * Package FlowFile then InvokeHTTP directly to another NiFi running ListenHTTP, which can natively unpack FlowFileV3 format h4. Other Ideas * Offer best-effort, no guarantee N FlowFiles to 1 bundling * Create new FlowFile serialization format to support interoperability with non-NiFi services, such as core operating system tools > Create processor to package FlowFiles > - > > Key: NIFI-12038 > URL: https://issues.apache.org/jira/browse/NIFI-12038 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Michael W Moser >Assignee: Michael W Moser >Priority: Minor > > h4. Design Goals > Provide a simple way to package FlowFile attributes and content into > FlowFileV3 format that can be exported from NiFi and reimported later. > MergeContent can do this, but it is not intuitive that it has this > capability, and it can be complicated to setup perfectly. > h4. Use Cases > * Package FlowFile for external (off-NiFi) storage, for later ingest back > into NiFi using an ingress processor followed by UnpackContent > * Package FlowFile for NiFi-to-NiFi transfer when a direct connection is not > possible, or another transfer mechanism is required > * Package FlowFile then InvokeHTTP directly to another NiFi running > ListenHTTP, which can natively unpack FlowFileV3 format > h4. Other Ideas > * Offer best-effort, no guarantee N FlowFiles to 1 bundling > * Create new FlowFile serialization format to support interoperability with > non-NiFi services, such as core operating system tools -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763836#comment-17763836
]
Chuck Tilly commented on NIFI-11627:
This seems like an anti-pattern since the prescribed way of performing
validation in NiFi is through the use of a schema registry. Using a hack like
the Jolt spec is undocumented, and inconsistent with best practices for data
validation in NiFi.
> Add Dynamic Schema References to ValidateJSON Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7660: NIFI-12011: Add optional MIME Type property to ExecuteStreamCommand and ExecuteProcess
exceptionfactory commented on code in PR #7660:
URL: https://github.com/apache/nifi/pull/7660#discussion_r1321829199
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteProcess.java:
##
@@ -146,6 +148,13 @@ public class ExecuteProcess extends AbstractProcessor {
.defaultValue(" ")
.build();
+static final PropertyDescriptor MIME_TYPE = new
PropertyDescriptor.Builder()
+.name("mime-type")
+.displayName("Mime Type")
Review Comment:
Recommend naming this `Output MIME Type` for clarity, also recommend using
the same value for `name` following the pattern of existing properties in this
class:
```suggestion
static final PropertyDescriptor OUTPUT_MIME_TYPE = new
PropertyDescriptor.Builder()
.name("Output MIME Type")
.displayName("Output MIME Type")
```
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteProcess.java:
##
@@ -290,15 +302,20 @@ public void process(final OutputStream flowFileOut)
throws IOException {
session.remove(flowFile);
getLogger().error("Failed to read data from Process, so will not
generate FlowFile");
} else {
-// add command and arguments as attribute
-flowFile = session.putAttribute(flowFile, ATTRIBUTE_COMMAND,
command);
+// add command, arguments, and MIME type as attributes
+HashMap attributes = new HashMap<>();
Review Comment:
The declared variable type should use the `Map` interface:
```suggestion
final Map attributes = new HashMap<>();
```
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java:
##
@@ -274,6 +276,14 @@ public class ExecuteStreamCommand extends
AbstractProcessor {
.defaultValue("256")
.build();
+static final PropertyDescriptor MIME_TYPE = new
PropertyDescriptor.Builder()
+.name("mime-type")
+.displayName("Mime Type")
Review Comment:
```suggestion
static final PropertyDescriptor OUTPUT_MIME_TYPE = new
PropertyDescriptor.Builder()
.name("Output MIME Type")
.displayName("Output MIME Type")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-7243) SFTP Processors - Exhausted available authentication methods
[ https://issues.apache.org/jira/browse/NIFI-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763820#comment-17763820 ] David Handermann commented on NIFI-7243: [~pammya] As this Jira issue is closed, I recommend creating a new issue and providing as much detail as possible in terms of Processor configuration and debug log output. The error indicating exhausted authentication methods is fairly generic, so it is important to know the type of authentication (passwords or public key), as well as the SFTP server vendor and version. > SFTP Processors - Exhausted available authentication methods > > > Key: NIFI-7243 > URL: https://issues.apache.org/jira/browse/NIFI-7243 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.10.0, 1.11.0, 1.11.1, 1.11.3 > Environment: PRO >Reporter: Raúl >Assignee: David Handermann >Priority: Critical > Labels: SFTP, listsftp > Fix For: 1.13.0 > > Attachments: Screen Shot 2020-05-07 at 5.28.29 PM.png > > Time Spent: 1h > Remaining Estimate: 0h > > In version 1.8 this works correctly. In superiors no. > > Any of the processors: ListSFTP, FetchSFTP, GetSFTP, PutSFTP when connecting > to an sftp shows the error: > 2020-03-10 15:12:51,596 ERROR [Timer-Driven Process Thread-3] > o.a.nifi.processors.standard.ListSFTP > ListSFTP[id=af72555e-0170-1000-c80d-7e992c9de544] Failed to perform listing > on remote host due to Exhausted available authentication methods: > net.schmizz.sshj.userauth.UserAuthException: Exhausted available > authentication methods > net.schmizz.sshj.userauth.UserAuthException: Exhausted available > authentication methods > at net.schmizz.sshj.SSHClient.auth(SSHClient.java:230) > > These tests that I commented have been made from nifi, both in windows and > linux environment and fails in both. > 1 - Strict Host Key Checking: false > 2 - Strict Host Key Checking: true > Host Key File: C:\Users\usuario\.ssh\known_hosts --> (ssh-rsa, > ssh-dss and ecdsa-sha2-nistp256) > > From the machines, both in windows and in linux, if an sftp is made from the > command line it connects without problems. But with Nifi he fails to connect. > > Any idea about how can I resolve this error? > > Thank you in advance, > log > - > 2020-03-10 15:12:51,596 ERROR [Timer-Driven Process Thread-3] > o.a.nifi.processors.standard.ListSFTP > ListSFTP[id=af72555e-0170-1000-c80d-7e992c9de544] Failed to perform listing > on remote host due to Exhausted available authentication methods: > net.schmizz.sshj.userauth.UserAuthException: Exhausted available > authentication methods2020-03-10 15:12:51,596 ERROR [Timer-Driven Process > Thread-3] o.a.nifi.processors.standard.ListSFTP > ListSFTP[id=af72555e-0170-1000-c80d-7e992c9de544] Failed to perform listing > on remote host due to Exhausted available authentication methods: > net.schmizz.sshj.userauth.UserAuthException: Exhausted available > authentication methodsnet.schmizz.sshj.userauth.UserAuthException: Exhausted > available authentication methods at > net.schmizz.sshj.SSHClient.auth(SSHClient.java:230) at > org.apache.nifi.processors.standard.util.SFTPTransfer.getSFTPClient(SFTPTransfer.java:606) > at > org.apache.nifi.processors.standard.util.SFTPTransfer.getListing(SFTPTransfer.java:233) > at > org.apache.nifi.processors.standard.util.SFTPTransfer.getListing(SFTPTransfer.java:196) > at > org.apache.nifi.processors.standard.ListFileTransfer.performListing(ListFileTransfer.java:106) > at > org.apache.nifi.processors.standard.ListSFTP.performListing(ListSFTP.java:146) > at > org.apache.nifi.processor.util.list.AbstractListProcessor.listByTrackingTimestamps(AbstractListProcessor.java:472) > at > org.apache.nifi.processor.util.list.AbstractListProcessor.onTrigger(AbstractListProcessor.java:414) > at > org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27) > at > org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1176) > at > org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:213) > at > org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:117) > at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110) at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) > at >
[jira] [Commented] (NIFI-7243) SFTP Processors - Exhausted available authentication methods
[ https://issues.apache.org/jira/browse/NIFI-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763809#comment-17763809 ] Pramod commented on NIFI-7243: -- I am using 1.19.1 version, and I am still facing the same issue. help needed here please. > SFTP Processors - Exhausted available authentication methods > > > Key: NIFI-7243 > URL: https://issues.apache.org/jira/browse/NIFI-7243 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.10.0, 1.11.0, 1.11.1, 1.11.3 > Environment: PRO >Reporter: Raúl >Assignee: David Handermann >Priority: Critical > Labels: SFTP, listsftp > Fix For: 1.13.0 > > Attachments: Screen Shot 2020-05-07 at 5.28.29 PM.png > > Time Spent: 1h > Remaining Estimate: 0h > > In version 1.8 this works correctly. In superiors no. > > Any of the processors: ListSFTP, FetchSFTP, GetSFTP, PutSFTP when connecting > to an sftp shows the error: > 2020-03-10 15:12:51,596 ERROR [Timer-Driven Process Thread-3] > o.a.nifi.processors.standard.ListSFTP > ListSFTP[id=af72555e-0170-1000-c80d-7e992c9de544] Failed to perform listing > on remote host due to Exhausted available authentication methods: > net.schmizz.sshj.userauth.UserAuthException: Exhausted available > authentication methods > net.schmizz.sshj.userauth.UserAuthException: Exhausted available > authentication methods > at net.schmizz.sshj.SSHClient.auth(SSHClient.java:230) > > These tests that I commented have been made from nifi, both in windows and > linux environment and fails in both. > 1 - Strict Host Key Checking: false > 2 - Strict Host Key Checking: true > Host Key File: C:\Users\usuario\.ssh\known_hosts --> (ssh-rsa, > ssh-dss and ecdsa-sha2-nistp256) > > From the machines, both in windows and in linux, if an sftp is made from the > command line it connects without problems. But with Nifi he fails to connect. > > Any idea about how can I resolve this error? > > Thank you in advance, > log > - > 2020-03-10 15:12:51,596 ERROR [Timer-Driven Process Thread-3] > o.a.nifi.processors.standard.ListSFTP > ListSFTP[id=af72555e-0170-1000-c80d-7e992c9de544] Failed to perform listing > on remote host due to Exhausted available authentication methods: > net.schmizz.sshj.userauth.UserAuthException: Exhausted available > authentication methods2020-03-10 15:12:51,596 ERROR [Timer-Driven Process > Thread-3] o.a.nifi.processors.standard.ListSFTP > ListSFTP[id=af72555e-0170-1000-c80d-7e992c9de544] Failed to perform listing > on remote host due to Exhausted available authentication methods: > net.schmizz.sshj.userauth.UserAuthException: Exhausted available > authentication methodsnet.schmizz.sshj.userauth.UserAuthException: Exhausted > available authentication methods at > net.schmizz.sshj.SSHClient.auth(SSHClient.java:230) at > org.apache.nifi.processors.standard.util.SFTPTransfer.getSFTPClient(SFTPTransfer.java:606) > at > org.apache.nifi.processors.standard.util.SFTPTransfer.getListing(SFTPTransfer.java:233) > at > org.apache.nifi.processors.standard.util.SFTPTransfer.getListing(SFTPTransfer.java:196) > at > org.apache.nifi.processors.standard.ListFileTransfer.performListing(ListFileTransfer.java:106) > at > org.apache.nifi.processors.standard.ListSFTP.performListing(ListSFTP.java:146) > at > org.apache.nifi.processor.util.list.AbstractListProcessor.listByTrackingTimestamps(AbstractListProcessor.java:472) > at > org.apache.nifi.processor.util.list.AbstractListProcessor.onTrigger(AbstractListProcessor.java:414) > at > org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27) > at > org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1176) > at > org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:213) > at > org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:117) > at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110) at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at > java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748)2020-03-10 15:12:51,601
[jira] [Commented] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763804#comment-17763804
]
Daniel Stieglitz commented on NIFI-11627:
-
JoltTransformJSON with the changes in NIFI-4957 is a good example of a
processor which supports both the use of flowfile attributes and resources for
Json (in that case the Jolt spec).
> Add Dynamic Schema References to ValidateJSON Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12038) Create processor to package FlowFiles
Michael W Moser created NIFI-12038: -- Summary: Create processor to package FlowFiles Key: NIFI-12038 URL: https://issues.apache.org/jira/browse/NIFI-12038 Project: Apache NiFi Issue Type: New Feature Components: Extensions Reporter: Michael W Moser Assignee: Michael W Moser h4. Design Goals Provide a simple way to package FlowFile attributes and content into FlowFileV3 format that can be exported from NiFi and reimported later. MergeContent can do this, but it is not intuitive that it has this capability, and it can be complicated to setup perfectly. h4. Use Cases * Package FlowFiles for external (off-NiFi) storage, for later ingest back into NiFi using UnpackContent * Package FlowFiles for NiFi-to-NiFi transfer when a direct connection is not possible, or another transfer mechanism is required * Package FlowFile then InvokeHTTP directly to another NiFi running ListenHTTP, which can natively unpack FlowFileV3 format h4. Other Ideas * Offer best-effort, no guarantee N FlowFiles to 1 bundling * Create new FlowFile serialization format to support interoperability with non-NiFi services, such as core operating system tools -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz reassigned NIFI-11627:
---
Assignee: Daniel Stieglitz
> Add Dynamic Schema References to ValidateJSON Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12037) AzureGraphUserGroupProvider does not work with regional Azure instances
Justin created NIFI-12037: - Summary: AzureGraphUserGroupProvider does not work with regional Azure instances Key: NIFI-12037 URL: https://issues.apache.org/jira/browse/NIFI-12037 Project: Apache NiFi Issue Type: Bug Reporter: Justin When configuring the AzureGraphUserGroupProvider for clouds other than the Azure global service cloud ([https://learn.microsoft.com/en-us/azure/active-directory/develop/authentication-national-cloud)] all of the necessary endpoints are not updated so the graph endpoint stays as graph.microsoft.com instead of using the associated endpoint for the regional clouds. To keep implementation simple the graph endpoint and scope in "ClientCredentialAuthProvider.java" and "AzureGraphUserGroupProvider.java" from the nifi-azure-bundle can be exposed to the configuration file, keeping the current defaults, but allowing them to be changed when necessary. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11959) Jolt spec in JoltTransformJson processor no longer supporting text comments
[
https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763770#comment-17763770
]
Daniel Stieglitz edited comment on NIFI-11959 at 9/11/23 3:29 PM:
--
[~mattyb149] I was able to trace this bug to code you had added for NIFI-4957
lines 488-495 in JoltTransformRecord and lines 396-402 in JoltTransformJSON
{code:java}
private String readTransform(final PropertyValue propertyValue) {
final ResourceReference resourceReference = propertyValue.asResource();
try (final BufferedReader reader = new BufferedReader(new
InputStreamReader(resourceReference.read( {
return reader.lines().collect(Collectors.joining());
} catch (final IOException e) {
throw new UncheckedIOException("Read JOLT Transform failed", e);
}
}{code}
Per [this article|https://www.baeldung.com/convert-input-stream-to-string]
'reader.lines()' uses readLine underneath the hood which thereby strips the new
lines. For single line comments ('//') that seems to prevent the JSON from
being parsed even if the parser is set to ignore comments. Multiline comments
('/**/') are unaffected. The fix for this would to reinsert the new lines with
{code:java}
return reader.lines().collect(Collectors.joining(System.lineSeparator()));{code}
I just wanted to double check with you first if there was any other reason not
to have the new lines in the spec. Please advise. Thanks!
was (Author: JIRAUSER294662):
[~mattyb149] I was able to trace this bug to code you had added for NIFI-4957
lines 488-495 in JoltTransformRecord and lines 396-402 in JoltTransformJSON
{code:java}
private String readTransform(final PropertyValue propertyValue) {
final ResourceReference resourceReference = propertyValue.asResource();
try (final BufferedReader reader = new BufferedReader(new
InputStreamReader(resourceReference.read( {
return reader.lines().collect(Collectors.joining());
} catch (final IOException e) {
throw new UncheckedIOException("Read JOLT Transform failed", e);
}
}{code}
Per [this article|https://www.baeldung.com/convert-input-stream-to-string]
lines uses readLine underneath the hood which thereby strips the new lines. For
single line comments ('//') that seems to prevent the JSON from being parsed
even if the parser is set to ignore comments. Multiline comments ('/**/') are
unaffected. The fix for this would to reinsert the new lines with
{code:java}
return reader.lines().collect(Collectors.joining(System.lineSeparator()));{code}
I just wanted to double check with you first if there was any other reason not
to have the new lines in the spec. Please advise. Thanks!
> Jolt spec in JoltTransformJson processor no longer supporting text comments
> ---
>
> Key: NIFI-11959
> URL: https://issues.apache.org/jira/browse/NIFI-11959
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.23.0
>Reporter: Mahieddine Cherif
>Assignee: Daniel Stieglitz
>Priority: Major
> Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json
>
>
> Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt
> Spec (JoltTransformJson/JoltTransformRecord processors)
> This however seems something that was already supported at least the most
> wide spread jolt engine [https://jolt-demo.appspot.com/#inception]
> *Reproducer :*
> We can easily reproduce it by simply putting a jolt with a comment using
> either JoltTransformRecord or JoltTransformJson processors as both are
> impacted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11959) Jolt spec in JoltTransformJson processor no longer supporting text comments
[
https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763770#comment-17763770
]
Daniel Stieglitz commented on NIFI-11959:
-
[~mattyb149] I was able to trace this bug to code you had added for NIFI-4957
lines 488-495 in JoltTransformRecord and lines 396-402 in JoltTransformJSON
{code:java}
private String readTransform(final PropertyValue propertyValue) {
final ResourceReference resourceReference = propertyValue.asResource();
try (final BufferedReader reader = new BufferedReader(new
InputStreamReader(resourceReference.read( {
return reader.lines().collect(Collectors.joining());
} catch (final IOException e) {
throw new UncheckedIOException("Read JOLT Transform failed", e);
}
}{code}
Per [this article|https://www.baeldung.com/convert-input-stream-to-string]
lines uses readLine underneath the hood which thereby strips the new lines. For
single line comments ('//') that seems to prevent the JSON from being parsed
even if the parser is set to ignore comments. Multiline comments ('/**/') are
unaffected. The fix for this would to reinsert the new lines with
{code:java}
return reader.lines().collect(Collectors.joining(System.lineSeparator()));{code}
I just wanted to double check with you first if there was any other reason not
to have the new lines in the spec. Please advise. Thanks!
> Jolt spec in JoltTransformJson processor no longer supporting text comments
> ---
>
> Key: NIFI-11959
> URL: https://issues.apache.org/jira/browse/NIFI-11959
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.23.0
>Reporter: Mahieddine Cherif
>Assignee: Daniel Stieglitz
>Priority: Major
> Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json
>
>
> Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt
> Spec (JoltTransformJson/JoltTransformRecord processors)
> This however seems something that was already supported at least the most
> wide spread jolt engine [https://jolt-demo.appspot.com/#inception]
> *Reproducer :*
> We can easily reproduce it by simply putting a jolt with a comment using
> either JoltTransformRecord or JoltTransformJson processors as both are
> impacted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11959) Jolt spec in JoltTransformJson processor no longer supporting text comments
[
https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763732#comment-17763732
]
Daniel Stieglitz edited comment on NIFI-11959 at 9/11/23 2:44 PM:
--
[~mahieddine] I see you are using single line ('//') comment.
{code:java}
// Defaut all{code}
I noticed the problem seems to be only with single line comment while with a
multiline comment ('/**/') there is no issue.
was (Author: JIRAUSER294662):
[~mahieddine] I see you are using single line ('//') comment.
{code:java}
// Defaut all{code}
I noticed the problem seems to be only with single line comment while with a
multiline comment there is no issue.
> Jolt spec in JoltTransformJson processor no longer supporting text comments
> ---
>
> Key: NIFI-11959
> URL: https://issues.apache.org/jira/browse/NIFI-11959
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.23.0
>Reporter: Mahieddine Cherif
>Assignee: Daniel Stieglitz
>Priority: Major
> Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json
>
>
> Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt
> Spec (JoltTransformJson/JoltTransformRecord processors)
> This however seems something that was already supported at least the most
> wide spread jolt engine [https://jolt-demo.appspot.com/#inception]
> *Reproducer :*
> We can easily reproduce it by simply putting a jolt with a comment using
> either JoltTransformRecord or JoltTransformJson processors as both are
> impacted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11959) Jolt spec in JoltTransformJson processor no longer supporting text comments
[
https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763732#comment-17763732
]
Daniel Stieglitz edited comment on NIFI-11959 at 9/11/23 2:44 PM:
--
[~mahieddine] I see you are using single line ('//') comment.
{code:java}
// Defaut all{code}
I noticed the problem seems to be only with single line comment while with a
multiline comment there is no issue.
was (Author: JIRAUSER294662):
[~mahieddine] What type of comment are using single line ('//') or multiline
('/**/') ? I noticed the problem seems to be only with single line comment
while with a multiline comment there is no issue.
> Jolt spec in JoltTransformJson processor no longer supporting text comments
> ---
>
> Key: NIFI-11959
> URL: https://issues.apache.org/jira/browse/NIFI-11959
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.23.0
>Reporter: Mahieddine Cherif
>Assignee: Daniel Stieglitz
>Priority: Major
> Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json
>
>
> Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt
> Spec (JoltTransformJson/JoltTransformRecord processors)
> This however seems something that was already supported at least the most
> wide spread jolt engine [https://jolt-demo.appspot.com/#inception]
> *Reproducer :*
> We can easily reproduce it by simply putting a jolt with a comment using
> either JoltTransformRecord or JoltTransformJson processors as both are
> impacted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11959) Jolt spec in JoltTransformJson processor no longer supporting text comments
[
https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763732#comment-17763732
]
Daniel Stieglitz edited comment on NIFI-11959 at 9/11/23 2:19 PM:
--
[~mahieddine] What type of comment are using single line ('//') or multiline
('/**/') ? I noticed the problem seems to be only with single line comment
while with a multiline comment there is no issue.
was (Author: JIRAUSER294662):
[~mahieddine] What type of comment are using single line ('//') or multiline
('/**/') ?
> Jolt spec in JoltTransformJson processor no longer supporting text comments
> ---
>
> Key: NIFI-11959
> URL: https://issues.apache.org/jira/browse/NIFI-11959
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.23.0
>Reporter: Mahieddine Cherif
>Assignee: Daniel Stieglitz
>Priority: Major
> Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json
>
>
> Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt
> Spec (JoltTransformJson/JoltTransformRecord processors)
> This however seems something that was already supported at least the most
> wide spread jolt engine [https://jolt-demo.appspot.com/#inception]
> *Reproducer :*
> We can easily reproduce it by simply putting a jolt with a comment using
> either JoltTransformRecord or JoltTransformJson processors as both are
> impacted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11959) Jolt spec in JoltTransformJson processor no longer supporting text comments
[
https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763732#comment-17763732
]
Daniel Stieglitz edited comment on NIFI-11959 at 9/11/23 2:11 PM:
--
[~mahieddine] What type of comment are using single line ('//') or multiline
('/**/') ?
was (Author: JIRAUSER294662):
[~mahieddine] What type of comment are using '//' or '/**/' ?
> Jolt spec in JoltTransformJson processor no longer supporting text comments
> ---
>
> Key: NIFI-11959
> URL: https://issues.apache.org/jira/browse/NIFI-11959
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.23.0
>Reporter: Mahieddine Cherif
>Assignee: Daniel Stieglitz
>Priority: Major
> Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json
>
>
> Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt
> Spec (JoltTransformJson/JoltTransformRecord processors)
> This however seems something that was already supported at least the most
> wide spread jolt engine [https://jolt-demo.appspot.com/#inception]
> *Reproducer :*
> We can easily reproduce it by simply putting a jolt with a comment using
> either JoltTransformRecord or JoltTransformJson processors as both are
> impacted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1640: MINIFICPP-1951 - Prevent append overwriting resource
adamdebreceni commented on code in PR #1640:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1640#discussion_r1321620359
##
libminifi/include/core/ContentRepository.h:
##
@@ -30,13 +31,23 @@
#include "ContentSession.h"
#include "core/RepositoryMetricsSource.h"
#include "core/Core.h"
+#include "core/StreamAppendLock.h"
namespace org::apache::nifi::minifi::core {
/**
* Content repository definition that extends StreamManager.
*/
class ContentRepository : public core::CoreComponent, public
StreamManager, public
utils::EnableSharedFromThis, public
core::RepositoryMetricsSource {
+ class ContentStreamAppendLock : public StreamAppendLock {
Review Comment:
yes, that is what I replied to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-11959) Jolt spec in JoltTransformJson processor no longer supporting text comments
[ https://issues.apache.org/jira/browse/NIFI-11959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763732#comment-17763732 ] Daniel Stieglitz commented on NIFI-11959: - [~mahieddine] What type of comment are using '//' or '/**/' ? > Jolt spec in JoltTransformJson processor no longer supporting text comments > --- > > Key: NIFI-11959 > URL: https://issues.apache.org/jira/browse/NIFI-11959 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.23.0 >Reporter: Mahieddine Cherif >Assignee: Daniel Stieglitz >Priority: Major > Attachments: Screenshot 2023-08-17 at 09.24.44-1.png, jolt-issue.json > > > Since NiFi 1.23.0, it seems like comments are no longer supported in Jolt > Spec (JoltTransformJson/JoltTransformRecord processors) > This however seems something that was already supported at least the most > wide spread jolt engine [https://jolt-demo.appspot.com/#inception] > *Reproducer :* > We can easily reproduce it by simply putting a jolt with a comment using > either JoltTransformRecord or JoltTransformJson processors as both are > impacted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2102) Compile failure with -ENABLE_LUA_SCRIPTING on aarch64
[ https://issues.apache.org/jira/browse/MINIFICPP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2102: --- Fix Version/s: 0.16.0 > Compile failure with -ENABLE_LUA_SCRIPTING on aarch64 > - > > Key: MINIFICPP-2102 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2102 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Major > Fix For: 0.16.0 > > > Due to missing luaopen_bit32 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12021) Convert Groovy unit tests in nifi-toolkit-tls to Java
[
https://issues.apache.org/jira/browse/NIFI-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12021:
Fix Version/s: 2.0.0
1.24.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Convert Groovy unit tests in nifi-toolkit-tls to Java
> -
>
> Key: NIFI-12021
> URL: https://issues.apache.org/jira/browse/NIFI-12021
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Fix For: 2.0.0, 1.24.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The two test to refactor are
> {code:java}
> TlsToolkitStandaloneGroovyTest.groovy
> TlsHelperGroovyTest.groovy{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12021) Convert Groovy unit tests in nifi-toolkit-tls to Java
[
https://issues.apache.org/jira/browse/NIFI-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763709#comment-17763709
]
ASF subversion and git services commented on NIFI-12021:
Commit 3cd4845fd47b79b2091a240102b792639eb56e00 in nifi's branch
refs/heads/support/nifi-1.x from dan-s1
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3cd4845fd4 ]
NIFI-12021 Refactored Groovy TLS Toolkit Tests to Java
This closes #7674
Signed-off-by: David Handermann
(cherry picked from commit 796ae2f5d1f1962c8dc9fb6df5cc5035dd2a0f9f)
> Convert Groovy unit tests in nifi-toolkit-tls to Java
> -
>
> Key: NIFI-12021
> URL: https://issues.apache.org/jira/browse/NIFI-12021
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The two test to refactor are
> {code:java}
> TlsToolkitStandaloneGroovyTest.groovy
> TlsHelperGroovyTest.groovy{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12021) Convert Groovy unit tests in nifi-toolkit-tls to Java
[
https://issues.apache.org/jira/browse/NIFI-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763708#comment-17763708
]
ASF subversion and git services commented on NIFI-12021:
Commit 796ae2f5d1f1962c8dc9fb6df5cc5035dd2a0f9f in nifi's branch
refs/heads/main from dan-s1
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=796ae2f5d1 ]
NIFI-12021 Refactored Groovy TLS Toolkit Tests to Java
This closes #7674
Signed-off-by: David Handermann
> Convert Groovy unit tests in nifi-toolkit-tls to Java
> -
>
> Key: NIFI-12021
> URL: https://issues.apache.org/jira/browse/NIFI-12021
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The two test to refactor are
> {code:java}
> TlsToolkitStandaloneGroovyTest.groovy
> TlsHelperGroovyTest.groovy{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request, #1654: MINIFICPP-2214 Fix extension list inconsistencies in build scripts
szaszm opened a new pull request, #1654: URL: https://github.com/apache/nifi-minifi-cpp/pull/1654 - Enable MQTT by default in the Windows MSI - Change all instances of "OS X" and "Mac OS X" to "macOS", to be consistent with Apple's current spelling - Update the extension list in the README bootstrap example to reflect enabled by default extensions - Remove abandoned bootstrap.py - Update bootstrap.sh to treat recently enabled by default extensions as such - Changed win_build_vs.bat CLI switches for enabled by default extensions from an enable switch to an optional disable switch - Renamed win_build_vs.bat internal variables to a more consistent naming scheme I didn't do any in-depth refactoring, as it would be wasted effort with the upcoming Python bootstrap rewrite. Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2214) Fix extension list inconsistencies in build scripts
Marton Szasz created MINIFICPP-2214: --- Summary: Fix extension list inconsistencies in build scripts Key: MINIFICPP-2214 URL: https://issues.apache.org/jira/browse/MINIFICPP-2214 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Marton Szasz -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12021) Convert Groovy unit tests in nifi-toolkit-tls to Java
[
https://issues.apache.org/jira/browse/NIFI-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-12021:
Status: Patch Available (was: Open)
> Convert Groovy unit tests in nifi-toolkit-tls to Java
> -
>
> Key: NIFI-12021
> URL: https://issues.apache.org/jira/browse/NIFI-12021
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The two test to refactor are
> {code:java}
> TlsToolkitStandaloneGroovyTest.groovy
> TlsHelperGroovyTest.groovy{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1640: MINIFICPP-1951 - Prevent append overwriting resource
szaszm commented on code in PR #1640:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1640#discussion_r1321442979
##
libminifi/include/core/ContentRepository.h:
##
@@ -30,13 +31,23 @@
#include "ContentSession.h"
#include "core/RepositoryMetricsSource.h"
#include "core/Core.h"
+#include "core/StreamAppendLock.h"
namespace org::apache::nifi::minifi::core {
/**
* Content repository definition that extends StreamManager.
*/
class ContentRepository : public core::CoreComponent, public
StreamManager, public
utils::EnableSharedFromThis, public
core::RepositoryMetricsSource {
+ class ContentStreamAppendLock : public StreamAppendLock {
Review Comment:
I meant line 42, ContentStreamAppendLock : StreamAppendLock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-2178) Move extension tests to the appropriate extension directories (from libminifi/test)
[ https://issues.apache.org/jira/browse/MINIFICPP-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Debreceni reassigned MINIFICPP-2178: - Assignee: Adam Debreceni > Move extension tests to the appropriate extension directories (from > libminifi/test) > --- > > Key: MINIFICPP-2178 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2178 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Adam Debreceni >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1651: MINIFICPP-2193 - Add manifest to debug bundle
adamdebreceni commented on code in PR #1651:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1651#discussion_r1321369802
##
libminifi/src/c2/C2Agent.cpp:
##
@@ -686,6 +686,25 @@ C2Payload C2Agent::bundleDebugInfo(std::mapgetAgentManifest();
+state::response::SerializedResponseNode manifest;
+manifest.name = std::move(reported_manifest.name);
+manifest.children = std::move(reported_manifest.serialized_nodes);
+manifest.array = reported_manifest.is_array;
+std::string manifest_str = manifest.to_pretty_string();
+std::ofstream{"/home/adam/Desktop/manifest.json", std::ios::binary} <<
manifest_str;
Review Comment:
yes, removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1640: MINIFICPP-1951 - Prevent append overwriting resource
adamdebreceni commented on code in PR #1640:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1640#discussion_r1321364832
##
libminifi/include/core/ContentRepository.h:
##
@@ -30,13 +31,23 @@
#include "ContentSession.h"
#include "core/RepositoryMetricsSource.h"
#include "core/Core.h"
+#include "core/StreamAppendLock.h"
namespace org::apache::nifi::minifi::core {
/**
* Content repository definition that extends StreamManager.
*/
class ContentRepository : public core::CoreComponent, public
StreamManager, public
utils::EnableSharedFromThis, public
core::RepositoryMetricsSource {
+ class ContentStreamAppendLock : public StreamAppendLock {
Review Comment:
it reflects the class hierarchy of ContentRepository and StreamManager,
since StreamManager generates the write stream (which are possibly append
streams) locking for append should appear at that level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1634: MINIFICPP-2146 Add support for SMB networking protocol
adamdebreceni commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1321338204
##
extensions/smb/SmbConnectionControllerService.cpp:
##
@@ -0,0 +1,119 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "SmbConnectionControllerService.h"
+#include "core/Resource.h"
+#include "utils/OsUtils.h"
+#include "utils/expected.h"
+
+namespace org::apache::nifi::minifi::extensions::smb {
+
+void SmbConnectionControllerService::initialize() {
+ setSupportedProperties(Properties);
+}
+
+void SmbConnectionControllerService::onEnable() {
+ std::string hostname;
+ std::string share;
+
+ if (!getProperty(Hostname, hostname))
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Missing hostname");
+
+ if (!getProperty(Share, share))
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Missing share");
Review Comment:
oh I see, maybe in some other PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1634: MINIFICPP-2146 Add support for SMB networking protocol
fgerlits commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1321285835
##
extensions/smb/SmbConnectionControllerService.cpp:
##
@@ -0,0 +1,119 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "SmbConnectionControllerService.h"
+#include "core/Resource.h"
+#include "utils/OsUtils.h"
+#include "utils/expected.h"
+
+namespace org::apache::nifi::minifi::extensions::smb {
+
+void SmbConnectionControllerService::initialize() {
+ setSupportedProperties(Properties);
+}
+
+void SmbConnectionControllerService::onEnable() {
+ std::string hostname;
+ std::string share;
+
+ if (!getProperty(Hostname, hostname))
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Missing hostname");
+
+ if (!getProperty(Share, share))
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Missing share");
+
+ server_path_ = "" + hostname + "\\" + share;
+
+ auto password = getProperty(Password);
+ auto username = getProperty(Username);
+
+ if (password.has_value() != username.has_value())
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Either both a username and a
password, or neither of them should be provided.");
+
+ if (username.has_value())
+credentials_.emplace(Credentials{.username = *username, .password =
*password});
+ else
+credentials_.reset();
+
+ ZeroMemory(_resource_, sizeof(net_resource_));
+ net_resource_.dwType = RESOURCETYPE_DISK;
+ net_resource_.lpLocalName = nullptr;
+ net_resource_.lpRemoteName = server_path_.data();
+ net_resource_.lpProvider = nullptr;
+}
+
+void SmbConnectionControllerService::notifyStop() {
+ auto disconnection_result = disconnect();
+ if (!disconnection_result)
+logger_->log_error("Error while disconnecting from SMB: %s",
disconnection_result.error().message());
+}
+
+std::shared_ptr
SmbConnectionControllerService::getFromProperty(const core::ProcessContext&
context, const core::PropertyReference& property) {
+ std::shared_ptr
smb_connection_controller_service;
+ if (auto connection_controller_name = context.getProperty(property)) {
+smb_connection_controller_service =
std::dynamic_pointer_cast(context.getControllerService(*connection_controller_name));
+ }
+ if (!smb_connection_controller_service) {
+minifi::Exception(ExceptionType::PROCESS_SCHEDULE_EXCEPTION, "Missing SMB
Connection Controller Service");
Review Comment:
Yes, the internal clang-tidy of CLion does catch it, so it probably would.
I have added a Jira for this:
https://issues.apache.org/jira/browse/MINIFICPP-2213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MINIFICPP-2213) Run clang-tidy on Windows, as well
Ferenc Gerlits created MINIFICPP-2213:
-
Summary: Run clang-tidy on Windows, as well
Key: MINIFICPP-2213
URL: https://issues.apache.org/jira/browse/MINIFICPP-2213
Project: Apache NiFi MiNiFi C++
Issue Type: Task
Reporter: Ferenc Gerlits
We should run {{clang-tidy}} on Windows, as well, at least for the windows-only
extensions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1634: MINIFICPP-2146 Add support for SMB networking protocol
fgerlits commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1321237887
##
extensions/smb/ListSmb.h:
##
@@ -0,0 +1,152 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include
+#include
+#include
+#include
+#include
+
+#include "SmbConnectionControllerService.h"
+#include "core/Processor.h"
+#include "core/ProcessSession.h"
+#include "core/Property.h"
+#include "core/PropertyDefinition.h"
+#include "core/PropertyDefinitionBuilder.h"
+#include "core/OutputAttributeDefinition.h"
+#include "core/logging/LoggerConfiguration.h"
+#include "utils/Enum.h"
+#include "utils/ListingStateManager.h"
+#include "utils/file/ListedFile.h"
+#include "utils/file/FileUtils.h"
+
+namespace org::apache::nifi::minifi::extensions::smb {
+
+class ListSmb : public core::Processor {
+ public:
+ explicit ListSmb(std::string name, const utils::Identifier& uuid = {})
+ : core::Processor(std::move(name), uuid) {
+ }
+
+ EXTENSIONAPI static constexpr const char* Description = "Retrieves a listing
of files from an SMB share. For each file that is listed, "
+ "creates a FlowFile
that represents the file so that it can be fetched in conjunction with
FetchSmb.";
+
+ EXTENSIONAPI static constexpr auto ConnectionControllerService =
core::PropertyDefinitionBuilder<>::createProperty("SMB Connection Controller
Service")
+ .withDescription("Specifies the SMB connection controller service to use
for connecting to the SMB server.")
+ .isRequired(true)
+ .withAllowedTypes()
+ .build();
+ EXTENSIONAPI static constexpr auto InputDirectory =
core::PropertyDefinitionBuilder<>::createProperty("Input Directory")
+ .withDescription("The input directory from which files to pull files")
+ .isRequired(false)
+ .build();
+ EXTENSIONAPI static constexpr auto RecurseSubdirectories =
core::PropertyDefinitionBuilder<>::createProperty("Recurse Subdirectories")
+ .withDescription("Indicates whether to list files from subdirectories of
the directory")
+ .withPropertyType(core::StandardPropertyTypes::BOOLEAN_TYPE)
+ .withDefaultValue("true")
+ .isRequired(true)
+ .build();
+ EXTENSIONAPI static constexpr auto FileFilter =
core::PropertyDefinitionBuilder<>::createProperty("File Filter")
+ .withDescription("Only files whose names match the given regular
expression will be picked up")
+ .build();
+ EXTENSIONAPI static constexpr auto PathFilter =
core::PropertyDefinitionBuilder<>::createProperty("Path Filter")
+ .withDescription("When Recurse Subdirectories is true, then only
subdirectories whose path matches the given regular expression will be scanned")
+ .build();
+ EXTENSIONAPI static constexpr auto MinimumFileAge =
core::PropertyDefinitionBuilder<>::createProperty("Minimum File Age")
+ .withDescription("The minimum age that a file must be in order to be
pulled; any file younger than this amount of time (according to last
modification date) will be ignored")
+ .isRequired(true)
+ .withPropertyType(core::StandardPropertyTypes::TIME_PERIOD_TYPE)
+ .withDefaultValue("0 sec")
+ .build();
+ EXTENSIONAPI static constexpr auto MaximumFileAge =
core::PropertyDefinitionBuilder<>::createProperty("Maximum File Age")
+ .withDescription("The maximum age that a file must be in order to be
pulled; any file older than this amount of time (according to last modification
date) will be ignored")
+ .build();
+ EXTENSIONAPI static constexpr auto MinimumFileSize =
core::PropertyDefinitionBuilder<>::createProperty("Minimum File Size")
+ .withDescription("The minimum size that a file must be in order to be
pulled")
+ .isRequired(true)
+ .withPropertyType(core::StandardPropertyTypes::DATA_SIZE_TYPE)
+ .withDefaultValue("0 B")
+ .build();
+ EXTENSIONAPI static constexpr auto MaximumFileSize =
core::PropertyDefinitionBuilder<>::createProperty("Maximum File Size")
+ .withDescription("The maximum size that a file can be in order to be
pulled")
+ .build();
+ EXTENSIONAPI static constexpr auto
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1634: MINIFICPP-2146 Add support for SMB networking protocol
fgerlits commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1321229527
##
extensions/smb/SmbConnectionControllerService.cpp:
##
@@ -0,0 +1,119 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "SmbConnectionControllerService.h"
+#include "core/Resource.h"
+#include "utils/OsUtils.h"
+#include "utils/expected.h"
+
+namespace org::apache::nifi::minifi::extensions::smb {
+
+void SmbConnectionControllerService::initialize() {
+ setSupportedProperties(Properties);
+}
+
+void SmbConnectionControllerService::onEnable() {
+ std::string hostname;
+ std::string share;
+
+ if (!getProperty(Hostname, hostname))
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Missing hostname");
+
+ if (!getProperty(Share, share))
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Missing share");
+
+ server_path_ = "" + hostname + "\\" + share;
+
+ auto password = getProperty(Password);
+ auto username = getProperty(Username);
+
+ if (password.has_value() != username.has_value())
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Either both a username and a
password, or neither of them should be provided.");
+
+ if (username.has_value())
+credentials_.emplace(Credentials{.username = *username, .password =
*password});
+ else
+credentials_.reset();
+
+ ZeroMemory(_resource_, sizeof(net_resource_));
+ net_resource_.dwType = RESOURCETYPE_DISK;
+ net_resource_.lpLocalName = nullptr;
+ net_resource_.lpRemoteName = server_path_.data();
+ net_resource_.lpProvider = nullptr;
+}
+
+void SmbConnectionControllerService::notifyStop() {
+ auto disconnection_result = disconnect();
+ if (!disconnection_result)
+logger_->log_error("Error while disconnecting from SMB: %s",
disconnection_result.error().message());
+}
+
+std::shared_ptr
SmbConnectionControllerService::getFromProperty(const core::ProcessContext&
context, const core::PropertyReference& property) {
Review Comment:
I did mean `unique_ptr`, but I can see now that that doesn't make sense,
since we get it as a `shared_ptr` from the context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MINIFICPP-1076) onTrigger always runs after a yield, regardless of the run schedule
[
https://issues.apache.org/jira/browse/MINIFICPP-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink updated MINIFICPP-1076:
---
Status: Patch Available (was: Reopened)
> onTrigger always runs after a yield, regardless of the run schedule
> ---
>
> Key: MINIFICPP-1076
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1076
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Affects Versions: 0.6.0
>Reporter: Andre Araujo
>Assignee: Martin Zink
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I'm running some tests with Minifi (C++) and noticed something strange that
> doesn't seem right to me.
> I created a test processor that generates a single flow file every time
> {{onTrigger}} is executed (pretty much like {{GenerateFlowFile}}). I ran this
> processor on NiFi and, as I expected, I got 1 flow file at every {{Run
> Schedule}} period.
> I tested calling {{context.yield()}} within {{onTrigger}} and noticed that it
> makes no difference; {{onTrigger}} is always called once per scheduling
> period.
> I wrote the same test processor for Minifi C++ and the result was different.
> If I *don't* call {{context->yield()}} in {{onTrigger}}, the behavior is the
> same as in NiFi. However, if I call {{context->yield()}} in {{onTrigger}},
> {{onTrigger}} will be invoked again at the end of the yielding period,
> regardless of the run schedule.
> If, for example, *Run Schedule = 60 secs* and *Yield Duration = 1 sec*, I'll
> get 60 flow files per minute.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2195) MQTT tests transiently fail in CI
[ https://issues.apache.org/jira/browse/MINIFICPP-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2195: --- Status: Patch Available (was: In Progress) > MQTT tests transiently fail in CI > - > > Key: MINIFICPP-2195 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2195 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gábor Gyimesi >Assignee: Martin Zink >Priority: Major > Attachments: mqtt_failure_1.zip, mqtt_failure_2.zip > > Time Spent: 20m > Remaining Estimate: 0h > > Various tests transiently fail in CI, more information in the attached logs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1652: MINIFICPP-2195 fix flaky MQTT docker tests
martinzink commented on code in PR #1652:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1652#discussion_r1321083062
##
docker/test/integration/features/steps/steps.py:
##
@@ -428,6 +428,7 @@ def step_impl(context):
@given("an MQTT broker is set up in correspondence with the PublishMQTT and
ConsumeMQTT")
def step_impl(context):
context.test.acquire_container(context=context, name="mqtt-broker",
engine="mqtt-broker")
+context.test.start('mqtt-broker')
Review Comment:
I've merged the steps you mentioned in
https://github.com/apache/nifi-minifi-cpp/pull/1652/commits/21d6cf4284885ad0855d4f7cb89b76362a19769b
##
docker/test/integration/features/steps/steps.py:
##
Review Comment:
Good idea I've merged the steps you mentioned in
https://github.com/apache/nifi-minifi-cpp/pull/1652/commits/21d6cf4284885ad0855d4f7cb89b76362a19769b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-12036) ListenTCPRecord throws exception when SSL is configured with JsonTreeReader with infer schema
Kalmár Róbert created NIFI-12036:
Summary: ListenTCPRecord throws exception when SSL is configured
with JsonTreeReader with infer schema
Key: NIFI-12036
URL: https://issues.apache.org/jira/browse/NIFI-12036
Project: Apache NiFi
Issue Type: Bug
Reporter: Kalmár Róbert
Call stack
{code:java}
2023-09-07 13:39:46,286 ERROR
org.apache.nifi.processors.standard.ListenTCPRecord:
ListenTCPRecord[id=6fdea6b5-018a-1000--39ac1fb1] Error processing
records: End of Stream found for Channel Read
java.io.EOFException: End of Stream found for Channel Read
at
org.apache.nifi.remote.io.socket.ssl.SSLSocketChannel.unwrapBufferReadChannel(SSLSocketChannel.java:500)
at
org.apache.nifi.remote.io.socket.ssl.SSLSocketChannel.read(SSLSocketChannel.java:347)
at
org.apache.nifi.remote.io.socket.ssl.SSLSocketChannelInputStream.read(SSLSocketChannelInputStream.java:46)
at
java.base/java.io.BufferedInputStream.fill(BufferedInputStream.java:252)
at
java.base/java.io.BufferedInputStream.read1(BufferedInputStream.java:292)
at
java.base/java.io.BufferedInputStream.read(BufferedInputStream.java:351)
at
org.apache.nifi.stream.io.NonCloseableInputStream.read(NonCloseableInputStream.java:48)
at
com.fasterxml.jackson.core.json.UTF8StreamJsonParser._loadMore(UTF8StreamJsonParser.java:258)
at
com.fasterxml.jackson.core.json.UTF8StreamJsonParser._skipWSOrEnd2(UTF8StreamJsonParser.java:3150)
at
com.fasterxml.jackson.core.json.UTF8StreamJsonParser._skipWSOrEnd(UTF8StreamJsonParser.java:3145)
at
com.fasterxml.jackson.core.json.UTF8StreamJsonParser.nextToken(UTF8StreamJsonParser.java:757)
at org.apache.nifi.json.JsonRecordSource.next(JsonRecordSource.java:65)
at org.apache.nifi.json.JsonRecordSource.next(JsonRecordSource.java:32)
at
org.apache.nifi.schema.inference.HierarchicalSchemaInference.inferSchema(HierarchicalSchemaInference.java:45)
at
org.apache.nifi.schema.inference.InferSchemaAccessStrategy.getSchema(InferSchemaAccessStrategy.java:49)
at
org.apache.nifi.serialization.SchemaRegistryService.getSchema(SchemaRegistryService.java:126)
at
org.apache.nifi.json.JsonTreeReader.createRecordReader(JsonTreeReader.java:166)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:254)
at
org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:105)
at com.sun.proxy.$Proxy203.createRecordReader(Unknown Source)
at
org.apache.nifi.record.listen.SSLSocketChannelRecordReader.createRecordReader(SSLSocketChannelRecordReader.java:69)
at
org.apache.nifi.processors.standard.ListenTCPRecord.onTrigger(ListenTCPRecord.java:364)
at
org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
at
org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1361)
at
org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:247)
at
org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:102)
at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at
java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12035) sensitive values are been deleted after restarting in costume processor
Dean Taler created NIFI-12035: - Summary: sensitive values are been deleted after restarting in costume processor Key: NIFI-12035 URL: https://issues.apache.org/jira/browse/NIFI-12035 Project: Apache NiFi Issue Type: Bug Components: Flow Versioning Affects Versions: 1.21.0 Reporter: Dean Taler Attachments: image-2023-09-11-09-35-47-033.png When adding a new sensitive Property to a costume processor it is deleted when restarting the cluster. !image-2023-09-11-09-35-47-033.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
