[GitHub] [nifi] mattyb149 opened a new pull request, #7686: NIFI-12024: Add CSV Writer property to CSVRecordSetWriter and a FastCSV writer implementation
mattyb149 opened a new pull request, #7686: URL: https://github.com/apache/nifi/pull/7686 # Summary [NIFI-12024](https://issues.apache.org/jira/browse/NIFI-12024) This PR adds a FastCSV writer implementation to CSVRecordSetWriter. This PR depends on the dependency being added by #7685 # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [x] JDK 17 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12024) Add CSV Writer property to CSVRecordSetWriter along with a FastCSV implementation
[ https://issues.apache.org/jira/browse/NIFI-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-12024: --- Assignee: Matt Burgess > Add CSV Writer property to CSVRecordSetWriter along with a FastCSV > implementation > - > > Key: NIFI-12024 > URL: https://issues.apache.org/jira/browse/NIFI-12024 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > > According to [these > benchmarks|https://github.com/osiegmar/JavaCsvBenchmarkSuite], FastCSV is > much faster than Apache Commons CSV and Jackson CSV with a small footprint. > This Jira proposes to add a property "CSV Writer" to CSVRecordSetWriter for > choosing an implementation of the underlying writer. The existing Apache > Commons CSV implementation should be available as a choice for CSV Writer, > and an implementation of Jackson CSV should be added as the library is > already available to the module. In addition an implementation of FastCSV as > a writer could be added. Attention must be paid to which features are > available from FastCSV, any unusual or unsupported behaviors should be well > documented to avoid confusion for the user. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mattyb149 opened a new pull request, #7685: NIFI-12023: Add FastCSV parser to CSVReader
mattyb149 opened a new pull request, #7685: URL: https://github.com/apache/nifi/pull/7685 # Summary [NIFI-12023](https://issues.apache.org/jira/browse/NIFI-12023) This PR adds a "FastCSV" option for CSV Parsers in the CSVReader controller service. The performance is supposedly MUCH better than Apache Commons CSV but the library is very tied to RFC4180, so the configuration of this option should reflect that. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [x] JDK 17 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12023) Add FastCSV parser to CSVReader
[ https://issues.apache.org/jira/browse/NIFI-12023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-12023: --- Assignee: Matt Burgess > Add FastCSV parser to CSVReader > --- > > Key: NIFI-12023 > URL: https://issues.apache.org/jira/browse/NIFI-12023 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > > According to [these > benchmarks|https://github.com/osiegmar/JavaCsvBenchmarkSuite], FastCSV is > much faster than Apache Commons CSV and Jackson CSV with a small footprint. > This Jira proposes to add an implementation of FastCSV as a parser for > CSVReader. Attention must be paid to which features are available from > FastCSV, any unusual or unsupported behaviors should be well documented to > avoid confusion for the user. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] Lehel44 commented on a diff in pull request #7644: NIFI-11992: Processor and sink service for filing tickets in Zendesk
Lehel44 commented on code in PR #7644:
URL: https://github.com/apache/nifi/pull/7644#discussion_r1323690358
##
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-services/src/main/java/org/apache/nifi/services/zendesk/ZendeskRecordSink.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.services.zendesk;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.node.ObjectNode;
+import com.github.benmanes.caffeine.cache.Cache;
+import com.github.benmanes.caffeine.cache.Caffeine;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.common.zendesk.ZendeskAuthenticationContext;
+import org.apache.nifi.common.zendesk.ZendeskAuthenticationType;
+import org.apache.nifi.common.zendesk.ZendeskClient;
+import
org.apache.nifi.common.zendesk.validation.JsonPointerPropertyNameValidator;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.record.sink.RecordSinkService;
+import org.apache.nifi.schema.access.SchemaNotFoundException;
+import org.apache.nifi.serialization.RecordSetWriter;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+import org.apache.nifi.serialization.WriteResult;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.serialization.record.RecordSet;
+import org.apache.nifi.web.client.api.HttpResponseEntity;
+import org.apache.nifi.web.client.api.HttpResponseStatus;
+import org.apache.nifi.web.client.api.HttpUriBuilder;
+import org.apache.nifi.web.client.provider.api.WebClientServiceProvider;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+import static java.lang.String.format;
+import static
org.apache.nifi.common.zendesk.ZendeskProperties.WEB_CLIENT_SERVICE_PROVIDER;
+import static
org.apache.nifi.common.zendesk.ZendeskProperties.ZENDESK_AUTHENTICATION_CREDENTIAL;
+import static
org.apache.nifi.common.zendesk.ZendeskProperties.ZENDESK_AUTHENTICATION_TYPE;
+import static
org.apache.nifi.common.zendesk.ZendeskProperties.ZENDESK_CREATE_TICKETS_RESOURCE;
+import static
org.apache.nifi.common.zendesk.ZendeskProperties.ZENDESK_CREATE_TICKET_RESOURCE;
+import static
org.apache.nifi.common.zendesk.ZendeskProperties.ZENDESK_SUBDOMAIN;
+import static
org.apache.nifi.common.zendesk.ZendeskProperties.ZENDESK_TICKET_COMMENT_BODY_NAME;
+import static
org.apache.nifi.common.zendesk.ZendeskProperties.ZENDESK_TICKET_PRIORITY_NAME;
+import static
org.apache.nifi.common.zendesk.ZendeskProperties.ZENDESK_TICKET_SUBJECT_NAME;
+import static
org.apache.nifi.common.zendesk.ZendeskProperties.ZENDESK_TICKET_TYPE_NAME;
+import static org.apache.nifi.common.zendesk.ZendeskProperties.ZENDESK_USER;
+import static
org.apache.nifi.common.zendesk.util.ZendeskRecordPathUtils.addDynamicField;
+import static
org.apache.nifi.common.zendesk.util.ZendeskRecordPathUtils.resolveFieldValue;
+import static
org.apache.nifi.common.zendesk.util.ZendeskUtils.createRequestObject;
+import static
org.apache.nifi.common.zendesk.util.ZendeskUtils.getDynamicProperties;
+import static org.apache.nifi.common.zendesk.util.ZendeskUtils.getResponseBody;
+
+@Tags({"zendesk", "record", "sink"})
+@CapabilityDescription("Create Zendesk tickets using the Zendesk API." +
+"The service requires a Zendesk account with configured access.")
+public class ZendeskRecordSink extends AbstractControllerService implements
RecordSinkService {
+
+private fi
[GitHub] [nifi] Lehel44 commented on a diff in pull request #7644: NIFI-11992: Processor and sink service for filing tickets in Zendesk
Lehel44 commented on code in PR #7644:
URL: https://github.com/apache/nifi/pull/7644#discussion_r1323684185
##
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-common/src/main/java/org/apache/nifi/common/zendesk/util/ZendeskUtils.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.common.zendesk.util;
+
+import com.fasterxml.jackson.core.JsonPointer;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.node.ArrayNode;
+import com.fasterxml.jackson.databind.node.ObjectNode;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.common.zendesk.ZendeskProperties;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.context.PropertyContext;
+import org.apache.nifi.web.client.api.HttpResponseEntity;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.UncheckedIOException;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public final class ZendeskUtils {
+
+private static final Logger logger =
LoggerFactory.getLogger(ZendeskUtils.class);
Review Comment:
The logger is not used anymore, it can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12011) Add MIME type property to ExecuteStreamCommand and ExecuteProcess
[ https://issues.apache.org/jira/browse/NIFI-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764399#comment-17764399 ] ASF subversion and git services commented on NIFI-12011: Commit ee813d965096f18a0ec234a6c53a2c29919646f1 in nifi's branch refs/heads/support/nifi-1.x from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ee813d9650 ] NIFI-12011 Added MIME Type to ExecuteStreamCommand and ExecuteProcess This closes #7660 Signed-off-by: David Handermann (cherry picked from commit 24736f62767a88669a6845a6e3f21ce801b8b645) > Add MIME type property to ExecuteStreamCommand and ExecuteProcess > - > > Key: NIFI-12011 > URL: https://issues.apache.org/jira/browse/NIFI-12011 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > Fix For: 1.latest, 2.latest > > Time Spent: 0.5h > Remaining Estimate: 0h > > Depending on what command is run by ExecuteStreamCommand or ExecuteProcess, > the output could be in any format. This Jira proposes to add an optional MIME > Type property to ExecuteStreamCommand and ExecuteProcess to avoid the need > for an UpdateAttribute processor downstream (similar to what is done in > GenerateFlowFile). The property should be ignored if the output is being > stored in an attribute rather than the content for ExecuteStreamCommand, or > if Batch Duration is set on ExecuteProcess. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12011) Add MIME type property to ExecuteStreamCommand and ExecuteProcess
[ https://issues.apache.org/jira/browse/NIFI-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12011: Fix Version/s: 2.0.0 1.24.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Add MIME type property to ExecuteStreamCommand and ExecuteProcess > - > > Key: NIFI-12011 > URL: https://issues.apache.org/jira/browse/NIFI-12011 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > Fix For: 2.0.0, 1.24.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Depending on what command is run by ExecuteStreamCommand or ExecuteProcess, > the output could be in any format. This Jira proposes to add an optional MIME > Type property to ExecuteStreamCommand and ExecuteProcess to avoid the need > for an UpdateAttribute processor downstream (similar to what is done in > GenerateFlowFile). The property should be ignored if the output is being > stored in an attribute rather than the content for ExecuteStreamCommand, or > if Batch Duration is set on ExecuteProcess. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12011) Add MIME type property to ExecuteStreamCommand and ExecuteProcess
[ https://issues.apache.org/jira/browse/NIFI-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764397#comment-17764397 ] ASF subversion and git services commented on NIFI-12011: Commit 24736f62767a88669a6845a6e3f21ce801b8b645 in nifi's branch refs/heads/main from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=24736f6276 ] NIFI-12011 Added MIME Type to ExecuteStreamCommand and ExecuteProcess This closes #7660 Signed-off-by: David Handermann > Add MIME type property to ExecuteStreamCommand and ExecuteProcess > - > > Key: NIFI-12011 > URL: https://issues.apache.org/jira/browse/NIFI-12011 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > Fix For: 1.latest, 2.latest > > Time Spent: 0.5h > Remaining Estimate: 0h > > Depending on what command is run by ExecuteStreamCommand or ExecuteProcess, > the output could be in any format. This Jira proposes to add an optional MIME > Type property to ExecuteStreamCommand and ExecuteProcess to avoid the need > for an UpdateAttribute processor downstream (similar to what is done in > GenerateFlowFile). The property should be ignored if the output is being > stored in an attribute rather than the content for ExecuteStreamCommand, or > if Batch Duration is set on ExecuteProcess. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12046) Update box-java-sdk to 4.4.0
[ https://issues.apache.org/jira/browse/NIFI-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764392#comment-17764392 ] ASF subversion and git services commented on NIFI-12046: Commit 213511c151b6ca64dab699c19462488b878d00f9 in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=213511c151 ] NIFI-12046 Upgraded box-java-sdk from 4.2.0 to 4.4.0 This closes #7683 Signed-off-by: David Handermann (cherry picked from commit 8c68e5d8ccab2cfa65593352ef58ad76d26ead89) > Update box-java-sdk to 4.4.0 > > > Key: NIFI-12046 > URL: https://issues.apache.org/jira/browse/NIFI-12046 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Update box-java-sdk to 4.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12046) Update box-java-sdk to 4.4.0
[ https://issues.apache.org/jira/browse/NIFI-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12046: Priority: Minor (was: Major) > Update box-java-sdk to 4.4.0 > > > Key: NIFI-12046 > URL: https://issues.apache.org/jira/browse/NIFI-12046 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update box-java-sdk to 4.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12046) Update box-java-sdk to 4.4.0
[ https://issues.apache.org/jira/browse/NIFI-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12046. - Fix Version/s: 2.0.0 1.24.0 Resolution: Fixed > Update box-java-sdk to 4.4.0 > > > Key: NIFI-12046 > URL: https://issues.apache.org/jira/browse/NIFI-12046 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update box-java-sdk to 4.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12046) Update box-java-sdk to 4.4.0
[ https://issues.apache.org/jira/browse/NIFI-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764391#comment-17764391 ] ASF subversion and git services commented on NIFI-12046: Commit 8c68e5d8ccab2cfa65593352ef58ad76d26ead89 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8c68e5d8cc ] NIFI-12046 Upgraded box-java-sdk from 4.2.0 to 4.4.0 This closes #7683 Signed-off-by: David Handermann > Update box-java-sdk to 4.4.0 > > > Key: NIFI-12046 > URL: https://issues.apache.org/jira/browse/NIFI-12046 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Update box-java-sdk to 4.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12044) Update h2 to 2.2.222
[ https://issues.apache.org/jira/browse/NIFI-12044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12044. - Fix Version/s: 2.0.0 1.24.0 Resolution: Fixed > Update h2 to 2.2.222 > > > Key: NIFI-12044 > URL: https://issues.apache.org/jira/browse/NIFI-12044 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.23.2 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update h2 to 2.2.222 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12044) Update h2 to 2.2.222
[ https://issues.apache.org/jira/browse/NIFI-12044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764385#comment-17764385 ] ASF subversion and git services commented on NIFI-12044: Commit 012e91be1d393a3e0562b3ed7d964694eaf216ba in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=012e91be1d ] NIFI-12044 Upgraded H2 DB from 2.2.220 to 2.2.222 This closes #7682 Signed-off-by: David Handermann (cherry picked from commit 01dadf10de173d665905b54a0785244517e2a6bf) > Update h2 to 2.2.222 > > > Key: NIFI-12044 > URL: https://issues.apache.org/jira/browse/NIFI-12044 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.23.2 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Update h2 to 2.2.222 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12044) Update h2 to 2.2.222
[ https://issues.apache.org/jira/browse/NIFI-12044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12044: Priority: Minor (was: Major) > Update h2 to 2.2.222 > > > Key: NIFI-12044 > URL: https://issues.apache.org/jira/browse/NIFI-12044 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.23.2 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update h2 to 2.2.222 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12044) Update h2 to 2.2.222
[ https://issues.apache.org/jira/browse/NIFI-12044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764384#comment-17764384 ] ASF subversion and git services commented on NIFI-12044: Commit 01dadf10de173d665905b54a0785244517e2a6bf in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=01dadf10de ] NIFI-12044 Upgraded H2 DB from 2.2.220 to 2.2.222 This closes #7682 Signed-off-by: David Handermann > Update h2 to 2.2.222 > > > Key: NIFI-12044 > URL: https://issues.apache.org/jira/browse/NIFI-12044 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.23.2 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Update h2 to 2.2.222 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7682: NIFI-12044 Update h2 to 2.2.222
exceptionfactory closed pull request #7682: NIFI-12044 Update h2 to 2.2.222 URL: https://github.com/apache/nifi/pull/7682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12047) Add HTTP/2 to Default Application Protocols
[ https://issues.apache.org/jira/browse/NIFI-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12047: Status: Patch Available (was: Open) > Add HTTP/2 to Default Application Protocols > --- > > Key: NIFI-12047 > URL: https://issues.apache.org/jira/browse/NIFI-12047 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > NiFi 1.17.0 introduced optional framework support for the HTTP/2 protocol > using application properties. With HTTP/2 widely supported in modern browsers > and clients, HTTP/2 should be enabled by default for the NiFi 2.0 release > version. Fallback support for HTTP/1.1 should be retained in the default > configuration, and the configuration semantics should remain unchanged, allow > administrators to customize HTTP protocol selection for the NiFi web > application as needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #7684: NIFI-12047 Add HTTP/2 to Default Application Protocols
exceptionfactory opened a new pull request, #7684: URL: https://github.com/apache/nifi/pull/7684 # Summary [NIFI-12047](https://issues.apache.org/jira/browse/NIFI-12047) Adds HTTP/2 to the list of default HTTPS application protocols for NiFi and NiFi Registry, as part of changes for NiFi 2.0. NiFi 1.17.0 introduced optional support or HTTP/2 but kept the default setting as HTTP/1.1 to avoid unexpected changes. With modern browsers and clients supporting HTTP/2, enabling both HTTP/2 and HTTP/1.1 provides broad compatibility with better protocol optimization for newer clients. Additional changes include adding the Jetty `HostHeaderCustomizer` to the Connector Factory in support of the NiFi `HostHeaderHandler` for validation. [RFC 7540 Section 8.1.2.3](https://www.rfc-editor.org/rfc/rfc7540.html#section-8.1.2.3) notes that clients should use the `:authority` pseudo-header instead of the `Host` header, so the Jetty `HostHeaderCustomizer` derives a `Host` Header from the server name when the client does not send the header. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12047) Add HTTP/2 to Default Application Protocols
David Handermann created NIFI-12047: --- Summary: Add HTTP/2 to Default Application Protocols Key: NIFI-12047 URL: https://issues.apache.org/jira/browse/NIFI-12047 Project: Apache NiFi Issue Type: Improvement Components: Core Framework, NiFi Registry Reporter: David Handermann Assignee: David Handermann Fix For: 2.latest NiFi 1.17.0 introduced optional framework support for the HTTP/2 protocol using application properties. With HTTP/2 widely supported in modern browsers and clients, HTTP/2 should be enabled by default for the NiFi 2.0 release version. Fallback support for HTTP/1.1 should be retained in the default configuration, and the configuration semantics should remain unchanged, allow administrators to customize HTTP protocol selection for the NiFi web application as needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10110) Add in OpenTelemetry integration to support distributed tracing
[ https://issues.apache.org/jira/browse/NIFI-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764340#comment-17764340 ] Eric Secules commented on NIFI-10110: - This would be a really useful feature! I'd also want to think about whether executing a processor should always create a new root span or continue as a child span if there are trace headers present on the flowfile attributes. I could see it being useful to see the whole journey for a given flowfile if the flow is small enough, but it could be a burden if the flow is too large. > Add in OpenTelemetry integration to support distributed tracing > --- > > Key: NIFI-10110 > URL: https://issues.apache.org/jira/browse/NIFI-10110 > Project: Apache NiFi > Issue Type: New Feature > Components: Core Framework >Reporter: brian >Priority: Major > Labels: opentelemetry, tracing > > It would be great if we had a way to trace data as it flows through NiFi and > identify bottlenecks in our flows. Distributed tracing offers advantages > where we can trace data as it moves through various systems (which can > include other NiFi instances/clusters) and enable teams to determine the > level of visibility through sampling. > Ideally, we make taking advantage of tracing as easy as possible by adding it > at the AbstractProcessor level or by providing annotations that can be added > to the various processors. > Some things to think about: > * How to expose flowfile attributes to inject into tags so that we can > include some metadata in the spans for a given trace > * How to take those flowfile attributes and make sampling decisions based on > simple key/val matching (i.e. I want to sample data from a specific system) > * Processors that egress data (i.e. posthttp, kafka) will need to include a > w3c trace context header so that the downstream system can continue the trace > The biggest question will be how to properly handle span context and dealing > with batching, which the otel spec provides some insight into that > [https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/overview.md#links-between-spans] > Java lib: > [https://github.com/open-telemetry/opentelemetry-java-instrumentation] > Messaging system spec draft: > [https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/messaging.md] > Messaging spec PRs: > [https://github.com/open-telemetry/oteps/pulls?q=is%3Apr+is%3Aopen+messaging] > We did try running NiFi with the otel autoinstrumentation and some of the > processors we used generated spans, but did not carry the context between > them, so otel generated a trace per processor...Ideally, we'd implement > native otel into NiFi to remove the startup cost of byte code injection -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2088) InvokeHTTP should check whether it needs to run before retrieving the HttpClient
[ https://issues.apache.org/jira/browse/MINIFICPP-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2088. - Resolution: Done > InvokeHTTP should check whether it needs to run before retrieving the > HttpClient > > > Key: MINIFICPP-2088 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2088 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Ferenc Gerlits >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > InvokeHTTP has setTriggerWhenEmpty=true to support GET requests with no > incoming flow files. But it creates/retrieves the http client even if it's > triggered as POST with no incoming flow files. We should keep the check as > lightweight as possible, and add a bored yield if it didn't need to run. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-1076) onTrigger always runs after a yield, regardless of the run schedule
[
https://issues.apache.org/jira/browse/MINIFICPP-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz updated MINIFICPP-1076:
Fix Version/s: 0.16.0
> onTrigger always runs after a yield, regardless of the run schedule
> ---
>
> Key: MINIFICPP-1076
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1076
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Affects Versions: 0.6.0
>Reporter: Andre Araujo
>Assignee: Martin Zink
>Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I'm running some tests with Minifi (C++) and noticed something strange that
> doesn't seem right to me.
> I created a test processor that generates a single flow file every time
> {{onTrigger}} is executed (pretty much like {{GenerateFlowFile}}). I ran this
> processor on NiFi and, as I expected, I got 1 flow file at every {{Run
> Schedule}} period.
> I tested calling {{context.yield()}} within {{onTrigger}} and noticed that it
> makes no difference; {{onTrigger}} is always called once per scheduling
> period.
> I wrote the same test processor for Minifi C++ and the result was different.
> If I *don't* call {{context->yield()}} in {{onTrigger}}, the behavior is the
> same as in NiFi. However, if I call {{context->yield()}} in {{onTrigger}},
> {{onTrigger}} will be invoked again at the end of the yielding period,
> regardless of the run schedule.
> If, for example, *Run Schedule = 60 secs* and *Yield Duration = 1 sec*, I'll
> get 60 flow files per minute.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2102) Compile failure with -ENABLE_LUA_SCRIPTING on aarch64
[ https://issues.apache.org/jira/browse/MINIFICPP-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2102: Resolution: Fixed Status: Resolved (was: Patch Available) > Compile failure with -ENABLE_LUA_SCRIPTING on aarch64 > - > > Key: MINIFICPP-2102 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2102 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Major > Fix For: 0.16.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Due to missing luaopen_bit32 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-1076) onTrigger always runs after a yield, regardless of the run schedule
[
https://issues.apache.org/jira/browse/MINIFICPP-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz updated MINIFICPP-1076:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> onTrigger always runs after a yield, regardless of the run schedule
> ---
>
> Key: MINIFICPP-1076
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1076
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Affects Versions: 0.6.0
>Reporter: Andre Araujo
>Assignee: Martin Zink
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I'm running some tests with Minifi (C++) and noticed something strange that
> doesn't seem right to me.
> I created a test processor that generates a single flow file every time
> {{onTrigger}} is executed (pretty much like {{GenerateFlowFile}}). I ran this
> processor on NiFi and, as I expected, I got 1 flow file at every {{Run
> Schedule}} period.
> I tested calling {{context.yield()}} within {{onTrigger}} and noticed that it
> makes no difference; {{onTrigger}} is always called once per scheduling
> period.
> I wrote the same test processor for Minifi C++ and the result was different.
> If I *don't* call {{context->yield()}} in {{onTrigger}}, the behavior is the
> same as in NiFi. However, if I call {{context->yield()}} in {{onTrigger}},
> {{onTrigger}} will be invoked again at the end of the yielding period,
> regardless of the run schedule.
> If, for example, *Run Schedule = 60 secs* and *Yield Duration = 1 sec*, I'll
> get 60 flow files per minute.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2195) MQTT tests transiently fail in CI
[ https://issues.apache.org/jira/browse/MINIFICPP-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2195: Resolution: Fixed Status: Resolved (was: Patch Available) > MQTT tests transiently fail in CI > - > > Key: MINIFICPP-2195 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2195 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gábor Gyimesi >Assignee: Martin Zink >Priority: Major > Attachments: mqtt_failure_1.zip, mqtt_failure_2.zip > > Time Spent: 0.5h > Remaining Estimate: 0h > > Various tests transiently fail in CI, more information in the attached logs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2182) Add C2 System Load Avg field
[ https://issues.apache.org/jira/browse/MINIFICPP-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2182: Fix Version/s: 0.16.0 > Add C2 System Load Avg field > > > Key: MINIFICPP-2182 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2182 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Marton Szasz >Assignee: Gábor Gyimesi >Priority: Major > Fix For: 0.16.0 > > > https://issues.apache.org/jira/browse/NIFI-11921 > To keep C2 feature parity with MiNiFi Java > heartbeat path: detail.deviceInfo.systemInfo.cpuLoadAverage -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2195) MQTT tests transiently fail in CI
[ https://issues.apache.org/jira/browse/MINIFICPP-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2195: Fix Version/s: 0.16.0 > MQTT tests transiently fail in CI > - > > Key: MINIFICPP-2195 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2195 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gábor Gyimesi >Assignee: Martin Zink >Priority: Major > Fix For: 0.16.0 > > Attachments: mqtt_failure_1.zip, mqtt_failure_2.zip > > Time Spent: 0.5h > Remaining Estimate: 0h > > Various tests transiently fail in CI, more information in the attached logs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-1372) Add batch cleanup for ContentRepository
[ https://issues.apache.org/jira/browse/MINIFICPP-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-1372. - Resolution: Done > Add batch cleanup for ContentRepository > --- > > Key: MINIFICPP-1372 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1372 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.9.0, 0.7.0 >Reporter: Adam Debreceni >Assignee: Adam Debreceni >Priority: Major > Labels: selected-for-development > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently all content is removed one-by-one whenever the refCount in the > ContentReposiroty::count_map_ goes to 0. For the rocksdb backed > DatabaseContentRepository this results in an unnecessary cost we could elide > if we batch-remove these resources. We could create a background gc thread > like in FlowFileRepository to handle the actual removal. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2088) InvokeHTTP should check whether it needs to run before retrieving the HttpClient
[ https://issues.apache.org/jira/browse/MINIFICPP-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2088: Fix Version/s: 0.16.0 > InvokeHTTP should check whether it needs to run before retrieving the > HttpClient > > > Key: MINIFICPP-2088 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2088 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Ferenc Gerlits >Priority: Minor > Fix For: 0.16.0 > > Time Spent: 20m > Remaining Estimate: 0h > > InvokeHTTP has setTriggerWhenEmpty=true to support GET requests with no > incoming flow files. But it creates/retrieves the http client even if it's > triggered as POST with no incoming flow files. We should keep the check as > lightweight as possible, and add a bored yield if it didn't need to run. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-1372) Add batch cleanup for ContentRepository
[ https://issues.apache.org/jira/browse/MINIFICPP-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-1372: Fix Version/s: 0.16.0 > Add batch cleanup for ContentRepository > --- > > Key: MINIFICPP-1372 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1372 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.9.0, 0.7.0 >Reporter: Adam Debreceni >Assignee: Adam Debreceni >Priority: Major > Labels: selected-for-development > Fix For: 0.16.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently all content is removed one-by-one whenever the refCount in the > ContentReposiroty::count_map_ goes to 0. For the rocksdb backed > DatabaseContentRepository this results in an unnecessary cost we could elide > if we batch-remove these resources. We could create a background gc thread > like in FlowFileRepository to handle the actual removal. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2182) Add C2 System Load Avg field
[ https://issues.apache.org/jira/browse/MINIFICPP-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2182. - Resolution: Done > Add C2 System Load Avg field > > > Key: MINIFICPP-2182 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2182 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Marton Szasz >Assignee: Gábor Gyimesi >Priority: Major > > https://issues.apache.org/jira/browse/NIFI-11921 > To keep C2 feature parity with MiNiFi Java > heartbeat path: detail.deviceInfo.systemInfo.cpuLoadAverage -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1636: Add System Load Avg field field to C2 and Prometheus metrics
szaszm closed pull request #1636: Add System Load Avg field field to C2 and Prometheus metrics URL: https://github.com/apache/nifi-minifi-cpp/pull/1636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1652: MINIFICPP-2195 fix flaky MQTT docker tests
szaszm closed pull request #1652: MINIFICPP-2195 fix flaky MQTT docker tests URL: https://github.com/apache/nifi-minifi-cpp/pull/1652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1653: MINIFICPP-1076 Yielding processor should still respect scheduling period
szaszm closed pull request #1653: MINIFICPP-1076 Yielding processor should still respect scheduling period URL: https://github.com/apache/nifi-minifi-cpp/pull/1653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1649: MINIFICPP-2102 update Sol2 to v3.3.0
szaszm closed pull request #1649: MINIFICPP-2102 update Sol2 to v3.3.0 URL: https://github.com/apache/nifi-minifi-cpp/pull/1649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1499: MINIFICPP-1372 - Allow async content deletion
szaszm closed pull request #1499: MINIFICPP-1372 - Allow async content deletion URL: https://github.com/apache/nifi-minifi-cpp/pull/1499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1643: MINIFICPP-2088 InvokeHTTP should check whether it needs to run
szaszm closed pull request #1643: MINIFICPP-2088 InvokeHTTP should check whether it needs to run URL: https://github.com/apache/nifi-minifi-cpp/pull/1643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mr1716 opened a new pull request, #7683: NIFI-12046 Update box-java-sdk to 4.4.0
mr1716 opened a new pull request, #7683: URL: https://github.com/apache/nifi/pull/7683 # Summary [NIFI-12046](https://issues.apache.org/jira/browse/NIFI-12046) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-12046) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12046) Update box-java-sdk to 4.4.0
Mike R created NIFI-12046: - Summary: Update box-java-sdk to 4.4.0 Key: NIFI-12046 URL: https://issues.apache.org/jira/browse/NIFI-12046 Project: Apache NiFi Issue Type: Improvement Reporter: Mike R Update box-java-sdk to 4.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-12046) Update box-java-sdk to 4.4.0
[ https://issues.apache.org/jira/browse/NIFI-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-12046: - Assignee: Mike R > Update box-java-sdk to 4.4.0 > > > Key: NIFI-12046 > URL: https://issues.apache.org/jira/browse/NIFI-12046 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update box-java-sdk to 4.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12045) Update jetty-webapp from 10.0.15 to 10.0.16
Mike R created NIFI-12045: - Summary: Update jetty-webapp from 10.0.15 to 10.0.16 Key: NIFI-12045 URL: https://issues.apache.org/jira/browse/NIFI-12045 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.23.2 Reporter: Mike R Update jetty-webapp from 10.0.15 to 10.0.16 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-12044) Update h2 to 2.2.222
[ https://issues.apache.org/jira/browse/NIFI-12044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-12044: - Assignee: Mike R > Update h2 to 2.2.222 > > > Key: NIFI-12044 > URL: https://issues.apache.org/jira/browse/NIFI-12044 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.23.2 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update h2 to 2.2.222 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mr1716 opened a new pull request, #7682: NIFI-12044 Update h2 to 2.2.222
mr1716 opened a new pull request, #7682: URL: https://github.com/apache/nifi/pull/7682 # Summary [NIFI-12044](https://issues.apache.org/jira/browse/NIFI-12044) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-12044) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12044) Update h2 to 2.2.222
Mike R created NIFI-12044: - Summary: Update h2 to 2.2.222 Key: NIFI-12044 URL: https://issues.apache.org/jira/browse/NIFI-12044 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.23.2 Reporter: Mike R Update h2 to 2.2.222 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12043) Update mariadb-java-client to 3.2.0
Mike R created NIFI-12043: - Summary: Update mariadb-java-client to 3.2.0 Key: NIFI-12043 URL: https://issues.apache.org/jira/browse/NIFI-12043 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.23.2 Reporter: Mike R Update mariadb-java-client to 3.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
exceptionfactory commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1323111761
##
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.graph;
+
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.nifi.annotation.behavior.RequiresInstanceClassLoading;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.components.resource.ResourceCardinality;
+import org.apache.nifi.components.resource.ResourceType;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.graph.gremlin.SimpleEntry;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.ssl.SSLContextService;
+import org.apache.nifi.util.StringUtils;
+import org.apache.tinkerpop.gremlin.driver.Client;
+import org.apache.tinkerpop.gremlin.driver.Cluster;
+import org.apache.tinkerpop.gremlin.driver.Result;
+import org.apache.tinkerpop.gremlin.driver.remote.DriverRemoteConnection;
+import org.apache.tinkerpop.gremlin.process.traversal.AnonymousTraversalSource;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource;
+
+import javax.script.Bindings;
+import javax.script.Compilable;
+import javax.script.CompiledScript;
+import javax.script.ScriptEngine;
+import javax.script.ScriptEngineManager;
+import javax.script.ScriptException;
+import java.io.File;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.stream.Collectors;
+
+
+@Tags({"graph", "gremlin"})
+@CapabilityDescription("This service interacts with a tinkerpop-compliant
graph service, providing both script submission and bytecode submission
capabilities. " +
+"Script submission is the default, with the script command being sent
to the gremlin server as text. This should only be used for simple interactions
with a tinkerpop-compliant server. " +
+"Bytecode submission, when providing a jar with the serialization
dependencies, offers much richer way of interacting with the server, and should
be used when doing complex manipulations" +
+" of the underlying data.")
+@RequiresInstanceClassLoading
+public class TinkerpopClientService extends AbstractControllerService
implements GraphClientService {
+public static final String NOT_SUPPORTED = "NOT_SUPPORTED";
+private static final AllowableValue BYTECODE_SUBMISSION = new
AllowableValue("bytecode-submission", "ByteCode Submission",
+"Scripts directly interact with the server via the NiFi JVM"
+);
+
+private static final AllowableValue SCRIPT_SUBMISSION = new
AllowableValue("script-submission", "Script Submission",
+"Script is sent to the gremlin server as a submittion"
+);
+
+private static final AllowableValue YAML_SETTINGS = new
AllowableValue("yaml-settings", "Yaml Settings",
+"Connection to the gremlin server will be specified via a yaml
file (more flexible)");
+
+private static final AllowableValue SERVICE_SETTINGS = new
AllowableValue("service-settings", "Service-Defined Settings",
+"Connection to the gremlin server will be specified
[jira] [Resolved] (NIFI-12042) Refactor Groovy unit test in nifi-mock-record-utils to Java
[ https://issues.apache.org/jira/browse/NIFI-12042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12042. - Fix Version/s: 2.0.0 1.24.0 Resolution: Fixed > Refactor Groovy unit test in nifi-mock-record-utils to Java > --- > > Key: NIFI-12042 > URL: https://issues.apache.org/jira/browse/NIFI-12042 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Fix For: 2.0.0, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The single unit test is TestMockSchemaRegistry.groovy -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12042) Refactor Groovy unit test in nifi-mock-record-utils to Java
[ https://issues.apache.org/jira/browse/NIFI-12042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764204#comment-17764204 ] ASF subversion and git services commented on NIFI-12042: Commit 09c1c8b2b39c37954b195a6b2d7ce09c502d1dec in nifi's branch refs/heads/main from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=09c1c8b2b3 ] NIFI-12042 Refactored Groovy test to Java in nifi-mock-record-utils This closes #7681 Signed-off-by: David Handermann > Refactor Groovy unit test in nifi-mock-record-utils to Java > --- > > Key: NIFI-12042 > URL: https://issues.apache.org/jira/browse/NIFI-12042 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > The single unit test is TestMockSchemaRegistry.groovy -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12042) Refactor Groovy unit test in nifi-mock-record-utils to Java
[ https://issues.apache.org/jira/browse/NIFI-12042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764206#comment-17764206 ] ASF subversion and git services commented on NIFI-12042: Commit 0fd77eff1c635ba07f153501c891989b25e74920 in nifi's branch refs/heads/support/nifi-1.x from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0fd77eff1c ] NIFI-12042 Refactored Groovy test to Java in nifi-mock-record-utils This closes #7681 Signed-off-by: David Handermann (cherry picked from commit 09c1c8b2b39c37954b195a6b2d7ce09c502d1dec) > Refactor Groovy unit test in nifi-mock-record-utils to Java > --- > > Key: NIFI-12042 > URL: https://issues.apache.org/jira/browse/NIFI-12042 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > The single unit test is TestMockSchemaRegistry.groovy -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7681: NIFI-12042 Refactored unit test to Java and removed groovy-json dependency
exceptionfactory closed pull request #7681: NIFI-12042 Refactored unit test to Java and removed groovy-json dependency URL: https://github.com/apache/nifi/pull/7681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12010) Handle auto-commit and commit based on driver capabilities in SQL components
[ https://issues.apache.org/jira/browse/NIFI-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess resolved NIFI-12010. - Fix Version/s: 2.0.0 1.24.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed > Handle auto-commit and commit based on driver capabilities in SQL components > > > Key: NIFI-12010 > URL: https://issues.apache.org/jira/browse/NIFI-12010 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0, 1.24.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Some JDBC drivers throw an exception when calling setAutoCommit(false), even > if the auto-commit setting for the driver is already false. Although > unfortunate, I'm not sure it is a violation of the JDBC API. The SQL > components in NiFi that use the JDBC API should catch > SQLFeatureNotSupportedException and perhaps log a debug message but otherwise > proceed. > Same goes for connection.commit() and connection.rollback(), these should not > be explicitly called if auto-commit is true for the connection. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1638: MINIFICPP-1774 Set properties from command line arguments
szaszm commented on code in PR #1638: URL: https://github.com/apache/nifi-minifi-cpp/pull/1638#discussion_r1312114968 ## controller/CMakeLists.txt: ## @@ -18,6 +18,9 @@ # cmake_minimum_required(VERSION 3.16) +if (CMAKE_VERSION VERSION_GREATER_EQUAL 3.24) +cmake_policy(SET CMP0135 NEW) # policy to set the timestamps of extracted contents to the time of extraction +endif() Review Comment: After #1624, we might as well change the required minimum version here as well, and get rid of the if statement. Anyone who compiles minifi will have CMake 3.24+ anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1654: MINIFICPP-2214 Fix extension list inconsistencies in build scripts
adamdebreceni commented on code in PR #1654: URL: https://github.com/apache/nifi-minifi-cpp/pull/1654#discussion_r1323018871 ## win_build_vs.bat: ## @@ -65,34 +63,33 @@ for %%x in (%*) do ( if [%%~x] EQU [/T]set skiptests=ON if [%%~x] EQU [/R]set skiptestrun=ON if [%%~x] EQU [/P]set cpack=ON -if [%%~x] EQU [/K]set build_kafka=ON -if [%%~x] EQU [/J]set build_JNI=ON -if [%%~x] EQU [/S]set build_SQL=ON -if [%%~x] EQU [/C]set build_coap=ON -if [%%~x] EQU [/A]set build_AWS=ON -if [%%~x] EQU [/SFTP] set build_SFTP=ON -if [%%~x] EQU [/PDH] set build_PDH=ON -if [%%~x] EQU [/SPLUNK] set build_SPLUNK=ON -if [%%~x] EQU [/GCP] set build_GCP=ON -if [%%~x] EQU [/ELASTIC] set build_ELASTIC=ON +if [%%~x] EQU [/NO_KAFKA] set enable_kafka=OFF +if [%%~x] EQU [/J]set enable_jni=ON +if [%%~x] EQU [/NO_SQL] set enable_sql=OFF +if [%%~x] EQU [/C]set enable_coap=ON +if [%%~x] EQU [/NO_AWS] set enable_aws=OFF +if [%%~x] EQU [/PDH] set enable_pdh=ON +if [%%~x] EQU [/NO_SPLUNK]set enable_splunk=OFF +if [%%~x] EQU [/NO_GCP] set enable_gcp=OFF +if [%%~x] EQU [/NO_ELASTIC] set enable_elastic=OFF if [%%~x] EQU [/M]set installer_merge_modules=ON -if [%%~x] EQU [/Z]set build_azure=ON -if [%%~x] EQU [/N]set build_nanofi=ON -if [%%~x] EQU [/O]set build_opencv=ON -if [%%~x] EQU [/PR] set build_prometheus=ON +if [%%~x] EQU [/NO_AZURE] set enable_azure=OFF +if [%%~x] EQU [/N]set enable_nanofi=ON +if [%%~x] EQU [/O]set enable_opencv=ON +if [%%~x] EQU [/NO_PROMETHEUS]set enable_prometheus=OFF if [%%~x] EQU [/BUSTACHE] set enable_bustache=ON if [%%~x] EQU [/COAP] set enable_coap=ON -if [%%~x] EQU [/ENCRYPT_CONFIG] set enable_encrypt_config=ON -if [%%~x] EQU [/LUA_SCRIPTING]set enable_lua_scripting=ON -if [%%~x] EQU [/MQTT] set enable_mqtt=ON -if [%%~x] EQU [/OPC] set enable_opc=ON +if [%%~x] EQU [/NO_ENCRYPT_CONFIG] set enable_encrypt_config=OFF +if [%%~x] EQU [/NO_LUA_SCRIPTING] set enable_lua_scripting=OFF +if [%%~x] EQU [/NO_MQTT] set enable_mqtt=OFF +if [%%~x] EQU [/NO_OPC] set enable_opc=OFF if [%%~x] EQU [/OPENWSMAN]set enable_openwsman=ON -if [%%~x] EQU [/OPS] set enable_ops=ON +if [%%~x] EQU [/NO_OPS] set enable_ops=OFF if [%%~x] EQU [/PCAP] set enable_pcap=ON -if [%%~x] EQU [/PYTHON_SCRIPTING] set enable_python_scripting=ON +if [%%~x] EQU [/NO_PYTHON_SCRIPTING] set enable_python_scripting=OFF Review Comment: what crossed my mind is if we could mirror the arguments like `/std:c++20`, as I understand they are still treated as a single token, but they provide something like a key-value argument, having a "NO_" prefix looks like a strong coupling between how we parametrize `win_build_vs.bat` and the default extensions, while `/MQTT:NO` feels different -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1634: MINIFICPP-2146 Add support for SMB networking protocol
szaszm commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1322944016
##
libminifi/src/utils/file/FileUtils.cpp:
##
@@ -96,4 +100,22 @@ std::filesystem::file_time_type
from_sys(std::chrono::system_clock::time_point s
#endif
}
+#ifdef WIN32
+std::chrono::file_clock::time_point fileTimePointFromFileTime(const FILETIME&
filetime) {
+ static_assert(std::ratio_equal_v>, "file_clock duration must be 100 nanoseconds");
+ std::chrono::file_clock::duration
duration{(static_cast(filetime.dwHighDateTime) << 32) |
filetime.dwLowDateTime};
+ return std::chrono::file_clock::time_point{duration};
+}
+
+nonstd::expected getWindowsFileTimes(const
std::filesystem::path& path) {
+ WIN32_FILE_ATTRIBUTE_DATA file_attributes;
+ auto get_file_attributes_result = GetFileAttributesExW(path.c_str(),
GetFileExInfoStandard, &file_attributes);
+ if (!get_file_attributes_result)
+return
nonstd::make_unexpected(utils::OsUtils::windowsErrorToErrorCode(GetLastError()));
+ return WindowsFileTimes{.creation_time =
fileTimePointFromFileTime(file_attributes.ftCreationTime),
+ .last_access_time =
fileTimePointFromFileTime(file_attributes.ftLastAccessTime),
+ .last_write_time =
fileTimePointFromFileTime(file_attributes.ftLastWriteTime)};
+}
Review Comment:
ok, let's leave it then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (NIFI-12026) PutDatabaseRecord doesn't route error flow file to failure and leaves it in the input queue
[ https://issues.apache.org/jira/browse/NIFI-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Voldemar resolved NIFI-12026. - Resolution: Not A Bug > PutDatabaseRecord doesn't route error flow file to failure and leaves it in > the input queue > --- > > Key: NIFI-12026 > URL: https://issues.apache.org/jira/browse/NIFI-12026 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.23.0, 1.23.2 >Reporter: Voldemar >Priority: Critical > Attachments: image-2023-09-06-10-20-38-026.png, > image-2023-09-06-10-21-30-404.png > > > The "PutDatabaseRecord" processor with Statement Type "INSERT", when an > integrity constraint is violated, do not route error the FlowFile to > "failure" queue. But it cycles through the FlowFile in the queue and > generates errors and bulletins. > It looks like this: > !image-2023-09-06-10-20-38-026.png! > Error message: > !image-2023-09-06-10-21-30-404.png! > This issue likes NIFI-8004 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12026) PutDatabaseRecord doesn't route error flow file to failure and leaves it in the input queue
[ https://issues.apache.org/jira/browse/NIFI-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764120#comment-17764120 ] Voldemar commented on NIFI-12026: - Shame on Me. It resolves by setting "Rollback On Error" to FALSE > PutDatabaseRecord doesn't route error flow file to failure and leaves it in > the input queue > --- > > Key: NIFI-12026 > URL: https://issues.apache.org/jira/browse/NIFI-12026 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.23.0, 1.23.2 >Reporter: Voldemar >Priority: Critical > Attachments: image-2023-09-06-10-20-38-026.png, > image-2023-09-06-10-21-30-404.png > > > The "PutDatabaseRecord" processor with Statement Type "INSERT", when an > integrity constraint is violated, do not route error the FlowFile to > "failure" queue. But it cycles through the FlowFile in the queue and > generates errors and bulletins. > It looks like this: > !image-2023-09-06-10-20-38-026.png! > Error message: > !image-2023-09-06-10-21-30-404.png! > This issue likes NIFI-8004 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12040) Upgrade Apache IoTDB to 1.2.0
[ https://issues.apache.org/jira/browse/NIFI-12040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764083#comment-17764083 ] ASF subversion and git services commented on NIFI-12040: Commit ea1602a0409f982e23f9e5b5474b744b5a228a7d in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ea1602a040 ] NIFI-12040 Upgraded Apache IoTDB from 1.1.2 to 1.2.0 Signed-off-by: Pierre Villard This closes #7680. > Upgrade Apache IoTDB to 1.2.0 > - > > Key: NIFI-12040 > URL: https://issues.apache.org/jira/browse/NIFI-12040 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 20m > Remaining Estimate: 0h > > Apache IoTDB [1.2.0|https://dlcdn.apache.org/iotdb/1.2.0/RELEASE_NOTES.md] > incorporates a number of improvements and bug fixes over version 1.1.2 and > retains compatibility with Java 8 and higher. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12040) Upgrade Apache IoTDB to 1.2.0
[ https://issues.apache.org/jira/browse/NIFI-12040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12040: -- Fix Version/s: 2.0.0 1.24.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Apache IoTDB to 1.2.0 > - > > Key: NIFI-12040 > URL: https://issues.apache.org/jira/browse/NIFI-12040 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 2.0.0, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Apache IoTDB [1.2.0|https://dlcdn.apache.org/iotdb/1.2.0/RELEASE_NOTES.md] > incorporates a number of improvements and bug fixes over version 1.1.2 and > retains compatibility with Java 8 and higher. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12040) Upgrade Apache IoTDB to 1.2.0
[ https://issues.apache.org/jira/browse/NIFI-12040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764082#comment-17764082 ] ASF subversion and git services commented on NIFI-12040: Commit f0b77752030144a06e89d88d94abe4b8065f85b0 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f0b7775203 ] NIFI-12040 Upgraded Apache IoTDB from 1.1.2 to 1.2.0 Signed-off-by: Pierre Villard This closes #7680. > Upgrade Apache IoTDB to 1.2.0 > - > > Key: NIFI-12040 > URL: https://issues.apache.org/jira/browse/NIFI-12040 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Apache IoTDB [1.2.0|https://dlcdn.apache.org/iotdb/1.2.0/RELEASE_NOTES.md] > incorporates a number of improvements and bug fixes over version 1.1.2 and > retains compatibility with Java 8 and higher. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12039) Upgrade Apache Commons DBCP to 2.10.0
[ https://issues.apache.org/jira/browse/NIFI-12039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764080#comment-17764080 ] ASF subversion and git services commented on NIFI-12039: Commit b5bfd258f7d50e14699d2c80b0e2197fd7f8ba54 in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b5bfd258f7 ] NIFI-12039 Upgraded Apache Commons DBCP from 2.9.0 to 2.10.0 Signed-off-by: Pierre Villard This closes #7679. > Upgrade Apache Commons DBCP to 2.10.0 > - > > Key: NIFI-12039 > URL: https://issues.apache.org/jira/browse/NIFI-12039 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 20m > Remaining Estimate: 0h > > Apache Commons DBCP > [2.10.0|https://commons.apache.org/proper/commons-dbcp/changes-report.html#a2.10.0] > includes a number of incremental bug fixes and performance improvements over > version 2.9.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12039) Upgrade Apache Commons DBCP to 2.10.0
[ https://issues.apache.org/jira/browse/NIFI-12039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12039: -- Fix Version/s: 2.0.0 1.24.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Apache Commons DBCP to 2.10.0 > - > > Key: NIFI-12039 > URL: https://issues.apache.org/jira/browse/NIFI-12039 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 2.0.0, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Apache Commons DBCP > [2.10.0|https://commons.apache.org/proper/commons-dbcp/changes-report.html#a2.10.0] > includes a number of incremental bug fixes and performance improvements over > version 2.9.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12039) Upgrade Apache Commons DBCP to 2.10.0
[ https://issues.apache.org/jira/browse/NIFI-12039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764079#comment-17764079 ] ASF subversion and git services commented on NIFI-12039: Commit 73a2d27b1264603cf910cd37cca4def949d69e00 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=73a2d27b12 ] NIFI-12039 Upgraded Apache Commons DBCP from 2.9.0 to 2.10.0 Signed-off-by: Pierre Villard This closes #7679. > Upgrade Apache Commons DBCP to 2.10.0 > - > > Key: NIFI-12039 > URL: https://issues.apache.org/jira/browse/NIFI-12039 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Apache Commons DBCP > [2.10.0|https://commons.apache.org/proper/commons-dbcp/changes-report.html#a2.10.0] > includes a number of incremental bug fixes and performance improvements over > version 2.9.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1634: MINIFICPP-2146 Add support for SMB networking protocol
fgerlits commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1322658175
##
extensions/smb/ListSmb.h:
##
@@ -0,0 +1,152 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include
+#include
+#include
+#include
+#include
+
+#include "SmbConnectionControllerService.h"
+#include "core/Processor.h"
+#include "core/ProcessSession.h"
+#include "core/Property.h"
+#include "core/PropertyDefinition.h"
+#include "core/PropertyDefinitionBuilder.h"
+#include "core/OutputAttributeDefinition.h"
+#include "core/logging/LoggerConfiguration.h"
+#include "utils/Enum.h"
+#include "utils/ListingStateManager.h"
+#include "utils/file/ListedFile.h"
+#include "utils/file/FileUtils.h"
+
+namespace org::apache::nifi::minifi::extensions::smb {
+
+class ListSmb : public core::Processor {
+ public:
+ explicit ListSmb(std::string name, const utils::Identifier& uuid = {})
+ : core::Processor(std::move(name), uuid) {
+ }
+
+ EXTENSIONAPI static constexpr const char* Description = "Retrieves a listing
of files from an SMB share. For each file that is listed, "
+ "creates a FlowFile
that represents the file so that it can be fetched in conjunction with
FetchSmb.";
+
+ EXTENSIONAPI static constexpr auto ConnectionControllerService =
core::PropertyDefinitionBuilder<>::createProperty("SMB Connection Controller
Service")
+ .withDescription("Specifies the SMB connection controller service to use
for connecting to the SMB server.")
+ .isRequired(true)
+ .withAllowedTypes()
+ .build();
+ EXTENSIONAPI static constexpr auto InputDirectory =
core::PropertyDefinitionBuilder<>::createProperty("Input Directory")
+ .withDescription("The input directory from which files to pull files")
+ .isRequired(false)
+ .build();
+ EXTENSIONAPI static constexpr auto RecurseSubdirectories =
core::PropertyDefinitionBuilder<>::createProperty("Recurse Subdirectories")
+ .withDescription("Indicates whether to list files from subdirectories of
the directory")
+ .withPropertyType(core::StandardPropertyTypes::BOOLEAN_TYPE)
+ .withDefaultValue("true")
+ .isRequired(true)
+ .build();
+ EXTENSIONAPI static constexpr auto FileFilter =
core::PropertyDefinitionBuilder<>::createProperty("File Filter")
+ .withDescription("Only files whose names match the given regular
expression will be picked up")
+ .build();
+ EXTENSIONAPI static constexpr auto PathFilter =
core::PropertyDefinitionBuilder<>::createProperty("Path Filter")
+ .withDescription("When Recurse Subdirectories is true, then only
subdirectories whose path matches the given regular expression will be scanned")
+ .build();
+ EXTENSIONAPI static constexpr auto MinimumFileAge =
core::PropertyDefinitionBuilder<>::createProperty("Minimum File Age")
+ .withDescription("The minimum age that a file must be in order to be
pulled; any file younger than this amount of time (according to last
modification date) will be ignored")
+ .isRequired(true)
+ .withPropertyType(core::StandardPropertyTypes::TIME_PERIOD_TYPE)
+ .withDefaultValue("0 sec")
+ .build();
+ EXTENSIONAPI static constexpr auto MaximumFileAge =
core::PropertyDefinitionBuilder<>::createProperty("Maximum File Age")
+ .withDescription("The maximum age that a file must be in order to be
pulled; any file older than this amount of time (according to last modification
date) will be ignored")
+ .build();
+ EXTENSIONAPI static constexpr auto MinimumFileSize =
core::PropertyDefinitionBuilder<>::createProperty("Minimum File Size")
+ .withDescription("The minimum size that a file must be in order to be
pulled")
+ .isRequired(true)
+ .withPropertyType(core::StandardPropertyTypes::DATA_SIZE_TYPE)
+ .withDefaultValue("0 B")
+ .build();
+ EXTENSIONAPI static constexpr auto MaximumFileSize =
core::PropertyDefinitionBuilder<>::createProperty("Maximum File Size")
+ .withDescription("The maximum size that a file can be in order to be
pulled")
+ .build();
+ EXTENSIONAPI static constexpr auto IgnoreHiddenFil
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1634: MINIFICPP-2146 Add support for SMB networking protocol
martinzink commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1322631868
##
libminifi/src/utils/file/FileUtils.cpp:
##
@@ -96,4 +100,22 @@ std::filesystem::file_time_type
from_sys(std::chrono::system_clock::time_point s
#endif
}
+#ifdef WIN32
+std::chrono::file_clock::time_point fileTimePointFromFileTime(const FILETIME&
filetime) {
+ static_assert(std::ratio_equal_v>, "file_clock duration must be 100 nanoseconds");
+ std::chrono::file_clock::duration
duration{(static_cast(filetime.dwHighDateTime) << 32) |
filetime.dwLowDateTime};
+ return std::chrono::file_clock::time_point{duration};
+}
+
+nonstd::expected getWindowsFileTimes(const
std::filesystem::path& path) {
+ WIN32_FILE_ATTRIBUTE_DATA file_attributes;
+ auto get_file_attributes_result = GetFileAttributesExW(path.c_str(),
GetFileExInfoStandard, &file_attributes);
+ if (!get_file_attributes_result)
+return
nonstd::make_unexpected(utils::OsUtils::windowsErrorToErrorCode(GetLastError()));
+ return WindowsFileTimes{.creation_time =
fileTimePointFromFileTime(file_attributes.ftCreationTime),
+ .last_access_time =
fileTimePointFromFileTime(file_attributes.ftLastAccessTime),
+ .last_write_time =
fileTimePointFromFileTime(file_attributes.ftLastWriteTime)};
+}
Review Comment:
I've tried to implement your suggestion (fortunetly macos also has the
creation time concept), but on centos 7 statx is still missing (it needs kernel
4.11 and glibc 2.28), and centos7 uses 2.17 glibc.
And our alpine based docker build also fails due to statx not being exposed
through musl :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1634: MINIFICPP-2146 Add support for SMB networking protocol
martinzink commented on code in PR #1634:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1322609714
##
extensions/smb/ListSmb.h:
##
@@ -0,0 +1,152 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include
+#include
+#include
+#include
+#include
+
+#include "SmbConnectionControllerService.h"
+#include "core/Processor.h"
+#include "core/ProcessSession.h"
+#include "core/Property.h"
+#include "core/PropertyDefinition.h"
+#include "core/PropertyDefinitionBuilder.h"
+#include "core/OutputAttributeDefinition.h"
+#include "core/logging/LoggerConfiguration.h"
+#include "utils/Enum.h"
+#include "utils/ListingStateManager.h"
+#include "utils/file/ListedFile.h"
+#include "utils/file/FileUtils.h"
+
+namespace org::apache::nifi::minifi::extensions::smb {
+
+class ListSmb : public core::Processor {
+ public:
+ explicit ListSmb(std::string name, const utils::Identifier& uuid = {})
+ : core::Processor(std::move(name), uuid) {
+ }
+
+ EXTENSIONAPI static constexpr const char* Description = "Retrieves a listing
of files from an SMB share. For each file that is listed, "
+ "creates a FlowFile
that represents the file so that it can be fetched in conjunction with
FetchSmb.";
+
+ EXTENSIONAPI static constexpr auto ConnectionControllerService =
core::PropertyDefinitionBuilder<>::createProperty("SMB Connection Controller
Service")
+ .withDescription("Specifies the SMB connection controller service to use
for connecting to the SMB server.")
+ .isRequired(true)
+ .withAllowedTypes()
+ .build();
+ EXTENSIONAPI static constexpr auto InputDirectory =
core::PropertyDefinitionBuilder<>::createProperty("Input Directory")
+ .withDescription("The input directory from which files to pull files")
+ .isRequired(false)
+ .build();
+ EXTENSIONAPI static constexpr auto RecurseSubdirectories =
core::PropertyDefinitionBuilder<>::createProperty("Recurse Subdirectories")
+ .withDescription("Indicates whether to list files from subdirectories of
the directory")
+ .withPropertyType(core::StandardPropertyTypes::BOOLEAN_TYPE)
+ .withDefaultValue("true")
+ .isRequired(true)
+ .build();
+ EXTENSIONAPI static constexpr auto FileFilter =
core::PropertyDefinitionBuilder<>::createProperty("File Filter")
+ .withDescription("Only files whose names match the given regular
expression will be picked up")
+ .build();
+ EXTENSIONAPI static constexpr auto PathFilter =
core::PropertyDefinitionBuilder<>::createProperty("Path Filter")
+ .withDescription("When Recurse Subdirectories is true, then only
subdirectories whose path matches the given regular expression will be scanned")
+ .build();
+ EXTENSIONAPI static constexpr auto MinimumFileAge =
core::PropertyDefinitionBuilder<>::createProperty("Minimum File Age")
+ .withDescription("The minimum age that a file must be in order to be
pulled; any file younger than this amount of time (according to last
modification date) will be ignored")
+ .isRequired(true)
+ .withPropertyType(core::StandardPropertyTypes::TIME_PERIOD_TYPE)
+ .withDefaultValue("0 sec")
+ .build();
+ EXTENSIONAPI static constexpr auto MaximumFileAge =
core::PropertyDefinitionBuilder<>::createProperty("Maximum File Age")
+ .withDescription("The maximum age that a file must be in order to be
pulled; any file older than this amount of time (according to last modification
date) will be ignored")
+ .build();
+ EXTENSIONAPI static constexpr auto MinimumFileSize =
core::PropertyDefinitionBuilder<>::createProperty("Minimum File Size")
+ .withDescription("The minimum size that a file must be in order to be
pulled")
+ .isRequired(true)
+ .withPropertyType(core::StandardPropertyTypes::DATA_SIZE_TYPE)
+ .withDefaultValue("0 B")
+ .build();
+ EXTENSIONAPI static constexpr auto MaximumFileSize =
core::PropertyDefinitionBuilder<>::createProperty("Maximum File Size")
+ .withDescription("The maximum size that a file can be in order to be
pulled")
+ .build();
+ EXTENSIONAPI static constexpr auto IgnoreHiddenF
