[jira] [Updated] (NIFI-12053) Update Minimum Build Version to Java 21
[ https://issues.apache.org/jira/browse/NIFI-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12053: Summary: Update Minimum Build Version to Java 21 (was: Update Github CI Builds for 2.x line to Java 21 images Update NiFi Docs/Readme to reference Java 21 as basis) > Update Minimum Build Version to Java 21 > --- > > Key: NIFI-12053 > URL: https://issues.apache.org/jira/browse/NIFI-12053 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12053) Update Minimum Build Version to Java 21
[ https://issues.apache.org/jira/browse/NIFI-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12053. - Fix Version/s: 2.0.0 Assignee: Joe Witt Resolution: Fixed > Update Minimum Build Version to Java 21 > --- > > Key: NIFI-12053 > URL: https://issues.apache.org/jira/browse/NIFI-12053 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12053) Update Github CI Builds for 2.x line to Java 21 images Update NiFi Docs/Readme to reference Java 21 as basis
[ https://issues.apache.org/jira/browse/NIFI-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766981#comment-17766981 ] ASF subversion and git services commented on NIFI-12053: Commit e5894cf943edfd9f2792b70c2f3ba84ebe394508 in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e5894cf943 ] NIFI-12053 Updated Minimum Build Version to Java 21 - Configured GitHub Workflows with Azul Zulu and Amazon Corretto - Added bootstrap.conf option for reflective access supporting Hive 3 This closes #7744 Signed-off-by: David Handermann > Update Github CI Builds for 2.x line to Java 21 images Update NiFi > Docs/Readme to reference Java 21 as basis > > > Key: NIFI-12053 > URL: https://issues.apache.org/jira/browse/NIFI-12053 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7744: NIFI-12053 - Update Github CI Builds for 2.x line to Java 21 images Update NiFi Docs/Readme to reference Java 21 as basis
exceptionfactory closed pull request #7744: NIFI-12053 - Update Github CI Builds for 2.x line to Java 21 images Update NiFi Docs/Readme to reference Java 21 as basis URL: https://github.com/apache/nifi/pull/7744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-3929) Allow external key management for EncryptContent processor
[
https://issues.apache.org/jira/browse/NIFI-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-3929.
Resolution: Won't Do
> Allow external key management for EncryptContent processor
> --
>
> Key: NIFI-3929
> URL: https://issues.apache.org/jira/browse/NIFI-3929
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
>Reporter: Andy LoPresto
>Priority: Major
> Labels: encryption, key-management, security
>
> Currently the {{EncryptContent}} processor (and a future {{EncryptAttribute}}
> processor) can only use a static key (or password-derived key) to
> encrypt/decrypt data. Similar to the {{KeyProvider}} interface used in the
> {{EncryptedWriteAheadProvenanceRepository}} that exposes multiple back-end
> implementations ({{StaticKeyProvider}}, {{FileBasedKeyProvider}}, etc.), a
> generic key management controller service is proposed in
> [NIFI-3890|https://issues.apache.org/jira/browse/NIFI-3890], and this
> processor should add support for consuming the CS and using it to dynamically
> access provided keys for encryption/decryption operations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-6669) Allow arbitrary IV values in EncryptContent processor when running in decrypt mode
[
https://issues.apache.org/jira/browse/NIFI-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-6669.
Resolution: Won't Do
> Allow arbitrary IV values in EncryptContent processor when running in decrypt
> mode
> --
>
> Key: NIFI-6669
> URL: https://issues.apache.org/jira/browse/NIFI-6669
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.9.2
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
> Labels: encryption, initialization-vector, security
>
> As discussed in the Apache NiFi Slack instance recently:
>
> {quote}
> [RuthMizzi|https://app.slack.com/team/UN6KDKGMB] [3 days
> ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568103042185700]
> Hello - wondering whether anyone can help me with question I have using the
> EncryptContent nifi component for decryption of messages received from
> maxwell daemon .. has anyone ever done this before?
>
> [Andy LoPresto|https://app.slack.com/team/U0LA8HR55] [3 days
> ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568138070190500?thread_ts=1568103042.185700=C0L9VCD47]
> This won’t work out of the box. Maxwell’s Daemon uses {{AES/CBC/NoPadding}}
> cipher mode of operation ([https://maxwells-daemon.io/encryption/]), which
> NiFi does support, but it generates a unique IV and sends both encoded in
> Base64. The underlying code in NiFi supports unique IVs but it is not
> currently exposed to the {{EncryptContent}} processor. I would suggest the
> following approach:
> 1. Submit a Jira requesting this feature and assign it to me. By adding an
> optional IV property, we can allow unique input for every decryption
> operation, and this value can be extracted from the JSON to a flowfile
> attribute in a preceding {{EvaluateJsonPath}} processor. We will need to
> eagerly detect Base64 encoding vs. Hex encoding for this input.
> 2. Write an {{ExecuteScript}} processor which consumes the two JSON values
> and calls simple decrypt logic in Groovy. I can help generate this if you
> need it.
>
> [RuthMizzi|https://app.slack.com/team/UN6KDKGMB][9 hours
> ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568361404228800?thread_ts=1568103042.185700=C0L9VCD47]
> thanks so much for your detailed response! In the meantime we convinced our
> data sources to send the data unencrypted but over a secured ssl kafka
> connection and therefore got around the issue -- but i really appreciate the
> knowledge shared. Thanks again
> {quote}
>
> The IV property descriptor should not be required, should support Expression
> Language, and should detect Base64 and Hex encoded values and validate them
> against the correct block length for the selected mode of operation via
> custom validation.
>
> We may also want a dropdown of "IV strategies" such as "IV prepended", "IV
> prepended with delimiter", etc. to handle incoming flowfile content which
> already has a per-ciphertext IV prepended.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12094) Remove EncryptContent Processor
David Handermann created NIFI-12094: --- Summary: Remove EncryptContent Processor Key: NIFI-12094 URL: https://issues.apache.org/jira/browse/NIFI-12094 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: David Handermann Assignee: David Handermann Fix For: 2.0.0 The EncryptContent Processor should be removed from the main branch based on the availability of better alternatives. The EncryptContentAge and DecryptContentAge Processors provide asymmetric key exchange and authenticated encryption using the standard age-encryption.org/v1 specification. The EncryptContentPGP and DecryptContentPGP Processors provide broad compatibility with OpenPGP, and the DecryptContent and DecryptContentCompatibility Processors provide backward compatible decryption for files encrypted using various EncryptContent configurations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12093) Deprecate EncryptContent Processor for Removal
David Handermann created NIFI-12093: --- Summary: Deprecate EncryptContent Processor for Removal Key: NIFI-12093 URL: https://issues.apache.org/jira/browse/NIFI-12093 Project: Apache NiFi Issue Type: Improvement Reporter: David Handermann Assignee: David Handermann Fix For: 1.24.0 The EncryptContent Processor should be deprecated on the support branch for subsequent removal from the main branch based on the availability of better alternatives. The EncryptContentPGP and DecryptContentPGP Processors incorporate the OpenPGP capabilities of EncryptContent and provide both performance and capability improvements. The DecryptContent and DecryptContentCompatibility Processors support decrypting existing files encrypted with various settings available in EncryptContent. The newer EncryptContentAge and DecryptContentAge Processors provide a modern alternative to OpenPGP and support simplified configuration options. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12093) Deprecate EncryptContent Processor for Removal
[ https://issues.apache.org/jira/browse/NIFI-12093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12093: Component/s: Extensions > Deprecate EncryptContent Processor for Removal > -- > > Key: NIFI-12093 > URL: https://issues.apache.org/jira/browse/NIFI-12093 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 1.24.0 > > > The EncryptContent Processor should be deprecated on the support branch for > subsequent removal from the main branch based on the availability of better > alternatives. > The EncryptContentPGP and DecryptContentPGP Processors incorporate the > OpenPGP capabilities of EncryptContent and provide both performance and > capability improvements. The DecryptContent and DecryptContentCompatibility > Processors support decrypting existing files encrypted with various settings > available in EncryptContent. The newer EncryptContentAge and > DecryptContentAge Processors provide a modern alternative to OpenPGP and > support simplified configuration options. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12092) Add exponential backoff to JettyWebsocketClient reconnect
[ https://issues.apache.org/jira/browse/NIFI-12092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lehel Boér updated NIFI-12092: -- Status: Patch Available (was: In Progress) > Add exponential backoff to JettyWebsocketClient reconnect > - > > Key: NIFI-12092 > URL: https://issues.apache.org/jira/browse/NIFI-12092 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > > The reconnection attempts were happening too quickly in JettyWebsocketClient. > A customizable exponential backoff with 20% jitter is added to prevent > overloading. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] Lehel44 opened a new pull request, #7761: Add backoff parameters to JettyWebsocketClient reconnect
Lehel44 opened a new pull request, #7761: URL: https://github.com/apache/nifi/pull/7761 # Summary [NIFI-12092](https://issues.apache.org/jira/browse/NIFI-12092) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12092) Add exponential backoff to JettyWebsocketClient reconnect
Lehel Boér created NIFI-12092: - Summary: Add exponential backoff to JettyWebsocketClient reconnect Key: NIFI-12092 URL: https://issues.apache.org/jira/browse/NIFI-12092 Project: Apache NiFi Issue Type: Improvement Reporter: Lehel Boér Assignee: Lehel Boér The reconnection attempts were happening too quickly in JettyWebsocketClient. A customizable exponential backoff with 20% jitter is added to prevent overloading. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12091) TestListenTCPRecord hangs on Windows frequently
[ https://issues.apache.org/jira/browse/NIFI-12091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766936#comment-17766936 ] Joe Witt commented on NIFI-12091: - Was able to reproduce this on osx. By commenting out TestListenTCPRecord lines 220-229 which simulates us missing the message send of records. The processor does its job and just waits in a loop indefinitely. But the test never finishes because the records were never sent or will never be received. > TestListenTCPRecord hangs on Windows frequently > > > Key: NIFI-12091 > URL: https://issues.apache.org/jira/browse/NIFI-12091 > Project: Apache NiFi > Issue Type: Test > Environment: Apache Maven 3.9.4 > (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) > Maven home: C:\development\tools\apache-maven-3.9.4 > Java version: 21, vendor: Azul Systems, Inc., runtime: C:\Program > Files\Zulu\zulu-21 > Default locale: en_US, platform encoding: UTF-8 > OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows" >Reporter: Joe Witt >Priority: Major > Attachments: jstack.out > > > attaching a stack dump -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12091) TestListenTCPRecord hangs on Windows frequently
[ https://issues.apache.org/jira/browse/NIFI-12091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12091: Attachment: jstack.out > TestListenTCPRecord hangs on Windows frequently > > > Key: NIFI-12091 > URL: https://issues.apache.org/jira/browse/NIFI-12091 > Project: Apache NiFi > Issue Type: Test > Environment: Apache Maven 3.9.4 > (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) > Maven home: C:\development\tools\apache-maven-3.9.4 > Java version: 21, vendor: Azul Systems, Inc., runtime: C:\Program > Files\Zulu\zulu-21 > Default locale: en_US, platform encoding: UTF-8 > OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows" >Reporter: Joe Witt >Priority: Major > Attachments: jstack.out > > > attaching a stack dump -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12091) TestListenTCPRecord hangs on Windows frequently
Joe Witt created NIFI-12091: --- Summary: TestListenTCPRecord hangs on Windows frequently Key: NIFI-12091 URL: https://issues.apache.org/jira/browse/NIFI-12091 Project: Apache NiFi Issue Type: Test Environment: Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: C:\development\tools\apache-maven-3.9.4 Java version: 21, vendor: Azul Systems, Inc., runtime: C:\Program Files\Zulu\zulu-21 Default locale: en_US, platform encoding: UTF-8 OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows" Reporter: Joe Witt attaching a stack dump -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] dan-s1 commented on pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on PR #7752: URL: https://github.com/apache/nifi/pull/7752#issuecomment-1726467071 @exceptionfactory I made the changes. That one test was actually using an instance variable and a method variable both annotated with `TempDir`. I kept the instance variable annotated as it is used by the other tests and I created a class variable for the temp file without the use of `TempDir` representing the jar file to load. Hopefully that will work on the Windows CI build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11903) TestZookeeperStateServer does not need to run on windows
[ https://issues.apache.org/jira/browse/NIFI-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-11903: Fix Version/s: 1.24.0 > TestZookeeperStateServer does not need to run on windows > > > Key: NIFI-11903 > URL: https://issues.apache.org/jira/browse/NIFI-11903 > Project: Apache NiFi > Issue Type: Test >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > On a windows machine I constantly see failures from the > testzookeeperstateserver class. This class does not need to be tested on > windows. We dont support clusters on windows. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11903) TestZookeeperStateServer does not need to run on windows
[ https://issues.apache.org/jira/browse/NIFI-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766926#comment-17766926 ] ASF subversion and git services commented on NIFI-11903: Commit bf0bb8136156315ad6d0539a56cf1d4b4c63d2ce in nifi's branch refs/heads/support/nifi-1.x from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=bf0bb81361 ] NIFI-11903 disable if windows (#7566) > TestZookeeperStateServer does not need to run on windows > > > Key: NIFI-11903 > URL: https://issues.apache.org/jira/browse/NIFI-11903 > Project: Apache NiFi > Issue Type: Test >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > On a windows machine I constantly see failures from the > testzookeeperstateserver class. This class does not need to be tested on > windows. We dont support clusters on windows. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12038) Create processor to package FlowFiles
[ https://issues.apache.org/jira/browse/NIFI-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael W Moser updated NIFI-12038: --- Status: Patch Available (was: In Progress) > Create processor to package FlowFiles > - > > Key: NIFI-12038 > URL: https://issues.apache.org/jira/browse/NIFI-12038 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Michael W Moser >Assignee: Michael W Moser >Priority: Minor > > h4. Design Goals > Provide a simple way to package FlowFile attributes and content into > FlowFileV3 format that can be exported from NiFi and reimported later. > MergeContent can do this, but it is not intuitive that it has this > capability, and it can be complicated to setup perfectly. > h4. Use Cases > * Package FlowFile for external (off-NiFi) storage, for later ingest back > into NiFi using an ingress processor followed by UnpackContent > * Package FlowFile for NiFi-to-NiFi transfer when a direct connection is not > possible, or another transfer mechanism is required > * Package FlowFile then InvokeHTTP directly to another NiFi running > ListenHTTP, which can natively unpack FlowFileV3 format > h4. Other Ideas > * Offer best-effort, no guarantee N FlowFiles to 1 bundling > * Create new FlowFile serialization format to support interoperability with > non-NiFi services, such as core operating system tools -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mosermw opened a new pull request, #7760: NIFI-12038 introduce PackageFlowFile processor and fix an NPE in FlowFilePackagerV3
mosermw opened a new pull request, #7760: URL: https://github.com/apache/nifi/pull/7760 # Summary [NIFI-12038](https://issues.apache.org/jira/browse/NIFI-12038) New PackageFlowFile processor, which will package FlowFile attributes and content into an output FlowFile that can be exported from NiFi and imported back into NiFi, preserving the original attributes and content. While testing this, I found and fixed an issue with FlowFilePackagerV3 where an attribute with a null value causes NullPointerException. See NIFI-4298 for how to get attributes with null value. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 17 ### Licensing - [n/a] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [n/a] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-11903) TestZookeeperStateServer does not need to run on windows
[ https://issues.apache.org/jira/browse/NIFI-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-11903. --- Fix Version/s: 2.0.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed > TestZookeeperStateServer does not need to run on windows > > > Key: NIFI-11903 > URL: https://issues.apache.org/jira/browse/NIFI-11903 > Project: Apache NiFi > Issue Type: Test >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > On a windows machine I constantly see failures from the > testzookeeperstateserver class. This class does not need to be tested on > windows. We dont support clusters on windows. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11903) TestZookeeperStateServer does not need to run on windows
[ https://issues.apache.org/jira/browse/NIFI-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766922#comment-17766922 ] ASF subversion and git services commented on NIFI-11903: Commit 017b16254bdd0b4a0ddb084b0370ee2dfbc30597 in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=017b16254b ] NIFI-11903 disable if windows (#7566) > TestZookeeperStateServer does not need to run on windows > > > Key: NIFI-11903 > URL: https://issues.apache.org/jira/browse/NIFI-11903 > Project: Apache NiFi > Issue Type: Test >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 20m > Remaining Estimate: 0h > > On a windows machine I constantly see failures from the > testzookeeperstateserver class. This class does not need to be tested on > windows. We dont support clusters on windows. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11903) TestZookeeperStateServer does not need to run on windows
[ https://issues.apache.org/jira/browse/NIFI-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766921#comment-17766921 ] ASF subversion and git services commented on NIFI-11903: Commit 490810452c092b0121c3ac3c5f3e54bbc1324103 in nifi's branch refs/heads/NIFI-11903 from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=490810452c ] NIFI-11903 disable if windows > TestZookeeperStateServer does not need to run on windows > > > Key: NIFI-11903 > URL: https://issues.apache.org/jira/browse/NIFI-11903 > Project: Apache NiFi > Issue Type: Test >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 20m > Remaining Estimate: 0h > > On a windows machine I constantly see failures from the > testzookeeperstateserver class. This class does not need to be tested on > windows. We dont support clusters on windows. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] dan-s1 commented on pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on PR #7752:
URL: https://github.com/apache/nifi/pull/7752#issuecomment-1726403205
Another option mentioned in the ticket involves not using the TempDir
annotation and instead using
```
private static Path tempDir;
@BeforeAll
public static void before() throws IOException {
tempDir = Files.createTempDirectory(null);
}
@AfterAll
public static void after() {
tempDir.toFile().delete();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-12090) Upgrade to Maven 4 for the build process (once Maven 4 is released)
Joe Witt created NIFI-12090: --- Summary: Upgrade to Maven 4 for the build process (once Maven 4 is released) Key: NIFI-12090 URL: https://issues.apache.org/jira/browse/NIFI-12090 Project: Apache NiFi Issue Type: Improvement Reporter: Joe Witt This suggests we can get rid of the nifi-nar-maven-plugin as its own separate release and just include it back in the main nifi source tree. https://maven.apache.org/guides/mini/guide-multiple-modules-4.html Probably many other benefits/considerations. https://maarten.mulders.it/2020/11/whats-new-in-maven-4/ Maven 4 has no currently known release date (that I am aware of). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] malthe commented on pull request #7076: NIFI-11294 - Add support for component state as checkpointing strategy
malthe commented on PR #7076: URL: https://github.com/apache/nifi/pull/7076#issuecomment-1726349415 @turcsanyip please do – I am currently not actively using NiFi so just following along from the sideline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1663: MINIFICPP-2223 Add .asf.yaml file to configure repository labels
lordgamez commented on code in PR #1663: URL: https://github.com/apache/nifi-minifi-cpp/pull/1663#discussion_r1330579686 ## .asf.yaml: ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +github: + description: "Apache NiFi - MiNiFi C++" + homepage: https://nifi.apache.org/minifi/ + labels: +- nifi +- c++ +- hacktoberfest Review Comment: I didn't want to remove the `nifi` label as we already have that at the moment, but we can add the `minifi` label too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a diff in pull request #7644: NIFI-11992: Processor and sink service for filing tickets in Zendesk
turcsanyip commented on code in PR #7644:
URL: https://github.com/apache/nifi/pull/7644#discussion_r1330557343
##
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-common/src/main/java/org/apache/nifi/common/zendesk/ZendeskProperties.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.common.zendesk;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.web.client.provider.api.WebClientServiceProvider;
+
+public final class ZendeskProperties {
+
+public static final String WEB_CLIENT_SERVICE_PROVIDER_NAME =
"web-client-service-provider";
+public static final String ZENDESK_SUBDOMAIN_NAME = "zendesk-subdomain";
+public static final String ZENDESK_USER_NAME = "zendesk-user";
+public static final String ZENDESK_AUTHENTICATION_TYPE_NAME =
"zendesk-authentication-type-name";
+public static final String ZENDESK_AUTHENTICATION_CREDENTIAL_NAME =
"zendesk-authentication-value-name";
+public static final String ZENDESK_TICKET_COMMENT_BODY_NAME =
"zendesk-comment-body";
+public static final String ZENDESK_TICKET_SUBJECT_NAME = "zendesk-subject";
+public static final String ZENDESK_TICKET_PRIORITY_NAME =
"zendesk-priority";
+public static final String ZENDESK_TICKET_TYPE_NAME = "zendesk-type";
+public static final String HTTPS = "https";
+public static final String APPLICATION_JSON = "application/json";
+public static final String ZENDESK_HOST_TEMPLATE = "%s.zendesk.com";
+public static final String ZENDESK_CREATE_TICKET_RESOURCE =
"/api/v2/tickets";
+public static final String ZENDESK_CREATE_TICKETS_RESOURCE =
"/api/v2/tickets/create_many";
+
+public static final String ZENDESK_TICKET_ROOT_NODE = "/ticket";
+public static final String ZENDESK_TICKETS_ROOT_NODE = "/tickets";
+
+public static final String REL_SUCCESS_NAME = "success";
+public static final String REL_FAILURE_NAME = "failure";
+
+private ZendeskProperties() {}
+
+public static final PropertyDescriptor WEB_CLIENT_SERVICE_PROVIDER = new
PropertyDescriptor.Builder()
+.name(WEB_CLIENT_SERVICE_PROVIDER_NAME)
+.displayName("Web Client Service Provider")
+.description("Controller service for HTTP client operations.")
+.identifiesControllerService(WebClientServiceProvider.class)
+.required(true)
+.build();
+
+public static final PropertyDescriptor ZENDESK_SUBDOMAIN = new
PropertyDescriptor.Builder()
+.name(ZENDESK_SUBDOMAIN_NAME)
+.displayName("Zendesk Subdomain Name")
Review Comment:
I know these are not new properties but I would suggest removing the
"Zendesk" prefix from the display name. Typically we don't add prefix because
the context is already given by the processor and all properties would start
with the same tag.
##
nifi-nar-bundles/nifi-zendesk-bundle/nifi-zendesk-processors/src/main/java/org/apache/nifi/processors/zendesk/PutZendeskTicket.java:
##
@@ -0,0 +1,283 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.zendesk;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.node.ObjectNode;
+import
[jira] [Updated] (NIFI-12075) Deprecate log methods with Object[] + Throwable parameters in ComponentLog
[
https://issues.apache.org/jira/browse/NIFI-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12075:
Fix Version/s: 1.24.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Deprecate log methods with Object[] + Throwable parameters in ComponentLog
> --
>
> Key: NIFI-12075
> URL: https://issues.apache.org/jira/browse/NIFI-12075
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0, 1.24.0
>
>
> {{ComponentLog}} defines
> {code:java}
> void error(String msg, Object[] os, Throwable t)
> {code}
> and similar methods where the caller needs to create the {{Object}} array
> explicitly which results in boilerplate and less readable code.
> The preferred way has been for a while to use the vararg signature instead:
> {code:java}
> void error(String msg, Object... os)
> {code}
> These methods can also handle the last {{Throwable}} argument properly.
> The {{Object[]}} methods should be deprecated and the existing usages should
> be migrated to use the vararg methods. In 2.0 the deprecated methods can be
> removed (NIFI-12076).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12075) Deprecate log methods with Object[] + Throwable parameters in ComponentLog
[
https://issues.apache.org/jira/browse/NIFI-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766902#comment-17766902
]
ASF subversion and git services commented on NIFI-12075:
Commit e07bb19233de81513a5218ed782c782b26591bb3 in nifi's branch
refs/heads/support/nifi-1.x from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e07bb19233 ]
NIFI-12075 Deprecated ComponentLog methods with Object[] and Throwable
- Updated component references to remove use of Object[] wrapping for log
methods
This closes #7758
Signed-off-by: David Handermann
> Deprecate log methods with Object[] + Throwable parameters in ComponentLog
> --
>
> Key: NIFI-12075
> URL: https://issues.apache.org/jira/browse/NIFI-12075
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0
>
>
> {{ComponentLog}} defines
> {code:java}
> void error(String msg, Object[] os, Throwable t)
> {code}
> and similar methods where the caller needs to create the {{Object}} array
> explicitly which results in boilerplate and less readable code.
> The preferred way has been for a while to use the vararg signature instead:
> {code:java}
> void error(String msg, Object... os)
> {code}
> These methods can also handle the last {{Throwable}} argument properly.
> The {{Object[]}} methods should be deprecated and the existing usages should
> be migrated to use the vararg methods. In 2.0 the deprecated methods can be
> removed (NIFI-12076).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on pull request #7758: NIFI-12075 Deprecated ComponentLog methods with Object[] and Throwable [support/nifi-1.x]
exceptionfactory commented on PR #7758: URL: https://github.com/apache/nifi/pull/7758#issuecomment-1726266805 Merged in https://github.com/apache/nifi/commit/e07bb19233de81513a5218ed782c782b26591bb3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7758: NIFI-12075 Deprecated ComponentLog methods with Object[] and Throwable [support/nifi-1.x]
exceptionfactory closed pull request #7758: NIFI-12075 Deprecated ComponentLog methods with Object[] and Throwable [support/nifi-1.x] URL: https://github.com/apache/nifi/pull/7758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on pull request #7076: NIFI-11294 - Add support for component state as checkpointing strategy
turcsanyip commented on PR #7076: URL: https://github.com/apache/nifi/pull/7076#issuecomment-1726259417 @malthe Just a heads-up that [NIFI-11595](https://issues.apache.org/jira/browse/NIFI-11595) has been merged fixing the `replaceState()` logic I mentioned in [my previous comment](https://github.com/apache/nifi/pull/7076#discussion_r1206003566). It makes the state handling of the checkpoints simpler, though it was not a blocker. Considering that there was no activity on the PR in the past months, I would like to ask if you are still interested in this feature? Do you intend to finish the PR? I'm happy to jump in and continue the implementation based on your PR if you have other interests now. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12076) Remove deprecated log methods with Object[] + Throwable parameters in ComponentLog
[
https://issues.apache.org/jira/browse/NIFI-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-12076.
-
Fix Version/s: 2.0.0
(was: 2.latest)
Resolution: Fixed
> Remove deprecated log methods with Object[] + Throwable parameters in
> ComponentLog
> --
>
> Key: NIFI-12076
> URL: https://issues.apache.org/jira/browse/NIFI-12076
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0
>
>
> Remove the deprecated {{error(String msg, Object[] os, Throwable t)}} and
> similar methods in ComponentLog. See NIFI-12075.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12076) Remove deprecated log methods with Object[] + Throwable parameters in ComponentLog
[
https://issues.apache.org/jira/browse/NIFI-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12076:
Epic Link: NIFI-11169
> Remove deprecated log methods with Object[] + Throwable parameters in
> ComponentLog
> --
>
> Key: NIFI-12076
> URL: https://issues.apache.org/jira/browse/NIFI-12076
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.latest
>
>
> Remove the deprecated {{error(String msg, Object[] os, Throwable t)}} and
> similar methods in ComponentLog. See NIFI-12075.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12076) Remove deprecated log methods with Object[] + Throwable parameters in ComponentLog
[
https://issues.apache.org/jira/browse/NIFI-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766900#comment-17766900
]
ASF subversion and git services commented on NIFI-12076:
Commit 520840d93b875ec3cba0c7792a80a25c9236b332 in nifi's branch
refs/heads/main from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=520840d93b ]
NIFI-12076 Removed ComponentLog methods with Object[] and Throwable
This closes #7759
Signed-off-by: David Handermann
> Remove deprecated log methods with Object[] + Throwable parameters in
> ComponentLog
> --
>
> Key: NIFI-12076
> URL: https://issues.apache.org/jira/browse/NIFI-12076
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.latest
>
>
> Remove the deprecated {{error(String msg, Object[] os, Throwable t)}} and
> similar methods in ComponentLog. See NIFI-12075.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7759: NIFI-12076 Removed log methods with Object[] + Throwable parameters f…
exceptionfactory closed pull request #7759: NIFI-12076 Removed log methods with Object[] + Throwable parameters f… URL: https://github.com/apache/nifi/pull/7759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12087) Remove all deprecated items in the nifi-api
[ https://issues.apache.org/jira/browse/NIFI-12087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12087: Fix Version/s: 2.0.0 > Remove all deprecated items in the nifi-api > --- > > Key: NIFI-12087 > URL: https://issues.apache.org/jira/browse/NIFI-12087 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12087) Remove all deprecated items in the nifi-api
[ https://issues.apache.org/jira/browse/NIFI-12087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12087: Epic Link: (was: NIFI-12049) > Remove all deprecated items in the nifi-api > --- > > Key: NIFI-12087 > URL: https://issues.apache.org/jira/browse/NIFI-12087 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12085) Update spring.security.version to 5.8.7
[ https://issues.apache.org/jira/browse/NIFI-12085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12085: Labels: dependency-upgrade (was: ) > Update spring.security.version to 5.8.7 > --- > > Key: NIFI-12085 > URL: https://issues.apache.org/jira/browse/NIFI-12085 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Major > Labels: dependency-upgrade > > Update spring.security.version to 5.8.7 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12085) Update spring.security.version to 5.8.7
[ https://issues.apache.org/jira/browse/NIFI-12085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12085. - Fix Version/s: 2.0.0 1.24.0 Resolution: Fixed > Update spring.security.version to 5.8.7 > --- > > Key: NIFI-12085 > URL: https://issues.apache.org/jira/browse/NIFI-12085 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Major > Labels: dependency-upgrade > Fix For: 2.0.0, 1.24.0 > > > Update spring.security.version to 5.8.7 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12085) Update spring.security.version to 5.8.7
[ https://issues.apache.org/jira/browse/NIFI-12085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12085: Affects Version/s: (was: 1.23.2) > Update spring.security.version to 5.8.7 > --- > > Key: NIFI-12085 > URL: https://issues.apache.org/jira/browse/NIFI-12085 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update spring.security.version to 5.8.7 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12085) Update spring.security.version to 5.8.7
[ https://issues.apache.org/jira/browse/NIFI-12085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766894#comment-17766894 ] ASF subversion and git services commented on NIFI-12085: Commit e281d134997a9314b88b5f16e93b8021f4e5f279 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e281d13499 ] NIFI-12085 Upgraded Spring Security from 5.8.6 to 5.8.7 This closes #7756 Signed-off-by: David Handermann > Update spring.security.version to 5.8.7 > --- > > Key: NIFI-12085 > URL: https://issues.apache.org/jira/browse/NIFI-12085 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.23.2 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update spring.security.version to 5.8.7 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12085) Update spring.security.version to 5.8.7
[ https://issues.apache.org/jira/browse/NIFI-12085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766895#comment-17766895 ] ASF subversion and git services commented on NIFI-12085: Commit 36956a709141f20786e38a0482516a6351e254c0 in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=36956a7091 ] NIFI-12085 Upgraded Spring Security from 5.8.6 to 5.8.7 This closes #7756 Signed-off-by: David Handermann (cherry picked from commit e281d134997a9314b88b5f16e93b8021f4e5f279) > Update spring.security.version to 5.8.7 > --- > > Key: NIFI-12085 > URL: https://issues.apache.org/jira/browse/NIFI-12085 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.23.2 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update spring.security.version to 5.8.7 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11595) StateProvider.replace() cannot create the initial state
[
https://issues.apache.org/jira/browse/NIFI-11595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11595:
Fix Version/s: 2.0.0
1.24.0
(was: 1.latest)
(was: 2.latest)
Resolution: Fixed
Status: Resolved (was: Patch Available)
> StateProvider.replace() cannot create the initial state
> ---
>
> Key: NIFI-11595
> URL: https://issues.apache.org/jira/browse/NIFI-11595
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0, 1.24.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{StateProvider.replace()}} method properly works when the state already
> exists and persisted in the storage. However, it cannot create the state at
> first run.
> As a workaround, {{setState()}} needs to be used but it does not provide the
> same compare-and-swap mechanism as {{replace()}} so it is the caller
> responsibility to handle concurrency.
> To lift this responsibility from the clients and also to provide a more
> consistent API, {{replace()}} should support creating the initial state. It
> should be able to move the state "from nothing to X" not only "from X1 to X2"
> and also providing the same compare-and-swap logic.
> Affected {{StateProvider}} implementations:
> - {{ZooKeeperStateProvider}}
> - {{RedisStateProvider}}
> - {{KubernetesConfigMapStateProvider}}
> - {{WriteAheadLocalStateProvider}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11595) StateProvider.replace() cannot create the initial state
[
https://issues.apache.org/jira/browse/NIFI-11595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766892#comment-17766892
]
ASF subversion and git services commented on NIFI-11595:
Commit 878d2e025f2464dad5ff95e2a095ea22036a0f2e in nifi's branch
refs/heads/support/nifi-1.x from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=878d2e025f ]
NIFI-11595 StateProvider.replace() supports creating the initial state
- Extracted common logic from setState() and replace() into modifyState()
- Removed redundant code from createNode() because exceptions are handled on
the caller side
- NodeExistsException and InterruptedException are handled in setState() and
replace()
- Also used KeeperException's subclasses instead of KeeperException.code()
This closes #7324
Signed-off-by: David Handermann
(cherry picked from commit ac80b9d900221fedb59142e4a4802bf4ab2a17f4)
> StateProvider.replace() cannot create the initial state
> ---
>
> Key: NIFI-11595
> URL: https://issues.apache.org/jira/browse/NIFI-11595
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 1.latest, 2.latest
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{StateProvider.replace()}} method properly works when the state already
> exists and persisted in the storage. However, it cannot create the state at
> first run.
> As a workaround, {{setState()}} needs to be used but it does not provide the
> same compare-and-swap mechanism as {{replace()}} so it is the caller
> responsibility to handle concurrency.
> To lift this responsibility from the clients and also to provide a more
> consistent API, {{replace()}} should support creating the initial state. It
> should be able to move the state "from nothing to X" not only "from X1 to X2"
> and also providing the same compare-and-swap logic.
> Affected {{StateProvider}} implementations:
> - {{ZooKeeperStateProvider}}
> - {{RedisStateProvider}}
> - {{KubernetesConfigMapStateProvider}}
> - {{WriteAheadLocalStateProvider}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11595) StateProvider.replace() cannot create the initial state
[
https://issues.apache.org/jira/browse/NIFI-11595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766890#comment-17766890
]
ASF subversion and git services commented on NIFI-11595:
Commit ac80b9d900221fedb59142e4a4802bf4ab2a17f4 in nifi's branch
refs/heads/main from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ac80b9d900 ]
NIFI-11595 StateProvider.replace() supports creating the initial state
- Extracted common logic from setState() and replace() into modifyState()
- Removed redundant code from createNode() because exceptions are handled on
the caller side
- NodeExistsException and InterruptedException are handled in setState() and
replace()
- Also used KeeperException's subclasses instead of KeeperException.code()
This closes #7324
Signed-off-by: David Handermann
> StateProvider.replace() cannot create the initial state
> ---
>
> Key: NIFI-11595
> URL: https://issues.apache.org/jira/browse/NIFI-11595
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 1.latest, 2.latest
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{StateProvider.replace()}} method properly works when the state already
> exists and persisted in the storage. However, it cannot create the state at
> first run.
> As a workaround, {{setState()}} needs to be used but it does not provide the
> same compare-and-swap mechanism as {{replace()}} so it is the caller
> responsibility to handle concurrency.
> To lift this responsibility from the clients and also to provide a more
> consistent API, {{replace()}} should support creating the initial state. It
> should be able to move the state "from nothing to X" not only "from X1 to X2"
> and also providing the same compare-and-swap logic.
> Affected {{StateProvider}} implementations:
> - {{ZooKeeperStateProvider}}
> - {{RedisStateProvider}}
> - {{KubernetesConfigMapStateProvider}}
> - {{WriteAheadLocalStateProvider}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7324: NIFI-11595: StateProvider.replace() supports creating the initial state
exceptionfactory closed pull request #7324: NIFI-11595: StateProvider.replace() supports creating the initial state URL: https://github.com/apache/nifi/pull/7324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12024) Add CSV Writer property to CSVRecordSetWriter along with a FastCSV implementation
[ https://issues.apache.org/jira/browse/NIFI-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-12024: Status: Patch Available (was: In Progress) > Add CSV Writer property to CSVRecordSetWriter along with a FastCSV > implementation > - > > Key: NIFI-12024 > URL: https://issues.apache.org/jira/browse/NIFI-12024 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Minor > Fix For: 2.latest > > Time Spent: 20m > Remaining Estimate: 0h > > According to [these > benchmarks|https://github.com/osiegmar/JavaCsvBenchmarkSuite], FastCSV is > much faster than Apache Commons CSV and Jackson CSV with a small footprint. > This Jira proposes to add a property "CSV Writer" to CSVRecordSetWriter for > choosing an implementation of the underlying writer. The existing Apache > Commons CSV implementation should be available as a choice for CSV Writer, > and an implementation of Jackson CSV should be added as the library is > already available to the module. In addition an implementation of FastCSV as > a writer could be added. Attention must be paid to which features are > available from FastCSV, any unusual or unsupported behaviors should be well > documented to avoid confusion for the user. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11789) ExecuteSQL doesn't set fragment.count attribute when Output Batch Size is set
[ https://issues.apache.org/jira/browse/NIFI-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766879#comment-17766879 ] Matt Burgess commented on NIFI-11789: - Doubtful, even though the PR may work for your use case, it is not a complete solution so I'm not sure we should offer a partial solution, please see my comments on the PR (I changed the PR to "draft" status) > ExecuteSQL doesn't set fragment.count attribute when Output Batch Size is set > - > > Key: NIFI-11789 > URL: https://issues.apache.org/jira/browse/NIFI-11789 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Tamas Neumer >Assignee: Matt Burgess >Priority: Minor > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Hi, > I am working with the ExecuteSQL processor and discovered an unexpected > behavior. If I specify the attribute "Output Batch Size", I get the > fragment.index on the outflowing flowing Flowfiles, but the fragment.count > attribute is not set (according to the documentation). > The behavior I would expect (in line with how merge processors work) is that > the attribute fragment.count is just set at the last Flowfile for the batch. > This would make it possible to merge all the batches together afterward. > So my proposal, in short, is that the fragment.count should be set in the > last Flowfile of a batch. > BR Florian -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1663: MINIFICPP-2223 Add .asf.yaml file to configure repository labels
fgerlits commented on code in PR #1663: URL: https://github.com/apache/nifi-minifi-cpp/pull/1663#discussion_r1330408257 ## .asf.yaml: ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +github: + description: "Apache NiFi - MiNiFi C++" + homepage: https://nifi.apache.org/minifi/ + labels: +- nifi +- c++ +- hacktoberfest Review Comment: I'm not sure how the labels are used, but should we have a `minifi` label instead, or in addition to, the `nifi` label? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1663: MINIFICPP-2223 Add .asf.yaml file to configure repository labels
lordgamez opened a new pull request, #1663: URL: https://github.com/apache/nifi-minifi-cpp/pull/1663 https://issues.apache.org/jira/browse/MINIFICPP-2223 - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1662: MINIFICPP-2222 Update CONTRIB.md file with new contributor access request process
lordgamez opened a new pull request, #1662: URL: https://github.com/apache/nifi-minifi-cpp/pull/1662 https://issues.apache.org/jira/browse/MINIFICPP- - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma commented on a diff in pull request #7667: NIFI-12022 Extract verification logic from JMSConnectionFactoryProvider
nandorsoma commented on code in PR #7667:
URL: https://github.com/apache/nifi/pull/7667#discussion_r1330343591
##
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-cf-service/src/main/java/org/apache/nifi/jms/cf/AbstractJMSConnectionFactoryProvider.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.jms.cf;
+
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.ConfigVerificationResult;
+import org.apache.nifi.components.ConfigVerificationResult.Outcome;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.controller.VerifiableControllerService;
+import org.apache.nifi.logging.ComponentLog;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.ExceptionListener;
+import javax.jms.JMSSecurityException;
+import javax.jms.Session;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
+
+/**
+ * Base JMS controller service implementation that provides verification logic.
+ */
+public abstract class AbstractJMSConnectionFactoryProvider extends
AbstractControllerService implements JMSConnectionFactoryProviderDefinition,
VerifiableControllerService {
+private static final String ESTABLISH_CONNECTION = "Establish Connection";
+private static final String VERIFY_JMS_INTERACTION = "Verify JMS
Interaction";
+
+protected volatile IJMSConnectionFactoryProvider delegate;
Review Comment:
As we agreed, I will leave the delegate logic as is because it is true that
it makes the code unnecessarily complex for simple Providers, but this is the
only way to create a parent class for all use cases. Having this "umbrella" is
a more significant advantage than what the less complex code could bring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MINIFICPP-2223) Add .asf.yaml file to configure repository labels
Gábor Gyimesi created MINIFICPP-2223: Summary: Add .asf.yaml file to configure repository labels Key: MINIFICPP-2223 URL: https://issues.apache.org/jira/browse/MINIFICPP-2223 Project: Apache NiFi MiNiFi C++ Issue Type: New Feature Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi Add .asf.yaml file to be able to configure multiple labels on the repository -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12089) CSVReader - bad documentation
Mermillod created NIFI-12089: Summary: CSVReader - bad documentation Key: NIFI-12089 URL: https://issues.apache.org/jira/browse/NIFI-12089 Project: Apache NiFi Issue Type: Bug Components: Examples Affects Versions: 1.20.0 Reporter: Mermillod Attachments: image-2023-09-19-17-34-44-532.png This avro sample is invalid in CSVReader documentation : !image-2023-09-19-17-34-44-532.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] turcsanyip opened a new pull request, #7759: NIFI-12076 Removed log methods with Object[] + Throwable parameters f…
turcsanyip opened a new pull request, #7759: URL: https://github.com/apache/nifi/pull/7759 …rom ComponentLog # Summary [NIFI-12076](https://issues.apache.org/jira/browse/NIFI-12076) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #7750: NIFI-12079 - WIP - Remove Variables / Variable Registry
pvillard31 commented on PR #7750: URL: https://github.com/apache/nifi/pull/7750#issuecomment-1725852709 Thanks David, yeah, I noticed that one (had some troubles running system tests locally). I'm trying to figure out some UI issues with my changes but not my domain of expertise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip opened a new pull request, #7758: Nifi 12075 1.x
turcsanyip opened a new pull request, #7758: URL: https://github.com/apache/nifi/pull/7758 # Summary [NIFI-12075](https://issues.apache.org/jira/browse/NIFI-12075) NIFI-12075 for `support/nifi-1.x` branch. The 1st commit was cherry-picked from `main`. The 2nd commit contains the additional changes on 1.x. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-1311) Ensure that the integration test include dirs correspond to that of libminifi
[
https://issues.apache.org/jira/browse/MINIFICPP-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi updated MINIFICPP-1311:
-
Labels: MiNiFi-CPP-Hygiene beginner starter (was: MiNiFi-CPP-Hygiene
starter)
> Ensure that the integration test include dirs correspond to that of libminifi
> -
>
> Key: MINIFICPP-1311
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1311
> Project: Apache NiFi MiNiFi C++
> Issue Type: Task
>Reporter: Adam Hunyadi
>Priority: Minor
> Labels: MiNiFi-CPP-Hygiene, beginner, starter
> Fix For: 1.0.0
>
>
> *Background:*
> We currently need to use somewhat convoluted includes when building
> integration tests, eg.:
> {code:c++}
> #include "../../../libminifi/test/TestBase.h"
> {code}
> *Proposal:*
> We should verify, that the target_include_directories specified for
> integration tests are similar to those of libminifi and then replace the
> obscure include patterns. Looking through all includes that start with ".."
> should probably be sufficient.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-1027) Move getclassname to ClassUtils
[ https://issues.apache.org/jira/browse/MINIFICPP-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-1027: - Labels: beginner easyfix newbie starter (was: easyfix newbie starter) > Move getclassname to ClassUtils > --- > > Key: MINIFICPP-1027 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1027 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marc Parisi >Priority: Trivial > Labels: beginner, easyfix, newbie, starter > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-1904) Replace (void) casts with [[ maybe_unused ]]
[ https://issues.apache.org/jira/browse/MINIFICPP-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-1904: - Labels: MiNiFi-CPP-Hygiene beginner newbie starter (was: MiNiFi-CPP-Hygiene newbie starter) > Replace (void) casts with [[ maybe_unused ]] > > > Key: MINIFICPP-1904 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1904 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Priority: Minor > Labels: MiNiFi-CPP-Hygiene, beginner, newbie, starter > > [[ maybe_unused ]] attribute suppresses warnings on unused entities, which > would be an improvement on the currently used void casts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1659: MINIFICPP-2218 Refactor expected monadic functions
szaszm commented on code in PR #1659:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1659#discussion_r1330273703
##
libminifi/test/unit/ExpectedTest.cpp:
##
@@ -153,124 +153,124 @@ TEST_CASE("expected map", "[expected][map]") {
// mapping functions which return references
{
nonstd::expected e(42);
-auto ret = e | utils::map([](int& i) -> int& { return i; });
+auto ret = e | utils::transform([](int& i) -> int& { return i; });
REQUIRE(ret);
REQUIRE(ret == 42);
}
}
-TEST_CASE("expected flatMap", "[expected][flatMap]") {
+TEST_CASE("expected andThen", "[expected][andThen]") {
auto succeed = [](int) { return nonstd::expected(21 * 2); };
auto fail = [](int) { return nonstd::expected(nonstd::unexpect,
17); };
{
nonstd::expected e = 21;
-auto ret = e | utils::flatMap(succeed);
+auto ret = e | utils::andThen(succeed);
REQUIRE(ret);
REQUIRE(*ret == 42);
}
{
const nonstd::expected e = 21;
-auto ret = e | utils::flatMap(succeed);
+auto ret = e | utils::andThen(succeed);
REQUIRE(ret);
REQUIRE(*ret == 42);
}
{
nonstd::expected e = 21;
-auto ret = std::move(e) | utils::flatMap(succeed);
+auto ret = std::move(e) | utils::andThen(succeed);
REQUIRE(ret);
REQUIRE(*ret == 42);
}
{
const nonstd::expected e = 21;
-auto ret = std::move(e) | utils::flatMap(succeed); //
NOLINT(performance-move-const-arg)
+auto ret = std::move(e) | utils::andThen(succeed); //
NOLINT(performance-move-const-arg)
REQUIRE(ret);
REQUIRE(*ret == 42);
}
{
nonstd::expected e = 21;
-auto ret = e | utils::flatMap(fail);
+auto ret = e | utils::andThen(fail);
REQUIRE(!ret);
REQUIRE(ret.error() == 17);
}
{
const nonstd::expected e = 21;
-auto ret = e | utils::flatMap(fail);
+auto ret = e | utils::andThen(fail);
REQUIRE(!ret);
REQUIRE(ret.error() == 17);
}
{
nonstd::expected e = 21;
-auto ret = std::move(e) | utils::flatMap(fail);
+auto ret = std::move(e) | utils::andThen(fail);
REQUIRE(!ret);
REQUIRE(ret.error() == 17);
}
{
const nonstd::expected e = 21;
-auto ret = std::move(e) | utils::flatMap(fail); //
NOLINT(performance-move-const-arg)
+auto ret = std::move(e) | utils::andThen(fail); //
NOLINT(performance-move-const-arg)
REQUIRE(!ret);
REQUIRE(ret.error() == 17);
}
{
nonstd::expected e(nonstd::unexpect, 21);
-auto ret = e | utils::flatMap(succeed);
+auto ret = e | utils::andThen(succeed);
REQUIRE(!ret);
REQUIRE(ret.error() == 21);
}
{
const nonstd::expected e(nonstd::unexpect, 21);
-auto ret = e | utils::flatMap(succeed);
+auto ret = e | utils::andThen(succeed);
REQUIRE(!ret);
REQUIRE(ret.error() == 21);
}
{
nonstd::expected e(nonstd::unexpect, 21);
-auto ret = std::move(e) | utils::flatMap(succeed);
+auto ret = std::move(e) | utils::andThen(succeed);
REQUIRE(!ret);
REQUIRE(ret.error() == 21);
}
{
const nonstd::expected e(nonstd::unexpect, 21);
-auto ret = std::move(e) | utils::flatMap(succeed); //
NOLINT(performance-move-const-arg)
+auto ret = std::move(e) | utils::andThen(succeed); //
NOLINT(performance-move-const-arg)
REQUIRE(!ret);
REQUIRE(ret.error() == 21);
}
{
nonstd::expected e(nonstd::unexpect, 21);
-auto ret = e | utils::flatMap(fail);
+auto ret = e | utils::andThen(fail);
REQUIRE(!ret);
REQUIRE(ret.error() == 21);
}
{
const nonstd::expected e(nonstd::unexpect, 21);
-auto ret = e | utils::flatMap(fail);
+auto ret = e | utils::andThen(fail);
REQUIRE(!ret);
REQUIRE(ret.error() == 21);
}
{
nonstd::expected e(nonstd::unexpect, 21);
-auto ret = std::move(e) | utils::flatMap(fail);
+auto ret = std::move(e) | utils::andThen(fail);
REQUIRE(!ret);
REQUIRE(ret.error() == 21);
}
{
const nonstd::expected e(nonstd::unexpect, 21);
-auto ret = std::move(e) | utils::flatMap(fail); //
NOLINT(performance-move-const-arg)
+auto ret = std::move(e) | utils::andThen(fail); //
NOLINT(performance-move-const-arg)
REQUIRE(!ret);
REQUIRE(ret.error() == 21);
}
Review Comment:
Thanks for pointing this out, reenabled them in
[47aede1](https://github.com/apache/nifi-minifi-cpp/pull/1659/commits/47aede10d43a4b9e0c0b27b67dda824bd5748096)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2222) Update CONTRIB.md file with new contributor access request process
[ https://issues.apache.org/jira/browse/MINIFICPP-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-: - Summary: Update CONTRIB.md file with new contributor access request process (was: Update CONTRIB.md file with new) > Update CONTRIB.md file with new contributor access request process > -- > > Key: MINIFICPP- > URL: https://issues.apache.org/jira/browse/MINIFICPP- > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > > Requesting contributor access should be updated in the CONTRIB.md file to > refer to the Self-Service Portal at > [https://selfserve.apache.org/jira-account.html] to access Jira. The file > name should also be updated to CONTRIBUTING.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2222) Update CONTRIB.md file with new
Gábor Gyimesi created MINIFICPP-: Summary: Update CONTRIB.md file with new Key: MINIFICPP- URL: https://issues.apache.org/jira/browse/MINIFICPP- Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi Requesting contributor access should be updated in the CONTRIB.md file to refer to the Self-Service Portal at [https://selfserve.apache.org/jira-account.html] to access Jira. The file name should also be updated to CONTRIBUTING.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2222) Update CONTRIB.md file with new
[ https://issues.apache.org/jira/browse/MINIFICPP-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-: - Issue Type: Bug (was: Improvement) > Update CONTRIB.md file with new > --- > > Key: MINIFICPP- > URL: https://issues.apache.org/jira/browse/MINIFICPP- > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > > Requesting contributor access should be updated in the CONTRIB.md file to > refer to the Self-Service Portal at > [https://selfserve.apache.org/jira-account.html] to access Jira. The file > name should also be updated to CONTRIBUTING.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1661: MINIFICPP-2196 Integrate cppcoreguideline clang-tidy checks in CI
lordgamez opened a new pull request, #1661: URL: https://github.com/apache/nifi-minifi-cpp/pull/1661 CPP Core Guideline checks added (most issues fixed, marked the checks only introduced, but not fixed due to too many instances of the issue being present): cppcoreguidelines-prefer-member-initializer cppcoreguidelines-pro-type-member-init cppcoreguidelines-narrowing-conversions cppcoreguidelines-init-variables (not fixed) cppcoreguidelines-avoid-c-arrays (not fixed) cppcoreguidelines-avoid-goto cppcoreguidelines-pro-bounds-constant-array-index cppcoreguidelines-special-member-functions cppcoreguidelines-pro-type-vararg cppcoreguidelines-avoid-capturing-lambda-coroutines cppcoreguidelines-interfaces-global-init cppcoreguidelines-misleading-capture-default-by-value cppcoreguidelines-missing-std-forward cppcoreguidelines-no-malloc cppcoreguidelines-no-suspend-with-lock cppcoreguidelines-owning-memory cppcoreguidelines-pro-type-union-access cppcoreguidelines-rvalue-reference-param-not-moved cppcoreguidelines-slicing cppcoreguidelines-virtual-class-destructor cppcoreguidelines-macro-usage Checks not added due to not being fit to our practices or producing too many false positives: cppcoreguidelines-avoid-do-while cppcoreguidelines-avoid-non-const-global-variables cppcoreguidelines-pro-bounds-pointer-arithmetic cppcoreguidelines-avoid-magic-numbers cppcoreguidelines-pro-type-reinterpret-cast cppcoreguidelines-non-private-member-variables-in-classes cppcoreguidelines-avoid-const-or-ref-data-members cppcoreguidelines-pro-type-const-cast cppcoreguidelines-pro-type-static-cast-downcast cppcoreguidelines-avoid-reference-coroutine-parameters cppcoreguidelines-pro-type-cstyle-cast cppcoreguidelines-pro-bounds-array-to-pointer-decay https://issues.apache.org/jira/browse/MINIFICPP-2196 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7624: NIFI-11958 Azure Data Explorer as sink
exceptionfactory commented on code in PR #7624:
URL: https://github.com/apache/nifi/pull/7624#discussion_r1330232784
##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/data/explorer/IngestAzureDataExplorer.java:
##
@@ -0,0 +1,401 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.azure.data.explorer;
+
+import com.microsoft.azure.kusto.data.KustoResultSetTable;
+import com.microsoft.azure.kusto.ingest.IngestionMapping;
+import com.microsoft.azure.kusto.ingest.IngestionProperties;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.annotation.behavior.ReadsAttribute;
+import org.apache.nifi.annotation.behavior.ReadsAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.ProcessorInitializationContext;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.services.azure.data.explorer.KustoIngestService;
+import org.apache.nifi.services.azure.data.explorer.KustoIngestionRequest;
+import org.apache.nifi.services.azure.data.explorer.KustoIngestionResult;
+import org.apache.nifi.services.azure.data.explorer.KustoQueryResponse;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URISyntaxException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+@Tags({"Azure", "Kusto", "ADX", "Explorer", "Data"})
+@CapabilityDescription("The Azure ADX Ingest Processor acts as a ADX sink
connector which sends flowFiles using the ADX-Service to the provided Azure
Data" +
+"Explorer Ingest Endpoint. The data can be sent through queued
ingestion or streaming ingestion to the Azure Data Explorer cluster.")
+@ReadsAttributes({
+@ReadsAttribute(attribute = "DB_NAME", description = "Specifies the
name of the ADX database where the data needs to be stored."),
+@ReadsAttribute(attribute = "TABLE_NAME", description = "Specifies the
name of the ADX table where the data needs to be stored."),
+@ReadsAttribute(attribute = "MAPPING_NAME", description = "Specifies
the name of the mapping responsible for storing the data in appropriate
columns."),
+@ReadsAttribute(attribute = "FLUSH_IMMEDIATE", description = "In case
of queued ingestion, this property determines whether the data should be
flushed immediately to the ingest endpoint."),
+@ReadsAttribute(attribute = "DATA_FORMAT", description = "Specifies
the format of data that is send to Azure Data Explorer."),
+@ReadsAttribute(attribute = "IGNORE_FIRST_RECORD", description =
"Specifies whether we want to ignore ingestion of first record. " +
+"This is primarily applicable for csv files. Default is set to
NO"),
+@ReadsAttribute(attribute = "POLL_ON_INGESTION_STATUS", description =
"Specifies whether we want to poll on ingestion result during ingestion into
ADX." +
+"In case of applications that need high throughput it is
recommended to keep the default value as false. Default is set to false." +
+"This property should be set to true during Queued Ingestion
for near realtime micro-batches of data that require acknowledgement of
ingestion status.")
+})
+public class IngestAzureDataExplorer extends AbstractProcessor {
Review Comment:
The name should be changed to `PutAzureDataExplorer` following the
convention of other Processors.
##
[jira] [Created] (NIFI-12088) UI - Dependent Properties are not shown when depending on newly created Service
Mark Bathori created NIFI-12088:
---
Summary: UI - Dependent Properties are not shown when depending on
newly created Service
Key: NIFI-12088
URL: https://issues.apache.org/jira/browse/NIFI-12088
Project: Apache NiFi
Issue Type: Bug
Components: Core UI
Reporter: Mark Bathori
When properties depends on a property containing controller services, the
dependent fields are not shown if the controller service is newly created.
E.g.: When using the *ListenHTTP* processor, if the *Record Reader* property is
being populated by choosing the ‘{_}Create new service…{_}’ option then the
*Record Writer* property which depends on this filed stays invisible. The
*Record Writer* property will be visible only after re-opening the window.
It works properly if I choose a previously created controller service in the
*Record Reader* property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12087) Remove all deprecated items in the nifi-api
Joe Witt created NIFI-12087: --- Summary: Remove all deprecated items in the nifi-api Key: NIFI-12087 URL: https://issues.apache.org/jira/browse/NIFI-12087 Project: Apache NiFi Issue Type: Improvement Reporter: Joe Witt Assignee: Joe Witt -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7749: Bump org.eclipse.jgit:org.eclipse.jgit from 4.3.1.201605051710-r to 6.6.1.202309021850-r in /nifi-nar-bundles/nifi-framework-bundle
exceptionfactory closed pull request #7749: Bump org.eclipse.jgit:org.eclipse.jgit from 4.3.1.201605051710-r to 6.6.1.202309021850-r in /nifi-nar-bundles/nifi-framework-bundle URL: https://github.com/apache/nifi/pull/7749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #7749: Bump org.eclipse.jgit:org.eclipse.jgit from 4.3.1.201605051710-r to 6.6.1.202309021850-r in /nifi-nar-bundles/nifi-framework-bundle
exceptionfactory commented on PR #7749: URL: https://github.com/apache/nifi/pull/7749#issuecomment-1725656709 This dependency is marked with the test scope and is not used. Closing in favor of #7757. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dependabot[bot] commented on pull request #7749: Bump org.eclipse.jgit:org.eclipse.jgit from 4.3.1.201605051710-r to 6.6.1.202309021850-r in /nifi-nar-bundles/nifi-framework-bundle
dependabot[bot] commented on PR #7749: URL: https://github.com/apache/nifi/pull/7749#issuecomment-1725656868 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12075) Deprecate log methods with Object[] + Throwable parameters in ComponentLog
[
https://issues.apache.org/jira/browse/NIFI-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766800#comment-17766800
]
ASF subversion and git services commented on NIFI-12075:
Commit ebd0d60e49e096841b12a48811c0c6ad941323d6 in nifi's branch
refs/heads/main from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ebd0d60e49 ]
NIFI-12075 Deprecated ComponentLog methods with Object[] and Throwable
- Updated component references to remove use of Object[] wrapping for log
methods
This closes #7748
Signed-off-by: David Handermann
> Deprecate log methods with Object[] + Throwable parameters in ComponentLog
> --
>
> Key: NIFI-12075
> URL: https://issues.apache.org/jira/browse/NIFI-12075
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>
> {{ComponentLog}} defines
> {code:java}
> void error(String msg, Object[] os, Throwable t)
> {code}
> and similar methods where the caller needs to create the {{Object}} array
> explicitly which results in boilerplate and less readable code.
> The preferred way has been for a while to use the vararg signature instead:
> {code:java}
> void error(String msg, Object... os)
> {code}
> These methods can also handle the last {{Throwable}} argument properly.
> The {{Object[]}} methods should be deprecated and the existing usages should
> be migrated to use the vararg methods. In 2.0 the deprecated methods can be
> removed (NIFI-12076).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12075) Deprecate log methods with Object[] + Throwable parameters in ComponentLog
[
https://issues.apache.org/jira/browse/NIFI-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12075:
Fix Version/s: 2.0.0
> Deprecate log methods with Object[] + Throwable parameters in ComponentLog
> --
>
> Key: NIFI-12075
> URL: https://issues.apache.org/jira/browse/NIFI-12075
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0
>
>
> {{ComponentLog}} defines
> {code:java}
> void error(String msg, Object[] os, Throwable t)
> {code}
> and similar methods where the caller needs to create the {{Object}} array
> explicitly which results in boilerplate and less readable code.
> The preferred way has been for a while to use the vararg signature instead:
> {code:java}
> void error(String msg, Object... os)
> {code}
> These methods can also handle the last {{Throwable}} argument properly.
> The {{Object[]}} methods should be deprecated and the existing usages should
> be migrated to use the vararg methods. In 2.0 the deprecated methods can be
> removed (NIFI-12076).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7748: NIFI-12075: Deprecated log methods with Object[] + Throwable paramete…
exceptionfactory closed pull request #7748: NIFI-12075: Deprecated log methods with Object[] + Throwable paramete… URL: https://github.com/apache/nifi/pull/7748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12086) Remove unused jgit test dependency from framework-core
[
https://issues.apache.org/jira/browse/NIFI-12086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12086:
Status: Patch Available (was: Open)
> Remove unused jgit test dependency from framework-core
> --
>
> Key: NIFI-12086
> URL: https://issues.apache.org/jira/browse/NIFI-12086
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
>
> The {{nifi-framework-core}} has an unused test dependency on jgit that should
> be removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #7757: NIFI-12086 Remove unused jgit dependency from framework-core
exceptionfactory opened a new pull request, #7757: URL: https://github.com/apache/nifi/pull/7757 # Summary [NIFI-12086](https://issues.apache.org/jira/browse/NIFI-12086) Removes an unused test dependency on `jgit` from the `nifi-framework-core` module. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12086) Remove unused jgit test dependency from framework-core
David Handermann created NIFI-12086:
---
Summary: Remove unused jgit test dependency from framework-core
Key: NIFI-12086
URL: https://issues.apache.org/jira/browse/NIFI-12086
Project: Apache NiFi
Issue Type: Improvement
Components: Core Framework
Reporter: David Handermann
Assignee: David Handermann
Fix For: 1.latest, 2.latest
The {{nifi-framework-core}} has an unused test dependency on jgit that should
be removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12043) Update mariadb-java-client to 3.2.0
[ https://issues.apache.org/jira/browse/NIFI-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766790#comment-17766790 ] ASF subversion and git services commented on NIFI-12043: Commit f35045d3ae195db1ee25b28f593e52ffc727892f in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f35045d3ae ] NIFI-12043 Upgraded MariaDB Java Client from 3.1.4 to 3.2.0 This closes #7747 Signed-off-by: David Handermann (cherry picked from commit 66524ab2678609ecb5c31869ad081e7446b977d8) > Update mariadb-java-client to 3.2.0 > --- > > Key: NIFI-12043 > URL: https://issues.apache.org/jira/browse/NIFI-12043 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.24.0 > > > Update mariadb-java-client to 3.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12043) Update mariadb-java-client to 3.2.0
[ https://issues.apache.org/jira/browse/NIFI-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766789#comment-17766789 ] ASF subversion and git services commented on NIFI-12043: Commit 66524ab2678609ecb5c31869ad081e7446b977d8 in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=66524ab267 ] NIFI-12043 Upgraded MariaDB Java Client from 3.1.4 to 3.2.0 This closes #7747 Signed-off-by: David Handermann > Update mariadb-java-client to 3.2.0 > --- > > Key: NIFI-12043 > URL: https://issues.apache.org/jira/browse/NIFI-12043 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.24.0 > > > Update mariadb-java-client to 3.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12075) Deprecate log methods with Object[] + Throwable parameters in ComponentLog
[
https://issues.apache.org/jira/browse/NIFI-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-12075:
---
Status: Patch Available (was: Open)
> Deprecate log methods with Object[] + Throwable parameters in ComponentLog
> --
>
> Key: NIFI-12075
> URL: https://issues.apache.org/jira/browse/NIFI-12075
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>
> {{ComponentLog}} defines
> {code:java}
> void error(String msg, Object[] os, Throwable t)
> {code}
> and similar methods where the caller needs to create the {{Object}} array
> explicitly which results in boilerplate and less readable code.
> The preferred way has been for a while to use the vararg signature instead:
> {code:java}
> void error(String msg, Object... os)
> {code}
> These methods can also handle the last {{Throwable}} argument properly.
> The {{Object[]}} methods should be deprecated and the existing usages should
> be migrated to use the vararg methods. In 2.0 the deprecated methods can be
> removed (NIFI-12076).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12043) Update mariadb-java-client to 3.2.0
[ https://issues.apache.org/jira/browse/NIFI-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12043: Priority: Minor (was: Major) > Update mariadb-java-client to 3.2.0 > --- > > Key: NIFI-12043 > URL: https://issues.apache.org/jira/browse/NIFI-12043 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > > Update mariadb-java-client to 3.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12043) Update mariadb-java-client to 3.2.0
[ https://issues.apache.org/jira/browse/NIFI-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12043: Affects Version/s: (was: 1.23.2) > Update mariadb-java-client to 3.2.0 > --- > > Key: NIFI-12043 > URL: https://issues.apache.org/jira/browse/NIFI-12043 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update mariadb-java-client to 3.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12043) Update mariadb-java-client to 3.2.0
[ https://issues.apache.org/jira/browse/NIFI-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12043. - Fix Version/s: 2.0.0 1.24.0 Resolution: Fixed > Update mariadb-java-client to 3.2.0 > --- > > Key: NIFI-12043 > URL: https://issues.apache.org/jira/browse/NIFI-12043 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.24.0 > > > Update mariadb-java-client to 3.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7747: NIFI-12043 Update mariadb-java-client to 3.2.0
exceptionfactory closed pull request #7747: NIFI-12043 Update mariadb-java-client to 3.2.0 URL: https://github.com/apache/nifi/pull/7747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12043) Update mariadb-java-client to 3.2.0
[ https://issues.apache.org/jira/browse/NIFI-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12043: Component/s: NiFi Registry > Update mariadb-java-client to 3.2.0 > --- > > Key: NIFI-12043 > URL: https://issues.apache.org/jira/browse/NIFI-12043 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: Mike R >Assignee: Mike R >Priority: Minor > > Update mariadb-java-client to 3.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mr1716 opened a new pull request, #7756: NIFI-12085 Update spring.security.version to 5.8.7
mr1716 opened a new pull request, #7756: URL: https://github.com/apache/nifi/pull/7756 # Summary [NIFI-12085](https://issues.apache.org/jira/browse/NIFI-12085) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-12085) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12043) Update mariadb-java-client to 3.2.0
[ https://issues.apache.org/jira/browse/NIFI-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-12043: - Assignee: Mike R > Update mariadb-java-client to 3.2.0 > --- > > Key: NIFI-12043 > URL: https://issues.apache.org/jira/browse/NIFI-12043 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.23.2 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update mariadb-java-client to 3.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mr1716 opened a new pull request, #7755: NIFI-12085 Update spring.security.version to 5.8.7
mr1716 opened a new pull request, #7755: URL: https://github.com/apache/nifi/pull/7755 # Summary [NIFI-12085](https://issues.apache.org/jira/browse/NIFI-12085) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-12085) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12085) Update spring.security.version to 5.8.7
[ https://issues.apache.org/jira/browse/NIFI-12085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-12085: - Assignee: Mike R > Update spring.security.version to 5.8.7 > --- > > Key: NIFI-12085 > URL: https://issues.apache.org/jira/browse/NIFI-12085 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.23.2 >Reporter: Mike R >Assignee: Mike R >Priority: Major > > Update spring.security.version to 5.8.7 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12085) Update spring.security.version to 5.8.7
Mike R created NIFI-12085: - Summary: Update spring.security.version to 5.8.7 Key: NIFI-12085 URL: https://issues.apache.org/jira/browse/NIFI-12085 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.23.2 Reporter: Mike R Update spring.security.version to 5.8.7 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12083) Upgrade Jetty to 9.4.52 on Support Branch
[ https://issues.apache.org/jira/browse/NIFI-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12083: Labels: dependency-upgrade (was: ) > Upgrade Jetty to 9.4.52 on Support Branch > - > > Key: NIFI-12083 > URL: https://issues.apache.org/jira/browse/NIFI-12083 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Labels: dependency-upgrade > Fix For: 1.24.0 > > > Jetty 9.4.52 is a security release upgrade mitigating CVE-2023-40167 related > to invalid characters in the Content-Length header. > The project support branch should be upgraded to the latest version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12034) Update commons-compress to 1.24.0
[ https://issues.apache.org/jira/browse/NIFI-12034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12034: Labels: dependency-upgrade (was: ) > Update commons-compress to 1.24.0 > - > > Key: NIFI-12034 > URL: https://issues.apache.org/jira/browse/NIFI-12034 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.23.2 >Reporter: Mike R >Assignee: David Handermann >Priority: Major > Labels: dependency-upgrade > Fix For: 2.0.0, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update commons-compress to 1.24.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12034) Update commons-compress to 1.24.0
[ https://issues.apache.org/jira/browse/NIFI-12034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12034: Affects Version/s: (was: 1.23.2) > Update commons-compress to 1.24.0 > - > > Key: NIFI-12034 > URL: https://issues.apache.org/jira/browse/NIFI-12034 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: David Handermann >Priority: Major > Labels: dependency-upgrade > Fix For: 2.0.0, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update commons-compress to 1.24.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1631: MINIFICPP-2174 Send all cached compressed log files through C2
lordgamez commented on code in PR #1631:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1631#discussion_r1330031519
##
libminifi/include/core/logging/internal/LogCompressorSink.h:
##
@@ -57,26 +58,44 @@ class LogCompressorSink : public
spdlog::sinks::base_sink {
~LogCompressorSink() override;
template
- std::unique_ptr getContent(const std::chrono::duration& time, bool flush = false) {
+ std::vector> getContent(const
std::chrono::duration& time, bool flush = false) {
if (flush) {
cached_logs_.commit();
compress(true);
}
-LogBuffer compressed;
-if (!compressed_logs_.tryDequeue(compressed, time) && flush) {
- return createEmptyArchive();
+
+std::vector> log_segments;
+const auto segment_count = compressed_logs_.itemCount();
+for (size_t i = 0; i < segment_count; ++i) {
+ LogBuffer compressed;
+ if (!compressed_logs_.tryDequeue(compressed, time) && flush) {
+break;
Review Comment:
You are right, there is no reason to keep that argument at the moment,
removed in 84abc4df7100b28695cb75a753bb9df3f64a0620
##
libminifi/test/unit/LoggerTests.cpp:
##
@@ -276,7 +280,7 @@ TEST_CASE("Setting either properties to 0 disables
in-memory compressed logs", "
log_config.initialize(properties);
auto logger = log_config.getLogger("DisableCompressionTestLogger");
logger->log_error("Hi there");
- REQUIRE((logging::LoggerConfiguration::getCompressedLog(true) == nullptr) ==
is_nullptr);
+ REQUIRE(logging::LoggerConfiguration::getCompressedLogs(true).empty() ==
is_nullptr);
Review Comment:
Updated in d32b92c94c133b8baf0d81be52bb780da799f05e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI
lordgamez commented on code in PR #1642:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1329971479
##
libminifi/include/utils/requirements/HasSpaceshipOperator.h:
##
@@ -0,0 +1,31 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include
+
+namespace org::apache::nifi::minifi::utils {
+
+template>
+struct has_spaceship_operator: std::false_type {};
+
+template
+struct has_spaceship_operator() <=>
std::declval())>> : std::true_type {};
Review Comment:
Updated in f2a1f93985c43cc6cd52a65a3e2d304b60b7834a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1631: MINIFICPP-2174 Send all cached compressed log files through C2
fgerlits commented on code in PR #1631:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1631#discussion_r1329969207
##
libminifi/test/unit/LoggerTests.cpp:
##
@@ -276,7 +280,7 @@ TEST_CASE("Setting either properties to 0 disables
in-memory compressed logs", "
log_config.initialize(properties);
auto logger = log_config.getLogger("DisableCompressionTestLogger");
logger->log_error("Hi there");
- REQUIRE((logging::LoggerConfiguration::getCompressedLog(true) == nullptr) ==
is_nullptr);
+ REQUIRE(logging::LoggerConfiguration::getCompressedLogs(true).empty() ==
is_nullptr);
Review Comment:
it would be better to rename `is_nullptr` to `is_empty`
##
libminifi/include/core/logging/internal/LogCompressorSink.h:
##
@@ -57,26 +58,44 @@ class LogCompressorSink : public
spdlog::sinks::base_sink {
~LogCompressorSink() override;
template
- std::unique_ptr getContent(const std::chrono::duration& time, bool flush = false) {
+ std::vector> getContent(const
std::chrono::duration& time, bool flush = false) {
if (flush) {
cached_logs_.commit();
compress(true);
}
-LogBuffer compressed;
-if (!compressed_logs_.tryDequeue(compressed, time) && flush) {
- return createEmptyArchive();
+
+std::vector> log_segments;
+const auto segment_count = compressed_logs_.itemCount();
+for (size_t i = 0; i < segment_count; ++i) {
+ LogBuffer compressed;
+ if (!compressed_logs_.tryDequeue(compressed, time) && flush) {
+break;
Review Comment:
I don't understand the purpose of checking `flush` here (I didn't understand
it before this change either, but it got more complex). As far as I can see,
we only call this with `flush = true`.
Can we remove the `flush` argument? If not, then I think the logic needs to
be made clearer, either by a comment or some other way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI
lordgamez commented on code in PR #1642:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1329971479
##
libminifi/include/utils/requirements/HasSpaceshipOperator.h:
##
@@ -0,0 +1,31 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include
+
+namespace org::apache::nifi::minifi::utils {
+
+template>
+struct has_spaceship_operator: std::false_type {};
+
+template
+struct has_spaceship_operator() <=>
std::declval())>> : std::true_type {};
Review Comment:
Updated in 96933e8c5206c3dd96f0a794260f41b49cce4d19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-10442) Create PutIceberg processor
[ https://issues.apache.org/jira/browse/NIFI-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766756#comment-17766756 ] Abdelrahim Ahmad commented on NIFI-10442: - Hi Guys, Thanks for this great processor. Is there any chance in the future for this one to support the modern data storage systems like Minio, S3 and other object storage tools? Thanks > Create PutIceberg processor > --- > > Key: NIFI-10442 > URL: https://issues.apache.org/jira/browse/NIFI-10442 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Mark Bathori >Assignee: Mark Bathori >Priority: Major > Fix For: 1.19.0 > > Time Spent: 4.5h > Remaining Estimate: 0h > > Add a processor that is able to ingest data into Iceberg tables. -- This message was sent by Atlassian Jira (v8.20.10#820010)
