[jira] [Updated] (NIFI-12485) Lineage Graph
[ https://issues.apache.org/jira/browse/NIFI-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12485: --- Status: Patch Available (was: In Progress) > Lineage Graph > - > > Key: NIFI-12485 > URL: https://issues.apache.org/jira/browse/NIFI-12485 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Implement the lineage graph that is opened from a Provenance event. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12527) Remove deprecated Session Cache Size property from JMS processors
[ https://issues.apache.org/jira/browse/NIFI-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-12527: --- Status: Patch Available (was: Open) > Remove deprecated Session Cache Size property from JMS processors > - > > Key: NIFI-12527 > URL: https://issues.apache.org/jira/browse/NIFI-12527 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > PublishJMS and ConsumeJMS processors' Session Cache Size property is not used > / has no effect. It was marked as deprecated and can be removed in 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12527: Removed deprecated Session Cache Size property from JMS p… [nifi]
turcsanyip opened a new pull request, #8172: URL: https://github.com/apache/nifi/pull/8172 …rocessors # Summary [NIFI-12527](https://issues.apache.org/jira/browse/NIFI-12527) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12527) Remove deprecated Session Cache Size property from JMS processors
Peter Turcsanyi created NIFI-12527: -- Summary: Remove deprecated Session Cache Size property from JMS processors Key: NIFI-12527 URL: https://issues.apache.org/jira/browse/NIFI-12527 Project: Apache NiFi Issue Type: Improvement Reporter: Peter Turcsanyi Assignee: Peter Turcsanyi PublishJMS and ConsumeJMS processors' Session Cache Size property is not used / has no effect. It was marked as deprecated and can be removed in 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12526) QueryCassandra should not output FlowFiles as soon as the "available rows without fetching" is reached
Matt Burgess created NIFI-12526: --- Summary: QueryCassandra should not output FlowFiles as soon as the "available rows without fetching" is reached Key: NIFI-12526 URL: https://issues.apache.org/jira/browse/NIFI-12526 Project: Apache NiFi Issue Type: Bug Components: Extensions Reporter: Matt Burgess Fix For: 1.25.0, 2.0.0 NIFI-5642 introduced the Max Rows Per Flow File and Output Batch Size properties to QueryCassandra, but still uses the internal "rowsAvailableWithoutFetching" variable (whose value comes from the Cassandra ResultSet and defaults to 5000) as a trigger to stop processing rows for a FlowFile. This can cause unexpected behavior, such as getting multiple FlowFiles when only one is expected. NIFI-5642 also removes the Compression Type property, which might be ok for 2.x but will cause all flows using this property in 1.x to become invalid. On the support (1.x) branch we need to add the property back in, perhaps we can keep it removed for 2.x but we'd want to remove the Cassandra Connect Points property and such to force the user to use a Cassandra Connection controller service. The reason to add the property back is if the Cassandra Contact Points property is used instead of the Cassandra Connection controller service, there is no way to set the Compression Type. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12402) MonitorActivity generates inactivity indicator after it is started and threshold duration exceeds without actual activities
[ https://issues.apache.org/jira/browse/NIFI-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798755#comment-17798755 ] Tan Luu commented on NIFI-12402: Yes, the expected behavior is to only trigger an inactive indicator after there was activity after the processor had been started then no activity for Threshold Duration. So the sequence of events is Start the processor -> activity comes -> no activity for "Threshold Duration" period In the pull request, I add a configuration property to toogle the processor behavior. It ensures backward compatibility > MonitorActivity generates inactivity indicator after it is started and > threshold duration exceeds without actual activities > --- > > Key: NIFI-12402 > URL: https://issues.apache.org/jira/browse/NIFI-12402 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.23.2 >Reporter: Tan Luu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > Even though there is no activity, a start or restart of MonitorActivity > processor produces an inactive flowfile after "Threshold Duration". This > behavior creates a false positive notification cause there was no actual > activity. The expected behavior is to only send an inactive indicator if > there is activity after the processor is started. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-5642) QueryCassandra processor : output FlowFiles as soon fetch_size is reached
[ https://issues.apache.org/jira/browse/NIFI-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798751#comment-17798751 ] Matt Burgess commented on NIFI-5642: The "maxRowsPerFlowFile" variable is changed to match the rows available without fetching (default is 5000), so only 5000 rows get put into the FlowFile even if the Max Rows Per Flow File property is set to zero. I have a test table with 20k rows, if I run QueryCassandra once I get 4 output FlowFiles when I should only get one. There's a logic error or two in there that need to be fixed, but since it has been released as of 1.22.0 and 2.0.0-M1, I will open a new Jira to fix them. > QueryCassandra processor : output FlowFiles as soon fetch_size is reached > - > > Key: NIFI-5642 > URL: https://issues.apache.org/jira/browse/NIFI-5642 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.7.1 >Reporter: André Gomes Lamas Otero >Assignee: Levi Lentz >Priority: Major > Fix For: 2.0.0-M1, 1.22.0 > > Time Spent: 4h 10m > Remaining Estimate: 0h > > When I'm using QueryCassandra alongside with fetch_size parameter I expected > that as soon my reader reaches the fetch_size the processor outputs some data > to be processed by the next processor, but QueryCassandra reads all the data, > then output the flow files. > I'll start to work on a patch for this situation, I'll appreciate any > suggestion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12525) Add property migration for the removed Consumer Hostname property in ConsumeAzureEventHub
[ https://issues.apache.org/jira/browse/NIFI-12525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-12525: --- Status: Patch Available (was: Open) > Add property migration for the removed Consumer Hostname property in > ConsumeAzureEventHub > - > > Key: NIFI-12525 > URL: https://issues.apache.org/jira/browse/NIFI-12525 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12525: Added property migration for the removed Consumer Hostnam… [nifi]
turcsanyip opened a new pull request, #8171: URL: https://github.com/apache/nifi/pull/8171 …e property in ConsumeAzureEventHub # Summary [NIFI-12525](https://issues.apache.org/jira/browse/NIFI-12525) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12525) Add property migration for the removed Consumer Hostname property in ConsumeAzureEventHub
Peter Turcsanyi created NIFI-12525: -- Summary: Add property migration for the removed Consumer Hostname property in ConsumeAzureEventHub Key: NIFI-12525 URL: https://issues.apache.org/jira/browse/NIFI-12525 Project: Apache NiFi Issue Type: Improvement Reporter: Peter Turcsanyi Assignee: Peter Turcsanyi -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12515 Removed deprecated Client Auth property from AMQP processors [nifi]
turcsanyip commented on PR #8162: URL: https://github.com/apache/nifi/pull/8162#issuecomment-1863289615 Thanks for the heads-up @pvillard31! Added `migrateProperties()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12524) AuditService NullPointerException After 1.23.2 to 1.24.0 Upgrade
[ https://issues.apache.org/jira/browse/NIFI-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798671#comment-17798671 ] David Handermann commented on NIFI-12524: - Thanks for reporting this issue and providing the stack trace [~Absolutesantaja]. Based on the stack trace, it looks like the Destination Name field of the Connection Details event is null, but the service is expecting this value to be populated. I will take a closer look, but it should be enough to replicate the problem and implement a solution. > AuditService NullPointerException After 1.23.2 to 1.24.0 Upgrade > > > Key: NIFI-12524 > URL: https://issues.apache.org/jira/browse/NIFI-12524 > Project: Apache NiFi > Issue Type: Bug > Environment: RHEL 8, OpenJDK11 Latest >Reporter: Shawn Weeks >Assignee: David Handermann >Priority: Major > Attachments: nifi-app.log > > > Seems to be an issue with the migration from H2 to Xodus. After upgrading > from 1.23.2 to 1.24.0 NiFi fails to start and throws a null pointer exception > with the auditService Bean. See attached log snippet. > The cluster started life as NiFi 1.13.2 and has been steadily upgraded since > mid 2021. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-12524) AuditService NullPointerException After 1.23.2 to 1.24.0 Upgrade
[ https://issues.apache.org/jira/browse/NIFI-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-12524: --- Assignee: David Handermann > AuditService NullPointerException After 1.23.2 to 1.24.0 Upgrade > > > Key: NIFI-12524 > URL: https://issues.apache.org/jira/browse/NIFI-12524 > Project: Apache NiFi > Issue Type: Bug > Environment: RHEL 8, OpenJDK11 Latest >Reporter: Shawn Weeks >Assignee: David Handermann >Priority: Major > Attachments: nifi-app.log > > > Seems to be an issue with the migration from H2 to Xodus. After upgrading > from 1.23.2 to 1.24.0 NiFi fails to start and throws a null pointer exception > with the auditService Bean. See attached log snippet. > The cluster started life as NiFi 1.13.2 and has been steadily upgraded since > mid 2021. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12524) AuditService NullPointerException After 1.23.2 to 1.24.0 Upgrade
[ https://issues.apache.org/jira/browse/NIFI-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798665#comment-17798665 ] Shawn Weeks commented on NIFI-12524: I have the H2 database files and if someone tells me what to look for I can look through them but I unfortunately can't share them. > AuditService NullPointerException After 1.23.2 to 1.24.0 Upgrade > > > Key: NIFI-12524 > URL: https://issues.apache.org/jira/browse/NIFI-12524 > Project: Apache NiFi > Issue Type: Bug > Environment: RHEL 8, OpenJDK11 Latest >Reporter: Shawn Weeks >Priority: Major > Attachments: nifi-app.log > > > Seems to be an issue with the migration from H2 to Xodus. After upgrading > from 1.23.2 to 1.24.0 NiFi fails to start and throws a null pointer exception > with the auditService Bean. See attached log snippet. > The cluster started life as NiFi 1.13.2 and has been steadily upgraded since > mid 2021. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12524) AuditService NullPointerException After 1.23.2 to 1.24.0 Upgrade
Shawn Weeks created NIFI-12524: -- Summary: AuditService NullPointerException After 1.23.2 to 1.24.0 Upgrade Key: NIFI-12524 URL: https://issues.apache.org/jira/browse/NIFI-12524 Project: Apache NiFi Issue Type: Bug Environment: RHEL 8, OpenJDK11 Latest Reporter: Shawn Weeks Attachments: nifi-app.log Seems to be an issue with the migration from H2 to Xodus. After upgrading from 1.23.2 to 1.24.0 NiFi fails to start and throws a null pointer exception with the auditService Bean. See attached log snippet. The cluster started life as NiFi 1.13.2 and has been steadily upgraded since mid 2021. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12495 Initial commit of new design [nifi-site]
joewitt commented on PR #78: URL: https://github.com/apache/nifi-site/pull/78#issuecomment-1863140057 @james-elliott @exceptionfactory Thank you both for the effort here. I just built locally and it looks really nice. There is an issue with a couple pages such as security and such where the footer gets put into a weird spot but the overall look, downloads page, etc.. is just a really nice fresh look. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12402 add option to user can avoid an inactive indicator is crea… [nifi]
dan-s1 commented on code in PR #8063:
URL: https://github.com/apache/nifi/pull/8063#discussion_r1431617697
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MonitorActivity.java:
##
@@ -105,6 +105,14 @@ public class MonitorActivity extends AbstractProcessor {
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.defaultValue("Activity restored at time:
${now():format('/MM/dd HH:mm:ss')} after being inactive for
${inactivityDurationMillis:toNumber():divide(6)} minutes")
.build();
+public static final PropertyDescriptor WAIT_FOR_ACTIVITY = new
PropertyDescriptor.Builder()
+.name("Initial Inactivity Indicator")
+.description("When the processor gets started or restarted, it is
considered there was no activity happened before. "
++ "If true, send inactivity indicator only if there was
activity.")
Review Comment:
```suggestion
.description("When the processor gets started or restarted, if
set to true, only send an inactive indicator if there had been activity
beforehand. Otherwise send an inactive indicator even if there had not been
activity beforehand.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (NIFI-12402) MonitorActivity generates inactivity indicator after it is started and threshold duration exceeds without actual activities
[
https://issues.apache.org/jira/browse/NIFI-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798628#comment-17798628
]
Daniel Stieglitz edited comment on NIFI-12402 at 12/19/23 3:51 PM:
---
[~nathluu] In the above description
??The expected behavior is to only send an inactive indicator if there is
activity after the processor is started.??
Do you mean to say
The expected behavior is to only send an inactive indicator if there had been
activity after the processor was started?
was (Author: JIRAUSER294662):
[~nathluu] In the above description
??The expected behavior is to only send an inactive indicator if there is
activity after the processor is started.??
Do you mean to say
The expected behavior is to only send an inactive indicator if there is
{color:#DE350B}no {color}activity after the processor is started.
?
> MonitorActivity generates inactivity indicator after it is started and
> threshold duration exceeds without actual activities
> ---
>
> Key: NIFI-12402
> URL: https://issues.apache.org/jira/browse/NIFI-12402
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.23.2
>Reporter: Tan Luu
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Even though there is no activity, a start or restart of MonitorActivity
> processor produces an inactive flowfile after "Threshold Duration". This
> behavior creates a false positive notification cause there was no actual
> activity. The expected behavior is to only send an inactive indicator if
> there is activity after the processor is started.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12402) MonitorActivity generates inactivity indicator after it is started and threshold duration exceeds without actual activities
[
https://issues.apache.org/jira/browse/NIFI-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798628#comment-17798628
]
Daniel Stieglitz edited comment on NIFI-12402 at 12/19/23 3:32 PM:
---
[~nathluu] In the above description
??The expected behavior is to only send an inactive indicator if there is
activity after the processor is started.??
Do you mean to say
The expected behavior is to only send an inactive indicator if there is
{color:#DE350B}no {color}activity after the processor is started.
?
was (Author: JIRAUSER294662):
[~nathluu] In the above description
^The expected behavior is to only send an inactive indicator if there is
activity after the processor is started.^
Do you mean to say
The expected behavior is to only send an inactive indicator if there is
{color:#DE350B}no {color}activity after the processor is started.
?
> MonitorActivity generates inactivity indicator after it is started and
> threshold duration exceeds without actual activities
> ---
>
> Key: NIFI-12402
> URL: https://issues.apache.org/jira/browse/NIFI-12402
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.23.2
>Reporter: Tan Luu
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Even though there is no activity, a start or restart of MonitorActivity
> processor produces an inactive flowfile after "Threshold Duration". This
> behavior creates a false positive notification cause there was no actual
> activity. The expected behavior is to only send an inactive indicator if
> there is activity after the processor is started.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12402) MonitorActivity generates inactivity indicator after it is started and threshold duration exceeds without actual activities
[
https://issues.apache.org/jira/browse/NIFI-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798628#comment-17798628
]
Daniel Stieglitz edited comment on NIFI-12402 at 12/19/23 3:32 PM:
---
[~nathluu] In the above description
??The expected behavior is to only send an inactive indicator if there is
activity after the processor is started.??
Do you mean to say
The expected behavior is to only send an inactive indicator if there is
{color:#DE350B}no {color}activity after the processor is started.
?
was (Author: JIRAUSER294662):
[~nathluu] In the above description
??The expected behavior is to only send an inactive indicator if there is
activity after the processor is started.??
Do you mean to say
The expected behavior is to only send an inactive indicator if there is
{color:#DE350B}no {color}activity after the processor is started.
?
> MonitorActivity generates inactivity indicator after it is started and
> threshold duration exceeds without actual activities
> ---
>
> Key: NIFI-12402
> URL: https://issues.apache.org/jira/browse/NIFI-12402
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.23.2
>Reporter: Tan Luu
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Even though there is no activity, a start or restart of MonitorActivity
> processor produces an inactive flowfile after "Threshold Duration". This
> behavior creates a false positive notification cause there was no actual
> activity. The expected behavior is to only send an inactive indicator if
> there is activity after the processor is started.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12402) MonitorActivity generates inactivity indicator after it is started and threshold duration exceeds without actual activities
[
https://issues.apache.org/jira/browse/NIFI-12402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798628#comment-17798628
]
Daniel Stieglitz commented on NIFI-12402:
-
[~nathluu] In the above description
^The expected behavior is to only send an inactive indicator if there is
activity after the processor is started.^
Do you mean to say
The expected behavior is to only send an inactive indicator if there is
{color:#DE350B}no {color}activity after the processor is started.
?
> MonitorActivity generates inactivity indicator after it is started and
> threshold duration exceeds without actual activities
> ---
>
> Key: NIFI-12402
> URL: https://issues.apache.org/jira/browse/NIFI-12402
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.23.2
>Reporter: Tan Luu
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Even though there is no activity, a start or restart of MonitorActivity
> processor produces an inactive flowfile after "Threshold Duration". This
> behavior creates a false positive notification cause there was no actual
> activity. The expected behavior is to only send an inactive indicator if
> there is activity after the processor is started.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12519) BUG - Parameter deletion does not update the selected param or referencing components (right panel)
[ https://issues.apache.org/jira/browse/NIFI-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12519: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > BUG - Parameter deletion does not update the selected param or referencing > components (right panel) > --- > > Key: NIFI-12519 > URL: https://issues.apache.org/jira/browse/NIFI-12519 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0 > > Attachments: image-2023-12-15-15-43-35-404.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > When editing a parameter context. If you delete a parameter, the panel on the > right does not update to reflect nothing is selected. The deleted parameter's > info remains displayed (name and referencing components) > > !image-2023-12-15-15-43-35-404.png|width=582,height=435! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12519) BUG - Parameter deletion does not update the selected param or referencing components (right panel)
[ https://issues.apache.org/jira/browse/NIFI-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798621#comment-17798621 ] ASF subversion and git services commented on NIFI-12519: Commit 703948b1d6718c5d98dcb3bd4ea6e2145cd093a9 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=703948b1d6 ] [NIFI-12519] - deselect parameter when it is deleted. (#8166) * [NIFI-12519] - deselect parameter when it is deleted. also, enable goto controller service linking * Added confirmation dialog in controller service edit when the form is dirty and the user attempts to route away using a referencing component link * Reset state when closing the summary and counter pages. This closes #8166 > BUG - Parameter deletion does not update the selected param or referencing > components (right panel) > --- > > Key: NIFI-12519 > URL: https://issues.apache.org/jira/browse/NIFI-12519 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Attachments: image-2023-12-15-15-43-35-404.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > When editing a parameter context. If you delete a parameter, the panel on the > right does not update to reflect nothing is selected. The deleted parameter's > info remains displayed (name and referencing components) > > !image-2023-12-15-15-43-35-404.png|width=582,height=435! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12519] - deselect parameter when it is deleted. [nifi]
mcgilman merged PR #8166: URL: https://github.com/apache/nifi/pull/8166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12493) Update Documentation References to Java 21
[ https://issues.apache.org/jira/browse/NIFI-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-12493: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Update Documentation References to Java 21 > -- > > Key: NIFI-12493 > URL: https://issues.apache.org/jira/browse/NIFI-12493 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.0.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Several documentation guides and comments various components should be > updated to reference Java 21 as it is the minimum required version for NiFi > 2.0.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12493) Update Documentation References to Java 21
[ https://issues.apache.org/jira/browse/NIFI-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798607#comment-17798607 ] ASF subversion and git services commented on NIFI-12493: Commit 6b7b7cccf812efe22f3c7a33124883c4fa09656a in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6b7b7cccf8 ] NIFI-12493 Update Documentation References to Java 21 (#8144) * NIFI-12493 Updated Documentation References to Java 21 - Removed Apache Maven download step from Custom Distribution instructions and referenced Apache Maven Wrapper in command - Updated Java Documentation links to Java 21 * NIFI-12493 Updated additional Java version references > Update Documentation References to Java 21 > -- > > Key: NIFI-12493 > URL: https://issues.apache.org/jira/browse/NIFI-12493 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.0.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Several documentation guides and comments various components should be > updated to reference Java 21 as it is the minimum required version for NiFi > 2.0.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12493 Update Documentation References to Java 21 [nifi]
bbende merged PR #8144: URL: https://github.com/apache/nifi/pull/8144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2261 Add processor for pushing logs to Grafana Loki through REST API [nifi-minifi-cpp]
fgerlits commented on code in PR #1695:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1695#discussion_r1425597679
##
docker/test/integration/cluster/checkers/GrafanaLokiChecker.py:
##
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+import requests
+from typing import List
+from utils import wait_for
+
+
+class GrafanaLokiChecker:
+def __init__(self):
+self.url = "localhost:3100/loki/api/v1/query"
+
+def veify_log_lines_on_grafana_loki(self, lines: List[str], ssl: bool,
tenant_id: str):
+labels = '{job="minifi"}'
+prefix = "http://;
+if ssl:
+prefix = "https://;
+
+query_url = f"{prefix}{self.url}?query={labels}"
+
+headers = None
+if tenant_id:
+headers = {'X-Scope-OrgID': tenant_id}
+
+response = requests.get(query_url, verify=False, timeout=30,
headers=headers)
+if response.status_code >= 200 and response.status_code < 300:
Review Comment:
this conditional could be reversed, so the `return True` happens at the end
of the function
##
extensions/grafana-loki/PushGrafanaLokiREST.cpp:
##
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "PushGrafanaLokiREST.h"
+
+#include
+#include
+#include
+
+#include "core/ProcessContext.h"
+#include "core/ProcessSession.h"
+#include "core/Resource.h"
+#include "utils/ProcessorConfigUtils.h"
+#include "utils/StringUtils.h"
+#include "rapidjson/document.h"
+#include "rapidjson/stream.h"
+#include "rapidjson/writer.h"
+
+namespace org::apache::nifi::minifi::extensions::grafana::loki {
+
+void PushGrafanaLokiREST::LogBatch::add(const std::shared_ptr&
flowfile) {
+ gsl_Expects(state_manager_);
+ if (log_line_batch_wait_ && batched_flowfiles_.empty()) {
+start_push_time_ = std::chrono::steady_clock::now();
+std::unordered_map state;
+state["start_push_time"] =
std::to_string(std::chrono::duration_cast(start_push_time_.time_since_epoch()).count());
+logger_->log_debug("Saved start push time to state: {}",
state["start_push_time"]);
+state_manager_->set(state);
+ }
+ batched_flowfiles_.push_back(flowfile);
+}
+
+void PushGrafanaLokiREST::LogBatch::restore(const
std::shared_ptr& flowfile) {
+ batched_flowfiles_.push_back(flowfile);
+}
+
+std::vector>
PushGrafanaLokiREST::LogBatch::flush() {
+ gsl_Expects(state_manager_);
+ start_push_time_ = {};
+ auto result = batched_flowfiles_;
+ batched_flowfiles_.clear();
+ if (log_line_batch_wait_) {
+start_push_time_ = {};
+std::unordered_map state;
+logger_->log_debug("Reset start push time state");
+state["start_push_time"] = "0";
+state_manager_->set(state);
+ }
+ return result;
+}
+
+bool PushGrafanaLokiREST::LogBatch::isReady() const {
+ return (log_line_batch_size_ && batched_flowfiles_.size() >=
*log_line_batch_size_) || (log_line_batch_wait_ &&
std::chrono::steady_clock::now() - start_push_time_ >= *log_line_batch_wait_);
+}
+
+void
PushGrafanaLokiREST::LogBatch::setLogLineBatchSize(std::optional
log_line_batch_size) {
+ log_line_batch_size_ = log_line_batch_size;
+}
+
+void
PushGrafanaLokiREST::LogBatch::setLogLineBatchWait(std::optional
log_line_batch_wait) {
+ log_line_batch_wait_ = log_line_batch_wait;
+}
+
+void PushGrafanaLokiREST::LogBatch::setStateManager(core::StateManager*
state_manager) {
+ state_manager_ = state_manager;
+}
+
+void
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12504) * Counters (NIFI-12415) * Bulletin Board * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Flow Analysis Rules * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable ** Disable ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * Prevent navigate to Service when configuration form is dirty * Introduce header in new pages to unify with canvas and offer better navigation. * Prompt user to save Parameter Context when Edit form is dirty [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12504) * Counters (NIFI-12415) * Bulletin Board * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Flow Analysis Rules * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable ** Disable ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * Prevent navigate to Service when configuration form is dirty * Introduce header in new pages to unify with canvas and offer better navigation. [1] [https://github.com/apache/nifi/pull/8053] > Remaining items to migrate UI to currently supported/active framework > - > > Key: NIFI-12400 > URL:
[jira] [Created] (MINIFICPP-2275) Use utils::string instead of utils::StringUtils
Ferenc Gerlits created MINIFICPP-2275:
-
Summary: Use utils::string instead of utils::StringUtils
Key: MINIFICPP-2275
URL: https://issues.apache.org/jira/browse/MINIFICPP-2275
Project: Apache NiFi MiNiFi C++
Issue Type: Improvement
Reporter: Ferenc Gerlits
Assignee: Ferenc Gerlits
The namespace alias {{utils::StringUtils}} of the namespace {{utils::string}}
was added for backwards compatibility, but I think it's time to get rid of it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] MINIFICPP-2275 Use utils::string instead of utils::StringUtils [nifi-minifi-cpp]
fgerlits opened a new pull request, #1710: URL: https://github.com/apache/nifi-minifi-cpp/pull/1710 https://issues.apache.org/jira/browse/MINIFICPP-2275 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2259 ProcessContext::getProperty should operate on raw poin… [nifi-minifi-cpp]
martinzink commented on code in PR #1707:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1707#discussion_r1431353285
##
extensions/aws/processors/FetchS3Object.h:
##
@@ -46,6 +46,7 @@ class FetchS3Object : public S3Processor {
.supportsExpressionLanguage(true)
.build();
EXTENSIONAPI static constexpr auto Version =
core::PropertyDefinitionBuilder<>::createProperty("Version")
+ .withDescription("The Version of the Object to download")
Review Comment:
good catch fixed it in
https://github.com/apache/nifi-minifi-cpp/pull/1707/commits/d64e7f890b82be04ec5a75bc484a1ebcbb001f32
##
libminifi/src/core/ProcessSession.cpp:
##
@@ -199,21 +198,19 @@ void ProcessSession::remove(const
std::shared_ptr ) {
flow->setDeleted(true);
deleted_flowfiles_.push_back(flow);
std::string reason = process_context_->getProcessorNode()->getName() + "
drop flow record " + flow->getUUIDStr();
- provenance_report_->drop(flow, reason);
+ provenance_report_->drop(*flow, reason);
}
-void ProcessSession::putAttribute(const std::shared_ptr& flow,
std::string_view key, const std::string& value) {
- flow->setAttribute(key, value);
- std::stringstream details;
- details << process_context_->getProcessorNode()->getName() << " modify flow
record " << flow->getUUIDStr() << " attribute " << key << ":" << value;
- provenance_report_->modifyAttributes(flow, details.str());
+void ProcessSession::putAttribute(core::FlowFile& flow_file, std::string_view
key, const std::string& value) {
+ flow_file.setAttribute(key, value);
+ std::string details = fmt::format("{} modify flow record {} attribute {} :
{}", process_context_->getProcessorNode()->getName(), flow_file.getUUIDStr(),
key, value);
Review Comment:
good catch fixed it in
https://github.com/apache/nifi-minifi-cpp/pull/1707/commits/d64e7f890b82be04ec5a75bc484a1ebcbb001f32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2273 Update minifi documentation [nifi-site]
martinzink commented on code in PR #79: URL: https://github.com/apache/nifi-site/pull/79#discussion_r1431113253 ## source/minifi/minifi-java-guide-pushing-nifi-minifi.md: ## @@ -94,7 +50,7 @@ No validation errors found in template. ``` Open the config.yml file and add Port and Host to a Properties section at the end of the Input Ports section (at the end of the file): -``` + Review Comment: good catch wasnt intentional fixed it in https://github.com/apache/nifi-site/pull/79/commits/db571ce47762a7ba99be83f7b45255bdb10fcbcb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
