Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
exceptionfactory commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1437971330
##
nifi-api/src/main/java/org/apache/nifi/provenance/upload/FileResource.java:
##
@@ -20,15 +20,26 @@
* Holds information of a file resource for UPLOAD
* provenance events.
*/
-public interface FileResource {
+public class FileResource {
Review Comment:
Thanks for the clarification, I should have reviewed the full history, that
makes sense.
Yes, I recommend defining the methods required for the common use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
Lehel44 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1437917401
##
nifi-api/src/main/java/org/apache/nifi/provenance/upload/FileResource.java:
##
@@ -20,15 +20,26 @@
* Holds information of a file resource for UPLOAD
* provenance events.
*/
-public interface FileResource {
+public class FileResource {
Review Comment:
I can reduce the number of methods, I followed the signatures of the send
method. I can check which ones are more frequently used and eliminate the
others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
Lehel44 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1437914962
##
nifi-api/src/main/java/org/apache/nifi/provenance/upload/FileResource.java:
##
@@ -20,15 +20,26 @@
* Holds information of a file resource for UPLOAD
* provenance events.
*/
-public interface FileResource {
+public class FileResource {
Review Comment:
@exceptionfactory I included the FileResource interface in this pull request
as an interface, but later realized it's unnecessary as it functions as a
straightforward DTO. Moreover, if I introduce the StandardFileResource
implementation to nifi-data-provenance-utils (the place I thought to add it),
it will create a dependency on nifi processors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12543: Users/User Groups [nifi]
rfellows commented on code in PR #8191:
URL: https://github.com/apache/nifi/pull/8191#discussion_r1437892895
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/users/ui/user-listing/user-access-policies/user-access-policies.component.html:
##
@@ -0,0 +1,82 @@
+
+
+
+User Policies
+
+User
+{{ request.identity }}
+
+
+
+
+
+
+Policy
+
+
+{{ formatPolicy(item) }}
+
+
+{{ item.id }}
+
+
+
+
+
+
+Action
+
+{{ item.component.action }}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+Some policies may be inherited by descendant components
unless explicitly overridden.
+
+Close
+
+
Review Comment:
This dialog is too wide when opened. Also, consider using `mat-dialog-title`
`` and `` to identify the dialog
structure.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/users/ui/user-listing/user-table/user-table.component.ts:
##
@@ -0,0 +1,245 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { AfterViewInit, Component, EventEmitter, Input, Output } from
'@angular/core';
+import { MatTableDataSource } from '@angular/material/table';
+import { Sort } from '@angular/material/sort';
+import { FormBuilder, FormGroup } from '@angular/forms';
+import { debounceTime } from 'rxjs';
+import { NiFiCommon } from '../../../../../service/nifi-common.service';
+import { CurrentUser } from '../../../../../state/current-user';
+import { AccessPolicySummaryEntity, UserEntity, UserGroupEntity } from
'../../../../../state/shared';
+
+export interface TenantItem {
+id: string;
+user: string;
+tenantType: 'user' | 'userGroup';
+membership: string[];
+configurable: boolean;
+}
+
+export interface Tenants {
+users: UserEntity[];
+userGroups: UserGroupEntity[];
+}
+
+@Component({
+selector: 'user-table',
+templateUrl: './user-table.component.html',
+styleUrls: ['./user-table.component.scss',
'../../../../../../assets/styles/listing-table.scss']
+})
+export class UserTable implements AfterViewInit {
+filterTerm: string = '';
+filterColumn: 'user' | 'membership' = 'user';
+totalCount: number = 0;
+filteredCount: number = 0;
+
+displayedColumns: string[] = ['user', 'membership', 'actions'];
+dataSource: MatTableDataSource = new
MatTableDataSource();
+filterForm: FormGroup;
+
+userLookup: Map = new Map();
+userGroupLookup: Map = new Map();
+
+@Input() set tenants(tenants: Tenants) {
+this.userLookup.clear();
+this.userGroupLookup.clear();
+
+const tenantItems: TenantItem[] = [];
+tenants.users.forEach((user) => {
+this.userLookup.set(user.id, user);
+tenantItems.push({
+id: user.id,
+tenantType: 'user',
+user: user.component.identity,
+membership: user.component.userGroups.map((userGroup) =>
userGroup.component.identity),
+configurable: user.component.configurable
+});
+});
+tenants.userGroups.forEach((userGroup) => {
+this.userGroupLookup.set(userGroup.id, userGroup);
+tenantItems.push({
+id: userGroup.id,
+tenantType: 'userGroup',
+user: userGroup.component.identity,
+membership: userGroup.component.users.map((user) =>
user.component.identity),
+configurable: userGroup.component.configurable
+});
+});
+
+
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
exceptionfactory commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1437901472
##
nifi-api/src/main/java/org/apache/nifi/provenance/upload/FileResource.java:
##
@@ -20,15 +20,26 @@
* Holds information of a file resource for UPLOAD
* provenance events.
*/
-public interface FileResource {
+public class FileResource {
Review Comment:
This is a breaking change, so it should be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12505) System Diagnostics
[ https://issues.apache.org/jira/browse/NIFI-12505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12505: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > System Diagnostics > -- > > Key: NIFI-12505 > URL: https://issues.apache.org/jira/browse/NIFI-12505 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12505) System Diagnostics
[ https://issues.apache.org/jira/browse/NIFI-12505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801050#comment-17801050 ] ASF subversion and git services commented on NIFI-12505: Commit e15aecce67ff329b268d3586a0953cff4ac7df7f in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e15aecce67 ] Nifi 12505 system diagnostics (#8190) * [NIFI-12505] System Diagnostics * Refactor Status History dialog to use the load and open action pattern. * address review feedback This closes #8190 > System Diagnostics > -- > > Key: NIFI-12505 > URL: https://issues.apache.org/jira/browse/NIFI-12505 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Nifi 12505 system diagnostics [nifi]
mcgilman merged PR #8190: URL: https://github.com/apache/nifi/pull/8190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12543: Users/User Groups [nifi]
rfellows commented on PR #8191: URL: https://github.com/apache/nifi/pull/8191#issuecomment-1871463866 reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12543) Introduce pages for managing Users/Groups
[ https://issues.apache.org/jira/browse/NIFI-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12543: --- Status: Patch Available (was: In Progress) > Introduce pages for managing Users/Groups > - > > Key: NIFI-12543 > URL: https://issues.apache.org/jira/browse/NIFI-12543 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Introduce pages for managing Users/Groups. This includes creation, listing, > configuration, deleting, and viewing the access policies for users and user > groups. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Nifi 12505 system diagnostics [nifi]
rfellows commented on code in PR #8190:
URL: https://github.com/apache/nifi/pull/8190#discussion_r1437738340
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-listing.component.html:
##
@@ -41,6 +41,9 @@
Last updated:
{{ loadedTimestamp$ | async
}}
+
+System
Diagnostics
Review Comment:
I'll hide these links if the user does not had the appropriate permission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Nifi 12505 system diagnostics [nifi]
mcgilman commented on code in PR #8190:
URL: https://github.com/apache/nifi/pull/8190#discussion_r1437691415
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-listing.component.html:
##
@@ -41,6 +41,9 @@
Last updated:
{{ loadedTimestamp$ | async
}}
+
+System
Diagnostics
Review Comment:
There is an explicit permission for accessing system diagnostics. In current
NiFi the link is always shown and the user gets an insufficient permissions
error message when clicking it. We could consider hiding the link in this case
or showing the message in a dialog. Currently, it is unhandled and nothing
happens in the UI. Inspecting Dev Tools shows the `403` response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Nifi 12505 system diagnostics [nifi]
mcgilman commented on code in PR #8190:
URL: https://github.com/apache/nifi/pull/8190#discussion_r1437691415
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-listing.component.html:
##
@@ -41,6 +41,9 @@
Last updated:
{{ loadedTimestamp$ | async
}}
+
+System
Diagnostics
Review Comment:
There is an explicit permission for accessing system diagnostics. In current
NiFi the URL is always shown and the user gets an insufficent permissions error
message when clicking it. We could consider hiding the link in this case or
showing the message in a dialog. Currently, it is unhandled and nothing happens
in the UI. Inspecting Dev Tools shows the `403` response.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-listing.component.ts:
##
@@ -104,4 +108,15 @@ export class ConnectionStatusListing {
})
);
}
+
+openSystemDiagnostics(event: MouseEvent) {
+event.stopPropagation();
Review Comment:
I don't think this `stopPropagation` is needed here. It's needed in table
actions which results in the user being navigated someplace. That navigation
conflicted with the row selection which also changed the route. This comment
applies to all instances of `openSystemDiagnostics` in all component status
listings.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/system-diagnostics-dialog/system-diagnostics-dialog.component.spec.ts:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { ComponentFixture, TestBed } from '@angular/core/testing';
+
+import { SystemDiagnosticsDialog } from
'./system-diagnostics-dialog.component';
+import { provideMockStore } from '@ngrx/store/testing';
+import { initialSystemDiagnosticsState } from
'../../../state/system-diagnostics/system-diagnostics.reducer';
+import { MAT_DIALOG_DATA } from '@angular/material/dialog';
+
+describe('SystemDiagnosticsDialogComponent', () => {
Review Comment:
This text does not match the component name. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12517 Enabled an attribute to be considered JSON even if it has leading and trailing spaces. [nifi]
exceptionfactory commented on PR #8165: URL: https://github.com/apache/nifi/pull/8165#issuecomment-1871230840 > @exceptionfactory I see on the `ci-workflow / Static Analysis` `Error:` but I do not see any stack trace explaining why when I search through the logs. Can you please restart this? It looks like there is a Checkstyle violation reported in the logs due to an unused import: ``` Warning: src/test/java/org/apache/nifi/processors/standard/TestAttributesToJSON.java:[30,8] (imports) UnusedImports: Unused import - org.junit.jupiter.api.function.ThrowingSupplier. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12517 Enabled an attribute to be considered JSON even if it has leading and trailing spaces. [nifi]
dan-s1 commented on PR #8165: URL: https://github.com/apache/nifi/pull/8165#issuecomment-1871216106 @exceptionfactory I see on the `ci-workflow / Static Analysis` `Error:` but I do not see any stack trace explaining why. Can you please restart this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12529) Enable/Disable Controller Service
[ https://issues.apache.org/jira/browse/NIFI-12529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12529: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Enable/Disable Controller Service > - > > Key: NIFI-12529 > URL: https://issues.apache.org/jira/browse/NIFI-12529 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Add support to enable and disable controller services. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12529) Enable/Disable Controller Service
[ https://issues.apache.org/jira/browse/NIFI-12529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801003#comment-17801003 ] ASF subversion and git services commented on NIFI-12529: Commit a73d812c235746b96dec589843991a6f0988ce65 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a73d812c23 ] NIFI-12529: Enable/Disable Controller Service (#8185) * NIFI-12529: - Enable/Disable Controller Services. - Resetting state when destroying Controller Service listings, General, Registry Clients, and Reporting Tasks. * NIFI-12529: - Addressing review feedback. This closes #8185 > Enable/Disable Controller Service > - > > Key: NIFI-12529 > URL: https://issues.apache.org/jira/browse/NIFI-12529 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Add support to enable and disable controller services. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12529: Enable/Disable Controller Service [nifi]
rfellows merged PR #8185: URL: https://github.com/apache/nifi/pull/8185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12202) SAML Infinitely Redirects
[ https://issues.apache.org/jira/browse/NIFI-12202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Jackson updated NIFI-12202: Affects Version/s: 1.24.0 > SAML Infinitely Redirects > - > > Key: NIFI-12202 > URL: https://issues.apache.org/jira/browse/NIFI-12202 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.24.0, 1.23.1, 1.23.2 >Reporter: Alex Jackson >Priority: Major > > We have SAML configured and when I updated from 1.20.0 to 1.23.1 (at the > time) and just tried now 1.23.2 I see that SAML authentication takes place > but I am infinitely redirected and eventually land on a nifi-api address. I > havent got it deployed in this bad state anymore but I feel like there is an > issue with SAML and it would be great if someone could look into it -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12202) SAML Infinitely Redirects
[ https://issues.apache.org/jira/browse/NIFI-12202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800983#comment-17800983 ] Alex Jackson commented on NIFI-12202: - Hi, apologies for the delay in update. I didn't get notified and I am revisiting this topic again on my end... Our SAML is done via ADFS. What I notice when I monitor the network tab is that I initially get 401 for current-user (this is expected as we do not know the user yet) then I am sent to the login page nifi login page /nifi/login which is found and following this I get consumer /nifi-api/saml2/authenticate/consumer which is also found, after this i see my saml request adfs/ls/?SAMLRequest=... which is 200 and then I am again at consumer 302 and then finally nifi with 200. It then lodas all the elements it should css wise etc. and gets the regular 409 for kerberos (makes sense as this is not configured) but on both expiration nifi-api/access/token/expiration and current-user nifi-api/flow/current-user I get a 401. So what I see is the whole loop again to saml happens, same game, to then again get 401 on current user... I cannot load any screenshots for you as my company is very strict with external internet access, this browser is in an isolated virtual machine that I cannot copy data to or from. I do not have this problem in 1.22 but as soon as I try 1.23.2 or 1.24 this problem exists. I believe this is related to this change: https://issues.apache.org/jira/browse/NIFI-11492 I cannot find anything else in the release notes that talks about SAML otherwise... I also do not see anything in nifi-app or nifi-user logs, not even me attempting to make my request, the only requests are my technical user that goes to the nifi-api/flow/metrics/prometheus endpoint. > SAML Infinitely Redirects > - > > Key: NIFI-12202 > URL: https://issues.apache.org/jira/browse/NIFI-12202 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.24.0, 1.23.1, 1.23.2 >Reporter: Alex Jackson >Priority: Major > > We have SAML configured and when I updated from 1.20.0 to 1.23.1 (at the > time) and just tried now 1.23.2 I see that SAML authentication takes place > but I am infinitely redirected and eventually land on a nifi-api address. I > havent got it deployed in this bad state anymore but I feel like there is an > issue with SAML and it would be great if someone could look into it -- This message was sent by Atlassian Jira (v8.20.10#820010)
