[jira] [Updated] (NIFI-11294) ConsumeAzureEventHub should support Component State for Checkpointing
[ https://issues.apache.org/jira/browse/NIFI-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11294: Fix Version/s: 1.25.0 > ConsumeAzureEventHub should support Component State for Checkpointing > - > > Key: NIFI-11294 > URL: https://issues.apache.org/jira/browse/NIFI-11294 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Malthe Borch >Assignee: Peter Turcsanyi >Priority: Major > Fix For: 1.25.0, 2.0.0-M2 > > Time Spent: 5h 10m > Remaining Estimate: 0h > > The current implementation requires an Azure Blob Storage account to persist > offsets (checkpointing) between restarts. > In NiFi, we have a readily available state store which is the processor state. > We should default to using this storage such that "Storage Account Name" > becomes a non-required field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11294) ConsumeAzureEventHub should support Component State for Checkpointing
[ https://issues.apache.org/jira/browse/NIFI-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810679#comment-17810679 ] ASF subversion and git services commented on NIFI-11294: Commit fa9f05812ab8238accac0016429ea4dcace3342c in nifi's branch refs/heads/support/nifi-1.x from Peter Turcsanyi [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=fa9f05812a ] NIFI-11294 Support Component State Checkpoints in ConsumeAzureEventHub This closes #8297 Signed-off-by: David Handermann Co-authored-by: Peter Turcsanyi Co-authored-by: Malthe Borch > ConsumeAzureEventHub should support Component State for Checkpointing > - > > Key: NIFI-11294 > URL: https://issues.apache.org/jira/browse/NIFI-11294 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Malthe Borch >Assignee: Peter Turcsanyi >Priority: Major > Fix For: 2.0.0-M2 > > Time Spent: 4h 50m > Remaining Estimate: 0h > > The current implementation requires an Azure Blob Storage account to persist > offsets (checkpointing) between restarts. > In NiFi, we have a readily available state store which is the processor state. > We should default to using this storage such that "Storage Account Name" > becomes a non-required field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11294 Support Component State Checkpoints in ConsumeAzureEventHub [nifi]
exceptionfactory commented on PR #8297: URL: https://github.com/apache/nifi/pull/8297#issuecomment-1909394234 Merged in https://github.com/apache/nifi/commit/fa9f05812ab8238accac0016429ea4dcace3342c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11294 Support Component State Checkpoints in ConsumeAzureEventHub [nifi]
exceptionfactory closed pull request #8297: NIFI-11294 Support Component State Checkpoints in ConsumeAzureEventHub URL: https://github.com/apache/nifi/pull/8297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12664 - remove deprecated DMC in GetHBase [nifi]
pvillard31 opened a new pull request, #8301: URL: https://github.com/apache/nifi/pull/8301 # Summary [NIFI-12664](https://issues.apache.org/jira/browse/NIFI-12664) - remove deprecated DMC in GetHBase # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12668 Fix conflict in Registry Git provider with system config gpg.format=ssh [nifi]
brianghig opened a new pull request, #8300: URL: https://github.com/apache/nifi/pull/8300 # Summary [NIFI-12668](https://issues.apache.org/jira/browse/NIFI-12668) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [X] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [X] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [X] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12668) Test for Git-backed Registry fails with global Git config value
[
https://issues.apache.org/jira/browse/NIFI-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810626#comment-17810626
]
Brian Ghigiarelli commented on NIFI-12668:
--
This is still an issue after upgrading to the latest version of JGit
6.8.0.202311291450-r, per NIFI-12667.
> Test for Git-backed Registry fails with global Git config value
> ---
>
> Key: NIFI-12668
> URL: https://issues.apache.org/jira/browse/NIFI-12668
> Project: Apache NiFi
> Issue Type: Improvement
> Components: NiFi Registry
>Affects Versions: 2.0.0-M1
>Reporter: Brian Ghigiarelli
>Priority: Minor
>
> The Git-backed Registry provider, GitFlowPersistenceProvider, does not
> digitally sign commits to Git, nor does it specify the GPG configuration that
> would be used if it were to sign commits. See
> [GitFlowMetaData.java:478|https://github.com/apache/nifi/blob/89836f32d017d77972a4de09c4e864b0e11899a8/nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/flow/git/GitFlowMetaData.java#L478].
> When the GPG configuration is not specified, the underlying jgit library uses
> the default value of openpgp for the GPG format when it performs the commit.
> This works fine except when the system's global Git configuration has
> `gpg.format` set to `ssh`. Available options are:
> * openpgp (default)
> * x509
> * ssh
> The underlying jgit library does not recognize `ssh` as a valid GPG format.
> jgit validates the GPG configuration when committing to git, whether it signs
> the commit or not.
> This issue manifests when a user attempts to run NiFi's tests with their
> global Git configuration has `gpg.format` set to `ssh`. It would also occur
> if the NiFi Registry ran on a server with Git installed and configured in the
> same manner.
> h3. Steps to reproduce
> From the root NiFi source code directory, run:
> {code:java}
> git config --global gpg.format ssh
> cd ./nifi-registry/nifi-registry-core/nifi-registry-framework
> mvn clean test{code}
> h3. Observed Failure
> {code:java}
> [ERROR] Tests run: 6, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 3.387
> s <<< FAILURE! -- in
> org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider
> [ERROR]
> org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadLargeFlow
> -- Time elapsed: 3.273 s <<< ERROR!
> java.lang.IllegalArgumentException: Invalid value: gpg.format=ssh
> at
> org.eclipse.jgit.lib.DefaultTypedConfigGetter.getEnum(DefaultTypedConfigGetter.java:103)
> at org.eclipse.jgit.lib.Config.getEnum(Config.java:453)
> at org.eclipse.jgit.lib.GpgConfig.(GpgConfig.java:86)
> at
> org.eclipse.jgit.api.CommitCommand.processOptions(CommitCommand.java:662)
> at org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:189)
> at
> org.apache.nifi.registry.provider.flow.git.GitFlowMetaData.commit(GitFlowMetaData.java:481)
> at
> org.apache.nifi.registry.provider.flow.git.GitFlowPersistenceProvider.saveFlowContent(GitFlowPersistenceProvider.java:187)
> at
> org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.lambda$testLoadLargeFlow$14(TestGitFlowPersistenceProvider.java:311)
> at
> org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.assertProvider(TestGitFlowPersistenceProvider.java:112)
> at
> org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadLargeFlow(TestGitFlowPersistenceProvider.java:300)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
> at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
> [ERROR]
> org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadCommitHistories
> -- Time elapsed: 0.008 s <<< ERROR!
> java.lang.IllegalArgumentException: Invalid value: gpg.format=ssh
> at
> org.eclipse.jgit.lib.DefaultTypedConfigGetter.getEnum(DefaultTypedConfigGetter.java:103)
> at org.eclipse.jgit.lib.Config.getEnum(Config.java:453)
> at org.eclipse.jgit.lib.GpgConfig.(GpgConfig.java:86)
> at
> org.eclipse.jgit.api.CommitCommand.processOptions(CommitCommand.java:662)
> at org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:189)
> at
> org.apache.nifi.registry.provider.flow.git.GitFlowMetaData.commit(GitFlowMetaData.java:481)
> at
> org.apache.nifi.registry.provider.flow.git.GitFlowPersistenceProvider.saveFlowContent(GitFlowPersistenceProvider.java:187)
> at
> org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.lambda$testLoadCommitHistories$6(TestGitFlowPersistenceProvider.java:153)
> at
> o
[jira] [Updated] (NIFI-12668) Test for Git-backed Registry fails with global Git config value
[
https://issues.apache.org/jira/browse/NIFI-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brian Ghigiarelli updated NIFI-12668:
-
Description:
The Git-backed Registry provider, GitFlowPersistenceProvider, does not
digitally sign commits to Git, nor does it specify the GPG configuration that
would be used if it were to sign commits. See
[GitFlowMetaData.java:478|https://github.com/apache/nifi/blob/89836f32d017d77972a4de09c4e864b0e11899a8/nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/flow/git/GitFlowMetaData.java#L478].
When the GPG configuration is not specified, the underlying jgit library uses
the default value of openpgp for the GPG format when it performs the commit.
This works fine except when the system's global Git configuration has
`gpg.format` set to `ssh`. Available options are:
* openpgp (default)
* x509
* ssh
The underlying jgit library does not recognize `ssh` as a valid GPG format.
jgit validates the GPG configuration when committing to git, whether it signs
the commit or not.
This issue manifests when a user attempts to run NiFi's tests with their global
Git configuration has `gpg.format` set to `ssh`. It would also occur if the
NiFi Registry ran on a server with Git installed and configured in the same
manner.
h3. Steps to reproduce
>From the root NiFi source code directory, run:
{code:java}
git config --global gpg.format ssh
cd ./nifi-registry/nifi-registry-core/nifi-registry-framework
mvn clean test{code}
h3. Observed Failure
{code:java}
[ERROR] Tests run: 6, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 3.387 s
<<< FAILURE! -- in
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider
[ERROR]
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadLargeFlow
-- Time elapsed: 3.273 s <<< ERROR!
java.lang.IllegalArgumentException: Invalid value: gpg.format=ssh
at
org.eclipse.jgit.lib.DefaultTypedConfigGetter.getEnum(DefaultTypedConfigGetter.java:103)
at org.eclipse.jgit.lib.Config.getEnum(Config.java:453)
at org.eclipse.jgit.lib.GpgConfig.(GpgConfig.java:86)
at
org.eclipse.jgit.api.CommitCommand.processOptions(CommitCommand.java:662)
at org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:189)
at
org.apache.nifi.registry.provider.flow.git.GitFlowMetaData.commit(GitFlowMetaData.java:481)
at
org.apache.nifi.registry.provider.flow.git.GitFlowPersistenceProvider.saveFlowContent(GitFlowPersistenceProvider.java:187)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.lambda$testLoadLargeFlow$14(TestGitFlowPersistenceProvider.java:311)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.assertProvider(TestGitFlowPersistenceProvider.java:112)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadLargeFlow(TestGitFlowPersistenceProvider.java:300)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
[ERROR]
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadCommitHistories
-- Time elapsed: 0.008 s <<< ERROR!
java.lang.IllegalArgumentException: Invalid value: gpg.format=ssh
at
org.eclipse.jgit.lib.DefaultTypedConfigGetter.getEnum(DefaultTypedConfigGetter.java:103)
at org.eclipse.jgit.lib.Config.getEnum(Config.java:453)
at org.eclipse.jgit.lib.GpgConfig.(GpgConfig.java:86)
at
org.eclipse.jgit.api.CommitCommand.processOptions(CommitCommand.java:662)
at org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:189)
at
org.apache.nifi.registry.provider.flow.git.GitFlowMetaData.commit(GitFlowMetaData.java:481)
at
org.apache.nifi.registry.provider.flow.git.GitFlowPersistenceProvider.saveFlowContent(GitFlowPersistenceProvider.java:187)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.lambda$testLoadCommitHistories$6(TestGitFlowPersistenceProvider.java:153)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.assertProvider(TestGitFlowPersistenceProvider.java:112)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadCommitHistories(TestGitFlowPersistenceProvider.java:140)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) {code}
...
{code:java}
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]
TestGitFlowPersistenceProvider.testLoadCommitHistories:140->assertProvider:112->lambda$testLoadCommitHistories$6:153
» IllegalA
[jira] [Commented] (NIFI-12387) Flow Configuration History can record a Comments change for Controller Service when no changes have been made
[
https://issues.apache.org/jira/browse/NIFI-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810623#comment-17810623
]
ASF subversion and git services commented on NIFI-12387:
Commit 7f0cedf6b6ac4a5858fc6a3297f4bdbb9668901e in nifi's branch
refs/heads/support/nifi-1.x from Nissim Shiman
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7f0cedf6b6 ]
NIFI-12387 Initialize Controller Service Comments with Empty String
The empty string allows controller service configuration to be saved without
flow
configuration history recording a configuration change for comments.
This closes #8275
Signed-off-by: David Handermann
(cherry picked from commit 2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4)
> Flow Configuration History can record a Comments change for Controller
> Service when no changes have been made
> -
>
> Key: NIFI-12387
> URL: https://issues.apache.org/jira/browse/NIFI-12387
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 2.0.0-M1, 1.16.3, 1.23.2
>Reporter: Nissim Shiman
>Assignee: Nissim Shiman
>Priority: Major
> Labels: backport-needed
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> To recreate, create a new controller service then open configuration gui for
> it and click Apply button (without having made any changes to default
> settings).
> Flow Configuration History will note that a Configure operation has occurred
> and the Comments have been changed from _No value set_ to an {_}Empty string
> se{_}t.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12387) Flow Configuration History can record a Comments change for Controller Service when no changes have been made
[
https://issues.apache.org/jira/browse/NIFI-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12387:
Fix Version/s: 1.25.0
2.0.0-M2
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Flow Configuration History can record a Comments change for Controller
> Service when no changes have been made
> -
>
> Key: NIFI-12387
> URL: https://issues.apache.org/jira/browse/NIFI-12387
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 2.0.0-M1, 1.16.3, 1.23.2
>Reporter: Nissim Shiman
>Assignee: Nissim Shiman
>Priority: Major
> Labels: backport-needed
> Fix For: 1.25.0, 2.0.0-M2
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> To recreate, create a new controller service then open configuration gui for
> it and click Apply button (without having made any changes to default
> settings).
> Flow Configuration History will note that a Configure operation has occurred
> and the Comments have been changed from _No value set_ to an {_}Empty string
> se{_}t.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12666) Correct NiFi Registry Data Source Configuration
[ https://issues.apache.org/jira/browse/NIFI-12666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810617#comment-17810617 ] ASF subversion and git services commented on NIFI-12666: Commit 693b187396ebe60a8e518d6fb8c4d222a178811a in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=693b187396 ] NIFI-12666 Corrected Registry Data Source Configuration (#8299) > Correct NiFi Registry Data Source Configuration > --- > > Key: NIFI-12666 > URL: https://issues.apache.org/jira/browse/NIFI-12666 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Critical > Fix For: 2.0.0-M2 > > Time Spent: 20m > Remaining Estimate: 0h > > Recent updates to NiFi Registry for Spring Framework 6.1 introduced > conditional configuration for Data Source configuration. This change resulted > in Registry ignoring the configured NiFi Registry Database URL and instead > using a memory-backed H2 URL at runtime. The conditional configuration > setting should be removed and associated tests should be updated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12387) Flow Configuration History can record a Comments change for Controller Service when no changes have been made
[
https://issues.apache.org/jira/browse/NIFI-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810618#comment-17810618
]
ASF subversion and git services commented on NIFI-12387:
Commit 2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4 in nifi's branch
refs/heads/main from Nissim Shiman
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2e3f83eb54 ]
NIFI-12387 Initialize Controller Service Comments with Empty String
The empty string allows controller service configuration to be saved without
flow
configuration history recording a configuration change for comments.
This closes #8275
Signed-off-by: David Handermann
> Flow Configuration History can record a Comments change for Controller
> Service when no changes have been made
> -
>
> Key: NIFI-12387
> URL: https://issues.apache.org/jira/browse/NIFI-12387
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 2.0.0-M1, 1.16.3, 1.23.2
>Reporter: Nissim Shiman
>Assignee: Nissim Shiman
>Priority: Major
> Labels: backport-needed
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> To recreate, create a new controller service then open configuration gui for
> it and click Apply button (without having made any changes to default
> settings).
> Flow Configuration History will note that a Configure operation has occurred
> and the Comments have been changed from _No value set_ to an {_}Empty string
> se{_}t.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12387 Allow controller service configuration to be saved without flow configuration history change for comments [nifi]
exceptionfactory closed pull request #8275: NIFI-12387 Allow controller service configuration to be saved without flow configuration history change for comments URL: https://github.com/apache/nifi/pull/8275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12666) Correct NiFi Registry Data Source Configuration
[ https://issues.apache.org/jira/browse/NIFI-12666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-12666: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Correct NiFi Registry Data Source Configuration > --- > > Key: NIFI-12666 > URL: https://issues.apache.org/jira/browse/NIFI-12666 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Critical > Fix For: 2.0.0-M2 > > Time Spent: 20m > Remaining Estimate: 0h > > Recent updates to NiFi Registry for Spring Framework 6.1 introduced > conditional configuration for Data Source configuration. This change resulted > in Registry ignoring the configured NiFi Registry Database URL and instead > using a memory-backed H2 URL at runtime. The conditional configuration > setting should be removed and associated tests should be updated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12666 Correct Registry Data Source Configuration [nifi]
bbende merged PR #8299: URL: https://github.com/apache/nifi/pull/8299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12668) Test for Git-backed Registry fails with global Git config value
[
https://issues.apache.org/jira/browse/NIFI-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brian Ghigiarelli updated NIFI-12668:
-
Description:
(!) This may be OBE per NIFI-12667
The Git-backed Registry provider, GitFlowPersistenceProvider, does not
digitally sign commits to Git, nor does it specify the GPG configuration that
would be used if it were to sign commits. See
[GitFlowMetaData.java:478|https://github.com/apache/nifi/blob/89836f32d017d77972a4de09c4e864b0e11899a8/nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/flow/git/GitFlowMetaData.java#L478].
When the GPG configuration is not specified, the underlying jgit library uses
the default value of openpgp for the GPG format when it performs the commit.
This works fine except when the system's global Git configuration has
`gpg.format` set to `ssh`. Available options are:
* openpgp (default)
* x509
* ssh
The underlying jgit library does not recognize `ssh` as a valid GPG format.
jgit validates the GPG configuration when committing to git, whether it signs
the commit or not.
This issue manifests when a user attempts to run NiFi's tests with their global
Git configuration has `gpg.format` set to `ssh`. It would also occur if the
NiFi Registry ran on a server with Git installed and configured in the same
manner.
h3. Steps to reproduce
>From the root NiFi source code directory, run:
{code:java}
git config --global gpg.format ssh
cd ./nifi-registry/nifi-registry-core/nifi-registry-framework
mvn clean test{code}
h3. Observed Failure
{code:java}
[ERROR] Tests run: 6, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 3.387 s
<<< FAILURE! -- in
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider
[ERROR]
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadLargeFlow
-- Time elapsed: 3.273 s <<< ERROR!
java.lang.IllegalArgumentException: Invalid value: gpg.format=ssh
at
org.eclipse.jgit.lib.DefaultTypedConfigGetter.getEnum(DefaultTypedConfigGetter.java:103)
at org.eclipse.jgit.lib.Config.getEnum(Config.java:453)
at org.eclipse.jgit.lib.GpgConfig.(GpgConfig.java:86)
at
org.eclipse.jgit.api.CommitCommand.processOptions(CommitCommand.java:662)
at org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:189)
at
org.apache.nifi.registry.provider.flow.git.GitFlowMetaData.commit(GitFlowMetaData.java:481)
at
org.apache.nifi.registry.provider.flow.git.GitFlowPersistenceProvider.saveFlowContent(GitFlowPersistenceProvider.java:187)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.lambda$testLoadLargeFlow$14(TestGitFlowPersistenceProvider.java:311)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.assertProvider(TestGitFlowPersistenceProvider.java:112)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadLargeFlow(TestGitFlowPersistenceProvider.java:300)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
[ERROR]
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadCommitHistories
-- Time elapsed: 0.008 s <<< ERROR!
java.lang.IllegalArgumentException: Invalid value: gpg.format=ssh
at
org.eclipse.jgit.lib.DefaultTypedConfigGetter.getEnum(DefaultTypedConfigGetter.java:103)
at org.eclipse.jgit.lib.Config.getEnum(Config.java:453)
at org.eclipse.jgit.lib.GpgConfig.(GpgConfig.java:86)
at
org.eclipse.jgit.api.CommitCommand.processOptions(CommitCommand.java:662)
at org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:189)
at
org.apache.nifi.registry.provider.flow.git.GitFlowMetaData.commit(GitFlowMetaData.java:481)
at
org.apache.nifi.registry.provider.flow.git.GitFlowPersistenceProvider.saveFlowContent(GitFlowPersistenceProvider.java:187)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.lambda$testLoadCommitHistories$6(TestGitFlowPersistenceProvider.java:153)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.assertProvider(TestGitFlowPersistenceProvider.java:112)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadCommitHistories(TestGitFlowPersistenceProvider.java:140)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) {code}
...
{code:java}
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]
TestGitFlowPersistenceProvider.testLoadCommitHistories:140->assertProvider:112->lambda$t
[jira] [Created] (NIFI-12668) Test for Git-backed Registry fails with global Git config value
Brian Ghigiarelli created NIFI-12668:
Summary: Test for Git-backed Registry fails with global Git config
value
Key: NIFI-12668
URL: https://issues.apache.org/jira/browse/NIFI-12668
Project: Apache NiFi
Issue Type: Improvement
Components: NiFi Registry
Affects Versions: 2.0.0-M1
Reporter: Brian Ghigiarelli
The Git-backed Registry provider, GitFlowPersistenceProvider, does not
digitally sign commits to Git, nor does it specify the GPG configuration that
would be used if it were to sign commits. See
[GitFlowMetaData.java:478|https://github.com/apache/nifi/blob/89836f32d017d77972a4de09c4e864b0e11899a8/nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/flow/git/GitFlowMetaData.java#L478].
When the GPG configuration is not specified, the underlying jgit library uses
the default value of openpgp for the GPG format when it performs the commit.
This works fine except when the system's global Git configuration has
`gpg.format` set to `ssh`. Available options are:
* openpgp (default)
* x509
* ssh
The underlying jgit library does not recognize `ssh` as a valid GPG format.
jgit validates the GPG configuration when committing to git, whether it signs
the commit or not.
This issue manifests when a user attempts to run NiFi's tests with their global
Git configuration has `gpg.format` set to `ssh`. It would also occur if the
NiFi Registry ran on a server with Git installed and configured in the same
manner.
h3. Steps to reproduce
>From the root NiFi source code directory, run:
{code:java}
git config --global gpg.format ssh
cd ./nifi-registry/nifi-registry-core/nifi-registry-framework
mvn clean test{code}
h3. Observed Failure
{code:java}
[ERROR] Tests run: 6, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 3.387 s
<<< FAILURE! -- in
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider
[ERROR]
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadLargeFlow
-- Time elapsed: 3.273 s <<< ERROR!
java.lang.IllegalArgumentException: Invalid value: gpg.format=ssh
at
org.eclipse.jgit.lib.DefaultTypedConfigGetter.getEnum(DefaultTypedConfigGetter.java:103)
at org.eclipse.jgit.lib.Config.getEnum(Config.java:453)
at org.eclipse.jgit.lib.GpgConfig.(GpgConfig.java:86)
at
org.eclipse.jgit.api.CommitCommand.processOptions(CommitCommand.java:662)
at org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:189)
at
org.apache.nifi.registry.provider.flow.git.GitFlowMetaData.commit(GitFlowMetaData.java:481)
at
org.apache.nifi.registry.provider.flow.git.GitFlowPersistenceProvider.saveFlowContent(GitFlowPersistenceProvider.java:187)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.lambda$testLoadLargeFlow$14(TestGitFlowPersistenceProvider.java:311)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.assertProvider(TestGitFlowPersistenceProvider.java:112)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadLargeFlow(TestGitFlowPersistenceProvider.java:300)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
[ERROR]
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadCommitHistories
-- Time elapsed: 0.008 s <<< ERROR!
java.lang.IllegalArgumentException: Invalid value: gpg.format=ssh
at
org.eclipse.jgit.lib.DefaultTypedConfigGetter.getEnum(DefaultTypedConfigGetter.java:103)
at org.eclipse.jgit.lib.Config.getEnum(Config.java:453)
at org.eclipse.jgit.lib.GpgConfig.(GpgConfig.java:86)
at
org.eclipse.jgit.api.CommitCommand.processOptions(CommitCommand.java:662)
at org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:189)
at
org.apache.nifi.registry.provider.flow.git.GitFlowMetaData.commit(GitFlowMetaData.java:481)
at
org.apache.nifi.registry.provider.flow.git.GitFlowPersistenceProvider.saveFlowContent(GitFlowPersistenceProvider.java:187)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.lambda$testLoadCommitHistories$6(TestGitFlowPersistenceProvider.java:153)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.assertProvider(TestGitFlowPersistenceProvider.java:112)
at
org.apache.nifi.registry.provider.flow.git.TestGitFlowPersistenceProvider.testLoadCommitHistories(TestGitFlowPersistenceProvider.java:140)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach
[jira] [Created] (NIFI-12667) Upgrade JGit to 6.8.0
David Handermann created NIFI-12667: --- Summary: Upgrade JGit to 6.8.0 Key: NIFI-12667 URL: https://issues.apache.org/jira/browse/NIFI-12667 Project: Apache NiFi Issue Type: Improvement Components: NiFi Registry Reporter: David Handermann Assignee: David Handermann JGit should should be upgraded to [6.8.0|https://projects.eclipse.org/projects/technology.jgit/releases/6.8.0] incorporating several bug fixes and dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12655] theme NiFi following Material Design spec and leveraging Angular Material themes [nifi]
rfellows commented on code in PR #8294:
URL: https://github.com/apache/nifi/pull/8294#discussion_r1465526272
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/flow-status/_flow-status.component-theme.scss:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+@use 'sass:map';
+@use '@angular/material' as mat;
+
+@mixin theme($theme) {
+// Get the color config from the theme.
+$color-config: mat.get-color-config($theme);
+
+// Get the color palette from the color-config.
+$primary-palette: map.get($color-config, 'primary');
+$accent-palette: map.get($color-config, 'accent');
+$warn-palette: map.get($color-config, 'warn');
+
+// Get hues from palette
+$primary-palette-300: mat.get-color-from-palette($primary-palette, 300);
+$primary-palette-500: mat.get-color-from-palette($primary-palette, 500);
+$primary-palette-contrast-900:
mat.get-color-from-palette($primary-palette, '900-contrast');
+$accent-palette-400: mat.get-color-from-palette($accent-palette, 400);
+$warn-palette-A400: mat.get-color-from-palette($warn-palette, 'A400');
+
+.flow-status {
+border-bottom: 1px solid $primary-palette-300;
+box-sizing: content-box;
+font-size: 15px;
+
+.fa,
+.icon {
+font-size: 15px;
+font-style: normal;
+color: $primary-palette-500;
+}
+
+.status-value {
+white-space: nowrap;
+font-weight: 500;
+color: $warn-palette-A400;
+text-shadow: none;
+}
+
+.controller-bulletins {
+border-left: 1px solid $primary-palette-300;
+background-color: $primary-palette-500;
+cursor: default;
+}
+
+.controller-bulletins.has-bulletins {
+background-color: $accent-palette-400;
Review Comment:
this is showing as a green bulletin icon. i think we need:
```suggestion
background-color: $warn-light-400;
```
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/pom.xml:
##
@@ -32,6 +32,11 @@
v20.5.1
${basedir}/src/main/nifi
${project.build.directory}/frontend-working-directory
+
+purple
Review Comment:
This should default to `nifi`.
To override during the build, you can just pass in an override to set it
(`-Dfrontend.theme=<>`)...
```
mvn -T 2 install -Dfrontend.theme=purple -DskipTests
-P\!minify-and-compress,avoid-archive-formats,include-new-ui
```
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/common/add-tenant-to-policy-dialog/add-tenant-to-policy-dialog.component.html:
##
@@ -42,7 +42,7 @@ Add Users/Groups To Policy
-Cancel
+Cancel
Review Comment:
we shouldn't have 2 primary buttons on the same dialog. this one should
probably be:
```suggestion
Cancel
```
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/pom.xml:
##
@@ -87,6 +92,27 @@
+
+com.coderplus.maven.plugins
+copy-rename-maven-plugin
+1.0
Review Comment:
should probably variablize this version, just to be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12236 Improving fault tolerancy of the QuestDB backed metrics repository [nifi]
simonbence commented on PR #8152: URL: https://github.com/apache/nifi/pull/8152#issuecomment-1908952704 Notable changes: - CapturedAt database fields were renamed to captured - I found the reason of the remaining test files and fixed it - I adjusted the NAR structure, now it is inherited from framework again, fixing an instance of issue - With this I renamed the NAR. I would prefer the more generic `nifi-questdb-nar` as name but with the framework as parent we would have challenges with processors in the NAR. So probably if we want to add them, it will be a separate NAR thus the more specific name is beneficial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12666 Correct Registry Data Source Configuration [nifi]
exceptionfactory opened a new pull request, #8299: URL: https://github.com/apache/nifi/pull/8299 # Summary [NIFI-12666](https://issues.apache.org/jira/browse/NIFI-12666) Corrects the NiFi Registry Data Source Configuration, which inadvertently defaulted to H2 memory-backed storage following an upgrade to Spring Framework 6.1. This change is present on the main branch, but does not impact any released versions. The changes remove the `ConditionalOnProperty` annotation, which did not function as intended based on NiFi Registry property loading. The new annotation supports overriding the Data Source in test classes, but otherwise uses standard NiFi Registry properties. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12666) Correct NiFi Registry Data Source Configuration
[ https://issues.apache.org/jira/browse/NIFI-12666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12666: Status: Patch Available (was: Open) > Correct NiFi Registry Data Source Configuration > --- > > Key: NIFI-12666 > URL: https://issues.apache.org/jira/browse/NIFI-12666 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Critical > Fix For: 2.0.0-M2 > > > Recent updates to NiFi Registry for Spring Framework 6.1 introduced > conditional configuration for Data Source configuration. This change resulted > in Registry ignoring the configured NiFi Registry Database URL and instead > using a memory-backed H2 URL at runtime. The conditional configuration > setting should be removed and associated tests should be updated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12666) Correct NiFi Registry Data Source Configuration
David Handermann created NIFI-12666: --- Summary: Correct NiFi Registry Data Source Configuration Key: NIFI-12666 URL: https://issues.apache.org/jira/browse/NIFI-12666 Project: Apache NiFi Issue Type: Improvement Reporter: David Handermann Assignee: David Handermann Fix For: 2.0.0-M2 Recent updates to NiFi Registry for Spring Framework 6.1 introduced conditional configuration for Data Source configuration. This change resulted in Registry ignoring the configured NiFi Registry Database URL and instead using a memory-backed H2 URL at runtime. The conditional configuration setting should be removed and associated tests should be updated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12500: Add dynamic target for Get/Set/SendTrapSNMP [nifi]
tpalfy commented on code in PR #8160:
URL: https://github.com/apache/nifi/pull/8160#discussion_r1465482740
##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/operations/SNMPRequestIT.java:
##
@@ -237,9 +243,11 @@ void testSnmpGetInvalidOidWithFlowFileInput(int version,
SNMPConfigurationFactor
agent.start();
try {
final SNMPConfiguration snmpConfiguration =
snmpConfigurationFactory.createSnmpGetSetConfiguration(agent.getPort());
-snmpResourceHandler =
SNMPFactoryProvider.getFactory(version).createSNMPResourceHandler(snmpConfiguration);
-final GetSNMPHandler getSNMPHandler = new
GetSNMPHandler(snmpResourceHandler);
-final Optional optionalResponse =
getSNMPHandler.get(getFlowFileAttributesForSnmpGet(INVALID_OID,
READ_ONLY_OID_2));
+final SNMPContext factory =
SNMPFactoryProvider.getFactory(version);
+final Target target =
factory.createTargetInstance(snmpConfiguration);
+final Snmp snmpManager =
factory.createSnmpManagerInstance(snmpConfiguration);
+final GetSNMPHandler getSNMPHandler = new
GetSNMPHandler(snmpManager);
+final Optional optionalResponse =
getSNMPHandler.get(getFlowFileAttributesForSnmpGet(INVALID_OID,
READ_ONLY_OID_2), target);
if (optionalResponse.isPresent()) {
final SNMPSingleResponse response = optionalResponse.get();
if (version == SnmpConstants.version1) {
Review Comment:
Unfortunately this integration test fails because the order in which the
OIDs are added to the request and hence the order in which they are in the
response is not deterministic.
I suggest changing lines 253-261 to this:
```java
final List actualVariableBindings =
response.getVariableBindings();
final List expectedVariableBindings;
final List> equalsProperties =
Arrays.asList(
SNMPValue::getOid,
SNMPValue::getVariable
);
if (version == SnmpConstants.version1) {
expectedVariableBindings = Arrays.asList(
new SNMPValue(INVALID_OID, "Null"),
new SNMPValue(READ_ONLY_OID_2,
READ_ONLY_OID_VALUE_2)
);
assertEquals(NO_SUCH_NAME,
response.getErrorStatusText());
} else {
expectedVariableBindings = Arrays.asList(
new SNMPValue(INVALID_OID, NO_SUCH_OBJECT),
new SNMPValue(READ_ONLY_OID_2,
READ_ONLY_OID_VALUE_2)
);
assertEquals(SUCCESS, response.getErrorStatusText());
}
assertEquals(
new
HashSet<>(EqualsWrapper.wrapList(actualVariableBindings, equalsProperties)),
new
HashSet<>(EqualsWrapper.wrapList(expectedVariableBindings, equalsProperties))
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12622) Parameter Providers
[ https://issues.apache.org/jira/browse/NIFI-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12622: --- Status: Patch Available (was: In Progress) > Parameter Providers > --- > > Key: NIFI-12622 > URL: https://issues.apache.org/jira/browse/NIFI-12622 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-12622] - Parameter Providers - listing table [nifi]
rfellows opened a new pull request, #8298: URL: https://github.com/apache/nifi/pull/8298 [NIFI-12622](https://issues.apache.org/jira/browse/NIFI-12622) * Add a new Parameter Provider * Delete parameter provider * refactor to reduce duplicate code when creating new properties * support editing parameter providers * refactored inline service creation into PropertyTableHelperService * added parameter provider linking to access policies. _This does not add support for "fetch". That will be a large enough effort to warrant its own PR - see [NIFI-12665](https://issues.apache.org/jira/browse/NIFI-12665)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Component Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Better theme support (NIFI-12655) * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * General API response error handling * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Prompt user to save Parameter Context when Edit form is dirty * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12662) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIF
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12662) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Component Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Better theme support (NIFI-12655) * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * General API response error handling * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Prompt user to save Parameter Context when Edit form is dirty * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI12662) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIF
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI12662) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Component Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Better theme support (NIFI-12655) * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * General API response error handling * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Prompt user to save Parameter Context when Edit form is dirty * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Cha
[jira] [Created] (NIFI-12665) Fetch dialog for Parameter Providers
Rob Fellows created NIFI-12665: -- Summary: Fetch dialog for Parameter Providers Key: NIFI-12665 URL: https://issues.apache.org/jira/browse/NIFI-12665 Project: Apache NiFi Issue Type: Sub-task Reporter: Rob Fellows Assignee: Rob Fellows Implement the dialog that fetches parameters from a provider and maps them to a parameter context. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12500) Support dynamic host/port in Set/Get SNMP processors
[ https://issues.apache.org/jira/browse/NIFI-12500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810547#comment-17810547 ] ASF subversion and git services commented on NIFI-12500: Commit 5fe41864781301076420eb6d215b4a37cc3014d6 in nifi's branch refs/heads/pr/8160/merge from lehelb [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5fe4186478 ] NIFI-12500: Add dynamic target for Get/Set/SendTrapSNMP > Support dynamic host/port in Set/Get SNMP processors > > > Key: NIFI-12500 > URL: https://issues.apache.org/jira/browse/NIFI-12500 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Currently GetSNMP initializes targets when the processor is first started. > Supporting dynamic hosts makes it possible to read hosts from flowfiles and > send SNMP GET requests to different targets dynamically. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12500) Support dynamic host/port in Set/Get SNMP processors
[ https://issues.apache.org/jira/browse/NIFI-12500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810548#comment-17810548 ] ASF subversion and git services commented on NIFI-12500: Commit e031ff254741d097bc51a9858b5c451cde4f52be in nifi's branch refs/heads/pr/8160/merge from tpalfy [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e031ff2547 ] NIFI-12500: Fix failing test in SNMPRequestIT > Support dynamic host/port in Set/Get SNMP processors > > > Key: NIFI-12500 > URL: https://issues.apache.org/jira/browse/NIFI-12500 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Currently GetSNMP initializes targets when the processor is first started. > Supporting dynamic hosts makes it possible to read hosts from flowfiles and > send SNMP GET requests to different targets dynamically. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12664) Remove deprecated Distributed Map Cache Client in GetHBase
Pierre Villard created NIFI-12664: - Summary: Remove deprecated Distributed Map Cache Client in GetHBase Key: NIFI-12664 URL: https://issues.apache.org/jira/browse/NIFI-12664 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Pierre Villard Assignee: Pierre Villard Fix For: 2.0.0 In 1.x, some code has been added in GetHBase processor to still support the legacy Distributed Map Cache Client (for storing the state of the processor) while migrating the state into the state manager of NiFi. However this DMC is no longer used and the associated property/code should be removed for NiFi 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12500: Add dynamic target for Get/Set/SendTrapSNMP [nifi]
Lehel44 commented on code in PR #8160:
URL: https://github.com/apache/nifi/pull/8160#discussion_r1465352063
##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SendTrapSNMP.java:
##
@@ -147,17 +158,18 @@ public void onTrigger(final ProcessContext context, final
ProcessSession process
attributes.put("enterpriseOid", enterpriseOid);
attributes.put("genericTrapType", genericTrapType);
attributes.put("specificTrapType", specificTrapType);
-snmpHandler.sendTrap(attributes, v1TrapConfiguration);
+snmpHandler.sendTrap(attributes, v1TrapConfiguration, target);
} else {
final String trapOidValue =
context.getProperty(V2TrapProperties.TRAP_OID_VALUE).evaluateAttributeExpressions(flowFile).getValue();
V2TrapConfiguration v2TrapConfiguration = new
V2TrapConfiguration(trapOidValue);
attributes.put("trapOidValue", trapOidValue);
-snmpHandler.sendTrap(attributes, v2TrapConfiguration);
+snmpHandler.sendTrap(attributes, v2TrapConfiguration, target);
}
-
-processSession.putAllAttributes(flowFile, attributes);
+flowFile = processSession.putAllAttributes(flowFile, attributes);
processSession.transfer(flowFile, REL_SUCCESS);
-
+if (isFlowFileReceived) {
+processSession.getProvenanceReporter().receive(flowFile,
"/sendTrap");
+}
Review Comment:
The data is not from an external system, I agree, removing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-11294 Support Component State Checkpoints in ConsumeAzureEventHub [nifi]
turcsanyip opened a new pull request, #8297: URL: https://github.com/apache/nifi/pull/8297 Backport NIFI-11294 to the 1.x branch. # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12500: Add dynamic target for Get/Set/SendTrapSNMP [nifi]
tpalfy commented on code in PR #8160:
URL: https://github.com/apache/nifi/pull/8160#discussion_r1465309276
##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SendTrapSNMP.java:
##
@@ -147,17 +158,18 @@ public void onTrigger(final ProcessContext context, final
ProcessSession process
attributes.put("enterpriseOid", enterpriseOid);
attributes.put("genericTrapType", genericTrapType);
attributes.put("specificTrapType", specificTrapType);
-snmpHandler.sendTrap(attributes, v1TrapConfiguration);
+snmpHandler.sendTrap(attributes, v1TrapConfiguration, target);
} else {
final String trapOidValue =
context.getProperty(V2TrapProperties.TRAP_OID_VALUE).evaluateAttributeExpressions(flowFile).getValue();
V2TrapConfiguration v2TrapConfiguration = new
V2TrapConfiguration(trapOidValue);
attributes.put("trapOidValue", trapOidValue);
-snmpHandler.sendTrap(attributes, v2TrapConfiguration);
+snmpHandler.sendTrap(attributes, v2TrapConfiguration, target);
}
-
-processSession.putAllAttributes(flowFile, attributes);
+flowFile = processSession.putAllAttributes(flowFile, attributes);
processSession.transfer(flowFile, REL_SUCCESS);
-
+if (isFlowFileReceived) {
+processSession.getProvenanceReporter().receive(flowFile,
"/sendTrap");
+}
Review Comment:
I think we don't need to add a provenance event explicitly. No data (not
even attribute) is getting value from any outside sources. Instead, an
ATTRIBUTES_UPDATED will be generated automatically.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12500: Add dynamic target for Get/Set/SendTrapSNMP [nifi]
tpalfy commented on code in PR #8160:
URL: https://github.com/apache/nifi/pull/8160#discussion_r1465266010
##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SetSNMP.java:
##
@@ -101,28 +102,30 @@ public class SetSNMP extends AbstractSNMPProcessor {
@OnScheduled
public void init(final ProcessContext context) {
initSnmpManager(context);
-snmpHandler = new SetSNMPHandler(snmpResourceHandler);
+snmpHandler = new SetSNMPHandler(snmpManager);
}
@Override
public void onTrigger(final ProcessContext context, final ProcessSession
processSession) {
final FlowFile flowFile = processSession.get();
if (flowFile != null) {
try {
-final Optional optionalResponse =
snmpHandler.set(flowFile.getAttributes());
+final Target target =
factory.createTargetInstance(getTargetConfiguration(context, flowFile));
+final Optional optionalResponse =
snmpHandler.set(flowFile.getAttributes(), target);
if (optionalResponse.isPresent()) {
processSession.remove(flowFile);
final FlowFile outgoingFlowFile = processSession.create();
final SNMPSingleResponse response = optionalResponse.get();
-
processSession.getProvenanceReporter().receive(outgoingFlowFile, "/set");
-handleResponse(context, processSession, outgoingFlowFile,
response, REL_SUCCESS, REL_FAILURE, "/set");
+handleResponse(context, processSession, outgoingFlowFile,
response, REL_SUCCESS, REL_FAILURE, "/set", true);
} else {
getLogger().warn("No SNMP specific attributes found in
flowfile.");
processSession.transfer(flowFile, REL_FAILURE);
+processSession.getProvenanceReporter().receive(flowFile,
"/set");
}
} catch (IOException e) {
getLogger().error("Failed to send request to the agent. Check
if the agent supports the used version.");
processSession.transfer(processSession.penalize(flowFile),
REL_FAILURE);
+processSession.getProvenanceReporter().receive(flowFile,
"/set");
Review Comment:
```suggestion
```
##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SetSNMP.java:
##
@@ -101,28 +102,30 @@ public class SetSNMP extends AbstractSNMPProcessor {
@OnScheduled
public void init(final ProcessContext context) {
initSnmpManager(context);
-snmpHandler = new SetSNMPHandler(snmpResourceHandler);
+snmpHandler = new SetSNMPHandler(snmpManager);
}
@Override
public void onTrigger(final ProcessContext context, final ProcessSession
processSession) {
final FlowFile flowFile = processSession.get();
if (flowFile != null) {
try {
-final Optional optionalResponse =
snmpHandler.set(flowFile.getAttributes());
+final Target target =
factory.createTargetInstance(getTargetConfiguration(context, flowFile));
+final Optional optionalResponse =
snmpHandler.set(flowFile.getAttributes(), target);
if (optionalResponse.isPresent()) {
processSession.remove(flowFile);
final FlowFile outgoingFlowFile = processSession.create();
final SNMPSingleResponse response = optionalResponse.get();
-
processSession.getProvenanceReporter().receive(outgoingFlowFile, "/set");
-handleResponse(context, processSession, outgoingFlowFile,
response, REL_SUCCESS, REL_FAILURE, "/set");
+handleResponse(context, processSession, outgoingFlowFile,
response, REL_SUCCESS, REL_FAILURE, "/set", true);
} else {
getLogger().warn("No SNMP specific attributes found in
flowfile.");
processSession.transfer(flowFile, REL_FAILURE);
+processSession.getProvenanceReporter().receive(flowFile,
"/set");
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12500: Add dynamic target for Get/Set/SendTrapSNMP [nifi]
tpalfy commented on code in PR #8160:
URL: https://github.com/apache/nifi/pull/8160#discussion_r1465260947
##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/GetSNMP.java:
##
@@ -148,97 +148,89 @@ public class GetSNMP extends AbstractSNMPProcessor {
@OnScheduled
public void init(final ProcessContext context) {
initSnmpManager(context);
-snmpHandler = new GetSNMPHandler(snmpResourceHandler);
+snmpHandler = new GetSNMPHandler(snmpManager);
}
@Override
public void onTrigger(final ProcessContext context, final ProcessSession
processSession) {
final SNMPStrategy snmpStrategy =
SNMPStrategy.valueOf(context.getProperty(SNMP_STRATEGY).getValue());
final String oid = context.getProperty(OID).getValue();
-final FlowFile flowfile = processSession.get();
+final boolean isNewFlowFileCreated;
+FlowFile flowfile = processSession.get();
+if (flowfile == null) {
+isNewFlowFileCreated = true;
+flowfile = processSession.create();
+} else {
+isNewFlowFileCreated = false;
+}
+final Target target =
factory.createTargetInstance(getTargetConfiguration(context, flowfile));
if (SNMPStrategy.GET == snmpStrategy) {
-performSnmpGet(context, processSession, oid, flowfile);
+performSnmpGet(context, processSession, oid, target, flowfile,
isNewFlowFileCreated);
} else if (SNMPStrategy.WALK == snmpStrategy) {
-performSnmpWalk(context, processSession, oid, flowfile);
+performSnmpWalk(context, processSession, oid, target, flowfile,
isNewFlowFileCreated);
}
}
void performSnmpWalk(final ProcessContext context, final ProcessSession
processSession, final String oid,
- final FlowFile flowFile) {
+ final Target target, FlowFile flowFile, final boolean
isNewFlowFileCreated) {
+
+if (oid != null) {
+String prefixedOid = SNMPUtils.SNMP_PROP_PREFIX + oid;
+flowFile = processSession.putAttribute(flowFile, prefixedOid, "");
+}
+
try {
-if (flowFile != null) {
-performSnmpWalkWithFlowFile(processSession, flowFile);
+final Optional optionalResponse =
snmpHandler.walk(flowFile.getAttributes(), target);
+if (optionalResponse.isPresent()) {
+final SNMPTreeResponse response = optionalResponse.get();
+response.logErrors(getLogger());
+flowFile = processSession.putAllAttributes(flowFile,
response.getAttributes());
+
processSession.getProvenanceReporter().modifyAttributes(flowFile,
response.getTargetAddress() + "/walk");
+if (isNewFlowFileCreated) {
+processSession.getProvenanceReporter().fetch(flowFile,
"/walk");
+} else {
+processSession.getProvenanceReporter().receive(flowFile,
"/walk");
+}
Review Comment:
```suggestion
if (isNewFlowFileCreated) {
processSession.getProvenanceReporter().receive(flowFile,
"/walk");
} else {
processSession.getProvenanceReporter().fetch(flowFile,
"/walk");
}
```
##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/GetSNMP.java:
##
@@ -148,97 +148,89 @@ public class GetSNMP extends AbstractSNMPProcessor {
@OnScheduled
public void init(final ProcessContext context) {
initSnmpManager(context);
-snmpHandler = new GetSNMPHandler(snmpResourceHandler);
+snmpHandler = new GetSNMPHandler(snmpManager);
}
@Override
public void onTrigger(final ProcessContext context, final ProcessSession
processSession) {
final SNMPStrategy snmpStrategy =
SNMPStrategy.valueOf(context.getProperty(SNMP_STRATEGY).getValue());
final String oid = context.getProperty(OID).getValue();
-final FlowFile flowfile = processSession.get();
+final boolean isNewFlowFileCreated;
+FlowFile flowfile = processSession.get();
+if (flowfile == null) {
+isNewFlowFileCreated = true;
+flowfile = processSession.create();
+} else {
+isNewFlowFileCreated = false;
+}
+final Target target =
factory.createTargetInstance(getTargetConfiguration(context, flowfile));
if (SNMPStrategy.GET == snmpStrategy) {
-performSnmpGet(context, processSession, oid, flowfile);
+performSnmpGet(context, processSession, oid, target, flowfile,
isNewFlowFileCreated);
} else if (SNMPStrategy.WALK == snmpStrategy) {
-performSnmpWalk(context, processSession, oid, flowfile);
+performS
Re: [PR] NIFI-12387 Allow controller service configuration to be saved without flow configuration history change for comments [nifi]
NissimShiman commented on PR #8275: URL: https://github.com/apache/nifi/pull/8275#issuecomment-1908534880 Thank you very much @exceptionfactory for looking at this. My initial thoughts were to model this similar to how the code is handling comment initialization for [processors](https://github.com/apache/nifi/blob/rel/nifi-2.0.0-M1/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java#L208). The solution to replace empty string with null when the value is sent fron the client will also work. (I put what that would look like [here](https://github.com/NissimShiman/nifi/tree/NIFI-12387a), but the backend needs to undo some notNull checks for this to work, which seems somewhat out of place. What are your thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12663) General API error response handling
Matt Gilman created NIFI-12663: -- Summary: General API error response handling Key: NIFI-12663 URL: https://issues.apache.org/jira/browse/NIFI-12663 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman Update all pages to show API error response in a consistent way throughout the application. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2276 Support FlowFileTransform NiFi Python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1712:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1712#discussion_r1465177492
##
extensions/python/ExecutePythonProcessor.h:
##
@@ -118,7 +126,30 @@ class ExecutePythonProcessor : public core::Processor {
return description_;
}
+ void setPythonClassName(const std::string& python_class_name) {
+python_class_name_ = python_class_name;
+ }
+
+ void setPythonPaths(const std::vector& python_paths) {
+python_paths_ = python_paths;
+ }
+
+ protected:
+ core::Property* findProperty(const std::string& name) const override;
+
private:
+ enum class PropertyTypeCode : int64_t {
+INTEGER_TYPE = 0,
+LONG_TYPE = 1,
+BOOLEAN_TYPE = 2,
+DATA_SIZE_TYPE = 3,
+TIME_PERIOD_TYPE = 4,
+NON_BLANK_TYPE = 5,
+PORT_TYPE = 6
+ };
Review Comment:
This is actually a reference to our `StandardPropertyTypes` found in MiNiFi
defined in the `libminifi/include/core/PropertyType.h` header, but we can
remove the suffix and I suppose it's better to have it as part of the
`core::PropertyType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2276 Support FlowFileTransform NiFi Python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1712:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1712#discussion_r1465177492
##
extensions/python/ExecutePythonProcessor.h:
##
@@ -118,7 +126,30 @@ class ExecutePythonProcessor : public core::Processor {
return description_;
}
+ void setPythonClassName(const std::string& python_class_name) {
+python_class_name_ = python_class_name;
+ }
+
+ void setPythonPaths(const std::vector& python_paths) {
+python_paths_ = python_paths;
+ }
+
+ protected:
+ core::Property* findProperty(const std::string& name) const override;
+
private:
+ enum class PropertyTypeCode : int64_t {
+INTEGER_TYPE = 0,
+LONG_TYPE = 1,
+BOOLEAN_TYPE = 2,
+DATA_SIZE_TYPE = 3,
+TIME_PERIOD_TYPE = 4,
+NON_BLANK_TYPE = 5,
+PORT_TYPE = 6
+ };
Review Comment:
This is actually a reference to our `StandardPropertyTypes` found in MiNiFi
defined in the `libminifi/include/core/PropertyType.h`, but we can remove the
suffix and I suppose it's better to have it as part of the `core::PropertyType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Component Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Better theme support (NIFI-12655) * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * General API response error handling * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Prompt user to save Parameter Context when Edit form is dirty * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes **
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Better theme support (NIFI-12655) * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * General API response error handling * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Prompt user to save Parameter Context when Edit form is dirty * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers (NIFI-12622) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert cha
[jira] [Commented] (NIFI-12646) Conduct Apache NiFi 2.0.0-M2 Release
[ https://issues.apache.org/jira/browse/NIFI-12646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810459#comment-17810459 ] ASF subversion and git services commented on NIFI-12646: Commit 098522dc5a9fd237d951487a10c4573c6480fb65 in nifi's branch refs/heads/NIFI-12646-RC2 from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=098522dc5a ] NIFI-12646-RC2 prepare for next development iteration > Conduct Apache NiFi 2.0.0-M2 Release > > > Key: NIFI-12646 > URL: https://issues.apache.org/jira/browse/NIFI-12646 > Project: Apache NiFi > Issue Type: Task >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12646) Conduct Apache NiFi 2.0.0-M2 Release
[ https://issues.apache.org/jira/browse/NIFI-12646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810457#comment-17810457 ] ASF subversion and git services commented on NIFI-12646: Commit 2cda59fb34369cd9ec8f6e35ff85ff475fc4de5c in nifi's branch refs/heads/NIFI-12646-RC2 from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2cda59fb34 ] NIFI-12646 Set Python Processor version to 2.0.0-M2 Signed-off-by: David Handermann > Conduct Apache NiFi 2.0.0-M2 Release > > > Key: NIFI-12646 > URL: https://issues.apache.org/jira/browse/NIFI-12646 > Project: Apache NiFi > Issue Type: Task >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12646) Conduct Apache NiFi 2.0.0-M2 Release
[ https://issues.apache.org/jira/browse/NIFI-12646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810458#comment-17810458 ] ASF subversion and git services commented on NIFI-12646: Commit f50ab61772de816b08edffc97393a856b0a87ed2 in nifi's branch refs/heads/NIFI-12646-RC2 from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f50ab61772 ] NIFI-12646-RC2 prepare release nifi-2.0.0-M2-RC2 > Conduct Apache NiFi 2.0.0-M2 Release > > > Key: NIFI-12646 > URL: https://issues.apache.org/jira/browse/NIFI-12646 > Project: Apache NiFi > Issue Type: Task >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2276 Support FlowFileTransform NiFi Python processors [nifi-minifi-cpp]
szaszm commented on code in PR #1712:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1712#discussion_r1463510235
##
extensions/python/ExecutePythonProcessor.h:
##
@@ -118,7 +126,30 @@ class ExecutePythonProcessor : public core::Processor {
return description_;
}
+ void setPythonClassName(const std::string& python_class_name) {
+python_class_name_ = python_class_name;
+ }
+
+ void setPythonPaths(const std::vector& python_paths) {
+python_paths_ = python_paths;
+ }
+
+ protected:
+ core::Property* findProperty(const std::string& name) const override;
+
private:
+ enum class PropertyTypeCode : int64_t {
+INTEGER_TYPE = 0,
+LONG_TYPE = 1,
+BOOLEAN_TYPE = 2,
+DATA_SIZE_TYPE = 3,
+TIME_PERIOD_TYPE = 4,
+NON_BLANK_TYPE = 5,
+PORT_TYPE = 6
+ };
Review Comment:
Is the naming directly coming from NiFi? If not, I'd drop the `_TYPE` suffix
of the alternatives. I also think we should consider moving this type and the
translate function near `core::PropertyType`, since it's related, general, and
not dependent on anything.
A reference to NiFi code or docs where these codes are defined would also be
nice, as a code comment.
##
libminifi/include/core/ConfigurableComponent.h:
##
@@ -212,6 +212,8 @@ class ConfigurableComponent {
// Dynamic properties
std::map dynamic_properties_;
+ virtual Property* findProperty(const std::string& name) const;
+
Review Comment:
I was under the impression that `getProperty` was already `virtual`, but
apparently that's not the case, so this new customization point makes sense
knowing this. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12270: Add new provenance event: UPLOAD [nifi]
Lehel44 commented on PR #8094: URL: https://github.com/apache/nifi/pull/8094#issuecomment-1908258979 Thanks for the review @markap14 @exceptionfactory. Is this one good to go in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11470) SQL Record query TimeZone issue
[ https://issues.apache.org/jira/browse/NIFI-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810422#comment-17810422 ] Sven Van Kerrebroeck commented on NIFI-11470: - We also ran into some serious problems with our data processing because of this bug. We are in "Europe\Brussels" timezone, and each time the data passes through one of these processors (like QueryRecord), the timestamps are moved 1 or 2 hours backwards (depending on summer or winter time). Depending on how these timestamps are used afterwards, this can have serious consequences (for us it nearly resulted in data loss further down the line). The danger is also that people don't know about the bug untill problems are detected in the final output of a flow. And then it's quite a challenge to find where things are going wrong... It would be good to have this resolved (even in the 1.x versions, because not everyone is able to switch to 2.x yet...). For the moment it's really dangerous to use these processors without checking if there are any timestamps in the dataset. > SQL Record query TimeZone issue > --- > > Key: NIFI-11470 > URL: https://issues.apache.org/jira/browse/NIFI-11470 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.19.1, 1.21.0, 1.23.2 >Reporter: Julien G. >Priority: Major > Attachments: Example_Issue_Timestamp_SQL_Query_on_record.json, > TIMEZONE_ISSUE.json > > > In the case of a cluster with a timezone different from UTC (+0 hours) like > CEST (+2 hours), in processors like QueryRecord or JoinEnrichment that use an > SQL query to manipulate the record, the TIMESTAMP type field will be > converted again and again to UTC. > So, for example, if you have JSON with a field with the value 2023/04/19 > 18:04:00 +0200 and you say it's a TIMESTAMP field in the Avro schema and > convert it to Avro, the field will be set to UTC (2023/04/19 16:04:00 +). > But if you then use a QueryRecord you will have 2023/04/19 14:04:00 + and > if you put another QueryRecord you will have 2023/04/19 14:04:00 +, ... > The field is reinterpreted as CEST time zone instead of UTC each time. > Same issue with SQL join strategy in the JoinEnrichment. > You can find a dataflow illustrating the point attached to the Jira. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12611) View State
[ https://issues.apache.org/jira/browse/NIFI-12611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12611: --- Status: Patch Available (was: In Progress) > View State > -- > > Key: NIFI-12611 > URL: https://issues.apache.org/jira/browse/NIFI-12611 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Introduce the ability to view and clear state for extension types that > support state. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12662) Conduct Apache NiFi 1.25.0 Release
Pierre Villard created NIFI-12662: - Summary: Conduct Apache NiFi 1.25.0 Release Key: NIFI-12662 URL: https://issues.apache.org/jira/browse/NIFI-12662 Project: Apache NiFi Issue Type: Task Reporter: Pierre Villard Assignee: Pierre Villard Fix For: 1.25.0 Conduct Apache NiFi 1.25.0 Release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-7836) Add Encrypt and Decrypt CMS Processors and Services
[ https://issues.apache.org/jira/browse/NIFI-7836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-7836. Resolution: Won't Fix Closing this issue based on the availability of EncryptContentAge and DecryptContentAge Processors as a more robust alternative for new encryption flows. > Add Encrypt and Decrypt CMS Processors and Services > --- > > Key: NIFI-7836 > URL: https://issues.apache.org/jira/browse/NIFI-7836 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.12.0 >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Labels: cms, encryption, security, smime, x509 > Time Spent: 0.5h > Remaining Estimate: 0h > > The purpose of this issue is to add new Processors and Controller Services > supporting encryption and decryption using Cryptographic Message Syntax as > defined in RFC 5652. > CMS provides the underlying specification for S/MIME messages and also > supports encryption and decryption using X.509 certificates. Standard Java > Key Stores can be used to support encrypting messages for one or more > recipients. Decrypting messages can also be supported based on matching > certificate serial number and issuer attributes. > The current EncryptContent Processor supports encryption using passwords and > PGP keys, but does not support encryption using X.509 certificates. New > Processors for encryption and decryption would support encryption using X.509 > certificates using CMS classes in the Bouncy Castle library. New Controller > Services would provide access to certificate and private key information from > standard Java Key Stores. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12639) Backport JSON Schema Registry for ValidateJson
[ https://issues.apache.org/jira/browse/NIFI-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12639: Fix Version/s: 1.25.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Backport JSON Schema Registry for ValidateJson > -- > > Key: NIFI-12639 > URL: https://issues.apache.org/jira/browse/NIFI-12639 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > Fix For: 1.25.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The changes made for NIFI-11627 were only committed on the 2.x branch and not > backported to the support/nifi-1.x branch. The purpose of this ticket is to > backport the code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12639) Backport JSON Schema Registry for ValidateJson
[ https://issues.apache.org/jira/browse/NIFI-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810386#comment-17810386 ] ASF subversion and git services commented on NIFI-12639: Commit 89ba16a09a6efdef70d60551462d3f4f95195328 in nifi's branch refs/heads/support/nifi-1.x from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=89ba16a09a ] NIFI-12639 Backported JSON Schema Registry for ValidateJson This closes #8274 Signed-off-by: David Handermann > Backport JSON Schema Registry for ValidateJson > -- > > Key: NIFI-12639 > URL: https://issues.apache.org/jira/browse/NIFI-12639 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > The changes made for NIFI-11627 were only committed on the 2.x branch and not > backported to the support/nifi-1.x branch. The purpose of this ticket is to > backport the code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12639 Ported all the changes from NIFI-11627 for the support/nifi-1.x branch [nifi]
exceptionfactory commented on PR #8274: URL: https://github.com/apache/nifi/pull/8274#issuecomment-1908147523 Merged to support branch in https://github.com/apache/nifi/commit/89ba16a09a6efdef70d60551462d3f4f95195328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12639 Ported all the changes from NIFI-11627 for the support/nifi-1.x branch [nifi]
exceptionfactory closed pull request #8274: NIFI-12639 Ported all the changes from NIFI-11627 for the support/nifi-1.x branch URL: https://github.com/apache/nifi/pull/8274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12639) Backport JSON Schema Registry for ValidateJson
[ https://issues.apache.org/jira/browse/NIFI-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12639: Summary: Backport JSON Schema Registry for ValidateJson (was: Backport the changes made in NIFI-11627 to the support/nifi-1.x branch) > Backport JSON Schema Registry for ValidateJson > -- > > Key: NIFI-12639 > URL: https://issues.apache.org/jira/browse/NIFI-12639 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > The changes made for NIFI-11627 were only committed on the 2.x branch and not > backported to the support/nifi-1.x branch. The purpose of this ticket is to > backport the code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11627) Add JSON Schema Registry Service for ValidateJson Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11627:
Labels: (was: backport-needed)
> Add JSON Schema Registry Service for ValidateJson Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
> Fix For: 2.0.0-M2
>
> Time Spent: 9h
> Remaining Estimate: 0h
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2287) Site-to-site with large files: "Site2Site transaction xxx peer unknown respond code 14"
[
https://issues.apache.org/jira/browse/MINIFICPP-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits resolved MINIFICPP-2287.
---
Resolution: Duplicate
This issue will be fixed by
https://issues.apache.org/jira/browse/MINIFICPP-2291, which contains more
information about the underlying problem.
> Site-to-site with large files: "Site2Site transaction xxx peer unknown
> respond code 14"
> ---
>
> Key: MINIFICPP-2287
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2287
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Marton Szasz
>Assignee: Ferenc Gerlits
>Priority: Major
>
> It looks like nifi may have extended the protocol, and minifi c++ didn't
> follow the development.
>
> From Thomas on the nifi slack:
> [https://apachenifi.slack.com/archives/CDF1VC1UZ/p1705327811015419]
>
> {quote}Running minifi c++ v0.15, I am getting errors when transferring large
> files (10gb) via site to site to a Nifi (v1.20) cluster. Per the logs,the
> transfer is on going for a while (warning logs, inputPortName has been
> running for x ms in \{connection ID}
> then it looks like the transfer completes (info log, Site to Site transaction
> ... set flow 1 flow records with total size xxx-yyy-zzz ) ALSO, the large
> file appears on the remote Nifi cluster
> then it looks like the transfer failed (warning log, Site2Site transaction
> xxx peer unknown respond code 14)
> then another error, (warning log , ProcessSession rollback for inputPortName
> executed )
> the finally, (warning protocol transmission failed, yielding ( xxx-yyy-zzz )
> This results in endless copies of the large files as presumably minifi
> retries the file despite successfully transferring the file.
> The logs show that other smaller files continue to be transferred while the
> large files yield. (edited)
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12643) Add local file upload option in PutGCS processor
[ https://issues.apache.org/jira/browse/NIFI-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balázs Gerner updated NIFI-12643: - Status: Patch Available (was: Open) > Add local file upload option in PutGCS processor > > > Key: NIFI-12643 > URL: https://issues.apache.org/jira/browse/NIFI-12643 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Balázs Gerner >Assignee: Balázs Gerner >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Similarly to PutAzure*Storage processors, inside the *PutGCSObject* > processor, add option to upload file from the local filesystem directly to > GCS storage by-passing the content repo. > The two available file resource transfer sources are: > * FlowFile's Content (default, current behaviour) > * Local File -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12642) Add local file upload option in PutS3 processor
[ https://issues.apache.org/jira/browse/NIFI-12642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balázs Gerner updated NIFI-12642: - Status: Patch Available (was: In Progress) > Add local file upload option in PutS3 processor > --- > > Key: NIFI-12642 > URL: https://issues.apache.org/jira/browse/NIFI-12642 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Balázs Gerner >Assignee: Balázs Gerner >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Similarly to PutAzure*Storage processors, inside the *PutS3Object* processor, > add option to upload file from the local filesystem directly to AWS S3 > by-passing the content repo. > The two available file resource transfer sources are: > * FlowFile's Content (default, current behaviour) > * Local File -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12642) Add local file upload option in PutS3 processor
[ https://issues.apache.org/jira/browse/NIFI-12642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balázs Gerner updated NIFI-12642: - Description: Similarly to PutAzure*Storage processors, inside the *PutS3Object* processor, add option to upload file from the local filesystem directly to AWS S3 by-passing the content repo. The two available file resource transfer sources are: * FlowFile's Content (default, current behaviour) * Local File was: Similarly to PutAzure*Storage processors, inside the *PutS3Object* processor, add option to upload file from the local filesystem directly to AWS S3 by-passing the content repo. The two available file resource transfer sources are: * FlowFile's Content (default, current behaviour) * Local File This ticket relates to: https://issues.apache.org/jira/browse/NIFI-11758 > Add local file upload option in PutS3 processor > --- > > Key: NIFI-12642 > URL: https://issues.apache.org/jira/browse/NIFI-12642 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Balázs Gerner >Assignee: Balázs Gerner >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Similarly to PutAzure*Storage processors, inside the *PutS3Object* processor, > add option to upload file from the local filesystem directly to AWS S3 > by-passing the content repo. > The two available file resource transfer sources are: > * FlowFile's Content (default, current behaviour) > * Local File -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12643) Add local file upload option in PutGCS processor
[ https://issues.apache.org/jira/browse/NIFI-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balázs Gerner updated NIFI-12643: - Description: Similarly to PutAzure*Storage processors, inside the *PutGCSObject* processor, add option to upload file from the local filesystem directly to GCS storage by-passing the content repo. The two available file resource transfer sources are: * FlowFile's Content (default, current behaviour) * Local File was: Similarly to PutAzure*Storage processors, inside the *PutGCSObject* processor, add option to upload file from the local filesystem directly to GCS storage by-passing the content repo. The two available file resource transfer sources are: * FlowFile's Content (default, current behaviour) * Local File This ticket relates to: https://issues.apache.org/jira/browse/NIFI-11758 > Add local file upload option in PutGCS processor > > > Key: NIFI-12643 > URL: https://issues.apache.org/jira/browse/NIFI-12643 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Balázs Gerner >Assignee: Balázs Gerner >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Similarly to PutAzure*Storage processors, inside the *PutGCSObject* > processor, add option to upload file from the local filesystem directly to > GCS storage by-passing the content repo. > The two available file resource transfer sources are: > * FlowFile's Content (default, current behaviour) > * Local File -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12642 Added support for FileResourceService in PutS3Object [nifi]
balazsgerner opened a new pull request, #8295: URL: https://github.com/apache/nifi/pull/8295 # Summary Added support to upload content directly from local file's inputstream (by-passing the content repository) inside the PutS3Object processor. The default behaviour is upload from flowfile content to be backward compatible. This can be overridden if the RESOURCE_TRANSFER_SOURCE property value is set to FILE_RESOURCE_SERVICE, and a FileResourceService controller service is registered. [NIFI-12642](https://issues.apache.org/jira/browse/NIFI-12642) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
