Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
scottyaslan commented on code in PR #8480: URL: https://github.com/apache/nifi/pull/8480#discussion_r1518476500 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/nifi.scss: ## @@ -19,11 +19,15 @@ // For more information: https://m2.material.io/design/color/the-color-system.html @use '@angular/material' as mat; +// Define some variables that are re-used throughout the theme. +$on-surface-dark: rgba(black, 0.87); +$on-surface-light: #ff; + // The $material-primary-light-palette define the PRIMARY AND ACCENT palettes for all Angular Material components used throughout Apache NiFi $material-primary-light-palette: ( // 50 -> 900 are the PRIMARY colors (mat.define-palette($material-primary-light-palette, 300);) defined by https://m2.material.io/design/color/the-color-system.html#tools-for-picking-colors for primary color #728e9b -50: rgba(249, 250, 251, 0.97), // .context-menu -100: rgba(233, 239, 243, 1), // "lighter" hue for this palette. Also .global-menu:hover, .navigation-control-header:hover, .operation-control-header:hover, .new-canvas-item.icon.hovering, table tr:hover, .CodeMirror.blank, .remote-banner, .process-group-details-banner, .process-group-details-banner, remote-process-group-details-banner, .remote-process-group-last-refresh-rect, Review Comment: Some of these color values are defined as `rgba(...)`. I thought this was because not all css properties support hex color values. Maybe you know better than I do but can we define all of these colors in hex or would it be better to update all of the colors to use rgba()??? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
scottyaslan commented on code in PR #8480: URL: https://github.com/apache/nifi/pull/8480#discussion_r1518466606 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/nifi.scss: ## @@ -49,355 +53,100 @@ $material-primary-light-palette: ( // NOTE: When creating the Material palette definition mat.define-palette($material-primary-light-palette, 300); // Since 300, was set as the default the contrast-300 will be used as the default text color. contrast: ( -50: rgba(black, 0.87), -100: rgba(black, 0.87), -200: rgba(black, 0.87), -300: #ff, -400: #ff, -500: #ff, -600: #ff, -700: #ff, -800: #ff, -900: #ff, -A100: rgba(black, 0.87), -A200: rgba(black, 0.87), -A400: #ff, -A700: #ff, -) -); - -// The $material-primary-dark-palette define the PRIMARY AND ACCENT palettes for all Angular Material components used throughout Apache NiFi -$material-primary-dark-palette: ( -// 50 -> 900 are the PRIMARY colors (mat.define-palette($material-primary-dark-palette, 300);) defined by https://m2.material.io/design/color/the-color-system.html#tools-for-picking-colors for primary color #728e9b -50: rgb(30, 45, 54), // .context-menu -100: rgba(32, 47, 54, 1), // "lighter" hue for this palette. Also .global-menu:hover, .navigation-control-header:hover, .operation-control-header:hover, .new-canvas-item.icon.hovering, table tr:hover, .CodeMirror.blank, .remote-banner, .process-group-details-banner, .process-group-details-banner, remote-process-group-details-banner, .remote-process-group-last-refresh-rect, -200: #30444d, // .processor-stats-border, .process-group-stats-border, .context-menu-item:hover, .process-group-banner, .remote-process-group-banner, .a, button.nifi-button, button.nifi-button:disabled -300: #3e5762, // .breadcrumb-container, .navigation-control, .operation-control, .flow-status, .controller-bulletins, .component-button-grip, .search-container, .nifi-navigation, .CodeMirror.blank -400: #4d6b78, // Default hue for this palette (color="primary"). -500: #587a89, // .disabled, .not-transmitting, .splash, .access-policies-header, .operation-context-type, .bulletin-board-header, .counter-header, .stats-info, .active-thread-count-icon, .processor-type, .port-transmission-icon, .operation-context-type, .flow-status.fa, .flow-status.icon, .controller-bulletins, .prioritizers-list, .controller-services-header, .login-title, .parameter-context-header, .parameter-context-inheritance-list, .provenance-header, .flowfile-header, .queue-listing-header, .settings-header, .summary-header, .user-header, table th, button.global-menu-item.fa, button.global-menu-item.icon, .event-header, .section-header, -600: #718d9a, // .breadcrumb-container, .birdseye-brush -700: #8aa2ad, // "darker" hue for this palette. Also #status-history-chart-container text, #status-history-chart-control-container text -800: #abbcc5, -900: #abbcc5, - -// A100 -> A700 are the ACCENT color (mat.define-palette($material-primary-dark-palette, A400, A100, A700);). These color are the ANALOGOUS (or possibly the TRIADIC??) colors as defined by https://m2.material.io/design/color/the-color-system.html#tools-for-picking-colors for primary color #728e9b -// These colors are also used by some custom canvas components that display the ANALOGOUS color for things like buttons, links, borders, info, etc. -A100: #aabec7, // .zero -A200: #44a3cf, // .enabled, .transmitting, .load-balance-icon-active -A400: #009b9d, // a, a:hover, button.nifi-button, button.nifi-button:hover, .add-tenant-to-policy-form.fa, .component.selected rect.border, .add-connect, .remote-process-group-uri, .remote-process-group-transmission-secure, .navigation-control.fa, .operation-control.fa, .new-canvas-item.icon, .upload-flow-definition, .lineage-controls.fa, .event circle.context, .nifi-navigation.icon, .listing-table.fa, .listing-table.icon, .context-menu -A700: #2cd5d5,//rgba(139, 208, 229, 1),//#aabec7 // .hint-pattern - -// These are the $material-primary-dark-palette PRIMARY AND ACCENT contrast colors. These color do not really get defined by https://m2.material.io/design/color/the-color-system.html#tools-for-picking-colors. -// Instead if we look to the Angular Material provided palettes we see that these fields are typically rgba(black, 0.87) or white. These values are particularly important -// for light mode and dark mode as these values set the colors for the text when displayed against the primary background on a button, badge, chip, etc. -// -// NOTE: Care should be taken here to ensure the values meet accessibility standards. -// -// NOTE: When creating the Material palette definition
[PR] NIFI-12871 Upgrade Commons Compress from 1.25.0 to 1.26.1 [nifi]
exceptionfactory opened a new pull request, #8488: URL: https://github.com/apache/nifi/pull/8488 # Summary [NIFI-12871](https://issues.apache.org/jira/browse/NIFI-12871) Upgrades Apache Commons Compress dependencies from 1.25.0 to [1.26.1](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310904=12354340). This upgrade resolves CVE-2024-26308 related to memory exhaustion for Pack200 files, which are not used directly in NiFi components. Commons Compress 1.26.1 also resolves a transitive dependency issue in version 1.26.0 related to the `TarArchiveOutputStream`. This version is compatible with Java 8 and should be backported to the support branch. Additional changes include updating the Excel Reader test to avoid message-based matching on failures, which surfaced when upgraded Commons Compress versions. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12871) Upgrade Commons Compress to 1.26.1
[ https://issues.apache.org/jira/browse/NIFI-12871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12871: Status: Patch Available (was: Open) > Upgrade Commons Compress to 1.26.1 > -- > > Key: NIFI-12871 > URL: https://issues.apache.org/jira/browse/NIFI-12871 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: Michael W Moser >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > Apache Commons Compress has released version > [1.26.0|https://commons.apache.org/proper/commons-compress/changes-report.html#a1.26.0] > which is a minor feature and maintenance release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12879) Upgrade Clojure to 1.11.2
[ https://issues.apache.org/jira/browse/NIFI-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824896#comment-17824896 ] ASF subversion and git services commented on NIFI-12879: Commit 691870806dfe273a584eef5f86f5aa0182e1700d in nifi's branch refs/heads/support/nifi-1.x from dependabot[bot] [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=691870806d ] NIFI-12879 Upgraded Clojure from 1.11.1 to 1.11.2 This closes #8487 Signed-off-by: David Handermann (cherry picked from commit 63cc0520dca09acee2dc8f1abb1e2c48c8f4e3e4) > Upgrade Clojure to 1.11.2 > - > > Key: NIFI-12879 > URL: https://issues.apache.org/jira/browse/NIFI-12879 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The Clojure library for the Scripting extensions bundle should be upgraded to > [1.11.2|https://clojure.org/releases/downloads#_stable_release_1_11_2_mar_8_2024] > to mitigate CVE-2024-22871, which relates to using Java Object serialization > to read crafted inputs. > Clojure is an optional scripting library and the Scripting extensions do not > perform Java Object serialization directly. For this reason, deployments of > NiFi that do not use custom Scripting components based on Clojure are not > directly exposed to this vulnerability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12879) Upgrade Clojure to 1.11.2
[ https://issues.apache.org/jira/browse/NIFI-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12879. - Resolution: Fixed > Upgrade Clojure to 1.11.2 > - > > Key: NIFI-12879 > URL: https://issues.apache.org/jira/browse/NIFI-12879 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The Clojure library for the Scripting extensions bundle should be upgraded to > [1.11.2|https://clojure.org/releases/downloads#_stable_release_1_11_2_mar_8_2024] > to mitigate CVE-2024-22871, which relates to using Java Object serialization > to read crafted inputs. > Clojure is an optional scripting library and the Scripting extensions do not > perform Java Object serialization directly. For this reason, deployments of > NiFi that do not use custom Scripting components based on Clojure are not > directly exposed to this vulnerability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12879) Upgrade Clojure to 1.11.2
[ https://issues.apache.org/jira/browse/NIFI-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824895#comment-17824895 ] ASF subversion and git services commented on NIFI-12879: Commit 63cc0520dca09acee2dc8f1abb1e2c48c8f4e3e4 in nifi's branch refs/heads/main from dependabot[bot] [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=63cc0520dc ] NIFI-12879 Upgraded Clojure from 1.11.1 to 1.11.2 This closes #8487 Signed-off-by: David Handermann > Upgrade Clojure to 1.11.2 > - > > Key: NIFI-12879 > URL: https://issues.apache.org/jira/browse/NIFI-12879 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The Clojure library for the Scripting extensions bundle should be upgraded to > [1.11.2|https://clojure.org/releases/downloads#_stable_release_1_11_2_mar_8_2024] > to mitigate CVE-2024-22871, which relates to using Java Object serialization > to read crafted inputs. > Clojure is an optional scripting library and the Scripting extensions do not > perform Java Object serialization directly. For this reason, deployments of > NiFi that do not use custom Scripting components based on Clojure are not > directly exposed to this vulnerability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12879 Bump org.clojure:clojure from 1.11.1 to 1.11.2 in /nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors [nifi]
dependabot[bot] commented on PR #8487: URL: https://github.com/apache/nifi/pull/8487#issuecomment-1986698940 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12879 Bump org.clojure:clojure from 1.11.1 to 1.11.2 in /nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors [nifi]
exceptionfactory closed pull request #8487: NIFI-12879 Bump org.clojure:clojure from 1.11.1 to 1.11.2 in /nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors URL: https://github.com/apache/nifi/pull/8487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
scottyaslan commented on code in PR #8480:
URL: https://github.com/apache/nifi/pull/8480#discussion_r1518453284
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/nifi.scss:
##
@@ -19,11 +19,15 @@
// For more information:
https://m2.material.io/design/color/the-color-system.html
@use '@angular/material' as mat;
+// Define some variables that are re-used throughout the theme.
+$on-surface-dark: rgba(black, 0.87);
+$on-surface-light: #ff;
+
// The $material-primary-light-palette define the PRIMARY AND ACCENT palettes
for all Angular Material components used throughout Apache NiFi
$material-primary-light-palette: (
Review Comment:
These same changes need to be made in the purple.scss theme file. As it
stands right now the purple theme light and dark mode look like:
https://github.com/apache/nifi/assets/6797571/1d12cfed-3651-4baf-b1ab-e427153c1cb1;>
https://github.com/apache/nifi/assets/6797571/e6d5b887-45b2-4956-9786-ff4c1344e971;>
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/styles.scss:
##
@@ -187,149 +192,146 @@ $appFontPath: '~roboto-fontface/fonts';
$canvas-accent-palette: map.get($canvas-color-config, 'accent');
// Get hues from palette
-$primary-palette-50: mat.get-color-from-palette($primary-palette, 50);
-$primary-palette-200: mat.get-color-from-palette($primary-palette, 200);
-$primary-palette-500: mat.get-color-from-palette($primary-palette, 500);
-$accent-palette-A100: mat.get-color-from-palette($accent-palette, 'A100');
-$accent-palette-A200: mat.get-color-from-palette($accent-palette, 'A200');
-$accent-palette-A400: mat.get-color-from-palette($accent-palette, 'A400');
-$canvas-primary-palette-50:
mat.get-color-from-palette($canvas-primary-palette, 50);
-$canvas-primary-palette-200:
mat.get-color-from-palette($canvas-primary-palette, 200);
+
+// Start with the canvas theme.
+$canvas-primary-palette-A200:
mat.get-color-from-palette($canvas-primary-palette, A200);
$canvas-primary-palette-400:
mat.get-color-from-palette($canvas-primary-palette, 400);
-$canvas-primary-palette-900:
mat.get-color-from-palette($canvas-primary-palette, 900);
-$canvas-accent-palette-200:
mat.get-color-from-palette($canvas-accent-palette, 200);
-$canvas-accent-palette-400:
mat.get-color-from-palette($canvas-accent-palette, 400);
-$canvas-accent-palette-A200:
mat.get-color-from-palette($canvas-accent-palette, 'A200');
-$warn-palette-200: mat.get-color-from-palette($warn-palette, 200);
-$warn-palette-300: mat.get-color-from-palette($warn-palette, 300);
-$warn-palette-A100: mat.get-color-from-palette($warn-palette, 'A100');
-$warn-palette-A400: mat.get-color-from-palette($warn-palette, 'A400');
+$canvas-primary-palette-500:
mat.get-color-from-palette($canvas-primary-palette, 500);
+$canvas-accent-palette-lighter:
mat.get-color-from-palette($canvas-accent-palette, lighter);
+$canvas-accent-palette-default:
mat.get-color-from-palette($canvas-accent-palette, default);
+
+$primary-palette-lighter: mat.get-color-from-palette($primary-palette,
lighter);
+$primary-palette-default: mat.get-color-from-palette($primary-palette,
'default');
+$primary-palette-A400: mat.get-color-from-palette($primary-palette,
'A400');
+
+$accent-palette-default: mat.get-color-from-palette($accent-palette,
'default');
+$accent-palette-lighter: mat.get-color-from-palette($accent-palette,
'lighter');
+
+$warn-palette-lighter: mat.get-color-from-palette($warn-palette, lighter);
+$warn-palette-default: mat.get-color-from-palette($warn-palette,
'default');
+
+// Alternative hue for warn colors.
+$warn-palette-A200: mat.get-color-from-palette($warn-palette, 'A200');
+
+$surface: utils.get-surface($canvas-color-config);
+$surface-darker: utils.get-surface($canvas-color-config, darker);
+$surface-highlight: utils.get-on-surface($canvas-color-config, highlight);
+$on-surface: utils.get-on-surface($canvas-color-config);
+$on-surface-lighter: utils.get-on-surface($canvas-color-config, lighter);
+
+* { // Tailwind sets a default that doesn't shift with light and dark
themes
+border-color: $on-surface-lighter;
+}
a {
-color: $accent-palette-A400;
-text-decoration-color: $primary-palette-200;
+color: utils.get-color-on-surface($color-config, $surface);
+text-decoration-color: $primary-palette-lighter;
}
a:hover {
-text-decoration-color: $accent-palette-A400;
+text-decoration-color: utils.get-color-on-surface($color-config,
$surface);
}
.tooltip {
-background-color: $canvas-primary-palette-900;
-border-color: $canvas-primary-palette-200;
-box-shadow: 0 2px 5px
[jira] [Updated] (NIFI-12617) Change the default nifi.web.https.host value from 127.0.0.1 to localhost
[
https://issues.apache.org/jira/browse/NIFI-12617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12617:
Summary: Change the default nifi.web.https.host value from 127.0.0.1 to
localhost (was: Change the default nifi.web.https.host value from 127.0.0.1 to
a host name)
> Change the default nifi.web.https.host value from 127.0.0.1 to localhost
>
>
> Key: NIFI-12617
> URL: https://issues.apache.org/jira/browse/NIFI-12617
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Ferenc Gerlits
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As of NiFi 2.0.0-M1, it is no longer possible to connect to NiFi on
> {{{}[https://127.0.0.1:8443|https://127.0.0.1:8443/]{}}}, but the default
> {{nifi.properties}} file still contains
> {noformat}
> nifi.web.https.host=127.0.0.1{noformat}
> and (therefore?) the log file still says
> {noformat}
> 2024-01-16 14:21:26,375 INFO [main] org.apache.nifi.web.server.JettyServer
> NiFi has started. The UI is available at the following URLs:
> 2024-01-16 14:21:26,375 INFO [main] org.apache.nifi.web.server.JettyServer
> https://127.0.0.1:8443/nifi{noformat}
> The default could be changed from {{127.0.0.1}} to (for example)
> {{{}localhost{}}}, to make the life of novice users easier, and to reduce the
> number of complaints coming from us.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12617 Change default nifi.web.https.host to localhost [nifi]
exceptionfactory closed pull request #8486: NIFI-12617 Change default nifi.web.https.host to localhost URL: https://github.com/apache/nifi/pull/8486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12617) Change the default nifi.web.https.host value from 127.0.0.1 to localhost
[
https://issues.apache.org/jira/browse/NIFI-12617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann reassigned NIFI-12617:
---
Assignee: endzeit
> Change the default nifi.web.https.host value from 127.0.0.1 to localhost
>
>
> Key: NIFI-12617
> URL: https://issues.apache.org/jira/browse/NIFI-12617
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Ferenc Gerlits
>Assignee: endzeit
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As of NiFi 2.0.0-M1, it is no longer possible to connect to NiFi on
> {{{}[https://127.0.0.1:8443|https://127.0.0.1:8443/]{}}}, but the default
> {{nifi.properties}} file still contains
> {noformat}
> nifi.web.https.host=127.0.0.1{noformat}
> and (therefore?) the log file still says
> {noformat}
> 2024-01-16 14:21:26,375 INFO [main] org.apache.nifi.web.server.JettyServer
> NiFi has started. The UI is available at the following URLs:
> 2024-01-16 14:21:26,375 INFO [main] org.apache.nifi.web.server.JettyServer
> https://127.0.0.1:8443/nifi{noformat}
> The default could be changed from {{127.0.0.1}} to (for example)
> {{{}localhost{}}}, to make the life of novice users easier, and to reduce the
> number of complaints coming from us.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-12617) Change the default nifi.web.https.host value from 127.0.0.1 to localhost
[
https://issues.apache.org/jira/browse/NIFI-12617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-12617.
-
Fix Version/s: 2.0.0
Resolution: Fixed
> Change the default nifi.web.https.host value from 127.0.0.1 to localhost
>
>
> Key: NIFI-12617
> URL: https://issues.apache.org/jira/browse/NIFI-12617
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Ferenc Gerlits
>Assignee: endzeit
>Priority: Minor
> Fix For: 2.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As of NiFi 2.0.0-M1, it is no longer possible to connect to NiFi on
> {{{}[https://127.0.0.1:8443|https://127.0.0.1:8443/]{}}}, but the default
> {{nifi.properties}} file still contains
> {noformat}
> nifi.web.https.host=127.0.0.1{noformat}
> and (therefore?) the log file still says
> {noformat}
> 2024-01-16 14:21:26,375 INFO [main] org.apache.nifi.web.server.JettyServer
> NiFi has started. The UI is available at the following URLs:
> 2024-01-16 14:21:26,375 INFO [main] org.apache.nifi.web.server.JettyServer
> https://127.0.0.1:8443/nifi{noformat}
> The default could be changed from {{127.0.0.1}} to (for example)
> {{{}localhost{}}}, to make the life of novice users easier, and to reduce the
> number of complaints coming from us.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12617) Change the default nifi.web.https.host value from 127.0.0.1 to a host name
[
https://issues.apache.org/jira/browse/NIFI-12617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824871#comment-17824871
]
ASF subversion and git services commented on NIFI-12617:
Commit fabf6bf53633bbc0534f85d0ad7fc7c312477dab in nifi's branch
refs/heads/main from EndzeitBegins
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=fabf6bf536 ]
NIFI-12617 Set default nifi.web.https.host to localhost
This closes #8486
Signed-off-by: David Handermann
> Change the default nifi.web.https.host value from 127.0.0.1 to a host name
> --
>
> Key: NIFI-12617
> URL: https://issues.apache.org/jira/browse/NIFI-12617
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Ferenc Gerlits
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As of NiFi 2.0.0-M1, it is no longer possible to connect to NiFi on
> {{{}[https://127.0.0.1:8443|https://127.0.0.1:8443/]{}}}, but the default
> {{nifi.properties}} file still contains
> {noformat}
> nifi.web.https.host=127.0.0.1{noformat}
> and (therefore?) the log file still says
> {noformat}
> 2024-01-16 14:21:26,375 INFO [main] org.apache.nifi.web.server.JettyServer
> NiFi has started. The UI is available at the following URLs:
> 2024-01-16 14:21:26,375 INFO [main] org.apache.nifi.web.server.JettyServer
> https://127.0.0.1:8443/nifi{noformat}
> The default could be changed from {{127.0.0.1}} to (for example)
> {{{}localhost{}}}, to make the life of novice users easier, and to reduce the
> number of complaints coming from us.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
james-elliott commented on code in PR #8480: URL: https://github.com/apache/nifi/pull/8480#discussion_r1518324698 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/feature/_settings.component-theme.scss: ## @@ -17,18 +17,17 @@ @use 'sass:map'; @use '@angular/material' as mat; +@use '../../../../../node_modules/@angular/material/core/theming/inspection' as inspection; Review Comment: Tried this originally, and then again just now, it throws an error `Can't find stylesheet to import.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
james-elliott commented on code in PR #8480: URL: https://github.com/apache/nifi/pull/8480#discussion_r1518317016 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/process-group/create-process-group/_create-process-group.component-theme.scss: ## @@ -26,13 +26,13 @@ $accent-palette: map.get($color-config, 'accent'); // Get hues from palette -$accent-palette-A400: mat.get-color-from-palette($accent-palette, 'A400'); +$accent-palette-default: mat.get-color-from-palette($accent-palette, 'default'); // Get hues from palette Review Comment: Not introduced in this PR, but worth fixing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12797) Record.incorporateInactiveFields fails if inactive field added with same name but different type
[ https://issues.apache.org/jira/browse/NIFI-12797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12797. - Resolution: Fixed > Record.incorporateInactiveFields fails if inactive field added with same name > but different type > > > Key: NIFI-12797 > URL: https://issues.apache.org/jira/browse/NIFI-12797 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The Record.incorporateInactiveFields has a bug in it. > It considers two cases: updated fields and inactive fields. When considering > inactive fields, it skips any fields that are also present in the 'updated > fields'. This makes sense, as we don't want to add a new field if there's > already a field with the same name. > However, the comparison it uses is based on RecordField and not the field > name. So in some cases it can throw an Exception because there's a conflict > where an inactive field has the same name but different type than an updated > field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12797) Record.incorporateInactiveFields fails if inactive field added with same name but different type
[ https://issues.apache.org/jira/browse/NIFI-12797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824866#comment-17824866 ] ASF subversion and git services commented on NIFI-12797: Commit 8ad3c731dabdf9f951b949ce733e81cdebc06749 in nifi's branch refs/heads/main from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8ad3c731da ] NIFI-12797 Refactored Record.incorporateInactiveFields Refactored Record.incorporateInactiveFields to handle when an updated field and an inactive field have the same name (which can happen if incorporateInactiveFields is called multiple times). Also refactored the setValue(String, Object) method to call setValue(RecordField, Object) because the logic had diverged. Also exposed the text of Expression Language, which led to the discovery of this bug. This closes #8413 Signed-off-by: David Handermann > Record.incorporateInactiveFields fails if inactive field added with same name > but different type > > > Key: NIFI-12797 > URL: https://issues.apache.org/jira/browse/NIFI-12797 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The Record.incorporateInactiveFields has a bug in it. > It considers two cases: updated fields and inactive fields. When considering > inactive fields, it skips any fields that are also present in the 'updated > fields'. This makes sense, as we don't want to add a new field if there's > already a field with the same name. > However, the comparison it uses is based on RecordField and not the field > name. So in some cases it can throw an Exception because there's a conflict > where an inactive field has the same name but different type than an updated > field. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
james-elliott commented on code in PR #8480:
URL: https://github.com/apache/nifi/pull/8480#discussion_r1518311684
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/styles.scss:
##
@@ -187,153 +192,145 @@ $appFontPath: '~roboto-fontface/fonts';
$canvas-accent-palette: map.get($canvas-color-config, 'accent');
// Get hues from palette
-$primary-palette-50: mat.get-color-from-palette($primary-palette, 50);
-$primary-palette-200: mat.get-color-from-palette($primary-palette, 200);
-$primary-palette-500: mat.get-color-from-palette($primary-palette, 500);
-$accent-palette-A100: mat.get-color-from-palette($accent-palette, 'A100');
-$accent-palette-A200: mat.get-color-from-palette($accent-palette, 'A200');
-$accent-palette-A400: mat.get-color-from-palette($accent-palette, 'A400');
-$canvas-primary-palette-50:
mat.get-color-from-palette($canvas-primary-palette, 50);
-$canvas-primary-palette-200:
mat.get-color-from-palette($canvas-primary-palette, 200);
-$canvas-primary-palette-400:
mat.get-color-from-palette($canvas-primary-palette, 400);
-$canvas-primary-palette-900:
mat.get-color-from-palette($canvas-primary-palette, 900);
-$canvas-accent-palette-200:
mat.get-color-from-palette($canvas-accent-palette, 200);
-$canvas-accent-palette-400:
mat.get-color-from-palette($canvas-accent-palette, 400);
-$canvas-accent-palette-A200:
mat.get-color-from-palette($canvas-accent-palette, 'A200');
-$warn-palette-200: mat.get-color-from-palette($warn-palette, 200);
-$warn-palette-300: mat.get-color-from-palette($warn-palette, 300);
-$warn-palette-A100: mat.get-color-from-palette($warn-palette, 'A100');
-$warn-palette-A400: mat.get-color-from-palette($warn-palette, 'A400');
+
+// Start with the canvas theme.
+$canvas-primary-palette-A200:
mat.get-color-from-palette($canvas-primary-palette, A200);
+$canvas-primary-palette-500:
mat.get-color-from-palette($canvas-primary-palette, 500);
+$canvas-accent-palette-lighter:
mat.get-color-from-palette($canvas-accent-palette, lighter);
+$canvas-accent-palette-default:
mat.get-color-from-palette($canvas-accent-palette, default);
+
+$primary-palette-lighter: mat.get-color-from-palette($primary-palette,
lighter);
+$primary-palette-default: mat.get-color-from-palette($primary-palette,
'default');
+$primary-palette-A400: mat.get-color-from-palette($primary-palette,
'A400');
+
+$accent-palette-default: mat.get-color-from-palette($accent-palette,
'default');
+$accent-palette-lighter: mat.get-color-from-palette($accent-palette,
'lighter');
+
+$warn-palette-lighter: mat.get-color-from-palette($warn-palette, lighter);
+$warn-palette-default: mat.get-color-from-palette($warn-palette,
'default');
+
+// Alternative hue for warn colors.
+$warn-palette-A200: mat.get-color-from-palette($warn-palette, 'A200');
+
+$surface: utils.get-surface($canvas-color-config);
+$surface-darker: utils.get-surface($canvas-color-config, darker);
+$surface-highlight: utils.get-on-surface($canvas-color-config, highlight);
+$on-surface: utils.get-on-surface($canvas-color-config);
+$on-surface-lighter: utils.get-on-surface($canvas-color-config, lighter);
+
+* { // Tailwind sets a default that doesn't shift with light and dark
themes
+border-color: $on-surface-lighter;
+}
a {
-color: $accent-palette-A400;
-text-decoration-color: $primary-palette-200;
+color: utils.get-color-on-surface($color-config, $surface);
+text-decoration-color: $primary-palette-lighter;
}
a:hover {
-text-decoration-color: $accent-palette-A400;
+text-decoration-color: utils.get-color-on-surface($color-config,
$surface);
}
.tooltip {
-background-color: $canvas-primary-palette-900;
-border-color: $canvas-primary-palette-200;
-box-shadow: 0 2px 5px $canvas-primary-palette-50;
-color: $canvas-primary-palette-200;
+background-color: $surface;
+border-color: $on-surface;
+box-shadow: 0 2px 5px $canvas-primary-palette-A200;
+color: $on-surface;
}
.property-editor {
-background-color: $canvas-primary-palette-900;
-box-shadow: 0 2px 5px $canvas-primary-palette-50;
+background-color: $surface;
+box-shadow: 0 2px 5px $canvas-primary-palette-A200;
}
.disabled {
-color: $primary-palette-500 !important;
-fill: $primary-palette-500 !important;
-text-shadow: 0 0 4px $canvas-primary-palette-900;
+color: $primary-palette-default !important;
+fill: $primary-palette-default !important;
}
.enabled {
-color: $accent-palette-A200 !important;
-fill: $accent-palette-A200 !important;
-text-shadow: 0 0 4px $canvas-primary-palette-900;
+color:
Re: [PR] NIFI-12797: Refactored Record.incorporateInactiveFields to handle whe… [nifi]
exceptionfactory closed pull request #8413: NIFI-12797: Refactored Record.incorporateInactiveFields to handle whe… URL: https://github.com/apache/nifi/pull/8413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
james-elliott commented on code in PR #8480:
URL: https://github.com/apache/nifi/pull/8480#discussion_r1518310219
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-utils.service.ts:
##
@@ -1253,9 +1253,9 @@ export class CanvasUtils {
})
.attr('class', function () {
if (terminatedThreads > 0) {
-return `active-thread-count-icon warn-400`;
+return `active-thread-count-icon warn-default`;
Review Comment:
Guess I should define it near `.warn-400`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
scottyaslan commented on code in PR #8480: URL: https://github.com/apache/nifi/pull/8480#discussion_r1518302857 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/navigation/_navigation.component-theme.scss: ## @@ -17,45 +17,59 @@ @use 'sass:map'; @use '@angular/material' as mat; +@use '../../../../../node_modules/@angular/material/core/theming/inspection' as inspection; Review Comment: ```suggestion @use '@angular/material/core/theming/inspection' as inspection; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
scottyaslan commented on code in PR #8480: URL: https://github.com/apache/nifi/pull/8480#discussion_r1518302221 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/feature/_summary.component-theme.scss: ## @@ -17,18 +17,17 @@ @use 'sass:map'; @use '@angular/material' as mat; +@use '../../../../../node_modules/@angular/material/core/theming/inspection' as inspection; Review Comment: ```suggestion @use '@angular/material/core/theming/inspection' as inspection; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
scottyaslan commented on code in PR #8480: URL: https://github.com/apache/nifi/pull/8480#discussion_r1518301819 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/feature/_settings.component-theme.scss: ## @@ -17,18 +17,17 @@ @use 'sass:map'; @use '@angular/material' as mat; +@use '../../../../../node_modules/@angular/material/core/theming/inspection' as inspection; Review Comment: ```suggestion @use '@angular/material/core/theming/inspection' as inspection; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
scottyaslan commented on code in PR #8480: URL: https://github.com/apache/nifi/pull/8480#discussion_r1518300224 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/process-group/create-process-group/_create-process-group.component-theme.scss: ## @@ -26,13 +26,13 @@ $accent-palette: map.get($color-config, 'accent'); // Get hues from palette -$accent-palette-A400: mat.get-color-from-palette($accent-palette, 'A400'); +$accent-palette-default: mat.get-color-from-palette($accent-palette, 'default'); // Get hues from palette Review Comment: Comment??? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12879) Upgrade Clojure to 1.11.2
David Handermann created NIFI-12879: --- Summary: Upgrade Clojure to 1.11.2 Key: NIFI-12879 URL: https://issues.apache.org/jira/browse/NIFI-12879 Project: Apache NiFi Issue Type: Improvement Reporter: David Handermann Assignee: David Handermann Fix For: 2.0.0, 1.26.0 The Clojure library for the Scripting extensions bundle should be upgraded to [1.11.2|https://clojure.org/releases/downloads#_stable_release_1_11_2_mar_8_2024] to mitigate CVE-2024-22871, which relates to using Java Object serialization to read crafted inputs. Clojure is an optional scripting library and the Scripting extensions do not perform Java Object serialization directly. For this reason, deployments of NiFi that do not use custom Scripting components based on Clojure are not directly exposed to this vulnerability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12870 Refactor the usage of Material color theming to be semantic [nifi]
scottyaslan commented on code in PR #8480:
URL: https://github.com/apache/nifi/pull/8480#discussion_r1518277266
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/canvas.component.ts:
##
@@ -339,13 +339,13 @@ export class Canvas implements OnInit, OnDestroy {
.attr('orient', 'auto')
.attr('class', function (d: string) {
if (d === 'ghost') {
-return 'primary-contrast-300';
+return 'primary-canvas-400';
Review Comment:
Is defined as:
```
.primary-canvas-400 {
fill: $canvas-primary-palette-500;
}
```
Is it intentional to make the `.primary-canvas-400` be
canvas-primary-palette-500??? Seems like if the correct color is
canvas-primary-palette-500 then the name of this class should be
`.canvas-primary-palette-500`...
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/new-canvas-item/_new-canvas-item.component-theme.scss:
##
@@ -25,33 +26,46 @@
// Get the color palette from the color-config.
$primary-palette: map.get($color-config, 'primary');
-$accent-palette: map.get($color-config, 'accent');
-$canvas-primary-palette: map.get($canvas-color-config, 'primary');
// Get hues from palette
-$primary-palette-100: mat.get-color-from-palette($primary-palette, 100);
-$primary-palette-300: mat.get-color-from-palette($primary-palette, 300);
-$accent-palette-A400: mat.get-color-from-palette($accent-palette, 'A400');
-$canvas-primary-palette-50:
mat.get-color-from-palette($canvas-primary-palette, 50);
+// Get hues from palette
Review Comment:
Additional comment. Is it necessary?
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-utils.service.ts:
##
@@ -1253,9 +1253,9 @@ export class CanvasUtils {
})
.attr('class', function () {
if (terminatedThreads > 0) {
-return `active-thread-count-icon warn-400`;
+return `active-thread-count-icon warn-default`;
Review Comment:
`warn-default` is not defined anywhere.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/styles.scss:
##
@@ -187,153 +192,145 @@ $appFontPath: '~roboto-fontface/fonts';
$canvas-accent-palette: map.get($canvas-color-config, 'accent');
// Get hues from palette
-$primary-palette-50: mat.get-color-from-palette($primary-palette, 50);
-$primary-palette-200: mat.get-color-from-palette($primary-palette, 200);
-$primary-palette-500: mat.get-color-from-palette($primary-palette, 500);
-$accent-palette-A100: mat.get-color-from-palette($accent-palette, 'A100');
-$accent-palette-A200: mat.get-color-from-palette($accent-palette, 'A200');
-$accent-palette-A400: mat.get-color-from-palette($accent-palette, 'A400');
-$canvas-primary-palette-50:
mat.get-color-from-palette($canvas-primary-palette, 50);
-$canvas-primary-palette-200:
mat.get-color-from-palette($canvas-primary-palette, 200);
-$canvas-primary-palette-400:
mat.get-color-from-palette($canvas-primary-palette, 400);
-$canvas-primary-palette-900:
mat.get-color-from-palette($canvas-primary-palette, 900);
-$canvas-accent-palette-200:
mat.get-color-from-palette($canvas-accent-palette, 200);
-$canvas-accent-palette-400:
mat.get-color-from-palette($canvas-accent-palette, 400);
-$canvas-accent-palette-A200:
mat.get-color-from-palette($canvas-accent-palette, 'A200');
-$warn-palette-200: mat.get-color-from-palette($warn-palette, 200);
-$warn-palette-300: mat.get-color-from-palette($warn-palette, 300);
-$warn-palette-A100: mat.get-color-from-palette($warn-palette, 'A100');
-$warn-palette-A400: mat.get-color-from-palette($warn-palette, 'A400');
+
+// Start with the canvas theme.
+$canvas-primary-palette-A200:
mat.get-color-from-palette($canvas-primary-palette, A200);
+$canvas-primary-palette-500:
mat.get-color-from-palette($canvas-primary-palette, 500);
+$canvas-accent-palette-lighter:
mat.get-color-from-palette($canvas-accent-palette, lighter);
+$canvas-accent-palette-default:
mat.get-color-from-palette($canvas-accent-palette, default);
+
+$primary-palette-lighter: mat.get-color-from-palette($primary-palette,
lighter);
+$primary-palette-default: mat.get-color-from-palette($primary-palette,
'default');
+$primary-palette-A400: mat.get-color-from-palette($primary-palette,
'A400');
+
+$accent-palette-default: mat.get-color-from-palette($accent-palette,
'default');
+$accent-palette-lighter:
[PR] Bump org.clojure:clojure from 1.11.1 to 1.11.2 in /nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors [nifi]
dependabot[bot] opened a new pull request, #8487: URL: https://github.com/apache/nifi/pull/8487 Bumps [org.clojure:clojure](https://github.com/clojure/clojure) from 1.11.1 to 1.11.2. Changelog Sourced from https://github.com/clojure/clojure/blob/master/changes.md;>org.clojure:clojure's changelog. Commits https://github.com/clojure/clojure/commit/218054f1f2ddfc69ef4f9d17f916de35e4a4effe;>218054f [maven-release-plugin] prepare release clojure-1.11.2 https://github.com/clojure/clojure/commit/63474dbaf356cbbc38ed9bd9f3a01c5800b8a6c4;>63474db update pom to snapshot version https://github.com/clojure/clojure/commit/5366a0e9e6df8ade159772703da3ac32c352fcdc;>5366a0e add github actions to clojure-1.11-dev branch https://github.com/clojure/clojure/commit/777456f5f485ed42cee386344fbce891c559ec4e;>777456f CLJ-2839 Infinite seq class hashCode() is infinite loop See full diff in https://github.com/clojure/clojure/compare/clojure-1.11.1...clojure-1.11.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/nifi/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12878) Enable flow history for process groups' Enable/Disable all controller services option(s) for controller services
Nissim Shiman created NIFI-12878: Summary: Enable flow history for process groups' Enable/Disable all controller services option(s) for controller services Key: NIFI-12878 URL: https://issues.apache.org/jira/browse/NIFI-12878 Project: Apache NiFi Issue Type: Improvement Reporter: Nissim Shiman When a process group's "Enable all controller services" option (or "Disable all controller services" option) is chosen, all controller services in that PG are enabled (or disabled). Flow configuration history captures the PG that was enabled/disabled, but the specific controller services that were enabled/disabled are not captured. It would be useful if the specific controller services that were enabled/disabled could be captured here as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-12878) Enable flow history for process groups' Enable/Disable all controller services option(s) for controller services
[ https://issues.apache.org/jira/browse/NIFI-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nissim Shiman reassigned NIFI-12878: Assignee: Nissim Shiman > Enable flow history for process groups' Enable/Disable all controller > services option(s) for controller services > > > Key: NIFI-12878 > URL: https://issues.apache.org/jira/browse/NIFI-12878 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Nissim Shiman >Assignee: Nissim Shiman >Priority: Major > > When a process group's "Enable all controller services" option (or "Disable > all controller services" option) is chosen, all controller services in that > PG are enabled (or disabled). > Flow configuration history captures the PG that was enabled/disabled, but the > specific controller services that were enabled/disabled are not captured. > It would be useful if the specific controller services that were > enabled/disabled could be captured here as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12861 Provide documentation on JASN1Reader that it only supports… [nifi]
Kapkiai commented on PR #8469: URL: https://github.com/apache/nifi/pull/8469#issuecomment-1986137672 @exceptionfactory @dan-s1 kindly help review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2313 Fix Grafana Loki issues on Windows [nifi-minifi-cpp]
szaszm commented on code in PR #1742: URL: https://github.com/apache/nifi-minifi-cpp/pull/1742#discussion_r1518033687 ## extensions/grafana-loki/tests/CMakeLists.txt: ## @@ -16,6 +16,8 @@ # specific language governing permissions and limitations # under the License. # +include(WholeArchive) + Review Comment: This include no longer seems necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]
szaszm commented on code in PR #1734:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1517981895
##
cmake/MiNiFiOptions.cmake:
##
@@ -82,6 +80,8 @@ list(APPEND STRICT_GSL_CHECKS_Values AUDIT ON DEBUG_ONLY OFF)
set_property(CACHE STRICT_GSL_CHECKS PROPERTY STRINGS
${STRICT_GSL_CHECKS_Values})
if (WIN32)
+add_minifi_option(INSTALLER_MERGE_MODULES "Creates installer with merge
modules" OFF)
+add_minifi_option(INSTALLER_WITH_VC_REDISTRIBUTABLES "Creates installer
with Visual C++ redistributables included" OFF)
Review Comment:
This sounds good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2313 Fix Grafana Loki issues on Windows [nifi-minifi-cpp]
lordgamez commented on code in PR #1742:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1742#discussion_r1517929222
##
extensions/grafana-loki/tests/CMakeLists.txt:
##
@@ -38,6 +40,9 @@ FOREACH(testfile ${GRAFANA_LOKI_TESTS})
createTests("${testfilename}")
target_link_libraries(${testfilename} Catch2WithMain)
target_link_libraries(${testfilename} minifi-grafana-loki)
+if (WIN32)
+target_wholearchive_library(${testfilename} grafana-loki-protos)
+endif()
Review Comment:
What I experienced was, that when I built a separate server as a separate
process using the generated source files from the proto files, the test passed
when communicating with that server.
When I created a separate test file that contained the server and client in
a single source file (running the server on a separate thread) and linked the
`minifi-grafana-loki` library the linking failed with the following issue:
```
LINK Pass 1: command
"C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1439~1.335\bin\Hostx64\x64\link.exe
/nologo @CMakeFiles\lokitest.rsp /out:bin\lokitest.exe
/implib:extensions\grafana-loki\tests\lokitest.lib /pdb:bin\lokitest.pdb
/version:0.0 /machine:x64 /debug /INCREMENTAL /subsystem:console
/WHOLEARCHIVE:test_base /MANIFEST
/MANIFESTFILE:extensions\grafana-loki\tests\CMakeFiles\lokitest.dir/intermediate.manifest
extensions\grafana-loki\tests\CMakeFiles\lokitest.dir/manifest.res" failed
(exit code 1120) with the following output:
lokitest.cc.obj : error LNK2019: unresolved external symbol "const
logproto::PushRequest::`vftable'" (??_7PushRequest@logproto@@6B@) referenced in
function "public: __cdecl logproto::PushRequest::PushRequest(void)"
(??0PushRequest@logproto@@QEAA@XZ)
lokitest.cc.obj : error LNK2019: unresolved external symbol "const
logproto::PushResponse::`vftable'" (??_7PushResponse@logproto@@6B@) referenced
in function "public: __cdecl logproto::PushResponse::PushResponse(void)"
(??0PushResponse@logproto@@QEAA@XZ)
bin\lokitest.exe : fatal error LNK1120: 2 unresolved externals
```
It seems that when the PushRequest and PushResponse are used directly in the
test source file it fails with link error, but when used only from
PushGrafanaLokiGrpc processor, the PushRequest and PushResponse are not used in
the tests and probably removed from the final executable, but this is only my
guess from this.
I was still experimenting with it and it may be able to remove the
wholearchive linking, as it seems to be enough for Windows to have a separate
`grafana-loki-protos` library for the generated proto source files and linked
to `minifi-grafana-loki` for the symbols to be available for the tests. I
updated it in e3564ef75b3782c9a77d0dbd6a782d9d8519de1d, we shall see if it
works in the CI as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-12617 Change default nifi.web.https.host to localhost [nifi]
EndzeitBegins opened a new pull request, #8486: URL: https://github.com/apache/nifi/pull/8486 # Summary The SNI checks in place when a secured NiFi is used prevent the access of NiFi using the IP address, this includes `127.0.0.1`. Additionally, the auto-generated TLS certificate does not contain a subject alternative name with the IP address `127.0.0.1`. However, the default (secure) configuration still declares `127.0.0.1` as `nifi.web.https.host` resulting in the following log output on fresh NiFi installations: > 2024-03-08 15:23:46,890 INFO [main] org.apache.nifi.web.server.JettyServer Started Server on https://127.0.0.1:8443/nifi However, accessing that link, users are "greeted" by an `Invalid SNI` error. This might lead to some confusion for new users of NiFi. This PR changes the default value, see [NIFI-12617](https://issues.apache.org/jira/browse/NIFI-12617). --- However, accessing NiFi using `127.0.0.1` is still possible and leads to the aforementioned SNI error. I thought about including the IP address in the auto-generated certificate and disabling SNI checks whenever "localhost" or "127.0.0.1" is set as host. However, I concluded that this might accidentally weaken security for only a very marginal gain in convenience. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2310) Extend ListenTCP with new ways to delimit flow files
[ https://issues.apache.org/jira/browse/MINIFICPP-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-2310: -- Description: * custom message delimiter * option to separate by connection (no delimiter, only optional size limit) * batching multiple messages to 1 flow file (like NiFi 'Max Batch Size') Also, ListenTCP should not remove the delimiter from the end of the outgoing flow files, to make sure that a byte stream going through PutTCP -> ListenTCP stays the same. (Optionally, we may want to make this configurable.) was: * custom message delimiter * option to separate by connection (no delimiter, only optional size limit) * batching multiple messages to 1 flow file (like NiFi 'Max Batch Size') > Extend ListenTCP with new ways to delimit flow files > > > Key: MINIFICPP-2310 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2310 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Marton Szasz >Priority: Major > > * custom message delimiter > * option to separate by connection (no delimiter, only optional size limit) > * batching multiple messages to 1 flow file (like NiFi 'Max Batch Size') > Also, ListenTCP should not remove the delimiter from the end of the outgoing > flow files, to make sure that a byte stream going through PutTCP -> ListenTCP > stays the same. (Optionally, we may want to make this configurable.) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1721:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1517807712
##
encrypt-config/tests/ConfigFileEncryptorTests.cpp:
##
@@ -77,7 +77,7 @@ TEST_CASE("ConfigFileEncryptor can encrypt the sensitive
properties", "[encrypt-
uint32_t num_properties_encrypted =
encryptSensitivePropertiesInFile(test_file, KEY);
REQUIRE(num_properties_encrypted == 1);
-REQUIRE(test_file.size() == 110);
+REQUIRE(test_file.size() == 115);
Review Comment:
When the default minifi.properties file changes this test always needs to be
updated, as it checks the property count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1721:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1517807712
##
encrypt-config/tests/ConfigFileEncryptorTests.cpp:
##
@@ -77,7 +77,7 @@ TEST_CASE("ConfigFileEncryptor can encrypt the sensitive
properties", "[encrypt-
uint32_t num_properties_encrypted =
encryptSensitivePropertiesInFile(test_file, KEY);
REQUIRE(num_properties_encrypted == 1);
-REQUIRE(test_file.size() == 110);
+REQUIRE(test_file.size() == 115);
Review Comment:
When the default minifi.properties file changes this test always needs to be
updated, as it checks the line count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1721:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1517821922
##
extensions/python/PythonConfigState.h:
##
@@ -0,0 +1,50 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include
+#include
+
+namespace org::apache::nifi::minifi::extensions::python {
+
+struct PythonConfigState {
+ public:
+ PythonConfigState(PythonConfigState&&) = delete;
+ PythonConfigState(const PythonConfigState&) = delete;
+ PythonConfigState& operator=(PythonConfigState&&) = delete;
+ PythonConfigState& operator=(const PythonConfigState&) = delete;
+
+ bool isPackageInstallationNeeded() const {
+return install_python_packages_automatically && !virtualenv_path.empty();
+ }
+
+ static PythonConfigState& getInstance() {
+static PythonConfigState config;
+return config;
+ }
Review Comment:
You are right, I also try to avoid them when possible. In this case the
python configuration is read in the PythonCreator from the Configuration
object, but has to be used in the PythonScriptEngine which is initialized in
each python processor. Due to the interface we use to create the python
processors (instantiating the ExecutePythonProcessor class from the
PythonObjectFactory) there is no clean way currently to reach the
`Configuration` object from the processors' scope. Even though it's better to
avoid them I think this is still a cleaner solution than anything else I could
come up with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1721:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1517807712
##
encrypt-config/tests/ConfigFileEncryptorTests.cpp:
##
@@ -77,7 +77,7 @@ TEST_CASE("ConfigFileEncryptor can encrypt the sensitive
properties", "[encrypt-
uint32_t num_properties_encrypted =
encryptSensitivePropertiesInFile(test_file, KEY);
REQUIRE(num_properties_encrypted == 1);
-REQUIRE(test_file.size() == 110);
+REQUIRE(test_file.size() == 115);
Review Comment:
When the default minifi.properties file changes this tests always needs to
be updated, as it checks the line count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1721:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1517806663
##
docker/python-verify/conda.Dockerfile:
##
@@ -31,14 +31,12 @@ USER root
RUN wget https://repo.anaconda.com/archive/Anaconda3-2023.09-0-Linux-x86_64.sh
-P /tmp \
&& echo "6c8a4abb36fbb711dc055b7049a23bbfd61d356de9468b41c5140f8a11abd851
/tmp/Anaconda3-2023.09-0-Linux-x86_64.sh" | sha256sum -c \
&& bash /tmp/Anaconda3-2023.09-0-Linux-x86_64.sh -b -p /opt/conda \
-&& chown -R ${USER}:${USER} /opt/conda \
-&& mkdir /home/${USER} \
-&& chown -R ${USER}:${USER} /home/${USER}
+&& chown -R ${USER}:${USER} /opt/conda
USER ${USER}
RUN ${CONDA_HOME}/bin/conda init bash
-RUN ${CONDA_HOME}/bin/conda install langchain -c conda-forge
+RUN ${CONDA_HOME}/bin/conda install "langchain<=0.17.0" -c conda-forge
Review Comment:
This is just for using fixed version of the library, to avoid breaking the
tests with newer versions, see comment
https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1513218719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12842) InvokeHTTP version wrong encoding of % in URL
[ https://issues.apache.org/jira/browse/NIFI-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12842: Fix Version/s: 2.0.0 1.26.0 > InvokeHTTP version wrong encoding of % in URL > - > > Key: NIFI-12842 > URL: https://issues.apache.org/jira/browse/NIFI-12842 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.25.0, 2.0.0-M2 > Environment: RHEL 7 >Reporter: WojciechWitos >Assignee: Daniel Stieglitz >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Attachments: image-2024-02-26-08-10-12-657.png, > image-2024-02-26-08-11-25-213.png, image-2024-02-26-08-13-14-199.png, > image-2024-02-26-08-16-36-309.png, image-2024-02-27-12-09-31-831.png, > image-2024-02-27-12-10-33-542.png, image-2024-02-27-12-10-59-337.png, > image-2024-02-27-12-11-39-163.png, image-2024-02-27-12-12-00-043.png, > image-2024-02-27-12-12-06-720.png, image-2024-02-27-12-13-10-173.png > > > Hi! > I've encountered on the version 1.25 issue with encoding of % in invokehttp > processor. > It changes every % into %25, which causes error 403 and most of the flows > don't work. > On the version 1.24 everything works properly with this processor. > Here are the screenshots of 1.25: > !image-2024-02-26-08-10-12-657.png! > And request: > !image-2024-02-26-08-11-25-213.png! > Where on version 1.24 this issue doesn't persist: > !image-2024-02-26-08-13-14-199.png! > !image-2024-02-26-08-16-36-309.png! > Please investigate this issue, it is the blocker of upgrading the environment > to this version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12842) InvokeHTTP version wrong encoding of % in URL
[ https://issues.apache.org/jira/browse/NIFI-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12842. - Assignee: Daniel Stieglitz Resolution: Fixed > InvokeHTTP version wrong encoding of % in URL > - > > Key: NIFI-12842 > URL: https://issues.apache.org/jira/browse/NIFI-12842 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.25.0, 2.0.0-M2 > Environment: RHEL 7 >Reporter: WojciechWitos >Assignee: Daniel Stieglitz >Priority: Major > Attachments: image-2024-02-26-08-10-12-657.png, > image-2024-02-26-08-11-25-213.png, image-2024-02-26-08-13-14-199.png, > image-2024-02-26-08-16-36-309.png, image-2024-02-27-12-09-31-831.png, > image-2024-02-27-12-10-33-542.png, image-2024-02-27-12-10-59-337.png, > image-2024-02-27-12-11-39-163.png, image-2024-02-27-12-12-00-043.png, > image-2024-02-27-12-12-06-720.png, image-2024-02-27-12-13-10-173.png > > > Hi! > I've encountered on the version 1.25 issue with encoding of % in invokehttp > processor. > It changes every % into %25, which causes error 403 and most of the flows > don't work. > On the version 1.24 everything works properly with this processor. > Here are the screenshots of 1.25: > !image-2024-02-26-08-10-12-657.png! > And request: > !image-2024-02-26-08-11-25-213.png! > Where on version 1.24 this issue doesn't persist: > !image-2024-02-26-08-13-14-199.png! > !image-2024-02-26-08-16-36-309.png! > Please investigate this issue, it is the blocker of upgrading the environment > to this version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12785) InvokeHTTP handler should not urlencode HTTP URL
[ https://issues.apache.org/jira/browse/NIFI-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824807#comment-17824807 ] Daniel Stieglitz commented on NIFI-12785: - [~exceptionfactory] Can you also please mark NIFI-12842 as resolved as it is a duplicate of this ticket? Thanks! > InvokeHTTP handler should not urlencode HTTP URL > > > Key: NIFI-12785 > URL: https://issues.apache.org/jira/browse/NIFI-12785 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.25.0, 2.0.0-M2 > Environment: AlmaLinux 8.9 Kernel 4.18.0-513.5.1.el8_9.x86_64 > Apache NiFi 2.0.0-M2 >Reporter: macdoor615 >Assignee: Daniel Stieglitz >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Attachments: M1-output.png, M2-output.png > > Time Spent: 2h 50m > Remaining Estimate: 0h > > InvokeHTTP processor call HTTP URL > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%2Fstage%2F15m%2Fheshangwuzhibo.yaml/raw?ref=main] > output attribute > invokehttp.request.url: > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%252Fstage%252F15m%252Fheshangwuzhibo.yaml/raw?ref=main] > > invokehttp.status.code: 404 > > The situation is different for version 2.0.0-M1, output attribute > invokehttp.request.url: > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%2Fstage%2F15m%2Fheshangwuzhibo.yaml/raw?ref=main] > > invokehttp.status.code: 200 > > I found that in the M2 version % symbol was urlencoded to %25, M1 version. > The M1 version does not urlencode > > pls refer to the uploaded pictures -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12785) InvokeHTTP handler should not urlencode HTTP URL
[ https://issues.apache.org/jira/browse/NIFI-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12785: Fix Version/s: 2.0.0 1.26.0 Resolution: Fixed Status: Resolved (was: Patch Available) > InvokeHTTP handler should not urlencode HTTP URL > > > Key: NIFI-12785 > URL: https://issues.apache.org/jira/browse/NIFI-12785 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.25.0, 2.0.0-M2 > Environment: AlmaLinux 8.9 Kernel 4.18.0-513.5.1.el8_9.x86_64 > Apache NiFi 2.0.0-M2 >Reporter: macdoor615 >Assignee: Daniel Stieglitz >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Attachments: M1-output.png, M2-output.png > > Time Spent: 2h 50m > Remaining Estimate: 0h > > InvokeHTTP processor call HTTP URL > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%2Fstage%2F15m%2Fheshangwuzhibo.yaml/raw?ref=main] > output attribute > invokehttp.request.url: > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%252Fstage%252F15m%252Fheshangwuzhibo.yaml/raw?ref=main] > > invokehttp.status.code: 404 > > The situation is different for version 2.0.0-M1, output attribute > invokehttp.request.url: > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%2Fstage%2F15m%2Fheshangwuzhibo.yaml/raw?ref=main] > > invokehttp.status.code: 200 > > I found that in the M2 version % symbol was urlencoded to %25, M1 version. > The M1 version does not urlencode > > pls refer to the uploaded pictures -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]
szaszm commented on code in PR #1721:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1511271227
##
docker/python-verify/conda.Dockerfile:
##
@@ -31,14 +31,12 @@ USER root
RUN wget https://repo.anaconda.com/archive/Anaconda3-2023.09-0-Linux-x86_64.sh
-P /tmp \
&& echo "6c8a4abb36fbb711dc055b7049a23bbfd61d356de9468b41c5140f8a11abd851
/tmp/Anaconda3-2023.09-0-Linux-x86_64.sh" | sha256sum -c \
&& bash /tmp/Anaconda3-2023.09-0-Linux-x86_64.sh -b -p /opt/conda \
-&& chown -R ${USER}:${USER} /opt/conda \
-&& mkdir /home/${USER} \
-&& chown -R ${USER}:${USER} /home/${USER}
+&& chown -R ${USER}:${USER} /opt/conda
USER ${USER}
RUN ${CONDA_HOME}/bin/conda init bash
-RUN ${CONDA_HOME}/bin/conda install langchain -c conda-forge
+RUN ${CONDA_HOME}/bin/conda install "langchain<=0.17.0" -c conda-forge
Review Comment:
What happened in langchain >0.17?
##
extensions/python/PythonScriptEngine.cpp:
##
@@ -68,6 +67,73 @@ void initThreads() {
#pragma warning(pop)
#endif
}
+
+std::string encapsulateCommandInQuotesIfNeeded(const std::string& command) {
+#if WIN32
+return "\"" + command + "\"";
+#else
+return command;
+#endif
+}
+
+std::vector getRequirementsFilePaths(const
std::shared_ptr ) {
+ std::vector paths;
+ if (auto python_processor_path =
configuration->get(minifi::Configuration::nifi_python_processor_dir)) {
+for (const auto& entry :
std::filesystem::recursive_directory_iterator(std::filesystem::path{*python_processor_path}))
{
+ if (std::filesystem::is_regular_file(entry.path()) &&
entry.path().filename() == "requirements.txt") {
+paths.push_back(entry.path());
+ }
+}
+ }
+ return paths;
+}
+
+std::string getPythonBinary(const std::shared_ptr ) {
+#if WIN32
+ std::string python_binary = "python";
+#else
+ std::string python_binary = "python3";
+#endif
+ if (auto binary =
configuration->get(minifi::Configuration::nifi_python_env_setup_binary)) {
+python_binary = *binary;
+ }
+ return python_binary;
+}
+
+void createVirtualEnvIfSpecified(const std::shared_ptr
) {
+ if (auto path =
configuration->get(minifi::Configuration::nifi_python_virtualenv_directory)) {
+PythonConfigState::getInstance().virtualenv_path = *path;
+if
(!std::filesystem::exists(PythonConfigState::getInstance().virtualenv_path) ||
!std::filesystem::is_empty(PythonConfigState::getInstance().virtualenv_path)) {
+ auto venv_command = "\"" +
PythonConfigState::getInstance().python_binary + "\" -m venv \"" +
PythonConfigState::getInstance().virtualenv_path.string() + "\"";
+ auto return_value =
std::system(encapsulateCommandInQuotesIfNeeded(venv_command).c_str());
+ if (return_value != 0) {
+throw PythonScriptException(fmt::format("The following command
creating python virtual env failed: '{}'", venv_command));
+ }
+}
+ }
+}
+
+void installPythonPackagesIfRequested(const std::shared_ptr
, const std::shared_ptr& logger) {
+ std::string automatic_install_str;
+ if (!PythonConfigState::getInstance().isPackageInstallationNeeded()) {
+return;
+ }
+ auto requirement_file_paths = getRequirementsFilePaths(configuration);
+ for (const auto& requirements_file_path : requirement_file_paths) {
+logger->log_info("Installing python packages from the following
requirements.txt file: {}", requirements_file_path.string());
+std::string pip_command;
+#if WIN32
+
pip_command.append("\"").append((PythonConfigState::getInstance().virtualenv_path
/ "Scripts" / "activate.bat").string()).append("\" && ");
+#else
+pip_command.append(".
\"").append((PythonConfigState::getInstance().virtualenv_path / "bin" /
"activate").string()).append("\" && ");
+#endif
+
pip_command.append("\"").append(PythonConfigState::getInstance().python_binary).append("\"
-m pip install --no-cache-dir -r
\"").append(requirements_file_path.string()).append("\"");
+auto return_value =
std::system(encapsulateCommandInQuotesIfNeeded(pip_command).c_str());
Review Comment:
Could you add this explanation into a code comment, maybe above the quoting
function? I had the very same question when reading the code.
##
encrypt-config/tests/ConfigFileEncryptorTests.cpp:
##
@@ -77,7 +77,7 @@ TEST_CASE("ConfigFileEncryptor can encrypt the sensitive
properties", "[encrypt-
uint32_t num_properties_encrypted =
encryptSensitivePropertiesInFile(test_file, KEY);
REQUIRE(num_properties_encrypted == 1);
-REQUIRE(test_file.size() == 110);
+REQUIRE(test_file.size() == 115);
Review Comment:
what's the increase?
##
extensions/python/PythonConfigState.h:
##
@@ -0,0 +1,50 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file
Re: [PR] NIFI-12785 Refactored the InvokeHttp code to avoid double encoding of the entered URL. (Backport fix for support/nifi-1.x) [nifi]
exceptionfactory commented on PR #8459: URL: https://github.com/apache/nifi/pull/8459#issuecomment-1985785277 Merged in https://github.com/apache/nifi/commit/611d268f674a02d22122c030966fbf687bf28019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12785 Refactored the InvokeHttp code to avoid double encoding of the entered URL. (Backport fix for support/nifi-1.x) [nifi]
exceptionfactory closed pull request #8459: NIFI-12785 Refactored the InvokeHttp code to avoid double encoding of the entered URL. (Backport fix for support/nifi-1.x) URL: https://github.com/apache/nifi/pull/8459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12785) InvokeHTTP handler should not urlencode HTTP URL
[ https://issues.apache.org/jira/browse/NIFI-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824804#comment-17824804 ] ASF subversion and git services commented on NIFI-12785: Commit 611d268f674a02d22122c030966fbf687bf28019 in nifi's branch refs/heads/support/nifi-1.x from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=611d268f67 ] NIFI-12785 Corrected InvokeHTTP URL handling to avoid double encoding This closes #8459 Signed-off-by: David Handermann > InvokeHTTP handler should not urlencode HTTP URL > > > Key: NIFI-12785 > URL: https://issues.apache.org/jira/browse/NIFI-12785 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.25.0, 2.0.0-M2 > Environment: AlmaLinux 8.9 Kernel 4.18.0-513.5.1.el8_9.x86_64 > Apache NiFi 2.0.0-M2 >Reporter: macdoor615 >Assignee: Daniel Stieglitz >Priority: Major > Attachments: M1-output.png, M2-output.png > > Time Spent: 2.5h > Remaining Estimate: 0h > > InvokeHTTP processor call HTTP URL > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%2Fstage%2F15m%2Fheshangwuzhibo.yaml/raw?ref=main] > output attribute > invokehttp.request.url: > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%252Fstage%252F15m%252Fheshangwuzhibo.yaml/raw?ref=main] > > invokehttp.status.code: 404 > > The situation is different for version 2.0.0-M1, output attribute > invokehttp.request.url: > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%2Fstage%2F15m%2Fheshangwuzhibo.yaml/raw?ref=main] > > invokehttp.status.code: 200 > > I found that in the M2 version % symbol was urlencoded to %25, M1 version. > The M1 version does not urlencode > > pls refer to the uploaded pictures -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12785) InvokeHTTP handler should not urlencode HTTP URL
[ https://issues.apache.org/jira/browse/NIFI-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824803#comment-17824803 ] ASF subversion and git services commented on NIFI-12785: Commit 942d13c118be59cb360f7e334c87c0897da8e3fb in nifi's branch refs/heads/main from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=942d13c118 ] NIFI-12785 Corrected InvokeHTTP URL handling to avoid double encoding This closes #8458 Signed-off-by: David Handermann > InvokeHTTP handler should not urlencode HTTP URL > > > Key: NIFI-12785 > URL: https://issues.apache.org/jira/browse/NIFI-12785 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.25.0, 2.0.0-M2 > Environment: AlmaLinux 8.9 Kernel 4.18.0-513.5.1.el8_9.x86_64 > Apache NiFi 2.0.0-M2 >Reporter: macdoor615 >Assignee: Daniel Stieglitz >Priority: Major > Attachments: M1-output.png, M2-output.png > > Time Spent: 2.5h > Remaining Estimate: 0h > > InvokeHTTP processor call HTTP URL > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%2Fstage%2F15m%2Fheshangwuzhibo.yaml/raw?ref=main] > output attribute > invokehttp.request.url: > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%252Fstage%252F15m%252Fheshangwuzhibo.yaml/raw?ref=main] > > invokehttp.status.code: 404 > > The situation is different for version 2.0.0-M1, output attribute > invokehttp.request.url: > [http://hb3-ifz-gitlab-000:8100/gitlab/api/v4/projects/318/repository/files/ftp%2Fstage%2F15m%2Fheshangwuzhibo.yaml/raw?ref=main] > > invokehttp.status.code: 200 > > I found that in the M2 version % symbol was urlencoded to %25, M1 version. > The M1 version does not urlencode > > pls refer to the uploaded pictures -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL. [nifi]
exceptionfactory closed pull request #8458: NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL. URL: https://github.com/apache/nifi/pull/8458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2313 Fix Grafana Loki issues on Windows [nifi-minifi-cpp]
szaszm commented on code in PR #1742:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1742#discussion_r1517767087
##
extensions/grafana-loki/tests/CMakeLists.txt:
##
@@ -38,6 +40,9 @@ FOREACH(testfile ${GRAFANA_LOKI_TESTS})
createTests("${testfilename}")
target_link_libraries(${testfilename} Catch2WithMain)
target_link_libraries(${testfilename} minifi-grafana-loki)
+if (WIN32)
+target_wholearchive_library(${testfilename} grafana-loki-protos)
+endif()
Review Comment:
What were the missing symbols? I also don't fully understand why it's a
runtime issue.
In general, "wholearchive" linking is a workaround for some underlying
issue, I think we should at least make an attempt to do a proper fix, instead
of just leaving all unused symbols in the library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2310) Extend ListenTCP with new ways to delimit flow files
[ https://issues.apache.org/jira/browse/MINIFICPP-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2310: Summary: Extend ListenTCP with new ways to delimit flow files (was: Extend ListenTCP by new ways to delimit flow files) > Extend ListenTCP with new ways to delimit flow files > > > Key: MINIFICPP-2310 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2310 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Marton Szasz >Priority: Major > > * custom message delimiter > * option to separate by connection (no delimiter, only optional size limit) > * batching multiple messages to 1 flow file (like NiFi 'Max Batch Size') -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MINIFICPP-2313 Fix Grafana Loki issues on Windows [nifi-minifi-cpp]
lordgamez opened a new pull request, #1742: URL: https://github.com/apache/nifi-minifi-cpp/pull/1742 Includes build fixes from https://github.com/apache/nifi-minifi-cpp/pull/1681 Even though the generated cpp files were compiled as part of the `minifi-grafana-loki` library, linking it to the Loki grpc test suite was not enough on Windows for the grpc test server. Some symbols used by the test server were probalby missing which caused a malformed message returned to the client that resulted in a segmentation fault. Linking the library built from the generated protocol files with `wholearchive` solves this issue. https://issues.apache.org/jira/browse/MINIFICPP-2313 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2313) Grafana Loki build fails and grpc test crashes on Windows
[ https://issues.apache.org/jira/browse/MINIFICPP-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2313: - Description: Grafana Loki build fails on Windows, which we did not realize earlier as the windows build batch file does not turn the Loki build flag on, so it was missing in the CI build as well. PushGrafanaLokiGrpcTest crashes with segmentation fault in the grpc library when run on Windows. was:PushGrafanaLokiGrpcTest crashes with segmentation fault in the grpc library when run on Windows. > Grafana Loki build fails and grpc test crashes on Windows > - > > Key: MINIFICPP-2313 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2313 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > > Grafana Loki build fails on Windows, which we did not realize earlier as the > windows build batch file does not turn the Loki build flag on, so it was > missing in the CI build as well. > PushGrafanaLokiGrpcTest crashes with segmentation fault in the grpc library > when run on Windows. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2313) Grafana Loki build fails and grpc test crashes on Windows
[ https://issues.apache.org/jira/browse/MINIFICPP-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2313: - Summary: Grafana Loki build fails and grpc test crashes on Windows (was: PushGrafanaLokiGrpcTest crashes on Windows) > Grafana Loki build fails and grpc test crashes on Windows > - > > Key: MINIFICPP-2313 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2313 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > > PushGrafanaLokiGrpcTest crashes with segmentation fault in the grpc library > when run on Windows. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12876) Update Maven Surefire Plugin to 3.2.5
[ https://issues.apache.org/jira/browse/NIFI-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824713#comment-17824713 ] ASF subversion and git services commented on NIFI-12876: Commit 1a26ad885852008e0aa38d99b23ee1527aaefe28 in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1a26ad8858 ] NIFI-12876 Upgraded Surefire Plugin from 3.1.2 to 3.2.5 Signed-off-by: Pierre Villard This closes #8483. > Update Maven Surefire Plugin to 3.2.5 > - > > Key: NIFI-12876 > URL: https://issues.apache.org/jira/browse/NIFI-12876 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 20m > Remaining Estimate: 0h > > The Maven Surefire Plugin for unit test execution should be upgraded to > [3.2.5|https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12354100] > to incorporate recent bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12876) Update Maven Surefire Plugin to 3.2.5
[ https://issues.apache.org/jira/browse/NIFI-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12876: -- Fix Version/s: 2.0.0 1.26.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Update Maven Surefire Plugin to 3.2.5 > - > > Key: NIFI-12876 > URL: https://issues.apache.org/jira/browse/NIFI-12876 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Fix For: 2.0.0, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The Maven Surefire Plugin for unit test execution should be upgraded to > [3.2.5|https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12354100] > to incorporate recent bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12876) Update Maven Surefire Plugin to 3.2.5
[ https://issues.apache.org/jira/browse/NIFI-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824711#comment-17824711 ] ASF subversion and git services commented on NIFI-12876: Commit df524b18b1372193e3021c1ae04820895d66a8af in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=df524b18b1 ] NIFI-12876 Upgraded Surefire Plugin from 3.1.2 to 3.2.5 Signed-off-by: Pierre Villard This closes #8483. > Update Maven Surefire Plugin to 3.2.5 > - > > Key: NIFI-12876 > URL: https://issues.apache.org/jira/browse/NIFI-12876 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > The Maven Surefire Plugin for unit test execution should be upgraded to > [3.2.5|https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12354100] > to incorporate recent bug fixes and improvements. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12503 Render from-data in swagger.json and RestAPI docs correctly [nifi]
EndzeitBegins opened a new pull request, #8485: URL: https://github.com/apache/nifi/pull/8485 # Summary Applies the workaround described in [swagger-maven-plugin#352](https://github.com/kongchen/swagger-maven-plugin/issues/352#issuecomment-244225312) to include form-data parameters in the generated swagger.json and the rendered RestAPI documentation for the 1.x branch. [NIFI-12503](https://issues.apache.org/jira/browse/NIFI-12503) Due to changes to the OpenAPI spec generation incorporated into the 2.x branch, this workaround seems to no longer be needed there. At least the documentation looks correct already. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12876 Upgrade Surefire Plugin from 3.1.2 to 3.2.5 [nifi]
asfgit closed pull request #8483: NIFI-12876 Upgrade Surefire Plugin from 3.1.2 to 3.2.5 URL: https://github.com/apache/nifi/pull/8483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12874) Upgrade Log4j 2 to 2.23.0
[ https://issues.apache.org/jira/browse/NIFI-12874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824707#comment-17824707 ] ASF subversion and git services commented on NIFI-12874: Commit 7ddee361e7a673740c5029d0677288ff5407b183 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7ddee361e7 ] NIFI-12874 Upgraded Log4j from 2.20.0 to 2.23.0 Signed-off-by: Pierre Villard This closes #8482. > Upgrade Log4j 2 to 2.23.0 > - > > Key: NIFI-12874 > URL: https://issues.apache.org/jira/browse/NIFI-12874 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Fix For: 2.0.0, 1.26.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Apache Log4j 2 dependencies should be upgraded to > [2.23.0|https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-23-0] > to align with the currently available version. Log4j 2 dependencies are > limited to API dependencies from several extension components. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12874 Upgrade Log4j from 2.20.0 to 2.23.0 [nifi]
asfgit closed pull request #8482: NIFI-12874 Upgrade Log4j from 2.20.0 to 2.23.0 URL: https://github.com/apache/nifi/pull/8482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12874) Upgrade Log4j 2 to 2.23.0
[ https://issues.apache.org/jira/browse/NIFI-12874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824704#comment-17824704 ] ASF subversion and git services commented on NIFI-12874: Commit 34055b185245d78c83bce2203806ade0440aed8a in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=34055b1852 ] NIFI-12874 Upgraded Log4j from 2.20.0 to 2.23.0 Signed-off-by: Pierre Villard This closes #8482. > Upgrade Log4j 2 to 2.23.0 > - > > Key: NIFI-12874 > URL: https://issues.apache.org/jira/browse/NIFI-12874 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > Apache Log4j 2 dependencies should be upgraded to > [2.23.0|https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-23-0] > to align with the currently available version. Log4j 2 dependencies are > limited to API dependencies from several extension components. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12874) Upgrade Log4j 2 to 2.23.0
[ https://issues.apache.org/jira/browse/NIFI-12874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12874: -- Fix Version/s: 2.0.0 1.26.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Log4j 2 to 2.23.0 > - > > Key: NIFI-12874 > URL: https://issues.apache.org/jira/browse/NIFI-12874 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Fix For: 2.0.0, 1.26.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Apache Log4j 2 dependencies should be upgraded to > [2.23.0|https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-23-0] > to align with the currently available version. Log4j 2 dependencies are > limited to API dependencies from several extension components. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:42 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
-I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.-
The documentation is broken in the most recent release version for 1.x which is
1.25.0.
However, it was broken already for:
-
[1.24.0|https://web.archive.org/web/20231208064943/https://nifi.apache.org/docs.html]
-
[1.23.2|https://web.archive.org/web/20231106213006/https://nifi.apache.org/docs.html]
- ...
-
[1.19.1|https://web.archive.org/web/20230315024356/https://nifi.apache.org/docs.html]
- ...
-
[1.14.0|https://web.archive.org/web/20211021223339/https://nifi.apache.org/docs.html]
-
[1.13.2|https://web.archive.org/web/20201004172411/http://nifi.apache.org/docs.html]
-
[1.10.0|https://web.archive.org/web/20190906190320/http://nifi.apache.org:80/docs.html]
*Looking at the documentation of all these older version of NiFi in Wayback
Machine, it looks like this never worked in the first place.*
It looks like the issue might stem from the Maven plugin used for the spec
generation, see [issue
#352|https://github.com/kongchen/swagger-maven-plugin/issues/352] in the
project. As outlined in the issue, there is a workaround that involves
declaring the param a second time as {{@ApiImplicitParam}} which seems to work,
as the only form parameter visible in the documentation for
{{/process-groups/id/templates/upload}} has this declared.
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required"
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:42 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
-I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.-
The documentation is broken in the most recent release version for 1.x which is
1.25.0.
However, it was broken already for:
-
[1.24.0|https://web.archive.org/web/20231208064943/https://nifi.apache.org/docs.html]
-
[1.23.2|https://web.archive.org/web/20231106213006/https://nifi.apache.org/docs.html]
- ...
-
[1.19.1|https://web.archive.org/web/20230315024356/https://nifi.apache.org/docs.html]
- ...
-
[1.14.0|https://web.archive.org/web/20211021223339/https://nifi.apache.org/docs.html]
-
[1.13.2|https://web.archive.org/web/20201004172411/http://nifi.apache.org/docs.html]
-
[1.10.0|https://web.archive.org/web/20190906190320/http://nifi.apache.org:80/docs.html]
*Looking at the documentation of all these older version of NiFi in Wayback
Machine, it looks like this never worked in the first place.*
It looks like the issue might stem from the Maven plugin used for the spec
generation, see [issue
#352|https://github.com/kongchen/swagger-maven-plugin/issues/352] in the
project. As outlined in the issue, there is a workaround that involves
declaring the param a second time as {{@ApiImplicitParam}} which seems to work,
as the only form parameter visible in the documentation for
{{/process-groups/{id}/templates/upload}} has this declared.
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:39 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
-I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.-
The documentation is broken in the most recent release version for 1.x which is
1.25.0.
However, it was broken already for:
-
[1.24.0|https://web.archive.org/web/20231208064943/https://nifi.apache.org/docs.html]
-
[1.23.2|https://web.archive.org/web/20231106213006/https://nifi.apache.org/docs.html]
- ...
-
[1.19.1|https://web.archive.org/web/20230315024356/https://nifi.apache.org/docs.html]
- ...
-
[1.14.0|https://web.archive.org/web/20211021223339/https://nifi.apache.org/docs.html]
-
[1.13.2|https://web.archive.org/web/20201004172411/http://nifi.apache.org/docs.html]
-
[1.10.0|https://web.archive.org/web/20190906190320/http://nifi.apache.org:80/docs.html]
*Looking at the documentation of all these older version of NiFi in Wayback
Machine, it looks like this never worked in the first place.*
It looks like the issue might stem from the Maven plugin used for the spec
generation, see [issue
#352|https://github.com/kongchen/swagger-maven-plugin/issues/352] in the
project.
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:30 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
-I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.-
The documentation is broken in the most recent release version for 1.x which is
1.25.0.
However, it was broken already for:
-
[1.24.0|https://web.archive.org/web/20231208064943/https://nifi.apache.org/docs.html]
-
[1.23.2|https://web.archive.org/web/20231106213006/https://nifi.apache.org/docs.html]
- ...
-
[1.19.1|https://web.archive.org/web/20230315024356/https://nifi.apache.org/docs.html]
- ...
-
[1.14.0|https://web.archive.org/web/20211021223339/https://nifi.apache.org/docs.html]
-
[1.13.2|https://web.archive.org/web/20201004172411/http://nifi.apache.org/docs.html]
-
[1.10.0|https://web.archive.org/web/20190906190320/http://nifi.apache.org:80/docs.html]
*Looking at the documentation of all these older version of NiFi in Wayback
Machine, it looks like this never worked in the first place.*
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:28 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.*
The documentation is broken in the most recent release version for 1.x which is
1.25.0.
However, it was broken already for:
-
[1.24.0|https://web.archive.org/web/20231208064943/https://nifi.apache.org/docs.html]
-
[1.23.2|https://web.archive.org/web/20231106213006/https://nifi.apache.org/docs.html]
- ...
-
[1.19.1|https://web.archive.org/web/20230315024356/https://nifi.apache.org/docs.html]
- ...
-
[1.14.0|https://web.archive.org/web/20211021223339/https://nifi.apache.org/docs.html]
-
[1.13.2|https://web.archive.org/web/20201004172411/http://nifi.apache.org/docs.html]
-
[1.10.0|https://web.archive.org/web/20190906190320/http://nifi.apache.org:80/docs.html]
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:27 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.*
The documentation is broken in the most recent release version for 1.x which is
1.25.0.
However, it was broken already for:
-
[1.24.0|https://web.archive.org/web/20231208064943/https://nifi.apache.org/docs.html]
-
[1.23.2|https://web.archive.org/web/20231106213006/https://nifi.apache.org/docs.html]
- ...
-
[1.19.1|https://web.archive.org/web/20230315024356/https://nifi.apache.org/docs.html]
- ...
-
[1.14.0|https://web.archive.org/web/20211021223339/https://nifi.apache.org/docs.html]
-
[1.13.2|https://web.archive.org/web/20201004172411/http://nifi.apache.org/docs.html]
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:26 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.*
The documentation is broken in the most recent release version for 1.x which is
1.25.0.
However, it was broken already for:
-
[1.24.0|https://web.archive.org/web/20231208064943/https://nifi.apache.org/docs.html]
-
[1.23.2|https://web.archive.org/web/20231106213006/https://nifi.apache.org/docs.html]
- ...
-
[1.19.1|https://web.archive.org/web/20230315024356/https://nifi.apache.org/docs.html]
- ...
-
[1.14.0|https://web.archive.org/web/20211021223339/https://nifi.apache.org/docs.html]
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:23 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.*
The documentation is broken in the most recent release version for 1.x which is
1.25.0.
However, it was broken already for:
-
[1.24.0|https://web.archive.org/web/20231208064943/https://nifi.apache.org/docs.html]
-
[1.23.2|https://web.archive.org/web/20231106213006/https://nifi.apache.org/docs.html]
- ...
-
[1.19.1|https://web.archive.org/web/20230315024356/https://nifi.apache.org/docs.html]
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:22 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.*
The documentation is broken in the most recent release version for 1.x which is
1.25.0.
However, it was broken already for:
-
[1.24.0|https://web.archive.org/web/20231208064943/https://nifi.apache.org/docs.html]
- [1.23.2
|https://web.archive.org/web/20231106213006/https://nifi.apache.org/docs.html]
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:20 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.*
The documentation is broken in the most recent release version for 1.x which is
1.25.0.
However, it was broken already for:
-
[1.24.0|https://web.archive.org/web/20231208064943/https://nifi.apache.org/docs.html]
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.*
> Missing
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:16 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger itself, introduced into NiFi
by using a newer version, a new Swagger version requiring a different type of
declaration or a change in the generation procedure of NiFi itself.*
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger Codegen itself, introduced
into NiFi by using a newer version, a new Codegen version requiring a different
type of declaration or a change in the generation procedure of NiFi itself.*
> Missing Documentation for nifi-api
> --
>
> Key: NIFI-12503
> URL: https://issues.apache.org/jira/browse/NIFI-12503
> Project: Apache NiFi
>
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:13 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
*I suspect there is either an issue in the Swagger Codegen itself, introduced
into NiFi by using a newer version, a new Codegen version requiring a different
type of declaration or a change in the generation procedure of NiFi itself.*
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
> Missing Documentation for nifi-api
> --
>
> Key: NIFI-12503
> URL: https://issues.apache.org/jira/browse/NIFI-12503
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0
>Reporter: Steven Matison
>Assignee: endzeit
>Priority: Minor
> Attachments: SAMSAL_0-1701894321710.png
>
>
> Community user
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:11 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code:java}
/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{code:java}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ... {code}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code}/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{{code}}"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ...{{code}}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
> Missing Documentation for nifi-api
> --
>
> Key: NIFI-12503
> URL: https://issues.apache.org/jira/browse/NIFI-12503
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0
>Reporter: Steven Matison
>Assignee: endzeit
>Priority: Minor
> Attachments: SAMSAL_0-1701894321710.png
>
>
> Community user has noticed that nifi-api docs are missing required request
> values. One such example is groupName on the api call for uploading
> process-groups:
> /process-groups/upload
>
>
> More dialouge and original conversation here:
>
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:10 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code}/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{{code}}"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ...{{code}}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code}/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{{code}}"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ...
{{code}}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
> Missing Documentation for nifi-api
> --
>
> Key: NIFI-12503
> URL: https://issues.apache.org/jira/browse/NIFI-12503
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0
>Reporter: Steven Matison
>Assignee: endzeit
>Priority: Minor
> Attachments: SAMSAL_0-1701894321710.png
>
>
> Community user has noticed that nifi-api docs are missing required request
> values. One such example is groupName on the api call for uploading
> process-groups:
> /process-groups/upload
>
>
> More dialouge and original conversation here:
>
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:10 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code}/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{{code}}"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ...
{{code}}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code}/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{{code}}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ...
{{code}}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
> Missing Documentation for nifi-api
> --
>
> Key: NIFI-12503
> URL: https://issues.apache.org/jira/browse/NIFI-12503
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0
>Reporter: Steven Matison
>Assignee: endzeit
>Priority: Minor
> Attachments: SAMSAL_0-1701894321710.png
>
>
> Community user has noticed that nifi-api docs are missing required request
> values. One such example is groupName on the api call for uploading
> process-groups:
> /process-groups/upload
>
>
> More dialouge and original conversation here:
>
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:09 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code}/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
{{code}}
"/process-groups/{id}/templates/upload" : {
"post" : {
"tags" : [ "process-groups" ],
"summary" : "Uploads a template",
"description" : "",
"operationId" : "uploadTemplate",
"consumes" : [ "multipart/form-data" ],
"produces" : [ "application/xml" ],
"parameters" : [ {
"name" : "id",
"in" : "path",
"description" : "The process group id.",
"required" : true,
"type" : "string"
}, {
"in" : "body",
"name" : "body",
"description" : "Acknowledges that this node is disconnected to allow
for mutable requests to proceed.",
"required" : false,
"schema" : {
"type" : "boolean"
}
}, {
"name" : "template",
"in" : "formData",
"description" : "The binary content of the template file being
uploaded.",
"required" : true,
"type" : "file"
} ],
"responses" : ...
{{code}}
The declaration side of the endpoints in
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java}}
looks fine and has not changed for a long time.
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code}/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
> Missing Documentation for nifi-api
> --
>
> Key: NIFI-12503
> URL: https://issues.apache.org/jira/browse/NIFI-12503
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0
>Reporter: Steven Matison
>Assignee: endzeit
>Priority: Minor
> Attachments: SAMSAL_0-1701894321710.png
>
>
> Community user has noticed that nifi-api docs are missing required request
> values. One such example is groupName on the api call for uploading
> process-groups:
> /process-groups/upload
>
>
> More dialouge and original conversation here:
> [https://community.cloudera.com/t5/Support-Questions/NIFI-API-REST-Upload-Json-definition-flow-file/m-p/380384#M244057]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 9:04 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code}/process-groups/{id}/templates/upload Uploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
This issue can be seen in the generated {{swagger.json}} under
{{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/target/swagger-ui}}
already, thus is not an issue of the rendered documentation itself.
was (Author: endzeitbegins):
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code}/process-groups/{id}/templates/uploadUploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
> Missing Documentation for nifi-api
> --
>
> Key: NIFI-12503
> URL: https://issues.apache.org/jira/browse/NIFI-12503
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0
>Reporter: Steven Matison
>Assignee: endzeit
>Priority: Minor
> Attachments: SAMSAL_0-1701894321710.png
>
>
> Community user has noticed that nifi-api docs are missing required request
> values. One such example is groupName on the api call for uploading
> process-groups:
> /process-groups/upload
>
>
> More dialouge and original conversation here:
> [https://community.cloudera.com/t5/Support-Questions/NIFI-API-REST-Upload-Json-definition-flow-file/m-p/380384#M244057]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12503) Missing Documentation for nifi-api
[
https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657
]
endzeit edited comment on NIFI-12503 at 3/8/24 8:57 AM:
The latest commit version of 2.x seems to not he affected.
This issue seems to only exist on the 1.x branch.
It affects other endpoint that use multipart/form-data as well, e.g.
{code}/process-groups/{id}/templates/uploadUploads a template{code}
Here only one of the two form-data parameters is displayed correctly, the other
one is displayed without name and said to be expected in the body, instead of
as part of the form-data; similar to the endpoint mentioned in the issue itself.
was (Author: endzeitbegins):
This issue seems to only exist on the 1.x branch.
The latest commit version of 2.x seems to not he affected.
> Missing Documentation for nifi-api
> --
>
> Key: NIFI-12503
> URL: https://issues.apache.org/jira/browse/NIFI-12503
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0
>Reporter: Steven Matison
>Assignee: endzeit
>Priority: Minor
> Attachments: SAMSAL_0-1701894321710.png
>
>
> Community user has noticed that nifi-api docs are missing required request
> values. One such example is groupName on the api call for uploading
> process-groups:
> /process-groups/upload
>
>
> More dialouge and original conversation here:
> [https://community.cloudera.com/t5/Support-Questions/NIFI-API-REST-Upload-Json-definition-flow-file/m-p/380384#M244057]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12877) RestLookupService - supports Sensitive Dynamic Properties
[ https://issues.apache.org/jira/browse/NIFI-12877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman updated NIFI-12877: - Priority: Major (was: Minor) > RestLookupService - supports Sensitive Dynamic Properties > - > > Key: NIFI-12877 > URL: https://issues.apache.org/jira/browse/NIFI-12877 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M2 >Reporter: Roman >Priority: Major > > The RestLookupService service does not provide the possibility to support > Sensitive Dynamic Properties: Yes. > When we add a header in InvokeHTTP processor we can set "Sensitive Value" > Yes/No, however during adding dynamic values (tokens) in RestLookupService > there is no way to make it sensitive it is grayed out. > Desired improvement: > RestLookupService > *Dynamic Properties:* > Supports Sensitive Dynamic Properties: *Yes* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12877) RestLookupService - supports Sensitive Dynamic Properties
Roman created NIFI-12877: Summary: RestLookupService - supports Sensitive Dynamic Properties Key: NIFI-12877 URL: https://issues.apache.org/jira/browse/NIFI-12877 Project: Apache NiFi Issue Type: Improvement Affects Versions: 2.0.0-M2 Reporter: Roman The RestLookupService service does not provide the possibility to support Sensitive Dynamic Properties: Yes. When we add a header in InvokeHTTP processor we can set "Sensitive Value" Yes/No, however during adding dynamic values (tokens) in RestLookupService there is no way to make it sensitive it is grayed out. Desired improvement: RestLookupService *Dynamic Properties:* Supports Sensitive Dynamic Properties: *Yes* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2313) PushGrafanaLokiGrpcTest crashes on Windows
Gábor Gyimesi created MINIFICPP-2313: Summary: PushGrafanaLokiGrpcTest crashes on Windows Key: MINIFICPP-2313 URL: https://issues.apache.org/jira/browse/MINIFICPP-2313 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi PushGrafanaLokiGrpcTest crashes with segmentation fault in the grpc library when run on Windows. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12503) Missing Documentation for nifi-api
[ https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] endzeit updated NIFI-12503: --- Affects Version/s: 1.25.0 > Missing Documentation for nifi-api > -- > > Key: NIFI-12503 > URL: https://issues.apache.org/jira/browse/NIFI-12503 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.25.0 >Reporter: Steven Matison >Assignee: endzeit >Priority: Minor > Attachments: SAMSAL_0-1701894321710.png > > > Community user has noticed that nifi-api docs are missing required request > values. One such example is groupName on the api call for uploading > process-groups: > /process-groups/upload > > > More dialouge and original conversation here: > [https://community.cloudera.com/t5/Support-Questions/NIFI-API-REST-Upload-Json-definition-flow-file/m-p/380384#M244057] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12503) Missing Documentation for nifi-api
[ https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824657#comment-17824657 ] endzeit commented on NIFI-12503: This issue seems to only exist on the 1.x branch. The latest commit version of 2.x seems to not he affected. > Missing Documentation for nifi-api > -- > > Key: NIFI-12503 > URL: https://issues.apache.org/jira/browse/NIFI-12503 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Steven Matison >Assignee: endzeit >Priority: Minor > Attachments: SAMSAL_0-1701894321710.png > > > Community user has noticed that nifi-api docs are missing required request > values. One such example is groupName on the api call for uploading > process-groups: > /process-groups/upload > > > More dialouge and original conversation here: > [https://community.cloudera.com/t5/Support-Questions/NIFI-API-REST-Upload-Json-definition-flow-file/m-p/380384#M244057] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-12503) Missing Documentation for nifi-api
[ https://issues.apache.org/jira/browse/NIFI-12503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] endzeit reassigned NIFI-12503: -- Assignee: endzeit > Missing Documentation for nifi-api > -- > > Key: NIFI-12503 > URL: https://issues.apache.org/jira/browse/NIFI-12503 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Steven Matison >Assignee: endzeit >Priority: Minor > Attachments: SAMSAL_0-1701894321710.png > > > Community user has noticed that nifi-api docs are missing required request > values. One such example is groupName on the api call for uploading > process-groups: > /process-groups/upload > > > More dialouge and original conversation here: > [https://community.cloudera.com/t5/Support-Questions/NIFI-API-REST-Upload-Json-definition-flow-file/m-p/380384#M244057] -- This message was sent by Atlassian Jira (v8.20.10#820010)
