[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated MINIFICPP-2346:
Description:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
Here is my draft PR for this Jira Ticket for your reference:
[https://github.com/apache/nifi-minifi-cpp/pull/1775]
* I have added *abseil* external lib dependency to conanfile.py and integrated
it into Abseil.cmake with conditional statement that checks if
USE_CONAN_PACKAGER minifi cpp option is true else checks if
USE_CMAKE_FETCH_CONTENT option is true for backward compatibility, so we can
began the process of integrating in conan version 2.
Here are the commands that I run:
{code:java}
cd $HOME/src/pipeline/nifi-minifi-cpp
# NOTE: I also plan to add smoother integration of conan commands into MiNiFI
CPP too
# For instance, I know you guys have your bootstrap scripts too
# You also have your github actions workflow scripts too
conan install . --output-folder=build
-pr=$HOME/src/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
cd build/
cmake ..
make -j $(nproc){code}
Tracking Prebuilt Binary Conan Packages Available on Conancenter:
* 'abseil/20230125.3',
* 'argparse/3.0',
* 'asio/1.30.2'
Tracking Conan Packages Not Available on Conancenter, so we need to use an
alternative hosting service to manage building package sources into prebuilt
binary conan packages. Here are some of the free conan hosting services for
open-source C/C++ projects:
* {*}Conan Center Index (CCI){*}: official, free, centralized repo for conan
packages maintained by conan team
* Bincrafters Bintray Repo: community-driven repo that hosts large number of
pre-built conan packages for open-source libraries for free
* Artifactory by JFrog: typically used as a commercial hosting service, but
also provides a free tier for open-source projects.
* {*}Self-Hosting{*}: While there are multiple options, I will focus on
*GitHub Packages* as its a free package hosting service, which can be used to
host our own conan package repos, allowing
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated MINIFICPP-2346:
Description:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
Here is my draft PR for this Jira Ticket for your reference:
[https://github.com/apache/nifi-minifi-cpp/pull/1775]
* I have added *abseil* external lib dependency to conanfile.py and integrated
it into Abseil.cmake with conditional statement that checks if
USE_CONAN_PACKAGER minifi cpp option is true else checks if
USE_CMAKE_FETCH_CONTENT option is true for backward compatibility, so we can
began the process of integrating in conan version 2.
Here are the commands that I run:
{code:java}
cd $HOME/src/pipeline/nifi-minifi-cpp
# NOTE: I also plan to add smoother integration of conan commands into MiNiFI
CPP too
# For instance, I know you guys have your bootstrap scripts too
# You also have your github actions workflow scripts too
conan install . --output-folder=build
-pr=$HOME/src/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
cd build/
cmake ..
make -j $(nproc){code}
Tracking Prebuilt Binary Conan Packages Available on Conancenter:
* 'abseil/20230125.3',
* 'argparse/3.0',
* 'asio/1.30.2'
Tracking Conan Packages Not Available on Conancenter, so we need to use an
alternative hosting service to manage building package sources into prebuilt
binary conan packages. Here are some of the free conan hosting services for
open-source C/C++ projects:
* {*}Conan Center Index (CCI){*}: official, free, centralized repo for conan
packages maintained by conan team
* Bincrafters Bintray Repo: community-driven repo that hosts large number of
pre-built conan packages for open-source libraries for free
* Artifactory by JFrog: typically used as a commercial hosting service, but
also provides a free tier for open-source projects.
* {*}Self-Hosting{*}: While there are multiple options, I will focus on
*GitHub Packages* as its a free package hosting service, which can be used to
host our own conan package repos, allowing
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated MINIFICPP-2346:
Description:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
Here is my draft PR for this Jira Ticket for your reference:
[https://github.com/apache/nifi-minifi-cpp/pull/1775]
* I have added *abseil* external lib dependency to conanfile.py and integrated
it into Abseil.cmake with conditional statement that checks if
USE_CONAN_PACKAGER minifi cpp option is true else checks if
USE_CMAKE_FETCH_CONTENT option is true for backward compatibility, so we can
began the process of integrating in conan version 2.
Here are the commands that I run:
{code:java}
cd $HOME/src/pipeline/nifi-minifi-cpp
# NOTE: I also plan to add smoother integration of conan commands into MiNiFI
CPP too
# For instance, I know you guys have your bootstrap scripts too
# You also have your github actions workflow scripts too
conan install . --output-folder=build
-pr=$HOME/src/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
cd build/
cmake ..
make -j $(nproc){code}
was:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows.
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated MINIFICPP-2346:
Description:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
Here is my draft PR for this Jira Ticket for your reference:
[https://github.com/apache/nifi-minifi-cpp/pull/1775]
* I have added *abseil* external lib dependency to conanfile.py and integrated
it into Abseil.cmake with conditional statement that checks if
USE_CONAN_PACKAGER minifi cpp option is true else checks if
USE_CMAKE_FETCH_CONTENT option is true for backward compatibility, so we can
began the process of integrating in conan version 2.
was:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these
Re: [PR] [NIFI-13093] use warn palette for all errors and introduce caution palette [nifi]
scottyaslan commented on code in PR #8721:
URL: https://github.com/apache/nifi/pull/8721#discussion_r1586895561
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.ts:
##
@@ -148,7 +148,7 @@ export class BulletinBoardList implements AfterViewInit {
case 'warning':
return 'bulletin-warn';
Review Comment:
No. Bulletins have a `.bulletin-error` state that is red. This is correct. I
updated it to use the semantic `.caution-color` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] MINIFICPP-2346: Switch to C++ Conan Packager to Replace CMake FetchContent for Faster MiNiFi CPP Builds [nifi-minifi-cpp]
james94 opened a new pull request, #1775: URL: https://github.com/apache/nifi-minifi-cpp/pull/1775 Also kept backward compatibility for cmake FetchContent by adding two MiNiFi CPP options: one for using CMake FetchContent and the other for using the more faster approach conan packager to manage C++ external lib dependencies. With conan, usually conan will install prebuilt binary conan packages from conancenter or some other conan repo where the prebuilt binary conan packages reside. For now, we'll stick with using conancenter as it is open source. Verified I can run conan install command from MiNiFi root folder where conanfile.py resides and successfully install abseil prebuilt binary conan package for MiNiFi C++, then ran cmake generate from MiNiFi's build folder and then started to run make. Stopped early on make since MiNiFi would try to download and build all the remaining external lib dependencies with CMake FetchContent since they arent managed by conan yet. Also in Abseil.cmake's file, I added conditional statement to check if user set the USE_CONAN_PACKAGER option or the USE_CMAKE_FETCH_CONTENT option. Will do similar approach for the remaining external lib dependencies Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13093] use warn palette for all errors and introduce caution palette [nifi]
scottyaslan commented on code in PR #8721:
URL: https://github.com/apache/nifi/pull/8721#discussion_r1586964545
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -261,56 +281,43 @@
//
// NOTE: nifi surface palette lighter/darker is purposefully omitted here.
Any application of nifi surface colors should be as a background-color to a
surface DOM element. The surface color should switch from light to dark
depending on the mode for the theme.
-.nifi-surface-default {
+.surface-color {
color: $nifi-theme-surface-palette-default;
fill: $nifi-theme-surface-palette-default;
}
-.nifi-success-default {
+.success-color {
color: $nifi-theme-success-palette-default;
fill: $nifi-theme-success-palette-default;
}
-.nifi-success-lighter {
+.success-color-lighter {
color: $nifi-theme-success-palette-lighter;
fill: $nifi-theme-success-palette-lighter;
}
-.nifi-success-darker {
+.success-color-darker {
color: $nifi-theme-success-palette-darker;
fill: $nifi-theme-success-palette-darker;
}
-.nifi-warn-default {
-color: $nifi-theme-warn-palette-default;
-fill: $nifi-theme-warn-palette-default;
+.caution-color {
+color: $nifi-theme-caution-palette-default;
+fill: $nifi-theme-caution-palette-default;
Review Comment:
Pretty much any time we need a yellow color it should be the
`.caution-color`. Currently this is used for the `.bulletin-warn` color and
extensively for any `.fa .fa-warning` icons which are used in the `.has-errors`
or `.invalid` status scenarios. The `.caution-color-darker` is used for things
like back pressure, when a connection is selected on the canvas, and midpoints,
bend points, and the label resize handle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13093] use warn palette for all errors and introduce caution palette [nifi]
scottyaslan commented on code in PR #8721:
URL: https://github.com/apache/nifi/pull/8721#discussion_r1586964545
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -261,56 +281,43 @@
//
// NOTE: nifi surface palette lighter/darker is purposefully omitted here.
Any application of nifi surface colors should be as a background-color to a
surface DOM element. The surface color should switch from light to dark
depending on the mode for the theme.
-.nifi-surface-default {
+.surface-color {
color: $nifi-theme-surface-palette-default;
fill: $nifi-theme-surface-palette-default;
}
-.nifi-success-default {
+.success-color {
color: $nifi-theme-success-palette-default;
fill: $nifi-theme-success-palette-default;
}
-.nifi-success-lighter {
+.success-color-lighter {
color: $nifi-theme-success-palette-lighter;
fill: $nifi-theme-success-palette-lighter;
}
-.nifi-success-darker {
+.success-color-darker {
color: $nifi-theme-success-palette-darker;
fill: $nifi-theme-success-palette-darker;
}
-.nifi-warn-default {
-color: $nifi-theme-warn-palette-default;
-fill: $nifi-theme-warn-palette-default;
+.caution-color {
+color: $nifi-theme-caution-palette-default;
+fill: $nifi-theme-caution-palette-default;
Review Comment:
Pretty much any time we need a yellow color it should be the
`.caution-color`. Currently this is used extensively for any `.fa .fa-warning`
icons which are used in the `.has-errors` or `.invalid` status scenarios. The
darker caution color is used for things like back pressure, when a connection
is selected on the canvas, and midpoints, bend points, and the label resize
handle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13093] use warn palette for all errors and introduce caution palette [nifi]
scottyaslan commented on code in PR #8721: URL: https://github.com/apache/nifi/pull/8721#discussion_r1586964629 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/material.scss: ## @@ -50,8 +50,33 @@ $material-primary-light-palette: ( A700: #ff, ) ); + $material-accent-light-palette: mat.$brown-palette; -$warn-light-palette: mat.$red-palette; + +$warn-light-palette: ( +50: #ffebee, +100: #ffccd2, +200: #f4, +300: #eb7071, +400: #f64e4c, +500: #fa3b30, +600: #ec3030, +700: #ff1507, +800: #ff, +900: #ba554a, // g.component rect.border.unauthorized, #connection-full-drop-shadow feFlood, text.restricted, g.connection rect.border.unauthorized, g.connection path.connection-path.full, g.connection path.connection-path.unauthorized, .controller-bulletins.has-bulletins, path.link.selected, g.event circle.selected +contrast: ( +50: rgba(#00, 0.87), +100: rgba(#00, 0.87), +200: rgba(#00, 0.87), +300: rgba(#00, 0.87), +400: #ff, +500: #ff, +600: #ff, +700: #ff, +800: #ff, +900: #ff +) +); Review Comment: Good catch! I have updated this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13093] use warn palette for all errors and introduce caution palette [nifi]
scottyaslan commented on code in PR #8721:
URL: https://github.com/apache/nifi/pull/8721#discussion_r1586964545
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -261,56 +281,43 @@
//
// NOTE: nifi surface palette lighter/darker is purposefully omitted here.
Any application of nifi surface colors should be as a background-color to a
surface DOM element. The surface color should switch from light to dark
depending on the mode for the theme.
-.nifi-surface-default {
+.surface-color {
color: $nifi-theme-surface-palette-default;
fill: $nifi-theme-surface-palette-default;
}
-.nifi-success-default {
+.success-color {
color: $nifi-theme-success-palette-default;
fill: $nifi-theme-success-palette-default;
}
-.nifi-success-lighter {
+.success-color-lighter {
color: $nifi-theme-success-palette-lighter;
fill: $nifi-theme-success-palette-lighter;
}
-.nifi-success-darker {
+.success-color-darker {
color: $nifi-theme-success-palette-darker;
fill: $nifi-theme-success-palette-darker;
}
-.nifi-warn-default {
-color: $nifi-theme-warn-palette-default;
-fill: $nifi-theme-warn-palette-default;
+.caution-color {
+color: $nifi-theme-caution-palette-default;
+fill: $nifi-theme-caution-palette-default;
Review Comment:
Pretty much any time we need a yellow color it should be the caution darker
color. Currently this is used extensively for any `.fa .fa-warning` icons but
it is also used for things like back pressure, when a connection is selected on
the canvas, and midpoint/bendpoints/label resize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
joewitt commented on PR #8463: URL: https://github.com/apache/nifi/pull/8463#issuecomment-2089326292 Can we just drop the old Kafka processors and go all in on the latest release? At this point the client libraries have stabilized greatly and us supporting the older stuff feels far less important and worthwhile now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13093] use warn palette for all errors and introduce caution palette [nifi]
scottyaslan commented on code in PR #8721:
URL: https://github.com/apache/nifi/pull/8721#discussion_r1586895561
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.ts:
##
@@ -148,7 +148,7 @@ export class BulletinBoardList implements AfterViewInit {
case 'warning':
return 'bulletin-warn';
Review Comment:
No. Bulletins have a `.bulletin-error` state that is red. This is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-13103) Enhance AutoCommit property to allow no value set in PutDatabaseRecord
[ https://issues.apache.org/jira/browse/NIFI-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842796#comment-17842796 ] ASF subversion and git services commented on NIFI-13103: Commit 165a174c0a4bdb889907d22804fd8b6e42ecdf9e in nifi's branch refs/heads/support/nifi-1.x from Joe Gresock [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=165a174c0a ] NIFI-13103: Make AutoCommit default to no value set in PutDatabaseRecord Signed-off-by: Joe Gresock This closes #8723 > Enhance AutoCommit property to allow no value set in PutDatabaseRecord > -- > > Key: NIFI-13103 > URL: https://issues.apache.org/jira/browse/NIFI-13103 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Jim Steinebrey >Assignee: Jim Steinebrey >Priority: Minor > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Enhance AutoCommit property to allow value of "No value set" in > PutDatabaseRecord to be consistent with PutSQL processor. No value set (null) > leaves the database connection's autoCommit mode unmodified. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13103) Enhance AutoCommit property to allow no value set in PutDatabaseRecord
[ https://issues.apache.org/jira/browse/NIFI-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Steinebrey updated NIFI-13103: -- Description: Enhance AutoCommit property to allow value of "No value set" in PutDatabaseRecord to be consistent with PutSQL processor. No value set (null) leaves the database connection's autoCommit mode unmodified. (was: Make AutoCommit default to no values set in PutDatabaseRecord so the database connection's autoCommit mode is left unchanged by default. ) > Enhance AutoCommit property to allow no value set in PutDatabaseRecord > -- > > Key: NIFI-13103 > URL: https://issues.apache.org/jira/browse/NIFI-13103 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Jim Steinebrey >Assignee: Jim Steinebrey >Priority: Minor > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Enhance AutoCommit property to allow value of "No value set" in > PutDatabaseRecord to be consistent with PutSQL processor. No value set (null) > leaves the database connection's autoCommit mode unmodified. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13103) Enhance AutoCommit property to allow no value set in PutDatabaseRecord
[ https://issues.apache.org/jira/browse/NIFI-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Steinebrey updated NIFI-13103: -- Summary: Enhance AutoCommit property to allow no value set in PutDatabaseRecord (was: Make AutoCommit default to no value set in PutDatabaseRecord) > Enhance AutoCommit property to allow no value set in PutDatabaseRecord > -- > > Key: NIFI-13103 > URL: https://issues.apache.org/jira/browse/NIFI-13103 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Jim Steinebrey >Assignee: Jim Steinebrey >Priority: Minor > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Make AutoCommit default to no values set in PutDatabaseRecord so the database > connection's autoCommit mode is left unchanged by default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13103) Make AutoCommit default to no value set in PutDatabaseRecord
[ https://issues.apache.org/jira/browse/NIFI-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842782#comment-17842782 ] ASF subversion and git services commented on NIFI-13103: Commit 1d24c080abdf583823933bc99eda3f9b38e7aaab in nifi's branch refs/heads/main from Jim Steinebrey [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1d24c080ab ] NiFiNIFI-13103 Make AutoCommit default to no value set in PutDatabaseRecord. Remove unneeded carriage return. Signed-off-by: Joe Gresock This closes #8723. > Make AutoCommit default to no value set in PutDatabaseRecord > > > Key: NIFI-13103 > URL: https://issues.apache.org/jira/browse/NIFI-13103 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Jim Steinebrey >Assignee: Jim Steinebrey >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Make AutoCommit default to no values set in PutDatabaseRecord so the database > connection's autoCommit mode is left unchanged by default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-13103) Make AutoCommit default to no value set in PutDatabaseRecord
[ https://issues.apache.org/jira/browse/NIFI-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Gresock resolved NIFI-13103. Fix Version/s: 2.0.0-M3 1.26.0 Resolution: Fixed > Make AutoCommit default to no value set in PutDatabaseRecord > > > Key: NIFI-13103 > URL: https://issues.apache.org/jira/browse/NIFI-13103 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Jim Steinebrey >Assignee: Jim Steinebrey >Priority: Minor > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Make AutoCommit default to no values set in PutDatabaseRecord so the database > connection's autoCommit mode is left unchanged by default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13103 Enhance AutoCommit property to allow no value set in PutDatabaseRecord [nifi]
asfgit closed pull request #8723: NIFI-13103 Enhance AutoCommit property to allow no value set in PutDatabaseRecord URL: https://github.com/apache/nifi/pull/8723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13093] use warn palette for all errors and introduce caution palette [nifi]
rfellows commented on code in PR #8721:
URL: https://github.com/apache/nifi/pull/8721#discussion_r1586818369
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -261,56 +281,43 @@
//
// NOTE: nifi surface palette lighter/darker is purposefully omitted here.
Any application of nifi surface colors should be as a background-color to a
surface DOM element. The surface color should switch from light to dark
depending on the mode for the theme.
-.nifi-surface-default {
+.surface-color {
color: $nifi-theme-surface-palette-default;
fill: $nifi-theme-surface-palette-default;
}
-.nifi-success-default {
+.success-color {
color: $nifi-theme-success-palette-default;
fill: $nifi-theme-success-palette-default;
}
-.nifi-success-lighter {
+.success-color-lighter {
color: $nifi-theme-success-palette-lighter;
fill: $nifi-theme-success-palette-lighter;
}
-.nifi-success-darker {
+.success-color-darker {
color: $nifi-theme-success-palette-darker;
fill: $nifi-theme-success-palette-darker;
}
-.nifi-warn-default {
-color: $nifi-theme-warn-palette-default;
-fill: $nifi-theme-warn-palette-default;
+.caution-color {
+color: $nifi-theme-caution-palette-default;
+fill: $nifi-theme-caution-palette-default;
Review Comment:
what is the guidance for using the warn vs the caution colors?
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.ts:
##
@@ -148,7 +148,7 @@ export class BulletinBoardList implements AfterViewInit {
case 'warning':
return 'bulletin-warn';
Review Comment:
should this one use the `caution-color`
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/material.scss:
##
@@ -50,8 +50,33 @@ $material-primary-light-palette: (
A700: #ff,
)
);
+
$material-accent-light-palette: mat.$brown-palette;
-$warn-light-palette: mat.$red-palette;
+
+$warn-light-palette: (
+50: #ffebee,
+100: #ffccd2,
+200: #f4,
+300: #eb7071,
+400: #f64e4c,
+500: #fa3b30,
+600: #ec3030,
+700: #ff1507,
+800: #ff,
+900: #ba554a, // g.component rect.border.unauthorized,
#connection-full-drop-shadow feFlood, text.restricted, g.connection
rect.border.unauthorized, g.connection path.connection-path.full, g.connection
path.connection-path.unauthorized, .controller-bulletins.has-bulletins,
path.link.selected, g.event circle.selected
+contrast: (
+50: rgba(#00, 0.87),
+100: rgba(#00, 0.87),
+200: rgba(#00, 0.87),
+300: rgba(#00, 0.87),
+400: #ff,
+500: #ff,
+600: #ff,
+700: #ff,
+800: #ff,
+900: #ff
+)
+);
Review Comment:
The red is very bright in dark mode:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13121) FetchHDFS handles runtime exceptions incorrectly
[ https://issues.apache.org/jira/browse/NIFI-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-13121: Fix Version/s: 2.0.0-M3 1.26.0 Status: Patch Available (was: In Progress) > FetchHDFS handles runtime exceptions incorrectly > > > Key: NIFI-13121 > URL: https://issues.apache.org/jira/browse/NIFI-13121 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 10m > Remaining Estimate: 0h > > FetchHDFS does not catch runtime exceptions and does not route the incoming > flowfile to failure or yield as a result. This causes FetchHDFS to run over > and over (especially if the Run Schedule is 0 seconds) and can cause NiFi to > be unresponsive. > This happened to the AWS processors in NIFI-6367, the same fix needs to be > applied to FetchHDFS -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13121: Handle runtime exceptions in FetchHDFS [nifi]
mattyb149 opened a new pull request, #8727: URL: https://github.com/apache/nifi/pull/8727 # Summary [NIFI-13121](https://issues.apache.org/jira/browse/NIFI-13121) This PR mimics the fix from NIFI-6367 that was applied to FetchS3Object, and applies it to FetchHDFS. Runtime exceptions can currently be thrown by the Ozone File System for example. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13093] use warn palette for all errors and introduce caution palette [nifi]
rfellows commented on PR #8721: URL: https://github.com/apache/nifi/pull/8721#issuecomment-2089085260 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13120) Introduce branch to registry client and version control info
[ https://issues.apache.org/jira/browse/NIFI-13120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-13120: --- Status: Patch Available (was: Open) > Introduce branch to registry client and version control info > > > Key: NIFI-13120 > URL: https://issues.apache.org/jira/browse/NIFI-13120 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > For registry clients that support branching, there should be a way to get a > list of branches, as well as pass in the branch on all the calls for > saving/retrieving flows. Eventually this should be selectable from the UI on > the screens where you choose Registry/Bucket/Flow/Version. > Any clients that don't support branching can just return a single hard-coded > branch in the getBranches method, and can ignore the branch that is passed in > on api calls. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende opened a new pull request, #8726:
URL: https://github.com/apache/nifi/pull/8726
- Methods for getBranches, getDefaultBranch, and createBranch in flow
registry client
- Add branch as a field to all relevant objects/dtos/etc
- Add optional branch argument to REST API for retrieving buckets
- Add new REST API for retrieving branches for a given registry client
# Summary
[NIFI-13120](https://issues.apache.org/jira/browse/NIFI-13120)
This PR introduces further refactoring to the `FlowRegistryClient` API. It
adds new methods related to branches which have default implementations, and
changes the parameters of other methods to use "location" objects to
consolidate the combos of branch/bucketId/flowId/version that need to be passed
around.
The NiFi Registry client will ignore the incoming branch on all methods and
continue to function as it always has.
This PR also adds a REST API for retrieving branches:
`nifi-api/flow/registries/{registryId}/branches`
Optional query param on the REST API for retrieving buckets:
`/nifi-api/flow/registries/{registryId}/buckets?branch=main`
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue
created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as
`NIFI-0`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number,
as such `NIFI-0`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing
changes
# Verification
Please indicate the verification steps performed prior to pull request
creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 21
### UI Contributions
- [ ] NiFi is modernizing its UI. Any contributions that update the [current
UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui)
also need to be implemented in the [new
UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi).
### Licensing
- [ ] New dependencies are compatible with the [Apache License
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License
Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE`
files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13104) UI - Route handling
[ https://issues.apache.org/jira/browse/NIFI-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13104: --- Status: Patch Available (was: In Progress) > UI - Route handling > --- > > Key: NIFI-13104 > URL: https://issues.apache.org/jira/browse/NIFI-13104 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Address routing issues that arise under the following scenarios... > * The user attempts to visit an unknown route > * The user attempts to visit a known route but supplies a route parameter > that is unknown > Depending on level of effort it may make sense to break this into two > separate efforts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13104] Unknown Route handling [nifi]
rfellows opened a new pull request, #8725: URL: https://github.com/apache/nifi/pull/8725 [NIFI-13104](https://issues.apache.org/jira/browse/NIFI-13104) * 1st commit: All unknown routes now will show a Route Not Found error page * 2nd commit: Added a method to the error helper to safely get an error message from an HttpErrorResponse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13119) Resolve dependent value through Parameter is necessary
[ https://issues.apache.org/jira/browse/NIFI-13119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13119: --- Status: Patch Available (was: In Progress) > Resolve dependent value through Parameter is necessary > -- > > Key: NIFI-13119 > URL: https://issues.apache.org/jira/browse/NIFI-13119 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When evaluating dependent Properties, the UI should identify when the > Property value is a parameter reference and resolve the value accordingly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13119: When evaluating dependent Properties, the UI should identify when the Property value is a parameter reference and resolve the value accordingly [nifi]
mcgilman opened a new pull request, #8724: URL: https://github.com/apache/nifi/pull/8724 NIFI-13119: - When evaluating dependent Properties, the UI should identify when the Property value is a parameter reference and resolve the value accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13111) Remove unimplemented features for 2.0.0-M3
[ https://issues.apache.org/jira/browse/NIFI-13111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842750#comment-17842750 ] ASF subversion and git services commented on NIFI-13111: Commit f70967ec9e302ae3f2f57de730d0ec169ec2af2e in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f70967ec9e ] NIFI-13111: Removing/Hiding unimplemented features in preparation for next milestone release (#8710) * NIFI-13111: - Removing/Hiding unimplemented features in preparation for next milestone release. * NIFI-13111: - Addressing review feedback. This closes #8710 > Remove unimplemented features for 2.0.0-M3 > -- > > Key: NIFI-13111 > URL: https://issues.apache.org/jira/browse/NIFI-13111 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > In preparation for 2.0.0-M3 remove some currently unsupported/unimplemented > features so avoid potential confusion as users may expect the feature to be > supported due to the presence of buttons in the UI. > * Remove info icons from Summary pages > * Remove Enable/Disable All Controller Services from context menu > * Remove color from Operation Panel -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13111) Remove unimplemented features for 2.0.0-M3
[ https://issues.apache.org/jira/browse/NIFI-13111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13111: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Remove unimplemented features for 2.0.0-M3 > -- > > Key: NIFI-13111 > URL: https://issues.apache.org/jira/browse/NIFI-13111 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > In preparation for 2.0.0-M3 remove some currently unsupported/unimplemented > features so avoid potential confusion as users may expect the feature to be > supported due to the presence of buttons in the UI. > * Remove info icons from Summary pages > * Remove Enable/Disable All Controller Services from context menu > * Remove color from Operation Panel -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13111: Removing/Hiding unimplemented features in preparation for next milestone release [nifi]
scottyaslan merged PR #8710: URL: https://github.com/apache/nifi/pull/8710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-13121) FetchHDFS handles runtime exceptions incorrectly
[ https://issues.apache.org/jira/browse/NIFI-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-13121: --- Assignee: Matt Burgess > FetchHDFS handles runtime exceptions incorrectly > > > Key: NIFI-13121 > URL: https://issues.apache.org/jira/browse/NIFI-13121 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > > FetchHDFS does not catch runtime exceptions and does not route the incoming > flowfile to failure or yield as a result. This causes FetchHDFS to run over > and over (especially if the Run Schedule is 0 seconds) and can cause NiFi to > be unresponsive. > This happened to the AWS processors in NIFI-6367, the same fix needs to be > applied to FetchHDFS -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13121) FetchHDFS handles runtime exceptions incorrectly
Matt Burgess created NIFI-13121: --- Summary: FetchHDFS handles runtime exceptions incorrectly Key: NIFI-13121 URL: https://issues.apache.org/jira/browse/NIFI-13121 Project: Apache NiFi Issue Type: Bug Components: Extensions Reporter: Matt Burgess FetchHDFS does not catch runtime exceptions and does not route the incoming flowfile to failure or yield as a result. This causes FetchHDFS to run over and over (especially if the Run Schedule is 0 seconds) and can cause NiFi to be unresponsive. This happened to the AWS processors in NIFI-6367, the same fix needs to be applied to FetchHDFS -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13103 Enhance AutoCommit property to allow no value set in PutDatabaseRecord [nifi]
jrsteinebrey opened a new pull request, #8723: URL: https://github.com/apache/nifi/pull/8723 # Summary [NIFI-13103](https://issues.apache.org/jira/browse/NIFI-13103) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-13103) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-13103` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-13103` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Added unit tests to teset AUTO_COMMIT property equal to null. Also tested in NiFi UI ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### UI Contributions No UI changes - [X] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing No dependency or licensing changes ### Documentation - [X] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13111: Removing/Hiding unimplemented features in preparation for next milestone release [nifi]
mcgilman commented on PR #8710: URL: https://github.com/apache/nifi/pull/8710#issuecomment-2088730044 Thanks for the review @scottyaslan! Let me fix the formatting issues. I can add some TODOs so they can be easily found. We don't yet have JIRAs for each individual item but they are already called out in the parent JIRA [1]. [1] - https://issues.apache.org/jira/browse/NIFI-12400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12763) Theme the mat-paginator
[ https://issues.apache.org/jira/browse/NIFI-12763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842711#comment-17842711 ] ASF subversion and git services commented on NIFI-12763: Commit d487ce4eefd7f3dcd41ed814ca75d2debecdb0ca in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d487ce4eef ] [NIFI-12763] - Theme mat paginator - unset the background color so it blends in with the theme. (#8722) This closes #8722 > Theme the mat-paginator > --- > > Key: NIFI-12763 > URL: https://issues.apache.org/jira/browse/NIFI-12763 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-02-08 at 11.50.08 AM.png, Screenshot > 2024-02-09 at 8.27.39 AM.png > > Time Spent: 1h > Remaining Estimate: 0h > > The paginator we use in a couple of places isn't picking up the theming. > > > !Screenshot 2024-02-09 at 8.27.39 AM.png|width=999,height=553! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12763) Theme the mat-paginator
[ https://issues.apache.org/jira/browse/NIFI-12763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-12763: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Theme the mat-paginator > --- > > Key: NIFI-12763 > URL: https://issues.apache.org/jira/browse/NIFI-12763 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-02-08 at 11.50.08 AM.png, Screenshot > 2024-02-09 at 8.27.39 AM.png > > Time Spent: 1h > Remaining Estimate: 0h > > The paginator we use in a couple of places isn't picking up the theming. > > > !Screenshot 2024-02-09 at 8.27.39 AM.png|width=999,height=553! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12763] - Theme mat paginator - unset the background color so it blends in with the theme [nifi]
scottyaslan commented on code in PR #8722:
URL: https://github.com/apache/nifi/pull/8722#discussion_r1586467069
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -136,6 +136,10 @@
flex-basis: 100%;
flex: 1;
}
+
+.mat-mdc-paginator {
+background-color: unset !important;
Review Comment:
Fair enough. Let's roll.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12763] - Theme mat paginator - unset the background color so it blends in with the theme [nifi]
scottyaslan merged PR #8722: URL: https://github.com/apache/nifi/pull/8722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12803) BUG - policy changes require page refresh to be applied
[ https://issues.apache.org/jira/browse/NIFI-12803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-12803: --- Resolution: Fixed Status: Resolved (was: Patch Available) https://github.com/apache/nifi/pull/8718 > BUG - policy changes require page refresh to be applied > --- > > Key: NIFI-12803 > URL: https://issues.apache.org/jira/browse/NIFI-12803 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Matt Gilman >Priority: Major > Attachments: image-2024-02-15-13-57-03-890.png, > image-2024-02-15-13-58-17-784.png > > > !image-2024-02-15-13-57-03-890.png! > > !image-2024-02-15-13-58-17-784.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12833) Style "Primary Node Only" properly for both light and dark modes
[ https://issues.apache.org/jira/browse/NIFI-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842708#comment-17842708 ] Matt Gilman commented on NIFI-12833: A commit message and PR for NIFI-12803 incorrectly referenced this JIRA. This comment is to help anyone trying to track down the original Jira for that commit. > Style "Primary Node Only" properly for both light and dark modes > > > Key: NIFI-12833 > URL: https://issues.apache.org/jira/browse/NIFI-12833 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-02-22 at 10.43.01 AM.png, Screenshot > 2024-02-22 at 10.43.12 AM.png, Screenshot 2024-02-22 at 10.43.32 AM.png, > Screenshot 2024-02-22 at 10.43.54 AM.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > We display an "icon" when a processor is "Primary Node Only". It shows on the > canvas as well as on the Summary listing. In reality these aren't actually > icons but DOM elements styled to look like icons. We should be consistent in > how they are displayed in both light and dark mode. > > !Screenshot 2024-02-22 at 10.43.54 AM.png!!Screenshot 2024-02-22 at 10.43.32 > AM.png! > > !Screenshot 2024-02-22 at 10.43.12 AM.png!!Screenshot 2024-02-22 at 10.43.01 > AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (NIFI-12968) Refresh token handling and keeping current token expiration
[ https://issues.apache.org/jira/browse/NIFI-12968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reopened NIFI-12968: My mistake. I closed the wrong jira. > Refresh token handling and keeping current token expiration > --- > > Key: NIFI-12968 > URL: https://issues.apache.org/jira/browse/NIFI-12968 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > > Ensure the updated UI is handling token refresh appropriately and that the > current token expiration is properly tracked to sure the user doesn't > incorrectly see a message about the session ending. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12968) Refresh token handling and keeping current token expiration
[ https://issues.apache.org/jira/browse/NIFI-12968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan resolved NIFI-12968. Resolution: Fixed https://github.com/apache/nifi/pull/8718 > Refresh token handling and keeping current token expiration > --- > > Key: NIFI-12968 > URL: https://issues.apache.org/jira/browse/NIFI-12968 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > > Ensure the updated UI is handling token refresh appropriately and that the > current token expiration is properly tracked to sure the user doesn't > incorrectly see a message about the session ending. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13114) Always show primary node indicator when configured
[ https://issues.apache.org/jira/browse/NIFI-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842703#comment-17842703 ] ASF subversion and git services commented on NIFI-13114: Commit be4c003cd73222b9e566b9c3b18f05d0018b6c88 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=be4c003cd7 ] NIFI-13114: (#8713) - Code clean up and removing TODO regarding enforcing isClustered to see the Primary Node indicator. This closes #8713 > Always show primary node indicator when configured > -- > > Key: NIFI-13114 > URL: https://issues.apache.org/jira/browse/NIFI-13114 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13114: Always show primary node indicator when configured [nifi]
rfellows merged PR #8713: URL: https://github.com/apache/nifi/pull/8713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12763] - Theme mat paginator - unset the background color so it blends in with the theme [nifi]
rfellows commented on code in PR #8722:
URL: https://github.com/apache/nifi/pull/8722#discussion_r1586458998
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -136,6 +136,10 @@
flex-basis: 100%;
flex: 1;
}
+
+.mat-mdc-paginator {
+background-color: unset !important;
Review Comment:
That assumes we always want to put the paginator on our app background.
setting is as `unset` allows it to be used on any background.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13114) Always show primary node indicator when configured
[ https://issues.apache.org/jira/browse/NIFI-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13114: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Always show primary node indicator when configured > -- > > Key: NIFI-13114 > URL: https://issues.apache.org/jira/browse/NIFI-13114 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13112) Fix search links for components not on canvas
[ https://issues.apache.org/jira/browse/NIFI-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13112: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Fix search links for components not on canvas > - > > Key: NIFI-13112 > URL: https://issues.apache.org/jira/browse/NIFI-13112 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13112) Fix search links for components not on canvas
[ https://issues.apache.org/jira/browse/NIFI-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842700#comment-17842700 ] ASF subversion and git services commented on NIFI-13112: Commit 2c43a706f87e4ea71f8b3ba8f5cce971f098ec70 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2c43a706f8 ] NIFI-13112: (#8711) - Fixing linking to non canvas items. - Adding a tooltip to render search match details. This closes #8711 > Fix search links for components not on canvas > - > > Key: NIFI-13112 > URL: https://issues.apache.org/jira/browse/NIFI-13112 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13112: Fixing linking to non canvas items [nifi]
scottyaslan merged PR #8711: URL: https://github.com/apache/nifi/pull/8711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12763] - Theme mat paginator - unset the background color so it blends in with the theme [nifi]
scottyaslan commented on code in PR #8722:
URL: https://github.com/apache/nifi/pull/8722#discussion_r1586440489
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -136,6 +136,10 @@
flex-basis: 100%;
flex: 1;
}
+
+.mat-mdc-paginator {
+background-color: unset !important;
Review Comment:
I think we likely want to just set it to the mat-app-background-color:
```suggestion
background-color: var(--mat-app-background-color) !important;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12833) Style "Primary Node Only" properly for both light and dark modes
[ https://issues.apache.org/jira/browse/NIFI-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842692#comment-17842692 ] ASF subversion and git services commented on NIFI-12833: Commit 0e373e9c21cc6c633822374138280d14af427ff9 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0e373e9c21 ] NIFI-12833: (#8718) - Reloading current user when any policy changes. - Reloading the component for the policy whenever it's view permissions changes. This closes #8718 > Style "Primary Node Only" properly for both light and dark modes > > > Key: NIFI-12833 > URL: https://issues.apache.org/jira/browse/NIFI-12833 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-02-22 at 10.43.01 AM.png, Screenshot > 2024-02-22 at 10.43.12 AM.png, Screenshot 2024-02-22 at 10.43.32 AM.png, > Screenshot 2024-02-22 at 10.43.54 AM.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > We display an "icon" when a processor is "Primary Node Only". It shows on the > canvas as well as on the Summary listing. In reality these aren't actually > icons but DOM elements styled to look like icons. We should be consistent in > how they are displayed in both light and dark mode. > > !Screenshot 2024-02-22 at 10.43.54 AM.png!!Screenshot 2024-02-22 at 10.43.32 > AM.png! > > !Screenshot 2024-02-22 at 10.43.12 AM.png!!Screenshot 2024-02-22 at 10.43.01 > AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12833: Ensuring permissions are updated when policies are changed [nifi]
scottyaslan merged PR #8718: URL: https://github.com/apache/nifi/pull/8718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12833: Ensuring permissions are updated when policies are changed [nifi]
scottyaslan commented on PR #8718: URL: https://github.com/apache/nifi/pull/8718#issuecomment-2088581588 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12763) Theme the mat-paginator
[ https://issues.apache.org/jira/browse/NIFI-12763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows reassigned NIFI-12763: -- Assignee: Rob Fellows > Theme the mat-paginator > --- > > Key: NIFI-12763 > URL: https://issues.apache.org/jira/browse/NIFI-12763 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-02-08 at 11.50.08 AM.png, Screenshot > 2024-02-09 at 8.27.39 AM.png > > Time Spent: 20m > Remaining Estimate: 0h > > The paginator we use in a couple of places isn't picking up the theming. > > > !Screenshot 2024-02-09 at 8.27.39 AM.png|width=999,height=553! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12763) Theme the mat-paginator
[ https://issues.apache.org/jira/browse/NIFI-12763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12763: --- Status: Patch Available (was: In Progress) > Theme the mat-paginator > --- > > Key: NIFI-12763 > URL: https://issues.apache.org/jira/browse/NIFI-12763 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-02-08 at 11.50.08 AM.png, Screenshot > 2024-02-09 at 8.27.39 AM.png > > Time Spent: 20m > Remaining Estimate: 0h > > The paginator we use in a couple of places isn't picking up the theming. > > > !Screenshot 2024-02-09 at 8.27.39 AM.png|width=999,height=553! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12763] - Theme mat paginator - unset the background color so it blends in with the theme [nifi]
scottyaslan commented on PR #8722: URL: https://github.com/apache/nifi/pull/8722#issuecomment-2088567813 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12833) Style "Primary Node Only" properly for both light and dark modes
[ https://issues.apache.org/jira/browse/NIFI-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-12833: --- Resolution: Fixed Status: Resolved (was: Patch Available) https://github.com/apache/nifi/pull/8707 > Style "Primary Node Only" properly for both light and dark modes > > > Key: NIFI-12833 > URL: https://issues.apache.org/jira/browse/NIFI-12833 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-02-22 at 10.43.01 AM.png, Screenshot > 2024-02-22 at 10.43.12 AM.png, Screenshot 2024-02-22 at 10.43.32 AM.png, > Screenshot 2024-02-22 at 10.43.54 AM.png > > Time Spent: 10m > Remaining Estimate: 0h > > We display an "icon" when a processor is "Primary Node Only". It shows on the > canvas as well as on the Summary listing. In reality these aren't actually > icons but DOM elements styled to look like icons. We should be consistent in > how they are displayed in both light and dark mode. > > !Screenshot 2024-02-22 at 10.43.54 AM.png!!Screenshot 2024-02-22 at 10.43.32 > AM.png! > > !Screenshot 2024-02-22 at 10.43.12 AM.png!!Screenshot 2024-02-22 at 10.43.01 > AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13120) Introduce branch to registry client and version control info
Bryan Bende created NIFI-13120: -- Summary: Introduce branch to registry client and version control info Key: NIFI-13120 URL: https://issues.apache.org/jira/browse/NIFI-13120 Project: Apache NiFi Issue Type: Improvement Reporter: Bryan Bende Assignee: Bryan Bende For registry clients that support branching, there should be a way to get a list of branches, as well as pass in the branch on all the calls for saving/retrieving flows. Eventually this should be selectable from the UI on the screens where you choose Registry/Bucket/Flow/Version. Any clients that don't support branching can just return a single hard-coded branch in the getBranches method, and can ignore the branch that is passed in on api calls. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13114) Always show primary node indicator when configured
[ https://issues.apache.org/jira/browse/NIFI-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13114: --- Summary: Always show primary node indicator when configured (was: Only show Primary icon when clustered) > Always show primary node indicator when configured > -- > > Key: NIFI-13114 > URL: https://issues.apache.org/jira/browse/NIFI-13114 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13114: Only showing the primary node indicator when the node is clustered [nifi]
mcgilman commented on PR #8713: URL: https://github.com/apache/nifi/pull/8713#issuecomment-2088469472 Just discussed this more with @rfellows offline. Considering we allow for configuring primary node only execution and support filtering for this in the Summary page, it makes more sense to always show the primary node icon if configured. Updating this PR to reflect this and do some additional clean up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13115) UI - update border, box-shadow, and border radius of context menu, nf editor, and search box to match angular material overlay styles
[ https://issues.apache.org/jira/browse/NIFI-13115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13115: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > UI - update border, box-shadow, and border radius of context menu, nf editor, > and search box to match angular material overlay styles > - > > Key: NIFI-13115 > URL: https://issues.apache.org/jira/browse/NIFI-13115 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13115) UI - update border, box-shadow, and border radius of context menu, nf editor, and search box to match angular material overlay styles
[ https://issues.apache.org/jira/browse/NIFI-13115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842619#comment-17842619 ] ASF subversion and git services commented on NIFI-13115: Commit d1173b2f98b218dd9f6b0b14f36afaa358f3fcee in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d1173b2f98 ] [NIFI-13115] update context menu, search results overalay, and nf edi… (#8714) * [NIFI-13115] update context menu, search results overalay, and nf editor overlay to match angular material overlay styles * use mat-elevation-z8 to match elevation of mat-menus * update nf editor resize handle * restore tooltip border width This closes #8714 > UI - update border, box-shadow, and border radius of context menu, nf editor, > and search box to match angular material overlay styles > - > > Key: NIFI-13115 > URL: https://issues.apache.org/jira/browse/NIFI-13115 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13115] update context menu, search results overalay, and nf edi… [nifi]
mcgilman merged PR #8714: URL: https://github.com/apache/nifi/pull/8714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13116) PutDatabaseRecord (INSERT_IGNORE) uses Update keys while not specified
[
https://issues.apache.org/jira/browse/NIFI-13116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Pinevskiy updated NIFI-13116:
-
Description:
PutDatabaseRecord hides field "Update Keys" while using INSERT_IGNORE ("A
comma-separated list of column names that uniquely identifies a row in the
database for UPDATE statements. If the Statement Type is UPDATE and this
property is not set, the table's Primary Keys are used. In this case, if no
Primary Key exists, the conversion to SQL will fail if Unmatched Column
Behaviour is set to FAIL. This property is ignored if the Statement Type is
INSERT").
Despite this field not being set and not being used, classes like
PostgreSQLDatabaseAdapter use it in methods for INSERT_IGNORE, which triggers
an exception if list of Update Keys is empty or null. MySQLDatabaseAdapter
methods have same checks for Update Keys, but do not use them. With that for
PostgreSQL we have "instert ... on conflict (Update Keys) ignore", and for
MySQL any constraint will trigger "on conflict" on any constraint, not
specified.
It means different and unclear behaviour, so i suggest removing use of Update
Keys in said classes.
was:
PutDatabaseRecord hides field "Update Keys" while using INSERT_IGNORE ("A
comma-separated list of column names that uniquely identifies a row in the
database for UPDATE statements. If the Statement Type is UPDATE and this
property is not set, the table's Primary Keys are used. In this case, if no
Primary Key exists, the conversion to SQL will fail if Unmatched Column
Behaviour is set to FAIL. This property is ignored if the Statement Type is
INSERT").
Despite this field not being set and not being used, classes like
PostgreSQLDatabaseAdapter use it in methods for INSERT_IGNORE and UPSERT, which
triggers an exception if list of Update Keys is empty or null.
MySQLDatabaseAdapter methods have same checks for Update Keys, but do not use
them. With that for PostgreSQL we have "instert ... on conflict (Update Keys)
ignore", and for MySQL any constraint will trigger "on conflict" on any
constraint, not specified.
It means different and unclear behaviour, so i suggest removing use of Update
Keys in said classes.
> PutDatabaseRecord (INSERT_IGNORE) uses Update keys while not specified
> --
>
> Key: NIFI-13116
> URL: https://issues.apache.org/jira/browse/NIFI-13116
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.25.0, 2.0.0-M2
>Reporter: Mikhail Pinevskiy
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> PutDatabaseRecord hides field "Update Keys" while using INSERT_IGNORE ("A
> comma-separated list of column names that uniquely identifies a row in the
> database for UPDATE statements. If the Statement Type is UPDATE and this
> property is not set, the table's Primary Keys are used. In this case, if no
> Primary Key exists, the conversion to SQL will fail if Unmatched Column
> Behaviour is set to FAIL. This property is ignored if the Statement Type is
> INSERT").
> Despite this field not being set and not being used, classes like
> PostgreSQLDatabaseAdapter use it in methods for INSERT_IGNORE, which triggers
> an exception if list of Update Keys is empty or null. MySQLDatabaseAdapter
> methods have same checks for Update Keys, but do not use them. With that for
> PostgreSQL we have "instert ... on conflict (Update Keys) ignore", and for
> MySQL any constraint will trigger "on conflict" on any constraint, not
> specified.
> It means different and unclear behaviour, so i suggest removing use of Update
> Keys in said classes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-13116 PutDatabaseRecord (INSERT_IGNORE) uses Update keys while n… [nifi]
Pinevskiy closed pull request #8717: NIFI-13116 PutDatabaseRecord (INSERT_IGNORE) uses Update keys while n… URL: https://github.com/apache/nifi/pull/8717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
