[jira] [Created] (NIFI-13132) Import from registry error handling
Scott Aslan created NIFI-13132: -- Summary: Import from registry error handling Key: NIFI-13132 URL: https://issues.apache.org/jira/browse/NIFI-13132 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Assignee: Scott Aslan Attachments: Screenshot 2024-05-02 at 4.33.01 PM.png When a registry is configured but no longer running or available the user can attempt to drag and drop on the canvas to import a flow from the registry. There is a console error in dev tools but no error is displayed to the user: -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13108) Dependency hygiene - various libraries for logging, apache commons, aws/azure/gcp
[ https://issues.apache.org/jira/browse/NIFI-13108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13108: Summary: Dependency hygiene - various libraries for logging, apache commons, aws/azure/gcp (was: Dependency hygiene - commons codec 1.17) > Dependency hygiene - various libraries for logging, apache commons, > aws/azure/gcp > -- > > Key: NIFI-13108 > URL: https://issues.apache.org/jira/browse/NIFI-13108 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13108 Update a variety of dependencies [nifi]
joewitt commented on PR #8708: URL: https://github.com/apache/nifi/pull/8708#issuecomment-2091897995 @pvillard31 For the 1.x line i put together https://issues.apache.org/jira/browse/NIFI-13131. This *should be* safe. Full clean build and a basic runs suggests so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13131) Dependency hygiene
[ https://issues.apache.org/jira/browse/NIFI-13131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13131: Affects Version/s: 1.25.0 > Dependency hygiene > --- > > Key: NIFI-13131 > URL: https://issues.apache.org/jira/browse/NIFI-13131 > Project: Apache NiFi > Issue Type: Task >Affects Versions: 1.25.0 >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Related to NIFI-13108 it was asked to do some similar updates. > I will pick off the safest looking ones. The NiFi 1.x line does not have the > same dependency tree/pom structure protections now established in the 2.x > line from NIFI-12998 so such dependency hygiene efforts will likely require > more and more specific scrutiny and effort going forward. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13131) Dependency hygiene
[ https://issues.apache.org/jira/browse/NIFI-13131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13131: Fix Version/s: 1.26.0 > Dependency hygiene > --- > > Key: NIFI-13131 > URL: https://issues.apache.org/jira/browse/NIFI-13131 > Project: Apache NiFi > Issue Type: Task >Affects Versions: 1.25.0 >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.26.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Related to NIFI-13108 it was asked to do some similar updates. > I will pick off the safest looking ones. The NiFi 1.x line does not have the > same dependency tree/pom structure protections now established in the 2.x > line from NIFI-12998 so such dependency hygiene efforts will likely require > more and more specific scrutiny and effort going forward. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13131) Dependency hygiene
[ https://issues.apache.org/jira/browse/NIFI-13131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13131: Affects Version/s: (was: 1.25.0) > Dependency hygiene > --- > > Key: NIFI-13131 > URL: https://issues.apache.org/jira/browse/NIFI-13131 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.26.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Related to NIFI-13108 it was asked to do some similar updates. > I will pick off the safest looking ones. The NiFi 1.x line does not have the > same dependency tree/pom structure protections now established in the 2.x > line from NIFI-12998 so such dependency hygiene efforts will likely require > more and more specific scrutiny and effort going forward. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13131 dependency updates [nifi]
joewitt opened a new pull request, #8732: URL: https://github.com/apache/nifi/pull/8732 # Summary [NIFI-13131](https://issues.apache.org/jira/browse/NIFI-13131) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13131) Dependency hygiene
[
https://issues.apache.org/jira/browse/NIFI-13131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843097#comment-17843097
]
Joe Witt commented on NIFI-13131:
-
Pulled all changes from NIFI-13108 and the following appear 'safe' to make.
{noformat}
azure.sdk.bom.version 1.2.21 -> 1.2.23 (nifi-azure-bundle)
google.libraries.version 26.34.0 26.37.0 (nifi-gcp-bundle)
- was 26.25.0
com.amazonaws.version 1.12.686 1.12.710 (root pom)
software.amazon.awssdk.version 2.25.16 2.25.40
org.apache.commons.cli.version 1.6.0 1.7.0
org.apache.commons.codec.version 1.16.1 1.17.0
com.github.luben.zstd-jni.version 1.5.6-1 1.5.6-3
org.apache.commons.text.version 1.11.0 1.12.0
testcontainers.version 1.19.4 1.19.7
log4j2.version 2.23.0 2.23.1
jsoup 1.17.1 1.17.2
{noformat}
> Dependency hygiene
> ---
>
> Key: NIFI-13131
> URL: https://issues.apache.org/jira/browse/NIFI-13131
> Project: Apache NiFi
> Issue Type: Task
>Reporter: Joe Witt
>Assignee: Joe Witt
>Priority: Major
>
> Related to NIFI-13108 it was asked to do some similar updates.
> I will pick off the safest looking ones. The NiFi 1.x line does not have the
> same dependency tree/pom structure protections now established in the 2.x
> line from NIFI-12998 so such dependency hygiene efforts will likely require
> more and more specific scrutiny and effort going forward.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-13131) Dependency hygiene
Joe Witt created NIFI-13131: --- Summary: Dependency hygiene Key: NIFI-13131 URL: https://issues.apache.org/jira/browse/NIFI-13131 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt Related to NIFI-13108 it was asked to do some similar updates. I will pick off the safest looking ones. The NiFi 1.x line does not have the same dependency tree/pom structure protections now established in the 2.x line from NIFI-12998 so such dependency hygiene efforts will likely require more and more specific scrutiny and effort going forward. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13130) Focus incorrectly applied to dialogs on page refresh
Scott Aslan created NIFI-13130: -- Summary: Focus incorrectly applied to dialogs on page refresh Key: NIFI-13130 URL: https://issues.apache.org/jira/browse/NIFI-13130 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Attachments: image-2024-05-02-16-27-06-410.png On page refresh the `tabindex="0"` on some dialogs seems to apply a focus border to the dialog. This is especially noticeable in dark mode. !image-2024-05-02-16-27-06-410.png|width=534,height=331! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13129) [BUG] selected prioritizer order is not honored when displayed in the UI
Scott Aslan created NIFI-13129: -- Summary: [BUG] selected prioritizer order is not honored when displayed in the UI Key: NIFI-13129 URL: https://issues.apache.org/jira/browse/NIFI-13129 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Attachments: image-2024-05-02-16-24-55-252.png !image-2024-05-02-16-24-55-252.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13128) [BUG] invalid port missing caution-color
[ https://issues.apache.org/jira/browse/NIFI-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13128: --- Status: Patch Available (was: In Progress) > [BUG] invalid port missing caution-color > > > Key: NIFI-13128 > URL: https://issues.apache.org/jira/browse/NIFI-13128 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-02 at 4.14.02 PM.png > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13128) [BUG] invalid port missing caution-color
Scott Aslan created NIFI-13128: -- Summary: [BUG] invalid port missing caution-color Key: NIFI-13128 URL: https://issues.apache.org/jira/browse/NIFI-13128 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Assignee: Scott Aslan Attachments: Screenshot 2024-05-02 at 4.14.02 PM.png -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13122) [BUG] - select all parameter checkbox is not visible
[ https://issues.apache.org/jira/browse/NIFI-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13122: --- Status: Patch Available (was: In Progress) > [BUG] - select all parameter checkbox is not visible > > > Key: NIFI-13122 > URL: https://issues.apache.org/jira/browse/NIFI-13122 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-02 at 9.51.25 AM.png, Screenshot > 2024-05-02 at 9.51.32 AM.png, Screenshot 2024-05-02 at 9.51.38 AM.png > > Time Spent: 10m > Remaining Estimate: 0h > > the checkbox we use to support select all, select none, or indicate some are > selected isn't clearly defined when checked or indicating some are selected. > It isn't immediately apparent that you can interact with it. It is fine when > nothing is selected because it has an outline: > > !Screenshot 2024-05-02 at 9.51.25 AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13122] use accent color for checkbox on top of primary color [nifi]
scottyaslan opened a new pull request, #8730: URL: https://github.com/apache/nifi/pull/8730  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-13124) PutDatabaseRecord: when AUTO_COMMIT property equals "No value set", an NPE occurs
[ https://issues.apache.org/jira/browse/NIFI-13124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Steinebrey resolved NIFI-13124. --- Resolution: Duplicate > PutDatabaseRecord: when AUTO_COMMIT property equals "No value set", an NPE > occurs > - > > Key: NIFI-13124 > URL: https://issues.apache.org/jira/browse/NIFI-13124 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.25.0 >Reporter: Jim Steinebrey >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13124) PutDatabaseRecord: when AUTO_COMMIT property equals "No value set", an NPE occurs
[ https://issues.apache.org/jira/browse/NIFI-13124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Steinebrey updated NIFI-13124: -- Summary: PutDatabaseRecord: when AUTO_COMMIT property equals "No value set", an NPE occurs (was: PutSQL: when AUTO_COMMIT property equals "No value set", an NPE occurs) > PutDatabaseRecord: when AUTO_COMMIT property equals "No value set", an NPE > occurs > - > > Key: NIFI-13124 > URL: https://issues.apache.org/jira/browse/NIFI-13124 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.25.0 >Reporter: Jim Steinebrey >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13124) PutSQL: when AUTO_COMMIT property equals "No value set", an NPE occurs
[ https://issues.apache.org/jira/browse/NIFI-13124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Steinebrey updated NIFI-13124: -- Description: (was: If user manually sets PutSQL property called "Database Session AutoCommit" to "No value set", then when a flow file attempts to be processed, a NullPointerException is thrown) > PutSQL: when AUTO_COMMIT property equals "No value set", an NPE occurs > -- > > Key: NIFI-13124 > URL: https://issues.apache.org/jira/browse/NIFI-13124 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.25.0 >Reporter: Jim Steinebrey >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13124) PutSQL: when AUTO_COMMIT property equals "No value set", an NPE occurs
[ https://issues.apache.org/jira/browse/NIFI-13124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Steinebrey reassigned NIFI-13124: - Assignee: (was: Jim Steinebrey) > PutSQL: when AUTO_COMMIT property equals "No value set", an NPE occurs > -- > > Key: NIFI-13124 > URL: https://issues.apache.org/jira/browse/NIFI-13124 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.25.0 >Reporter: Jim Steinebrey >Priority: Minor > > If user manually sets PutSQL property called "Database Session AutoCommit" to > "No value set", then when a flow file attempts to be processed, a > NullPointerException is thrown -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12973 Add Process Group scope to Flow Analysis rules [nifi]
pvillard31 commented on PR #8682: URL: https://github.com/apache/nifi/pull/8682#issuecomment-2091314480 @tpalfy - not sure if/why this is related to this PR but the system tests seem to be failing consistently Error: Errors: Error:PythonNarIT>NiFiSystemIT.setup:122 » Runtime Failed to start NiFi Error:PythonProcessorIT>NiFiSystemIT.setup:122 » Runtime Failed to start NiFi Error:PythonProcessorIT>NiFiSystemIT.setup:122 » Runtime Failed to start NiFi I've been rerunning the tests a few times already but no change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12831) Add PutOpenSearchVector and QueryOpenSearchVector processors
[ https://issues.apache.org/jira/browse/NIFI-12831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-12831. --- Fix Version/s: 2.0.0-M3 Resolution: Fixed > Add PutOpenSearchVector and QueryOpenSearchVector processors > > > Key: NIFI-12831 > URL: https://issues.apache.org/jira/browse/NIFI-12831 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Mark Bathori >Assignee: Mark Bathori >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Create vector store specific put and query processors for OpenSearch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12831) Add PutOpenSearchVector and QueryOpenSearchVector processors
[ https://issues.apache.org/jira/browse/NIFI-12831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843059#comment-17843059 ] ASF subversion and git services commented on NIFI-12831: Commit b608e5a2f0002a0f9c6d6121815b54f6dae67dc4 in nifi's branch refs/heads/main from Mark Bathori [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b608e5a2f0 ] NIFI-12831: Add PutOpenSearchVector and QueryOpenSearchVector processors Signed-off-by: Pierre Villard This closes #8441. > Add PutOpenSearchVector and QueryOpenSearchVector processors > > > Key: NIFI-12831 > URL: https://issues.apache.org/jira/browse/NIFI-12831 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Mark Bathori >Assignee: Mark Bathori >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Create vector store specific put and query processors for OpenSearch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12831: Add PutOpenSearchVector and QueryOpenSearchVector processors [nifi]
asfgit closed pull request #8441: NIFI-12831: Add PutOpenSearchVector and QueryOpenSearchVector processors URL: https://github.com/apache/nifi/pull/8441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on PR #8463: URL: https://github.com/apache/nifi/pull/8463#issuecomment-2091285872 > I see what you mean. I'm suggesting even needing to swap out the controller service seems problematic. The jump from 2.6 to 3.0 involved * slight * changes in the NiFi component code (IIRC compatible API parameter types and additional method arguments). Less than an hour to remediate. It is a good point. Aside from practical considerations (Maven dependencies declared at compile time), it is hard to anticipate the scope of future changes to the client library API. It'll be interesting to get additional perspectives here. > But in any case...I dont feel that strongly. Fine as is just sharing my thoughts. And thanks for that! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13108 Update a variety of dependencies [nifi]
joewitt commented on PR #8708: URL: https://github.com/apache/nifi/pull/8708#issuecomment-2091273371 The change-set for the main branch is ready to go and looks good. In general I do not plan to make hygiene updates on the 1.x line at this point. The dependency management there is substantially less certain than it is now on the 2/x main line post NIFI-12998 and various related JIRAs which reduced build size/etc... But some of these should be safe-ish and I'll flag those and put up a different JIRA and PR for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-13122) [BUG] - select all parameter checkbox is not visible
[ https://issues.apache.org/jira/browse/NIFI-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-13122: -- Assignee: Scott Aslan > [BUG] - select all parameter checkbox is not visible > > > Key: NIFI-13122 > URL: https://issues.apache.org/jira/browse/NIFI-13122 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-02 at 9.51.25 AM.png, Screenshot > 2024-05-02 at 9.51.32 AM.png, Screenshot 2024-05-02 at 9.51.38 AM.png > > > the checkbox we use to support select all, select none, or indicate some are > selected isn't clearly defined when checked or indicating some are selected. > It isn't immediately apparent that you can interact with it. It is fine when > nothing is selected because it has an outline: > > !Screenshot 2024-05-02 at 9.51.25 AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2336 Python bootstrap part 2 [nifi-minifi-cpp]
martinzink commented on code in PR #1773:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1773#discussion_r1587242859
##
bootstrap/system_dependency.py:
##
@@ -36,7 +36,7 @@ def _create_system_dependencies(minifi_options:
MinifiOptions) -> Dict[str, Set[
system_dependencies['libpng'] = {'libpng'}
if minifi_options.is_enabled("ENABLE_GPS"):
system_dependencies['gpsd'] = {'gpsd'}
-if minifi_options.is_enabled("ENABLE_COAP"):
+if minifi_options.is_enabled("ENABLE_COAP") or
(minifi_options.is_enabled("ENABLE_SQL") and platform.system() != "Windows"):
Review Comment:
You shouldnt need the platform specification here because these are noop
installs on windows already
https://github.com/apache/nifi-minifi-cpp/blob/main/bootstrap/package_manager.py#L250-L252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13104) UI - Route handling
[ https://issues.apache.org/jira/browse/NIFI-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13104: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > UI - Route handling > --- > > Key: NIFI-13104 > URL: https://issues.apache.org/jira/browse/NIFI-13104 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 40m > Remaining Estimate: 0h > > Address routing issues that arise under the following scenarios... > * The user attempts to visit an unknown route > * The user attempts to visit a known route but supplies a route parameter > that is unknown > Depending on level of effort it may make sense to break this into two > separate efforts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13104) UI - Route handling
[ https://issues.apache.org/jira/browse/NIFI-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843039#comment-17843039 ] ASF subversion and git services commented on NIFI-13104: Commit f87a0f47ef8a6a7038b371ca8e2205e49530a89a in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f87a0f47ef ] [NIFI-13104] Unknown Route handling (#8725) * [NIFI-13104] - Unknown route handling * Add method to the ErrorHelper that safely gets an error string from an HttpErrorResponse object * review feedback * use errorHelper.fullScreenError in favor of directly calling the fullScreenError action This closes #8725 > UI - Route handling > --- > > Key: NIFI-13104 > URL: https://issues.apache.org/jira/browse/NIFI-13104 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Rob Fellows >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Address routing issues that arise under the following scenarios... > * The user attempts to visit an unknown route > * The user attempts to visit a known route but supplies a route parameter > that is unknown > Depending on level of effort it may make sense to break this into two > separate efforts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13104] Unknown Route handling [nifi]
mcgilman merged PR #8725: URL: https://github.com/apache/nifi/pull/8725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
joewitt commented on PR #8463: URL: https://github.com/apache/nifi/pull/8463#issuecomment-2091227065 I see what you mean. I'm suggesting even needing to swap out the controller service seems problematic. I like the controller service model and I recall why this direction was taken. But we should be able to call it Kafka and not Kafka3 even there. IF a later client changes behavior we can call that by specific version. But in any case...I dont feel that strongly. Fine as is just sharing my thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINIFICPP-2349 FetchModbusTcp [nifi-minifi-cpp]
martinzink opened a new pull request, #1779: URL: https://github.com/apache/nifi-minifi-cpp/pull/1779 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-13097) Set Project Version in Python Extension Processors
[
https://issues.apache.org/jira/browse/NIFI-13097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard resolved NIFI-13097.
---
Resolution: Fixed
> Set Project Version in Python Extension Processors
> --
>
> Key: NIFI-13097
> URL: https://issues.apache.org/jira/browse/NIFI-13097
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Python Processors in the {{nifi-python-extensions}} module have the version
> field set to {{2.0.0-SNAPSHOT}} in the Processor Details section of the
> Python class. Although this works while the main branch remains on the
> snapshot version, it does not support applying the project version to these
> Processors using standard release processes.
> The version field can use a placeholder that will be populated during the
> Maven module build process to align the Processor version field with the
> released Maven module version, without other manual changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-13097) Set Project Version in Python Extension Processors
[
https://issues.apache.org/jira/browse/NIFI-13097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843036#comment-17843036
]
ASF subversion and git services commented on NIFI-13097:
Commit 49c8d1b4903ac9c23b10cbb89f1ff8b135b5bcf8 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=49c8d1b490 ]
NIFI-13097 Set project.version in Python Extension Processors
- Enabled resource filtering for Python Extension modules
Signed-off-by: Pierre Villard
This closes #8700.
> Set Project Version in Python Extension Processors
> --
>
> Key: NIFI-13097
> URL: https://issues.apache.org/jira/browse/NIFI-13097
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.0.0-M3
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Python Processors in the {{nifi-python-extensions}} module have the version
> field set to {{2.0.0-SNAPSHOT}} in the Processor Details section of the
> Python class. Although this works while the main branch remains on the
> snapshot version, it does not support applying the project version to these
> Processors using standard release processes.
> The version field can use a placeholder that will be populated during the
> Maven module build process to align the Processor version field with the
> released Maven module version, without other manual changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-13097 Set project.version in Python Extension Processors [nifi]
asfgit closed pull request #8700: NIFI-13097 Set project.version in Python Extension Processors URL: https://github.com/apache/nifi/pull/8700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13119: When evaluating dependent Properties, the UI should identify when the Property value is a parameter reference and resolve the value accordingly [nifi]
rfellows commented on code in PR #8724:
URL: https://github.com/apache/nifi/pull/8724#discussion_r1588080597
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/property-table/property-table.component.ts:
##
@@ -215,18 +220,50 @@ export class PropertyTable implements AfterViewInit,
ControlValueAccessor {
return false;
}
+// if the dependent item is sensitive, in this case we are lenient and
+// consider the dependency met
+if (dependentItem.descriptor.sensitive) {
+return true;
+}
+
// if the dependent item is visible, but does not require a specific
// dependent value consider the dependency met
if (this.nifiCommon.isEmpty(dependency.dependentValues)) {
Review Comment:
We need to handle the scenario where the dependentItem.value is null so the
dependency is not shown. An example of this is the
`AWSCredentialsProviderControllerService` and the `Assume Role ARN` property.
If it is unset, the other properties below it should not be shown (like `Assume
Role Session Name` among others).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12903) UI - update disabled/enabled drag/drop colors
[ https://issues.apache.org/jira/browse/NIFI-12903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-12903: --- Status: Patch Available (was: In Progress) > UI - update disabled/enabled drag/drop colors > - > > Key: NIFI-12903 > URL: https://issues.apache.org/jira/browse/NIFI-12903 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The connection prioritizers and the parameter context inheritance drag and > drop controls need to update the background color for enabled and disabled > states. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-12903] style updates for drag/drop UX [nifi]
scottyaslan opened a new pull request, #8729: URL: https://github.com/apache/nifi/pull/8729 This PR creates reuseable styles for all cdk drag/drop UX. Please test with connection prioritizers as well as parameter context inheritence.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2357) Test processors should not be packaged
Marton Szasz created MINIFICPP-2357:
---
Summary: Test processors should not be packaged
Key: MINIFICPP-2357
URL: https://issues.apache.org/jira/browse/MINIFICPP-2357
Project: Apache NiFi MiNiFi C++
Issue Type: Bug
Reporter: Marton Szasz
When running `make package` or `ninja package`, the generated package contains
the test_processors component. It should be skipped, as it's not useful for
users, even if they wish to run unit tests with ctest.
{color:#00}CPack: - Install component: test_processors{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13126) Add Impala DB Adapter
[ https://issues.apache.org/jira/browse/NIFI-13126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajmund Takacs updated NIFI-13126: -- Status: Patch Available (was: In Progress) > Add Impala DB Adapter > - > > Key: NIFI-13126 > URL: https://issues.apache.org/jira/browse/NIFI-13126 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 2.0.0-M2, 1.25.0, 1.24.0, 2.0.0-M1 >Reporter: Rajmund Takacs >Assignee: Rajmund Takacs >Priority: Major > Labels: feature > Time Spent: 10m > Remaining Estimate: 0h > > PutDatabaseRecord standard processor is familiar with various SQL dialects, > that the user can set during configuration to match their DBCP connection. > Unfortunately Apache Impala dialect is not supported. Most of the operations > work with MySQL dialect, but for example UPSERT does not. > Please add support for Impala too. Thanks. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13126: Add Impala DB Adapter [nifi]
takraj opened a new pull request, #8728: URL: https://github.com/apache/nifi/pull/8728 # Summary [NIFI-13126](https://issues.apache.org/jira/browse/NIFI-13126) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### UI Contributions - [x] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
joewitt commented on PR #8463: URL: https://github.com/apache/nifi/pull/8463#issuecomment-2090978880 @greyp9 Yeah that is fair. Dropping the 2.x stuff is certainly fair in a diff PR. More relevant for this PR though would be the naming for the Kafka3 components and breaking the cycle of users having to change processors with Kafka changes. We had to do this during the 0x/1x/2x transitions as the client behaviors just weren't stable enough. But I suspect now they are (just my view -others may have different info). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1587922187
##
nifi-api/src/main/java/org/apache/nifi/registry/flow/CreateBranch.java:
##
@@ -0,0 +1,53 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under one or more
+ * * contributor license agreements. See the NOTICE file distributed with
+ * * this work for additional information regarding copyright ownership.
+ * * The ASF licenses this file to You under the Apache License, Version 2.0
+ * * (the "License"); you may not use this file except in compliance with
+ * * the License. You may obtain a copy of the License at
+ * *
+ * * http://www.apache.org/licenses/LICENSE-2.0
+ * *
+ * * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ *
+ */
+
+package org.apache.nifi.registry.flow;
+
+/**
+ * Information for creating a branch in a flow registry.
+ */
+public class CreateBranch {
+
+private String fromBranch;
+private String newBranch;
+
+public CreateBranch() {
+}
+
+public CreateBranch(final String fromBranch, final String newBranch) {
+this.fromBranch = fromBranch;
Review Comment:
That was my current thinking, but you are right that possibly having a
commit to branch from would make sense. I will consider adding this if we
decide to keep this method based on discussion in other comment about where
this should be done outside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1587920491
##
nifi-api/src/main/java/org/apache/nifi/registry/flow/FlowRegistryBranch.java:
##
@@ -0,0 +1,52 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under one or more
+ * * contributor license agreements. See the NOTICE file distributed with
+ * * this work for additional information regarding copyright ownership.
+ * * The ASF licenses this file to You under the Apache License, Version 2.0
+ * * (the "License"); you may not use this file except in compliance with
+ * * the License. You may obtain a copy of the License at
+ * *
+ * * http://www.apache.org/licenses/LICENSE-2.0
+ * *
+ * * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ *
+ */
+
+package org.apache.nifi.registry.flow;
+
+import java.util.Objects;
+
+public class FlowRegistryBranch {
Review Comment:
Currently there wasn't a need to know this since I wasn't envisioning any
advanced features like merging back or rebasing etc from NiFi. All of these
things would be done outside in GitHub, or whatever registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1587917581
##
nifi-api/src/main/java/org/apache/nifi/registry/flow/FlowRegistryClient.java:
##
@@ -71,30 +74,82 @@ public interface FlowRegistryClient extends
ConfigurableComponent {
*/
boolean isStorageLocationApplicable(FlowRegistryClientConfigurationContext
context, String location);
+/**
+ * Indicates if the registry supports branching.
+ *
+ * @param context Configuration context
+ * @return true if the registry supports branching, false otherwise
+ */
+default boolean isBranchingSupported(final
FlowRegistryClientConfigurationContext context) {
+return false;
+}
+
+/**
+ * Get the available branches. Should return at least one branch that
matches the response of getDefaultBranch.
+ *
+ * @param context Configuration context
+ * @return the set of available branches
+ *
+ * @throws FlowRegistryException If an issue happens during processing the
request.
+ * @throws IOException If there is issue with the communication between
NiFi and the Flow Registry.
+ */
+default Set getBranches(final
FlowRegistryClientConfigurationContext context) throws FlowRegistryException,
IOException {
+return Set.of(getDefaultBranch(context));
+}
+
+/**
+ * Gets the default branch. Must return a non-null FlowRegistryBranch
instance with a non-null name.
+ *
+ * @param context Configuration context
+ * @return the default branch
+ *
+ * @throws FlowRegistryException If an issue happens during processing the
request.
+ * @throws IOException If there is issue with the communication between
NiFi and the Flow Registry.
+ */
+default FlowRegistryBranch getDefaultBranch(final
FlowRegistryClientConfigurationContext context) throws FlowRegistryException,
IOException {
+final FlowRegistryBranch branch = new FlowRegistryBranch();
+branch.setName(DEFAULT_BRANCH_NAME);
+return branch;
+}
+
+/**
+ * Creates a new branch from a given branch.
+ *
+ * @param context Configuration context
+ * @param createBranch the info for creating the branch
+ *
+ * @throws FlowRegistryException If an issue happens during processing the
request.
+ * @throws IOException If there is issue with the communication between
NiFi and the Flow Registry.
+ */
+default void createBranch(FlowRegistryClientConfigurationContext context,
final CreateBranch createBranch) throws FlowRegistryException, IOException {
Review Comment:
That is a fair point and it is making me think whether we should leave this
out initially, since I did not plan to expose any API to use this yet, and we
could always add it later with a default impl.
The reason I added this was related to the Git workflow I described in a
later comment. I was picturing a possible UX in NiFi UI where you go to `Import
Flow From Registry` screen and you choose (Branch - Bucket - Flow - Version)
and then an option to create a new branch from this and have your imported PG
track to the new branch. Essentially "create my feature branch" to work on
this, but maybe we should be punting this to an out of band process through
GitHub UI or Git command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1587909319
##
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/registry/flow/FlowAnalyzingRegistryClientNode.java:
##
@@ -401,13 +401,33 @@ public boolean isStorageLocationApplicable(final String
location) {
}
@Override
-public Set getBuckets(final
FlowRegistryClientUserContext context) throws FlowRegistryException,
IOException {
-return node.getBuckets(context);
+public boolean isBranchingSupported() {
+return node.isBranchingSupported();
}
@Override
-public FlowRegistryBucket getBucket(final FlowRegistryClientUserContext
context, final String bucketId) throws FlowRegistryException, IOException {
-return node.getBucket(context, bucketId);
+public Set getBranches(final
FlowRegistryClientUserContext context) throws FlowRegistryException,
IOException {
+return node.getBranches(context);
+}
+
+@Override
+public FlowRegistryBranch getDefaultBranch(final
FlowRegistryClientUserContext context) throws FlowRegistryException,
IOException {
+return node.getDefaultBranch(context);
+}
+
+@Override
+public void createBranch(final FlowRegistryClientUserContext context,
final CreateBranch createBranch) throws FlowRegistryException, IOException {
Review Comment:
The `CreateBranch` object is still just a data driven pojo just like
`RegisteredFlow`. I am happy to name it something that sounds less like a
command, maybe just adding `Info` to the end - `CreateBranchInfo` ?
I originally had the method as `createBranch(context, String fromBranch,
String toBranch)`, but I made the arguments an object following similar
thinking to the location objects, meaning - in the future if we have to add
another argument, we don't have to break the API signature of `createBranch`,
we just add another field to the `CreateBranch` object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on PR #8463: URL: https://github.com/apache/nifi/pull/8463#issuecomment-2090939791 > Can we just drop the old Kafka processors and go all in on the latest release? At this point the client libraries have stabilized greatly and us supporting the older stuff feels far less important and worthwhile now. It was difficult to tease out all of the business logic from the existing processor set. Some logic is there because of actual user need, and some is there because of the way Kafka and NiFi evolved alongside each other. It seems like the happy path works well for the new components, but not sure about all of the possible runtime permutations. In my mind, we’re only talking about the 2.6 processor set; the previous implementations aren’t available in the development executable. It does seem like a good idea to stop investing in enhancements to the 2.6 processors. The 2.6 work in this PR is only scaffolding, intended to better understand runtime processor behavior so it can be reproduced in the new components. The concern for me is that if we drop the 2.6 set as part of this PR, we’ll make things harder for users during the transition period, in case some important edge case is missed. It would also complicate this PR. I’d like to pitch the idea of a transition period where both sets of components exist, to facilitate transition, and to provide a simple fallback if needed. Longer term, it makes a lot of sense for 2.6 to go the way of 2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13127) Support branch selection for registry providers that offer branching
Rob Fellows created NIFI-13127: -- Summary: Support branch selection for registry providers that offer branching Key: NIFI-13127 URL: https://issues.apache.org/jira/browse/NIFI-13127 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows This is intended to be the UI portion of NIFI-13120. There is a Pull Request available: [https://github.com/apache/nifi/pull/8726] Essentially what is needed is that the the registry client supports branching, a new branch dropdown should be inserted between the registry selection and the bucket selection. Changing the registry should reload the branches, changing the branch should reload the buckets and so forth. Impacted areas would be: * Import from registry * Start Version Control * Change Version dialog - read only display of the branch * Commit local changes dialog - read only display of the branch -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated MINIFICPP-2346:
Description:
*NOTE:* I noticed you guys recently switched from 0.15 to 0.99, so at certain
point, I will pull in lastest updates from MiNiFi C++ main branch on parent
level and rebase or merge into my PR.
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
Here is my draft PR for this Jira Ticket for your reference:
[https://github.com/apache/nifi-minifi-cpp/pull/1775]
* I have added *abseil* external lib dependency to conanfile.py and integrated
it into Abseil.cmake with conditional statement that checks if
USE_CONAN_PACKAGER minifi cpp option is true else checks if
USE_CMAKE_FETCH_CONTENT option is true for backward compatibility, so we can
began the process of integrating in conan version 2.
Here are the commands that I run:
{code:java}
cd $HOME/src/pipeline/nifi-minifi-cpp
# NOTE: I also plan to add smoother integration of conan commands into MiNiFI
CPP too
# For instance, I know you guys have your bootstrap scripts too
# You also have your github actions workflow scripts too
conan install . --output-folder=build
-pr=$HOME/src/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
cd build/
cmake ..
make -j $(nproc){code}
Tracking Prebuilt Binary Conan Packages Available on Conancenter:
* 'abseil/20230125.3',
* 'argparse/3.0',
* 'asio/1.30.2'
Tracking Conan Packages Not Available on Conancenter, so we need to use an
alternative hosting service to manage building package sources into prebuilt
binary conan packages. Here are some of the free conan hosting services for
open-source C/C++ projects:
* {*}Conan Center Index (CCI){*}: official, free, centralized repo for conan
packages maintained by conan team
* Bincrafters Bintray Repo: community-driven repo that hosts large number of
pre-built conan packages for open-source libraries for free
* Artifactory by JFrog: typically used as a commercial hosting service, but
also provides a free tier for open-source projects.
*
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1587901450
##
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java:
##
@@ -4040,14 +4045,20 @@ public void verifyCanSaveToFlowRegistry(final String
registryId, final String bu
// Flow ID matches. We want to publish the Process Group as
the next version of the Flow, so we must
// ensure that all other parameters match as well.
+
+if (branch != null && !Objects.equals(branch,
vci.getBranch())) {
Review Comment:
I'll take a look at this, but this is basically the same as the existing
checks that are here to ensure that a new version being saved is not changing
the bucketId/flowId/etc that it is already tracking against. The only
difference here is that branch is optional when submitting the save, so we need
to check that its not null. If its null, then the code during register will
correctly select either the existing branch from VCI, or the default branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1587893025
##
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java:
##
@@ -4022,7 +4027,7 @@ private VersionedFlowSynchronizationContext
createGroupSynchronizationContext(fi
}
@Override
-public void verifyCanSaveToFlowRegistry(final String registryId, final
String bucketId, final String flowId, final String saveAction) {
+public void verifyCanSaveToFlowRegistry(final String registryId, final
String branch, final String bucketId, final String flowId, final String
saveAction) {
Review Comment:
You are probably right, I'll take a look at this. It was hard to determine
at which points were the correct place to use the objects outside of the
FlowRegistryClient API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1587892003
##
nifi-extension-bundles/nifi-flow-registry-client-bundle/nifi-flow-registry-client-services/src/main/java/org/apache/nifi/registry/flow/NifiRegistryFlowRegistryClient.java:
##
@@ -149,7 +149,7 @@ public boolean isStorageLocationApplicable(final
FlowRegistryClientConfiguration
}
@Override
-public Set getBuckets(final
FlowRegistryClientConfigurationContext context) throws FlowRegistryException,
IOException {
+public Set getBuckets(final
FlowRegistryClientConfigurationContext context, final String branch) throws
FlowRegistryException, IOException {
Review Comment:
I would say it is really up to the implementation to decide. We could have
all the methods in NiFi registry check the incoming branch argument, and
validate that it equals the same name as the default branch, but I don't think
it is providing much value since none of the methods are using the branch.
Can you clarify what you mean about `getFlowContents` ? I believe that
method is unchanged in the NiFi Registry implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1587884737
##
nifi-api/src/main/java/org/apache/nifi/registry/flow/BucketLocation.java:
##
@@ -0,0 +1,54 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under one or more
+ * * contributor license agreements. See the NOTICE file distributed with
+ * * this work for additional information regarding copyright ownership.
+ * * The ASF licenses this file to You under the Apache License, Version 2.0
+ * * (the "License"); you may not use this file except in compliance with
+ * * the License. You may obtain a copy of the License at
+ * *
+ * * http://www.apache.org/licenses/LICENSE-2.0
+ * *
+ * * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ *
+ */
+
+package org.apache.nifi.registry.flow;
+
+/**
+ * Information for locating a bucket in a flow registry.
+ */
+public class BucketLocation {
+
+private String branch;
Review Comment:
Great question...
The way it is currently designed, branch is the first argument that needs to
be chosen in order to then determine the buckets. For example, in Git/GitHub, a
Bucket is just a top-level directory in the repo. So in order to know what
top-level directories exist, you need to list the contents of the repo on a
given branch.
Also, in the current design, once a process group is under version control,
either by `Import From Registry` or `Start Version Control`, at that point the
branch of the PG can't change, just like you can't change Bucket. So you can't
have a PG tracking to `Branch1 - Bucket1` and then all of a sudden change it to
`Branch2` where you are worried about maybe `Bucket1` doesn't exist.
The GitHub workflow I have been testing is something like the following...
- Lets assume the Git repo has the branch `main` and already has a flow
named `My Flow` in `My Bucket`
- `Production` NiFi has a process group that imported this flow from `main`
- Some user wants to make a change to this flow...
- They go to GitHub, or command line Git, and they create a new branch
from `main` called `flow-change-1` (or whatever)
- At this point the branch `flow-change-1` has the same buckets and flows
as `main`
- They go the `Development` NiFi, or their laptop, and they `Import Flow
From Registry` and choose the `flow-change-1` - `My Bucket` - `My Flow` -
latest version
- They make changes and commit the next version which commits to
`flow-change-1` branch
- They go to GitHub UI and raise a PR from `flow-change-1` to `main`
- Someone else reviews the PR and merges to `main`
- Someone else goes to `Production` NiFi and now sees a new version
available for the PG tracking to `main`
- They do Change Flow Version to the new version
- At this point maybe the PG in the `Dev` NiFi is deleted because it was a
temporary feature branch, or maybe this process it iterated for more changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (NIFI-13126) Add Impala DB Adapter
[ https://issues.apache.org/jira/browse/NIFI-13126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajmund Takacs reassigned NIFI-13126: - Assignee: Rajmund Takacs > Add Impala DB Adapter > - > > Key: NIFI-13126 > URL: https://issues.apache.org/jira/browse/NIFI-13126 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 2.0.0-M1, 1.24.0, 1.25.0, 2.0.0-M2 >Reporter: Rajmund Takacs >Assignee: Rajmund Takacs >Priority: Major > Labels: feature > > PutDatabaseRecord standard processor is familiar with various SQL dialects, > that the user can set during configuration to match their DBCP connection. > Unfortunately Apache Impala dialect is not supported. Most of the operations > work with MySQL dialect, but for example UPSERT does not. > Please add support for Impala too. Thanks. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13126) Add Impala DB Adapter
Rajmund Takacs created NIFI-13126: - Summary: Add Impala DB Adapter Key: NIFI-13126 URL: https://issues.apache.org/jira/browse/NIFI-13126 Project: Apache NiFi Issue Type: New Feature Components: Extensions Affects Versions: 2.0.0-M2, 1.25.0, 1.24.0, 2.0.0-M1 Reporter: Rajmund Takacs PutDatabaseRecord standard processor is familiar with various SQL dialects, that the user can set during configuration to match their DBCP connection. Unfortunately Apache Impala dialect is not supported. Most of the operations work with MySQL dialect, but for example UPSERT does not. Please add support for Impala too. Thanks. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2346: Replace CMake FetchContent with Conan Packager for Faster Builds [nifi-minifi-cpp]
szaszm commented on PR #1775: URL: https://github.com/apache/nifi-minifi-cpp/pull/1775#issuecomment-2090806035 1.0.0 will be released some time after NiFi 2.0, but there is no clear target date. We were just discussing the idea (so no commitment), as third party library builds are already taking up the majority of the build time. I think someone would have given it a second try in the following months. I did a first try of moving everything to Conan 2-3 years ago, but it quickly got too complex. Me not being very familiar with Conan probably didn't help it. Thanks for the contribution! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2346: Replace CMake FetchContent with Conan Packager for Faster Builds [nifi-minifi-cpp]
james94 commented on PR #1775: URL: https://github.com/apache/nifi-minifi-cpp/pull/1775#issuecomment-2090795945 @szaszm thanks for sharing the requirements and what you guys are looking for to make this PR viable. I will shift the updates to meet those requirements. I appreciate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2346: Replace CMake FetchContent with Conan Packager for Faster Builds [nifi-minifi-cpp]
james94 commented on PR #1775: URL: https://github.com/apache/nifi-minifi-cpp/pull/1775#issuecomment-2090790581 @lordgamez thanks for the suggestion, I'll switch the default option to USE_FETCH_CONTENT for now. I'm excited to hear it was planned for 1.0.0 release to bring this feature to the build infrastructure. When is the planned release date, so I can track that target date? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13125) UI - Add view for comparing different versions of registered flows
Shane Ardell created NIFI-13125: --- Summary: UI - Add view for comparing different versions of registered flows Key: NIFI-13125 URL: https://issues.apache.org/jira/browse/NIFI-13125 Project: Apache NiFi Issue Type: New Feature Components: Core UI Reporter: Shane Ardell Assignee: Shane Ardell NIFI-13030 adds a new endpoint for comparing different versions of registered flows. A new view should be added to the UI for users to compare different versions. This should list out all the differences returned from the backend and allow a user to choose between different versions. +Notes:+ - Selecting the same version for both sides of the comparison will display a message indicating no differences between the two versions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13124) PutSQL: when AUTO_COMMIT property equals "No value set", an NPE occurs
Jim Steinebrey created NIFI-13124: - Summary: PutSQL: when AUTO_COMMIT property equals "No value set", an NPE occurs Key: NIFI-13124 URL: https://issues.apache.org/jira/browse/NIFI-13124 Project: Apache NiFi Issue Type: Bug Components: Extensions Affects Versions: 1.25.0 Reporter: Jim Steinebrey Assignee: Jim Steinebrey If user manually sets PutSQL property called "Database Session AutoCommit" to "No value set", then when a flow file attempts to be processed, a NullPointerException is thrown -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
simonbence commented on PR #8726: URL: https://github.com/apache/nifi/pull/8726#issuecomment-2090578311 > Hi @simonbence ! I have been working on a GitHub based registry client and this evolved from that. > > In my first iteration I had a property called "Branch" on the GH Registry Client, which does work fine, but it means that all operations on the client are tied to that one branch, which means just to import or save to a different branch you need multiple registry clients per branch which didn't feel correct. > > Branch really needs to be another parameter to all the methods the way that we send in some combination of bucketId, flowId, version. So I refactored some of the methods to consolidate all the String arguments into "location" objects to reduce the number of arguments per method, and also to hopefully avoid needing to change method signatures in the future if a new argument is needed. The new branch methods all provide default implementations so any existing registry clients can ignore those if they don't care about branching. > > I'm not sure when the UI can be updated, but the end goal would be for the screens where you save/import to/from a registry client, that you would see: > > * Registry Client > * Branch > * Bucket > * Flow > * Versions list > > For now branch is an optional field when saving/importing, and if not specified then the backend will call `getDefaultBranch` from the client and use that. > > For NiFi Registry, I doubt that we will implement branching there, although its possible some day, so for now the branch argument is mostly just passed around and not used when interacting with NiFi Registry. > > This PR on it's own is a little hard to test the branching changes, but the main thing would be making sure that no regressions happen when using NiFi Registry, which I did do a bit of testing. After this is merged then I can submit the GH Registry Client and then further testing can be done using branches there. Thanks for the quick and comprehensive answer! I really like the "location" idea. I left a couple of comments but I think part of my questions might have answered by this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2345 Upgrade CI matrix [nifi-minifi-cpp]
martinzink commented on code in PR #1776: URL: https://github.com/apache/nifi-minifi-cpp/pull/1776#discussion_r1587692280 ## docker/centos/Dockerfile: ## Review Comment: Reverted the centos7 removal, but without testing that will probably break in the future. (but centos7 eol is already upon us so thats might not be an issue) ## docker/focal/Dockerfile: ## Review Comment: Its not tested and it seems broken since ~2023.06. I've refreshed the README.md so it communicates clearly that instead of multiple docker builds we now recommend building a distro-agnostic binary. https://github.com/apache/nifi-minifi-cpp/pull/1776/commits/4ab03d512124bef024e97ce3af7364a0f43a09a6#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13123) [MiNiFi] Async C2 Operation Queue
Ferenc Kis created NIFI-13123: - Summary: [MiNiFi] Async C2 Operation Queue Key: NIFI-13123 URL: https://issues.apache.org/jira/browse/NIFI-13123 Project: Apache NiFi Issue Type: Improvement Components: MiNiFi Affects Versions: 2.0.0-M2 Reporter: Ferenc Kis Assignee: Ferenc Kis In case of complex ACK logics / multiple callback, the heartbeat is blocked till the whole ACK is processed. This might cause the agent to become offline if it reaches the specified threshold. The ACK operation should be async. We should use an async operation queue in the agent and process elements from that queue synchronously. Note: Take care of the case when restart needed (update configuration), heartbeats should be turned off in that case -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
simonbence commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1587603716
##
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java:
##
@@ -4022,7 +4027,7 @@ private VersionedFlowSynchronizationContext
createGroupSynchronizationContext(fi
}
@Override
-public void verifyCanSaveToFlowRegistry(final String registryId, final
String bucketId, final String flowId, final String saveAction) {
+public void verifyCanSaveToFlowRegistry(final String registryId, final
String branch, final String bucketId, final String flowId, final String
saveAction) {
Review Comment:
Should not the newly created `FlowLocation` used? If I am correct, branch,
bucket id and flow id covers just the same set of info as `FlowLocation`s state
covers.
##
nifi-extension-bundles/nifi-flow-registry-client-bundle/nifi-flow-registry-client-services/src/main/java/org/apache/nifi/registry/flow/NifiRegistryFlowRegistryClient.java:
##
@@ -149,7 +149,7 @@ public boolean isStorageLocationApplicable(final
FlowRegistryClientConfiguration
}
@Override
-public Set getBuckets(final
FlowRegistryClientConfigurationContext context) throws FlowRegistryException,
IOException {
+public Set getBuckets(final
FlowRegistryClientConfigurationContext context, final String branch) throws
FlowRegistryException, IOException {
Review Comment:
What is the expectation against requests for "non-existing" branches? (In
case of the NiFiRegistry this should be always the default and I think it is
planned to enforce this from UI but do we want to have server-side validation
and failure for cases with different branch or we want branch parameter
completely ignored for NiFiRegistry)
The question comes from that in `getFlowContents` we do not ignore it. It
could be shortcutted to be main but it is handled properly, which somewhat
different from the branch handling in other methods.
##
nifi-api/src/main/java/org/apache/nifi/registry/flow/FlowRegistryClient.java:
##
@@ -71,30 +74,82 @@ public interface FlowRegistryClient extends
ConfigurableComponent {
*/
boolean isStorageLocationApplicable(FlowRegistryClientConfigurationContext
context, String location);
+/**
+ * Indicates if the registry supports branching.
+ *
+ * @param context Configuration context
+ * @return true if the registry supports branching, false otherwise
+ */
+default boolean isBranchingSupported(final
FlowRegistryClientConfigurationContext context) {
+return false;
+}
+
+/**
+ * Get the available branches. Should return at least one branch that
matches the response of getDefaultBranch.
+ *
+ * @param context Configuration context
+ * @return the set of available branches
+ *
+ * @throws FlowRegistryException If an issue happens during processing the
request.
+ * @throws IOException If there is issue with the communication between
NiFi and the Flow Registry.
+ */
+default Set getBranches(final
FlowRegistryClientConfigurationContext context) throws FlowRegistryException,
IOException {
+return Set.of(getDefaultBranch(context));
+}
+
+/**
+ * Gets the default branch. Must return a non-null FlowRegistryBranch
instance with a non-null name.
Review Comment:
I think it might worth mentioning that in case of the impementation does not
support branching, a default value will be returned for convinience.
##
nifi-api/src/main/java/org/apache/nifi/registry/flow/CreateBranch.java:
##
@@ -0,0 +1,53 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under one or more
+ * * contributor license agreements. See the NOTICE file distributed with
+ * * this work for additional information regarding copyright ownership.
+ * * The ASF licenses this file to You under the Apache License, Version 2.0
+ * * (the "License"); you may not use this file except in compliance with
+ * * the License. You may obtain a copy of the License at
+ * *
+ * * http://www.apache.org/licenses/LICENSE-2.0
+ * *
+ * * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ *
+ */
+
+package org.apache.nifi.registry.flow;
+
+/**
+ * Information for creating a branch in a flow registry.
+ */
+public class CreateBranch {
+
+private String fromBranch;
+private String newBranch;
+
+public CreateBranch() {
+}
+
+public CreateBranch(final String fromBranch, final String newBranch) {
+this.fromBranch = fromBranch;
Review Comment:
When we do create a branch, is
Re: [PR] MINIFICPP-2345 Upgrade CI matrix [nifi-minifi-cpp]
martinzink commented on code in PR #1776:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1776#discussion_r1587688057
##
docker/rockylinux/Dockerfile:
##
@@ -40,26 +40,30 @@ COPY . ${MINIFI_BASE_DIR}
# Install the system dependencies needed for a build
# gpsd-devel and ccache are in EPEL
-RUN dnf -y install epel-release && dnf -y install sudo git which make
libarchive ccache ca-certificates perl && \
+RUN dnf -y install epel-release && dnf -y install gcc-toolset-12 sudo git
which make libarchive ccache ca-certificates perl patch bison flex libtool
cmake && \
+if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_ALL=ON"; then dnf -y
--enablerepo=devel install gpsd-devel libpng-devel libusbx-devel python3-devel
java-1.8.0-openjdk maven libpcap-devel; fi && \
if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_GPS=ON"; then dnf -y install
gpsd-devel; fi && \
if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_JNI=ON"; then dnf -y install
java-1.8.0-openjdk maven; fi && \
-if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_PCAP=ON"; then dnf -y install
libpcap-devel; fi && \
+if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_PCAP=ON"; then dnf -y
--enablerepo=devel install libpcap-devel; fi && \
if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_USB_CAMERA=ON"; then dnf -y
install libpng-devel libusbx-devel; fi && \
if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_PYTHON_SCRIPTING=ON"; then dnf
-y install python3-devel; fi && \
if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_SFTP=ON" && [
"${DOCKER_SKIP_TESTS}" == "OFF" ]; then dnf -y install java-1.8.0-openjdk
maven; fi
RUN cd $MINIFI_BASE_DIR && \
-./bootstrap.sh -t && \
ln -s /usr/bin/ccache /usr/lib64/ccache/c++
# Setup minificpp user
RUN groupadd -g ${GID} ${USER} && useradd -g ${GID} ${USER} && \
chown -R ${USER}:${USER} ${MINIFI_BASE_DIR}
+RUN ls -lah ${MINIFI_BASE_DIR}/docker
+RUN patch -p1
/opt/rh/gcc-toolset-12/root/usr/include/c++/12/bits/basic_string.tcc
${MINIFI_BASE_DIR}/thirdparty/libstdc++/avoid_bogus_Wrestrict_PR105651.patch
Review Comment:
good catch, that was only some debugging leftover
##
libminifi/src/utils/Cron.cpp:
##
@@ -50,7 +50,7 @@ namespace {
// the month parsing with '%b' and the weekday parsing with '%a' is
case-sensitive in gcc11
// This has been fixed in gcc12.2
std::stringstream getCaseInsensitiveCStream(const std::string& str) {
-#if defined(__GNUC__) && (__GNUC__ < 12 || (__GNUC__ == 12 && __GNUC_MINOR__ <
2))
+#if defined(__GNUC__) && (__GNUC__ < 12 || (__GNUC__ == 12 && __GNUC_MINOR__ <
3))
Review Comment:
actualized the comment in
https://github.com/apache/nifi-minifi-cpp/pull/1776/commits/4ab03d512124bef024e97ce3af7364a0f43a09a6#diff-977a7d8d2ef0da59036a2e53f02f087ea0b5c962d8d3bad8a5c566d3842c322dR51
##
.github/workflows/ci.yml:
##
@@ -72,35 +72,34 @@ jobs:
uses: actions/cache/restore@v4
with:
path: ${{ env.CCACHE_DIR }}
- key: macos-xcode-ccache-${{github.ref}}-${{github.sha}}
+ key: macos-arm-xcode-ccache-${{github.ref}}-${{github.sha}}
restore-keys: |
-macos-xcode-ccache-${{github.ref}}-
-macos-xcode-ccache-refs/heads/main-
+macos-arm-xcode-ccache-${{github.ref}}-
+macos-arm-xcode-ccache-refs/heads/main-
- id: install_dependencies
run: |
# Skip brew update until
https://github.com/actions/setup-python/issues/577 is fixed
- # brew update
- HOMEBREW_NO_AUTO_UPDATE=1 brew install ossp-uuid bison flex ccache
sqliteodbc automake autoconf ninja
+ brew update
Review Comment:
:+1:
https://github.com/apache/nifi-minifi-cpp/pull/1776/commits/4ab03d512124bef024e97ce3af7364a0f43a09a6#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13122) [BUG] - select all parameter checkbox is not visible
Scott Aslan created NIFI-13122: -- Summary: [BUG] - select all parameter checkbox is not visible Key: NIFI-13122 URL: https://issues.apache.org/jira/browse/NIFI-13122 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Attachments: Screenshot 2024-05-02 at 9.51.25 AM.png, Screenshot 2024-05-02 at 9.51.32 AM.png, Screenshot 2024-05-02 at 9.51.38 AM.png the checkbox we use to support select all, select none, or indicate some are selected isn't clearly defined when checked or indicating some are selected. It isn't immediately apparent that you can interact with it. It is fine when nothing is selected because it has an outline: !Screenshot 2024-05-02 at 9.51.25 AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13093) better align nifi warn and material warn palettes
[ https://issues.apache.org/jira/browse/NIFI-13093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13093: --- Resolution: Fixed Status: Resolved (was: Patch Available) > better align nifi warn and material warn palettes > - > > Key: NIFI-13093 > URL: https://issues.apache.org/jira/browse/NIFI-13093 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > When to use which palette? Or can we combine into a single palette? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13093) better align nifi warn and material warn palettes
[ https://issues.apache.org/jira/browse/NIFI-13093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842973#comment-17842973 ] ASF subversion and git services commented on NIFI-13093: Commit 9ac17833b8050fefb6ddd3794de498282c8710b5 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=9ac17833b8 ] [NIFI-13093] use warn palette for all errors and introduce caution palette (#8721) * [NIFI-13093] use warn palette for all errors and introduce caution palette * update semantic color names * update warn palette darker hue * import ErrorBanner component into cluster.component.spec.ts * .primary-contrast * some code clean up and reuse of .surface-contrast * caution color cleanup * update bulletin to use inverted contrast color and semantic caution-color class This closes #8721 > better align nifi warn and material warn palettes > - > > Key: NIFI-13093 > URL: https://issues.apache.org/jira/browse/NIFI-13093 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > When to use which palette? Or can we combine into a single palette? -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13093] use warn palette for all errors and introduce caution palette [nifi]
rfellows merged PR #8721: URL: https://github.com/apache/nifi/pull/8721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-13084) Backport Allow Disabling Scientific Notation in JSON Writer
[ https://issues.apache.org/jira/browse/NIFI-13084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy resolved NIFI-13084. Fix Version/s: 1.26.0 Resolution: Fixed > Backport Allow Disabling Scientific Notation in JSON Writer > > > Key: NIFI-13084 > URL: https://issues.apache.org/jira/browse/NIFI-13084 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Zsihovszki Krisztina >Assignee: Zsihovszki Krisztina >Priority: Major > Fix For: 1.26.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The changes made for NIFI-12697 were only committed on the 2.x branch and not > backported to the support/nifi-1.x branch. The purpose of this ticket is to > backport the code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13093] use warn palette for all errors and introduce caution palette [nifi]
scottyaslan commented on PR #8721: URL: https://github.com/apache/nifi/pull/8721#issuecomment-2090483016 > Overall this looks great. I did find one thing that we might want to clean up but I'm also happy if we just want to log it and fix as part of another pull request... > > Essentially, in dark mode, the checkbox we use to support select all, select none, or indicate some are selected isn't clearly defined when checked or indicating some are selected. It isn't immediately apparent that you can interact with it. It is fine when nothing is selected because it has an outline: > > https://private-user-images.githubusercontent.com/713866/327430128-18a9644b-079e-4c17-8966-51f0fac87880.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ2NTYxOTUsIm5iZiI6MTcxNDY1NTg5NSwicGF0aCI6Ii83MTM4NjYvMzI3NDMwMTI4LTE4YTk2NDRiLTA3OWUtNGMxNy04OTY2LTUxZjBmYWM4Nzg4MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNTAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDUwMlQxMzE4MTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNDU2NjZjNTMwNmE4OWZmZDMzZDhmYTY0NzI1NzM3OGI5ZmU2MGVkZTkzYmMzNWNhYjU0ZGZhNmNkYmRmMzYzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.ypA42Ik4DLHAMzsbO69Qcb93Sn0NbTRfiTRR3SWiFpI;> https://private-user-images.githubuserconte nt.com/713866/327430171-dc15d0e5-74f2-486a-a370-35b57925ed02.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ2NTYxOTUsIm5iZiI6MTcxNDY1NTg5NSwicGF0aCI6Ii83MTM4NjYvMzI3NDMwMTcxLWRjMTVkMGU1LTc0ZjItNDg2YS1hMzcwLTM1YjU3OTI1ZWQwMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNTAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDUwMlQxMzE4MTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iNjdiYmM0MmNhZTExZDhiNGY1M2Y2MTU0Yzk1NDRlNTUyMDAwY2Y5MjRkNzI0ZjQxYmNkMzYzMDVkMzM0OTMxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.pBzeNEpPZIqFXJoJyWrzdwx23eVwZ3LMnngvxJxb3BQ"> https://private-user-images.githubusercontent.com/713866/327430190-d2778102-9feb-4073-9b10-fdaafbc03bb6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3Mi OiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ2NTYxOTUsIm5iZiI6MTcxNDY1NTg5NSwicGF0aCI6Ii83MTM4NjYvMzI3NDMwMTkwLWQyNzc4MTAyLTlmZWItNDA3My05YjEwLWZkYWFmYmMwM2JiNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNTAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDUwMlQxMzE4MTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ZDliM2MyYWNkNGI5ZmY4NjlhYWVjNDIzY2JjMTZmMTA0YzJlYjMxMzJkOWZhMzI5MmE0NzNiOWVkNWQ2ZjBhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.7XVxE_ECAQT3bBRzwjVEhbRPusDvfRY18xeoeV689J8"> > @scottyaslan let me know if you want to include a fix for this here or if we should log it separately. Ooo good eye! Let's log it as a separate jira. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on PR #8726: URL: https://github.com/apache/nifi/pull/8726#issuecomment-2090466214 Hi @simonbence ! I have been working on a GitHub based registry client and this evolved from that. In my first iteration I had a property called "Branch" on the GH Registry Client, which does work fine, but it means that all operations on the client are tied to that one branch, which means just to import or save to a different branch you need multiple registry clients per branch which didn't feel correct. Branch really needs to be another parameter to all the methods the way that we send in some combination of bucketId, flowId, version. So I refactored some of the methods to consolidate all the String arguments into "location" objects to reduce the number of arguments per method, and also to hopefully avoid needing to change method signatures in the future if a new argument is needed. The new branch methods all provide default implementations so any existing registry clients can ignore those if they don't care about branching. I'm not sure when the UI can be updated, but the end goal would be for the screens where you save/import to/from a registry client, that you would see: - Registry Client - Branch - Bucket - Flow - Versions list For now branch is an optional field when saving/importing, and if not specified then the backend will call `getDefaultBranch` from the client and use that. For NiFi Registry, I doubt that we will implement branching there, although its possible some day, so for now the branch argument is mostly just passed around and not used when interacting with NiFi Registry. This PR on it's own is a little hard to test the branching changes, but the main thing would be making sure that no regressions happen when using NiFi Registry, which I did do a bit of testing. After this is merged then I can submit the GH Registry Client and then further testing can be done using branches there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13104] Unknown Route handling [nifi]
mcgilman commented on code in PR #8725:
URL: https://github.com/apache/nifi/pull/8725#discussion_r1587561028
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/service/error-helper.service.ts:
##
@@ -78,4 +78,18 @@ export class ErrorHelper {
return this.fullScreenError(errorResponse);
}
}
+
+getErrorString(errorResponse: HttpErrorResponse, prefix?: string): string {
+let errorMessage = 'An unspecified error occurred.';
+if (errorResponse.error && errorResponse.status !== 0) {
+errorMessage = errorResponse.error;
+} else if (!errorResponse.error && errorResponse.status !== 0) {
+errorMessage = errorResponse.message || `${errorResponse.status}`;
+}
Review Comment:
```suggestion
if (errorResponse.status !== 0) {
if (errorResponse.error) {
errorMessage = errorResponse.error;
} else {
errorMessage = errorResponse.message ||
`${errorResponse.status}`;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2346: Replace CMake FetchContent with Conan Packager for Faster Builds [nifi-minifi-cpp]
szaszm commented on PR #1775: URL: https://github.com/apache/nifi-minifi-cpp/pull/1775#issuecomment-2090424252 There are a few things we would need for this to be viable: - The python bootstrap should be updated to support selecting each extension with its dependencies installed from Conan vs FetchContent - I think CMake should be updated to allow selecting the dependency source on a per-extension basis. This is also needed to implement the first point. - (optional) If we're doing the per-extension dependency source selection, a normal find_package could be added as well, to use the system version of libs. This may not be trivial to get working, but if it works at least at a few places, it can be an easy win. - I wouldn't flood FetchContent users with "SLOW" messages. Until we can ensure that all dependencies have viable binary packages on conan center, there isn't necessarily a build speed difference. We need to discuss how to handle these cases with Conan. And even after we can ensure binary packages for all major targets, FetchContent can still be a viable option, even if it builds the packages. Let's see how this progresses, these can be done separately as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13119: When evaluating dependent Properties, the UI should identify when the Property value is a parameter reference and resolve the value accordingly [nifi]
rfellows commented on PR #8724: URL: https://github.com/apache/nifi/pull/8724#issuecomment-2090422886 reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13104] Unknown Route handling [nifi]
mcgilman commented on PR #8725: URL: https://github.com/apache/nifi/pull/8725#issuecomment-2090383228 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2346: Replace CMake FetchContent with Conan Packager for Faster Builds [nifi-minifi-cpp]
lordgamez commented on PR #1775: URL: https://github.com/apache/nifi-minifi-cpp/pull/1775#issuecomment-2090368183 Hi @james94, thanks for the heads up, this is great stuff you have here! Last week we actually talked about having this feature implemented as part of the 1.0.0 release, so it is awesome you've already started working on this. For the first iteration I would probably stick to having the old behaviour as the default and have a separate CI job with the `USE_CONAN_PACKAGER` variable enabled to test the build using Conan thirdparty packages. If the `USE_CONAN_PACKAGER` is `OFF` then everything would be built as it is at the moment, so probably the `USE_CMAKE_FETCH_CONTENT` wouldn't be needed. But these are just small details that can be discussed on the review after the PR is ready, can't wait to see more of it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
simonbence commented on PR #8726: URL: https://github.com/apache/nifi/pull/8726#issuecomment-2090279180 Hi @bbende ! It looks to be a very nice addition. Is there any discussion or description could help me understand the gist of it before looking into the code in detail? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2356) Kafka docker tests fail with zookeeper connection issue
[
https://issues.apache.org/jira/browse/MINIFICPP-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz updated MINIFICPP-2356:
Fix Version/s: 0.99.0
> Kafka docker tests fail with zookeeper connection issue
> ---
>
> Key: MINIFICPP-2356
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2356
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Major
> Fix For: 0.99.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Kafka broker fails to start up in docker tests with the following issue,
> failing to connect to Zookeeper:
> {code:java}
> [2024-05-02 08:22:54,358] INFO [ZooKeeperClient Kafka server] Waiting until
> connected. (kafka.zookeeper.ZooKeeperClient)
> [2024-05-02 08:22:54,387] INFO Opening socket connection to server
> 172.17.0.1/172.17.0.1:2181. (org.apache.zookeeper.ClientCnxn)
> [2024-05-02 08:22:54,388] INFO SASL config status: Will not attempt to
> authenticate using SASL (unknown error) (org.apache.zookeeper.ClientCnxn)
> [2024-05-02 08:23:00,361] INFO [ZooKeeperClient Kafka server] Closing.
> (kafka.zookeeper.ZooKeeperClient)
> [2024-05-02 08:23:12,372] WARN Client session timed out, have not heard from
> server in 18012ms for session id 0x0 (org.apache.zookeeper.ClientCnxn)
> [2024-05-02 08:23:12,375] WARN An exception was thrown while closing send
> thread for session 0x0. (org.apache.zookeeper.ClientCnxn)
> org.apache.zookeeper.ClientCnxn$SessionTimeoutException: Client session timed
> out, have not heard from server in 18012ms for session id 0x0
> at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1258)
> [2024-05-02 08:23:12,485] INFO Session: 0x0 closed
> (org.apache.zookeeper.ZooKeeper)
> [2024-05-02 08:23:12,486] INFO EventThread shut down for session: 0x0
> (org.apache.zookeeper.ClientCnxn)
> [2024-05-02 08:23:12,487] INFO [ZooKeeperClient Kafka server] Closed.
> (kafka.zookeeper.ZooKeeperClient)
> [2024-05-02 08:23:12,489] ERROR Fatal error during KafkaServer startup.
> Prepare to shutdown (kafka.server.KafkaServer)
> kafka.zookeeper.ZooKeeperClientTimeoutException: Timed out waiting for
> connection while in state: CONNECTING
> at
> kafka.zookeeper.ZooKeeperClient.waitUntilConnected(ZooKeeperClient.scala:254)
> at kafka.zookeeper.ZooKeeperClient.(ZooKeeperClient.scala:108)
> at kafka.zk.KafkaZkClient$.apply(KafkaZkClient.scala:1981)
> at kafka.server.KafkaServer.initZkClient(KafkaServer.scala:491)
> at kafka.server.KafkaServer.startup(KafkaServer.scala:201)
> at kafka.Kafka$.main(Kafka.scala:109)
> at kafka.Kafka.main(Kafka.scala)
> [2024-05-02 08:23:12,490] INFO shutting down (kafka.server.KafkaServer)
> [2024-05-02 08:23:12,496] INFO App info kafka.server for 1 unregistered
> (org.apache.kafka.common.utils.AppInfoParser)
> [2024-05-02 08:23:12,497] INFO shut down completed (kafka.server.KafkaServer)
> [2024-05-02 08:23:12,497] ERROR Exiting Kafka. (kafka.Kafka$)
> [2024-05-02 08:23:12,497] INFO shutting down (kafka.server.KafkaServer) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2356) Kafka docker tests fail with zookeeper connection issue
[
https://issues.apache.org/jira/browse/MINIFICPP-2356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz resolved MINIFICPP-2356.
-
Resolution: Fixed
> Kafka docker tests fail with zookeeper connection issue
> ---
>
> Key: MINIFICPP-2356
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2356
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Kafka broker fails to start up in docker tests with the following issue,
> failing to connect to Zookeeper:
> {code:java}
> [2024-05-02 08:22:54,358] INFO [ZooKeeperClient Kafka server] Waiting until
> connected. (kafka.zookeeper.ZooKeeperClient)
> [2024-05-02 08:22:54,387] INFO Opening socket connection to server
> 172.17.0.1/172.17.0.1:2181. (org.apache.zookeeper.ClientCnxn)
> [2024-05-02 08:22:54,388] INFO SASL config status: Will not attempt to
> authenticate using SASL (unknown error) (org.apache.zookeeper.ClientCnxn)
> [2024-05-02 08:23:00,361] INFO [ZooKeeperClient Kafka server] Closing.
> (kafka.zookeeper.ZooKeeperClient)
> [2024-05-02 08:23:12,372] WARN Client session timed out, have not heard from
> server in 18012ms for session id 0x0 (org.apache.zookeeper.ClientCnxn)
> [2024-05-02 08:23:12,375] WARN An exception was thrown while closing send
> thread for session 0x0. (org.apache.zookeeper.ClientCnxn)
> org.apache.zookeeper.ClientCnxn$SessionTimeoutException: Client session timed
> out, have not heard from server in 18012ms for session id 0x0
> at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1258)
> [2024-05-02 08:23:12,485] INFO Session: 0x0 closed
> (org.apache.zookeeper.ZooKeeper)
> [2024-05-02 08:23:12,486] INFO EventThread shut down for session: 0x0
> (org.apache.zookeeper.ClientCnxn)
> [2024-05-02 08:23:12,487] INFO [ZooKeeperClient Kafka server] Closed.
> (kafka.zookeeper.ZooKeeperClient)
> [2024-05-02 08:23:12,489] ERROR Fatal error during KafkaServer startup.
> Prepare to shutdown (kafka.server.KafkaServer)
> kafka.zookeeper.ZooKeeperClientTimeoutException: Timed out waiting for
> connection while in state: CONNECTING
> at
> kafka.zookeeper.ZooKeeperClient.waitUntilConnected(ZooKeeperClient.scala:254)
> at kafka.zookeeper.ZooKeeperClient.(ZooKeeperClient.scala:108)
> at kafka.zk.KafkaZkClient$.apply(KafkaZkClient.scala:1981)
> at kafka.server.KafkaServer.initZkClient(KafkaServer.scala:491)
> at kafka.server.KafkaServer.startup(KafkaServer.scala:201)
> at kafka.Kafka$.main(Kafka.scala:109)
> at kafka.Kafka.main(Kafka.scala)
> [2024-05-02 08:23:12,490] INFO shutting down (kafka.server.KafkaServer)
> [2024-05-02 08:23:12,496] INFO App info kafka.server for 1 unregistered
> (org.apache.kafka.common.utils.AppInfoParser)
> [2024-05-02 08:23:12,497] INFO shut down completed (kafka.server.KafkaServer)
> [2024-05-02 08:23:12,497] ERROR Exiting Kafka. (kafka.Kafka$)
> [2024-05-02 08:23:12,497] INFO shutting down (kafka.server.KafkaServer) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] MINIFICPP-2356 Fix Kafka broker connection issue to Zookeeper [nifi-minifi-cpp]
szaszm closed pull request #1777: MINIFICPP-2356 Fix Kafka broker connection issue to Zookeeper URL: https://github.com/apache/nifi-minifi-cpp/pull/1777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13108 Update a variety of dependencies [nifi]
pvillard31 commented on PR #8708: URL: https://github.com/apache/nifi/pull/8708#issuecomment-2090234009 @joewitt - it feels like some of the dep upgrades included in that PR could also apply to NiFi 1.26 - are you planning for a PR that would apply to 1.x and should I wait for this before kicking off the NiFi 1.26 RC? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2345 Upgrade CI matrix [nifi-minifi-cpp]
szaszm commented on code in PR #1776:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1776#discussion_r1587428695
##
.github/workflows/ci.yml:
##
@@ -72,35 +72,34 @@ jobs:
uses: actions/cache/restore@v4
with:
path: ${{ env.CCACHE_DIR }}
- key: macos-xcode-ccache-${{github.ref}}-${{github.sha}}
+ key: macos-arm-xcode-ccache-${{github.ref}}-${{github.sha}}
restore-keys: |
-macos-xcode-ccache-${{github.ref}}-
-macos-xcode-ccache-refs/heads/main-
+macos-arm-xcode-ccache-${{github.ref}}-
+macos-arm-xcode-ccache-refs/heads/main-
- id: install_dependencies
run: |
# Skip brew update until
https://github.com/actions/setup-python/issues/577 is fixed
- # brew update
- HOMEBREW_NO_AUTO_UPDATE=1 brew install ossp-uuid bison flex ccache
sqliteodbc automake autoconf ninja
+ brew update
Review Comment:
the comment above this line should be removed
##
docker/centos/Dockerfile:
##
Review Comment:
Is there anything that necessitates the removal of centos7, while it still
works? Until we drop support, it can stick around IMO.
##
docker/focal/Dockerfile:
##
Review Comment:
I don't think we should drop focal just yet.
##
libminifi/src/utils/Cron.cpp:
##
@@ -50,7 +50,7 @@ namespace {
// the month parsing with '%b' and the weekday parsing with '%a' is
case-sensitive in gcc11
// This has been fixed in gcc12.2
std::stringstream getCaseInsensitiveCStream(const std::string& str) {
-#if defined(__GNUC__) && (__GNUC__ < 12 || (__GNUC__ == 12 && __GNUC_MINOR__ <
2))
+#if defined(__GNUC__) && (__GNUC__ < 12 || (__GNUC__ == 12 && __GNUC_MINOR__ <
3))
Review Comment:
The comment above these lines needs to be checked and updated. It states
this is fixed in 12.2, so why do we include the workaround in 12.2?
##
docker/rockylinux/Dockerfile:
##
@@ -40,26 +40,30 @@ COPY . ${MINIFI_BASE_DIR}
# Install the system dependencies needed for a build
# gpsd-devel and ccache are in EPEL
-RUN dnf -y install epel-release && dnf -y install sudo git which make
libarchive ccache ca-certificates perl && \
+RUN dnf -y install epel-release && dnf -y install gcc-toolset-12 sudo git
which make libarchive ccache ca-certificates perl patch bison flex libtool
cmake && \
+if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_ALL=ON"; then dnf -y
--enablerepo=devel install gpsd-devel libpng-devel libusbx-devel python3-devel
java-1.8.0-openjdk maven libpcap-devel; fi && \
if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_GPS=ON"; then dnf -y install
gpsd-devel; fi && \
if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_JNI=ON"; then dnf -y install
java-1.8.0-openjdk maven; fi && \
-if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_PCAP=ON"; then dnf -y install
libpcap-devel; fi && \
+if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_PCAP=ON"; then dnf -y
--enablerepo=devel install libpcap-devel; fi && \
if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_USB_CAMERA=ON"; then dnf -y
install libpng-devel libusbx-devel; fi && \
if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_PYTHON_SCRIPTING=ON"; then dnf
-y install python3-devel; fi && \
if echo "$MINIFI_OPTIONS" | grep -q "ENABLE_SFTP=ON" && [
"${DOCKER_SKIP_TESTS}" == "OFF" ]; then dnf -y install java-1.8.0-openjdk
maven; fi
RUN cd $MINIFI_BASE_DIR && \
-./bootstrap.sh -t && \
ln -s /usr/bin/ccache /usr/lib64/ccache/c++
# Setup minificpp user
RUN groupadd -g ${GID} ${USER} && useradd -g ${GID} ${USER} && \
chown -R ${USER}:${USER} ${MINIFI_BASE_DIR}
+RUN ls -lah ${MINIFI_BASE_DIR}/docker
+RUN patch -p1
/opt/rh/gcc-toolset-12/root/usr/include/c++/12/bits/basic_string.tcc
${MINIFI_BASE_DIR}/thirdparty/libstdc++/avoid_bogus_Wrestrict_PR105651.patch
Review Comment:
The `ls` doesn't seem necessary. The patch deserves a comment IMO, to draw
attention to the fact that we're patching the system standard headers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-13121) FetchHDFS handles runtime exceptions incorrectly
[ https://issues.apache.org/jira/browse/NIFI-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842931#comment-17842931 ] ASF subversion and git services commented on NIFI-13121: Commit d1579b4d21335c1e200de079cde151f670764c01 in nifi's branch refs/heads/support/nifi-1.x from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d1579b4d21 ] NIFI-13121: Handle runtime exceptions in FetchHDFS Signed-off-by: Joe Gresock This closes #8727. > FetchHDFS handles runtime exceptions incorrectly > > > Key: NIFI-13121 > URL: https://issues.apache.org/jira/browse/NIFI-13121 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > FetchHDFS does not catch runtime exceptions and does not route the incoming > flowfile to failure or yield as a result. This causes FetchHDFS to run over > and over (especially if the Run Schedule is 0 seconds) and can cause NiFi to > be unresponsive. > This happened to the AWS processors in NIFI-6367, the same fix needs to be > applied to FetchHDFS -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13121) FetchHDFS handles runtime exceptions incorrectly
[ https://issues.apache.org/jira/browse/NIFI-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Gresock updated NIFI-13121: --- Resolution: Fixed Status: Resolved (was: Patch Available) > FetchHDFS handles runtime exceptions incorrectly > > > Key: NIFI-13121 > URL: https://issues.apache.org/jira/browse/NIFI-13121 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > FetchHDFS does not catch runtime exceptions and does not route the incoming > flowfile to failure or yield as a result. This causes FetchHDFS to run over > and over (especially if the Run Schedule is 0 seconds) and can cause NiFi to > be unresponsive. > This happened to the AWS processors in NIFI-6367, the same fix needs to be > applied to FetchHDFS -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13121: Handle runtime exceptions in FetchHDFS [nifi]
asfgit closed pull request #8727: NIFI-13121: Handle runtime exceptions in FetchHDFS URL: https://github.com/apache/nifi/pull/8727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13121) FetchHDFS handles runtime exceptions incorrectly
[ https://issues.apache.org/jira/browse/NIFI-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842929#comment-17842929 ] ASF subversion and git services commented on NIFI-13121: Commit b6a8699b574f495cbc8ef6590929de6d91a0cd95 in nifi's branch refs/heads/main from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b6a8699b57 ] NIFI-13121: Handle runtime exceptions in FetchHDFS Signed-off-by: Joe Gresock This closes #8727. > FetchHDFS handles runtime exceptions incorrectly > > > Key: NIFI-13121 > URL: https://issues.apache.org/jira/browse/NIFI-13121 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 10m > Remaining Estimate: 0h > > FetchHDFS does not catch runtime exceptions and does not route the incoming > flowfile to failure or yield as a result. This causes FetchHDFS to run over > and over (especially if the Run Schedule is 0 seconds) and can cause NiFi to > be unresponsive. > This happened to the AWS processors in NIFI-6367, the same fix needs to be > applied to FetchHDFS -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MINIFICPP-2347 - Add path of the json node to the exception [nifi-minifi-cpp]
adamdebreceni opened a new pull request, #1778: URL: https://github.com/apache/nifi-minifi-cpp/pull/1778 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINIFICPP-2356 Fix Kafka broker connection issue to Zookeeper [nifi-minifi-cpp]
lordgamez opened a new pull request, #1777: URL: https://github.com/apache/nifi-minifi-cpp/pull/1777 - Additionally update Zookeeper image version - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2356) Kafka docker tests fail with zookeeper connection issue
Gábor Gyimesi created MINIFICPP-2356:
Summary: Kafka docker tests fail with zookeeper connection issue
Key: MINIFICPP-2356
URL: https://issues.apache.org/jira/browse/MINIFICPP-2356
Project: Apache NiFi MiNiFi C++
Issue Type: Bug
Reporter: Gábor Gyimesi
Assignee: Gábor Gyimesi
Kafka broker fails to start up in docker tests with the following issue,
failing to connect to Zookeeper:
{code:java}
[2024-05-02 08:22:54,358] INFO [ZooKeeperClient Kafka server] Waiting until
connected. (kafka.zookeeper.ZooKeeperClient)
[2024-05-02 08:22:54,387] INFO Opening socket connection to server
172.17.0.1/172.17.0.1:2181. (org.apache.zookeeper.ClientCnxn)
[2024-05-02 08:22:54,388] INFO SASL config status: Will not attempt to
authenticate using SASL (unknown error) (org.apache.zookeeper.ClientCnxn)
[2024-05-02 08:23:00,361] INFO [ZooKeeperClient Kafka server] Closing.
(kafka.zookeeper.ZooKeeperClient)
[2024-05-02 08:23:12,372] WARN Client session timed out, have not heard from
server in 18012ms for session id 0x0 (org.apache.zookeeper.ClientCnxn)
[2024-05-02 08:23:12,375] WARN An exception was thrown while closing send
thread for session 0x0. (org.apache.zookeeper.ClientCnxn)
org.apache.zookeeper.ClientCnxn$SessionTimeoutException: Client session timed
out, have not heard from server in 18012ms for session id 0x0
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1258)
[2024-05-02 08:23:12,485] INFO Session: 0x0 closed
(org.apache.zookeeper.ZooKeeper)
[2024-05-02 08:23:12,486] INFO EventThread shut down for session: 0x0
(org.apache.zookeeper.ClientCnxn)
[2024-05-02 08:23:12,487] INFO [ZooKeeperClient Kafka server] Closed.
(kafka.zookeeper.ZooKeeperClient)
[2024-05-02 08:23:12,489] ERROR Fatal error during KafkaServer startup. Prepare
to shutdown (kafka.server.KafkaServer)
kafka.zookeeper.ZooKeeperClientTimeoutException: Timed out waiting for
connection while in state: CONNECTING
at
kafka.zookeeper.ZooKeeperClient.waitUntilConnected(ZooKeeperClient.scala:254)
at kafka.zookeeper.ZooKeeperClient.(ZooKeeperClient.scala:108)
at kafka.zk.KafkaZkClient$.apply(KafkaZkClient.scala:1981)
at kafka.server.KafkaServer.initZkClient(KafkaServer.scala:491)
at kafka.server.KafkaServer.startup(KafkaServer.scala:201)
at kafka.Kafka$.main(Kafka.scala:109)
at kafka.Kafka.main(Kafka.scala)
[2024-05-02 08:23:12,490] INFO shutting down (kafka.server.KafkaServer)
[2024-05-02 08:23:12,496] INFO App info kafka.server for 1 unregistered
(org.apache.kafka.common.utils.AppInfoParser)
[2024-05-02 08:23:12,497] INFO shut down completed (kafka.server.KafkaServer)
[2024-05-02 08:23:12,497] ERROR Exiting Kafka. (kafka.Kafka$)
[2024-05-02 08:23:12,497] INFO shutting down (kafka.server.KafkaServer) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] MINIFICPP-2345 Upgrade CI matrix [nifi-minifi-cpp]
martinzink opened a new pull request, #1776: URL: https://github.com/apache/nifi-minifi-cpp/pull/1776 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
