[jira] [Created] (NIFI-13144) Update various dependencies (cloud providers, etc..)
Joe Witt created NIFI-13144: --- Summary: Update various dependencies (cloud providers, etc..) Key: NIFI-13144 URL: https://issues.apache.org/jira/browse/NIFI-13144 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt com.puppycrawl.tools:checkstyle ... 10.15.0 -> 10.16.0 software.amazon.awssdk:xray ... 2.25.40 -> 2.25.45 com.amazonaws:aws-java-sdk-keyspaces 1.12.710 -> 1.12.715 com.azure:azure-core 1.46.0 -> 1.49.0 com.google.api:api-common ... 2.18.0 -> 2.31.0 io.grpc:grpc-all 1.58.0 -> 1.63.0 [INFO] com.azure:azure-core-http-okhttp .. 1.11.18 -> 1.11.21 [INFO] com.azure:azure-security-keyvault-keys 4.8.0 -> 4.8.3 [INFO] com.azure:azure-security-keyvault-secrets . 4.8.0 -> 4.8.2 [INFO] com.google.cloud:google-cloud-kms ... 2.31.0 -> 2.45.0 [INFO] net.bytebuddy:byte-buddy .. 1.14.12 -> 1.14.14 [INFO] org.checkerframework:checker-qual ... 3.37.0 -> 3.43.0 [INFO] org.eclipse.jdt:ecj . 3.33.0 -> 3.37.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated MINIFICPP-2346:
Description:
*NOTE:* I noticed you guys recently switched from 0.15 to 0.99, so at certain
point, I will pull in lastest updates from MiNiFi C++ main branch on parent
level and rebase or merge into my PR.
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
Here is my draft PR for this Jira Ticket for your reference:
[https://github.com/apache/nifi-minifi-cpp/pull/1775]
* I have added *abseil* external lib dependency to conanfile.py and integrated
it into Abseil.cmake with conditional statement that checks if
USE_CONAN_PACKAGER minifi cpp option is true else checks if
USE_CMAKE_FETCH_CONTENT option is true for backward compatibility, so we can
began the process of integrating in conan version 2.
Here are the commands that I run:
{code:java}
cd $HOME/src/pipeline/nifi-minifi-cpp
# NOTE: I also plan to add smoother integration of conan commands into MiNiFI
CPP too
# For instance, I know you guys have your bootstrap scripts too
# You also have your github actions workflow scripts too
conan install . --output-folder=build
-pr=$HOME/src/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
# install conan packages and build C++ for minifi using Conan & CMake, we run
this way, so conan's tc.cache_variables
# are like passing -D{minifi_option} upon running cmake generate, then make
to build MiNiFi C++
conan build . --output-folder=build
-pr=/home/bizon/src/jam-repo/main/etc/build/conan/profiles/release-linux{code}
Tracking Prebuilt Binary Conan Packages Available on Conancenter:
* 'abseil/20230125.3',
* 'argparse/3.0',
* 'asio/1.30.2'
Tracking Conan Packages Not Available on Conancenter, so we need to use an
alternative hosting service to manage building package sources into prebuilt
binary conan packages. Here are some of the free conan hosting services for
open-source C/C++ projects:
* {*}Conan Center Index (CCI){*}: official, free, centralized repo for conan
packages
[jira] [Updated] (NIFI-13008) CLI command to upgrade all instances of a versioned flow
[ https://issues.apache.org/jira/browse/NIFI-13008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13008: -- Fix Version/s: 1.27.0 (was: 1.26.0) > CLI command to upgrade all instances of a versioned flow > > > Key: NIFI-13008 > URL: https://issues.apache.org/jira/browse/NIFI-13008 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > Fix For: 2.0.0-M3, 1.27.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Add a CLI command allowing someone to upgrade all the instances of a given > versioned flow. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13123 MiNiFi async C2 operation processing [nifi]
bejancsaba commented on code in PR #8738:
URL: https://github.com/apache/nifi/pull/8738#discussion_r1589847318
##
c2/c2-client-bundle/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/C2OperationManager.java:
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.c2.client.service;
+
+import static java.util.Optional.of;
+import static java.util.Optional.ofNullable;
+import static java.util.function.Predicate.not;
+import static
org.apache.nifi.c2.protocol.api.C2OperationState.OperationState.FULLY_APPLIED;
+import static
org.apache.nifi.c2.protocol.api.C2OperationState.OperationState.NOT_APPLIED;
+
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.locks.ReentrantLock;
+import org.apache.nifi.c2.client.api.C2Client;
+import org.apache.nifi.c2.client.service.operation.C2OperationHandler;
+import org.apache.nifi.c2.client.service.operation.C2OperationHandlerProvider;
+import org.apache.nifi.c2.client.service.operation.C2OperationRestartHandler;
+import org.apache.nifi.c2.client.service.operation.OperationQueue;
+import org.apache.nifi.c2.client.service.operation.OperationQueueDAO;
+import org.apache.nifi.c2.protocol.api.C2Operation;
+import org.apache.nifi.c2.protocol.api.C2OperationAck;
+import org.apache.nifi.c2.protocol.api.C2OperationState;
+import org.apache.nifi.c2.protocol.api.C2OperationState.OperationState;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class C2OperationManager implements Runnable {
+
+private static final Logger LOGGER =
LoggerFactory.getLogger(C2OperationManager.class);
+
+private final C2Client client;
+private final C2OperationHandlerProvider c2OperationHandlerProvider;
+private final ReentrantLock heartbeatLock;
+private final OperationQueueDAO operationQueueDAO;
+private final C2OperationRestartHandler c2OperationRestartHandler;
+private final BlockingQueue c2Operations;
+
+public C2OperationManager(C2Client client, C2OperationHandlerProvider
c2OperationHandlerProvider, ReentrantLock heartbeatLock,
+ OperationQueueDAO operationQueueDAO,
C2OperationRestartHandler c2OperationRestartHandler) {
+this.client = client;
+this.c2OperationHandlerProvider = c2OperationHandlerProvider;
+this.heartbeatLock = heartbeatLock;
+this.operationQueueDAO = operationQueueDAO;
+this.c2OperationRestartHandler = c2OperationRestartHandler;
+this.c2Operations = new LinkedBlockingQueue<>();
+}
+
+public void add(C2Operation c2Operation) {
+try {
+c2Operations.put(c2Operation);
+} catch (InterruptedException e) {
+LOGGER.warn("Thread was interrupted", e);
+}
+}
+
+@Override
+public void run() {
+processRestartState();
+
+while (true) {
+C2Operation operation;
+try {
+operation = c2Operations.take();
+} catch (InterruptedException e) {
+LOGGER.warn("Thread was interrupted", e);
+return;
+}
+
+LOGGER.debug("Processing operation {}", operation);
+C2OperationHandler operationHandler =
c2OperationHandlerProvider.getHandlerForOperation(operation).orElse(null);
+if (operationHandler == null) {
+LOGGER.debug("No handler is present for for C2 Operation {}",
operation);
Review Comment:
"for" is accidentally duplicated in the log message. Also super minor but
would there be added value in printing the available handler names? That could
help investigation in case of issues but this is extremely rare anyway. Will
leave it to you.
##
c2/c2-client-bundle/c2-client-service/src/test/java/org/apache/nifi/c2/client/service/C2HeartbeatManagerTest.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional
[jira] [Created] (NIFI-13143) [BUG] EL/Parameter tooltip missing styles
Scott Aslan created NIFI-13143: -- Summary: [BUG] EL/Parameter tooltip missing styles Key: NIFI-13143 URL: https://issues.apache.org/jira/browse/NIFI-13143 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Attachments: Screenshot 2024-05-03 at 7.18.24 PM.png, Screenshot 2024-05-03 at 7.18.33 PM.png The section header is missing the darker bold font. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13142) Configure typography via angular material
[ https://issues.apache.org/jira/browse/NIFI-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13142: --- Status: Patch Available (was: In Progress) > Configure typography via angular material > - > > Key: NIFI-13142 > URL: https://issues.apache.org/jira/browse/NIFI-13142 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13142) Configure typography via angular material
Scott Aslan created NIFI-13142: -- Summary: Configure typography via angular material Key: NIFI-13142 URL: https://issues.apache.org/jira/browse/NIFI-13142 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Assignee: Scott Aslan -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-12802) Update to minimum node LTS version needed to support new UI
[ https://issues.apache.org/jira/browse/NIFI-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows reassigned NIFI-12802: -- Assignee: Rob Fellows > Update to minimum node LTS version needed to support new UI > --- > > Key: NIFI-12802 > URL: https://issues.apache.org/jira/browse/NIFI-12802 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/nifi/pull/8410/files#r1491162482 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12802) Update to minimum node LTS version needed to support new UI
[ https://issues.apache.org/jira/browse/NIFI-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12802: --- Status: Patch Available (was: Open) > Update to minimum node LTS version needed to support new UI > --- > > Key: NIFI-12802 > URL: https://issues.apache.org/jira/browse/NIFI-12802 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/nifi/pull/8410/files#r1491162482 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13140) Fix error handling in guards
[ https://issues.apache.org/jira/browse/NIFI-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13140: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Fix error handling in guards > > > Key: NIFI-13140 > URL: https://issues.apache.org/jira/browse/NIFI-13140 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13140) Fix error handling in guards
[ https://issues.apache.org/jira/browse/NIFI-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843373#comment-17843373 ] ASF subversion and git services commented on NIFI-13140: Commit ab5025c652182a67730037b3d28bb75fbd363cde in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ab5025c652 ] NIFI-13140: (#8743) - Cleaning up error handling in guards. This closes #8743 > Fix error handling in guards > > > Key: NIFI-13140 > URL: https://issues.apache.org/jira/browse/NIFI-13140 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13140: Cleaning up error handling in guards [nifi]
rfellows merged PR #8743: URL: https://github.com/apache/nifi/pull/8743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated MINIFICPP-2346:
Description:
*NOTE:* I noticed you guys recently switched from 0.15 to 0.99, so at certain
point, I will pull in lastest updates from MiNiFi C++ main branch on parent
level and rebase or merge into my PR.
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
Here is my draft PR for this Jira Ticket for your reference:
[https://github.com/apache/nifi-minifi-cpp/pull/1775]
* I have added *abseil* external lib dependency to conanfile.py and integrated
it into Abseil.cmake with conditional statement that checks if
USE_CONAN_PACKAGER minifi cpp option is true else checks if
USE_CMAKE_FETCH_CONTENT option is true for backward compatibility, so we can
began the process of integrating in conan version 2.
Here are the commands that I run:
{code:java}
cd $HOME/src/pipeline/nifi-minifi-cpp
# NOTE: I also plan to add smoother integration of conan commands into MiNiFI
CPP too
# For instance, I know you guys have your bootstrap scripts too
# You also have your github actions workflow scripts too
conan install . --output-folder=build
-pr=$HOME/src/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
# install conan packages and build C++ for minifi using Conan & CMake, we run
this way, so conan's tc.cache_variables
# are like passing -D{minifi_option} upon running cmake generate, then make
to build MiNiFi C++
conan build . --output-folder=build
-pr=/home/bizon/src/jam-repo/main/etc/build/conan/profiles/release-linux{code}
Tracking Prebuilt Binary Conan Packages Available on Conancenter:
* 'abseil/20230125.3',
* 'argparse/3.0',
* 'asio/1.30.2'
Tracking Conan Packages Not Available on Conancenter, so we need to use an
alternative hosting service to manage building package sources into prebuilt
binary conan packages. Here are some of the free conan hosting services for
open-source C/C++ projects:
* {*}Conan Center Index (CCI){*}: official, free, centralized repo for conan
packages
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated MINIFICPP-2346:
Description:
*NOTE:* I noticed you guys recently switched from 0.15 to 0.99, so at certain
point, I will pull in lastest updates from MiNiFi C++ main branch on parent
level and rebase or merge into my PR.
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
Here is my draft PR for this Jira Ticket for your reference:
[https://github.com/apache/nifi-minifi-cpp/pull/1775]
* I have added *abseil* external lib dependency to conanfile.py and integrated
it into Abseil.cmake with conditional statement that checks if
USE_CONAN_PACKAGER minifi cpp option is true else checks if
USE_CMAKE_FETCH_CONTENT option is true for backward compatibility, so we can
began the process of integrating in conan version 2.
Here are the commands that I run:
{code:java}
cd $HOME/src/pipeline/nifi-minifi-cpp
# NOTE: I also plan to add smoother integration of conan commands into MiNiFI
CPP too
# For instance, I know you guys have your bootstrap scripts too
# You also have your github actions workflow scripts too
conan install . --output-folder=build
-pr=$HOME/src/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
cd build/
cmake ..
make -j $(nproc){code}
Tracking Prebuilt Binary Conan Packages Available on Conancenter:
* 'abseil/20230125.3',
* 'argparse/3.0',
* 'asio/1.30.2'
Tracking Conan Packages Not Available on Conancenter, so we need to use an
alternative hosting service to manage building package sources into prebuilt
binary conan packages. Here are some of the free conan hosting services for
open-source C/C++ projects:
* {*}Conan Center Index (CCI){*}: official, free, centralized repo for conan
packages maintained by conan team
* Bincrafters Bintray Repo: community-driven repo that hosts large number of
pre-built conan packages for open-source libraries for free
* Artifactory by JFrog: typically used as a commercial hosting service, but
also provides a free tier for open-source projects.
*
[jira] [Updated] (NIFI-12901) Remove time units in description of properties that specify a time period
[
https://issues.apache.org/jira/browse/NIFI-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew M. Lim updated NIFI-12901:
-
Component/s: Documentation & Website
> Remove time units in description of properties that specify a time period
> -
>
> Key: NIFI-12901
> URL: https://issues.apache.org/jira/browse/NIFI-12901
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Documentation Website
>Reporter: endzeit
>Assignee: endzeit
>Priority: Trivial
> Fix For: 2.0.0-M3, 1.26.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In some properties that specify a time period, like {{Max Connection
> Lifetime}} of {{DBCPProperties}}, the documentation claims that the property
> value is to be defined in a concrete time unit, like milliseconds.
> However, those properties use the
> {{StandardValidators.TIME_PERIOD_VALIDATOR}}, or a derivative thereof, which
> supports to define the period in a plethora of time units.
> The documentation should be changed accordingly, to clarify that the
> properties do not require an integer value of a static time unit but rather
> the declaration of a time period including a time unit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12893) Adjust documentation on time based properties in DBCPProperties
[
https://issues.apache.org/jira/browse/NIFI-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew M. Lim updated NIFI-12893:
-
Component/s: Documentation & Website
> Adjust documentation on time based properties in DBCPProperties
> ---
>
> Key: NIFI-12893
> URL: https://issues.apache.org/jira/browse/NIFI-12893
> Project: Apache NiFi
> Issue Type: Task
> Components: Documentation Website
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3, 1.26.0
>
>
> Some of the properties in {{DBCPProperties}}, like {{MAX_CONN_LIFETIME}},
> note that the time has to be defined in milliseconds.
> However, this is not true as an time period like "5 mins" is expected.
> The documentation should be adjusted accordingly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13132) Import from registry error handling
[ https://issues.apache.org/jira/browse/NIFI-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13132: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Import from registry error handling > --- > > Key: NIFI-13132 > URL: https://issues.apache.org/jira/browse/NIFI-13132 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Attachments: Screenshot 2024-05-02 at 4.33.01 PM.png > > Time Spent: 40m > Remaining Estimate: 0h > > When a registry is configured but no longer running or available the user can > attempt to drag and drop on the canvas to import a flow from the registry. > There is a console error in dev tools but no error is displayed to the user: > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13132) Import from registry error handling
[ https://issues.apache.org/jira/browse/NIFI-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843352#comment-17843352 ] ASF subversion and git services commented on NIFI-13132: Commit 3192bc85ef212775753637bdba80496da8fa68f6 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3192bc85ef ] [NIFI-13132] show banner error in import flow dialog when registry is… (#8737) * [NIFI-13132] show banner error in import flow dialog when registry is configured but unreachable * address review comments This closes #8737 > Import from registry error handling > --- > > Key: NIFI-13132 > URL: https://issues.apache.org/jira/browse/NIFI-13132 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-02 at 4.33.01 PM.png > > Time Spent: 40m > Remaining Estimate: 0h > > When a registry is configured but no longer running or available the user can > attempt to drag and drop on the canvas to import a flow from the registry. > There is a console error in dev tools but no error is displayed to the user: > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13132] show banner error in import flow dialog when registry is… [nifi]
rfellows merged PR #8737: URL: https://github.com/apache/nifi/pull/8737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13130) Focus incorrectly applied to dialogs on page refresh
[ https://issues.apache.org/jira/browse/NIFI-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843351#comment-17843351 ] ASF subversion and git services commented on NIFI-13130: Commit 9ddf8ffdd0644d745447eccb11455d9f0a16194d in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=9ddf8ffdd0 ] [NIFI-13130] disabled autofocus for dialog with no form fields to prevent dialog from being focused on page refresh (#8742) This closes #8742 > Focus incorrectly applied to dialogs on page refresh > > > Key: NIFI-13130 > URL: https://issues.apache.org/jira/browse/NIFI-13130 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: image-2024-05-02-16-27-06-410.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > On page refresh the `tabindex="0"` on some dialogs seems to apply a focus > border to the dialog. This is especially noticeable in dark mode. > !image-2024-05-02-16-27-06-410.png|width=534,height=331! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13130) Focus incorrectly applied to dialogs on page refresh
[ https://issues.apache.org/jira/browse/NIFI-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13130: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Focus incorrectly applied to dialogs on page refresh > > > Key: NIFI-13130 > URL: https://issues.apache.org/jira/browse/NIFI-13130 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Attachments: image-2024-05-02-16-27-06-410.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > On page refresh the `tabindex="0"` on some dialogs seems to apply a focus > border to the dialog. This is especially noticeable in dark mode. > !image-2024-05-02-16-27-06-410.png|width=534,height=331! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13130] disabled autofocus for dialog with no form fields to pre… [nifi]
rfellows merged PR #8742: URL: https://github.com/apache/nifi/pull/8742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13141) Some canvas actions reset when polling occurs
Matt Gilman created NIFI-13141: -- Summary: Some canvas actions reset when polling occurs Key: NIFI-13141 URL: https://issues.apache.org/jira/browse/NIFI-13141 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman If polling occurs while the user is moving a bend point, moving a connection label, or resizing a label and the canvas polls the positions will be reset. If the user is performing one of these actions we should consider not applying these values which would reset the positions. We may however need to honor the existing behavior if the component revision has changed by another user. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13091) Only show selected Relationships in Edit Connection
[ https://issues.apache.org/jira/browse/NIFI-13091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843346#comment-17843346 ] ASF subversion and git services commented on NIFI-13091: Commit 0672bf395446496475b4a58defeff4c4f2ca9b2b in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0672bf3954 ] [NIFI-13091] only show selected relationships in read only connection details dialog (#8741) This closes #8741 > Only show selected Relationships in Edit Connection > --- > > Key: NIFI-13091 > URL: https://issues.apache.org/jira/browse/NIFI-13091 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The Edit Connection dialog was updated in NIFI-12972 to only show the > selected Relationships. This Jira is tracking the same change in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13091) Only show selected Relationships in Edit Connection
[ https://issues.apache.org/jira/browse/NIFI-13091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13091: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Only show selected Relationships in Edit Connection > --- > > Key: NIFI-13091 > URL: https://issues.apache.org/jira/browse/NIFI-13091 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The Edit Connection dialog was updated in NIFI-12972 to only show the > selected Relationships. This Jira is tracking the same change in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13091] only show selected relationships in read only connection… [nifi]
mcgilman merged PR #8741: URL: https://github.com/apache/nifi/pull/8741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12903) UI - update disabled/enabled drag/drop colors
[ https://issues.apache.org/jira/browse/NIFI-12903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12903: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > UI - update disabled/enabled drag/drop colors > - > > Key: NIFI-12903 > URL: https://issues.apache.org/jira/browse/NIFI-12903 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The connection prioritizers and the parameter context inheritance drag and > drop controls need to update the background color for enabled and disabled > states. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12903) UI - update disabled/enabled drag/drop colors
[ https://issues.apache.org/jira/browse/NIFI-12903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843337#comment-17843337 ] ASF subversion and git services commented on NIFI-12903: Commit b946465709114369dafa341921baac42d86e8f6a in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b946465709 ] [NIFI-12903] style updates for drag/drop UX (#8729) * [NIFI-12903] style updates for drag/drop UX * restore nf-editor styles * remove padding from new canvas items * remove unused disabled * no value set UX * restore initial disabled state This closes #8729 > UI - update disabled/enabled drag/drop colors > - > > Key: NIFI-12903 > URL: https://issues.apache.org/jira/browse/NIFI-12903 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > The connection prioritizers and the parameter context inheritance drag and > drop controls need to update the background color for enabled and disabled > states. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12903] style updates for drag/drop UX [nifi]
mcgilman merged PR #8729: URL: https://github.com/apache/nifi/pull/8729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13140: Cleaning up error handling in guards [nifi]
rfellows commented on PR #8743: URL: https://github.com/apache/nifi/pull/8743#issuecomment-2093663842 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13140: Cleaning up error handling in guards [nifi]
mcgilman opened a new pull request, #8743: URL: https://github.com/apache/nifi/pull/8743 NIFI-13140: - Cleaning up error handling in guards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13140) Fix error handling in guards
[ https://issues.apache.org/jira/browse/NIFI-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13140: --- Status: Patch Available (was: In Progress) > Fix error handling in guards > > > Key: NIFI-13140 > URL: https://issues.apache.org/jira/browse/NIFI-13140 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13130] disabled autofocus for dialog with no form fields to pre… [nifi]
rfellows commented on PR #8742: URL: https://github.com/apache/nifi/pull/8742#issuecomment-2093651463 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13136) Unable to clear optional property value
[ https://issues.apache.org/jira/browse/NIFI-13136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13136: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Unable to clear optional property value > --- > > Key: NIFI-13136 > URL: https://issues.apache.org/jira/browse/NIFI-13136 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 40m > Remaining Estimate: 0h > > It is currently not possible to unset an optional property. We need to update > the property value editor so that the user can set the value, set the value > to empty string, and clear the value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13136: Allowing users to unset optional property values [nifi]
rfellows merged PR #8734: URL: https://github.com/apache/nifi/pull/8734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13136) Unable to clear optional property value
[ https://issues.apache.org/jira/browse/NIFI-13136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843323#comment-17843323 ] ASF subversion and git services commented on NIFI-13136: Commit 914e2b1057653a258ff91edff569eb0d6fb1b99c in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=914e2b1057 ] NIFI-13136: Allowing users to unset optional property values (#8734) * NIFI-13136: - Allowing users to unset optional property values. - Only selecting value and applying focus if it is not read only. * NIFI-13136: - Addressing review feedback. - Adding styles to disabled editor input. - Fixing show hint/autocomplete in production build. This closes #8734 > Unable to clear optional property value > --- > > Key: NIFI-13136 > URL: https://issues.apache.org/jira/browse/NIFI-13136 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > It is currently not possible to unset an optional property. We need to update > the property value editor so that the user can set the value, set the value > to empty string, and clear the value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13132) Import from registry error handling
[ https://issues.apache.org/jira/browse/NIFI-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13132: --- Status: Patch Available (was: In Progress) > Import from registry error handling > --- > > Key: NIFI-13132 > URL: https://issues.apache.org/jira/browse/NIFI-13132 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-02 at 4.33.01 PM.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > When a registry is configured but no longer running or available the user can > attempt to drag and drop on the canvas to import a flow from the registry. > There is a console error in dev tools but no error is displayed to the user: > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13130) Focus incorrectly applied to dialogs on page refresh
[ https://issues.apache.org/jira/browse/NIFI-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13130: --- Status: Patch Available (was: In Progress) > Focus incorrectly applied to dialogs on page refresh > > > Key: NIFI-13130 > URL: https://issues.apache.org/jira/browse/NIFI-13130 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: image-2024-05-02-16-27-06-410.png > > Time Spent: 10m > Remaining Estimate: 0h > > On page refresh the `tabindex="0"` on some dialogs seems to apply a focus > border to the dialog. This is especially noticeable in dark mode. > !image-2024-05-02-16-27-06-410.png|width=534,height=331! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13130] disabled autofocus for dialog with no form fields to pre… [nifi]
scottyaslan opened a new pull request, #8742: URL: https://github.com/apache/nifi/pull/8742 …vent dialog from being focused on page refresh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-13130) Focus incorrectly applied to dialogs on page refresh
[ https://issues.apache.org/jira/browse/NIFI-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-13130: -- Assignee: Scott Aslan > Focus incorrectly applied to dialogs on page refresh > > > Key: NIFI-13130 > URL: https://issues.apache.org/jira/browse/NIFI-13130 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: image-2024-05-02-16-27-06-410.png > > > On page refresh the `tabindex="0"` on some dialogs seems to apply a focus > border to the dialog. This is especially noticeable in dark mode. > !image-2024-05-02-16-27-06-410.png|width=534,height=331! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13140) Fix error handling in guards
Matt Gilman created NIFI-13140: -- Summary: Fix error handling in guards Key: NIFI-13140 URL: https://issues.apache.org/jira/browse/NIFI-13140 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13132] show banner error in import flow dialog when registry is… [nifi]
rfellows commented on code in PR #8737:
URL: https://github.com/apache/nifi/pull/8737#discussion_r1589607420
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/import-from-registry/import-from-registry.component.ts:
##
@@ -191,23 +195,30 @@ export class ImportFromRegistry implements OnInit {
this.getBuckets(registryId)
.pipe(take(1))
-.subscribe((buckets: BucketEntity[]) => {
-if (buckets.length > 0) {
-buckets.forEach((entity: BucketEntity) => {
-if (entity.permissions.canRead) {
-this.bucketOptions.push({
-text: entity.bucket.name,
-value: entity.id,
-description: entity.bucket.description
-});
-}
-});
+.subscribe({
+next: (buckets: BucketEntity[]) => {
+if (buckets.length > 0) {
+buckets.forEach((entity: BucketEntity) => {
+if (entity.permissions.canRead) {
+this.bucketOptions.push({
+text: entity.bucket.name,
+value: entity.id,
+description: entity.bucket.description
+});
+}
+});
-const bucketId = this.bucketOptions[0].value;
-if (bucketId) {
-
this.importFromRegistryForm.get('bucket')?.setValue(bucketId);
-this.loadFlows(registryId, bucketId);
+const bucketId = this.bucketOptions[0].value;
+if (bucketId) {
+
this.importFromRegistryForm.get('bucket')?.setValue(bucketId);
+this.loadFlows(registryId, bucketId);
+}
}
+},
+error: (errorResponse: HttpErrorResponse) => {
+this.store.dispatch(
+FlowActions.flowBannerError({ error:
this.errorHelper.getErrorString(errorResponse) })
+);
Review Comment:
We've been pretty consistent in handling errors in the effects classes
rather than in the component classes. Was there a particular reason you chose
to handle the errors in here?
I assumed the error handling would have been done in the flow.effects in a
tap like so:
```
dialogReference.componentInstance.getBuckets = (
registryId: string
): Observable => {
return
this.registryService.getBuckets(registryId).pipe(
take(1),
map((response) => response.buckets),
tap({
error: (errorResponse:
HttpErrorResponse) => {
this.store.dispatch(
FlowActions.flowBannerError({
error: this.errorHelper.getErrorString(errorResponse) })
);
}
})
);
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13091] only show selected relationships in read only connection… [nifi]
mcgilman commented on PR #8741: URL: https://github.com/apache/nifi/pull/8741#issuecomment-2093550805 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13091) Only show selected Relationships in Edit Connection
[ https://issues.apache.org/jira/browse/NIFI-13091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13091: --- Status: Patch Available (was: In Progress) > Only show selected Relationships in Edit Connection > --- > > Key: NIFI-13091 > URL: https://issues.apache.org/jira/browse/NIFI-13091 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The Edit Connection dialog was updated in NIFI-12972 to only show the > selected Relationships. This Jira is tracking the same change in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13091) Only show selected Relationships in Edit Connection
[ https://issues.apache.org/jira/browse/NIFI-13091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-13091: -- Assignee: Scott Aslan > Only show selected Relationships in Edit Connection > --- > > Key: NIFI-13091 > URL: https://issues.apache.org/jira/browse/NIFI-13091 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > > The Edit Connection dialog was updated in NIFI-12972 to only show the > selected Relationships. This Jira is tracking the same change in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13129) [BUG] selected prioritizer order is not honored when displayed in the UI
[ https://issues.apache.org/jira/browse/NIFI-13129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843301#comment-17843301 ] ASF subversion and git services commented on NIFI-13129: Commit 37937ffa155244652adc207953b5adbc27dc4709 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=37937ffa15 ] [NIFI-13129] - Fix: selected prioritizer order is not honored when displayed in the UI (#8736) This closes #8736 > [BUG] selected prioritizer order is not honored when displayed in the UI > > > Key: NIFI-13129 > URL: https://issues.apache.org/jira/browse/NIFI-13129 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Attachments: image-2024-05-02-16-24-55-252.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > !image-2024-05-02-16-24-55-252.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13129) [BUG] selected prioritizer order is not honored when displayed in the UI
[ https://issues.apache.org/jira/browse/NIFI-13129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13129: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > [BUG] selected prioritizer order is not honored when displayed in the UI > > > Key: NIFI-13129 > URL: https://issues.apache.org/jira/browse/NIFI-13129 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M3 > > Attachments: image-2024-05-02-16-24-55-252.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > !image-2024-05-02-16-24-55-252.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13129] - Fix: selected prioritizer order is not honored when displayed in the UI [nifi]
mcgilman merged PR #8736: URL: https://github.com/apache/nifi/pull/8736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12903] style updates for drag/drop UX [nifi]
scottyaslan commented on code in PR #8729:
URL: https://github.com/apache/nifi/pull/8729#discussion_r1589566978
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-context-inheritance/parameter-context-inheritance.component.ts:
##
@@ -73,7 +73,7 @@ export class ParameterContextInheritance implements
ControlValueAccessor {
protected readonly TextTip = TextTip;
-isDisabled = false;
+isDisabled = true;
Review Comment:
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1589565627
##
nifi-api/src/main/java/org/apache/nifi/registry/flow/FlowRegistryBranch.java:
##
@@ -0,0 +1,52 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under one or more
+ * * contributor license agreements. See the NOTICE file distributed with
+ * * this work for additional information regarding copyright ownership.
+ * * The ASF licenses this file to You under the Apache License, Version 2.0
+ * * (the "License"); you may not use this file except in compliance with
+ * * the License. You may obtain a copy of the License at
+ * *
+ * * http://www.apache.org/licenses/LICENSE-2.0
+ * *
+ * * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ *
+ */
+
+package org.apache.nifi.registry.flow;
+
+import java.util.Objects;
+
+public class FlowRegistryBranch {
Review Comment:
I think this ok to mark as resolved, but let me know if not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1589563432
##
nifi-api/src/main/java/org/apache/nifi/registry/flow/CreateBranch.java:
##
@@ -0,0 +1,53 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under one or more
+ * * contributor license agreements. See the NOTICE file distributed with
+ * * this work for additional information regarding copyright ownership.
+ * * The ASF licenses this file to You under the Apache License, Version 2.0
+ * * (the "License"); you may not use this file except in compliance with
+ * * the License. You may obtain a copy of the License at
+ * *
+ * * http://www.apache.org/licenses/LICENSE-2.0
+ * *
+ * * Unless required by applicable law or agreed to in writing, software
+ * * distributed under the License is distributed on an "AS IS" BASIS,
+ * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * * See the License for the specific language governing permissions and
+ * * limitations under the License.
+ *
+ */
+
+package org.apache.nifi.registry.flow;
+
+/**
+ * Information for creating a branch in a flow registry.
+ */
+public class CreateBranch {
+
+private String fromBranch;
+private String newBranch;
+
+public CreateBranch() {
+}
+
+public CreateBranch(final String fromBranch, final String newBranch) {
+this.fromBranch = fromBranch;
Review Comment:
CreateBranch is removed for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13135) Allow parameter table to be sortable by parameter name
[ https://issues.apache.org/jira/browse/NIFI-13135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13135: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Allow parameter table to be sortable by parameter name > -- > > Key: NIFI-13135 > URL: https://issues.apache.org/jira/browse/NIFI-13135 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1589562736
##
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/registry/flow/FlowAnalyzingRegistryClientNode.java:
##
@@ -401,13 +401,33 @@ public boolean isStorageLocationApplicable(final String
location) {
}
@Override
-public Set getBuckets(final
FlowRegistryClientUserContext context) throws FlowRegistryException,
IOException {
-return node.getBuckets(context);
+public boolean isBranchingSupported() {
+return node.isBranchingSupported();
}
@Override
-public FlowRegistryBucket getBucket(final FlowRegistryClientUserContext
context, final String bucketId) throws FlowRegistryException, IOException {
-return node.getBucket(context, bucketId);
+public Set getBranches(final
FlowRegistryClientUserContext context) throws FlowRegistryException,
IOException {
+return node.getBranches(context);
+}
+
+@Override
+public FlowRegistryBranch getDefaultBranch(final
FlowRegistryClientUserContext context) throws FlowRegistryException,
IOException {
+return node.getDefaultBranch(context);
+}
+
+@Override
+public void createBranch(final FlowRegistryClientUserContext context,
final CreateBranch createBranch) throws FlowRegistryException, IOException {
Review Comment:
Marking this as resolved since createBranch is removed for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13134) Support No Value Set in Edit Parameter Context
[ https://issues.apache.org/jira/browse/NIFI-13134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13134: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Support No Value Set in Edit Parameter Context > -- > > Key: NIFI-13134 > URL: https://issues.apache.org/jira/browse/NIFI-13134 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 40m > Remaining Estimate: 0h > > Need to support setting a parameter value to null. When the value is empty > but the `Set empty string` checkbox is not checked, the value should be null. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13129] - Fix: selected prioritizer order is not honored when displayed in the UI [nifi]
mcgilman commented on PR #8736: URL: https://github.com/apache/nifi/pull/8736#issuecomment-2093509730 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13135) Allow parameter table to be sortable by parameter name
[ https://issues.apache.org/jira/browse/NIFI-13135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843298#comment-17843298 ] ASF subversion and git services commented on NIFI-13135: Commit 57f684de97d21477c6eb23aecdf898fa0ec1d2a3 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=57f684de97 ] [NIFI-13134] - Support No Value Set in Edit Parameter Context. (#8733) * [NIFI-13134] - Support No Value Set in Edit Parameter Context. [NIFI-13135] - Allow parameter table to be sortable by parameter name * retain the valueRemoved setting when editing parameters This closes #8733 > Allow parameter table to be sortable by parameter name > -- > > Key: NIFI-13135 > URL: https://issues.apache.org/jira/browse/NIFI-13135 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13134) Support No Value Set in Edit Parameter Context
[ https://issues.apache.org/jira/browse/NIFI-13134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843297#comment-17843297 ] ASF subversion and git services commented on NIFI-13134: Commit 57f684de97d21477c6eb23aecdf898fa0ec1d2a3 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=57f684de97 ] [NIFI-13134] - Support No Value Set in Edit Parameter Context. (#8733) * [NIFI-13134] - Support No Value Set in Edit Parameter Context. [NIFI-13135] - Allow parameter table to be sortable by parameter name * retain the valueRemoved setting when editing parameters This closes #8733 > Support No Value Set in Edit Parameter Context > -- > > Key: NIFI-13134 > URL: https://issues.apache.org/jira/browse/NIFI-13134 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Need to support setting a parameter value to null. When the value is empty > but the `Set empty string` checkbox is not checked, the value should be null. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13134] - Support No Value Set in Edit Parameter Context. [nifi]
mcgilman merged PR #8733: URL: https://github.com/apache/nifi/pull/8733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13132] show banner error in import flow dialog when registry is… [nifi]
rfellows commented on PR #8737: URL: https://github.com/apache/nifi/pull/8737#issuecomment-2093507059 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12903] style updates for drag/drop UX [nifi]
mcgilman commented on code in PR #8729:
URL: https://github.com/apache/nifi/pull/8729#discussion_r1589553811
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-context-inheritance/parameter-context-inheritance.component.ts:
##
@@ -73,7 +73,7 @@ export class ParameterContextInheritance implements
ControlValueAccessor {
protected readonly TextTip = TextTip;
-isDisabled = false;
+isDisabled = true;
Review Comment:
Was this change intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13139) PythonNarIT tests failing, missing StandardPythonBridge
Tamas Palfy created NIFI-13139: -- Summary: PythonNarIT tests failing, missing StandardPythonBridge Key: NIFI-13139 URL: https://issues.apache.org/jira/browse/NIFI-13139 Project: Apache NiFi Issue Type: Bug Reporter: Tamas Palfy The issue seems to be due to nifi-system-tests/nifi-system-test-suite/target/pythonic-instance/lib not prepared to have the nifi-py4j-nar-2.0.0-SNAPSHOT.nar. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13008) CLI command to upgrade all instances of a versioned flow
[ https://issues.apache.org/jira/browse/NIFI-13008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Gresock updated NIFI-13008: --- Fix Version/s: 2.0.0-M3 1.26.0 Resolution: Fixed Status: Resolved (was: Patch Available) > CLI command to upgrade all instances of a versioned flow > > > Key: NIFI-13008 > URL: https://issues.apache.org/jira/browse/NIFI-13008 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Add a CLI command allowing someone to upgrade all the instances of a given > versioned flow. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13008) CLI command to upgrade all instances of a versioned flow
[ https://issues.apache.org/jira/browse/NIFI-13008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843293#comment-17843293 ] ASF subversion and git services commented on NIFI-13008: Commit 42eed224debd6b13406f0d7898f68c3e69e90205 in nifi's branch refs/heads/support/nifi-1.x from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=42eed224de ] NIFI-13008 - CLI command to upgrade all instances of a versioned flow Signed-off-by: Joe Gresock This closes #8735. > CLI command to upgrade all instances of a versioned flow > > > Key: NIFI-13008 > URL: https://issues.apache.org/jira/browse/NIFI-13008 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > Time Spent: 1h 10m > Remaining Estimate: 0h > > Add a CLI command allowing someone to upgrade all the instances of a given > versioned flow. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1589526553
##
nifi-api/src/main/java/org/apache/nifi/registry/flow/FlowRegistryClient.java:
##
@@ -71,30 +74,82 @@ public interface FlowRegistryClient extends
ConfigurableComponent {
*/
boolean isStorageLocationApplicable(FlowRegistryClientConfigurationContext
context, String location);
+/**
+ * Indicates if the registry supports branching.
+ *
+ * @param context Configuration context
+ * @return true if the registry supports branching, false otherwise
+ */
+default boolean isBranchingSupported(final
FlowRegistryClientConfigurationContext context) {
+return false;
+}
+
+/**
+ * Get the available branches. Should return at least one branch that
matches the response of getDefaultBranch.
+ *
+ * @param context Configuration context
+ * @return the set of available branches
+ *
+ * @throws FlowRegistryException If an issue happens during processing the
request.
+ * @throws IOException If there is issue with the communication between
NiFi and the Flow Registry.
+ */
+default Set getBranches(final
FlowRegistryClientConfigurationContext context) throws FlowRegistryException,
IOException {
+return Set.of(getDefaultBranch(context));
+}
+
+/**
+ * Gets the default branch. Must return a non-null FlowRegistryBranch
instance with a non-null name.
+ *
+ * @param context Configuration context
+ * @return the default branch
+ *
+ * @throws FlowRegistryException If an issue happens during processing the
request.
+ * @throws IOException If there is issue with the communication between
NiFi and the Flow Registry.
+ */
+default FlowRegistryBranch getDefaultBranch(final
FlowRegistryClientConfigurationContext context) throws FlowRegistryException,
IOException {
+final FlowRegistryBranch branch = new FlowRegistryBranch();
+branch.setName(DEFAULT_BRANCH_NAME);
+return branch;
+}
+
+/**
+ * Creates a new branch from a given branch.
+ *
+ * @param context Configuration context
+ * @param createBranch the info for creating the branch
+ *
+ * @throws FlowRegistryException If an issue happens during processing the
request.
+ * @throws IOException If there is issue with the communication between
NiFi and the Flow Registry.
+ */
+default void createBranch(FlowRegistryClientConfigurationContext context,
final CreateBranch createBranch) throws FlowRegistryException, IOException {
Review Comment:
I agree, I am going to remove the `createBranch` method and `CreateBranch`
object for now, which addresses some of the discussion/questions. It can be
added in a non-breaking way later if we decide we ever want to create branches
from NiFi, but I have a feeling we don't want to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12855: Add more information to provenance events to facilitate full graph traversal [nifi]
joewitt commented on PR #8498: URL: https://github.com/apache/nifi/pull/8498#issuecomment-2093453610 @mattyb149 It is important to undo all the whitespace changes to improve the reviewer efficiency and avoid the whitespace in general. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12855: Add more information to provenance events to facilitate full graph traversal [nifi]
joewitt commented on code in PR #8498:
URL: https://github.com/apache/nifi/pull/8498#discussion_r1589498608
##
nifi-api/src/main/java/org/apache/nifi/provenance/ProvenanceEventBuilder.java:
##
@@ -283,6 +283,13 @@ public interface ProvenanceEventBuilder {
*/
ProvenanceEventBuilder setRelationship(Relationship relationship);
+/**
+ * Sets the IDs for the event that happened previously to this event for
the given FlowFile
+ * @param previousEventIds The previous event IDs (usually one except for
JOIN events and such)
+ * @return the builder
+ */
+ProvenanceEventBuilder setPreviousEventIds(List previousEventIds);
Review Comment:
Ah maybe it is that we had parent FlowFile identifiers and now we'll have
previous Event Identfiers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12855: Add more information to provenance events to facilitate full graph traversal [nifi]
joewitt commented on code in PR #8498:
URL: https://github.com/apache/nifi/pull/8498#discussion_r1589491223
##
nifi-api/src/main/java/org/apache/nifi/provenance/ProvenanceEventBuilder.java:
##
@@ -283,6 +283,13 @@ public interface ProvenanceEventBuilder {
*/
ProvenanceEventBuilder setRelationship(Relationship relationship);
+/**
+ * Sets the IDs for the event that happened previously to this event for
the given FlowFile
+ * @param previousEventIds The previous event IDs (usually one except for
JOIN events and such)
+ * @return the builder
+ */
+ProvenanceEventBuilder setPreviousEventIds(List previousEventIds);
Review Comment:
Does this imply we're storing event ids for the before and after event on
both the before and after event?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12855: Add more information to provenance events to facilitate full graph traversal [nifi]
joewitt commented on code in PR #8498:
URL: https://github.com/apache/nifi/pull/8498#discussion_r1589489118
##
minifi/minifi-nar-bundles/minifi-provenance-repository-bundle/minifi-provenance-repositories/src/main/java/org/apache/nifi/provenance/NoOpProvenanceRepository.java:
##
@@ -29,20 +29,19 @@
import java.util.Optional;
import java.util.Set;
-import static java.util.Collections.EMPTY_SET;
import static java.util.Collections.emptyList;
/**
* Implementation of {@link ProvenanceRepository} that does not
* store events.
*
*/
-public class NoOpProvenanceRepository implements ProvenanceRepository {
+public class NoOpProvenanceRepository extends AbstractProvenanceRepository {
@Override
public void initialize(EventReporter eventReporter, Authorizer authorizer,
- ProvenanceAuthorizableFactory factory, IdentifierLookup identifierLookup)
- throws IOException {
+ ProvenanceAuthorizableFactory factory,
IdentifierLookup identifierLookup)
Review Comment:
there are a number of entries here that look like whitespace additions.
Please double check and if so remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12855: Add more information to provenance events to facilitate full graph traversal [nifi]
mattyb149 closed pull request #8498: NIFI-12855: Add more information to provenance events to facilitate full graph traversal URL: https://github.com/apache/nifi/pull/8498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13138) Add extensions name and description in NiFi Registry
[ https://issues.apache.org/jira/browse/NIFI-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13138: -- Status: Patch Available (was: Open) > Add extensions name and description in NiFi Registry > > > Key: NIFI-13138 > URL: https://issues.apache.org/jira/browse/NIFI-13138 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Similar to NIFI-13050, it'd be extremely useful, for a given bundle, in NiFi > Registry, to display the included extensions in that bundle. For each > extension, we want to display the name and associated description. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13138 - Add extensions name and description in NiFi Registry [nifi]
pvillard31 opened a new pull request, #8740: URL: https://github.com/apache/nifi/pull/8740 # Summary [NIFI-13138](https://issues.apache.org/jira/browse/NIFI-13138) - Add extensions name and description in NiFi Registry    # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13138) Add extensions name and description in NiFi Registry
Pierre Villard created NIFI-13138: - Summary: Add extensions name and description in NiFi Registry Key: NIFI-13138 URL: https://issues.apache.org/jira/browse/NIFI-13138 Project: Apache NiFi Issue Type: Improvement Components: NiFi Registry Reporter: Pierre Villard Assignee: Pierre Villard Similar to NIFI-13050, it'd be extremely useful, for a given bundle, in NiFi Registry, to display the included extensions in that bundle. For each extension, we want to display the name and associated description. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12903] style updates for drag/drop UX [nifi]
scottyaslan commented on code in PR #8729:
URL: https://github.com/apache/nifi/pull/8729#discussion_r1589408963
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/connection/prioritizers/prioritizers.component.html:
##
@@ -16,53 +16,64 @@
-->
-
-
-Available Prioritizers
-
-
-
-@for (item of availablePrioritizers; track item; let i = $index) {
-
-
-
-}
+@if (!isDisabled) {
+
+
+Available Prioritizers
+
+
+
+@for (item of availablePrioritizers; track item; let i =
$index) {
+
+
+
+}
+
-
+}
-Selected Prioritizers
+@if (!isDisabled) {
+Selected Prioritizers
+} @else {
+Prioritizers
Review Comment:
OK updated this UX to display "No value set".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13120 Introduce branch as a concept in registry client and VCI [nifi]
bbende commented on code in PR #8726:
URL: https://github.com/apache/nifi/pull/8726#discussion_r1589333765
##
nifi-extension-bundles/nifi-flow-registry-client-bundle/nifi-flow-registry-client-services/src/main/java/org/apache/nifi/registry/flow/NifiRegistryFlowRegistryClient.java:
##
@@ -149,7 +149,7 @@ public boolean isStorageLocationApplicable(final
FlowRegistryClientConfiguration
}
@Override
-public Set getBuckets(final
FlowRegistryClientConfigurationContext context) throws FlowRegistryException,
IOException {
+public Set getBuckets(final
FlowRegistryClientConfigurationContext context, final String branch) throws
FlowRegistryException, IOException {
Review Comment:
Are you saying that you think we should check the `branch` argument in all
of the methods in `NiFiRegistryFlowRegistryClient` to validate that it matches
the default branch?
The only way this could happen is someone making API calls outside of the UI
where they could submit a request for save/import with a branch name that
wasn't the default branch NiFi Registry is expecting, but also it would just be
ignored by all of the methods, so it wouldn't cause any issues.
One other note... I did not add `branch` to the NiFi Registry specific data
model class like `VersionedFlow`, `VersionedFlowSnapshot`, and
`VersionedFlowSnapshotMetadat`, because its not used for anything on registry
side. So in your example, if someone calls `getFlowContents` with `branch` as
`dev`, they will get back a null branch in the response since there wasn't a
branch in the content returned from registry.
Happy to improve something here, just want to make sure I'm following what
you are suggesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13137) Switch to Zulu for MacOS Java 8 action
[ https://issues.apache.org/jira/browse/NIFI-13137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13137: -- Status: Patch Available (was: Open) > Switch to Zulu for MacOS Java 8 action > -- > > Key: NIFI-13137 > URL: https://issues.apache.org/jira/browse/NIFI-13137 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Affects Versions: 1.26.0 >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Temurin Java 8 is not available for macOS 14 on AArch64. The most > straightforward solution would be switching to some other JDK, such as Azul. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13008 - CLI command to upgrade all instances of a versioned flow (support/nifi-1.x) [nifi]
pvillard31 commented on PR #8735: URL: https://github.com/apache/nifi/pull/8735#issuecomment-2093191715 Good point @exceptionfactory - submitted a PR #8739. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13137 - Switch to Zulu for MacOS Java 8 action [nifi]
pvillard31 opened a new pull request, #8739: URL: https://github.com/apache/nifi/pull/8739 # Summary [NIFI-13137](https://issues.apache.org/jira/browse/NIFI-13137) - Switch to Zulu for MacOS Java 8 action # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13123 MiNiFi async C2 operation processing [nifi]
exceptionfactory commented on code in PR #8738:
URL: https://github.com/apache/nifi/pull/8738#discussion_r1589322962
##
nifi-framework-api/src/main/java/org/apache/nifi/bootstrap/BootstrapCommunicator.java:
##
@@ -25,11 +25,13 @@ public interface BootstrapCommunicator {
/**
* Sends a command with specific arguments to the bootstrap process
+ *
* @param command the command to send
- * @param args the args to send
+ * @param argsthe args to send
+ * @return whether the command send was successful or not
* @throws IOException exception in case of communication issue
*/
-void sendCommand(String command, String... args) throws IOException;
+boolean sendCommand(String command, String... args) throws IOException;
Review Comment:
For future flexibility, I recommend changing the `boolean` to an `enum`
named something like `CommandResult` or `CommandStatus`. The initial values
could be `FAILURE` and `SUCCESS`, but using an `enum` provides more options for
extension with changing the interface contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13137) Switch to Zulu for MacOS Java 8 action
Pierre Villard created NIFI-13137: - Summary: Switch to Zulu for MacOS Java 8 action Key: NIFI-13137 URL: https://issues.apache.org/jira/browse/NIFI-13137 Project: Apache NiFi Issue Type: Task Components: Tools and Build Affects Versions: 1.26.0 Reporter: Pierre Villard Assignee: Pierre Villard Temurin Java 8 is not available for macOS 14 on AArch64. The most straightforward solution would be switching to some other JDK, such as Azul. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13123 MiNiFi async C2 operation processing [nifi]
briansolo1985 opened a new pull request, #8738: URL: https://github.com/apache/nifi/pull/8738 # Summary [NIFI-13123](https://issues.apache.org/jira/browse/NIFI-13123) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13126: Add Impala DB Adapter [nifi]
dan-s1 commented on code in PR #8728:
URL: https://github.com/apache/nifi/pull/8728#discussion_r1589300753
##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl/ImpalaDatabaseAdapter.java:
##
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard.db.impl;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Collectors;
+import org.apache.nifi.processors.standard.db.ColumnDescription;
+import org.apache.nifi.util.StringUtils;
+
+/**
+ * A generic database adapter that generates Impala compatible SQL.
+ */
+public class ImpalaDatabaseAdapter extends GenericDatabaseAdapter {
+@Override
+public String getName() {
+return "Impala";
+}
+
+@Override
+public String getDescription() {
+return "Generates Impala compatible SQL";
+}
+
+@Override
+public String unwrapIdentifier(String identifier) {
+// Removes double quotes and back-ticks.
+return identifier == null ? null : identifier.replaceAll("[\"`]", "");
+}
+
+@Override
+public boolean supportsUpsert() {
+return true;
+}
+
+@Override
+public boolean supportsInsertIgnore() {
+return false;
+}
+
+@Override
+public String getUpsertStatement(String table, List columnNames,
Collection uniqueKeyColumnNames) {
+if (StringUtils.isEmpty(table)) {
+throw new IllegalArgumentException("Table name cannot be null or
blank");
+}
+if (columnNames == null || columnNames.isEmpty()) {
+throw new IllegalArgumentException("Column names cannot be null or
empty");
+}
+if (uniqueKeyColumnNames == null || uniqueKeyColumnNames.isEmpty()) {
+throw new IllegalArgumentException("Key column names cannot be
null or empty");
+}
Review Comment:
```suggestion
if (StringUtils.isEmpty(columnNames) {
throw new IllegalArgumentException("Column names cannot be null
or empty");
}
if (StringUtils.isEmpty(uniqueKeyColumnNames) {
throw new IllegalArgumentException("Key column names cannot be
null or empty");
}
```
##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/db/impl/TestImpalaDatabaseAdapter.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard.db.impl;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+public class TestImpalaDatabaseAdapter {
+
+private ImpalaDatabaseAdapter testSubject;
+
+@BeforeEach
+public void setUp() throws Exception {
+testSubject = new ImpalaDatabaseAdapter();
+}
+
+@Test
+public void testSupportsUpsert() {
+assertTrue(testSubject.supportsUpsert(),
testSubject.getClass().getSimpleName() + " should support upsert");
Re: [PR] NIFI-13008 - CLI command to upgrade all instances of a versioned flow (support/nifi-1.x) [nifi]
exceptionfactory commented on PR #8735: URL: https://github.com/apache/nifi/pull/8735#issuecomment-2093157025 @pvillard31 Although not related to this particular set of changes, the build workflow for Java 8 on macOS looks like it needs to be updated. The issue appears to be that Temurin Java 8 is not available for macOS 14 on AArch64. The most straightforward solution would be switching to some other JDK, such as Azul. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-13108) Dependency hygiene - various libraries for logging, apache commons, aws/azure/gcp
[ https://issues.apache.org/jira/browse/NIFI-13108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-13108. - Resolution: Fixed > Dependency hygiene - various libraries for logging, apache commons, > aws/azure/gcp > -- > > Key: NIFI-13108 > URL: https://issues.apache.org/jira/browse/NIFI-13108 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13108) Dependency hygiene - various libraries for logging, apache commons, aws/azure/gcp
[ https://issues.apache.org/jira/browse/NIFI-13108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13108: Issue Type: Improvement (was: Task) > Dependency hygiene - various libraries for logging, apache commons, > aws/azure/gcp > -- > > Key: NIFI-13108 > URL: https://issues.apache.org/jira/browse/NIFI-13108 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12998) nifi-nar-bundle has improper dependencies - the full source tree needs dependency cleanup and management
[ https://issues.apache.org/jira/browse/NIFI-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843229#comment-17843229 ] ASF subversion and git services commented on NIFI-12998: Commit 52255ee813350700e6a055e055f1a575c929a374 in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=52255ee813 ] NIFI-13108 Updated common and framework dependencies - Fixed logging logic for tests vs runtime scope - Restoring behavior to testProcessUnparsableRecordWithRawOutputWithCheckpoint that changed in NIFI-12998 presumably because of log dependency changes. Now that we have a single provider the test behavior appears to be back to normal. - Upgraded AWS SDK 1 from 1.12.686 to 1.12.710 - Upgraded AWS SDK 2 from 2.25.16 to 2.25.40 - Upgraded Azure SDK BOM from 1.2.21 to 1.2.23 - Upgraded GCP Libraries from 26.34.0 to 26.37.0 - Upgraded Fabric8 Kubernetes Client from 6.10.0 to 6.12.1 - Upgraded Commons CLI from 1.6.0 to 1.7.0 - Upgraded Commons Codec from 1.16.1 to 1.17.0 - Upgraded zstd-jni from 1.5.6-1 to 1.5.6-3 - Upgraded Commons Text from 1.11.0 to 1.12.0 - Upgraded Test Containers from 1.19.4 to 1.19.7 - Upgraded JAXB Runtime from 4.0.4 to 4.0.5 - Upgraded JAXB API from 4.0.1 to 4.0.2 - Upgraded Jersey from 3.1.4 to 3.1.6 - Upgraded Log4j 2 from 2.23.0 to 2.23.1 - Upgraded Logback from 1.5.5 to 1.5.6 - Upgraded Mockito from 5.8.0 to 5.11.0 - Upgraded Swagger Annotations from 2.2.20 to 2.2.21 - Upgraded jsoup from 1.17.1 to 1.17.2 - Upgraded JUnit Platform Commons from 1.10.0 to 1.10.2 - Upgraded Checkstyle from 9.3 to 10.15.0 - Upgraded ASM from 9.6 to 9.7 This closes #8708 Signed-off-by: David Handermann > nifi-nar-bundle has improper dependencies - the full source tree needs > dependency cleanup and management > > > Key: NIFI-12998 > URL: https://issues.apache.org/jira/browse/NIFI-12998 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M2 >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > found in nifi-nar-bundles pom > > com.maxmind.geoip2 > geoip2 > 4.2.0 > > This should not be here. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13108) Dependency hygiene - various libraries for logging, apache commons, aws/azure/gcp
[ https://issues.apache.org/jira/browse/NIFI-13108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843228#comment-17843228 ] ASF subversion and git services commented on NIFI-13108: Commit 52255ee813350700e6a055e055f1a575c929a374 in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=52255ee813 ] NIFI-13108 Updated common and framework dependencies - Fixed logging logic for tests vs runtime scope - Restoring behavior to testProcessUnparsableRecordWithRawOutputWithCheckpoint that changed in NIFI-12998 presumably because of log dependency changes. Now that we have a single provider the test behavior appears to be back to normal. - Upgraded AWS SDK 1 from 1.12.686 to 1.12.710 - Upgraded AWS SDK 2 from 2.25.16 to 2.25.40 - Upgraded Azure SDK BOM from 1.2.21 to 1.2.23 - Upgraded GCP Libraries from 26.34.0 to 26.37.0 - Upgraded Fabric8 Kubernetes Client from 6.10.0 to 6.12.1 - Upgraded Commons CLI from 1.6.0 to 1.7.0 - Upgraded Commons Codec from 1.16.1 to 1.17.0 - Upgraded zstd-jni from 1.5.6-1 to 1.5.6-3 - Upgraded Commons Text from 1.11.0 to 1.12.0 - Upgraded Test Containers from 1.19.4 to 1.19.7 - Upgraded JAXB Runtime from 4.0.4 to 4.0.5 - Upgraded JAXB API from 4.0.1 to 4.0.2 - Upgraded Jersey from 3.1.4 to 3.1.6 - Upgraded Log4j 2 from 2.23.0 to 2.23.1 - Upgraded Logback from 1.5.5 to 1.5.6 - Upgraded Mockito from 5.8.0 to 5.11.0 - Upgraded Swagger Annotations from 2.2.20 to 2.2.21 - Upgraded jsoup from 1.17.1 to 1.17.2 - Upgraded JUnit Platform Commons from 1.10.0 to 1.10.2 - Upgraded Checkstyle from 9.3 to 10.15.0 - Upgraded ASM from 9.6 to 9.7 This closes #8708 Signed-off-by: David Handermann > Dependency hygiene - various libraries for logging, apache commons, > aws/azure/gcp > -- > > Key: NIFI-13108 > URL: https://issues.apache.org/jira/browse/NIFI-13108 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13108 Update a variety of dependencies [nifi]
exceptionfactory closed pull request #8708: NIFI-13108 Update a variety of dependencies URL: https://github.com/apache/nifi/pull/8708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13134] - Support No Value Set in Edit Parameter Context. [nifi]
mcgilman commented on code in PR #8733:
URL: https://github.com/apache/nifi/pull/8733#discussion_r1589296525
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/edit-parameter-dialog/edit-parameter-dialog.component.ts:
##
@@ -163,8 +166,8 @@ export class EditParameterDialog {
this.editParameter.next({
parameter: {
name: this.editParameterForm.get('name')?.value,
-value,
-valueRemoved: value == '' && !empty,
+value: value === '' && !empty ? null : value,
+valueRemoved: value === '' && !empty,
Review Comment:
When applying the Parameter Context update, this `valueRemoved` field is
getting lost and doesn't not get included in the update request. As a result,
it's not possible when the user attempts to clear a field it is not removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13136: Allowing users to unset optional property values [nifi]
rfellows commented on code in PR #8734:
URL: https://github.com/apache/nifi/pull/8734#discussion_r1589291907
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/property-table/editors/nf-editor/nf-editor.component.ts:
##
@@ -207,8 +218,18 @@ export class NfEditor implements OnDestroy {
okClicked(): void {
const valueControl: AbstractControl | null =
this.nfEditorForm.get('value');
-if (valueControl) {
-this.ok.next(valueControl.value);
+const emptyStringChecked: AbstractControl | null =
this.nfEditorForm.get('setEmptyString');
+if (valueControl && emptyStringChecked) {
+const value = valueControl.value;
+if (value === '') {
+if (emptyStringChecked.value) {
+this.ok.next('');
+} else {
+this.ok.next(null);
+}
+} else {
+this.ok.next(value);
+}
Review Comment:
Not sure where else to leave this comment, but we need to prevent `Enter`
from submitting the okClicked action if the form is invalid (required value not
entered)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [NIFI-13132] show banner error in import flow dialog when registry is… [nifi]
scottyaslan opened a new pull request, #8737: URL: https://github.com/apache/nifi/pull/8737 … configured but unreachable  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13134] - Support No Value Set in Edit Parameter Context. [nifi]
mcgilman commented on PR #8733: URL: https://github.com/apache/nifi/pull/8733#issuecomment-2093098313 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13136: Allowing users to unset optional property values [nifi]
rfellows commented on PR #8734: URL: https://github.com/apache/nifi/pull/8734#issuecomment-2093097636 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13128) [BUG] invalid port missing caution-color
[ https://issues.apache.org/jira/browse/NIFI-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13128: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > [BUG] invalid port missing caution-color > > > Key: NIFI-13128 > URL: https://issues.apache.org/jira/browse/NIFI-13128 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Attachments: Screenshot 2024-05-02 at 4.14.02 PM.png > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13128) [BUG] invalid port missing caution-color
[ https://issues.apache.org/jira/browse/NIFI-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843221#comment-17843221 ] ASF subversion and git services commented on NIFI-13128: Commit f7dc3247018abc5de9d3abb07ab08d38c88df13e in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f7dc324701 ] [NIFI-13128] add missing caution-color to invalid input port (#8731) This closes #8731 > [BUG] invalid port missing caution-color > > > Key: NIFI-13128 > URL: https://issues.apache.org/jira/browse/NIFI-13128 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-02 at 4.14.02 PM.png > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13128] add missing caution-color to invalid input port [nifi]
rfellows merged PR #8731: URL: https://github.com/apache/nifi/pull/8731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13122) [BUG] - select all parameter checkbox is not visible
[ https://issues.apache.org/jira/browse/NIFI-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13122: --- Fix Version/s: 2.0.0-M3 > [BUG] - select all parameter checkbox is not visible > > > Key: NIFI-13122 > URL: https://issues.apache.org/jira/browse/NIFI-13122 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Attachments: Screenshot 2024-05-02 at 9.51.25 AM.png, Screenshot > 2024-05-02 at 9.51.32 AM.png, Screenshot 2024-05-02 at 9.51.38 AM.png > > Time Spent: 20m > Remaining Estimate: 0h > > the checkbox we use to support select all, select none, or indicate some are > selected isn't clearly defined when checked or indicating some are selected. > It isn't immediately apparent that you can interact with it. It is fine when > nothing is selected because it has an outline: > > !Screenshot 2024-05-02 at 9.51.25 AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13122) [BUG] - select all parameter checkbox is not visible
[ https://issues.apache.org/jira/browse/NIFI-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13122: --- Resolution: Fixed Status: Resolved (was: Patch Available) > [BUG] - select all parameter checkbox is not visible > > > Key: NIFI-13122 > URL: https://issues.apache.org/jira/browse/NIFI-13122 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-02 at 9.51.25 AM.png, Screenshot > 2024-05-02 at 9.51.32 AM.png, Screenshot 2024-05-02 at 9.51.38 AM.png > > Time Spent: 20m > Remaining Estimate: 0h > > the checkbox we use to support select all, select none, or indicate some are > selected isn't clearly defined when checked or indicating some are selected. > It isn't immediately apparent that you can interact with it. It is fine when > nothing is selected because it has an outline: > > !Screenshot 2024-05-02 at 9.51.25 AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13122) [BUG] - select all parameter checkbox is not visible
[ https://issues.apache.org/jira/browse/NIFI-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843220#comment-17843220 ] ASF subversion and git services commented on NIFI-13122: Commit 3f2c0a39dbeb45ed1d418289ea041fad6e125b64 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3f2c0a39db ] [NIFI-13122] use accent color for checkbox on top of primary color (#8730) This closes #8730 > [BUG] - select all parameter checkbox is not visible > > > Key: NIFI-13122 > URL: https://issues.apache.org/jira/browse/NIFI-13122 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-02 at 9.51.25 AM.png, Screenshot > 2024-05-02 at 9.51.32 AM.png, Screenshot 2024-05-02 at 9.51.38 AM.png > > Time Spent: 20m > Remaining Estimate: 0h > > the checkbox we use to support select all, select none, or indicate some are > selected isn't clearly defined when checked or indicating some are selected. > It isn't immediately apparent that you can interact with it. It is fine when > nothing is selected because it has an outline: > > !Screenshot 2024-05-02 at 9.51.25 AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13122] use accent color for checkbox on top of primary color [nifi]
rfellows merged PR #8730: URL: https://github.com/apache/nifi/pull/8730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13129) [BUG] selected prioritizer order is not honored when displayed in the UI
[ https://issues.apache.org/jira/browse/NIFI-13129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13129: --- Status: Patch Available (was: In Progress) > [BUG] selected prioritizer order is not honored when displayed in the UI > > > Key: NIFI-13129 > URL: https://issues.apache.org/jira/browse/NIFI-13129 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Rob Fellows >Priority: Major > Attachments: image-2024-05-02-16-24-55-252.png > > Time Spent: 10m > Remaining Estimate: 0h > > !image-2024-05-02-16-24-55-252.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
