[PR] NIFI-13189 bumped testcontainers, aws/amazon, and picoli [nifi]
joewitt opened a new pull request, #8785: URL: https://github.com/apache/nifi/pull/8785 # Summary [NIFI-13189](https://issues.apache.org/jira/browse/NIFI-13189) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13189) Update AWS and Testcontainers dependencies
[ https://issues.apache.org/jira/browse/NIFI-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13189: Status: Patch Available (was: Open) > Update AWS and Testcontainers dependencies > -- > > Key: NIFI-13189 > URL: https://issues.apache.org/jira/browse/NIFI-13189 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > > org.testcontainers 1.19.7 to 1.19.8 > software.amazon.awssdk 2.25.46 to 2.25.48 > com.amazonaws 1.12.716 to 1.12.718 > picocli 4.7.5 to 4.7.6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13189) Update AWS and Testcontainers dependencies
Joe Witt created NIFI-13189: --- Summary: Update AWS and Testcontainers dependencies Key: NIFI-13189 URL: https://issues.apache.org/jira/browse/NIFI-13189 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt org.testcontainers 1.19.7 to 1.19.8 software.amazon.awssdk 2.25.46 to 2.25.48 com.amazonaws 1.12.716 to 1.12.718 picocli 4.7.5 to 4.7.6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13188 updated to latest dependency check plugin 9.1.0 [nifi]
joewitt commented on PR #8784: URL: https://github.com/apache/nifi/pull/8784#issuecomment-2101981759 I again created this PR on the back of another PR. So this trivial change will need to be cherry-picked. Instructions on how to use this new version are on the JIRA. It will execute very slowly without an API key as the download is substantially throttled but it does appear to work. With an API key it is much faster. We should consider getting a key for the NiFi CI builds and will want to cache the results for several hours/full day. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13188 updated to latest dependency check plugin 9.1.0 [nifi]
joewitt opened a new pull request, #8784: URL: https://github.com/apache/nifi/pull/8784 # Summary [NIFI-13188](https://issues.apache.org/jira/browse/NIFI-13188) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13188) Upgrade to dependency-check 9.1.0
[
https://issues.apache.org/jira/browse/NIFI-13188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844865#comment-17844865
]
Joe Witt commented on NIFI-13188:
-
Steps to run the new version:
1. Execute this command at the nifi root
{noformat}
mvn org.owasp:dependency-check-maven:9.1.0:purge
{noformat}
2. optionally go to request an NVD API key
https://nvd.nist.gov/developers/request-an-api-key
3. Execute if you requested a key
mvn validate -Pdependency-check -DnvdApiKey=
OR if you did not request a key
mvn validate -Pdependency-check
> Upgrade to dependency-check 9.1.0
> -
>
> Key: NIFI-13188
> URL: https://issues.apache.org/jira/browse/NIFI-13188
> Project: Apache NiFi
> Issue Type: Task
>Reporter: Joe Witt
>Assignee: Joe Witt
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-13188) Upgrade to dependency-check 9.1.0
Joe Witt created NIFI-13188: --- Summary: Upgrade to dependency-check 9.1.0 Key: NIFI-13188 URL: https://issues.apache.org/jira/browse/NIFI-13188 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13186 corrected required runtime dep lucene-backward-codecs and … [nifi]
joewitt commented on PR #8782: URL: https://github.com/apache/nifi/pull/8782#issuecomment-2101910023 Additional code changes applied now. Tested with a previous build generating Lucene-8 indexes with a range of content. Verified then again post this patch and it picks up where it left off, is still queryable, and continues generating new indexes with the lucene-9 naming. Was able to query both old and new data in the system. Also verifed query syntax still works despite not including the queryparsers module at this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13105 Implement a FlowRegistryClient that use GitHub for version… [nifi]
bbende commented on code in PR #8765:
URL: https://github.com/apache/nifi/pull/8765#discussion_r1594911232
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -0,0 +1,633 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.nifi.github;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.MapperFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import com.fasterxml.jackson.databind.json.JsonMapper;
+import com.fasterxml.jackson.databind.type.TypeFactory;
+import
com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flow.ConnectableComponent;
+import org.apache.nifi.flow.Position;
+import org.apache.nifi.flow.VersionedComponent;
+import org.apache.nifi.flow.VersionedConnection;
+import org.apache.nifi.flow.VersionedFlowCoordinates;
+import org.apache.nifi.flow.VersionedProcessGroup;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.registry.flow.AbstractFlowRegistryClient;
+import org.apache.nifi.registry.flow.BucketLocation;
+import org.apache.nifi.registry.flow.FlowLocation;
+import org.apache.nifi.registry.flow.FlowRegistryBranch;
+import org.apache.nifi.registry.flow.FlowRegistryBucket;
+import org.apache.nifi.registry.flow.FlowRegistryClientConfigurationContext;
+import org.apache.nifi.registry.flow.FlowRegistryException;
+import org.apache.nifi.registry.flow.FlowRegistryPermissions;
+import org.apache.nifi.registry.flow.FlowVersionLocation;
+import org.apache.nifi.registry.flow.RegisterAction;
+import org.apache.nifi.registry.flow.RegisteredFlow;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshot;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshotMetadata;
+import org.kohsuke.github.GHCommit;
+import org.kohsuke.github.GHContent;
+import org.kohsuke.github.GHContentUpdateResponse;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.stream.Collectors;
+
+/**
+ * Implementation of {@link org.apache.nifi.registry.flow.FlowRegistryClient}
that uses GitHub for version controlling flows.
+ */
+public class GitHubFlowRegistryClient extends AbstractFlowRegistryClient {
+
+static final PropertyDescriptor GITHUB_API_URL = new
PropertyDescriptor.Builder()
+.name("GitHub API URL")
+.description("The URL of the GitHub API")
+.addValidator(StandardValidators.URL_VALIDATOR)
+.defaultValue("https://api.github.com/;)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_NAME = new
PropertyDescriptor.Builder()
+.name("Repository Name")
+.description("The name of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_OWNER = new
PropertyDescriptor.Builder()
+.name("Repository Owner")
+.description("The owner of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_BRANCH = new
PropertyDescriptor.Builder()
+.name("Default Branch")
+.description("The default branch to use for this client")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.defaultValue("main")
+.required(true)
+
Re: [PR] NIFI-13105 Implement a FlowRegistryClient that use GitHub for version… [nifi]
bbende commented on code in PR #8765:
URL: https://github.com/apache/nifi/pull/8765#discussion_r1594911047
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -0,0 +1,633 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.nifi.github;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.MapperFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import com.fasterxml.jackson.databind.json.JsonMapper;
+import com.fasterxml.jackson.databind.type.TypeFactory;
+import
com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flow.ConnectableComponent;
+import org.apache.nifi.flow.Position;
+import org.apache.nifi.flow.VersionedComponent;
+import org.apache.nifi.flow.VersionedConnection;
+import org.apache.nifi.flow.VersionedFlowCoordinates;
+import org.apache.nifi.flow.VersionedProcessGroup;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.registry.flow.AbstractFlowRegistryClient;
+import org.apache.nifi.registry.flow.BucketLocation;
+import org.apache.nifi.registry.flow.FlowLocation;
+import org.apache.nifi.registry.flow.FlowRegistryBranch;
+import org.apache.nifi.registry.flow.FlowRegistryBucket;
+import org.apache.nifi.registry.flow.FlowRegistryClientConfigurationContext;
+import org.apache.nifi.registry.flow.FlowRegistryException;
+import org.apache.nifi.registry.flow.FlowRegistryPermissions;
+import org.apache.nifi.registry.flow.FlowVersionLocation;
+import org.apache.nifi.registry.flow.RegisterAction;
+import org.apache.nifi.registry.flow.RegisteredFlow;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshot;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshotMetadata;
+import org.kohsuke.github.GHCommit;
+import org.kohsuke.github.GHContent;
+import org.kohsuke.github.GHContentUpdateResponse;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.stream.Collectors;
+
+/**
+ * Implementation of {@link org.apache.nifi.registry.flow.FlowRegistryClient}
that uses GitHub for version controlling flows.
+ */
+public class GitHubFlowRegistryClient extends AbstractFlowRegistryClient {
+
+static final PropertyDescriptor GITHUB_API_URL = new
PropertyDescriptor.Builder()
+.name("GitHub API URL")
+.description("The URL of the GitHub API")
+.addValidator(StandardValidators.URL_VALIDATOR)
+.defaultValue("https://api.github.com/;)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_NAME = new
PropertyDescriptor.Builder()
+.name("Repository Name")
+.description("The name of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_OWNER = new
PropertyDescriptor.Builder()
+.name("Repository Owner")
+.description("The owner of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_BRANCH = new
PropertyDescriptor.Builder()
+.name("Default Branch")
+.description("The default branch to use for this client")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.defaultValue("main")
+.required(true)
+
Re: [PR] NIFI-13105 Implement a FlowRegistryClient that use GitHub for version… [nifi]
bbende commented on code in PR #8765:
URL: https://github.com/apache/nifi/pull/8765#discussion_r1594910869
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -0,0 +1,633 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.nifi.github;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.MapperFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import com.fasterxml.jackson.databind.json.JsonMapper;
+import com.fasterxml.jackson.databind.type.TypeFactory;
+import
com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flow.ConnectableComponent;
+import org.apache.nifi.flow.Position;
+import org.apache.nifi.flow.VersionedComponent;
+import org.apache.nifi.flow.VersionedConnection;
+import org.apache.nifi.flow.VersionedFlowCoordinates;
+import org.apache.nifi.flow.VersionedProcessGroup;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.registry.flow.AbstractFlowRegistryClient;
+import org.apache.nifi.registry.flow.BucketLocation;
+import org.apache.nifi.registry.flow.FlowLocation;
+import org.apache.nifi.registry.flow.FlowRegistryBranch;
+import org.apache.nifi.registry.flow.FlowRegistryBucket;
+import org.apache.nifi.registry.flow.FlowRegistryClientConfigurationContext;
+import org.apache.nifi.registry.flow.FlowRegistryException;
+import org.apache.nifi.registry.flow.FlowRegistryPermissions;
+import org.apache.nifi.registry.flow.FlowVersionLocation;
+import org.apache.nifi.registry.flow.RegisterAction;
+import org.apache.nifi.registry.flow.RegisteredFlow;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshot;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshotMetadata;
+import org.kohsuke.github.GHCommit;
+import org.kohsuke.github.GHContent;
+import org.kohsuke.github.GHContentUpdateResponse;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.stream.Collectors;
+
+/**
+ * Implementation of {@link org.apache.nifi.registry.flow.FlowRegistryClient}
that uses GitHub for version controlling flows.
+ */
+public class GitHubFlowRegistryClient extends AbstractFlowRegistryClient {
+
+static final PropertyDescriptor GITHUB_API_URL = new
PropertyDescriptor.Builder()
+.name("GitHub API URL")
+.description("The URL of the GitHub API")
+.addValidator(StandardValidators.URL_VALIDATOR)
+.defaultValue("https://api.github.com/;)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_NAME = new
PropertyDescriptor.Builder()
+.name("Repository Name")
+.description("The name of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_OWNER = new
PropertyDescriptor.Builder()
+.name("Repository Owner")
+.description("The owner of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_BRANCH = new
PropertyDescriptor.Builder()
+.name("Default Branch")
+.description("The default branch to use for this client")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.defaultValue("main")
+.required(true)
+
Re: [PR] NIFI-13105 Implement a FlowRegistryClient that use GitHub for version… [nifi]
bbende commented on code in PR #8765:
URL: https://github.com/apache/nifi/pull/8765#discussion_r1594910362
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -0,0 +1,633 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.nifi.github;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.MapperFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import com.fasterxml.jackson.databind.json.JsonMapper;
+import com.fasterxml.jackson.databind.type.TypeFactory;
+import
com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flow.ConnectableComponent;
+import org.apache.nifi.flow.Position;
+import org.apache.nifi.flow.VersionedComponent;
+import org.apache.nifi.flow.VersionedConnection;
+import org.apache.nifi.flow.VersionedFlowCoordinates;
+import org.apache.nifi.flow.VersionedProcessGroup;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.registry.flow.AbstractFlowRegistryClient;
+import org.apache.nifi.registry.flow.BucketLocation;
+import org.apache.nifi.registry.flow.FlowLocation;
+import org.apache.nifi.registry.flow.FlowRegistryBranch;
+import org.apache.nifi.registry.flow.FlowRegistryBucket;
+import org.apache.nifi.registry.flow.FlowRegistryClientConfigurationContext;
+import org.apache.nifi.registry.flow.FlowRegistryException;
+import org.apache.nifi.registry.flow.FlowRegistryPermissions;
+import org.apache.nifi.registry.flow.FlowVersionLocation;
+import org.apache.nifi.registry.flow.RegisterAction;
+import org.apache.nifi.registry.flow.RegisteredFlow;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshot;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshotMetadata;
+import org.kohsuke.github.GHCommit;
+import org.kohsuke.github.GHContent;
+import org.kohsuke.github.GHContentUpdateResponse;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.stream.Collectors;
+
+/**
+ * Implementation of {@link org.apache.nifi.registry.flow.FlowRegistryClient}
that uses GitHub for version controlling flows.
+ */
+public class GitHubFlowRegistryClient extends AbstractFlowRegistryClient {
+
+static final PropertyDescriptor GITHUB_API_URL = new
PropertyDescriptor.Builder()
+.name("GitHub API URL")
+.description("The URL of the GitHub API")
+.addValidator(StandardValidators.URL_VALIDATOR)
+.defaultValue("https://api.github.com/;)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_NAME = new
PropertyDescriptor.Builder()
+.name("Repository Name")
+.description("The name of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_OWNER = new
PropertyDescriptor.Builder()
+.name("Repository Owner")
+.description("The owner of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_BRANCH = new
PropertyDescriptor.Builder()
+.name("Default Branch")
+.description("The default branch to use for this client")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.defaultValue("main")
+.required(true)
+
[jira] [Assigned] (NIFI-12669) EvaluateXQuery processor incorrectly encodes result attributes
[
https://issues.apache.org/jira/browse/NIFI-12669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Steinebrey reassigned NIFI-12669:
-
Assignee: Jim Steinebrey
> EvaluateXQuery processor incorrectly encodes result attributes
> --
>
> Key: NIFI-12669
> URL: https://issues.apache.org/jira/browse/NIFI-12669
> Project: Apache NiFi
> Issue Type: Bug
> Components: Configuration, Extensions
>Affects Versions: 2.0.0-M1, 1.24.0, 1.25.0, 2.0.0-M2
> Environment: JVM with non-UTF-8 default encoding (e.g. default
> Windows installation)
>Reporter: René Zeidler
>Assignee: Jim Steinebrey
>Priority: Major
> Labels: encoding, utf8, windows, xml
> Attachments: EvaluateXQuery_Encoding_Bug.json,
> image-2024-01-25-10-24-17-005.png, image-2024-01-25-10-31-35-200.png
>
>
> h2. Environment
> This issue affects environments where the JVM default encoding is not
> {{{}UTF-8{}}}. Standard Java installations on Windows are affected, as they
> usually use the default encoding {{{}windows-1252{}}}. To reproduce the issue
> on Linux, change the default encoding to {{windows-1252}} by adding the
> following line to your {{{}bootstrap.conf{}}}:
> {quote}{{java.arg.21=-Dfile.encoding=windows-1252}}
> {quote}
> h2. Summary
> The EvaluateXQuery incorrectly encodes result values when storing them in
> attributes. This causes non-ASCII characters to be garbled.
> Example:
> !image-2024-01-25-10-24-17-005.png!
> h2. Steps to reproduce
> # Make sure NiFi runs with a non-UTF-8 default encoding, see "Environment"
> # Create a GenerateFlowFile processor with the following content:
> {quote}{{}}
> {{}}
> {{ This text contains non-ASCII characters: ÄÖÜäöüßéèóò}}
> {{}}
> {quote}
> # Connect the processor to an EvaluateXQuery processor.
> Set the {{Destination}} to {{{}flowfile-attribute{}}}.
> Create a custom property {{myData}} with value {{{}string(/myRoot/myData){}}}.
> # Connect the outputs of the EvaluateXQuery processor to funnels to be able
> to observe the result in the queue.
> # Start the EvaluateXQuery processor and run the GenerateFlowFile processor
> once.
> The flow should look similar to this:
> !image-2024-01-25-10-31-35-200.png!
> I also attached a JSON export of the example flow.
> # Observe the attributes of the resulting FlowFile in the queue.
> h3. Expected Result
> The FlowFile should contain an attribute {{myData}} with the value {{{}"This
> text contains non-ASCII characters: ÄÖÜäöüßéèóò"{}}}.
> h3. Actual Result
> The attribute has the value "This text contains non-ASCII characters:
> ÄÖÜäöüßéèóò".
> h2. Root Cause Analysis
> EvaluateXQuery uses the method
> [{{formatItem}}|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java#L368-L372]
> to write the query result to an attribute. This method calls
> {{{}ByteArrayOutputStream{}}}'s
> [toString|https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/ByteArrayOutputStream.html#toString()]
> method without an encoding argument, which then defaults to the default
> charset of the environment. Bytes are always written to this output stream
> using UTF-8
> ([.getBytes(StandardCharsets.UTF8)|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java#L397]).
> When the default charset is not UTF-8, this results in UTF-8 bytes to be
> interpreted in a different encoding when converting to a string, resulting in
> garbled text (see above).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-13187 - Modernize Archetypes [nifi]
joewitt commented on PR #8783: URL: https://github.com/apache/nifi/pull/8783#issuecomment-2101792965 nice. will let the ci bits validate rat/checkstyle and then merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13187 - Modernize Archetypes [nifi]
bobpaulin opened a new pull request, #8783: URL: https://github.com/apache/nifi/pull/8783 # Summary [NIFI-13187](https://issues.apache.org/jira/browse/NIFI-13187) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-13187) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13187) Modernize Nifi Maven Archetypes
Bob Paulin created NIFI-13187: - Summary: Modernize Nifi Maven Archetypes Key: NIFI-13187 URL: https://issues.apache.org/jira/browse/NIFI-13187 Project: Apache NiFi Issue Type: Bug Components: Tools and Build Affects Versions: 2.0.0-M3 Reporter: Bob Paulin * Modernize Nifi's Java archetypes using Immutable Map, List utils * Provide more readable property and relationship names * Provide example of flow file transfer usage -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13186 corrected required runtime dep lucene-backward-codecs and … [nifi]
joewitt opened a new pull request, #8782: URL: https://github.com/apache/nifi/pull/8782 …updated tests # Summary [NIFI-13186](https://issues.apache.org/jira/browse/NIFI-13186) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13186 corrected required runtime dep lucene-backward-codecs and … [nifi]
joewitt commented on PR #8782: URL: https://github.com/apache/nifi/pull/8782#issuecomment-2101721029 Validating against m2 built index (lucene 8.11.3) vs this PR. Will share more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated MINIFICPP-2346:
Description:
*NOTE:* I noticed you guys recently switched from 0.15 to 0.99, so at certain
point, I will pull in lastest updates from MiNiFi C++ main branch on parent
level and rebase or merge into my PR.
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
Here is my draft PR for this Jira Ticket for your reference:
[https://github.com/apache/nifi-minifi-cpp/pull/1775]
Here are the commands that I run:
{code:java}
cd $HOME/src/pipeline/nifi-minifi-cpp
# NOTE: I also plan to add smoother integration of conan commands into MiNiFI
CPP too
# For instance, I know you guys have your bootstrap scripts too
# You also have your github actions workflow scripts too
conan install . --output-folder=build
-pr=$HOME/src/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
# install conan packages and build C++ for minifi using Conan & CMake, we run
this way, so conan's tc.cache_variables
# are like passing -D{minifi_option} upon running cmake generate, then make
to build MiNiFi C++
conan build . --output-folder=build
-pr=/home/bizon/src/jam-repo/main/etc/build/conan/profiles/release-linux{code}
{color:#0747a6}*(UPDATE (May 8, 2024) -
[93fe5d1|https://github.com/apache/nifi-minifi-cpp/pull/1775/commits/93fe5d1a712834b422d5c8e45829a3641852ca7a]:*
{color:#172b4d}*Enabled NANOFI* lib and binary executable, {*}Enabled MiNiFi
C++ extensions SYSTEMD, PROCFS, LIBARCHIVE and XY_UTILS (LZMA){*}. I added
conan recipe for liblzma (xy_utils) and libarchive keeping the patches for
minifi. One area I found an issue with was integrating openssl conan package
with libarchive conan package and libarchive complained about not being able to
find openssl::openssl target. I did try to solve the issue by updating the
libarchive conan recipe, but wasn't able to solve that openssl integration
issue. I think the problem comes from libarchive CMakeLists.txt and its
integration with conan in the repo. I opened
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated MINIFICPP-2346:
Description:
*NOTE:* I noticed you guys recently switched from 0.15 to 0.99, so at certain
point, I will pull in lastest updates from MiNiFi C++ main branch on parent
level and rebase or merge into my PR.
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
Here is my draft PR for this Jira Ticket for your reference:
[https://github.com/apache/nifi-minifi-cpp/pull/1775]
Here are the commands that I run:
{code:java}
cd $HOME/src/pipeline/nifi-minifi-cpp
# NOTE: I also plan to add smoother integration of conan commands into MiNiFI
CPP too
# For instance, I know you guys have your bootstrap scripts too
# You also have your github actions workflow scripts too
conan install . --output-folder=build
-pr=$HOME/src/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
# install conan packages and build C++ for minifi using Conan & CMake, we run
this way, so conan's tc.cache_variables
# are like passing -D{minifi_option} upon running cmake generate, then make
to build MiNiFi C++
conan build . --output-folder=build
-pr=/home/bizon/src/jam-repo/main/etc/build/conan/profiles/release-linux{code}
{color:#0747a6}*(UPDATE (May 8, 2024) -
[93fe5d1|https://github.com/apache/nifi-minifi-cpp/pull/1775/commits/93fe5d1a712834b422d5c8e45829a3641852ca7a]:*
{color:#172b4d}*Enabled NANOFI* lib and binary executable, {*}Enabled MiNiFi
C++ extensions SYSTEMD, PROCFS, LIBARCHIVE and XY_UTILS (LZMA){*}. I added
conan recipe for liblzma (xy_utils) and libarchive keeping the patches for
minifi. One area I found an issue with was integrating openssl conan package
with libarchive conan package and libarchive complained about not being able to
find openssl::openssl target. I did try to solve the issue by updating the
libarchive conan recipe, but wasn't able to solve that openssl integration
issue. I think the problem comes from libarchive CMakeLists.txt and its
integration with conan in the repo. I opened
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Guzman (Medel) updated MINIFICPP-2346:
Description:
*NOTE:* I noticed you guys recently switched from 0.15 to 0.99, so at certain
point, I will pull in lastest updates from MiNiFi C++ main branch on parent
level and rebase or merge into my PR.
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
Here is my draft PR for this Jira Ticket for your reference:
[https://github.com/apache/nifi-minifi-cpp/pull/1775]
Here are the commands that I run:
{code:java}
cd $HOME/src/pipeline/nifi-minifi-cpp
# NOTE: I also plan to add smoother integration of conan commands into MiNiFI
CPP too
# For instance, I know you guys have your bootstrap scripts too
# You also have your github actions workflow scripts too
conan install . --output-folder=build
-pr=$HOME/src/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
# install conan packages and build C++ for minifi using Conan & CMake, we run
this way, so conan's tc.cache_variables
# are like passing -D{minifi_option} upon running cmake generate, then make
to build MiNiFi C++
conan build . --output-folder=build
-pr=/home/bizon/src/jam-repo/main/etc/build/conan/profiles/release-linux{code}
{color:#0747a6}*UPDATE (May 7, 2024)* -
[2460e84|https://github.com/apache/nifi-minifi-cpp/pull/1775/commits/2460e846832d693c991e1da632b86ba2d4e34516]:
{color:#172b4d}*Enabled OPS and OPC* MiNiFi Options, so those *MiNiFi C++
extensions* are built using *Conan CMake* and their bundled CMake dependencies
use their particular *{{open62541/1.3.3@minifi/dev}}* and
{*}{{mbedtls/2.16.3@minifi/dev}} conan packages{*}. I had to fix the mbedtls
conan package from conan center index since it wasnt compatible when open62541
tried to integrate with mbedtls. In the thirdparty folder, you will see on line
139 where I updated libembedtls to be libmbedtls and fixing that typo allowed
open62541 conan package to be able to be created with mbedtls as the
encryption. I plan to make a follow up PR on conan center
[jira] [Commented] (NIFI-13186) Lucene 9 upgrade no longer depends on various modules so we need to pull in the legacy module for migration
[ https://issues.apache.org/jira/browse/NIFI-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844810#comment-17844810 ] Joe Witt commented on NIFI-13186: - Should have caught in the previous JIRA but local testing did not properly retain old repositories as previously expected. > Lucene 9 upgrade no longer depends on various modules so we need to pull in > the legacy module for migration > --- > > Key: NIFI-13186 > URL: https://issues.apache.org/jira/browse/NIFI-13186 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M3 >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13186) Lucene 9 upgrade no longer depends on various modules so we need to pull in the legacy module for migration
[ https://issues.apache.org/jira/browse/NIFI-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844806#comment-17844806 ] Joe Witt commented on NIFI-13186: - https://issues.apache.org/jira/browse/NIFI-13163 in this update it appears lucene no longer explicitly depends on various modules so legacy codecs for instance we need to declare specifically. > Lucene 9 upgrade no longer depends on various modules so we need to pull in > the legacy module for migration > --- > > Key: NIFI-13186 > URL: https://issues.apache.org/jira/browse/NIFI-13186 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M3 >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13186) Lucene 9 upgrade no longer depends on various modules so we need to pull in the legacy module for migration
Joe Witt created NIFI-13186: --- Summary: Lucene 9 upgrade no longer depends on various modules so we need to pull in the legacy module for migration Key: NIFI-13186 URL: https://issues.apache.org/jira/browse/NIFI-13186 Project: Apache NiFi Issue Type: Bug Affects Versions: 2.0.0-M3 Reporter: Joe Witt Assignee: Joe Witt Fix For: 2.0.0-M3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13185) Remove "integration tests" which are not maintained and require personal credentials to Cloud services
Joe Witt created NIFI-13185: --- Summary: Remove "integration tests" which are not maintained and require personal credentials to Cloud services Key: NIFI-13185 URL: https://issues.apache.org/jira/browse/NIFI-13185 Project: Apache NiFi Issue Type: Task Reporter: Joe Witt Assignee: Joe Witt There is a rather large chunk of code and pom configuration sitting in our codebase for tests which are never run or maintained. These are for cloud services/integrations that are simply not exercised/maintained and are therefore not useful. Of course having real tests to these systems is valuable but unless they're run and maintained they're not. Meanwhile a ton of excellent work has occurred to vet behaviors using things like test containers and those are easily run by anyone with docker/etc.. We should remove all these tests which dont get maintained and require special permissions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-13158) Support keyboard shortcuts on the canvas
[ https://issues.apache.org/jira/browse/NIFI-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman resolved NIFI-13158. Fix Version/s: 2.0.0-M3 Resolution: Fixed > Support keyboard shortcuts on the canvas > > > Key: NIFI-13158 > URL: https://issues.apache.org/jira/browse/NIFI-13158 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 40m > Remaining Estimate: 0h > > CTRL+R -> reload canvas > CTRL+A -> select all > CTRL+C -> copy > CTRL+V -> paste > Backspace/Delete -> delete > ESC -> leave group -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13158) Support keyboard shortcuts on the canvas
[ https://issues.apache.org/jira/browse/NIFI-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844798#comment-17844798 ] ASF subversion and git services commented on NIFI-13158: Commit a840c14c8410fe11d4e71499e758195623b24053 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a840c14c84 ] [NIFI-13158] - Fix: need to prevent/diable keyboard hotkeys when a dialog is open or when typeing in the search bar. (#8781) This closes #8781 > Support keyboard shortcuts on the canvas > > > Key: NIFI-13158 > URL: https://issues.apache.org/jira/browse/NIFI-13158 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > CTRL+R -> reload canvas > CTRL+A -> select all > CTRL+C -> copy > CTRL+V -> paste > Backspace/Delete -> delete > ESC -> leave group -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13158] - Fix: need to prevent/disable keyboard hotkeys when a dialog is open or when typing in the search bar. [nifi]
mcgilman merged PR #8781: URL: https://github.com/apache/nifi/pull/8781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13176) Relax the minimum scale on the canvas
[ https://issues.apache.org/jira/browse/NIFI-13176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844795#comment-17844795 ] ASF subversion and git services commented on NIFI-13176: Commit 63cc1c3af6309a47c6b45cb6a6b295505304a0f5 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=63cc1c3af6 ] NIFI-13176: (#8780) - Relaxing the scale that triggers when details for components on the canvas are not rendered. This closes #8780 > Relax the minimum scale on the canvas > - > > Key: NIFI-13176 > URL: https://issues.apache.org/jira/browse/NIFI-13176 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13176) Relax the minimum scale on the canvas
[ https://issues.apache.org/jira/browse/NIFI-13176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13176: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Relax the minimum scale on the canvas > - > > Key: NIFI-13176 > URL: https://issues.apache.org/jira/browse/NIFI-13176 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13176: Relaxing the scale that triggers when details for components on the canvas are not rendered [nifi]
scottyaslan merged PR #8780: URL: https://github.com/apache/nifi/pull/8780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13183] add drop shadow to connections to increase visibility on… [nifi]
scottyaslan commented on PR #8778: URL: https://github.com/apache/nifi/pull/8778#issuecomment-2101594936 @rfellows thanks for the thorough review! Great catch. I found this STO that I think hints at the issue you are seeing. Applying the drop shadow via css seems to have fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [NIFI-13158] - Fix: need to prevent/disable keyboard hotkeys when a dialog is open or when typing in the search bar. [nifi]
rfellows opened a new pull request, #8781: URL: https://github.com/apache/nifi/pull/8781 [NIFI-13158](https://issues.apache.org/jira/browse/NIFI-13158) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (NIFI-13158) Support keyboard shortcuts on the canvas
[ https://issues.apache.org/jira/browse/NIFI-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows reopened NIFI-13158: Initial PR did not disable keyboard shortcuts when a dialog was open of when typing in the search bar. > Support keyboard shortcuts on the canvas > > > Key: NIFI-13158 > URL: https://issues.apache.org/jira/browse/NIFI-13158 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > CTRL+R -> reload canvas > CTRL+A -> select all > CTRL+C -> copy > CTRL+V -> paste > Backspace/Delete -> delete > ESC -> leave group -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13181 Updated msal4j to 1.15.0 [nifi]
exceptionfactory closed pull request #8777: NIFI-13181 Updated msal4j to 1.15.0 URL: https://github.com/apache/nifi/pull/8777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13181 Updated msal4j to 1.15.0 [nifi]
exceptionfactory commented on PR #8777: URL: https://github.com/apache/nifi/pull/8777#issuecomment-2101470175 Merged in https://github.com/apache/nifi/commit/dc39334b37407d92c45974b134b28fc5bc80d19d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13180) Content viewer does not display "json-lines" completely when view-as is set to formatted
[ https://issues.apache.org/jira/browse/NIFI-13180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844783#comment-17844783 ] Andrew M. Lim commented on NIFI-13180: -- [~dstiegli1] Thanks for taking the time to add your comment. Good question about what what formatted multiline JSON should look like. > Content viewer does not display "json-lines" completely when view-as is set > to formatted > > > Key: NIFI-13180 > URL: https://issues.apache.org/jira/browse/NIFI-13180 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Andrew M. Lim >Priority: Minor > Attachments: PDF-test.pdf, image-2024-05-07-19-06-19-292.png, > screenshot-1.png > > > ParseDocument is a Python processor whose output is formatted as > "json-lines". When looking at the FlowFile contents in the content viewer > with view-as set to "original", multiple lines are displayed as expected: > !image-2024-05-07-19-06-19-292.png! > But, if view-as is set to "formatted", only one line is shown: > !screenshot-1.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13105 Implement a FlowRegistryClient that use GitHub for version… [nifi]
bbende commented on PR #8765: URL: https://github.com/apache/nifi/pull/8765#issuecomment-2101392260 @simonbence I pushed up some improvements based on your review, I think the permissions part is working much better now that I figured out how get the permissions that the client has to the repo, and can use them to set the bucket permissions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13184) Adjust process group processor filter to enable auto-start of Python processors after dependency download
[ https://issues.apache.org/jira/browse/NIFI-13184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Grey updated NIFI-13184: - Description: On flow initialization, Python processors requiring download of dependencies are temporarily marked "INVALID" by the framework, in order to resolve the dependencies. Invocation of a "ProcessGroup / Start" action during this period of time excludes the affected Python processors, due to operant filter [1]. Removal of the "IsValid" filter will cause these processors to be marked appropriately, which will cause them to be started once the dependencies are resolved. [1] https://github.com/apache/nifi/blob/6950290c247bfa81b6ea0458bc79246e6c7bb39f/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/groups/ProcessGroup.java#L71 > Adjust process group processor filter to enable auto-start of Python > processors after dependency download > - > > Key: NIFI-13184 > URL: https://issues.apache.org/jira/browse/NIFI-13184 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Grey >Assignee: Paul Grey >Priority: Minor > > On flow initialization, Python processors requiring download of dependencies > are temporarily marked "INVALID" by the framework, in order to resolve the > dependencies. Invocation of a "ProcessGroup / Start" action during this > period of time excludes the affected Python processors, due to operant filter > [1]. > Removal of the "IsValid" filter will cause these processors to be marked > appropriately, which will cause them to be started once the dependencies are > resolved. > [1] > https://github.com/apache/nifi/blob/6950290c247bfa81b6ea0458bc79246e6c7bb39f/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/groups/ProcessGroup.java#L71 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13184) Adjust process group processor filter to enable auto-start of Python processors after dependency download
Paul Grey created NIFI-13184: Summary: Adjust process group processor filter to enable auto-start of Python processors after dependency download Key: NIFI-13184 URL: https://issues.apache.org/jira/browse/NIFI-13184 Project: Apache NiFi Issue Type: Improvement Reporter: Paul Grey Assignee: Paul Grey -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13176) Relax the minimum scale on the canvas
[ https://issues.apache.org/jira/browse/NIFI-13176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13176: --- Status: Patch Available (was: In Progress) > Relax the minimum scale on the canvas > - > > Key: NIFI-13176 > URL: https://issues.apache.org/jira/browse/NIFI-13176 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13176) Relax the minimum scale on the canvas
[ https://issues.apache.org/jira/browse/NIFI-13176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-13176: -- Assignee: Matt Gilman > Relax the minimum scale on the canvas > - > > Key: NIFI-13176 > URL: https://issues.apache.org/jira/browse/NIFI-13176 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13181) Azure Blob and ADLS processors throw NoSuchMethodError when Service Principal is used
[
https://issues.apache.org/jira/browse/NIFI-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-13181:
Fix Version/s: 1.27.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Azure Blob and ADLS processors throw NoSuchMethodError when Service Principal
> is used
> -
>
> Key: NIFI-13181
> URL: https://issues.apache.org/jira/browse/NIFI-13181
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.26.0
>Reporter: Zoltán Kornél Török
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 1.27.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I spent some time testing nifi 1.26 and found this error, when tried to use
> blobstorage related processors, like ListAzureBlobStorage_v12 .
> {code:java}
> 2024-05-08 09:09:06,416 WARN reactor.core.Exceptions: throwIfFatal detected a
> jvm fatal exception, which is thrown and logged below:
> java.lang.NoSuchMethodError:
> com.microsoft.aad.msal4j.ConfidentialClientApplication$Builder.logPii(Z)Lcom/microsoft/aad/msal4j/AbstractApplicationBase$Builder;
> at
> com.azure.identity.implementation.IdentityClientBase.getConfidentialClient(IdentityClientBase.java:233)
> at
> com.azure.identity.implementation.IdentityClient.lambda$getConfidentialClientApplication$4(IdentityClient.java:130)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:45)
> at
> reactor.core.publisher.MonoCacheTime.subscribeOrReturn(MonoCacheTime.java:143)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
> at reactor.core.publisher.MonoUsing.subscribe(MonoUsing.java:102)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at
> reactor.core.publisher.MonoFromFluxOperator.subscribe(MonoFromFluxOperator.java:81)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.subscribeNext(MonoIgnoreThen.java:263)
> at reactor.core.publisher.MonoIgnoreThen.subscribe(MonoIgnoreThen.java:51)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:203)
> at
> reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:203)
> at
> reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
> at reactor.core.publisher.Flux.subscribe(Flux.java:8628)
> at reactor.core.publisher.Flux.blockLast(Flux.java:2760)
> at
> com.azure.core.util.paging.ContinuablePagedByIteratorBase.requestPage(ContinuablePagedByIteratorBase.java:102)
> at
> com.azure.core.util.paging.ContinuablePagedByItemIterable$ContinuablePagedByItemIterator.(ContinuablePagedByItemIterable.java:75)
> at
> com.azure.core.util.paging.ContinuablePagedByItemIterable.iterator(ContinuablePagedByItemIterable.java:55)
> at
> com.azure.core.util.paging.ContinuablePagedIterable.iterator(ContinuablePagedIterable.java:141)
> at
> org.apache.nifi.processors.azure.storage.ListAzureBlobStorage_v12.performListing(ListAzureBlobStorage_v12.java:230)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.lambda$listByTrackingEntities$11(AbstractListProcessor.java:1126)
> at
> org.apache.nifi.processor.util.list.ListedEntityTracker.trackEntities(ListedEntityTracker.java:272)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.listByTrackingEntities(AbstractListProcessor.java:1124)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.onTrigger(AbstractListProcessor.java:529)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1361)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:247)
> at
>
[jira] [Commented] (NIFI-13181) Azure Blob and ADLS processors throw NoSuchMethodError when Service Principal is used
[
https://issues.apache.org/jira/browse/NIFI-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844761#comment-17844761
]
Joe Witt commented on NIFI-13181:
-
i am not in a position to execute the integration tests but I do see msal4j was
bumped on the latest sweeps of dep updates in 2.0 so will merge this as well.
The relationship between msal4j and a given bom reference of azure is ... I
wonder if we could just rely on that better. I'm not sure why msal4j is called
out separately. Thanks
> Azure Blob and ADLS processors throw NoSuchMethodError when Service Principal
> is used
> -
>
> Key: NIFI-13181
> URL: https://issues.apache.org/jira/browse/NIFI-13181
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.26.0
>Reporter: Zoltán Kornél Török
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I spent some time testing nifi 1.26 and found this error, when tried to use
> blobstorage related processors, like ListAzureBlobStorage_v12 .
> {code:java}
> 2024-05-08 09:09:06,416 WARN reactor.core.Exceptions: throwIfFatal detected a
> jvm fatal exception, which is thrown and logged below:
> java.lang.NoSuchMethodError:
> com.microsoft.aad.msal4j.ConfidentialClientApplication$Builder.logPii(Z)Lcom/microsoft/aad/msal4j/AbstractApplicationBase$Builder;
> at
> com.azure.identity.implementation.IdentityClientBase.getConfidentialClient(IdentityClientBase.java:233)
> at
> com.azure.identity.implementation.IdentityClient.lambda$getConfidentialClientApplication$4(IdentityClient.java:130)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:45)
> at
> reactor.core.publisher.MonoCacheTime.subscribeOrReturn(MonoCacheTime.java:143)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
> at reactor.core.publisher.MonoUsing.subscribe(MonoUsing.java:102)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at
> reactor.core.publisher.MonoFromFluxOperator.subscribe(MonoFromFluxOperator.java:81)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.subscribeNext(MonoIgnoreThen.java:263)
> at reactor.core.publisher.MonoIgnoreThen.subscribe(MonoIgnoreThen.java:51)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:203)
> at
> reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:203)
> at
> reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
> at reactor.core.publisher.Flux.subscribe(Flux.java:8628)
> at reactor.core.publisher.Flux.blockLast(Flux.java:2760)
> at
> com.azure.core.util.paging.ContinuablePagedByIteratorBase.requestPage(ContinuablePagedByIteratorBase.java:102)
> at
> com.azure.core.util.paging.ContinuablePagedByItemIterable$ContinuablePagedByItemIterator.(ContinuablePagedByItemIterable.java:75)
> at
> com.azure.core.util.paging.ContinuablePagedByItemIterable.iterator(ContinuablePagedByItemIterable.java:55)
> at
> com.azure.core.util.paging.ContinuablePagedIterable.iterator(ContinuablePagedIterable.java:141)
> at
> org.apache.nifi.processors.azure.storage.ListAzureBlobStorage_v12.performListing(ListAzureBlobStorage_v12.java:230)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.lambda$listByTrackingEntities$11(AbstractListProcessor.java:1126)
> at
> org.apache.nifi.processor.util.list.ListedEntityTracker.trackEntities(ListedEntityTracker.java:272)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.listByTrackingEntities(AbstractListProcessor.java:1124)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.onTrigger(AbstractListProcessor.java:529)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
>
[jira] [Commented] (NIFI-13181) Azure Blob and ADLS processors throw NoSuchMethodError when Service Principal is used
[
https://issues.apache.org/jira/browse/NIFI-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844762#comment-17844762
]
ASF subversion and git services commented on NIFI-13181:
Commit dc39334b37407d92c45974b134b28fc5bc80d19d in nifi's branch
refs/heads/support/nifi-1.x from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=dc39334b37 ]
NIFI-13181 Updated msal4j to 1.15.0
This closes #8777
Signed-off-by: Joseph Witt
> Azure Blob and ADLS processors throw NoSuchMethodError when Service Principal
> is used
> -
>
> Key: NIFI-13181
> URL: https://issues.apache.org/jira/browse/NIFI-13181
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.26.0
>Reporter: Zoltán Kornél Török
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I spent some time testing nifi 1.26 and found this error, when tried to use
> blobstorage related processors, like ListAzureBlobStorage_v12 .
> {code:java}
> 2024-05-08 09:09:06,416 WARN reactor.core.Exceptions: throwIfFatal detected a
> jvm fatal exception, which is thrown and logged below:
> java.lang.NoSuchMethodError:
> com.microsoft.aad.msal4j.ConfidentialClientApplication$Builder.logPii(Z)Lcom/microsoft/aad/msal4j/AbstractApplicationBase$Builder;
> at
> com.azure.identity.implementation.IdentityClientBase.getConfidentialClient(IdentityClientBase.java:233)
> at
> com.azure.identity.implementation.IdentityClient.lambda$getConfidentialClientApplication$4(IdentityClient.java:130)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:45)
> at
> reactor.core.publisher.MonoCacheTime.subscribeOrReturn(MonoCacheTime.java:143)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
> at reactor.core.publisher.MonoUsing.subscribe(MonoUsing.java:102)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at
> reactor.core.publisher.MonoFromFluxOperator.subscribe(MonoFromFluxOperator.java:81)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.subscribeNext(MonoIgnoreThen.java:263)
> at reactor.core.publisher.MonoIgnoreThen.subscribe(MonoIgnoreThen.java:51)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:203)
> at
> reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:203)
> at
> reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
> at reactor.core.publisher.Flux.subscribe(Flux.java:8628)
> at reactor.core.publisher.Flux.blockLast(Flux.java:2760)
> at
> com.azure.core.util.paging.ContinuablePagedByIteratorBase.requestPage(ContinuablePagedByIteratorBase.java:102)
> at
> com.azure.core.util.paging.ContinuablePagedByItemIterable$ContinuablePagedByItemIterator.(ContinuablePagedByItemIterable.java:75)
> at
> com.azure.core.util.paging.ContinuablePagedByItemIterable.iterator(ContinuablePagedByItemIterable.java:55)
> at
> com.azure.core.util.paging.ContinuablePagedIterable.iterator(ContinuablePagedIterable.java:141)
> at
> org.apache.nifi.processors.azure.storage.ListAzureBlobStorage_v12.performListing(ListAzureBlobStorage_v12.java:230)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.lambda$listByTrackingEntities$11(AbstractListProcessor.java:1126)
> at
> org.apache.nifi.processor.util.list.ListedEntityTracker.trackEntities(ListedEntityTracker.java:272)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.listByTrackingEntities(AbstractListProcessor.java:1124)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.onTrigger(AbstractListProcessor.java:529)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
>
[jira] [Updated] (NIFI-13175) Double scroll bar in dialogs on smaller screen
[ https://issues.apache.org/jira/browse/NIFI-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13175: --- Status: Patch Available (was: In Progress) > Double scroll bar in dialogs on smaller screen > -- > > Key: NIFI-13175 > URL: https://issues.apache.org/jira/browse/NIFI-13175 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Attachments: Screenshot 2024-05-07 at 4.21.07 PM.png > > Time Spent: 10m > Remaining Estimate: 0h > > For smaller screen sizes there is not enough vertical space to render the > dialog in it's entirety. As a result the user ends up seeing a double scroll > bar. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13175: Updating dialog layout and sizes to prevent a double scroll bar on smaller screen sizes [nifi]
mcgilman opened a new pull request, #8779: URL: https://github.com/apache/nifi/pull/8779 NIFI-13175: - Updating dialog layout and sizes to prevent a double scroll bar on smaller screen sizes. Now the dialog content is set to 50vh and content scrolls as needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2251 Make OPENSSL and CURL mandatory [nifi-minifi-cpp]
lordgamez commented on PR #1749: URL: https://github.com/apache/nifi-minifi-cpp/pull/1749#issuecomment-2101286514 > @szaszm I agree **MINIFI_OPENSSL** and **ENABLE_CURL** should now no longer be minifi_options, they must be enabled in order to successfully build libminifi. However, for the case of building libarchive, we can build libarchive with openssl enabled set to true or false. Did you make it mandatory for minifi extensions that use openssl? > > In my PR-1775 for MINIFICPP-2346: I do note about the critical minifi options that must be enabled to successfully build libminifi. I found that **ENABLE_OPENWSMAN, ENABLE_CIVET** must also be ON for libminifi to build succssfully. Those 4 minifi options are the minimum to build libminifi C++ core-minifi, mainexe and standard processors. > > * I also mention about the options that must be enabled to build GTESTs. Furthermore, I am wrapping up testing enabling all the remaining extension. @james94 how did you find the ENABLE_OPENWSMAN must be ON for libminifi build to succeed? I managed to build it successfully without it and it should be a separate extension that should not have any effect on the core libminifi. We also had some discussions in the past if civetweb should be part of the core libminifi, but we decided not to due to the following reasons: - It is not actually required by core libminifi, it is only needed for the tests and some of the extensions. If you build libminifi with SKIP_TESTS=ON and turn off civetweb extension the libminifi should build successfully - We had some concerns about the civetweb codebase so we may replace it in the future with a different library, so we would rather not include it in the core libminifi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13162) Align components
[ https://issues.apache.org/jira/browse/NIFI-13162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13162: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Align components > > > Key: NIFI-13162 > URL: https://issues.apache.org/jira/browse/NIFI-13162 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13162) Align components
[ https://issues.apache.org/jira/browse/NIFI-13162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844756#comment-17844756 ] ASF subversion and git services commented on NIFI-13162: Commit 6950290c247bfa81b6ea0458bc79246e6c7bb39f in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6950290c24 ] [NIFI-13162] horizontal and vertical canvas component alignment (#8762) * [NIFI-13162] horizontal and vertical canvas component alignment * review feedback * rename to updatePositionRequestId * use enum * use the appropriate generic type and separate components and connections updates * use enum This closes #8762 > Align components > > > Key: NIFI-13162 > URL: https://issues.apache.org/jira/browse/NIFI-13162 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13162] horizontal and vertical canvas component alignment [nifi]
mcgilman merged PR #8762: URL: https://github.com/apache/nifi/pull/8762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13181) Azure Blob and ADLS processors throw NoSuchMethodError when Service Principal is used
[
https://issues.apache.org/jira/browse/NIFI-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844753#comment-17844753
]
Peter Turcsanyi commented on NIFI-13181:
[~joewitt] No worries. I'm afraid there are no integration tests for Service
Principal authentication because it would require a specific setup on Azure.
> Azure Blob and ADLS processors throw NoSuchMethodError when Service Principal
> is used
> -
>
> Key: NIFI-13181
> URL: https://issues.apache.org/jira/browse/NIFI-13181
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.26.0
>Reporter: Zoltán Kornél Török
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I spent some time testing nifi 1.26 and found this error, when tried to use
> blobstorage related processors, like ListAzureBlobStorage_v12 .
> {code:java}
> 2024-05-08 09:09:06,416 WARN reactor.core.Exceptions: throwIfFatal detected a
> jvm fatal exception, which is thrown and logged below:
> java.lang.NoSuchMethodError:
> com.microsoft.aad.msal4j.ConfidentialClientApplication$Builder.logPii(Z)Lcom/microsoft/aad/msal4j/AbstractApplicationBase$Builder;
> at
> com.azure.identity.implementation.IdentityClientBase.getConfidentialClient(IdentityClientBase.java:233)
> at
> com.azure.identity.implementation.IdentityClient.lambda$getConfidentialClientApplication$4(IdentityClient.java:130)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:45)
> at
> reactor.core.publisher.MonoCacheTime.subscribeOrReturn(MonoCacheTime.java:143)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
> at reactor.core.publisher.MonoUsing.subscribe(MonoUsing.java:102)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at
> reactor.core.publisher.MonoFromFluxOperator.subscribe(MonoFromFluxOperator.java:81)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.subscribeNext(MonoIgnoreThen.java:263)
> at reactor.core.publisher.MonoIgnoreThen.subscribe(MonoIgnoreThen.java:51)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:203)
> at
> reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:203)
> at
> reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
> at reactor.core.publisher.Flux.subscribe(Flux.java:8628)
> at reactor.core.publisher.Flux.blockLast(Flux.java:2760)
> at
> com.azure.core.util.paging.ContinuablePagedByIteratorBase.requestPage(ContinuablePagedByIteratorBase.java:102)
> at
> com.azure.core.util.paging.ContinuablePagedByItemIterable$ContinuablePagedByItemIterator.(ContinuablePagedByItemIterable.java:75)
> at
> com.azure.core.util.paging.ContinuablePagedByItemIterable.iterator(ContinuablePagedByItemIterable.java:55)
> at
> com.azure.core.util.paging.ContinuablePagedIterable.iterator(ContinuablePagedIterable.java:141)
> at
> org.apache.nifi.processors.azure.storage.ListAzureBlobStorage_v12.performListing(ListAzureBlobStorage_v12.java:230)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.lambda$listByTrackingEntities$11(AbstractListProcessor.java:1126)
> at
> org.apache.nifi.processor.util.list.ListedEntityTracker.trackEntities(ListedEntityTracker.java:272)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.listByTrackingEntities(AbstractListProcessor.java:1124)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.onTrigger(AbstractListProcessor.java:529)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1361)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:247)
> at
>
[jira] [Commented] (NIFI-13181) Azure Blob and ADLS processors throw NoSuchMethodError when Service Principal is used
[
https://issues.apache.org/jira/browse/NIFI-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844747#comment-17844747
]
Joe Witt commented on NIFI-13181:
-
[~turcsanyip]Sorry for the trouble. I will take a look. Do the integration
tests not expose this by chance? Or maybe they get skipped by the
integration-tests-ci mode. i'll look
> Azure Blob and ADLS processors throw NoSuchMethodError when Service Principal
> is used
> -
>
> Key: NIFI-13181
> URL: https://issues.apache.org/jira/browse/NIFI-13181
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.26.0
>Reporter: Zoltán Kornél Török
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I spent some time testing nifi 1.26 and found this error, when tried to use
> blobstorage related processors, like ListAzureBlobStorage_v12 .
> {code:java}
> 2024-05-08 09:09:06,416 WARN reactor.core.Exceptions: throwIfFatal detected a
> jvm fatal exception, which is thrown and logged below:
> java.lang.NoSuchMethodError:
> com.microsoft.aad.msal4j.ConfidentialClientApplication$Builder.logPii(Z)Lcom/microsoft/aad/msal4j/AbstractApplicationBase$Builder;
> at
> com.azure.identity.implementation.IdentityClientBase.getConfidentialClient(IdentityClientBase.java:233)
> at
> com.azure.identity.implementation.IdentityClient.lambda$getConfidentialClientApplication$4(IdentityClient.java:130)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:45)
> at
> reactor.core.publisher.MonoCacheTime.subscribeOrReturn(MonoCacheTime.java:143)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
> at reactor.core.publisher.MonoUsing.subscribe(MonoUsing.java:102)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at
> reactor.core.publisher.MonoFromFluxOperator.subscribe(MonoFromFluxOperator.java:81)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.MonoIgnoreThen$ThenIgnoreMain.subscribeNext(MonoIgnoreThen.java:263)
> at reactor.core.publisher.MonoIgnoreThen.subscribe(MonoIgnoreThen.java:51)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:64)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:203)
> at
> reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
> at
> reactor.core.publisher.InternalMonoOperator.subscribe(InternalMonoOperator.java:57)
> at reactor.core.publisher.MonoDefer.subscribe(MonoDefer.java:53)
> at reactor.core.publisher.Mono.subscribe(Mono.java:4491)
> at
> reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:203)
> at
> reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
> at reactor.core.publisher.Flux.subscribe(Flux.java:8628)
> at reactor.core.publisher.Flux.blockLast(Flux.java:2760)
> at
> com.azure.core.util.paging.ContinuablePagedByIteratorBase.requestPage(ContinuablePagedByIteratorBase.java:102)
> at
> com.azure.core.util.paging.ContinuablePagedByItemIterable$ContinuablePagedByItemIterator.(ContinuablePagedByItemIterable.java:75)
> at
> com.azure.core.util.paging.ContinuablePagedByItemIterable.iterator(ContinuablePagedByItemIterable.java:55)
> at
> com.azure.core.util.paging.ContinuablePagedIterable.iterator(ContinuablePagedIterable.java:141)
> at
> org.apache.nifi.processors.azure.storage.ListAzureBlobStorage_v12.performListing(ListAzureBlobStorage_v12.java:230)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.lambda$listByTrackingEntities$11(AbstractListProcessor.java:1126)
> at
> org.apache.nifi.processor.util.list.ListedEntityTracker.trackEntities(ListedEntityTracker.java:272)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.listByTrackingEntities(AbstractListProcessor.java:1124)
> at
> org.apache.nifi.processor.util.list.AbstractListProcessor.onTrigger(AbstractListProcessor.java:529)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1361)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:247)
> at
>
Re: [PR] MINIFICPP-2251 Make OPENSSL and CURL mandatory [nifi-minifi-cpp]
james94 commented on PR #1749: URL: https://github.com/apache/nifi-minifi-cpp/pull/1749#issuecomment-2101187740 @szaszm I agree **MINIFI_OPENSSL** and **ENABLE_CURL** should now no longer be minifi_options, they must be enabled in order to successfully build libminifi. However, for the case of building libarchive, we can build libarchive with openssl enabled set to true or false. Did you make it mandatory for minifi extensions that use openssl? In my PR-1775 for MINIFICPP-2346: I do note about the critical minifi options that must be enabled to successfully build libminifi. I found that **ENABLE_OPENWSMAN, ENABLE_CIVET** must also be ON for libminifi to build succssfully. Those 4 minifi options are the minimum to build libminifi C++ core-minifi, mainexe and standard processors. - I also mention about the options that must be enabled to build GTESTs. Furthermore, I am wrapping up testing enabling all the remaining extension. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13165) [BUG] Status history resize handle show when insufficient history
[ https://issues.apache.org/jira/browse/NIFI-13165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13165: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > [BUG] Status history resize handle show when insufficient history > - > > Key: NIFI-13165 > URL: https://issues.apache.org/jira/browse/NIFI-13165 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Attachments: Screenshot 2024-05-07 at 11.52.15 AM.png > > Time Spent: 1h > Remaining Estimate: 0h > > !Screenshot 2024-05-07 at 11.52.15 AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13165) [BUG] Status history resize handle show when insufficient history
[ https://issues.apache.org/jira/browse/NIFI-13165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844739#comment-17844739 ] ASF subversion and git services commented on NIFI-13165: Commit fc8f072e0a87c5fc627050f39089c58c4e9b11b2 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=fc8f072e0a ] [NIFI-13165] hide resize handle is status history when insufficient h… (#8768) * [NIFI-13165] hide resize handle is status history when insufficient history * hide last updated/refresh button when insufficient history * Update nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/status-history/status-history.component.html Co-authored-by: Rob Fellows - Co-authored-by: Rob Fellows This closes #8768 > [BUG] Status history resize handle show when insufficient history > - > > Key: NIFI-13165 > URL: https://issues.apache.org/jira/browse/NIFI-13165 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-07 at 11.52.15 AM.png > > Time Spent: 1h > Remaining Estimate: 0h > > !Screenshot 2024-05-07 at 11.52.15 AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13165] hide resize handle is status history when insufficient h… [nifi]
rfellows merged PR #8768: URL: https://github.com/apache/nifi/pull/8768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13183) Connections are difficult to see when displayed on top of a label in dark mode
[ https://issues.apache.org/jira/browse/NIFI-13183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13183: --- Status: Patch Available (was: In Progress) > Connections are difficult to see when displayed on top of a label in dark mode > -- > > Key: NIFI-13183 > URL: https://issues.apache.org/jira/browse/NIFI-13183 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-08 at 1.38.31 PM.png > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-13180) Content viewer does not display "json-lines" completely when view-as is set to formatted
[ https://issues.apache.org/jira/browse/NIFI-13180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844731#comment-17844731 ] Daniel Stieglitz edited comment on NIFI-13180 at 5/8/24 6:06 PM: - [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default, Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782]) hence it would make sense then why you are only seeing the first document. Also as an aside, I am not sure what formatted multiline JSON should look like as each line is a separate document. If you format them without making them as part of an array it will not be legal JSON. was (Author: JIRAUSER294662): [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782]) hence it would make sense then why you are only seeing the first document. Also as an aside, I am not sure what formatted multiline JSON should look like as each line is a separate document. If you format them without making them as part of an array it will not be legal JSON. > Content viewer does not display "json-lines" completely when view-as is set > to formatted > > > Key: NIFI-13180 > URL: https://issues.apache.org/jira/browse/NIFI-13180 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Andrew M. Lim >Priority: Minor > Attachments: PDF-test.pdf, image-2024-05-07-19-06-19-292.png, > screenshot-1.png > > > ParseDocument is a Python processor whose output is formatted as > "json-lines". When looking at the FlowFile contents in the content viewer > with view-as set to "original", multiple lines are displayed as expected: > !image-2024-05-07-19-06-19-292.png! > But, if view-as is set to "formatted", only one line is shown: > !screenshot-1.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-13180) Content viewer does not display "json-lines" completely when view-as is set to formatted
[ https://issues.apache.org/jira/browse/NIFI-13180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844731#comment-17844731 ] Daniel Stieglitz edited comment on NIFI-13180 at 5/8/24 6:06 PM: - [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782]) hence it would make sense then why you are only seeing the first document. Also as an aside, I am not sure what formatted multiline JSON should look like as each line is a separate document. If you format them without making them as part of an array it will not be legal JSON. was (Author: JIRAUSER294662): [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782]) Also as an aside, I am not sure what formatted multiline JSON should look like as each line is a separate document. If you format them without making them as part of an array it will not be legal JSON. > Content viewer does not display "json-lines" completely when view-as is set > to formatted > > > Key: NIFI-13180 > URL: https://issues.apache.org/jira/browse/NIFI-13180 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Andrew M. Lim >Priority: Minor > Attachments: PDF-test.pdf, image-2024-05-07-19-06-19-292.png, > screenshot-1.png > > > ParseDocument is a Python processor whose output is formatted as > "json-lines". When looking at the FlowFile contents in the content viewer > with view-as set to "original", multiple lines are displayed as expected: > !image-2024-05-07-19-06-19-292.png! > But, if view-as is set to "formatted", only one line is shown: > !screenshot-1.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-13180) Content viewer does not display "json-lines" completely when view-as is set to formatted
[ https://issues.apache.org/jira/browse/NIFI-13180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844731#comment-17844731 ] Daniel Stieglitz edited comment on NIFI-13180 at 5/8/24 6:05 PM: - [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782]) Also as an aside, I am not sure what formatted multiline JSON should look like as each line is a separate document. If you format them without making them as part of an array it will not be legal JSON. was (Author: JIRAUSER294662): [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782]) Also as an aside, I am not sure what formatted multiline JSON should look like as each line its own document. If you format them without making them as part of an array it will not be legal JSON. > Content viewer does not display "json-lines" completely when view-as is set > to formatted > > > Key: NIFI-13180 > URL: https://issues.apache.org/jira/browse/NIFI-13180 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Andrew M. Lim >Priority: Minor > Attachments: PDF-test.pdf, image-2024-05-07-19-06-19-292.png, > screenshot-1.png > > > ParseDocument is a Python processor whose output is formatted as > "json-lines". When looking at the FlowFile contents in the content viewer > with view-as set to "original", multiple lines are displayed as expected: > !image-2024-05-07-19-06-19-292.png! > But, if view-as is set to "formatted", only one line is shown: > !screenshot-1.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13183] add drop shadow to connections to increase visibility on… [nifi]
scottyaslan opened a new pull request, #8778: URL: https://github.com/apache/nifi/pull/8778 … top of colored labels in both light and dark mode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (NIFI-13180) Content viewer does not display "json-lines" completely when view-as is set to formatted
[ https://issues.apache.org/jira/browse/NIFI-13180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844731#comment-17844731 ] Daniel Stieglitz edited comment on NIFI-13180 at 5/8/24 6:04 PM: - [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782] Also as aside, I am not sure what formatted multiline JSON should look like as each line its own document. If you format them without making them as part of an array it will not be legal JSON. was (Author: JIRAUSER294662): [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782] > Content viewer does not display "json-lines" completely when view-as is set > to formatted > > > Key: NIFI-13180 > URL: https://issues.apache.org/jira/browse/NIFI-13180 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Andrew M. Lim >Priority: Minor > Attachments: PDF-test.pdf, image-2024-05-07-19-06-19-292.png, > screenshot-1.png > > > ParseDocument is a Python processor whose output is formatted as > "json-lines". When looking at the FlowFile contents in the content viewer > with view-as set to "original", multiple lines are displayed as expected: > !image-2024-05-07-19-06-19-292.png! > But, if view-as is set to "formatted", only one line is shown: > !screenshot-1.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-13180) Content viewer does not display "json-lines" completely when view-as is set to formatted
[ https://issues.apache.org/jira/browse/NIFI-13180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844731#comment-17844731 ] Daniel Stieglitz edited comment on NIFI-13180 at 5/8/24 6:04 PM: - [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782]) Also as an aside, I am not sure what formatted multiline JSON should look like as each line its own document. If you format them without making them as part of an array it will not be legal JSON. was (Author: JIRAUSER294662): [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782]) Also as aside, I am not sure what formatted multiline JSON should look like as each line its own document. If you format them without making them as part of an array it will not be legal JSON. > Content viewer does not display "json-lines" completely when view-as is set > to formatted > > > Key: NIFI-13180 > URL: https://issues.apache.org/jira/browse/NIFI-13180 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Andrew M. Lim >Priority: Minor > Attachments: PDF-test.pdf, image-2024-05-07-19-06-19-292.png, > screenshot-1.png > > > ParseDocument is a Python processor whose output is formatted as > "json-lines". When looking at the FlowFile contents in the content viewer > with view-as set to "original", multiple lines are displayed as expected: > !image-2024-05-07-19-06-19-292.png! > But, if view-as is set to "formatted", only one line is shown: > !screenshot-1.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-13180) Content viewer does not display "json-lines" completely when view-as is set to formatted
[ https://issues.apache.org/jira/browse/NIFI-13180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844731#comment-17844731 ] Daniel Stieglitz edited comment on NIFI-13180 at 5/8/24 6:04 PM: - [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782]) Also as aside, I am not sure what formatted multiline JSON should look like as each line its own document. If you format them without making them as part of an array it will not be legal JSON. was (Author: JIRAUSER294662): [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782] Also as aside, I am not sure what formatted multiline JSON should look like as each line its own document. If you format them without making them as part of an array it will not be legal JSON. > Content viewer does not display "json-lines" completely when view-as is set > to formatted > > > Key: NIFI-13180 > URL: https://issues.apache.org/jira/browse/NIFI-13180 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Andrew M. Lim >Priority: Minor > Attachments: PDF-test.pdf, image-2024-05-07-19-06-19-292.png, > screenshot-1.png > > > ParseDocument is a Python processor whose output is formatted as > "json-lines". When looking at the FlowFile contents in the content viewer > with view-as set to "original", multiple lines are displayed as expected: > !image-2024-05-07-19-06-19-292.png! > But, if view-as is set to "formatted", only one line is shown: > !screenshot-1.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13180) Content viewer does not display "json-lines" completely when view-as is set to formatted
[ https://issues.apache.org/jira/browse/NIFI-13180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844731#comment-17844731 ] Daniel Stieglitz commented on NIFI-13180: - [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782] > Content viewer does not display "json-lines" completely when view-as is set > to formatted > > > Key: NIFI-13180 > URL: https://issues.apache.org/jira/browse/NIFI-13180 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Andrew M. Lim >Priority: Minor > Attachments: PDF-test.pdf, image-2024-05-07-19-06-19-292.png, > screenshot-1.png > > > ParseDocument is a Python processor whose output is formatted as > "json-lines". When looking at the FlowFile contents in the content viewer > with view-as set to "original", multiple lines are displayed as expected: > !image-2024-05-07-19-06-19-292.png! > But, if view-as is set to "formatted", only one line is shown: > !screenshot-1.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-13180) Content viewer does not display "json-lines" completely when view-as is set to formatted
[ https://issues.apache.org/jira/browse/NIFI-13180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844731#comment-17844731 ] Daniel Stieglitz edited comment on NIFI-13180 at 5/8/24 6:00 PM: - [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782] was (Author: JIRAUSER294662): [~andrewmlim] I had a similar issue with NIFI-12116 where I had discovered by default Jackson's ObjectMapper only parses the first object from multiline JSON (see discussion on the related PR [#7782|https://github.com/apache/nifi/pull/7782] > Content viewer does not display "json-lines" completely when view-as is set > to formatted > > > Key: NIFI-13180 > URL: https://issues.apache.org/jira/browse/NIFI-13180 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Andrew M. Lim >Priority: Minor > Attachments: PDF-test.pdf, image-2024-05-07-19-06-19-292.png, > screenshot-1.png > > > ParseDocument is a Python processor whose output is formatted as > "json-lines". When looking at the FlowFile contents in the content viewer > with view-as set to "original", multiple lines are displayed as expected: > !image-2024-05-07-19-06-19-292.png! > But, if view-as is set to "formatted", only one line is shown: > !screenshot-1.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13061] replace actions with menu [nifi]
rfellows commented on code in PR #8766:
URL: https://github.com/apache/nifi/pull/8766#discussion_r1594348911
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/users/ui/user-listing/user-table/user-table.component.html:
##
@@ -79,24 +79,37 @@
-@if (canEditOrDelete(currentUser, item)) {
-
-}
-@if (canEditOrDelete(currentUser, item)) {
-
-}
-@if (hasAccessPolicies(item)) {
-
+@if (
+canEditOrDelete(currentUser, item) ||
hasAccessPolicies(item) || hasAccessPolicies(item)
+) {
+
+
+
}
+
+@if (canEditOrDelete(currentUser, item)) {
+
+
+Edit
+
+}
+@if (canEditOrDelete(currentUser, item)) {
+
+
+Remove
+
+}
+@if (hasAccessPolicies(item)) {
+
+
+Manage Access Policies
Review Comment:
This might not be the correct phrase. It doesn't open the policies page like
the other ones do. it opens a dialog with the user policies. It might be best
to leave this one as `Manage User Policies` to draw a distinction.
https://github.com/apache/nifi/assets/713866/4543448d-1e50-47bf-ba8e-a8dfab5cf89a;>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13183) Connections are difficult to see when displayed on top of a label in dark mode
Scott Aslan created NIFI-13183: -- Summary: Connections are difficult to see when displayed on top of a label in dark mode Key: NIFI-13183 URL: https://issues.apache.org/jira/browse/NIFI-13183 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Assignee: Scott Aslan Attachments: Screenshot 2024-05-08 at 1.38.31 PM.png -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13177) Typography-related issues
[ https://issues.apache.org/jira/browse/NIFI-13177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13177: --- Attachment: Screenshot 2024-05-08 at 1.35.53 PM.png > Typography-related issues > - > > Key: NIFI-13177 > URL: https://issues.apache.org/jira/browse/NIFI-13177 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-05-07 at 4.30.14 PM.png, Screenshot > 2024-05-07 at 4.30.52 PM.png, Screenshot 2024-05-08 at 1.35.07 PM.png, > Screenshot 2024-05-08 at 1.35.53 PM.png, image-2024-05-07-16-32-17-165.png, > image-2024-05-07-16-32-35-782.png > > > Noticed a few things that we should clean up post theming typography. > > 1. Font inconsistent size in table footer area (last refreshed and paginator): > > !image-2024-05-07-16-32-35-782.png|width=815,height=41! > 2. Rendering of component type, name, and icon looks like it should be spaced > out a bit more > > !image-2024-05-07-16-32-17-165.png|width=605,height=124! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13177) Typography-related issues
[ https://issues.apache.org/jira/browse/NIFI-13177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13177: --- Description: Noticed a few things that we should clean up post theming typography. 1. Font inconsistent size in table footer area (last refreshed and paginator): !image-2024-05-07-16-32-35-782.png|width=815,height=41! 2. Rendering of component type, name, and icon looks like it should be spaced out a bit more !image-2024-05-07-16-32-17-165.png|width=605,height=124! !Screenshot 2024-05-08 at 1.35.07 PM.png|width=202,height=131! vs !Screenshot 2024-05-08 at 1.35.53 PM.png|width=287,height=140! for the same component in different areas of the app was: Noticed a few things that we should clean up post theming typography. 1. Font inconsistent size in table footer area (last refreshed and paginator): !image-2024-05-07-16-32-35-782.png|width=815,height=41! 2. Rendering of component type, name, and icon looks like it should be spaced out a bit more !image-2024-05-07-16-32-17-165.png|width=605,height=124! > Typography-related issues > - > > Key: NIFI-13177 > URL: https://issues.apache.org/jira/browse/NIFI-13177 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-05-07 at 4.30.14 PM.png, Screenshot > 2024-05-07 at 4.30.52 PM.png, Screenshot 2024-05-08 at 1.35.07 PM.png, > Screenshot 2024-05-08 at 1.35.53 PM.png, image-2024-05-07-16-32-17-165.png, > image-2024-05-07-16-32-35-782.png > > > Noticed a few things that we should clean up post theming typography. > > 1. Font inconsistent size in table footer area (last refreshed and paginator): > > !image-2024-05-07-16-32-35-782.png|width=815,height=41! > 2. Rendering of component type, name, and icon looks like it should be spaced > out a bit more > > !image-2024-05-07-16-32-17-165.png|width=605,height=124! > !Screenshot 2024-05-08 at 1.35.07 PM.png|width=202,height=131! vs > !Screenshot 2024-05-08 at 1.35.53 PM.png|width=287,height=140! for the same > component in different areas of the app -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13177) Typography-related issues
[ https://issues.apache.org/jira/browse/NIFI-13177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13177: --- Description: Noticed a few things that we should clean up post theming typography. 1. Font inconsistent size in table footer area (last refreshed and paginator): !image-2024-05-07-16-32-35-782.png|width=815,height=41! 2. Rendering of component type, name, and icon looks like it should be spaced out a bit more !image-2024-05-07-16-32-17-165.png|width=605,height=124! was: Noticed a few things that we should clean up post theming typography. 1. Font inconsistent size in table footer area (last refreshed and paginator): !image-2024-05-07-16-32-35-782.png|width=815,height=41! 2. Rendering of component type, name, and icon looks like it should be spaced out a bit more !image-2024-05-07-16-32-17-165.png|width=605,height=124! > Typography-related issues > - > > Key: NIFI-13177 > URL: https://issues.apache.org/jira/browse/NIFI-13177 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-05-07 at 4.30.14 PM.png, Screenshot > 2024-05-07 at 4.30.52 PM.png, Screenshot 2024-05-08 at 1.35.07 PM.png, > image-2024-05-07-16-32-17-165.png, image-2024-05-07-16-32-35-782.png > > > Noticed a few things that we should clean up post theming typography. > > 1. Font inconsistent size in table footer area (last refreshed and paginator): > > !image-2024-05-07-16-32-35-782.png|width=815,height=41! > 2. Rendering of component type, name, and icon looks like it should be spaced > out a bit more > > !image-2024-05-07-16-32-17-165.png|width=605,height=124! > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13177) Typography-related issues
[ https://issues.apache.org/jira/browse/NIFI-13177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13177: --- Attachment: Screenshot 2024-05-08 at 1.35.07 PM.png > Typography-related issues > - > > Key: NIFI-13177 > URL: https://issues.apache.org/jira/browse/NIFI-13177 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-05-07 at 4.30.14 PM.png, Screenshot > 2024-05-07 at 4.30.52 PM.png, Screenshot 2024-05-08 at 1.35.07 PM.png, > image-2024-05-07-16-32-17-165.png, image-2024-05-07-16-32-35-782.png > > > Noticed a few things that we should clean up post theming typography. > > 1. Font inconsistent size in table footer area (last refreshed and paginator): > > !image-2024-05-07-16-32-35-782.png|width=815,height=41! > 2. Rendering of component type, name, and icon looks like it should be spaced > out a bit more > > !image-2024-05-07-16-32-17-165.png|width=605,height=124! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13165] hide resize handle is status history when insufficient h… [nifi]
rfellows commented on code in PR #8768:
URL: https://github.com/apache/nifi/pull/8768#discussion_r1594328556
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/status-history/status-history.component.html:
##
@@ -170,7 +170,7 @@ Status History
-@if (instances.length > 0) {
+@if (instances.length === 0 || fieldDescriptors.length
=== 0) {
Review Comment:
this is inverted. should be
```suggestion
@if (instances.length > 0 && fieldDescriptors.length
> 0) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13061] replace actions with menu [nifi]
scottyaslan commented on PR #8766: URL: https://github.com/apache/nifi/pull/8766#issuecomment-2100990315 > I found a number of instances where selecting a menu option doesn't close the menu and it is still visible behind the dialog that it opens. I commented inline in a number of places, but there are more. I just stopped as it was getting redundant. Yes, I see that this happens anytime we `event.stopPropagation();`. I have removed them as they are no longer necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13061] replace actions with menu [nifi]
scottyaslan commented on code in PR #8766:
URL: https://github.com/apache/nifi/pull/8766#discussion_r1594324132
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-context-table/parameter-context-table.component.html:
##
@@ -58,32 +58,52 @@
-@if (canRead(item)) {
-
-}
-@if (canDelete(item)) {
-
-}
-@if (canManageAccessPolicies()) {
-
-}
-@if (canGoToParameterProvider(item)) {
-
+@if (
+canRead(item) ||
+canDelete(item) ||
+canManageAccessPolicies() ||
+canGoToParameterProvider(item)
+) {
+
+
+
}
+
+@if (canRead(item)) {
+
+
+{{ canWrite(item) ? 'Edit' : 'View
Configuration' }}
+
Review Comment:
https://github.com/apache/nifi/pull/8766#discussion_r1594323472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13061] replace actions with menu [nifi]
scottyaslan commented on code in PR #8766:
URL: https://github.com/apache/nifi/pull/8766#discussion_r1594323808
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/users/ui/user-listing/user-table/user-table.component.html:
##
@@ -79,24 +79,37 @@
-@if (canEditOrDelete(currentUser, item)) {
-
-}
-@if (canEditOrDelete(currentUser, item)) {
-
-}
-@if (hasAccessPolicies(item)) {
-
+@if (
+canEditOrDelete(currentUser, item) ||
hasAccessPolicies(item) || hasAccessPolicies(item)
+) {
+
+
+
}
+
Review Comment:
https://github.com/apache/nifi/pull/8766#discussion_r1594323472
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/processor-status-listing/processor-status-table/processor-status-table.component.html:
##
@@ -248,25 +248,36 @@
-
+
+
+
+
Review Comment:
https://github.com/apache/nifi/pull/8766#discussion_r1594323472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13061] replace actions with menu [nifi]
scottyaslan commented on code in PR #8766:
URL: https://github.com/apache/nifi/pull/8766#discussion_r1594323472
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/controller-service-table/controller-service-table.component.html:
##
@@ -116,62 +116,73 @@
-@if (definedByCurrentGroup(item)) {
-
-
-@if (hasAdvancedUi(item)) {
-
+
+
+
+
+
+@if (definedByCurrentGroup(item)) {
+
+
+{{ canConfigure(item) ? 'Edit' : 'View
Configuration' }}
+
+@if (hasAdvancedUi(item)) {
+
+
+Advanced
+
+}
+@if (canDisable(item)) {
+
+
+Disable
+
+}
+@if (canEnable(item)) {
+
+
+Enable
+
+}
+@if (canChangeVersion(item)) {
+
+
+Change Version
+
+}
+@if (canDelete(item)) {
+
+
+Delete
Review Comment:
This happens anywhere we `event.stopPropagation();`. I think these were in
place to not cause selection to fire. I will remove them.
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/ui/reporting-tasks/reporting-task-table/reporting-task-table.component.html:
##
@@ -111,53 +111,64 @@
-
-@if (hasAdvancedUi(item)) {
-
-}
-@if (canStop(item)) {
-
-}
-@if (canStart(item)) {
-
-}
-@if (canChangeVersion(item)) {
-
-}
-@if (canDelete(item)) {
-
-}
-@if (canViewState(item)) {
-
-}
-@if (canManageAccessPolicies()) {
-
-}
+
+
+
+
+
+
+{{ canEdit(item) ? 'Edit' : 'View
Configuration' }}
Review Comment:
https://github.com/apache/nifi/pull/8766#discussion_r1594323472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13061] replace actions with menu [nifi]
scottyaslan commented on code in PR #8766:
URL: https://github.com/apache/nifi/pull/8766#discussion_r1594305968
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/processor-status-listing/processor-status-table/processor-status-table.component.html:
##
@@ -248,25 +248,36 @@
-
+
+
+
+
+
+
+Go to Processor in
+{{
item?.processorStatusSnapshot?.processGroupNamePath }}
+
+
+
+View Status History
Review Comment:
The "View Status History" seems to be correct. For the clustered details I
will update those menu options to "View Clustered Details" everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13061] replace actions with menu [nifi]
scottyaslan commented on code in PR #8766:
URL: https://github.com/apache/nifi/pull/8766#discussion_r1594284148
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/controller-service-table/controller-service-table.component.html:
##
@@ -116,62 +116,73 @@
-@if (definedByCurrentGroup(item)) {
-
-
-@if (hasAdvancedUi(item)) {
-
+
+
+
+
+
+@if (definedByCurrentGroup(item)) {
+
+
+{{ canConfigure(item) ? 'Edit' : 'View
Configuration' }}
+
+@if (hasAdvancedUi(item)) {
+
+
+Advanced
+
+}
+@if (canDisable(item)) {
+
+
+Disable
+
+}
+@if (canEnable(item)) {
+
+
+Enable
+
+}
+@if (canChangeVersion(item)) {
+
+
+Change Version
+
+}
+@if (canDelete(item)) {
+
+
+Delete
+
+}
+@if (canViewState(item)) {
+
+
+View State
+
+}
+@if (canManageAccessPolicies()) {
+
+
+Manage Access Policies
Review Comment:
I will update all to "Manage Access Policies"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13165] hide resize handle is status history when insufficient h… [nifi]
scottyaslan commented on code in PR #8768: URL: https://github.com/apache/nifi/pull/8768#discussion_r1594275146 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/status-history/status-history.component.html: ## @@ -14,7 +14,13 @@ ~ See the License for the specific language governing permissions and ~ limitations under the License. --> - + Review Comment: Sure, I can hide it in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2364 - Add plist file to the package [nifi-minifi-cpp]
szaszm commented on PR #1782: URL: https://github.com/apache/nifi-minifi-cpp/pull/1782#issuecomment-2100905602 Currently it looks like it's installed on Linux as well, do we really need it there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13162] horizontal and vertical canvas component alignment [nifi]
scottyaslan commented on PR #8762: URL: https://github.com/apache/nifi/pull/8762#issuecomment-2100902317 > Also, what are your thoughts on updating this to also include connections (even if they aren't selected) if both the source and destination are selected? It seems like this would be helpful, but I might be overlooking a scenario. Happy to discuss this further. I simply copied most of this code over from legacy nifi and maintained the UX from there. I think it makes sense as is. If the user wants to align the connection they should included it in the selection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13162] horizontal and vertical canvas component alignment [nifi]
scottyaslan commented on code in PR #8762:
URL: https://github.com/apache/nifi/pull/8762#discussion_r1594267390
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-context-menu.service.ts:
##
@@ -321,24 +326,193 @@ export class CanvasContextMenu implements
ContextMenuDefinitionProvider {
menuItems: [
{
condition: (selection: any) => {
-// TODO - canAlign
-return false;
+return this.canvasUtils.canAlign(selection);
},
clazz: 'fa fa-align-center fa-rotate-90',
text: 'Horizontally',
-action: () => {
-// TODO - alignHorizontal
+action: (selection: any) => {
+const updates = new Map();
+
+// determine the extent
+let minY: number = 0,
+maxY: number = 0;
+selection.each((d: any) => {
+if (d.type !== 'Connection') {
+if (minY === 0 || d.position.y < minY) {
+minY = d.position.y;
+}
+const componentMaxY = d.position.y +
d.dimensions.height;
+if (maxY === 0 || componentMaxY > maxY) {
+maxY = componentMaxY;
+}
+}
+});
+
+const center = (minY + maxY) / 2;
+
+// align all components with top most component
+selection.each((d: any) => {
+if (d.type !== 'Connection') {
+const delta = {
+x: 0,
+y: center - (d.position.y +
d.dimensions.height / 2)
+};
+
+// if this component is already centered, no need
to updated it
+if (delta.y !== 0) {
+// consider any connections
+const connections =
this.canvasUtils.getComponentConnections(d.id);
+
+connections.forEach((connection: any) => {
+const connectionSelection =
d3.select('#id-' + connection.id);
+
+if (
+!updates.has(connection.id) &&
+
this.canvasUtils.getConnectionSourceComponentId(connection) ===
+
this.canvasUtils.getConnectionDestinationComponentId(connection)
+) {
+// this connection is self looping and
hasn't been updated by the delta yet
+const connectionUpdate =
this.draggableBehavior.updateConnectionPosition(
+connectionSelection.datum(),
+delta
+);
+if (connectionUpdate !== null) {
+updates.set(connection.id,
connectionUpdate);
+}
+} else if (
+!updates.has(connection.id) &&
+
connectionSelection.classed('selected') &&
+
this.canvasUtils.canModify(connectionSelection)
+) {
+// this is a selected connection that
hasn't been updated by the delta yet
+if (
+
this.canvasUtils.getConnectionSourceComponentId(connection) === d.id ||
+
!this.canvasUtils.isSourceSelected(connection, selection)
+) {
+// the connection is either
outgoing or incoming when the source of the connection is not part of the
selection
Review Comment:
Happy to revisit this UX but from legacy nifi if the user has a connection
selected it is aligned. If not, it is not:
Except for self looping connections. Those are treated differently since
they move with a component when it is moved so they are also moved in the align
use case as well:
![Kapture 2024-05-08 at 11 54
Re: [PR] [NIFI-13117] update label resize handle to match other resize handles… [nifi]
rfellows merged PR #8774: URL: https://github.com/apache/nifi/pull/8774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13117) Update resize handle
[ https://issues.apache.org/jira/browse/NIFI-13117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13117: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Update resize handle > > > Key: NIFI-13117 > URL: https://issues.apache.org/jira/browse/NIFI-13117 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 10m > Remaining Estimate: 0h > > The current resize handle shown on the editor and diagnostic modal too > closely resembles the comment indicator shown on the canvas. We should > consider some alternatives for resize handle to maybe more closely resemble > the textarea resize handle. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13117) Update resize handle
[ https://issues.apache.org/jira/browse/NIFI-13117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844705#comment-17844705 ] ASF subversion and git services commented on NIFI-13117: Commit 43aca6597ecbccc481296520b6636ba23ab0a280 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=43aca6597e ] [NIFI-13117] update label resize handle to match other resize handles and replace comments indicator with icon (#8774) This closes #8774 > Update resize handle > > > Key: NIFI-13117 > URL: https://issues.apache.org/jira/browse/NIFI-13117 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The current resize handle shown on the editor and diagnostic modal too > closely resembles the comment indicator shown on the canvas. We should > consider some alternatives for resize handle to maybe more closely resemble > the textarea resize handle. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13105 Implement a FlowRegistryClient that use GitHub for version… [nifi]
bbende commented on code in PR #8765:
URL: https://github.com/apache/nifi/pull/8765#discussion_r1594262547
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -0,0 +1,633 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.nifi.github;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.MapperFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import com.fasterxml.jackson.databind.json.JsonMapper;
+import com.fasterxml.jackson.databind.type.TypeFactory;
+import
com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flow.ConnectableComponent;
+import org.apache.nifi.flow.Position;
+import org.apache.nifi.flow.VersionedComponent;
+import org.apache.nifi.flow.VersionedConnection;
+import org.apache.nifi.flow.VersionedFlowCoordinates;
+import org.apache.nifi.flow.VersionedProcessGroup;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.registry.flow.AbstractFlowRegistryClient;
+import org.apache.nifi.registry.flow.BucketLocation;
+import org.apache.nifi.registry.flow.FlowLocation;
+import org.apache.nifi.registry.flow.FlowRegistryBranch;
+import org.apache.nifi.registry.flow.FlowRegistryBucket;
+import org.apache.nifi.registry.flow.FlowRegistryClientConfigurationContext;
+import org.apache.nifi.registry.flow.FlowRegistryException;
+import org.apache.nifi.registry.flow.FlowRegistryPermissions;
+import org.apache.nifi.registry.flow.FlowVersionLocation;
+import org.apache.nifi.registry.flow.RegisterAction;
+import org.apache.nifi.registry.flow.RegisteredFlow;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshot;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshotMetadata;
+import org.kohsuke.github.GHCommit;
+import org.kohsuke.github.GHContent;
+import org.kohsuke.github.GHContentUpdateResponse;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.stream.Collectors;
+
+/**
+ * Implementation of {@link org.apache.nifi.registry.flow.FlowRegistryClient}
that uses GitHub for version controlling flows.
+ */
+public class GitHubFlowRegistryClient extends AbstractFlowRegistryClient {
+
+static final PropertyDescriptor GITHUB_API_URL = new
PropertyDescriptor.Builder()
+.name("GitHub API URL")
+.description("The URL of the GitHub API")
+.addValidator(StandardValidators.URL_VALIDATOR)
+.defaultValue("https://api.github.com/;)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_NAME = new
PropertyDescriptor.Builder()
+.name("Repository Name")
+.description("The name of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_OWNER = new
PropertyDescriptor.Builder()
+.name("Repository Owner")
+.description("The owner of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_BRANCH = new
PropertyDescriptor.Builder()
+.name("Default Branch")
+.description("The default branch to use for this client")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.defaultValue("main")
+.required(true)
+
[PR] MINIFICPP-2366 various OSSP-uuid fixes [nifi-minifi-cpp]
szaszm opened a new pull request, #1784: URL: https://github.com/apache/nifi-minifi-cpp/pull/1784 - inverted debug flag: The ossp-uuid lib was built in debug in non-debug minifi builds, and in release mode in debug minifi builds - pass along isysroot to the autotools build on Mac OS: On my Mac, the isysroot flag needed to be passed to autotools, it didn't autodetect it from the SDKROOT env var. - separate patch and configure to different steps Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2366) Various OSSP-UUID fixes
Marton Szasz created MINIFICPP-2366: --- Summary: Various OSSP-UUID fixes Key: MINIFICPP-2366 URL: https://issues.apache.org/jira/browse/MINIFICPP-2366 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Marton Szasz - inverted debug flag - pass along isysroot to the autotools build on Mac OS - separate patch and configure to different steps -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13158) Support keyboard shortcuts on the canvas
[ https://issues.apache.org/jira/browse/NIFI-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13158: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Support keyboard shortcuts on the canvas > > > Key: NIFI-13158 > URL: https://issues.apache.org/jira/browse/NIFI-13158 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > CTRL+R -> reload canvas > CTRL+A -> select all > CTRL+C -> copy > CTRL+V -> paste > Backspace/Delete -> delete > ESC -> leave group -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13158] support for keyboard shortcuts for canvas actions [nifi]
scottyaslan merged PR #8770: URL: https://github.com/apache/nifi/pull/8770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13158) Support keyboard shortcuts on the canvas
[ https://issues.apache.org/jira/browse/NIFI-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844699#comment-17844699 ] ASF subversion and git services commented on NIFI-13158: Commit 0f394282091607e1c30bbf00baf1b5086aa2e89b in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0f39428209 ] [NIFI-13158] support for keyboard shortcuts (#8770) * removed aliasing of 'this' from canvas.component.ts * removed aliasing of 'this' from canvas-utils.ts * reuse common actions between operation and context menu This closes #8770 > Support keyboard shortcuts on the canvas > > > Key: NIFI-13158 > URL: https://issues.apache.org/jira/browse/NIFI-13158 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > CTRL+R -> reload canvas > CTRL+A -> select all > CTRL+C -> copy > CTRL+V -> paste > Backspace/Delete -> delete > ESC -> leave group -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13105 Implement a FlowRegistryClient that use GitHub for version… [nifi]
bbende commented on code in PR #8765:
URL: https://github.com/apache/nifi/pull/8765#discussion_r1594235055
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -0,0 +1,633 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.nifi.github;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.MapperFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import com.fasterxml.jackson.databind.json.JsonMapper;
+import com.fasterxml.jackson.databind.type.TypeFactory;
+import
com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flow.ConnectableComponent;
+import org.apache.nifi.flow.Position;
+import org.apache.nifi.flow.VersionedComponent;
+import org.apache.nifi.flow.VersionedConnection;
+import org.apache.nifi.flow.VersionedFlowCoordinates;
+import org.apache.nifi.flow.VersionedProcessGroup;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.registry.flow.AbstractFlowRegistryClient;
+import org.apache.nifi.registry.flow.BucketLocation;
+import org.apache.nifi.registry.flow.FlowLocation;
+import org.apache.nifi.registry.flow.FlowRegistryBranch;
+import org.apache.nifi.registry.flow.FlowRegistryBucket;
+import org.apache.nifi.registry.flow.FlowRegistryClientConfigurationContext;
+import org.apache.nifi.registry.flow.FlowRegistryException;
+import org.apache.nifi.registry.flow.FlowRegistryPermissions;
+import org.apache.nifi.registry.flow.FlowVersionLocation;
+import org.apache.nifi.registry.flow.RegisterAction;
+import org.apache.nifi.registry.flow.RegisteredFlow;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshot;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshotMetadata;
+import org.kohsuke.github.GHCommit;
+import org.kohsuke.github.GHContent;
+import org.kohsuke.github.GHContentUpdateResponse;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.stream.Collectors;
+
+/**
+ * Implementation of {@link org.apache.nifi.registry.flow.FlowRegistryClient}
that uses GitHub for version controlling flows.
+ */
+public class GitHubFlowRegistryClient extends AbstractFlowRegistryClient {
+
+static final PropertyDescriptor GITHUB_API_URL = new
PropertyDescriptor.Builder()
+.name("GitHub API URL")
+.description("The URL of the GitHub API")
+.addValidator(StandardValidators.URL_VALIDATOR)
+.defaultValue("https://api.github.com/;)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_NAME = new
PropertyDescriptor.Builder()
+.name("Repository Name")
+.description("The name of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_OWNER = new
PropertyDescriptor.Builder()
+.name("Repository Owner")
+.description("The owner of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_BRANCH = new
PropertyDescriptor.Builder()
+.name("Default Branch")
+.description("The default branch to use for this client")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.defaultValue("main")
+.required(true)
+
Re: [PR] [NIFI-13162] horizontal and vertical canvas component alignment [nifi]
mcgilman commented on code in PR #8762:
URL: https://github.com/apache/nifi/pull/8762#discussion_r1594086173
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-utils.service.ts:
##
@@ -231,6 +231,33 @@ export class CanvasUtils {
return this.isNotRootGroup() && selection.empty();
}
+/**
+ * Determines if the specified selection is alignable (in a single action).
+ *
+ * @param {selection} selection The selection
+ * @returns {boolean}
+ */
+public canAlign(selection: any) {
+let canAlign = true;
+
+// determine if the current selection is entirely connections
+const selectedConnections = selection.filter((d: any) => {
+return d.type == 'Connection';
Review Comment:
Can we use `ComponentType.Connection` here?
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-context-menu.service.ts:
##
@@ -321,24 +326,193 @@ export class CanvasContextMenu implements
ContextMenuDefinitionProvider {
menuItems: [
{
condition: (selection: any) => {
-// TODO - canAlign
-return false;
+return this.canvasUtils.canAlign(selection);
},
clazz: 'fa fa-align-center fa-rotate-90',
text: 'Horizontally',
-action: () => {
-// TODO - alignHorizontal
+action: (selection: any) => {
+const updates = new Map();
+
+// determine the extent
+let minY: number = 0,
+maxY: number = 0;
+selection.each((d: any) => {
+if (d.type !== 'Connection') {
+if (minY === 0 || d.position.y < minY) {
+minY = d.position.y;
+}
+const componentMaxY = d.position.y +
d.dimensions.height;
+if (maxY === 0 || componentMaxY > maxY) {
+maxY = componentMaxY;
+}
+}
+});
+
+const center = (minY + maxY) / 2;
+
+// align all components with top most component
+selection.each((d: any) => {
+if (d.type !== 'Connection') {
+const delta = {
+x: 0,
+y: center - (d.position.y +
d.dimensions.height / 2)
+};
+
+// if this component is already centered, no need
to updated it
+if (delta.y !== 0) {
+// consider any connections
+const connections =
this.canvasUtils.getComponentConnections(d.id);
+
+connections.forEach((connection: any) => {
+const connectionSelection =
d3.select('#id-' + connection.id);
+
+if (
+!updates.has(connection.id) &&
+
this.canvasUtils.getConnectionSourceComponentId(connection) ===
+
this.canvasUtils.getConnectionDestinationComponentId(connection)
+) {
+// this connection is self looping and
hasn't been updated by the delta yet
+const connectionUpdate =
this.draggableBehavior.updateConnectionPosition(
+connectionSelection.datum(),
+delta
+);
+if (connectionUpdate !== null) {
+updates.set(connection.id,
connectionUpdate);
+}
+} else if (
+!updates.has(connection.id) &&
+
connectionSelection.classed('selected') &&
+
this.canvasUtils.canModify(connectionSelection)
+) {
+// this is a selected connection that
hasn't been updated by the delta yet
+if (
+
this.canvasUtils.getConnectionSourceComponentId(connection) === d.id ||
+
Re: [PR] MINIFICPP-2364 - Add plist file to the package [nifi-minifi-cpp]
adamdebreceni commented on PR #1782: URL: https://github.com/apache/nifi-minifi-cpp/pull/1782#issuecomment-2100791494 > What's this plist? An equivalent to the linux minifi.service file but for macos -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13105 Implement a FlowRegistryClient that use GitHub for version… [nifi]
bbende commented on code in PR #8765:
URL: https://github.com/apache/nifi/pull/8765#discussion_r1594170696
##
nifi-extension-bundles/nifi-github-bundle/nifi-github-extensions/src/main/java/org/apache/nifi/github/GitHubFlowRegistryClient.java:
##
@@ -0,0 +1,633 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.nifi.github;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.MapperFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
+import com.fasterxml.jackson.databind.json.JsonMapper;
+import com.fasterxml.jackson.databind.type.TypeFactory;
+import
com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flow.ConnectableComponent;
+import org.apache.nifi.flow.Position;
+import org.apache.nifi.flow.VersionedComponent;
+import org.apache.nifi.flow.VersionedConnection;
+import org.apache.nifi.flow.VersionedFlowCoordinates;
+import org.apache.nifi.flow.VersionedProcessGroup;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.registry.flow.AbstractFlowRegistryClient;
+import org.apache.nifi.registry.flow.BucketLocation;
+import org.apache.nifi.registry.flow.FlowLocation;
+import org.apache.nifi.registry.flow.FlowRegistryBranch;
+import org.apache.nifi.registry.flow.FlowRegistryBucket;
+import org.apache.nifi.registry.flow.FlowRegistryClientConfigurationContext;
+import org.apache.nifi.registry.flow.FlowRegistryException;
+import org.apache.nifi.registry.flow.FlowRegistryPermissions;
+import org.apache.nifi.registry.flow.FlowVersionLocation;
+import org.apache.nifi.registry.flow.RegisterAction;
+import org.apache.nifi.registry.flow.RegisteredFlow;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshot;
+import org.apache.nifi.registry.flow.RegisteredFlowSnapshotMetadata;
+import org.kohsuke.github.GHCommit;
+import org.kohsuke.github.GHContent;
+import org.kohsuke.github.GHContentUpdateResponse;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.stream.Collectors;
+
+/**
+ * Implementation of {@link org.apache.nifi.registry.flow.FlowRegistryClient}
that uses GitHub for version controlling flows.
+ */
+public class GitHubFlowRegistryClient extends AbstractFlowRegistryClient {
+
+static final PropertyDescriptor GITHUB_API_URL = new
PropertyDescriptor.Builder()
+.name("GitHub API URL")
+.description("The URL of the GitHub API")
+.addValidator(StandardValidators.URL_VALIDATOR)
+.defaultValue("https://api.github.com/;)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_NAME = new
PropertyDescriptor.Builder()
+.name("Repository Name")
+.description("The name of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_OWNER = new
PropertyDescriptor.Builder()
+.name("Repository Owner")
+.description("The owner of the repository")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.required(true)
+.build();
+
+static final PropertyDescriptor REPOSITORY_BRANCH = new
PropertyDescriptor.Builder()
+.name("Default Branch")
+.description("The default branch to use for this client")
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+.defaultValue("main")
+.required(true)
+
[jira] [Updated] (NIFI-13174) [BUG] prioritizer and parameter context inheritance drag/drop scrollbars
[ https://issues.apache.org/jira/browse/NIFI-13174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13174: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > [BUG] prioritizer and parameter context inheritance drag/drop scrollbars > > > Key: NIFI-13174 > URL: https://issues.apache.org/jira/browse/NIFI-13174 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13174) [BUG] prioritizer and parameter context inheritance drag/drop scrollbars
[ https://issues.apache.org/jira/browse/NIFI-13174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844685#comment-17844685 ] ASF subversion and git services commented on NIFI-13174: Commit 45098ed8594ab9d451c5a0ebeadd8c1022d8ea3a in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=45098ed859 ] [NIFI-13174] increase drag/drop preview hieght to not display scroll bar (#8769) This closes #8769 > [BUG] prioritizer and parameter context inheritance drag/drop scrollbars > > > Key: NIFI-13174 > URL: https://issues.apache.org/jira/browse/NIFI-13174 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13174] increase drag/drop preview hieght to not display scroll bar [nifi]
rfellows merged PR #8769: URL: https://github.com/apache/nifi/pull/8769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
