[jira] [Commented] (NIFI-13219) Conduct Apache NiFi 2.0.0-M3 Release
[ https://issues.apache.org/jira/browse/NIFI-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846164#comment-17846164 ] ASF subversion and git services commented on NIFI-13219: Commit f2215c6522a5571189290760c55f0317f8562cbd in nifi's branch refs/heads/NIFI-13219-RC1 from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f2215c6522 ] NIFI-13219-RC1 prepare release nifi-2.0.0-M3-RC1 > Conduct Apache NiFi 2.0.0-M3 Release > > > Key: NIFI-13219 > URL: https://issues.apache.org/jira/browse/NIFI-13219 > Project: Apache NiFi > Issue Type: Task >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13219) Conduct Apache NiFi 2.0.0-M3 Release
[ https://issues.apache.org/jira/browse/NIFI-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846165#comment-17846165 ] ASF subversion and git services commented on NIFI-13219: Commit 3828a372962e8be5338c7bf96eabfd091f4a88d6 in nifi's branch refs/heads/NIFI-13219-RC1 from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3828a37296 ] NIFI-13219-RC1 prepare for next development iteration > Conduct Apache NiFi 2.0.0-M3 Release > > > Key: NIFI-13219 > URL: https://issues.apache.org/jira/browse/NIFI-13219 > Project: Apache NiFi > Issue Type: Task >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2311 Initial support for recordset readers and writers [nifi-minifi-cpp]
szaszm commented on code in PR #1763:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1763#discussion_r1598412718
##
libminifi/include/controllers/RecordSetReader.h:
##
@@ -0,0 +1,39 @@
+/**
+* Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+
+#include "core/controller/ControllerService.h"
+
+#include "core/FlowFile.h"
+#include "core/ProcessSession.h"
+#include "Record.h"
+#include "utils/Enum.h"
+#include "utils/ProcessorConfigUtils.h"
+
+
+namespace org::apache::nifi::minifi::core {
+
+class RecordSetReader : public controller::ControllerService {
+ public:
+ using ControllerService::ControllerService;
+
+
+ virtual nonstd::expected read(const
std::shared_ptr& flow_file, ProcessSession& session) = 0;
Review Comment:
Could this be changed to take FlowFile& instead of shared_ptr?
##
libminifi/include/controllers/RecordSetWriter.h:
##
@@ -0,0 +1,34 @@
+/**
+* Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include "core/controller/ControllerService.h"
+
+#include "core/FlowFile.h"
+#include "core/ProcessSession.h"
+#include "Record.h"
+
+namespace org::apache::nifi::minifi::core {
+
+class RecordSetWriter : public controller::ControllerService {
+ public:
+ using ControllerService::ControllerService;
+
+ virtual void write(const RecordSet& record_set, const
std::shared_ptr& flow_file, ProcessSession& session) = 0;
Review Comment:
Could this be changed to take `FlowFile&` instead of `shared_ptr`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-13225 Replaced most of the deprecated methods/classes/enums in JwtService with the API suggestions [nifi]
dan-s1 opened a new pull request, #8827: URL: https://github.com/apache/nifi/pull/8827 I was able to replace many of the deprecated warnings with the API suggested equivalents. The only ones I could not replace was the warning for ``` [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/secur ity/authentication/jwt/JwtService.java:[88,59] [deprecation] SigningKeyResolverAdapter in io.jsonwebtoken has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/secur ity/authentication/jwt/JwtService.java:[88,32] [deprecation] setSigningKeyResolver(SigningKeyResolver) in JwtParserBuilder has been deprecated ``` as the API suggestion to replace with [keyLocator](https://javadoc.io/static/io.jsonwebtoken/jjwt-api/0.12.5/io/jsonwebtoken/JwtParserBuilder.html#keyLocator(io.jsonwebtoken.Locator)) but that has no method with a signature which has a `Claims` object which would do the equivalent of the current `resolveSigningKeyBytes` in `SigningKeyResolverAdapter` # Summary [NIFI-13225](https://issues.apache.org/jira/browse/NIFI-13225) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13225) Replace the deprecated methods/classes/enums in JwtService with API suggestions
[
https://issues.apache.org/jira/browse/NIFI-13225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-13225:
Status: Patch Available (was: In Progress)
> Replace the deprecated methods/classes/enums in JwtService with API
> suggestions
> ---
>
> Key: NIFI-13225
> URL: https://issues.apache.org/jira/browse/NIFI-13225
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
>
> These are the warnings seen from a build
> {code:java}
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,25]
> [deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,66]
> [deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[68,39]
> [deprecation] getBody() in Jwt has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[73,39]
> [deprecation] getBody() in Jwt has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[76,22]
> [deprecation] getBody() in Jwt has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[87,59]
> [deprecation] SigningKeyResolverAdapter in io.jsonwebtoken has been
> deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[87,32]
> [deprecation] setSigningKeyResolver(SigningKeyResolver) in JwtParserBuilder
> has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[103,22]
> [deprecation] parseClaimsJws(CharSequence) in JwtParser has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[104,73]
> [deprecation] SignatureException in io.jsonwebtoken has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[155,33]
> [deprecation] setSubject(String) in ClaimsMutator has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[156,20]
> [deprecation] setIssuer(String) in ClaimsMutator has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[157,20]
> [deprecation] setAudience(String) in ClaimsMutator has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[160,20]
> [deprecation] setIssuedAt(Date) in ClaimsMutator has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[161,20]
> [deprecation] setExpiration(Date) in ClaimsMutator has been deprecated
> [WARNING]
> nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[162,20]
> [deprecation] signWith(SignatureAlgorithm,byte[]) in JwtBuilder has been
> deprecated
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13224) Replace deprecated commons-compress IOUtils.toByteArray(InputStream) with commons-io IOUtils.toByteArray(InputStream)
[ https://issues.apache.org/jira/browse/NIFI-13224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13224: Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Replace deprecated commons-compress IOUtils.toByteArray(InputStream) with > commons-io IOUtils.toByteArray(InputStream) > - > > Key: NIFI-13224 > URL: https://issues.apache.org/jira/browse/NIFI-13224 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > Changes should be made for files > # > nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/avro/AvroTypeUtil.java > # > nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/java/org/apache/nifi/elasticsearch/integration/ElasticSearchClientService_IT.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13222) Replace deprecated commons-compress IOUtils.closeQuietly(Closeable) with commons-io IOUtils.closeQuietly(Closeable)
[
https://issues.apache.org/jira/browse/NIFI-13222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-13222:
Fix Version/s: 2.0.0-M3
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Replace deprecated commons-compress IOUtils.closeQuietly(Closeable) with
> commons-io IOUtils.closeQuietly(Closeable)
> ---
>
> Key: NIFI-13222
> URL: https://issues.apache.org/jira/browse/NIFI-13222
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Fix For: 2.0.0-M3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This change must be applied to
> {code:java}
> c2/c2-client-bundle/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/operation/TransferDebugOperationHandler
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13169) Upgrade NiFi Registry to Flyway DB 10.latest
[ https://issues.apache.org/jira/browse/NIFI-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13169: Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade NiFi Registry to Flyway DB 10.latest > > > Key: NIFI-13169 > URL: https://issues.apache.org/jira/browse/NIFI-13169 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13223) Replace commons-lang3 CharSequenceTranslator, AggregateTranslator, LookupTranslator and UnicodeUnpairedSurrogateRemover with suggested API replacements
[
https://issues.apache.org/jira/browse/NIFI-13223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-13223:
Fix Version/s: 2.0.0-M3
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Replace commons-lang3 CharSequenceTranslator, AggregateTranslator,
> LookupTranslator and UnicodeUnpairedSurrogateRemover with suggested API
> replacements
> ---
>
> Key: NIFI-13223
> URL: https://issues.apache.org/jira/browse/NIFI-13223
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Fix For: 2.0.0-M3
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Changes must be applied to
> {code:java}
> nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/util/CharacterFilterUtils
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13169) Upgrade NiFi Registry to Flyway DB 10.12.0
[ https://issues.apache.org/jira/browse/NIFI-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13169: Issue Type: Improvement (was: Task) > Upgrade NiFi Registry to Flyway DB 10.12.0 > -- > > Key: NIFI-13169 > URL: https://issues.apache.org/jira/browse/NIFI-13169 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13169) Upgrade NiFi Registry to Flyway DB 10.12.0
[ https://issues.apache.org/jira/browse/NIFI-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13169: Summary: Upgrade NiFi Registry to Flyway DB 10.12.0 (was: Upgrade NiFi Registry to Flyway DB 10.latest) > Upgrade NiFi Registry to Flyway DB 10.12.0 > -- > > Key: NIFI-13169 > URL: https://issues.apache.org/jira/browse/NIFI-13169 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13223) Replace commons-lang3 CharSequenceTranslator, AggregateTranslator, LookupTranslator and UnicodeUnpairedSurrogateRemover with suggested API replacements
[
https://issues.apache.org/jira/browse/NIFI-13223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846097#comment-17846097
]
ASF subversion and git services commented on NIFI-13223:
Commit 92ed464f5dda1ede412f144928655494032e8734 in nifi's branch
refs/heads/main from dan-s1
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=92ed464f5d ]
NIFI-13223 Replaced deprecated commons-lang3 classes with commons-text versions
Replaced commons-lang3 CharSequenceTranslator, AggregateTranslator,
LookupTranslator and UnicodeUnpairedSurrogateRemover with commons-text
replacements.
This closes #8824
Signed-off-by: David Handermann
> Replace commons-lang3 CharSequenceTranslator, AggregateTranslator,
> LookupTranslator and UnicodeUnpairedSurrogateRemover with suggested API
> replacements
> ---
>
> Key: NIFI-13223
> URL: https://issues.apache.org/jira/browse/NIFI-13223
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Changes must be applied to
> {code:java}
> nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/util/CharacterFilterUtils
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-13224) Replace deprecated commons-compress IOUtils.toByteArray(InputStream) with commons-io IOUtils.toByteArray(InputStream)
[ https://issues.apache.org/jira/browse/NIFI-13224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846098#comment-17846098 ] ASF subversion and git services commented on NIFI-13224: Commit 2a45cae588967b7d7a4cfb96c9a08bec92380e6e in nifi's branch refs/heads/main from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2a45cae588 ] NIFI-13224 Replaced deprecated commons-compress IOUtils.toByteArray Replaced deprecated commons-compress IOUtils.toByteArray with commons-io IOUtils.toByteArray This closes #8825 Signed-off-by: David Handermann > Replace deprecated commons-compress IOUtils.toByteArray(InputStream) with > commons-io IOUtils.toByteArray(InputStream) > - > > Key: NIFI-13224 > URL: https://issues.apache.org/jira/browse/NIFI-13224 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Changes should be made for files > # > nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/avro/AvroTypeUtil.java > # > nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/java/org/apache/nifi/elasticsearch/integration/ElasticSearchClientService_IT.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13219) Conduct Apache NiFi 2.0.0-M3 Release
[ https://issues.apache.org/jira/browse/NIFI-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846095#comment-17846095 ] ASF subversion and git services commented on NIFI-13219: Commit 7f536117b10d95a82f2e1d7a113af8ec917762b2 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7f536117b1 ] NIFI-13219 Corrected phase for python-extensions-bundle plugins Signed-off-by: David Handermann > Conduct Apache NiFi 2.0.0-M3 Release > > > Key: NIFI-13219 > URL: https://issues.apache.org/jira/browse/NIFI-13219 > Project: Apache NiFi > Issue Type: Task >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13169) Upgrade NiFi Registry to Flyway DB 10.latest
[ https://issues.apache.org/jira/browse/NIFI-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846099#comment-17846099 ] ASF subversion and git services commented on NIFI-13169: Commit 08cc23826ba2f4c83848d9eefbf69193d8c10b29 in nifi's branch refs/heads/main from Matt Burgess [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=08cc23826b ] NIFI-13169 Upgraded Flyway in Registry from 9.22.3 to 10.12.0 This closes #8823 Signed-off-by: David Handermann > Upgrade NiFi Registry to Flyway DB 10.latest > > > Key: NIFI-13169 > URL: https://issues.apache.org/jira/browse/NIFI-13169 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Matt Burgess >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13222) Replace deprecated commons-compress IOUtils.closeQuietly(Closeable) with commons-io IOUtils.closeQuietly(Closeable)
[
https://issues.apache.org/jira/browse/NIFI-13222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846096#comment-17846096
]
ASF subversion and git services commented on NIFI-13222:
Commit 5d702671f63b75e50a8675d981df5981916abda5 in nifi's branch
refs/heads/main from dan-s1
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5d702671f6 ]
NIFI-13222 Replaced deprecated commons-compress IOUtils.closeQuietly
This closes #8822
Signed-off-by: David Handermann
> Replace deprecated commons-compress IOUtils.closeQuietly(Closeable) with
> commons-io IOUtils.closeQuietly(Closeable)
> ---
>
> Key: NIFI-13222
> URL: https://issues.apache.org/jira/browse/NIFI-13222
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This change must be applied to
> {code:java}
> c2/c2-client-bundle/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/operation/TransferDebugOperationHandler
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-13169: Upgrade Flyway in Registry to 10.12.0 [nifi]
exceptionfactory closed pull request #8823: NIFI-13169: Upgrade Flyway in Registry to 10.12.0 URL: https://github.com/apache/nifi/pull/8823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13224 Replaced deprecated commons-compress IOUtils.toByteArray(InputStream) with commons-io IOUtils.toByteArray(InputStream) [nifi]
exceptionfactory closed pull request #8825: NIFI-13224 Replaced deprecated commons-compress IOUtils.toByteArray(InputStream) with commons-io IOUtils.toByteArray(InputStream) URL: https://github.com/apache/nifi/pull/8825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13223 Replaced deprecated commons-lang3 CharSequenceTranslator, AggregateTranslator, LookupTranslator and UnicodeUnpairedSurrogateRemover with commons-text replacements. [nifi]
exceptionfactory closed pull request #8824: NIFI-13223 Replaced deprecated commons-lang3 CharSequenceTranslator, AggregateTranslator, LookupTranslator and UnicodeUnpairedSurrogateRemover with commons-text replacements. URL: https://github.com/apache/nifi/pull/8824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13222 Replaced deprecated commons-compress IOUtils.closeQuietly with commons-io IOUtils.closeQuietly. [nifi]
exceptionfactory closed pull request #8822: NIFI-13222 Replaced deprecated commons-compress IOUtils.closeQuietly with commons-io IOUtils.closeQuietly. URL: https://github.com/apache/nifi/pull/8822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12669 Fix EvaluateXQuery processor to encode result attr correctly on Windows [nifi]
jrsteinebrey opened a new pull request, #8826: URL: https://github.com/apache/nifi/pull/8826 # Summary [NIFI-12669](https://issues.apache.org/jira/browse/NIFI-12669) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-12669) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-12669` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-12669` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### UI Contributions No UI Changes ### Licensing No new dependencies ### Documentation No documentation changes required -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13225) Replace the deprecated methods/classes/enums in JwtService with API suggestions
[
https://issues.apache.org/jira/browse/NIFI-13225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-13225:
Description:
These are the warnings seen from a build
{code:java}
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,25]
[deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,66]
[deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[68,39]
[deprecation] getBody() in Jwt has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[73,39]
[deprecation] getBody() in Jwt has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[76,22]
[deprecation] getBody() in Jwt has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[87,59]
[deprecation] SigningKeyResolverAdapter in io.jsonwebtoken has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[87,32]
[deprecation] setSigningKeyResolver(SigningKeyResolver) in JwtParserBuilder
has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[103,22]
[deprecation] parseClaimsJws(CharSequence) in JwtParser has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[104,73]
[deprecation] SignatureException in io.jsonwebtoken has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[155,33]
[deprecation] setSubject(String) in ClaimsMutator has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[156,20]
[deprecation] setIssuer(String) in ClaimsMutator has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[157,20]
[deprecation] setAudience(String) in ClaimsMutator has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[160,20]
[deprecation] setIssuedAt(Date) in ClaimsMutator has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[161,20]
[deprecation] setExpiration(Date) in ClaimsMutator has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[162,20]
[deprecation] signWith(SignatureAlgorithm,byte[]) in JwtBuilder has been
deprecated
{code}
was:
These are the warnings seen from a build
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,25]
[deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,66]
[deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[68,39]
[deprecation] getBody() in Jwt has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[73,39]
[deprecation] getBody() in Jwt has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[76,22]
[deprecation] getBody() in Jwt has been deprecated
[WARNING]
nifi-registry/nifi-registry-core/nifi-registry-web-api/
[jira] [Assigned] (NIFI-13159) Change how PutSFTP handles the REPLACE Conflict Resolution strategy
[ https://issues.apache.org/jira/browse/NIFI-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael W Moser reassigned NIFI-13159: -- Assignee: Michael W Moser > Change how PutSFTP handles the REPLACE Conflict Resolution strategy > --- > > Key: NIFI-13159 > URL: https://issues.apache.org/jira/browse/NIFI-13159 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Michael W Moser >Assignee: Michael W Moser >Priority: Minor > > In the PutSFTP processor, in the specific case when "Dot Rename = true" and > "Conflict Resolution = replace", PutSFTP currently behaves like this: > * if remote filename.txt exists, delete it > * send file to remote as .filename.txt > * rename .filename.txt to filename.txt > This causes filename.txt to not exist on the remote machine while the SFTP > transfer is taking place. This is different than the PutFile processor, > which will wait to replace the file until it has written the "dot file". Is > it possible for PutSFTP to behave like this: > * send file to remote as .filename.txt > * if remote filename.txt exists, delete it > * rename .filename.txt to filename.txt > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13224) Replace deprecated commons-compress IOUtils.toByteArray(InputStream) with commons-io IOUtils.toByteArray(InputStream)
[ https://issues.apache.org/jira/browse/NIFI-13224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13224: Status: Patch Available (was: In Progress) > Replace deprecated commons-compress IOUtils.toByteArray(InputStream) with > commons-io IOUtils.toByteArray(InputStream) > - > > Key: NIFI-13224 > URL: https://issues.apache.org/jira/browse/NIFI-13224 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Changes should be made for files > # > nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/avro/AvroTypeUtil.java > # > nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/java/org/apache/nifi/elasticsearch/integration/ElasticSearchClientService_IT.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13224 Replaced deprecated commons-compress IOUtils.toByteArray(InputStream) with commons-io IOUtils.toByteArray(InputStream) [nifi]
dan-s1 opened a new pull request, #8825: URL: https://github.com/apache/nifi/pull/8825 # Summary [NIFI-13224](https://issues.apache.org/jira/browse/NIFI-13224) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) *** Support Processor Details dialog *** Support Connection Details dialog * Counters (NIFI-12415) ** Counter table has extra unnecessary can modify check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Node table (Disconnect/Connect/Load Balance/Etc) (NIFI-13053) ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About (NIFI-13094) * Show Upstream/Downstream * Align (NIFI-13162) * Replay last event (NIFI-12445) * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering (NIFI-13005) * Change Component Version (NIFI-13034) * Consider PG permissions in Toolbox (NIFI-12683) * PG Version (NIFI-12963 & NIFI-12995) ** Start (NIFI-12963) ** Commit (NIFI-12963) ** Force Commit (NIFI-12963) ** Show changes (NIFI-12995) ** Revert changes (NIFI-12995) ** Change Flow version (NIFI-12995) ** Stop (NIFI-12963) * Configure PG (NIFI-12417) * Configure Label (NIFI-13081) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Status Bar ** Stop and Configure ** Open Custom UI (NIFI-12958) ** Property History (NIFI-13047) ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * Terminate Threads (context menu) (NIFI-13068) * Enable/Disable (context menu/operate panel) (NIFI-13078) * More Details (Processor, Controller Service, Reporting Task) (NIFI-13062) * Download Flow (NIFI-13029) * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color (context menu/operate panel) (NIFI-13226) * Move to Front (NIFI-13044) * Copy/Paste (context menu/operate panel) (NIFI-13059) * Add/Update Info Icons in dialogs throughout the application (NIFI-13092) * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation (NIFI-13001) * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling (NIFI-13104) * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer (NIFI-13100) ** Parameter Contexts (NIFI-12937) ** C
[jira] [Created] (NIFI-13226) Color (context menu/operate panel)
Rob Fellows created NIFI-13226: -- Summary: Color (context menu/operate panel) Key: NIFI-13226 URL: https://issues.apache.org/jira/browse/NIFI-13226 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows Assignee: Rob Fellows -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13225) Replace the deprecated methods/classes/enums in JwtService with API suggestions
Daniel Stieglitz created NIFI-13225: --- Summary: Replace the deprecated methods/classes/enums in JwtService with API suggestions Key: NIFI-13225 URL: https://issues.apache.org/jira/browse/NIFI-13225 Project: Apache NiFi Issue Type: Improvement Reporter: Daniel Stieglitz Assignee: Daniel Stieglitz These are the warnings seen from a build [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,25] [deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[47,66] [deprecation] SignatureAlgorithm in io.jsonwebtoken has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[68,39] [deprecation] getBody() in Jwt has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[73,39] [deprecation] getBody() in Jwt has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[76,22] [deprecation] getBody() in Jwt has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[87,59] [deprecation] SigningKeyResolverAdapter in io.jsonwebtoken has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[87,32] [deprecation] setSigningKeyResolver(SigningKeyResolver) in JwtParserBuilder has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[103,22] [deprecation] parseClaimsJws(CharSequence) in JwtParser has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[104,73] [deprecation] SignatureException in io.jsonwebtoken has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[155,33] [deprecation] setSubject(String) in ClaimsMutator has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[156,20] [deprecation] setIssuer(String) in ClaimsMutator has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[157,20] [deprecation] setAudience(String) in ClaimsMutator has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[160,20] [deprecation] setIssuedAt(Date) in ClaimsMutator has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[161,20] [deprecation] setExpiration(Date) in ClaimsMutator has been deprecated [WARNING] nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/authentication/jwt/JwtService.java:[162,20] [deprecation] signWith(SignatureAlgorithm,byte[]) in JwtBuilder has been deprecated -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13224) Replace deprecated commons-compress IOUtils.toByteArray(InputStream) with commons-io IOUtils.toByteArray(InputStream)
Daniel Stieglitz created NIFI-13224: --- Summary: Replace deprecated commons-compress IOUtils.toByteArray(InputStream) with commons-io IOUtils.toByteArray(InputStream) Key: NIFI-13224 URL: https://issues.apache.org/jira/browse/NIFI-13224 Project: Apache NiFi Issue Type: Improvement Reporter: Daniel Stieglitz Assignee: Daniel Stieglitz Changes should be made for files # nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/avro/AvroTypeUtil.java # nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/java/org/apache/nifi/elasticsearch/integration/ElasticSearchClientService_IT.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13223) Replace commons-lang3 CharSequenceTranslator, AggregateTranslator, LookupTranslator and UnicodeUnpairedSurrogateRemover with suggested API replacements
[
https://issues.apache.org/jira/browse/NIFI-13223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-13223:
Status: Patch Available (was: In Progress)
> Replace commons-lang3 CharSequenceTranslator, AggregateTranslator,
> LookupTranslator and UnicodeUnpairedSurrogateRemover with suggested API
> replacements
> ---
>
> Key: NIFI-13223
> URL: https://issues.apache.org/jira/browse/NIFI-13223
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Changes must be applied to
> {code:java}
> nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/util/CharacterFilterUtils
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13169) Upgrade NiFi Registry to Flyway DB 10.latest
[ https://issues.apache.org/jira/browse/NIFI-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-13169: Status: Patch Available (was: In Progress) > Upgrade NiFi Registry to Flyway DB 10.latest > > > Key: NIFI-13169 > URL: https://issues.apache.org/jira/browse/NIFI-13169 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Matt Burgess >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13223 Replaced commons-lang3 CharSequenceTranslator, AggregateTranslator, LookupTranslator and UnicodeUnpairedSurrogateRemover with commons-text replacements. [nifi]
dan-s1 opened a new pull request, #8824: URL: https://github.com/apache/nifi/pull/8824 # Summary [NIFI-13223](https://issues.apache.org/jira/browse/NIFI-13223) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13169: Upgrade Flyway in Registry to 10.12.0 [nifi]
mattyb149 opened a new pull request, #8823: URL: https://github.com/apache/nifi/pull/8823 # Summary [NIFI-13169](https://issues.apache.org/jira/browse/NIFI-13169) Upgraded the Flyway version in NiFi Registry to 10.12.0 and made any necessary API changes. Tested buckets and flows against PostgreSQL 15. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13223) Replace commons-lang3 CharSequenceTranslator, AggregateTranslator, LookupTranslator and UnicodeUnpairedSurrogateRemover with suggested API replacements
Daniel Stieglitz created NIFI-13223:
---
Summary: Replace commons-lang3 CharSequenceTranslator,
AggregateTranslator, LookupTranslator and UnicodeUnpairedSurrogateRemover with
suggested API replacements
Key: NIFI-13223
URL: https://issues.apache.org/jira/browse/NIFI-13223
Project: Apache NiFi
Issue Type: Improvement
Reporter: Daniel Stieglitz
Assignee: Daniel Stieglitz
Changes must be applied to
{code:java}
nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/util/CharacterFilterUtils
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13222) Replace deprecated commons-compress IOUtils.closeQuietly(Closeable) with commons-io IOUtils.closeQuietly(Closeable)
[
https://issues.apache.org/jira/browse/NIFI-13222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-13222:
Status: Patch Available (was: In Progress)
> Replace deprecated commons-compress IOUtils.closeQuietly(Closeable) with
> commons-io IOUtils.closeQuietly(Closeable)
> ---
>
> Key: NIFI-13222
> URL: https://issues.apache.org/jira/browse/NIFI-13222
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This change must be applied to
> {code:java}
> c2/c2-client-bundle/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/operation/TransferDebugOperationHandler
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-13222 Replaced deprecated commons-compress IOUtils.closeQuietly with commons-io IOUtils.closeQuietly. [nifi]
dan-s1 opened a new pull request, #8822: URL: https://github.com/apache/nifi/pull/8822 # Summary [NIFI-13222](https://issues.apache.org/jira/browse/NIFI-13222) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
scottyaslan commented on code in PR #8804: URL: https://github.com/apache/nifi/pull/8804#discussion_r1598830962 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/ui/provenance-event-listing/provenance-event-table/provenance-event-table.component.html: ## @@ -17,7 +17,7 @@ - + Review Comment: This is also an issue throughout the app. For all `mat-form-field`'s like this angular adds a bottom margin for the `mat-hint` or `mat-error`. However, in these usages of `mat-form-field` above tables throughout nifi we do not follow the material spec and instead we place the hint above the fields. In order to address this issue I see two options: 1. We can update the UX to follow the material specification and leverage the `mat-hint`. OR 2. We need to remove the margin at the bottom of these fields ( I think we can leverage https://material.angular.io/components/form-field/api#SubscriptSizing) and then also go through and update the spacing/padding of these form fields table filters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
scottyaslan commented on code in PR #8804:
URL: https://github.com/apache/nifi/pull/8804#discussion_r1598820913
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/global-access-policies/global-access-policies.component.html:
##
@@ -22,7 +22,7 @@
} @else {
@if (flowConfiguration$ | async; as flowConfiguration) {
-
+
Review Comment:
This is actually an issue throughout the application:
For example the edit dialogs:
https://github.com/apache/nifi/assets/6797571/97c4bf01-b08a-4bd1-8b3d-d5765fcca0ca";>
I will add some padding to the top and bottom of the error-banner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13221) Display hotkey combos in context menu
[ https://issues.apache.org/jira/browse/NIFI-13221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13221: --- Status: Patch Available (was: In Progress) > Display hotkey combos in context menu > - > > Key: NIFI-13221 > URL: https://issues.apache.org/jira/browse/NIFI-13221 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When appropriate, display the hotkey combinations in the context menu to > bring awareness to them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13222) Replace deprecated commons-compress IOUtils.closeQuietly(Closeable) with commons-io IOUtils.closeQuietly(Closeable)
Daniel Stieglitz created NIFI-13222:
---
Summary: Replace deprecated commons-compress
IOUtils.closeQuietly(Closeable) with commons-io IOUtils.closeQuietly(Closeable)
Key: NIFI-13222
URL: https://issues.apache.org/jira/browse/NIFI-13222
Project: Apache NiFi
Issue Type: Improvement
Reporter: Daniel Stieglitz
Assignee: Daniel Stieglitz
This change must be applied to
{code:java}
c2/c2-client-bundle/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/operation/TransferDebugOperationHandler
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-13221) Display hotkey combos in context menu
Rob Fellows created NIFI-13221: -- Summary: Display hotkey combos in context menu Key: NIFI-13221 URL: https://issues.apache.org/jira/browse/NIFI-13221 Project: Apache NiFi Issue Type: Sub-task Reporter: Rob Fellows Assignee: Rob Fellows When appropriate, display the hotkey combinations in the context menu to bring awareness to them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
scottyaslan commented on code in PR #8804: URL: https://github.com/apache/nifi/pull/8804#discussion_r1598737032 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/feature/access-policies.component.html: ## @@ -15,14 +15,14 @@ ~ limitations under the License. --> - - + + -Access Policies +Access Policies - + Review Comment: It is very similar but these changes do align the bottom padding/spacing with the other pages. Specifically the spacing for the last refreshed timestamp and button. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12888 In AbstractEmailProcessor recreate email receiver when token expires. [nifi]
tpalfy commented on PR #8494: URL: https://github.com/apache/nifi/pull/8494#issuecomment-2108094848 Hi @AnTu2702, Do you happen to try connecting to an Office365 account? The issue you mention didn't occur when I was testing but when googled it, it gave me several results users complaining about this when using Office365. According to one search result this can be caused by clients that are trying to connect too frequently. Can you try lowering the schedule period and see if that helps? Others suggest checking the OAuth config of Office365. Couple of links for reference: https://confluence.atlassian.com/jirakb/imap-fails-with-a3-bad-user-is-authenticated-but-not-connected-error-in-jira-server-integrated-with-office365-665420269.html https://github.com/mscdex/node-imap/issues/689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13220) Filter out buckets users don't have write access to from dropdown
[ https://issues.apache.org/jira/browse/NIFI-13220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13220: Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Filter out buckets users don't have write access to from dropdown > - > > Key: NIFI-13220 > URL: https://issues.apache.org/jira/browse/NIFI-13220 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > When starting version control, buckets where the user does not have write > access to should not be available to select. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13220) Filter out buckets users don't have write access to from dropdown
[ https://issues.apache.org/jira/browse/NIFI-13220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845991#comment-17845991 ] ASF subversion and git services commented on NIFI-13220: Commit 13e281d8d72f6f33514f2f2baaba5d3a25627949 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=13e281d8d7 ] NIFI-13220 Only allow buckets with write access dropdown when starting version control This closes #8820 Signed-off-by: David Handermann > Filter out buckets users don't have write access to from dropdown > - > > Key: NIFI-13220 > URL: https://issues.apache.org/jira/browse/NIFI-13220 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > When starting version control, buckets where the user does not have write > access to should not be available to select. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13220] - only allow buckets that users have write access to in the bucket dropdown when starting version control [nifi]
exceptionfactory closed pull request #8820: [NIFI-13220] - only allow buckets that users have write access to in the bucket dropdown when starting version control URL: https://github.com/apache/nifi/pull/8820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2346: Build MiNiFi Core, MainExe, Standard-Processors with Conan2 [nifi-minifi-cpp]
martinzink commented on PR #1775: URL: https://github.com/apache/nifi-minifi-cpp/pull/1775#issuecomment-2108070872 You will need to rebase your PR for the CI to work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1596969674
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/util/PCAP.java:
##
@@ -0,0 +1,717 @@
+// MIT License
+
+// Copyright (c) 2015-2023 Kaitai Project
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to
deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+
+// The above copyright notice and this permission notice shall be included in
all
+// copies or substantial portions of the Software.
+
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE
+// SOFTWARE.
+
+package org.apache.nifi.processors.network.util;
+
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+import java.util.Map;
+
+import org.apache.commons.lang3.EnumUtils;
+
+import java.util.HashMap;
+import java.util.ListIterator;
+import java.util.ArrayList;
+
+/**
+ * PCAP (named after libpcap / winpcap) is a popular format for saving
+ * network traffic grabbed by network sniffers. It is typically
+ * produced by tools like [tcpdump](https://www.tcpdump.org/) or
+ * [Wireshark](https://www.wireshark.org/).
+ *
+ * @see https://wiki.wireshark.org/Development/LibpcapFileFormat";>Source
+ */
+public class PCAP {
+public ByteBufferInterface io;
+
+public enum Linktype {
+NULL_LINKTYPE(0),
+ETHERNET(1),
+EXP_ETHERNET(2),
+AX25(3),
+PRONET(4),
+CHAOS(5),
+IEEE802_5(6),
+ARCNET_BSD(7),
+SLIP(8),
+PPP(9),
+FDDI(10),
+REDBACK_SMARTEDGE(32),
+PPP_HDLC(50),
+PPP_ETHER(51),
+SYMANTEC_FIREWALL(99),
+ATM_RFC1483(100),
+RAW(101),
+C_HDLC(104),
+IEEE802_11(105),
+ATM_CLIP(106),
+FRELAY(107),
+LOOP(108),
+ENC(109),
+NETBSD_HDLC(112),
+LINUX_SLL(113),
+LTALK(114),
+ECONET(115),
+IPFILTER(116),
+PFLOG(117),
+CISCO_IOS(118),
+IEEE802_11_PRISM(119),
+AIRONET_HEADER(120),
+IP_OVER_FC(122),
+SUNATM(123),
+RIO(124),
+PCI_EXP(125),
+AURORA(126),
+IEEE802_11_RADIOTAP(127),
+TZSP(128),
+ARCNET_LINUX(129),
+JUNIPER_MLPPP(130),
+JUNIPER_MLFR(131),
+JUNIPER_ES(132),
+JUNIPER_GGSN(133),
+JUNIPER_MFR(134),
+JUNIPER_ATM2(135),
+JUNIPER_SERVICES(136),
+JUNIPER_ATM1(137),
+APPLE_IP_OVER_IEEE1394(138),
+MTP2_WITH_PHDR(139),
+MTP2(140),
+MTP3(141),
+SCCP(142),
+DOCSIS(143),
+LINUX_IRDA(144),
+IBM_SP(145),
+IBM_SN(146),
+USER0(147),
+USER1(148),
+USER2(149),
+USER3(150),
+USER4(151),
+USER5(152),
+USER6(153),
+USER7(154),
+USER8(155),
+USER9(156),
+USER10(157),
+USER11(158),
+USER12(159),
+USER13(160),
+USER14(161),
+USER15(162),
+IEEE802_11_AVS(163),
+JUNIPER_MONITOR(164),
+BACNET_MS_TP(165),
+PPP_PPPD(166),
+JUNIPER_PPPOE(167),
+JUNIPER_PPPOE_ATM(168),
+GPRS_LLC(169),
+GPF_T(170),
+GPF_F(171),
+GCOM_T1E1(172),
+GCOM_SERIAL(173),
+JUNIPER_PIC_PEER(174),
+ERF_ETH(175),
+ERF_POS(176),
+LINUX_LAPD(177),
+JUNIPER_ETHER(178),
+JUNIPER_PPP(179),
+JUNIPER_FRELAY(180),
+JUNIPER_CHDLC(181),
+MFR(182),
+JUNIPER_VP(183),
+A429(184),
+A653_ICM(185),
+USB_FREEBSD(186),
+BLUETOOTH_HCI_H4(187),
+IEEE802_16_MAC_CPS(188),
+USB_LINUX(189),
+CAN20B(190),
+IEEE802_15_4_LINUX(191),
+PPI(192),
+IEEE802_16_MAC_CPS_RADIO(193),
+JUNIPER_ISM(194),
+IEEE802_15_4_WITHFCS(195),
+SITA(196),
+ERF(197),
+RAIF1(198),
+IPMB_KONTRON(199),
+JUNIPER_ST(200),
+BLUETOOTH_HCI_H4_WITH_PHDR(201),
+AX25_KISS(202),
+LAPD(203),
+PPP_WITH_DIR(204),
+
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1596930498
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/SplitPCAP.java:
##
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.processors.network.util.PCAP;
+import org.apache.nifi.processors.network.util.PCAP.ByteBufferInterface;
+import org.apache.nifi.processors.network.util.PCAP.Packet;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttribute(attribute = "ERROR_REASON", description = "The reason the
flowfile was sent to the failure relationship.")
+
+public class SplitPCAP extends AbstractProcessor {
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP_MAX_SIZE")
+.displayName("PCAP max size (bytes)")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.addValidator(StandardValidators.INTEGER_VALIDATOR)
+.build();
+
+public static final Relationship REL_SUCCESS = new Relationship.Builder()
+.name("success")
+.description("output flowfiles")
+.build();
+
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("Flowfiles not parseable as pcap.")
+.build();
+
+private static final List DESCRIPTORS =
List.of(PCAP_MAX_SIZE);
+
+private static final Set RELATIONSHIPS = Set.of(REL_SUCCESS,
REL_FAILURE);
+
+@Override
+public Set getRelationships() {
+return RELATIONSHIPS;
+}
+
+@Override
+public final List getSupportedPropertyDescriptors() {
+return DESCRIPTORS;
+}
+
+@OnScheduled
+public void onScheduled(final ProcessContext context) {
+
+}
Review Comment:
No need to include this if there is no implementation
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13220) Filter out buckets users don't have write access to from dropdown
[ https://issues.apache.org/jira/browse/NIFI-13220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13220: --- Status: Patch Available (was: In Progress) > Filter out buckets users don't have write access to from dropdown > - > > Key: NIFI-13220 > URL: https://issues.apache.org/jira/browse/NIFI-13220 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When starting version control, buckets where the user does not have write > access to should not be available to select. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13220] - only allow buckets that users have write access to in the bucket dropdown when starting version control [nifi]
rfellows opened a new pull request, #8820: URL: https://github.com/apache/nifi/pull/8820 [NIFI-13220](https://issues.apache.org/jira/browse/NIFI-13220) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13220) Filter out buckets users don't have write access to from dropdown
Rob Fellows created NIFI-13220: -- Summary: Filter out buckets users don't have write access to from dropdown Key: NIFI-13220 URL: https://issues.apache.org/jira/browse/NIFI-13220 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Rob Fellows Assignee: Rob Fellows When starting version control, buckets where the user does not have write access to should not be available to select. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2349 FetchModbusTcp [nifi-minifi-cpp]
martinzink commented on code in PR #1779: URL: https://github.com/apache/nifi-minifi-cpp/pull/1779#discussion_r1598603379 ## extensions/standard-processors/modbus/ReadModbusFunctions.h: ## Review Comment: Good idea, I've extracted the non-tempalte fucntion to source file in https://github.com/apache/nifi-minifi-cpp/pull/1779/commits/a08b46b37dd61817923349d802ab351fdf9b79a5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2349 FetchModbusTcp [nifi-minifi-cpp]
martinzink commented on code in PR #1779:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1779#discussion_r1598602084
##
extensions/standard-processors/modbus/FetchModbusTcp.cpp:
##
@@ -0,0 +1,259 @@
+/**
+* Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "FetchModbusTcp.h"
+
+#include
+
+#include
+#include
+
+#include "core/Resource.h"
+
+#include "core/ProcessSession.h"
+#include "modbus/Error.h"
+#include "modbus/ReadModbusFunctions.h"
+#include "utils/net/AsioCoro.h"
+#include "utils/net/AsioSocketUtils.h"
+
+using namespace std::literals::chrono_literals;
+
+namespace org::apache::nifi::minifi::modbus {
+
+
+void FetchModbusTcp::onSchedule(core::ProcessContext& context,
core::ProcessSessionFactory&) {
+ const auto record_set_writer_name = context.getProperty(RecordSetWriter);
+ record_set_writer_ =
std::dynamic_pointer_cast(context.getControllerService(record_set_writer_name.value_or("")));
+ if (!record_set_writer_)
+throw Exception{ExceptionType::PROCESS_SCHEDULE_EXCEPTION, "Invalid or
missing RecordSetWriter"};
+
+// if the required properties are missing or empty even before evaluating
the EL expression, then we can throw in onSchedule, before we waste any flow
files
+ if (context.getProperty(Hostname).value_or(std::string{}).empty()) {
+throw Exception{ExceptionType::PROCESS_SCHEDULE_EXCEPTION, "missing
hostname"};
+ }
+ if (context.getProperty(Port).value_or(std::string{}).empty()) {
+throw Exception{ExceptionType::PROCESS_SCHEDULE_EXCEPTION, "missing port"};
+ }
+ if (const auto idle_connection_expiration =
context.getProperty(IdleConnectionExpiration);
idle_connection_expiration && idle_connection_expiration->getMilliseconds() >
0ms)
+idle_connection_expiration_ =
idle_connection_expiration->getMilliseconds();
+ else
+idle_connection_expiration_.reset();
+
+ if (const auto timeout =
context.getProperty(Timeout); timeout &&
timeout->getMilliseconds() > 0ms)
+timeout_duration_ = timeout->getMilliseconds();
+ else
+timeout_duration_ = 15s;
+
+ if (context.getProperty(ConnectionPerFlowFile).value_or(false))
+connections_.reset();
+ else
+connections_.emplace();
+
+ ssl_context_.reset();
+ if (const auto context_name = context.getProperty(SSLContextService);
context_name && !IsNullOrEmpty(*context_name)) {
+if (auto controller_service = context.getControllerService(*context_name))
{
+ if (const auto ssl_context_service =
std::dynamic_pointer_cast(context.getControllerService(*context_name)))
{
+ssl_context_ = utils::net::getSslContext(*ssl_context_service);
+ } else {
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, *context_name + " is not
an SSL Context Service");
+ }
+} else {
+ throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Invalid controller service:
" + *context_name);
+}
+ }
+
+ readDynamicPropertyKeys(context);
+}
+
+void FetchModbusTcp::onTrigger(core::ProcessContext& context,
core::ProcessSession& session) {
+ const auto flow_file = getFlowFile(session);
+ if (!flow_file) {
Review Comment:
Makes sense, changed it in
https://github.com/apache/nifi-minifi-cpp/pull/1779/commits/a08b46b37dd61817923349d802ab351fdf9b79a5#diff-9f8b9763f59e4bfc0ab6bfb37c88dbd4a441b99abc14682bc954309aa0c59551R85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2349 FetchModbusTcp [nifi-minifi-cpp]
martinzink commented on code in PR #1779:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1779#discussion_r1598601511
##
extensions/standard-processors/modbus/Error.h:
##
@@ -0,0 +1,69 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include
+#include
+#include "magic_enum.hpp"
+
+namespace org::apache::nifi::minifi::modbus {
+
+enum class ModbusExceptionCode : std::underlying_type_t {
+ IllegalFunction = 0x01,
+ IllegalDataAddress = 0x02,
+ IllegalDataValue = 0x03,
+ SlaveDeviceFailure = 0x04,
+ Acknowledge = 0x05,
+ SlaveDeviceBusy = 0x06,
+ NegativeAcknowledge = 0x07,
+ MemoryParityError = 0x08,
+ GatewayPathUnavailable = 0x0a,
+ GatewayTargetDeviceFailedToRespond = 0x0b,
+ InvalidResponse,
+ MessageTooLarge,
+ InvalidTransactionId,
+ IllegalProtocol,
+ InvalidSlaveId
+};
+
+
+struct ModbusErrorCategory final : std::error_category {
+ [[nodiscard]] const char* name() const noexcept override {
+return "modbus error";
+ }
+
+ [[nodiscard]] std::string message(int ev) const override {
+const auto modbus_exception_code = static_cast(ev);
+return
std::string{magic_enum::enum_name(modbus_exception_code)};
+ }
+};
+
+inline const ModbusErrorCategory& modbus_category() noexcept {
+ static ModbusErrorCategory category;
+ return category;
+};
+
+inline std::error_code make_error_code(ModbusExceptionCode c) {
+ return {static_cast(c), modbus_category()};
+}
+
+} // namespace org::apache::nifi::minifi::modbus
+
+template <>
+struct
std::is_error_code_enum
: true_type {};
Review Comment:
good idea 👍
https://github.com/apache/nifi-minifi-cpp/pull/1779/commits/a08b46b37dd61817923349d802ab351fdf9b79a5#diff-5e196a0d70ff6c0ce2a67954b04ebb23032ed82a12faed296b1ec00793dddfa5R69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2311 Initial support for recordset readers and writers [nifi-minifi-cpp]
martinzink commented on code in PR #1763: URL: https://github.com/apache/nifi-minifi-cpp/pull/1763#discussion_r1598591018 ## libminifi/test/TestRecord.h: ## Review Comment: Those example record contain all the fields that Record support, and there is nothing that Json specific, any new RecordSetReader/RecordSetWriter could use these to show how their serialization/deserialization work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2311 Initial support for recordset readers and writers [nifi-minifi-cpp]
martinzink commented on code in PR #1763:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1763#discussion_r1598588398
##
extensions/standard-processors/controllers/JsonRecordSetWriter.h:
##
@@ -0,0 +1,93 @@
+/**
+* Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include "PropertyDefinitionBuilder.h"
+#include "Record.h"
+#include "controllers/RecordSetWriter.h"
+#include "core/FlowFile.h"
+#include "core/ProcessSession.h"
+#include "utils/Enum.h"
+
+namespace org::apache::nifi::minifi::standard {
+
+enum class OutputGroupingType {
+ Array,
+ OneLinePerObject
+};
+
+class JsonRecordSetWriter final : public core::RecordSetWriter {
+ public:
+ explicit JsonRecordSetWriter(const std::string& name, const
utils::Identifier& uuid = {});
+ explicit JsonRecordSetWriter(const std::string& name, const
std::shared_ptr& configuration);
+
+ JsonRecordSetWriter(JsonRecordSetWriter&&) = delete;
+ JsonRecordSetWriter(const JsonRecordSetWriter&) = delete;
+ JsonRecordSetWriter& operator=(JsonRecordSetWriter&&) = delete;
+ JsonRecordSetWriter& operator=(const JsonRecordSetWriter&) = delete;
+
+ ~JsonRecordSetWriter() override = default;
+
+ EXTENSIONAPI static constexpr const char* Description =
+ "Writes the results of a RecordSet as either a JSON Array or one JSON
object per line. "
+ "If using Array output, then even if the RecordSet consists of a single
row, it will be written as an array with a single element. "
+ "If using One Line Per Object output, the JSON objects cannot be
pretty-printed.";
+
+ EXTENSIONAPI static constexpr auto OutputGrouping =
core::PropertyDefinitionBuilder()>::createProperty("Output
Grouping")
+.withDescription("Specifies how the writer should output the JSON records
(as an array or one object per line, e.g.) "
+"Note that if 'One Line Per Object' is selected, then
Pretty Print JSON must be false.")
Review Comment:
agree 👍
https://github.com/apache/nifi-minifi-cpp/pull/1763/commits/c9aa16d7cd2ea2bd69e0345f365213f5a403cda2#diff-f10913418d7471adbf70fd555a46415f88c6cc031efb380861ab93d744c5c94dR76
https://github.com/apache/nifi-minifi-cpp/pull/1763/commits/c9aa16d7cd2ea2bd69e0345f365213f5a403cda2#diff-f10913418d7471adbf70fd555a46415f88c6cc031efb380861ab93d744c5c94dR31-R48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2311 Initial support for recordset readers and writers [nifi-minifi-cpp]
martinzink commented on code in PR #1763:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1763#discussion_r1598587330
##
extensions/standard-processors/tests/unit/JsonRecordTests.cpp:
##
@@ -0,0 +1,145 @@
+/**
+* Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.c
+ */
+
+#include
+#include
+
+#include "Catch.h"
+#include "RecordSetTesters.h"
+#include "TestBase.h"
+#include "TestRecord.h"
+#include "controllers/JsonRecordSetReader.h"
+#include "controllers/JsonRecordSetWriter.h"
+#include "core/Record.h"
+
+namespace org::apache::nifi::minifi::standard::test {
+
+constexpr std::string_view record_per_line_str =
R"({"baz":3.14,"qux":[true,false,true],"is_test":true,"bar":123,"quux":{"Aprikose":"apricot","Birne":"pear","Apfel":"apple"},"foo":"asd","when":"2012-07-01T09:53:00Z"}
+{"baz":3.141592653589793,"qux":[false,false,true],"is_test":true,"bar":98402134,"quux":{"Aprikose":"abricot","Birne":"poire","Apfel":"pomme"},"foo":"Lorem
ipsum dolor sit amet, consectetur adipiscing
elit.","when":"2022-11-01T19:52:11Z"}
+)";
+constexpr std::string_view array_compressed_str =
R"([{"baz":3.14,"qux":[true,false,true],"is_test":true,"bar":123,"quux":{"Aprikose":"apricot","Birne":"pear","Apfel":"apple"},"foo":"asd","when":"2012-07-01T09:53:00Z"},{"baz":3.141592653589793,"qux":[false,false,true],"is_test":true,"bar":98402134,"quux":{"Aprikose":"abricot","Birne":"poire","Apfel":"pomme"},"foo":"Lorem
ipsum dolor sit amet, consectetur adipiscing
elit.","when":"2022-11-01T19:52:11Z"}])";
+constexpr std::string_view array_pretty_str = R"([
+{
+"baz": 3.14,
+"qux": [
+true,
+false,
+true
+],
+"is_test": true,
+"bar": 123,
+"quux": {
+"Aprikose": "apricot",
+"Birne": "pear",
+"Apfel": "apple"
+},
+"foo": "asd",
+"when": "2012-07-01T09:53:00Z"
+},
+{
+"baz": 3.141592653589793,
+"qux": [
+false,
+false,
+true
+],
+"is_test": true,
+"bar": 98402134,
+"quux": {
+"Aprikose": "abricot",
+"Birne": "poire",
+"Apfel": "pomme"
+},
+"foo": "Lorem ipsum dolor sit amet, consectetur adipiscing elit.",
+"when": "2022-11-01T19:52:11Z"
+}
+])";
+
+bool test_json_equality(const std::string_view expected_str, const
std::string_view actual_str) {
Review Comment:
👍
https://github.com/apache/nifi-minifi-cpp/pull/1763/commits/c9aa16d7cd2ea2bd69e0345f365213f5a403cda2#diff-57d2adaddec9ace677119724e550df7ec037b8cad18b8cf32dca577d73787014R73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2311 Initial support for recordset readers and writers [nifi-minifi-cpp]
martinzink commented on code in PR #1763:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1763#discussion_r1598586506
##
extensions/standard-processors/controllers/JsonRecordSetWriter.h:
##
@@ -0,0 +1,93 @@
+/**
+* Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include "PropertyDefinitionBuilder.h"
+#include "Record.h"
+#include "controllers/RecordSetWriter.h"
+#include "core/FlowFile.h"
+#include "core/ProcessSession.h"
+#include "utils/Enum.h"
+
+namespace org::apache::nifi::minifi::standard {
+
+enum class OutputGroupingType {
+ Array,
+ OneLinePerObject
+};
+
+class JsonRecordSetWriter final : public core::RecordSetWriter {
+ public:
+ explicit JsonRecordSetWriter(const std::string& name, const
utils::Identifier& uuid = {});
+ explicit JsonRecordSetWriter(const std::string& name, const
std::shared_ptr& configuration);
+
+ JsonRecordSetWriter(JsonRecordSetWriter&&) = delete;
+ JsonRecordSetWriter(const JsonRecordSetWriter&) = delete;
+ JsonRecordSetWriter& operator=(JsonRecordSetWriter&&) = delete;
+ JsonRecordSetWriter& operator=(const JsonRecordSetWriter&) = delete;
+
+ ~JsonRecordSetWriter() override = default;
+
+ EXTENSIONAPI static constexpr const char* Description =
+ "Writes the results of a RecordSet as either a JSON Array or one JSON
object per line. "
+ "If using Array output, then even if the RecordSet consists of a single
row, it will be written as an array with a single element. "
+ "If using One Line Per Object output, the JSON objects cannot be
pretty-printed.";
+
+ EXTENSIONAPI static constexpr auto OutputGrouping =
core::PropertyDefinitionBuilder()>::createProperty("Output
Grouping")
+.withDescription("Specifies how the writer should output the JSON records
(as an array or one object per line, e.g.) "
+"Note that if 'One Line Per Object' is selected, then
Pretty Print JSON must be false.")
+.withDefaultValue(magic_enum::enum_name(OutputGroupingType::Array))
+.withAllowedValues(magic_enum::enum_names())
+.supportsExpressionLanguage(false)
+.isRequired(true)
+.build();
+
+ EXTENSIONAPI static constexpr auto PrettyPrint =
core::PropertyDefinitionBuilder<>::createProperty("Pretty Print JSON")
+.withDescription("Specifies whether or not the JSON should be pretty
printed")
Review Comment:
Good idea
https://github.com/apache/nifi-minifi-cpp/pull/1763/commits/c9aa16d7cd2ea2bd69e0345f365213f5a403cda2#diff-f10913418d7471adbf70fd555a46415f88c6cc031efb380861ab93d744c5c94dR76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-7085 add flowFile batching to ConsumeJMS and PublishJMS [nifi]
mosermw commented on PR #8584: URL: https://github.com/apache/nifi/pull/8584#issuecomment-2107769874 Rebased to account for nifi-nar-bundles moving to nifi-extension-bundles. Removed the JMSPublisherConsumerIT testMultipleThreads integration test fixes since that test itself was removed. This MR may not seem like an appealing change, but ConsumeJMS already supported batching messages when using a Record Reader/Writer. This MR promotes batching to be available in all configurations. And as a reminder this MR fixes an bug in JMSConsumer consumeMessageSet() where it could read then drop an extra message when batchCounter reaches MAX_MESSAGES_PER_FLOW_FILE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2311 Initial support for recordset readers and writers [nifi-minifi-cpp]
martinzink commented on code in PR #1763: URL: https://github.com/apache/nifi-minifi-cpp/pull/1763#discussion_r1598585523 ## extensions/standard-processors/controllers/JsonRecordSetReader.h: ## Review Comment: Good point. I've added JsonRecordSetReader and Writer to Controllers.md I like the idea of a how to recordset documentation but maybe thats out of the scope of this PR. I think we should address that if we feel the interface of the RecordSet is stable (multiple users of the RecordSet controllers to iron out the possible kinks) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12916) Develop an ExecutePythonScript Processor
[ https://issues.apache.org/jira/browse/NIFI-12916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12916: Fix Version/s: (was: 2.0.0-M3) > Develop an ExecutePythonScript Processor > > > Key: NIFI-12916 > URL: https://issues.apache.org/jira/browse/NIFI-12916 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 2.0.0-M2 >Reporter: Fredrick Eisele >Priority: Major > > Given the ability to create python processors in NiFi 2, and the presence of > ExecuteGroovyScript, development of an ExecutePythonScript processor seems > logical. > That said there will be differences due to differences between on the NiFi > Python and JVM support. > The first step is to outline what capabilities are or may be possible. > "The new native Python support in NiFi 2.0 provides a more streamlined API > for Processor implementation, as opposed to the full set of capabilities that > the Java Processor API provides. > This enables simplified Processor implementation, and streamlined > communication between Java and Python processes. > For that reason, a generic ExecutePythonScript would not provide all of the > same options as the generalized ExecuteGroovyScript." > Ref: > * > [https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx] > * > [https://nifi.apache.org/documentation/nifi-2.0.0-M2/html/python-developer-guide.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2311 Initial support for recordset readers and writers [nifi-minifi-cpp]
martinzink commented on code in PR #1763:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1763#discussion_r1598548222
##
extensions/standard-processors/tests/unit/JsonRecordTests.cpp:
##
@@ -0,0 +1,145 @@
+/**
+* Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.c
+ */
+
+#include
+#include
+
+#include "Catch.h"
+#include "RecordSetTesters.h"
+#include "TestBase.h"
+#include "TestRecord.h"
+#include "controllers/JsonRecordSetReader.h"
+#include "controllers/JsonRecordSetWriter.h"
+#include "core/Record.h"
+
+namespace org::apache::nifi::minifi::standard::test {
+
+constexpr std::string_view record_per_line_str =
R"({"baz":3.14,"qux":[true,false,true],"is_test":true,"bar":123,"quux":{"Aprikose":"apricot","Birne":"pear","Apfel":"apple"},"foo":"asd","when":"2012-07-01T09:53:00Z"}
+{"baz":3.141592653589793,"qux":[false,false,true],"is_test":true,"bar":98402134,"quux":{"Aprikose":"abricot","Birne":"poire","Apfel":"pomme"},"foo":"Lorem
ipsum dolor sit amet, consectetur adipiscing
elit.","when":"2022-11-01T19:52:11Z"}
+)";
+constexpr std::string_view array_compressed_str =
R"([{"baz":3.14,"qux":[true,false,true],"is_test":true,"bar":123,"quux":{"Aprikose":"apricot","Birne":"pear","Apfel":"apple"},"foo":"asd","when":"2012-07-01T09:53:00Z"},{"baz":3.141592653589793,"qux":[false,false,true],"is_test":true,"bar":98402134,"quux":{"Aprikose":"abricot","Birne":"poire","Apfel":"pomme"},"foo":"Lorem
ipsum dolor sit amet, consectetur adipiscing
elit.","when":"2022-11-01T19:52:11Z"}])";
+constexpr std::string_view array_pretty_str = R"([
+{
+"baz": 3.14,
+"qux": [
+true,
+false,
+true
+],
+"is_test": true,
+"bar": 123,
+"quux": {
+"Aprikose": "apricot",
+"Birne": "pear",
+"Apfel": "apple"
+},
+"foo": "asd",
+"when": "2012-07-01T09:53:00Z"
+},
+{
+"baz": 3.141592653589793,
+"qux": [
+false,
+false,
+true
+],
+"is_test": true,
+"bar": 98402134,
+"quux": {
+"Aprikose": "abricot",
+"Birne": "poire",
+"Apfel": "pomme"
+},
+"foo": "Lorem ipsum dolor sit amet, consectetur adipiscing elit.",
+"when": "2022-11-01T19:52:11Z"
+}
+])";
+
+bool test_json_equality(const std::string_view expected_str, const
std::string_view actual_str) {
+ rapidjson::Document expected;
+ expected.Parse(expected_str.data());
+ rapidjson::Document actual;
+ actual.Parse(actual_str.data());
+ return actual == expected;
+}
+
+TEST_CASE("JsonRecordSetWriter test Record Per Line") {
+ core::RecordSet record_set;
+ record_set.push_back(core::test::createSampleRecord());
+ record_set.push_back(core::test::createSampleRecord2());
+
+ JsonRecordSetWriter json_record_set_writer;
+ json_record_set_writer.initialize();
+
CHECK(json_record_set_writer.setProperty(JsonRecordSetWriter::OutputGrouping,
"OneLinePerObject"));
+ json_record_set_writer.onEnable();
+ CHECK(core::test::testRecordWriter(json_record_set_writer, record_set,
[](auto serialized_record_set) -> bool {
+return test_json_equality(record_per_line_str, serialized_record_set);
+ }));
+}
+
+TEST_CASE("JsonRecordSetWriter test array") {
+ core::RecordSet record_set;
+ record_set.push_back(core::test::createSampleRecord());
+ record_set.push_back(core::test::createSampleRecord2());
+
+ JsonRecordSetWriter json_record_set_writer;
+ CHECK(core::test::testRecordWriter(json_record_set_writer, record_set,
[](auto serialized_record_set) -> bool {
+return test_json_equality(array_compressed_str, serialized_record_set);
+ }));
+}
+
+TEST_CASE("JsonRecordSetWriter test pretty array") {
+ core::RecordSet record_set;
+ record_set.push_back(core::test::createSampleRecord());
+ record_set.push_back(core::test::createSampleRecord2());
+
+ JsonRecordSetWriter json_record_set_writer;
+ json_record_set_writer.initialize();
+ CHECK(json_record_set_writer.setProperty(JsonRecordSetWriter::PrettyPrint,
"true"));
+ json_record_set_writer.onEnable();
+ CHECK(core::test::testRecordWriter(json_record_set_writer, record_set,
Re: [PR] MINIFICPP-2311 Initial support for recordset readers and writers [nifi-minifi-cpp]
martinzink commented on code in PR #1763:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1763#discussion_r1598547186
##
extensions/standard-processors/controllers/JsonRecordSetReader.h:
##
@@ -0,0 +1,58 @@
+/**
+* Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include "Record.h"
+#include "controllers/RecordSetReader.h"
+#include "core/FlowFile.h"
+#include "core/ProcessSession.h"
+
+namespace org::apache::nifi::minifi::standard {
+
+class JsonRecordSetReader final : public core::RecordSetReader {
+ public:
+ explicit JsonRecordSetReader(const std::string& name, const
utils::Identifier& uuid = {});
+ explicit JsonRecordSetReader(const std::string& name, const
std::shared_ptr& configuration);
+
+ JsonRecordSetReader(JsonRecordSetReader&&) = delete;
+ JsonRecordSetReader(const JsonRecordSetReader&) = delete;
+ JsonRecordSetReader& operator=(JsonRecordSetReader&&) = delete;
+ JsonRecordSetReader& operator=(const JsonRecordSetReader&) = delete;
+
+ ~JsonRecordSetReader() override = default;
+
+ EXTENSIONAPI static constexpr const char* Description = "Parses JSON into
individual Record objects. "
+"While the reader expects each record to be well-formed JSON, the content
of a FlowFile may consist of many records, "
+"each as a well-formed JSON array or JSON object with optional whitespace
between them, such as the common 'JSON-per-line' format. "
+"If an array is encountered, each element in that array will be treated as
a separate record. "
+"If the schema that is configured contains a field that is not present in
the JSON, a null value will be used. "
+"If the JSON contains a field that is not present in the schema, that
field will be skipped.";
+
+
+ EXTENSIONAPI static constexpr bool SupportsDynamicProperties = false;
+ ADD_COMMON_VIRTUAL_FUNCTIONS_FOR_CONTROLLER_SERVICES
+
+ using RecordSetReader::RecordSetReader;
+
+ nonstd::expected read(const
std::shared_ptr& flow_file, core::ProcessSession& session)
override;
+
+ void yield() override {}
+ bool isRunning() const override {return getState() ==
core::controller::ControllerServiceState::ENABLED; }
Review Comment:
Not intentional thats for sure, fixed it in
https://github.com/apache/nifi-minifi-cpp/pull/1763/commits/c9aa16d7cd2ea2bd69e0345f365213f5a403cda2#diff-ec967d9d271148d68545eaaf57fa6506ac38db9525253959af285d2583e01b67L54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINIFICPP-2311 Initial support for recordset readers and writers [nifi-minifi-cpp]
martinzink commented on code in PR #1763:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1763#discussion_r1598546392
##
libminifi/test/RecordSetTesters.h:
##
@@ -0,0 +1,82 @@
+/**
+*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include "controllers/RecordSetReader.h"
+#include "controllers/RecordSetWriter.h"
+#include "core/Record.h"
+#include "TestBase.h"
+
+namespace org::apache::nifi::minifi::core::test {
+
+class RecordSetFixture {
+ public:
+ explicit RecordSetFixture(TestController::PlanConfig config = {}):
plan_config_(std::move(config)) {}
+
+ [[nodiscard]] ProcessSession& processSession() const { return
*process_session_; }
+
+ [[nodiscard]] const Relationship& getRelationship() const { return
relationship_; }
+ private:
+ TestController test_controller_{};
+ TestController::PlanConfig plan_config_{};
+ std::shared_ptr test_plan_ =
test_controller_.createPlan(plan_config_);
+ std::shared_ptr dummy_processor_ =
test_plan_->addProcessor("DummyProcessor", "dummyProcessor");
+ std::shared_ptr context_ = [this] {
test_plan_->runNextProcessor(); return test_plan_->getCurrentContext(); }();
+ std::unique_ptr process_session_ =
std::make_unique(context_);
+
+ const Relationship relationship_{"success", "description"};
+};
+
+bool testRecordWriter(RecordSetWriter& record_set_writer, const RecordSet&
record_set, auto tester) {
+ const RecordSetFixture fixture;
+ ProcessSession& process_session = fixture.processSession();
+
+ const auto flow_file = process_session.create();
+
+ record_set_writer.write(record_set, flow_file, process_session);
+ process_session.transfer(flow_file, fixture.getRelationship());
+ process_session.commit();
+ const auto input_stream =
process_session.getFlowFileContentStream(*flow_file);
+ std::array buffer{};
+ const auto buffer_size = input_stream->read(buffer);
+ const std::string flow_file_content(reinterpret_cast(buffer.data()),
buffer_size);
+
+ return tester(flow_file_content);
+}
+
+inline bool testRecordReader(RecordSetReader& record_set_reader, const
std::string_view serialized_record_set, const RecordSet& expected_record_set) {
+ const RecordSetFixture fixture;
+ ProcessSession& process_session = fixture.processSession();
+
+ const auto flow_file = process_session.create();
+ process_session.writeBuffer(flow_file, serialized_record_set);
+ process_session.transfer(flow_file, fixture.getRelationship());
+ process_session.commit();
+
+ const auto record_set = record_set_reader.read(flow_file, process_session);
+ if (!record_set)
+return false;
+ auto& record_set_0 = (*record_set)[0];
+ auto& expected_set_0 = expected_record_set[0];
+ CHECK(record_set_0 == expected_set_0);
Review Comment:
Its probably some leftover debugging code, removed it in
https://github.com/apache/nifi-minifi-cpp/pull/1763/commits/c9aa16d7cd2ea2bd69e0345f365213f5a403cda2#diff-405287f5b19cb14a6586eb31ccd3080ef179beac643489539f7f72dfbda002bfL75-L77
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (NIFI-13169) Upgrade NiFi Registry to Flyway DB 10.latest
[ https://issues.apache.org/jira/browse/NIFI-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-13169: --- Assignee: Matt Burgess > Upgrade NiFi Registry to Flyway DB 10.latest > > > Key: NIFI-13169 > URL: https://issues.apache.org/jira/browse/NIFI-13169 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Matt Burgess >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13219) Conduct Apache NiFi 2.0.0-M3 Release
David Handermann created NIFI-13219: --- Summary: Conduct Apache NiFi 2.0.0-M3 Release Key: NIFI-13219 URL: https://issues.apache.org/jira/browse/NIFI-13219 Project: Apache NiFi Issue Type: Task Reporter: David Handermann Assignee: David Handermann Fix For: 2.0.0-M3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13127) Support branch selection for registry providers that offer branching
[ https://issues.apache.org/jira/browse/NIFI-13127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13127: Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Support branch selection for registry providers that offer branching > > > Key: NIFI-13127 > URL: https://issues.apache.org/jira/browse/NIFI-13127 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > This is intended to be the UI portion of NIFI-13120. There is a Pull Request > available: [https://github.com/apache/nifi/pull/8726] > > Essentially what is needed is that the the registry client supports > branching, a new branch dropdown should be inserted between the registry > selection and the bucket selection. Changing the registry should reload the > branches, changing the branch should reload the buckets and so forth. > Impacted areas would be: > * Import from registry > * Start Version Control > * Change Version dialog - read only display of the branch > * Commit local changes dialog - read only display of the branch -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13127) Support branch selection for registry providers that offer branching
[ https://issues.apache.org/jira/browse/NIFI-13127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845931#comment-17845931 ] ASF subversion and git services commented on NIFI-13127: Commit 0c9ef91507e8c6b7b7f0994b1bb9897cd0701bbe in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0c9ef91507 ] NIFI-13127 Add branching support to Registry dialogs This closes #8817 Signed-off-by: David Handermann > Support branch selection for registry providers that offer branching > > > Key: NIFI-13127 > URL: https://issues.apache.org/jira/browse/NIFI-13127 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > This is intended to be the UI portion of NIFI-13120. There is a Pull Request > available: [https://github.com/apache/nifi/pull/8726] > > Essentially what is needed is that the the registry client supports > branching, a new branch dropdown should be inserted between the registry > selection and the bucket selection. Changing the registry should reload the > branches, changing the branch should reload the buckets and so forth. > Impacted areas would be: > * Import from registry > * Start Version Control > * Change Version dialog - read only display of the branch > * Commit local changes dialog - read only display of the branch -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13127] - Add branching support to registry dialogs [nifi]
exceptionfactory closed pull request #8817: [NIFI-13127] - Add branching support to registry dialogs URL: https://github.com/apache/nifi/pull/8817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12991) Can't switch to Standard execution engine if there is a child process group inheriting
[ https://issues.apache.org/jira/browse/NIFI-12991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12991: Fix Version/s: (was: 2.0.0-M3) > Can't switch to Standard execution engine if there is a child process group > inheriting > --- > > Key: NIFI-12991 > URL: https://issues.apache.org/jira/browse/NIFI-12991 > Project: Apache NiFi > Issue Type: Bug > Components: NiFi Stateless >Affects Versions: 2.0.0-M2 >Reporter: Gabriel Orstadius-Bui >Priority: Major > > If process group "A" has child process group "B" which inherits its parent's > (A's) execution engine, switching A's execution engine to Stateless is no > problem. > However, thereafter switching A's execution engine back to Standard leads to > this error message being shown: > "A Process Group using the Standard Engine may not be the child of a Process > Group using the Stateless Engine. Cannot set Execution Engine of > StandardProcessGroup[identifier=f406cf3a-018d-1000-42a3-6a708991aab7,name=B] > to Standard because it is a child of > StandardProcessGroup[identifier=e574e59b-018d-1000-530e-0a9db5c39a6e,name=A]" > It seems as if NiFi in this case first tries to switch B's execution engine > to standard, which is not allowed because A is still using the Standard > execution engine. In this case, NiFi should instead first change A's > execution engine and thereafter B's. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13218) API call for updating Reporting Task run status does not support "DISABLED" status
[
https://issues.apache.org/jira/browse/NIFI-13218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-13218:
Fix Version/s: (was: 2.0.0-M3)
> API call for updating Reporting Task run status does not support "DISABLED"
> status
> --
>
> Key: NIFI-13218
> URL: https://issues.apache.org/jira/browse/NIFI-13218
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 2.0.0-M2
>Reporter: Gabriel Orstadius-Bui
>Priority: Major
>
> Reporting Tasks can be RUNNING, STOPPED or DISABLED. However, the API call
> for updating the run status ({{{}PUT /reporting-tasks/\{id}/run-status){}}}
> does not support setting the status to DISABLED.
> The object ReportingTaskRunStatusEntity needs to support DISABLED (see
> ReportingTaskStatusDTO
> https://nifi.apache.org/documentation/nifi-2.0.0-M2/rest-api/index.html#ReportingTaskStatusDTO)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12992) Processor referencing controller service shown as invalid after switching to stateless execution engine
[ https://issues.apache.org/jira/browse/NIFI-12992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12992: Fix Version/s: (was: 2.0.0-M3) > Processor referencing controller service shown as invalid after switching to > stateless execution engine > --- > > Key: NIFI-12992 > URL: https://issues.apache.org/jira/browse/NIFI-12992 > Project: Apache NiFi > Issue Type: Bug > Components: NiFi Stateless >Affects Versions: 2.0.0-M2 >Reporter: Gabriel Orstadius-Bui >Priority: Major > > How to reproduce: > # A processor and a controller service referenced by the processor are both > within a process group using the standard execution engine. The controller > service is disabled and the processor is therefore displayed as invalid in > the diagram. > # Switch the process group's execution engine to Stateless. > # The processor is incorrectly still displayed as invalid in the diagram. > # Quickly opening the processor's configurations will still display the > processor as invalid within the pop-up dialog. > # Waiting for a few seconds and then (re-)opening the processor's > configurations will then correctly show the processor as valid (just > stopped). Going back to the diagram will then also display the processor as > valid. > # (Switching back to standard will conversely incorrectly display the > processor as valid until waiting for a few seconds and opening its > configurations) > In other words, it seems as if there is a long window of time after switching > execution engine in which NiFi does not take the new execution engine into > consideration when validating processors. > Ideally, the validation should correctly validate the processors right after > switching the execution engine and display them as valid/invalid accordingly > in the diagram. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12992) Processor referencing controller service shown as invalid after switching to stateless execution engine
[ https://issues.apache.org/jira/browse/NIFI-12992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Orstadius-Bui updated NIFI-12992: - Fix Version/s: 2.0.0-M3 > Processor referencing controller service shown as invalid after switching to > stateless execution engine > --- > > Key: NIFI-12992 > URL: https://issues.apache.org/jira/browse/NIFI-12992 > Project: Apache NiFi > Issue Type: Bug > Components: NiFi Stateless >Affects Versions: 2.0.0-M2 >Reporter: Gabriel Orstadius-Bui >Priority: Major > Fix For: 2.0.0-M3 > > > How to reproduce: > # A processor and a controller service referenced by the processor are both > within a process group using the standard execution engine. The controller > service is disabled and the processor is therefore displayed as invalid in > the diagram. > # Switch the process group's execution engine to Stateless. > # The processor is incorrectly still displayed as invalid in the diagram. > # Quickly opening the processor's configurations will still display the > processor as invalid within the pop-up dialog. > # Waiting for a few seconds and then (re-)opening the processor's > configurations will then correctly show the processor as valid (just > stopped). Going back to the diagram will then also display the processor as > valid. > # (Switching back to standard will conversely incorrectly display the > processor as valid until waiting for a few seconds and opening its > configurations) > In other words, it seems as if there is a long window of time after switching > execution engine in which NiFi does not take the new execution engine into > consideration when validating processors. > Ideally, the validation should correctly validate the processors right after > switching the execution engine and display them as valid/invalid accordingly > in the diagram. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13218) API call for updating Reporting Task run status does not support "DISABLED" status
Gabriel Orstadius-Bui created NIFI-13218:
Summary: API call for updating Reporting Task run status does not
support "DISABLED" status
Key: NIFI-13218
URL: https://issues.apache.org/jira/browse/NIFI-13218
Project: Apache NiFi
Issue Type: Bug
Components: Core Framework
Affects Versions: 2.0.0-M2
Reporter: Gabriel Orstadius-Bui
Fix For: 2.0.0-M3
Reporting Tasks can be RUNNING, STOPPED or DISABLED. However, the API call for
updating the run status ({{{}PUT /reporting-tasks/\{id}/run-status){}}} does
not support setting the status to DISABLED.
The object ReportingTaskRunStatusEntity needs to support DISABLED (see
ReportingTaskStatusDTO
https://nifi.apache.org/documentation/nifi-2.0.0-M2/rest-api/index.html#ReportingTaskStatusDTO)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12991) Can't switch to Standard execution engine if there is a child process group inheriting
[ https://issues.apache.org/jira/browse/NIFI-12991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Orstadius-Bui updated NIFI-12991: - Fix Version/s: 2.0.0-M3 > Can't switch to Standard execution engine if there is a child process group > inheriting > --- > > Key: NIFI-12991 > URL: https://issues.apache.org/jira/browse/NIFI-12991 > Project: Apache NiFi > Issue Type: Bug > Components: NiFi Stateless >Affects Versions: 2.0.0-M2 >Reporter: Gabriel Orstadius-Bui >Priority: Major > Fix For: 2.0.0-M3 > > > If process group "A" has child process group "B" which inherits its parent's > (A's) execution engine, switching A's execution engine to Stateless is no > problem. > However, thereafter switching A's execution engine back to Standard leads to > this error message being shown: > "A Process Group using the Standard Engine may not be the child of a Process > Group using the Stateless Engine. Cannot set Execution Engine of > StandardProcessGroup[identifier=f406cf3a-018d-1000-42a3-6a708991aab7,name=B] > to Standard because it is a child of > StandardProcessGroup[identifier=e574e59b-018d-1000-530e-0a9db5c39a6e,name=A]" > It seems as if NiFi in this case first tries to switch B's execution engine > to standard, which is not allowed because A is still using the Standard > execution engine. In this case, NiFi should instead first change A's > execution engine and thereafter B's. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12888 In AbstractEmailProcessor recreate email receiver when token expires. [nifi]
AnTu2702 commented on PR #8494: URL: https://github.com/apache/nifi/pull/8494#issuecomment-2106900968 @tpalfy Hey. How are you? First of all: Thanks for the fix/workaround in NIFI 1.26. Although things are basically working there, we still don't seem to be through. The ConsumeIMAP Processor is continuously logging this ERROR... (although the mailbox can and will be processed successfully using a refreshed token...)  We still have serious doubts to take this into production because of the log being spammed and of course the fact, that we have no clue, what causes this error. Could you help and double check your fix/workaround? Thank you in advance... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12224: Add support for updateMany operation with operators enabled option in `PutMongo` processor [nifi]
umarhussain15 commented on code in PR #8610:
URL: https://github.com/apache/nifi/pull/8610#discussion_r1597988711
##
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java:
##
@@ -127,20 +153,17 @@ public class PutMongo extends AbstractMongoProcessor {
private final static List propertyDescriptors;
static {
-List _propertyDescriptors = new ArrayList<>();
-_propertyDescriptors.addAll(descriptors);
+ List _propertyDescriptors = new
ArrayList<>(descriptors);
_propertyDescriptors.add(MODE);
_propertyDescriptors.add(UPSERT);
_propertyDescriptors.add(UPDATE_QUERY_KEY);
_propertyDescriptors.add(UPDATE_QUERY);
-_propertyDescriptors.add(UPDATE_MODE);
+_propertyDescriptors.add(UPDATE_OPERATION_MODE);
+_propertyDescriptors.add(MONGO_UPDATE_MODE);
_propertyDescriptors.add(CHARACTER_SET);
propertyDescriptors =
Collections.unmodifiableList(_propertyDescriptors);
-final Set _relationships = new HashSet<>();
-_relationships.add(REL_SUCCESS);
-_relationships.add(REL_FAILURE);
-relationships = Collections.unmodifiableSet(_relationships);
+ relationships = Set.of(REL_SUCCESS, REL_FAILURE);
Review Comment:
The ticket description says that currently the behavior of the processor is
not clearly documented (where it uses `updateOne` and user might be expecting
`updateMany`), so I think it's a bug fix. For bug fixes, we usually do a
backport as well? I will then raise another pull request for 1.x branch and
keep these changes for main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12224: Add support for updateMany operation with operators enabled option in `PutMongo` processor [nifi]
umarhussain15 commented on code in PR #8610:
URL: https://github.com/apache/nifi/pull/8610#discussion_r1597988711
##
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java:
##
@@ -127,20 +153,17 @@ public class PutMongo extends AbstractMongoProcessor {
private final static List propertyDescriptors;
static {
-List _propertyDescriptors = new ArrayList<>();
-_propertyDescriptors.addAll(descriptors);
+ List _propertyDescriptors = new
ArrayList<>(descriptors);
_propertyDescriptors.add(MODE);
_propertyDescriptors.add(UPSERT);
_propertyDescriptors.add(UPDATE_QUERY_KEY);
_propertyDescriptors.add(UPDATE_QUERY);
-_propertyDescriptors.add(UPDATE_MODE);
+_propertyDescriptors.add(UPDATE_OPERATION_MODE);
+_propertyDescriptors.add(MONGO_UPDATE_MODE);
_propertyDescriptors.add(CHARACTER_SET);
propertyDescriptors =
Collections.unmodifiableList(_propertyDescriptors);
-final Set _relationships = new HashSet<>();
-_relationships.add(REL_SUCCESS);
-_relationships.add(REL_FAILURE);
-relationships = Collections.unmodifiableSet(_relationships);
+ relationships = Set.of(REL_SUCCESS, REL_FAILURE);
Review Comment:
The ticket description says that currently the behavior of the processor is
not clearly documented, so I think it's a bug fix. For bug fixes, we usually do
a backport as well? I will then raise another pull request for 1.x branch and
keep these changes for main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11107 In ConsumeIMAP and ConsumePOP3 added support for OAUTH based authorization. [nifi]
AnTu2702 commented on PR #6900: URL: https://github.com/apache/nifi/pull/6900#issuecomment-2106808373 @tpalfy Hey. How are you? First of all: Thanks for the fix/workaround in NIFI 1.26. Although things are basically working there, we still don't seem to be through. The ConsumeIMAP Processor is continuously logging this ERROR... (although the mailbox can and will be processed successfully using a refreshed token...)  We still have serious doubts to take this into production because of the log being spammed and of course the fact, that we have no clue, that causes this error. Could you help and double check your fix/workaround? Thank you in advance... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
