Re: [PR] MINIFICPP-2346-P1: Integrated Conan2 for OpenSSL, CURL, ZLIB & Build MiNiFi [nifi-minifi-cpp]
james94 commented on PR #1793: URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#issuecomment-2123815671 @szaszm If I get access to a macOS, I can looking into fixing the linter issue in the conanfile. Currently, I am testing MiNiFi from Ubuntu 22.04. I can later test it in Windows too if needed. For now, I addressed @martinzink suggested updates for integrating conan into MiNiFi build infrastructure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2346-P1: Integrated Conan2 for OpenSSL, CURL, ZLIB & Build MiNiFi [nifi-minifi-cpp]
james94 commented on code in PR #1793: URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1609216217 ## cmake/BundledZLIB.cmake: ## @@ -18,56 +18,65 @@ function(use_bundled_zlib SOURCE_DIR BINARY_DIR) Review Comment: I incorporated your feedback into commit [cf2face](https://github.com/apache/nifi-minifi-cpp/pull/1793/commits/cf2facee3a1ecc2909d439a4fe9cd1ca60830617) I do like your suggestion, it makes the MiNiFi CMake code look cleaner with the conan v2.3.1 integration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2346-P1: Integrated Conan2 for OpenSSL, CURL, ZLIB & Build MiNiFi [nifi-minifi-cpp]
james94 commented on code in PR #1793: URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1609215848 ## cmake/MiNiFiOptions.cmake: ## @@ -42,6 +42,8 @@ add_minifi_option(DOCKER_SKIP_TESTS "Skip building tests in docker image targets add_minifi_option(DOCKER_PUSH "Push created images to the specified tags" OFF) add_minifi_option(PORTABLE "Instructs the compiler to remove architecture specific optimizations" ON) +add_minifi_option(USE_CONAN_PACKAGER "Instructs cmake to use conan packager to install external libs & build MiNiFi C++" OFF) Review Comment: I incorporated your feedback into commit [cf2face](https://github.com/apache/nifi-minifi-cpp/pull/1793/commits/cf2facee3a1ecc2909d439a4fe9cd1ca60830617) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13281) Changing process group concurrency/outbound policy while data is within the group appears to result in stuck flow files
Joe Witt created NIFI-13281: --- Summary: Changing process group concurrency/outbound policy while data is within the group appears to result in stuck flow files Key: NIFI-13281 URL: https://issues.apache.org/jira/browse/NIFI-13281 Project: Apache NiFi Issue Type: Bug Affects Versions: 2.0.0-M3, 1.26.0 Reporter: Joe Witt Attachments: DATFLOW_TO_REPRODUCE_ISSUE.json Ravinarayan Singh on slack shared the attached flow. And the described steps Step to reproduce: 1. Upload the attached Flow 2. Start the flow 3. Stop the Flow and Configure the TEST processor with following: Process Group FlowFile Concurrency: Single FlowFile Per Node Process Group Outbound Policy: Batch Output 3. Start the flow ,Now flow file will be stuck I just did the same process on the latest codebase and I do see the behavior. I tried using a different sequence of steps such as 1. Upload attached flow 2. Stop the Flow and Configure the TEST processor with following: Process Group FlowFile Concurrency: Single FlowFile Per Node Process Group Outbound Policy: Batch Output 3. Start the Flow 4. Stop the flow 5. start the flow And that sequence worked fine. So I am thinking what happens is that changing concurrency/outbound policy when the flow is stopped but has data in it leads to a weird condition possibly that then results in stuck flow files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13257] codemirror light and dark mode theme [nifi]
scottyaslan commented on code in PR #8855: URL: https://github.com/apache/nifi/pull/8855#discussion_r1608970556 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_codemirror-theme.scss: ## Review Comment: https://discuss.codemirror.net/t/help-plz-issue-with-small-white-flickering-input-box-when-codemirror-react-component-first-renders/3942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13247] - Property Verification [nifi]
mcgilman commented on code in PR #8857:
URL: https://github.com/apache/nifi/pull/8857#discussion_r1608849065
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/ui/flow-analysis-rules/edit-flow-analysis-rule/edit-flow-analysis-rule.component.ts:
##
@@ -75,6 +78,10 @@ export class EditFlowAnalysisRule extends
CloseOnEscapeDialog {
@Input() createNewService!: (request: InlineServiceCreationRequest) =>
Observable;
@Input() saving$!: Observable;
@Input() goToService!: (serviceId: string) => void;
+@Input() propertyVerificationResults$!:
Observable;
+@Input() propertyVerificationStatus$: Observable<'pending' | 'loading' |
'success'> = of('pending');
+
+@Output() verify: EventEmitter = new EventEmitter();
Review Comment:
Can we use `FlowAnalysisRuleEntity` instead of `any`?
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/processor/edit-processor/edit-processor.component.html:
##
@@ -249,6 +250,12 @@
[supportsSensitiveDynamicProperties]="
request.entity.component.supportsSensitiveDynamicProperties
">
+ void;
@Input() goToReferencingComponent!: (component:
ControllerServiceReferencingComponent) => void;
@Input() saving$!: Observable;
+@Input() propertyVerificationResults$!:
Observable;
+@Input() propertyVerificationStatus$: Observable<'pending' | 'loading' |
'success'> = of('pending');
+
+@Output() verify: EventEmitter = new EventEmitter();
Review Comment:
Can we use `ReportingTaskEntity` instead of `any`?
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/property-table/property-table.component.ts:
##
@@ -114,6 +114,8 @@ export class PropertyTable implements AfterViewInit,
ControlValueAccessor {
@Input() goToService!: (serviceId: string) => void;
@Input() supportsSensitiveDynamicProperties = false;
@Input() propertyHistory: ComponentHistory | undefined;
+@Input() supportsParameters: boolean = true;
+@Input() forReferencedAttributes: boolean = false;
Review Comment:
I don't think the changes introduced here for the `forReferencedAttributes`
Input are being used. Assuming that is the case, we should be able to revert
the changes in the `PropertyTable` component.
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/property-verification/common/referenced-attributes-dialog/referenced-attributes-dialog.component.ts:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, EventEmitter, Inject, Input, Output } from '@angular/core';
+import { CommonModule } from '@angular/common';
+import {
+MAT_DIALOG_DATA,
+MatDialogActions,
+MatDialogClose,
+MatDialogContent,
+MatDialogTitle
+} from '@angular/material/dialog';
+import { FormBuilder, FormControl, FormGroup, ReactiveFormsModule } from
'@angular/forms';
+import { Observable } from 'rxjs';
+import { MapTableEntry } from '../../../../../state/shared';
+import { MatButton, MatIconButton } from '@angular/material/button';
+import { NifiSpinnerDirective } from '../../../spinner/nifi-spinner.directive';
+import { MapTable } from '../../../map-table/map-table.component';
+import { NifiTooltipDirective } from
'../../../tooltips/nifi-tooltip.directive';
+import { TextTip } from '../../../tooltips/text-tip/text-tip.component';
+import { CloseOnEscapeDialog } from
'../../../close-on-escape-dialog/close-on-escape-dialog.component';
+
+export interface ReferencedAttributesDialogData {
+attributes: MapTableEntry[];
+}
+
+@Component({
+selector: 'referenced-attributes-dialog',
+standalone: true,
+imports: [
+CommonModule,
+MatDialogTitle,
+ReactiveFormsModule,
+MatDialogContent,
+MatDialogActions,
+MatButton,
+MatDialogClose,
+NifiSpinnerDirective,
+MapTable,
+NifiTooltipDirective,
+
Re: [PR] [NIFI-13257] codemirror light and dark mode theme [nifi]
rfellows commented on code in PR #8855: URL: https://github.com/apache/nifi/pull/8855#discussion_r1608930171 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_codemirror-theme.scss: ## Review Comment: I logged this JIRA for it: https://issues.apache.org/jira/browse/NIFI-13280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13280) Odd flashing of a text input when opening the property value editor
Rob Fellows created NIFI-13280: -- Summary: Odd flashing of a text input when opening the property value editor Key: NIFI-13280 URL: https://issues.apache.org/jira/browse/NIFI-13280 Project: Apache NiFi Issue Type: Sub-task Reporter: Rob Fellows Attachments: flash.gif, image-2024-05-21-16-43-28-160.png There is a flash of what appears to be a text box when opening the editor !image-2024-05-21-16-43-28-160.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13279) Question about monitoring heap usage in a default no flow NiFi instance.
[ https://issues.apache.org/jira/browse/NIFI-13279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13279: Summary: Question about monitoring heap usage in a default no flow NiFi instance. (was: Memory Leak in fresh=empty NiFi 2.0.0.M3) > Question about monitoring heap usage in a default no flow NiFi instance. > > > Key: NIFI-13279 > URL: https://issues.apache.org/jira/browse/NIFI-13279 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0-M3 > Environment: Ubuntu 22.04 >Reporter: Alex Stanfield >Priority: Major > Attachments: nifi_memory_leak.png > > > I have just installed the last version of NiFi, the system is literally OOB > totally empty. However the system look like it's leaking memory and resetting > or recovering it's heap over and over again. Please see attachment. > > Any suggestions are welcome. > > Thanks > Alex -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13279) Memory Leak in fresh=empty NiFi 2.0.0.M3
[ https://issues.apache.org/jira/browse/NIFI-13279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848379#comment-17848379 ] Joe Witt commented on NIFI-13279: - [~alexs]That graph just shows nifi as a JVM app creating resources on the heap/waiting to do stuff, and then the heap cleaning up. This is, barring any additional information, very normal behavior. A sign of a leak would look a lot more like a graph that is slowly but surely moving up and to the right. This is just up/clean/down,repeat. If you use the application you'll see a similar pattern but the floor will be higher since indeed some data will be retained. You should be in good shape. Not saying it isn't possible there is a memory leak but I am saying this does not indicate one. > Memory Leak in fresh=empty NiFi 2.0.0.M3 > > > Key: NIFI-13279 > URL: https://issues.apache.org/jira/browse/NIFI-13279 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0-M3 > Environment: Ubuntu 22.04 >Reporter: Alex Stanfield >Priority: Major > Attachments: nifi_memory_leak.png > > > I have just installed the last version of NiFi, the system is literally OOB > totally empty. However the system look like it's leaking memory and resetting > or recovering it's heap over and over again. Please see attachment. > > Any suggestions are welcome. > > Thanks > Alex -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-13279) Memory Leak in fresh=empty NiFi 2.0.0.M3
[ https://issues.apache.org/jira/browse/NIFI-13279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt resolved NIFI-13279. - Resolution: Information Provided > Memory Leak in fresh=empty NiFi 2.0.0.M3 > > > Key: NIFI-13279 > URL: https://issues.apache.org/jira/browse/NIFI-13279 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0-M3 > Environment: Ubuntu 22.04 >Reporter: Alex Stanfield >Priority: Major > Attachments: nifi_memory_leak.png > > > I have just installed the last version of NiFi, the system is literally OOB > totally empty. However the system look like it's leaking memory and resetting > or recovering it's heap over and over again. Please see attachment. > > Any suggestions are welcome. > > Thanks > Alex -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13279) Memory Leak in fresh=empty NiFi 2.0.0.M3
[ https://issues.apache.org/jira/browse/NIFI-13279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13279: Fix Version/s: (was: 2.0.0-M3) > Memory Leak in fresh=empty NiFi 2.0.0.M3 > > > Key: NIFI-13279 > URL: https://issues.apache.org/jira/browse/NIFI-13279 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0-M3 > Environment: Ubuntu 22.04 >Reporter: Alex Stanfield >Priority: Major > Attachments: nifi_memory_leak.png > > > I have just installed the last version of NiFi, the system is literally OOB > totally empty. However the system look like it's leaking memory and resetting > or recovering it's heap over and over again. Please see attachment. > > Any suggestions are welcome. > > Thanks > Alex -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13279) Memory Leak in fresh=empty NiFi 2.0.0.M3
Alex Stanfield created NIFI-13279: - Summary: Memory Leak in fresh=empty NiFi 2.0.0.M3 Key: NIFI-13279 URL: https://issues.apache.org/jira/browse/NIFI-13279 Project: Apache NiFi Issue Type: Bug Components: Configuration Affects Versions: 2.0.0-M3 Environment: Ubuntu 22.04 Reporter: Alex Stanfield Fix For: 2.0.0-M3 Attachments: nifi_memory_leak.png I have just installed the last version of NiFi, the system is literally OOB totally empty. However the system look like it's leaking memory and resetting or recovering it's heap over and over again. Please see attachment. Any suggestions are welcome. Thanks Alex -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13257] codemirror light and dark mode theme [nifi]
scottyaslan commented on code in PR #8855: URL: https://github.com/apache/nifi/pull/8855#discussion_r1608886029 ## nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_codemirror-theme.scss: ## Review Comment: Yes let's file a separate task for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13257] codemirror light and dark mode theme [nifi]
scottyaslan commented on code in PR #8855:
URL: https://github.com/apache/nifi/pull/8855#discussion_r1608884798
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_codemirror-theme.scss:
##
@@ -0,0 +1,227 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+@use 'sass:map';
+@use '@angular/material' as mat;
+
+@mixin generate-nifi-theme($material-theme, $nifi-theme) {
+// Get the color config from the theme.
+$material-theme-color-config: mat.get-color-config($material-theme);
+$nifi-theme-color-config: mat.get-color-config($nifi-theme);
+
+// Get the color palette from the color-config.
+$material-theme-primary-palette: map.get($material-theme-color-config,
'primary');
+$nifi-theme-surface-palette: map.get($nifi-theme-color-config, 'primary');
+$material-theme-accent-palette: map.get($material-theme-color-config,
'accent');
+
+// Get hues from palette
+$is-dark: map-get($nifi-theme-color-config, is-dark);
+
+$material-theme-primary-palette-lighter:
mat.get-color-from-palette($material-theme-primary-palette, lighter);
+$material-theme-primary-palette-darker:
mat.get-color-from-palette($material-theme-primary-palette, darker);
+$material-theme-primary-palette-default:
mat.get-color-from-palette($material-theme-primary-palette, default);
+
+$nifi-theme-surface-palette-default:
mat.get-color-from-palette($nifi-theme-surface-palette, default);
+$nifi-theme-surface-palette-lighter:
mat.get-color-from-palette($nifi-theme-surface-palette, lighter);
+$nifi-theme-surface-palette-darker:
mat.get-color-from-palette($nifi-theme-surface-palette, darker);
+$nifi-theme-surface-palette-darker-contrast: mat.get-color-from-palette(
+$nifi-theme-surface-palette,
+darker-contrast
+);
+$nifi-theme-surface-palette-lighter-contrast: mat.get-color-from-palette(
+$nifi-theme-surface-palette,
+lighter-contrast
+);
+
+.cm-s-nifi.CodeMirror {
+@extend .surface-contrast;
+background-color: if($is-dark, $nifi-theme-surface-palette-darker,
$nifi-theme-surface-palette-lighter);
+border: 1px solid var(--mdc-outlined-text-field-label-text-color);
+}
+
+.cm-s-nifi .CodeMirror-gutters {
+background: if($is-dark, #3b3b3b, #efefef);
+}
+
+.cm-s-nifi .CodeMirror-guttermarker,
+.cm-s-nifi .CodeMirror-guttermarker-subtle,
+.cm-s-nifi .CodeMirror-linenumber {
+color: if($is-dark, #bb, #b4b4b4);
+}
+
+.cm-s-nifi .CodeMirror-cursor {
+border-left: 1px solid
+if($is-dark, $nifi-theme-surface-palette-darker-contrast,
$nifi-theme-surface-palette-lighter-contrast);
+}
+
+.cm-s-nifi div.CodeMirror-selected {
+background: if(
+$is-dark,
+rgba($material-theme-primary-palette-default, 0.4),
+rgba($material-theme-primary-palette-darker, 0.4)
+);
+}
+
+.cm-s-nifi.CodeMirror-focused div.CodeMirror-selected {
+background: if(
+$is-dark,
+rgba($material-theme-primary-palette-default, 0.4),
+rgba($material-theme-primary-palette-darker, 0.4)
+);
+}
+
+.cm-s-nifi .CodeMirror-line::selection,
+.cm-s-nifi .CodeMirror-line > span::selection,
+.cm-s-nifi .CodeMirror-line > span > span::selection {
+background: if($is-dark, rgba(128, 203, 196, 0.2), rgba(128, 203, 196,
0.8));
+}
+
+.cm-s-nifi .CodeMirror-line::-moz-selection,
+.cm-s-nifi .CodeMirror-line > span::-moz-selection,
+.cm-s-nifi .CodeMirror-line > span > span::-moz-selection {
+background: if($is-dark, rgba(128, 203, 196, 0.2), rgba(128, 203, 196,
0.8));
+}
+
+.cm-s-nifi .cm-header {
+color: if($is-dark, #b8b8ff, #ff);
+}
+
+.cm-s-nifi .cm-quote {
+color: if($is-dark, #6bfd6b, #009400);
+}
+
+.cm-s-nifi .cm-negative {
+color: if($is-dark, #fc9797, #de3535);
+}
+
+.cm-s-nifi .cm-positive {
+color: if($is-dark, #8cfd8c, #219a21);
+}
+
+.cm-s-nifi .cm-bracket {
+color: if($is-dark, #93937c, #93937c);
+}
+
+
[jira] [Resolved] (MINIFICPP-2312) Do not return shared_ptrs unnecessarily in ControllerServiceMap and ControllerServiceNode
[
https://issues.apache.org/jira/browse/MINIFICPP-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi resolved MINIFICPP-2312.
--
Fix Version/s: 0.99.1
Resolution: Fixed
> Do not return shared_ptrs unnecessarily in ControllerServiceMap and
> ControllerServiceNode
> -
>
> Key: MINIFICPP-2312
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2312
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Ferenc Gerlits
>Assignee: Ferenc Gerlits
>Priority: Minor
> Fix For: 0.99.1
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> There are several functions in and around Controller Service storage which
> return shared_ptr's, probably unnecessarily. For example,
> {noformat}
> ControllerServiceMap::getAllControllerServices()
> ControllerServiceNode::getControllerServiceImplementation();
> ControllerServiceNode::getLinkedControllerServices();
> ControllerServiceNode::getLinkedComponents();
> {noformat}
> Check if these function can return non-owning, possibly const, possibly
> gsl::not_null, pointers instead of shared_ptrs, and if it is possible, then
> change them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2381) Python bootstrap fails to start with python 3.12
[
https://issues.apache.org/jira/browse/MINIFICPP-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi resolved MINIFICPP-2381.
--
Fix Version/s: 0.99.1
Resolution: Fixed
> Python bootstrap fails to start with python 3.12
>
>
> Key: MINIFICPP-2381
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2381
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Major
> Fix For: 0.99.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This results in a CI failure on MacOS:
> {code:java}
> Traceback (most recent call last):
> 50 File
> "/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/main.py", line
> 20, in
> 51from cli import main_menu, do_one_click_build
> 52 File
> "/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/cli.py", line
> 18, in
> 53import inquirer
> 54 File
> "/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/inquirer/__init__.py",
> line 1, in
> 55from inquirer.prompt import prompt
> 56 File
> "/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/inquirer/prompt.py",
> line 2, in
> 57from inquirer.render.console import ConsoleRender
> 58 File
> "/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/inquirer/render/__init__.py",
> line 1, in
> 59from inquirer.render.console import ConsoleRender
> 60 File
> "/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/inquirer/render/console/__init__.py",
> line 10, in
> 61from inquirer.render.console._editor import Editor
> 62 File
> "/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/inquirer/render/console/_editor.py",
> line 1, in
> 63import editor
> 64 File
> "/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/editor.py",
> line 11, in
> 65from distutils.spawn import find_executable
> 66ModuleNotFoundError: No module named 'distutils' {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2358) Skip File permission tests while running as root
[ https://issues.apache.org/jira/browse/MINIFICPP-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2358: - Fix Version/s: 0.99.1 Resolution: Fixed Status: Resolved (was: Patch Available) > Skip File permission tests while running as root > > > Key: MINIFICPP-2358 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2358 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: 0.15.0, 0.99.0 >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Trivial > Fix For: 0.99.1 > > Time Spent: 40m > Remaining Estimate: 0h > > Currently FileStreamTests, FileSystemRepositoryTests and FetchFileTests fail > while running as a root. > The reason is that the tests expect that some of their actions will fail due > to insufficient permission, but they succeed as root. > We should probably skip these tests while running as root (maybe issue a > warning that these tests are skipped) so there are no false test failures. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2338) Move ExecuteProcess out of standard processors
[ https://issues.apache.org/jira/browse/MINIFICPP-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2338: - Fix Version/s: 0.99.1 Resolution: Fixed Status: Resolved (was: Patch Available) > Move ExecuteProcess out of standard processors > -- > > Key: MINIFICPP-2338 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2338 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Major > Fix For: 0.99.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2345) Upgrade CI matrix
[ https://issues.apache.org/jira/browse/MINIFICPP-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2345: - Fix Version/s: 0.99.1 Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade CI matrix > - > > Key: MINIFICPP-2345 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2345 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Major > Fix For: 0.99.1 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > We should move to rockylinux 8 from centos 7 > we should move from macos13 to macos14 (its ARM), and we should try to build > rockylinux from the mac runner -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2358 Skip File permission tests while running as root [nifi-minifi-cpp]
lordgamez closed pull request #1789: MINIFICPP-2358 Skip File permission tests while running as root URL: https://github.com/apache/nifi-minifi-cpp/pull/1789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2338 Move out ExecuteProcess from standard processors [nifi-minifi-cpp]
lordgamez closed pull request #1788: MINIFICPP-2338 Move out ExecuteProcess from standard processors URL: https://github.com/apache/nifi-minifi-cpp/pull/1788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2345 Upgrade CI matrix [nifi-minifi-cpp]
lordgamez closed pull request #1776: MINIFICPP-2345 Upgrade CI matrix URL: https://github.com/apache/nifi-minifi-cpp/pull/1776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-13277) Compact the main menu
[ https://issues.apache.org/jira/browse/NIFI-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman resolved NIFI-13277. Fix Version/s: 2.0.0-M4 Resolution: Fixed > Compact the main menu > - > > Key: NIFI-13277 > URL: https://issues.apache.org/jira/browse/NIFI-13277 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M4 > > Attachments: Screenshot 2024-05-21 at 1.05.17 PM.png, > image-2024-05-21-13-05-27-035.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > The main menu has much padding. it makes it so large that on smaller > resolutions the whole menu doesn't fit > !image-2024-05-21-13-05-27-035.png|width=868,height=508! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13277) Compact the main menu
[ https://issues.apache.org/jira/browse/NIFI-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848346#comment-17848346 ] ASF subversion and git services commented on NIFI-13277: Commit f625d4c6c15d3dc2f79c4e60febce2c30d408bca in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f625d4c6c1 ] [NIFI-13277] - Make the main menu more compact in terms of spacing. (#8861) This closes #8861 > Compact the main menu > - > > Key: NIFI-13277 > URL: https://issues.apache.org/jira/browse/NIFI-13277 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-05-21 at 1.05.17 PM.png, > image-2024-05-21-13-05-27-035.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > The main menu has much padding. it makes it so large that on smaller > resolutions the whole menu doesn't fit > !image-2024-05-21-13-05-27-035.png|width=868,height=508! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13277] - Make the main menu more compact in terms of spacing. [nifi]
mcgilman merged PR #8861: URL: https://github.com/apache/nifi/pull/8861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1608824023
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/PCAP.java:
##
@@ -0,0 +1,161 @@
+// MIT License
+
+// Copyright (c) 2015-2023 Kaitai Project
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to
deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+
+// The above copyright notice and this permission notice shall be included in
all
+// copies or substantial portions of the Software.
+
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE
+// SOFTWARE.
+
+package org.apache.nifi.processors.network.pcap;
+
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * PCAP (named after libpcap / winpcap) is a popular format for saving
+ * network traffic grabbed by network sniffers. It is typically
+ * produced by tools like [tcpdump](https://www.tcpdump.org/;>...) or
+ * [Wireshark](https://www.wireshark.org/;>...).
+ *
+ * @see https://wiki.wireshark.org/Development/LibpcapFileFormat;>Source
+ */
+public class PCAP {
+private ByteBufferInterface io;
+
+public PCAP(ByteBufferInterface io) {
+this(io, null, null);
+}
+
+public PCAP(ByteBufferInterface io, Object parent, PCAP root) {
+
+this.parent = parent;
+this.root = root == null ? this : root;
+this.io = io;
+read();
+}
+
+public PCAP(Header hdr, List packets) {
+this.hdr = hdr;
+this.packets = packets;
+}
+
+public byte[] readBytesFull() {
+
+int headerBufferSize = 20 + this.hdr().magicNumber().length;
+ByteBuffer headerBuffer = ByteBuffer.allocate(headerBufferSize);
+headerBuffer.order(ByteOrder.LITTLE_ENDIAN);
+
+headerBuffer.put(this.hdr().magicNumber());
+headerBuffer.put(this.readIntToNBytes(this.hdr().versionMajor(), 2,
false));
+headerBuffer.put(this.readIntToNBytes(this.hdr().versionMinor(), 2,
false));
+headerBuffer.put(this.readIntToNBytes(this.hdr().thiszone(), 4,
false));
+headerBuffer.put(this.readLongToNBytes(this.hdr().sigfigs(), 4, true));
+headerBuffer.put(this.readLongToNBytes(this.hdr().snaplen(), 4, true));
+headerBuffer.put(this.readLongToNBytes(this.hdr().network(), 4, true));
+
+List packetByteArrays = new ArrayList<>();
+
+int packetBufferSize = 0;
+
+for (Packet currentPacket : packets) {
+ByteBuffer currentPacketBytes = ByteBuffer.allocate(16 +
currentPacket.rawBody().length);
+currentPacketBytes.put(readLongToNBytes(currentPacket.tsSec(), 4,
false));
+currentPacketBytes.put(readLongToNBytes(currentPacket.tsUsec(), 4,
false));
+currentPacketBytes.put(readLongToNBytes(currentPacket.inclLen(),
4, false));
+currentPacketBytes.put(readLongToNBytes(currentPacket.origLen(),
4, false));
+currentPacketBytes.put(currentPacket.rawBody());
+
+packetByteArrays.add(currentPacketBytes.array());
+packetBufferSize += 16 + currentPacket.rawBody().length;
+}
Review Comment:
Per earlier comment
and also should probably do the adding in one place. Please rename the
variable as you see fit
```suggestion
for (Packet currentPacket : packets) {
int packetHeaderAndBodySize = PACKET_HEADER_LENGTH +
currentPacket.rawBody().length;
ByteBuffer currentPacketBytes =
ByteBuffer.allocate(packetHeaderAndBodySize);
currentPacketBytes.put(readLongToNBytes(currentPacket.tsSec(),
4, false));
currentPacketBytes.put(readLongToNBytes(currentPacket.tsUsec(),
4, false));
currentPacketBytes.put(readLongToNBytes(currentPacket.inclLen(),
4, false));
currentPacketBytes.put(readLongToNBytes(currentPacket.origLen(),
4, false));
currentPacketBytes.put(currentPacket.rawBody());
packetByteArrays.add(currentPacketBytes.array());
packetBufferSize += packetHeaderAndBodySize;
}
```
--
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1608822619
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/PCAP.java:
##
@@ -0,0 +1,161 @@
+// MIT License
+
+// Copyright (c) 2015-2023 Kaitai Project
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to
deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+
+// The above copyright notice and this permission notice shall be included in
all
+// copies or substantial portions of the Software.
+
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE
+// SOFTWARE.
+
+package org.apache.nifi.processors.network.pcap;
+
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * PCAP (named after libpcap / winpcap) is a popular format for saving
+ * network traffic grabbed by network sniffers. It is typically
+ * produced by tools like [tcpdump](https://www.tcpdump.org/;>...) or
+ * [Wireshark](https://www.wireshark.org/;>...).
+ *
+ * @see https://wiki.wireshark.org/Development/LibpcapFileFormat;>Source
+ */
+public class PCAP {
+private ByteBufferInterface io;
Review Comment:
Per earlier comment
```suggestion
static final int PACKET_HEADER_LENGTH = 16;
private ByteBufferInterface io;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1608820651
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/SplitPCAP.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network.pcap;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.stream.IntStream;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark", "TcpDump", "WinDump", "sniffers"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(
+attribute = SplitPCAP.ERROR_REASON,
+description = "The reason the flowfile was sent to the failure
relationship."
+),
+@WritesAttribute(
+attribute = "fragment.identifier",
+description = "All split PCAP FlowFiles produced from the same parent
PCAP FlowFile will have the same randomly generated UUID added for this
attribute"
+),
+@WritesAttribute(
+attribute = "fragment.index",
+description = "A one-up number that indicates the ordering of the
split PCAP FlowFiles that were created from a single parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "fragment.count",
+description = "The number of split PCAP FlowFiles generated from the
parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "segment.original.filename ",
+description = "The filename of the parent PCAP FlowFile"
+)
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP Max Size")
+.displayName("PCAP Max Size")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
+.build();
+
+public static final Relationship REL_ORIGINAL = new Relationship.Builder()
+.name("original")
+.description("The original FlowFile that was split into segments.
If the FlowFile fails processing, nothing will be sent to "
++ "this relationship")
+.build();
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("If a FlowFile cannot be transformed from the
configured input format to the configured output format, "
+
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1608824023
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/PCAP.java:
##
@@ -0,0 +1,161 @@
+// MIT License
+
+// Copyright (c) 2015-2023 Kaitai Project
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to
deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+
+// The above copyright notice and this permission notice shall be included in
all
+// copies or substantial portions of the Software.
+
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE
+// SOFTWARE.
+
+package org.apache.nifi.processors.network.pcap;
+
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * PCAP (named after libpcap / winpcap) is a popular format for saving
+ * network traffic grabbed by network sniffers. It is typically
+ * produced by tools like [tcpdump](https://www.tcpdump.org/;>...) or
+ * [Wireshark](https://www.wireshark.org/;>...).
+ *
+ * @see https://wiki.wireshark.org/Development/LibpcapFileFormat;>Source
+ */
+public class PCAP {
+private ByteBufferInterface io;
+
+public PCAP(ByteBufferInterface io) {
+this(io, null, null);
+}
+
+public PCAP(ByteBufferInterface io, Object parent, PCAP root) {
+
+this.parent = parent;
+this.root = root == null ? this : root;
+this.io = io;
+read();
+}
+
+public PCAP(Header hdr, List packets) {
+this.hdr = hdr;
+this.packets = packets;
+}
+
+public byte[] readBytesFull() {
+
+int headerBufferSize = 20 + this.hdr().magicNumber().length;
+ByteBuffer headerBuffer = ByteBuffer.allocate(headerBufferSize);
+headerBuffer.order(ByteOrder.LITTLE_ENDIAN);
+
+headerBuffer.put(this.hdr().magicNumber());
+headerBuffer.put(this.readIntToNBytes(this.hdr().versionMajor(), 2,
false));
+headerBuffer.put(this.readIntToNBytes(this.hdr().versionMinor(), 2,
false));
+headerBuffer.put(this.readIntToNBytes(this.hdr().thiszone(), 4,
false));
+headerBuffer.put(this.readLongToNBytes(this.hdr().sigfigs(), 4, true));
+headerBuffer.put(this.readLongToNBytes(this.hdr().snaplen(), 4, true));
+headerBuffer.put(this.readLongToNBytes(this.hdr().network(), 4, true));
+
+List packetByteArrays = new ArrayList<>();
+
+int packetBufferSize = 0;
+
+for (Packet currentPacket : packets) {
+ByteBuffer currentPacketBytes = ByteBuffer.allocate(16 +
currentPacket.rawBody().length);
+currentPacketBytes.put(readLongToNBytes(currentPacket.tsSec(), 4,
false));
+currentPacketBytes.put(readLongToNBytes(currentPacket.tsUsec(), 4,
false));
+currentPacketBytes.put(readLongToNBytes(currentPacket.inclLen(),
4, false));
+currentPacketBytes.put(readLongToNBytes(currentPacket.origLen(),
4, false));
+currentPacketBytes.put(currentPacket.rawBody());
+
+packetByteArrays.add(currentPacketBytes.array());
+packetBufferSize += 16 + currentPacket.rawBody().length;
+}
Review Comment:
Per earlier comment
```suggestion
for (Packet currentPacket : packets) {
ByteBuffer currentPacketBytes =
ByteBuffer.allocate(PACKET_HEADER_LENGTH + currentPacket.rawBody().length);
currentPacketBytes.put(readLongToNBytes(currentPacket.tsSec(),
4, false));
currentPacketBytes.put(readLongToNBytes(currentPacket.tsUsec(),
4, false));
currentPacketBytes.put(readLongToNBytes(currentPacket.inclLen(),
4, false));
currentPacketBytes.put(readLongToNBytes(currentPacket.origLen(),
4, false));
currentPacketBytes.put(currentPacket.rawBody());
packetByteArrays.add(currentPacketBytes.array());
packetBufferSize += PACKET_HEADER_LENGTH +
currentPacket.rawBody().length;
}
```
##
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1608585813
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/Header.java:
##
@@ -0,0 +1,151 @@
+// MIT License
+
+// Copyright (c) 2015-2023 Kaitai Project
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to
deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+
+// The above copyright notice and this permission notice shall be included in
all
+// copies or substantial portions of the Software.
+
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE
+// SOFTWARE.
+
+package org.apache.nifi.processors.network.pcap;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class Header {
+private ByteBufferInterface io;
+private final Logger logger = LoggerFactory.getLogger(Header.class);
+
+public Header(ByteBufferInterface io, PCAP parent, PCAP root) {
+
+this.parent = parent;
+this.root = root;
+this.io = io;
+
+try {
+read();
+} catch (ByteBufferInterface.ValidationNotEqualError e) {
+this.logger.error("PCAP file header could not be parsed due to ",
e);
+}
+}
+
+public Header(byte[] magicNumber, int versionMajor, int versionMinor, int
thiszone, long sigfigs, long snaplen,
+long network) {
+
+this.magicNumber = magicNumber;
+this.versionMajor = versionMajor;
+this.versionMinor = versionMinor;
+this.thiszone = thiszone;
+this.sigfigs = sigfigs;
+this.snaplen = snaplen;
+this.network = network;
+}
+
+public ByteBufferInterface io() {
+return io;
+}
+
+private void read()
+throws ByteBufferInterface.ValidationNotEqualError {
+this.magicNumber = this.io.readBytes(4);
+if (this.magicNumber == new byte[] {(byte) 0xd4, (byte) 0xc3, (byte)
0xb2, (byte) 0xa1 }) {
+// have to swap the bits
+this.versionMajor = this.io.readU2be();
+if (!(versionMajor() == 2)) {
+
+throw new ByteBufferInterface.ValidationNotEqualError("Packet
major version is not 2.");
+}
+this.versionMinor = this.io.readU2be();
+this.thiszone = this.io.readS4be();
+this.sigfigs = this.io.readU4be();
+this.snaplen = this.io.readU4be();
+this.network = this.io.readU4be();
+} else {
+this.versionMajor = this.io.readU2le();
+if (!(versionMajor() == 2)) {
+throw new ByteBufferInterface.ValidationNotEqualError("Packet
major version is not 2.");
+}
+this.versionMinor = this.io.readU2le();
+this.thiszone = this.io.readS4le();
+this.sigfigs = this.io.readU4le();
+this.snaplen = this.io.readU4le();
+this.network = this.io.readU4le();
+}
Review Comment:
Add some spacing between `if` blocks and other assignments
```suggestion
if (this.magicNumber == new byte[] {(byte) 0xd4, (byte) 0xc3, (byte)
0xb2, (byte) 0xa1 }) {
// have to swap the bits
this.versionMajor = this.io.readU2be();
if (!(versionMajor() == 2)) {
throw new
ByteBufferInterface.ValidationNotEqualError("Packet major version is not 2.");
}
this.versionMinor = this.io.readU2be();
this.thiszone = this.io.readS4be();
this.sigfigs = this.io.readU4be();
this.snaplen = this.io.readU4be();
this.network = this.io.readU4be();
} else {
this.versionMajor = this.io.readU2le();
if (!(versionMajor() == 2)) {
throw new
ByteBufferInterface.ValidationNotEqualError("Packet major version is not 2.");
}
this.versionMinor = this.io.readU2le();
this.thiszone = this.io.readS4le();
this.sigfigs = this.io.readU4le();
this.snaplen = this.io.readU4le();
[jira] [Commented] (NIFI-13268) ConsumeGCPPubSub Stopped Working with M3
[
https://issues.apache.org/jira/browse/NIFI-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848324#comment-17848324
]
Joe Witt commented on NIFI-13268:
-
[~turcsanyip]sorry didnt mean to change it from you to me. It hadnt updated
locally
> ConsumeGCPPubSub Stopped Working with M3
>
>
> Key: NIFI-13268
> URL: https://issues.apache.org/jira/browse/NIFI-13268
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Emin
>Assignee: Peter Turcsanyi
>Priority: Major
>
> After updating from 1.26 to 2.0.0M3, getting the following for
> `ConsumeGCPPubSub`
>
> {{nifi-1 | 2024-05-18 23:00:02,157 INFO [NiFi Web Server-405]
> o.a.n.c.s.StandardProcessScheduler Running once
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] nifi-1 | 2024-05-18
> 23:00:02,158 INFO [NiFi Web Server-405]
> o.a.n.controller.StandardProcessorNode Starting
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] nifi-1 | 2024-05-18
> 23:00:02,170 ERROR [Timer-Driven Process Thread-1]
> o.a.n.p.gcp.pubsub.ConsumeGCPubSub
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] Failed to properly
> initialize Processor. If still scheduled to run, NiFi will attempt to
> initialize and run the Processor again after the 'Administrative Yield
> Duration' has elapsed. Failure is due to java.util.ServiceConfigurationError:
> io.grpc.ManagedChannelProvider:
> io.grpc.netty.shaded.io.grpc.netty.UdsNettyChannelProvider Unable to get
> public no-arg constructor nifi-1 | java.util.ServiceConfigurationError:
> io.grpc.ManagedChannelProvider:
> io.grpc.netty.shaded.io.grpc.netty.UdsNettyChannelProvider Unable to get
> public no-arg constructor nifi-1 | at
> java.base/java.util.ServiceLoader.fail(ServiceLoader.java:586) nifi-1 | at
> java.base/java.util.ServiceLoader.getConstructor(ServiceLoader.java:679)
> nifi-1 | at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1240)
> nifi-1 | at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
> nifi-1 | at
> java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309) nifi-1 |
> at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
> nifi-1 | at io.grpc.ServiceProviders.loadAll(ServiceProviders.java:67) nifi-1
> | at
> io.grpc.ManagedChannelRegistry.getDefaultRegistry(ManagedChannelRegistry.java:101)
> nifi-1 | at
> io.grpc.ManagedChannelProvider.provider(ManagedChannelProvider.java:43)
> nifi-1 | at
> io.grpc.ManagedChannelBuilder.forAddress(ManagedChannelBuilder.java:44)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.createSingleChannel(InstantiatingGrpcChannelProvider.java:404)
> nifi-1 | at com.google.api.gax.grpc.ChannelPool.(ChannelPool.java:107)
> nifi-1 | at com.google.api.gax.grpc.ChannelPool.create(ChannelPool.java:85)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.createChannel(InstantiatingGrpcChannelProvider.java:243)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.getTransportChannel(InstantiatingGrpcChannelProvider.java:237)
> nifi-1 | at
> com.google.api.gax.rpc.ClientContext.create(ClientContext.java:230) nifi-1 |
> at
> com.google.cloud.pubsub.v1.stub.GrpcSubscriberStub.create(GrpcSubscriberStub.java:287)
> nifi-1 | at
> org.apache.nifi.processors.gcp.pubsub.ConsumeGCPubSub.getSubscriber(ConsumeGCPubSub.java:286)
> nifi-1 | at
> org.apache.nifi.processors.gcp.pubsub.ConsumeGCPubSub.onScheduled(ConsumeGCPubSub.java:134)
> nifi-1 | at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> nifi-1 | at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
> nifi-1 | at
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$10(StandardProcessorNode.java:1668)
> nifi-1 | at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
> nifi-1 | at
> java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) nifi-1 |
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> nifi-1 | at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> nifi-1 | at
>
[jira] [Assigned] (NIFI-13268) ConsumeGCPPubSub Stopped Working with M3
[
https://issues.apache.org/jira/browse/NIFI-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt reassigned NIFI-13268:
---
Assignee: Peter Turcsanyi (was: Joe Witt)
> ConsumeGCPPubSub Stopped Working with M3
>
>
> Key: NIFI-13268
> URL: https://issues.apache.org/jira/browse/NIFI-13268
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Emin
>Assignee: Peter Turcsanyi
>Priority: Major
>
> After updating from 1.26 to 2.0.0M3, getting the following for
> `ConsumeGCPPubSub`
>
> {{nifi-1 | 2024-05-18 23:00:02,157 INFO [NiFi Web Server-405]
> o.a.n.c.s.StandardProcessScheduler Running once
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] nifi-1 | 2024-05-18
> 23:00:02,158 INFO [NiFi Web Server-405]
> o.a.n.controller.StandardProcessorNode Starting
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] nifi-1 | 2024-05-18
> 23:00:02,170 ERROR [Timer-Driven Process Thread-1]
> o.a.n.p.gcp.pubsub.ConsumeGCPubSub
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] Failed to properly
> initialize Processor. If still scheduled to run, NiFi will attempt to
> initialize and run the Processor again after the 'Administrative Yield
> Duration' has elapsed. Failure is due to java.util.ServiceConfigurationError:
> io.grpc.ManagedChannelProvider:
> io.grpc.netty.shaded.io.grpc.netty.UdsNettyChannelProvider Unable to get
> public no-arg constructor nifi-1 | java.util.ServiceConfigurationError:
> io.grpc.ManagedChannelProvider:
> io.grpc.netty.shaded.io.grpc.netty.UdsNettyChannelProvider Unable to get
> public no-arg constructor nifi-1 | at
> java.base/java.util.ServiceLoader.fail(ServiceLoader.java:586) nifi-1 | at
> java.base/java.util.ServiceLoader.getConstructor(ServiceLoader.java:679)
> nifi-1 | at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1240)
> nifi-1 | at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
> nifi-1 | at
> java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309) nifi-1 |
> at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
> nifi-1 | at io.grpc.ServiceProviders.loadAll(ServiceProviders.java:67) nifi-1
> | at
> io.grpc.ManagedChannelRegistry.getDefaultRegistry(ManagedChannelRegistry.java:101)
> nifi-1 | at
> io.grpc.ManagedChannelProvider.provider(ManagedChannelProvider.java:43)
> nifi-1 | at
> io.grpc.ManagedChannelBuilder.forAddress(ManagedChannelBuilder.java:44)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.createSingleChannel(InstantiatingGrpcChannelProvider.java:404)
> nifi-1 | at com.google.api.gax.grpc.ChannelPool.(ChannelPool.java:107)
> nifi-1 | at com.google.api.gax.grpc.ChannelPool.create(ChannelPool.java:85)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.createChannel(InstantiatingGrpcChannelProvider.java:243)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.getTransportChannel(InstantiatingGrpcChannelProvider.java:237)
> nifi-1 | at
> com.google.api.gax.rpc.ClientContext.create(ClientContext.java:230) nifi-1 |
> at
> com.google.cloud.pubsub.v1.stub.GrpcSubscriberStub.create(GrpcSubscriberStub.java:287)
> nifi-1 | at
> org.apache.nifi.processors.gcp.pubsub.ConsumeGCPubSub.getSubscriber(ConsumeGCPubSub.java:286)
> nifi-1 | at
> org.apache.nifi.processors.gcp.pubsub.ConsumeGCPubSub.onScheduled(ConsumeGCPubSub.java:134)
> nifi-1 | at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> nifi-1 | at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
> nifi-1 | at
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$10(StandardProcessorNode.java:1668)
> nifi-1 | at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
> nifi-1 | at
> java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) nifi-1 |
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> nifi-1 | at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> nifi-1 | at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> nifi-1 | at
[jira] [Assigned] (NIFI-13268) ConsumeGCPPubSub Stopped Working with M3
[
https://issues.apache.org/jira/browse/NIFI-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt reassigned NIFI-13268:
---
Assignee: Joe Witt (was: Peter Turcsanyi)
> ConsumeGCPPubSub Stopped Working with M3
>
>
> Key: NIFI-13268
> URL: https://issues.apache.org/jira/browse/NIFI-13268
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Emin
>Assignee: Joe Witt
>Priority: Major
>
> After updating from 1.26 to 2.0.0M3, getting the following for
> `ConsumeGCPPubSub`
>
> {{nifi-1 | 2024-05-18 23:00:02,157 INFO [NiFi Web Server-405]
> o.a.n.c.s.StandardProcessScheduler Running once
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] nifi-1 | 2024-05-18
> 23:00:02,158 INFO [NiFi Web Server-405]
> o.a.n.controller.StandardProcessorNode Starting
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] nifi-1 | 2024-05-18
> 23:00:02,170 ERROR [Timer-Driven Process Thread-1]
> o.a.n.p.gcp.pubsub.ConsumeGCPubSub
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] Failed to properly
> initialize Processor. If still scheduled to run, NiFi will attempt to
> initialize and run the Processor again after the 'Administrative Yield
> Duration' has elapsed. Failure is due to java.util.ServiceConfigurationError:
> io.grpc.ManagedChannelProvider:
> io.grpc.netty.shaded.io.grpc.netty.UdsNettyChannelProvider Unable to get
> public no-arg constructor nifi-1 | java.util.ServiceConfigurationError:
> io.grpc.ManagedChannelProvider:
> io.grpc.netty.shaded.io.grpc.netty.UdsNettyChannelProvider Unable to get
> public no-arg constructor nifi-1 | at
> java.base/java.util.ServiceLoader.fail(ServiceLoader.java:586) nifi-1 | at
> java.base/java.util.ServiceLoader.getConstructor(ServiceLoader.java:679)
> nifi-1 | at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1240)
> nifi-1 | at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
> nifi-1 | at
> java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309) nifi-1 |
> at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
> nifi-1 | at io.grpc.ServiceProviders.loadAll(ServiceProviders.java:67) nifi-1
> | at
> io.grpc.ManagedChannelRegistry.getDefaultRegistry(ManagedChannelRegistry.java:101)
> nifi-1 | at
> io.grpc.ManagedChannelProvider.provider(ManagedChannelProvider.java:43)
> nifi-1 | at
> io.grpc.ManagedChannelBuilder.forAddress(ManagedChannelBuilder.java:44)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.createSingleChannel(InstantiatingGrpcChannelProvider.java:404)
> nifi-1 | at com.google.api.gax.grpc.ChannelPool.(ChannelPool.java:107)
> nifi-1 | at com.google.api.gax.grpc.ChannelPool.create(ChannelPool.java:85)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.createChannel(InstantiatingGrpcChannelProvider.java:243)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.getTransportChannel(InstantiatingGrpcChannelProvider.java:237)
> nifi-1 | at
> com.google.api.gax.rpc.ClientContext.create(ClientContext.java:230) nifi-1 |
> at
> com.google.cloud.pubsub.v1.stub.GrpcSubscriberStub.create(GrpcSubscriberStub.java:287)
> nifi-1 | at
> org.apache.nifi.processors.gcp.pubsub.ConsumeGCPubSub.getSubscriber(ConsumeGCPubSub.java:286)
> nifi-1 | at
> org.apache.nifi.processors.gcp.pubsub.ConsumeGCPubSub.onScheduled(ConsumeGCPubSub.java:134)
> nifi-1 | at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> nifi-1 | at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
> nifi-1 | at
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$10(StandardProcessorNode.java:1668)
> nifi-1 | at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
> nifi-1 | at
> java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) nifi-1 |
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> nifi-1 | at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> nifi-1 | at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> nifi-1 | at
[jira] [Updated] (NIFI-13274) Dependencies housekeeping for NiFi NAR Maven plugin
[ https://issues.apache.org/jira/browse/NIFI-13274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13274: Resolution: Fixed Status: Resolved (was: Patch Available) > Dependencies housekeeping for NiFi NAR Maven plugin > --- > > Key: NIFI-13274 > URL: https://issues.apache.org/jira/browse/NIFI-13274 > Project: Apache NiFi > Issue Type: Task >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: nifi-nar-maven-plugin-2.0.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Dependencies housekeeping for NiFi NAR Maven plugin > Also fixing the SNAPSHOT version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
asfgit closed pull request #38: NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT URL: https://github.com/apache/nifi-maven/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691: URL: https://github.com/apache/nifi/pull/8691#discussion_r1608719446 ## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors-nar/src/main/resources/META-INF/NOTICE: ## @@ -4,6 +4,12 @@ Copyright 2017-2020 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). +This project includes derived works from the Kaitai Project available under the MIT License. + Portions of code found at https://formats.kaitai.io/pcap/java.html + Copyright 2015-2023 Kaitai Project + The code can be found in: +nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/util/PCAP.java + nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/util/Linktype.java Review Comment: The paths have changed, `PCAP` has been broken down to different files, `LinkType` has been removed and the copyright year should reflect the current year hence the following changes should be made.. ```suggestion Copyright 2015-2024 Kaitai Project The code can be found in: nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/ByteBufferInterface.java nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/Header.java nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/PCAP.java nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/Packet.java ``` @exceptionfactory Can you please advise whether this information belongs in this file only, in the top level `NOTICE` file only or in both? ## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/PCAP.java: ## @@ -0,0 +1,161 @@ +// MIT License + +// Copyright (c) 2015-2023 Kaitai Project Review Comment: ```suggestion // Copyright (c) 2015-2024 Kaitai Project ``` ## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/Packet.java: ## @@ -0,0 +1,98 @@ +// MIT License + +// Copyright (c) 2015-2023 Kaitai Project Review Comment: ```suggestion // Copyright (c) 2015-2024 Kaitai Project ``` ## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/Header.java: ## @@ -0,0 +1,151 @@ +// MIT License + +// Copyright (c) 2015-2023 Kaitai Project Review Comment: ```suggestion // Copyright (c) 2015-2024 Kaitai Project ``` ## nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/ByteBufferInterface.java: ## @@ -0,0 +1,87 @@ +// MIT License + +// Copyright (c) 2015-2023 Kaitai Project Review Comment: ```suggestion // Copyright (c) 2015-2024 Kaitai Project ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13247] - Property Verification [nifi]
mcgilman commented on PR #8857: URL: https://github.com/apache/nifi/pull/8857#issuecomment-2123128943 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13275) Remove web.xml from nifi-web-frontend
[ https://issues.apache.org/jira/browse/NIFI-13275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848311#comment-17848311 ] ASF subversion and git services commented on NIFI-13275: Commit 2a4d1de6c1cc899b8275772333ba8d8b1d85733d in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2a4d1de6c1 ] NIFI-13275 Removed web.xml from nifi-web-frontend (#8858) This closes #8858 > Remove web.xml from nifi-web-frontend > - > > Key: NIFI-13275 > URL: https://issues.apache.org/jira/browse/NIFI-13275 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > Following recent changes in nifi-web-frontend to remove the need for Servlet > Filters, the Servlet configuration in web.xml is no longer needed. With the > frontend code relying exclusively on REST API calls to nifi-web-api, the > web.xml configuration and nifi-web-utils dependencies are no longer required. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13275) Remove web.xml from nifi-web-frontend
[ https://issues.apache.org/jira/browse/NIFI-13275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13275: --- Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Remove web.xml from nifi-web-frontend > - > > Key: NIFI-13275 > URL: https://issues.apache.org/jira/browse/NIFI-13275 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.0.0-M4 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Following recent changes in nifi-web-frontend to remove the need for Servlet > Filters, the Servlet configuration in web.xml is no longer needed. With the > frontend code relying exclusively on REST API calls to nifi-web-api, the > web.xml configuration and nifi-web-utils dependencies are no longer required. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13275 Remove web.xml from nifi-web-frontend [nifi]
mcgilman merged PR #8858: URL: https://github.com/apache/nifi/pull/8858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1608630888
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/ByteBufferInterface.java:
##
@@ -0,0 +1,87 @@
+// MIT License
+
+// Copyright (c) 2015-2023 Kaitai Project
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to
deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+
+// The above copyright notice and this permission notice shall be included in
all
+// copies or substantial portions of the Software.
+
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE
+// SOFTWARE.
+
+package org.apache.nifi.processors.network.pcap;
+
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+
+public class ByteBufferInterface {
+
+public ByteBufferInterface(byte[] byteArray) {
+this.buffer = ByteBuffer.wrap(byteArray);
+}
+
+public static class ValidationNotEqualError extends Exception {
+public ValidationNotEqualError(String message) {
+super(message);
+}
+}
+
+public ByteBuffer buffer;
Review Comment:
Please place this towards the top of class before the constructor and make
it `final private` .
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13277] - Make the main menu more compact in terms of spacing. [nifi]
mcgilman commented on PR #8861: URL: https://github.com/apache/nifi/pull/8861#issuecomment-2123119194 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13278) Fix license file exclusion
[ https://issues.apache.org/jira/browse/NIFI-13278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13278: --- Status: Patch Available (was: In Progress) > Fix license file exclusion > -- > > Key: NIFI-13278 > URL: https://issues.apache.org/jira/browse/NIFI-13278 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Changes introduced in NIFI-12902 inadvertently excluded the > 3rdpartylicenses.txt file from being included in the resulting artifact. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1608670513
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/test/java/org/apache/nifi/processors/network/pcap/TestSplitPCAP.java:
##
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.nifi.processors.network.pcap;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+
+
+public class TestSplitPCAP {
+
+private Header hdr;
+private Packet validPacket;
+private Packet invalidPacket;
+
+@BeforeEach
+public void init() {
+// Create a header for the test PCAP
+this.hdr = new Header(
+new byte[]{(byte) 0xa1, (byte) 0xb2, (byte) 0xc3, (byte) 0xd4},
+2,
+4,
+0,
+(long) 0,
+(long) 40,
+(long) 1 // ETHERNET
+);
+
+this.validPacket = new Packet(
+(long) 1713184965,
+(long) 1000,
+(long) 30,
+(long) 30,
+new byte[]{
+0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
+20, 21, 22, 23, 24, 25, 26, 27, 28, 29,
+}
+);
+
+this.invalidPacket = new Packet(
+(long) 1713184965,
+(long) 1000,
+(long) 10,
+(long) 10,
+new byte[]{
+0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
+20, 21, 22, 23, 24, 25, 26, 27, 28, 29,
+}
+);
+
+}
+
+@Test
+public void testValidPackets() throws IOException {
+TestRunner runner = TestRunners.newTestRunner(SplitPCAP.class);
+runner.setProperty(SplitPCAP.PCAP_MAX_SIZE, "100");
+
+List packets = new ArrayList<>();
+for (var loop = 0; loop < 3; loop++) {
+packets.add(this.validPacket);
+}
Review Comment:
Intellij says the `throws` is not necessary as an `IOException` is not being
thrown.
In addition, it turns out Java already has a method to repeat an object in a
collection as seen below.
Please include `import java.util.Collections;`.
```suggestion
public void testValidPackets() {
TestRunner runner = TestRunners.newTestRunner(SplitPCAP.class);
runner.setProperty(SplitPCAP.PCAP_MAX_SIZE, "100");
List packets = Collections.nCopies(3, this.validPacket);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12967: Introducing Back action [nifi]
rfellows commented on PR #8859: URL: https://github.com/apache/nifi/pull/8859#issuecomment-2123114282 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1608672361
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/test/java/org/apache/nifi/processors/network/pcap/TestSplitPCAP.java:
##
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.nifi.processors.network.pcap;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+
+
+public class TestSplitPCAP {
+
+private Header hdr;
+private Packet validPacket;
+private Packet invalidPacket;
+
+@BeforeEach
+public void init() {
+// Create a header for the test PCAP
+this.hdr = new Header(
+new byte[]{(byte) 0xa1, (byte) 0xb2, (byte) 0xc3, (byte) 0xd4},
+2,
+4,
+0,
+(long) 0,
+(long) 40,
+(long) 1 // ETHERNET
+);
+
+this.validPacket = new Packet(
+(long) 1713184965,
+(long) 1000,
+(long) 30,
+(long) 30,
+new byte[]{
+0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
+20, 21, 22, 23, 24, 25, 26, 27, 28, 29,
+}
+);
+
+this.invalidPacket = new Packet(
+(long) 1713184965,
+(long) 1000,
+(long) 10,
+(long) 10,
+new byte[]{
+0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
+20, 21, 22, 23, 24, 25, 26, 27, 28, 29,
+}
+);
+
+}
+
+@Test
+public void testValidPackets() throws IOException {
+TestRunner runner = TestRunners.newTestRunner(SplitPCAP.class);
+runner.setProperty(SplitPCAP.PCAP_MAX_SIZE, "100");
+
+List packets = new ArrayList<>();
+for (var loop = 0; loop < 3; loop++) {
+packets.add(this.validPacket);
+}
+
+PCAP testPcap = new PCAP(this.hdr, packets);
+
+runner.enqueue(testPcap.readBytesFull());
+
+runner.run();
+
+runner.assertTransferCount(SplitPCAP.REL_SPLIT, 3);
+runner.assertTransferCount(SplitPCAP.REL_ORIGINAL, 1);
+runner.assertQueueEmpty();
+}
+
+@Test
+public void testInvalidPackets() throws IOException {
+TestRunner runner = TestRunners.newTestRunner(SplitPCAP.class);
+runner.setProperty(SplitPCAP.PCAP_MAX_SIZE, "50");
+
+List packets = new ArrayList<>();
+for (var loop = 0; loop < 3; loop++) {
+packets.add(this.invalidPacket);
+}
+
+PCAP testPcap = new PCAP(this.hdr, packets);
+
+runner.enqueue(testPcap.readBytesFull());
+
+runner.run();
+
+runner.assertAllFlowFilesTransferred(SplitPCAP.REL_FAILURE, 1);
+runner.assertQueueEmpty();
+}
+
+@Test
+public void testPacketsTooBig() throws IOException {
+TestRunner runner = TestRunners.newTestRunner(SplitPCAP.class);
+runner.setProperty(SplitPCAP.PCAP_MAX_SIZE, "10");
+
+List packets = new ArrayList<>();
+for (var loop = 0; loop < 3; loop++) {
+packets.add(this.validPacket);
+}
Review Comment:
```suggestion
@Test
public void testPacketsTooBig() {
TestRunner runner = TestRunners.newTestRunner(SplitPCAP.class);
runner.setProperty(SplitPCAP.PCAP_MAX_SIZE, "10");
List packets = Collections.nCopies(3, this.validPacket);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
joewitt commented on PR #38: URL: https://github.com/apache/nifi-maven/pull/38#issuecomment-2123103408 Can confirm with the nifi PR that the build does again work as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13267) Bump NiFi NAR Maven plugin version
[ https://issues.apache.org/jira/browse/NIFI-13267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13267: -- Status: Patch Available (was: Open) > Bump NiFi NAR Maven plugin version > -- > > Key: NIFI-13267 > URL: https://issues.apache.org/jira/browse/NIFI-13267 > Project: Apache NiFi > Issue Type: Task >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Once we have a new version of the NiFi NAR Maven Plugin, we'll need to bump > the version in the NiFi code base and make some changes to account for the > new extension types (Parameter Providers and Flow Analysis Rules). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1608670513
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/test/java/org/apache/nifi/processors/network/pcap/TestSplitPCAP.java:
##
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.nifi.processors.network.pcap;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+
+
+public class TestSplitPCAP {
+
+private Header hdr;
+private Packet validPacket;
+private Packet invalidPacket;
+
+@BeforeEach
+public void init() {
+// Create a header for the test PCAP
+this.hdr = new Header(
+new byte[]{(byte) 0xa1, (byte) 0xb2, (byte) 0xc3, (byte) 0xd4},
+2,
+4,
+0,
+(long) 0,
+(long) 40,
+(long) 1 // ETHERNET
+);
+
+this.validPacket = new Packet(
+(long) 1713184965,
+(long) 1000,
+(long) 30,
+(long) 30,
+new byte[]{
+0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
+20, 21, 22, 23, 24, 25, 26, 27, 28, 29,
+}
+);
+
+this.invalidPacket = new Packet(
+(long) 1713184965,
+(long) 1000,
+(long) 10,
+(long) 10,
+new byte[]{
+0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
+20, 21, 22, 23, 24, 25, 26, 27, 28, 29,
+}
+);
+
+}
+
+@Test
+public void testValidPackets() throws IOException {
+TestRunner runner = TestRunners.newTestRunner(SplitPCAP.class);
+runner.setProperty(SplitPCAP.PCAP_MAX_SIZE, "100");
+
+List packets = new ArrayList<>();
+for (var loop = 0; loop < 3; loop++) {
+packets.add(this.validPacket);
+}
Review Comment:
Intellij says the `throws` is not necessary as an `IOException` is not being
thrown.
In addition, it turns out Java already has a method to repeat an object in a
collection as seen below.
Please include `import java.util.Collections;`.
```suggestion
public void testValidPackets() {
TestRunner runner = TestRunners.newTestRunner(SplitPCAP.class);
runner.setProperty(SplitPCAP.PCAP_MAX_SIZE, "100");
List packets = Collections.nCopies(3, this.validPacket);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
joewitt commented on PR #38: URL: https://github.com/apache/nifi-maven/pull/38#issuecomment-2123097228 thanks - am building maven plugin with this PR and the nifi one now as well. will advise on results -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1608585813
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/Header.java:
##
@@ -0,0 +1,151 @@
+// MIT License
+
+// Copyright (c) 2015-2023 Kaitai Project
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to
deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+
+// The above copyright notice and this permission notice shall be included in
all
+// copies or substantial portions of the Software.
+
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE
+// SOFTWARE.
+
+package org.apache.nifi.processors.network.pcap;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class Header {
+private ByteBufferInterface io;
+private final Logger logger = LoggerFactory.getLogger(Header.class);
+
+public Header(ByteBufferInterface io, PCAP parent, PCAP root) {
+
+this.parent = parent;
+this.root = root;
+this.io = io;
+
+try {
+read();
+} catch (ByteBufferInterface.ValidationNotEqualError e) {
+this.logger.error("PCAP file header could not be parsed due to ",
e);
+}
+}
+
+public Header(byte[] magicNumber, int versionMajor, int versionMinor, int
thiszone, long sigfigs, long snaplen,
+long network) {
+
+this.magicNumber = magicNumber;
+this.versionMajor = versionMajor;
+this.versionMinor = versionMinor;
+this.thiszone = thiszone;
+this.sigfigs = sigfigs;
+this.snaplen = snaplen;
+this.network = network;
+}
+
+public ByteBufferInterface io() {
+return io;
+}
+
+private void read()
+throws ByteBufferInterface.ValidationNotEqualError {
+this.magicNumber = this.io.readBytes(4);
+if (this.magicNumber == new byte[] {(byte) 0xd4, (byte) 0xc3, (byte)
0xb2, (byte) 0xa1 }) {
+// have to swap the bits
+this.versionMajor = this.io.readU2be();
+if (!(versionMajor() == 2)) {
+
+throw new ByteBufferInterface.ValidationNotEqualError("Packet
major version is not 2.");
+}
+this.versionMinor = this.io.readU2be();
+this.thiszone = this.io.readS4be();
+this.sigfigs = this.io.readU4be();
+this.snaplen = this.io.readU4be();
+this.network = this.io.readU4be();
+} else {
+this.versionMajor = this.io.readU2le();
+if (!(versionMajor() == 2)) {
+throw new ByteBufferInterface.ValidationNotEqualError("Packet
major version is not 2.");
+}
+this.versionMinor = this.io.readU2le();
+this.thiszone = this.io.readS4le();
+this.sigfigs = this.io.readU4le();
+this.snaplen = this.io.readU4le();
+this.network = this.io.readU4le();
+}
Review Comment:
Add some spacing between `if` blocks and other assignments
```suggestion
if (this.magicNumber == new byte[] {(byte) 0xd4, (byte) 0xc3, (byte)
0xb2, (byte) 0xa1 }) {
// have to swap the bits
this.versionMajor = this.io.readU2be();
if (!(versionMajor() == 2)) {
throw new
ByteBufferInterface.ValidationNotEqualError("Packet major version is not 2.");
}
this.versionMinor = this.io.readU2be();
this.thiszone = this.io.readS4be();
this.sigfigs = this.io.readU4be();
this.snaplen = this.io.readU4be();
this.network = this.io.readU4be();
} else {
this.versionMajor = this.io.readU2le();
if (!(versionMajor() == 2)) {
throw new
ByteBufferInterface.ValidationNotEqualError("Packet major version is not 2.");
}
this.versionMinor = this.io.readU2le();
this.thiszone = this.io.readS4le();
this.sigfigs = this.io.readU4le();
this.snaplen = this.io.readU4le();
[jira] [Resolved] (MINIFICPP-2353) improve some logs, accept the old yaml c2 mimetype
[ https://issues.apache.org/jira/browse/MINIFICPP-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2353. - Fix Version/s: 0.99.1 Assignee: Marton Szasz Resolution: Fixed > improve some logs, accept the old yaml c2 mimetype > -- > > Key: MINIFICPP-2353 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2353 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Marton Szasz >Priority: Major > Fix For: 0.99.1 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MINIFICPP-2383) update phoenix-actions/test-reporting to v15
[ https://issues.apache.org/jira/browse/MINIFICPP-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-2383. - Fix Version/s: 0.99.1 Assignee: Marton Szasz Resolution: Fixed > update phoenix-actions/test-reporting to v15 > > > Key: MINIFICPP-2383 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2383 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Marton Szasz >Priority: Major > Fix For: 0.99.1 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2251 Make OPENSSL and CURL mandatory [nifi-minifi-cpp]
szaszm commented on code in PR #1749:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1749#discussion_r1608546502
##
libminifi/test/libtest/unit/TestUtils.h:
##
@@ -0,0 +1,223 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "utils/file/FileUtils.h"
+#include "utils/Environment.h"
+#include "utils/Id.h"
+#include "utils/TimeUtil.h"
+#include "TestBase.h"
+
+#include "rapidjson/document.h"
+#include "asio.hpp"
+#include "asio/ssl.hpp"
+#include "utils/net/Ssl.h"
+
+using namespace std::literals::chrono_literals;
+
+#undef GetObject // windows.h #defines GetObject = GetObjectA or GetObjectW,
which conflicts with rapidjson
+#include "Connection.h"
+#include "utils/FlowFileQueue.h"
+#include "Catch.h"
+
+#define FIELD_ACCESSOR(field) \
+ template \
+ static auto get_##field(T&& instance) ->
decltype((std::forward(instance).field)) { \
+return std::forward(instance).field; \
+ }
+
+#define METHOD_ACCESSOR(method) \
+ template \
+ static auto call_##method(T&& instance, Args&& ...args) ->
decltype((std::forward(instance).method(std::forward(args)...))) { \
+return std::forward(instance).method(std::forward(args)...); \
+ }
+
+namespace org::apache::nifi::minifi::test::utils {
+
+std::filesystem::path putFileToDir(const std::filesystem::path& dir_path,
const std::filesystem::path& file_name, const std::string& content);
+std::string getFileContent(const std::filesystem::path& file_name);
+
+void makeFileOrDirectoryNotWritable(const std::filesystem::path& file_name);
+void makeFileOrDirectoryWritable(const std::filesystem::path& file_name);
+
+minifi::utils::Identifier generateUUID();
+
+class ManualClock : public minifi::utils::timeutils::SteadyClock {
+ public:
+ [[nodiscard]] std::chrono::milliseconds timeSinceEpoch() const override {
+std::lock_guard lock(mtx_);
+return time_;
+ }
+
+ [[nodiscard]] std::chrono::time_point now() const
override {
+return std::chrono::steady_clock::time_point{timeSinceEpoch()};
+ }
+
+ void advance(std::chrono::milliseconds elapsed_time);
+ bool wait_until(std::condition_variable& cv, std::unique_lock&
lck, std::chrono::milliseconds time, const std::function& pred)
override;
+
+ private:
+ mutable std::mutex mtx_;
+ std::unordered_set cvs_;
+ std::chrono::milliseconds time_{0};
+};
+
+template
+bool verifyEventHappenedInPollTime(
+const std::chrono::duration& wait_duration,
+Fun&& check,
+std::chrono::microseconds check_interval = std::chrono::milliseconds(100))
{
+ std::chrono::steady_clock::time_point wait_end =
std::chrono::steady_clock::now() + wait_duration;
+ do {
+if (std::forward(check)()) {
+ return true;
+}
+std::this_thread::sleep_for(check_interval);
+ } while (std::chrono::steady_clock::now() < wait_end);
+ return false;
+}
+
+template
+bool verifyLogLinePresenceInPollTime(const std::chrono::duration&
wait_duration, String&&... patterns) {
+ auto check = [] {
+const std::string logs = LogTestController::getInstance().getLogs();
+return ((logs.find(patterns) != std::string::npos) && ...);
+ };
+ return verifyEventHappenedInPollTime(wait_duration, check);
+}
+
+template
+bool verifyLogLineVariantPresenceInPollTime(const std::chrono::duration& wait_duration, String&&... patterns) {
+ auto check = [] {
+const std::string logs = LogTestController::getInstance().getLogs();
+return ((logs.find(patterns) != std::string::npos) || ...);
+ };
+ return verifyEventHappenedInPollTime(wait_duration, check);
+}
+
+namespace internal {
+struct JsonContext {
+ const JsonContext *parent{nullptr};
+ std::string_view member;
+
+ std::string path() const {
+if (!parent) {
+ return "/";
+}
+return minifi::utils::string::join_pack(parent->path(), member, "/");
+ }
+};
+} // namespace internal
+
+#define REQUIRE_WARN(cond, msg) if (!(cond)) {WARN(msg); REQUIRE(cond);}
+
+// carries out a loose match on objects, i.e. it doesn't matter if the
+// actual object has extra fields than expected
+void matchJSON(const internal::JsonContext& ctx, const
[PR] [NIFI-13277] - Make the main menu more compact in terms of spacing. [nifi]
rfellows opened a new pull request, #8861: URL: https://github.com/apache/nifi/pull/8861 [NIFI-13277](https://issues.apache.org/jira/browse/NIFI-13277) Before: https://github.com/apache/nifi/assets/713866/cc768394-06c6-4fba-b914-41eedb255dda;> After: https://github.com/apache/nifi/assets/713866/5c427825-e604-455b-9e4e-a354b900837f;> With the changes, the menu (as of now) displays without the need for scrollbars until the displayable browser area gets below 570 pixels in height. Previously it needed more than 740px. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13278) Fix license file exclusion
Matt Gilman created NIFI-13278: -- Summary: Fix license file exclusion Key: NIFI-13278 URL: https://issues.apache.org/jira/browse/NIFI-13278 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman Changes introduced in NIFI-12902 inadvertently excluded the 3rdpartylicenses.txt file from being included in the resulting artifact. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on PR #8463: URL: https://github.com/apache/nifi/pull/8463#issuecomment-2123083750 > @greyp9 It looks like the latest changes are failing on integration tests due to property name changes. Thanks; pushed an update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
pvillard31 commented on PR #38: URL: https://github.com/apache/nifi-maven/pull/38#issuecomment-2123082949 PR for NiFi changes is here: https://github.com/apache/nifi/pull/8860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13267 - Bump NiFi NAR Maven plugin version [nifi]
pvillard31 opened a new pull request, #8860: URL: https://github.com/apache/nifi/pull/8860 # Summary [NIFI-13267](https://issues.apache.org/jira/browse/NIFI-13267) - Bump NiFi NAR Maven plugin version # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12967) Improve navigation to/from Canvas
[ https://issues.apache.org/jira/browse/NIFI-12967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12967: --- Status: Patch Available (was: In Progress) > Improve navigation to/from Canvas > - > > Key: NIFI-12967 > URL: https://issues.apache.org/jira/browse/NIFI-12967 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When leaving the Canvas (ie listing queue, viewing documentation, etc) the UI > should offer a more intuitive means to navigate back to where they were > before. Currently they must use the Global menu or click on the logo in the > header. However, these options are not necessarily obvious at first. The > browser back button also works but the UI should probably offer some in the > application. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
joewitt commented on PR #38: URL: https://github.com/apache/nifi-maven/pull/38#issuecomment-2123074094 I admit i've been slow to come around to it myself but i've started to see the light on why @exceptionfactory is so fond of it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
pvillard31 commented on PR #38: URL: https://github.com/apache/nifi-maven/pull/38#issuecomment-2123071926 OK, I didn't take the approach of using mvnw but I can do that to be consistent with NiFi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13277) Compact the main menu
[ https://issues.apache.org/jira/browse/NIFI-13277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13277: --- Description: The main menu has much padding. it makes it so large that on smaller resolutions the whole menu doesn't fit !image-2024-05-21-13-05-27-035.png|width=868,height=508! (was: The main menu has much padding. it makes it so large that on smaller resolutions the whole menu doesn't fit !image-2024-05-21-13-05-27-035.png!) > Compact the main menu > - > > Key: NIFI-13277 > URL: https://issues.apache.org/jira/browse/NIFI-13277 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Attachments: Screenshot 2024-05-21 at 1.05.17 PM.png, > image-2024-05-21-13-05-27-035.png > > > The main menu has much padding. it makes it so large that on smaller > resolutions the whole menu doesn't fit > !image-2024-05-21-13-05-27-035.png|width=868,height=508! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13277) Compact the main menu
Rob Fellows created NIFI-13277: -- Summary: Compact the main menu Key: NIFI-13277 URL: https://issues.apache.org/jira/browse/NIFI-13277 Project: Apache NiFi Issue Type: Sub-task Reporter: Rob Fellows Assignee: Rob Fellows Attachments: Screenshot 2024-05-21 at 1.05.17 PM.png, image-2024-05-21-13-05-27-035.png The main menu has much padding. it makes it so large that on smaller resolutions the whole menu doesn't fit !image-2024-05-21-13-05-27-035.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
joewitt commented on PR #38: URL: https://github.com/apache/nifi-maven/pull/38#issuecomment-2123062509 basically lets mvnw ensure the proper maven version is present -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
joewitt commented on PR #38:
URL: https://github.com/apache/nifi-maven/pull/38#issuecomment-2123061948
For the github ci change here is a form that should help
`name: build
on: [push, pull_request]
env:
MAVEN_COMMAND: ./mvnw
MAVEN_COMPILE_COMMAND: >-
verify
--batch-mode
--update-snapshots
--show-version
--no-snapshot-updates
--no-transfer-progress
--fail-fast
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
permissions:
security-events: write
contents: read
pull-requests: read
jobs:
build:
runs-on: ubuntu-latest
name: Ubuntu Correto JDK 21 EN
steps:
- name: Checkout Code
uses: actions/checkout@v4
- name: Set up Java 21
uses: actions/setup-java@v4
with:
distribution: 'corretto'
java-version: '21'
cache: 'maven'
- name: Build
run: >
${{ env.MAVEN_COMMAND }}
${{ env.MAVEN_COMPILE_COMMAND }}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
joewitt commented on PR #38: URL: https://github.com/apache/nifi-maven/pull/38#issuecomment-2123060860 ah ok thanks. can you share the PR for the nifi side so I can review that in context? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13126: Add Impala DB Adapter [nifi]
mattyb149 commented on PR #8728: URL: https://github.com/apache/nifi/pull/8728#issuecomment-2123057860 I didn't make them controller services at the time because they just didn't feel like controller services to me, they shouldn't need to be configured separately and just represent specific dialects of SQL. Having said that I'm not opposed to the idea if it makes sense going forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
pvillard31 commented on PR #38: URL: https://github.com/apache/nifi-maven/pull/38#issuecomment-2123052402 The NiFi issue is "expected". I have a PR ready with the changes on the NiFi side that are required in addition to bumping the plugin version. Will take care of the github workflow now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
joewitt commented on PR #38: URL: https://github.com/apache/nifi-maven/pull/38#issuecomment-2123049129 and github workflow needs updating Error: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.4.1:enforce (enforce-maven-version) on project nifi-nar-maven-plugin: Error: Rule 2: org.apache.maven.enforcer.rules.version.RequireMavenVersion failed with message: Error: Detected Maven Version: 3.8.8 is not in the allowed range [3.9.6,). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13274 - Dependencies and switch to 2.0.0-SNAPSHOT [nifi-maven]
joewitt commented on PR #38: URL: https://github.com/apache/nifi-maven/pull/38#issuecomment-2123047698 looks like we aren't quite there. A NiFi build with this results in `[INFO] --- exec:3.2.0:java (generate-runtime-manifest) @ nifi-runtime-manifest --- [org.apache.nifi.runtime.manifest.impl.RuntimeManifestGenerator.main()] INFO org.apache.nifi.runtime.manifest.impl.RuntimeManifestGenerator - Writing runtime manifest to: /Users/jwitt/development/nifi.git/nifi-manifest/nifi-runtime-manifest/target/classes/nifi-runtime-manifest.json [org.apache.nifi.runtime.manifest.impl.RuntimeManifestGenerator.main()] INFO org.apache.nifi.runtime.manifest.impl.DirectoryExtensionManifestProvider - Loading extension manifests from: /Users/jwitt/development/nifi.git/nifi-manifest/nifi-runtime-manifest/target/nifi-manifests [org.apache.nifi.runtime.manifest.impl.RuntimeManifestGenerator.main()] INFO org.apache.nifi.runtime.manifest.impl.DirectoryExtensionManifestProvider - Loaded 108 extension manifests [WARNING] java.lang.NullPointerException: Cannot invoke "org.apache.nifi.extension.manifest.ExtensionType.ordinal()" because the return value of "org.apache.nifi.extension.manifest.Extension.getType()" is null at org.apache.nifi.runtime.manifest.impl.StandardRuntimeManifestBuilder.addExtension (StandardRuntimeManifestBuilder.java:194) at org.apache.nifi.runtime.manifest.impl.StandardRuntimeManifestBuilder.lambda$addBundle$0 (StandardRuntimeManifestBuilder.java:146) at java.util.ArrayList.forEach (ArrayList.java:1596) at org.apache.nifi.runtime.manifest.impl.StandardRuntimeManifestBuilder.addBundle (StandardRuntimeManifestBuilder.java:144) at java.util.ArrayList.forEach (ArrayList.java:1596) at org.apache.nifi.runtime.manifest.impl.StandardRuntimeManifestBuilder.addBundles (StandardRuntimeManifestBuilder.java:157) at org.apache.nifi.runtime.manifest.impl.RuntimeManifestGenerator.execute (RuntimeManifestGenerator.java:109) at org.apache.nifi.runtime.manifest.impl.RuntimeManifestGenerator.main (RuntimeManifestGenerator.java:187) at org.codehaus.mojo.exec.ExecJavaMojo.doMain (ExecJavaMojo.java:385) at org.codehaus.mojo.exec.ExecJavaMojo.doExec (ExecJavaMojo.java:374) at org.codehaus.mojo.exec.ExecJavaMojo.lambda$execute$0 (ExecJavaMojo.java:296) at java.lang.Thread.run (Thread.java:1583)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13257] codemirror light and dark mode theme [nifi]
rfellows commented on code in PR #8855:
URL: https://github.com/apache/nifi/pull/8855#discussion_r1608579895
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_codemirror-theme.scss:
##
@@ -0,0 +1,227 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+@use 'sass:map';
+@use '@angular/material' as mat;
+
+@mixin generate-nifi-theme($material-theme, $nifi-theme) {
+// Get the color config from the theme.
+$material-theme-color-config: mat.get-color-config($material-theme);
+$nifi-theme-color-config: mat.get-color-config($nifi-theme);
+
+// Get the color palette from the color-config.
+$material-theme-primary-palette: map.get($material-theme-color-config,
'primary');
+$nifi-theme-surface-palette: map.get($nifi-theme-color-config, 'primary');
+$material-theme-accent-palette: map.get($material-theme-color-config,
'accent');
+
+// Get hues from palette
+$is-dark: map-get($nifi-theme-color-config, is-dark);
+
+$material-theme-primary-palette-lighter:
mat.get-color-from-palette($material-theme-primary-palette, lighter);
+$material-theme-primary-palette-darker:
mat.get-color-from-palette($material-theme-primary-palette, darker);
+$material-theme-primary-palette-default:
mat.get-color-from-palette($material-theme-primary-palette, default);
+
+$nifi-theme-surface-palette-default:
mat.get-color-from-palette($nifi-theme-surface-palette, default);
+$nifi-theme-surface-palette-lighter:
mat.get-color-from-palette($nifi-theme-surface-palette, lighter);
+$nifi-theme-surface-palette-darker:
mat.get-color-from-palette($nifi-theme-surface-palette, darker);
+$nifi-theme-surface-palette-darker-contrast: mat.get-color-from-palette(
+$nifi-theme-surface-palette,
+darker-contrast
+);
+$nifi-theme-surface-palette-lighter-contrast: mat.get-color-from-palette(
+$nifi-theme-surface-palette,
+lighter-contrast
+);
+
+.cm-s-nifi.CodeMirror {
+@extend .surface-contrast;
+background-color: if($is-dark, $nifi-theme-surface-palette-darker,
$nifi-theme-surface-palette-lighter);
+border: 1px solid var(--mdc-outlined-text-field-label-text-color);
+}
+
+.cm-s-nifi .CodeMirror-gutters {
+background: if($is-dark, #3b3b3b, #efefef);
+}
+
+.cm-s-nifi .CodeMirror-guttermarker,
+.cm-s-nifi .CodeMirror-guttermarker-subtle,
+.cm-s-nifi .CodeMirror-linenumber {
+color: if($is-dark, #bb, #b4b4b4);
+}
+
+.cm-s-nifi .CodeMirror-cursor {
+border-left: 1px solid
+if($is-dark, $nifi-theme-surface-palette-darker-contrast,
$nifi-theme-surface-palette-lighter-contrast);
+}
+
+.cm-s-nifi div.CodeMirror-selected {
+background: if(
+$is-dark,
+rgba($material-theme-primary-palette-default, 0.4),
+rgba($material-theme-primary-palette-darker, 0.4)
+);
+}
+
+.cm-s-nifi.CodeMirror-focused div.CodeMirror-selected {
+background: if(
+$is-dark,
+rgba($material-theme-primary-palette-default, 0.4),
+rgba($material-theme-primary-palette-darker, 0.4)
+);
+}
+
+.cm-s-nifi .CodeMirror-line::selection,
+.cm-s-nifi .CodeMirror-line > span::selection,
+.cm-s-nifi .CodeMirror-line > span > span::selection {
+background: if($is-dark, rgba(128, 203, 196, 0.2), rgba(128, 203, 196,
0.8));
+}
+
+.cm-s-nifi .CodeMirror-line::-moz-selection,
+.cm-s-nifi .CodeMirror-line > span::-moz-selection,
+.cm-s-nifi .CodeMirror-line > span > span::-moz-selection {
+background: if($is-dark, rgba(128, 203, 196, 0.2), rgba(128, 203, 196,
0.8));
+}
+
+.cm-s-nifi .cm-header {
+color: if($is-dark, #b8b8ff, #ff);
+}
+
+.cm-s-nifi .cm-quote {
+color: if($is-dark, #6bfd6b, #009400);
+}
+
+.cm-s-nifi .cm-negative {
+color: if($is-dark, #fc9797, #de3535);
+}
+
+.cm-s-nifi .cm-positive {
+color: if($is-dark, #8cfd8c, #219a21);
+}
+
+.cm-s-nifi .cm-bracket {
+color: if($is-dark, #93937c, #93937c);
+}
+
+
[PR] NIFI-12967: Introducing Back action [nifi]
mcgilman opened a new pull request, #8859: URL: https://github.com/apache/nifi/pull/8859 NIFI-12967: - Adding support for navigating back to the users previous location in certain circumstances like going to a Controller Service, managing access policies, going to parameters, viewing documentation, opening advanced UIs, and viewing data provenance. - Cleaning unnecessary instances of postUpdateNavigation. The scenarios mentioned in the commit message above have a slightly different UX from the existing application. In the old UI, these actions would open in a large modal on top of the current component. When the user was done they could return to where they were by closing the modal. In the new UI, the user currently needs to use their browser back button as the application did not directly offer a back option. This PR introduces that back option but only in the cases identified above. Scenarios outside of this (other links in the application like Referencing Components) are not included here but could be considered in the future as a further improvement over the old UI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13274) Dependencies housekeeping for NiFi NAR Maven plugin
[ https://issues.apache.org/jira/browse/NIFI-13274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13274: -- Status: Patch Available (was: Open) > Dependencies housekeeping for NiFi NAR Maven plugin > --- > > Key: NIFI-13274 > URL: https://issues.apache.org/jira/browse/NIFI-13274 > Project: Apache NiFi > Issue Type: Task >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: nifi-nar-maven-plugin-2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Dependencies housekeeping for NiFi NAR Maven plugin > Also fixing the SNAPSHOT version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13268) ConsumeGCPPubSub Stopped Working with M3
[
https://issues.apache.org/jira/browse/NIFI-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi reassigned NIFI-13268:
--
Assignee: Peter Turcsanyi
> ConsumeGCPPubSub Stopped Working with M3
>
>
> Key: NIFI-13268
> URL: https://issues.apache.org/jira/browse/NIFI-13268
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Emin
>Assignee: Peter Turcsanyi
>Priority: Major
>
> After updating from 1.26 to 2.0.0M3, getting the following for
> `ConsumeGCPPubSub`
>
> {{nifi-1 | 2024-05-18 23:00:02,157 INFO [NiFi Web Server-405]
> o.a.n.c.s.StandardProcessScheduler Running once
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] nifi-1 | 2024-05-18
> 23:00:02,158 INFO [NiFi Web Server-405]
> o.a.n.controller.StandardProcessorNode Starting
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] nifi-1 | 2024-05-18
> 23:00:02,170 ERROR [Timer-Driven Process Thread-1]
> o.a.n.p.gcp.pubsub.ConsumeGCPubSub
> ConsumeGCPubSub[id=890ffc25-018f-1000-f9bc-b29966db3fc6] Failed to properly
> initialize Processor. If still scheduled to run, NiFi will attempt to
> initialize and run the Processor again after the 'Administrative Yield
> Duration' has elapsed. Failure is due to java.util.ServiceConfigurationError:
> io.grpc.ManagedChannelProvider:
> io.grpc.netty.shaded.io.grpc.netty.UdsNettyChannelProvider Unable to get
> public no-arg constructor nifi-1 | java.util.ServiceConfigurationError:
> io.grpc.ManagedChannelProvider:
> io.grpc.netty.shaded.io.grpc.netty.UdsNettyChannelProvider Unable to get
> public no-arg constructor nifi-1 | at
> java.base/java.util.ServiceLoader.fail(ServiceLoader.java:586) nifi-1 | at
> java.base/java.util.ServiceLoader.getConstructor(ServiceLoader.java:679)
> nifi-1 | at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1240)
> nifi-1 | at
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
> nifi-1 | at
> java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309) nifi-1 |
> at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
> nifi-1 | at io.grpc.ServiceProviders.loadAll(ServiceProviders.java:67) nifi-1
> | at
> io.grpc.ManagedChannelRegistry.getDefaultRegistry(ManagedChannelRegistry.java:101)
> nifi-1 | at
> io.grpc.ManagedChannelProvider.provider(ManagedChannelProvider.java:43)
> nifi-1 | at
> io.grpc.ManagedChannelBuilder.forAddress(ManagedChannelBuilder.java:44)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.createSingleChannel(InstantiatingGrpcChannelProvider.java:404)
> nifi-1 | at com.google.api.gax.grpc.ChannelPool.(ChannelPool.java:107)
> nifi-1 | at com.google.api.gax.grpc.ChannelPool.create(ChannelPool.java:85)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.createChannel(InstantiatingGrpcChannelProvider.java:243)
> nifi-1 | at
> com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.getTransportChannel(InstantiatingGrpcChannelProvider.java:237)
> nifi-1 | at
> com.google.api.gax.rpc.ClientContext.create(ClientContext.java:230) nifi-1 |
> at
> com.google.cloud.pubsub.v1.stub.GrpcSubscriberStub.create(GrpcSubscriberStub.java:287)
> nifi-1 | at
> org.apache.nifi.processors.gcp.pubsub.ConsumeGCPubSub.getSubscriber(ConsumeGCPubSub.java:286)
> nifi-1 | at
> org.apache.nifi.processors.gcp.pubsub.ConsumeGCPubSub.onScheduled(ConsumeGCPubSub.java:134)
> nifi-1 | at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> nifi-1 | at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
> nifi-1 | at
> org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
> nifi-1 | at
> org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$10(StandardProcessorNode.java:1668)
> nifi-1 | at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
> nifi-1 | at
> java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) nifi-1 |
> at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
> nifi-1 | at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> nifi-1 | at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> nifi-1 | at
[jira] [Created] (NIFI-13276) Property value editor's initial size can be too large to fit on the screen.
Rob Fellows created NIFI-13276: -- Summary: Property value editor's initial size can be too large to fit on the screen. Key: NIFI-13276 URL: https://issues.apache.org/jira/browse/NIFI-13276 Project: Apache NiFi Issue Type: Sub-task Reporter: Rob Fellows Attachments: Kapture 2024-05-21 at 11.32.14.gif, image-2024-05-21-11-33-09-566.png If the value of a property is many many lines long, when you open the editor the next time it extends beyond the screen and you can't scroll !image-2024-05-21-11-33-09-566.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-10964) FetchSmb Processor should have the option to delete file after being fetched
[ https://issues.apache.org/jira/browse/NIFI-10964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi resolved NIFI-10964. Resolution: Duplicate > FetchSmb Processor should have the option to delete file after being fetched > > > Key: NIFI-10964 > URL: https://issues.apache.org/jira/browse/NIFI-10964 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Sam Williams >Priority: Minor > > It would be good to have the option to delete a file once the FetchSmb > processor has collected the file. This could either be a whole new processor, > or just a property on the existing FetSmb processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
exceptionfactory commented on PR #8463: URL: https://github.com/apache/nifi/pull/8463#issuecomment-2122889110 @greyp9 It looks like the latest changes are failing on integration tests due to property name changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13273) Release NiFi NAR Maven Plugin 2.0.0
[ https://issues.apache.org/jira/browse/NIFI-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13273: -- Summary: Release NiFi NAR Maven Plugin 2.0.0 (was: Release NiFi NAR Maven Plugin 1.6.0) > Release NiFi NAR Maven Plugin 2.0.0 > --- > > Key: NIFI-13273 > URL: https://issues.apache.org/jira/browse/NIFI-13273 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Affects Versions: nifi-nar-maven-plugin-1.6.0 >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: nifi-nar-maven-plugin-1.6.0 > > > Release NiFi NAR Maven Plugin 1.6.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-13259) Publish NiFi Stateless Assembly to Maven
[ https://issues.apache.org/jira/browse/NIFI-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-13259. - Fix Version/s: 2.0.0-M4 Assignee: Bob Paulin Resolution: Fixed > Publish NiFi Stateless Assembly to Maven > > > Key: NIFI-13259 > URL: https://issues.apache.org/jira/browse/NIFI-13259 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bob Paulin >Assignee: Bob Paulin >Priority: Minor > Fix For: 2.0.0-M4 > > Time Spent: 20m > Remaining Estimate: 0h > > I'd like to do some integration test work with flow files using the nifi > stateless assembly zip. Would like this published to maven to allow this to > work using unit tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13255) Replace deprecated io.netty.handler.ssl.JdkSslContext constructor with API suggested replacement
[ https://issues.apache.org/jira/browse/NIFI-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13255: Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Replace deprecated io.netty.handler.ssl.JdkSslContext constructor with API > suggested replacement > > > Key: NIFI-13255 > URL: https://issues.apache.org/jira/browse/NIFI-13255 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Fix For: 2.0.0-M4 > > Time Spent: 20m > Remaining Estimate: 0h > > Fix should be applied to > nifi-extension-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13259) Publish NiFi Stateless Assembly to Maven
[ https://issues.apache.org/jira/browse/NIFI-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13259: Summary: Publish NiFi Stateless Assembly to Maven (was: Publish NiFi Stateless to Maven) > Publish NiFi Stateless Assembly to Maven > > > Key: NIFI-13259 > URL: https://issues.apache.org/jira/browse/NIFI-13259 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M3 >Reporter: Bob Paulin >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > I'd like to do some integration test work with flow files using the nifi > stateless assembly zip. Would like this published to maven to allow this to > work using unit tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13259) Publish NiFi Stateless Assembly to Maven
[ https://issues.apache.org/jira/browse/NIFI-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13259: Affects Version/s: (was: 2.0.0-M3) > Publish NiFi Stateless Assembly to Maven > > > Key: NIFI-13259 > URL: https://issues.apache.org/jira/browse/NIFI-13259 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bob Paulin >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > I'd like to do some integration test work with flow files using the nifi > stateless assembly zip. Would like this published to maven to allow this to > work using unit tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13259) Publish NiFi Stateless to Maven
[ https://issues.apache.org/jira/browse/NIFI-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848249#comment-17848249 ] ASF subversion and git services commented on NIFI-13259: Commit 59eae00847fcdaa5c44fa9acafcb5ef91905b980 in nifi's branch refs/heads/main from Bob Paulin [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=59eae00847 ] NIFI-13259 Enabled publishing nifi-stateless-assembly to Maven This closes #8844 Signed-off-by: David Handermann > Publish NiFi Stateless to Maven > --- > > Key: NIFI-13259 > URL: https://issues.apache.org/jira/browse/NIFI-13259 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M3 >Reporter: Bob Paulin >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > I'd like to do some integration test work with flow files using the nifi > stateless assembly zip. Would like this published to maven to allow this to > work using unit tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13255) Replace deprecated io.netty.handler.ssl.JdkSslContext constructor with API suggested replacement
[ https://issues.apache.org/jira/browse/NIFI-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848250#comment-17848250 ] ASF subversion and git services commented on NIFI-13255: Commit e12a2dd39ef18857c85314419d5350d8bbb2265e in nifi's branch refs/heads/main from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e12a2dd39e ] NIFI-13255 Replaced deprecated Netty JdkSslContext constructor This closes #8856 Signed-off-by: David Handermann > Replace deprecated io.netty.handler.ssl.JdkSslContext constructor with API > suggested replacement > > > Key: NIFI-13255 > URL: https://issues.apache.org/jira/browse/NIFI-13255 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Fix should be applied to > nifi-extension-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13255 Replaced deprecated io.netty.handler.ssl.JdkSslContext constructor with API suggested replacement [nifi]
exceptionfactory closed pull request #8856: NIFI-13255 Replaced deprecated io.netty.handler.ssl.JdkSslContext constructor with API suggested replacement URL: https://github.com/apache/nifi/pull/8856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13259 - Enable publishing of Nifi Stateless to Maven Repo. [nifi]
exceptionfactory closed pull request #8844: NIFI-13259 - Enable publishing of Nifi Stateless to Maven Repo. URL: https://github.com/apache/nifi/pull/8844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-13275 Remove web.xml from nifi-web-frontend [nifi]
mcgilman commented on PR #8858: URL: https://github.com/apache/nifi/pull/8858#issuecomment-2122828725 Will remove... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-11078) Add Component UUID to Flow Configuration History viewable table
[ https://issues.apache.org/jira/browse/NIFI-11078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sue Kim reassigned NIFI-11078: -- Assignee: Sue Kim > Add Component UUID to Flow Configuration History viewable table > --- > > Key: NIFI-11078 > URL: https://issues.apache.org/jira/browse/NIFI-11078 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Sue Kim >Priority: Major > > The Flow Configuration History table provides the component name but not the > component UUID directly in the viewable table except via the "View Details" > icon link. There are often many processors on the canvas with the same name > and it is impossible to differentiate between two of the same name unless you > apply a filter on the id. Sometimes the component id is unknown (for instance > when it was removed from the canvas) and so there is no way to apply the > filter. Being able to view and sort by component id would be helpful. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13275) Remove web.xml from nifi-web-frontend
[ https://issues.apache.org/jira/browse/NIFI-13275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13275: Status: Patch Available (was: Open) > Remove web.xml from nifi-web-frontend > - > > Key: NIFI-13275 > URL: https://issues.apache.org/jira/browse/NIFI-13275 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Following recent changes in nifi-web-frontend to remove the need for Servlet > Filters, the Servlet configuration in web.xml is no longer needed. With the > frontend code relying exclusively on REST API calls to nifi-web-api, the > web.xml configuration and nifi-web-utils dependencies are no longer required. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13275 Remove web.xml from nifi-web-frontend [nifi]
exceptionfactory opened a new pull request, #8858: URL: https://github.com/apache/nifi/pull/8858 # Summary [NIFI-13275](https://issues.apache.org/jira/browse/NIFI-13275) Removes `web.xml` Servlet configuration from `nifi-web-frontend` along with the unnecessary dependency on `nifi-web-utils`. Following updates for [NIFI-12968](https://issues.apache.org/jira/browse/NIFI-12968) to use REST API requests for handling login and logout redirection, the `nifi-web-frontend` module no longer requires a custom Servlet configuration. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13275) Remove web.xml from nifi-web-frontend
David Handermann created NIFI-13275: --- Summary: Remove web.xml from nifi-web-frontend Key: NIFI-13275 URL: https://issues.apache.org/jira/browse/NIFI-13275 Project: Apache NiFi Issue Type: Improvement Components: Core UI Reporter: David Handermann Assignee: David Handermann Following recent changes in nifi-web-frontend to remove the need for Servlet Filters, the Servlet configuration in web.xml is no longer needed. With the frontend code relying exclusively on REST API calls to nifi-web-api, the web.xml configuration and nifi-web-utils dependencies are no longer required. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13257] codemirror light and dark mode theme [nifi]
rfellows commented on PR #8855: URL: https://github.com/apache/nifi/pull/8855#issuecomment-2122801839 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13247) Property Verification
[ https://issues.apache.org/jira/browse/NIFI-13247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13247: --- Status: Patch Available (was: In Progress) > Property Verification > - > > Key: NIFI-13247 > URL: https://issues.apache.org/jira/browse/NIFI-13247 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13247] - Property Verification [nifi]
rfellows opened a new pull request, #8857: URL: https://github.com/apache/nifi/pull/8857 [NIFI-13247](https://issues.apache.org/jira/browse/NIFI-13247) Added property verification to * Edit parameters * Edit controller services * Edit management controller services * Edit reporting tasks * Edit flow analysis rules * Edit parameter providers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2312 Reduce shared_ptr usage for controller services [nifi-minifi-cpp]
martinzink closed pull request #1771: MINIFICPP-2312 Reduce shared_ptr usage for controller services URL: https://github.com/apache/nifi-minifi-cpp/pull/1771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2383 update phoenix-actions/test-reporting to v15 [nifi-minifi-cpp]
martinzink closed pull request #1795: MINIFICPP-2383 update phoenix-actions/test-reporting to v15 URL: https://github.com/apache/nifi-minifi-cpp/pull/1795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2340 - Increment wix version to latest available on github runner image [nifi-minifi-cpp]
martinzink closed pull request #1761: MINIFICPP-2340 - Increment wix version to latest available on github runner image URL: https://github.com/apache/nifi-minifi-cpp/pull/1761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2381 Update inquirer package for python 3.12 support [nifi-minifi-cpp]
martinzink closed pull request #1790: MINIFICPP-2381 Update inquirer package for python 3.12 support URL: https://github.com/apache/nifi-minifi-cpp/pull/1790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
