[jira] [Created] (NIFI-13291) NiFi GetFile processor is functioning erratically
Uday Kumar created NIFI-13291: - Summary: NiFi GetFile processor is functioning erratically Key: NIFI-13291 URL: https://issues.apache.org/jira/browse/NIFI-13291 Project: Apache NiFi Issue Type: Bug Components: Configuration, NiFi Registry Affects Versions: 1.21.0 Environment: Prod Env (Linux, Java 11, Linux/Unix, instance type : m5.2xlarge, Volume size 700 GB EBS) Reporter: Uday Kumar Attachments: Configuration Properties tab.JPG, Configuration Scheduling Tab.JPG, Configuration Setting Tab.JPG, Nifi Processor Group.JPG I have a NiFi flow in which GetFile processor gets the txt file from local folder, as per configured cron schedule, which is further used for downloading the PDF files. I have observed that NiFi requires a restart before the cron job time of GetFile processor. If NiFi is not restarted, the txt file does not get picked up as per cron schedule. I have not encountered any issues in manual processing (run once) of the GetFile processor. I can't find anything on the log. The log file is printed as if nothing was scheduled for that particular time. It's simply skipping the timing and continuing. I'm using Apache NiFi version 1.21.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13231) Update GitHubFlowRegistryClient to generate App Installation Token
[ https://issues.apache.org/jira/browse/NIFI-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849148#comment-17849148 ] Vansh Chaudhary commented on NIFI-13231: [~exceptionfactory] Starting my contribution to NIFI community with this, Working on this for a day now and i would be grateful if you would review my code. > Update GitHubFlowRegistryClient to generate App Installation Token > -- > > Key: NIFI-13231 > URL: https://issues.apache.org/jira/browse/NIFI-13231 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M3 >Reporter: Brian Ghigiarelli >Assignee: Vansh Chaudhary >Priority: Major > > The new GitHubFlowRegistryClient accepts two types of authentication: > # Personal Access Token > # App Installation Token > The App Installation Token requires the user to input the token as a > property, then uses that to communicate with GitHub. However, this token is > short-lived and would require frequent updates (~hourly). > Instead of directly providing the token, the GitHubFlowRegistryClient should > accept as properties: > # App ID > # Private Key (PEM text format) > and use these values to generate a short-lived token, following the guide at > https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app#generating-a-json-web-token-jwt -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13289 Add tooltip to NewCanvas item [nifi]
zeevo opened a new pull request, #8870: URL: https://github.com/apache/nifi/pull/8870 # Summary [NIFI-13289](https://issues.apache.org/jira/browse/NIFI-13289) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### UI Contributions - [x] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12983: Qdrant vector store support [nifi]
Anush008 commented on PR #8590: URL: https://github.com/apache/nifi/pull/8590#issuecomment-2128392260 I am unsure if the failing test is related to the changes in this PR. Doesn't look like it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12967: Introducing Back action [nifi]
scottyaslan commented on code in PR #8859:
URL: https://github.com/apache/nifi/pull/8859#discussion_r1612591011
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/navigation/navigation.reducer.ts:
##
@@ -28,7 +28,14 @@ export const navigationReducer = createReducer(
initialState,
on(pushBackNavigation, (state, { backNavigation }) => {
return produce(state, (draftState) => {
-draftState.backNavigations.push(backNavigation);
+if (draftState.backNavigations.length > 0) {
Review Comment:
Looks like there is still a bug in here:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12967: Introducing Back action [nifi]
mcgilman commented on code in PR #8859:
URL: https://github.com/apache/nifi/pull/8859#discussion_r1612409434
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##
@@ -1392,14 +1478,7 @@ export class FlowEffects {
.subscribe((updateProcessorRequest:
UpdateProcessorRequest) => {
this.store.dispatch(
FlowActions.updateProcessor({
-request: {
-id: processorId,
-uri: request.uri,
-type: request.type,
-payload:
updateProcessorRequest.payload,
-errorStrategy: 'banner',
-postUpdateNavigation:
updateProcessorRequest.postUpdateNavigation
-}
+request: updateProcessorRequest
})
);
});
Review Comment:
@scottyaslan Thanks for filing the JIRA. Agreed that is an issue with our
dialog close handling when the user navigates forward/back with their browsers.
The other scenario looks like a bug in the logic when a new back navigation is
pushed that is introduced in this PR. I think simply avoid pushing a duplicate
back navigation would address this case. Great idea. Let me prep another commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13290) Dialog close on route navigation causes extra selection route to fire and browser history to be removed
[ https://issues.apache.org/jira/browse/NIFI-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13290: --- Attachment: example2.gif > Dialog close on route navigation causes extra selection route to fire and > browser history to be removed > --- > > Key: NIFI-13290 > URL: https://issues.apache.org/jira/browse/NIFI-13290 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Priority: Major > Attachments: Kapture 2024-05-22 at 17.24.17.gif, example2.gif > > > https://github.com/apache/nifi/pull/8859#discussion_r1612046025 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12967: Introducing Back action [nifi]
scottyaslan commented on code in PR #8859:
URL: https://github.com/apache/nifi/pull/8859#discussion_r1612402084
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##
@@ -1392,14 +1478,7 @@ export class FlowEffects {
.subscribe((updateProcessorRequest:
UpdateProcessorRequest) => {
this.store.dispatch(
FlowActions.updateProcessor({
-request: {
-id: processorId,
-uri: request.uri,
-type: request.type,
-payload:
updateProcessorRequest.payload,
-errorStrategy: 'banner',
-postUpdateNavigation:
updateProcessorRequest.postUpdateNavigation
-}
+request: updateProcessorRequest
})
);
});
Review Comment:
https://issues.apache.org/jira/browse/NIFI-13290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13290) Dialog close on route navigation causes extra selection route to fire and browser history to be removed
[ https://issues.apache.org/jira/browse/NIFI-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13290: --- Attachment: Kapture 2024-05-22 at 17.24.17.gif > Dialog close on route navigation causes extra selection route to fire and > browser history to be removed > --- > > Key: NIFI-13290 > URL: https://issues.apache.org/jira/browse/NIFI-13290 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Priority: Major > Attachments: Kapture 2024-05-22 at 17.24.17.gif > > > https://github.com/apache/nifi/pull/8859#discussion_r1612046025 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13290) Dialog close on route navigation causes extra selection route to fire and browser history to be removed
[ https://issues.apache.org/jira/browse/NIFI-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13290: --- Description: https://github.com/apache/nifi/pull/8859#discussion_r1612046025 > Dialog close on route navigation causes extra selection route to fire and > browser history to be removed > --- > > Key: NIFI-13290 > URL: https://issues.apache.org/jira/browse/NIFI-13290 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Priority: Major > > https://github.com/apache/nifi/pull/8859#discussion_r1612046025 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12967: Introducing Back action [nifi]
scottyaslan commented on code in PR #8859:
URL: https://github.com/apache/nifi/pull/8859#discussion_r1612046025
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##
@@ -1392,14 +1478,7 @@ export class FlowEffects {
.subscribe((updateProcessorRequest:
UpdateProcessorRequest) => {
this.store.dispatch(
FlowActions.updateProcessor({
-request: {
-id: processorId,
-uri: request.uri,
-type: request.type,
-payload:
updateProcessorRequest.payload,
-errorStrategy: 'banner',
-postUpdateNavigation:
updateProcessorRequest.postUpdateNavigation
-}
+request: updateProcessorRequest
})
);
});
Review Comment:
Something strange is happening to the browser history when the browser
forward/back navigation is used to close a dialog:
Here is another example:
This behavior is present on master so it is not related to this PR. We
should file another jira to address this. We need to add handling for the
browser forward/backward close dialog navigation as well as handling the 'Esc'
button to close the dialog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13290) Dialog close on route navigation causes extra selection route to fire and browser history to be removed
Scott Aslan created NIFI-13290: -- Summary: Dialog close on route navigation causes extra selection route to fire and browser history to be removed Key: NIFI-13290 URL: https://issues.apache.org/jira/browse/NIFI-13290 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13289) Add tooltip to NewCanvas item
[ https://issues.apache.org/jira/browse/NIFI-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane O'Neill reassigned NIFI-13289: Assignee: Shane O'Neill > Add tooltip to NewCanvas item > - > > Key: NIFI-13289 > URL: https://issues.apache.org/jira/browse/NIFI-13289 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Shane O'Neill >Priority: Major > Attachments: Screenshot 2024-05-23 at 2.36.55 PM.png > > > Old NiFi UI had tooltips for the new canvas items in the top bar. These are > currently missing in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12226) Maven plugin: Add flag to skip doc generation
[ https://issues.apache.org/jira/browse/NIFI-12226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12226: Fix Version/s: nifi-nar-maven-plugin-2.0.0 > Maven plugin: Add flag to skip doc generation > - > > Key: NIFI-12226 > URL: https://issues.apache.org/jira/browse/NIFI-12226 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Nicolò Boschi >Priority: Minor > Fix For: nifi-nar-maven-plugin-2.0.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > In [LangStream/langstream|https://github.com/LangStream/langstream] we use > this plugin for producing NAR files. The NAR are then ingested by the > LangStream runtime and the documentation is not needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12226) Maven plugin: Add flag to skip doc generation
[ https://issues.apache.org/jira/browse/NIFI-12226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12226: Fix Version/s: (was: nifi-nar-maven-plugin-2.0.0) > Maven plugin: Add flag to skip doc generation > - > > Key: NIFI-12226 > URL: https://issues.apache.org/jira/browse/NIFI-12226 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Nicolò Boschi >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > In [LangStream/langstream|https://github.com/LangStream/langstream] we use > this plugin for producing NAR files. The NAR are then ingested by the > LangStream runtime and the documentation is not needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13191) Deprecate InvokeAWSGatewayApi Processor
[ https://issues.apache.org/jira/browse/NIFI-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849085#comment-17849085 ] David Handermann commented on NIFI-13191: - Thanks for following up [~chien]. The processor was using an older version of the AWS SDK 1, and the level of abstraction was not a good fit for a maintainable Processor. The binaries and source for earlier versions are available, which is an option if you would like to maintain your own version. On the other hand, it would be helpful to create new Jira issues describing the more specific Processors, such as one for sending messages using Amazon SES. > Deprecate InvokeAWSGatewayApi Processor > --- > > Key: NIFI-13191 > URL: https://issues.apache.org/jira/browse/NIFI-13191 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Minor > Fix For: 1.27.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Similar to the other AWS client library upgrade issues, this targets the > InvokeAWSGatewayApi processor. > Note: After discussing with [~exceptionfactory] and [~otto], we agree that > this processor can be deprecated, and removed in NiFi 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13267 - Bump NiFi NAR Maven plugin version [nifi]
pvillard31 commented on code in PR #8860: URL: https://github.com/apache/nifi/pull/8860#discussion_r1612158954 ## nifi-manifest/nifi-runtime-manifest-core/src/main/java/org/apache/nifi/runtime/manifest/impl/StandardComponentManifestBuilder.java: ## @@ -33,6 +35,8 @@ public class StandardComponentManifestBuilder implements ComponentManifestBuilde private final List processors = new ArrayList<>(); private final List controllerServices = new ArrayList<>(); private final List reportingTasks = new ArrayList<>(); +private final List parameterProviders = new ArrayList<>(); +private final List flowAnalysisRules = new ArrayList<>(); Review Comment: Good catch @bbende - pushed a commit to add this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13288) Fix SplitJson, SplitXml, and SplitAvro processors not to call session.putAttribute multiple times
[ https://issues.apache.org/jira/browse/NIFI-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13288: Description: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to session.putAttribute which leads to potentially a huge amount of garbage getting created. Some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls session.putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. Per Mark's advice, these should be fixed to to populate the attributes in a Map and then make one call to session.putAllAttributes. was: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to session.putAttribute which leads to potentially a huge amount of garbage getting created. Some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls session.putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. Per Mark's advice, these should be fixed to to populate the attributes in a Map and then make one call to session.putAttributes. > Fix SplitJson, SplitXml, and SplitAvro processors not to call > session.putAttribute multiple times > - > > Key: NIFI-13288 > URL: https://issues.apache.org/jira/browse/NIFI-13288 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > > Per [~markap14] in the following > [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one > should avoid calling session.putAttribute many times since in order to > maintain object immutability it has to create a new FlowFile object (and a > new HashMap of all attributes!) > for every call to session.putAttribute which leads to potentially a huge > amount of garbage getting created. Some of the split processors SplitJson, > SplitXml, and SplitAvro all have loops to create a new flow file for each > split and it calls session.putAttribute more than once (in order to populate > the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file > created. Per Mark's advice, these should be fixed to to populate the > attributes in a Map and then make one call to session.putAllAttributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13289) Add tooltip to NewCanvas item
[ https://issues.apache.org/jira/browse/NIFI-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13289: --- Attachment: Screenshot 2024-05-23 at 2.36.55 PM.png > Add tooltip to NewCanvas item > - > > Key: NIFI-13289 > URL: https://issues.apache.org/jira/browse/NIFI-13289 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Priority: Major > Attachments: Screenshot 2024-05-23 at 2.36.55 PM.png > > > Old NiFi UI had tooltips for the new canvas items in the top bar. These are > currently missing in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13289) Add tooltip to NewCanvas item
Matt Gilman created NIFI-13289: -- Summary: Add tooltip to NewCanvas item Key: NIFI-13289 URL: https://issues.apache.org/jira/browse/NIFI-13289 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Old NiFi UI had tooltips for the new canvas items in the top bar. These are currently missing in the new UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable [nifi]
jrsteinebrey commented on PR #7544: URL: https://github.com/apache/nifi/pull/7544#issuecomment-2127792570 Thanks for the changes you made. Some other files in this PR now have checkstyle violations: Warning: src/main/java/org/apache/nifi/processors/standard/db/TableSchema.java:[155,47] (whitespace) WhitespaceAround: '!=' is not followed by whitespace. Warning: src/main/java/org/apache/nifi/processors/standard/db/TableSchema.java:[155,47] (whitespace) WhitespaceAround: '!=' is not preceded with whitespace. Warning: src/test/java/org/apache/nifi/processors/standard/db/impl/TestOracleDatabaseAdapter.java:[124,122] (whitespace) WhitespaceAfter: ',' is not followed by whitespace. Warning: src/test/java/org/apache/nifi/processors/standard/db/impl/TestOracle12DatabaseAdapter.java:[166,122] (whitespace) WhitespaceAfter: ',' is not followed by whitespace. Warning: src/test/java/org/apache/nifi/processors/standard/PutDatabaseRecordTest.java:[1832,11] (whitespace) WhitespaceAfter: 'catch' is not followed by whitespace. Warning: src/test/java/org/apache/nifi/processors/standard/PutDatabaseRecordTest.java:[1832,11] (whitespace) WhitespaceAround: 'catch' is not followed by whitespace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11658) Streamline using single parameter context for nested PGs
[ https://issues.apache.org/jira/browse/NIFI-11658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-11658: -- Fix Version/s: 1.27.0 > Streamline using single parameter context for nested PGs > > > Key: NIFI-11658 > URL: https://issues.apache.org/jira/browse/NIFI-11658 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Timea Barna >Assignee: Timea Barna >Priority: Major > Fix For: 2.0.0-M1, 1.27.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > 1. when adding a new process group to the canvas, in the create PG view where > one should give the name of the process group, add a drop down menu to select > the parameter context to associate with the process group. It would default > to the parameter context associated to the parent process group (if there is > one specified and if the user has the permissions) > 2. in the configuration view of a process group, add a dedicated tab for > parameter context to have dedicated handling. In addition to the dropdown > menu for selecting a parameter context, add a checkbox to recursively apply > the change. This checkbox would only be used when clicking "Apply", it would > not be persisted. If checked, it means that the parameter context will be > applied to the process group as well to all the embedded process groups > (recursively) if and only if the user has the proper permissions on all > process groups. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11658) Streamline using single parameter context for nested PGs
[ https://issues.apache.org/jira/browse/NIFI-11658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849065#comment-17849065 ] ASF subversion and git services commented on NIFI-11658: Commit 4aae517cca997b12e254a7778199a6fe048d2439 in nifi's branch refs/heads/support/nifi-1.x from Timea Barna [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4aae517cca ] NIFI-11658 Streamline using single Parameter Context for nested PGs Including applicable modifications from NIFI-12101 by Mark Payne This closes #7353 Co-authored-by: Matt Gilman Signed-off-by: David Handermann (cherry picked from commit 42910e80d1d0a71c8f3de51bdd5c6dd0183da26d) Signed-off-by: Pierre Villard This closes #8868. > Streamline using single parameter context for nested PGs > > > Key: NIFI-11658 > URL: https://issues.apache.org/jira/browse/NIFI-11658 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Timea Barna >Assignee: Timea Barna >Priority: Major > Fix For: 2.0.0-M1 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > 1. when adding a new process group to the canvas, in the create PG view where > one should give the name of the process group, add a drop down menu to select > the parameter context to associate with the process group. It would default > to the parameter context associated to the parent process group (if there is > one specified and if the user has the permissions) > 2. in the configuration view of a process group, add a dedicated tab for > parameter context to have dedicated handling. In addition to the dropdown > menu for selecting a parameter context, add a checkbox to recursively apply > the change. This checkbox would only be used when clicking "Apply", it would > not be persisted. If checked, it means that the parameter context will be > applied to the process group as well to all the embedded process groups > (recursively) if and only if the user has the proper permissions on all > process groups. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12101) System Test StatelessBasicsIT.testChangeFlowVersion failing frequently
[ https://issues.apache.org/jira/browse/NIFI-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849066#comment-17849066 ] ASF subversion and git services commented on NIFI-12101: Commit 4aae517cca997b12e254a7778199a6fe048d2439 in nifi's branch refs/heads/support/nifi-1.x from Timea Barna [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4aae517cca ] NIFI-11658 Streamline using single Parameter Context for nested PGs Including applicable modifications from NIFI-12101 by Mark Payne This closes #7353 Co-authored-by: Matt Gilman Signed-off-by: David Handermann (cherry picked from commit 42910e80d1d0a71c8f3de51bdd5c6dd0183da26d) Signed-off-by: Pierre Villard This closes #8868. > System Test StatelessBasicsIT.testChangeFlowVersion failing frequently > -- > > Key: NIFI-12101 > URL: https://issues.apache.org/jira/browse/NIFI-12101 > Project: Apache NiFi > Issue Type: Bug >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 2.0.0-M1 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > This test is failing intermittently but seems to be very frequent. Need to > address the issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11658 Streamline using single Parameter Context for nested PGs (backport to 1.x) [nifi]
pvillard31 closed pull request #8868: NIFI-11658 Streamline using single Parameter Context for nested PGs (backport to 1.x) URL: https://github.com/apache/nifi/pull/8868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13283) Exception thrown in PutKinesisFirehose processor
[ https://issues.apache.org/jira/browse/NIFI-13283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849063#comment-17849063 ] ASF subversion and git services commented on NIFI-13283: Commit 99253b9673ac7aab19e6612599a0e687d8eb438f in nifi's branch refs/heads/main from Evan Shelton [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=99253b9673 ] NIFI-13283 - Fix exception thrown in PutKinesisFirehose processor by ensuring value exists before referencing Signed-off-by: Pierre Villard This closes #8867. > Exception thrown in PutKinesisFirehose processor > > > Key: NIFI-13283 > URL: https://issues.apache.org/jira/browse/NIFI-13283 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 2.0.0-M1, 2.0.0-M2, 2.0.0-M3 >Reporter: Evan Shelton >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > When attempting to send data to Firehose an exception is thrown related to > attempting to access an ArrayList that hasn't been initialized -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-13283) Exception thrown in PutKinesisFirehose processor
[ https://issues.apache.org/jira/browse/NIFI-13283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-13283. --- Fix Version/s: 2.0.0-M4 Resolution: Fixed > Exception thrown in PutKinesisFirehose processor > > > Key: NIFI-13283 > URL: https://issues.apache.org/jira/browse/NIFI-13283 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 2.0.0-M1, 2.0.0-M2, 2.0.0-M3 >Reporter: Evan Shelton >Priority: Major > Fix For: 2.0.0-M4 > > Time Spent: 0.5h > Remaining Estimate: 0h > > When attempting to send data to Firehose an exception is thrown related to > attempting to access an ArrayList that hasn't been initialized -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13283 - Exception thrown in PutKinesisFirehose processor [nifi]
asfgit closed pull request #8867: NIFI-13283 - Exception thrown in PutKinesisFirehose processor URL: https://github.com/apache/nifi/pull/8867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12983: Qdrant vector store support [nifi]
Anush008 commented on code in PR #8590: URL: https://github.com/apache/nifi/pull/8590#discussion_r1612116673 ## nifi-python-extensions/nifi-text-embeddings-module/src/main/python/vectorstores/requirements.txt: ## @@ -25,8 +27,10 @@ requests # Pinecone requirements pinecone-client==3.0.1 -tiktoken -langchain==0.1.11 + # OpenSearch requirements opensearch-py==2.5.0 + +# Qdrant requirements +qdrant-client==1.9.0 Review Comment: Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13283) Exception thrown in PutKinesisFirehose processor
[ https://issues.apache.org/jira/browse/NIFI-13283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13283: -- Affects Version/s: 2.0.0-M2 2.0.0-M1 > Exception thrown in PutKinesisFirehose processor > > > Key: NIFI-13283 > URL: https://issues.apache.org/jira/browse/NIFI-13283 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 2.0.0-M1, 2.0.0-M2, 2.0.0-M3 >Reporter: Evan Shelton >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > When attempting to send data to Firehose an exception is thrown related to > attempting to access an ArrayList that hasn't been initialized -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12983: Qdrant vector store support [nifi]
pvillard31 commented on code in PR #8590: URL: https://github.com/apache/nifi/pull/8590#discussion_r1612109584 ## nifi-python-extensions/nifi-text-embeddings-module/src/main/python/vectorstores/requirements.txt: ## @@ -25,8 +27,10 @@ requests # Pinecone requirements pinecone-client==3.0.1 -tiktoken -langchain==0.1.11 + # OpenSearch requirements opensearch-py==2.5.0 + +# Qdrant requirements +qdrant-client==1.9.0 Review Comment: ```suggestion qdrant-client==1.9.1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (NIFI-13191) Deprecate InvokeAWSGatewayApi Processor
[ https://issues.apache.org/jira/browse/NIFI-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849056#comment-17849056 ] Chien edited comment on NIFI-13191 at 5/23/24 5:57 PM: --- Hello [~exceptionfactory] It would be great if this processor can be restored? We are currently highly dependent on this processor, and it would be a major challenge to replace it with a secure alternative for invoking our gateway. Many thanks was (Author: chien): Hello [~exceptionfactory] [~exceptionfactory] It would be great if this processor can be restored? We are currently highly dependent on this processor, and it would be a major challenge to replace it with a secure alternative for invoking our gateway. Many thanks > Deprecate InvokeAWSGatewayApi Processor > --- > > Key: NIFI-13191 > URL: https://issues.apache.org/jira/browse/NIFI-13191 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Minor > Fix For: 1.27.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Similar to the other AWS client library upgrade issues, this targets the > InvokeAWSGatewayApi processor. > Note: After discussing with [~exceptionfactory] and [~otto], we agree that > this processor can be deprecated, and removed in NiFi 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-13191) Deprecate InvokeAWSGatewayApi Processor
[ https://issues.apache.org/jira/browse/NIFI-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849056#comment-17849056 ] Chien edited comment on NIFI-13191 at 5/23/24 5:57 PM: --- Hello [~exceptionfactory] [~exceptionfactory] It would be great if this processor can be restored? We are currently highly dependent on this processor, and it would be a major challenge to replace it with a secure alternative for invoking our gateway. Many thanks was (Author: chien): Hello [~exceptionfactory] [~exceptionfactory] It would be great if this processor can be restored? We are currently highly dependent on this processor, and it would be a major challenge to replace it with a secure alternative for invoking our gateway. > Deprecate InvokeAWSGatewayApi Processor > --- > > Key: NIFI-13191 > URL: https://issues.apache.org/jira/browse/NIFI-13191 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Minor > Fix For: 1.27.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Similar to the other AWS client library upgrade issues, this targets the > InvokeAWSGatewayApi processor. > Note: After discussing with [~exceptionfactory] and [~otto], we agree that > this processor can be deprecated, and removed in NiFi 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13191) Deprecate InvokeAWSGatewayApi Processor
[ https://issues.apache.org/jira/browse/NIFI-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849056#comment-17849056 ] Chien commented on NIFI-13191: -- Hello [~exceptionfactory] [~exceptionfactory] It would be great if this processor can be restored? We are currently highly dependent on this processor, and it would be a major challenge to replace it with a secure alternative for invoking our gateway. > Deprecate InvokeAWSGatewayApi Processor > --- > > Key: NIFI-13191 > URL: https://issues.apache.org/jira/browse/NIFI-13191 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Minor > Fix For: 1.27.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Similar to the other AWS client library upgrade issues, this targets the > InvokeAWSGatewayApi processor. > Note: After discussing with [~exceptionfactory] and [~otto], we agree that > this processor can be deprecated, and removed in NiFi 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12226: Add flag to skip doc generation [nifi-maven]
mattyb149 commented on PR #35: URL: https://github.com/apache/nifi-maven/pull/35#issuecomment-2127717824 Not for NiFi 1.x, but there is currently a vote underway for version 2.0.0 of the plugin which will be applied to the main branch (NiFi 2.x) once released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13245) Provenance Event dialog overflow issues
[ https://issues.apache.org/jira/browse/NIFI-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849048#comment-17849048 ] ASF subversion and git services commented on NIFI-13245: Commit 969b332fb0c165c165a37873add5242466b99e44 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=969b332fb0 ] [NIFI-13245] address component name overflow in provenance details di… (#8845) * [NIFI-13245] address component name overflow in provenance details dialog * address content tab column spacing * use padding appropriately to ensure no overflow text * restore vertical spacing This closes #8845 > Provenance Event dialog overflow issues > --- > > Key: NIFI-13245 > URL: https://issues.apache.org/jira/browse/NIFI-13245 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-15 at 10.18.51 AM.png > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13245) Provenance Event dialog overflow issues
[ https://issues.apache.org/jira/browse/NIFI-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13245: --- Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Provenance Event dialog overflow issues > --- > > Key: NIFI-13245 > URL: https://issues.apache.org/jira/browse/NIFI-13245 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M4 > > Attachments: Screenshot 2024-05-15 at 10.18.51 AM.png > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13245] address component name overflow in provenance details di… [nifi]
mcgilman merged PR #8845: URL: https://github.com/apache/nifi/pull/8845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13207) Page header padding/spacing
[ https://issues.apache.org/jira/browse/NIFI-13207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13207: --- Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Page header padding/spacing > --- > > Key: NIFI-13207 > URL: https://issues.apache.org/jira/browse/NIFI-13207 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M4 > > Attachments: Screenshot 2024-05-09 at 8.04.12 PM.png, Screenshot > 2024-05-09 at 8.04.20 PM.png, Screenshot 2024-05-09 at 8.04.30 PM.png, > Screenshot 2024-05-09 at 8.04.40 PM.png, Screenshot 2024-05-09 at 8.04.50 > PM.png, Screenshot 2024-05-09 at 8.05.02 PM.png, Screenshot 2024-05-09 at > 8.05.10 PM.png, Screenshot 2024-05-09 at 8.05.26 PM.png, Screenshot > 2024-05-09 at 8.05.33 PM.png > > Time Spent: 4h 40m > Remaining Estimate: 0h > > The various page header titles have various spacing padding: -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump azure-storage-blob from 12.9.0 to 12.13.0 in /docker [nifi-minifi-cpp]
dependabot[bot] opened a new pull request, #1801: URL: https://github.com/apache/nifi-minifi-cpp/pull/1801 Bumps [azure-storage-blob](https://github.com/Azure/azure-sdk-for-python) from 12.9.0 to 12.13.0. Commits https://github.com/Azure/azure-sdk-for-python/commit/e90af4374bfd7c139737ad2888fcd269b3023520;>e90af43 DataLake funny dependency (https://redirect.github.com/Azure/azure-sdk-for-python/issues/25129;>#25129) https://github.com/Azure/azure-sdk-for-python/commit/cbec3383039ffeb46760268d1a8f81cf1b4d2219;>cbec338 [AutoRelease] t2-storagecache-2022-07-06-35884(Do not merge) (https://redirect.github.com/Azure/azure-sdk-for-python/issues/25089;>#25089) https://github.com/Azure/azure-sdk-for-python/commit/dc7c5a16d39df8a8d4b838a7240e58f64fc824f2;>dc7c5a1 [Storage] API View Feedback For STG84 GA (https://redirect.github.com/Azure/azure-sdk-for-python/issues/25085;>#25085) https://github.com/Azure/azure-sdk-for-python/commit/9f66f6bce7d777b34c03dc9a633148acd0c4f238;>9f66f6b [Storage] Revert removing aiohttp dependency for storage.blob.aio (https://redirect.github.com/Azure/azure-sdk-for-python/issues/25084;>#25084) https://github.com/Azure/azure-sdk-for-python/commit/e40d3e1d985cee13a2e0d070fb8e04958905f468;>e40d3e1 [storage.blob] Remove aiohttp as dependency for storage.blob.aio (https://redirect.github.com/Azure/azure-sdk-for-python/issues/24965;>#24965) https://github.com/Azure/azure-sdk-for-python/commit/7915719f211cc1217dfca6f3973a2b1f04c2e3f5;>7915719 [Storage] Prepare for STG83 GA release (https://redirect.github.com/Azure/azure-sdk-for-python/issues/25040;>#25040) https://github.com/Azure/azure-sdk-for-python/commit/155eb8b69b3cd2f8ef992cf1436bf2751769ac42;>155eb8b [Storage] Add progress_hook to file-share upload/download (https://redirect.github.com/Azure/azure-sdk-for-python/issues/24997;>#24997) https://github.com/Azure/azure-sdk-for-python/commit/66dd3bef2d6e531e83cefd65be4cbbf41fcf2531;>66dd3be [Storage] Fix more flaky lease tests (https://redirect.github.com/Azure/azure-sdk-for-python/issues/25011;>#25011) https://github.com/Azure/azure-sdk-for-python/commit/030141734a239fa6fb1aa7a8c43d322c82753510;>0301417 [Storage] Add argument to perf tests to use client-side encryption (https://redirect.github.com/Azure/azure-sdk-for-python/issues/24978;>#24978) https://github.com/Azure/azure-sdk-for-python/commit/489906539fe89167d749431d77202e7ca9562fac;>4899065 [perf] Add pipeline template and storage pipelines (https://redirect.github.com/Azure/azure-sdk-for-python/issues/24894;>#24894) Additional commits viewable in https://github.com/Azure/azure-sdk-for-python/compare/azure-storage-blob_12.9.0...azure-storage-blob_12.13.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/nifi-minifi-cpp/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
[jira] [Commented] (NIFI-13207) Page header padding/spacing
[ https://issues.apache.org/jira/browse/NIFI-13207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849044#comment-17849044 ] ASF subversion and git services commented on NIFI-13207: Commit 62d5502bba7fe72c2b2ea6ad4eb6b3dbb675fe2d in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=62d5502bba ] [NIFI-13207] page headers and refresh containers are consistently pos… (#8804) * [NIFI-13207] page headers and refresh containers are consistently positioned between pages * pad error banner * display hint below form fields to follow material spec, updating padding/spacing accordingly * revert access policies template * remove unused MatHint * access policy status as hint and center align hints * use margin bottom on error banner and more spacing improvements * update hint spacing in a few more use cases * remove extra padding from bottom of nifi cluster table filter component * collapse hint height when no text to display * update padding for input form field placeholder padding * use margins instead of padding * final touches This closes #8804 > Page header padding/spacing > --- > > Key: NIFI-13207 > URL: https://issues.apache.org/jira/browse/NIFI-13207 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-09 at 8.04.12 PM.png, Screenshot > 2024-05-09 at 8.04.20 PM.png, Screenshot 2024-05-09 at 8.04.30 PM.png, > Screenshot 2024-05-09 at 8.04.40 PM.png, Screenshot 2024-05-09 at 8.04.50 > PM.png, Screenshot 2024-05-09 at 8.05.02 PM.png, Screenshot 2024-05-09 at > 8.05.10 PM.png, Screenshot 2024-05-09 at 8.05.26 PM.png, Screenshot > 2024-05-09 at 8.05.33 PM.png > > Time Spent: 4h 40m > Remaining Estimate: 0h > > The various page header titles have various spacing padding: -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
mcgilman merged PR #8804: URL: https://github.com/apache/nifi/pull/8804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13288) Fix SplitJson, SplitXml, and SplitAvro processors not to call session.putAttribute multiple times
[ https://issues.apache.org/jira/browse/NIFI-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13288: Summary: Fix SplitJson, SplitXml, and SplitAvro processors not to call session.putAttribute multiple times (was: Fix SplitJson, SplitXml, and SplitAvro processor not to call session.putAttribute multiple times) > Fix SplitJson, SplitXml, and SplitAvro processors not to call > session.putAttribute multiple times > - > > Key: NIFI-13288 > URL: https://issues.apache.org/jira/browse/NIFI-13288 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > > Per [~markap14] in the following > [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one > should avoid calling session.putAttribute many times since in order to > maintain object immutability it has to create a new FlowFile object (and a > new HashMap of all attributes!) > for every call to session.putAttribute which leads to potentially a huge > amount of garbage getting created. Some of the split processors SplitJson, > SplitXml, and SplitAvro all have loops to create a new flow file for each > split and it calls session.putAttribute more than once (in order to populate > the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file > created. Per Mark's advice, these should be fixed to to populate the > attributes in a Map and then make one call to session.putAttributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13288) Fix SplitJson, SplitXml, and SplitAvro processor not to call session.putAttribute multiple times
[ https://issues.apache.org/jira/browse/NIFI-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13288: Description: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to session.putAttribute which leads to potentially a huge amount of garbage getting created. Some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls session.putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. Per Mark's advice, these should be fixed to to populate the attributes in a Map and then make one call to session.putAttributes. was: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to session.putAttribute which leads to potentially a huge amount of garbage getting created. Some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls session.putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. Per Mark;s advice, these should be fixed to to populate the attributes in a Map and then make one call to session.putAttributes. > Fix SplitJson, SplitXml, and SplitAvro processor not to call > session.putAttribute multiple times > > > Key: NIFI-13288 > URL: https://issues.apache.org/jira/browse/NIFI-13288 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > > Per [~markap14] in the following > [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one > should avoid calling session.putAttribute many times since in order to > maintain object immutability it has to create a new FlowFile object (and a > new HashMap of all attributes!) > for every call to session.putAttribute which leads to potentially a huge > amount of garbage getting created. Some of the split processors SplitJson, > SplitXml, and SplitAvro all have loops to create a new flow file for each > split and it calls session.putAttribute more than once (in order to populate > the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file > created. Per Mark's advice, these should be fixed to to populate the > attributes in a Map and then make one call to session.putAttributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13288) Fix SplitJson, SplitXml, and SplitAvro processor not to call session.putAttribute multiple times
[ https://issues.apache.org/jira/browse/NIFI-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13288: Description: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to session.putAttribute which leads to potentially a huge amount of garbage getting created. Some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls session.putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. Per Mark;s advice, these should be fixed to to populate the attributes in a Map and then make one call to session.putAttributes. was: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to session.putAttribute which leads to potentially a huge amount of garbage getting created. Per this advice some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls session.putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. These should be fixed to to populate the attributes in a Map and then make one call to session.putAttributes. > Fix SplitJson, SplitXml, and SplitAvro processor not to call > session.putAttribute multiple times > > > Key: NIFI-13288 > URL: https://issues.apache.org/jira/browse/NIFI-13288 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > > Per [~markap14] in the following > [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one > should avoid calling session.putAttribute many times since in order to > maintain object immutability it has to create a new FlowFile object (and a > new HashMap of all attributes!) > for every call to session.putAttribute which leads to potentially a huge > amount of garbage getting created. Some of the split processors SplitJson, > SplitXml, and SplitAvro all have loops to create a new flow file for each > split and it calls session.putAttribute more than once (in order to populate > the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file > created. Per Mark;s advice, these should be fixed to to populate the > attributes in a Map and then make one call to session.putAttributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13288) Fix SplitJson, SplitXml, and SplitAvro processor not to call session.putAttribute multiple times
[ https://issues.apache.org/jira/browse/NIFI-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13288: Description: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to session.putAttribute which leads to potentially a huge amount of garbage getting created. Per this advice some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. These should be fixed to to populate the attributes in a Map and then make one call to session.putAttributes. was: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to putAttribute which leads to potentially a huge amount of garbage getting created. Per this advice some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. These should be fixed to to populate the attributes in a Map and then make one call to session.putAttributes. > Fix SplitJson, SplitXml, and SplitAvro processor not to call > session.putAttribute multiple times > > > Key: NIFI-13288 > URL: https://issues.apache.org/jira/browse/NIFI-13288 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > > Per [~markap14] in the following > [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one > should avoid calling session.putAttribute many times since in order to > maintain object immutability it has to create a new FlowFile object (and a > new HashMap of all attributes!) > for every call to session.putAttribute which leads to potentially a huge > amount of garbage getting created. Per this advice some of the split > processors SplitJson, SplitXml, and SplitAvro all have loops to create a new > flow file for each split and it calls putAttribute more than once (in order > to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each > flow file created. These should be fixed to to populate the attributes in a > Map and then make one call to session.putAttributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13288) Fix SplitJson, SplitXml, and SplitAvro processor not to call session.putAttribute multiple times
[ https://issues.apache.org/jira/browse/NIFI-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13288: Description: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to session.putAttribute which leads to potentially a huge amount of garbage getting created. Per this advice some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls session.putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. These should be fixed to to populate the attributes in a Map and then make one call to session.putAttributes. was: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to session.putAttribute which leads to potentially a huge amount of garbage getting created. Per this advice some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. These should be fixed to to populate the attributes in a Map and then make one call to session.putAttributes. > Fix SplitJson, SplitXml, and SplitAvro processor not to call > session.putAttribute multiple times > > > Key: NIFI-13288 > URL: https://issues.apache.org/jira/browse/NIFI-13288 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > > Per [~markap14] in the following > [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one > should avoid calling session.putAttribute many times since in order to > maintain object immutability it has to create a new FlowFile object (and a > new HashMap of all attributes!) > for every call to session.putAttribute which leads to potentially a huge > amount of garbage getting created. Per this advice some of the split > processors SplitJson, SplitXml, and SplitAvro all have loops to create a new > flow file for each split and it calls session.putAttribute more than once (in > order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for > each flow file created. These should be fixed to to populate the attributes > in a Map and then make one call to session.putAttributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13288) Fix SplitJson, SplitXml, and SplitAvro processor not to call session.putAttribute multiple times
[ https://issues.apache.org/jira/browse/NIFI-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13288: Summary: Fix SplitJson, SplitXml, and SplitAvro processor not to call session.putAttribute multiple times (was: Fix SplitJson, SplitXml, and SplitAvro processor not to call putAttribute multiple times) > Fix SplitJson, SplitXml, and SplitAvro processor not to call > session.putAttribute multiple times > > > Key: NIFI-13288 > URL: https://issues.apache.org/jira/browse/NIFI-13288 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > > Per [~markap14] in the following > [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one > should avoid calling session.putAttribute many times since in order to > maintain object immutability it has to create a new FlowFile object (and a > new HashMap of all attributes!) > for every call to putAttribute which leads to potentially a huge amount of > garbage getting created. Per this advice some of the split processors > SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file > for each split and it calls putAttribute more than once (in order to populate > the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file > created. These should be fixed to to populate the attributes in a Map and > then make one call to putAttributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13288) Fix SplitJson, SplitXml, and SplitAvro processor not to call session.putAttribute multiple times
[ https://issues.apache.org/jira/browse/NIFI-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13288: Description: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to putAttribute which leads to potentially a huge amount of garbage getting created. Per this advice some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. These should be fixed to to populate the attributes in a Map and then make one call to session.putAttributes. was: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to putAttribute which leads to potentially a huge amount of garbage getting created. Per this advice some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. These should be fixed to to populate the attributes in a Map and then make one call to putAttributes. > Fix SplitJson, SplitXml, and SplitAvro processor not to call > session.putAttribute multiple times > > > Key: NIFI-13288 > URL: https://issues.apache.org/jira/browse/NIFI-13288 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > > Per [~markap14] in the following > [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one > should avoid calling session.putAttribute many times since in order to > maintain object immutability it has to create a new FlowFile object (and a > new HashMap of all attributes!) > for every call to putAttribute which leads to potentially a huge amount of > garbage getting created. Per this advice some of the split processors > SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file > for each split and it calls putAttribute more than once (in order to populate > the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file > created. These should be fixed to to populate the attributes in a Map and > then make one call to session.putAttributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13288) Fix SplitJson, SplitXml, and SplitAvro processor not to call putAttribute multiple times
[ https://issues.apache.org/jira/browse/NIFI-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13288: Summary: Fix SplitJson, SplitXml, and SplitAvro processor not to call putAttribute multiple times (was: Fix SplitJson, SplitXml, and SplitAvro processor not call putAttributes multiple times) > Fix SplitJson, SplitXml, and SplitAvro processor not to call putAttribute > multiple times > > > Key: NIFI-13288 > URL: https://issues.apache.org/jira/browse/NIFI-13288 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > > Per [~markap14] in the following > [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one > should avoid calling session.putAttribute many times since in order to > maintain object immutability it has to create a new FlowFile object (and a > new HashMap of all attributes!) > for every call to putAttribute which leads to potentially a huge amount of > garbage getting created. Per this advice some of the split processors > SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file > for each split and it calls putAttribute more than once (in order to populate > the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file > created. These should be fixed to to populate the attributes in a Map and > then make one call to putAttributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13288) Fix SplitJson, SplitXml, and SplitAvro processor not call putAttributes multiple times
[ https://issues.apache.org/jira/browse/NIFI-13288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13288: Description: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times since in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to putAttribute which leads to potentially a huge amount of garbage getting created. Per this advice some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. These should be fixed to to populate the attributes in a Map and then make one call to putAttributes. was: Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times as in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to putAttribute which leads to potentially a huge amount of garbage getting created. Per this advice some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. These should be fixed to to populate the attributes in a Map and then make one call to putAttributes. > Fix SplitJson, SplitXml, and SplitAvro processor not call putAttributes > multiple times > -- > > Key: NIFI-13288 > URL: https://issues.apache.org/jira/browse/NIFI-13288 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Major > > Per [~markap14] in the following > [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one > should avoid calling session.putAttribute many times since in order to > maintain object immutability it has to create a new FlowFile object (and a > new HashMap of all attributes!) > for every call to putAttribute which leads to potentially a huge amount of > garbage getting created. Per this advice some of the split processors > SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file > for each split and it calls putAttribute more than once (in order to populate > the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file > created. These should be fixed to to populate the attributes in a Map and > then make one call to putAttributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13288) Fix SplitJson, SplitXml, and SplitAvro processor not call putAttributes multiple times
Daniel Stieglitz created NIFI-13288: --- Summary: Fix SplitJson, SplitXml, and SplitAvro processor not call putAttributes multiple times Key: NIFI-13288 URL: https://issues.apache.org/jira/browse/NIFI-13288 Project: Apache NiFi Issue Type: Improvement Reporter: Daniel Stieglitz Assignee: Daniel Stieglitz Per [~markap14] in the following [post|https://lists.apache.org/thread/7zo2px31r3377c7vhby4h6nrngdf3llf] one should avoid calling session.putAttribute many times as in order to maintain object immutability it has to create a new FlowFile object (and a new HashMap of all attributes!) for every call to putAttribute which leads to potentially a huge amount of garbage getting created. Per this advice some of the split processors SplitJson, SplitXml, and SplitAvro all have loops to create a new flow file for each split and it calls putAttribute more than once (in order to populate the split attributes FRAGMENT_ID, FRAGMENT_INDEX etc) for each flow file created. These should be fixed to to populate the attributes in a Map and then make one call to putAttributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13287: Added note to msal4j dependency in Azure bundle's pom [nifi]
joewitt commented on PR #8869: URL: https://github.com/apache/nifi/pull/8869#issuecomment-2127455021 Think about it from the perspective of the people in the community that actively work to keep things up to date for vulnerability and other reasons. The note if it is to be useful will direct on where to look/what to look for. Notes that simply warn result in things not getting updated (we can't have that). Notes that describe how, specifically, to improve it increase accessibility for more people to do this work. ie: i'd use exactly those URLs and indicate they're examples. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
joewitt commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2127449187 > @joewitt Earlier you had advised to use the MIT license for the generated software from the Kaitai Project. We have changed the code (i.e. removed some of the generated code, placed in its own classes, added variables, removed variables, used different methods than the generate code etc.) Should these changed classes still have the MIT license or should we use the Apache license and mention in the NOTICE file the derived classes are from the Kaitai Project which has an MIT license? This trends towards the i'm not a lawyer space but i'd say it this way If the code is started from a substantial block of MIT code and chose to decompose it and improve it various ways I'd keep the resulting code that stemmed from that original as MIT as well. We don't really gain much by trying to claim it is ASLv2 and/or under the apache copyright anyway so better to be safe here and keep its original provenance clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2387) Improve error handling in Python processors
[ https://issues.apache.org/jira/browse/MINIFICPP-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2387: - Description: Errors are handled multiple ways in the * throwing PythonScriptException * throwing PyException * setting PyErr_SetString The error handling should be revised. In case of the minifi_native python module we should probably set the error with PyErr_SetString instead of throwing exceptions that would result in throwing exception in python instead of the c++ code. We should focus on having better error messages and tracebacks in the logs in case of an error to be able to identify the source of the error. We are also using PyErr_Fetch and PyErr_Restore functions that are deprecated since Python 3.12 so we should see if they could be replaced with something that is both available in older and newer versions too. was: Errors are handled multiple ways in the * throwing PythonScriptException * throwing PyException * setting PyErr_SetString The error handling should be revised. In case of the minifi_native python module we should probably set the error with PyErr_SetString instead of throwing exceptions that would result in throwing exception in python instead of the c++ code. We should focus on having better error messages and tracebacks in the logs in case of an error to be able to identify the source of the error. We are also using PyErr_Fetch and PyErr_Restore functions that are deprecated since Python 3.12 and should be replaced. > Improve error handling in Python processors > --- > > Key: MINIFICPP-2387 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2387 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > > Errors are handled multiple ways in the > * throwing PythonScriptException > * throwing PyException > * setting PyErr_SetString > The error handling should be revised. In case of the minifi_native python > module we should probably set the error with PyErr_SetString instead of > throwing exceptions that would result in throwing exception in python instead > of the c++ code. We should focus on having better error messages and > tracebacks in the logs in case of an error to be able to identify the source > of the error. > We are also using PyErr_Fetch and PyErr_Restore functions that are deprecated > since Python 3.12 so we should see if they could be replaced with something > that is both available in older and newer versions too. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13287: Added note to msal4j dependency in Azure bundle's pom [nifi]
turcsanyip commented on PR #8869: URL: https://github.com/apache/nifi/pull/8869#issuecomment-2127433526 Usually I check the pom's on https://search.maven.org/. First get the `azure-identity` version from the BOM's pom, e.g.: https://search.maven.org/artifact/com.azure/azure-sdk-bom/1.2.23/pom => 1.12.0 Then look for the `msal4j` version in the given `azure-identity`'s pom: https://search.maven.org/artifact/com.azure/azure-identity/1.12.0/jar => 1.15.0 These are version specific URLs so I would not add them in the code. Our `nifi-azure-graph-authorizer` uses a few `msal4j` [classes](https://github.com/apache/nifi/blob/7951b4be80f4416d2cc9b4272fb7e004c64a989e/nifi-extension-bundles/nifi-azure-bundle/nifi-azure-graph-authorizer/src/main/java/org/apache/nifi/authorization/azure/ClientCredentialAuthProvider.java#L30-L33). If no compilation error, it should be fine. If there was no common `msal4j` version for `azure-identity` and `nifi-azure-graph-authorizer`, then we would need to separate the components into 2 nars, I'm afraid. Hopefully, it will not happen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2311 Initial support for recordset readers and writers [nifi-minifi-cpp]
fgerlits commented on code in PR #1763:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1763#discussion_r1609813309
##
extensions/standard-processors/controllers/JsonRecordSetWriter.h:
##
@@ -0,0 +1,107 @@
+/**
+* Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include "PropertyDefinitionBuilder.h"
+#include "Record.h"
+#include "controllers/RecordSetWriter.h"
+#include "core/FlowFile.h"
+#include "core/ProcessSession.h"
+#include "utils/Enum.h"
+
+namespace org::apache::nifi::minifi::standard {
+enum class OutputGroupingType {
+ ARRAY,
+ ONE_LINE_PER_OBJECT
+};
+} // namespace org::apache::nifi::minifi::standard
+
+namespace magic_enum::customize {
+using OutputGroupingType =
org::apache::nifi::minifi::standard::OutputGroupingType;
+
+template <>
+constexpr customize_t enum_name(OutputGroupingType value)
noexcept {
+ switch (value) {
+case OutputGroupingType::ARRAY:
+ return "Array";
+case OutputGroupingType::ONE_LINE_PER_OBJECT:
+ return "One Line Per Object";
+ }
+ return invalid_tag;
+}
+} // namespace magic_enum::customize
+
+namespace org::apache::nifi::minifi::standard {
+
+class JsonRecordSetWriter final : public core::RecordSetWriter {
+ public:
+ explicit JsonRecordSetWriter(const std::string_view name, const
utils::Identifier& uuid = {}) : RecordSetWriter(name, uuid) {}
+
+ JsonRecordSetWriter(JsonRecordSetWriter&&) = delete;
+ JsonRecordSetWriter(const JsonRecordSetWriter&) = delete;
+ JsonRecordSetWriter& operator=(JsonRecordSetWriter&&) = delete;
+ JsonRecordSetWriter& operator=(const JsonRecordSetWriter&) = delete;
+
+ ~JsonRecordSetWriter() override = default;
+
+ EXTENSIONAPI static constexpr const char* Description =
+ "Writes the results of a RecordSet as either a JSON Array or one JSON
object per line. "
+ "If using Array output, then even if the RecordSet consists of a single
row, it will be written as an array with a single element. "
+ "If using One Line Per Object output, the JSON objects cannot be
pretty-printed.";
+
+ EXTENSIONAPI static constexpr auto OutputGrouping =
core::PropertyDefinitionBuilder()>::createProperty("Output
Grouping")
+.withDescription("Specifies how the writer should output the JSON records
(as an array or one object per line, e.g.) "
+"Note that if 'One Line Per Object' is selected, then
Pretty Print JSON is ignored.")
Review Comment:
Minor, but it's not clear what the `e.g.` refers to; also I would remove the
whole `(...)` part, as the list of allowed values already contains the same
info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
exceptionfactory commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1611877524
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/SplitPCAP.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network.pcap;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.stream.IntStream;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark", "TcpDump", "WinDump", "sniffers"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(
+attribute = SplitPCAP.ERROR_REASON,
+description = "The reason the flowfile was sent to the failure
relationship."
+),
+@WritesAttribute(
+attribute = "fragment.identifier",
+description = "All split PCAP FlowFiles produced from the same parent
PCAP FlowFile will have the same randomly generated UUID added for this
attribute"
+),
+@WritesAttribute(
+attribute = "fragment.index",
+description = "A one-up number that indicates the ordering of the
split PCAP FlowFiles that were created from a single parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "fragment.count",
+description = "The number of split PCAP FlowFiles generated from the
parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "segment.original.filename ",
+description = "The filename of the parent PCAP FlowFile"
+)
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP Max Size")
+.displayName("PCAP Max Size")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.defaultValue("100") // 1MB
+.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
+.build();
+
+public static final Relationship REL_ORIGINAL = new Relationship.Builder()
+.name("original")
+.description("The original FlowFile that was split into segments.
If the FlowFile fails processing, nothing will be sent to "
++ "this relationship")
+.build();
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("If a FlowFile cannot be transformed from the
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2127377170 @joewitt Earlier you had advised to use the MIT license for the generated software from the Kaitai Project. We have changed the code (i.e. removed some of the generated code, placed in its own classes, added variables, removed variables, used different methods than the generate code etc.) Should these changed classes still have the MIT license or should we use the Apache license and mention in the NOTICE file the derived classes are from the Kaitai Project which has an MIT license? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
exceptionfactory commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1611865507
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/SplitPCAP.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network.pcap;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.stream.IntStream;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark", "TcpDump", "WinDump", "sniffers"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(
+attribute = SplitPCAP.ERROR_REASON,
+description = "The reason the flowfile was sent to the failure
relationship."
+),
+@WritesAttribute(
+attribute = "fragment.identifier",
+description = "All split PCAP FlowFiles produced from the same parent
PCAP FlowFile will have the same randomly generated UUID added for this
attribute"
+),
+@WritesAttribute(
+attribute = "fragment.index",
+description = "A one-up number that indicates the ordering of the
split PCAP FlowFiles that were created from a single parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "fragment.count",
+description = "The number of split PCAP FlowFiles generated from the
parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "segment.original.filename ",
+description = "The filename of the parent PCAP FlowFile"
+)
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP Max Size")
+.displayName("PCAP Max Size")
Review Comment:
Based on the description, it sounds like this should be named `Max Output
Size`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
exceptionfactory commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1611864501
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/SplitPCAP.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network.pcap;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.stream.IntStream;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark", "TcpDump", "WinDump", "sniffers"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(
+attribute = SplitPCAP.ERROR_REASON,
+description = "The reason the flowfile was sent to the failure
relationship."
+),
+@WritesAttribute(
+attribute = "fragment.identifier",
+description = "All split PCAP FlowFiles produced from the same parent
PCAP FlowFile will have the same randomly generated UUID added for this
attribute"
+),
+@WritesAttribute(
+attribute = "fragment.index",
+description = "A one-up number that indicates the ordering of the
split PCAP FlowFiles that were created from a single parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "fragment.count",
+description = "The number of split PCAP FlowFiles generated from the
parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "segment.original.filename ",
+description = "The filename of the parent PCAP FlowFile"
+)
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP Max Size")
+.displayName("PCAP Max Size")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.defaultValue("100") // 1MB
+.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
Review Comment:
Instead of using a number, this should use the `DATA_SIZE_VALIDATOR`, which
supports common size notation, such as `1 MB` or `500 KB`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13287: Added note to msal4j dependency in Azure bundle's pom [nifi]
joewitt commented on PR #8869: URL: https://github.com/apache/nifi/pull/8869#issuecomment-2127359098 Is there more guidance on where that version will be found though? It mentions match msal with the graph identity. Can you add more context for where to look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13287) Add note to msal4j dependency in Azure bundle's pom
[
https://issues.apache.org/jira/browse/NIFI-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-13287:
---
Status: Patch Available (was: Open)
> Add note to msal4j dependency in Azure bundle's pom
> ---
>
> Key: NIFI-13287
> URL: https://issues.apache.org/jira/browse/NIFI-13287
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{com.azure:azure-identity}} in {{nifi-azure-nar}} has a dependency on
> {{com.microsoft.azure:msal4j}} and requires a given version of it. It could
> bring that version transitively but {{msal4j}} is also used directly by
> {{nifi-azure-graph-authorizer}} and the {{msal4j}} version needs to be
> configured in that pom. Unfortunately, {{azure-sdk-bom}} does not control the
> {{msal4j}} version (I think because it is a {{com.microsoft.azure}} artifact,
> not {{{}com.azure{}}}).
> Configuring the {{azure-identity}} (via the BOM) and {{msal4j}} versions
> separately caused dependency issues multiple times in the past (NIFI-9305,
> NIFI-13181). I will add a "heads-up" note in the pom to keep these versions
> consistent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-13287: Added note to msal4j dependency in Azure bundle's pom [nifi]
turcsanyip opened a new pull request, #8869: URL: https://github.com/apache/nifi/pull/8869 # Summary [NIFI-13287](https://issues.apache.org/jira/browse/NIFI-13287) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1611840148
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/SplitPCAP.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network.pcap;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.stream.IntStream;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark", "TcpDump", "WinDump", "sniffers"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(
+attribute = SplitPCAP.ERROR_REASON,
+description = "The reason the flowfile was sent to the failure
relationship."
+),
+@WritesAttribute(
+attribute = "fragment.identifier",
+description = "All split PCAP FlowFiles produced from the same parent
PCAP FlowFile will have the same randomly generated UUID added for this
attribute"
+),
+@WritesAttribute(
+attribute = "fragment.index",
+description = "A one-up number that indicates the ordering of the
split PCAP FlowFiles that were created from a single parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "fragment.count",
+description = "The number of split PCAP FlowFiles generated from the
parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "segment.original.filename ",
+description = "The filename of the parent PCAP FlowFile"
+)
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP Max Size")
+.displayName("PCAP Max Size")
+.description("Maximum size of the output pcap file in bytes.")
Review Comment:
Please add to the description what the default is
```suggestion
.description("Maximum size of the output pcap file in bytes.
Defaults to 1MB (100).")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13287) Add note to msal4j dependency in Azure bundle's pom
Peter Turcsanyi created NIFI-13287:
--
Summary: Add note to msal4j dependency in Azure bundle's pom
Key: NIFI-13287
URL: https://issues.apache.org/jira/browse/NIFI-13287
Project: Apache NiFi
Issue Type: Improvement
Reporter: Peter Turcsanyi
Assignee: Peter Turcsanyi
{{com.azure:azure-identity}} in {{nifi-azure-nar}} has a dependency on
{{com.microsoft.azure:msal4j}} and requires a given version of it. It could
bring that version transitively but {{msal4j}} is also used directly by
{{nifi-azure-graph-authorizer}} and the {{msal4j}} version needs to be
configured in that pom. Unfortunately,
{{azure-sdk-bom}} does not control the {{msal4j}} version (I think because it
is a {{com.microsoft.azure}} artifact, not {{{}com.azure{}}}).
Configuring the {{azure-identity}} (via the BOM) and {{msal4j}} versions
separately caused dependency issues multiple times in the past (NIFI-9305,
NIFI-13181). I will add a "heads-up" note in the pom to keep these versions
consistent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13287) Add note to msal4j dependency in Azure bundle's pom
[
https://issues.apache.org/jira/browse/NIFI-13287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-13287:
---
Description:
{{com.azure:azure-identity}} in {{nifi-azure-nar}} has a dependency on
{{com.microsoft.azure:msal4j}} and requires a given version of it. It could
bring that version transitively but {{msal4j}} is also used directly by
{{nifi-azure-graph-authorizer}} and the {{msal4j}} version needs to be
configured in that pom. Unfortunately, {{azure-sdk-bom}} does not control the
{{msal4j}} version (I think because it is a {{com.microsoft.azure}} artifact,
not {{{}com.azure{}}}).
Configuring the {{azure-identity}} (via the BOM) and {{msal4j}} versions
separately caused dependency issues multiple times in the past (NIFI-9305,
NIFI-13181). I will add a "heads-up" note in the pom to keep these versions
consistent.
was:
{{com.azure:azure-identity}} in {{nifi-azure-nar}} has a dependency on
{{com.microsoft.azure:msal4j}} and requires a given version of it. It could
bring that version transitively but {{msal4j}} is also used directly by
{{nifi-azure-graph-authorizer}} and the {{msal4j}} version needs to be
configured in that pom. Unfortunately,
{{azure-sdk-bom}} does not control the {{msal4j}} version (I think because it
is a {{com.microsoft.azure}} artifact, not {{{}com.azure{}}}).
Configuring the {{azure-identity}} (via the BOM) and {{msal4j}} versions
separately caused dependency issues multiple times in the past (NIFI-9305,
NIFI-13181). I will add a "heads-up" note in the pom to keep these versions
consistent.
> Add note to msal4j dependency in Azure bundle's pom
> ---
>
> Key: NIFI-13287
> URL: https://issues.apache.org/jira/browse/NIFI-13287
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Minor
>
> {{com.azure:azure-identity}} in {{nifi-azure-nar}} has a dependency on
> {{com.microsoft.azure:msal4j}} and requires a given version of it. It could
> bring that version transitively but {{msal4j}} is also used directly by
> {{nifi-azure-graph-authorizer}} and the {{msal4j}} version needs to be
> configured in that pom. Unfortunately, {{azure-sdk-bom}} does not control the
> {{msal4j}} version (I think because it is a {{com.microsoft.azure}} artifact,
> not {{{}com.azure{}}}).
> Configuring the {{azure-identity}} (via the BOM) and {{msal4j}} versions
> separately caused dependency issues multiple times in the past (NIFI-9305,
> NIFI-13181). I will add a "heads-up" note in the pom to keep these versions
> consistent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-11470) SQL Record query TimeZone issue
[ https://issues.apache.org/jira/browse/NIFI-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt resolved NIFI-11470. - Resolution: Information Provided > SQL Record query TimeZone issue > --- > > Key: NIFI-11470 > URL: https://issues.apache.org/jira/browse/NIFI-11470 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M1, 1.19.1, 1.21.0, 1.24.0, 1.23.2, 1.25.0, > 2.0.0-M2, 1.26.0, 2.0.0-M3 >Reporter: Julien G. >Priority: Major > Attachments: Example_Issue_Timestamp_SQL_Query_on_record.json, > TIMEZONE_ISSUE.json > > > In the case of a cluster with a timezone different from UTC (+0 hours) like > CEST (+2 hours), in processors like QueryRecord or JoinEnrichment that use an > SQL query to manipulate the record, the TIMESTAMP type field will be > converted again and again to UTC. > So, for example, if you have JSON with a field with the value 2023/04/19 > 18:04:00 +0200 and you say it's a TIMESTAMP field in the Avro schema and > convert it to Avro, the field will be set to UTC (2023/04/19 16:04:00 +). > But if you then use a QueryRecord you will have 2023/04/19 14:04:00 + and > if you put another QueryRecord you will have 2023/04/19 12:04:00 +, ... > The field is reinterpreted as CEST time zone instead of UTC each time. > Same issue with SQL join strategy in the JoinEnrichment. > You can find a dataflow illustrating the point attached to the Jira. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11470) SQL Record query TimeZone issue
[
https://issues.apache.org/jira/browse/NIFI-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848976#comment-17848976
]
Julien G. commented on NIFI-11470:
--
The issue can't be solved because it's inherent to Java. The discussion around
it can be seen
[here|https://apachenifi.slack.com/archives/C0L9VCD47/p1716471923088829].
{quote}This could be more complicated than it seems because the general
TIMESTAMP type does not include a time zone offset.
In the process of converting between the database record value and the NiFi
field, a TIMESTAMP will be handled using the time zone of the NiFi node itself.
This is inherent behavior in Java, due to the nature of not having the time
zone offset in the database field.{quote}
It is recommended to force NiFi's time zone to UTC to solve the problem. It's
important to note that the same problem can occur with database servers that
are configured with a non-UTC time zone.
> SQL Record query TimeZone issue
> ---
>
> Key: NIFI-11470
> URL: https://issues.apache.org/jira/browse/NIFI-11470
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 2.0.0-M1, 1.19.1, 1.21.0, 1.24.0, 1.23.2, 1.25.0,
> 2.0.0-M2, 1.26.0, 2.0.0-M3
>Reporter: Julien G.
>Priority: Major
> Attachments: Example_Issue_Timestamp_SQL_Query_on_record.json,
> TIMEZONE_ISSUE.json
>
>
> In the case of a cluster with a timezone different from UTC (+0 hours) like
> CEST (+2 hours), in processors like QueryRecord or JoinEnrichment that use an
> SQL query to manipulate the record, the TIMESTAMP type field will be
> converted again and again to UTC.
> So, for example, if you have JSON with a field with the value 2023/04/19
> 18:04:00 +0200 and you say it's a TIMESTAMP field in the Avro schema and
> convert it to Avro, the field will be set to UTC (2023/04/19 16:04:00 +).
> But if you then use a QueryRecord you will have 2023/04/19 14:04:00 + and
> if you put another QueryRecord you will have 2023/04/19 12:04:00 +, ...
> The field is reinterpreted as CEST time zone instead of UTC each time.
> Same issue with SQL join strategy in the JoinEnrichment.
> You can find a dataflow illustrating the point attached to the Jira.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-13231) Update GitHubFlowRegistryClient to generate App Installation Token
[ https://issues.apache.org/jira/browse/NIFI-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848974#comment-17848974 ] David Handermann commented on NIFI-13231: - [~vanshchaudhary] are you planning on working on this soon? I was also planning take a look at implementing this change, but if you are familiar with the properties and operations required for implementation, I would be willing to review. > Update GitHubFlowRegistryClient to generate App Installation Token > -- > > Key: NIFI-13231 > URL: https://issues.apache.org/jira/browse/NIFI-13231 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M3 >Reporter: Brian Ghigiarelli >Assignee: Vansh Chaudhary >Priority: Major > > The new GitHubFlowRegistryClient accepts two types of authentication: > # Personal Access Token > # App Installation Token > The App Installation Token requires the user to input the token as a > property, then uses that to communicate with GitHub. However, this token is > short-lived and would require frequent updates (~hourly). > Instead of directly providing the token, the GitHubFlowRegistryClient should > accept as properties: > # App ID > # Private Key (PEM text format) > and use these values to generate a short-lived token, following the guide at > https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app#generating-a-json-web-token-jwt -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12967) Improve navigation to/from Canvas
[ https://issues.apache.org/jira/browse/NIFI-12967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848966#comment-17848966 ] Matt Gilman commented on NIFI-12967: Also added back actions for * Go To Service (not from a Property reference) * Back from Service Listing * Back to Connection from Queue Listing * Back to Queue Listing from Provenance > Improve navigation to/from Canvas > - > > Key: NIFI-12967 > URL: https://issues.apache.org/jira/browse/NIFI-12967 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > When leaving the Canvas (ie listing queue, viewing documentation, etc) the UI > should offer a more intuitive means to navigate back to where they were > before. Currently they must use the Global menu or click on the logo in the > header. However, these options are not necessarily obvious at first. The > browser back button also works but the UI should probably offer some in the > application. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11470) SQL Record query TimeZone issue
[ https://issues.apache.org/jira/browse/NIFI-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien G. updated NIFI-11470: - Description: In the case of a cluster with a timezone different from UTC (+0 hours) like CEST (+2 hours), in processors like QueryRecord or JoinEnrichment that use an SQL query to manipulate the record, the TIMESTAMP type field will be converted again and again to UTC. So, for example, if you have JSON with a field with the value 2023/04/19 18:04:00 +0200 and you say it's a TIMESTAMP field in the Avro schema and convert it to Avro, the field will be set to UTC (2023/04/19 16:04:00 +). But if you then use a QueryRecord you will have 2023/04/19 14:04:00 + and if you put another QueryRecord you will have 2023/04/19 12:04:00 +, ... The field is reinterpreted as CEST time zone instead of UTC each time. Same issue with SQL join strategy in the JoinEnrichment. You can find a dataflow illustrating the point attached to the Jira. was: In the case of a cluster with a timezone different from UTC (+0 hours) like CEST (+2 hours), in processors like QueryRecord or JoinEnrichment that use an SQL query to manipulate the record, the TIMESTAMP type field will be converted again and again to UTC. So, for example, if you have JSON with a field with the value 2023/04/19 18:04:00 +0200 and you say it's a TIMESTAMP field in the Avro schema and convert it to Avro, the field will be set to UTC (2023/04/19 16:04:00 +). But if you then use a QueryRecord you will have 2023/04/19 14:04:00 + and if you put another QueryRecord you will have 2023/04/19 14:04:00 +, ... The field is reinterpreted as CEST time zone instead of UTC each time. Same issue with SQL join strategy in the JoinEnrichment. You can find a dataflow illustrating the point attached to the Jira. > SQL Record query TimeZone issue > --- > > Key: NIFI-11470 > URL: https://issues.apache.org/jira/browse/NIFI-11470 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M1, 1.19.1, 1.21.0, 1.24.0, 1.23.2, 1.25.0, > 2.0.0-M2, 1.26.0, 2.0.0-M3 >Reporter: Julien G. >Priority: Major > Attachments: Example_Issue_Timestamp_SQL_Query_on_record.json, > TIMEZONE_ISSUE.json > > > In the case of a cluster with a timezone different from UTC (+0 hours) like > CEST (+2 hours), in processors like QueryRecord or JoinEnrichment that use an > SQL query to manipulate the record, the TIMESTAMP type field will be > converted again and again to UTC. > So, for example, if you have JSON with a field with the value 2023/04/19 > 18:04:00 +0200 and you say it's a TIMESTAMP field in the Avro schema and > convert it to Avro, the field will be set to UTC (2023/04/19 16:04:00 +). > But if you then use a QueryRecord you will have 2023/04/19 14:04:00 + and > if you put another QueryRecord you will have 2023/04/19 12:04:00 +, ... > The field is reinterpreted as CEST time zone instead of UTC each time. > Same issue with SQL join strategy in the JoinEnrichment. > You can find a dataflow illustrating the point attached to the Jira. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2386 Add Jom support for building OpenSSL in parallel [nifi-minifi-cpp]
szaszm commented on code in PR #1799:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1799#discussion_r1611729611
##
cmake/BundledOpenSSL.cmake:
##
@@ -71,17 +71,37 @@ function(use_openssl SOURCE_DIR BINARY_DIR)
# Note: when upgrading to a later release than 3.1.1 the --no-apps could
be used instead of --no-tests to minimize the build size
if (WIN32)
+if(MINIFI_USE_JOM_FOR_OPENSSL_BUILD)
+find_program(JOM_EXECUTABLE_PATH
+NAMES jom.exe
+PATHS ENV PATH
+NO_DEFAULT_PATH)
+if (NOT JOM_EXECUTABLE_PATH)
+message(FATAL_ERROR "jom.exe not found. Please install jom and
add it to the PATH or turn MINIFI_USE_JOM_FOR_OPENSSL_BUILD option off.")
+endif()
+message("Using jom for OpenSSL build: ${JOM_EXECUTABLE_PATH}")
+include(ProcessorCount)
+processorcount(jobs)
+set(OPENSSL_BUILD_COMMAND ${JOM_EXECUTABLE_PATH} -j${jobs})
+set(OPENSSL_INSTALL_COMMAND ${JOM_EXECUTABLE_PATH} install)
+set(OPENSSL_WINDOWS_COMPILE_FLAGS /FS)
+else()
+message("Using nmake for OpenSSL build")
+set(OPENSSL_BUILD_COMMAND nmake)
+set(OPENSSL_INSTALL_COMMAND nmake install)
+set(OPENSSL_WINDOWS_COMPILE_FLAGS "")
+endif()
Review Comment:
I would just use jom whenever it's installed, and fall back to nmake when
it's not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-11470) SQL Record query TimeZone issue
[ https://issues.apache.org/jira/browse/NIFI-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien G. updated NIFI-11470: - Affects Version/s: 2.0.0-M3 1.26.0 2.0.0-M2 1.25.0 1.24.0 2.0.0-M1 > SQL Record query TimeZone issue > --- > > Key: NIFI-11470 > URL: https://issues.apache.org/jira/browse/NIFI-11470 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 2.0.0-M1, 1.19.1, 1.21.0, 1.24.0, 1.23.2, 1.25.0, > 2.0.0-M2, 1.26.0, 2.0.0-M3 >Reporter: Julien G. >Priority: Major > Attachments: Example_Issue_Timestamp_SQL_Query_on_record.json, > TIMEZONE_ISSUE.json > > > In the case of a cluster with a timezone different from UTC (+0 hours) like > CEST (+2 hours), in processors like QueryRecord or JoinEnrichment that use an > SQL query to manipulate the record, the TIMESTAMP type field will be > converted again and again to UTC. > So, for example, if you have JSON with a field with the value 2023/04/19 > 18:04:00 +0200 and you say it's a TIMESTAMP field in the Avro schema and > convert it to Avro, the field will be set to UTC (2023/04/19 16:04:00 +). > But if you then use a QueryRecord you will have 2023/04/19 14:04:00 + and > if you put another QueryRecord you will have 2023/04/19 14:04:00 +, ... > The field is reinterpreted as CEST time zone instead of UTC each time. > Same issue with SQL join strategy in the JoinEnrichment. > You can find a dataflow illustrating the point attached to the Jira. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MINIFICPP-2389 Fix auto-terminated relationships in python processors [nifi-minifi-cpp]
lordgamez opened a new pull request, #1800: URL: https://github.com/apache/nifi-minifi-cpp/pull/1800 The original relationship in python processors was added with the NiFi python processor support and was set to be auto terminated by default to be in sync with NiFi's implementation. Unfortunately setting the relationship to be auto-terminated clears every previously auto-terminated relationship, so the auto-terminated relationships set in the flow configuration are removed from the list. https://issues.apache.org/jira/browse/MINIFICPP-2389 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2389) Cannot set auto terminated relationship in python processors
Gábor Gyimesi created MINIFICPP-2389: Summary: Cannot set auto terminated relationship in python processors Key: MINIFICPP-2389 URL: https://issues.apache.org/jira/browse/MINIFICPP-2389 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi Auto terminated relationships are overriden by mistake in ExecutePythonProcessor::onScheduleSharedPtr -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13231) Update GitHubFlowRegistryClient to generate App Installation Token
[ https://issues.apache.org/jira/browse/NIFI-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vansh Chaudhary reassigned NIFI-13231: -- Assignee: Vansh Chaudhary > Update GitHubFlowRegistryClient to generate App Installation Token > -- > > Key: NIFI-13231 > URL: https://issues.apache.org/jira/browse/NIFI-13231 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M3 >Reporter: Brian Ghigiarelli >Assignee: Vansh Chaudhary >Priority: Major > > The new GitHubFlowRegistryClient accepts two types of authentication: > # Personal Access Token > # App Installation Token > The App Installation Token requires the user to input the token as a > property, then uses that to communicate with GitHub. However, this token is > short-lived and would require frequent updates (~hourly). > Instead of directly providing the token, the GitHubFlowRegistryClient should > accept as properties: > # App ID > # Private Key (PEM text format) > and use these values to generate a short-lived token, following the guide at > https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app#generating-a-json-web-token-jwt -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINIFICPP-2388) Windows build should compile with MINIFI_FAIL_ON_WARNINGS turned on
[ https://issues.apache.org/jira/browse/MINIFICPP-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-2388: Assignee: Gábor Gyimesi > Windows build should compile with MINIFI_FAIL_ON_WARNINGS turned on > --- > > Key: MINIFICPP-2388 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2388 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > > There are some issues when compiling MiNiFi C++ with MINIFI_FAIL_ON_WARNINGS > turned on with the latest MSVC version using VS2022 that should be resolved. > This may also depend on https://issues.apache.org/jira/browse/MINIFICPP-2387 > as some of these warnings are due to the exceptions thrown from the python > bindings library. > After these issues are resolved MINIFI_FAIL_ON_WARNINGS should also be turned > on in the CI build -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MINIFICPP-2386 Add Jom support for building OpenSSL in parallel [nifi-minifi-cpp]
lordgamez opened a new pull request, #1799: URL: https://github.com/apache/nifi-minifi-cpp/pull/1799 https://issues.apache.org/jira/browse/MINIFICPP-2386 -- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2388) Windows build should compile with MINIFI_FAIL_ON_WARNINGS turned on
Gábor Gyimesi created MINIFICPP-2388: Summary: Windows build should compile with MINIFI_FAIL_ON_WARNINGS turned on Key: MINIFICPP-2388 URL: https://issues.apache.org/jira/browse/MINIFICPP-2388 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Gábor Gyimesi There are some issues when compiling MiNiFi C++ with MINIFI_FAIL_ON_WARNINGS turned on with the latest MSVC version using VS2022 that should be resolved. This may also depend on https://issues.apache.org/jira/browse/MINIFICPP-2387 as some of these warnings are due to the exceptions thrown from the python bindings library. After these issues are resolved MINIFI_FAIL_ON_WARNINGS should also be turned on in the CI build -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2387) Improve error handling in Python processors
Gábor Gyimesi created MINIFICPP-2387: Summary: Improve error handling in Python processors Key: MINIFICPP-2387 URL: https://issues.apache.org/jira/browse/MINIFICPP-2387 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi Errors are handled multiple ways in the * throwing PythonScriptException * throwing PyException * setting PyErr_SetString The error handling should be revised. In case of the minifi_native python module we should probably set the error with PyErr_SetString instead of throwing exceptions that would result in throwing exception in python instead of the c++ code. We should focus on having better error messages and tracebacks in the logs in case of an error to be able to identify the source of the error. We are also using PyErr_Fetch and PyErr_Restore functions that are deprecated since Python 3.12 and should be replaced. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2386) Add Jom support for building OpenSSL in parallel
Gábor Gyimesi created MINIFICPP-2386: Summary: Add Jom support for building OpenSSL in parallel Key: MINIFICPP-2386 URL: https://issues.apache.org/jira/browse/MINIFICPP-2386 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Gábor Gyimesi Assignee: Gábor Gyimesi Jom can be used instead of nmake on windows to build in parallel on multiple cores. Support for jom could be added for the OpenSSL build to make the builds faster. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13267 - Bump NiFi NAR Maven plugin version [nifi]
bbende commented on code in PR #8860: URL: https://github.com/apache/nifi/pull/8860#discussion_r1611517108 ## nifi-manifest/nifi-runtime-manifest-core/src/main/java/org/apache/nifi/runtime/manifest/impl/StandardComponentManifestBuilder.java: ## @@ -33,6 +35,8 @@ public class StandardComponentManifestBuilder implements ComponentManifestBuilde private final List processors = new ArrayList<>(); private final List controllerServices = new ArrayList<>(); private final List reportingTasks = new ArrayList<>(); +private final List parameterProviders = new ArrayList<>(); +private final List flowAnalysisRules = new ArrayList<>(); Review Comment: Just a heads up that the same two lists need to be added to the actual `ComponentManifest` class, and this builder needs to set them: https://github.com/apache/nifi/blob/main/c2/c2-protocol/c2-protocol-component-api/src/main/java/org/apache/nifi/c2/protocol/component/api/ComponentManifest.java#L32 Currently the final manifest.json doesn't end up with the parameter providers and flow analysis rules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13279) Question about monitoring heap usage in a default no flow NiFi instance.
[ https://issues.apache.org/jira/browse/NIFI-13279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848911#comment-17848911 ] Alex Stanfield commented on NIFI-13279: --- Thanks for clarifying Joe, sorry for the confusion! Diving into NiFi now... > Question about monitoring heap usage in a default no flow NiFi instance. > > > Key: NIFI-13279 > URL: https://issues.apache.org/jira/browse/NIFI-13279 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration >Affects Versions: 2.0.0-M3 > Environment: Ubuntu 22.04 >Reporter: Alex Stanfield >Priority: Major > Attachments: nifi_memory_leak.png > > > I have just installed the last version of NiFi, the system is literally OOB > totally empty. However the system look like it's leaking memory and resetting > or recovering it's heap over and over again. Please see attachment. > > Any suggestions are welcome. > > Thanks > Alex -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-11658 Streamline using single Parameter Context for nested PGs [nifi]
timeabarna opened a new pull request, #8868: URL: https://github.com/apache/nifi/pull/8868 # Summary [NIFI-11658](https://issues.apache.org/jira/browse/NIFI-11658) Including Enum rename from NIFI-12101 by Mark Payne without no other changes from that commit. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1611329042
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/SplitPCAP.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network.pcap;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.stream.IntStream;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark", "TcpDump", "WinDump", "sniffers"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(
+attribute = SplitPCAP.ERROR_REASON,
+description = "The reason the flowfile was sent to the failure
relationship."
+),
+@WritesAttribute(
+attribute = "fragment.identifier",
+description = "All split PCAP FlowFiles produced from the same parent
PCAP FlowFile will have the same randomly generated UUID added for this
attribute"
+),
+@WritesAttribute(
+attribute = "fragment.index",
+description = "A one-up number that indicates the ordering of the
split PCAP FlowFiles that were created from a single parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "fragment.count",
+description = "The number of split PCAP FlowFiles generated from the
parent PCAP FlowFile"
+),
+@WritesAttribute(
+attribute = "segment.original.filename ",
+description = "The filename of the parent PCAP FlowFile"
+)
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP Max Size")
+.displayName("PCAP Max Size")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
+.build();
Review Comment:
We tend to use 100 (1MB) ourselves, so I've put that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
