[GitHub] nifi issue #2970: NIFI-5542 Added support for node groups to FileAccessPolic...
Github user achristianson commented on the issue: https://github.com/apache/nifi/pull/2970 @pepov I took that lookup out. It appeared to be completely unnecessary. ---
[GitHub] nifi issue #2970: NIFI-5542 Added support for node groups to FileAccessPolic...
Github user achristianson commented on the issue: https://github.com/apache/nifi/pull/2970 @pepov is the second lookup you're referring to this line? ```java Group nodeGroup = userGroupProvider.getGroup(nodeGroupIdentifier); ``` ---
[GitHub] nifi issue #2970: NIFI-5542 Added support for node groups to FileAccessPolic...
Github user achristianson commented on the issue: https://github.com/apache/nifi/pull/2970 The group id lookup logic was running even if group name was not specified. Fixed that. All tests are passing locally. ---
[GitHub] nifi issue #2970: NIFI-5542 Added support for node groups to FileAccessPolic...
Github user achristianson commented on the issue: https://github.com/apache/nifi/pull/2970 @kevdoran @pepov it's now looking up group ID from the given name. Unit test updated to reflect such, and docs updated to reflect the new property. ---
[GitHub] nifi issue #2970: NIFI-5542 Added support for node groups to FileAccessPolic...
Github user achristianson commented on the issue: https://github.com/apache/nifi/pull/2970 @pepov @kevdoran thanks for the feedback. I'll update the docs to reflect the property change, and update the code to reflect that the group name is provided and look up the group identifier accordingly. ---
[GitHub] nifi issue #2970: NIFI-5542 Added support for node groups to FileAccessPolic...
Github user achristianson commented on the issue: https://github.com/apache/nifi/pull/2970 @pepov @mcgilman new PR where we authorize the node group rather than its users. Please take a look when you get a chance. ---
[GitHub] nifi pull request #2970: NIFI-5542 Added support for node groups to FileAcce...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi/pull/2970 NIFI-5542 Added support for node groups to FileAccessPolicyProvider Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi NIFI-5542 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2970.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2970 commit 94e05575fec715a2c76dc1397e7f7124dcd1ab20 Author: Andrew I. Christianson Date: 2018-08-23T15:50:54Z NIFI-5542 Added support for node groups to FileAccessPolicyProvider ---
[GitHub] nifi pull request #2965: NIFI-5542 Added support for node groups to FileAcce...
Github user achristianson closed the pull request at: https://github.com/apache/nifi/pull/2965 ---
[GitHub] nifi pull request #2965: NIFI-5542 Added support for node groups to FileAcce...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2965#discussion_r212977830
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization/FileAccessPolicyProvider.java
---
@@ -604,12 +610,26 @@ private void populateInitialAdmin(final
Authorizations authorizations) {
* @param authorizations the overall authorizations
*/
private void populateNodes(Authorizations authorizations) {
+// authorize static nodes
+authorizeNodeIdentities(authorizations, nodeIdentities);
+
+// authorize dynamic nodes (node group)
+if (nodeGroupName != null) {
+Group nodeGroup = userGroupProvider.getGroup(nodeGroupName);
+if (nodeGroup == null) {
+throw new AuthorizerCreationException("Unable to locate
node group " + nodeGroupName + " to seed policies.");
+}
+Set nodeGroupUserIdentities = nodeGroup.getUsers();
+authorizeNodeIdentities(authorizations,
nodeGroupUserIdentities);
--- End diff --
Hmm, good point. It depends on how/when the FileAccessPolicyProvider is
called. Looking into it...
---
[GitHub] nifi pull request #2965: NIFI-5542 Added support for node groups to FileAcce...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi/pull/2965 NIFI-5542 Added support for node groups to FileAccessPolicyProvider Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi NIFI-5542 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2965.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2965 commit d957f655a17dff8cd464f0a1e2b44d6031410fec Author: Andrew I. Christianson Date: 2018-08-23T15:50:54Z NIFI-5542 Added support for node groups to FileAccessPolicyProvider ---
[GitHub] nifi-minifi-cpp issue #347: MINIFIPP-514 Incorporated regex property validat...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/347 @apiri This was merged on the basis of "I'll provide an implicit agreement to move forward." MINIFICPP-577 has been created to refactor the Property constructor to reduce the # of arguments. I don't see that it was actually clarified in the conversation as to what the issue was, but that is my best guess. Pleas update ticket if incorrect. ---
[GitHub] nifi-minifi-cpp issue #371: MINIFICPP-556 Added initial snapcraft build
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/371 Added snap build instructions. Will merge unless there are any further objections. ---
[GitHub] nifi-minifi-cpp issue #350: MINIFICPP-465 Implemented regex validation of pr...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/350 Rebased & all issues addressed. Ready for review. ---
[GitHub] nifi-minifi-cpp issue #347: MINIFIPP-514 Incorporated regex property validat...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/347 @phrocker Please elaborate what exactly your issues are. As you can see from 20 days ago, all concerns were addressed to the best of my knowledge. ---
[GitHub] nifi-minifi-cpp pull request #380: MINIFICPP-574 Include required cstring li...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/380 MINIFICPP-574 Include required cstring library Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-574 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/380.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #380 ---
[GitHub] nifi-minifi-cpp pull request #379: MINIFICPP-574 Include required cstring li...
Github user achristianson closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/379 ---
[GitHub] nifi-minifi-cpp pull request #379: Minificpp 574
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/379 Minificpp 574 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-574 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/379.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #379 ---
[GitHub] nifi-minifi-cpp issue #374: MINIFICPP-559 Move cURL external build up to fix...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/374 Fixed. ---
[GitHub] nifi-minifi-cpp pull request #374: MINIFICPP-559 Move cURL external build up...
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/374#discussion_r204400344 --- Diff: CMakeLists.txt --- @@ -165,6 +165,56 @@ else() set(UUID_LIBRARIES "uuid") endif() +if(NOT USE_SYSTEM_CURL) --- End diff -- Agreed, with the caveat that the boolean here has gotten a little muddy due to various hooks into cURL. I'll see what I can do to make a readable bool along the lines of NEEDS_CURL. ---
[GitHub] nifi-minifi-cpp issue #375: MINIFICPP-561 Added internal/static build of bzi...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/375 @phrocker I agree. Since this would affect all the external project builds, I created MINIFICPP-570 to move all external builds out to their own space(s) consistently. ---
[GitHub] nifi-minifi-cpp pull request #377: MINIFICPP-555 Pass through CMAKE args to ...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/377 MINIFICPP-555 Pass through CMAKE args to external projects so that ex⦠â¦ternal builds are consistent with main build Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-555 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/377.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #377 commit 72ed3f347ce289e6d207204029b1112c559444e4 Author: Andrew I. Christianson Date: 2018-07-19T14:35:59Z MINIFICPP-555 Pass through CMAKE args to external projects so that external builds are consistent with main build ---
[GitHub] nifi-minifi-cpp pull request #376: MINIFICPP-562 Fixed thirdparty/uuid inclu...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/376 MINIFICPP-562 Fixed thirdparty/uuid include path Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-562 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/376.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #376 commit f1b564c68a929bf58792f81a6c43fa850952115f Author: Andrew I. Christianson Date: 2018-07-18T15:33:43Z MINIFICPP-562 Fixed thirdparty/uuid include path ---
[GitHub] nifi-minifi-cpp pull request #375: MINIFICPP-561 Added internal/static build...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/375 MINIFICPP-561 Added internal/static build of bzip2 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-561 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/375.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #375 commit c12564670f88f6849c3ff2a4e490718f37f285bd Author: Andrew I. Christianson Date: 2018-07-18T15:23:58Z MINIFICPP-561 Added internal/static build of bzip2 ---
[GitHub] nifi-minifi-cpp pull request #374: MINIFICPP-559 Move cURL external build up...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/374 MINIFICPP-559 Move cURL external build up to fix dependency resolution Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-559 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/374.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #374 commit 993ae73604437741fdb50300be72bb66d9548ef7 Author: Andrew I. Christianson Date: 2018-07-18T14:23:27Z MINIFICPP-559 Move cURL external build up to fix dependency resolution ---
[GitHub] nifi-minifi-cpp issue #371: MINIFICPP-556 Added initial snapcraft build
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/371 @jdye64 if you can, please send me the instructions you gave @phrocker. I can add those to the build instructions and update this PR. ---
[GitHub] nifi-minifi-cpp issue #371: MINIFICPP-556 Added initial snapcraft build
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/371 @phrocker The official snap docs recommend building using Ubuntu 16.04. Other environments might not work. ---
[GitHub] nifi-minifi-cpp pull request #371: MINIFICPP-556 Added initial snapcraft bui...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/371 MINIFICPP-556 Added initial snapcraft build This wouldn't have been possible without the help of Jeremy Dyer. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-556 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/371.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #371 commit 4c5481aa0c44cf08786326407598659b9f3576c7 Author: Andrew I. Christianson Date: 2018-07-13T15:17:37Z MINIFICPP-556 Added initial snapcraft build ---
[GitHub] nifi-minifi-cpp pull request #370: MINIFICPP-459 Added build-time caveat for...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/370 MINIFICPP-459 Added build-time caveat for flex regarding accessibilit⦠â¦y and compatibility of FlexLexer.h Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-459 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/370.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #370 commit daf5a258fa25e0ce89f1263113b7259165dbecb7 Author: Andrew I. Christianson Date: 2018-07-06T14:40:34Z MINIFICPP-459 Added build-time caveat for flex regarding accessibility and compatibility of FlexLexer.h ---
[GitHub] nifi-minifi-cpp pull request #369: MINIFICPP-483 Added compile-time bustache...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/369 MINIFICPP-483 Added compile-time bustache caveats Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-483 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/369.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #369 commit 678355315a79f2ad7c08079dce60a865298c01c3 Author: Andrew I. Christianson Date: 2018-07-05T14:17:35Z MINIFICPP-483 Added compile-time bustache caveats ---
[GitHub] nifi-minifi-cpp issue #350: MINIFICPP-465 Implemented regex validation of pr...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/350 Build fails are timeouts after 52/53 passed unit tests; suspect possible travis environmental issue. ---
[GitHub] nifi-minifi-cpp issue #347: MINIFIPP-514 Incorporated regex property validat...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/347 Fixed. ---
[GitHub] nifi-minifi-cpp issue #347: MINIFIPP-514 Incorporated regex property validat...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/347 Looks like some conflict(s) cropped up. Taking a look. ---
[GitHub] nifi-minifi-cpp issue #350: MINIFICPP-465 Implemented regex validation of pr...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/350 Fixed. ---
[GitHub] nifi-minifi-cpp issue #359: MINIFICPP-515 Use emplace_back instead of push_b...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/359 Fixed. ---
[GitHub] nifi-minifi-cpp issue #359: MINIFICPP-515 Use emplace_back instead of push_b...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/359 @phrocker I read through the blog post. The high level objective of this PR is to achieve the "copy free" state. The push_back( T&& value ) is what we want. "in general push_back of already constructed objects with a move constructor should be fine" It would copy, because the string is still valid after we add it (this would be "Case B" from the article): "Case B is not affected (it still copies), and that's good, because we want to print s1 to cout below, so we want that data there." "Case G" is the fit here, since the strings would still be valid. We need std::move to say that we're done with the string in this scope and it's OK for it to go into arbitrary post-move state. I'll update to call push_back( T&& value ) which should be copy-free and is appropriate because we're not constructing an object. ---
[GitHub] nifi-minifi-cpp pull request #359: MINIFICPP-515 Use emplace_back instead of...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/359 MINIFICPP-515 Use emplace_back instead of push_back Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-515 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/359.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #359 commit 0123dfa5579ca4d831fd608391ae54b5660a6d18 Author: Andrew I. Christianson Date: 2018-06-15T05:27:46Z MINIFICPP-515 Use emplace_back instead of push_back ---
[GitHub] nifi-minifi-cpp pull request #358: MINIFICPP-533 Fixed signed/unsigned integ...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/358 MINIFICPP-533 Fixed signed/unsigned integer comparison mismatch Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-533 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/358.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #358 commit 845fc9f1960c42fe5656a92e309c2eb64d8c8207 Author: Andrew I. Christianson Date: 2018-06-14T09:13:23Z MINIFICPP-533 Fixed signed/unsigned integer comparison mismatch ---
[GitHub] nifi-minifi-cpp pull request #357: MINIFICPP-534 Added EL support to Execute...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/357 MINIFICPP-534 Added EL support to ExecuteProcess Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-534 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/357.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #357 commit 4a03fa9acee85def717bf7dd2a46672b73eb9860 Author: Andrew I. Christianson Date: 2018-06-14T09:07:56Z MINIFICPP-534 Added EL support to ExecuteProcess ---
[GitHub] nifi-minifi-cpp pull request #356: MINIFICPP-536 Added EL support to GetFile
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/356 MINIFICPP-536 Added EL support to GetFile Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-536 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/356.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #356 commit 31b4d4dc86d278643cb56ae1b15a8e9c0de555f8 Author: Andrew I. Christianson Date: 2018-06-12T12:46:07Z MINIFICPP-536 Added EL support to GetFile ---
[GitHub] nifi-minifi-cpp pull request #355: MINIFICPP-535 Add support for nonexistent...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/355 MINIFICPP-535 Add support for nonexistent flow_file provided as param⦠⦠to an Expression Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-535 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #355 commit dc29a28b632f164588b066959605666365cad8b5 Author: Andrew I. Christianson Date: 2018-06-11T13:28:53Z MINIFICPP-535 Add support for nonexistent flow_file provided as param to an Expression ---
[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192156058
--- Diff: extensions/sensors/CMakeLists.txt ---
@@ -0,0 +1,61 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+cmake_minimum_required(VERSION 2.6)
+
+
+set(CMAKE_EXE_LINKER_FLAGS "-Wl,--export-all-symbols")
+set(CMAKE_SHARED_LINKER_FLAGS "-Wl,--export-symbols")
+
+include_directories(../../libminifi/include
../../libminifi/include/core/yaml ../../libminifi/include/core
../../thirdparty/spdlog-20170710/include ../../thirdparty/concurrentqueue
../../thirdparty/yaml-cpp-yaml-cpp-0.5.3/include
${CIVET_THIRDPARTY_ROOT}/include ../../thirdparty/)
--- End diff --
Not unique to this PR or ticket, but a lot of this extension boilerplate is
really getting duplicated a lot... might be worth considering or adding a
ticket for. (Not just this line but quite a bit of various duplicated cruft in
an extension CMakeLists.txt).
---
[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192155481
--- Diff: extensions/sensors/SensorLoader.cpp ---
@@ -0,0 +1,30 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "SensorLoader.h"
+
+#include "core/FlowConfiguration.h"
+
+bool SensorFactory::added =
core::FlowConfiguration::add_static_func("createSensorFactory");
+
+extern "C" {
+
+void *createSensorFactory(void) {
+ return new SensorFactory();
--- End diff --
Maybe return a moved unique_ptr to make ownership semantics clearer?
---
[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192155217
--- Diff: extensions/sensors/GetMovementSensors.cpp ---
@@ -0,0 +1,109 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "utils/ByteArrayCallback.h"
+#include "core/FlowFile.h"
+#include "core/logging/Logger.h"
+#include "core/ProcessContext.h"
+#include "core/Relationship.h"
+#include "GetMovementSensors.h"
+#include "io/DataStream.h"
+#include "io/StreamFactory.h"
+#include "ResourceClaim.h"
+#include "utils/StringUtils.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace processors {
+
+std::shared_ptr GetMovementSensors::id_generator_ =
utils::IdGenerator::getIdGenerator();
+
+const char *GetMovementSensors::ProcessorName = "EnvironmentalSensors";
+
+core::Relationship GetMovementSensors::Success("success", "All files are
routed to success");
+
+void GetMovementSensors::initialize() {
+ logger_->log_trace("Initializing EnvironmentalSensors");
+ // Set the supported properties
+ std::set properties;
+
+ setSupportedProperties(properties);
+ // Set the supported relationships
+ std::set relationships;
+ relationships.insert(Success);
+ setSupportedRelationships(relationships);
+}
+
+void GetMovementSensors::onSchedule(const
std::shared_ptr , const
std::shared_ptr ) {
+ imu = RTIMU::createIMU();
+ if (imu) {
+imu->IMUInit();
+imu->setGyroEnable(true);
+imu->setAccelEnable(true);
+ } else {
+throw std::runtime_error("RTIMU could not be initialized");
+ }
+
+}
+
+GetMovementSensors::~GetMovementSensors() {
+}
+
+void GetMovementSensors::onTrigger(const
std::shared_ptr , const
std::shared_ptr ) {
+ auto flow_file_ = session->create();
+
+ flow_file_->setSize(0);
+
+ if (imu->IMURead()) {
+RTIMU_DATA imuData = imu->getIMUData();
+
+if (imuData.accelValid) {
+ auto vector = imuData.accel;
+ std::string degrees = RTMath::displayDegrees("acceleration", vector);
+ flow_file_->addAttribute("ACCELERATION", degrees);
+}
+if (imuData.gyroValid) {
+ auto vector = imuData.gyro;
+ std::string degrees = RTMath::displayDegrees("gyro", vector);
+ flow_file_->addAttribute("GYRO", degrees);
+}
+
--- End diff --
Same type of comment w/r/t error or exception cases. Didn't notice anything
wrong but I imagine there could be failures on sensor polls that we'd want to
at least log a warn or error for.
---
[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192154943
--- Diff: extensions/sensors/GetMovementSensors.cpp ---
@@ -0,0 +1,109 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "utils/ByteArrayCallback.h"
+#include "core/FlowFile.h"
+#include "core/logging/Logger.h"
+#include "core/ProcessContext.h"
+#include "core/Relationship.h"
+#include "GetMovementSensors.h"
+#include "io/DataStream.h"
+#include "io/StreamFactory.h"
+#include "ResourceClaim.h"
+#include "utils/StringUtils.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace processors {
+
+std::shared_ptr GetMovementSensors::id_generator_ =
utils::IdGenerator::getIdGenerator();
+
+const char *GetMovementSensors::ProcessorName = "EnvironmentalSensors";
+
+core::Relationship GetMovementSensors::Success("success", "All files are
routed to success");
+
+void GetMovementSensors::initialize() {
+ logger_->log_trace("Initializing EnvironmentalSensors");
+ // Set the supported properties
+ std::set properties;
+
+ setSupportedProperties(properties);
+ // Set the supported relationships
+ std::set relationships;
+ relationships.insert(Success);
+ setSupportedRelationships(relationships);
+}
+
+void GetMovementSensors::onSchedule(const
std::shared_ptr , const
std::shared_ptr ) {
+ imu = RTIMU::createIMU();
--- End diff --
Does this createIMU alloc and give us owner? Didn't catch a delete in the
destructor like the other one. If so, same comment applies w/r/t unique_ptr to
give more of a RAII memory assurance given that nothing technically precludes a
N call to onSchedule where N > 1.
---
[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192154395
--- Diff: extensions/sensors/GetEnvironmentalSensors.cpp ---
@@ -0,0 +1,156 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "utils/ByteArrayCallback.h"
+#include "core/FlowFile.h"
+#include "core/logging/Logger.h"
+#include "core/ProcessContext.h"
+#include "core/Relationship.h"
+#include "GetEnvironmentalSensors.h"
+#include "io/DataStream.h"
+#include "io/StreamFactory.h"
+#include "ResourceClaim.h"
+#include "utils/StringUtils.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace processors {
+
+std::shared_ptr GetEnvironmentalSensors::id_generator_
= utils::IdGenerator::getIdGenerator();
+
+const char *GetEnvironmentalSensors::ProcessorName =
"EnvironmentalSensors";
+
+core::Relationship GetEnvironmentalSensors::Success("success", "All files
are routed to success");
+
+void GetEnvironmentalSensors::initialize() {
+ logger_->log_trace("Initializing EnvironmentalSensors");
+ // Set the supported properties
+ std::set properties;
+
+ setSupportedProperties(properties);
+ // Set the supported relationships
+ std::set relationships;
+ relationships.insert(Success);
+ setSupportedRelationships(relationships);
+}
+
+void GetEnvironmentalSensors::onSchedule(const
std::shared_ptr , const
std::shared_ptr ) {
+
+ imu = RTIMU::createIMU();
+ if (imu) {
+imu->IMUInit();
+imu->setGyroEnable(true);
+imu->setAccelEnable(true);
+ } else {
+throw std::runtime_error("RTIMU could not be initialized");
+ }
+
+ humidity_sensor_ = RTHumidity::createHumidity();
+ if (humidity_sensor_) {
+humidity_sensor_->humidityInit();
+ } else {
+throw std::runtime_error("RTHumidity could not be initialized");
+ }
+
+ pressure_sensor_ = RTPressure::createPressure();
+ if (pressure_sensor_) {
+pressure_sensor_->pressureInit();
+ } else {
+throw std::runtime_error("RTPressure could not be initialized");
+ }
+
+}
+
+GetEnvironmentalSensors::~GetEnvironmentalSensors() {
+ delete humidity_sensor_;
+ delete pressure_sensor_;
+}
+
+void GetEnvironmentalSensors::onTrigger(const
std::shared_ptr , const
std::shared_ptr ) {
+
+ auto flow_file_ = session->create();
+
+ flow_file_->setSize(0);
+
+ if (imu->IMURead()) {
+RTIMU_DATA imuData = imu->getIMUData();
+auto vector = imuData.accel;
+std::string degrees = RTMath::displayDegrees("acceleration", vector);
+flow_file_->addAttribute("ACCELERATION", degrees);
+ }
+
+ RTIMU_DATA data;
+
+ bool have_sensor = false;
+
+ if (humidity_sensor_->humidityRead(data)) {
+if (data.humidityValid) {
+ have_sensor = true;
+ std::stringstream ss;
+ ss << std::fixed << std::setprecision(2) << data.humidity;
+ flow_file_->addAttribute("HUMIDITY", ss.str());
+}
+ }
+
+ if (pressure_sensor_->pressureRead(data)) {
+if (data.pressureValid) {
+ have_sensor = true;
+ {
+std::stringstream ss;
+ss << std::fixed << std::setprecision(2) << data.pressure;
+flow_file_->addAttribute("PRESSURE", ss.str());
+ }
+
+ if (data.temperatureVa
[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192153880
--- Diff: extensions/sensors/GetEnvironmentalSensors.cpp ---
@@ -0,0 +1,156 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "utils/ByteArrayCallback.h"
+#include "core/FlowFile.h"
+#include "core/logging/Logger.h"
+#include "core/ProcessContext.h"
+#include "core/Relationship.h"
+#include "GetEnvironmentalSensors.h"
+#include "io/DataStream.h"
+#include "io/StreamFactory.h"
+#include "ResourceClaim.h"
+#include "utils/StringUtils.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace processors {
+
+std::shared_ptr GetEnvironmentalSensors::id_generator_
= utils::IdGenerator::getIdGenerator();
+
+const char *GetEnvironmentalSensors::ProcessorName =
"EnvironmentalSensors";
+
+core::Relationship GetEnvironmentalSensors::Success("success", "All files
are routed to success");
+
+void GetEnvironmentalSensors::initialize() {
+ logger_->log_trace("Initializing EnvironmentalSensors");
+ // Set the supported properties
+ std::set properties;
+
+ setSupportedProperties(properties);
+ // Set the supported relationships
+ std::set relationships;
+ relationships.insert(Success);
+ setSupportedRelationships(relationships);
+}
+
+void GetEnvironmentalSensors::onSchedule(const
std::shared_ptr , const
std::shared_ptr ) {
+
+ imu = RTIMU::createIMU();
+ if (imu) {
+imu->IMUInit();
+imu->setGyroEnable(true);
+imu->setAccelEnable(true);
+ } else {
+throw std::runtime_error("RTIMU could not be initialized");
+ }
+
+ humidity_sensor_ = RTHumidity::createHumidity();
+ if (humidity_sensor_) {
+humidity_sensor_->humidityInit();
+ } else {
+throw std::runtime_error("RTHumidity could not be initialized");
+ }
+
+ pressure_sensor_ = RTPressure::createPressure();
+ if (pressure_sensor_) {
+pressure_sensor_->pressureInit();
+ } else {
+throw std::runtime_error("RTPressure could not be initialized");
+ }
+
+}
+
+GetEnvironmentalSensors::~GetEnvironmentalSensors() {
+ delete humidity_sensor_;
+ delete pressure_sensor_;
+}
+
+void GetEnvironmentalSensors::onTrigger(const
std::shared_ptr , const
std::shared_ptr ) {
+
+ auto flow_file_ = session->create();
+
+ flow_file_->setSize(0);
--- End diff --
Isn't 0 size the default?
---
[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192153700
--- Diff: extensions/sensors/GetEnvironmentalSensors.cpp ---
@@ -0,0 +1,156 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "utils/ByteArrayCallback.h"
+#include "core/FlowFile.h"
+#include "core/logging/Logger.h"
+#include "core/ProcessContext.h"
+#include "core/Relationship.h"
+#include "GetEnvironmentalSensors.h"
+#include "io/DataStream.h"
+#include "io/StreamFactory.h"
+#include "ResourceClaim.h"
+#include "utils/StringUtils.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace processors {
+
+std::shared_ptr GetEnvironmentalSensors::id_generator_
= utils::IdGenerator::getIdGenerator();
+
+const char *GetEnvironmentalSensors::ProcessorName =
"EnvironmentalSensors";
+
+core::Relationship GetEnvironmentalSensors::Success("success", "All files
are routed to success");
+
+void GetEnvironmentalSensors::initialize() {
+ logger_->log_trace("Initializing EnvironmentalSensors");
+ // Set the supported properties
+ std::set properties;
+
+ setSupportedProperties(properties);
+ // Set the supported relationships
+ std::set relationships;
+ relationships.insert(Success);
+ setSupportedRelationships(relationships);
+}
+
+void GetEnvironmentalSensors::onSchedule(const
std::shared_ptr , const
std::shared_ptr ) {
+
+ imu = RTIMU::createIMU();
+ if (imu) {
+imu->IMUInit();
+imu->setGyroEnable(true);
+imu->setAccelEnable(true);
+ } else {
+throw std::runtime_error("RTIMU could not be initialized");
+ }
+
+ humidity_sensor_ = RTHumidity::createHumidity();
+ if (humidity_sensor_) {
+humidity_sensor_->humidityInit();
+ } else {
+throw std::runtime_error("RTHumidity could not be initialized");
+ }
+
+ pressure_sensor_ = RTPressure::createPressure();
+ if (pressure_sensor_) {
+pressure_sensor_->pressureInit();
+ } else {
+throw std::runtime_error("RTPressure could not be initialized");
+ }
+
+}
+
+GetEnvironmentalSensors::~GetEnvironmentalSensors() {
--- End diff --
Possible (but unlikely??) memleak as nothing precludes onSchedule from
being called twice. Maybe embed in unique_ptr?
---
[GitHub] nifi-minifi-cpp pull request #348: MINIFICPP-517: Add RTIMULib and create ba...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/348#discussion_r192153282
--- Diff: extensions/sensors/GetEnvironmentalSensors.cpp ---
@@ -0,0 +1,156 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "utils/ByteArrayCallback.h"
+#include "core/FlowFile.h"
+#include "core/logging/Logger.h"
+#include "core/ProcessContext.h"
+#include "core/Relationship.h"
+#include "GetEnvironmentalSensors.h"
+#include "io/DataStream.h"
+#include "io/StreamFactory.h"
+#include "ResourceClaim.h"
+#include "utils/StringUtils.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace processors {
+
+std::shared_ptr GetEnvironmentalSensors::id_generator_
= utils::IdGenerator::getIdGenerator();
+
+const char *GetEnvironmentalSensors::ProcessorName =
"EnvironmentalSensors";
+
+core::Relationship GetEnvironmentalSensors::Success("success", "All files
are routed to success");
+
+void GetEnvironmentalSensors::initialize() {
+ logger_->log_trace("Initializing EnvironmentalSensors");
+ // Set the supported properties
+ std::set properties;
+
+ setSupportedProperties(properties);
+ // Set the supported relationships
+ std::set relationships;
+ relationships.insert(Success);
+ setSupportedRelationships(relationships);
+}
+
+void GetEnvironmentalSensors::onSchedule(const
std::shared_ptr , const
std::shared_ptr ) {
+
+ imu = RTIMU::createIMU();
+ if (imu) {
+imu->IMUInit();
+imu->setGyroEnable(true);
+imu->setAccelEnable(true);
+ } else {
+throw std::runtime_error("RTIMU could not be initialized");
+ }
+
+ humidity_sensor_ = RTHumidity::createHumidity();
+ if (humidity_sensor_) {
+humidity_sensor_->humidityInit();
+ } else {
+throw std::runtime_error("RTHumidity could not be initialized");
+ }
+
+ pressure_sensor_ = RTPressure::createPressure();
--- End diff --
Are these sensor objects thread safe? I don't see issue, but wanted to
double-check.
---
[GitHub] nifi-minifi-cpp pull request #350: Minificpp 465
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/350 Minificpp 465 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-465 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/350.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #350 commit d2a6d0e8dda528dd8e98812c0d284390196616e2 Author: Andrew I. Christianson Date: 2018-05-29T17:08:56Z MINIFIPP-514 Incorporated regex property validation information into agent manifest commit ab01f42b3140d998879434fa6317d28b6e72f2d2 Author: Andrew I. Christianson Date: 2018-05-31T16:03:50Z MINIFICPP-465 Implemented regex validation of properties ---
[GitHub] nifi-minifi-cpp pull request #349: Minificpp 467
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/349 Minificpp 467 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-467 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #349 commit 6be971fc76acd8a411c6946eeaf65a91d31b22e1 Author: Andrew I. Christianson Date: 2018-05-25T14:03:55Z MINIFICPP-466 Implement enforcement of dependent property validation commit 80bfee9257a3f27048ff8404470af48740011628 Author: Andrew I. Christianson Date: 2018-05-31T15:32:25Z MINIFICPP-467 Added validation of mutually-exclusive properties ---
[GitHub] nifi-minifi-cpp issue #347: MINIFIPP-514 Incorporated regex property validat...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/347 Build fail looks unrelated. ---
[GitHub] nifi-minifi-cpp issue #342: MINIFICPP-466 Implement enforcement of dependent...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/342 Fixed. ---
[GitHub] nifi-minifi-cpp pull request #347: MINIFIPP-514 Incorporated regex peroperty...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/347#discussion_r191844258
--- Diff: extensions/http-curl/processors/InvokeHTTP.cpp ---
@@ -65,7 +65,13 @@ core::Property InvokeHTTP::FollowRedirects("Follow
Redirects", "Follow HTTP redi
core::Property InvokeHTTP::AttributesToSend("Attributes to Send", "Regular
expression that defines which attributes to send as HTTP"
" headers in the request. If
not defined, no attributes are sent as headers.",
"");
-core::Property InvokeHTTP::SSLContext("SSL Context Service", "The SSL
Context Service used to provide client certificate information for TLS/SSL
(https) connections.", "");
+core::Property InvokeHTTP::SSLContext("SSL Context Service",
+ "The SSL Context Service used to
provide client certificate "
+ "information for TLS/SSL (https)
connections.",
+ "",
+ false,
+ {},
+ {{"Remote URL", "^http:.*$"}});
--- End diff --
To clarify, the regex is just checking for positive incidence of HTTP
protocol, nothing more. It isn't there to validate a URL (again this is very
confusing due to the incidental git basing).
---
[GitHub] nifi-minifi-cpp pull request #347: MINIFIPP-514 Incorporated regex peroperty...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/347#discussion_r191843838
--- Diff: extensions/http-curl/processors/InvokeHTTP.cpp ---
@@ -65,7 +65,13 @@ core::Property InvokeHTTP::FollowRedirects("Follow
Redirects", "Follow HTTP redi
core::Property InvokeHTTP::AttributesToSend("Attributes to Send", "Regular
expression that defines which attributes to send as HTTP"
" headers in the request. If
not defined, no attributes are sent as headers.",
"");
-core::Property InvokeHTTP::SSLContext("SSL Context Service", "The SSL
Context Service used to provide client certificate information for TLS/SSL
(https) connections.", "");
+core::Property InvokeHTTP::SSLContext("SSL Context Service",
+ "The SSL Context Service used to
provide client certificate "
+ "information for TLS/SSL (https)
connections.",
+ "",
+ false,
+ {},
+ {{"Remote URL", "^http:.*$"}});
--- End diff --
This is confusing because the PR is based on MINIFICPP-500
mutually-exclusive. This PR is for MINIFICPP-514 so that Remote URL
mutually-exclusive property is correct.
A URL regex could get complex, but in this case we're just checking for
HTTP protocol as per RFC3986 (which is exclusive of this SSL property, for
mutual-exclusivity as defined by MINIFICPP-467 E.g. "If I set certificates in
InvokeHTTP, I shouldnât allow http as the target protocol.").
Should it use a controller service? Probably. That's out of scope for this
ticket but I agree with a new ticket for that.
All these notes apply for MINIFICPP-500, not MINIFICPP-514.
---
[GitHub] nifi-minifi-cpp pull request #347: MINIFIPP-514 Incorporated regex peroperty...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/347 MINIFIPP-514 Incorporated regex peroperty validation information into agent manifest Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-514 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/347.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #347 commit f49baba21de54105806d9236ae8f21f204ef55ff Author: Andrew I. Christianson Date: 2018-05-24T19:34:29Z MINIFICPP-500 Incorporate mutually-exclusive property metadata into agent information commit fa5718f4d6561562dc6302398c432c9a0acb1d9e Author: Andrew I. Christianson Date: 2018-05-29T17:08:56Z MINIFIPP-514 Incorporated regex peroperty validation information into agent manifest ---
[GitHub] nifi-minifi-cpp pull request #346: MINIFICPP-513: Avoid rvalue ref and move ...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/346#discussion_r191486780
--- Diff: libminifi/src/controllers/NetworkPrioritizerService.cpp ---
@@ -65,33 +65,38 @@ void NetworkPrioritizerService::yield() {
/**
* If not an intersecting operation we will attempt to locate the highest
priority interface available.
*/
-io::NetworkInterface &::getInterface(uint32_t
size = 0) {
+io::NetworkInterface NetworkPrioritizerService::getInterface(uint32_t size
= 0) {
std::vector controllers;
+ std::string ifc = "";
if (!network_controllers_.empty()) {
if (sufficient_tokens(size) && size < max_payload_) {
controllers.insert(std::end(controllers),
std::begin(network_controllers_), std::end(network_controllers_));
}
}
if (!controllers.empty()) {
-auto ifc = get_nearest_interface(controllers);
+ifc = get_nearest_interface(controllers);
if (!ifc.empty()) {
reduce_tokens(size);
- return std::move(io::NetworkInterface(ifc, shared_from_this()));
+ io::NetworkInterface newifc(ifc, shared_from_this());
+ return newifc;
}
}
for (size_t i = 0; i < linked_services_.size(); i++) {
auto np =
std::dynamic_pointer_cast(linked_services_.at(i));
if (np != nullptr) {
auto ifcs = np->getInterfaces(size);
- auto ifc = get_nearest_interface(ifcs);
+ ifc = get_nearest_interface(ifcs);
if (!ifc.empty()) {
np->reduce_tokens(size);
-return std::move(io::NetworkInterface(ifc, np));
+io::NetworkInterface newifc(ifc, np);
+return newifc;
}
}
}
- return std::move(io::NetworkInterface("", nullptr));
+
+ io::NetworkInterface newifc(ifc, nullptr);
+ return newifc;
--- End diff --
Ditto (trival though).
---
[GitHub] nifi-minifi-cpp pull request #346: MINIFICPP-513: Avoid rvalue ref and move ...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/346#discussion_r191486723
--- Diff: libminifi/src/controllers/NetworkPrioritizerService.cpp ---
@@ -65,33 +65,38 @@ void NetworkPrioritizerService::yield() {
/**
* If not an intersecting operation we will attempt to locate the highest
priority interface available.
*/
-io::NetworkInterface &::getInterface(uint32_t
size = 0) {
+io::NetworkInterface NetworkPrioritizerService::getInterface(uint32_t size
= 0) {
std::vector controllers;
+ std::string ifc = "";
if (!network_controllers_.empty()) {
if (sufficient_tokens(size) && size < max_payload_) {
controllers.insert(std::end(controllers),
std::begin(network_controllers_), std::end(network_controllers_));
}
}
if (!controllers.empty()) {
-auto ifc = get_nearest_interface(controllers);
+ifc = get_nearest_interface(controllers);
if (!ifc.empty()) {
reduce_tokens(size);
- return std::move(io::NetworkInterface(ifc, shared_from_this()));
+ io::NetworkInterface newifc(ifc, shared_from_this());
+ return newifc;
}
}
for (size_t i = 0; i < linked_services_.size(); i++) {
auto np =
std::dynamic_pointer_cast(linked_services_.at(i));
if (np != nullptr) {
auto ifcs = np->getInterfaces(size);
- auto ifc = get_nearest_interface(ifcs);
+ ifc = get_nearest_interface(ifcs);
if (!ifc.empty()) {
np->reduce_tokens(size);
-return std::move(io::NetworkInterface(ifc, np));
+io::NetworkInterface newifc(ifc, np);
+return newifc;
--- End diff --
Likewise.
---
[GitHub] nifi-minifi-cpp pull request #346: MINIFICPP-513: Avoid rvalue ref and move ...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/346#discussion_r191486681
--- Diff: libminifi/src/controllers/NetworkPrioritizerService.cpp ---
@@ -65,33 +65,38 @@ void NetworkPrioritizerService::yield() {
/**
* If not an intersecting operation we will attempt to locate the highest
priority interface available.
*/
-io::NetworkInterface &::getInterface(uint32_t
size = 0) {
+io::NetworkInterface NetworkPrioritizerService::getInterface(uint32_t size
= 0) {
std::vector controllers;
+ std::string ifc = "";
if (!network_controllers_.empty()) {
if (sufficient_tokens(size) && size < max_payload_) {
controllers.insert(std::end(controllers),
std::begin(network_controllers_), std::end(network_controllers_));
}
}
if (!controllers.empty()) {
-auto ifc = get_nearest_interface(controllers);
+ifc = get_nearest_interface(controllers);
if (!ifc.empty()) {
reduce_tokens(size);
- return std::move(io::NetworkInterface(ifc, shared_from_this()));
+ io::NetworkInterface newifc(ifc, shared_from_this());
+ return newifc;
--- End diff --
Why not just return io::NetworkInterface(ifc, shared_from_this())?
---
[GitHub] nifi-minifi-cpp pull request #346: MINIFICPP-513: Avoid rvalue ref and move ...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/346#discussion_r191486381
--- Diff: libminifi/include/io/NetworkPrioritizer.h ---
@@ -86,10 +92,15 @@ class NetworkInterface {
friend class NetworkPrioritizer;
std::string ifc_;
std::shared_ptr prioritizer_;
-};
+}
+;
--- End diff --
Minor style nit. May want to run through clang-format --style=Google.
---
[GitHub] nifi-minifi-cpp pull request #344: MINIFICPP-511 Fix "controllserServices" <...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/344 MINIFICPP-511 Fix "controllserServices" AgentInformation key Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-511 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/344.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #344 commit efb5e18927ade9806af50a8b2b7c029f98a56b09 Author: Andrew I. Christianson <andy@...> Date: 2018-05-25T14:14:33Z MINIFICPP-511 Fix "controllserServices" AgentInformation key ---
[GitHub] nifi-minifi-cpp pull request #343: MINIFICPP-510 Fix log level when notifyin...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/343 MINIFICPP-510 Fix log level when notifying of usage of default values Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-510 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/343.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #343 commit f13bc50336a25341aec8d5e8a89b0519ced2b376 Author: Andrew I. Christianson <andy@...> Date: 2018-05-25T14:10:02Z MINIFICPP-510 Fix log level when notifying of usage of default values ---
[GitHub] nifi-minifi-cpp pull request #341: Minificpp 507
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/341 Minificpp 507 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-507 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/341.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #341 commit 96d31e11147b1c255640bf4f83eb0766d755cd5b Author: Andrew I. Christianson <andy@...> Date: 2018-05-24T19:34:29Z MINIFICPP-500 Incorporate mutually-exclusive property metadata into agent information commit bce7e010be9e21a62e9e0c75418898ba9cb570bc Author: Andrew I. Christianson <andy@...> Date: 2018-05-24T19:40:13Z MINIFICPP-507 Added NOOP appveyor.xml ---
[GitHub] nifi-minifi-cpp pull request #340: MINIFICPP-500 Incorporate mutually-exclus...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/340 MINIFICPP-500 Incorporate mutually-exclusive property metadata into a⦠â¦gent information Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-500 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/340.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #340 commit 96d31e11147b1c255640bf4f83eb0766d755cd5b Author: Andrew I. Christianson <andy@...> Date: 2018-05-24T19:34:29Z MINIFICPP-500 Incorporate mutually-exclusive property metadata into agent information ---
[GitHub] nifi-minifi-cpp issue #336: MINIFICPP-498 Test newer compiler (gcc >= 6) (an...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/336 Travis fail seems to be unrelated (segfault in C2 components). ---
[GitHub] nifi-minifi-cpp pull request #338: Minificpp 508
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/338 Minificpp 508 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-508 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/338.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #338 commit e743a210005eb6f8b6526fae58c281feda5449c9 Author: Andrew I. Christianson <andy@...> Date: 2018-05-22T14:42:50Z MINIFICPP-498 Test newer compiler (gcc >= 6) (and also test build of Docker image) in travis commit c79f9c4fcb493dd279e1e43678f026b86d0c2585 Author: Andrew I. Christianson <andy@...> Date: 2018-05-23T15:37:22Z MINIFICPP-508 Added EL support to Template property of ApplyTemplate ---
[GitHub] nifi-minifi-cpp issue #336: MINIFICPP-498 Test newer compiler (gcc >= 6) (an...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/336 Rebased. ---
[GitHub] nifi-minifi-cpp issue #336: MINIFICPP-498 Test newer compiler (gcc >= 6) (an...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/336 The general build covers an older/LTS Ubuntu which is more conservative. This way we cover old as well as new compilers. ---
[GitHub] nifi-minifi-cpp issue #336: MINIFICPP-498 Test newer compiler (gcc >= 6) (an...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/336 This is ready for review. The build fails due to MINIFICPP-503. The custom script is because we're building in docker (make docker). The reason for this additional build is outlined in the ticket description. ---
[GitHub] nifi-minifi-cpp issue #337: MINIFICPP-457: Add prioritizer service for Netwo...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/337 Should this be an extension? it seems like a fairly specific use case that we might want to leave out of the compilation in many cases. ---
[GitHub] nifi-minifi-cpp pull request #336: MINIFICPP-498 Test newer compiler (gcc >=...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/336 MINIFICPP-498 Test newer compiler (gcc >= 6) (and also test build of ⦠â¦Docker image) in travis Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-498 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/336.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #336 commit ace0d0f983147d582287d767f3db5afd121e2356 Author: Andrew I. Christianson <andy@...> Date: 2018-05-22T14:42:50Z MINIFICPP-498 Test newer compiler (gcc >= 6) (and also test build of Docker image) in travis ---
[GitHub] nifi-minifi-cpp pull request #335: MINIFICPP-503 Fix docker sync excludes to...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/335 MINIFICPP-503 Fix docker sync excludes to fix missing Parser.yy build⦠⦠error Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-503 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/335.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #335 commit c44d24ab765e96b42e487d7704c6703e57abe18e Author: Andrew I. Christianson <andy@...> Date: 2018-05-22T15:22:03Z MINIFICPP-503 Fix docker sync excludes to fix missing Parser.yy build error ---
[GitHub] nifi-minifi-cpp pull request #333: MINIFICPP-501 Incorporate dependent prope...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/333#discussion_r189914896
--- Diff: libminifi/src/processors/PutFile.cpp ---
@@ -51,7 +51,9 @@ core::Property PutFile::CreateDirs(
"Create Missing Directories",
"If true, then missing destination directories will be created. "
"If false, flowfiles are penalized and sent to failure.",
-"true");
+"true",
+true,
--- End diff --
Also note the case where a prop is required & has a default, and no value
is given in the config is covered in unit tests. It will use the default value
and validation will pass. So this change has no operational effect unless the
user explicitly gives an empty value ("") in the config file.
---
[GitHub] nifi-minifi-cpp issue #334: MINIFICPP-502 Add validation to config parser to...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/334 Fixed the linter issue. ---
[GitHub] nifi-minifi-cpp pull request #334: MINIFICPP-502 Add validation to config pa...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/334#discussion_r189913737
--- Diff: libminifi/include/core/Property.h ---
@@ -56,10 +56,15 @@ class Property {
/*!
* Create a new property
*/
- Property(const std::string name, const std::string description, const
std::string value, bool is_required)
--- End diff --
Yeah MINIFICPP-502 is to perform validation. MINIFICPP-501 is for
incorporating the validation metadata into the agent info.
---
[GitHub] nifi-minifi-cpp issue #333: MINIFICPP-501 Incorporate dependent property met...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/333 Fixed the name/value redundancy. ---
[GitHub] nifi-minifi-cpp pull request #333: MINIFICPP-501 Incorporate dependent prope...
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/333#discussion_r189911483
--- Diff: libminifi/include/core/state/nodes/AgentInformation.h ---
@@ -297,9 +297,20 @@ class ComponentManifest : public DeviceInformation {
descriptorRequired.name = "required";
descriptorRequired.value = prop.second.getRequired();
+SerializedResponseNode descriptorDependentProperties;
+descriptorDependentProperties.name = "dependentProperties";
+
+for (const auto :
prop.second.getDependentProperties()) {
+ SerializedResponseNode descriptorDependentProperty;
+ descriptorDependentProperty.name = propName;
+ descriptorDependentProperty.value = propName;
--- End diff --
Fixed.
---
[GitHub] nifi-minifi-cpp pull request #333: MINIFICPP-501 Incorporate dependent prope...
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/333#discussion_r189911362 --- Diff: libminifi/src/processors/PutFile.cpp --- @@ -51,7 +51,9 @@ core::Property PutFile::CreateDirs( "Create Missing Directories", "If true, then missing destination directories will be created. " "If false, flowfiles are penalized and sent to failure.", -"true"); +"true", +true, --- End diff -- It's required per documentation https://github.com/apache/nifi-minifi-cpp/blob/master/PROCESSORS.md#putfile. There are other properties out of sync with documentation/spec, which will be reconciled in future commits. ---
[GitHub] nifi-minifi-cpp pull request #334: Minificpp 502
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/334 Minificpp 502 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-502 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/334.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #334 commit c67473f5e15068629eab46cb9fdcc48df6f56d30 Author: Andrew I. Christianson <andy@...> Date: 2018-05-21T15:55:14Z MINIFICPP-501 Incorporate dependent property metadata into agent information commit 1d8864f004d9609d88f9b32b474f7b0b96f582d0 Author: Andrew I. Christianson <andy@...> Date: 2018-05-21T16:43:40Z MINIFICPP-502 Add validation to config parser to validate required properties ---
[GitHub] nifi-minifi-cpp pull request #333: MINIFICPP-501 Incorporate dependent prope...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/333 MINIFICPP-501 Incorporate dependent property metadata into agent info⦠â¦rmation Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-501 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/333.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #333 commit c67473f5e15068629eab46cb9fdcc48df6f56d30 Author: Andrew I. Christianson <andy@...> Date: 2018-05-21T15:55:14Z MINIFICPP-501 Incorporate dependent property metadata into agent information ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @apiri I think that might be more of a container issue vs. a build issue. The date lib interacts with the system zoneinfo db, so I think trouble with that is why it is raising a runtime exception during the test. ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @apiri done. ---
[GitHub] nifi-minifi-cpp pull request #332: MINIFICPP-499 Incorporate property requir...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/332 MINIFICPP-499 Incorporate property required validation metadata into ⦠â¦agent manifest Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-499 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/332.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #332 commit 32cfb50ea9557b424abfde609cd98023cb7b2a37 Author: Andrew I. Christianson <andy@...> Date: 2018-05-18T18:07:16Z MINIFICPP-499 Incorporate property required validation metadata into agent manifest ---
[GitHub] nifi-minifi-cpp issue #325: MINIFICPP-369 Added multiple attribute/aggregate...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/325 @phrocker fixed travis & rebased. Did you see anything else? ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @apiri looks like travis issue is fixed. Did you see any other issues? ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 @apiri Confirmed compiler version issue, from Howard Hinnant, author of date: "I'm not positive to tell you the truth, but based on this bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60396 my best guess is gcc-5 and forward, at least for date::parse. The parse function is implemented in terms of the C++11 std::time_get::get() function(s) proposed by this 2007 paper: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2321.html. There is no workaround, except to manually implement your own parsing. Sorry." https://gitter.im/HowardHinnant/date/archives/2016/08/31 Will add a version restriction. ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 Ah, seems to be in the 3rd party date lib. We might need to disable these date fns when an old compiler is in use (similar to how we disable regex). The lib should support C++11 though, so will look into it a bit more before making the call. ---
[GitHub] nifi-minifi-cpp pull request #329: MINIFICPP-476 Added support for literal t...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/329 MINIFICPP-476 Added support for literal true/false values Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x ] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-476 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/329.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #329 commit 1e3ceecb1a3c5ad494bfd5b0fae19ef8cfe58f14 Author: Andrew I. Christianson <andy@...> Date: 2018-05-14T19:02:28Z MINIFICPP-476 Added support for literal true/false values ---
[GitHub] nifi-minifi-cpp issue #328: MINIFICPP-474 Added getDelimitedField EL functio...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/328 @phrocker Also rm -rf thirdparty/flex. It might have some junk from another PR that is no longer in git. ---
[GitHub] nifi-minifi-cpp issue #328: MINIFICPP-474 Added getDelimitedField EL functio...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/328 @phrocker Try deleting the following generated files & trying again: /extensions/expression-language/Parser.* /extensions/expression-language/Scanner.cpp /extensions/expression-language/location.hh /extensions/expression-language/position.hh /extensions/expression-language/stack.hh ---
[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/315 Taking a look. ---
[GitHub] nifi-minifi-cpp pull request #328: MINIFICPP-474 Added getDelimitedField EL ...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/328 MINIFICPP-474 Added getDelimitedField EL function Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-474 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/328.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #328 commit b17252fb09f13fefde79d61baf1555b21c0817e9 Author: Andrew I. Christianson <andy@...> Date: 2018-05-11T14:46:55Z MINIFICPP-474 Added getDelimitedField EL function ---
[GitHub] nifi-minifi-cpp pull request #325: MINIFICPP-369 Added multiple attribute/ag...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/325 MINIFICPP-369 Added multiple attribute/aggregate EL functions Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-369 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/325.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #325 commit 688cd1cbe1a18bf5f225a2aca2cf39934a0b7703 Author: Andrew I. Christianson <andy@...> Date: 2018-05-09T20:09:59Z MINIFICPP-369 Added multiple attribute/aggregate EL functions ---
[GitHub] nifi-minifi-cpp pull request #322: MINIFICPP-484 Updated sol2 to 2.20.0
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/322 MINIFICPP-484 Updated sol2 to 2.20.0 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-484 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/322.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #322 commit d8b85c1a13c6dcf5619760a2421e627cb4b1b426 Author: Andrew I. Christianson <andy@...> Date: 2018-05-07T19:36:00Z MINIFICPP-484 Updated sol2 to 2.20.0 ---
[GitHub] nifi-minifi-cpp issue #311: MINIFICPP-432 Added docs for ApplyTemplate
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/311 Agreed that should be documented. I created MINIFICPP-483 to do the build-time instructions. This ticket is for ApplyTemplate usage docs, which at the processor level is distinct from the template library implementation and it's build-time instructions. ---
[GitHub] nifi-minifi-cpp pull request #307: MINIFICPP-469 Added encode/decode base64 ...
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/307#discussion_r186519113 --- Diff: extensions/expression-language/base64.h --- @@ -0,0 +1,188 @@ +/*** --- End diff -- Rebased to fix conflicts. The reason it's here rather than 3rd-party is that it's specific functions copied/pasted, not a third party lib. We own/adopted the code now and it won't be maintained by a third party. ---
[GitHub] nifi-minifi-cpp pull request #320: MINIFICPP-392 Switched to black list for ...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/320 MINIFICPP-392 Switched to black list for copying src tree to avoid mi⦠â¦ssing newly-added dirs Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-392 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/320.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #320 commit e5132fac9b1b471db7d35dc3823d245ad0abc8e4 Author: Andrew I. Christianson <andy@...> Date: 2018-05-04T17:17:18Z MINIFICPP-392 Switched to black list for copying src tree to avoid missing newly-added dirs ---
[GitHub] nifi-minifi-cpp pull request #301: MINIFICPP-459 Include FLexLexer.h in thir...
Github user achristianson closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/301 ---
[GitHub] nifi-minifi-cpp issue #301: MINIFICPP-459 Include FLexLexer.h in thirdparty ...
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/301 Going to close this PR as invalid. FlexLexer.h appears to be incompatible between common versions. Flex/bison are build requirements when EL code is generated. This ticket made it possible to build when system headers were not in the include path (e.g. Android builds); this remains a requirement, but a different solution needs to be applied. ---
[GitHub] nifi-minifi-cpp pull request #318: MINIFICPP-475 Added support for preferred...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/318 MINIFICPP-475 Added support for preferred frame width/height to GetUS⦠â¦BCamera properties Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-475 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/318.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #318 commit f3840dcbe89490de32389c782d39ae8ace333ae9 Author: Andrew I. Christianson <andy@...> Date: 2018-05-03T18:37:55Z MINIFICPP-475 Added support for preferred frame width/height to GetUSBCamera properties ---
[GitHub] nifi-minifi-cpp pull request #317: MINIFICPP-478 Added missing date manipula...
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/317 MINIFICPP-478 Added missing date manipulation heading/intro docs Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-477 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/317.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #317 commit 3a86b8f1274d1042cfdbd7d344348895b0c7145f Author: Andrew I. Christianson <andy@...> Date: 2018-05-02T18:12:36Z MINIFICPP-478 Added missing date manipulation heading/intro docs ---
