[GitHub] nifi pull request #3177: NIFI-5828: Documents behavior of ExecuteSQL attrs w...

2018-11-18 Thread colindean 
GitHub user colindean opened a pull request:

https://github.com/apache/nifi/pull/3177

NIFI-5828: Documents behavior of ExecuteSQL attrs when Max Rows Per Flow 
File is enabled

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] ~Have you written or updated unit tests to verify your changes?~
- [ ] ~If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?~
- [ ] ~If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?~
- [ ] ~If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?~
- [ ] ~If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?~

### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in 
which it is rendered?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/colindean/nifi 
nifi-5828-doc-max-rows-per-flowfile

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/3177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3177


commit 0c6995f35b24ddfab05bc103d48b2a97e3f8c336
Author: Colin Dean 
Date:   2018-11-19T04:14:55Z

NIFI-5828: Documents behavior of ExecuteSQL attrs when Max Rows Per Flow 
File is enabled




---

[GitHub] nifi pull request #3172: NIFI-5823: Fixes typo in min idle connections prope...

2018-11-15 Thread colindean 
GitHub user colindean opened a pull request:

https://github.com/apache/nifi/pull/3172

NIFI-5823: Fixes typo in min idle connections property name

So many people missed it :-(

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] ~If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?~
- [ ] ~If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?~
- [ ] ~If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?~
- [ ] ~If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?~

### For documentation related changes:
- [ ] ~Have you ensured that format looks appropriate for the output in 
which it is rendered?~

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/colindean/nifi patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/3172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3172


commit 09794d1506541808541e56285ddb5cfa3dbf5fec
Author: Colin Dean 
Date:   2018-11-15T18:46:41Z

NIFI-5823: Fixes typo in min idle connections property name

So many people missed it :-(




---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-09 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
Thank you for confirming. Looks like my team will have some work to do
next week!



---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-09 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
🎉 

@patricker @mattyb149 How often and for what reasons does NiFi issue patch 
releases? Looking through the release history, it seems pretty rare and saved 
for regressions only. More directly, I'd love to get this into an official 
release sooner than later, in order to avoid the burdens of building NiFi 
internally or pulling in patched NARs as a part of our build process (we ship 
NiFi as a part of a product in development, but we're like _days_ from shipping 
1.0…). I understand if there are rules/guidelines that would prevent this.


---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-09 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
Very strange… it's there in the PR's commit and my local copy and Travis 
built fine:


https://github.com/apache/nifi/blob/a3868928e278dc6797367f97d1d84eebcf1aad38/nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java#L27


---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-08 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
Squash incoming…


---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-08 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
I'll squash once travis says 🆗 


---

[GitHub] nifi pull request #3156: NIFI-5780 Add pre and post statements to ExecuteSQL...

2018-11-08 Thread colindean 
Github user colindean commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3156#discussion_r231993492
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
 ---
@@ -82,6 +84,16 @@
 .identifiesControllerService(DBCPService.class)
 .build();
 
+public static final PropertyDescriptor SQL_PRE_QUERY = new 
PropertyDescriptor.Builder()
+.name("sql-pre-query")
+.displayName("SQL Pre-Query")
+.description("SQL pre-query to execute. Semicolon-delimited 
list of queries. "
++ "Note, the results/outputs of these queries will be 
suppressed if successfully executed.")
--- End diff --

You can probably omit "Note," here.


---

[GitHub] nifi pull request #3156: NIFI-5780 Add pre and post statements to ExecuteSQL...

2018-11-08 Thread colindean 
Github user colindean commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3156#discussion_r231993409
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
 ---
@@ -82,6 +84,16 @@
 .identifiesControllerService(DBCPService.class)
 .build();
 
+public static final PropertyDescriptor SQL_PRE_QUERY = new 
PropertyDescriptor.Builder()
+.name("sql-pre-query")
+.displayName("SQL Pre-Query")
+.description("SQL pre-query to execute. Semicolon-delimited 
list of queries. "
--- End diff --

"SQL pre-query to execute" is duplicative with the name. Can you explain in 
another way its intent? Perhaps something like, "Queries that will be executed 
before each intended query is executed."


---

[GitHub] nifi pull request #3156: NIFI-5780 Add pre and post statements to ExecuteSQL...

2018-11-08 Thread colindean 
Github user colindean commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3156#discussion_r231993705
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
 ---
@@ -94,6 +106,16 @@
 
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
 .build();
 
+public static final PropertyDescriptor SQL_POST_QUERY = new 
PropertyDescriptor.Builder()
+.name("sql-post-query")
+.displayName("SQL Post-Query")
+.description("SQL post-query to execute. Semicolon-delimited 
list of queries. "
--- End diff --

Likewise, this description is duplicative with the name. "Queries that will 
be executed after the intended query."


---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-08 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
Test failure is on the Japanese build.


---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-07 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
> an Idle connection was one that had been returned to the pool?

That's what I would think, but I couldn't seem to actually trigger it. 

Reading through the API docs some more, I didn't think to try checking the 
idle connection count _after_ closing a connection. I'll try that tomorrow.


---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-07 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
Ah, I did that through checking the minIdle and maxIdle properties.



---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-07 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
> What if you exposed the number of active and idle connections in the 
connection pool as properties on the DBCPConnectionPool? These are available by 
calling getNumActive() and getNumIdle(). Or you could call listAllObjects() and 
get back the full pool on the dataSource object.

I started down this track but I couldn't actually seem to trigger idle 
within a reasonable test setup. I can't for the life of me tell what actually 
makes a connection go idle, only really what removes it _when_ it's idle. 
Thoughts on how to proceed?


---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-07 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
Test failure now seems to be a timeout in another module:

```
[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
30.287 s <<< FAILURE! - in 
org.apache.nifi.processors.standard.TestHandleHttpRequest
[ERROR] 
testMultipartFormDataRequest(org.apache.nifi.processors.standard.TestHandleHttpRequest)
  Time elapsed: 30.012 s  <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 3 
milliseconds
at 
org.apache.nifi.processors.standard.TestHandleHttpRequest.testMultipartFormDataRequest(TestHandleHttpRequest.java:271)
```


---

[GitHub] nifi pull request #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPCo...

2018-11-07 Thread colindean 
Github user colindean commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3133#discussion_r231660071
  
--- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
 ---
@@ -164,6 +164,71 @@ public ValidationResult validate(final String subject, 
final String input, final
 
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
 .build();
 
+public static final PropertyDescriptor MIN_IDLE = new 
PropertyDescriptor.Builder()
+.displayName("Minimum Idle Connections")
+.name("dbcp-mim-idle-conns")
+.description("The minimum number of connections that can 
remain idle in the pool, without extra ones being " +
+"created, or zero to create none.")
+.defaultValue("0")
+.required(true)
+.addValidator(StandardValidators.INTEGER_VALIDATOR)
+.build();
+
+public static final PropertyDescriptor MAX_IDLE = new 
PropertyDescriptor.Builder()
+.displayName("Max Idle Connections")
+.name("dbcp-max-idle-conns")
+.description("The maximum number of connections that can 
remain idle in the pool, without extra ones being " +
+"released, or negative for no limit.")
+.defaultValue("8")
+.required(true)
+.addValidator(StandardValidators.INTEGER_VALIDATOR)
+.build();
+
+public static final PropertyDescriptor MAX_CONN_LIFETIME = new 
PropertyDescriptor.Builder()
+.displayName("Max Connection Lifetime")
+.name("dbcp-max-conn-lifetime")
+.description("The maximum lifetime in milliseconds of a 
connection. After this time is exceeded the " +
+"connection will fail the next activation, passivation 
or validation test. A value of zero or less " +
+"means the connection has an infinite lifetime.")
+.defaultValue("-1")
--- End diff --

Looking into it, `NONNEGATIVE_INTEGER_VALIDATOR` lacks the custom time 
period validation. The new time period options should continue to use the 
`CUSTOM_TIME_PERIOD_VALIDATOR` defined in this class but I'll change `MIN_IDLE` 
to use `NONNEGATIVE_INTEGER_VALIDATOR`.  `MAX_IDLE` needs to stay 
`INTEGER_VALIDATOR` because 0 is a valid value for it.


---

[GitHub] nifi pull request #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPCo...

2018-11-07 Thread colindean 
Github user colindean commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3133#discussion_r231654261
  
--- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
 ---
@@ -164,6 +161,71 @@ public ValidationResult validate(final String subject, 
final String input, final
 
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
 .build();
 
+public static final PropertyDescriptor MIN_IDLE = new 
PropertyDescriptor.Builder()
+.name("Minimum Idle Connections")
+.description("The minimum number of connections that can 
remain idle in the pool, without extra ones being " +
+"created, or zero to create none.")
+.defaultValue("0")
+.required(true)
+.addValidator(StandardValidators.INTEGER_VALIDATOR)
+.sensitive(false)
+.build();
+
+public static final PropertyDescriptor MAX_IDLE = new 
PropertyDescriptor.Builder()
+.name("Max Idle Connections")
+.description("The maximum number of connections that can 
remain idle in the pool, without extra ones being " +
+"released, or negative for no limit.")
+.defaultValue("8")
--- End diff --

@mattyb149 Yes, it's 8. Should I reach into the impl to refer to the 
default constants?


---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-05 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
> What about making all of the new fields not required? `required(false)`. 
Then, if a value is provided, you override, otherwise you leave it be. You 
could call out the default values, or default functionality at least, in the 
property description?

I _could_ go this route, but I'm not where to strike the balance between 
"explicit settings from defaults at the time of creation" versus "use the 
latest default". I could reference the DBCP default constants in the property 
description, too, thus preventing the description from becoming out of date…


---

[GitHub] nifi pull request #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPCo...

2018-11-05 Thread colindean 
Github user colindean commented on a diff in the pull request:

https://github.com/apache/nifi/pull/3133#discussion_r230935621
  
--- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
 ---
@@ -164,6 +161,71 @@ public ValidationResult validate(final String subject, 
final String input, final
 
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
 .build();
 
+public static final PropertyDescriptor MIN_IDLE = new 
PropertyDescriptor.Builder()
+.name("Minimum Idle Connections")
+.description("The minimum number of connections that can 
remain idle in the pool, without extra ones being " +
+"created, or zero to create none.")
+.defaultValue("0")
+.required(true)
+.addValidator(StandardValidators.INTEGER_VALIDATOR)
+.sensitive(false)
+.build();
+
+public static final PropertyDescriptor MAX_IDLE = new 
PropertyDescriptor.Builder()
+.name("Max Idle Connections")
+.description("The maximum number of connections that can 
remain idle in the pool, without extra ones being " +
+"released, or negative for no limit.")
+.defaultValue("8")
--- End diff --

There are some defaults I could reference, e.g. 
`org.apache.commons.pool2.impl.BaseObjectPoolConfig#DEFAULT_MIN_EVICTABLE_IDLE_TIME_MILLIS`
 and `org.apache.commons.pool2.impl.GenericObjectPoolConfig#DEFAULT_MAX_IDLE`. 
Should I instead reach into DBCP to get those?


---

[GitHub] nifi issue #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectio...

2018-11-05 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3133
  
> If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

I added properties but I used a readable string for `.name`.

> Have you written or updated unit tests to verify your changes?

I'm not sure how best I can _operationally_ test these, or if that makes 
sense because we'd be testing the API functionality of commons-dbcp…


---

[GitHub] nifi pull request #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPCo...

2018-11-05 Thread colindean 
GitHub user colindean opened a pull request:

https://github.com/apache/nifi/pull/3133

NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectionPool

These six options support the eviction and passivation of idle
connections.

This adds the feature described in NIFI-5790 in pursuit of a
fix for NIFI-5789.



Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] ~~If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?~~
- [ ] ~~If applicable, have you updated the LICENSE file, including the 
main LICENSE file under nifi-assembly?~~
- [ ] ~~If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?~~
- [ ] ~~If adding new Properties, have you added .displayName in addition 
to .name (programmatic access) for each of the new properties?~~ 

### For documentation related changes:
- [ ] ~~Have you ensured that format looks appropriate for the output in 
which it is rendered?~~



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/colindean/nifi nifi-5790_expose-dbcp-options

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/3133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3133


commit 2bd51cbc7495529acc174655d187fdefb7451382
Author: Colin Dean 
Date:   2018-11-05T21:18:21Z

NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectionPool

These six options support the eviction and passivation of idle
connections.

This adds the feature described in NIFI-5790 in pursuit of a
fix for NIFI-5789.




---

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-28 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3032
  
That's fair. I feel like a release is coming up. Looking at the calendar, 
it seems like it happens in the first two weeks of each quarter. There's a been 
a lot of commits since 1.7.1! We're OK dropping in a 1.8.0-SNAPSHOT to this one 
environment but we'd love to include 1.8.0 in our builds as soon as possible. 
Do you have a feel for when 1.8.0 might be released?


---

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-28 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3032
  
Awesome! @mattyb149, where you able to reproduce the bug on other database 
software/driver combinations? 

Was this behavior unique to MySQL 5.0.x and driver 5.1.x? 

I wasn't able to reproduce it with MSSQL 2012 and JTDS 1.3.1.


---

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-28 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3032
  
I'll note that I built this NAR and used it for a job running against the 
production server in which I originally observed the problem. That job did not 
display the behavior and seems to have retrieved all of the expected data, so I 
can conclude that this fix does fully resolve the original problem for me.


---

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-27 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3032
  
@mattyb149 Thoughts?


---

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-25 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3032
  
The test failure seems to be a timeout from a test unrelated to what I 
changed but still within the nifi-standard-processors maven component:

```
[ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
10.089 s <<< FAILURE! - in 
org.apache.nifi.processors.standard.TestHandleHttpRequest
[ERROR] 
testRequestAddedToService(org.apache.nifi.processors.standard.TestHandleHttpRequest)
  Time elapsed: 10.01 s  <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 1 
milliseconds
at 
org.apache.nifi.processors.standard.TestHandleHttpRequest.testRequestAddedToService(TestHandleHttpRequest.java:138)
```

All other tests passed. Is this an intermittent failure?


---

[GitHub] nifi pull request #3032: NIFI-5612: Support JDBC drivers that return Long fo...

2018-09-25 Thread colindean 
GitHub user colindean opened a pull request:

https://github.com/apache/nifi/pull/3032

NIFI-5612: Support JDBC drivers that return Long for unsigned ints

Refactors tests in order to share code repeated in tests and to enable some 
parameterized testing.

MySQL Connector/J 5.1.x in conjunction with MySQL 5.0.x will return a Long 
for ResultSet#getObject when the SQL type is an unsigned integer. This change 
prevents that error from occurring while implementing a more informational 
exception describing what the failing object's POJO type is in addition to its 
string value.

---

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] ~~If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? ~~
- [ ] ~~If applicable, have you updated the LICENSE file, including the 
main LICENSE file under nifi-assembly?~~
- [ ] ~~If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?~~
- [ ] ~~If adding new Properties, have you added .displayName in addition 
to .name (programmatic access) for each of the new properties?~~

### For documentation related changes:
- [ ] ~~Have you ensured that format looks appropriate for the output in 
which it is rendered?~~

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/colindean/nifi 
colindean/nifi-5612-unresolvedunionint

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/3032.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3032


commit a017ff49aadde6dbddc0b89a0f1a47a9803a
Author: Colin Dean 
Date:   2018-09-20T00:27:47Z

NIFI-5612: Support JDBC drivers that return Long for unsigned ints

Refactors tests in order to share code repeated in tests and to enable
some parameterized testing.

MySQL Connector/J 5.1.x in conjunction with MySQL 5.0.x will return
a Long for ResultSet#getObject when the SQL type is an unsigned integer.
This change prevents that error from occurring while implementing a more
informational exception describing what the failing object's POJO type
is in addition to its string value.




---

[GitHub] nifi issue #3022: NIFI-5588 - Fix max wait time in DBCP Connection Pool

2018-09-25 Thread colindean 
Github user colindean commented on the issue:

https://github.com/apache/nifi/pull/3022
  
:tada:



---