[GitHub] nifi pull request #2220: NIFI-2979 PriorityAttributePrioritizer violates Com...
GitHub user jmark99 opened a pull request: https://github.com/apache/nifi/pull/2220 NIFI-2979 PriorityAttributePrioritizer violates Comparator contract NIFI-2979 PriorityAttributePrioritizer violates Comparator contract Modified the return value when both objects priority values are null to zero in order to match the expected return value based upon the Comparator contract. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X ] Is your initial contribution a single, squashed commit? ### For code changes: - [X ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [X ] Have you written or updated unit tests to verify your changes? - [X ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [X ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [X ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [X ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [X ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jmark99/nifi NIFI-2979 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2220.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2220 commit cd611a717a6a988985a30a4c0dc5a0dc283278fd Author: Mark Owens Date: 2017-10-20T15:54:54Z NIFI-2979 PriorityAttributePrioritizer violates Comparator contract Modified the return value when both objects priority values are null to zero to match the expected return value based upon the Comparator contract. ---
[GitHub] nifi pull request #2192: NIFI-1547: DistributedMapCacheServer: Ambiguous err...
GitHub user jmark99 opened a pull request: https://github.com/apache/nifi/pull/2192 NIFI-1547: DistributedMapCacheServer: Ambiguous error on misconfiguration misconfiguration Updated PersistentMapCache constructor in PersistentMapCache.java to catch an OverlappingFileLockException and present a more useful error message before propagating the exception forward. The log message alerts user to possible duplicated persistencePath in call to PersistentMapCache. Created a test method to verify the exception is thrown as expected. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jmark99/nifi NIFI-1547 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2192 commit cd7a8fc91827688032c57a1955b5443cb588b653 Author: Mark Owens Date: 2017-10-03T14:48:42Z NIFI-1547: DistributedMapCacheServer: Ambiguous error on misconfiguration Updated PersistentMapCache constructor in PersistentMapCache.java to catch an OverlappingFileLockException and present a more useful error message before propagating the exception forward. The log message alerts user to possible duplicated persistencePath in call to PersistentMapCache. Created a test method to verify the exception is thrown as expected. ---
[GitHub] nifi pull request #2164: NIFI-2184 JettyServer should confirm "docs" path ex...
GitHub user jmark99 opened a pull request: https://github.com/apache/nifi/pull/2164 NIFI-2184 JettyServer should confirm "docs" path exists before using it in .createDocsWebApp(). NIFI-2184 JettyServer should confirm "docs" path exists before using it in .createDocsWebApp(). Refactored the createDocsWebApp method of the JettyServer.java class. Previously NiFi would fail to start up and instead throw an IllegalStatException if the ''docs' directory did not exist in the installation directory. With the update, if the 'docs' directory is missing, an attempt to create the missing directory will be made and if successful will enable NIFI to startup successfully, barring any other startup errors of course. The side effect of this change is that the help documentation under the 'General' heading of the help page will be missing but the start up process will have succeeded. Three small helper methods were extracted from the original method. Each related to a section of the original code that could throw an exception. In each case if an exception is now thrown a more helpful log message will be output and the process will be closed via the startUpfailure method rather than throwing an exception The update was tested successfully on my local instance of NiFi with various scenarios (missing directories, introduced exceptions, etc). Due to the fact that the updated method is private and several layers into the call chain of the Jetty server constructor there did not appear to be a clean way to write a unit test. Conversation with one of the committers suggested submitting without a unit test given this situation. Additionally, Contrib-check build discovered a long line in ProcessGroupResource.java. Re-formatted line to pass checkstyle requirement. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x ] Is your initial contribution a single, squashed commit? ### For code changes: - [x ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [n/a] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [n/a] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [n/a] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [n/a] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jmark99/nifi nifi-2184 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2164.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2164 commit 14ad50141cb012afddb4ef63853c559cbf24ec02 Author: Mark Owens Date: 2017-09-20T14:14:08Z NIFI-2184 JettyServer should confirm "docs" path exists before using it in .createDocsWebApp(). Refactored the createDocsWebApp method of the JettyServer.java class. Previously NiFi would fail to start up and instead throw an IllegalStatException if the ''docs' directory did not exist in the installation directory. With the update, if the 'docs' directory is missing, an attempt to create the missing directory will be made and if successful will enable NIFI to startup successfully, barring any other startup errors of course. The side effect of this change is that the help documentation under the 'General' heading of the help page will be missing.
