[GitHub] nifi issue #1241: NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Ro...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1241 Overcome by events. ---
[GitHub] nifi issue #1241: NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Ro...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1241 @joewitt Since 0.x is end-of-life, this is OBE and should be closed. IIRC, the root problem was writing records first and then checking afterward to see if storage limits were exceeded and a rollover needed. If the storage limits don't leave a margin before reaching the physical capacity, writes can fill the disk and crash the NiFi and possible the system. I looked at the 1.x repositories in depth since they were re-written, but if the same write-then-check behavior exists this could still be a problem. ---
[GitHub] nifi issue #2198: NIFI-4468: If an entire batch of Provenance Events are rea...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/2198 @markap14 I tested on S2S with and without Provenance filter to see the bug before and after fix and all checked out as expected. ---
[GitHub] nifi issue #1975: NIFI-3332: ListXXX to not miss files with the latest proce...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1975 @ijokarumawak @bbende Sorry I haven't kept up with this recently. I'm happy to say that I was able to do some preliminary testing and this appears to solve the problem! **_Thanks!_** ð¥ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1986: NIFI-2528: added support for SSLContextService protocols i...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1986 I don't want to complicate this, but I feel like I must be missing something. As much as possible, the validation at configuration time should provide the user feedback, not failure upon execution. So, - SSLContextService should only allow selection of supported protocols, if SSLv3 will not work it should be removed from the list, and - if we need SSLv3 in some places we either need 2 variations of SSLContextService like @alopresto mentioned earlier or the ability to configure and query the security level so processors requiring only the higher security protocols can invalidate in the GUI (before execution) if provided a less secure service. Does that make sense? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2008: NIFI-4183 - Fix handshake error logic in SocketFlow...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/2008 NIFI-4183 - Fix handshake error logic in SocketFlowFileServerProtocol * Added new unit tests to show how the suppressed handshake exceptions leave the server in a connected status. * Fixed SocketFlowFileServerProtocol handshake logic to remove suppression of handshake exceptions. * Cleaned up log entry argument lists. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [X] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-4183 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2008.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2008 commit 6c3f0c8abadf9bf1e9811c14da6cb1eb5f96e32d Author: Joe Skora <jsk...@apache.org> Date: 2017-07-13T14:49:19Z NIFI-4183 - Fix handshake error logic in SocketFlowFileServerProtocol * Added new unit tests to show how the suppressed handshake exceptions leave the server in a connected status. * Fixed SocketFlowFileServerProtocol handshake logic to remove suppression of handshake exceptions. * Cleaned up log entry argument lists. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1986: NIFI-2528: added support for SSLContextService protocols i...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1986 @trkurc Have you [enabled SSLv3](https://stackoverflow.com/questions/28236091/how-to-enable-ssl-3-in-java) in the JVM? It is disabled by default starting with [Java 8 Update 31](http://www.oracle.com/technetwork/java/javase/8u31-relnotes-2389094.html) and [Java 7 Update 75](http://www.oracle.com/technetwork/java/javase/7u75-relnotes-2389086.html)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1994: NIFI-4166 - Create toolkit module to generate and b...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1994 NIFI-4166 - Create toolkit module to generate and build Swagger API library for NiFi REST API Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-4166 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1994.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1994 commit dd67c05e353db6fa8655121cfd86f65cd9475a63 Author: Joe Skora <jsk...@gmail.com> Date: 2017-05-31T04:08:19Z Create nifi-toolkit-api. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1993: NIFI-3677 - ExtractMediaMetadata should close TikaI...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1993 NIFI-3677 - ExtractMediaMetadata should close TikaInputStream * Added finally block to close TikaInputStream. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ X Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-3677 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1993.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1993 commit 37cf1252fb9c150b5c7bc7470a1fa1712dd7ab03 Author: Joe Skora <jsk...@apache.org> Date: 2017-07-07T17:38:28Z NIFI-3677 - ExtractMediaMetadata should close TikaInputStream * Added finally block to close TikaInputStream. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1988: NIFI-3218: throw exception in MockProcessSession wh...
Github user jskora commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1988#discussion_r125982805
--- Diff:
nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java ---
@@ -756,6 +756,13 @@ public void transfer(FlowFile flowFile) {
throw new IllegalArgumentException("I only accept
MockFlowFile");
}
+// if the flowfile provided was created in this session (i.e. it's
in currentVersions),
+// then throw an exception indicating that you can't transfer
flowfiles back to self.
+// this mimics the behavior of StandardProcessSession
+if(currentVersions.get(flowFile.getId()) != null) {
--- End diff --
This should only fire the exception if the `flowFile.getId()` is in
`currentVersions` but not in `originalVersions` since those are the newly
created FlowFiles. If it's in both it's a queued file being transferred back
to the queue. You can see the problem if you run the `TestUpdateAttribute`
tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1821: NIFI-3932 Symbols in API comments cause problems wi...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1821 NIFI-3932 Symbols in API comments cause problems with Swagger Codegen * Update ApiModelProperty descriptions to avoid problematic characters. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-3932 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1821.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1821 commit b6c8c69a7941fd4de8fe1e856752f8e0bbe2edb9 Author: Joe Skora <jsk...@apache.org> Date: 2017-05-18T13:45:36Z NIFI-3932 Symbols in API comments cause problems with Swagger Codegen * Update ApiModelProperty descriptions to avoid problematic characters. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1732: NIFI-2752 Correct ReplaceText default pattern and u...
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/1732 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1732: NIFI-2752 Correct ReplaceText default pattern and unit tes...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1732 @trkurc @pvillard Sorry, my bad for not closing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1732: NIFI-2752 Correct ReplaceText default pattern and u...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1732 NIFI-2752 Correct ReplaceText default pattern and unit tests (0.x) Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [X] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2752-0.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1732.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1732 commit 64e8e00152dc53114aac53ad67d3c241836b5784 Author: Joe Skora <jsk...@apache.org> Date: 2017-05-02T17:14:28Z NIFI-2752 Correct ReplaceText default pattern and unit tests (0.x) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1699: NIFI-3725 - validate processors only when they are in STOP...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1699 @mosermw Committed on https://github.com/apache/nifi/commit/8a18d26c28bcb0e2df6b30359976638637d9. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1688: NIFI-3553 FetchFileTransfer fix
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1688 Committed on https://github.com/apache/nifi/commit/b69b3b6c622d27544df70e157f8d8b1531a881c6 and https://github.com/apache/nifi/commit/c1e65f95bd9951390215c8ef7e2b25cf95f8b5f1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1667: NIFI-3019 cherry-picked from NIFI-3692 into 0.x branch
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1667 @mosermw Committed on https://github.com/apache/nifi/commit/cd1cf68c9841d0cc892187ce0e510492cd9ddd48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1699: NIFI-3725 - validate processors only when they are in STOP...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1699 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1688: NIFI-3553 FetchFileTransfer fix
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1688 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1667: NIFI-3019 cherry-picked from NIFI-3692 into 0.x branch
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1667 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1666: NIFI-3018 removed flume-twitter-source due to usage of org...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1666 @mwmoser Committed to 0.x on https://github.com/apache/nifi/commit/5072559156c613823ac554884dd9166acb0edd6b. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1666: NIFI-3018 removed flume-twitter-source due to usage of org...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1666 Reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1567: NIFI-3517 If HandleHttpResponse cannot write respon...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1567 NIFI-3517 If HandleHttpResponse cannot write response remove entry from HttpContextMap * Add test for failure not clear context map. * Add handler to remove context map entry if ProcessException occurs during while exporting response. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-3517-1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1567.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1567 commit 3aabd1eb23efb84d842489adcff55463633885f3 Author: Joe Skora <jsk...@gmail.com> Date: 2017-03-07T01:25:06Z NIFI-3517 If HandleHttpResponse cannot write response remove entry from HttpContextMap. * Add test for failure not clear context map. * Add handler to remove context map entry if ProcessException occurs during while exporting response. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1484: NIFI-2890 Provenance Repository Corruption (0.x)
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/1484 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1484: NIFI-2890 Provenance Repository Corruption (0.x)
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1484 Committed on [7d23bd7](https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=7d23bd7ac6af228a3e723d18253063231c919cf9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1203: NIFI-2890 Provenance Repository Corruption
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1203 Replaced by #1485 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1203: NIFI-2890 Provenance Repository Corruption
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/1203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1201 Replaced by #1484. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1201: NIFI-2890 Provenance Repository Corruption
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/1201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1481: NIFI-3055 StandardRecordWriter Can Throw UTFDataFor...
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/1481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1481: NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatExce...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1481 Closed by commit [4f72e34](https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=4f72e3491f2372c8c45afb96a765c1f5cdd2f07d). Thanks @mosermw! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1485: NIFI-2890 Provenance Repository Corruption (1.x)
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1485 NIFI-2890 Provenance Repository Corruption (1.x) * Corrected handling of corrupt journal file records that prevents instance startup and loss of records from corrupt files. Specifically, exception handling was expanded to cover failures on records after the first the same as failures on the first record. * Adjusted log messages to reflect that the remainder or all of the journal will be skipped, not just the current record. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2890-1.x-v2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1485.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1485 commit d844c21683cd177e7ae3122762bbe4c737a23934 Author: Joe Skora <jsk...@apache.org> Date: 2017-02-07T20:43:08Z NIFI-2890 Provenance Repository Corruption (1.x) * Corrected handling of corrupt journal file records that prevents instance startup and loss of records from corrupt files. Specifically, exception handling was expanded to cover failures on records after the first the same as failures on the first record. * Adjusted log messages to reflect that the remainder or all of the journal will be skipped, not just the current record. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1484: NIFI-2890 Provenance Repository Corruption (0.x)
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1484 NIFI-2890 Provenance Repository Corruption (0.x) * Corrected handling of corrupt journal file records that prevents instance startup and loss of records from corrupt files. Specifically, exception handling was expanded to cover failures on records after the first the same as failures on the first record. * Adjusted log messages to reflect that the remainder or all of the journal will be skipped, not just the current record. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2890-0.x-v2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1484.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1484 commit cedbbb5aef4c457f0a44435d4201ae70c600f2db Author: Joe Skora <jsk...@apache.org> Date: 2017-02-07T21:02:19Z NIFI-2890 Provenance Repository Corruption (0.x) * Corrected handling of corrupt journal file records that prevents instance startup and loss of records from corrupt files. Specifically, exception handling was expanded to cover failures on records after the first the same as failures on the first record. * Adjusted log messages to reflect that the remainder or all of the journal will be skipped, not just the current record. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1481: NIFI-3055 StandardRecordWriter Can Throw UTFDataFor...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1481 NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatException (0.x) * Remove function based on JDK source. * Add new function to find bytes based on RFC3629. * Add field name to log entry when field is truncated. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-3055-0.x-v4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1481.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1481 commit 660de4efde23fbbcb9b49307997c3b9619e9d90e Author: Joe Skora <jsk...@apache.org> Date: 2017-02-07T17:09:20Z NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatException (1.x) * Remove function based on JDK source. * Add new function to find bytes based on RFC3629. * Add field name to log entry when field is truncated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1475: NIFI-3055 StandardRecordWriter Can Throw UTFDataFor...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1475 NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatException (1.x) * Remove function based on JDK source. * Add new function to find bytes based on RFC3629. * Add field name to log entry when field is truncated. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x ] Is your initial contribution a single, squashed commit? ### For code changes: - [x ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-3055-1.x-v4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1475.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1475 commit 65310351bf07c410544c1d8e1acbba96de649c95 Author: Joe Skora <jsk...@apache.org> Date: 2017-02-06T18:55:01Z NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatException (1.x) * Remove function based on JDK source. * Add new function to find bytes based on RFC3629. * Add field name to log entry when field is truncated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1470: NIFI-3055 StandardRecordWriter Can Throw UTFDataFor...
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/1470 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1470: NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatExce...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1470 Closing this PR, committed on [4f72e34](https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=4f72e3491f2372c8c45afb96a765c1f5cdd2f07d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1469: NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatExce...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1469 @mosermw I have updated the log message in both PRs. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1470: NIFI-3055 StandardRecordWriter Can Throw UTFDataFor...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1470 NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatException (0.x) * Updated StandardRecordWriter to consider the encoding behavior of java.io.DataOutputStream.writeUTF() and truncate string values such that the UTF representation will not be longer than that DataOutputStream's 64K UTF format limit. * Add test to confirm handling of large UTF strings. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [X] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-3055-0.x-v3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1470.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1470 commit dab33e1e47214fa8797801126ca8e46b23693cd0 Author: Joe Skora <jsk...@apache.org> Date: 2017-02-02T19:11:05Z NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatException (0.x) * Updated StandardRecordWriter to consider the encoding behavior of java.io.DataOutputStream.writeUTF() and truncate string values such that the UTF representation will not be longer than that DataOutputStream's 64K UTF format limit. * Add test to confirm handling of large UTF strings. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1128: NIFI-2861 ControlRate should accept more than one flow fil...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1128 Closing per commit a3d95dc1582f2edfd7997c5d8a23105e88729d11 by @mosermw . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1128: NIFI-2861 ControlRate should accept more than one f...
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/1128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1412: NIFI-2861 ControlRate should accept more than one flow fil...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1412 @mosermw this is the replacement for https://github.com/apache/nifi/pull/1127, rebased and squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1127: NIFI-2861 ControlRate should accept more than one flow fil...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1127 @mwoser, I will close and resubmit a clean request with squashed commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1127: NIFI-2861 ControlRate should accept more than one f...
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/1127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1203: NIFI-2890 Provenance Repository Corruption
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1203 @JPercivall This has @been updated to align with the changes in Apache/0.x. I couldn't squash without creating a new branch, but a diff with Apache/0.x only shows the PersistentProvenanceRepository and TestPersistentProvenanceRepository classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1201 @JPercivall this has been updated to align with other changes in Master. I couldn't squash without creating a new branch, but a diff with Master only shows the PersistentProvenanceRepository and TestPersistentProvenanceRepository classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1241: NIFI-3039 Provenance Repository - Fix PurgeOldEvent...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1241 NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Rollover Size Limits (0.x) Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x ] Is your initial contribution a single, squashed commit? ### For code changes: - [x ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Rollover Size Limits Added low water mark for purgeOldEvents() to prevent thrashing on event cleanup. Adjusted rollover high water mark to match purgeOldEvents() to prevent overrunning "nifi.provenance.repository.max.storage.size". Moved high/low water marks to constants. Adjusted looping logic in mergeJournals() to use ".firstKey()" instead of ".entrySet().iterator().next()" to avoid unnecessary object creation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-3039-0.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1241.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1241 commit 1b4d2fd09fceba98d6c739296eb416ad508e6241 Author: Joe Skora <jsk...@apache.org> Date: 2016-11-17T15:30:52Z NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Rollover Size Limits * Added low water mark for purgeOldEvents() to prevent thrashing on event cleanup. * Adjusted rollover high water mark to match purgeOldEvents() to prevent overrunning "nifi.provenance.repository.max.storage.size". * Moved high/low water marks to constants. * Adjusted looping logic in mergeJournals() to use ".firstKey()" instead of ".entrySet().iterator().next()" to avoid unnecessary object creation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1240: NIFI-3039 Provenance Repository - Fix PurgeOldEvent...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1240 NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Rollover Size Limits (1.x) Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x ] Is your initial contribution a single, squashed commit? ### For code changes: - [x ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Rollover Size Limits * Added low water mark for purgeOldEvents() to prevent thrashing on event cleanup. * Adjusted rollover high water mark to match purgeOldEvents() to prevent overrunning "nifi.provenance.repository.max.storage.size". * Moved high/low water marks to constants. * Adjusted looping logic in mergeJournals() to use ".firstKey()" instead of ".entrySet().iterator().next()" to avoid unnecessary object creation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-3039-1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1240.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1240 commit 205f9805c39d4a0027699c9426853923d83f724d Author: Joe Skora <jsk...@apache.org> Date: 2016-11-17T15:30:52Z NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Rollover Size Limits * Added low water mark for purgeOldEvents() to prevent thrashing on event cleanup. * Adjusted rollover high water mark to match purgeOldEvents() to prevent overrunning "nifi.provenance.repository.max.storage.size". * Moved high/low water marks to constants. * Adjusted looping logic in mergeJournals() to use ".firstKey()" instead of ".entrySet().iterator().next()" to avoid unnecessary object creation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1203: NIFI-2890 Provenance Repository Corruption
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1203 NIFI-2890 Provenance Repository Corruption Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [X ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. Correct handling of corrupt journal file that was preventing instance startup and causing loss of records from uncorrupt files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2890-0.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1203.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1203 commit bdb00ecd78d16dd33903c3cfd69271444ccf0f37 Author: Joe Skora <jsk...@apache.org> Date: 2016-11-10T19:52:18Z NIFI-2890 Provenance Repository Corruption - Correct handling of corrupt journal file that was preventing instance startup and causing loss of records from uncorrupt files. (0.x) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1201: NIFI-2890 Provenance Repository Corruption
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1201 NIFI-2890 Provenance Repository Corruption Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X ] Is your initial contribution a single, squashed commit? ### For code changes: - [X ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [X ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. Correct handling of corrupt journal file that was preventing instance startup and causing loss of records from uncorrupt files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2890-1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1201.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1201 commit d89d5f684e1ea19b74167a03c6b987e161fceab1 Author: Joe Skora <jsk...@apache.org> Date: 2016-11-10T18:06:41Z NIFI-2890 Provenance Repository Corruption - Correct handling of corrupt journal file that was preventing instance startup and causing loss of records from uncorrupt files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-site pull request #7: NIFI-2911 Update Release Guide
GitHub user jskora opened a pull request: https://github.com/apache/nifi-site/pull/7 NIFI-2911 Update Release Guide * Added steps to configure GPG to default to strong digest algorithms (SHA512/SHA384/SHA256 over SHA1). * Added steps to produce SHA-256 checksum over artifacts. * Added link explaining Maven encrypted password setup. * Organized structure and tasks based on current process. * Standardized references to versions, tags, etc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi-site NIFI-2911 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-site/pull/7.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7 commit 2c118f22480724e1103ef631bd6d4574155de487 Author: Joe Skora <jsk...@gmail.com> Date: 2016-10-18T04:25:56Z Initial work on cleanup of Release Guide. commit 0d5b793fe36aaf6375da6708369d83f2c5922744 Author: Joe Skora <jsk...@gmail.com> Date: 2016-10-20T04:46:53Z Added todo items. commit 3b301f94eafd2d64fd77f433b537193498d92da0 Author: Joe Skora <jsk...@gmail.com> Date: 2016-10-21T04:04:05Z Finished first cut through guide. commit 7a0795b3ece1de10e3770d1bf1732478c854bca1 Author: Andy LoPresto <alopre...@apache.org> Date: 2016-10-21T15:58:27Z Added steps to configure GPG to default to strong digest algorithms (SHA512/SHA384/SHA256 over SHA1). Added steps to produce SHA-256 checksum over artifacts. Added link explaining Maven encrypted password setup. commit 165a8cca5a5210fc3988703b761fd7bcc84b5e9e Author: Joe Skora <jsk...@users.noreply.github.com> Date: 2016-10-21T17:17:39Z Merge pull request #1 from alopresto/NIFI-2911-temp1 Added steps to configure GPG to default to strong digest algorithms (⦠commit a657058764c66bacdd38a5dad81175945e8b9baa Author: Joe Skora <jsk...@gmail.com> Date: 2016-10-23T17:59:37Z Standardized references to versions, tags, etc. Finished cleanup of process tasks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1127: NIFI-2861 ControlRate should accept more than one flow fil...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1127 @markap14 except for removing the limit, review comments have been addressed. The FlowFile limit property has been renamed "Max FlowFiles per Batch" to reflect a batching metaphor instead of onTrigger references, that should be less confusing to users. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-site pull request #6: NIFI-2910 Added Pony Mail archive links to mailin...
GitHub user jskora opened a pull request: https://github.com/apache/nifi-site/pull/6 NIFI-2910 Added Pony Mail archive links to mailing lists page. Adds Pony Mail links to the website mailing lists page. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi-site NIFI-2910 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-site/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 commit fd173a8e30031852bc7eab0adb094666dd323053 Author: Joe Skora <jsk...@gmail.com> Date: 2016-10-18T01:14:45Z Added Pony Mail archive links to mailing lists page. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1128: NIFI-2861 ControlRate should accept more than one f...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1128 NIFI-2861 ControlRate should accept more than one flow file per execution (0.x) Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. * Support multiple files per onTrigger call. (0.x branch) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2861-0.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1128.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1128 commit 9d4a6e742bc67838176756bb7ef600e54d2904df Author: Joe Skora <jsk...@gmail.com> Date: 2016-10-13T06:18:23Z NIFI-2861 ControlRate should accept more than one flow file per execution * Support multiple files per onTrigger call. (0.x branch) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1127: NIFI-2861 ControlRate should accept more than one f...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1127 NIFI-2861 ControlRate should accept more than one flow file per execution (1.x) Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. * Support multiple files per onTrigger call. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2861-1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1127.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1127 commit d66dd6d0f59784da14a26fce50542224e1cf4b07 Author: Joe Skora <jsk...@gmail.com> Date: 2016-10-13T05:14:23Z NIFI-2861 ControlRate should accept more than one flow file per execution * Support multiple files per onTrigger call. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1072: NIFI-2429 PersistentProvenanceRepository bug fixes
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1072 Reviewed and committed. Thanks @mosermw --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1072: NIFI-2429 PersistentProvenanceRepository bug fixes
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/1072 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1007: NIFI-2752 Correct ReplaceText default pattern and u...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1007 NIFI-2752 Correct ReplaceText default pattern and unit tests * Corrected the DEFAULT_REGEX pattern. * Added tests to isolate regex capture group problem and verify corrected functionality. * Removed short circuit logic that masked configuration errors and created inconsistent processor behavior. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2752 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1007.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1007 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #913: NIFI-2440 - Add 'file.lastModifiedTime' attribute to ListSF...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/913 @kirkalicious Please close this, I committed it, but I transposed the PR number in the comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #913: NIFI-2440 - Add 'file.lastModifiedTime' attribute to ListSF...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/913 @joewitt Thanks, from what I can tell looking at JDK source the format spec drives the output more than the Locale, so I agree that the comments should cover it. @kirkalicious can you add the date format to the WritesAttribute description in ListSFTP like it is in [ListFile](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java#L95)? I will commit it once you are done. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #913: NIFI-2440 - Add 'file.lastModifiedTime' attribute to ListSF...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/913 @kirkalicious, thanks! The changes look good and tests check out fine. I'd prefer to move the constants to a parent common to ListFileTransfer and ListFile, but the only common parent is AbstractListProcessor which is not specifically "file" oriented and I prefer the reference as you have it to duplicating the constants. I will commit this tomorrow, unless you, @joewitt, or someone else suggests an alternative. Should this go into the 0.x branch as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #904: NIFI-2411 ModifyBytes should use long instead of int...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/904 NIFI-2411 ModifyBytes should use long instead of int for offsets (1.x) * Update to support offsets larger than 2 gigabyte. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2411-1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/904.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #904 commit f47d04e5cf3620de833d8c53161214564750dacf Author: Joe Skora <jsk...@apache.org> Date: 2016-08-19T19:49:11Z Update to support offsets larger than 2 gigabyte. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #903: NIFI-2411 ModifyBytes should use long instead of int...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/903 NIFI-2411 ModifyBytes should use long instead of int for offsets (0.x) * Update to support offsets larger than 2 gigabyte. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2411-0.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/903.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #903 commit a0e1efd7a3ac1b96dbe63e954dff977084d7c1f9 Author: Joe Skora <jsk...@apache.org> Date: 2016-08-19T19:06:23Z * Update to support offsets larger than 2 gigabyte. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #886: NIFI-1867 Improve ModifyBytes to make it easy to remove all...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/886 Closed by 0.x branch commit f89bc9efd8b8458b5bfd6a1b4045ce8230117ff4. Thanks @pvillard31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #886: NIFI-1867 Improve ModifyBytes to make it easy to rem...
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/886 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #886: NIFI-1867 Improve ModifyBytes to make it easy to remove all...
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/886 @pvillard31, I committed the .allowableValues change to this and the 1.x pull https://github.com/apache/nifi/pull/890. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #886: NIFI-1867 Improve ModifyBytes to make it easy to rem...
Github user jskora commented on a diff in the pull request:
https://github.com/apache/nifi/pull/886#discussion_r75469531
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ModifyBytes.java
---
@@ -74,6 +74,13 @@
.addValidator(StandardValidators.DATA_SIZE_VALIDATOR)
.defaultValue("0 B")
.build();
+public static final PropertyDescriptor REMOVE_ALL = new
PropertyDescriptor.Builder()
+.name("Remove All Content")
+.description("Remove all content from the FlowFile superseding
Start Offset and End Offset properties.")
+.required(true)
+.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+.defaultValue("false")
--- End diff --
Will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #890: NIFI-1867 Improve ModifyBytes to make it easy to rem...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/890 NIFI-1867 Improve ModifyBytes to make it easy to remove all FlowFile content (1.x) * Add "Remove All Content" property, related functionality, and tests to ModifyBytes processor to allow deletion of all flow file content. * Removed @Ignore annotation on class and unnecessary EOL translation of test data. Because ModifyBytes treat input as binary data, not text, line endings don't matter as long as they byte offsets are calculated correctly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-1867-1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/890.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #890 commit 5e8867d755a0ae9fefea97aaf731683cbccb8bcf Author: Joe Skora <jsk...@apache.org> Date: 2016-08-18T14:02:24Z * Add "Remove All Content" property, related functionality, and tests to ModifyBytes processor to allow deletion of all flow file content. * Removed @Ignore annotation on class and unnecessary EOL translation of test data. Because ModifyBytes treat input as binary data, not text, line endings don't matter as long as they byte offsets are calculated correctly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #886: NIFI-1867 Improve ModifyBytes to make it easy to rem...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/886 NIFI-1867 Improve ModifyBytes to make it easy to remove all FlowFile content (0.x) * Add "Remove All Content" property, related functionality, and tests to ModifyBytes processor to allow deletion of all flow file content. * Removed @Ignore annotation on class and unnecessary EOL translation of test data. Because ModifyBytes treat input as binary data, not text, line endings don't matter as long as they byte offsets are calculated correctly. (For 0.x branch, a separate PR for 1.x branch will follow.) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-1867-0.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/886.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #886 commit d8cba513daecb022e0620a8a0bd57bdca76ea99a Author: Joe Skora <jsk...@apache.org> Date: 2016-08-18T14:02:24Z * Add "Remove All Content" property, related functionality, and tests to ModifyBytes processor to allow deletion of all flow file content. * Removed @Ignore annotation on class and unnecessary EOL translation of test data. Because ModifyBytes treat input as binary data, not text, line endings don't matter as long as they byte offsets are calculated correctly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #811: NIFI-2503 Backport PostHTTP SSL Protocol fix to 0.x ...
Github user jskora closed the pull request at: https://github.com/apache/nifi/pull/811 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #811: NIFI-2503 Backport PostHTTP SSL Protocol fix to 0.x ...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/811 NIFI-2503 Backport PostHTTP SSL Protocol fix to 0.x branch Merge changes from [NIFI-1688](https://issues.apache.org/jira/browse/NIFI-1688) / [PR-624](https://github.com/apache/nifi/pull/624/files) into 0.x branch. Changes apply cleanly and test without problem. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2503 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/811.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #811 commit b3cb5d7ead12f8fc970a1c44dd54cb2176c08683 Author: Andy LoPresto <alopre...@apache.org> Date: 2016-06-21T22:31:56Z NIFI-1688 Added test skeleton. commit a20c4c46696eac123f09bfdf3a5053b7bbc9e0ce Author: Andy LoPresto <alopre...@apache.org> Date: 2016-06-21T22:32:54Z NIFI-1688 Cleaned up unnecessary imports. commit 0ac084142ca7946d8a7bc1d91b1820a4ad4e2789 Author: Andy LoPresto <alopre...@apache.org> Date: 2016-06-23T03:52:37Z NIFI-1688 Implemented integration test that generates key pair, inserts into and persists keystore, starts embedded HTTPS Jetty server, connects, and verifies response. Currently only TLSv1.2 connections are successful because of the overlap of cipher suites. Will manually insert cipher suites into server for TLSv1 and TLSv1.1 support. commit 60a06e40fa1d423d628eb77922294e676fd6e1fc Author: Andy LoPresto <alopre...@apache.org> Date: 2016-06-23T15:13:08Z NIFI-1688 Added debug information for supported cipher suites. commit 90fdce25579256223cfeda8cb13ff786d20e1714 Author: Andy LoPresto <alopre...@apache.org> Date: 2016-06-24T01:01:28Z NIFI-1688 Added test Groovlet for handling POST requests. Modified construction of SSLSocketFactory to avoid hardcoding supported protocol. Added integration tests (2 of 4 pass -- TLSv1.2 is supported on my machine but TLSv1 and TLSv1.1 are not). commit fc864b2459e89406c66df20ad0edce18ce161296 Author: Andy LoPresto <alopre...@apache.org> Date: 2016-06-24T03:43:04Z NIFI-1688 Resolved issue in PostHTTP -- now uses SSLContextService's protocol setting. Tests pass (require cleanup). Previously, dynamically-generated keystores with only RSA certificates were not acceptable for TLSv1 or TLSv1.1 connections which required DSA/DSS cipher suites for some reason. commit 26df6c8d9bf683a4b55665cdbcf6d4d196ed032d Author: Andy LoPresto <alopre...@apache.org> Date: 2016-06-24T03:48:16Z NIFI-1688 Tests pass (cleanup still required). commit 075a2731881ea1ddd8458b41b89ed427f224c194 Author: Andy LoPresto <alopre...@apache.org> Date: 2016-06-29T22:41:32Z NIFI-1688 Tests pass (cleanup still required). commit 68e6e13b61d09266bdbf9d15a174c5b266e794e1 Author: Andy LoPresto <alopre...@apache.org> Date: 2016-07-09T06:13:35Z NIFI-1688 Finished integration tests for PostHTTP processor. commit 8aef8f2313102a490f8707d70a6529e681bacad1 Author: Andy LoPresto <alopre...@apache.org> Date: 2016-07-09T06:29:32Z NIFI-1688 Removed legacy comments. Added ASF license to Groovlet handlers for test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #806: Extend REST API docs template to handle read only pr...
GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/806 Extend REST API docs template to handle read only properties. * Add read only property handling to type.hbs template. * Add flag to ProcessorDTO.getRelationships to reflect read only nature of the property. * Remove explicit "read only" message from ConnectionDTO.getAvailableRelationships to avoid duplicate text. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2237 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/806.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #806 commit a74080987f4da517a0d00bcb0e6997248ae94c24 Author: Joe Skora <jsk...@gmail.com> Date: 2016-08-08T02:13:13Z Extend template handling to read only properties. * Add read only property handling to type.hbs template. * Add flag to ProcessorDTO.getRelationships to reflect read only nature of the property. * Remove explicit "read only" message from ConnectionDTO.getAvailableRelationships to avoid duplicate text. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #793: NIFI-2494 Remove extraneous text that shows on banner line
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/793 @mcgilman, I restored the text and added the class to the div tag. My canvas is still fixed and the title is back on the Controller Settings page. Thanks for catching that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #793: NIFI-2494 Remove extraneous text that shows on banner line
Github user jskora commented on the issue: https://github.com/apache/nifi/pull/793 Working on it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
