[GitHub] nifi issue #2666: NIFI-5130 ExecuteInfluxDBQuery processor chunking support
Github user michalmisiewicz commented on the issue: https://github.com/apache/nifi/pull/2666 @MikeThomsen I've updated the code. Please let me know if I should change maximum chunk size. ---
[GitHub] nifi pull request #2666: NIFI-5130 ExecuteInfluxDBQuery processor chunking s...
Github user michalmisiewicz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2666#discussion_r186177020
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/ExecuteInfluxDBQuery.java
---
@@ -86,6 +93,18 @@
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.build();
+public static final PropertyDescriptor INFLUX_DB_QUERY_CHUNK_SIZE =
new PropertyDescriptor.Builder()
+.name("influxdb-query-chunk-size")
+.displayName("Results chunk size")
+.description("Chunking can be used to return results in a
stream of smaller batches "
++ "(each has a partial results up to a chunk size) rather
than as a single response. "
++ "Chunking queries can return an unlimited number of
rows. Note: Chunking is enable when result chunk size is greater than 0")
+
.defaultValue(String.valueOf(DEFAULT_INFLUX_RESPONSE_CHUNK_SIZE))
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+.addValidator(StandardValidators.createLongValidator(0,
Integer.MAX_VALUE, true))
--- End diff --
According to InfluxDB
[documentation](https://docs.influxdata.com/influxdb/v1.5/guides/querying_data/).
> The maximum row limit only applies to non-chunked queries. Chunked
queries can return an unlimited number of points.
How big limit do you suggest ?
---
[GitHub] nifi issue #2666: NIFI-5130 ExecuteInfluxDBQuery processor chunking support
Github user michalmisiewicz commented on the issue: https://github.com/apache/nifi/pull/2666 @MikeThomsen it supposed to fetch the entire result set of that select statement each run ---
[GitHub] nifi issue #2666: NIFI-5130 ExecuteInfluxDBQuery processor chunking support
Github user michalmisiewicz commented on the issue: https://github.com/apache/nifi/pull/2666 @MikeThomsen yes. Chunking is the only way to fetch unlimited number of rows in a single query from InfluxDB that has set `max-row-limit` property. > Many production InfluxDB installation has limited number of rows returned in a single query (by default 10k). Chunking query can return an unlimited number of rows. ---
[GitHub] nifi pull request #2666: NIFI-5130 ExecuteInfluxDBQuery processor chunking s...
GitHub user michalmisiewicz opened a pull request: https://github.com/apache/nifi/pull/2666 NIFI-5130 ExecuteInfluxDBQuery processor chunking support Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/michalmisiewicz/nifi NIFI-5130-ExecuteInfluxDBQuery-chunking-support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2666.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2666 ---
