[GitHub] nifi issue #2607: NIFI-1295: Adding UI controls for terminating threads

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/2607
  
Thanks @mcgilman, looks good. Could go either way on the Terminate v 
Terminate threads menu, so unless anyone has a strong opinion for adding 
"threads," I understand your logic for not making the change. Good catch on the 
cluster formatting; the formatting changes made here so far are a good step.


---

[GitHub] nifi issue #2607: NIFI-1295: Adding UI controls for terminating threads

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/2607
  
@mcgilman , I was thinking about some suggestions to the formatting and 
tooltip labeling used on these. I think we're using the '/' (forward slash) 
inconsistently which could be a bit confusing.

How about formatting the thread count in the global status bar like so:
**3 (1)**

And the tooltip could read something like:
**Threads: Active (Terminated)**

Then when the thread icon shows on a processor, the count would again show 
as '# (#)' and the tooltip could be something like:
**3 active threads (1 terminated)**

I'm also thinking change the current queue/data size global status format 
to:
**_Object Count (Data Size)_**
i.e., use parentheses instead of the forward slash

This is consistent with the In & Out stats on components.

And one last thing I thought is adding the term 'threads' to the Terminate 
context menu action. So, change _Terminate_ to _Terminate threads_


---

[GitHub] nifi-registry pull request #99: [NIFIREG-126] adding some polish and testing...

[moranr]

Github user moranr commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/99#discussion_r167249634
  
--- Diff: 
nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/AccessPolicyResource.java
 ---
@@ -174,7 +174,7 @@ public Response getAccessPolicy(
 
 final AccessPolicy accessPolicy = 
authorizationService.getAccessPolicy(identifier);
 if (accessPolicy == null) {
-throw new ResourceNotFoundException("No access policy found 
with ID + " + identifier);
+throw new ResourceNotFoundException("The specified access 
policy does not exist for this bucket.");
--- End diff --

I think that works, we could even add _"...in this registry."_ to end of 
that. It's consistent with the other messages.


---

[GitHub] nifi-registry issue #99: [NIFIREG-126] adding some polish and testing around...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi-registry/pull/99
  
@scottyaslan , @kevdoran – redirect behavior looks good. Below are 
recommendations for the dialog titles and messages.

UNSECURED
_-nifi-registry/explorer/grid-list/buckets/0_
_-nifi-registry/explorer/grid-list/buckets/0/flows/0_
- Title – Bucket Not Found
- Msg – The specified bucket ID does not exist in this registry.

_-nifi-registry/explorer/grid-list/buckets/**existing-bucket-id**/flows/0_
- Title – Flow Not Found
- Msg – The specified flow ID does not exist in this bucket.

_-nifi-registry/administration/users_
- Title – Not Applicable
- Msg – User administration is not configured for this registry.

SECURED
_-nifi-registry/administration/workflow(sidenav:manage/bucket/)_
- Title – Bucket Not Found
- Msg – The specified bucket ID does not exist in this registry.

_-nifi-registry/administration/users(sidenav:manage/user/)_
- Title – User Not Found
- Msg – The specified user ID does not exist in this registry.

_-nifi-registry/administration/users(sidenav:manage/group/)_
- Title – User Group Not Found
- Msg – The specified user group ID does not exist in this registry.

_-nifi-registry/administration/*_ (If user does not have applicable admin 
privileges)
- Title – Access Denied
- Msg – Please contact your System Administrator.


---

[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/2269
  
To add to my previous comments, I also notice some styling changes, not 
only in the advanced UI but other areas of the app as well. For example:

- Visible elements in the toolbar, status bar, and canvas palettes now have 
a border-radius being applied; previously they had square corners (i.e., no 
border-radius)

- Other areas such as shells and dialogs where the same canvas palette 
style buttons appear are being affected as well (e.g., 'Open in New Window', 
'Close', 'Refresh', etc.)

- Scott noted the fa-align icon sitting a pixel or two higher - I think 
this is occurring on many other 'fa-...' icons. I notice shifted positions in 
the canvas palette buttons, dialogs, and shells too

I would suggest that unless a new UI component is being introduced, we use 
established styles to maintain a consistent look. From what I've seen I don't 
believe there is a need to introduce anything new.

In the advanced UIs:

- the primary buttons (e.g., 'SAVE') have a border-radius now and also as 
Scott noted some position shifting occurs on hover

- select/combo box styling is completely different, including the menu that 
is shown when it is clicked on

- the 'Format' button should be square as are others that share the same 
look

I would also suggest capitalizing 'ruby', 'lua', and 'python' --> Ruby, 
Lua, Python


---

[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/2269
  
@yuri1969 the behavior of the code editor addition looks good! Changes made 
between the Script Engine/Body properties stay in place as changes are made and 
as you move between the standard/advanced editors. I did not experience 
anything odd there.

I agree with others about how closing it should return to point from which 
you came.

Regarding the save/close behavior - I would not expect 'SAVE' to close as 
well. It is, however, not very intuitive to save then have to go up the the 'X' 
button to close it out. Ideally I'd suggest an auto-save behavior that 
continuously notifies the user their work has been saved after a certain amount 
of time. Then place a close/done/ok button at the bottom right to close it out. 
Alternatively, and probably easier, group a separate 'Save' button with the 
code editor and add a close/done/ok button at the bottom right. There is more 
of a natural flow that way, working from the top left to the bottom right of 
the dialog.

Also, another idea, with the exception of Jolt these advanced UIs are 
pretty simple in that you're only choosing a type (engine) then entering code 
(body). It would be nice to simply have access the code editor directly from 
the property list when you click the cell to edit the value. This would 
eliminate the need for the advanced UI.


---

[GitHub] nifi issue #2102: NIFI-3781 - Controller Service Config Dialog...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/2102
  
I also commented in original JIRA looking for feedback from some others as 
well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2102: NIFI-3781 - Controller Service Config Dialog...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/2102
  
This looks pretty good @yuri1969 . Another thing that would probably makes 
sense is to change the icon's tooltip (title) to 'View configuration' since it 
does not use the view details icon anymore. That, of course, would only happen 
when the controller service is enabled.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/2081
  
@scottyaslan – agreed, likely a larger and separate effort to know all 
existing CSs. I'll create a new jira to capture the idea.

I think your suggestion as a first step is a good one. One thing I would 
recommend is that the CS Name field be placed _after_ the Compatible CS 
dropdown since the default name will be dependent of the user's Compatible CS 
selection.

And just to add more complexity ;) – if the user edits the default name 
and then goes back to choose a different Compatible CS, I'd recommend leaving 
the user-entered name as is. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/2081
  
This will be a nice addition from a usability perspective.

It could be helpful to go ahead and generate a default name for the service 
following some type of simple naming convention (e.g., 
StandardSSLContextService**-1**, StandardSSLContextService**-2**, and so on). 
This would actually be helpful to follow for _any_ controller service that is 
created, not just if it is created via a processor/service configuration 
dialog. 

I also notice in the dialog that the name field is at the bottom of the 
dialog and not seen unless scrolled to. It would be helpful see that field at 
or near the top so the user can immediately relate to the new service by its 
name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1305: [NIFI-3154] display ellipsis when text is sufficiently lon...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/1305
  
@scottyaslan this looks good. I put in a few long names in various cases 
and it is behaving as you describe.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1104: [NIFI-2844] Update CSS styles for Cluster Summary Dialog i...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/1104
  
@scottyaslan let's go ahead and get this in since the issue is fixed and 
the icons are now visible. I'll file a separate jira to completely update the 
styling.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1191: [NIFI-2898] restore ellipsis for processor type, controlle...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/1191
  
Thanks for the info @scottyaslan – I understand the issue regarding the 
spacing/height so addressing in a follow on Jira is best. 

I did just check out the latest and it looks good! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1191: [NIFI-2898] restore ellipsis for processor type, controlle...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/1191
  
@mcgilman  I think it makes sense to use the ellipsis for view state too.

@scottyaslan I'm still seeing the scrollable class applied on the Add 
Processor description as well, so I can both scroll _and_ hover to see the full 
description.

Also, can we apply the the styling that I outlined in my earlier jira 
comment to all these areas? This way both behavior and design will be 
consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1151: [NIFI-2888] Display processor fill color when zoomed in/ou...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/1151
  
Thanks @scottyaslan – agree on getting @mcgilman 's opinion too. Perhaps 
it's just that initial color choice I'm not fond of. It's fine applied to the 
processor icon, but at a larger scale it's really not that nice ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1151: [NIFI-2888] Display processor fill color when zoomed in/ou...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/1151
  
@scottyaslan, @mcgilman – I think the processor preview looks good, 
showing only what will change. For me, what is odd is the fact that the initial 
preview is not an accurate view of the current state of the processor. I feel 
like an initial color should not be selected and either the preview is empty or 
it shows the default processor. The preview would change once the user selects 
a color. Overall it's a trivial concern and could be addressed later; I don't 
think the current interaction will confuse anyone.

I like the color change of the label value text, but the label preview is 
using a gradient and the border color changes as well. To be accurate I would 
suggest using the solid color and keep the border gray (`rgba(0,0,0,0.25`). I'd 
also suggest updating the text in the label preview to say "Label Value" 
instead of only "Label." This aligns with the wording seen when you _configure_ 
the label to enter text.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-site pull request #4: NIFI-2706 new updates to MiNiFi section of site -...

[moranr]

Github user moranr closed the pull request at:

https://github.com/apache/nifi-site/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-site pull request #3: NIFI-2706 Updating NiFi logos, home page screensh...

[moranr]

GitHub user moranr opened a pull request:

https://github.com/apache/nifi-site/pull/3

NIFI-2706 Updating NiFi logos, home page screenshot, and some backgro…

…und colors of website to align with UI redesign

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/moranr/nifi-site NIFI-2706

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-site/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3


commit a15fcc543470201688b335501b76af96edd08a2b
Author: Rob Moran <rmo...@gmail.com>
Date:   2016-08-30T18:57:30Z

NIFI-2706 Updating NiFi logos, home page screenshot, and some background 
colors of website to align with UI redesign




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #775: [NIFI-2053] update open/close palettes

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/775
  
Looks good @scottyaslan thanks for getting this one in!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #763: NIFI-2450 Update Getting Started guide, Data Provena...

[moranr]

GitHub user moranr opened a pull request:

https://github.com/apache/nifi/pull/763

NIFI-2450 Update Getting Started guide, Data Provenance section graphics

- Updated data provenance section screen shots to reflect new styling
- Combined two Content tab screen shots into a single image
- Minor text edits 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/moranr/nifi NIFI-2450

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/763.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #763


commit e837217484cf7f3dbf14e145914141a7cb333a63
Author: Rob Moran <rmo...@gmail.com>
Date:   2016-08-01T19:05:25Z

NIFI-2450 Update Getting Started guide, Data Provenance section graphics




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #749: [NIFI-2303] Update lineage styles

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/749
  
Also for the context menus I recommend changing the Expand icon to 
_fa-plus-square_ (from _fa-plus-square-o_) and Collapse to _fa-minus-square_ 
(from _fa-minus-square-o_); this reversed style will better match the others


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #749: [NIFI-2303] Update lineage styles

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/749
  
I can confirm the issues @joewitt has mentioned. Additionally, the context 
menus still appear to be picking up some old styles. They should look just like 
the component context menus.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIF...

[moranr]

Github user moranr commented on a diff in the pull request:

https://github.com/apache/nifi/pull/703#discussion_r71937949
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/common-ui.css
 ---
@@ -150,9 +150,8 @@ ul.links span.header-link-over {
 }
 
 .blank, .unset, .sensitive {
--- End diff --

@scottyaslan Where `.unset` is being applied here, it needs `font-size: 
13px` and `padding-top: 2px`
Not sure all places the other classes are referenced...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIF...

[moranr]

Github user moranr commented on a diff in the pull request:

https://github.com/apache/nifi/pull/703#discussion_r71937491
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/provenance.css
 ---
@@ -178,31 +178,26 @@ div.flowfile-container {
 width: 282px;
 height: 120px;
--- End diff --

@scottyaslan Also please add `line-height:1.4`. When multiples are listed 
they sit a little close to each other.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIF...

[moranr]

Github user moranr commented on a diff in the pull request:

https://github.com/apache/nifi/pull/703#discussion_r71937315
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/provenance.css
 ---
@@ -178,31 +178,26 @@ div.flowfile-container {
 width: 282px;
 height: 120px;
--- End diff --

@scottyaslan I think we can remove the `height` property all together so 
the Children FlowFiles heading will not sit so far below Parent FlowFile heading


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #703: [NIFI-2050] [NIFI-2076] [NIFI-2136] [NIFI-2139] [NIF...

[moranr]

Github user moranr commented on a diff in the pull request:

https://github.com/apache/nifi/pull/703#discussion_r71936940
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/provenance.css
 ---
@@ -270,11 +272,13 @@ div.modified-attribute-label {
 
 div.modified-attribute-value {
--- End diff --

@scottyaslan please add `font-weight: 500;` and change `padding-top: 5px;` 
to `padding-top: 2px;` 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #700: NIFI-2211 Updating NiFi architecture graphics for ov...

[moranr]

GitHub user moranr opened a pull request:

https://github.com/apache/nifi/pull/700

NIFI-2211 Updating NiFi architecture graphics for overview doc

Created new versions of _zero-master-cluster.png_ and _zero-master-node.png_

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/moranr/nifi NIFI-2211

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/700.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #700


commit 8b79f46f36b891259fd32193e0c9321a3d210fa4
Author: Rob Moran <rmo...@gmail.com>
Date:   2016-07-21T11:36:14Z

NIFI-2211 Updating NiFi architecture graphics for overview doc




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #627: [NIFI-2205] [NIFI-2217] [NIFI-2219] [NIFI-2180] [NIFI-2140]...

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/627
  
@scottyaslan I don't see headerText for Processor Group Configuration – 
for example if you edit a process group name and click APPLY – dialog header 
is empty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #604: [NIFI-2038] [NIFI-2144] [NIFI-2031] [NIFI-2036] [NIFI-2037]

[moranr]

Github user moranr commented on the issue:

https://github.com/apache/nifi/pull/604
  
Everything is looking good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---