[GitHub] nifi pull request #1395: NIFI-3280 PostHTTP Option to write response to attr...
Github user nickcarenza commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1395#discussion_r113246581
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java
---
@@ -880,6 +936,29 @@ public long getContentLength() {
}
}
+private FlowFile appendResponseData(final ProcessContext context,
final ProcessSession session, final FlowFile original, String responseBody, int
statusCode, String mimeType) {
+FlowFile appended = original;
+switch (context.getProperty(RESPONSE_BODY_DESTINATION).getValue())
{
+case DESTINATION_ATTRIBUTE:
+if (context.getProperty(RESPONSE_BODY_ATTRIBUTE).isSet()) {
+appended = session.putAttribute(appended,
context.getProperty(RESPONSE_BODY_ATTRIBUTE).getValue(), responseBody);
+} else {
+getLogger().warn("{} is set to {} but {} is not set",
new
Object[]{RESPONSE_BODY_DESTINATION.getName(),DESTINATION_ATTRIBUTE,RESPONSE_BODY_ATTRIBUTE.getName()});
--- End diff --
I agree it should be detected in validation. I didn't realize properties
could be validated within the context of other properties.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1395: NIFI-3280 PostHTTP Option to write response to attribute o...
Github user nickcarenza commented on the issue: https://github.com/apache/nifi/pull/1395 thanks @trixpan. i dont remember this failing builds. i will try to look at cleaning that up but i don't know that ill get to it this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1522: NIFI-3508 Added support for PATCH identical to that of PUT...
Github user nickcarenza commented on the issue: https://github.com/apache/nifi/pull/1522 NIFI-3508 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1522: Added support for PATCH identical to that of PUT/PO...
GitHub user nickcarenza opened a pull request: https://github.com/apache/nifi/pull/1522 Added support for PATCH identical to that of PUT/POST Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickcarenza/nifi NIFI-3508 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1522.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1522 commit af09ff769ef6bb854491b728644b3b8c3e972209 Author: Nick Carenza Date: 2017-02-21T02:01:27Z Added support for PATCH identical to that of PUT/POST --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1395: NIFI-3280 PostHTTP Option to write response to attribute o...
Github user nickcarenza commented on the issue: https://github.com/apache/nifi/pull/1395 @trixpan thanks for making me finally learn to rebase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1464: NIFI-3429 optionally quoting all table identifiers
Github user nickcarenza commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1464#discussion_r99702931
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java
---
@@ -500,7 +521,11 @@ private String generateUpdate(final JsonNode rootNode,
final Map
final StringBuilder sqlBuilder = new StringBuilder();
int fieldCount = 0;
-sqlBuilder.append("UPDATE ").append(tableName).append(" SET ");
+sqlBuilder.append("UPDATE ");
--- End diff --
@pvillard31 i think i got everything this time
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1464: NIFI-3429 optionally quoting all table identifiers
Github user nickcarenza commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1464#discussion_r99683156
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java
---
@@ -500,7 +521,11 @@ private String generateUpdate(final JsonNode rootNode,
final Map
final StringBuilder sqlBuilder = new StringBuilder();
int fieldCount = 0;
-sqlBuilder.append("UPDATE ").append(tableName).append(" SET ");
+sqlBuilder.append("UPDATE ");
--- End diff --
ah yes, of course
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1464: NIFI-3429 optionally quoting all table identifiers
Github user nickcarenza commented on the issue: https://github.com/apache/nifi/pull/1464 @pvillard31 thanks for the review! Changes applied. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1464: NIFI-3429 automatically quoting all table identifiers
Github user nickcarenza commented on the issue: https://github.com/apache/nifi/pull/1464 @patricker All set. Mind giving this a review please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1464: NIFI-3429 automatically quoting all table identifiers
Github user nickcarenza commented on the issue: https://github.com/apache/nifi/pull/1464 @patricker I think I might have to implement this behind a new property and change to display name of the existing property to 'Quote Column Identifiers'. In my current flow, I've had to use a ReplaceText processor following ConvertJSONToSQL to wrap the table name in quotes. If I were to deploy the next minor I would expect that not to break but I would end up with 2 pairs of quotes around my table identifier. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1468: NIFI-3430 adds support for date format property to parse i...
Github user nickcarenza commented on the issue: https://github.com/apache/nifi/pull/1468 @trixpan squashed and added details about the change in the processor description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1468: NIFI-3430 adds support for date format property to ...
GitHub user nickcarenza opened a pull request: https://github.com/apache/nifi/pull/1468 NIFI-3430 adds support for date format property to parse incoming date strings Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickcarenza/nifi NIFI-3430 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1468.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1468 commit 16fdb3b5753f5393ebe0d902269de5b1cf82fd03 Author: Nick Carenza Date: 2017-02-02T01:41:45Z adds date_format property to parse incoming date strings commit 65178852a81413a926bc7bc3d1f664c33de9fcfb Author: Nick Carenza Date: 2017-02-02T18:49:50Z refactored to use the existing valueFormat and java.time.format.DateTimeFormatter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1463: NIFI-3430 adds date_format property to parse incomi...
Github user nickcarenza closed the pull request at: https://github.com/apache/nifi/pull/1463 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1464: NIFI-3429 automatically quoting all table identifie...
GitHub user nickcarenza opened a pull request: https://github.com/apache/nifi/pull/1464 NIFI-3429 automatically quoting all table identifiers Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickcarenza/nifi NIFI-3429 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1464.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1464 commit 27fb5d5e297b69b51e794fb57f42fba0cb02f361 Author: Nick Carenza Date: 2017-02-02T01:50:34Z automatically quoting all table identifiers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1463: adds date_format property to parse incoming date st...
GitHub user nickcarenza opened a pull request: https://github.com/apache/nifi/pull/1463 adds date_format property to parse incoming date strings Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickcarenza/nifi NIFI-3430 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1463.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1463 commit 16fdb3b5753f5393ebe0d902269de5b1cf82fd03 Author: Nick Carenza Date: 2017-02-02T01:41:45Z adds date_format property to parse incoming date strings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1418: NIFI-3238 - Introduce ListenBeats processor and deprecates...
Github user nickcarenza commented on the issue: https://github.com/apache/nifi/pull/1418 I've been playing with this branch locally for a few days and I haven't experienced any issues yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1395: NIFI-3280 PostHTTP Option to write response to attribute o...
Github user nickcarenza commented on the issue: https://github.com/apache/nifi/pull/1395 ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] ~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?~ - [ ] ~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~ - [ ] ~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~ - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] ~Have you ensured that format looks appropriate for the output in which it is rendered?~ ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1395: NIFI-3280 [WIP] PostHTTP Option to write response t...
Github user nickcarenza commented on a diff in the pull request: https://github.com/apache/nifi/pull/1395#discussion_r94995239 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java --- @@ -16,49 +16,45 @@ */ package org.apache.nifi.processors.standard; --- End diff -- - sorted imports - added org.apache.http.entity.ContentType - added org.apache.nifi.annotation.behavior.WritesAttribute - added org.apache.nifi.annotation.behavior.WritesAttributes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1395: NIFI-3280 [WIP] PostHTTP Option to write response t...
GitHub user nickcarenza opened a pull request: https://github.com/apache/nifi/pull/1395 NIFI-3280 [WIP] PostHTTP Option to write response to attribute or flowfile content - property to store response body in attribute or replace flowfile content - property to set which attribute to store response body in - property to store response code in attribute - property to set which attribute to store response code in You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickcarenza/nifi NIFI-3280 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1395.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1395 commit c5fac63cccf743aa1838e9325e5002d460745531 Author: Nick Carenza Date: 2017-01-05T02:39:13Z NIFI-3280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1392: NIFI-3279 - Jolt 0.1.0 [WIP]
Github user nickcarenza commented on the issue: https://github.com/apache/nifi/pull/1392 Duplicate of https://github.com/apache/nifi/pull/1348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1392: NIFI-3279 - Jolt 0.1.0 [WIP]
Github user nickcarenza closed the pull request at: https://github.com/apache/nifi/pull/1392 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1392: NIFI-3279 - Jolt 0.1.0 [WIP]
GitHub user nickcarenza opened a pull request: https://github.com/apache/nifi/pull/1392 NIFI-3279 - Jolt 0.1.0 [WIP] - Updated jolt-core and json-utils to 0.1.0 from 0.0.21 - Adds support for new class of transform operations You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickcarenza/nifi jolt-0.1.0 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1392.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1392 commit 9370120dea1e6810854cceac2d295c3d550da508 Author: Nick Carenza Date: 2017-01-03T23:59:17Z init commit 33f1fc93cec44c42f117d9935ac9cba99fa5e8e3 Author: Nick Carenza Date: 2017-01-04T17:59:21Z updated another pom --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
