[GitHub] nifi-registry issue #145: NIFIREG-210 Corrected incorrect document-links

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/145
  
Reviewing...


---

[GitHub] nifi issue #3115: NIFI-5766 Make formatting in User Guide consistent with Ad...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/3115
  
@andrewmlim thanks! This has been merged to master.


---

[GitHub] nifi issue #3115: NIFI-5766 Make formatting in User Guide consistent with Ad...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/3115
  
Reviewing...


---

[GitHub] nifi issue #2957: NIFI-5543: fix connection path is not visualizing as selec...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2957
  
Chrome Version 68.0.3440.106 (Official Build) (64-bit)


---

[GitHub] nifi issue #2957: NIFI-5543: fix connection path is not visualizing as selec...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2957
  
@markobean sorry, but I still cannot reproduce the issue. I have a 
GenerateFlowFile processor with 2 connections to an UpdateAttribute processor. 
Each of the connection has bend point. I click on the first connection and I 
see that connection is highlighted. I click on the second connection by one of 
its bend points and the second connection is now highlighted. Please advise...


---

[GitHub] nifi issue #2957: NIFI-5543: fix connection path is not visualizing as selec...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2957
  
Reviewing...

@markobean can you please provide steps to test this?

It sounds like you have 2 connections overlaid on top of each other and 
that the 'bottom' connection has a bend point. Is that correct? and that you 
are trying to select the bottom connection by its' bend point?

If that is what you are trying to do then there may already be a solution 
for this...if you right click on the connection you are trying to edit you 
should then be able to select 'Bring to front' from the context menu. Then when 
you click the bend point you will have the desired connection. 


---

[GitHub] nifi-registry issue #135: [NIFIREG-193] upgrade superagent

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/135
  
FYI this PR is still open even though it has been merged


---

[GitHub] nifi-registry pull request #138: [NIFIREG-196] update client deps

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/138

[NIFIREG-196] update client deps



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-196

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #138


commit 225f5482d865ab46c311aa5f7e785d0e46b95ce5
Author: Scott Aslan 
Date:   2018-08-17T17:52:37Z

[NIFIREG-196] update client deps




---

[GitHub] nifi-registry issue #137: NIFIREG-191 Make formatting consistent in Registry...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/137
  
Thanks @andrewmlim this has been merged to master.


---

[GitHub] nifi-registry issue #137: NIFIREG-191 Make formatting consistent in Registry...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/137
  
Reviewing


---

[GitHub] nifi-registry pull request #135: [NIFIREG-193] upgrade superagent

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/135

[NIFIREG-193] upgrade superagent



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-193

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #135


commit 1d9c8866d792039e8a4757a6b914543167904bb5
Author: Scott Aslan 
Date:   2018-08-13T18:02:59Z

[NIFIREG-193] upgrade superagent




---

[GitHub] nifi issue #2941: [NIFI-5499] upgrade AngularJS to v1.7.2

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2941
  
I have updated the package-lock.json file and added a commit to this PR. 
Nice catch @mcgilman!


---

[GitHub] nifi pull request #2941: [NIFI-5499] upgrade AngularJS to v1.7.2

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi/pull/2941

[NIFI-5499] upgrade AngularJS to v1.7.2

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi NIFI-5499

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2941


commit c452cc4c1ba80b070bad2147439178cbb17b0e32
Author: Scott Aslan 
Date:   2018-08-08T15:00:21Z

[NIFI-5499] upgrade AngularJS to v1.7.2




---

[GitHub] nifi-registry pull request #131: NIFIREG-186: Adding Ranger authorizer

[scottyaslan]

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/131#discussion_r204182456
  
--- Diff: 
nifi-registry-web-ui/src/main/webapp/services/nf-registry.service.js ---
@@ -37,8 +37,14 @@ var rxjs = require('rxjs/Observable');
 function NfRegistryService(nfRegistryApi, nfStorage, tdDataTableService, 
router, fdsDialogService, fdsSnackBarService) {
 var self = this;
 this.registry = {
-name: "NiFi Registry"
+name: "NiFi Registry",
+// Config is updated later by calling the /config API.
+config: {}
 };
+nfRegistryApi.getRegistryConfig().subscribe(function (registryConfig) {
--- End diff --

Please move this call to getRegistryConfig  to 
https://github.com/apache/nifi-registry/blob/master/nifi-registry-web-ui/src/main/webapp/nf-registry.js#L56


---

[GitHub] nifi-registry issue #131: NIFIREG-186: Adding Ranger authorizer

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/131
  
Reviewing...


---

[GitHub] nifi-registry issue #130: NIFIREG-185 Added element id's to facilitate User ...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/130
  
Thanks @andrewmlim this has been merged to master


---

[GitHub] nifi-registry issue #130: NIFIREG-185 Added element id's to facilitate User ...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/130
  
Reviewing...


---

[GitHub] nifi-fds issue #7: NIFI-5299 Adjusting license abbreviation for Registry.

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-fds/pull/7
  
Thanks @apiri this has been merged to master.


---

[GitHub] nifi-fds pull request #8: [NIFI-5315] unset td-chips input width, expansion ...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-fds/pull/8

[NIFI-5315] unset td-chips input width, expansion panel title and sub…

…head font update

Thank you for submitting a contribution to Apache NiFi Flow Design System.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with either NIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you ensured that a full build and that the full suite of unit 
tests is executed via npm run clean:install at the root nifi-fds folder?
- [ ] Have you written or updated the Apache NiFi Flow Design System demo 
application to demonstrate any new functionality, provide examples of usage, 
and to verify your changes via npm start at the nifi-fds/target folder?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-fds?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-fds?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-fds NIFI-5315

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-fds/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 72e3272d77d1ff458c36e9c5b920ef15549970d2
Author: Scott Aslan 
Date:   2018-06-15T19:19:13Z

[NIFI-5315] unset td-chips input width, expansion panel title and subhead 
font update




---

[GitHub] nifi-fds issue #7: NIFI-5299 Adjusting license abbreviation for Registry.

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-fds/pull/7
  
Reviewing...


---

[GitHub] nifi-registry pull request #126: [NIFIREG-175] remove unused files and uness...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/126

[NIFIREG-175] remove unused files and unessecary header from karma-te…

…st-shim.js

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-175

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #126


commit 0eda054b4f3bd2cbf22cd5ed2d19c14a11cfd8e2
Author: Scott Aslan 
Date:   2018-06-13T18:58:10Z

[NIFIREG-175] remove unused files and unessecary header from 
karma-test-shim.js




---

[GitHub] nifi-registry pull request #125: [NIFIREG-175] remove unneccessary license h...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/125

[NIFIREG-175] remove unneccessary license header



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-175

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #125


commit c423aa1b1794b6e61acaf07c3787a281f2d82f0c
Author: Scott Aslan 
Date:   2018-06-13T18:26:38Z

[NIFIREG-175] remove unneccessary license header




---

[GitHub] nifi-fds pull request #5: add flow_design_styles.css to demo-app index.html

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-fds/pull/5

add flow_design_styles.css to demo-app index.html

Thank you for submitting a contribution to Apache NiFi Flow Design System.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with either NIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you ensured that a full build and that the full suite of unit 
tests is executed via npm run clean:install at the root nifi-fds folder?
- [ ] Have you written or updated the Apache NiFi Flow Design System demo 
application to demonstrate any new functionality, provide examples of usage, 
and to verify your changes via npm start at the nifi-fds/target folder?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-fds?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-fds?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-fds NIFI-5283

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-fds/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5


commit 300d2d678d065ebad2b61699005759658d265f2d
Author: Scott Aslan 
Date:   2018-06-08T19:32:43Z

add flow_design_styles.css to demo-app index.html




---

[GitHub] nifi issue #2766: NIFI-3217: Preventing editor close on window resize

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2766
  
@mcgilman I merged this PR to master...thanks for the awesome contrib!


---

[GitHub] nifi-registry issue #123: [NIFIREG-39] leverage npm @nifi-fds/core

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/123
  
Please do not merge.


---

[GitHub] nifi-registry pull request #123: [NIFIREG-39] leverage npm @nifi-fds/core

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/123

[NIFIREG-39] leverage npm @nifi-fds/core



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-39

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #123


commit b23f403b7db41cfd445d9e8508c8b49d205a5ef7
Author: Scott Aslan 
Date:   2018-06-07T14:17:03Z

[NIFIREG-39] leverage npm @nifi-fds/core




---

[GitHub] nifi issue #2766: NIFI-3217: Preventing editor close on window resize

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2766
  
Reviewing...


---

[GitHub] nifi-fds pull request #4: [NIFI-5216] facilitate npm publish

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-fds/pull/4

[NIFI-5216] facilitate npm publish

Thank you for submitting a contribution to Apache NiFi Flow Design System.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with either NIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you ensured that a full build and that the full suite of unit 
tests is executed via npm run clean:install at the root nifi-fds folder?
- [ ] Have you written or updated the Apache NiFi Flow Design System demo 
application to demonstrate any new functionality, provide examples of usage, 
and to verify your changes via npm start at the nifi-fds/target folder?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-fds?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-fds?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-fds NIFI-5216

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-fds/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4


commit 3ba3bafb09ad63eea56f9ddcaeca002f29e80116
Author: Scott Aslan 
Date:   2018-06-06T15:24:57Z

[NIFI-5216] facilitate npm publish




---

[GitHub] nifi issue #2757: NIFI-5208: Fixing issue preventing connections from being ...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2757
  
Thanks @mcgilman this has been merged to master.


---

[GitHub] nifi issue #2757: NIFI-5208: Fixing issue preventing connections from being ...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2757
  
Reviewing...


---

[GitHub] nifi-registry issue #120: NIFIREG-56: Added element ids to facilitate bucket...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/120
  
Will review...


---

[GitHub] nifi issue #2740: NIFI-5208: Restore dialog when nodes disconnects

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2740
  
Thanks @mcgilman this is a nice addition to the cluster UX. This has been 
merged to master!


---

[GitHub] nifi-fds issue #2: [NIFI-5198] update tooling versions

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-fds/pull/2
  
@joewitt I believe you need to run `npm cache verify` to get rid of those 
'stale package data' warnings.


---

[GitHub] nifi-fds issue #2: [NIFI-5198] update tooling versions

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-fds/pull/2
  
^ that was taken from the package-lock.json documentation on npm at: 
https://docs.npmjs.com/files/package-lock.json


---

[GitHub] nifi-fds issue #2: [NIFI-5198] update tooling versions

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-fds/pull/2
  
@joewitt I have clarified which items from the Angular Quickstart and add 
headers to each of the files including the package-lock.json file which is 
intended to be committed into source repositories, and serves various purposes 
including:

Describe a single representation of a dependency tree such that teammates, 
deployments, and continuous integration are guaranteed to install exactly the 
same dependencies.

Provide a facility for users to "time-travel" to previous states of 
node_modules without having to commit the directory itself.

To facilitate greater visibility of tree changes through readable source 
control diffs.

And optimize the installation process by allowing npm to skip repeated 
metadata resolutions for previously-installed packages. 


---

[GitHub] nifi-fds issue #2: [NIFI-5198] update tooling versions

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-fds/pull/2
  
The karma files are from the Angular Quickstart MIT licensed project and is 
already listed in the LICENSE file.


---

[GitHub] nifi-fds pull request #3: [NIFI-5219] update project name to NiFi Flow Desig...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-fds/pull/3

[NIFI-5219] update project name to NiFi Flow Design System

Thank you for submitting a contribution to Apache NiFi Fluid Design System.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with either NIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you ensured that a full build and that the full suite of unit 
tests is executed via npm run clean:install at the root nifi-fds folder?
- [ ] Have you written or updated the Apache NiFi Fluid Design System demo 
application to demonstrate any new functionality, provide examples of usage, 
and to verify your changes via npm start at the nifi-fds/target folder?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-fds?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-fds?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-fds NIFI-5219

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-fds/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3


commit 4ebfce9888c0a5ea151f11062c072f5218844f13
Author: Scott Aslan <scottyaslan@...>
Date:   2018-05-22T22:29:04Z

[NIFI-5219] update project name to NiFi Flow Design System




---

[GitHub] nifi issue #2719: NIFI-4585 Add nifi.cluster.node.max.concurrent.requests to...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2719
  
Thanks @andrewmlim this has been merged to master.


---

[GitHub] nifi issue #2719: NIFI-4585 Add nifi.cluster.node.max.concurrent.requests to...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2719
  
Reviewing...


---

[GitHub] nifi issue #2722: NIFI-5186: Updating UI to support asynchronous validation

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2722
  
Thanks @mcgilman this has been merged to master.


---

[GitHub] nifi pull request #2722: NIFI-5186: Updating UI to support asynchronous vali...

[scottyaslan]

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2722#discussion_r189689454
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-settings.js
 ---
@@ -264,12 +264,20 @@
 var bType = 
nfCommon.isDefinedAndNotNull(b.component[sortDetails.columnId]) ? 
nfCommon.substringAfterLast(b.component[sortDetails.columnId], '.') : '';
 return aType === bType ? 0 : aType > bType ? 1 : -1;
 } else if (sortDetails.columnId === 'state') {
-var aState = 'Invalid';
-if (nfCommon.isEmpty(a.component.validationErrors)) {
+var aState;
+if (a.component.validationStatus === 'VALIDATING') {
+aState = 'Validating';
+} else if (a.component.validationStatus === 'INVALID') 
{
+aState = 'Invalid';
+} else {
 aState = 
nfCommon.isDefinedAndNotNull(a.component[sortDetails.columnId]) ? 
a.component[sortDetails.columnId] : '';
 }
-var bState = 'Invalid';
-if (nfCommon.isEmpty(b.component.validationErrors)) {
+var bState;
+if (a.component.validationStatus === 'VALIDATING') {
+bState = 'Validating';
--- End diff --

should this be checking b.component.validationStatus


---

[GitHub] nifi pull request #2722: NIFI-5186: Updating UI to support asynchronous vali...

[scottyaslan]

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2722#discussion_r189688839
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-services.js
 ---
@@ -814,12 +814,20 @@
 var bType = 
nfCommon.isDefinedAndNotNull(b.component[sortDetails.columnId]) ? 
nfCommon.substringAfterLast(b.component[sortDetails.columnId], '.') : '';
 return aType === bType ? 0 : aType > bType ? 1 : -1;
 } else if (sortDetails.columnId === 'state') {
-var aState = 'Invalid';
-if (nfCommon.isEmpty(a.component.validationErrors)) {
+var aState;
+if (a.component.validationStatus === 'VALIDATING') {
+aState = 'Validating';
+} else if (a.component.validationStatus === 'INVALID') 
{
+aState = 'Invalid';
+} else {
 aState = 
nfCommon.isDefinedAndNotNull(a.component[sortDetails.columnId]) ? 
a.component[sortDetails.columnId] : '';
 }
-var bState = 'Invalid';
-if (nfCommon.isEmpty(b.component.validationErrors)) {
+var bState;
+if (a.component.validationStatus === 'VALIDATING') {
--- End diff --

should this be checking b.component.validationStatus?


---

[GitHub] nifi pull request #2721: [NIFI-5215] Upgrade AngularJS to v1.7.0. Also, addi...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi/pull/2721

[NIFI-5215] Upgrade AngularJS to v1.7.0. Also, adding package-lock.js…

…on to source control

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi NIFI-5215

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2721.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2721


commit de2705386aa1fb7f4d98b3a4fd05606a117238c9
Author: Scott Aslan <scottyaslan@...>
Date:   2018-05-18T18:50:23Z

[NIFI-5215] Upgrade AngularJS to v1.7.0. Also, adding package-lock.json to 
source control




---

[GitHub] nifi issue #2716: NIFI-5205 Updated default value for nifi.content.claim.max...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2716
  
Thanks @andrewmlim this has been merged to master.


---

[GitHub] nifi issue #2716: NIFI-5205 Updated default value for nifi.content.claim.max...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2716
  
Reviewing...


---

[GitHub] nifi issue #2692: NIFI-5173: Fixing component selection issue in zoom handli...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2692
  
Thanks @mcgilman this has been merged to master.


---

[GitHub] nifi-fds pull request #2: [NIFI-5198] update tooling versions

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-fds/pull/2

[NIFI-5198] update tooling versions

Thank you for submitting a contribution to Apache NiFi Fluid Design System.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with either NIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you ensured that a full build and that the full suite of unit 
tests is executed via npm run clean:install at the root nifi-fds folder?
- [ ] Have you written or updated the Apache NiFi Fluid Design System demo 
application to demonstrate any new functionality, provide examples of usage, 
and to verify your changes via npm start at the nifi-fds/target folder?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-fds?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-fds?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-fds NIFI-5198

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-fds/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2


commit d8ef37397477f722b7a2adabc19cd6154eb9193c
Author: Scott Aslan <scottyaslan@...>
Date:   2018-05-15T21:20:38Z

[NIFI-5198] update tooling versions




---

[GitHub] nifi issue #2692: NIFI-5173: Fixing component selection issue in zoom handli...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2692
  
Reviewing...


---

[GitHub] nifi issue #2688: NIFI-5167: Updating how the nf-reporting-task module is in...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2688
  
Thanks @mcgilman this has been merged to master.


---

[GitHub] nifi issue #2688: NIFI-5167: Updating how the nf-reporting-task module is in...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2688
  
Will review...


---

[GitHub] nifi-registry pull request #116: [NIFIREG-171] update moment.js

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/116

[NIFIREG-171] update moment.js



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-171

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #116


commit 0b0a571757073620c9e78f6f3979748840ae1c43
Author: Scott Aslan <scottyaslan@...>
Date:   2018-05-07T20:29:36Z

[NIFIREG-171] update moment.js




---

[GitHub] nifi-registry pull request #115: [NIFIREG-170] upgrade hoek.js

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/115

[NIFIREG-170] upgrade hoek.js



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-170

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #115


commit 48aa7103a5688d0036f633f2ee4f5d7218bacdc2
Author: Scott Aslan <scottyaslan@...>
Date:   2018-05-03T17:43:47Z

[NIFIREG-170] upgrade hoek.js




---

[GitHub] nifi-registry issue #113: NIFIREG-163 Added JDK information to System Requir...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/113
  
Reviewing...


---

[GitHub] nifi issue #2633: NIFI-5066: Allow global enable/disable component requests

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2633
  
+1 for the UI code.


---

[GitHub] nifi issue #2624: NIFI-5063 Added screenshots and supporting text for Primar...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2624
  
Reviewing...


---

[GitHub] nifi issue #2607: NIFI-1295: Adding UI controls for terminating threads

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2607
  
Looks good!


---

[GitHub] nifi issue #2620: NIFI-4941 Updated nifi.sensitive.props.additional.keys des...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2620
  
Thanks @andrewmlim this has been merged to master.


---

[GitHub] nifi issue #2620: NIFI-4941 Updated nifi.sensitive.props.additional.keys des...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2620
  
Will Review...


---

[GitHub] nifi-registry pull request #111: [NIFIREG-161] add vendor prefix to user-sel...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/111

[NIFIREG-161] add vendor prefix to user-select style



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-161

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #111


commit 902295a50d38bc3b12539619932fe806bdd69bae
Author: Scott Aslan <scottyaslan@...>
Date:   2018-04-09T13:16:30Z

[NIFIREG-161] add vendor prefix to user-select style




---

[GitHub] nifi issue #2613: NIFI-5050 update frontend-maven-plugin

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2613
  
Thanks @vion1 this has been merged to master.


---

[GitHub] nifi issue #2613: NIFI-5050 update frontend-maven-plugin

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2613
  
Reviewing...


---

[GitHub] nifi-registry pull request #109: [NIFIREG-161] selectable bucket and flow UU...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/109

[NIFIREG-161] selectable bucket and flow UUIDs in flow details panel



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-161

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #109


commit c9781d311ec2cdf7121131091805e0bd029b5a04
Author: Scott Aslan <scottyaslan@...>
Date:   2018-04-06T19:56:01Z

[NIFIREG-161] selectable bucket and flow UUIDs in flow details panel




---

[GitHub] nifi issue #2612: NIFI-5048 Corrected typo in KeytabCredentialsService contr...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2612
  
Thanks @andrewmlim this has been merged to master.


---

[GitHub] nifi issue #2612: NIFI-5048 Corrected typo in KeytabCredentialsService contr...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2612
  
Reviewing...


---

[GitHub] nifi issue #2607: NIFI-1295: Adding UI controls for terminating threads

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2607
  
@mcgilman I have reviewed the client side code and I am a +1 to merge once 
you have made the updates to the messages as @moranr suggested. Thanks for this 
contribution!


---

[GitHub] nifi issue #2571: [NIFI-4998] update node and npm version

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2571
  
@patricker nice catch! @mcgilman I have update this PR. Please review...


---

[GitHub] nifi pull request #2571: [NIFI-4998] update node and npm version

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi/pull/2571

[NIFI-4998] update node and npm version

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi NIFI-4998

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2571.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2571






---

[GitHub] nifi-registry pull request #106: [NIFIREG-153] inject angular router module ...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/106

[NIFIREG-153] inject angular router module into required components



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-153

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #106


commit 243dd2cfbf797db8bab548cce3abda855f022ed5
Author: Scott Aslan <scottyaslan@...>
Date:   2018-03-15T15:00:37Z

[NIFIREG-153] inject angular router module into required components




---

[GitHub] nifi issue #2515: NIFI-4885: Granular component restrictions

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2515
  
Thanks @mcgilman! I am a +1 for the UI code.


---

[GitHub] nifi-registry issue #100: [NIFIREG-124] persist sidenav table sorting

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/100
  
Nice catch! I have updated this PR to address the issue with the "add to 
group" button. Please re-review. Thanks!


---

[GitHub] nifi-registry pull request #104: [NIFIREG-149] directs user to login page fo...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/104

[NIFIREG-149] directs user to login page for LDAP



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-149

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #104


commit 30b8e19b84acc34fbe20606cf3ec168f371f69b2
Author: Scott Aslan <scottyaslan@...>
Date:   2018-03-05T19:05:38Z

[NIFIREG-149] directs user to login page for LDAP




---

[GitHub] nifi issue #2495: NIFI-3502: Ensuring D3 is available on the summary and use...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2495
  
Thanks @mcgilman this has been merged to master.


---

[GitHub] nifi issue #2495: NIFI-3502: Ensuring D3 is available on the summary and use...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2495
  
Reviewing...


---

[GitHub] nifi issue #2482: NIFI-4894: Ensuring that any proxy paths are retained when...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2482
  
Thanks @jtstorck! Thanks @mcgilman this has been merged to master.


---

[GitHub] nifi issue #2482: NIFI-4894: Ensuring that any proxy paths are retained when...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2482
  
@mcgilman I have reviewed and built these changes and all looks good.


---

[GitHub] nifi issue #2471: NIFI-3502: Upgrading D3 version

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2471
  
Thanks @mcgilman this has been merged to master.


---

[GitHub] nifi pull request #2471: NIFI-3502: Upgrading D3 version

[scottyaslan]

Github user scottyaslan commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2471#discussion_r169393440
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-canvas.js
 ---
@@ -996,34 +1030,42 @@
 zoomed = true;
 }
 
-// see if the scale has changed during this 
zoom event,
-// we want to only transition when zooming 
in/out as running
-// the transitions during pan events is
-var transition = d3.event.sourceEvent.type === 
'wheel' || d3.event.sourceEvent.type === 'mousewheel';
-
 // refresh the canvas
 refreshed = nfCanvas.View.refresh({
 persist: false,
-transition: transition,
+transition: 
shouldTransition(d3.event.sourceEvent),
 refreshComponents: false,
 refreshBirdseye: false
 });
 })
-.on('zoomend', function () {
-// ensure the canvas was actually refreshed
-if (nfCommon.isDefinedAndNotNull(refreshed)) {
-nfGraph.updateVisibility();
-
-// refresh the birdseye
-refreshed.done(function () {
-nfBirdseye.refresh();
-});
+.on('end', function () {
+if (!isBirdseyeEvent(d3.event.sourceEvent)) {
+// ensure the canvas was actually refreshed
+if 
(nfCommon.isDefinedAndNotNull(refreshed)) {
+nfGraph.updateVisibility();
+
+// refresh the birdseye
+refreshed.done(function () {
+nfBirdseye.refresh();
+});
 
-// persist the users view
-nfCanvasUtils.persistUserView();
+// persist the users view
+nfCanvasUtils.persistUserView();
 
-// reset the refreshed deferred
-refreshed = null;
+// reset the refreshed deferred
+refreshed = null;
+}
+
+if (panning === false) {
+// deselect as necessary if we are not 
panning
+
nfCanvasUtils.getSelection().classed('selected', false);
+
+// update URL deep linking params
+nfCanvasUtils.setURLParameters();
+
+// inform Angular app values have 
changed
+nfNgBridge.digest();
--- End diff --

This is unnecessary...


---

[GitHub] nifi issue #2482: NIFI-4894: Ensuring that any proxy paths are retained when...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2482
  
Reviewing...


---

[GitHub] nifi issue #2471: NIFI-3502: Upgrading D3 version

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2471
  
Will review...


---

[GitHub] nifi-registry issue #99: [NIFIREG-126] adding some polish and testing around...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/99
  
@kevdoran I have updated this PR with the new message as well as logging 
info.


---

[GitHub] nifi-registry issue #99: [NIFIREG-126] adding some polish and testing around...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/99
  
@kevdoran I have updated this PR with @moranr suggested messaging.


---

[GitHub] nifi-registry pull request #99: [NIFIREG-126] adding some polish and testing...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/99

[NIFIREG-126] adding some polish and testing around deep links

To test this PR:

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-126

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #99


commit bbf9d96abc96023bcc2cf0deeb8c31a1c435e850
Author: Scott Aslan <scottyaslan@...>
Date:   2018-02-01T21:38:28Z

[NIFIREG-126] adding some polish and testing around deep links




---

[GitHub] nifi-registry issue #94: NIFIREG-125 Adding bucket id and item id to droplet...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/94
  
Thanks @bbende ! FYI, I updated a few styles and amended them to this 
commit. Nice job, this has been merged to master.


---

[GitHub] nifi-registry issue #94: NIFIREG-125 Adding bucket id and item id to droplet...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/94
  
Reviewing...


---

[GitHub] nifi-registry issue #85: [NIFIREG-117] update sorting function name and add ...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi-registry/pull/85
  
Nice catch @kevdoran this is a def a bug. This bug also exists in when 
editing a user as well as when editing a bucket. I have created 
https://issues.apache.org/jira/browse/NIFIREG-124 to address this issue but I 
think this PR can be merged.


---

[GitHub] nifi-registry pull request #85: [NIFIREG-117] update sorting function name a...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/85

[NIFIREG-117] update sorting function name and add ellipsis to long t…

…ext in sidenav tables

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-117

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #85


commit 6085007168632fcda855de0f1a6939f1b271f448
Author: Scott Aslan <scottyaslan@...>
Date:   2018-01-12T02:32:29Z

[NIFIREG-117] update sorting function name and add ellipsis to long text in 
sidenav tables




---

[GitHub] nifi-registry pull request #84: [NIFIREG-116] update New Policy dialog check...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/84

[NIFIREG-116] update New Policy dialog checkbox UI/UX



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-116

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #84


commit 2a78049d20eb4de06d56e4cf91317b60ec58b0b6
Author: Scott Aslan <scottyaslan@...>
Date:   2018-01-12T02:27:46Z

[NIFIREG-116] update New Policy dialog checkbox UI/UX




---

[GitHub] nifi-registry pull request #83: [NIFIREG-115] add focus to inputs in the new...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/83

[NIFIREG-115] add focus to inputs in the new user, new group, new buc…

…kets dialogs

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-115

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit a43c5e42248e8705e7452d1377bdb81665ed87c4
Author: Scott Aslan <scottyaslan@...>
Date:   2018-01-12T02:15:32Z

[NIFIREG-115] add focus to inputs in the new user, new group, new buckets 
dialogs




---

[GitHub] nifi-registry pull request #80: [NIFIREG-99] add refresh button to an items ...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/80

[NIFIREG-99] add refresh button to an items change log in the explore…

…r grid-list

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-99

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/80.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #80


commit 076f037cf1cb0632de9c2a23f1b952f29aa9b95e
Author: Scott Aslan <scottyaslan@...>
Date:   2018-01-08T20:52:57Z

[NIFIREG-99] add refresh button to an items change log in the explorer 
grid-list




---

[GitHub] nifi-registry pull request #79: [NIFIREG-95] remove help icon button from he...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/79

[NIFIREG-95] remove help icon button from header toolbar on the login…

… page

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-95

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit cf66abb386b7990b8d443b6dd2be993a88de7387
Author: Scott Aslan <scottyaslan@...>
Date:   2018-01-08T20:50:00Z

[NIFIREG-95] remove help icon button from header toolbar on the login page




---

[GitHub] nifi-registry pull request #78: [NIFIREG-78] disable new policy option when ...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/78

[NIFIREG-78] disable new policy option when registry is unsecured



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-78

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit f0be275f8d41399dfd8211dbc29aad524542033f
Author: Scott Aslan <scottyaslan@...>
Date:   2018-01-08T20:46:28Z

[NIFIREG-78] disable new policy option when registry is unsecured




---

[GitHub] nifi-registry pull request #77: [NIFIREG-96] capitalize delete menu option i...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/77

[NIFIREG-96] capitalize delete menu option in grid-list item view



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-96

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #77


commit d79506032a539be51a88c00cda5653fa321eb607
Author: Scott Aslan <scottyaslan@...>
Date:   2018-01-08T20:43:18Z

[NIFIREG-96] capitalize delete menu option in grid-list item view




---

[GitHub] nifi issue #2219: NiFi-4436: Add UI controls for starting/stopping/reverting...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2219
  
@mcgilman thanks! I am a +1 for the UI portion of this PR! Very nice work 
and thank you for this contribution.


---

[GitHub] nifi issue #2219: NiFi-4436: Add UI controls for starting/stopping/reverting...

[scottyaslan]

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/2219
  
@mcgilman I noticed an issue when trying to import a flow and there are a 
large number of buckets in the selected registry. See screenshot: 
![screen shot 2018-01-03 at 12 29 49 
pm](https://user-images.githubusercontent.com/6797571/34531977-4d87eb6a-f082-11e7-9a4a-2afa0f5f789f.png)
 


---

[GitHub] nifi-registry pull request #68: [NIFIREG-83] deselect all users or groups in...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/68

[NIFIREG-83] deselect all users or groups in the add users to group a…

…nd add user to groups dialogs

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-83

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #68


commit 5e1cf1c6c465917d5c8c9b17622f955cc66ec1ed
Author: Scott Aslan <scottyaslan@...>
Date:   2017-12-22T20:41:47Z

[NIFIREG-83] deselect all users or groups in the add users to group and add 
user to groups dialogs




---

[GitHub] nifi-registry pull request #66: [NIFIREG-14] remove fds demo

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/66

[NIFIREG-14] remove fds demo



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-14

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #66


commit d9b15ce9dc382bcf9906135025d040fe635b444c
Author: Scott Aslan <scottyaslan@...>
Date:   2017-12-21T22:07:57Z

[NIFIREG-14] remove fds demo




---

[GitHub] nifi-registry pull request #65: [NIFIREG-30] update delete icons

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/65

[NIFIREG-30] update delete icons



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-30

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #65


commit 0e3596e7c082221b88e1b3d3e3de9ecbb43618c6
Author: Scott Aslan <scottyaslan@...>
Date:   2017-12-21T15:53:09Z

[NIFIREG-30] update delete icons




---

[GitHub] nifi-registry pull request #61: Nifireg 30

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/61

Nifireg 30



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-30

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #61


commit 31b3e50b1d71a6353e025d16a9d96da220f63935
Author: Kevin Doran <kdoran.apa...@gmail.com>
Date:   2017-12-15T21:17:37Z

NIFIREG-72 Fix API status codes for errors

Fixes Tenants and Policies to return 404 for resource not found cases.

commit 762bdcbc5059d225136251cf7de74241753bceff
Author: Scott Aslan <scottyas...@gmail.com>
Date:   2017-12-17T19:09:19Z

[NIFIREG-30] add bucket side nav




---

[GitHub] nifi-registry pull request #58: [NIFIREG-30] add login component, auth guard...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/58

[NIFIREG-30] add login component, auth guard to login, tenants, bucke…

…ts, admin, and explorer routes. Also added route for login component. 
[NIFIREG-20] improve page load times. [NIFIREG-15] add loading screen.

In an unsecured registry an anonymous user should be able to access:
http://localhost:8080/nifi-registry/login
http://localhost:8080/nifi-registry/administration/workflow
http://localhost:8080/nifi-registry/explorer/grid-list

an attempt to access 
http://localhost:8080/nifi-registry/administration/users will reroute the user 
to the login screen (as will any other attempt to access a deep link to which a 
user does not have access to).

an attempt to access an unknown route 
(http://localhost:8080/nifi-registry/abcef) will prompt the user with a dialog 
to click to easily access http://localhost:8080/nifi-registry/explorer/grid-list

In a secured registry the user should only have access to the routes for 
which they have permissions.  If the user is logging in via certs or kerberos 
the client recognizes this and routes the user to the 
http://localhost:8080/nifi-registry/explorer/grid-list.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-30

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #58


commit 81ef11c2e3bb0247e1166650bea3296e27b9e025
Author: Scott Aslan <scottyas...@gmail.com>
Date:   2017-12-14T21:25:32Z

[NIFIREG-30] add login component, auth guard to login, tenants, buckets, 
admin, and explorer routes. Also added route for login component. [NIFIREG-20] 
improve page load times. [NIFIREG-15] add loading screen.




---

[GitHub] nifi-registry pull request #50: [NIFIREG-30] update unit tests and harden cl...

[scottyaslan]

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-registry/pull/50

[NIFIREG-30] update unit tests and harden client code



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-registry NIFIREG-30

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-registry/pull/50.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #50


commit 0ec1ffe38ebf0ee693383af4c23b310677dab9b5
Author: Scott Aslan <scottyas...@gmail.com>
Date:   2017-12-06T04:28:23Z

[NIFIREG-30] update unit tests and harden client code




---