[GitHub] nifi issue #2962: NIFI-5535: fix metric tagging in DataDogReportingTask
Github user snagafritz commented on the issue: https://github.com/apache/nifi/pull/2962 Closing pull request. After some testing, with tags working "properly", I think we blew through our custom metric limits with Datadog. I saw someone on the previous PR that implemented this reporting task had mentioned it would be a good idea to allow users to select with metrics they would want reported. That may be a very good idea. In the meantime, I may suggest that we just remove all of the tags _except_ the environment tag that is configured with the controller service. ---
[GitHub] nifi pull request #2962: NIFI-5535: fix metric tagging in DataDogReportingTa...
Github user snagafritz closed the pull request at: https://github.com/apache/nifi/pull/2962 ---
[GitHub] nifi pull request #2962: NIFI-5535: fix metric tagging in DataDogReportingTa...
GitHub user snagafritz opened a pull request: https://github.com/apache/nifi/pull/2962 NIFI-5535: fix metric tagging in DataDogReportingTask Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Snagajob/nifi NIFI-5535 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2962.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2962 commit 8b0a9d39fb3f6c75b47c1511329e617cd1467135 Author: Corey Fritz Date: 2018-08-24T11:34:56Z NIFI-5535: Fixed metric tagging in DataDogReportingTask ---
[GitHub] nifi pull request #2913: NIFI-5083: enabled EL support for processor configu...
Github user snagafritz closed the pull request at: https://github.com/apache/nifi/pull/2913 ---
[GitHub] nifi pull request #2915: NIFI-5388: enabled EL support for dynamic propertie...
GitHub user snagafritz opened a pull request: https://github.com/apache/nifi/pull/2915 NIFI-5388: enabled EL support for dynamic properties of Kafka 1.0 processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? ``` Started writing unit tests but it seemed trivial validating that the properties have EL support enabled. I will attach a video to the JIRA ticket of me verifying expected behavior for the Kafka consumer. ``` - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Snagajob/nifi NIFI-5388 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2915.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2915 commit 76707086dfef73e2ee8e2ea9dd9f6d9c725b96be Author: Corey Fritz Date: 2018-07-17T01:06:01Z NIFI-5388: enabled EL support for dynamic properties of Kafka 1.0 processors ---
[GitHub] nifi pull request #2913: NIFI-5083: enabled EL support for processor configu...
GitHub user snagafritz opened a pull request: https://github.com/apache/nifi/pull/2913 NIFI-5083: enabled EL support for processor configuration of Kafka consumer group id Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? ``` I started to write unit tests for these changes then realized that the tests were really verifying the evaluation of the EL expressions, and I assume far better unit tests for this already exist. I will attach a video of me verifying expected behavior of a build of this branch to the JIRA ticket. ``` - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Snagajob/nifi NIFI-5083 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2913.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2913 commit 9d0a1ecd1d83ee2c6e54e3018db41280876a9629 Author: Corey Fritz Date: 2018-07-07T05:28:50Z NIFI-5083: enabled EL support for processor configuration of Kafka consumer `group.id` property ---
