[GitHub] nifi issue #2745: NIFI-5245: SimpleCSVFileLookupService should take account ...
Github user ssogabe commented on the issue: https://github.com/apache/nifi/pull/2745 Thanks @MikeThomsen, I'll fix it as soon as possible! ---
[GitHub] nifi pull request #2745: NIFI-5245: SimpleCSVFileLookupService should take a...
GitHub user ssogabe opened a pull request: https://github.com/apache/nifi/pull/2745 NIFI-5245: SimpleCSVFileLookupService should take account of charset Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ssogabe/nifi NiFi-5245 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2745.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2745 commit 025eec69d6fa19767077b9bbef2271a66e7969ba Author: Seiji Sogabe Date: 2018-05-29T01:55:51Z NIFI-5245: SimpleCSVFileLookupService should take account of charset ---
[GitHub] nifi pull request #2744: NIFI-5245: SimpleCSVFileLookupService should take a...
Github user ssogabe closed the pull request at: https://github.com/apache/nifi/pull/2744 ---
[GitHub] nifi pull request #2744: NIFI-5245: SimpleCSVFileLookupService should take a...
GitHub user ssogabe opened a pull request: https://github.com/apache/nifi/pull/2744 NIFI-5245: SimpleCSVFileLookupService should take account of charset Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ssogabe/nifi NiFi-5245 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2744.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2744 commit 3d3d604b1822104e8e4c0ee0177a98cd8bfd73ab Author: Seiji Sogabe Date: 2018-04-09T09:18:02Z Merge tag 'rel/nifi-1.6.0' NIFI-4995 signed release tag for approved release of NiFi 1.6.0 commit a3cfa9c3f2d2e9f3f437e515ae9a045bff83b143 Author: Seiji Sogabe Date: 2018-04-26T03:33:43Z Merge remote-tracking branch 'github/master' commit fd6c855f166163416c355a0d581adb774bd8e106 Author: Seiji Sogabe Date: 2018-05-28T09:59:34Z Merge remote-tracking branch 'nifi/master' commit 8d9ce01a3531a0d8d43342676a1bdb359c80be50 Author: Seiji Sogabe Date: 2018-05-29T01:36:38Z NiFi-5245: SimpleCSVFileLookupService should take account of charset ---
