[GitHub] [nifi] Chrzi commented on pull request #6996: NIFI-11232 Fix buffer handling in ContentClaimInputStream

2023-03-01 Thread via GitHub


Chrzi commented on PR #6996:
URL: https://github.com/apache/nifi/pull/6996#issuecomment-1450533660

   I tested that the new unit test `testBigReadAfterSmallRereads` really tests 
for this bug, if ran against the current main branch it fails the large read in 
line 262 with an IOException.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] Chrzi commented on pull request #6996: NIFI-11232 Fix buffer handling in ContentClaimInputStream

2023-02-28 Thread via GitHub


Chrzi commented on PR #6996:
URL: https://github.com/apache/nifi/pull/6996#issuecomment-1448764306

   I have confirmed the behaviour using the unit test provided in the Issue, 
which I also used to reproduce the bug.
   
   At the moment I am having issues executing `mvn clean install -P 
contrib-check` (the contrib-check fails) and just asked on Slack for help.
   
   If that works I want to get the unit test into a state where it is mergeable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org