[GitHub] [nifi] MikeThomsen commented on a change in pull request #5900: NIFI-7234 Standardized on Avro 1.11.0
MikeThomsen commented on a change in pull request #5900:
URL: https://github.com/apache/nifi/pull/5900#discussion_r835955309
##
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/test/java/org/apache/nifi/util/orc/TestNiFiOrcUtils.java
##
@@ -377,10 +378,11 @@ public static Schema buildComplexAvroSchema() {
public static GenericData.Record buildComplexAvroRecord(Integer i,
Map m, String e, Object unionVal, List intArray,
ByteBuffer decimal) {
Schema schema = buildComplexAvroSchema();
+Schema enumSchema = schema.getField("myEnum").schema();
GenericData.Record row = new GenericData.Record(schema);
row.put("myInt", i);
row.put("myMap", m);
-row.put("myEnum", e);
+row.put("myEnum", new GenericData.EnumSymbol(enumSchema, e));
Review comment:
https://issues.apache.org/jira/browse/AVRO-1810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a change in pull request #5900: NIFI-7234 Standardized on Avro 1.11.0
MikeThomsen commented on a change in pull request #5900:
URL: https://github.com/apache/nifi/pull/5900#discussion_r835954170
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/resources/org/apache/nifi/avro/schema.json
##
@@ -1,20 +1,20 @@
[ {
- "namespace" : "net.a",
- "type" : "record",
- "name" : "O",
- "fields" : [ {
- "name" : "hash",
- "type" : [ "null", {
- "type" : "map",
- "values" : "string"
- } ]
- } ]
-}, {
"namespace" : "net.a",
"type" : "record",
"name" : "A",
"fields" : [ {
"name" : "o",
- "type" : [ "null", "O" ]
+ "type" : [ {
Review comment:
This appears to have changed with the parsing functionality in 1.9+.
Under 1.10 and 1.11, the Avro API was not able to the first type and reference
it in the second type until it was embedded in the second type as shown here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a change in pull request #5900: NIFI-7234 Standardized on Avro 1.11.0
MikeThomsen commented on a change in pull request #5900: URL: https://github.com/apache/nifi/pull/5900#discussion_r835954005 ## File path: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/resources/org/apache/nifi/avro/defaultArrayInRecords1.json ## @@ -16,7 +16,7 @@ "items":"int" }, "doc":"array of ints", - "default": 0 + "default": [ 0 ] Review comment: Not sure why the first one ever worked because the `0` literal is not an array. It broke with the update to 1.11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a change in pull request #5900: NIFI-7234 Standardized on Avro 1.11.0
MikeThomsen commented on a change in pull request #5900:
URL: https://github.com/apache/nifi/pull/5900#discussion_r835953933
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/avro/AvroTypeUtil.java
##
@@ -326,7 +326,7 @@ private static Schema nullable(final Schema schema) {
return Schema.createUnion(unionTypes);
}
-return Schema.createUnion(Schema.create(Type.NULL), schema);
+return Schema.createUnion(schema, Schema.create(Type.NULL));
Review comment:
Changed this and our test schemas per this line in the Avro
Specification:
> default: A default value for this field, only used when reading instances
that lack the field for schema evolution purposes. The presence of a default
value does not make the field optional at encoding time. Permitted values
depend on the field's schema type, according to the table below. **Default
values for union fields correspond to the first schema in the union**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
