[GitHub] [nifi] exceptionfactory commented on pull request #5711: NIFI-9625 Refactor Distributed Cache Server and Client Tests

2022-01-25 Thread GitBox


exceptionfactory commented on pull request #5711:
URL: https://github.com/apache/nifi/pull/5711#issuecomment-1020641887






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] exceptionfactory commented on pull request #5711: NIFI-9625 Refactor Distributed Cache Server and Client Tests

2022-01-24 Thread GitBox


exceptionfactory commented on pull request #5711:
URL: https://github.com/apache/nifi/pull/5711#issuecomment-1020684595


   Pushed another commit that improves the behavior of the other test classes 
in the `nifi-distributed-cache-server` module to use 
`NetworkUtils.getAvailableTcpPort()` to avoid unexpected conflicts.  Since 
multiple test classes were using the default port number, concurrent execution 
could result in the `BindException`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] exceptionfactory commented on pull request #5711: NIFI-9625 Refactor Distributed Cache Server and Client Tests

2022-01-24 Thread GitBox


exceptionfactory commented on pull request #5711:
URL: https://github.com/apache/nifi/pull/5711#issuecomment-1020682277


   Interesting that the `DistributedSetCacheTest` happened to fail, since it is 
not directly related to these changes. However, it looks like it uses the 
default port, which could be in use, so I will change that to use a random 
available port as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] exceptionfactory commented on pull request #5711: NIFI-9625 Refactor Distributed Cache Server and Client Tests

2022-01-24 Thread GitBox


exceptionfactory commented on pull request #5711:
URL: https://github.com/apache/nifi/pull/5711#issuecomment-1020641887


   Thanks for the feedback @joewitt, it looks like the local test run was 
relying on the previous existence of the cache data directory. I pushed an 
update to check for the existence of the directory before running the clean 
method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org